| dalees | Hello, do we have folk around for a meeting in 5min? | 06:55 |
|---|---|---|
| hemanth | dalees: not really, appreciate review for https://review.opendev.org/c/openstack/magnum-capi-helm/+/960941 when you get time.. we discussed about this in prior meetings | 06:56 |
| hemanth | * not really much to discuss, appreciate | 06:59 |
| * dalees checks daylight savings. I'm off by an hour ;) | 07:04 | |
| dalees | in that case, I'll return in 55 minutes | 07:04 |
| hemanth | :-) | 07:05 |
| dalees | hemanth: ack, thanks for noting | 07:05 |
| hemanth | dalees: thanks for the review | 07:42 |
| dalees | I'll start meeting shortly, as jakeyip is on his way. | 08:02 |
| dalees | please add to agenda if there are topics to discuss | 08:02 |
| jakeyip | hi I"m here | 08:08 |
| jakeyip | dalees: o/ | 08:09 |
| dalees | #startmeeting Magnum | 08:10 |
| opendevmeet | Meeting started Tue Oct 14 08:10:17 2025 UTC and is due to finish in 60 minutes. The chair is dalees. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:10 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:10 |
| opendevmeet | The meeting name has been set to 'magnum' | 08:10 |
| dalees | Hi, thanks for waiting, and joining. | 08:10 |
| dalees | who is around today? | 08:10 |
| dalees | o/ | 08:10 |
| hemanth | o/ | 08:10 |
| BigMax | o/ (although will need to drop out at half past) | 08:10 |
| sd109 | o/ | 08:11 |
| dalees | #topic Release Liason updates | 08:12 |
| dalees | #link https://review.opendev.org/c/openstack/releases/+/963815 | 08:13 |
| dalees | first up, just a quick note to say I've added a patchset to update the release liasons. | 08:13 |
| jakeyip | I've just +1 that :) | 08:13 |
| dalees | if anyone has comments, there or here are fine. | 08:13 |
| dalees | #topic vPTG | 08:14 |
| dalees | and the other topic is vPTG - this is in two weeks. | 08:14 |
| dalees | in April we had two timeslots, 6am UTC for 1hr. | 08:14 |
| dalees | shall i book similar again, or a 2 hour timeslot? | 08:15 |
| jakeyip | i think previously we booked 2 because michal was busy and we couldn't have a 2 hr stretch? | 08:16 |
| sd109 | The same time of day works for me again, happy to do a 2 hour slot | 08:16 |
| jakeyip | same | 08:17 |
| dalees | how about 6-8am UTC Tuesday, as the planner allows this (which leads into this meeting at 8 UTC) | 08:17 |
| dalees | yeah the longer meeting time in a previous PTG was good to continue longer discussions with the same folk | 08:18 |
| dalees | #link vPTG etherpad link is https://etherpad.opendev.org/p/oct2025-ptg-magnum | 08:19 |
| dalees | add your topics, I'll bring a few over from April to review | 08:20 |
| jakeyip | ok | 08:20 |
| dalees | #topic Open Discussion | 08:20 |
| dalees | anything to raise, from anyone? | 08:21 |
| sd109 | Nothing from me this week | 08:22 |
| jakeyip | nothing from me, do you need anything pushed dalees ? | 08:24 |
| dalees | I think we should revisit https://review.opendev.org/c/openstack/magnum/+/952069 and decide a path forwards | 08:25 |
| jakeyip | ok, I will take a look | 08:27 |
| mnasiadka | And we should also start thinking about https://review.opendev.org/c/openstack/magnum/+/958387 | 08:27 |
| dalees | there are several options, but having something to backport would be good to resolve the regressions. | 08:27 |
| dalees | ah yeah, I've not tested that yet mnasiadka but it would make sense to merge sooner in the cycle and find any problems with it | 08:28 |
| mnasiadka | yup | 08:28 |
| jakeyip | yeah agree | 08:29 |
| dalees | if it works, we should merge it sooner. reverting or adding fixes is always an option. I'll give it some time in the next couple of weeks to try out. | 08:32 |
| jakeyip | testing this is challenging ... I'm wondering how other projects handle this | 08:33 |
| dalees | yes, there are many things we could miss in dev with the change | 08:34 |
| jakeyip | I like https://review.opendev.org/c/openstack/magnum/+/961770 | 08:38 |
| dalees | it makes for an easy backport, too. | 08:40 |
| jakeyip | wondering about the way forward though | 08:42 |
| dalees | I think there's a bigger discussion as to whether the api or client *should* be responsible for converting the template name to id. | 08:43 |
| jakeyip | sorry, before that, do we need 2 tests in 961770 ? template id and template name? | 08:43 |
| dalees | hmm, maybe so. I thought I saw another test that covered that, but they're for non existent cluster templates. I need to check that | 08:46 |
| jakeyip | ideally there should be an additional test that should fail without your patch? not sure why that doesn't | 08:48 |
| dalees | some of that discussion is in https://review.opendev.org/c/openstack/magnum/+/952069 | 08:51 |
| jakeyip | oh man I went deep into the test code :P | 08:54 |
| jakeyip | anyway, we are almost at time | 08:54 |
| dalees | that test is just renamed to make it clearer, and fixed so it tests the thing it used to. Alex linked to the commit that broke them both in 952069. | 08:56 |
| jakeyip | oh | 08:56 |
| dalees | the test case in 961770 is the same as Alex's change in 952069 | 08:56 |
| jakeyip | ah I understand now | 08:56 |
| dalees | yeah sorry, it wasn't fresh for me either | 08:57 |
| jakeyip | prob will be good to have a NOTE(dalees): This is not ideal and support for this will be removed in future clients or something like that | 08:59 |
| jakeyip | also, need test_create_cluster_with_cluster_template_id? which is the right test going forward? | 08:59 |
| jakeyip | then we can start thinking about new api version going forward | 09:00 |
| dalees | yeah it's probably worth an explicit test for template_id if it isn't covered. | 09:01 |
| dalees | would you add those as comments and i'll address them | 09:01 |
| dalees | I need to depart for now, it's late | 09:02 |
| jakeyip | can I click 'start review'? else I cannot reply | 09:02 |
| jakeyip | yeah end meeting | 09:02 |
| dalees | #endmeeting | 09:02 |
| opendevmeet | Meeting ended Tue Oct 14 09:02:45 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:02 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/magnum/2025/magnum.2025-10-14-08.10.html | 09:02 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/magnum/2025/magnum.2025-10-14-08.10.txt | 09:02 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/magnum/2025/magnum.2025-10-14-08.10.log.html | 09:02 |
| dalees | I've marked 'ready for review' | 09:02 |
| jakeyip | can I add alex as co-author and we get this in soon? the other test can be a separate PS | 09:03 |
| dalees | yes sure | 09:05 |
| jakeyip | oh I forgot now there's DCO so I can't change it without re-signing | 09:05 |
| jakeyip | forget it, I +2, don't wanna hold you up with minor things | 09:06 |
| mnasiadka | dalees: so - recapping - 961770 is the one we want to merge and backport? | 10:08 |
| opendevreview | Merged openstack/magnum master: Cluster Create: template name now permitted again https://review.opendev.org/c/openstack/magnum/+/961770 | 10:55 |
| opendevreview | Michal Nasiadka proposed openstack/magnum stable/2025.2: Cluster Create: template name now permitted again https://review.opendev.org/c/openstack/magnum/+/963950 | 11:56 |
| *** gmaan_pto is now known as gmaan | 16:00 | |
| opendevreview | Dale Smith proposed openstack/magnum stable/2025.1: Cluster Create: template name now permitted again https://review.opendev.org/c/openstack/magnum/+/964081 | 20:55 |
| opendevreview | Dale Smith proposed openstack/magnum stable/2025.2: Cluster Create: template name now permitted again https://review.opendev.org/c/openstack/magnum/+/963950 | 20:59 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!