| xinranwang | hi all | 02:32 |
|---|---|---|
| brinzhang_ | hi | 02:33 |
| songwenping_ | hi all | 02:33 |
| brinzhang_ | at 11:00, I have a meeting | 02:33 |
| xinranwang | ok | 02:33 |
| brinzhang_ | in each Thursday in fruture it will be happened :( | 02:33 |
| xinranwang | let's start the meeting quickly | 02:33 |
| xinranwang | #startmeeting | 02:34 |
| opendevmeet | xinranwang: Error: A meeting name is required, e.g., '#startmeeting Marketing Committee' | 02:34 |
| xinranwang | #startmeeting openstack-cyborg | 02:34 |
| opendevmeet | Meeting started Thu Jul 29 02:34:11 2021 UTC and is due to finish in 60 minutes. The chair is xinranwang. Information about MeetBot at http://wiki.debian.org/MeetBot. | 02:34 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 02:34 |
| opendevmeet | The meeting name has been set to 'openstack_cyborg' | 02:34 |
| xinranwang | #topic roll call | 02:34 |
| brinzhang_ | #info brinzhang | 02:34 |
| xinranwang | #info xinranwang | 02:34 |
| xinranwang | #topic pending patches | 02:35 |
| songwenping_ | #info songwenping_ | 02:35 |
| xinranwang | let's go through the pending patches | 02:36 |
| xinranwang | 1st: https://review.opendev.org/c/openstack/cyborg/+/790937 | 02:36 |
| xinranwang | I think this one is good for me. each time we delete trart for on rp, we should check if we need to delete the trait as well. | 02:37 |
| xinranwang | brinzhang_ what do you think about this | 02:39 |
| xinranwang | 2nd: https://review.opendev.org/c/openstack/cyborg/+/797403 | 02:39 |
| brinzhang_ | for delete the trait I think it's ok, I will review it at afternoon | 02:41 |
| xinranwang | brinzhang_: ok, thanks | 02:41 |
| brinzhang_ | the sec I have talked with wenping, I suggest to combine the duplicate exception | 02:42 |
| xinranwang | what do you mean by combine | 02:43 |
| songwenping_ | combine name exist and uuid exist exception | 02:43 |
| brinzhang_ | yes | 02:44 |
| songwenping_ | to resource existed exception | 02:44 |
| songwenping_ | need we distingush them | 02:44 |
| xinranwang | it should be 2 different exceptions | 02:45 |
| brinzhang_ | if columns just only exist with name, using string will be better,but it'a an array now, just using arr[0] will be have a risk | 02:45 |
| brinzhang_ | we can using log + rase exception to warning the user/developer | 02:46 |
| xinranwang | i think the array is not for one colume, it records all duplicated columes' name | 02:46 |
| xinranwang | so it is a array | 02:46 |
| brinzhang_ | if so, why are you just call the first key arr[0]? | 02:47 |
| xinranwang | we didn't use arr[0] now, the if condition is: if 'name' in ['name'] | 02:48 |
| xinranwang | calling arr[0] is a workaround because the value of the list is not 'name', but "xxxxxxname" instead | 02:49 |
| songwenping_ | just for verify the tempest, we cannot use arr[0] in fact. | 02:49 |
| xinranwang | songwenping_: +1 | 02:49 |
| songwenping_ | we should find why the e.columns is different, some env is ok. | 02:50 |
| brinzhang_ | but now changed with if 'name' in e.columns[0] it will be always using the fist | 02:51 |
| brinzhang_ | is right? | 02:51 |
| songwenping_ | we donnot plan to merge arr[0] | 02:52 |
| xinranwang | it just a work around. I think we should find out how this array formed | 02:52 |
| songwenping_ | yes | 02:52 |
| songwenping_ | why the exception columns is ['name'] | 02:53 |
| songwenping_ | s/is/isnot | 02:53 |
| xinranwang | do you think we can try to use 10.0.0, | 02:54 |
| songwenping_ | perhaps has no relate with the oslo.db version | 02:55 |
| songwenping_ | need to look into it. | 02:56 |
| xinranwang | ok, let's discuss offline | 02:56 |
| songwenping_ | yes let's continue | 02:56 |
| xinranwang | #topic AoB | 02:56 |
| xinranwang | anything else you wanna bring up? | 02:56 |
| songwenping_ | eric xie commit one patch | 02:57 |
| xinranwang | you mean the url related one? | 02:58 |
| songwenping_ | i am finding | 02:58 |
| songwenping_ | https://review.opendev.org/c/openstack/python-cyborgclient/+/802140 | 02:59 |
| songwenping_ | we donnot support device profile show with name | 02:59 |
| songwenping_ | should we support to do this? | 03:00 |
| xinranwang | oh, yes | 03:00 |
| xinranwang | good point. | 03:00 |
| songwenping_ | the patch is not reasonable | 03:00 |
| xinranwang | I think we should support using name | 03:01 |
| songwenping_ | i talked with him to discuss in the ptg, maybe we need a spec to do this. | 03:01 |
| xinranwang | cool, thanks wenping | 03:02 |
| songwenping_ | no problem | 03:03 |
| xinranwang | anything else? | 03:03 |
| songwenping_ | nothing | 03:03 |
| xinranwang | ok, if nothing else, let's wrap up the meeting | 03:04 |
| songwenping_ | ok | 03:04 |
| songwenping_ | bye | 03:04 |
| xinranwang | #endmeeting | 03:04 |
| opendevmeet | Meeting ended Thu Jul 29 03:04:44 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 03:04 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-07-29-02.34.html | 03:04 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-07-29-02.34.txt | 03:04 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-07-29-02.34.log.html | 03:04 |
| xinranwang | bye, have a nice day | 03:04 |
| opendevreview | Wenping Song proposed openstack/cyborg master: update oslo.db version to 10.0.0 https://review.opendev.org/c/openstack/cyborg/+/802839 | 08:45 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!