| opendevreview | Takashi Kajinami proposed openstack/cyborg-tempest-plugin master: Add stable/2026.1 job https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/982768 | 10:57 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/cyborg master: Add NVMe DevStack development guide and local.conf template https://review.opendev.org/c/openstack/cyborg/+/982711 | 13:38 |
| chandankumar | Hello all, Cyborg team meeting starts in 22 mins, Please add your here: https://etherpad.opendev.org/p/openstack-cyborg-irc-meeting#L45 | 13:39 |
| chandankumar | Hello, who all are around for cyborg meeting? | 14:00 |
| sean-k-mooney | o/ | 14:00 |
| chandankumar | #startmeeting cyborg | 14:00 |
| opendevmeet | Meeting started Tue Mar 31 14:00:53 2026 UTC and is due to finish in 60 minutes. The chair is chandankumar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cyborg' | 14:00 |
| chandankumar | #courtesy ping rlandy bogdando[m] | 14:01 |
| chandankumar | Feel free to add your topics to the agenda | 14:01 |
| chandankumar | #link https://etherpad.opendev.org/p/openstack-cyborg-irc-meeting#L45 | 14:01 |
| chandankumar | we have few topics today and less attendence due to holidays | 14:03 |
| chandankumar | Let me start with first one | 14:03 |
| chandankumar | #topic Dropping devstack_setup.rst in favor of devstack_nvme rst: Needs suggestion | 14:03 |
| chandankumar | #link https://opendev.org/openstack/cyborg/src/branch/master/doc/source/contributor/devstack_setup.rst | 14:04 |
| chandankumar | I am working on adding a fresh guide for cyborg nvme devstack setup https://review.opendev.org/c/openstack/cyborg/+/982711/2/doc/source/contributor/devstack_nvme.rst | 14:04 |
| chandankumar | #link https://review.opendev.org/c/openstack/cyborg/+/982711/2/doc/source/contributor/devstack_nvme.rst | 14:04 |
| chandankumar | Since devstack_setup.rst is quite old and we have similar content kind of in devstack_nvme.rst | 14:04 |
| chandankumar | Do we want to drop the devstack_setup.rst in favor of devstack_nvme.rst? | 14:05 |
| sean-k-mooney | in my opion no | 14:05 |
| sean-k-mooney | i just started reviewing https://review.opendev.org/c/openstack/cyborg/+/982711/2/doc/source/contributor/devstack_nvme.rst | 14:05 |
| sean-k-mooney | before the meeting | 14:05 |
| chandankumar | https://review.opendev.org/c/openstack/cyborg/+/982711 provides https://review.opendev.org/c/openstack/cyborg/+/982711/2/devstack/local-conf | 14:05 |
| sean-k-mooney | and there are a number of things i woudl perfer to change before proceedign with it | 14:05 |
| sean-k-mooney | yep im ok with providing sample local.confs | 14:06 |
| chandankumar | In that case, I will wait for the review comments. | 14:06 |
| sean-k-mooney | the main devstack document shoud ljust descibe the basics fo deploying cyborg | 14:06 |
| sean-k-mooney | then we shoudl have driver specific docs that explain how to use emulated or real hardware with devstack for each dirver | 14:07 |
| sean-k-mooney | so to me they fufill diffent usecase | 14:07 |
| sean-k-mooney | what i dont want to have to do is try and figureou out what parts to remove if im just working on the nvidia driver or pci driver | 14:08 |
| sean-k-mooney | form the devstack_nvme doc | 14:08 |
| sean-k-mooney | does that make sense | 14:08 |
| chandankumar | yes, sounds good. | 14:08 |
| sean-k-mooney | the other thing i woudl personally change is remove the use of virt-install and instead provide an example domain exml and use virsh define | 14:09 |
| sean-k-mooney | the current mix of virsh install + virsh edit is a littel confusing and messy | 14:09 |
| sean-k-mooney | as in something are done on the cli then we have to add the iommu eleemtns | 14:09 |
| sean-k-mooney | idealy i woudl have a seperate doc for creating a development vm tahat we can cross refence and have the nvme guide focus on the compliation and cybrog configureation | 14:10 |
| sean-k-mooney | so baiscly 3 docs 1 for optional vm creation, 1 for the geneeric devstack usage to deploy cyborg and a final one that docuemtn how to configure the nvme driver with real or fake nvme devices | 14:11 |
| chandankumar | ok, these are good suggestions, it will make the docs experience cleaner. | 14:12 |
| sean-k-mooney | https://review.opendev.org/c/openstack/cyborg/+/982711/2/doc/source/contributor/devstack_nvme.rst is currently covering 4 related but difernet topics | 14:12 |
| sean-k-mooney | host config/vm creation, emulated deivce creation, devstack install. and finally using the nvme driver | 14:12 |
| chandankumar | I will break the patch into 2 patches one for devstack with fresh instructions and another for nvme or fake driver with vs creation | 14:12 |
| sean-k-mooney | well or pci driver currently | 14:12 |
| sean-k-mooney | the lattter part probaly shoudl be in the user docs for the driver | 14:13 |
| chandankumar | ok | 14:13 |
| sean-k-mooney | ack hte tempest plugin and verifcaion part including the creation fo the device profile ectra proably shoudl be its own doc too | 14:14 |
| sean-k-mooney | since that will be pretty commen for all drivers | 14:14 |
| sean-k-mooney | and we shoudl avoid duplciating it | 14:14 |
| sean-k-mooney | i can leave some of these comemnts in the review later but that the majority fo my feed back | 14:14 |
| chandankumar | Ok, I will work on breaking it into different docs | 14:15 |
| sean-k-mooney | content looks reasonable over all but the doc is covering to many topic today | 14:15 |
| sean-k-mooney | cool ill re reivew when you revise it | 14:15 |
| chandankumar | sure, thank you! | 14:15 |
| chandankumar | Now moving to reviews since there is no other topic | 14:16 |
| chandankumar | #topic reviews | 14:16 |
| chandankumar | I was working on cleaning up python-cyborgclient | 14:16 |
| chandankumar | proposed these two simple reviews | 14:16 |
| chandankumar | #link 982246: Drop dead code common/http.py | https://review.opendev.org/c/openstack/python-cyborgclient/+/982246 | 14:16 |
| chandankumar | common/http.py is dead code, not used anywhere in cyborgclient. | 14:17 |
| chandankumar | and second on cleaning up unused deps | 14:17 |
| chandankumar | # 982244: Cleanup requirements.txt unused packages | https://review.opendev.org/c/openstack/python-cyborgclient/+/982244 | 14:17 |
| sean-k-mooney | i was going to ask have you cofnirmed its not used in horizon but we dont have a plugin | 14:17 |
| chandankumar | https://github.com/openstack/python-cyborgclient/blob/master/cyborgclient/common/httpclient.py is used in the cyborgclient not http.py | 14:18 |
| sean-k-mooney | https://minio-api.teim.app/zuul-logs/8bf/main/8bf05a369b744132ab643a1fdf5d17c3/code-review/review-report.html yep the ai review agrees | 14:19 |
| sean-k-mooney | i think the removal shoudl be safe but ill verify that later | 14:19 |
| sean-k-mooney | i think directionaly this is good | 14:19 |
| sean-k-mooney | we will need a release note | 14:20 |
| sean-k-mooney | otherwise i think the patch is fine. the cyborg client may be used by thirdparty external tools | 14:20 |
| chandankumar | ah ok, will add a release note, good point about external tools | 14:20 |
| sean-k-mooney | so we will need to do a major version bump when we release it | 14:20 |
| sean-k-mooney | but i think that is fine | 14:21 |
| sean-k-mooney | as for the requireme clean up i agree that also looks reasonabe. | 14:21 |
| chandankumar | https://review.opendev.org/c/openstack/python-cyborgclient/+/982244/2/requirements.txt it drops cryptography | 14:21 |
| sean-k-mooney | oslo.log we may revisit but in general the client "logs" via print statmetnt | 14:21 |
| chandankumar | as we were discussing earlier, other deps might bring down cryptography, Do we still want to keep it? | 14:22 |
| sean-k-mooney | if we are currently using python loging in teh cleint the correct fix woudl be to keep oslo.log and port the code to use it | 14:22 |
| sean-k-mooney | chandankumar: no we only ist direct deps | 14:22 |
| sean-k-mooney | so if our indirect deps pull it in (openstacksdk likely will) | 14:23 |
| sean-k-mooney | then thats ok | 14:23 |
| chandankumar | for oslo.log, I will keep it and port the code to use it in a seperate patch. | 14:23 |
| chandankumar | that's it on review | 14:24 |
| chandankumar | Moving to bugs now | 14:24 |
| chandankumar | #topic bugs | 14:24 |
| chandankumar | #link Remove deprecated HTTPClient and VerifiedHTTPSConnection: https://bugs.launchpad.net/python-cyborgclient/+bug/2146351 | 14:24 |
| chandankumar | VerifiedHTTPSConnection is used only at https://github.com/openstack/python-cyborgclient/blob/dcab1011666bcb9fc0e0a6062db3b6badb843ce9/cyborgclient/common/httpclient.py#L91 | 14:25 |
| sean-k-mooney | we should be using the httpclint form the sdk exlusively | 14:25 |
| sean-k-mooney | pror to that we woudl have used the keystoneauth one directly | 14:25 |
| chandankumar | Do you have the link to httpclient from the sdk? | 14:26 |
| sean-k-mooney | we shoudl not be using it directly in most case we shoudl be using the sdk functionaltiy | 14:26 |
| sean-k-mooney | but its part of the connection object | 14:27 |
| sean-k-mooney | when you create an openstack sdk connection it proves 3 levels of api access | 14:27 |
| sean-k-mooney | a direct authencated http client for raw requests | 14:27 |
| sean-k-mooney | a service/proxy api and a clout api wiht some cleanups | 14:28 |
| sean-k-mooney | we shoudl be using that middel layer but if that is missing functionatliy fall back to the sdk's client since that handels the keystone auth for us | 14:28 |
| sean-k-mooney | https://github.com/openstack/openstacksdk/tree/master/openstack/accelerator | 14:29 |
| sean-k-mooney | cyborg has sdk supprot so we shoudl not need to use the raw client at all | 14:29 |
| sean-k-mooney | we shoudl likely remvoe https://opendev.org/openstack/python-cyborgclient/src/branch/master/cyborgclient/v1 entirly by the way | 14:31 |
| sean-k-mooney | can we file a bug to remvoe the remvoe v1 api | 14:31 |
| sean-k-mooney | that was remvoed in 2018 | 14:31 |
| chandankumar | ok | 14:31 |
| sean-k-mooney | or perhaps 2019 but it well past the point where all non eol cyborg version have delete it | 14:31 |
| sean-k-mooney | same for https://opendev.org/openstack/python-cyborgclient/src/branch/master/cyborgclient/osc/v1 | 14:32 |
| chandankumar | I am trying to understand we need use https://github.com/openstack/openstacksdk/tree/master/openstack/accelerator in python cyborgclient that will gget us everything | 14:32 |
| chandankumar | I will file a bug for v1 removal | 14:32 |
| sean-k-mooney | correct the sdk has full supprot for the v2 api | 14:32 |
| sean-k-mooney | so i think if we remvoe the v1 api we can remove the use of the raw http client entirly | 14:33 |
| sean-k-mooney | i belvie https://opendev.org/openstack/python-cyborgclient/src/branch/master/cyborgclient/osc/v2 | 14:33 |
| sean-k-mooney | only uses the sdk today | 14:33 |
| chandankumar | Ok I will modify this bug then drop http raw client of sdk support | 14:34 |
| chandankumar | *to drop | 14:34 |
| sean-k-mooney | lets use it to track fully removing all supprot for the v1 api | 14:35 |
| sean-k-mooney | that will remove all useage of https://opendev.org/openstack/python-cyborgclient/src/branch/master/cyborgclient/common/httpclient.py | 14:36 |
| sean-k-mooney | and perhaps a few other files | 14:36 |
| sean-k-mooney | if you want to split this up into multiple parts we coudl do that | 14:37 |
| chandankumar | I have updated this bug to drop v1 api support | 14:38 |
| sean-k-mooney | we shodul also be removing the native shell (when not used via osc) but that needs deprecation before we can do that | 14:38 |
| sean-k-mooney | python-cyborgclient should eventuly only provdie the osc plugin | 14:38 |
| sean-k-mooney | but we can do that in phases | 14:39 |
| chandankumar | sean-k-mooney: can you add me the launchpad bug admin to add importance status in the bug https://bugs.launchpad.net/python-cyborgclient/+bug/2146351 | 14:40 |
| sean-k-mooney | its an open team you do not need admin | 14:40 |
| sean-k-mooney | you just need to join the team | 14:40 |
| sean-k-mooney | https://launchpad.net/~cyborg-bug-team | 14:41 |
| sean-k-mooney | you shoudl join that | 14:41 |
| chandankumar | Done, thank you! | 14:41 |
| chandankumar | I am setting the importance to medum for now | 14:42 |
| chandankumar | that's it from today | 14:42 |
| sean-k-mooney | ack | 14:42 |
| chandankumar | Moving to open discussion | 14:42 |
| sean-k-mooney | we shoudl start fixing it this cycle but its not broken | 14:42 |
| chandankumar | #topic open discussion | 14:42 |
| chandankumar | I have added it to 2026.1 series | 14:42 |
| sean-k-mooney | it shoudl be in the 2026.2 serise but i may not have created that yet | 14:43 |
| chandankumar | any last min topic anyone wants to discuss | 14:43 |
| sean-k-mooney | i did for cyborg | 14:43 |
| sean-k-mooney | am one | 14:43 |
| sean-k-mooney | https://review.opendev.org/q/project:openstack/python-cyborgclient+owner:infra-root@openstack.org+is:open | 14:43 |
| sean-k-mooney | there are a bunch of bot patches | 14:43 |
| sean-k-mooney | im goign to reabse all of thos einto a stack for each branch based on release | 14:43 |
| sean-k-mooney | and then merge them unless someone else whant to do it | 14:43 |
| sean-k-mooney | i did if for the main cybrog repo a few weeks ago | 14:44 |
| chandankumar | if I take a look and go over them this week | 14:44 |
| sean-k-mooney | but forgot to do it for the client | 14:44 |
| sean-k-mooney | ack so we want them to be ordered oldest to newest | 14:44 |
| sean-k-mooney | to pretened we merged them when we were orginally ment too | 14:44 |
| sean-k-mooney | on master that is | 14:45 |
| sean-k-mooney | for the stable branches we can merge thos mostly in any oder but the .gitrevew and tox change shoudl be the first on teh brance | 14:45 |
| chandankumar | ok thanks for metntion the order | 14:45 |
| sean-k-mooney | ok that was the only thing i had to raise | 14:46 |
| chandankumar | thank you! | 14:46 |
| chandankumar | #topic volunteer for next meeting | 14:46 |
| chandankumar | anyone up to chair for next meeting? | 14:47 |
| chandankumar | If no, then I will do that | 14:48 |
| chandankumar | #info chandankumar will chair the next meeting | 14:48 |
| chandankumar | now it's time to close | 14:48 |
| chandankumar | thank you all for attending | 14:48 |
| chandankumar | #endmeeting | 14:48 |
| opendevmeet | Meeting ended Tue Mar 31 14:48:25 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:48 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-03-31-14.00.html | 14:48 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-03-31-14.00.txt | 14:48 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-03-31-14.00.log.html | 14:48 |
| sean-k-mooney | o/ | 14:48 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!