| opendevreview | chandan kumar proposed openstack/cyborg master: Update DevStack setup guide and add sample local.conf https://review.opendev.org/c/openstack/cyborg/+/983003 | 06:19 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/cyborg master: Add VM setup and NVMe driver documentation https://review.opendev.org/c/openstack/cyborg/+/982711 | 09:46 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add VM setup and NVMe driver documentation https://review.opendev.org/c/openstack/cyborg/+/982711 | 09:50 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add VM setup and NVMe driver documentation https://review.opendev.org/c/openstack/cyborg/+/982711 | 09:58 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add VM setup and NVMe driver documentation https://review.opendev.org/c/openstack/cyborg/+/982711 | 10:18 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add user guide for creating instances with accelerators https://review.opendev.org/c/openstack/cyborg/+/983027 | 10:52 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add doc around running cyborg tempest plugin test https://review.opendev.org/c/openstack/cyborg/+/983030 | 11:31 |
| chandankumar | sean-k-mooney: hello, Tox update and .gitreview update for 2025.2 is good to go https://review.opendev.org/c/openstack/python-cyborgclient/+/959714 and https://review.opendev.org/c/openstack/python-cyborgclient/+/959715/1 , Please have a look when free, thank you! | 12:28 |
| sean-k-mooney | chandankumar: thanks ill try and ge though the sabel one ones today | 12:29 |
| chandankumar | 2024.2 and 2025.1 tox jobs are broken due to pkg_resources | 12:30 |
| chandankumar | I will propose a stable only fix for these branches by pinning setuptool | 12:30 |
| sean-k-mooney | in which job | 12:31 |
| sean-k-mooney | the docs job? | 12:31 |
| chandankumar | https://review.opendev.org/c/openstack/python-cyborgclient/+/928258/1#message-93732aabc5b3bc3dffc2e66d0022a83fa41ab037 | 12:31 |
| chandankumar | tox jobs except pep8 | 12:31 |
| chandankumar | https://review.opendev.org/c/openstack/python-cyborgclient/+/943714/1#message-52854be5dadc03bbadaf2a199387cb3737b92e3f | 12:32 |
| sean-k-mooney | that not really the corerct fix for the python ones | 12:32 |
| sean-k-mooney | alhtohg maybe that what we need to do without some other changes | 12:32 |
| sean-k-mooney | we do not pin it in nova or watcher client | 12:34 |
| chandankumar | yes, we did it in watcher repo for docs https://opendev.org/openstack/watcher/commit/9b5babfbcbc66c6d9298d3c8ddaf8ea42576aaf1 | 12:35 |
| sean-k-mooney | oh i think i might see the issue | 12:36 |
| sean-k-mooney | python-cyborgclient is missing it pyproject.toml | 12:36 |
| sean-k-mooney | which means it is not proprly using pbr to build on the sable branches | 12:36 |
| sean-k-mooney | the fix woudl be to add https://github.com/openstack/python-novaclient/blob/stable/2025.1/pyproject.toml | 12:36 |
| sean-k-mooney | lets fix that on master | 12:37 |
| chandankumar | proposing patch | 12:38 |
| sean-k-mooney | and try cherry-picking it ot the older brnaches adn see if that resolves the issues | 12:38 |
| opendevreview | chandan kumar proposed openstack/python-cyborgclient master: add pyproject.toml to support pip 23.1 https://review.opendev.org/c/openstack/python-cyborgclient/+/983046 | 12:47 |
| chandankumar | ok | 12:53 |
| chandankumar | sean-k-mooney: https://review.opendev.org/c/openstack/python-cyborgclient/+/983051/1#message-fb3303afcbd5d567f6b358030894bb0b0b67e1a8 with pyproject.toml changes, it is still failing with same error. | 13:05 |
| chandankumar | Requirement already satisfied: setuptools in ./.tox/py39/lib/python3.9/site-packages (from pbr!=2.1.0,>=2.0.0->-r /home/zuul/src/opendev.org/openstack/python-cyborgclient/requirements.txt (line 4)) (82.0.0) is used there | 13:06 |
| chandankumar | I think we need to avoid installing this version in pyproject.toml also | 13:07 |
| sean-k-mooney | let me double check | 13:09 |
| sean-k-mooney | but we shoudl not need too | 13:09 |
| sean-k-mooney | we are requireign >6 | 13:10 |
| sean-k-mooney | 6.somthing in pre-commit | 13:10 |
| sean-k-mooney | https://github.com/openstack/python-cyborgclient/blob/master/requirements.txt#L4 is a lot lower then we actully need | 13:10 |
| chandankumar | python-watcherclient uses pbr!=2.1.0,>=3.1.1 # Apache-2.0 | 13:11 |
| sean-k-mooney | ya we dont nee the !=2.1.0 part | 13:12 |
| sean-k-mooney | nova client just has pbr>=3.0.0 # | 13:12 |
| sean-k-mooney | but our actual reqiremetnis >6.1.0 i think | 13:12 |
| sean-k-mooney | or >=5.7.0 as the acual min that works with pyproject.toml | 13:12 |
| sean-k-mooney | nova has >=5.8.0 in requiremets.txt | 13:13 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/requirements.txt#L5C1-L5C24 | 13:13 |
| sean-k-mooney | so lets go with that for now | 13:14 |
| sean-k-mooney | that what they have on 2024.2 as well | 13:14 |
| sean-k-mooney | https://github.com/openstack/nova/blob/stable/2024.2/requirements.txt#L5 | 13:14 |
| sean-k-mooney | so we know that we at least have that aviabel | 13:14 |
| chandankumar | Can I include pbr change in pyproject.toml itself ? I will keep the same in requirements and pyproject.toml | 13:15 |
| sean-k-mooney | update both | 13:16 |
| chandankumar | ok | 13:21 |
| sean-k-mooney | there may be other work requried to fix this properly but you shoudl be abel to repoduce the issues locally just runnign tox | 13:23 |
| sean-k-mooney | i makde sure this was all fixed in cybrog beofre the release but i forgot to do it for the client repo so my bad on that | 13:24 |
| -opendevstatus- NOTICE: The opendev.org site is currently experiencing overwhelming load adversely impacting git operations and repository browsing since 12:20 UTC today, mitigation work is in progress | 14:41 | |
| chandank` | sean-k-mooney: I am not able to reproduce that locally with tox -e py39 or tox -e py312 locally | 14:59 |
| chandank` | I proposed https://review.opendev.org/c/openstack/python-cyborgclient/+/983073 to pin setuptools for 2025.1 | 15:00 |
| chandank` | ci job passes here | 15:00 |
| sean-k-mooney | so directlly im not ok wiht pins like that in genral unless they are tempeory | 15:02 |
| sean-k-mooney | chandank`: policy wise project are not ment to cap or pin depencies in genreal. this is slightly diffent | 15:02 |
| chandank` | yes I agree. But I am not able to get a reproducer | 15:03 |
| sean-k-mooney | that is because this depend on the version of setuptools and virual env you have i think so you would likely need to repoduce on ubuntu | 15:04 |
| chandank` | I tried with ubuntu noble with py312 same here. Setuptools 82.0.1 is getting installed there | 15:05 |
| sean-k-mooney | yes and that is ok | 15:13 |
| sean-k-mooney | on 2025.1 we have backported the change sin other repos to make it compatible | 15:13 |
| sean-k-mooney | let me take a look in a few minutes | 15:14 |
| sean-k-mooney | we might proceed with the pin for now to unblock things but we shoudl fix it properly | 15:14 |
| sean-k-mooney | the ping woudl only be ok on stable | 15:14 |
| sean-k-mooney | master need to remain unpinned | 15:15 |
| chandank` | https://paste.openstack.org/raw/bHvAJfuJzCW2OXVMYhZP/ | 15:16 |
| chandank` | I am pinning it on stable/2025.1 only | 15:16 |
| chandank` | and will backport it to 2024.2 to ubblock CI | 15:16 |
| chandank` | sure, | 15:17 |
| chandank` | feel free to leave your comments based on your investigation | 15:17 |
| chandank` | I will take a look tomorrow morning | 15:17 |
| chandank` | 983073: [Stable-only][CI] Pin setuptools | https://review.opendev.org/c/openstack/python-cyborgclient/+/983073 for 2025.1 is the review pin for 2025.1 only | 15:19 |
| sean-k-mooney | https://paste.opendev.org/show/bPESsYNpkOOQju6gLKuu/ | 15:45 |
| sean-k-mooney | i can repoduce it locally | 15:45 |
| sean-k-mooney | https://review.opendev.org/c/openstack/python-cyborgclient/+/983051 fixes it but i need to od that properly on master and backport it | 16:10 |
| sean-k-mooney | i think we will have to squash it into https://review.opendev.org/c/openstack/python-cyborgclient/+/943715/1 and make the .gitreview patch go after to get it to pass ci | 16:11 |
| sean-k-mooney | or squash all 3 | 16:11 |
| -opendevstatus- NOTICE: Load on the opendev.org Gitea backends is under control again for now, if any Zuul jobs failed with SSL errors or disconnects reaching the service they can be safely rechecked | 16:12 | |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!