*** HenryG has quit IRC | 00:41 | |
*** HenryG has joined #openstack-dns | 00:46 | |
*** lpmulligan has joined #openstack-dns | 00:51 | |
*** EricGonczer_ has joined #openstack-dns | 01:06 | |
*** lpmulligan has quit IRC | 01:24 | |
*** HenryG has quit IRC | 01:24 | |
*** HenryG has joined #openstack-dns | 01:32 | |
*** EricGonczer_ has quit IRC | 01:38 | |
*** nosnos has joined #openstack-dns | 02:07 | |
*** jmcbride has joined #openstack-dns | 02:15 | |
*** nosnos has quit IRC | 03:22 | |
*** nosnos has joined #openstack-dns | 03:23 | |
*** nosnos has quit IRC | 03:27 | |
*** jmcbride has quit IRC | 03:33 | |
*** nosnos has joined #openstack-dns | 04:04 | |
*** simon-AS559 has joined #openstack-dns | 05:39 | |
*** simon-AS5591 has joined #openstack-dns | 05:42 | |
*** simon-AS559 has quit IRC | 05:44 | |
*** simon-AS5591 has quit IRC | 05:52 | |
*** nosnos has quit IRC | 05:59 | |
*** nosnos_ has joined #openstack-dns | 05:59 | |
*** k4n0 has joined #openstack-dns | 06:18 | |
*** nosnos_ has quit IRC | 07:13 | |
*** nosnos has joined #openstack-dns | 07:13 | |
*** jordanP has joined #openstack-dns | 08:38 | |
*** mwagner_lap has quit IRC | 11:31 | |
*** jordanP has quit IRC | 11:56 | |
*** jordanP has joined #openstack-dns | 12:00 | |
*** mwagner_lap has joined #openstack-dns | 12:11 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/designate: Updated from global requirements https://review.openstack.org/131109 | 12:15 |
---|---|---|
*** ryanpetrello has quit IRC | 12:16 | |
*** openstackgerrit has quit IRC | 12:19 | |
*** ryanpetrello has joined #openstack-dns | 12:19 | |
*** openstackgerrit has joined #openstack-dns | 12:19 | |
*** ChanServ sets mode: +v openstackgerrit | 12:19 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-designateclient: Updated from global requirements https://review.openstack.org/131121 | 12:21 |
*** openstackgerrit has quit IRC | 12:34 | |
*** openstackgerrit has joined #openstack-dns | 12:34 | |
*** ChanServ sets mode: +v openstackgerrit | 12:34 | |
*** lpmulligan has joined #openstack-dns | 12:41 | |
*** rmoe has quit IRC | 12:44 | |
*** rmoe has joined #openstack-dns | 12:46 | |
*** EricGonczer_ has joined #openstack-dns | 12:54 | |
*** jmcbride has joined #openstack-dns | 13:06 | |
*** EricGonczer_ has quit IRC | 13:09 | |
*** nkinder has quit IRC | 13:11 | |
*** richm has joined #openstack-dns | 13:19 | |
*** lpmulligan has quit IRC | 13:20 | |
*** jmcbride has quit IRC | 13:29 | |
*** paul_glass has joined #openstack-dns | 13:33 | |
*** paul_glass has quit IRC | 13:36 | |
*** jmcbride has joined #openstack-dns | 13:37 | |
*** paul_glass has joined #openstack-dns | 13:38 | |
*** jmcbride has quit IRC | 13:41 | |
*** k4n0 has quit IRC | 13:51 | |
*** mwagner_lap has quit IRC | 13:53 | |
*** mwagner_lap has joined #openstack-dns | 13:55 | |
*** simon-AS5591 has joined #openstack-dns | 13:57 | |
*** jmcbride has joined #openstack-dns | 14:01 | |
*** nosnos has quit IRC | 14:04 | |
*** nosnos has joined #openstack-dns | 14:05 | |
*** nosnos has quit IRC | 14:09 | |
*** nkinder has joined #openstack-dns | 14:09 | |
*** betsy has quit IRC | 14:13 | |
*** EricGonczer_ has joined #openstack-dns | 14:17 | |
*** russellb is now known as drumkilla | 14:20 | |
*** drumkilla is now known as russellb | 14:20 | |
*** jmcbride has quit IRC | 14:21 | |
*** jmcbride has joined #openstack-dns | 14:22 | |
*** paul_glass has quit IRC | 14:30 | |
*** paul_glass has joined #openstack-dns | 14:30 | |
*** vinod1 has joined #openstack-dns | 14:32 | |
*** simon-AS5591 has quit IRC | 14:33 | |
*** timsim has joined #openstack-dns | 14:43 | |
*** simon-AS559 has joined #openstack-dns | 14:51 | |
*** EricGonczer_ has quit IRC | 14:53 | |
*** simon-AS5591 has joined #openstack-dns | 14:54 | |
*** simon-AS559 has quit IRC | 14:56 | |
*** EricGonczer_ has joined #openstack-dns | 14:56 | |
*** jmcbride has quit IRC | 14:56 | |
*** jmcbride has joined #openstack-dns | 14:56 | |
*** betsy has joined #openstack-dns | 14:58 | |
*** timsim has quit IRC | 14:59 | |
openstackgerrit | A change was merged to openstack/designate: Updated from global requirements https://review.openstack.org/131109 | 15:06 |
*** timsim has joined #openstack-dns | 15:13 | |
*** jmcbride has quit IRC | 15:16 | |
*** jmcbride has joined #openstack-dns | 15:50 | |
*** jmcbride has quit IRC | 15:51 | |
*** simon-AS559 has joined #openstack-dns | 15:57 | |
*** simon-AS5591 has quit IRC | 16:00 | |
*** EricGonczer_ has quit IRC | 16:03 | |
*** rmoe has quit IRC | 16:03 | |
*** mwagner_lap has quit IRC | 16:05 | |
*** EricGonczer_ has joined #openstack-dns | 16:10 | |
*** jmcbride has joined #openstack-dns | 16:19 | |
*** rmoe has joined #openstack-dns | 16:22 | |
openstackgerrit | Endre Karlson proposed a change to openstack/designate-specs: Refactor Zone import functionality https://review.openstack.org/130852 | 16:23 |
openstackgerrit | Endre Karlson proposed a change to openstack/designate-specs: Add secondary zones https://review.openstack.org/130758 | 16:23 |
ekarlso | eyes on ^ would be niceness :) | 16:24 |
*** jmcbride has quit IRC | 16:30 | |
*** jmcbride has joined #openstack-dns | 16:30 | |
*** mikedillion has joined #openstack-dns | 16:41 | |
*** mikedillion has quit IRC | 16:41 | |
*** paul_glass has quit IRC | 17:00 | |
*** mwagner_lap has joined #openstack-dns | 17:01 | |
*** paul_glass has joined #openstack-dns | 17:10 | |
*** jmcbride has quit IRC | 17:18 | |
*** simon-AS5591 has joined #openstack-dns | 17:18 | |
*** simon-AS559 has quit IRC | 17:21 | |
*** rrickard has joined #openstack-dns | 17:26 | |
*** simon-AS5591 has quit IRC | 17:26 | |
rrickard | kiall: you around? | 17:26 |
Kiall | rrickard: heya, kinda :) | 17:26 |
rrickard | what is it going to take to get my pool manager changes merged? | 17:26 |
*** amcrn has joined #openstack-dns | 17:27 | |
rrickard | had to spend a little while last Friday resolving another change and i don't want to waste time doing that if i can avoid it. | 17:27 |
Kiall | rrickard: Tim left some comments, and we'll need a core besides me to review it too (i.e. mugsie / betsy / vinod1) | 17:28 |
Kiall | It's good to go from me - just need some more eyes! | 17:29 |
Kiall | Humm .. I thought I had left a +2 on it -_- | 17:29 |
rrickard | are tims comments reasonable to -1 the work? | 17:29 |
rrickard | this started as 'we'll take the changes as they come' and it seems to be getting bigger and bigger. | 17:30 |
Kiall | Generlalt - Yep they are - But we'd like to get this stuff merged, so only if there is another patchset needed anyway | 17:30 |
Kiall | Generally* | 17:30 |
rrickard | do we have a checklist of things like this (sample config file, devstack, etc.)? | 17:31 |
Kiall | No we don't, we probably should though :) | 17:32 |
rrickard | for example, i know i also need tests cases to cover most of the code, but i thought getting the code in front of everyone first was important. | 17:33 |
rrickard | i figured i fill in the test cases once the code is out there for scrutiny. | 17:33 |
rrickard | not exactly test driven development (TDD), but ... | 17:34 |
Kiall | Yea.. I've gotta run.. But ping mugsie / vinod1 / betsy about reviewing the change and merging :) | 17:36 |
rrickard | cool. thanks! | 17:36 |
*** simon-AS559 has joined #openstack-dns | 17:49 | |
*** jmcbride has joined #openstack-dns | 17:52 | |
rrickard | any core contributor around besides kiall? | 17:56 |
timsim | vinod1 ^ | 17:59 |
*** jmcbride has quit IRC | 18:00 | |
rrickard | vinod1? | 18:00 |
rrickard | vinod1: can i get you to review https://review.openstack.org/#/c/128300/? | 18:01 |
vinod1 | rrickard: I will take a look at it later tonight | 18:01 |
rrickard | okay | 18:02 |
rrickard | timsim: maybe i can help you out here in the meantime with your configuration file questions? | 18:04 |
timsim | Sure | 18:05 |
timsim | So you're testing it with a bind9 backend? | 18:05 |
rrickard | correct. | 18:05 |
timsim | What does your configuration look like for that? | 18:06 |
rrickard | what is the name of that file sharing site we use? i can add my config file there? | 18:06 |
timsim | paste.openstack.org | 18:07 |
rrickard | just a sec. | 18:07 |
*** jmcbride has joined #openstack-dns | 18:07 | |
rrickard | timsim: let me know if you can see this: http://paste.openstack.org/show/125475/ | 18:10 |
timsim | Yep. | 18:10 |
*** shakamunyi has joined #openstack-dns | 18:10 | |
*** shakamunyi has quit IRC | 18:10 | |
rrickard | so, i know 'host' and 'rndc_host' are goofy. i had talked to kiall about that. if no 'rndc_host' exists, we'll use host. i will be making that change in the next code release. | 18:11 |
rrickard | but we'll support both, just incase someone has the server bound to a different IP than rndc. | 18:11 |
timsim | Yeah that's no big deal. | 18:12 |
rrickard | masters should be set to the server running Designate. i don't have minidns turned on during my testing, so instead, i'm pointing it at another master. i've been testing designate-pool-manager in isolation. | 18:13 |
rrickard | pmdomain.py in contribs is how i'm adding and deleting domains. | 18:14 |
*** shakamunyi has joined #openstack-dns | 18:14 | |
*** shakamunyi has quit IRC | 18:14 | |
rrickard | 'python pmdomain.py -c example.com' and 'python pmdomain.py -d example.com' for example. | 18:14 |
rrickard | and clearly, i'm not storing status or anything in the code that is ready for review. that is coming in the next release too. | 18:15 |
rrickard | just wanted to make sure i had a working backend driver for BIND9. | 18:15 |
timsim | Right. I'll check it out. I was just trying to make sure all the tools were there so that if someone wanted to test it out they could. | 18:16 |
rrickard | np. i'm adding the configuration file examples now. it will go in the next code to be reviewed. | 18:17 |
timsim | Obviously there's a lot of code that needs to be merged and refactored to work together, so it's a good first step to get Betsy and your stuff merged so we can get this closer to truly operational. | 18:17 |
rrickard | and vinod's (if it wasn't merged already.) | 18:18 |
rrickard | i have been holding off on adding more code to be reviewed, but i am sitting on more code. 8^) | 18:18 |
timsim | We've got to figure a way to get that broken up a bit. | 18:19 |
rrickard | it is becoming a pain everytime i have to fix something in the code i submitted. | 18:19 |
timsim | Yeah, I'm sure some form of separate reviews that depend on each other, and then when you want to test it all together you can rebase all the branches on each other could be done. Or something like that. | 18:20 |
rrickard | the first code i submitted was almost 2 weeks ago. i didn't think it would take this long for it to be merged. unfortunately, i kept adding to it. if i had known, i would have taken a different approach. | 18:21 |
rrickard | 8^) | 18:21 |
*** shakamunyi has joined #openstack-dns | 18:23 | |
*** jmcbride has quit IRC | 18:24 | |
*** jmcbride has joined #openstack-dns | 18:24 | |
*** EricGonczer_ has quit IRC | 18:26 | |
*** EricGonczer_ has joined #openstack-dns | 18:27 | |
*** shakamunyi has quit IRC | 18:30 | |
*** rossk has joined #openstack-dns | 18:34 | |
betsy | The server pools storage should be good to be merged in, too | 18:36 |
betsy | If anybody has a chance to review the latest changes | 18:36 |
*** jmcbride1 has joined #openstack-dns | 18:43 | |
*** jmcbride has quit IRC | 18:44 | |
*** jmcbride1 has quit IRC | 18:58 | |
*** jmcbride has joined #openstack-dns | 19:01 | |
*** amcrn has quit IRC | 19:23 | |
vinod1 | rrickard: https://wiki.openstack.org/wiki/Gerrit_Workflow#Add_dependency This link has the instructions on how to add dependencies. Might be useful later if you want to split your new code into multiple changelists | 19:23 |
*** jordanP has quit IRC | 19:24 | |
openstackgerrit | Vinod Mangalpally proposed a change to openstack/designate: API for pools https://review.openstack.org/129382 | 19:30 |
ekarlso | rrickard: you gonna split https://review.openstack.org/#/c/128300/12 into pieces or ? :) | 19:33 |
timsim | ekarlso: It looks like it's just going to merge as is. | 19:34 |
ekarlso | yeah, but it's a big change -,,- | 19:34 |
* timsim shrugs | 19:35 | |
ekarlso | +2k lines :| | 19:35 |
timsim | Yeah I gave it a look, but it's pretty hard to review at that size. | 19:36 |
timsim | I think they're just looking to get it in, and if there are issues there can be more patchsets to fix. There are going to be many more anyway. | 19:36 |
ekarlso | well | 19:36 |
ekarlso | there's some stuff that could be done outside .. | 19:36 |
ekarlso | timsim: that still doesn't mean we shouldn't try to abide to the small patchset rule :p | 19:39 |
timsim | I agree, but it looks like it's going to be an exception to the rule. Might be more effort than it's worth. | 19:40 |
ekarlso | maybe ;) | 19:40 |
ekarlso | +1 from me anyways | 19:41 |
ekarlso | rrickard: you around bud ? | 19:43 |
*** nkinder has quit IRC | 19:53 | |
*** nkinder has joined #openstack-dns | 19:56 | |
*** EricGonc_ has joined #openstack-dns | 20:00 | |
*** EricGonczer_ has quit IRC | 20:00 | |
*** jmcbride has quit IRC | 20:06 | |
*** jmcbride has joined #openstack-dns | 20:46 | |
*** jmcbride1 has joined #openstack-dns | 20:48 | |
*** jmcbride has quit IRC | 20:51 | |
*** EricGonc_ has quit IRC | 20:54 | |
*** EricGonczer_ has joined #openstack-dns | 20:56 | |
*** shakamunyi has joined #openstack-dns | 21:10 | |
*** shakamunyi has quit IRC | 21:10 | |
*** simon-AS559 has quit IRC | 21:13 | |
vinod1 | kiall: any objections to merging the pool manager service changes? | 21:13 |
vinod1 | https://review.openstack.org/#/c/128300/12 | 21:13 |
*** nkinder has quit IRC | 21:15 | |
*** simon-AS559 has joined #openstack-dns | 21:21 | |
*** rossk has left #openstack-dns | 21:24 | |
openstackgerrit | A change was merged to openstack/designate: Pool Manager Service Changes https://review.openstack.org/128300 | 21:37 |
timsim | ^ woot! | 21:37 |
*** paul_glass has quit IRC | 21:41 | |
*** timsim has quit IRC | 21:47 | |
rrickard | ekarlso: i'm here. | 21:58 |
rrickard | okay. code merged. i'll keep subsequent changes smaller. | 22:00 |
openstackgerrit | Betsy Luzader proposed a change to openstack/designate: Server Pools Storage https://review.openstack.org/127355 | 22:02 |
*** betsy has quit IRC | 22:06 | |
*** nkinder has joined #openstack-dns | 22:06 | |
*** shakamunyi has joined #openstack-dns | 22:30 | |
*** shakamunyi has quit IRC | 22:30 | |
*** amcrn has joined #openstack-dns | 22:33 | |
*** EricGonczer_ has quit IRC | 22:35 | |
*** shakamunyi has joined #openstack-dns | 22:41 | |
*** shakamunyi has quit IRC | 22:41 | |
*** shakamunyi has joined #openstack-dns | 22:42 | |
*** shakamunyi has quit IRC | 22:42 | |
*** shakamunyi has joined #openstack-dns | 22:43 | |
*** shakamunyi has quit IRC | 22:43 | |
*** shakamunyi has joined #openstack-dns | 22:44 | |
*** shakamunyi has quit IRC | 22:44 | |
*** jmcbride1 has quit IRC | 22:49 | |
*** shakamunyi has joined #openstack-dns | 22:49 | |
*** shakamunyi has quit IRC | 22:49 | |
*** ryanpetrello has quit IRC | 22:52 | |
*** ryanpetrello has joined #openstack-dns | 22:53 | |
openstackgerrit | Vinod Mangalpally proposed a change to openstack/designate: API for pools https://review.openstack.org/129382 | 22:55 |
*** vinod1 has quit IRC | 22:56 | |
*** jmcbride has joined #openstack-dns | 23:22 | |
*** simon-AS559 has quit IRC | 23:41 | |
*** betsy has joined #openstack-dns | 23:42 | |
*** paul_glass has joined #openstack-dns | 23:50 | |
*** paul_glass has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!