Tuesday, 2014-10-28

« Monday, 2014-10-27 Index Wednesday, 2014-10-29 »
*** jmcbride has quit IRC00:20
*** rmoe has quit IRC00:28
*** amcrn has quit IRC00:33
openstackgerritRon Rickard proposed a change to openstack/designate: Pool Manager - BIND9 Pool Backend Driver Fixes  https://review.openstack.org/13131200:46
*** rmoe has joined #openstack-dns00:49
*** jmcbride has joined #openstack-dns01:04
*** EricGonczer_ has joined #openstack-dns01:24
*** EricGonczer_ has quit IRC01:32
*** EricGonczer_ has joined #openstack-dns01:34
*** jmcbride has quit IRC01:49
*** paul_glass has joined #openstack-dns01:50
*** EricGonczer_ has quit IRC01:54
*** paul_glass has quit IRC01:55
*** vinod1 has joined #openstack-dns01:56
*** nosnos has joined #openstack-dns01:59
*** puck has quit IRC02:13
*** jmcbride has joined #openstack-dns02:18
*** puck has joined #openstack-dns02:20
openstackgerritJoe McBride proposed a change to openstack/designate: Initial documentation for v2 API record sets  https://review.openstack.org/13093802:41
*** jmcbride has quit IRC02:43
*** vinod1 has quit IRC02:43
*** nosnos has quit IRC03:36
*** nosnos has joined #openstack-dns03:37
*** nosnos has quit IRC03:41
*** richm has quit IRC03:44
*** nosnos has joined #openstack-dns04:15
*** jmcbride has joined #openstack-dns04:29
*** vinod1 has joined #openstack-dns04:39
*** simon-AS559 has joined #openstack-dns05:04
*** alokj has joined #openstack-dns05:11
*** vinod1 has quit IRC06:02
openstackgerritOpenStack Proposal Bot proposed a change to openstack/designate: Imported Translations from Transifex  https://review.openstack.org/13135006:08
*** k4n0 has joined #openstack-dns06:57
*** simon-AS5591 has joined #openstack-dns07:07
*** simon-AS559 has quit IRC07:07
*** simon-AS559 has joined #openstack-dns07:10
*** simon-AS5591 has quit IRC07:11
*** simon-AS559 has quit IRC07:31
*** simon-AS5591 has joined #openstack-dns08:33
*** jordanP has joined #openstack-dns09:07
*** simon-AS5591 has quit IRC09:51
*** simon-AS5591 has joined #openstack-dns10:18
*** simon-AS5591 has quit IRC10:55
*** alokj has quit IRC12:05
*** mwagner_lap has quit IRC12:10
*** alokj has joined #openstack-dns12:18
*** paul_glass has joined #openstack-dns12:18
*** alokj is now known as Guest4936512:18
*** Guest49365 has quit IRC12:26
*** ryanpetrello has quit IRC12:34
*** ryanpetrello has joined #openstack-dns12:34
ekarlsobetsy: you up ? :)12:37
*** k4n0 has quit IRC12:46
*** vinod1 has joined #openstack-dns12:52
*** mwagner_lap has joined #openstack-dns12:53
*** simon-AS559 has joined #openstack-dns12:55
*** ryanpetrello has quit IRC13:02
*** ryanpetrello has joined #openstack-dns13:05
*** ryanpetrello has quit IRC13:06
*** ryanpetrello has joined #openstack-dns13:11
*** nkinder has quit IRC13:14
*** richm has joined #openstack-dns13:21
*** ryanpetrello_ has joined #openstack-dns13:26
*** paul_glass has quit IRC13:41
openstackgerritEndre Karlson proposed a change to openstack/designate: Move rec.priority into rec.data  https://review.openstack.org/13143213:43
*** paul_glass has joined #openstack-dns13:46
*** paul_glass has quit IRC13:47
*** paul_glass has joined #openstack-dns13:47
*** ryanpetrello has quit IRC13:59
*** ryanpetrello_ is now known as ryanpetrello13:59
*** rrickard has quit IRC14:00
*** nkinder has joined #openstack-dns14:05
*** nosnos has quit IRC14:06
*** nosnos has joined #openstack-dns14:07
*** vinod1 has quit IRC14:07
betsyekarlson: I’m on now14:09
*** nosnos has quit IRC14:11
*** jmcbride has joined #openstack-dns14:15
*** vinod1 has joined #openstack-dns14:16
*** jmcbride has quit IRC14:18
vinod1mugsie: Do you have updated images about pools that you had created earlier? - https://imgur.com/a/CawLd#014:19
mugsievinod1: not to hand, but i can get thrm when i am back in the office tomorrow14:24
vinod1Thanks mugsie.  I wanted to include them in the designate presentation14:26
*** jmcbride has joined #openstack-dns14:30
*** jordanP has quit IRC14:35
betsyvinod1: Oh, good idea. That’ll be nice in the presentation14:37
*** timsim has joined #openstack-dns14:40
*** jmcbride has quit IRC14:43
*** jmcbride has joined #openstack-dns14:44
*** vinod1 has quit IRC14:49
*** timsim has quit IRC14:54
*** vinod1 has joined #openstack-dns14:54
*** timsim has joined #openstack-dns14:55
*** jmcbride has quit IRC14:57
*** jordanP has joined #openstack-dns14:59
*** paul_glass has quit IRC14:59
*** jmcbride has joined #openstack-dns15:04
*** jmcbride has quit IRC15:05
*** jmcbride has joined #openstack-dns15:06
*** paul_glass has joined #openstack-dns15:09
*** EricGonczer_ has joined #openstack-dns15:27
*** rmoe has quit IRC15:34
*** mudrykaa has joined #openstack-dns15:44
*** mudrykaa has quit IRC15:46
*** mudrykaa has joined #openstack-dns15:48
*** bitblt has joined #openstack-dns15:49
*** rmoe has joined #openstack-dns15:55
*** jmcbride has quit IRC16:07
*** rjrjr_ has joined #openstack-dns16:09
*** vinod1 has quit IRC16:12
*** mudrykaa has quit IRC16:32
*** paul_glass has quit IRC16:32
rjrjr_i have a question: would it make sense for the pool backend to throw a custom exception when the create or delete domain fails?  i'm thinking a BackendFailure exception which i can then use to determine if the backend call was successful or not in the pool manager code.16:34
rjrjr_it would be part of the contract for a backend driver.  if a method fails (create_domain or delete_domain) the method will raise the BackendFailure exception.16:36
Kiallrjrjr_: We (kinda) already do that with the current backends - e.g.the backends are expected to raise a BackendFailure (or a subclass of that) - if any other exception is raised, we "convert" to a BackendFailure to prevent it bubbeling up16:48
Kiallbubbling*16:48
KiallI'd say we just reuse the exact same exception classes, as pool backends will be the only backends anyway..16:48
Kialle.g. let's node add new code where the existing backend stuff will work, considering we'll just end up with more churn :)16:49
* Kiall wishes gerrit was smarter about showing PS -> PS diffs after a rebase -_-16:51
Kiallvinod / betsy / mugsie - https://review.openstack.org/#/c/127355/ and https://review.openstack.org/#/c/129382/ are in good shape to merge (Betsy's and Vinod's pools reviews)17:00
Kiallekarlso: your change at https://review.openstack.org/#/c/131432/ is failing the devstack gate.. http://logs.openstack.org/32/131432/1/check/gate-designate-devstack-dsvm/63f21a0/logs/screen-designate-central.txt.gz17:01
mugsieon a phone, so it will have to wait till i get to the office tomorrow17:02
Kiallmugsie: unaccptable ;)17:02
Kiallalso.. delete IRC from your phone.17:03
rjrjr_kiall, i'm not seeing a uniform exception raised on the backends, which is why i'm asking.17:03
mugsieKiall: ssh ftw17:03
Kiallrjrjr_: https://github.com/openstack/designate/blob/master/designate/central/service.py#L44 and it's usage throughout that enforces it, and, I think your right, none of the stock backends actually use a subclass of those anywhere ;)17:05
Kiall(We have some code @ HP for our Akamai integration which does actually make use of it..._17:05
rjrjr_okay.  i'm going to make use of it then.17:06
rjrjr_i think it needs to be part of the contract for a backend.17:07
KiallYea.. That code came in after all the current backends, I'd defiantly prefer to see a more concrete contract for them though17:09
Kiallrephrase: Yea.. That code came in after the current backend pattern was already in, I'd defiantly prefer to see a more concrete contract for them though17:10
*** paul_glass has joined #openstack-dns17:12
*** simon-AS559 has quit IRC17:13
rjrjr_another dumb question, does designate support IPv6?  when i validate an IP address for the BIND9 masters (masters { <ip-address> port <port>; <ip-address> port <port>; }) should I assume IPv4 IPs?17:17
Kiallrjrjr_: good question :) Speaking as some connected to IRC over IPv6, I'd probably assume IPv4 right now - specifically because we'd then need a per backend way of deciding to accept an IPv6 address or not.. e.g. PowerDNS might not be able to slave over v6 (I honestly have no idea if that's a real thing or not.. But I know I've never tested it ;))17:19
rjrjr_okay.  i'll assume IPv4.  we can always add IPv6 support later.17:20
KiallYea, I'm pretty sure there are still exactly zero OpenStack deployments on IPv6 with no IPv4 at all.. So I'd prefer to get the churn of pools merged ASAP and use the end of the cycle for niceties like IPv617:22
openstackgerritEndre Karlson proposed a change to openstack/designate: Move rec.priority into rec.data  https://review.openstack.org/13143217:22
ekarlsoKiall: ^17:22
Kiallekarlso: thanks17:23
KiallBTW .. It's a race to see who gets migration #41 ;)17:23
ekarlso:'(17:23
Kiallekarlso: I'm seeing this code used in a couple of places, can we turn that into a utils method? http://paste.openstack.org/show/126045/17:29
*** jmcbride has joined #openstack-dns17:29
Kiallwhen we add new types etc we should avoid having to update N places17:29
*** jmcbride has quit IRC17:30
*** jmcbride has joined #openstack-dns17:30
Kialle.g. a `priority, data = utils.extract_priority_from_data(data)` method17:33
ekarlsowhere's that Kiall ?17:34
Kiallekarlso: left some comments in the reviewq17:36
Kiallreview*17:36
ekarlsoall done Kiall :)17:44
openstackgerritEndre Karlson proposed a change to openstack/designate: Move rec.priority into rec.data  https://review.openstack.org/13143217:44
*** amcrn has joined #openstack-dns17:46
*** simon-AS559 has joined #openstack-dns17:48
*** simon-AS5591 has joined #openstack-dns17:50
*** simon-AS559 has quit IRC17:52
*** jordanP has quit IRC18:00
ekarlsoanyone wanna +A ? :D https://review.openstack.org/#/c/131432/18:04
timsimekarlso: You just want to beat betsy to migration #41 ;)18:06
ekarlso:P18:06
Kialltimsim: lol, I know he does ;)18:12
ekarlsowell I got other change ready to g: p18:13
timsimsure sure ;)18:14
*** nkinder has left #openstack-dns18:20
Kiall9 changes with 1x +2 needing a final +A for those core folks around ;)18:40
openstackgerritRon Rickard proposed a change to openstack/designate: Pool Manager - BIND9 Pool Backend Driver Fixes  https://review.openstack.org/13131218:50
*** RandeepJalli has joined #openstack-dns18:52
RandeepJallihey guys, I think I have a fix for the agent18:52
RandeepJalliwhat's the procedure for a pull request on github?18:52
timsimRandeepJalli: https://wiki.openstack.org/wiki/Gerrit_Workflow18:56
KiallRandeepJalli: heya - So, none of the OpenStack projects can take pull requests from GitHub.. OpenStack uses the Gerrit code review system, which can be a tad daunting at first.. There's lots of info on https://wiki.openstack.org/wiki/How_To_Contribute and https://wiki.openstack.org/wiki/GerritWorkflow18:56
Kiall(also .. those diagrams make it look even more scary than it is ;))18:56
openstackgerritTim Simmons proposed a change to openstack/designate-specs: WIP: The New Agent  https://review.openstack.org/13153018:57
timsimI hate the name of that, btw ^18:57
*** RandeepJalli has quit IRC19:01
*** paul_glass has quit IRC19:04
betsytimsim: Hey! My patch should go in first. :)19:07
timsimI +1'd yours second so it'd be at the top ;)19:08
openstackgerritTim Simmons proposed a change to openstack/designate-specs: WIP: The New Agent  https://review.openstack.org/13153019:09
*** vinod1 has joined #openstack-dns19:13
*** vinod1 has joined #openstack-dns19:13
Kiallbetsy: lol... I guess it's up to vinod1 and mugsie ;) Unless you Do The Right Thing and fairly review ekarlso's patch :P19:15
vinod1kiall: the default values for id,created_at etc in the pools table is duplicated in 2 places19:25
vinod1this was done to create the default pool here https://review.openstack.org/#/c/127355/6/designate/storage/impl_sqlalchemy/migrate_repo/versions/041_server_pools_storage.py19:26
vinod1do you know if there is a way to prevent this duplication?19:26
KiallHumm.. I must have missed that.. let me check19:26
KiallAhh19:27
KiallI see19:27
KiallYes, that can be solved...19:27
KiallAh. No, it can't be ;)19:27
KiallBecause the migration in inserting data etc, the values need to be in there, and the values can't reference the main codebase since the main codebase can change and we need to migration to do the exact same thing every time it's ran19:28
vinod1Thanks Kiall for the clarification. +2 it is then19:30
Kiallekarlso: looks like you lost the race for that second +2 ;)19:30
vinod1ekarlso: https://review.openstack.org/#/c/129382/ is still open :-)19:31
Kiallvinod1: Ah, I meant ekarlso has a change with a migration #41 too19:33
Kialleither he or betsy needs to rebase once 1 lands ;)19:33
betsyYep. We’ll see who has to rebase :)19:33
Kiallit's ekarlso ;)19:35
betsykiall: Yeah. That’s what I ran into. If I didn’t add it in, then the create date as null19:35
betsyOh, I did win!19:35
betsyI guess I’m behind in my reading of the IRC chat. :(19:36
KiallIf this was HipChat, I'd give you some (beer) and (cake) ;)19:36
betsy:D19:36
Kiallvinod1: BTW - Did you get a chance to read over http://docs-draft.openstack.org/65/130265/4/check/gate-designate-specs-docs/79f0c02/doc/build/html/specs/kilo/validation-cleanup.html ?19:38
vinod1That is next on my list.  Hope to get to it later in the evening19:39
Kiall(Last section isn't complete yet though - due to there only being 24hours in a day ;))19:39
vinod1Thanks for putting up the spec and all those changes19:39
vinod1Kiall: So I had one question on git.  I see you have a bunch of validation changes all with the same topic and each one dependent on another19:40
KiallYep19:40
vinod1How do you get multiple dependent changes with the same topic?19:40
KiallCreate a branch for the work .. e.g. `git checkout -b bp/validation-cleanup` :)19:41
KiallFor changes like this, I tend to create a branch and have many small commits which I keep reworking..19:41
Kiall(Rebase isn't as painful as people think it can be ;))19:41
vinod1So do you have a separate branch for each of the validation changes or are all the changes in one branch?19:42
Kialle.g. I might do the Object Registry change, then Object Validation which uses it, realize I missed something from the Registry so commit another change, then rebase and reorder + merge the first and last commits back into 1 change etc et19:42
Kiallc19:42
KiallAll on one19:42
Kiallwith rebase allowing me to go back and edit things which aren't the tip of the branch commits19:43
openstackgerritA change was merged to openstack/designate:  Server Pools Storage  https://review.openstack.org/12735519:46
*** simon-AS559 has joined #openstack-dns19:46
*** simon-AS559 has quit IRC19:47
Kiallvinod1:e.g. try this series of commands... http://paste.openstack.org/show/126110/19:48
*** simon-AS559 has joined #openstack-dns19:48
*** simon-AS5591 has quit IRC19:50
Kiallthen if you `git-review`, those changes will go up as dependencies.. and you can keep editing changes over and over by comitting another change and using rebase as that example did.. or use rebase FIRST, and change the commit you want to edit to "edit" instead of "fixup", once you done with  changes, `git commit -a --amend` and `git rebase --continue`19:50
*** mwagner_lap has quit IRC19:50
KiallThe idea is to keep changes small + easily reviewable, each commit still has to pass gate on it's own, and life of a multi part change becomes much easier...19:51
richmalso makes it much easier to backport commits19:56
KiallYep - if you find a bug half way through a feature.. commit everything you have, fix the bug, commit, rebase and swap the order of the two lines to move the bugfix above the new feature, then continue with the new feature knowing your bugfix can be merged separately, and easily backported19:59
KiallIt takes discipline to always do that though, I know I often don't when I should!20:01
openstackgerritA change was merged to openstack/designate: Imported Translations from Transifex  https://review.openstack.org/13135020:33
ekarlsodamned u :p20:43
ekarlsoanyone care to look at mine ? ^20:44
ekarlsoafter i resubmit20:44
openstackgerritEndre Karlson proposed a change to openstack/designate: Move rec.priority into rec.data  https://review.openstack.org/13143220:50
ekarlsoanyone wanna +a ? : P20:52
* ekarlso glares at Kiall and mugsie :p20:52
ekarlsovinod1: and betsy :p20:52
vinod1one minor change - can be changed later too20:54
ekarlsosure20:54
openstackgerritEndre Karlson proposed a change to openstack/designate: Move rec.priority into rec.data  https://review.openstack.org/13143220:55
*** jmcbride has quit IRC21:10
*** EricGonczer_ has quit IRC21:10
ekarlsovinod1: wanna take a look ? :D21:24
vinod1just trying out the changes. will post my review shortly21:25
ekarlso;)21:26
*** jmcbride has joined #openstack-dns21:31
*** timsim has quit IRC21:42
openstackgerritJoe McBride proposed a change to openstack/designate: Initial documentation for v2 API record sets  https://review.openstack.org/13093821:45
*** vinod2 has joined #openstack-dns21:53
*** vinod1 has quit IRC21:55
*** simon-AS5591 has joined #openstack-dns21:57
*** simon-AS559 has quit IRC22:00
openstackgerritJoe McBride proposed a change to openstack/designate: Initial documentation for v2 API record sets  https://review.openstack.org/13093822:04
openstackgerritEndre Karlson proposed a change to openstack/designate-specs: Add secondary zones  https://review.openstack.org/13075822:06
*** simon-AS5591 has quit IRC22:07
*** jmcbride has quit IRC22:07
openstackgerritA change was merged to openstack/designate: API for pools  https://review.openstack.org/12938222:09
*** vinod2 has quit IRC22:12
ekarlsoeveryone else get +2 then me -,,-22:12
openstackgerritEndre Karlson proposed a change to openstack/designate-specs: Add secondary zones  https://review.openstack.org/13075822:17
*** ryanpetrello has quit IRC22:19
rjrjrekarlso: i responded to your comments in the code i submitted.22:33
ekarlsorjrjr: :)22:36
ekarlsowhy does my specs change bork :(22:42
*** ryanpetrello has joined #openstack-dns22:44
openstackgerritEndre Karlson proposed a change to openstack/designate-specs: Add secondary zones  https://review.openstack.org/13075822:51
*** amcrn has quit IRC22:52
*** ryanpetrello has quit IRC22:53
openstackgerritEndre Karlson proposed a change to openstack/designate-specs: Add secondary zones  https://review.openstack.org/13075822:53
*** jmcbride has joined #openstack-dns23:14
*** amcrn has joined #openstack-dns23:42
*** jmcbride has quit IRC23:44
*** jmcbride has joined #openstack-dns23:44
*** jmcbride has quit IRC23:48
*** mwagner_lap has joined #openstack-dns23:51
« Monday, 2014-10-27 Index Wednesday, 2014-10-29 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!