| opendevreview | Brin Zhang proposed openstack/election master: Brin Zhang candidacy for Cyborg PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804930 | 00:15 |
|---|---|---|
| opendevreview | Brin Zhang proposed openstack/election master: Brin Zhang candidacy for Cyborg PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804930 | 00:16 |
| opendevreview | 王昊 proposed openstack/election master: Wang Hao candidacy for Zaqar PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804935 | 02:10 |
| opendevreview | Sylvain Bauza proposed openstack/election master: Adding Sylvain Bauza candidacy for Nova Yoga PTL https://review.opendev.org/c/openstack/election/+/804949 | 06:32 |
| opendevreview | Artem Goncharov proposed openstack/election master: Artem Goncharov candidacy for SDK PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804964 | 08:28 |
| opendevreview | Lajos Katona proposed openstack/election master: Adding Lajos Katona candidacy for Neutron Yoga PTL https://review.opendev.org/c/openstack/election/+/804967 | 08:51 |
| opendevreview | Michal Nasiadka proposed openstack/election master: Michal Nasiadka candidacy for Kolla PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804975 | 09:40 |
| opendevreview | Lajos Katona proposed openstack/election master: Adding Lajos Katona candidacy for Neutron Yoga PTL https://review.opendev.org/c/openstack/election/+/804967 | 09:44 |
| opendevreview | Lucian Petrut proposed openstack/election master: Add Lucian Petrut candidacy for Winstackers https://review.opendev.org/c/openstack/election/+/804981 | 10:27 |
| spotz | Hey alll, there's a few candidacies that have a placeholder file in their patch. Wasn't sure if that was an issue or not for the review | 12:44 |
| fungi | normally the election officials create an initial change to populate the directories for all the teams, and that's done with .placeholder files because git is incapable of recording empty directories | 12:59 |
| ianychoi[m] | Should we create empty directories now? | 13:01 |
| opendevreview | Merged openstack/election master: Add Lucian Petrut candidacy for Winstackers https://review.opendev.org/c/openstack/election/+/804981 | 13:02 |
| opendevreview | Merged openstack/election master: Michal Nasiadka candidacy for Kolla PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804975 | 13:02 |
| opendevreview | Merged openstack/election master: Adding Lajos Katona candidacy for Neutron Yoga PTL https://review.opendev.org/c/openstack/election/+/804967 | 13:07 |
| opendevreview | Merged openstack/election master: Adding Sylvain Bauza candidacy for Nova Yoga PTL https://review.opendev.org/c/openstack/election/+/804949 | 13:10 |
| opendevreview | Merged openstack/election master: Brin Zhang candidacy for Cyborg PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804930 | 13:10 |
| fungi | ianychoi[m]: it's normally done with a change like https://review.opendev.org/751922 before the candidacy period | 13:14 |
| fungi | but better late than never i guess | 13:14 |
| opendevreview | Ian Y. Choi proposed openstack/election master: Set up empty directories for Yoga elections https://review.opendev.org/c/openstack/election/+/805021 | 13:27 |
| ianychoi[m] | fungi: thank you done like ^ | 13:27 |
| fungi | yep! +1 | 13:28 |
| opendevreview | chenker proposed openstack/election master: Add Ke Chen candidacy for Cyborg https://review.opendev.org/c/openstack/election/+/805032 | 14:17 |
| opendevreview | chenker proposed openstack/election master: Add Ke Chen candidacy for Cyborg https://review.opendev.org/c/openstack/election/+/805032 | 14:26 |
| opendevreview | chenker proposed openstack/election master: Add Ke Chen candidacy for Cyborg https://review.opendev.org/c/openstack/election/+/805032 | 14:32 |
| opendevreview | Merged openstack/election master: Artem Goncharov candidacy for SDK PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804964 | 15:10 |
| opendevreview | Merged openstack/election master: Wang Hao candidacy for Zaqar PTL (Yoga) https://review.opendev.org/c/openstack/election/+/804935 | 15:12 |
| ianychoi[m] | fungi: Looks like that ci-check-all-candidate-files command cannot search the candidate on the log, and event my local execution just returns PASS. I could manually validate the candidate, but any hint to investigate in the tool bugs you think? The log is available at - https://zuul.opendev.org/t/openstack/build/9bc607cfa93d4b7dbe04bdea9a89c542/log/job-output.txt | 15:14 |
| fungi | ianychoi[m]: easier to see from the election-tox-ci-checks-review log | 15:22 |
| fungi | er, i mean from the console view | 15:23 |
| fungi | expand the "tox: Run tox" task | 15:23 |
| fungi | that way you don't have to skim through the entire log | 15:23 |
| fungi | oh, i think i see what you're asking | 15:24 |
| ianychoi[m] | Yeah, I have not been leveraging console view honestly :) | 15:25 |
| fungi | this seems to normally work if i look at other builds | 15:25 |
| fungi | is this one candidacy the only problem you've seen so far? | 15:26 |
| ianychoi[m] | On the other hand, it just returns PASS - usually there are OSF member and ATC validation | 15:26 |
| ianychoi[m] | Yep only this so far | 15:26 |
| ianychoi[m] | For others I have checked all the logs | 15:26 |
| fungi | ianychoi[m]: oh, the file path is wrong | 15:27 |
| fungi | it's missing the leading candidates directory | 15:27 |
| fungi | i wonder how we could adjust the jobs to catch that | 15:28 |
| ianychoi[m] | Ah......... | 15:28 |
| fungi | basically it's passing because that file is being ignored as outside the tree we build the candidate list from | 15:28 |
| fungi | so if you did merge it, they wouldn't be listed as a candidate | 15:28 |
| ianychoi[m] | Lol I couldn't think that the path was wrong | 15:28 |
| fungi | the jobs are only validating the candidates in the expected tree, which are the ones that have merged so far | 15:29 |
| ianychoi[m] | Thanks a lot - in future, returning fail for no validation steps on the job would be better solution? | 15:29 |
| fungi | maybe, except that would keep us from being able to merge tooling-only changes | 15:31 |
| ianychoi[m] | Agree with this - it would imply that tooling set can't replace election officials :) | 15:32 |
| fungi | yes, that's one of the reasons why i always looked at the election-tox-ci-checks-review build output and copied the example change and foundation profile urls in my review comment, just to be clear that the job had successfully validated their candidacy | 15:35 |
| ianychoi[m] | +1 I have been also doing the similar ways | 15:45 |
| fungi | so while it does make the role of the official quite necessary still, it at least means you no longer need to run those commands yourself and can rely on the ci jobs to do the search for you. but yes don't assume that just because the job succeeded that means it actually returned any results | 15:48 |
| fungi | i suppose one thing we *could* do is add a file filter to only run election-tox-ci-checks-review when files under the candidates directory are added/modified, so in this case there would have been no election-tox-ci-checks-review run at all which might have made it more obvious | 15:49 |
| fungi | though we'd need to update that file filter every cycle if we wanted to make sure it didn't run in cases where the nomination got added to the wrong (or perhaps a nonexistent) cycle name | 15:51 |
| ianychoi[m] | Yeah, alternatively just printing file name to ensure that "one filepath was detected" would be also helpful | 15:55 |
| fungi | well, it does that when it validates the filename is an e-mail address | 15:56 |
| ianychoi[m] | I thought this for loop was not executed https://opendev.org/openstack/election/src/branch/master/openstack_election/cmds/ci_check_all_candidate_files.py#L139 | 15:57 |
| fungi | depends on which job runs, i think? | 15:58 |
| ianychoi[m] | Yep exactly let me more look at the file after sleep.. :) | 16:00 |
| fungi | oh, you're suggesting it should print a warning in the log that there was no candidate file processed? | 16:01 |
| ianychoi[m] | Yes something like (not should, just suggestion instead) | 16:01 |
| fungi | that might help make it more obvious to someone casually looking at the log that there's a problem | 16:01 |
| fungi | but yeah, this isn't urgent, just a reminder that officials should be looking at the output from that job to make sure it found a valid candidate in the change being reviewed | 16:02 |
| ianychoi[m] | +1 thank you fungi for your deep looking on this! | 16:03 |
| fungi | (or running an equivalent command locally, or researching the candidate manually if they prefer) | 16:03 |
| fungi | any time, it's my pleasure, glad to be of help | 16:03 |
| ianychoi[m] | Thanks a lot | 16:03 |
| opendevreview | Douglas Mendizábal proposed openstack/election master: Add Barbican PTL candidacy for Yoga cycle https://review.opendev.org/c/openstack/election/+/805063 | 16:59 |
| opendevreview | Douglas Mendizábal proposed openstack/election master: Adding Douglas Mendizábal candidacy for Barbican https://review.opendev.org/c/openstack/election/+/805063 | 17:00 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!