*** mickeys has joined #openstack-fwaas | 00:54 | |
*** mickeys has quit IRC | 01:00 | |
*** mickeys has joined #openstack-fwaas | 01:00 | |
*** mickeys has quit IRC | 02:01 | |
*** yamamoto_ has joined #openstack-fwaas | 02:05 | |
*** SarathMekala has joined #openstack-fwaas | 03:08 | |
*** vishwanathj has joined #openstack-fwaas | 03:28 | |
*** vishwanathj has quit IRC | 04:11 | |
*** chandanc_ has joined #openstack-fwaas | 04:45 | |
*** SarathMekala has quit IRC | 06:12 | |
*** SarathMekala has joined #openstack-fwaas | 06:15 | |
*** mickeys has joined #openstack-fwaas | 06:21 | |
*** mickeys has quit IRC | 06:21 | |
*** SarathMekala has quit IRC | 07:06 | |
*** SarathMekala has joined #openstack-fwaas | 07:08 | |
*** SarathMekala has quit IRC | 07:32 | |
*** mickeys has joined #openstack-fwaas | 07:56 | |
*** yushiro has joined #openstack-fwaas | 07:57 | |
*** chandanc_ has quit IRC | 07:57 | |
*** mickeys has quit IRC | 08:05 | |
*** yamamoto_ has quit IRC | 08:17 | |
*** yamamoto_ has joined #openstack-fwaas | 08:18 | |
*** yamamoto_ has quit IRC | 08:23 | |
*** SarathMekala has joined #openstack-fwaas | 08:42 | |
*** chandanc_ has joined #openstack-fwaas | 09:00 | |
*** yamamoto has joined #openstack-fwaas | 09:26 | |
*** yushiro has quit IRC | 09:49 | |
*** chandanc_ has quit IRC | 11:02 | |
*** SarathMekala has quit IRC | 11:03 | |
*** njohnston has quit IRC | 11:16 | |
*** afranc has quit IRC | 11:17 | |
*** njohnston has joined #openstack-fwaas | 11:18 | |
*** afranc has joined #openstack-fwaas | 11:18 | |
*** openstackstatus has quit IRC | 11:36 | |
*** openstackstatus has joined #openstack-fwaas | 11:37 | |
*** ChanServ sets mode: +v openstackstatus | 11:37 | |
*** chandanc_ has joined #openstack-fwaas | 12:39 | |
njohnston | Good Monday, everyone. | 13:37 |
---|---|---|
*** vishwanathj has joined #openstack-fwaas | 13:44 | |
SridarK | hi all GM | 13:55 |
SridarK | njohnston: just catching up on email | 13:56 |
SridarK | njohnston: saw the revert patch for db due to migration issues | 13:56 |
njohnston | se ended up fixing it instead | 13:57 |
njohnston | s/se/we/ | 13:57 |
njohnston | That patch should be marked as abandoned | 13:57 |
njohnston | (as long as we're talking about the same thing - if not then it's something I am not aware of) | 13:58 |
SridarK | njohnston: https://review.openstack.org/#/c/358541/ | 13:58 |
SridarK | njohnston: was just abt to ask if we can triage - to fix instead of revert | 13:59 |
njohnston | This is news to me | 13:59 |
njohnston | yamamoto: Can you give us some detail on the db migration issues you are seeing? | 13:59 |
yamamoto | njohnston: hi | 14:01 |
yamamoto | isn't bugs referenced by the change enough? | 14:01 |
SridarK | yamamoto: thx looking | 14:03 |
SridarK | yamamoto: would u be ok if we were to get a fix in instead of revert | 14:03 |
yamamoto | njohnston: it's blocking networking-midonet gate badly so i prefere quick revert and later fix | 14:03 |
njohnston | yamamoto: Sorry, you're right. I am looking at the details of the bugs now. | 14:04 |
njohnston | I'm not sure how we got onto a separate branch, that is distressing. | 14:04 |
SridarK | sigh yes | 14:06 |
yamamoto | SridarK: of course it's fine for me if you can fix it quickly. (well, it depends on how quickly, as it's blocking gate) | 14:06 |
SridarK | yamamoto: sorry did not realize the impact on midonet - | 14:06 |
SridarK | yamamoto: could we triage this quickly together - as we did not realize any issue with the fwaas gate | 14:07 |
SridarK | if it is a sync btwn the model and migration script | 14:07 |
yamamoto | SridarK: no problem. i feel it's partly networking-midonet's fault. it has too many involving projects for its voting jobs. | 14:07 |
SridarK | yamamoto: thx for ur understanding - we are running tight on fwaas with the Newton deadline | 14:08 |
njohnston | yamamoto: Agreed - I think it might be a good move to also remove fwaas from the midonet jobs, unless & until there is someone who has the resources to ensure such an integration works well. | 14:08 |
njohnston | Because nobody on the FWaaS team works in the midonet space as afr as I can tell. | 14:08 |
SridarK | yamamoto: how would we ensure that the fix will not break midonet | 14:08 |
yamamoto | njohnston: sure, but it's my job to maintain the integration. so early notice is good thing. probabaly it should be non-voting though. | 14:09 |
SridarK | njohnston: one thing i see quickly, https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/db/migration/alembic_migrations/versions/d6a12e637e28_neutron_fwaas_v2_0.py | 14:10 |
SridarK | L#19 - we revise kilo | 14:11 |
SridarK | also lets quickly sync on the model vs migration | 14:11 |
yamamoto | SridarK: currently the easiest way is to have a patch on networking-midonet with Depends-On. | 14:12 |
yamamoto | 3rd party ci has always been on our (midonet's) todo list. :-) | 14:13 |
SridarK | yamamoto: ok | 14:13 |
yamamoto | SridarK: regardless of midonet, the most (all?) of these issues would have been found if we have https://review.openstack.org/#/c/357028/ | 14:15 |
yamamoto | thus my suggestion to revert it and merge the test and retry. | 14:15 |
SridarK | yamamoto: ok - if this is a quick enough fix we can get that in as well as 357028 | 14:17 |
yamamoto | it's time to go bed for me. later. good luck :-) | 14:18 |
SridarK | yamamoto: thx - sorry i just woke up so trying to understand still | 14:20 |
SridarK | yamamoto: but we will work on this | 14:20 |
njohnston | I am trying to run the test in 357028 to make sure we can use it to debug this issue | 14:20 |
SridarK | njohnston: ok perfect | 14:21 |
SridarK | njohnston: let me get some caffeine and be right back, we can get on a call to triage together as well | 14:21 |
SridarK | if needed | 14:21 |
njohnston | SridarK: Sounds good | 14:30 |
SridarK | njohnston: back | 14:37 |
*** SarathMekala has joined #openstack-fwaas | 14:42 | |
njohnston | SridarK: Conversing with HenryG in #openstack-neutron | 14:43 |
SridarK | njohnston: ok | 14:43 |
njohnston | I'll get a change up with the minor fixes and let's see if he can help us get this working | 14:43 |
SridarK | njohnston: ok i am getting on there too | 14:44 |
SridarK | njohnston: yes i think it is some minor tweaks | 14:44 |
*** yamamoto has quit IRC | 14:52 | |
*** vishwanathj has quit IRC | 14:53 | |
*** vishwanathj has joined #openstack-fwaas | 14:53 | |
SridarK | njohnston: one thing to pick up also will be - on both colums in FirewallGroupPortAssociation - we will need a ondelete="CASCADE" | 15:10 |
SridarK | njohnston: esp with port_id since it is extenal to fwaas. Just wanted to add that. | 15:11 |
njohnston | ok | 15:12 |
*** SarathMekala has quit IRC | 15:12 | |
*** SarathMekala has joined #openstack-fwaas | 15:42 | |
njohnston | SridarK: Check out https://review.openstack.org/358728 but wait to approve until the Jenkins jobs come back | 15:51 |
SridarK | njohnston: ok looking | 15:51 |
njohnston | I am getting a weird issue when running tests: "AttributeError: 'String' object has no attribute '_set_parent_with_dispatch'" | 15:52 |
*** yamamoto has joined #openstack-fwaas | 15:54 | |
SridarK | njohnston: just finishing up on a mtg - give me a few mins | 15:57 |
*** chandanc_ has quit IRC | 15:57 | |
njohnston | thanks! | 15:57 |
*** chandanc_ has joined #openstack-fwaas | 15:58 | |
*** yamamoto has quit IRC | 16:02 | |
*** SarathMekala has quit IRC | 16:03 | |
*** chandanc_ has quit IRC | 16:22 | |
SridarK | njohnston: back | 16:25 |
*** mickeys has joined #openstack-fwaas | 16:34 | |
njohnston | OK, DB fix change looks ready to go: https://review.openstack.org/358728 | 16:51 |
njohnston | xgerman: I put those FK constraints back in. They had bedeviled me all morning, but I finally figured them out. | 17:12 |
xgerman | NICE!!! | 17:12 |
*** SridarK has quit IRC | 17:35 | |
njohnston | biab | 17:50 |
njohnston | back | 18:16 |
*** SridarK has joined #openstack-fwaas | 18:18 | |
*** mickeys has quit IRC | 18:46 | |
njohnston | SridarK and xgerman: Zuul came back +1 for https://review.openstack.org/#/c/358728/ | 18:57 |
xgerman | done, sridark can +A | 18:58 |
SridarK | Done | 18:58 |
SridarK | thx njohnston: for getting on this quickly | 18:58 |
xgerman | +1 | 18:58 |
SridarK | we can confirm with yamamoto to ensure that his issues are resoloved | 18:59 |
SridarK | when he is back online | 18:59 |
njohnston | Any time, glad to know there is this model/migration script! I tried looking at how to create a new gate job to run the model/migration tasks, but it made my brain go on strike, so I'll get back to that some other time. | 19:00 |
SridarK | njohnston: i am with u on that, i think we may not be touching this area too much now, right away | 19:29 |
njohnston | SridarK: How goes it with those last couple UTs for the driver? | 19:29 |
SridarK | njohnston: i think i need at least one more | 19:30 |
SridarK | will get a change out soon | 19:30 |
SridarK | njohnston: u meant the plugin correct ? | 19:32 |
njohnston | yes, sorry, I say the driver but I mean the plugin :-/ | 19:33 |
SridarK | njohnston: no worries - today has started with a roller coaster :-) | 19:35 |
*** mickeys has joined #openstack-fwaas | 19:47 | |
*** mickeys has quit IRC | 19:52 | |
*** mickeys has joined #openstack-fwaas | 20:09 | |
*** yamamoto has joined #openstack-fwaas | 21:50 | |
*** yamamoto has quit IRC | 21:51 | |
*** yamamoto has joined #openstack-fwaas | 22:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!