| *** yushiro has joined #openstack-fwaas | 00:08 | |
| *** SridarK has quit IRC | 01:08 | |
| yushiro | ping njohnston | 01:50 |
|---|---|---|
| njohnston | pong yushiro | 01:50 |
| yushiro | njohnston, Thanks for your review with plugin patch. Currently, I try to build devstack in my local env. I'll put +A after reviewing. | 01:52 |
| yushiro | I wanted to test for it but I didn't have bandwitdh yesterday :( | 01:53 |
| njohnston | yushiro: Sounds good! After that there are a couple of additional fixes for the DB migrations, if you could take a look at them for yamamoto then we can fix the issues we are causing in the midonet gate as well. | 01:53 |
| njohnston | So after the plugin if you could look at https://review.openstack.org/#/c/358913 https://review.openstack.org/#/c/358914 and https://review.openstack.org/#/c/358915 that will be very helpful. Thanks! | 01:54 |
| njohnston | (they are all very small) | 01:55 |
| yushiro | njohnston: Yes. ah, it fixes revision number of migration file. OK, I'll take a look ASAP. | 01:56 |
| njohnston | and they have all passed their voting tests, all that is left is "gate-neutron-fwaas-dsvm-tempest (non-voting)" to finish and then Jenkins will +1 | 01:56 |
| yushiro | njohnston: I see. | 01:56 |
| yamamoto | read this comment in case if you are not sure how to run migration tests https://github.com/openstack/neutron/blob/master/neutron/tests/functional/db/test_migrations.py#L62 | 02:02 |
| yushiro | yamamoto: thanks | 02:04 |
| yushiro | yamamoto: I'll try it | 02:04 |
| njohnston | yushiro: Quick question, is https://review.openstack.org/#/c/251140/ still a change we need? | 02:16 |
| yushiro | njohnston: just a moment | 02:17 |
| *** mickeys has quit IRC | 02:18 | |
| yushiro | njohnston: I think it's necessary for v1 but it's pending now. | 02:18 |
| yushiro | Currently, I was mentioned 'the code is very ugly' from reviewer. | 02:19 |
| njohnston | I think it's not bad :-) | 02:21 |
| yushiro | njohnston: Thanks for your kindness :) Reedip also reviewed and put +1 for me. | 02:22 |
| yushiro | njohnston: sorry. I cannot answer your question about https://review.openstack.org/251140 . Just a rebase is necessary for this patch :) | 02:37 |
| yushiro | thanks for your review. | 02:38 |
| njohnston | I don;t think it's a bad idea - there are still people out there using fwaas v1, and I am all in favor of doing the right thing for them. | 02:38 |
| yushiro | njohnston: I agree with you and I'm glad our efforts paid off in this time. | 02:42 |
| *** yushiro is now known as yushiro_lunch | 03:00 | |
| *** SarathMekala has joined #openstack-fwaas | 03:31 | |
| *** yushiro_lunch has quit IRC | 03:41 | |
| *** yushiro has joined #openstack-fwaas | 03:58 | |
| yushiro | njohnston: Hi, chandan has just commented on plugin patch. I think it's a nit bug. Could you check it, please? | 04:33 |
| yushiro | link: https://review.openstack.org/#/c/267046/10/neutron_fwaas/db/firewall/v2/firewall_db_v2.py | 04:33 |
| *** chandanc_ has joined #openstack-fwaas | 04:34 | |
| yushiro | Hi chandanc_ thanks for your comment on plugin patch. | 04:35 |
| chandanc_ | sure, happy to help :) | 04:36 |
| yushiro | OK. Sridar fixed so quickly. | 04:41 |
| chandanc_ | can anyone explain how this works? where it is used ? https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L115 | 04:55 |
| yushiro | chandanc_: I'm not expert of sqlalchemy, but this relation is typical one('One to Many'). I think you can refer as follows. | 05:08 |
| yushiro | http://docs.sqlalchemy.org/en/latest/orm/basic_relationships.html#one-to-many | 05:08 |
| *** chandanc_ has quit IRC | 05:10 | |
| *** SarathMekala has quit IRC | 05:10 | |
| *** chandanc_ has joined #openstack-fwaas | 05:12 | |
| *** vishwanathj has quit IRC | 05:17 | |
| *** SarathMekala has joined #openstack-fwaas | 05:23 | |
| *** vishwanathj has joined #openstack-fwaas | 05:55 | |
| *** chandanc_ has quit IRC | 05:57 | |
| *** chandanc_ has joined #openstack-fwaas | 05:57 | |
| *** vishwanathj is now known as vishwanathj_zzz | 06:24 | |
| yushiro | ping mfranc213 | 06:28 |
| *** yamamoto has quit IRC | 07:38 | |
| *** yamamoto has joined #openstack-fwaas | 08:16 | |
| yushiro | ping yamamoto | 08:18 |
| yamamoto | yushiro: pong | 08:18 |
| yushiro | yamamoto: I tried to check your patch for migration by using following hints: | 08:20 |
| yushiro | https://github.com/openstack/neutron/blob/master/neutron/tests/functional/db/test_migrations.py#L62 | 08:20 |
| yushiro | yamamoto: Would you tell me how to execute after setup DB? | 08:21 |
| yushiro | I installed postgresql in my env and set up DB named 'openstack_citest'. | 08:21 |
| yamamoto | tox -e functional | 08:23 |
| yushiro | yamamoto: ah, thanks. I specified neutron.tests.functional.db.test_migrations | 08:24 |
| *** yamamoto has quit IRC | 08:40 | |
| *** mickeys has joined #openstack-fwaas | 08:40 | |
| yushiro | 08:42 | |
| *** mickeys has quit IRC | 08:43 | |
| *** yamamoto has joined #openstack-fwaas | 08:48 | |
| yushiro | njohnston: I've tried to check yamamoto's patch for DB migration but the migration for fwaas haven't tested.. | 08:59 |
| yushiro | njohnston: However, you've already checked and put +2. Therefore, I think it's OK to put +2 for me. | 09:01 |
| yushiro | yamamoto: hi, please let me check the environment how to test your DB patch again. | 09:02 |
| yushiro | yamamoto: I tried testing but fwaas migration files weren't tested. | 09:03 |
| *** chandanc_ has quit IRC | 09:05 | |
| *** chandanc_ has joined #openstack-fwaas | 09:05 | |
| yushiro | yamamoto: Is it necessary some options to test 'tox -e functional' ?? | 09:06 |
| yushiro | with fwaas | 09:06 |
| *** chandanc_ has quit IRC | 09:17 | |
| *** chandanc_ has joined #openstack-fwaas | 09:20 | |
| *** yushiro has quit IRC | 09:27 | |
| *** SarathMekala has quit IRC | 10:59 | |
| *** chandanc_ has quit IRC | 11:02 | |
| *** chandanc_ has joined #openstack-fwaas | 12:51 | |
| *** vishwanathj_zzz is now known as vishwanathj | 12:57 | |
| njohnston | chandanc_: I am wondering if there is anything I can do to help you progress with https://review.openstack.org/#/c/333338/ | 12:58 |
| njohnston | I am worried it is not going to make it | 12:58 |
| chandanc_ | I was not able to get any comments on both the patches from Kevin Benton, do you know anyone else who can help with the review ? | 13:00 |
| njohnston | Someone else who knows about SG code? Hmm, I don't know who else would be a good person to ask. sc68cal, can you recommend someone else to take a look at a refactor of some SG code in Neutron? | 13:11 |
| sc68cal | what part/ | 13:12 |
| chandanc_ | sure I can add sc68cal to the list of reviewers | 13:12 |
| njohnston | sc68cal: https://review.openstack.org/#/c/333338/ Thanks! | 13:12 |
| njohnston | sc68cal: https://review.openstack.org/#/c/348177/ also along the same lines | 13:13 |
| sc68cal | k, I don't have a lot of bandwidth to review. Also we're coming up on the third milestone soon? risky change for this late in the cycle | 13:18 |
| njohnston | Well, setting aside the schedule and rick parts of this - it's not in any shape to merge at the moment, and the schedule is no't something we can control anyway - who would be a good person to work with for reviews on this, who'd be knowledgeable about SG/iptables parts of the neutron codebase? chandanc_ has been trying to hail kevinbenton to no avail. | 13:21 |
| njohnston | s/rick/risk/ | 13:21 |
| *** SridarK has joined #openstack-fwaas | 13:37 | |
| *** chandanc_ is now known as chandanc_afk | 14:34 | |
| *** davidlenwell has quit IRC | 14:36 | |
| *** davidlenwell has joined #openstack-fwaas | 14:37 | |
| *** chandanc_afk has quit IRC | 14:38 | |
| *** yamamoto has quit IRC | 14:57 | |
| *** yamamoto has joined #openstack-fwaas | 15:01 | |
| xgerman | njohnston I think they have a Neutron mid cycle right now… so maybe they can make that a topic | 15:03 |
| njohnston | xgerman: The midcycle was last week, the 17th-19th: https://etherpad.openstack.org/p/newton-neutron-midcycle | 15:04 |
| xgerman | yeah, I am not up-to-date any longer | 15:04 |
| *** yamamoto has quit IRC | 15:06 | |
| *** davidlenwell has quit IRC | 15:27 | |
| *** yamamoto has joined #openstack-fwaas | 15:31 | |
| *** yamamoto has quit IRC | 15:32 | |
| *** yamamoto has joined #openstack-fwaas | 15:33 | |
| *** yamamoto has quit IRC | 15:33 | |
| *** davidlenwell has joined #openstack-fwaas | 15:40 | |
| *** vishwanathj_ has joined #openstack-fwaas | 16:03 | |
| *** yamamoto has joined #openstack-fwaas | 16:33 | |
| *** yamamoto has quit IRC | 16:41 | |
| *** mickeys has joined #openstack-fwaas | 17:00 | |
| *** SridarK has quit IRC | 17:08 | |
| *** chandanc_ has joined #openstack-fwaas | 17:12 | |
| *** chandanc_ has quit IRC | 17:27 | |
| *** chandanc__ has joined #openstack-fwaas | 17:27 | |
| *** SridarK has joined #openstack-fwaas | 18:05 | |
| *** chandanc_ has joined #openstack-fwaas | 18:16 | |
| *** chandanc__ has quit IRC | 18:19 | |
| *** vishwanathj_ has quit IRC | 18:26 | |
| *** mickeys has quit IRC | 18:35 | |
| *** chandanc_ has quit IRC | 18:49 | |
| njohnston | SridarK: So I think the real problem we are seeing in http://logs.openstack.org/99/337699/22/check/gate-neutron-fwaas-python35/e981ee2/testr_results.html.gz is that the patch breaks FWaaS v1; all of the failing tests are all v1 tests, and their v2 equivalents all succeed. | 20:12 |
| njohnston | OK, I fixed that... let's see how it fares with Jenkins. | 20:18 |
| njohnston | SridarK and xgerman: Do cores need to approve "Updated from global requirements" type changes like https://review.openstack.org/#/c/354524/ and if so, what kind of testing/validation do you usually do? | 20:26 |
| xgerman | yep | 20:27 |
| xgerman | njohnston on to you for +A | 20:27 |
| xgerman | I usually rely on jenkins | 20:28 |
| njohnston | OK, so for us approval is basically a no-op once tests pass? | 20:28 |
| xgerman | but some global req updates can break your code | 20:28 |
| njohnston | right... the trouble is, what do you do first to pick up on that, if the tests didn't pick up on it | 20:28 |
| xgerman | yeah, it’s a no-op unless it’s an error you are worried about (e.g. neutron-lib) | 20:28 |
| xgerman | area | 20:28 |
| xgerman | well, it usually breaks the build ;-) | 20:29 |
| njohnston | yep, makes sense | 20:29 |
| njohnston | thanks! | 20:29 |
| SridarK | njohnston: ok on the UT fix - yes it was all v1 - | 21:22 |
| njohnston | YEP, ZUUL IS ALMOST DONE GIVING IT A +1 | 21:23 |
| njohnston | oops caps lock | 21:23 |
| SridarK | njohnston: :-) ok sigh | 21:23 |
| SridarK | i will continue on with devstack | 21:23 |
| njohnston | My fingers are crossed that https://review.openstack.org/#/c/357503/ will also pass - that is the L3 extension agent api object patch. Last time everything passed but gate-tempest-dsvm-neutron-dvr, which looked like it was hit with a transient issue. | 21:35 |
| *** mickeys has joined #openstack-fwaas | 22:50 | |
| *** yamamoto has joined #openstack-fwaas | 22:51 | |
| *** padkrish has joined #openstack-fwaas | 23:14 | |
| padkrish | mfranc213# ping | 23:17 |
| *** padkrish has quit IRC | 23:46 | |
| *** padkrish has joined #openstack-fwaas | 23:47 | |
| *** padkrish has quit IRC | 23:53 | |
| *** yushiro has joined #openstack-fwaas | 23:56 | |
| yushiro | morning, SridarK and njohnston. Thanks for your review about db migrations. | 23:56 |
| yushiro | Yesterday, I couldn't build devstack env due to my VM's condition. | 23:58 |
| yushiro | Thank you. | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!