*** reedip_ has joined #openstack-fwaas | 00:23 | |
openstackgerrit | Merged openstack/neutron-fwaas master: Updated from global requirements https://review.openstack.org/483370 | 00:32 |
---|---|---|
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Handle rehome of firewall exceptions https://review.openstack.org/478363 | 00:42 |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Handle rehome of firewall exceptions https://review.openstack.org/478363 | 00:51 |
*** yamamoto has joined #openstack-fwaas | 00:56 | |
*** reedip_ has quit IRC | 01:05 | |
*** yamamoto has quit IRC | 01:05 | |
*** yamamoto has joined #openstack-fwaas | 01:06 | |
*** yamamoto has quit IRC | 01:18 | |
*** yamamoto has joined #openstack-fwaas | 01:19 | |
*** yamamoto has quit IRC | 01:24 | |
*** yamamoto has joined #openstack-fwaas | 01:32 | |
*** yamamoto has quit IRC | 01:35 | |
*** yamamoto has joined #openstack-fwaas | 01:41 | |
*** yamamoto has quit IRC | 01:44 | |
*** yamamoto has joined #openstack-fwaas | 01:45 | |
*** yamamoto has quit IRC | 01:47 | |
*** yamamoto has joined #openstack-fwaas | 01:49 | |
*** yamamoto has quit IRC | 01:50 | |
*** yamamoto has joined #openstack-fwaas | 01:52 | |
*** yamamoto has quit IRC | 01:54 | |
*** yamamoto has joined #openstack-fwaas | 02:13 | |
*** yamamoto has quit IRC | 02:13 | |
*** yamamoto has joined #openstack-fwaas | 02:22 | |
*** yamamoto has quit IRC | 02:29 | |
*** yamamoto has joined #openstack-fwaas | 02:34 | |
*** yamamoto has quit IRC | 02:36 | |
*** yamamoto has joined #openstack-fwaas | 02:40 | |
*** yamamoto has quit IRC | 02:41 | |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Handle rehome of firewall exceptions https://review.openstack.org/478363 | 03:05 |
openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas master: Update the documentation link for doc migration https://review.openstack.org/485423 | 03:39 |
*** vishwanathj has quit IRC | 03:52 | |
*** Tim_Eberhard has quit IRC | 03:55 | |
*** Tim_Eberhard has joined #openstack-fwaas | 03:55 | |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Handle rehome of firewall exceptions https://review.openstack.org/478363 | 04:20 |
*** yamamoto has joined #openstack-fwaas | 04:59 | |
reedip | SridarK_ , xgerman_ awake ? | 05:18 |
SridarK_ | reedip: hi | 05:19 |
reedip | hello , https://review.openstack.org/478363 passed the voting tests .. can you review it if possible ? | 05:19 |
reedip | I would like to get it merged soon so that the neutron-lib migration can be done | 05:20 |
SridarK_ | reedip: yes will do | 05:20 |
reedip | s/done/started | 05:20 |
reedip | thanks | 05:20 |
reedip | :) | 05:20 |
SridarK_ | yes agree - it will be good to get that in asap | 05:20 |
SridarK_ | reedip: u had a tenant_id to project_id change in there too | 05:25 |
reedip | SridarK_ yep .. the same changes were done in neutron-lib | 05:26 |
SridarK_ | ok we changed the arg | 05:26 |
reedip | its only in the exception messages | 05:26 |
SridarK_ | yes got it | 05:26 |
*** yamamoto has quit IRC | 05:31 | |
*** Tim_Eberhard has quit IRC | 05:32 | |
SridarK_ | reedip: looks good to me | 05:43 |
SridarK_ | reedip: oh good yushiro has also reviewed | 05:44 |
reedip | ok :) | 05:48 |
reedip | gr8 | 05:48 |
reedip | Once that merges, I can push the other patch for migration and then we would be on track | 05:49 |
SridarK_ | reedip: perfect thx | 05:57 |
*** yamamoto has joined #openstack-fwaas | 06:05 | |
*** yamamoto has quit IRC | 06:23 | |
openstackgerrit | Merged openstack/neutron-fwaas master: Handle rehome of firewall exceptions https://review.openstack.org/478363 | 06:59 |
openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas master: Update the documentation link for doc migration https://review.openstack.org/485423 | 07:15 |
*** yamamoto has joined #openstack-fwaas | 07:16 | |
*** yamamoto has quit IRC | 07:25 | |
*** Tim_Eberhard has joined #openstack-fwaas | 07:32 | |
*** Tim_Eberhard has quit IRC | 07:36 | |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 07:40 |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 08:40 |
*** trungnv has quit IRC | 09:44 | |
*** bzhao has joined #openstack-fwaas | 09:55 | |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 09:57 |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 10:13 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas-dashboard master: Updated from global requirements https://review.openstack.org/485619 | 13:18 |
*** yamamoto has joined #openstack-fwaas | 13:39 | |
*** yamamoto has quit IRC | 13:50 | |
*** SridarK_ has quit IRC | 14:28 | |
*** yamamoto has joined #openstack-fwaas | 14:37 | |
*** vishwanathj has joined #openstack-fwaas | 14:47 | |
*** bbzhao has joined #openstack-fwaas | 14:48 | |
*** bzhao has quit IRC | 14:51 | |
*** yamamoto has quit IRC | 14:55 | |
*** yamamoto has joined #openstack-fwaas | 14:57 | |
*** yamamoto has quit IRC | 15:03 | |
*** Tim_Eberhard has joined #openstack-fwaas | 15:17 | |
*** reedip_ has joined #openstack-fwaas | 15:31 | |
openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Updated from global requirements https://review.openstack.org/485619 | 17:18 |
*** SridarK has joined #openstack-fwaas | 17:32 | |
*** reedip_ has quit IRC | 17:39 | |
*** reedip_ has joined #openstack-fwaas | 17:49 | |
reedip_ | xgerman_ : there ? | 17:54 |
xgerman_ | yes | 17:54 |
reedip_ | I am not able to resolve one problem in one of my patches | 17:55 |
reedip_ | Need your help xgerman_ | 17:55 |
xgerman_ | ok, link? | 17:55 |
reedip_ | xgerman_ : http://logs.openstack.org/83/478883/8/check/gate-neutron-fwaas-python27-ubuntu-xenial/c255216/console.html#_2017-07-20_10_19_42_046669 | 17:56 |
reedip_ | The issue is arising because of https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/extensions.py#L191 | 17:57 |
reedip_ | The api_definition is _UNSET | 17:57 |
reedip_ | xgerman_ : but this seems to originate from l3.py extension | 17:57 |
reedip_ | and not from fwaas/fwaas_v2 | 17:58 |
reedip_ | need your inputs | 17:58 |
xgerman_ | makes sense it crashed when checking extensions | 17:58 |
xgerman_ | so we piggy back on the neutron tests and load their extensions | 17:59 |
reedip_ | but l3.py doesnt use APIExtensionDescriptor Class | 17:59 |
xgerman_ | reedip_ I will see if I can replicate the error in my local environment — will take a while | 18:11 |
reedip_ | jut checkout https://review.openstack.org/#/c/478883/ | 18:11 |
reedip_ | and run | 18:11 |
reedip_ | tox -v -e py27 py27 neutron_fwaas.tests.unit.services.firewall.test_fwaas_plugin.TestFirewallPluginBase.test_update_firewall_fails_when_firewall_pending | 18:11 |
reedip_ | its already 12 here so m going off as is... | 18:12 |
reedip_ | thanks a lot :) | 18:12 |
xgerman_ | ok, will put in the channel when I find soemthing | 18:16 |
reedip_ | makes sense .. thanks | 18:22 |
*** reedip_ has quit IRC | 19:02 | |
*** openstack has joined #openstack-fwaas | 19:58 | |
*** openstackgerrit has quit IRC | 20:17 | |
*** SridarK has quit IRC | 21:37 | |
*** yamamoto has joined #openstack-fwaas | 21:57 | |
*** yamamoto has quit IRC | 22:00 | |
*** vishwanathj has quit IRC | 22:26 | |
*** vishwanathj has joined #openstack-fwaas | 22:26 | |
*** vishwana_ has joined #openstack-fwaas | 22:32 | |
*** vishwanathj has quit IRC | 22:34 | |
*** yamamoto has joined #openstack-fwaas | 23:01 | |
*** Tim_Eberhard has quit IRC | 23:01 | |
*** Tim_Eberhard has joined #openstack-fwaas | 23:02 | |
*** Tim_Eberhard has quit IRC | 23:06 | |
*** yamamoto has quit IRC | 23:07 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!