| *** yamamoto has joined #openstack-fwaas | 00:03 | |
| *** yamamoto has quit IRC | 00:08 | |
| *** trungnv has joined #openstack-fwaas | 00:57 | |
| *** vishwanathj has joined #openstack-fwaas | 01:12 | |
| *** vishwana_ has quit IRC | 01:12 | |
| xgerman_ | https://www.irccloud.com/pastebin/jMteDoSb/ | 01:14 |
|---|---|---|
| xgerman_ | Mine are failing with a missing AF_Br[idge | 01:15 |
| *** yushiro has joined #openstack-fwaas | 01:39 | |
| *** yamamoto has joined #openstack-fwaas | 02:36 | |
| reedip | xgerman_ : Looking at the paste | 02:58 |
| reedip | yushiro : hi | 02:59 |
| reedip | xgerman_ : that seems to be a different issue, because in your case the tests arent getting executed.. seems like some requirement issue | 03:00 |
| yushiro | reedip, hi | 03:01 |
| yushiro | reedip, sorry. I'll go for lunch now. will back 1 hour later :) | 03:01 |
| *** yushiro is now known as yushiro_lunch | 03:01 | |
| reedip | ok :) | 03:02 |
| *** yamamoto has quit IRC | 03:08 | |
| *** yushiro_lunch is now known as yushiro | 04:02 | |
| yushiro | reedip, https://review.openstack.org/#/c/478883/ sorry for confusing. I just remove -1 now. | 04:06 |
| reedip | yushiro : the failure is occuring becuase of the get_required_extensions and get_optional_extensions is not defined, it seems | 04:18 |
| yushiro | reedip, https://github.com/openstack/neutron/search?utf8=%E2%9C%93&q=get_required_extensions&type= | 04:19 |
| yushiro | reedip, OK | 04:19 |
| yushiro | good catch! | 04:19 |
| reedip | runnin the new tests now | 04:22 |
| *** yamamoto has joined #openstack-fwaas | 04:39 | |
| reedip | yushiro : tests work fine | 04:43 |
| reedip | now need to check how midonet responds | 04:43 |
| *** openstackgerrit has joined #openstack-fwaas | 04:44 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 04:44 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 04:45 |
| *** yamamoto has quit IRC | 04:48 | |
| *** yamamoto has joined #openstack-fwaas | 04:51 | |
| reedip | yamamoto : I am testing the changes in the new patch | 04:53 |
| reedip | yamamoto : I removed the @classmethod for Name, Alias, Description and Updated time in firewall, firewall_v2 and firewallrouterinsertion extensions | 04:53 |
| reedip | yamamoto : but py27 is failing to find the extensions now.... so rechecking | 04:54 |
| reedip | yamamoto : these tests run fine when these values are specified in the extension file | 04:54 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 04:56 |
| reedip | yamamoto : tests ran fine when the classmethods have been removed from firewall and firewall_V2 , but fail when removed from fwaasrouterinsertion ^^ | 04:57 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 05:04 |
| yamamoto | reedip: why does it fail? | 05:08 |
| *** yamamoto has quit IRC | 05:15 | |
| reedip | yamamoto : it could find the fwaasrouterinsertion extension | 05:16 |
| reedip | yamamoto : also , if we remove the get_optional_extensions or get_required_extensions , then py27 complains that the API extension is not defiend | 05:19 |
| yushiro | OK, let's wait until PS12 will finish. | 05:39 |
| reedip | yushiro : the tests are running properly in my system, but fails as per zuul :( | 05:40 |
| reedip | can you check it once ? midonet also fails due to similar error | 05:40 |
| reedip | i need a break .. | 05:42 |
| yushiro | please take a seat and have a break :) | 06:23 |
| *** jhesketh has quit IRC | 06:35 | |
| *** jhesketh has joined #openstack-fwaas | 06:35 | |
| yushiro | reedip, Can I update your patch? | 06:39 |
| reedip | yeah sure , thanks | 06:40 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 06:43 |
| yushiro | I just reflected yamamoto's comment. | 06:43 |
| yushiro | I think his comment for PS12 is not only firewall but also firewall_v2 and firewallrouterinsertion. | 06:43 |
| *** trungnv has quit IRC | 07:12 | |
| reedip | yushiro : as stated earlier, we need to revert the changes for firewallrouterinsertion. firewallrouterinsertion needs the class methods, else py27 tests fail | 07:16 |
| reedip | Reference: http://logs.openstack.org/83/478883/13/check/gate-neutron-fwaas-python27-ubuntu-xenial/e0fed81/console.html#_2017-07-21_06_50_02_424347 | 07:16 |
| *** yamamoto has joined #openstack-fwaas | 07:20 | |
| yushiro | reedip, hmm, firewallrouterinsertion also inheritted extensions.APIExtensionDescriptor. I don't know why a behavior was different.. | 07:26 |
| reedip | logs say so ... | 07:31 |
| yushiro | OK. | 07:32 |
| *** hoangcx has quit IRC | 07:37 | |
| *** yamamoto has quit IRC | 07:42 | |
| yushiro | http://logs.openstack.org/83/478883/13/check/gate-neutron-fwaas-python27-ubuntu-xenial/e0fed81/console.html#_2017-07-21_06_50_02_342414 | 08:09 |
| yushiro | WARNING [neutron.api.extensions] Extension file firewallrouterinsertion.py wasn't loaded due to Extension module API definition not set. | 08:09 |
| reedip | exactly | 08:26 |
| yushiro | aaaaa | 08:52 |
| yushiro | I found it | 08:52 |
| yushiro | api_definiton = firewallrouterinsertion | 08:52 |
| yushiro | x: api_definiton = firewallrouterinsertion | 08:52 |
| yushiro | o: api_definition = firewallrouterinsertion | 08:52 |
| yushiro | but still occurs KeyError: 'router_ids' | 08:55 |
| reedip | ??? | 09:32 |
| reedip | damn ! and it doesnt show any error ? | 09:32 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 09:46 |
| yushiro | reedip, can I update it? | 09:54 |
| yushiro | The cause was a timing to call self.addCleanup(self.restore_attribute_map) | 09:56 |
| yushiro | self.addCleanup(self.restore_attribute_map) | 09:56 |
| yushiro | removes 'router_ids' from 'firewalls' resource attribute map | 09:56 |
| yushiro | However, 'router_ids' is inserted after calling super(test_db_firewall.FirewallPluginDbTestCase, self).setUp(plugin=plugin, service_plugins=service_plugins, ext_mgr=ext_mgr) | 09:57 |
| yushiro | If your PS14 will be failed, please move self.addCleanup(self.restore_attribute_map) in neutron_fwaas/tests/unit/services/firewall/test_fwaas_plugin.py | 09:58 |
| yushiro | But I don't know why the behavior is different b/w before and after. | 10:01 |
| reedip | yushiro : shouldnt addCleanup work after the test cases fail ? | 10:03 |
| reedip | or complete | 10:03 |
| yushiro | hmm? addCleanup is called in setUp(). So, it should be called before testing. | 10:05 |
| reedip | interesting to note that fwaas_plugin_v2 doesnt have the addCleanup routing | 10:07 |
| reedip | and other thing is that py27 is still working 100% on my system ... | 10:08 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 10:13 |
| *** yamamoto_ has joined #openstack-fwaas | 10:48 | |
| *** yamamoto_ has quit IRC | 11:32 | |
| *** yamamoto has joined #openstack-fwaas | 11:52 | |
| *** yamamoto has quit IRC | 11:56 | |
| *** yamamoto has joined #openstack-fwaas | 12:42 | |
| yushiro | yamamoto, hi | 12:51 |
| *** yamamoto has quit IRC | 12:52 | |
| yushiro | I noticed that resource attribute map for firewall_rule are missing 1 converter. That's why reedip avoids to specify integer as source/destination port. | 12:52 |
| *** yamamoto has joined #openstack-fwaas | 12:52 | |
| yushiro | yamamoto, I noticed that resource attribute map for firewall_rule are missing 1 converter. That's why reedip avoids to specify integer as source/destination port. I just posted a patch into neutron-lib although deadline is over. | 12:52 |
| yushiro | yamamoto, To avoid breaking backward compatibility, I need to be merged this patch https://review.openstack.org/#/c/486133/ | 12:53 |
| yushiro | yamamoto, Is it possible to be merged in this timing? I strongly hope that.... | 12:54 |
| yamamoto | yushiro: i feel it isn't so urgent but you can ask an exception i guess | 13:08 |
| yushiro | yamamoto, https://releases.openstack.org/pike/schedule.html I thought that 21st is deadline. | 13:08 |
| yamamoto | yushiro: it seems so. if it's worth to make another release, i don't know. | 13:10 |
| yushiro | yamamoto, you commented to reedip's patch that 'i don't follow'. I thought that we should keep backward compat. That's why I post a patch into neutron-lib and need to be merged ASAP. | 13:13 |
| yamamoto | yushiro: i don't understand why "use neutron-lib definition" patch is that urgent. | 13:13 |
| yushiro | yamamoto, because we cannot handle neutron-lib with 'depends-on' tag. In addition, 'migrate API extension to neutron-lib' was one of stadium constraint. | 13:15 |
| yamamoto | yushiro: relax, i don't think fwaas will be kicked out only for that reason. :-) | 13:17 |
| yushiro | yamamoto, hmm, so, could you tell me what is the better way? I'm just confusing between you'd like to fix broken compat or not. | 13:19 |
| yushiro | s/between/whether | 13:19 |
| yamamoto | i wonder if "with-neutron-lib-master" job (something like the existing periodic job) can be useful. | 13:19 |
| yamamoto | fixing the definition in neutron-lib (as your patch does) is fine. i'm not sure if it warrants another neutron-lib release. anyway you can ask and neutron-lib folks will decide. | 13:22 |
| yamamoto | have you asked kevin etc? | 13:23 |
| openstackgerrit | melissaml proposed openstack/neutron-fwaas master: Update URLs in documents according to document migration https://review.openstack.org/483736 | 13:23 |
| *** yamamoto_ has joined #openstack-fwaas | 13:28 | |
| *** yamamoto_ has quit IRC | 13:28 | |
| *** yamamoto has quit IRC | 13:28 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 13:45 | |
| *** yamamoto has joined #openstack-fwaas | 13:47 | |
| *** vishwanathj has quit IRC | 13:50 | |
| *** vishwanathj has joined #openstack-fwaas | 13:50 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 14:19 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 14:24 |
| *** Tim_Eberhard has quit IRC | 15:12 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 15:12 | |
| *** Tim_Eberhard has quit IRC | 15:16 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Remove log translations https://review.openstack.org/479102 | 15:20 |
| *** vishwanathj has quit IRC | 15:22 | |
| *** vishwanathj has joined #openstack-fwaas | 15:23 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Remove log translations https://review.openstack.org/479102 | 15:27 |
| *** yushiro has quit IRC | 15:28 | |
| *** yamamoto has quit IRC | 15:44 | |
| *** yamamoto has joined #openstack-fwaas | 15:44 | |
| *** yamamoto has quit IRC | 15:49 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 16:10 | |
| *** reedip_ has joined #openstack-fwaas | 16:17 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 16:41 |
| *** yamamoto has joined #openstack-fwaas | 16:50 | |
| -openstackstatus- NOTICE: Restarting Gerrit for our weekly memory leak cleanup. | 17:05 | |
| *** yamamoto has quit IRC | 17:05 | |
| *** reedip_ has quit IRC | 17:08 | |
| -openstackstatus- NOTICE: docs.o.o is currently broken, we're investigating | 18:38 | |
| *** vishwana_ has joined #openstack-fwaas | 19:41 | |
| *** vishwanathj has quit IRC | 19:41 | |
| *** vishwana_ has quit IRC | 19:50 | |
| *** vishwanathj has joined #openstack-fwaas | 19:50 | |
| *** vishwanathj has quit IRC | 19:54 | |
| *** vishwanathj has joined #openstack-fwaas | 19:54 | |
| *** vishwana_ has joined #openstack-fwaas | 20:07 | |
| *** vishwanathj has quit IRC | 20:07 | |
| *** vishwana_ has quit IRC | 20:46 | |
| *** vishwanathj has joined #openstack-fwaas | 20:47 | |
| *** vishwana_ has joined #openstack-fwaas | 20:59 | |
| *** vishwanathj has quit IRC | 20:59 | |
| *** mestery has quit IRC | 21:40 | |
| *** mestery_ has joined #openstack-fwaas | 21:40 | |
| *** mestery_ is now known as mestery | 21:42 | |
| *** Tim_Eberhard has quit IRC | 21:58 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 21:59 | |
| *** Tim_Eberhard has quit IRC | 22:04 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!