*** thumpba has quit IRC | 00:02 | |
*** bpokorny has quit IRC | 00:05 | |
*** buzztroll has joined #openstack-glance | 00:08 | |
*** buzztroll has quit IRC | 00:10 | |
*** ducttape_ has quit IRC | 00:14 | |
*** ducttape_ has joined #openstack-glance | 00:14 | |
*** ducttape_ has quit IRC | 00:22 | |
*** jerrygb has joined #openstack-glance | 00:25 | |
*** jerrygb has quit IRC | 00:30 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/glance: [WIP] Testing latest u-c https://review.openstack.org/318436 | 00:31 |
---|---|---|
*** ducttape_ has joined #openstack-glance | 00:47 | |
*** markvoelker has quit IRC | 00:48 | |
openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Improving help text for swift_store_utils opts https://review.openstack.org/342485 | 01:10 |
openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Improving help text for glare loader opts. https://review.openstack.org/342254 | 01:11 |
*** thumpba has joined #openstack-glance | 01:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store: Updated from global requirements https://review.openstack.org/339887 | 01:35 |
*** ducttape_ has quit IRC | 01:38 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient: Updated from global requirements https://review.openstack.org/340048 | 01:42 |
*** ducttape_ has joined #openstack-glance | 01:44 | |
*** itlinux has quit IRC | 01:45 | |
*** ducttape_ has quit IRC | 01:49 | |
*** kfox1111 has quit IRC | 01:51 | |
*** links has joined #openstack-glance | 02:16 | |
*** sdake_ has quit IRC | 02:16 | |
*** buzztroll has joined #openstack-glance | 02:17 | |
*** ducttape_ has joined #openstack-glance | 02:28 | |
*** sdake has joined #openstack-glance | 02:31 | |
*** ducttape_ has quit IRC | 02:39 | |
*** markvoelker has joined #openstack-glance | 02:48 | |
*** zul has quit IRC | 02:54 | |
*** chlong has joined #openstack-glance | 02:56 | |
*** sdake_ has joined #openstack-glance | 02:58 | |
*** sdake has quit IRC | 03:02 | |
*** sdake_ has quit IRC | 03:05 | |
*** julim has quit IRC | 03:06 | |
*** sdake has joined #openstack-glance | 03:08 | |
*** jerrygb has joined #openstack-glance | 03:32 | |
*** links has quit IRC | 03:33 | |
*** jerrygb has quit IRC | 03:39 | |
*** ducttape_ has joined #openstack-glance | 03:40 | |
*** jerrygb has joined #openstack-glance | 03:40 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/342550 | 03:40 |
*** jerrygb has quit IRC | 03:41 | |
*** jerrygb has joined #openstack-glance | 03:41 | |
*** ducttape_ has quit IRC | 03:44 | |
*** thumpba has quit IRC | 03:58 | |
*** sdake has quit IRC | 04:05 | |
*** GB21 has joined #openstack-glance | 04:16 | |
*** GB21 has quit IRC | 04:31 | |
*** jerrygb has quit IRC | 04:34 | |
*** btully has joined #openstack-glance | 04:38 | |
*** links has joined #openstack-glance | 04:39 | |
*** ducttape_ has joined #openstack-glance | 04:40 | |
*** ducttape_ has quit IRC | 04:46 | |
*** pdeore has joined #openstack-glance | 04:47 | |
*** prateek has joined #openstack-glance | 04:53 | |
*** buzztroll has quit IRC | 04:57 | |
*** GB21 has joined #openstack-glance | 05:02 | |
*** prateek_ has joined #openstack-glance | 05:03 | |
*** prateek has quit IRC | 05:06 | |
*** ratailor has joined #openstack-glance | 05:09 | |
*** parora has joined #openstack-glance | 05:13 | |
*** prateek_ has quit IRC | 05:16 | |
*** sdake has joined #openstack-glance | 05:17 | |
*** itisha has quit IRC | 05:20 | |
*** prateek_ has joined #openstack-glance | 05:23 | |
*** GB21 has quit IRC | 05:26 | |
*** pt_15 has quit IRC | 05:26 | |
*** parora has quit IRC | 05:27 | |
*** GB21 has joined #openstack-glance | 05:34 | |
*** jerrygb has joined #openstack-glance | 05:34 | |
*** jerrygb has quit IRC | 05:40 | |
*** ducttape_ has joined #openstack-glance | 05:42 | |
*** markvoelker has quit IRC | 05:43 | |
*** ducttape_ has quit IRC | 05:47 | |
*** sdake has quit IRC | 05:51 | |
*** groen692 has joined #openstack-glance | 05:51 | |
*** sdake has joined #openstack-glance | 06:13 | |
*** rcernin has joined #openstack-glance | 06:17 | |
*** markvoelker has joined #openstack-glance | 06:30 | |
*** openstackgerrit has quit IRC | 06:33 | |
*** openstackgerrit has joined #openstack-glance | 06:33 | |
*** chlong has quit IRC | 06:38 | |
*** markvoelker has quit IRC | 06:39 | |
*** ducttape_ has joined #openstack-glance | 06:44 | |
*** ducttape_ has quit IRC | 06:48 | |
*** sdake_ has joined #openstack-glance | 06:49 | |
*** sdake has quit IRC | 06:52 | |
*** tesseract- has joined #openstack-glance | 07:15 | |
*** sdake_ has quit IRC | 07:16 | |
*** pcaruana has joined #openstack-glance | 07:27 | |
*** btully has quit IRC | 07:27 | |
*** d0ugal has joined #openstack-glance | 07:31 | |
*** d0ugal has quit IRC | 07:31 | |
*** d0ugal has joined #openstack-glance | 07:31 | |
*** d0ugal has quit IRC | 07:31 | |
*** d0ugal has joined #openstack-glance | 07:31 | |
*** parora has joined #openstack-glance | 07:34 | |
*** jerrygb has joined #openstack-glance | 07:37 | |
*** prateek_ has quit IRC | 07:37 | |
*** prateek_ has joined #openstack-glance | 07:38 | |
*** parora has quit IRC | 07:40 | |
*** jerrygb has quit IRC | 07:41 | |
*** ducttape_ has joined #openstack-glance | 07:45 | |
*** ducttape_ has quit IRC | 07:49 | |
gabor_antal | hello! Anybody there? | 07:56 |
*** dshakhray has quit IRC | 08:09 | |
*** MattMan has quit IRC | 08:20 | |
*** MattMan has joined #openstack-glance | 08:20 | |
*** e0ne has joined #openstack-glance | 08:21 | |
*** markvoelker has joined #openstack-glance | 08:23 | |
*** markvoelker has quit IRC | 08:27 | |
*** parora has joined #openstack-glance | 08:31 | |
*** prateek_ has quit IRC | 08:34 | |
abhishekk | jokke_: hi, you around? | 08:37 |
*** parora has quit IRC | 08:38 | |
*** prateek has joined #openstack-glance | 08:38 | |
*** prateek has quit IRC | 08:40 | |
*** prateek has joined #openstack-glance | 08:40 | |
*** ducttape_ has joined #openstack-glance | 08:46 | |
*** ducttape_ has quit IRC | 08:50 | |
jokke_ | hi abhishekk | 08:56 |
abhishekk | hi, I have checked nova impelementation and it will return all request-ids there as well | 08:57 |
jokke_ | someone will be happy realizing that :P | 08:58 |
abhishekk | jokke_: between what you suggested yesterday to log same request-id for pagination will need changes at both the ends clinet as well as server | 08:59 |
jokke_ | and there is not even reasonable way around that in Nova cause I think their implementatio does not allow sending the req-id when making request | 08:59 |
abhishekk | jokke_: right | 08:59 |
abhishekk | jokke_: https://review.openstack.org/331981 could you please have a look at it? as per your convinience? | 09:04 |
jokke_ | I will | 09:07 |
abhishekk | jokke_: thank you | 09:08 |
*** btully has joined #openstack-glance | 09:12 | |
jokke_ | oh, that one ... sorry I missed the new PS on it | 09:13 |
abhishekk | jokke_: thank you :D | 09:14 |
*** dshakhray has joined #openstack-glance | 09:14 | |
*** btully has quit IRC | 09:16 | |
*** markvoelker has joined #openstack-glance | 09:17 | |
*** markvoelker has quit IRC | 09:21 | |
gabor_antal | Hey, can anyone help me a little bit? I have an old patch, which was said that i should do specs also. How this going on glance, Why are so few specs in the specs repo? Anyone can help me? | 09:23 |
*** GB21 has quit IRC | 09:23 | |
kairat | nikhil, rbd store doesn't have auth part AFAIK | 09:24 |
kairat | It can be possible to have auth issues if rados is used with swift driver but looks like it is not the current case | 09:25 |
kairat | nikhil, Daviey I suggest to dig into glance-api logs first | 09:26 |
*** flwang1 has quit IRC | 09:26 | |
abhishekk | kairat: https://review.openstack.org/331981 could you please have a look at it? as per your convinience? | 09:27 |
kairat | abhishekk, yep, np | 09:27 |
abhishekk | kairat: thank you | 09:27 |
abhishekk | gabor_antal: what exactly you are looking for? | 09:28 |
openstackgerrit | jingtao liang proposed openstack/glance_store: Cleanup i18n marker functions to match Oslo docs https://review.openstack.org/342699 | 09:30 |
*** GB21 has joined #openstack-glance | 09:31 | |
gabor_antal | abhishekk: Previously I made a patch where I extracted numerical response numbers to symbolic constants (like it can be seen in swift) but I only got comments, that I should do a spec to discuss the way we can do this (urL: https://review.openstack.org/#/c/273196/). And I'd like to do that spec. On nova, lots of specs are there, and lots of activity happens every day. But on glance, I barely can see any activities with speccs. | 09:36 |
gabor_antal | So can you guide me a bit? | 09:36 |
kairat | gabor_antal, I am against spec personally | 09:37 |
kairat | It looks like bikeshedding | 09:38 |
kairat | gabor_antal, I personally prefer to use standart where it is possible | 09:38 |
kairat | all these codes(https://review.openstack.org/#/c/273196/1/glance/common/http.py) already exists in httplib | 09:39 |
abhishekk | in six package as well | 09:39 |
kairat | so I will support you with this change without the spec | 09:39 |
kairat | yep, in six also | 09:39 |
abhishekk | kairat ++ for without spec | 09:40 |
kairat | gabor_antal, you can also omit updates for api v1 | 09:41 |
gabor_antal | Okay, so if I change it to the common httplib version, is it okay? | 09:42 |
kairat | because it is deprecated officially (or will be deprecated), so it will be useless work | 09:42 |
kairat | yep, for me it is okay | 09:42 |
gabor_antal | kairat: okay, i will keep my eye on this. | 09:43 |
gabor_antal | Can you please add yourself as a reviewer? On monday I will commit these changes | 09:43 |
abhishekk | gabor_antal: he is already there in the reviewers list | 09:44 |
kairat | yep, i -1'ed your patch :=) | 09:45 |
gabor_antal | Yes, I can see it. | 09:45 |
gabor_antal | Thanks for your help, I'll commit the changes on monday | 09:46 |
*** ducttape_ has joined #openstack-glance | 09:46 | |
*** ducttape_ has quit IRC | 09:51 | |
*** zul has joined #openstack-glance | 09:52 | |
abhishekk | thanks kairat | 09:55 |
kairat | abhishekk, np | 09:55 |
kairat | btw, are you involved in some kind of debugging service for openstack? | 09:55 |
kairat | or you are just support OS cloud | 09:56 |
kairat | abhishekk, I am interesting if request-id is already useful for users | 09:57 |
abhishekk | kairat: I just support OS cloud | 09:58 |
kairat | we are using oslo.middleware in glare for request-id, https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/request_id.py | 09:58 |
kairat | abhishekk, do other project also use middleware for request-id generation? | 09:59 |
abhishekk | kairat:yes | 09:59 |
kairat | cool | 09:59 |
abhishekk | nova is also using this oslo.middleware | 10:00 |
abhishekk | IMO only glance has its own middleware for generating request-ids | 10:00 |
kairat | abhishekk, ok, got it, thanks for info | 10:01 |
abhishekk | nova, cinder, keystone, neutron are using oslo.middleware/request_id.py | 10:01 |
abhishekk | kairat, np | 10:01 |
*** GB21 has quit IRC | 10:07 | |
*** markvoelker has joined #openstack-glance | 10:11 | |
*** markvoelker has quit IRC | 10:16 | |
*** gabor_antal has quit IRC | 10:19 | |
*** GB21 has joined #openstack-glance | 10:25 | |
*** rcernin has quit IRC | 10:26 | |
*** prateek has quit IRC | 10:40 | |
*** mfedosin has joined #openstack-glance | 10:42 | |
*** rcernin has joined #openstack-glance | 10:45 | |
*** rcernin is now known as rcernin|lunch | 10:46 | |
*** wxy__ has quit IRC | 10:49 | |
*** wxy__ has joined #openstack-glance | 10:49 | |
*** sgotliv has joined #openstack-glance | 10:53 | |
Daviey | kairat: There is nothing really useful there... Just PATCH 403. However.. the instance was booted from 'packer'.. and it seems to be using ceph as ephemeral disk, rather than boot from Volume.. and snapshotting an rbd ephemeral disks seems to cause this. | 10:53 |
Daviey | so i'm not sure if this is working as-designed, a bug in packer or a bug in nova. :/ | 10:53 |
openstackgerrit | Merged openstack/python-glanceclient: Log request-id for each api call https://review.openstack.org/331981 | 10:56 |
johnthetubaguy | jokke_: abhishekk: we don't want people picking an arbitrary request-id, because it would break our logs, I thought the plan was to supply an additional request-id, so the two request-ids get logged together, to help cascade things down? (think about creating two ports for a single VM create) | 10:56 |
*** prateek has joined #openstack-glance | 10:56 | |
*** btully has joined #openstack-glance | 11:01 | |
jokke_ | johnthetubaguy: so glance had the req-id support (and support to provide the req id to the service) already when the cross project work started ... I still don't see how it breaks any logs, we limit the length and if someone really wants to feck themselves over by sending something arbitary on their every single request instead of utilizing the uniqueness, they really just shoot themselves into the foot | 11:01 |
jokke_ | but on situations like paginating it's incredibly handy that you don't need to deal with thousands of req id's which really defets the purpose of them as well | 11:02 |
johnthetubaguy | jokke_: so I am oversimplifying, the user doing bad things is a very weak argument, its just one that came up when we discussed this in Nova | 11:04 |
johnthetubaguy | jokke_: if you sell support on your public cloud, you really don't want that to happen | 11:04 |
*** btully has quit IRC | 11:05 | |
*** markvoelker has joined #openstack-glance | 11:05 | |
jokke_ | johnthetubaguy: I was closely following the discussion when the x-project spec was on the review and I know that topic came out ... I did not see it fitting then and I still don't | 11:07 |
jokke_ | like we have had that functionality in glance, I've yet to hear a single case where that would have been abused | 11:07 |
jokke_ | just like we allow our users to set their image-id, which will land to the logs and we haven't had issues with that either | 11:08 |
*** sgotliv has quit IRC | 11:09 | |
johnthetubaguy | anyways, I think there is a more important use case for all this | 11:10 |
*** markvoelker has quit IRC | 11:10 | |
johnthetubaguy | during a VM create, we have a single request-id for that, and multiple calls to many services | 11:10 |
johnthetubaguy | now there are totally multiple ways of doing this, but the one I thought we had gone for (and I probably just lost track), was logging the incoming request-id next to the generated request-id | 11:11 |
johnthetubaguy | that way we get the best of both worlds, I think | 11:11 |
johnthetubaguy | although you do get a very long log line | 11:11 |
jokke_ | johnthetubaguy: so the logging plan as I understood it was that you log the response req id with the one that you have on that request you got ... only two | 11:12 |
jokke_ | so when someone creates VM lets say from image that is stored in swift you will not see the swift req id ever in nova logs | 11:13 |
jokke_ | so there is still lots of jumping around to map it. It's possible it's just lots of work | 11:13 |
jokke_ | but when you end up to situation where you're listing 50k images and you get dumped 2.5k req ids with that list (like where this discussion initiated) that it just pure insanity | 11:14 |
johnthetubaguy | jokke_: I guess it depends what you are trying to debug | 11:17 |
johnthetubaguy | jokke_: and what log tooling you are using | 11:17 |
jokke_ | like user and support perspective the most convenient option is that your nova call returns you exactly one req-id for that VM creation and that req id would show to all calls related to that VM creation across the services | 11:17 |
openstackgerrit | Mike Fedosin proposed openstack/glance: [WIP] Add locks to sqlalchemy db https://review.openstack.org/342358 | 11:17 |
johnthetubaguy | jokke_: agreed, Nova *must* return one and only one request-id to the user | 11:21 |
johnthetubaguy | jokke_: you need to trace its path through all the services | 11:21 |
johnthetubaguy | jokke_: for the first version, I am OK with that being the request-id | 11:22 |
johnthetubaguy | jokke_: its just I know that leaves me relying on timestamps to debug things | 11:22 |
*** cdelatte has joined #openstack-glance | 11:22 | |
johnthetubaguy | jokke_: the nothing we have right now is way worse than *something* | 11:23 |
jokke_ | johnthetubaguy: I do agree | 11:23 |
johnthetubaguy | jokke_: I think this is one of the things we need to make an OpenStack wide priority for the next cycle | 11:23 |
jokke_ | johnthetubaguy: I haven't been against req-ids at any point | 11:24 |
johnthetubaguy | jokke_: +1, just working out where we agree | 11:24 |
johnthetubaguy | jokke_: I think its 99% of it | 11:24 |
jokke_ | but if you want to have nova returning you individual req-id for each paginate call, have fun, we can avoid that in glance and plan to do so even if that means that it behaves bit differently compared to nova ;) | 11:25 |
jokke_ | end result will be anyways that one will have req-id(s) related to their operation that can be correlated to the logs == profit | 11:26 |
*** zul has quit IRC | 11:26 | |
johnthetubaguy | jokke_: yeah, so I don't want Nova returning multiple to the end user, only ever one request-id | 11:29 |
johnthetubaguy | jokke_: what I am would like (in an ideal world), is to uniquely identify each create port request to Neutron separately, so I can tell which one failed, as part of that create instance request-id | 11:30 |
johnthetubaguy | jokke_: but the knowing it was part of the create request is more important, its just I would like both, ideally | 11:30 |
johnthetubaguy | jokke_: in my head, Nova still returns one request-id, and it sends that to all those create port calls, its just in the logs in neutron, you can see there were multiple requests, and on the nova side we log the request-id we get back for each create call from Neutron | 11:31 |
johnthetubaguy | jokke_: as you say, nova -> glance -> swift gets messy, but I think glance could pass the incoming request id (the nova create instance one) to swift, and maybe that works | 11:32 |
*** ratailor has quit IRC | 11:33 | |
johnthetubaguy | that way you get the nova create request-id in all the logs, but you have next to it a unique id for each chunk fetch | 11:33 |
jokke_ | johnthetubaguy: the beauty of the current glance behavior is that you as caller of the api can decide that ... so if you don't supply the req-id you will get one unique for your call ... so like this paginate situation ... we're going to not being sending req-ids for most of our api calls from the client ... like when you list we don't send the req-id initially so we get new one and what I'm proposing here is that because we can we sho | 11:33 |
johnthetubaguy | jokke_: that doesn't work for me | 11:33 |
johnthetubaguy | jokke_: I need my request-id in the glance logs | 11:34 |
jokke_ | johnthetubaguy: well with glance you can do that ... with the rest of the services you cant | 11:34 |
johnthetubaguy | jokke_: but I want a unique request-id for each of the calls to glance | 11:34 |
johnthetubaguy | jokke_: yes, true | 11:34 |
jokke_ | johnthetubaguy: and that's where we 100% agree ... that's what I wanted as well | 11:34 |
jokke_ | ok so glance does not generate one for you if you supply it one | 11:35 |
johnthetubaguy | jokke_: so I don't think glance should move to oslo, until it gives you something better, I am just curious where we are all at really | 11:35 |
johnthetubaguy | jokke_: yeah, I think we need to do both, supply, and generate one | 11:35 |
johnthetubaguy | then passed the supplied one down to swift, etc | 11:36 |
jokke_ | johnthetubaguy: that's why we didn't, because moving to oslo would have broken us backwards | 11:36 |
johnthetubaguy | jokke_: yeah, ++ that | 11:36 |
johnthetubaguy | I should find time to go work on this in oslo, its bugging me | 11:36 |
jokke_ | as said we had it before the decision was made on the x-project level ... luckily we supported all the functionality from the middleware perspective that the x-proj needed | 11:37 |
jokke_ | so we could keep both | 11:38 |
*** jerrygb has joined #openstack-glance | 11:38 | |
openstackgerrit | Darja Shakhray proposed openstack/glance: [WIP] Add test for Glare https://review.openstack.org/342752 | 11:40 |
jokke_ | johnthetubaguy: I'd really like if we could move this towards 2 req-ids but other way around than now ... so you generate the req-id when the call intially comes in, you pass that one with every call you make and that one req-id will be passed through the whole chain of the requests, logged and each individual call would generate their own that they would add to their logs and return to caller. That way you could only return that initi | 11:43 |
*** jerrygb has quit IRC | 11:43 | |
kairat | Daviey, you are adding a location here | 11:46 |
kairat | If location looks like rbd://<some_address> then it goes to rbd driver | 11:47 |
kairat | otherwise ceph shouldn't be involved here | 11:47 |
jokke_ | _if_ that driver has been enabled | 11:47 |
kairat | Are you sure you have show_multiple_location=True | 11:47 |
kairat | yep, ++ to jokke_ | 11:47 |
*** ducttape_ has joined #openstack-glance | 11:48 | |
*** gabor_antal has joined #openstack-glance | 11:49 | |
*** julim has joined #openstack-glance | 11:50 | |
*** takedakn has joined #openstack-glance | 11:50 | |
*** ducttape_ has quit IRC | 11:52 | |
*** prateek_ has joined #openstack-glance | 11:54 | |
*** prateek has quit IRC | 11:57 | |
*** markvoelker has joined #openstack-glance | 11:59 | |
*** markvoelker has quit IRC | 12:03 | |
*** abhishekk has quit IRC | 12:08 | |
*** takedakn has quit IRC | 12:08 | |
openstackgerrit | Darja Shakhray proposed openstack/glance: Add distinction layer https://review.openstack.org/272118 | 12:09 |
*** ducttape_ has joined #openstack-glance | 12:12 | |
*** GB21 has quit IRC | 12:14 | |
*** GB21 has joined #openstack-glance | 12:26 | |
*** GB21 has quit IRC | 12:31 | |
johnthetubaguy | jokke_: so I think thats the same thing I was trying to describe above | 12:31 |
openstackgerrit | Darja Shakhray proposed openstack/glance: Add distinction layer https://review.openstack.org/272118 | 12:33 |
*** ducttape_ has quit IRC | 12:37 | |
jokke_ | johnthetubaguy: yes, I was kind of recapping that for myself in form of agreement ;) | 12:37 |
johnthetubaguy | jokke_: cool | 12:38 |
*** pdeore has quit IRC | 12:40 | |
*** ducttape_ has joined #openstack-glance | 12:48 | |
*** jerrygb has joined #openstack-glance | 12:48 | |
*** btully has joined #openstack-glance | 12:55 | |
rosmaita | dshakhray: yt? | 12:59 |
dshakhray | rosmaita, yes | 12:59 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient: Updated from global requirements https://review.openstack.org/340048 | 13:00 |
*** btully has quit IRC | 13:00 | |
*** ducttape_ has quit IRC | 13:00 | |
rosmaita | dshakhray: i need a favor ... can you look over the stuff i wrote about the "in" operator for the api-ref? you don't have to read the entire patch, just the diff between patch sets 9 and 10 | 13:01 |
rosmaita | https://review.openstack.org/#/c/332950/9..10/api-ref/source/v2/images-images-v2.inc | 13:01 |
rosmaita | i left a question or two for you inline | 13:01 |
*** btully has joined #openstack-glance | 13:01 | |
*** parora has joined #openstack-glance | 13:03 | |
*** markvoelker has joined #openstack-glance | 13:03 | |
*** buzztroll has joined #openstack-glance | 13:05 | |
*** prateek_ has quit IRC | 13:06 | |
dshakhray | rosmaita: I understood correctly, the request "GET v2/images?name=in:"glass,%20darkly",share%20me" did not work? | 13:09 |
*** parora has quit IRC | 13:11 | |
nikhil | rosmaita: just let me know a bit before (if) you plan to upload a new PS for api ref. I will post my comments and pick up rest of the work on latest one. | 13:11 |
rosmaita | dshakhray: that one worked | 13:11 |
rosmaita | dshakhray: the problem one was where the name had quotation marks in it | 13:12 |
rosmaita | i couldn't get this one to work: "really,+really+\"good\"+image" | 13:13 |
rosmaita | the outer " are needed because the name has a comma in it | 13:13 |
rosmaita | but then the inner " need escaping | 13:13 |
*** parora has joined #openstack-glance | 13:14 | |
rosmaita | dshakhray: iirc it didnt' return an error, just an empty list of results | 13:14 |
* rosmaita is looking for his notes | 13:14 | |
rosmaita | nikhil: will do | 13:14 |
rosmaita | dshakhray: using just the regular = finds the image: | 13:17 |
rosmaita | curl -X GET -H "x-auth-token: $TK" 'http://localhost:9292/v2/images?name=really,%20really%20"good"%20image' | 13:17 |
rosmaita | but using 'in' did not | 13:17 |
rosmaita | curl -X GET -H "x-auth-token: $TK" 'http://localhost:9292/v2/images?name=in:"really,%20really%20\"good\"%20image"' | 13:17 |
dshakhray | rosmaita: symbol "%" - special to use it within quotation marks, it must be escaped \ | 13:18 |
dshakhray | i.e http://localhost:9292/v2/images?name=in:"really,\%20really\%20\"good\"\%20image" | 13:19 |
rosmaita | ok, cool, let me try that one in my devstack | 13:20 |
*** takedakn has joined #openstack-glance | 13:20 | |
dshakhray | I checked on devstek, "\%20" working properly | 13:20 |
dshakhray | ok) | 13:20 |
*** ducttape_ has joined #openstack-glance | 13:23 | |
*** dshakhray has quit IRC | 13:23 | |
*** dshakhray has joined #openstack-glance | 13:25 | |
*** ametts has joined #openstack-glance | 13:27 | |
rosmaita | dshakhray: not sure what i'm doing wrong | 13:28 |
rosmaita | devVM! curl -X GET -H "x-auth-token: $TK" 'http://localhost:9292/v2/images?name=really,%20really%20"good"%20image' | 13:28 |
rosmaita | {"images": [{"status": "queued", "name": "really, really \"good\" image", "tags": ["gotta space", "ferd"], "container_format": null, "created_at": "2016-07-06T17:34:39Z", "size": null, "disk_format": null, "updated_at": "2016-07-08T19:58:30Z", "visibility": "private", "self": "/v2/images/240ab36f-6704-47d9-8be1-b1f3d917085b", "min_disk": 0, "protected": false, "id": "240ab36f-6704-47d9-8be1-b1f3d917085b", "file": "/v2/images/240ab36f-6704-47d9-8be | 13:28 |
rosmaita | devVM! | 13:28 |
rosmaita | devVM! curl -X GET -H "x-auth-token: $TK" 'http://localhost:9292/v2/images?name=in:"really,\%20really\%20\"good\"\%20image"' | 13:28 |
rosmaita | {"images": [], "schema": "/v2/schemas/images", "first": "/v2/images?name=in%3A%22really%2C%5C+really%5C+%5C%22good%5C%22%5C+image%22"}devVM! | 13:28 |
*** dshakhray_ has joined #openstack-glance | 13:30 | |
*** takedakn has quit IRC | 13:32 | |
*** ducttape_ has quit IRC | 13:37 | |
dshakhray | I think the problem is in quotes in the name... | 13:42 |
*** prateek_ has joined #openstack-glance | 13:42 | |
rosmaita | yeah, i tried several things, like double-backslashing, couldn't get it to work | 13:44 |
rosmaita | just wanted to make sure i was trying the right things | 13:44 |
*** parora has quit IRC | 13:44 | |
*** sdake has joined #openstack-glance | 13:47 | |
*** sdake_ has joined #openstack-glance | 13:50 | |
*** sdake has quit IRC | 13:52 | |
*** sdake_ has quit IRC | 13:52 | |
*** pt_15 has joined #openstack-glance | 13:54 | |
*** ducttape_ has joined #openstack-glance | 13:55 | |
*** itisha has joined #openstack-glance | 13:58 | |
*** edmondsw has joined #openstack-glance | 14:02 | |
openstackgerrit | Mike Fedosin proposed openstack/glance: [WIP] Add test for Glare https://review.openstack.org/342752 | 14:03 |
dshakhray_ | rosmaita: the problem arises from the fact that the name of the image does not contain a \ before the quote | 14:05 |
dshakhray_ | because of this, the filter can not distinguish what type quote - part of the name or not | 14:07 |
*** markvoelker has quit IRC | 14:13 | |
*** markvoelker has joined #openstack-glance | 14:16 | |
rosmaita | dshakhray_: that seems like a bug? | 14:16 |
rosmaita | (not that this situation should arise very often) | 14:17 |
-openstackstatus- NOTICE: Gerrit is restarting to correct memory/performance issues. | 14:17 | |
*** ihrachys has joined #openstack-glance | 14:18 | |
*** links has quit IRC | 14:27 | |
*** prateek_ has quit IRC | 14:36 | |
*** markvoelker has joined #openstack-glance | 14:37 | |
openstackgerrit | Niall Bunting proposed openstack/glance: Introduce a policy to govern the deletion of deactivated images https://review.openstack.org/256381 | 14:37 |
openstackgerrit | Brian Rosmaita proposed openstack/glance-specs: Database strategy for rolling upgrades https://review.openstack.org/331740 | 14:38 |
rosmaita | nikhil: i think i should remove lines 310-317 in images-images-v2.inc until we've sorted out how the escaping is supposed to work | 14:49 |
*** rrecio has joined #openstack-glance | 14:50 | |
rosmaita | nikhil: but that's the only change i'd make | 14:50 |
*** rrecio_ has joined #openstack-glance | 14:50 | |
rosmaita | nikhil: let me know if you want a new PS now; otherwise i'll make the change when i address whatever comments you have on the current patch | 14:51 |
*** ducttape_ has quit IRC | 14:51 | |
*** jerrygb has joined #openstack-glance | 14:52 | |
*** rrecio has quit IRC | 14:54 | |
*** mtanino has joined #openstack-glance | 14:56 | |
*** buzztroll has quit IRC | 15:05 | |
*** jerrygb_ has joined #openstack-glance | 15:06 | |
*** dshakhray_ has quit IRC | 15:08 | |
openstackgerrit | Mike Fedosin proposed openstack/glance: [WIP] Glare https://review.openstack.org/292327 | 15:08 |
*** jerrygb has quit IRC | 15:09 | |
nikhil | rosmaita: I got only 30% thru :/ lemme publish comments now | 15:11 |
nikhil | rosmaita: published, will wait for you now. | 15:13 |
openstackgerrit | jingtao liang proposed openstack/glance_store: Cleanup i18n marker functions to match Oslo docs https://review.openstack.org/342699 | 15:17 |
*** buzztroll has joined #openstack-glance | 15:18 | |
openstackgerrit | Mike Fedosin proposed openstack/glance: [WIP] Glare https://review.openstack.org/292327 | 15:18 |
rosmaita | nikhil: ok, thanks | 15:18 |
openstackgerrit | Mike Fedosin proposed openstack/glance: [WIP] Glare https://review.openstack.org/292327 | 15:19 |
*** burgerk has joined #openstack-glance | 15:20 | |
openstackgerrit | Hemanth Makkapati proposed openstack/glance_store: Cleanup i18n marker functions to match Oslo docs https://review.openstack.org/342699 | 15:21 |
*** bhagyashri has quit IRC | 15:27 | |
*** ametts has quit IRC | 15:27 | |
*** itlinux has joined #openstack-glance | 15:34 | |
*** ametts has joined #openstack-glance | 15:35 | |
rosmaita | nikhil: left some replies; i will make changes based on your responses | 15:36 |
nikhil | Thx looking | 15:36 |
nikhil | rosmaita: replied | 15:39 |
* nikhil 's brunch time | 15:39 | |
*** links has joined #openstack-glance | 15:45 | |
openstackgerrit | Niall Bunting proposed openstack/glance: Introduce a policy to govern the deletion of deactivated images https://review.openstack.org/256381 | 15:48 |
*** groen692 has quit IRC | 15:54 | |
*** tsymanczyk has joined #openstack-glance | 16:00 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance: WADL to RST migration (part 2 - images) https://review.openstack.org/332950 | 16:02 |
tsymanczyk | nikhil : rosmaita : good morning and happy friday! re community images sync. the spec seems mostly stable. as to the actual code / active changeset. what i've been struggling with is that i absolutely LOATHE code that requires people with a deep knowledge base to spend significant time staring at it to figure out correctness - so i've been trying to come up | 16:04 |
tsymanczyk | with a plan to make the changeset such that it's clearly and unambiguously correct. i BELIEVE that i've finally come up with a plan of this nature and am methodically knocking down the (locally) broken unit tests. if this plan is not another dead end and the wind is just right i hope to drop the majority-patchset some time next week. time will tell if that's | 16:04 |
tsymanczyk | how it goes. ... no other news or questions from my end. | 16:04 |
*** sdake has joined #openstack-glance | 16:07 | |
*** e0ne has quit IRC | 16:10 | |
nikhil | tsymanczyk: g'morning and happy friday. thanks for that update. I saw rosmaita posted some comment last night however, I haven't had any chance to take a look. as far as change itself goes, I would love to help out as much as I can, so if you feel confortable collaborating, please publish a WIP change set (if any besides | 16:10 |
nikhil | https://review.openstack.org/#/c/326128/ ) and we can work together to fix things. | 16:10 |
*** dshakhray has quit IRC | 16:11 | |
*** dshakhray has joined #openstack-glance | 16:11 | |
tsymanczyk | nikhil : rosmaita's comments from yesterday were both minor and reasonable, and should already be addressed. thank you for the explicit offer to help - the next time i find myself significantly stuck i will certainly take you up on that. i understand how busy you must be, and will strive not to bother you unless it's necessary. | 16:13 |
hemanthm|afk | kairat: this is more or less ready for review https://review.openstack.org/#/c/331740/ | 16:14 |
*** hemanthm|afk is now known as hemanthm | 16:14 | |
nikhil | tsymanczyk: thank you! from my end, things look great so, I will keep a passive watch until you want otherwise. | 16:15 |
*** tesseract- has quit IRC | 16:16 | |
*** rcernin|lunch has quit IRC | 16:18 | |
*** pcaruana has quit IRC | 16:20 | |
tsymanczyk | nikhil : one last thing, my company is taking a mandatory shutdown for the end of july - so i'll be away and travelling for the next two thursday-glance-meetings and friday-community-images syncs. i will try to sync with you on irc wednesday before close-of-business. i very much hope to drop the patchset by then - but i've been wrong about my estimates on | 16:22 |
tsymanczyk | this before. | 16:22 |
*** sdake has quit IRC | 16:25 | |
openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Improving help text for RPC opt https://review.openstack.org/342947 | 16:27 |
nikhil | tsymanczyk: gotcha, have fun with time away. no issues on estimates, please drop off whatever you have in any state the patch set may be in. we don't judge here in glance (except for some people) but your feature and subset of team involved is friendly on that front. | 16:28 |
tsymanczyk | nikhil : sounds good, thank you. :) | 16:29 |
*** cdelatte has quit IRC | 16:29 | |
*** ametts has quit IRC | 16:29 | |
nikhil | :) | 16:29 |
openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Improving help text for RPC opt https://review.openstack.org/342947 | 16:32 |
*** ducttape_ has joined #openstack-glance | 16:36 | |
*** david-lyle has joined #openstack-glance | 16:42 | |
*** ametts has joined #openstack-glance | 16:45 | |
*** bpokorny has joined #openstack-glance | 16:50 | |
*** mfedosin has quit IRC | 17:05 | |
*** david-lyle has quit IRC | 17:08 | |
*** btully has quit IRC | 17:16 | |
*** sgotliv has joined #openstack-glance | 17:23 | |
*** bpokorny has quit IRC | 17:24 | |
*** bpokorny has joined #openstack-glance | 17:27 | |
*** dshakhray has quit IRC | 17:31 | |
*** harlowja has quit IRC | 17:39 | |
*** harlowja has joined #openstack-glance | 17:41 | |
*** seldenr has joined #openstack-glance | 17:41 | |
*** mine0901 has joined #openstack-glance | 17:47 | |
*** catintheroof has joined #openstack-glance | 17:48 | |
*** btully has joined #openstack-glance | 17:49 | |
*** ntpttr has joined #openstack-glance | 17:49 | |
*** links has quit IRC | 17:52 | |
*** ducttape_ has quit IRC | 17:53 | |
openstackgerrit | Ryan Selden proposed openstack/glance: {WIP} Properly validate metadef objects https://review.openstack.org/343012 | 17:56 |
*** catintheroof has quit IRC | 17:56 | |
*** rcernin has joined #openstack-glance | 17:59 | |
*** buzztroll has quit IRC | 18:05 | |
*** bpokorny has quit IRC | 18:06 | |
*** jmccrory_away is now known as jmccrory | 18:08 | |
openstackgerrit | Itisha Dewan proposed openstack/glance_store: Improve the help text for vmware datastore driver opts https://review.openstack.org/342286 | 18:11 |
*** sgotliv has quit IRC | 18:12 | |
*** buzztroll has joined #openstack-glance | 18:13 | |
*** bpokorny has joined #openstack-glance | 18:14 | |
*** ducttape_ has joined #openstack-glance | 18:19 | |
*** flwang1 has joined #openstack-glance | 18:38 | |
openstackgerrit | Itisha Dewan proposed openstack/glance_store: Improve the help text for vmware datastore driver opts https://review.openstack.org/342286 | 18:39 |
*** ihrachys has quit IRC | 18:42 | |
*** sdake has joined #openstack-glance | 18:48 | |
*** d0ugal has quit IRC | 19:09 | |
*** jerrygb_ has quit IRC | 19:10 | |
*** buzztroll has quit IRC | 19:14 | |
*** e0ne has joined #openstack-glance | 19:20 | |
*** buzztroll has joined #openstack-glance | 19:24 | |
*** e0ne has quit IRC | 19:35 | |
*** e0ne has joined #openstack-glance | 19:38 | |
nikhil | rosmaita: got a few more comments https://review.openstack.org/#/c/332950/ | 19:40 |
nikhil | rosmaita: lemme know if you wanna follow PS | 19:41 |
nikhil | s/PS/commit/ | 19:41 |
*** ihrachys has joined #openstack-glance | 19:50 | |
*** ametts has quit IRC | 19:56 | |
*** rrecio_ has quit IRC | 19:57 | |
*** rrecio has joined #openstack-glance | 20:04 | |
openstackgerrit | Ryan Selden proposed openstack/glance: {WIP} Properly validate metadef objects https://review.openstack.org/343012 | 20:06 |
*** sdake has quit IRC | 20:08 | |
*** bpokorny has quit IRC | 20:09 | |
*** burgerk has quit IRC | 20:15 | |
*** e0ne has quit IRC | 20:41 | |
*** buzztroll has quit IRC | 20:45 | |
*** buzztroll has joined #openstack-glance | 20:53 | |
*** bpokorny has joined #openstack-glance | 20:53 | |
*** bpokorny has quit IRC | 20:56 | |
*** bpokorny has joined #openstack-glance | 20:56 | |
*** edmondsw has quit IRC | 20:58 | |
openstackgerrit | Ryan Selden proposed openstack/glance: Properly validate metadef objects https://review.openstack.org/343012 | 21:00 |
*** edmondsw has joined #openstack-glance | 21:02 | |
*** edmondsw has quit IRC | 21:02 | |
*** edmondsw has joined #openstack-glance | 21:03 | |
*** sdake has joined #openstack-glance | 21:03 | |
*** edmondsw has quit IRC | 21:04 | |
*** mine0901 has quit IRC | 21:13 | |
*** bpokorny has quit IRC | 21:32 | |
*** bpokorny has joined #openstack-glance | 21:43 | |
*** cfriesen has quit IRC | 21:44 | |
*** julim has quit IRC | 21:48 | |
*** buzztroll has quit IRC | 22:10 | |
*** seldenr has quit IRC | 22:16 | |
*** sdake has quit IRC | 22:19 | |
*** buzztroll has joined #openstack-glance | 22:21 | |
*** ducttape_ has quit IRC | 22:22 | |
*** rrecio has quit IRC | 22:25 | |
*** buzztroll has quit IRC | 22:29 | |
*** buzztroll has joined #openstack-glance | 22:36 | |
*** buzztroll has quit IRC | 22:38 | |
*** edmondsw has joined #openstack-glance | 22:40 | |
*** buzztroll has joined #openstack-glance | 22:40 | |
*** sdake has joined #openstack-glance | 22:40 | |
*** edmondsw has quit IRC | 22:45 | |
*** sdake has quit IRC | 22:46 | |
*** bpokorny has quit IRC | 22:53 | |
*** buzztroll has quit IRC | 22:57 | |
*** bpokorny has joined #openstack-glance | 22:59 | |
*** sdake has joined #openstack-glance | 23:02 | |
*** buzztroll has joined #openstack-glance | 23:02 | |
*** buzztroll has quit IRC | 23:02 | |
*** buzztroll has joined #openstack-glance | 23:02 | |
*** buzztroll has quit IRC | 23:03 | |
*** buzztroll has joined #openstack-glance | 23:04 | |
*** buzztroll has quit IRC | 23:05 | |
*** btully has quit IRC | 23:08 | |
*** btully has joined #openstack-glance | 23:08 | |
*** btully has quit IRC | 23:13 | |
*** sdake has quit IRC | 23:22 | |
*** mtanino has quit IRC | 23:25 | |
*** rcernin has quit IRC | 23:30 | |
*** ihrachys has quit IRC | 23:31 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!