*** brinzhang has quit IRC | 00:50 | |
*** brinzhang has joined #openstack-glance | 00:51 | |
*** gyee has quit IRC | 00:58 | |
*** brinzhang_ has joined #openstack-glance | 00:59 | |
*** brinzhang has quit IRC | 01:03 | |
*** happyhemant has quit IRC | 01:08 | |
*** Liang__ has joined #openstack-glance | 01:17 | |
openstackgerrit | kayluu proposed openstack/glance master: Add recommendations on image schema customization docs https://review.opendev.org/717889 | 01:21 |
---|---|---|
openstackgerrit | Merged openstack/glance master: Remove all references to sheepdog https://review.opendev.org/705558 | 04:05 |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Fail gracefully when MD5 is unavailable https://review.opendev.org/717946 | 04:16 |
*** brinzhang has joined #openstack-glance | 04:36 | |
*** evrardjp has quit IRC | 04:36 | |
*** evrardjp has joined #openstack-glance | 04:37 | |
*** brinzhang_ has quit IRC | 04:39 | |
*** ratailor has joined #openstack-glance | 05:00 | |
openstackgerrit | kayluu proposed openstack/glance master: Add warning and note on image schema customization docs https://review.opendev.org/717889 | 05:18 |
openstackgerrit | kayluu proposed openstack/glance master: Add warning and note on image schema customization docs https://review.opendev.org/717889 | 05:26 |
openstackgerrit | kayluu proposed openstack/glance master: Add warning and note on image schema customization docs https://review.opendev.org/717889 | 05:27 |
openstackgerrit | kayluu proposed openstack/glance master: Add warning and note on image schema customization docs https://review.opendev.org/717889 | 05:30 |
freefood | jokke_ when you do `tox -e docs`, do you get error of missing dependencies in requirements.txt (specifically `boto3` and `hacking`)? | 05:32 |
freefood | and looks like I'm having 2 pairs of remotes right now | 05:32 |
freefood | $ git remote -v | 05:33 |
freefood | gerrit ssh://khashf@review.opendev.org:29418/openstack/glance.git (fetch) | 05:33 |
freefood | gerrit ssh://khashf@review.opendev.org:29418/openstack/glance.git (push) | 05:33 |
freefood | origin ssh://khashf@review.opendev.org:29418/openstack/glance (fetch) | 05:33 |
freefood | origin ssh://khashf@review.opendev.org:29418/openstack/glance (push) | 05:33 |
freefood | should I delete the `origin` remote? | 05:33 |
*** brinzhang_ has joined #openstack-glance | 05:33 | |
freefood | hmm when I look at what I was having on another machine, my `origin` has the `.git` suffix, but in my current machine, the `origin` remote doesn't | 05:35 |
*** brinzhang has quit IRC | 05:36 | |
freefood | another question: when my patch is approved but out-of-date with master, does rebase-ing then `git review` again (so my branch is up-to-date with master) invalidate the existing approvals on my patch? | 05:40 |
freefood | (including Zuul's approval) | 05:40 |
*** udesale has joined #openstack-glance | 05:41 | |
freefood | diablo_rojo: if jokke_ hasn't seen this, could you help me answer these questions? | 05:43 |
freefood | right now when I do a clean `tox --recreate -e docs` I get the following error (link below) which I described above | 05:47 |
freefood | https://pastebin.com/vQP3RFQr | 05:47 |
freefood | then I added `boto3` and `hacking` to doc/requirements.txt the error is gone, and next error is | 05:49 |
freefood | glance/doc/source/contributor/api/glance.hacking.rst:document isn't included in any toctree | 05:49 |
*** abhishekk has joined #openstack-glance | 06:09 | |
*** udesale has quit IRC | 06:09 | |
freefood | I've narrowed down the cause, this commit is possible the cause: https://opendev.org/openstack/glance/commit/6d2c55bc769107207bd2a39059701b76ab27f2b0 | 06:11 |
freefood | hacking>=3.0,<3.1.0 should have been also added to doc/requirements.txt | 06:11 |
*** udesale has joined #openstack-glance | 06:13 | |
freefood | additionally, local `sphinx-build` may have also generated glance/doc/source/contributor/api/glance.hacking.rst | 06:16 |
*** ratailor has quit IRC | 06:40 | |
*** ratailor has joined #openstack-glance | 06:47 | |
*** gtema has joined #openstack-glance | 06:55 | |
abhishekk | freefood, what is the context | 06:58 |
*** brinzhang has joined #openstack-glance | 07:56 | |
*** brinzhang_ has quit IRC | 07:59 | |
*** brinzhang_ has joined #openstack-glance | 08:05 | |
*** gtema has left #openstack-glance | 08:08 | |
*** brinzhang has quit IRC | 08:09 | |
*** tkajinam has quit IRC | 08:17 | |
*** priteau has joined #openstack-glance | 09:01 | |
openstackgerrit | Erno Kuvaja proposed openstack/glance master: Do not decompress 'compressed' containers https://review.opendev.org/718005 | 09:32 |
*** brinzhang has joined #openstack-glance | 09:36 | |
*** brinzhang_ has quit IRC | 09:39 | |
openstackgerrit | Erno Kuvaja proposed openstack/glance master: Do not decompress 'compressed' containers https://review.opendev.org/718005 | 09:46 |
openstackgerrit | Merged openstack/python-glanceclient master: Add release note for glanceclient 3.0.0 https://review.opendev.org/717667 | 10:05 |
*** Liang__ has quit IRC | 10:09 | |
openstackgerrit | Rajat Dhasmana proposed openstack/glance-specs master: Refactor and Imporve glance cinder store https://review.opendev.org/717756 | 10:12 |
abhishekk | smcginnis, around? | 10:15 |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Rename releasenotes to reflect correct version https://review.opendev.org/718050 | 10:27 |
openstackgerrit | Merged openstack/python-glanceclient master: Rename releasenotes to reflect correct version https://review.opendev.org/718050 | 10:46 |
smcginnis | abhishekk: Now I am. | 11:09 |
abhishekk | smcginnis, pushed release patch for glanceclient | 11:10 |
smcginnis | abhishekk: Thanks, I saw that. Once the zuul jobs pass and I can take a look at that, we should be able to get that through right away. | 11:10 |
abhishekk | smcginnis, thank you :D | 11:11 |
smcginnis | Thanks for getting it done ahead of the deadline. I wish more folks could do that. :) | 11:11 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Ussuri final release notes https://review.opendev.org/717679 | 11:12 |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Fail gracefully when MD5 is unavailable https://review.opendev.org/717946 | 11:34 |
*** rosmaita has quit IRC | 11:40 | |
*** rosmaita has joined #openstack-glance | 11:42 | |
*** gtema has joined #openstack-glance | 12:04 | |
*** tkajinam has joined #openstack-glance | 12:08 | |
openstackgerrit | James Page proposed openstack/python-glanceclient master: Update test certificates to use strong signing https://review.opendev.org/718093 | 12:50 |
*** udesale_ has joined #openstack-glance | 13:03 | |
*** udesale has quit IRC | 13:05 | |
*** Luzi has joined #openstack-glance | 13:09 | |
*** ratailor has quit IRC | 13:11 | |
openstackgerrit | OpenStack Release Bot proposed openstack/python-glanceclient stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/718103 | 13:19 |
openstackgerrit | OpenStack Release Bot proposed openstack/python-glanceclient stable/ussuri: Update TOX/UPPER_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/718104 | 13:19 |
openstackgerrit | OpenStack Release Bot proposed openstack/python-glanceclient master: Update master for stable/ussuri https://review.opendev.org/718105 | 13:19 |
*** gtema has quit IRC | 13:45 | |
*** tkajinam has quit IRC | 14:03 | |
*** tkajinam has joined #openstack-glance | 14:03 | |
*** Luzi has quit IRC | 14:07 | |
*** gtema has joined #openstack-glance | 14:12 | |
*** gtema has quit IRC | 14:25 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance-specs master: Deprecate 'checksum' computation https://review.opendev.org/708761 | 14:25 |
*** priteau has quit IRC | 14:37 | |
*** tkajinam has quit IRC | 14:42 | |
*** rcernin has quit IRC | 15:13 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: Deprecate the 'checksum' image property https://review.opendev.org/718147 | 15:19 |
*** gyee has joined #openstack-glance | 15:31 | |
*** udesale_ has quit IRC | 16:08 | |
*** lpetrut has joined #openstack-glance | 16:27 | |
*** brinzhang has quit IRC | 16:30 | |
*** brinzhang has joined #openstack-glance | 16:31 | |
*** evrardjp has quit IRC | 16:36 | |
*** evrardjp has joined #openstack-glance | 16:37 | |
*** lpetrut has quit IRC | 16:56 | |
*** brinzhang_ has joined #openstack-glance | 17:51 | |
*** brinzhang has quit IRC | 17:53 | |
abhishekk | rosmaita, around? | 17:59 |
rosmaita | abhishekk: hello | 17:59 |
abhishekk | good morning | 17:59 |
abhishekk | saw your md5 patch for glanceclient | 17:59 |
abhishekk | glanceclient version released 3.1.0 just few hours ago :( | 18:00 |
rosmaita | yeah, i saw that | 18:01 |
abhishekk | Should we tag another version? | 18:01 |
rosmaita | up to you ... might be worth having in ussuri | 18:01 |
rosmaita | spec still isn't approved, though | 18:01 |
abhishekk | sorry, it completely slipped out of my mind | 18:02 |
rosmaita | not a big deal | 18:02 |
abhishekk | specs looks good to me, we still have next week if it get approves then we can release new version | 18:02 |
freefood | abhishekk: I'm trying to build docs locally with `tox -e docs` | 18:23 |
abhishekk | freefood, and it is failing with some error related to hacking module not exist | 18:24 |
freefood | yes | 18:24 |
freefood | and I'm surprised because it's the master branch | 18:24 |
abhishekk | I am just wondering why it is not failing in check/gate jobs | 18:24 |
freefood | exactly, I've been wondering that too | 18:24 |
freefood | can you replicate this on your machine? | 18:25 |
abhishekk | yes, its failing on my machine as well | 18:25 |
freefood | okay phew | 18:25 |
freefood | As I said above, I suspect this particular commit cause this error | 18:25 |
freefood | https://opendev.org/openstack/glance/commit/6d2c55bc769107207bd2a39059701b76ab27f2b0 | 18:25 |
abhishekk | I will spend some time tomorrow to understand the reason | 18:25 |
freefood | this commit is made by Zuul. This looks like a routine job | 18:26 |
abhishekk | likely | 18:26 |
freefood | If I add `hacking` to doc/requirements.txt, the error resolves, then there's another one: "glance/doc/source/contributor/api/glance.hacking.rst is not added to source tree" | 18:27 |
freefood | This tilted me to be more sure on the probable cause of 6d2c55bc769107207bd2a39059701b76ab27f2b0 | 18:27 |
abhishekk | ohh | 18:28 |
freefood | for now, do you recommend me to let Zuul build do the building job and skip the local build for now? | 18:28 |
abhishekk | freefood, for time being yes | 18:28 |
freefood | Thanks for your attention! :) :) | 18:28 |
abhishekk | freefood, no problem :D | 18:29 |
openstackgerrit | Merged openstack/python-glanceclient master: Update master for stable/ussuri https://review.opendev.org/718105 | 18:38 |
openstackgerrit | Merged openstack/python-glanceclient stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/718103 | 18:39 |
openstackgerrit | Merged openstack/python-glanceclient stable/ussuri: Update TOX/UPPER_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/718104 | 18:40 |
freefood | that feeling when you carefully crafted a looong bug report, then accidentally clicked on a link, then the drafting bug is destroyed :( :( | 18:51 |
freefood | I'll never draft directly on launchpad again :( | 18:51 |
abhishekk | :D | 19:05 |
abhishekk | I always use notepad first | 19:05 |
freefood | gmann told me to submit the same bug summary again and BOOM! My lost edit is resurrected! | 19:12 |
freefood | undocumented feature it is | 19:12 |
openstackgerrit | Merged openstack/glance master: Add Policy enforcement for several Metadata Definition delete APIs https://review.opendev.org/584530 | 19:29 |
abhishekk | cool | 19:43 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Add description of how to use S3 driver https://review.opendev.org/710894 | 19:46 |
abhishekk | rebased patchset with master ^^ | 19:47 |
freefood | abhishekk: When the patchset author rebase the patchset, does it invalidate the existing approvals/reviews of that patch? | 19:58 |
freefood | For example, says you already approved my patch and I have all I need to merge the patch to master, however, someone else patch has been merged before me, so I have to rebase. Then, do I lose your approval after my rebase? | 19:59 |
freefood | (meaning you have to review my new patchset of the patch and approve again?) | 20:00 |
freefood | or it depends on which lines the rebase touches? | 20:01 |
*** rcernin has joined #openstack-glance | 22:11 | |
*** tkajinam has joined #openstack-glance | 22:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!