openstackgerrit | kayluu proposed openstack/glance master: Update 'common image properties' doc https://review.opendev.org/718287 | 01:01 |
---|---|---|
*** gyee has quit IRC | 01:07 | |
*** Liang__ has joined #openstack-glance | 01:13 | |
openstackgerrit | kayluu proposed openstack/glance master: Update OS::Glance::CommonImageProperties in metadefs https://review.opendev.org/718292 | 01:21 |
*** brinzhang_ has quit IRC | 02:59 | |
*** brinzhang_ has joined #openstack-glance | 02:59 | |
*** evrardjp has quit IRC | 04:36 | |
*** evrardjp has joined #openstack-glance | 04:37 | |
abhishekk | freefood, most probably it doesn't loose approval on clean rebase | 04:55 |
openstackgerrit | kayluu proposed openstack/glance master: Add missing Image property hw_vif_multiqueue_enabled to metadefs https://review.opendev.org/718307 | 04:58 |
openstackgerrit | kayluu proposed openstack/glance master: Add missing Image property hw_vif_multiqueue_enabled to metadefs https://review.opendev.org/718307 | 04:59 |
*** brinzhang has joined #openstack-glance | 05:08 | |
*** brinzhang_ has quit IRC | 05:11 | |
*** ratailor has joined #openstack-glance | 05:17 | |
*** udesale has joined #openstack-glance | 05:22 | |
*** udesale has quit IRC | 05:23 | |
*** udesale has joined #openstack-glance | 05:23 | |
freefood | abhishekk: Thanks. Also, Brian told me to ask you if these two bugs are still relevant/valid | 05:51 |
freefood | https://bugs.launchpad.net/glance/+bug/1845338 | 05:51 |
openstack | Launchpad bug 1845338 in Glance " Make location API compatible with multiple store" [Undecided,New] | 05:51 |
freefood | https://bugs.launchpad.net/glance/+bug/1843526 | 05:51 |
openstack | Launchpad bug 1843526 in Glance " Add periodic job to prefetch images into cache" [Undecided,New] | 05:51 |
abhishekk | those are fixed | 05:51 |
freefood | These are not really literal "bugs" but some todos | 05:52 |
freefood | okay | 05:52 |
freefood | should I change them to "Fix Released" | 05:53 |
freefood | !check out sleep Zzzz | 05:56 |
openstack | freefood: Error: "check" is not a valid command. | 05:56 |
abhishekk | freefood, yes | 05:57 |
*** gtema has joined #openstack-glance | 06:30 | |
*** gtema has quit IRC | 06:38 | |
*** gtema has joined #openstack-glance | 06:40 | |
*** gtema has quit IRC | 06:45 | |
*** gtema has joined #openstack-glance | 06:45 | |
*** lpetrut has joined #openstack-glance | 07:09 | |
*** belmoreira has joined #openstack-glance | 07:16 | |
*** gtema has quit IRC | 07:44 | |
*** brinzhang_ has joined #openstack-glance | 07:48 | |
*** brinzhang has quit IRC | 07:51 | |
*** gtema has joined #openstack-glance | 07:58 | |
*** gtema has quit IRC | 08:04 | |
*** gtema has joined #openstack-glance | 08:07 | |
*** brinzhang has joined #openstack-glance | 08:10 | |
*** brinzhang_ has quit IRC | 08:13 | |
*** brinzhang_ has joined #openstack-glance | 08:14 | |
*** brinzhang has quit IRC | 08:15 | |
*** rcernin has quit IRC | 08:27 | |
*** tkajinam has quit IRC | 08:51 | |
*** brinzhang has joined #openstack-glance | 09:06 | |
*** brinzhang_ has quit IRC | 09:09 | |
*** Liang__ has quit IRC | 09:38 | |
openstackgerrit | Rajat Dhasmana proposed openstack/glance_store master: Refactor Glance Cinder Store https://review.opendev.org/718361 | 09:42 |
*** brinzhang_ has joined #openstack-glance | 09:52 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Fix multiple image imports if boolean input passed as string https://review.opendev.org/718367 | 09:52 |
*** brinzhang has quit IRC | 09:55 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance master: Imported Translations from Zanata https://review.opendev.org/718377 | 10:22 |
*** brinzhang has joined #openstack-glance | 10:37 | |
*** brinzhang_ has quit IRC | 10:40 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store master: Imported Translations from Zanata https://review.opendev.org/718384 | 10:44 |
*** brinzhang_ has joined #openstack-glance | 10:57 | |
*** brinzhang has quit IRC | 11:00 | |
openstackgerrit | Merged openstack/glance master: Add description of how to use S3 driver https://review.opendev.org/710894 | 11:11 |
*** gtema has left #openstack-glance | 11:12 | |
*** ratailor has quit IRC | 11:16 | |
abhishekk | freefood, sorry didn't got time to look at docs issue, will look tomorrow first thing | 11:23 |
*** brinzhang has joined #openstack-glance | 11:47 | |
openstackgerrit | Merged openstack/glance master: Add deprecation message to policy "default" rule https://review.opendev.org/698793 | 11:49 |
*** brinzhang_ has quit IRC | 11:50 | |
*** tkajinam has joined #openstack-glance | 12:14 | |
*** brinzhang has quit IRC | 12:19 | |
*** brinzhang has joined #openstack-glance | 12:23 | |
*** brinzhang has quit IRC | 12:23 | |
openstackgerrit | Sean McGinnis proposed openstack/glance_store master: Enforce constraints for docs dependencies https://review.opendev.org/718423 | 12:43 |
*** udesale_ has joined #openstack-glance | 13:18 | |
*** udesale has quit IRC | 13:20 | |
*** jv has quit IRC | 13:23 | |
*** jv has joined #openstack-glance | 13:27 | |
*** Liang__ has joined #openstack-glance | 13:50 | |
*** Liang__ is now known as LiangFang | 14:00 | |
*** belmoreira has quit IRC | 14:02 | |
noonedeadpunk | hi everyone | 14:19 |
noonedeadpunk | just wanted to ask if using glance with uwsgi is still the problem for interoperable import feature? | 14:20 |
*** udesale_ has quit IRC | 14:46 | |
*** lpetrut has quit IRC | 14:46 | |
*** hoonetorg has quit IRC | 14:56 | |
*** LiangFang has quit IRC | 15:01 | |
*** priteau has joined #openstack-glance | 15:06 | |
*** gyee has joined #openstack-glance | 15:13 | |
*** hoonetorg has joined #openstack-glance | 16:02 | |
abhishekk | noonedeadpunk, yes | 16:15 |
noonedeadpunk | I see:( Was you able to track down to why it's broken? | 16:16 |
noonedeadpunk | in terms of some prespectives for it to be fixed... | 16:17 |
abhishekk | noonedeadpunk, sadly no | 16:20 |
abhishekk | we don't have enough manpower to look at it | 16:20 |
noonedeadpunk | oh, ok, I see. | 16:21 |
abhishekk | many things are broken with uwsgi apart from import feature | 16:21 |
noonedeadpunk | Yeah, actually that's why I was asking - like is it worth trying to spend some time on it or it's known not being able to fix | 16:21 |
abhishekk | such as reload config file | 16:21 |
abhishekk | noonedeadpunk, if you are planning to work on this then go ahead | 16:22 |
abhishekk | I will help as much as possible | 16:22 |
noonedeadpunk | abhishekk: ok, thanks:) Will see what I can do :) | 16:22 |
abhishekk | noonedeadpunk, no problem | 16:23 |
abhishekk | let me know if you need anything | 16:23 |
noonedeadpunk | yeah, sure | 16:23 |
abhishekk | smcginnis, rosmaita kindly have a look, https://review.opendev.org/#/c/718367/ | 16:24 |
abhishekk | when you have time | 16:25 |
rosmaita | ok | 16:25 |
rosmaita | abhishekk: do you want me to remove the glanceclient spec-lite from https://review.opendev.org/#/c/708761/ ? | 16:26 |
rosmaita | (and make it a bug) | 16:26 |
abhishekk | Yes, sounds good to me | 16:26 |
rosmaita | ok, will do that before tomorrow's meeting | 16:27 |
rosmaita | looking at the boolean thing now | 16:27 |
abhishekk | cool | 16:27 |
abhishekk | thank you | 16:27 |
abhishekk | smcginnis, thank you | 16:31 |
rosmaita | i guess we don't have those requests schematized | 16:31 |
abhishekk | nope | 16:32 |
smcginnis | Unfortunate conversation going on in #openstack-tc about image import and uwsgi, if anyone cares to chime in there. | 16:32 |
abhishekk | looking | 16:34 |
rosmaita | abhishekk: so the only problem i see with this patch is that we won't be able to schematize the requests later on | 16:35 |
rosmaita | or rather, we can, but requests using strings instead of bools that will work with this patch, will no longer work | 16:35 |
abhishekk | rosmaita, is it, I don't think so | 16:36 |
*** evrardjp has quit IRC | 16:37 | |
*** evrardjp has joined #openstack-glance | 16:37 | |
smcginnis | I suppose we can make sure the client does the transformation, then make sure the api-docs are clear for anyone using the API directly. | 16:37 |
freefood | rosmaita: When I need to change an error message string and this string also appears in other languages, should I contact the corresponding language teams to notify them? | 16:39 |
abhishekk | smcginnis, for client change we need to fix it backport it to stable/ussuri as well | 16:39 |
rosmaita | freefood: i honestly don't know any more | 16:40 |
freefood | okay np I'll ask jokke_ :) | 16:40 |
rosmaita | used to be, you make the change, and the news would automatically get propagated out to the i18n team | 16:41 |
freefood | woah | 16:41 |
rosmaita | abhishekk: how do you feel about checking whether it's a bool in the controller, and raising a BadRequest if it's not? | 16:42 |
abhishekk | sounds good | 16:43 |
rosmaita | abhishekk: left a comment with no vote on the patch | 16:49 |
abhishekk | rosmaita, thank you | 16:49 |
rosmaita | hopefully the glanceclient is sending a real bool for this | 16:49 |
rosmaita | how did you find the bug? | 16:49 |
abhishekk | glanceclient is sending string | 16:49 |
rosmaita | oh no! | 16:49 |
abhishekk | I was writing test scenarios | 16:50 |
rosmaita | hooray for test scenarios! | 16:50 |
abhishekk | I guess we can fix client later | 16:50 |
rosmaita | well, that should be a quick fix in the client | 16:50 |
abhishekk | yes it is | 16:50 |
rosmaita | sorry to make trouble | 16:51 |
abhishekk | no problem | 16:51 |
abhishekk | whats your take? | 16:51 |
abhishekk | rosmaita, we need to fix client as well otherwise every time it will raise bad request | 16:55 |
rosmaita | yes, i know | 16:55 |
abhishekk | Let me work on client patch and then backport it to ussuri | 16:56 |
rosmaita | i don't see a way around it, though | 16:56 |
abhishekk | I will post both the patches within hour | 16:56 |
rosmaita | ok, ping me and i will review | 16:56 |
abhishekk | rosmaita, yes | 16:57 |
openstackgerrit | Brian Rosmaita proposed openstack/glance-specs master: Deprecate 'checksum' computation https://review.opendev.org/708761 | 17:03 |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Fail gracefully when MD5 is unavailable https://review.opendev.org/717946 | 17:09 |
openstackgerrit | Abhishek Kekane proposed openstack/python-glanceclient master: Pass --all-stores, --allow-failure as bool to API https://review.opendev.org/718521 | 17:11 |
abhishekk | rosmaita, ^^ | 17:12 |
*** priteau has quit IRC | 17:15 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Fix multiple image imports if boolean input passed as string https://review.opendev.org/718367 | 17:47 |
abhishekk | rosmaita, submitted both the patches | 17:47 |
openstackgerrit | Merged openstack/glance_store master: Enforce constraints for docs dependencies https://review.opendev.org/718423 | 18:10 |
noonedeadpunk | abhishekk: another question about image import - is rpc used between staging and importing steps? | 18:13 |
abhishekk | noonedeadpunk, not yes | 18:13 |
abhishekk | s/yes/yet | 18:14 |
abhishekk | noonedeadpunk, it is on the table, we might change it to use RPC in near future | 18:14 |
noonedeadpunk | but is going to... just trying to figure out if setting load balancer to balance by source will help with HA | 18:14 |
noonedeadpunk | as if RPC is used only shared filesystem is going to help... | 18:15 |
noonedeadpunk | in case of multiple api endpoints | 18:15 |
noonedeadpunk | so maybe it's worth making a configurable thing? | 18:16 |
abhishekk | noonedeadpunk, frankly not thought about this yet | 18:21 |
rosmaita | abhishekk: left comments for you | 18:42 |
abhishekk | rosmaita, yes, will add unit tests later as at the moment no test coverage at all for new options in that file | 18:43 |
rosmaita | ok | 18:43 |
abhishekk | rosmaita, looking | 18:43 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Fix multiple image imports if boolean input passed as string https://review.opendev.org/718367 | 19:08 |
abhishekk | rosmaita, ^^ | 19:08 |
rosmaita | was in a meeting, will take a look now | 19:33 |
rosmaita | LGTM | 19:41 |
abhishekk | thank you | 19:41 |
freefood | abhishekk: Perhaps this is a relevant patch to the one above? https://review.opendev.org/#/c/717889/ | 20:08 |
freefood | https://review.opendev.org/#/c/717889/ | 20:09 |
abhishekk | freefood, not really | 20:10 |
abhishekk | freefood, I have created new VM, installed openstack, ran tox -e docs and the error is gone | 20:27 |
abhishekk | not able to reproduce it any more | 20:27 |
openstackgerrit | Merged openstack/python-glanceclient master: Pass --all-stores, --allow-failure as bool to API https://review.opendev.org/718521 | 20:44 |
openstackgerrit | Abhishek Kekane proposed openstack/python-glanceclient stable/ussuri: Pass --all-stores, --allow-failure as bool to API https://review.opendev.org/718551 | 20:45 |
*** rosmaita has quit IRC | 20:58 | |
*** rosmaita has joined #openstack-glance | 21:23 | |
*** rcernin has joined #openstack-glance | 22:32 | |
*** gyee has quit IRC | 22:49 | |
*** threestrands has joined #openstack-glance | 23:10 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!