Wednesday, 2020-04-08

openstackgerritkayluu proposed openstack/glance master: Update 'common image properties' doc  https://review.opendev.org/71828701:01
*** gyee has quit IRC01:07
*** Liang__ has joined #openstack-glance01:13
openstackgerritkayluu proposed openstack/glance master: Update OS::Glance::CommonImageProperties in metadefs  https://review.opendev.org/71829201:21
*** brinzhang_ has quit IRC02:59
*** brinzhang_ has joined #openstack-glance02:59
*** evrardjp has quit IRC04:36
*** evrardjp has joined #openstack-glance04:37
abhishekkfreefood, most probably it doesn't loose approval on clean rebase04:55
openstackgerritkayluu proposed openstack/glance master: Add missing Image property hw_vif_multiqueue_enabled to metadefs  https://review.opendev.org/71830704:58
openstackgerritkayluu proposed openstack/glance master: Add missing Image property hw_vif_multiqueue_enabled to metadefs  https://review.opendev.org/71830704:59
*** brinzhang has joined #openstack-glance05:08
*** brinzhang_ has quit IRC05:11
*** ratailor has joined #openstack-glance05:17
*** udesale has joined #openstack-glance05:22
*** udesale has quit IRC05:23
*** udesale has joined #openstack-glance05:23
freefoodabhishekk: Thanks. Also, Brian told me to ask you if these two bugs are still relevant/valid05:51
freefoodhttps://bugs.launchpad.net/glance/+bug/184533805:51
openstackLaunchpad bug 1845338 in Glance " Make location API compatible with multiple store" [Undecided,New]05:51
freefoodhttps://bugs.launchpad.net/glance/+bug/184352605:51
openstackLaunchpad bug 1843526 in Glance " Add periodic job to prefetch images into cache" [Undecided,New]05:51
abhishekkthose are fixed05:51
freefoodThese are not really literal "bugs" but some todos05:52
freefoodokay05:52
freefoodshould I change them to "Fix Released"05:53
freefood!check out sleep Zzzz05:56
openstackfreefood: Error: "check" is not a valid command.05:56
abhishekkfreefood, yes05:57
*** gtema has joined #openstack-glance06:30
*** gtema has quit IRC06:38
*** gtema has joined #openstack-glance06:40
*** gtema has quit IRC06:45
*** gtema has joined #openstack-glance06:45
*** lpetrut has joined #openstack-glance07:09
*** belmoreira has joined #openstack-glance07:16
*** gtema has quit IRC07:44
*** brinzhang_ has joined #openstack-glance07:48
*** brinzhang has quit IRC07:51
*** gtema has joined #openstack-glance07:58
*** gtema has quit IRC08:04
*** gtema has joined #openstack-glance08:07
*** brinzhang has joined #openstack-glance08:10
*** brinzhang_ has quit IRC08:13
*** brinzhang_ has joined #openstack-glance08:14
*** brinzhang has quit IRC08:15
*** rcernin has quit IRC08:27
*** tkajinam has quit IRC08:51
*** brinzhang has joined #openstack-glance09:06
*** brinzhang_ has quit IRC09:09
*** Liang__ has quit IRC09:38
openstackgerritRajat Dhasmana proposed openstack/glance_store master: Refactor Glance Cinder Store  https://review.opendev.org/71836109:42
*** brinzhang_ has joined #openstack-glance09:52
openstackgerritAbhishek Kekane proposed openstack/glance master: Fix multiple image imports if boolean input passed as string  https://review.opendev.org/71836709:52
*** brinzhang has quit IRC09:55
openstackgerritOpenStack Proposal Bot proposed openstack/glance master: Imported Translations from Zanata  https://review.opendev.org/71837710:22
*** brinzhang has joined #openstack-glance10:37
*** brinzhang_ has quit IRC10:40
openstackgerritOpenStack Proposal Bot proposed openstack/glance_store master: Imported Translations from Zanata  https://review.opendev.org/71838410:44
*** brinzhang_ has joined #openstack-glance10:57
*** brinzhang has quit IRC11:00
openstackgerritMerged openstack/glance master: Add description of how to use S3 driver  https://review.opendev.org/71089411:11
*** gtema has left #openstack-glance11:12
*** ratailor has quit IRC11:16
abhishekkfreefood, sorry didn't got time to look at docs issue, will look tomorrow first thing11:23
*** brinzhang has joined #openstack-glance11:47
openstackgerritMerged openstack/glance master: Add deprecation message to policy "default" rule  https://review.opendev.org/69879311:49
*** brinzhang_ has quit IRC11:50
*** tkajinam has joined #openstack-glance12:14
*** brinzhang has quit IRC12:19
*** brinzhang has joined #openstack-glance12:23
*** brinzhang has quit IRC12:23
openstackgerritSean McGinnis proposed openstack/glance_store master: Enforce constraints for docs dependencies  https://review.opendev.org/71842312:43
*** udesale_ has joined #openstack-glance13:18
*** udesale has quit IRC13:20
*** jv has quit IRC13:23
*** jv has joined #openstack-glance13:27
*** Liang__ has joined #openstack-glance13:50
*** Liang__ is now known as LiangFang14:00
*** belmoreira has quit IRC14:02
noonedeadpunkhi everyone14:19
noonedeadpunkjust wanted to ask if using glance with uwsgi is still the problem for interoperable import feature?14:20
*** udesale_ has quit IRC14:46
*** lpetrut has quit IRC14:46
*** hoonetorg has quit IRC14:56
*** LiangFang has quit IRC15:01
*** priteau has joined #openstack-glance15:06
*** gyee has joined #openstack-glance15:13
*** hoonetorg has joined #openstack-glance16:02
abhishekknoonedeadpunk, yes16:15
noonedeadpunkI see:( Was you able to track down to why it's broken?16:16
noonedeadpunkin terms of some prespectives for it to be fixed...16:17
abhishekknoonedeadpunk, sadly no16:20
abhishekkwe don't have enough manpower to look at it16:20
noonedeadpunkoh, ok, I see.16:21
abhishekkmany things are broken with uwsgi apart from import feature16:21
noonedeadpunkYeah, actually that's why I was asking - like is it worth trying to spend some time on it or it's known not being able to fix16:21
abhishekksuch as reload config file16:21
abhishekknoonedeadpunk, if you are planning to work on this then go ahead16:22
abhishekkI will help as much as possible16:22
noonedeadpunkabhishekk: ok, thanks:) Will see what I can do :)16:22
abhishekknoonedeadpunk, no problem16:23
abhishekklet me know if you need anything16:23
noonedeadpunkyeah, sure16:23
abhishekksmcginnis, rosmaita kindly have a look, https://review.opendev.org/#/c/718367/16:24
abhishekkwhen you have time16:25
rosmaitaok16:25
rosmaitaabhishekk: do you want me to remove the glanceclient spec-lite from https://review.opendev.org/#/c/708761/ ?16:26
rosmaita(and make it a bug)16:26
abhishekkYes, sounds good to me16:26
rosmaitaok, will do that before tomorrow's meeting16:27
rosmaitalooking at the boolean thing now16:27
abhishekkcool16:27
abhishekkthank you16:27
abhishekksmcginnis, thank you16:31
rosmaitai guess we don't have those requests schematized16:31
abhishekknope16:32
smcginnisUnfortunate conversation going on in #openstack-tc about image import and uwsgi, if anyone cares to chime in there.16:32
abhishekklooking16:34
rosmaitaabhishekk: so the only problem i see with this patch is that we won't be able to schematize the requests later on16:35
rosmaitaor rather, we can, but requests using strings instead of bools that will work with this patch, will no longer work16:35
abhishekkrosmaita, is it, I don't think so16:36
*** evrardjp has quit IRC16:37
*** evrardjp has joined #openstack-glance16:37
smcginnisI suppose we can make sure the client does the transformation, then make sure the api-docs are clear for anyone using the API directly.16:37
freefoodrosmaita: When I need to change an error message string and this string also appears in other languages, should I contact the corresponding language teams to notify them?16:39
abhishekksmcginnis, for client change we need to fix it backport it to stable/ussuri as well16:39
rosmaitafreefood: i honestly don't know any more16:40
freefoodokay np I'll ask jokke_ :)16:40
rosmaitaused to be, you make the change, and the news would automatically get propagated out to the i18n team16:41
freefoodwoah16:41
rosmaitaabhishekk: how do you feel about checking whether it's a bool in the controller, and raising a BadRequest if it's not?16:42
abhishekksounds good16:43
rosmaitaabhishekk: left a comment with no vote on the patch16:49
abhishekkrosmaita, thank you16:49
rosmaitahopefully the glanceclient is sending a real bool for this16:49
rosmaitahow did you find the bug?16:49
abhishekkglanceclient is sending string16:49
rosmaitaoh no!16:49
abhishekkI was writing test scenarios16:50
rosmaitahooray for test scenarios!16:50
abhishekkI guess we can fix client later16:50
rosmaitawell, that should be a quick fix in the client16:50
abhishekkyes it is16:50
rosmaitasorry to make trouble16:51
abhishekkno problem16:51
abhishekkwhats your take?16:51
abhishekkrosmaita, we need to fix client as well otherwise every time it will raise bad request16:55
rosmaitayes, i know16:55
abhishekkLet me work on client patch and then backport it to ussuri16:56
rosmaitai don't see a way around it, though16:56
abhishekkI will post both the patches within hour16:56
rosmaitaok, ping me and i will review16:56
abhishekkrosmaita, yes16:57
openstackgerritBrian Rosmaita proposed openstack/glance-specs master: Deprecate 'checksum' computation  https://review.opendev.org/70876117:03
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Fail gracefully when MD5 is unavailable  https://review.opendev.org/71794617:09
openstackgerritAbhishek Kekane proposed openstack/python-glanceclient master: Pass --all-stores, --allow-failure as bool to API  https://review.opendev.org/71852117:11
abhishekkrosmaita, ^^17:12
*** priteau has quit IRC17:15
openstackgerritAbhishek Kekane proposed openstack/glance master: Fix multiple image imports if boolean input passed as string  https://review.opendev.org/71836717:47
abhishekkrosmaita, submitted both the patches17:47
openstackgerritMerged openstack/glance_store master: Enforce constraints for docs dependencies  https://review.opendev.org/71842318:10
noonedeadpunkabhishekk: another question about image import - is rpc used between staging and importing steps?18:13
abhishekknoonedeadpunk, not yes18:13
abhishekks/yes/yet18:14
abhishekknoonedeadpunk, it is on the table, we might change it to use RPC in near future18:14
noonedeadpunkbut is going to... just trying to figure out if setting load balancer to balance by source will help with HA18:14
noonedeadpunkas if RPC is used only shared filesystem is going to help...18:15
noonedeadpunkin case of multiple api endpoints18:15
noonedeadpunkso maybe it's worth making a configurable thing?18:16
abhishekknoonedeadpunk, frankly not thought about this yet18:21
rosmaitaabhishekk: left comments for you18:42
abhishekkrosmaita, yes, will add unit tests later as at the moment no test coverage at all for new options in that file18:43
rosmaitaok18:43
abhishekkrosmaita, looking18:43
openstackgerritAbhishek Kekane proposed openstack/glance master: Fix multiple image imports if boolean input passed as string  https://review.opendev.org/71836719:08
abhishekkrosmaita, ^^19:08
rosmaitawas in a meeting, will take a look now19:33
rosmaitaLGTM19:41
abhishekkthank you19:41
freefoodabhishekk: Perhaps this is a relevant patch to the one above? https://review.opendev.org/#/c/717889/20:08
freefoodhttps://review.opendev.org/#/c/717889/20:09
abhishekkfreefood, not really20:10
abhishekkfreefood, I have created new VM, installed openstack, ran tox -e docs and the error is gone20:27
abhishekknot able to reproduce it any more20:27
openstackgerritMerged openstack/python-glanceclient master: Pass --all-stores, --allow-failure as bool to API  https://review.opendev.org/71852120:44
openstackgerritAbhishek Kekane proposed openstack/python-glanceclient stable/ussuri: Pass --all-stores, --allow-failure as bool to API  https://review.opendev.org/71855120:45
*** rosmaita has quit IRC20:58
*** rosmaita has joined #openstack-glance21:23
*** rcernin has joined #openstack-glance22:32
*** gyee has quit IRC22:49
*** threestrands has joined #openstack-glance23:10

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!