| *** rcernin has quit IRC | 02:59 | |
| *** rcernin has joined #openstack-glance | 03:08 | |
| *** rcernin has quit IRC | 03:19 | |
| *** rcernin has joined #openstack-glance | 03:30 | |
| *** baojg has joined #openstack-glance | 03:52 | |
| *** baojg has quit IRC | 03:53 | |
| *** baojg has joined #openstack-glance | 03:53 | |
| *** baojg has quit IRC | 03:54 | |
| *** baojg has joined #openstack-glance | 03:54 | |
| *** baojg has quit IRC | 03:54 | |
| *** baojg has joined #openstack-glance | 03:55 | |
| *** baojg has quit IRC | 03:55 | |
| *** baojg has joined #openstack-glance | 03:55 | |
| *** baojg has quit IRC | 03:56 | |
| *** baojg has joined #openstack-glance | 03:57 | |
| *** baojg has quit IRC | 03:58 | |
| *** baojg has joined #openstack-glance | 03:59 | |
| *** baojg has quit IRC | 03:59 | |
| *** baojg has joined #openstack-glance | 03:59 | |
| *** baojg has quit IRC | 04:00 | |
| *** baojg has joined #openstack-glance | 04:00 | |
| *** baojg has quit IRC | 04:01 | |
| *** udesale has joined #openstack-glance | 04:20 | |
| *** rosmaita has left #openstack-glance | 04:43 | |
| *** baojg has joined #openstack-glance | 05:34 | |
| *** m75abrams has joined #openstack-glance | 06:09 | |
| *** ralonsoh has joined #openstack-glance | 07:40 | |
| *** hoonetorg has joined #openstack-glance | 07:47 | |
| *** rcernin has quit IRC | 07:51 | |
| *** nikparasyr has joined #openstack-glance | 08:32 | |
| *** ralonsoh has quit IRC | 08:38 | |
| *** ralonsoh has joined #openstack-glance | 08:41 | |
| *** lpetrut has joined #openstack-glance | 08:45 | |
| *** yoctozepto has quit IRC | 08:48 | |
| *** baojg has quit IRC | 11:01 | |
| *** udesale_ has joined #openstack-glance | 11:14 | |
| *** udesale has quit IRC | 11:17 | |
| *** zzzeek has quit IRC | 11:33 | |
| *** zzzeek has joined #openstack-glance | 11:35 | |
| *** rcernin has joined #openstack-glance | 11:51 | |
| *** zzzeek has quit IRC | 12:19 | |
| *** rcernin has quit IRC | 12:21 | |
| *** zzzeek has joined #openstack-glance | 12:21 | |
| *** Luzi has joined #openstack-glance | 12:56 | |
| *** rosmaita has joined #openstack-glance | 13:04 | |
| *** yoctozepto has joined #openstack-glance | 13:45 | |
| *** udesale_ has quit IRC | 13:51 | |
| *** ralonsoh_ has joined #openstack-glance | 13:59 | |
| *** ralonsoh has quit IRC | 13:59 | |
| *** ralonsoh_ is now known as ralonsoh | 14:01 | |
| *** Luzi has quit IRC | 14:04 | |
| *** ralonsoh has quit IRC | 14:37 | |
| *** ralonsoh has joined #openstack-glance | 14:38 | |
| *** ralonsoh has quit IRC | 14:40 | |
| abhishekk | dansmith, sorry I missed you by couple of minutes on Friday, I am around now | 14:44 |
|---|---|---|
| dansmith | abhishekk: that's okay I figured it was too late | 14:44 |
| abhishekk | welcome back and happy new year | 14:45 |
| dansmith | thanks, you too | 14:45 |
| abhishekk | thank you | 14:45 |
| dansmith | abhishekk: so unless you know of other work going on to implement that distributed import spec, I'll keep working on making that ready | 14:46 |
| dansmith | since there are still revisions on the spec not yet made, I figure there's no code either | 14:47 |
| *** m75abrams has quit IRC | 14:47 | |
| abhishekk | Yeah, I think so | 14:48 |
| abhishekk | between went through the patch and it looks better and simple to understand | 14:49 |
| dansmith | it's what we discussed at PTG | 14:49 |
| abhishekk | yes | 14:50 |
| dansmith | but yeah, figured it would be helpful to just put it into code to get things moving | 14:50 |
| abhishekk | ++ | 14:50 |
| abhishekk | dansmith, just to update you I am going on PTO from 13 to 21 January to attend sister's wedding | 14:50 |
| dansmith | I just saw the email... I'll allow it :P | 14:51 |
| abhishekk | you guys needs to look after 2nd milestone which is due next week | 14:51 |
| abhishekk | thank you :D | 14:51 |
| dansmith | does anything specific need doing for m2? | 14:51 |
| *** m75abrams has joined #openstack-glance | 14:52 | |
| abhishekk | we just need to get specs approved during m2 | 14:52 |
| abhishekk | I will try to push new revision of task show api by tomorrow | 14:52 |
| abhishekk | I am just not sure how useful it will be if we add image-id field in task db table | 14:54 |
| *** spotz has joined #openstack-glance | 14:57 | |
| abhishekk | dansmith, also here I am recording results of manual testing done with secure RBAC changes posted for glance | 14:58 |
| abhishekk | https://etherpad.opendev.org/p/glance-rbac-testing | 14:58 |
| dansmith | abhishekk: we need image-id and request-id, it seems to me | 14:59 |
| abhishekk | dansmith, yes, as pointed out by rosmaita it is in input section and not indexable at the moment | 15:00 |
| dansmith | yeah, so one migration to add both of those seems like a good plan to me | 15:00 |
| abhishekk | Ack, I will push the new revision tomorrow and will try to modify my PoC as well | 15:01 |
| dansmith | cool | 15:01 |
| dansmith | jokke: are we likely to see a rev of the distributed spec in time to have it reviews and merged by next week? | 15:02 |
| dansmith | if not and you prefer, I can rev it to match the comments and proposal if it would help | 15:02 |
| abhishekk | I am not sure about making updates in Poc, but will update the specs for sure | 15:02 |
| dansmith | okay, well, more time for the code than spec, so that's okay right? | 15:03 |
| abhishekk | right | 15:03 |
| abhishekk | So just to be sure, we need to return all tasks associated with the image-id (which are not expired) | 15:04 |
| dansmith | yeah, that's what I'm proposing | 15:04 |
| abhishekk | ack | 15:05 |
| dansmith | if I submit a request at the same time as another client, mine fails immediately and another one starts running, | 15:05 |
| dansmith | I can see that by looking through the list and finding the one that matches my request-id.. | 15:05 |
| dansmith | without that, I can only see the running one and assume it's mine | 15:05 |
| abhishekk | got it | 15:06 |
| rosmaita | is there a 'user' field in the task? | 15:06 |
| dansmith | IIRC we have a functional test that has to cheat in order to reliably test this API, so that should be a good indication that a real client would be out of luck :) | 15:06 |
| abhishekk | I think owner is there | 15:06 |
| dansmith | yeah owner on task | 15:06 |
| rosmaita | yeah, but that will be the project | 15:06 |
| dansmith | oh user, I see | 15:07 |
| rosmaita | maybe we should think about adding user? | 15:07 |
| dansmith | ...since we're adding stuff, yeah... easier to do it in one go | 15:07 |
| rosmaita | that was my thought | 15:07 |
| rosmaita | client tooling will have the request-id, but normal people won't | 15:07 |
| dansmith | sure | 15:07 |
| rosmaita | abhishekk: this simple spec just keeps getting bigger and bigger! | 15:08 |
| dansmith | rosmaita: sidebar, since you were reviewing the spec, could you have a quick gander at my PoC for the distributed import thing here? it's very small: https://review.opendev.org/c/openstack/glance/+/769976 | 15:08 |
| rosmaita | dansmith: sure | 15:08 |
| dansmith | thanks | 15:08 |
| abhishekk | rosmaita, :D | 15:09 |
| *** lpetrut has quit IRC | 15:10 | |
| *** ralonsoh has joined #openstack-glance | 15:16 | |
| *** m75abrams has quit IRC | 15:52 | |
| *** nikparasyr has left #openstack-glance | 16:09 | |
| dansmith | gmann: I have a dumb question that you probably know the answer to | 16:46 |
| dansmith | gmann: I want to raise a webob.exc.HTTPError with a specific code and reason string, but it seems like I can't actually provide that, I have to choose one of the subclasses | 16:47 |
| dansmith | gmann: what do we do when we need to raise an http error by code instead of by name? Meaning raise HTTPError(code=some_variable, reason=other_variable) | 16:47 |
| gmann | dansmith: hi | 16:54 |
| *** gyee has joined #openstack-glance | 16:55 | |
| gmann | dansmith: I think you can pass via more detail on reason via 'detail' | 16:55 |
| dansmith | >>> webob.exc.HTTPError(detail='foo') | 16:56 |
| dansmith | <HTTPError at 0x7f62e3a22d00 500 Internal Server Error> | 16:56 |
| gmann | not sure if code can be passed but let me check if possible for HTTPError other HTTP exception it cannot be | 16:56 |
| dansmith | it seems to me that all the intermediate classes between the base and the subclasses expect each subclass to have a class-level variable of "code" | 16:56 |
| gmann | yeah for all HTTP yes (I need to check what is hard coded code for HTTPError ) otherwise base self.code which is 500 is used | 16:58 |
| dansmith | okay so maybe I need to make a subclass with @property for code or something so I can pass it through | 16:59 |
| gmann | dansmith: yeah, or use specific HTTP* if any of them match code you want | 17:02 |
| gmann | dansmith: other way is to use urllib.error.HTTPError there you can pass code and reason. | 17:02 |
| dansmith | ah does that work? I can raise that? | 17:02 |
| gmann | yes that take code and msg | 17:03 |
| dansmith | ah perfect thanks | 17:03 |
| *** openstackgerrit has quit IRC | 17:37 | |
| dansmith | abhishekk: ISTR in the past working on the task lock thing that you had an image property that was excluded from the view | 18:03 |
| dansmith | kinda like _reserved_properties, but _hidden_properties ... I don't see that now though.. do you remember if you added that exclusion list just for that or if I'm missing somewhere else where we can hide properties? | 18:04 |
| dansmith | nm, I don't see it, so I'll just add it for my purposes | 19:15 |
| *** gmann is now known as gmann_afk | 19:25 | |
| *** ralonsoh has quit IRC | 20:44 | |
| *** gmann_afk is now known as gmann | 21:13 | |
| *** hoonetorg has quit IRC | 21:22 | |
| *** hoonetorg has joined #openstack-glance | 21:40 | |
| *** rcernin has joined #openstack-glance | 22:07 | |
| *** rcernin has quit IRC | 22:09 | |
| *** rcernin has joined #openstack-glance | 22:11 | |
| *** tkajinam has joined #openstack-glance | 22:57 | |
| dansmith | gmann: hmm, raising urllib.error.HTTPError with a code of something like 40x causes the wsgi stack in glance to return 500, presumably because it think it's just an unknown exception (i.e. instead of webob.exc.something) | 23:38 |
| *** rcernin_ has joined #openstack-glance | 23:54 | |
| *** rcernin has quit IRC | 23:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!