*** baojg has joined #openstack-glance | 01:49 | |
*** baojg has quit IRC | 02:38 | |
*** rcernin_ has quit IRC | 03:14 | |
*** zzzeek has quit IRC | 04:06 | |
*** zzzeek has joined #openstack-glance | 04:07 | |
*** rcernin_ has joined #openstack-glance | 04:25 | |
*** rcernin_ has quit IRC | 04:25 | |
*** rcernin has joined #openstack-glance | 04:25 | |
*** udesale has joined #openstack-glance | 04:50 | |
*** ratailor has joined #openstack-glance | 05:56 | |
*** m75abrams has joined #openstack-glance | 06:10 | |
*** gyee has quit IRC | 06:17 | |
*** openstackgerrit has joined #openstack-glance | 06:21 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance-specs master: New Image API /v2/images/{id}/tasks for task information https://review.opendev.org/c/openstack/glance-specs/+/763740 | 06:21 |
---|---|---|
*** rcernin has quit IRC | 06:26 | |
*** rcernin has joined #openstack-glance | 06:26 | |
*** hoonetorg has quit IRC | 06:34 | |
*** zzzeek has quit IRC | 07:02 | |
*** zzzeek has joined #openstack-glance | 07:07 | |
*** rcernin has quit IRC | 07:07 | |
*** nikparasyr has joined #openstack-glance | 07:27 | |
*** ralonsoh has joined #openstack-glance | 07:48 | |
*** ratailor has quit IRC | 07:56 | |
*** ratailor has joined #openstack-glance | 07:56 | |
*** m75abrams has quit IRC | 08:37 | |
*** udesale_ has joined #openstack-glance | 10:33 | |
*** udesale has quit IRC | 10:36 | |
*** m75abrams has joined #openstack-glance | 11:29 | |
*** udesale_ has quit IRC | 11:42 | |
*** Luzi has joined #openstack-glance | 11:47 | |
*** udesale has joined #openstack-glance | 12:19 | |
*** m75abrams has quit IRC | 12:31 | |
*** m75abrams has joined #openstack-glance | 12:32 | |
*** ratailor has quit IRC | 12:40 | |
*** udesale_ has joined #openstack-glance | 13:01 | |
*** m75abrams has quit IRC | 13:03 | |
*** udesale has quit IRC | 13:04 | |
*** m75abrams has joined #openstack-glance | 13:04 | |
abhishekk | dansmith, I think I have used reserved properties | 13:40 |
rosmaita | abhishekk: dansmith: i forgot about _reserved_properties, so you can disregard all suggestions about using property protections | 13:58 |
abhishekk | :D | 13:58 |
gmann | dansmith: i do not think, you use expected_error kind of decorator in glance to restrict the range of return error. | 14:03 |
gmann | anyways I will check after QA office hour | 14:03 |
*** udesale_ has quit IRC | 14:10 | |
*** udesale has joined #openstack-glance | 14:10 | |
*** Luzi has quit IRC | 14:31 | |
openstackgerrit | Erno Kuvaja proposed openstack/glance-specs master: Distrbuted Image Import via request proxying https://review.opendev.org/c/openstack/glance-specs/+/763574 | 14:37 |
dansmith | gmann: ah, okay that might be it, thanks for the hint | 14:40 |
gmann | dansmith: i did not find any such decorator but this is place where urllib.error.HTTPError is converted to 500 https://github.com/openstack/glance/blob/73742be99944d923031aa5f90e06051126b17007/glance/common/wsgi.py#L1358 | 15:12 |
gmann | dansmith: but if it going to webob layer then it will understand urllib.error.HTTPError while preparing response. I think subclass option is easy way to go. | 15:24 |
gmann | *will not understand | 15:24 |
dansmith | gmann: okay I have the subclass option working, when I post next I'll let you look and see if you think it's terrible enough to do something else ;) | 15:25 |
gmann | yeah, | 15:25 |
*** lbragstad has quit IRC | 15:29 | |
*** lbragstad has joined #openstack-glance | 15:34 | |
*** lbragstad has quit IRC | 15:35 | |
*** lbragstad has joined #openstack-glance | 15:35 | |
*** udesale has quit IRC | 16:15 | |
*** m75abrams has quit IRC | 16:40 | |
*** openstackgerrit has quit IRC | 16:55 | |
*** ralonsoh has quit IRC | 18:02 | |
*** nikparasyr has left #openstack-glance | 18:13 | |
*** ianw_pto is now known as ianw | 18:58 | |
*** gyee has joined #openstack-glance | 19:02 | |
dansmith | rosmaita: as I understand it, we need to get specs merged while abhishekk is gone | 21:15 |
dansmith | I have a bunch of nits on his tasks api spec, which I can fix and then +2 | 21:16 |
dansmith | I had one larger suggestion, which I can also do: https://review.opendev.org/c/openstack/glance-specs/+/763740/5/specs/wallaby/approved/glance/expose_task_show_api.rst#29 | 21:16 |
rosmaita | dansmith: only the glance PTL can actually merge specs | 21:16 |
dansmith | which is to rephrase the problem as "Users ain't got no task info" | 21:16 |
dansmith | rosmaita: oh | 21:16 |
rosmaita | i guess we can just get them all ready and +2'd though | 21:17 |
dansmith | he said: [06:52:31] <abhishekk> we just need to get specs approved during m2 | 21:17 |
dansmith | so yeah anyway, +2d is probably good | 21:17 |
rosmaita | it will be a nice surprise for him when he gets back | 21:17 |
dansmith | anyway, if you could make sure you're good with his latest, plus judge my suggestion, I'll revise for him and +2 | 21:19 |
rosmaita | ok, cool | 21:26 |
*** lbragstad has quit IRC | 21:35 | |
*** lbragstad has joined #openstack-glance | 21:38 | |
rosmaita | dansmith: left comments on https://review.opendev.org/c/openstack/glance-specs/+/763740 | 22:05 |
dansmith | rosmaita: thanks I'll push up in a bit | 22:30 |
rosmaita | ok | 22:30 |
jokke | dansmith: rosmaita: I hope my reasoning made sense in the request proxy spec. thanks for the review | 22:33 |
dansmith | jokke: I'm not really seeing the benefit of plumbing it through all those layers, honestly, but I'm sure it's just my lack of experience with all those other things | 22:39 |
dansmith | I'll defer to the more literate reviewers | 22:39 |
*** openstackgerrit has joined #openstack-glance | 22:58 | |
openstackgerrit | Dan Smith proposed openstack/glance master: WIP: Distributed image import https://review.opendev.org/c/openstack/glance/+/769976 | 22:58 |
dansmith | BTW, I have devstack working for this (locally at least): https://review.opendev.org/c/openstack/devstack/+/770487 | 23:00 |
dansmith | and will hope to have a tempest test actually staging and importing against disparate workers tomorrow | 23:01 |
*** rcernin has joined #openstack-glance | 23:02 | |
openstackgerrit | Dan Smith proposed openstack/glance-specs master: New Image API /v2/images/{id}/tasks for task information https://review.opendev.org/c/openstack/glance-specs/+/763740 | 23:09 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!