| *** akekane__ is now known as abhishekk | 05:54 | |
| opendevreview | HanGuangyu proposed openstack/glance master: Make "killed" images list available using the CLI https://review.opendev.org/c/openstack/glance/+/806134 | 08:58 |
|---|---|---|
| opendevreview | HanGuangyu proposed openstack/glance master: Make "killed" images list available using the CLI https://review.opendev.org/c/openstack/glance/+/806134 | 09:03 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 09:20 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 09:20 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 09:20 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 09:20 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 09:20 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 12:18 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 12:18 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 12:18 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 12:18 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 12:18 |
| abhishekk | dansmith, today it will be only you and me in the meeting, rosmaita will be busy in cinder and jokke_ and cyril or on leave | 13:49 |
| abhishekk | we will wrap it quickly | 13:50 |
| dansmith | heh okay | 13:50 |
| rosmaita | abhishekk: ty | 13:50 |
| abhishekk | rosmaita, np | 13:51 |
| abhishekk | that was really quick | 14:08 |
| dansmith | \o/ | 14:08 |
| dansmith | left you a question on the bottom metadef patch | 14:08 |
| abhishekk | dansmith, yep, will have a look | 14:09 |
| abhishekk | dansmith, do you mean we should also call _update_namespace after line 404 ? | 14:11 |
| dansmith | oh jeez | 14:12 |
| dansmith | hang on | 14:12 |
| abhishekk | ack | 14:12 |
| dansmith | yeah sorry I'm an idiot.. I mis-read that yesterday and then assumed today that it was as I read it yesterday | 14:13 |
| dansmith | I was thinking that was a delete as admin, followed by attempts to delete it as a non-admin | 14:14 |
| dansmith | which makes no sense since you're deleting at the bottom as admin | 14:14 |
| abhishekk | no worries, i can understand, | 14:15 |
| abhishekk | lbragstad, if you have look at metadef RBAC patches then we could start merging it (I know you are busy as well) | 14:19 |
| lbragstad | abhishekk ok - i can take a look today | 14:19 |
| lbragstad | last i looked i think they are good | 14:19 |
| lbragstad | i was mostly concerned about the duplication across the functional tests | 14:20 |
| abhishekk | lbragstad, also can I rebase your patches on top of mine ? | 14:20 |
| lbragstad | abhishekk yeah - go for it | 14:20 |
| lbragstad | i just threw those up to get the various consolidation ideas out of my head and written down somewhere | 14:20 |
| lbragstad | if they don't make sense, feel free to abandon | 14:21 |
| abhishekk | lbragstad, cool, will rebase them, thank you | 14:21 |
| dansmith | lbragstad: the duplication definitely needs some attention, but are we holding these up for that? | 14:21 |
| lbragstad | but... it would be cool to consolidate some of the testing stuff before we retrofit that API with system scope (if we decide to) | 14:21 |
| lbragstad | since we're just be doing more copy/pasta to test those personas | 14:22 |
| lbragstad | dansmith abhishekk i'll defer to both of you if you want to address the consolidation | 14:22 |
| abhishekk | lbragstad, I think we can add/work on tempest-plugin work after m3 as well as we don't release tempest plugin | 14:23 |
| dansmith | it's definitely a lot of duplication and I'd like to see it share more, but I think abhishekk would probably prioritize getting it in | 14:23 |
| abhishekk | ++ | 14:23 |
| lbragstad | but - a lot of my comments on those reviews were focused on nit picking consolidation techniques, so i put my money where my mouth is and started proposing ways to do that - it's your call if you want to hold up the project persona work for the metadef api | 14:23 |
| lbragstad | i'm happy to continue helping with that if you think it's a priority | 14:24 |
| dansmith | oh, I hadn't seen those on top | 14:24 |
| abhishekk | It's a priority for us, and I will rebase them | 14:24 |
| dansmith | we can merge those after the deadline surely, as they're just test cleanups | 14:24 |
| lbragstad | right | 14:24 |
| abhishekk | so we still have 3-4 days in hand | 14:24 |
| abhishekk | before tagging m3 | 14:24 |
| dansmith | oh sure, that's totally cool, I was thinking you wanted all the proposed ones re-written on top of common stuff | 14:25 |
| lbragstad | but - they're mostly focused on the FunctionalTest base class | 14:25 |
| dansmith | abhishekk: we can merge test cleanups even after m3 yeah? | 14:25 |
| abhishekk | right | 14:25 |
| lbragstad | i'm not sure if we want to retrofit them to use SynchronousAPIBase instead? | 14:26 |
| abhishekk | lbragstad, that was in my mind, but due to lack of time I avoided it | 14:26 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Remove duplicate namespace utilities in functional tests https://review.opendev.org/c/openstack/glance/+/806775 | 14:55 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move global constants to test module setUp https://review.opendev.org/c/openstack/glance/+/806779 | 15:24 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Remove duplicate _url() methods from functional test classes https://review.opendev.org/c/openstack/glance/+/806797 | 15:53 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Remove duplicate _header() implementations in metadef tests https://review.opendev.org/c/openstack/glance/+/806801 | 15:53 |
| * abhishekk going for dinner break | 16:09 | |
| abhishekk | just to update all, apart from Secure RBAC, we need config refresh and release note patch for M3, I will submit them tomorrow | 17:41 |
| abhishekk | I am planning to tag M3 on Sept 08 around 1400 UTC | 17:41 |
| dansmith | abhishekk: those are just mechanical right? link me and I'll look | 17:41 |
| abhishekk | yes | 17:42 |
| * abhishekk thinking of signing out early | 17:53 | |
| abhishekk | dansmith, not urgent, but do you think we should follow this approach to test our code with pacific version of ceph ? | 17:59 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/806774 | 17:59 |
| abhishekk | gmann, ^^ | 18:00 |
| dansmith | idk, seems okay if we're pushing past the current default | 18:02 |
| abhishekk | ack | 18:02 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Add Yoga directory for specs https://review.opendev.org/c/openstack/glance-specs/+/807197 | 18:22 |
| opendevreview | Abhishek Kekane proposed openstack/glance-specs master: Add Yoga directory for specs https://review.opendev.org/c/openstack/glance-specs/+/807197 | 18:39 |
| * abhishekk signing out for the day | 18:41 | |
| dansmith | lbragstad: you don't have +1s on a bunch of the metadef persona patches.. are you planning to try to hit those? | 19:57 |
| dansmith | I've been +2ing without +Wing hoping you would :) | 19:57 |
| lbragstad | dansmith yeah - i'll start taking a look, just wrapping up a pile of sprint planning | 20:03 |
| dansmith | kthx | 20:05 |
| dansmith | I shall go do some stuff and circle back to +W what you find acceptable | 20:05 |
| lbragstad | dansmith pdeore_ i think the first few in that series look good | 20:34 |
| lbragstad | i'm wondering if we're missing a case here though https://review.opendev.org/c/openstack/glance/+/802055/18 | 20:34 |
| lbragstad | but namespaces, objects, and resource-types look good to me | 20:35 |
| lbragstad | (assuming we can clean up some of the smaller stuff during RC) | 20:35 |
| lbragstad | s/RC/feature freeze/ | 20:35 |
| dansmith | lbragstad: replied | 20:58 |
| dansmith | lbragstad: you know what I just realized? | 21:20 |
| dansmith | I think all of these tests are not actually testing anything | 21:20 |
| dansmith | lbragstad: because they're not setting enforce_new_defaults=True | 21:20 |
| dansmith | ...right? | 21:21 |
| * lbragstad checks | 21:21 | |
| dansmith | that's why your test just now didn't break I think | 21:21 |
| dansmith | er, well you ran just one so maybe that's why too, but I'd expect that to have broken other stuff | 21:22 |
| lbragstad | well - i'm suspicious that the test didn't break because we don't test that API in the test | 21:23 |
| * lbragstad grabs a bigger hammer | 21:23 | |
| dansmith | that's what I meant with my second statement, | 21:23 |
| dansmith | but I still think they're all wrong | 21:23 |
| lbragstad | yeah - i think you're right | 21:24 |
| lbragstad | https://paste.opendev.org/show/808557/ | 21:24 |
| lbragstad | that should break stuff, right? | 21:24 |
| lbragstad | https://paste.opendev.org/raw/808559/ | 21:25 |
| dansmith | yeah | 21:25 |
| dansmith | I think we oughta kick these out of the gate | 21:25 |
| lbragstad | agree | 21:26 |
| opendevreview | Dan Smith proposed openstack/glance master: WIP Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 21:27 |
| lbragstad | strange | 21:28 |
| lbragstad | https://github.com/openstack/glance/blob/master/glance/tests/functional/__init__.py#L415-L417 | 21:29 |
| lbragstad | i was looking for a config fixture to set the right oslo.policy options | 21:29 |
| lbragstad | but found that instead | 21:29 |
| lbragstad | now i'm not sure what the functional tests are running for policy https://github.com/openstack/glance/blob/master/glance/tests/functional/__init__.py#L406-L407 | 21:30 |
| lbragstad | :) | 21:30 |
| dansmith | ooooh right, gdi | 21:30 |
| dansmith | I knew this, I'm dumb | 21:31 |
| lbragstad | knew what? | 21:32 |
| dansmith | that it's tested in a separate job | 21:32 |
| dansmith | so this gets run without enforce on, and with enforce on: | 21:32 |
| dansmith | glance-tox-functional-py38-rbac-defaults SUCCESS | 21:32 |
| lbragstad | oh functional-py38-rbac | 21:34 |
| lbragstad | there's a tox env for it | 21:34 |
| lbragstad | yeah, i don't think i'm using that | 21:34 |
| lbragstad | trying that quick | 21:34 |
| lbragstad | ok- cool, things are failing now so that's good | 21:36 |
| dansmith | okay, so .. do we hit the list thing or not? | 21:36 |
| lbragstad | nope - | 21:37 |
| dansmith | okay, so still missing case | 21:37 |
| lbragstad | https://paste.opendev.org/raw/808560/ | 21:37 |
| lbragstad | do we want to do that in a follow up or? | 21:40 |
| dansmith | I'm fixing since I have to unfsck the mess I made anyway | 21:44 |
| lbragstad | ok - checking the first few patches prior to that one to see if they're susceptible to the same gap | 21:45 |
| dansmith | I'm getting 404 for the list | 21:46 |
| lbragstad | with your new changes? | 21:46 |
| dansmith | wait | 21:47 |
| dansmith | okay, nm, I was getting 404 fort the wrong tenant | 21:47 |
| lbragstad | the metadef object tests have the same issue | 21:49 |
| lbragstad | https://review.opendev.org/c/openstack/glance/+/802054 | 21:49 |
| dansmith | gdi lbragstad | 21:51 |
| lbragstad | resource types is good though - looks they have coverage for list_metadef_resource_types | 21:51 |
| lbragstad | and i think tags is also missing it, but i could be wrong | 21:52 |
| lbragstad | testing it real quick | 21:52 |
| lbragstad | mm it fails for tags, but i can't tell in the test where it actually call the GET /v2/metadefs/namespaces/{namespace}/tags API | 21:55 |
| opendevreview | Dan Smith proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 22:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 22:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 22:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 22:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 22:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove duplicate namespace utilities in functional tests https://review.opendev.org/c/openstack/glance/+/806775 | 22:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Move global constants to test module setUp https://review.opendev.org/c/openstack/glance/+/806779 | 22:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove duplicate _url() methods from functional test classes https://review.opendev.org/c/openstack/glance/+/806797 | 22:03 |
| opendevreview | Dan Smith proposed openstack/glance master: Remove duplicate _header() implementations in metadef tests https://review.opendev.org/c/openstack/glance/+/806801 | 22:03 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!