| opendevreview | Merged openstack/glance master: 'community' images need to be treated as public https://review.opendev.org/c/openstack/glance/+/800221 | 00:42 |
|---|---|---|
| opendevreview | HanGuangyu proposed openstack/glance master: Make "killed" images list available using the CLI https://review.opendev.org/c/openstack/glance/+/806134 | 01:48 |
| opendevreview | Merged openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 02:08 |
| opendevreview | Merged openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 02:08 |
| opendevreview | Mridula Joshi proposed openstack/glance master: Add doc support for delete-from-store API https://review.opendev.org/c/openstack/glance/+/806180 | 05:32 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 05:45 |
| opendevreview | Mridula Joshi proposed openstack/glance master: Add doc support for delete-from-store API https://review.opendev.org/c/openstack/glance/+/806180 | 06:06 |
| opendevreview | Merged openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 06:07 |
| opendevreview | Merged openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 06:32 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Remove duplicate namespace utilities in functional tests https://review.opendev.org/c/openstack/glance/+/806775 | 06:34 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move global constants to test module setUp https://review.opendev.org/c/openstack/glance/+/806779 | 06:34 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Remove duplicate _url() methods from functional test classes https://review.opendev.org/c/openstack/glance/+/806797 | 06:34 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Remove duplicate _header() implementations in metadef tests https://review.opendev.org/c/openstack/glance/+/806801 | 06:34 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Refresh Glance example configs for Xena milestone 3 https://review.opendev.org/c/openstack/glance/+/807242 | 07:26 |
| *** bhagyashris__ is now known as bhagyashris | 07:27 | |
| opendevreview | Merged openstack/glance-tempest-plugin master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/glance-tempest-plugin/+/789759 | 07:33 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Refresh Glance example configs for Xena milestone 3 https://review.opendev.org/c/openstack/glance/+/807242 | 13:44 |
| dansmith | abhishekk: ninja for conf generation patch right?> | 13:55 |
| lbragstad | dansmith thanks for respinning all the metadef patches | 14:02 |
| dansmith | np | 14:02 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Add protection testing for metadef namespaces https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 14:11 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef objects https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802793 | 14:11 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef resource types https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802792 | 14:11 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef properties https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802794 | 14:11 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef tags https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802795 | 14:11 |
| abhishekk | dansmith, yes | 15:43 |
| dansmith | done | 15:44 |
| abhishekk | great, now only releasenote patch is remaining | 15:44 |
| abhishekk | and refactoring done by lance as well | 15:45 |
| dansmith | where is the release note patch? | 15:50 |
| abhishekk | not pushed yet | 15:54 |
| abhishekk | will do it tonight | 15:54 |
| dansmith | ah okay | 15:57 |
| lbragstad | we're still going to try and get the glance-tempest-plugin patches in right? | 16:10 |
| lbragstad | but we have time for that since glance-tempest-plugin is branchless | 16:10 |
| lbragstad | ? | 16:10 |
| dansmith | I would assume | 16:35 |
| dansmith | and hope since they're just tests | 16:35 |
| lbragstad | ok - cool, just wanted to check | 16:35 |
| abhishekk | lbragstad, yes, we will | 16:38 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Xena milestone 3 release notes https://review.opendev.org/c/openstack/glance/+/807363 | 16:38 |
| lbragstad | qq on the glance-tempest-plugin | 16:38 |
| lbragstad | should glance-secure-rbac-protection-functional be running tests on https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 16:39 |
| lbragstad | same question here - https://review.opendev.org/c/openstack/glance/+/802056 | 16:40 |
| lbragstad | should those patches be running the tests we have in glance-tempest-plugin? | 16:40 |
| lbragstad | because i think they're getting skipped since we're not telling tempest we want to test the new stuff | 16:40 |
| lbragstad | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_fd8/802056/20/check/glance-secure-rbac-protection-functional/fd8a61a/testr_results.html | 16:40 |
| abhishekk | lbragstad, you mean to say at the moment those tests are skipped for glance patches ? | 16:43 |
| lbragstad | i think so? | 16:43 |
| lbragstad | for example - https://review.opendev.org/c/openstack/glance/+/798266 | 16:43 |
| dansmith | lbragstad: that job only runs functional with rbac enabled, why would we need to run functional tests on the tempest-plugin patches? | 16:43 |
| lbragstad | skipped the tests https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5a0/798266/30/gate/glance-secure-rbac-protection-functional/5a05263/testr_results.html | 16:43 |
| lbragstad | i thought that job was supposed to run https://github.com/openstack/glance-tempest-plugin/blob/master/glance_tempest_plugin/tests/rbac/v2/test_images.py | 16:44 |
| abhishekk | right | 16:45 |
| lbragstad | glance-tox-functional-py38-rbac-defaults is the functional tests in glance proper (i think) | 16:45 |
| lbragstad | or at least based on what i learned yesterday | 16:45 |
| dansmith | ...right | 16:45 |
| abhishekk | yes, those are for secure RBAC | 16:45 |
| lbragstad | so - is there anything running the glance_tempest_plugin.tests.rbac.v2.test_images stuff? | 16:46 |
| dansmith | oh in glance you mean | 16:47 |
| lbragstad | or in glance-tempest-plugin | 16:47 |
| lbragstad | i don't think https://github.com/openstack/glance-tempest-plugin/blob/master/.zuul.yaml#L1-L22 is doing what we thought it was | 16:47 |
| lbragstad | that job should setup tempest, devstack, and glance so that it runs https://github.com/openstack/glance-tempest-plugin/blob/master/glance_tempest_plugin/tests/rbac/v2/test_images.py | 16:48 |
| lbragstad | but i don't think that's actually happening | 16:48 |
| dansmith | eh? | 16:48 |
| lbragstad | because the tests are skipped | 16:48 |
| lbragstad | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5a0/798266/30/gate/glance-secure-rbac-protection-functional/5a05263/testr_results.html | 16:48 |
| dansmith | okay, that's a tempest job not a functional one, and loading the plugin | 16:48 |
| lbragstad | yes | 16:49 |
| dansmith | if they're skipped then maybe it's a tempest config thing? | 16:49 |
| abhishekk | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_eb3/800902/20/check/glance-legacy-rbac-protection-functional/eb3ced9/testr_results.html | 16:49 |
| dansmith | abhishekk: those are without secure-rbac enabled yeah? | 16:49 |
| abhishekk | hmm | 16:50 |
| dansmith | who wrote the jobs for the tempest-plugin ? | 16:50 |
| lbragstad | me | 16:50 |
| lbragstad | 2a3d8bd0c9df4a6a50475262855e40b5a437bd16 | 16:50 |
| dansmith | okay | 16:50 |
| lbragstad | b23fefad3e6b90e8985b6667b580be69ee0c9532 | 16:50 |
| lbragstad | and we had them working at the end of wallaby | 16:51 |
| dansmith | and you think you just didn't notice that they were skipping before? | 16:51 |
| abhishekk | strange, If i click on glance-legacy-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/eb3ced92383a4e888f983378cb52e19a it is redirecting me to legacy job | 16:51 |
| lbragstad | so - this is weird | 16:52 |
| dansmith | lbragstad: is it this? https://github.com/openstack/glance-tempest-plugin/blob/master/glance_tempest_plugin/tests/rbac/v2/base.py#L29 | 16:52 |
| lbragstad | we enable the glance devstack plugin | 16:52 |
| lbragstad | which used to run on https://github.com/openstack/glance/blob/stable/wallaby/devstack/plugin.sh#L22-L26 | 16:52 |
| dansmith | I don't see that message in the report | 16:52 |
| lbragstad | and we don't have the devstack plugin anymore in master? | 16:53 |
| dansmith | huh? the plugin doesn't need to be in glance itself right? | 16:53 |
| lbragstad | i'm not sure - but that's what we were relying on to set the tempest config so the tests didn't skip | 16:53 |
| lbragstad | https://paste.opendev.org/raw/808587/ | 16:54 |
| lbragstad | ^ the tests skip for me locally when i deploy devstack with https://github.com/openstack/glance-tempest-plugin/blob/master/.zuul.yaml#L1-L22 | 16:54 |
| lbragstad | and i think that's apparent when you look at the test runs for that job in the patches we have in review since they're skipped | 16:54 |
| abhishekk | I think that patch which removed enfocing scope from glance devstack has triggered it | 16:55 |
| lbragstad | abe052d6dbc923d3419e31852339a081a8dd7fc6 | 16:56 |
| lbragstad | I3bf583e98fd610a8edb7cd31e6809f951463d771 | 16:56 |
| lbragstad | bah! *and* i left a comment on https://review.opendev.org/c/openstack/devstack/+/778945 | 16:57 |
| dansmith | okay, I would have expected the thing gmann was moving to to be how this is done, so I never knew about the devstack.sh hook in tree | 16:57 |
| dansmith | but I also didn't see/review this change | 16:58 |
| lbragstad | https://review.opendev.org/c/openstack/devstack/+/778945 looks right | 16:58 |
| lbragstad | https://review.opendev.org/c/openstack/devstack/+/778945/2/lib/tempest should be working | 16:58 |
| lbragstad | oh - it is working | 16:59 |
| lbragstad | https://paste.opendev.org/raw/808588/ | 17:00 |
| opendevreview | Lance Bragstad proposed openstack/glance-tempest-plugin master: Fix glance tempest plugin test to use the right tempest variables https://review.opendev.org/c/openstack/glance-tempest-plugin/+/807366 | 17:02 |
| lbragstad | moment of truth | 17:02 |
| lbragstad | we'll see if those refactors we landed moving the policy checks up to the API broke anything :) | 17:02 |
| dansmith | that seems odd | 17:03 |
| dansmith | is those things were moved from image_feature_enabled ? | 17:03 |
| lbragstad | luckily - it looks like this happened on the 19th | 17:03 |
| lbragstad | we probably should have made sure https://review.opendev.org/c/openstack/devstack/+/778945/2/lib/tempest included the image_feature_enabled bit so things continued to work | 17:04 |
| opendevreview | Merged openstack/glance master: Refresh Glance example configs for Xena milestone 3 https://review.opendev.org/c/openstack/glance/+/807242 | 17:05 |
| opendevreview | Merged openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 17:05 |
| abhishekk | I don't think anything will break | 17:05 |
| lbragstad | i just ran things locally and they passed - so that's good | 17:06 |
| dansmith | can we circle back here? | 17:06 |
| dansmith | you're saying that tempest now expects [enforce_scope]glance=True to enable the stuff we need, | 17:06 |
| dansmith | and that the plugin was checking the old value in the image_feature_enabled group right? | 17:07 |
| lbragstad | yeah | 17:07 |
| dansmith | that makes little sense to me | 17:07 |
| dansmith | as everything in tempest is image_ and not glance_ | 17:07 |
| lbragstad | that was part of the consolidation that gmann was doing to pull this all into tempest | 17:08 |
| dansmith | and also seems very unlike gmann to have proposed these thigns and not realized | 17:08 |
| lbragstad | https://review.opendev.org/c/openstack/devstack/+/778975/1 is the keystone one | 17:08 |
| lbragstad | i should probably make sure the keystone protection tests are still running | 17:08 |
| dansmith | just seems really strange | 17:08 |
| dansmith | is there a corresponding deprecation/removal of the image_feature_enabled knob? | 17:09 |
| lbragstad | idk - that's a question for gmann | 17:09 |
| abhishekk | no it is still used for other options | 17:09 |
| dansmith | abhishekk: no I mean the enforce_rbac option under that group | 17:09 |
| abhishekk | no | 17:09 |
| dansmith | (or whatever it's called) | 17:09 |
| abhishekk | They run locally without any issues for me so didn't noticed/cared to check actual results | 17:11 |
| lbragstad | abhishekk were you running the tempest tests locally? | 17:11 |
| abhishekk | yeah, glance-tempest-plugin for each policy and rbac patches | 17:11 |
| lbragstad | nice | 17:12 |
| lbragstad | so - this didn't break in keystone because we are still using the keystone/devstack plugin | 17:12 |
| lbragstad | which sets https://github.com/openstack/keystone/blob/master/devstack/lib/scope.sh#L23 | 17:12 |
| abhishekk | tha's why I found that we need Locking for metadef tests or we need to run it serially | 17:12 |
| dansmith | this is the thing I was missing: https://github.com/openstack/glance-tempest-plugin/blob/master/glance_tempest_plugin/config.py | 17:14 |
| dansmith | that knob is defined in the plugin itself and not in tempest | 17:14 |
| dansmith | it still seems very strange to use project names in tempest, because everything else seems to be service-scoped (i.e. image not glance) | 17:15 |
| lbragstad | yeah | 17:17 |
| lbragstad | so - how do we want to fix this? | 17:17 |
| lbragstad | update the plugin to use the right variable, patch devstack to set the old thing, both? | 17:17 |
| dansmith | your patch is the fix, right? I just want gmann to ack it | 17:17 |
| lbragstad | i think so - and yeah, i'm also curious to hear what gmann says | 17:18 |
| opendevreview | Lance Bragstad proposed openstack/glance-tempest-plugin master: Fix glance tempest plugin test to use the right tempest variables https://review.opendev.org/c/openstack/glance-tempest-plugin/+/807366 | 17:21 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Xena milestone 3 release notes https://review.opendev.org/c/openstack/glance/+/807363 | 17:25 |
| abhishekk | also any idea why glance-legacy-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/eb3ced92383a4e888f983378cb52e19a redirects to legacy and legacy to protection ? | 17:28 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Xena milestone 3 release notes https://review.opendev.org/c/openstack/glance/+/807363 | 18:01 |
| gmann | dansmith: lbragstad idea of making it 'enforce_scope'.<service> is that we can use it consistently for all services and in tempest test too along with plugins | 18:06 |
| abhishekk | something is wrong with my brain, I guess, legacy is redirected to legacy only | 18:06 |
| gmann | tempest tests also need to migrate to new scope at some point | 18:06 |
| gmann | dansmith: lbragstad abhishekk I think with that patch we can remove or deprecate to remove this https://github.com/openstack/glance-tempest-plugin/blob/master/glance_tempest_plugin/config.py | 18:07 |
| gmann | and both config options seems went in parallel and later on devstack setting moving, did not realize test are still using plugin one | 18:07 |
| abhishekk | I think deprecate to remove will be better | 18:08 |
| gmann | but has this been released yet? | 18:09 |
| abhishekk | no | 18:09 |
| dansmith | abhishekk: deprecate in the plugin? seems like we don't need to be worried about long-term usage of the plugin to me.. and it's broken now | 18:09 |
| gmann | abhishekk: it is, in 0.1.0 | 18:09 |
| gmann | we can remove it directly with reno saying to enable test via another config options | 18:10 |
| gmann | for now lbragstad patch seems good to me, i am +1 if you want to remove/deprecate config option in later patch | 18:11 |
| abhishekk | I didn't noticed this because my local tempest.conf is still using old parameter | 18:12 |
| abhishekk | but yeah as pointed by dansmith it's plugin so we can directly remove it with reno | 18:13 |
| gmann | yeah, works for me | 18:14 |
| abhishekk | ack | 18:20 |
| dansmith | abhishekk: you know that US people are out on monday right? | 18:39 |
| abhishekk | nope | 18:40 |
| dansmith | abhishekk: now you know that US people are out on monday. | 18:40 |
| abhishekk | yes | 18:40 |
| dansmith | heh | 18:41 |
| abhishekk | Ack, I think we have everything sorted now | 18:41 |
| abhishekk | just one doc patch, lance's refactoring patches (4) and 1 reno patch is remaining | 18:42 |
| * abhishekk planning to watch laca sa de papel now | 18:45 | |
| abhishekk | Ok then, happy long weekend and see you on Tuesday | 18:50 |
| abhishekk | Monday I will keep focus on protection testing patches for metadef | 18:51 |
| abhishekk | o/~ over and out | 18:51 |
| dansmith | o/ | 18:51 |
| opendevreview | Merged openstack/glance-tempest-plugin master: Fix glance tempest plugin test to use the right tempest variables https://review.opendev.org/c/openstack/glance-tempest-plugin/+/807366 | 19:26 |
| opendevreview | Lance Bragstad proposed openstack/glance-tempest-plugin master: Remove plugin-specific enforce_scope configuration option https://review.opendev.org/c/openstack/glance-tempest-plugin/+/807396 | 19:53 |
| opendevreview | Lance Bragstad proposed openstack/glance-tempest-plugin master: Remove plugin-specific enforce_scope configuration option https://review.opendev.org/c/openstack/glance-tempest-plugin/+/807396 | 21:05 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!