dansmith | dtantsur: question on that, not sure if the format thing is up for discussion or not | 15:03 |
---|---|---|
dansmith | but any time we codify stuff like this I think it's good to think about the words we use so they're general enough to be reusable later and for other things | 15:04 |
dansmith | also rosmaita ^ | 15:04 |
rosmaita | dansmith: i had a system crash yesterday bad enough to lose a day of irc logs ... got a link? | 15:06 |
dansmith | https://review.opendev.org/c/openstack/glance/+/826684 | 15:06 |
dtantsur | dansmith: I understand your point, but these very terms have been used in the Ironic community for years, so I'd feel uneasy about changing them | 15:11 |
dtantsur | (I know it's not 100% fair to ask you to sign off on something basically pre-defined, but here we are) | 15:12 |
dansmith | but presumably not in glance | 15:12 |
dansmith | just saying, this makes no sense for a docker usage, for example | 15:12 |
dtantsur | do image types like this even make sense for docker images? | 15:13 |
dansmith | dtantsur: to be clear, you're saying ironic already uses this property with these values? | 15:13 |
dansmith | dtantsur: sure | 15:13 |
dtantsur | dansmith: no, not in case of glance | 15:13 |
dtantsur | we're still open to modifying this, but it will be inconsistent with a lot of history in Ironic | 15:13 |
dansmith | dtantsur: this is how the docker, openvz and lxc drivers worked in nova, for example | 15:14 |
dansmith | ack, well, if rosmaita doesn't think it's important I'll just keep quiet | 15:14 |
dtantsur | you folks have the bigger picture when it comes to glance | 15:15 |
dtantsur | the reason I created the glance patch, is to make sure it's consistent with whatever may be happening in the glance world | 15:15 |
dansmith | dtantsur: if ironic doesn't use it in glance as it is, what's the big problem with calling it the right thing in glance? | 15:15 |
dansmith | just users creating an image in glance to be used need to know about the different terminoloy? | 15:16 |
dtantsur | the agreement on the right thing? :) | 15:16 |
dtantsur | more seriously, while the terms are not used in glance, that's what people have been referring to in the Ironic world for years | 15:18 |
rosmaita | tbh, i am heads-down for cinder RC-1 atm ... but we've traditionally been pretty lenient about letting consuming projects define/describe metadata they consume | 15:18 |
rosmaita | usually, it happens that the metadata has already been used for a while before someone comes across the "useful image properties" list and decides it would be a good idea to add it | 15:18 |
dtantsur | heh, I decided to do it the other way around this time :) | 15:19 |
rosmaita | and look where that got you!!! | 15:19 |
dtantsur | exactly! | 15:19 |
dtantsur | face to face with a wild dansmith | 15:19 |
dansmith | rosmaita: yeah that's what makes this fairly opaque and obscure to people who don't understand why some properties work for something and don't for others, and seem to overlap a lot :) | 15:20 |
dansmith | but fair enough, I just wanted to make sure we considered it | 15:20 |
dansmith | I will approve with a passive-aggressive snide remark :) | 15:20 |
dtantsur | just as the stone tablets predicted | 15:20 |
rosmaita | like I said, i am not going to be helpful here, i could go either way | 15:20 |
opendevreview | Merged openstack/glance master: Document new properties used by Ironic https://review.opendev.org/c/openstack/glance/+/826684 | 16:18 |
opendevreview | Cyril Roelandt proposed openstack/python-glanceclient stable/yoga: Update TOX_CONSTRAINTS_FILE for stable/yoga https://review.opendev.org/c/openstack/python-glanceclient/+/830831 | 22:08 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!