opendevreview | OpenStack Proposal Bot proposed openstack/glance master: Imported Translations from Zanata https://review.opendev.org/c/openstack/glance/+/831892 | 02:44 |
---|---|---|
*** abhishekk is now known as akekane|home | 04:56 | |
*** akekane|home is now known as abhishekk | 04:56 | |
opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Replace FakeObject with MagicMock[1/2] https://review.opendev.org/c/openstack/glance_store/+/832921 | 06:29 |
opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Replace FakeObject with MagicMock[2/2] https://review.opendev.org/c/openstack/glance_store/+/832922 | 06:30 |
abhishekk | rosmaita, jokke_, dansmith, croelandt, pdeore, mrjoshi glance weekly meeting in 10 minutes at #openstack-meeting | 13:50 |
rosmaita | abhishekk: ty | 13:51 |
abhishekk | np | 13:51 |
abhishekk | ade_lee_, we are starting the glance meeting, if you want you can join in | 13:57 |
opendevreview | Merged openstack/python-glanceclient stable/yoga: Update TOX_CONSTRAINTS_FILE for stable/yoga https://review.opendev.org/c/openstack/python-glanceclient/+/830831 | 14:02 |
ade_lee_ | abhishekk, I'm here now if the meeting is still going -- not sure where it is though | 14:37 |
ade_lee_ | agh .. see it | 14:37 |
abhishekk | ade_lee_, its almost over now, you need to go through logs now | 14:38 |
abhishekk | or else I will walk you through in some time | 14:38 |
ade_lee_ | abhishekk, sure - I'll check out the logs and get back to you. you also asked about times at the ptg | 14:39 |
abhishekk | yeah | 14:39 |
ade_lee_ | I'm going to go to the tc meeting today to enquire about when we would meet to do a community goal sync/update there - and then I can get back to you | 14:40 |
abhishekk | sure, thank you | 14:40 |
ade_lee_ | abhishekk, its a good thing you reminded me - I was thinking the ptg was at the end of april instead of the beginning :/ | 14:41 |
abhishekk | ohh | 14:42 |
jokke_ | abhishekk: pdeore: oh I won't be around for next weeks meeting (sorry Pranali for missing your first one) It's St. Patrick's Day next Thu and Day of Remembrance and Recognition at Fri so long weekend! | 14:46 |
abhishekk | aah | 14:47 |
abhishekk | we do have long weekend as well, holiday on Friday \o/ | 14:47 |
abhishekk | Enjoy yours :D | 14:47 |
jokke_ | Likewise! | 14:48 |
pdeore | ahh .. np, Enjoy your long weekend :) | 14:49 |
*** gmann is now known as gmann_afk | 16:13 | |
*** gmann_afk is now known as gmann | 16:29 | |
opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Refactor cinder store tests[1/2] https://review.opendev.org/c/openstack/glance_store/+/833141 | 17:12 |
whoami-rajat | croelandt, ^^ this fixes the temporary_chown issue (see #4 in commit msg) | 17:14 |
croelandt | whoami-rajat: wasn't that already fixed in a prior patch? | 17:40 |
whoami-rajat | croelandt, the code is fixed but this is fixing the test part which didn't catch it | 17:42 |
croelandt | oh ok so these tests would have caught it | 17:46 |
croelandt | I'm gonna need to read that once I'm well rested though :D | 17:46 |
whoami-rajat | yep, initially i ran the cover job and saw that this code part was covered so i looked at the mocked method during refactoring and caught the problem, now if you change the original method (temporary_chown), the tests will barf | 17:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!