*** spzala has quit IRC | 00:02 | |
*** spzala has joined #openstack-heat-translator | 00:02 | |
*** tbh has joined #openstack-heat-translator | 00:15 | |
*** bobh has joined #openstack-heat-translator | 00:16 | |
*** bobh has quit IRC | 00:19 | |
*** bobh_ has joined #openstack-heat-translator | 01:59 | |
*** bobh_ has quit IRC | 04:02 | |
*** bobh has joined #openstack-heat-translator | 04:06 | |
*** bobh has quit IRC | 04:11 | |
*** spzala has quit IRC | 04:16 | |
*** tbh has quit IRC | 09:23 | |
*** tbh has joined #openstack-heat-translator | 10:03 | |
*** bobh has joined #openstack-heat-translator | 13:07 | |
*** bobh has quit IRC | 13:23 | |
*** bobh_ has joined #openstack-heat-translator | 14:59 | |
*** spzala has joined #openstack-heat-translator | 15:16 | |
tbh | spzala, raised the bug https://bugs.launchpad.net/tosca-parser/+bug/1653992 | 15:33 |
---|---|---|
openstack | Launchpad bug 1653992 in TOSCA Parser "Log the warning instead of raising an exception if input are not passed for tosca template raising" [Undecided,New] - Assigned to bharaththiruveedula (bharath-ves) | 15:33 |
spzala | tbh: Hi | 15:35 |
tbh | spzala, Hi | 15:35 |
spzala | tbh: Happy New Year! and thanks, sounds good | 15:35 |
tbh | thanks and wish you the same Sahdev! | 15:36 |
tbh | so mostly the fix will be logging rather than raising exception? | 15:36 |
spzala | tbh: thanks! Yep, let's do that | 15:39 |
spzala | tbh: hopefully that will be quick and also I don't prefer to force input values in the template itself | 15:40 |
spzala | tbh: user may planned it to provide later via command line using heat-translator or other orchestrator | 15:40 |
spzala | tbh: one more thing here | 15:41 |
spzala | tbh: in the template you used in the bug I guess if you provide a 'default' value that will work without error right? | 15:42 |
spzala | but that's what can break Tacker because old Tacker templates don't have default? | 15:42 |
spzala | bobh_: good morning | 15:47 |
spzala | tbh: there? :-) | 15:54 |
tbh | spzala, sorry just went afk | 15:57 |
spzala | tbh: :-) np at all | 15:57 |
bobh_ | spzala: Good morning - I have to run to a meeting - can I catch up with you after? | 15:57 |
spzala | bobh_: Sure, no rush | 15:57 |
spzala | bobh_: thanks! | 15:57 |
tbh | spzala, I didn't provide default to input | 15:57 |
spzala | tbh: right, but I was wondering that if you do provide then it may not fail | 15:58 |
tbh | spzala, yup, it won't fail | 15:58 |
spzala | tbh: OK but that's where it can break some old templates I guess | 15:58 |
tbh | spzala, exactly | 15:58 |
spzala | tbh: OK sounds good then I just wanted to double check | 15:59 |
spzala | tbh: on a side note, do you have a minute to look at another Tacker related bug | 15:59 |
spzala | ? | 15:59 |
spzala | tbh: https://bugs.launchpad.net/heat-translator/+bug/1652928 | 15:59 |
openstack | Launchpad bug 1652928 in Heat Translator "Fails to translate the derived polices" [High,New] - Assigned to Sahdev Zala (spzala) | 15:59 |
tbh | spzala, morning Kangaraj was talking about it, some one is working on it I think | 15:59 |
spzala | tbh: well, what I need to know is 'what the problem is" ? | 16:00 |
tbh | spzala, though we are passing scaling policy, those resources are not converting into HOT | 16:01 |
spzala | tbh: since you and bobh knows both projects Tacker and TP/HT, you can help | 16:01 |
spzala | that was the reason to pinging bobh :-) | 16:01 |
tbh | spzala, I can see the issue in 0.6.0 | 16:01 |
spzala | tbh: I understand that but if you look at my comments I mentioned 4 ways the parser can understand the custom types | 16:02 |
spzala | and I don't know how Tacker passes and why parser can't get the definition | 16:02 |
spzala | if I use parser as such it works fine | 16:02 |
spzala | tbh: can you quickly test it with latest tosac-parser? | 16:03 |
tbh | spzala, yup doing that | 16:03 |
spzala | tbh: awesome thanks | 16:04 |
tbh | spzala, this is how tacker passes to tosca-parser(in imports section) | 16:04 |
tbh | I will let you know if I find some clue | 16:05 |
spzala | tbh: Thanks! so in the init of entity_template.py in tosca-parser is where it should resolve the imports at the end | 16:06 |
spzala | def __init__(self, name, template, entity_name, custom_def=None): | 16:06 |
spzala | tbh: as you try it, and see a failure error from TP please provide me that too | 16:07 |
tbh | spzala, sure | 16:07 |
spzala | tbh: thanks!! | 16:07 |
spzala | tbh: as you know we delayed the 0.7.0 release by few days and now plan is to have parser release on Monday and then HT release 0.7.0 next day | 16:08 |
spzala | tbh: since we don't have lot of time I am doing whatever I can to solve this .. I appreciate your help here | 16:08 |
tbh | spzala, oh okay,sure I will try to find the root cause | 16:09 |
spzala | tbh: thank you much!! | 16:09 |
tbh | spzala, np :) | 16:11 |
spzala | tbh: :) | 16:12 |
spzala | tbh: bobh_ has a good comment .. please look at the end of the bug when you get chance | 16:12 |
tbh | sure | 16:13 |
spzala | tbh: thanks! | 16:13 |
tbh | spzala, ping | 16:23 |
spzala | tbh: pong | 16:23 |
tbh | spzala, if you see this https://github.com/openstack/tosca-parser/blob/master/toscaparser/topology_template.py#L134 | 16:24 |
tbh | spzala, we are getting 'groups' for each scaling | 16:24 |
spzala | tbh: sure | 16:24 |
tbh | spzala, but here https://github.com/openstack/tacker/blob/master/samples/tosca-templates/vnfd/tosca-vnfd-scale.yaml#L65 | 16:25 |
tbh | spzala, targets are in "properties" | 16:25 |
tbh | spzala, so targets are empty in this case and it returns empty list for policies in topology_template | 16:26 |
spzala | tbh: I see, targets should be at the same level as property | 16:26 |
tbh | spzala, yes that's the difference I found | 16:26 |
tbh | spzala, so because of this it is considering any scaling policy | 16:27 |
spzala | tbh: OK cool but the bug is saying that the template translation fails because it can not resolve 'tosca.policies.tacker.Scaling' | 16:27 |
spzala | tbh: if you can please look at bug description which is not much | 16:28 |
tbh | spzala, yes but in the morning meeting kanagaraj was saying he didn't get the error | 16:28 |
spzala | tbh: so if you move the targets in template does that produce expected result? | 16:28 |
tbh | spzala, let me give the conversation | 16:28 |
spzala | tbh: oh seems like he forgot updating bug discussion | 16:29 |
tbh | spzala, yup it worked, I mean scalingpolicy in HOT | 16:29 |
spzala | tbh: I guess that was main discussion that custom types were no resolved | 16:29 |
spzala | tbh: cool, that's good to know | 16:29 |
spzala | tbh: so the main problem with the template is it's not giving expected result and you already found possible cause in use of 'targets' | 16:30 |
spzala | tbh: can you please try moving targets out of properties | 16:32 |
spzala | ? | 16:32 |
spzala | tbh: :) unless you already did | 16:32 |
tbh | spzala, yup tried | 16:32 |
spzala | tbh: :) OK that's what I thought you might | 16:32 |
tbh | spzala, http://eavesdrop.openstack.org/meetings/tacker/2017/tacker.2017-01-04-05.30.log.html | 16:33 |
tbh | spzala, at "06:08:34 " | 16:33 |
spzala | tbh: OK looking | 16:33 |
spzala | tbh: it's taking time to load | 16:33 |
spzala | tbh: not yet loaded | 16:34 |
tbh | spzala, sure | 16:34 |
spzala | tbh: yup I see it | 16:35 |
spzala | tbh: oh well | 16:35 |
spzala | tbh: so I guess we just need to focus on making sure that the template you are using provides expected translation | 16:36 |
spzala | tbh: makes sense right? | 16:36 |
tbh | spzala, right | 16:36 |
spzala | tbh: what happens when you modify targets to the way it should be? | 16:36 |
tbh | spzala, can I paste the template with "targets" at right position? | 16:37 |
tbh | spzala, I mean in the bug details | 16:37 |
spzala | tbh: with template examples we have, it produces asg_res.yaml and works correctly | 16:37 |
tbh | spzala, this is the output I got http://paste.openstack.org/show/593880/ | 16:37 |
spzala | tbh: oh I guess I am mixing up something :) | 16:37 |
spzala | tbh: bug detail of this https://bugs.launchpad.net/heat-translator/+bug/1652928 ? | 16:38 |
openstack | Launchpad bug 1652928 in Heat Translator "Fails to translate the derived polices" [High,New] - Assigned to Sahdev Zala (spzala) | 16:38 |
spzala | tbh: it's loading | 16:38 |
spzala | tbh: so looking at it did produce a translated template | 16:40 |
spzala | tbh: did it create SP1_res.yaml? | 16:41 |
spzala | tbh: did we get expected translation? | 16:41 |
tbh | spzala, yes it create | 16:42 |
spzala | tbh: nice | 16:42 |
tbh | *created | 16:42 |
tbh | spzala, http://paste.openstack.org/show/593882/ | 16:42 |
spzala | tbh: so what's the problem now? sorry fill me please | 16:42 |
tbh | spzala, as "targets" is not in the correct place in scaling resource, tosca-parser ignores those policies to parse | 16:43 |
spzala | tbh: I see, so that's something the template needs to be fixed | 16:43 |
tbh | spzala, that's the problem in the template | 16:44 |
spzala | tbh: Yup | 16:44 |
spzala | tbh: glad that I asked to help out :-) | 16:44 |
spzala | tbh: do you want to add a comment detailing your findings in the bug? | 16:44 |
tbh | spzala,sure | 16:45 |
spzala | tbh: If you want I can add, but adding by you would be proper | 16:45 |
tbh | spzala, anything is fine for me | 16:45 |
spzala | tbh: Cool, thanks!! | 16:45 |
spzala | tbh: :) go ahead add it. Let me add a line that you are going to add your findings | 16:46 |
spzala | to keep the communication in line for references | 16:46 |
tbh | spzala, ok | 16:46 |
spzala | tbh: or just go ahead add your comment | 16:46 |
spzala | tbh: :) | 16:46 |
spzala | tbh: :) small things | 16:46 |
tbh | spzala, : ) | 16:47 |
spzala | bobh_: thanks to tbh: finding seems like we are good on TP/HT side .. custom types are working fine as he confirmed. He did find an error in template and going to add his comments. | 16:49 |
spzala | bobh_: updating so that you don't spend time on it if you don't look at the comment tbh: is going to add | 16:50 |
spzala | bobh_: thanks for your help on it again! | 16:51 |
tbh | spzala, bobh_ just added the comment | 16:51 |
spzala | tbh: awesome!! Thanks a bunch again Bharath! | 16:51 |
tbh | spzala, np :) | 16:51 |
spzala | tbh: :) | 16:52 |
*** openstackgerrit has joined #openstack-heat-translator | 17:07 | |
openstackgerrit | Merged openstack/heat-translator: Updated from global requirements https://review.openstack.org/413809 | 17:07 |
openstackgerrit | Merged openstack/heat-translator: Removes unnecessary utf-8 coding https://review.openstack.org/414841 | 17:08 |
tbh | spzala, pushed the code for the get_input validation https://review.openstack.org/#/c/416698/ | 18:21 |
*** spzala has quit IRC | 18:40 | |
*** spzala has joined #openstack-heat-translator | 18:41 | |
*** spzala has quit IRC | 18:44 | |
*** spzala has joined #openstack-heat-translator | 18:44 | |
*** tbh has quit IRC | 18:44 | |
spzala | tbh: hi | 18:44 |
*** spzala has quit IRC | 19:01 | |
*** spzala has joined #openstack-heat-translator | 19:32 | |
*** spzala_ has joined #openstack-heat-translator | 19:35 | |
*** spzala has quit IRC | 19:36 | |
*** tbh has joined #openstack-heat-translator | 19:53 | |
spzala_ | tbh: reviewed and also added some comments in the bug to make arguments for this work stronger ;) | 19:55 |
tbh | spzala_, in the bug details? | 19:57 |
spzala_ | tbh: yes | 19:57 |
tbh | spzala_, just now saw the comments, thanks for the comments! | 19:58 |
spzala_ | tbh: :) OK, you are welcome. Thank you for the quick patch. | 19:58 |
spzala_ | tbh: So I guess we are all set or close to release 0.7.0 of parser and translator | 19:59 |
tbh | spzala_, yup I think so | 19:59 |
spzala_ | tbh: I will be testing stuff myself but I would like to get some help from you from Tacker perspective before the release | 19:59 |
spzala_ | tbh: some quick one | 19:59 |
spzala_ | tbh: like running tox | 19:59 |
spzala_ | tbh: I will reach out to you on that by Friday | 20:00 |
tbh | spzala_, sure will do that | 20:00 |
spzala_ | tbh: thanks!! :-) | 20:00 |
tbh | spzala_, ywc :) | 20:01 |
spzala_ | tbh: :) | 20:01 |
*** tbh has quit IRC | 20:03 | |
*** spzala_ has quit IRC | 20:42 | |
*** spzala has joined #openstack-heat-translator | 21:06 | |
*** spzala has quit IRC | 21:19 | |
*** bobh_ has quit IRC | 22:45 | |
*** openstack has joined #openstack-heat-translator | 22:56 | |
*** spzala has joined #openstack-heat-translator | 23:17 | |
*** spzala has quit IRC | 23:42 | |
*** spzala has joined #openstack-heat-translator | 23:45 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!