| *** yamamoto has quit IRC | 00:00 | |
| *** ybathia has quit IRC | 00:03 | |
| *** kzaitsev_mb has joined #openstack-horizon | 00:06 | |
| tqtran | TravT: regarding your comments on https://review.openstack.org/#/c/211345/, isAvailableTable sounds good? | 00:08 |
|---|---|---|
| TravT | yeah, any of those names would work for me. | 00:08 |
| tqtran | as for the st-table and st-safe-src, i don't think its possible to add it programmatically, i tried and failed | 00:08 |
| tqtran | i think it has something to do with how angular compiles, you are welcome to give it a shot :P | 00:09 |
| TravT | well, i don't think those are blockers for this patch. | 00:09 |
| TravT | maybe can be improved later. | 00:09 |
| TravT | just the name so far... | 00:09 |
| tqtran | thats possible, but i dont think it can be done | 00:09 |
| tqtran | you need to explicitly say that there is a directive there, OR invoke the $compile yourself | 00:10 |
| tqtran | since we're not using $compile ourselves, angular is reading and parsing and compile, so you can't add the st-table directive after the fact | 00:11 |
| tqtran | thats my theory at least | 00:11 |
| tqtran | and regarding parent patch, can we just leave that as is? | 00:12 |
| TravT | yes, i think it is right, since the directive is currently link (which is actually post-link) | 00:12 |
| TravT | i was just looking at parent patch and got distracted by noticing that I was too heads down today to see my meeting reminders that I missed the IRC meeting today | 00:13 |
| TravT | so was reading the logs on that. | 00:13 |
| *** alexvictorchan has quit IRC | 00:13 | |
| TravT | give me a minute to finish that and then look back again | 00:13 |
| *** zul has joined #openstack-horizon | 00:16 | |
| *** vishwanathj has quit IRC | 00:16 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 00:17 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding clone feature to Transfer Table https://review.openstack.org/211345 | 00:18 |
| *** kyleolivo has quit IRC | 00:20 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Adding CREATE action to identity users panel https://review.openstack.org/202315 | 00:23 |
| *** SimonChung has quit IRC | 00:29 | |
| *** skylerberg has quit IRC | 00:29 | |
| *** dsneddon_ has quit IRC | 00:29 | |
| *** nlahouti has quit IRC | 00:31 | |
| *** mwhagedorn has quit IRC | 00:32 | |
| *** linkedinyou has quit IRC | 00:32 | |
| *** gyee has quit IRC | 00:40 | |
| *** tqtran has quit IRC | 00:43 | |
| *** jingjing_ren has quit IRC | 00:46 | |
| *** davidmichaelkarr has quit IRC | 00:47 | |
| *** shivrao has quit IRC | 00:51 | |
| *** lhcheng has quit IRC | 00:52 | |
| *** josecastroleon has quit IRC | 00:56 | |
| *** freyes has quit IRC | 00:59 | |
| *** freyes has joined #openstack-horizon | 01:03 | |
| *** chlong has joined #openstack-horizon | 01:03 | |
| *** kzaitsev_mb has quit IRC | 01:04 | |
| *** drupalmonkey has joined #openstack-horizon | 01:07 | |
| *** davidmichaelkarr has joined #openstack-horizon | 01:10 | |
| *** jingjing_ren has joined #openstack-horizon | 01:13 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Add description and is_public to volume type table https://review.openstack.org/203532 | 01:19 |
| *** jingjing_ren has quit IRC | 01:20 | |
| *** tjones has joined #openstack-horizon | 01:33 | |
| *** zhenguo has joined #openstack-horizon | 01:33 | |
| *** lyanchih has joined #openstack-horizon | 01:39 | |
| *** jpomeroy has quit IRC | 01:42 | |
| *** jrpomeroy has joined #openstack-horizon | 01:47 | |
| *** bpokorny has quit IRC | 01:50 | |
| *** jrpomeroy is now known as jpomeroy | 01:51 | |
| *** jwy has quit IRC | 01:56 | |
| *** jpomeroy has quit IRC | 01:57 | |
| *** jpomeroy has joined #openstack-horizon | 01:58 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:01 | |
| *** kyleolivo has joined #openstack-horizon | 02:03 | |
| *** kzaitsev_mb has quit IRC | 02:05 | |
| *** drupalmonkey has quit IRC | 02:07 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Add description and is_public to volume type table https://review.openstack.org/203532 | 02:10 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/210887 | 02:11 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/212217 | 02:12 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Use security group id for launch instance https://review.openstack.org/212279 | 02:19 |
| *** hurgleburgler has quit IRC | 02:26 | |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - style guide cleanup for Keypair step https://review.openstack.org/193658 | 02:29 |
| *** jingjing_ren has joined #openstack-horizon | 02:29 | |
| *** jingjing_ren has quit IRC | 02:30 | |
| *** jingjing_ren has joined #openstack-horizon | 02:30 | |
| *** tjones has left #openstack-horizon | 02:31 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:31 | |
| *** kzaitsev_mb has quit IRC | 02:36 | |
| *** jpomeroy has quit IRC | 02:37 | |
| *** jpomeroy has joined #openstack-horizon | 02:39 | |
| *** stevemar has joined #openstack-horizon | 02:46 | |
| *** stevemar has quit IRC | 02:49 | |
| *** stevemar_ has joined #openstack-horizon | 02:49 | |
| *** tjones has joined #openstack-horizon | 02:51 | |
| *** KunalGandhi has quit IRC | 03:00 | |
| *** yamamoto has joined #openstack-horizon | 03:03 | |
| *** ducttape_ has joined #openstack-horizon | 03:06 | |
| *** kyleolivo has quit IRC | 03:16 | |
| *** saksham has quit IRC | 03:17 | |
| *** jpomeroy has quit IRC | 03:17 | |
| *** jingjing_ren has quit IRC | 03:19 | |
| *** kyleolivo has joined #openstack-horizon | 03:20 | |
| *** kyleolivo has quit IRC | 03:22 | |
| *** jtriley has joined #openstack-horizon | 03:25 | |
| *** kyleolivo has joined #openstack-horizon | 03:27 | |
| *** kzaitsev_mb has joined #openstack-horizon | 03:33 | |
| *** jingjing_ren has joined #openstack-horizon | 03:37 | |
| *** ducttape_ has quit IRC | 03:39 | |
| *** SimonChung has joined #openstack-horizon | 03:43 | |
| *** SimonChung1 has joined #openstack-horizon | 03:45 | |
| *** kyleolivo has quit IRC | 03:47 | |
| *** SimonChung has quit IRC | 03:48 | |
| *** jtriley has quit IRC | 03:49 | |
| *** tjones has quit IRC | 03:50 | |
| *** kyleolivo has joined #openstack-horizon | 03:51 | |
| *** kzaitsev_mb has quit IRC | 03:58 | |
| *** stevemar_ has quit IRC | 04:07 | |
| *** jingjing_ren has quit IRC | 04:09 | |
| *** lyanchih has quit IRC | 04:16 | |
| *** kzaitsev_mb has joined #openstack-horizon | 04:25 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Move magic_search.js in _scripts.html to after Angular files https://review.openstack.org/212308 | 04:26 |
| *** drupalmonkey has joined #openstack-horizon | 04:26 | |
| *** tjones has joined #openstack-horizon | 04:26 | |
| *** alexvictorchan has joined #openstack-horizon | 04:29 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 04:34 |
| *** jingjing_ren has joined #openstack-horizon | 04:36 | |
| *** Ephur has quit IRC | 04:36 | |
| *** jingjing_ren has quit IRC | 04:42 | |
| *** masco has joined #openstack-horizon | 04:44 | |
| *** kzaitsev_mb has quit IRC | 04:45 | |
| openstackgerrit | Merged openstack/horizon: Sidebar now inherits from a Bootstrap Theme https://review.openstack.org/209259 | 04:59 |
| *** lyanchih has joined #openstack-horizon | 05:04 | |
| openstackgerrit | Balaji Narayanan proposed openstack/horizon: Fix incorrect terminology in Deployment Doc https://review.openstack.org/212326 | 05:05 |
| *** alexvictorchan_ has joined #openstack-horizon | 05:05 | |
| *** nlahouti has joined #openstack-horizon | 05:06 | |
| *** alexvictorchan has quit IRC | 05:07 | |
| *** alexvictorchan_ is now known as alexvictorchan | 05:07 | |
| *** stevemar has joined #openstack-horizon | 05:08 | |
| *** tjones has quit IRC | 05:11 | |
| *** stevemar has quit IRC | 05:11 | |
| *** nlahouti has quit IRC | 05:11 | |
| openstackgerrit | Karthik Suresh proposed openstack/horizon: Edited create subnet comment to create network https://review.openstack.org/211969 | 05:12 |
| *** nlahouti has joined #openstack-horizon | 05:14 | |
| *** nlahouti has quit IRC | 05:17 | |
| *** nlahouti has joined #openstack-horizon | 05:17 | |
| *** kmARC has joined #openstack-horizon | 05:19 | |
| *** KingKhan has joined #openstack-horizon | 05:21 | |
| openstackgerrit | Balaji Narayanan proposed openstack/horizon: Fix XSS settings in Deployment Documentation https://review.openstack.org/212326 | 05:21 |
| *** jprovazn has joined #openstack-horizon | 05:26 | |
| *** drupalmonkey has quit IRC | 05:29 | |
| *** kmARC has quit IRC | 05:30 | |
| *** rakesh_mishra has joined #openstack-horizon | 05:33 | |
| *** lyanchih has quit IRC | 05:33 | |
| *** hhuang has joined #openstack-horizon | 05:36 | |
| *** hhuang has quit IRC | 05:38 | |
| *** hhuang has joined #openstack-horizon | 05:39 | |
| *** nlahouti has quit IRC | 05:41 | |
| *** shivrao has joined #openstack-horizon | 05:42 | |
| *** nlahouti has joined #openstack-horizon | 05:43 | |
| *** fifieldt has joined #openstack-horizon | 05:49 | |
| *** kyleolivo has quit IRC | 05:50 | |
| *** med_ has quit IRC | 05:50 | |
| *** yamamoto has quit IRC | 05:50 | |
| *** yamamoto has joined #openstack-horizon | 05:50 | |
| *** shivrao has quit IRC | 05:54 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Use security group id for launch instance https://review.openstack.org/212279 | 05:56 |
| *** lyanchih has joined #openstack-horizon | 06:08 | |
| *** mohankumar has joined #openstack-horizon | 06:09 | |
| *** lhcheng has joined #openstack-horizon | 06:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/212362 | 06:14 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Use the JP Style Guide for KeyStone Service https://review.openstack.org/211782 | 06:15 |
| *** linkedinyou has joined #openstack-horizon | 06:16 | |
| *** sayan has joined #openstack-horizon | 06:21 | |
| *** Guest471 has joined #openstack-horizon | 06:23 | |
| *** lyanchih has quit IRC | 06:25 | |
| *** nlahouti has quit IRC | 06:26 | |
| *** Guest471 has quit IRC | 06:44 | |
| *** kyleolivo has joined #openstack-horizon | 06:50 | |
| *** kyleolivo has quit IRC | 06:55 | |
| *** rdopiera has joined #openstack-horizon | 06:57 | |
| *** lhcheng has quit IRC | 06:58 | |
| *** linkedinyou has quit IRC | 06:59 | |
| *** mrunge has joined #openstack-horizon | 07:00 | |
| *** rakesh_mishra_ has joined #openstack-horizon | 07:04 | |
| *** lyanchih has joined #openstack-horizon | 07:07 | |
| *** rakesh_mishra has quit IRC | 07:07 | |
| *** MaxV has joined #openstack-horizon | 07:12 | |
| *** markus_z has joined #openstack-horizon | 07:13 | |
| *** vgridnev has joined #openstack-horizon | 07:13 | |
| *** Guest61394 has joined #openstack-horizon | 07:15 | |
| *** fifieldt has quit IRC | 07:17 | |
| *** e0ne has joined #openstack-horizon | 07:17 | |
| *** MaxV_ has joined #openstack-horizon | 07:18 | |
| *** MaxV has quit IRC | 07:18 | |
| *** bharath_ has joined #openstack-horizon | 07:19 | |
| bharath_ | Is horizon got broken? i am seeing "from openstack_dashboard.api import base => ImportError: cannot import name base" error | 07:21 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for KeyStone Service https://review.openstack.org/211782 | 07:21 |
| *** romainh has joined #openstack-horizon | 07:22 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:22 | |
| *** MaxV_ has quit IRC | 07:25 | |
| lifeless | bharath_: some more context than that may be needed. | 07:26 |
| *** dguerri` is now known as dguerri | 07:26 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for Nova Service https://review.openstack.org/211783 | 07:28 |
| mrunge | bharath_, I can not confirm this | 07:28 |
| *** alexvictorchan has quit IRC | 07:30 | |
| *** dguerri is now known as dguerri` | 07:31 | |
| zhenguo | mrunge: could you have a look at https://review.openstack.org/#/c/186810/ please? | 07:33 |
| mrunge | zhenguo, just a sec | 07:34 |
| zhenguo | mrunge, thanks | 07:34 |
| *** linkedinyou has joined #openstack-horizon | 07:40 | |
| *** MaxV_ has joined #openstack-horizon | 07:40 | |
| *** mohankumar has quit IRC | 07:41 | |
| *** e0ne has quit IRC | 07:41 | |
| *** SimonChung1 has quit IRC | 07:41 | |
| *** Anticimex has quit IRC | 07:41 | |
| *** openstackgerrit has quit IRC | 07:41 | |
| *** csd has quit IRC | 07:41 | |
| *** cody-somerville- has quit IRC | 07:41 | |
| *** r1chardj0n3s has quit IRC | 07:41 | |
| *** devananda has quit IRC | 07:41 | |
| *** SimonChung1 has joined #openstack-horizon | 07:43 | |
| *** Anticimex has joined #openstack-horizon | 07:43 | |
| *** openstackgerrit has joined #openstack-horizon | 07:43 | |
| *** csd has joined #openstack-horizon | 07:43 | |
| *** cody-somerville- has joined #openstack-horizon | 07:43 | |
| *** r1chardj0n3s has joined #openstack-horizon | 07:43 | |
| *** devananda has joined #openstack-horizon | 07:43 | |
| *** kmARC has joined #openstack-horizon | 07:44 | |
| *** csd has quit IRC | 07:45 | |
| *** vgridnev has quit IRC | 07:45 | |
| *** SimonChung1 has quit IRC | 07:45 | |
| *** openstackgerrit has quit IRC | 07:45 | |
| *** devananda has quit IRC | 07:45 | |
| *** Anticimex has quit IRC | 07:46 | |
| *** cody-somerville- has quit IRC | 07:46 | |
| *** r1chardj0n3s has quit IRC | 07:46 | |
| *** devananda has joined #openstack-horizon | 07:47 | |
| *** cody-somerville- has joined #openstack-horizon | 07:47 | |
| *** r1chardj0n3s has joined #openstack-horizon | 07:47 | |
| *** Anticimex has joined #openstack-horizon | 07:47 | |
| *** csd has joined #openstack-horizon | 07:52 | |
| *** vgridnev has joined #openstack-horizon | 07:55 | |
| *** regebro has joined #openstack-horizon | 07:55 | |
| regebro | I'm trying to add locale-files to the Tuskar-UI Dashboard, but it seems Django doesn't pick up on the .po/.mo files existing. (I think) | 07:56 |
| regebro | Any hints on what that could be? | 07:57 |
| regebro | Actually, I get no translations of Horizon itself either, I just realized. | 08:00 |
| *** jcoufal has joined #openstack-horizon | 08:00 | |
| *** openstackgerrit has joined #openstack-horizon | 08:00 | |
| mrunge | regebro, I just saw this in my install. what kind of session storage are you using? | 08:01 |
| mrunge | :q | 08:02 |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Replace SortedDict with OrderedDict https://review.openstack.org/212399 | 08:02 |
| regebro | mrunge: I don't know. :-) | 08:02 |
| *** akrivoka has joined #openstack-horizon | 08:02 | |
| regebro | mrunge: Aha, OK, the Horizon files weren't translated. | 08:03 |
| regebro | I mean compiled. | 08:03 |
| mrunge | regebro, hmm, yesterday I had to change CACHES from LocMemCache to e.g. MemcachedCache | 08:04 |
| regebro | mrunge: Wow, strange. | 08:04 |
| mrunge | LocMemCache seems to be a bit short lived to change the language over a session | 08:04 |
| mrunge | I was using CACHE as session backend | 08:04 |
| regebro | mrunge: Well, I now have Horizon/openstack_dashboard in a local language, so it's going forward. :-) | 08:05 |
| mrunge | but afterwards, I was able to switch locale | 08:05 |
| mrunge | great | 08:05 |
| regebro | mrunge: Now I just need to figure out why the Tuskar-UI dashboards translations are ignored... | 08:06 |
| *** KingKhan has quit IRC | 08:11 | |
| *** chlong has quit IRC | 08:13 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/212362 | 08:20 |
| *** lyanchih has quit IRC | 08:23 | |
| *** jcoufal has quit IRC | 08:27 | |
| *** yamamoto has quit IRC | 08:27 | |
| *** yamamoto has joined #openstack-horizon | 08:28 | |
| *** zhenguo has quit IRC | 08:29 | |
| bharath_ | i am hitting "django.core.exceptions.ImproperlyConfigured: Requested setting LOGIN_REDIRECT_URL, but settings are not configured" error. Can someone help me out | 08:29 |
| bharath_ | while importing from openstack_dashboard.api import base | 08:29 |
| *** lyanchih has joined #openstack-horizon | 08:31 | |
| vgridnev | mrunge, are you around? I would like to ask you several questions about this change https://review.openstack.org/#/c/197018 . I not sure that we need some kind of tests just because it was already covered openstack_dashboard/contrib/sahara/content/data_processing/nodegroup_templates/tests.py test_create . All change looks like one replacement and another renderer. Can you explain what kind of tests is required? | 08:32 |
| *** jcoufal has joined #openstack-horizon | 08:37 | |
| *** sayan has quit IRC | 08:39 | |
| mrunge | vgridnev, I am around | 08:41 |
| mrunge | vgridnev, I was generally concerned about missing tests at all | 08:41 |
| *** kzaitsev_mb has quit IRC | 08:42 | |
| mrunge | vgridnev, such a big change not touching any tests didn't give me a good feeling about test coverage in total | 08:42 |
| *** zz_ttrifonov is now known as ttrifonov | 08:44 | |
| vgridnev | mrunge, when you refactor code, I should not cause tests failures, I think. At least because it says that something is going wrong in refactoring | 08:44 |
| mrunge | vgridnev, didn't you add a new step to workflow? | 08:44 |
| vgridnev | it should not cause** | 08:44 |
| mrunge | yes, it shouldn't cause test failures | 08:45 |
| vgridnev | this step contains one thing from another step, just because it can be too big | 08:45 |
| mrunge | but you don't care, if you're loosing that step again? | 08:46 |
| mrunge | vgridnev, manual testing is an option. but it's not the option we really want | 08:46 |
| vgridnev | btw, tests just for tests looks strange | 08:47 |
| mrunge | vgridnev, in a different commit I can propose to remove your additional step, marking it as not required. nobody will catch that, besides you guys in manual tests | 08:48 |
| robcresswell | vgridnev: mrunge is not asking for tests of tests, he's asking to test for presence of workflow step. | 08:48 |
| *** kzaitsev_mb has joined #openstack-horizon | 08:48 | |
| mrunge | yes, thank you robcresswell | 08:48 |
| *** jcoufal has quit IRC | 08:49 | |
| robcresswell | If, for example, the Node processes selection tab was removed in another patch (say, accidental deletion or something) tests would not catch that. | 08:49 |
| mrunge | <rant> of course, we don't make mistakes and our software is flawless. no need for tests at all </rant> | 08:49 |
| *** SimonChung has joined #openstack-horizon | 08:50 | |
| robcresswell | This is important for deployers, as well as upstream :) | 08:50 |
| vgridnev | robcresswell, It's already covered by current tests, see that line: https://github.com/openstack/horizon/blob/master/openstack_dashboard/contrib/sahara/content/data_processing/nodegroup_templates/tests.py#L189 | 08:52 |
| *** kzaitsev_mb has quit IRC | 08:52 | |
| vgridnev | If you will remove that step, It will not be presented in any workflow step, so test will be failed | 08:53 |
| robcresswell | How can a current test cover code that has not yet been added? | 08:53 |
| robcresswell | That would mean the repo is already in failure state | 08:53 |
| robcresswell | If you add SelectNodeProcesses(workflows.Step), and there are NO tests, then if I remove SelectNodeProcesses, nobody will know, surely? | 08:54 |
| vgridnev | robcresswell, It just code refactoring, I replace one field to another step | 08:54 |
| robcresswell | sec, just reading code through and making sure I understand | 08:54 |
| mrunge | vgridnev, just to understand it right here: you're moving processes to a different workflow step, but you don't really care about that? | 08:56 |
| vgridnev | mrunge, right, just moving | 08:56 |
| mrunge | but if you don't care, why not abandoning the change? | 08:57 |
| mrunge | vgridnev, the proposal would be here: add a test, that renders your workflow | 08:58 |
| mrunge | test for presence of your important steps | 08:58 |
| mrunge | that's how to test for visual presentation | 08:58 |
| mrunge | the other test is about the presence of your post data | 08:58 |
| mrunge | vgridnev, does that make sense? | 08:59 |
| *** mpavlase has joined #openstack-horizon | 08:59 | |
| vgridnev | There are so many questions with that. We still care, because we still check that fields['processes'] is presented in some workflow | 09:03 |
| vgridnev | We need this change because we have plugins with more then 30 processes, that why we decided to move that processes field definition to another step. So, that why I don't abandon this change, because it's important for us | 09:05 |
| ^Gal^ | short question - I've added a table column which has a link, it works but the link has no text. I want to add my own custom text (not relates to any data) | 09:06 |
| robcresswell | vgridnev: Okay, so the test you are relying on is just looking for the presence of a field on creation; it doesn't verify the tabs presence at all. The patch could be reverted without testing. | 09:07 |
| mrunge | vgridnev, I was not really suggesting to abandon that change. but I was asking you to care a bit more about it. | 09:07 |
| robcresswell | vgridnev: I'm also curious, in the original code, checkboxselect multiple is not overriden, but here it is; why the override? | 09:08 |
| robcresswell | ^Gal^: Are you looking for this? https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L183 | 09:09 |
| *** stevemar has joined #openstack-horizon | 09:09 | |
| ^Gal^ | robcresswell: that's the column name right? I'm looking to change the inner text like: <a href="">some text </a> | 09:10 |
| robcresswell | ^Gal^: Nope, that's the action name, just needs a verbose_name field | 09:12 |
| *** stevemar has quit IRC | 09:12 | |
| *** rodrigods has quit IRC | 09:13 | |
| *** rodrigods has joined #openstack-horizon | 09:13 | |
| robcresswell | ^Gal^: Like this: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/metering/tables.py#L26 | 09:14 |
| ^Gal^ | robcresswell: I do have the verbose name set, but my link text shows as "-" | 09:15 |
| robcresswell | Can you paste your code? | 09:15 |
| robcresswell | ^Gal^: http://paste.openstack.org/ | 09:16 |
| ^Gal^ | yep, thanks | 09:16 |
| robcresswell | Just put the relevant bits and obfuscate anything important :) | 09:16 |
| vgridnev | It was overridden to group processes that is related to same sections together. | 09:17 |
| vgridnev | robcresswell, ^^ | 09:17 |
| openstackgerrit | Merged openstack/horizon: Edited create subnet comment to create network https://review.openstack.org/211969 | 09:18 |
| ^Gal^ | robcresswell: http://paste.openstack.org/show/412844/ | 09:18 |
| openstackgerrit | Merged openstack/horizon: Fixes align issue for database networking workflow https://review.openstack.org/183415 | 09:19 |
| *** tosky has joined #openstack-horizon | 09:19 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: filter doesn't handle unicode character https://review.openstack.org/211850 | 09:20 |
| robcresswell | ^Gal^: Ohh, I misread your initial question, I thought you had put a link inside the column as an action. I understand now. | 09:20 |
| ^Gal^ | robcresswell: :) | 09:21 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/212217 | 09:23 |
| *** mohankumar has joined #openstack-horizon | 09:25 | |
| robcresswell | ^Gal^: So, the fields are populated automatically but fallback to empty_value | 09:27 |
| robcresswell | Which is "-" by default, which is why you have that value | 09:27 |
| ^Gal^ | robcresswell: any ideas how to add my own? | 09:28 |
| robcresswell | You can override the empty_value :) | 09:28 |
| ^Gal^ | ohhhhhhhhh | 09:28 |
| ^Gal^ | robcresswell: that's great :) thanks! | 09:28 |
| robcresswell | Ideally though, the values should just be passed through as the first value | 09:29 |
| robcresswell | like "name_or_id" | 09:29 |
| robcresswell | etc | 09:29 |
| ^Gal^ | robcresswell: thanks I'll rethink our implementation, appreciate! | 09:30 |
| robcresswell | ^Gal^: No problem, ping again if you need more help | 09:31 |
| robcresswell | vgridnev: Ah, I see | 09:31 |
| ^Gal^ | robcresswell: appreciate :) | 09:31 |
| *** zhenguo has joined #openstack-horizon | 09:39 | |
| robcresswell | vgridnev, mrunge: mrunge's -1 is totally valid, there is no testing of presence of steps, the only test just checks for acceptance of value. This confirms the fields exist, but not where and how. | 09:41 |
| robcresswell | vgridnev: That said, the code is mostly okay, but I have a couple of small issues with the override, just looking into it more. | 09:41 |
| vgridnev | ok, I will add that shortly | 09:42 |
| *** yamamoto has quit IRC | 09:42 | |
| *** yamamoto has joined #openstack-horizon | 09:44 | |
| robcresswell | vgridnev: Thanks | 09:50 |
| openstackgerrit | vaibhav proposed openstack/horizon: Type and Code fields not marked * https://review.openstack.org/212444 | 09:51 |
| *** jcoufal has joined #openstack-horizon | 09:53 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:57 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Fixed alignment issues in create firewall https://review.openstack.org/209455 | 10:13 |
| openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 10:13 |
| *** romainh has quit IRC | 10:15 | |
| *** akrivoka has quit IRC | 10:15 | |
| *** yamamoto has quit IRC | 10:21 | |
| *** rakesh_mishra_ has quit IRC | 10:21 | |
| *** rakesh_mishra_ has joined #openstack-horizon | 10:22 | |
| *** lyanchih has quit IRC | 10:26 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/210887 | 10:27 |
| *** yamamoto has joined #openstack-horizon | 10:28 | |
| *** yamamoto has joined #openstack-horizon | 10:28 | |
| vgridnev | robcresswell, could please how that replacement to css works? Thanks in advance | 10:37 |
| bharath_ | tempest.api.network.test_fwaas_extensions was moved to neutron repo . How to run tempest for the cases which are under neutron repo? i tried to list cases using " sudo -u stack -H testr list-tests neutron.tests.api.test_fwaas_extensions" but this is returning empty list | 10:38 |
| *** jcoufal_ has joined #openstack-horizon | 10:44 | |
| *** yamamoto has quit IRC | 10:46 | |
| *** jcoufal has quit IRC | 10:47 | |
| *** sambetts has quit IRC | 10:49 | |
| *** rakesh_mishra__ has joined #openstack-horizon | 10:52 | |
| *** rakesh_mishra_ has quit IRC | 10:52 | |
| *** sayan has joined #openstack-horizon | 10:53 | |
| *** mohankumar has quit IRC | 10:54 | |
| *** romainh has joined #openstack-horizon | 11:02 | |
| *** chlong has joined #openstack-horizon | 11:04 | |
| *** stevemar has joined #openstack-horizon | 11:10 | |
| *** sayan has quit IRC | 11:11 | |
| *** sayan has joined #openstack-horizon | 11:12 | |
| *** stevemar has quit IRC | 11:14 | |
| *** christophs has joined #openstack-horizon | 11:14 | |
| *** christophs has joined #openstack-horizon | 11:14 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move node processes selection to own tab https://review.openstack.org/197018 | 11:14 |
| *** christophs has quit IRC | 11:15 | |
| *** christophs has joined #openstack-horizon | 11:15 | |
| *** christophs has joined #openstack-horizon | 11:15 | |
| vgridnev | robcresswell, mrunge I added a couple for tests, could you please take a look on it? | 11:15 |
| vgridnev | https://review.openstack.org/#/c/197018/ | 11:15 |
| *** ttrifonov is now known as zz_ttrifonov | 11:17 | |
| *** jcoufal has joined #openstack-horizon | 11:24 | |
| *** regebro has quit IRC | 11:24 | |
| *** rakesh_mishra__ has quit IRC | 11:25 | |
| *** lyanchih has joined #openstack-horizon | 11:26 | |
| *** jcoufal_ has quit IRC | 11:27 | |
| *** bharath_ has quit IRC | 11:27 | |
| openstackgerrit | Lennart Regebro proposed openstack/tuskar-ui: Adding i18n support https://review.openstack.org/212099 | 11:29 |
| *** jprovazn has quit IRC | 11:30 | |
| *** shunliz has joined #openstack-horizon | 11:31 | |
| robcresswell | vgridnev: Tests look better, at first glance, havent time to look properly. As for CSS, at this stage probably best to declare a data-processing css file as it will be removed anyway. Like this: https://github.com/openstack/horizon/blob/0ef239c6cf4b9d2f55d744f24b7aa0046afd390c/openstack_dashboard/test/test_plugins/panel_config/_10_admin_add_panel.py | 11:32 |
| robcresswell | grr, stupid branch. Better link: https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/test_plugins/panel_config/_10_admin_add_panel.py | 11:33 |
| *** jcoufal_ has joined #openstack-horizon | 11:33 | |
| *** yamamoto has joined #openstack-horizon | 11:34 | |
| *** kzaitsev_mb has quit IRC | 11:35 | |
| vgridnev | robcresswell, it's not so important stylings, so I removed that | 11:35 |
| *** zz_ttrifonov is now known as ttrifonov | 11:36 | |
| *** mohankumar has joined #openstack-horizon | 11:36 | |
| *** jcoufal has quit IRC | 11:37 | |
| *** mohankumar has quit IRC | 11:42 | |
| *** mohankumar has joined #openstack-horizon | 11:44 | |
| *** kzaitsev_mb has joined #openstack-horizon | 11:48 | |
| mrunge | has anyone tried horizon lately with keystone, when keystone uses PKI token? | 11:51 |
| mrunge | it looks like our token handling is just broken | 11:51 |
| robcresswell | :( | 11:52 |
| robcresswell | mrunge: Is it woring with stable/kilo? | 11:52 |
| mrunge | unfortunately not | 11:53 |
| robcresswell | Ack | 11:53 |
| robcresswell | Critical bug time? | 11:53 |
| mrunge | it's not completely broken, but there are things not working | 11:53 |
| mrunge | and looking deeper, it seems, it's just somehow working by coincidence | 11:53 |
| mrunge | I'll file a bug to coordinate | 11:54 |
| robcresswell | Link the bug when it's up and I will see if I can confirm | 11:55 |
| *** sayan has quit IRC | 11:59 | |
| *** sambetts has joined #openstack-horizon | 12:00 | |
| *** ducttape_ has joined #openstack-horizon | 12:04 | |
| mrunge | that'll be https://bugs.launchpad.net/django-openstack-auth/+bug/1484499 | 12:06 |
| openstack | Launchpad bug 1484499 in django-openstack-auth "user tenants list not working" [Undecided,New] | 12:06 |
| *** yamamoto has quit IRC | 12:07 | |
| *** mwhagedorn has joined #openstack-horizon | 12:10 | |
| *** jschlueter has quit IRC | 12:10 | |
| *** lyanchih has quit IRC | 12:11 | |
| mrunge | it looks like keystone tokens in horizon are getting hashed | 12:11 |
| *** ducttape_ has quit IRC | 12:11 | |
| *** sayan has joined #openstack-horizon | 12:11 | |
| *** masco has quit IRC | 12:17 | |
| *** ducttape_ has joined #openstack-horizon | 12:20 | |
| *** _crobertsrh is now known as crobertsrh | 12:21 | |
| *** crobertsrh has quit IRC | 12:23 | |
| ducttape_ | mrunge robcresswell - if you guys have a few minutes, review of https://review.openstack.org/#/c/184776/ would be nice (it's not my change, but one I would like to see) thanks! | 12:28 |
| mrunge | ducttape_, just clicked it, marking for later | 12:29 |
| ducttape_ | thanks! | 12:29 |
| mrunge | ducttape_, are you using pki tokens? | 12:29 |
| ducttape_ | I should just add you guys as reviewers | 12:30 |
| ducttape_ | we have fernets deployed | 12:30 |
| mrunge | ducttape_, ah yes. | 12:30 |
| ducttape_ | PKI is like fernets * 10, right ? ;) | 12:30 |
| mrunge | I haven't heard of anyone using fernets | 12:30 |
| *** lapalm has joined #openstack-horizon | 12:31 | |
| ducttape_ | it helps a bit, though not quite the performance benefits we first thought | 12:31 |
| *** jtriley has joined #openstack-horizon | 12:31 | |
| ducttape_ | we are looking to adding more caching to keystone for better performance | 12:31 |
| mrunge | ducttape_, I found out, our handling with tenants of a user is wrong, at least with PKI tokens | 12:31 |
| ducttape_ | that seems like an important detail | 12:31 |
| ducttape_ | :o | 12:32 |
| *** akrivoka has joined #openstack-horizon | 12:32 | |
| mrunge | I filed https://bugs.launchpad.net/django-openstack-auth/+bug/1484499 | 12:32 |
| openstack | Launchpad bug 1484499 in django-openstack-auth "token gets truncated with PKI tokens" [High,New] | 12:32 |
| mrunge | but I might have made myself not very clear | 12:32 |
| *** jcoufal_ has quit IRC | 12:33 | |
| ducttape_ | I understand it. I think it's clear enough | 12:33 |
| ducttape_ | if you are going to be working in DOA, you'd understand it at least | 12:33 |
| mrunge | ok, thanks | 12:34 |
| *** ducttape_ has quit IRC | 12:38 | |
| *** jcoufal has joined #openstack-horizon | 12:38 | |
| *** jtriley has quit IRC | 12:40 | |
| *** jcoufal has quit IRC | 12:52 | |
| *** jcoufal has joined #openstack-horizon | 12:52 | |
| *** crobertsrh has joined #openstack-horizon | 12:54 | |
| *** doug-fish has joined #openstack-horizon | 12:54 | |
| *** bapalm has joined #openstack-horizon | 12:55 | |
| *** lyanchih has joined #openstack-horizon | 12:55 | |
| *** bapalm__ has joined #openstack-horizon | 12:57 | |
| *** mohankumar has quit IRC | 12:58 | |
| *** bapalm___ has joined #openstack-horizon | 12:58 | |
| *** bapalm has quit IRC | 12:59 | |
| *** openstackgerrit has quit IRC | 13:01 | |
| *** bapalm__ has quit IRC | 13:01 | |
| *** openstackgerrit has joined #openstack-horizon | 13:02 | |
| *** neelashah has joined #openstack-horizon | 13:05 | |
| *** bapalm___ has quit IRC | 13:05 | |
| *** lyanchih has quit IRC | 13:06 | |
| *** yamamoto has joined #openstack-horizon | 13:07 | |
| *** pauloewerton has joined #openstack-horizon | 13:08 | |
| *** stevemar has joined #openstack-horizon | 13:11 | |
| *** yamamoto has quit IRC | 13:12 | |
| *** stevemar has quit IRC | 13:15 | |
| *** mwhagedorn has quit IRC | 13:17 | |
| *** mwhagedorn has joined #openstack-horizon | 13:17 | |
| *** julim has quit IRC | 13:19 | |
| *** Piet has quit IRC | 13:22 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Add support for event logs https://review.openstack.org/158715 | 13:22 |
| *** bebech has joined #openstack-horizon | 13:24 | |
| *** matt-borland has joined #openstack-horizon | 13:26 | |
| *** bebech has quit IRC | 13:27 | |
| *** kzaitsev_mb has quit IRC | 13:28 | |
| *** sayan has quit IRC | 13:29 | |
| *** BobBall has joined #openstack-horizon | 13:29 | |
| *** kzaitsev_mb has joined #openstack-horizon | 13:33 | |
| *** drupalmonkey has joined #openstack-horizon | 13:35 | |
| *** jtriley has joined #openstack-horizon | 13:42 | |
| *** kzaitsev_mb has quit IRC | 13:44 | |
| BobBall | Hey - I'm trying to port some changes to horizon and I'm getting an error "Something went wrong!". Nothing is logged in /var/log/apache2/; where else should I be looking for some logging about what might have gone wrong? | 13:45 |
| *** lyanchih has joined #openstack-horizon | 13:46 | |
| *** julim has joined #openstack-horizon | 13:46 | |
| mrunge | BobBall, you probably want to turn DEBUG = True | 13:51 |
| pkarikh | BobBall: you can try to set DEBUG=True in settings.py and restart apache. It could help to get more useful error message. | 13:51 |
| *** lblanchard has joined #openstack-horizon | 13:53 | |
| *** petertr7_away is now known as petertr7 | 13:54 | |
| *** kyleolivo has joined #openstack-horizon | 13:54 | |
| *** kzaitsev_mb has joined #openstack-horizon | 13:54 | |
| vgridnev | mrunge, could you please take a look on added tests? https://review.openstack.org/#/c/197018/ Maybe anything else is required? | 13:54 |
| mrunge | vgridnev, it's better now. | 13:57 |
| mrunge | vgridnev, I would make that an own test and name it in a way, that you could more easily figure out, that it's checking for presence of tabs | 13:57 |
| *** tvanderwiel has joined #openstack-horizon | 13:58 | |
| mrunge | naming that "test_copy" is a bit unfortunate | 13:58 |
| *** tvanderwiel has left #openstack-horizon | 13:58 | |
| mrunge | esp. since you're testing create_workflow | 13:58 |
| openstackgerrit | Lennart Regebro proposed openstack/tuskar-ui: Adding i18n support https://review.openstack.org/212099 | 13:59 |
| *** doug-fish has quit IRC | 13:59 | |
| *** kyleolivo has quit IRC | 13:59 | |
| *** ^Gal^ has quit IRC | 13:59 | |
| vgridnev | mrunge, that is just a part of existing tests, it's not my naming pattern | 13:59 |
| mrunge | vgridnev, what's wrong with making that an own test? | 14:00 |
| vgridnev | mrunge, I don't like a lot of copy paste | 14:00 |
| mrunge | you could re-use that code, refactor it | 14:00 |
| mrunge | vgridnev, I like the code to be clean and explicit. mixing it all together may work. but it makes maintenance much harder | 14:01 |
| *** ^Gal^__ has joined #openstack-horizon | 14:03 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Modify the pagination message to show total count https://review.openstack.org/212111 | 14:04 |
| openstackgerrit | Matt Borland proposed openstack/horizon: DEMO: Demonstrates how the pagination message change works. https://review.openstack.org/212181 | 14:04 |
| *** jtriley_ has joined #openstack-horizon | 14:06 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Modify the pagination message to show total count https://review.openstack.org/212111 | 14:08 |
| *** fifieldt has joined #openstack-horizon | 14:08 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: DEMO: Demonstrates how the pagination message change works. https://review.openstack.org/212181 | 14:08 |
| *** jtriley has quit IRC | 14:09 | |
| *** stevemar has joined #openstack-horizon | 14:12 | |
| *** stevemar has quit IRC | 14:15 | |
| BobBall | yay - thanks mrunge / pkarikh | 14:21 |
| *** devlaps has quit IRC | 14:24 | |
| *** stevemar has joined #openstack-horizon | 14:27 | |
| *** absubram has quit IRC | 14:29 | |
| *** e0ne has joined #openstack-horizon | 14:29 | |
| *** doug-fish has joined #openstack-horizon | 14:29 | |
| openstackgerrit | Darren Shaw proposed openstack/horizon: Fix local_settings.py.example to follow Python styling guidelines. https://review.openstack.org/212041 | 14:32 |
| *** ducttape_ has joined #openstack-horizon | 14:35 | |
| *** linkedinyou has quit IRC | 14:35 | |
| *** linkedinyou has joined #openstack-horizon | 14:42 | |
| *** vijendar has joined #openstack-horizon | 14:43 | |
| *** radez_g0n3 is now known as radez | 14:48 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Angular API https://review.openstack.org/209073 | 14:50 |
| *** bharath_ has joined #openstack-horizon | 14:50 | |
| *** petertr7 is now known as petertr7_away | 14:52 | |
| *** kzaitsev_mb has quit IRC | 14:54 | |
| *** morgan_404 is now known as morgan_302 | 14:55 | |
| *** Ephur has joined #openstack-horizon | 15:02 | |
| *** Piet has joined #openstack-horizon | 15:03 | |
| *** kzaitsev_mb has joined #openstack-horizon | 15:03 | |
| *** Drago has joined #openstack-horizon | 15:05 | |
| *** ^Gal^__ has quit IRC | 15:05 | |
| *** ^Gal^ has joined #openstack-horizon | 15:05 | |
| *** jcoufal has quit IRC | 15:06 | |
| *** Drago has quit IRC | 15:06 | |
| *** Ephur has quit IRC | 15:06 | |
| *** Drago has joined #openstack-horizon | 15:06 | |
| openstackgerrit | Darren Shaw proposed openstack/horizon: Correct local_settings example from overwriting settings https://review.openstack.org/212090 | 15:08 |
| *** ^Gal^ has quit IRC | 15:10 | |
| *** bpokorny has joined #openstack-horizon | 15:11 | |
| *** hurgleburgler has joined #openstack-horizon | 15:13 | |
| *** TravT has quit IRC | 15:14 | |
| *** TravT has joined #openstack-horizon | 15:14 | |
| *** vgridnev has quit IRC | 15:18 | |
| matt-borland | ducttape_: I put a screenshot of the Image Details including the block-format display of the properties | 15:18 |
| matt-borland | into invision | 15:18 |
| *** nlahouti has joined #openstack-horizon | 15:18 | |
| ducttape_ | thanks. | 15:18 |
| ducttape_ | I look forward to invision sending me 20 emails notifying me that one item changed | 15:19 |
| *** kzaitsev_mb has quit IRC | 15:19 | |
| matt-borland | oh gosh, don't you know it ducttape_ | 15:19 |
| Piet | How bad are the notifications? | 15:20 |
| matt-borland | the default is to send a notification for any comment | 15:21 |
| Piet | Sounds like I need to look into reducing comments. | 15:21 |
| ducttape_ | not great. something like a daily digest might help, could be my personal preferences or the defaults are bad | 15:21 |
| matt-borland | so for sys info I got probably 30x notifications. I like the comments, just not the notices :) | 15:21 |
| Piet | Rather, notifications (not comments) | 15:21 |
| Piet | k | 15:22 |
| matt-borland | I try to un-check notifications when posting, but the default is to notify all people | 15:22 |
| Piet | let me look into it | 15:22 |
| matt-borland | thanks Piet! | 15:22 |
| *** SimonChung has quit IRC | 15:22 | |
| *** geoffarnold has joined #openstack-horizon | 15:23 | |
| *** hhuang has quit IRC | 15:23 | |
| Piet | BTW - had a good chat with the Intel Open Source UX team this morning. Looks like OpenStack will be getting cycles from them. | 15:23 |
| ducttape_ | matt-borland - here is something to think about - | 15:23 |
| matt-borland | yep? | 15:24 |
| ducttape_ | the actions at the top of the page - you might want those actions moved into the lower 4 quadrants.... with actions fitting into one of the areas | 15:24 |
| ducttape_ | like share image would go into the security info area | 15:24 |
| ducttape_ | or something like that | 15:24 |
| *** ttrifonov is now known as zz_ttrifonov | 15:24 | |
| ducttape_ | just an idea, not sure if it's a good idea | 15:24 |
| matt-borland | interesting, we'd also thought of something similar when mocking up the Instances screens | 15:25 |
| matt-borland | putting actions in relevant places | 15:25 |
| matt-borland | one issue we'd had is when we had multiple tabs | 15:25 |
| matt-borland | (not the case here) | 15:25 |
| matt-borland | if there were persistent actions that we should have "above the bar" (above the tabs) | 15:26 |
| *** kyleolivo has joined #openstack-horizon | 15:26 | |
| matt-borland | we wanted to make sure those were always available. | 15:26 |
| ducttape_ | could be, larger actions like high level CRUD stuff | 15:26 |
| matt-borland | exactly | 15:26 |
| matt-borland | I think with respect to the block vs. horizontal display of properties, | 15:27 |
| *** vgridnev has joined #openstack-horizon | 15:27 | |
| matt-borland | most of the useful information like you say is probably more readable as a block | 15:27 |
| *** mpavlase has left #openstack-horizon | 15:27 | |
| matt-borland | although for some things, like the owner/status above, it can probably remain horizontal, as long as there's only one such line | 15:28 |
| matt-borland | multiple lines each containing multiple properties is harder to read | 15:28 |
| ducttape_ | the horizontal display was not easy to read, at least in that case. I think we should have maybe a general rule: horizontal display of multiple pieces of data should use a table with column headings | 15:29 |
| *** shunliz has quit IRC | 15:29 | |
| *** vishwanathj has joined #openstack-horizon | 15:29 | |
| ducttape_ | and details with key/value pairs should in general use a vertical listing of name: value | 15:29 |
| ducttape_ | if you have multiple values, you are free to use either table or vertical | 15:30 |
| *** kyleolivo has quit IRC | 15:30 | |
| ducttape_ | something like that, at least. maybe Piet will have a list of best practices :p | 15:30 |
| ducttape_ | and then we can try to break all those rules | 15:31 |
| Piet | ;^) | 15:32 |
| *** e0ne has quit IRC | 15:32 | |
| *** romainh has quit IRC | 15:32 | |
| matt-borland | I'll get some other perspectives on the displays as well. Thanks for looking through these ducttape_: | 15:32 |
| Piet | I mentioned the need for a patterns library/best practices guide to the Intel folks. Hopefully they'll bite | 15:33 |
| robcresswell | ducttape_: I saw your post about that patch btw (Delete VIP Action Refactoring) is on my list | 15:36 |
| ducttape_ | thanks. we are in the process of taking lbaas to production, that bug is on our list of stuff we need. I might have more. My boss is good at lists ;) | 15:37 |
| robcresswell | ducttape_: Yeah, ping if there's others. Sometimes we get a bit lost in developer land (he says, while working on his "Developer Dashboard" patch) | 15:37 |
| *** kzaitsev_mb has joined #openstack-horizon | 15:43 | |
| *** petertr7_away is now known as petertr7 | 15:44 | |
| *** amotoki has joined #openstack-horizon | 15:44 | |
| *** kzaitsev_mb has quit IRC | 15:48 | |
| *** petertr7 is now known as petertr7_away | 15:53 | |
| *** kzaitsev_mb has joined #openstack-horizon | 15:54 | |
| *** bharath_ has quit IRC | 15:55 | |
| *** aorourke has joined #openstack-horizon | 15:58 | |
| *** hhuang has joined #openstack-horizon | 16:01 | |
| *** Ephur has joined #openstack-horizon | 16:02 | |
| *** MaxV_ has quit IRC | 16:03 | |
| *** akrivoka_ has joined #openstack-horizon | 16:04 | |
| *** akrivoka has quit IRC | 16:06 | |
| *** shivrao has joined #openstack-horizon | 16:06 | |
| *** alexpilotti_ has joined #openstack-horizon | 16:11 | |
| *** kmARC has quit IRC | 16:14 | |
| *** SimonChung has joined #openstack-horizon | 16:14 | |
| *** akrivoka_ has quit IRC | 16:15 | |
| *** vgridnev has quit IRC | 16:18 | |
| *** hhuang has quit IRC | 16:18 | |
| *** garthb has joined #openstack-horizon | 16:18 | |
| *** alexpilotti_ is now known as alexpilotti | 16:19 | |
| *** alexpilotti has quit IRC | 16:19 | |
| *** alexpilotti has joined #openstack-horizon | 16:19 | |
| *** alexpilotti has quit IRC | 16:19 | |
| *** gyee has joined #openstack-horizon | 16:22 | |
| *** alejandrito has joined #openstack-horizon | 16:22 | |
| *** garthb has quit IRC | 16:29 | |
| *** openstackgerrit has quit IRC | 16:31 | |
| *** openstackgerrit has joined #openstack-horizon | 16:32 | |
| *** Sukhdev has joined #openstack-horizon | 16:32 | |
| *** petertr7_away is now known as petertr7 | 16:32 | |
| ducttape_ | david-lyle or robcresswell - do you guys know if there is a ticket or blueprint on extensibility ? I was going to add docs (the horror - I know!) and I need to get the gerrit book keeping correct | 16:36 |
| david-lyle | ducttape_: limitied | 16:37 |
| david-lyle | wait you asked about extensibility not amount of docs | 16:37 |
| david-lyle | you could tie it to https://blueprints.launchpad.net/horizon/+spec/plugin-sanity if you think it lines up | 16:38 |
| david-lyle | but if it's documenting how to extend now, I'd just file a bug | 16:38 |
| ducttape_ | yeah, I just need to add "don't use overrides - use something else instead blah blah" | 16:38 |
| david-lyle | lacking docs is a bug | 16:39 |
| david-lyle | just file a new bug and point at that | 16:39 |
| david-lyle | thanks for addressing that ducttape_ | 16:40 |
| *** petertr7 is now known as petertr7_away | 16:40 | |
| robcresswell | Yeah I can't recall a bp about it | 16:41 |
| robcresswell | ducttape_: ^^ | 16:41 |
| robcresswell | bug would be great | 16:41 |
| ducttape_ | ok | 16:41 |
| *** kyleolivo has joined #openstack-horizon | 16:41 | |
| robcresswell | Thanks for adding to the docs btw. | 16:42 |
| *** kyleolivo has quit IRC | 16:42 | |
| robcresswell | Really cuts down on repeated questions in IRC when I can just point people at docs | 16:42 |
| *** KunalGandhi has joined #openstack-horizon | 16:45 | |
| *** jamielennox is now known as jamielennox|away | 16:45 | |
| *** bharath_ has joined #openstack-horizon | 16:48 | |
| david-lyle | robcresswell: does it? | 16:49 |
| david-lyle | :D | 16:49 |
| david-lyle | probably does | 16:49 |
| david-lyle | and nice to have a reference to point people to | 16:49 |
| *** lyanchih has quit IRC | 16:51 | |
| *** kmARC has joined #openstack-horizon | 16:53 | |
| *** kmARC has quit IRC | 16:54 | |
| *** kyleolivo has joined #openstack-horizon | 16:54 | |
| *** rajatvig has joined #openstack-horizon | 16:54 | |
| *** kmARC has joined #openstack-horizon | 16:54 | |
| *** rdopiera has quit IRC | 16:57 | |
| *** kyleolivo has quit IRC | 16:59 | |
| *** lapalm has quit IRC | 17:00 | |
| *** lapalm has joined #openstack-horizon | 17:01 | |
| *** skylerberg has joined #openstack-horizon | 17:02 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 17:02 |
| *** kmARC has quit IRC | 17:03 | |
| *** zhenguo has quit IRC | 17:03 | |
| *** petertr7_away is now known as petertr7 | 17:05 | |
| *** lapalm has quit IRC | 17:05 | |
| *** kristinebrown has joined #openstack-horizon | 17:07 | |
| *** petertr7 is now known as petertr7_away | 17:10 | |
| *** zz_ttrifonov is now known as ttrifonov | 17:10 | |
| *** vgridnev has joined #openstack-horizon | 17:13 | |
| *** vishwanathj has quit IRC | 17:15 | |
| *** kyleolivo has joined #openstack-horizon | 17:15 | |
| *** ^Gal^ has joined #openstack-horizon | 17:18 | |
| *** kristinebrown has quit IRC | 17:21 | |
| *** kyleolivo has quit IRC | 17:21 | |
| *** rajatvig has quit IRC | 17:22 | |
| *** vgridnev has quit IRC | 17:23 | |
| *** kristinebrown has joined #openstack-horizon | 17:24 | |
| *** rajatvig has joined #openstack-horizon | 17:24 | |
| *** petertr7_away is now known as petertr7 | 17:25 | |
| *** amotoki has quit IRC | 17:25 | |
| *** jingjing_ren has joined #openstack-horizon | 17:26 | |
| *** jingjing_ren has quit IRC | 17:26 | |
| *** jingjing_ren has joined #openstack-horizon | 17:26 | |
| *** mrunge has quit IRC | 17:26 | |
| *** petertr7 is now known as petertr7_away | 17:27 | |
| *** tqtran has joined #openstack-horizon | 17:28 | |
| *** ^Gal^ has quit IRC | 17:29 | |
| *** ^Gal^ has joined #openstack-horizon | 17:29 | |
| *** absubram has joined #openstack-horizon | 17:31 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 17:35 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 17:35 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 17:36 |
| *** sambetts has quit IRC | 17:36 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: remove django<1.7 from tests https://review.openstack.org/201066 | 17:36 |
| *** shivrao has quit IRC | 17:38 | |
| *** ^Gal^ has quit IRC | 17:41 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 17:42 |
| *** Ephur_ has joined #openstack-horizon | 17:46 | |
| *** Ephur has quit IRC | 17:48 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 17:49 |
| *** Ephur has joined #openstack-horizon | 17:50 | |
| *** Ephur_ has quit IRC | 17:51 | |
| *** petertr7_away is now known as petertr7 | 17:51 | |
| *** TravT has quit IRC | 17:51 | |
| *** markus_z has quit IRC | 17:53 | |
| *** mwhagedorn has quit IRC | 17:53 | |
| *** ybathia has joined #openstack-horizon | 17:54 | |
| *** lapalm has joined #openstack-horizon | 17:54 | |
| ducttape_ | david-lyle - I think you can close this one https://bugs.launchpad.net/horizon/+bug/1378560 | 17:54 |
| openstack | Launchpad bug 1378560 in OpenStack Dashboard (Horizon) "Customizing Horizon doc needs to be cleaned up" [Low,Confirmed] - Assigned to Cindy Lu (clu-m) | 17:54 |
| *** mwhagedorn has joined #openstack-horizon | 17:54 | |
| *** saksham has joined #openstack-horizon | 17:55 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Context Selection should be to the right https://review.openstack.org/212682 | 17:55 |
| *** lapalm has quit IRC | 17:55 | |
| *** TravT has joined #openstack-horizon | 17:55 | |
| *** lapalm has joined #openstack-horizon | 17:55 | |
| hurgleburgler | New responsive context selection menu if anyone wants to give it a test run ^ | 17:56 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Updating docs for customization https://review.openstack.org/212683 | 17:56 |
| *** shivrao has joined #openstack-horizon | 17:56 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Updating docs for customization https://review.openstack.org/212683 | 17:57 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 17:59 |
| *** tosky has quit IRC | 17:59 | |
| Piet | Can you guys review the following projects and leave comments? They went away from the Select Flavor pattern for Launch Instance and wanted your feedback. https://openstack.invisionapp.com/d/main/#/projects/4168226 | 17:59 |
| *** lapalm_ has joined #openstack-horizon | 17:59 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 17:59 |
| *** jingjing_ren has quit IRC | 17:59 | |
| *** lapalm has quit IRC | 17:59 | |
| *** kmARC has joined #openstack-horizon | 18:00 | |
| *** kyleolivo has joined #openstack-horizon | 18:01 | |
| *** bpokorny_ has joined #openstack-horizon | 18:02 | |
| *** jingjing_ren has joined #openstack-horizon | 18:02 | |
| *** lapalm_ has quit IRC | 18:04 | |
| *** mwhagedorn has quit IRC | 18:04 | |
| *** jingjing_ren has quit IRC | 18:04 | |
| *** lapalm has joined #openstack-horizon | 18:05 | |
| *** bpokorny has quit IRC | 18:05 | |
| *** mwhagedorn has joined #openstack-horizon | 18:05 | |
| *** drupalmonkey has quit IRC | 18:07 | |
| *** SimonChung has quit IRC | 18:07 | |
| *** SimonChung1 has joined #openstack-horizon | 18:07 | |
| *** jingjing_ren has joined #openstack-horizon | 18:07 | |
| *** bpokorny_ has quit IRC | 18:08 | |
| *** kmARC has quit IRC | 18:11 | |
| *** nlahouti has quit IRC | 18:13 | |
| *** kyleolivo has quit IRC | 18:14 | |
| *** kyleolivo has joined #openstack-horizon | 18:15 | |
| *** nlahouti has joined #openstack-horizon | 18:19 | |
| *** kyleolivo has quit IRC | 18:22 | |
| *** lhcheng has joined #openstack-horizon | 18:23 | |
| *** petertr7 is now known as petertr7_away | 18:23 | |
| *** kyleolivo has joined #openstack-horizon | 18:26 | |
| *** TravT_ has joined #openstack-horizon | 18:28 | |
| *** bpokorny has joined #openstack-horizon | 18:29 | |
| *** kyleolivo has quit IRC | 18:29 | |
| *** TravT has quit IRC | 18:30 | |
| *** Sukhdev has quit IRC | 18:32 | |
| *** SimonChung has joined #openstack-horizon | 18:32 | |
| *** SimonChung1 has quit IRC | 18:32 | |
| *** nlahouti has quit IRC | 18:37 | |
| *** petertr7_away is now known as petertr7 | 18:39 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Directive to check if Service is enabled https://review.openstack.org/212125 | 18:39 |
| *** nlahouti has joined #openstack-horizon | 18:42 | |
| *** kzaitsev_mb has quit IRC | 18:43 | |
| *** lapalm_ has joined #openstack-horizon | 18:43 | |
| *** gyee has quit IRC | 18:45 | |
| *** jwy has joined #openstack-horizon | 18:45 | |
| *** lapalm has quit IRC | 18:46 | |
| *** kristinebrown has quit IRC | 18:46 | |
| rajatvig | TravT_: I addressed most of the comments in https://review.openstack.org/212125. Please do look when you've some time. I'll merge it to the parent patch post that. Thanks. | 18:47 |
| *** kristinebrown has joined #openstack-horizon | 18:48 | |
| *** TravT_ is now known as TravT | 18:59 | |
| TravT | rajatvig: Great, thanks. I'll look in a couple minutes. | 18:59 |
| *** drupalmonkey has joined #openstack-horizon | 19:05 | |
| *** nlahouti has quit IRC | 19:07 | |
| *** bapalm_ is now known as bapalm | 19:07 | |
| *** neelashah has quit IRC | 19:07 | |
| *** jingjing_ren has quit IRC | 19:10 | |
| *** nlahouti has joined #openstack-horizon | 19:12 | |
| *** jingjing_ren has joined #openstack-horizon | 19:13 | |
| kfox1111 | any more reviewers for: https://review.openstack.org/#/c/199333 ? :) | 19:15 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Updating docs for customization https://review.openstack.org/212683 | 19:15 |
| *** petertr7 is now known as petertr7_away | 19:20 | |
| ducttape_ | kfox1111: you might have input for https://review.openstack.org/#/c/212683/ as well, docs for customizing horizon | 19:20 |
| * ducttape_ is trolling for reviews of https://review.openstack.org/#/c/184776/ lbaas fix from Tatiana | 19:21 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Context Selection should be to the right https://review.openstack.org/212682 | 19:23 |
| lhcheng | ducttape_: I'll take a look at that, I've did the initial review anyway | 19:23 |
| ducttape_ | I'll tell "he who shall not be named" if you slow it down ;) lhcheng | 19:25 |
| *** petertr7_away is now known as petertr7 | 19:25 | |
| *** kmARC has joined #openstack-horizon | 19:25 | |
| *** lapalm_ has quit IRC | 19:26 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Context Selection should be to the right https://review.openstack.org/212682 | 19:26 |
| *** lapalm has joined #openstack-horizon | 19:26 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Context Selection should be to the right https://review.openstack.org/212682 | 19:27 |
| openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Add domain scoped token to session in multidomain https://review.openstack.org/141153 | 19:27 |
| *** lapalm has quit IRC | 19:31 | |
| *** kristinebrown has quit IRC | 19:32 | |
| *** fifieldt_ has joined #openstack-horizon | 19:33 | |
| *** fifieldt has quit IRC | 19:34 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 19:37 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 19:38 |
| *** rajatvig has quit IRC | 19:39 | |
| *** saksham has quit IRC | 19:40 | |
| *** vgridnev has joined #openstack-horizon | 19:42 | |
| *** alejandrito has quit IRC | 19:44 | |
| *** Sukhdev has joined #openstack-horizon | 19:47 | |
| *** nlahouti has quit IRC | 19:51 | |
| *** TravT has quit IRC | 19:51 | |
| matt-borland | ducttape_: you can set those InVision notifications to be on a digest | 19:51 |
| matt-borland | (profile) > Email Notifications | 19:51 |
| ducttape_ | yep, I did that. I'm looking forward to getting a reprieve ;) | 19:51 |
| *** TravT has joined #openstack-horizon | 19:52 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 19:57 |
| *** kmARC has quit IRC | 19:58 | |
| *** lapalm has joined #openstack-horizon | 20:00 | |
| *** lapalm_ has joined #openstack-horizon | 20:02 | |
| *** lapalm_ has quit IRC | 20:03 | |
| *** lapalm_ has joined #openstack-horizon | 20:03 | |
| *** lapalm has quit IRC | 20:05 | |
| *** rajatvig has joined #openstack-horizon | 20:10 | |
| *** bharath_ has quit IRC | 20:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/212217 | 20:17 |
| *** garthb has joined #openstack-horizon | 20:19 | |
| *** cardeois has joined #openstack-horizon | 20:21 | |
| *** rajatvig has quit IRC | 20:22 | |
| *** mpavlase has joined #openstack-horizon | 20:24 | |
| *** petertr7 is now known as petertr7_away | 20:27 | |
| *** kyleolivo has joined #openstack-horizon | 20:27 | |
| *** alejandrito has joined #openstack-horizon | 20:28 | |
| *** Piet has quit IRC | 20:29 | |
| *** rajatvig has joined #openstack-horizon | 20:29 | |
| *** petertr7_away is now known as petertr7 | 20:32 | |
| *** kyleolivo has quit IRC | 20:33 | |
| *** garthb has quit IRC | 20:33 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Add example keystone v3 policy file to horizon https://review.openstack.org/162325 | 20:33 |
| *** kyleolivo has joined #openstack-horizon | 20:33 | |
| *** Drago has quit IRC | 20:37 | |
| *** Drago has joined #openstack-horizon | 20:37 | |
| *** Drago has quit IRC | 20:37 | |
| *** Drago has joined #openstack-horizon | 20:37 | |
| *** matt-borland has quit IRC | 20:41 | |
| *** tjones has joined #openstack-horizon | 20:43 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for KeyStone Service https://review.openstack.org/211782 | 20:45 |
| *** kristinebrown has joined #openstack-horizon | 20:47 | |
| *** saksham has joined #openstack-horizon | 20:47 | |
| *** nlahouti has joined #openstack-horizon | 20:48 | |
| *** kyleolivo has quit IRC | 20:49 | |
| openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Add domain scoped token to session in multidomain https://review.openstack.org/141153 | 20:49 |
| *** Guest61394 is now known as med_ | 20:51 | |
| *** med_ has joined #openstack-horizon | 20:51 | |
| *** julim has quit IRC | 20:52 | |
| *** kmARC has joined #openstack-horizon | 20:54 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 20:55 |
| *** lblanchard has quit IRC | 20:56 | |
| *** kmARC has quit IRC | 20:58 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel https://review.openstack.org/206203 | 20:59 |
| *** kzaitsev_mb has joined #openstack-horizon | 21:02 | |
| lhcheng | ducttape_: I promise to show up in the next meeting | 21:04 |
| lhcheng | ducttape_: ;-) | 21:04 |
| ducttape_ | sure ya do.... sure ya do | 21:04 |
| *** SimonChung1 has joined #openstack-horizon | 21:06 | |
| *** SimonChung has quit IRC | 21:06 | |
| *** vijendar has quit IRC | 21:06 | |
| *** petertr7 is now known as petertr7_away | 21:07 | |
| *** SimonChung1 has quit IRC | 21:07 | |
| *** SimonChung has joined #openstack-horizon | 21:07 | |
| *** SimonChung1 has joined #openstack-horizon | 21:07 | |
| *** SimonChung has quit IRC | 21:07 | |
| *** SimonChung has joined #openstack-horizon | 21:08 | |
| *** SimonChung1 has quit IRC | 21:08 | |
| *** vijendar has joined #openstack-horizon | 21:10 | |
| *** yamamoto has joined #openstack-horizon | 21:10 | |
| *** SimonChung has quit IRC | 21:11 | |
| *** SimonChung has joined #openstack-horizon | 21:11 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Add example keystone v3 policy file to horizon https://review.openstack.org/162325 | 21:14 |
| *** kmARC has joined #openstack-horizon | 21:14 | |
| *** Piet has joined #openstack-horizon | 21:15 | |
| *** jtriley_ has quit IRC | 21:16 | |
| kfox1111 | ducttape_: thanks. I'll have a look. | 21:16 |
| *** vishwanathj has joined #openstack-horizon | 21:17 | |
| *** kyleolivo has joined #openstack-horizon | 21:18 | |
| *** yamamoto has quit IRC | 21:19 | |
| *** Sukhdev has quit IRC | 21:21 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for Nova Service https://review.openstack.org/211783 | 21:21 |
| *** kyleolivo has quit IRC | 21:21 | |
| *** kmARC_ has joined #openstack-horizon | 21:22 | |
| *** crobertsrh has left #openstack-horizon | 21:24 | |
| *** Sukhdev has joined #openstack-horizon | 21:24 | |
| *** crobertsrh has joined #openstack-horizon | 21:25 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for KeyStone Service https://review.openstack.org/211782 | 21:34 |
| vishwanathj | lhcheng, hi | 21:34 |
| lhcheng | vishwanathj: hey | 21:35 |
| vishwanathj | I am noticing that the error message generated by an exception on the server side is not being displayed when the exception is caught by the horizon code.... | 21:36 |
| *** lapalm_ has quit IRC | 21:37 | |
| vishwanathj | I just get a generic message.... | 21:38 |
| *** lapalm has joined #openstack-horizon | 21:38 | |
| *** kristinebrown has quit IRC | 21:39 | |
| lhcheng | vishwanathj: yeah, the exception message from server side is not translatable | 21:39 |
| vishwanathj | Line 105 at https://review.openstack.org/#/c/212223/2/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/forms.py,unified should work right? | 21:39 |
| lhcheng | I think there is blueprint to make the error message better | 21:39 |
| lhcheng | but it got buried with other BP | 21:40 |
| vishwanathj | oh I see | 21:40 |
| lhcheng | hopefully it can be revived in the horizon driver meeting | 21:40 |
| vishwanathj | but, when I step through the debugger, I do see the message from the server though | 21:40 |
| vishwanathj | I mean, the exception in horizon code has the error message from the server | 21:41 |
| *** dsneddon has joined #openstack-horizon | 21:41 | |
| *** alejandrito has quit IRC | 21:41 | |
| *** rajatvig has quit IRC | 21:41 | |
| lhcheng | vishwanathj: don't think you need _() in _(e.message) | 21:41 |
| vishwanathj | ok | 21:42 |
| *** gyee has joined #openstack-horizon | 21:42 | |
| lhcheng | vishwanathj: you might want to do "str(e.message)" | 21:43 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Table https://review.openstack.org/199567 | 21:43 |
| vishwanathj | lhcheng, let me try your suggestion | 21:44 |
| vishwanathj | lhcheng: I made the change you suggested, i still get the generic message "Danger: There was an error submitting the form. Please try again" | 21:47 |
| *** stevemar has quit IRC | 21:51 | |
| lhcheng | vishwanathj: I wonder if there is some error in the clean method.. you can add some logging just before the exception.handle() to verify if its called. | 21:52 |
| *** cardeois has quit IRC | 21:52 | |
| *** lapalm has quit IRC | 21:55 | |
| *** crobertsrh has quit IRC | 21:55 | |
| vishwanathj | lhcheng, when using the pycharm debugger, i set a break point where the exception.handle() is being called, I do get to the breakpoint and the e.message contains the message from the server | 21:57 |
| *** crobertsrh has joined #openstack-horizon | 21:58 | |
| *** kristinebrown has joined #openstack-horizon | 22:03 | |
| tjones | gotta interesting (i think) question. i have a ChoiceField that has a Select widget that is switchable and controls if another ChoiceField is visible or not (based on the choice selection). when the (call it) parent ChoiceField value is set by javascript the (call it) child never becomes visible. Only when i manually select the value it will work. Any ideas on how to trigger the switched action when the javascript does the selection? | 22:03 |
| *** alexpilotti has joined #openstack-horizon | 22:04 | |
| *** SimonChung1 has joined #openstack-horizon | 22:04 | |
| *** SimonChung has quit IRC | 22:04 | |
| *** morgan_302 has quit IRC | 22:04 | |
| *** vijendar has quit IRC | 22:05 | |
| *** SimonChung has joined #openstack-horizon | 22:05 | |
| *** SimonChung1 has quit IRC | 22:05 | |
| *** drupalmonkey has quit IRC | 22:07 | |
| *** morganfainberg has joined #openstack-horizon | 22:07 | |
| *** pauloewerton has quit IRC | 22:07 | |
| lhcheng | vishwanathj: digging into the code, give me a few | 22:11 |
| vishwanathj | lhcheng, sure, thanks a bunch | 22:11 |
| *** doug-fish has left #openstack-horizon | 22:11 | |
| *** gyee is now known as gyee_500 | 22:12 | |
| vishwanathj | lhcheng, not sure if I am doing it right, but I put a messages.error(request, str(e.message)) before the exceptions.handle()....that atleast shows me the error message from the server | 22:13 |
| lhcheng | vishwanathj: does it still show you "Danger: There was an error submitting the form... " ? | 22:14 |
| vishwanathj | it shows the error message from the server and also the generic danger message | 22:14 |
| *** crobertsrh is now known as _crobertsrh | 22:16 | |
| *** tvanderwiel has joined #openstack-horizon | 22:16 | |
| *** Drago1 has joined #openstack-horizon | 22:24 | |
| lhcheng | vishwanathj: I tried it with the existing code too, I got the same behavior | 22:25 |
| lhcheng | vishwanathj: I suspect it is a regression | 22:25 |
| lhcheng | vishwanathj: do you mind opening a bug for that. | 22:26 |
| *** stevemar has joined #openstack-horizon | 22:26 | |
| *** Drago has quit IRC | 22:26 | |
| vishwanathj | lhcheng, I dont mind opening a bug, should the bug be that message is not being displayed by the exceptions.handle() and not only a generic message is being thrown? | 22:27 |
| lhcheng | vishwanathj: in the old behavior, the modal window should remain open with the error msg | 22:27 |
| lhcheng | vishwanathj: yup, and mention the expected behavior too | 22:28 |
| vishwanathj | lhcheng, looks like others have already opened a bug that displays the danger message, see https://bugs.launchpad.net/horizon/+bug/1437230 | 22:31 |
| openstack | Launchpad bug 1437230 in OpenStack Dashboard (Horizon) "The error is not propagated to the UI when https request fails due to disk space exhaustion" [Undecided,New] | 22:31 |
| vishwanathj | let me know if you still need me to open another bug | 22:31 |
| *** julim has joined #openstack-horizon | 22:32 | |
| *** vgridnev has quit IRC | 22:32 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Updating docs for customization https://review.openstack.org/212683 | 22:33 |
| *** jamielennox|away is now known as jamielennox | 22:33 | |
| lhcheng | vishwanathj: I think that might be specific to "disk space exhaustion" | 22:33 |
| vishwanathj | lhcheng, Ok, I will go ahead and open the bug that we discussed | 22:34 |
| lhcheng | vishwanathj: thanks! | 22:34 |
| *** tvanderwiel has quit IRC | 22:35 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Fixed translation in python modal templates https://review.openstack.org/212823 | 22:36 |
| *** kmARC_ has quit IRC | 22:39 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Add example keystone v3 policy file to horizon https://review.openstack.org/162325 | 22:40 |
| *** kmARC has quit IRC | 22:40 | |
| vishwanathj | lhcheng, bug is now opened - https://bugs.launchpad.net/horizon/+bug/1484723 | 22:43 |
| openstack | Launchpad bug 1484723 in OpenStack Dashboard (Horizon) "Error message from server not being displayed in Horizon UI" [Undecided,New] | 22:43 |
| *** vgridnev has joined #openstack-horizon | 22:43 | |
| *** absubram has quit IRC | 22:43 | |
| *** vgridnev has quit IRC | 22:44 | |
| lhcheng | vishwanathj: I've targetted it for L-3, hopefully someone can pick it up. Thanks for reporting the bug. | 22:45 |
| vishwanathj | lhcheng, if you can guide me, I can attempt to fix it | 22:46 |
| david-lyle | vishwanathj: lhcheng in the above bug what is server? | 22:48 |
| david-lyle | cinder or horizon? | 22:48 |
| vishwanathj | david-lyle, in my case it is the tacker code in stackforge, but it could be cinder or neutron as well | 22:49 |
| *** alexpilotti has quit IRC | 22:49 | |
| david-lyle | right, but we don't pass on server generated strings on purpose | 22:50 |
| lhcheng | david-lyle: I can reproduce it in my local horizon too, you can reproduce it on any modal form | 22:50 |
| david-lyle | server/service | 22:50 |
| *** ducttape_ has quit IRC | 22:50 | |
| david-lyle | my question is what is generating the message that is missing? | 22:50 |
| david-lyle | neutron or horizon? | 22:50 |
| david-lyle | only a bug if the answer is horizon, so think carefully :) | 22:51 |
| lhcheng | the bug summary may not be accurate :) | 22:51 |
| david-lyle | it's not clear | 22:51 |
| david-lyle | that's for sure | 22:51 |
| david-lyle | which is why I'm asking | 22:51 |
| vishwanathj | lhcheng, I am sorry, filled in with details that I knew...please feel free to edit | 22:51 |
| david-lyle | and still don't know the answer | 22:51 |
| lhcheng | server = django.forms | 22:52 |
| lhcheng | for example: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/roles/forms.py#L33 | 22:52 |
| david-lyle | if you're telling me the handling of form errors is broken, I will agree with that | 22:52 |
| lhcheng | yup | 22:52 |
| david-lyle | I believe that's been around for years | 22:52 |
| david-lyle | probably time to fix | 22:52 |
| david-lyle | I had some way of making it work, way back | 22:52 |
| david-lyle | let's clarify the bug report | 22:53 |
| lhcheng | the error msg does not show up, it jst close the modal, and just show "danger: there is an error submitting the form" | 22:53 |
| david-lyle | yes | 22:53 |
| *** rajatvig has joined #openstack-horizon | 22:53 | |
| david-lyle | I think my workaround was post the message directly then redirect | 22:53 |
| lhcheng | thought it is fixed at some point, the modal stay opens with the error msg | 22:53 |
| david-lyle | or something hacky like that | 22:53 |
| david-lyle | some of my finer work for sure | 22:54 |
| david-lyle | but then isn't all of it :P | 22:54 |
| *** kzaitsev_mb has quit IRC | 22:55 | |
| lhcheng | hmm trying out old code, seems to work fine. | 22:56 |
| lhcheng | the modal stays open | 22:56 |
| david-lyle | how old? | 22:56 |
| lhcheng | grizzly :P | 22:56 |
| lhcheng | trying to get my juno setup | 22:56 |
| lhcheng | still downloading.. | 22:56 |
| david-lyle | I remember issues over a year ago | 22:57 |
| david-lyle | about the time Brian left | 22:57 |
| *** morganfainberg is now known as morgan_404 | 22:57 | |
| *** nlahouti has quit IRC | 23:01 | |
| *** nlahouti has joined #openstack-horizon | 23:03 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for KeyStone Service https://review.openstack.org/211782 | 23:15 |
| *** jamielennox is now known as jamielennox|away | 23:18 | |
| *** stevemar has quit IRC | 23:20 | |
| *** stevemar has joined #openstack-horizon | 23:21 | |
| *** geoffarnold has quit IRC | 23:22 | |
| *** stevemar has quit IRC | 23:24 | |
| *** Sukhdev has quit IRC | 23:24 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services https://review.openstack.org/212838 | 23:27 |
| *** mpavlase has quit IRC | 23:29 | |
| *** geoffarnold has joined #openstack-horizon | 23:32 | |
| *** dsneddon has quit IRC | 23:37 | |
| *** dsneddon has joined #openstack-horizon | 23:39 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Refactor angular cloud services utilities https://review.openstack.org/179516 | 23:43 |
| *** Sukhdev has joined #openstack-horizon | 23:44 | |
| *** jamielennox|away is now known as jamielennox | 23:47 | |
| *** julim has quit IRC | 23:47 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel https://review.openstack.org/206203 | 23:50 |
| openstackgerrit | David Lyle proposed openstack/horizon: Revert "Fix error message on project create" https://review.openstack.org/212848 | 23:50 |
| *** nlahouti has quit IRC | 23:52 | |
| *** jtriley has joined #openstack-horizon | 23:53 | |
| *** kristinebrown has quit IRC | 23:57 | |
| esp | hey, I’m getting a weird error after running $ python manage.py collectstatic | 23:57 |
| kfox1111 | tqtran: hehe. We wrote the same review at the same time. :) | 23:57 |
| esp | File "/Users/dan/git_openstack/horizon/openstack_dashboard/exceptions.py", line 25, in <module> | 23:57 |
| esp | from requests import exceptions as requests | 23:57 |
| esp | File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/requests/__init__.py", line 53, in <module> | 23:57 |
| esp | from .packages.urllib3.contrib import pyopenssl | 23:57 |
| esp | File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 55, in <module> | 23:58 |
| esp | orig_connectionpool_ssl_wrap_socket = connectionpool.ssl_wrap_socket | 23:58 |
| esp | AttributeError: 'module' object has no attribute 'ssl_wrap_socket' | 23:58 |
| esp | ^ sorry for the paste | 23:58 |
| tqtran | lol nice | 23:58 |
| esp | haha | 23:58 |
| *** nlahouti has joined #openstack-horizon | 23:58 | |
| esp | tqtran: you have words of wisdom? | 23:58 |
| *** julim has joined #openstack-horizon | 23:58 | |
| tqtran | esp reading | 23:58 |
| esp | I think it’s from the requests lib that django uses? | 23:59 |
| tqtran | let me try locally | 23:59 |
| esp | tqtran: kelly says this is a known issue | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!