Friday, 2015-08-14

espdon’t mess up your env :)00:00
tqtranlol try this instead00:00
tqtran./tools/with_venv.sh python manage.py collectstatic00:01
espah, right00:01
tqtranassuming you're in the horizon folder00:01
espI forgot about that00:01
esphere goes00:01
tqtrankeep your fingers crossed lol00:01
openstackgerritTravis Tripp proposed openstack/horizon: Refactor angular cloud services utilities  https://review.openstack.org/17951600:02
*** stevemar has joined #openstack-horizon00:02
espthat did it!  thx tqtran00:03
espI need to write that down00:03
*** tjones has quit IRC00:04
*** jamielennox is now known as jamielennox|away00:05
tqtranlol you're welcome00:06
*** rajatvig has quit IRC00:07
*** jamielennox|away is now known as jamielennox00:07
*** nlahouti has quit IRC00:08
*** geoffarnold has quit IRC00:08
*** jamielennox is now known as jamielennox|away00:10
*** jingjing_ren has quit IRC00:10
*** yamamoto has joined #openstack-horizon00:11
*** yamamoto has quit IRC00:16
*** geoffarnold has joined #openstack-horizon00:17
*** wolverineav has joined #openstack-horizon00:24
*** Sukhdev has quit IRC00:27
*** SimonChung has quit IRC00:29
*** tqtran has quit IRC00:30
*** tjones has joined #openstack-horizon00:34
*** geoffarnold has quit IRC00:38
openstackgerritKelly Domico proposed openstack/horizon: Move magic_search.js in _scripts.html to after Angular files  https://review.openstack.org/21230800:43
*** tjones has quit IRC00:44
*** zhenguo has joined #openstack-horizon00:49
openstackgerritMerged openstack/horizon: Delete VIP action refactoring  https://review.openstack.org/18477600:51
*** mwhagedorn has quit IRC00:53
*** dsneddon has quit IRC00:54
openstackgerritDiana Whitten proposed openstack/horizon: Horizon's scss webroot should come from settings.py  https://review.openstack.org/20659200:55
*** juggler has joined #openstack-horizon00:57
*** yingjun has joined #openstack-horizon00:59
*** bpokorny has quit IRC01:06
*** ybathia has quit IRC01:07
*** hhuang has joined #openstack-horizon01:11
*** jwy has quit IRC01:13
*** hurgleburgler has quit IRC01:13
*** jtriley has quit IRC01:22
*** jtriley has joined #openstack-horizon01:23
*** skylerberg has quit IRC01:27
*** bharath_ has joined #openstack-horizon01:32
openstackgerritLi Yingjun proposed openstack/horizon: Use security group id for launch instance  https://review.openstack.org/21227901:34
*** lyanchih has joined #openstack-horizon01:38
*** bharath_ has quit IRC01:41
*** bharath_ has joined #openstack-horizon01:43
*** jwy has joined #openstack-horizon01:44
*** shivrao has quit IRC02:01
*** jamielennox|away is now known as jamielennox02:08
*** bharath_ has quit IRC02:09
*** bharath_ has joined #openstack-horizon02:11
*** Ephur has quit IRC02:11
*** jtriley has quit IRC02:23
zhenguolhcheng: could you have a look at this https://review.openstack.org/#/c/186810/ please?02:23
lhchengzhenguo: I'm heading out now, but will review it when get home02:25
zhenguolhcheng: ok, thanks.02:25
* lhcheng starred the patch02:26
lhchengzhenguo: later02:26
lhchengzhenguo: have to get food :)02:26
*** lhcheng has quit IRC02:27
*** bharath_ has quit IRC02:27
openstackgerritMerged openstack/horizon: Revert patch of bug #1445055  https://review.openstack.org/21100102:28
openstackbug 1445055 in OpenStack Dashboard (Horizon) "Misleading message on project create" [Low,Fix released] https://launchpad.net/bugs/1445055 - Assigned to Dimitri Mazmanov (sorantis)02:28
*** gyee_500 has quit IRC02:29
*** eroussel has joined #openstack-horizon02:36
*** ducttape_ has joined #openstack-horizon02:39
*** jwy has quit IRC02:43
*** KunalGandhi has quit IRC02:46
*** fedexo has joined #openstack-horizon02:46
*** yamamoto has joined #openstack-horizon02:48
*** masco has joined #openstack-horizon02:49
openstackgerritMerged openstack/horizon: Updated from global requirements  https://review.openstack.org/21221702:50
*** saksham has quit IRC02:52
*** bpokorny has joined #openstack-horizon02:52
*** fedexo has quit IRC02:56
*** stevemar has quit IRC02:58
*** stevemar has joined #openstack-horizon02:59
*** ducttape_ has quit IRC03:02
*** julim has quit IRC03:03
*** ducttape_ has joined #openstack-horizon03:04
*** eroussel has quit IRC03:09
*** KunalGandhi has joined #openstack-horizon03:10
*** saksham has joined #openstack-horizon03:14
*** saksham has quit IRC03:16
openstackgerritKelly Domico proposed openstack/horizon: Move magic_search.js in _scripts.html to after Angular files  https://review.openstack.org/21230803:17
openstackgerritKelly Domico proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance  https://review.openstack.org/20158203:18
*** jingjing_ren has joined #openstack-horizon03:27
*** jingjing_ren has quit IRC03:32
*** ducttape_ has quit IRC03:37
*** shivrao has joined #openstack-horizon03:37
*** tjones has joined #openstack-horizon03:38
*** KunalGandhi has quit IRC03:43
*** KunalGandhi has joined #openstack-horizon03:43
*** shivrao has quit IRC03:44
*** shivrao has joined #openstack-horizon03:45
*** kyleolivo has joined #openstack-horizon03:47
*** shivrao has quit IRC03:50
*** KunalGan_ has joined #openstack-horizon03:52
*** yingjun has quit IRC03:54
*** KunalGandhi has quit IRC03:56
*** Sukhdev has joined #openstack-horizon03:57
*** sambetts has joined #openstack-horizon03:59
*** KingKhan has joined #openstack-horizon04:00
*** lyanchih has quit IRC04:02
*** jamielennox is now known as jamielennox|away04:02
*** fedexo has joined #openstack-horizon04:05
*** KingKhan has quit IRC04:06
*** KunalGan_ has quit IRC04:09
*** lhcheng has joined #openstack-horizon04:17
lhchengzhenguo: patch reviewed, added my comments04:18
*** SimonChung has joined #openstack-horizon04:19
*** SimonChung1 has joined #openstack-horizon04:20
*** yamamoto has quit IRC04:21
*** KingKhan has joined #openstack-horizon04:24
*** SimonChung has quit IRC04:24
*** yamamoto has joined #openstack-horizon04:25
*** KingKhan has quit IRC04:28
*** KunalGandhi has joined #openstack-horizon04:29
openstackgerritMerged openstack/horizon: JSCS Cleanup - Use mock module to avoid using window  https://review.openstack.org/19933304:33
*** KingKhan has joined #openstack-horizon04:35
*** KingKhan_ has joined #openstack-horizon04:36
*** KingKhan has left #openstack-horizon04:40
*** KingKhan has joined #openstack-horizon04:41
*** KingKhan_ has quit IRC04:41
*** early has quit IRC04:42
*** morgan_404 is now known as morgan_20404:42
*** morgan_204 is now known as morgan_20604:44
*** morgan_206 is now known as morgan_50304:45
*** jamielennox|away is now known as jamielennox04:46
*** tjones has quit IRC04:47
*** bharath_ has joined #openstack-horizon04:48
*** fedexo has quit IRC04:51
*** yamamoto has quit IRC04:54
*** fedexo has joined #openstack-horizon04:55
*** bharath_ has quit IRC04:59
*** KunalGandhi has quit IRC05:00
*** early has joined #openstack-horizon05:00
*** yamamoto has joined #openstack-horizon05:00
*** fedexo has quit IRC05:02
*** lhcheng has quit IRC05:03
*** fedexo has joined #openstack-horizon05:03
*** bharath_ has joined #openstack-horizon05:06
*** shivrao has joined #openstack-horizon05:12
*** Drago1 has quit IRC05:13
*** kyleolivo has quit IRC05:15
*** bpokorny has quit IRC05:17
*** bpokorny has joined #openstack-horizon05:18
*** bpokorny has quit IRC05:18
*** bpokorny has joined #openstack-horizon05:19
*** bpokorny has quit IRC05:24
*** yamamoto has quit IRC05:25
*** mrunge has joined #openstack-horizon05:28
*** yamamoto has joined #openstack-horizon05:29
*** kmARC_ has joined #openstack-horizon05:31
*** kmARC has joined #openstack-horizon05:31
*** bharath_ has quit IRC05:32
*** fedexo has quit IRC05:34
*** kyleolivo has joined #openstack-horizon05:38
*** chlong has quit IRC05:41
*** kyleolivo has quit IRC05:42
*** chlong has joined #openstack-horizon05:44
*** masco has quit IRC05:48
*** jprovazn has joined #openstack-horizon05:48
*** yingjun has joined #openstack-horizon05:54
*** Sukhdev has quit IRC05:57
*** fifieldt_ has quit IRC06:00
*** shivrao has quit IRC06:02
*** masco has joined #openstack-horizon06:05
*** bharath_ has joined #openstack-horizon06:05
*** e0ne has joined #openstack-horizon06:08
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/21299506:12
*** peristeri has joined #openstack-horizon06:15
zhenguolhcheng: thanks for the review and will address your comments soon :)06:18
*** e0ne has quit IRC06:27
*** lyanchih has joined #openstack-horizon06:33
*** kmARC_ has quit IRC06:37
*** kmARC has quit IRC06:39
*** KingKhan_ has joined #openstack-horizon06:42
*** KingKhan_ has quit IRC06:42
*** jprovazn has quit IRC06:42
*** KingKhan has quit IRC06:42
*** kyleolivo has joined #openstack-horizon06:42
*** nlahouti has joined #openstack-horizon06:43
*** kyleolivo has quit IRC06:49
*** e0ne has joined #openstack-horizon06:51
*** kmARC_ has joined #openstack-horizon06:56
*** kmARC has joined #openstack-horizon06:56
*** nlahouti has quit IRC07:00
*** e0ne has quit IRC07:04
mrungezhenguo, thank you for your +2 on https://review.openstack.org/#/c/201066/07:06
mrungezhenguo, would you set +A there too, or don't you feel comfortable with that?07:06
*** yingjun has quit IRC07:09
*** rdopiera has joined #openstack-horizon07:10
*** yingjun has joined #openstack-horizon07:12
*** masco has quit IRC07:15
*** jamielennox is now known as jamielennox|away07:17
openstackgerritAlbert Tu proposed openstack/horizon: Add i18n support to Angular humanizeNumbers helper  https://review.openstack.org/19999707:24
openstackgerritZhenguo Niu proposed openstack/horizon: Add volume migration support  https://review.openstack.org/18681007:31
*** chlong has quit IRC07:36
*** chlong has joined #openstack-horizon07:39
*** MaxV has joined #openstack-horizon07:40
*** kmARC_ has quit IRC07:47
*** kmARC has quit IRC07:47
christophsIs there a way to get this issue handled? https://bugs.launchpad.net/horizon/+bug/148265707:48
openstackLaunchpad bug 1482657 in OpenStack Dashboard (Horizon) "Attribute error on virtual_size" [Undecided,New]07:48
*** kzaitsev_mb has joined #openstack-horizon07:49
*** MaxV has quit IRC07:50
mrungechristophs, you should propose your patch on gerrit07:50
zhenguomrunge: sure, will +A that :)07:50
mrungechristophs, https://wiki.openstack.org/wiki/How_To_Contribute07:51
mrungezhenguo, thank you07:51
christophsmrunge, Okay will do this. Thanks07:51
zhenguomrunge: np07:51
mrungechristophs, thank you, and thank you for your patch proposed in launchpad. usually it's easier to review in gerrit, it get's tested there as well.07:52
mrungechristophs, feel free to ask here, if there are issues around the process07:53
*** shivrao has joined #openstack-horizon07:54
*** wolverineav has quit IRC07:57
*** stevemar has quit IRC07:58
*** akrivoka has joined #openstack-horizon08:05
*** jcoufal has joined #openstack-horizon08:05
*** romainh has joined #openstack-horizon08:07
*** kyleolivo has joined #openstack-horizon08:10
*** shivrao has quit IRC08:10
*** kmARC_ has joined #openstack-horizon08:11
*** kmARC has joined #openstack-horizon08:12
*** kyleolivo has quit IRC08:14
*** kzaitsev_mb has quit IRC08:15
*** MaxV has joined #openstack-horizon08:16
*** kzaitsev_mb has joined #openstack-horizon08:17
openstackgerritziyu032 proposed openstack/horizon: Filter out networks that have no subnets when launch instance  https://review.openstack.org/21302708:18
*** MaxV has quit IRC08:21
*** MaxV has joined #openstack-horizon08:21
*** kzaitsev_mb has quit IRC08:24
*** kzaitsev_mb has joined #openstack-horizon08:25
*** lyanchih has quit IRC08:26
*** MaxV has quit IRC08:31
*** MaxV has joined #openstack-horizon08:31
openstackgerritMerged openstack/horizon: remove django<1.7 from tests  https://review.openstack.org/20106608:42
*** masco has joined #openstack-horizon09:00
christophsmrunge, I need to be a foundation member to submit code?09:03
*** kzaitsev_mb has quit IRC09:04
mrungechristophs, I don't think so09:04
mrungebut you need to sign the CLA (iirc)09:05
christophsYes I did this. But I can't add contact data to my gerrit account. So I found this: https://ask.openstack.org/en/question/56720/cannot-store-contact-information-when-updating-info-in-openstack-gerrit/09:05
mrungehmmm, according to that, you'd need to be a member then09:07
mrungewhatever that means...09:07
christophsWho know :D... will try it.09:07
mrungechristophs, as long as you're trying to become an indiviual member, you should be safe09:08
*** jcoufal_ has joined #openstack-horizon09:12
*** vgridnev has joined #openstack-horizon09:13
*** jcoufal has quit IRC09:15
openstackgerritChristoph Seifert proposed openstack/horizon: Fix attribute error with old glance backend  https://review.openstack.org/21305409:18
christophsmrunge, Finally it worked. Thank you.09:22
mrungechristophs, great, glad you figured it out09:26
mrungechristophs, for what version would you need your patch?09:27
christophsFor the kilo release. Should the patch be against stable/kilo?09:29
mrungechristophs, nope. master is fine. after is was merged, we need to cherry-pick it into stable/kilo as well09:30
mrungejust to be sure not to create a regression in a later version09:30
christophsmrunge, That's great. Thank you.09:32
*** yingjun has quit IRC09:34
*** tosky has joined #openstack-horizon09:34
openstackgerritMerged openstack/manila-ui: Add extend support to manila-ui  https://review.openstack.org/18535209:34
*** yingjun has joined #openstack-horizon09:35
*** yingjun has quit IRC09:35
*** yingjun has joined #openstack-horizon09:35
*** yingjun has quit IRC09:40
*** markus_z has joined #openstack-horizon09:43
*** BobBall has quit IRC09:51
*** lyanchih has joined #openstack-horizon09:54
*** marlinc has quit IRC09:55
*** marlinc has joined #openstack-horizon09:58
*** marlinc has joined #openstack-horizon09:59
*** jcoufal has joined #openstack-horizon10:01
*** jcoufal_ has quit IRC10:04
*** marlinc has quit IRC10:10
*** kyleolivo has joined #openstack-horizon10:10
*** marlinc has joined #openstack-horizon10:12
*** kyleolivo has quit IRC10:14
*** romainh has quit IRC10:14
*** sayan has joined #openstack-horizon10:15
*** ttrifonov is now known as zz_ttrifonov10:16
*** kmartin has quit IRC10:18
*** kzaitsev_mb has joined #openstack-horizon10:22
*** zhenguo has quit IRC10:26
*** bharath_ has quit IRC10:35
openstackgerritVitaly Gridnev proposed openstack/horizon: [Sahara] Move node processes selection to own tab  https://review.openstack.org/19701810:38
vgridnevhey mrunge, could you please take a look on it ^^10:39
mrungevgridnev, I'm quite busy now10:39
*** yamamoto has quit IRC10:44
*** zz_ttrifonov is now known as ttrifonov10:44
*** yamamoto has joined #openstack-horizon10:46
*** MaxV has quit IRC11:00
*** yamamoto has quit IRC11:11
*** _crobertsrh is now known as crobertsrh11:14
*** sambetts has quit IRC11:24
*** MaxV has joined #openstack-horizon11:27
*** jcoufal_ has joined #openstack-horizon11:28
*** sambetts has joined #openstack-horizon11:29
*** linkedinyou has quit IRC11:29
*** jcoufal has quit IRC11:31
*** masco has quit IRC11:35
*** MaxV has quit IRC11:37
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui: Fix set/unset extra specs for share type update form  https://review.openstack.org/21310611:39
*** akrivoka has quit IRC11:42
*** lyanchih has quit IRC11:45
*** kzaitsev_mb has quit IRC11:50
*** lyanchih has joined #openstack-horizon11:53
*** masco has joined #openstack-horizon11:55
*** kyleolivo has joined #openstack-horizon11:58
*** vgridnev has quit IRC12:01
*** kyleolivo has quit IRC12:02
*** romainh has joined #openstack-horizon12:03
*** yamamoto has joined #openstack-horizon12:03
*** MaxV has joined #openstack-horizon12:04
*** vgridnev has joined #openstack-horizon12:07
*** vgridnev has quit IRC12:07
*** masco has quit IRC12:12
*** yamamoto has quit IRC12:20
*** kzaitsev_mb has joined #openstack-horizon12:21
*** ducttape_ has joined #openstack-horizon12:22
*** mwhagedorn has joined #openstack-horizon12:22
*** lblanchard has joined #openstack-horizon12:23
*** petertr7_away is now known as petertr712:29
*** MaxV has quit IRC12:36
*** tosky has quit IRC12:38
*** linkedinyou has joined #openstack-horizon12:40
*** ducttape_ has quit IRC12:41
*** tosky has joined #openstack-horizon12:41
*** jcoufal_ has quit IRC12:43
*** jcoufal has joined #openstack-horizon12:43
*** markus_z has quit IRC12:47
*** radez is now known as radez_g0n312:48
*** doug-fish has joined #openstack-horizon12:49
*** peristeri_ has joined #openstack-horizon12:49
*** peristeri has quit IRC12:50
*** yamamoto has joined #openstack-horizon12:51
*** vgridnev has joined #openstack-horizon12:51
*** crobertsrh has left #openstack-horizon12:53
*** crobertsrh has joined #openstack-horizon12:58
*** MaxV has joined #openstack-horizon13:03
*** kzaitsev_mb has quit IRC13:06
*** kzaitsev_mb has joined #openstack-horizon13:08
openstackgerritKarthik Suresh proposed openstack/horizon: Added small block to remove default panels  https://review.openstack.org/21313913:09
*** KunalGandhi has joined #openstack-horizon13:12
*** rodrigods has quit IRC13:13
*** KunalGan_ has joined #openstack-horizon13:14
*** markus_z has joined #openstack-horizon13:15
*** julim has joined #openstack-horizon13:16
*** KunalGandhi has quit IRC13:17
*** cardeois has joined #openstack-horizon13:19
*** MaxV has quit IRC13:20
*** rodrigods has joined #openstack-horizon13:20
*** MaxV has joined #openstack-horizon13:22
*** tjones has joined #openstack-horizon13:23
openstackgerritTimur Sufiev proposed openstack/horizon: Enable pagination for Project->Images view  https://review.openstack.org/20781213:24
*** akrivoka has joined #openstack-horizon13:28
*** zhenguo has joined #openstack-horizon13:28
*** fifieldt has joined #openstack-horizon13:30
openstackgerritFlorian Fuchs proposed openstack/horizon: Add default sorting to the Security Groups table.  https://review.openstack.org/21314313:31
*** jtriley has joined #openstack-horizon13:40
*** MaxV has quit IRC13:41
*** radez_g0n3 is now known as radez13:41
*** MaxV has joined #openstack-horizon13:42
openstackgerritMichael Hagedorn proposed openstack/horizon: Neutron Quota Settings Flag Disables Neutron GUI  https://review.openstack.org/21010013:43
openstackgerritMichael Hagedorn proposed openstack/horizon: enable_quotas=False breaks Neutron usage  https://review.openstack.org/21131013:44
openstackgerritPaulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Table  https://review.openstack.org/19956713:45
*** lyanchih has quit IRC13:48
*** ducttape_ has joined #openstack-horizon13:52
*** jcoufal has quit IRC13:55
*** MaxV has quit IRC13:56
*** petertr7 is now known as petertr7_away13:58
*** peristeri_ has quit IRC13:58
*** kyleolivo has joined #openstack-horizon13:58
*** MaxV has joined #openstack-horizon13:59
*** petertr7_away is now known as petertr714:00
*** MaxV has quit IRC14:00
*** MaxV has joined #openstack-horizon14:00
*** kyleolivo has quit IRC14:03
*** lapalm has joined #openstack-horizon14:04
*** tvanderwiel has joined #openstack-horizon14:06
*** tvanderwiel has left #openstack-horizon14:06
ducttape_last 100 commits, about 20% have cleanup in the commit message.  confidence14:10
*** tosky has quit IRC14:12
*** vijendar has joined #openstack-horizon14:15
openstackgerritTracy Jones proposed openstack/horizon: code cleanup from commits on https://review.openstack.org/#/c/195751/  https://review.openstack.org/20030114:16
*** Drago has joined #openstack-horizon14:17
*** Drago has quit IRC14:17
*** lapalm has quit IRC14:19
*** chlong has quit IRC14:19
*** lapalm has joined #openstack-horizon14:20
openstackgerritRyan Brady proposed openstack/tuskar-ui: Add discovery on demand  https://review.openstack.org/21181614:20
*** tosky has joined #openstack-horizon14:22
*** Drago has joined #openstack-horizon14:23
*** Drago has quit IRC14:23
*** pauloewerton has joined #openstack-horizon14:23
*** MaxV has quit IRC14:25
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui: Fix set/unset extra specs for share type update form  https://review.openstack.org/21310614:26
*** rdopiera has quit IRC14:26
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui: Fix set/unset extra specs for share type update form  https://review.openstack.org/21310614:27
*** absubram has joined #openstack-horizon14:30
*** sayan has quit IRC14:32
*** rdopiera has joined #openstack-horizon14:34
*** geoffarnold has joined #openstack-horizon14:35
*** Drago has joined #openstack-horizon14:37
*** Drago has quit IRC14:38
*** Drago has joined #openstack-horizon14:38
*** absubram has quit IRC14:38
*** geoffarnold has quit IRC14:39
*** geoffarnold has joined #openstack-horizon14:41
*** absubram has joined #openstack-horizon14:41
*** alejandrito has joined #openstack-horizon14:44
*** yamamoto has quit IRC14:48
*** MaxV has joined #openstack-horizon14:52
*** yamamoto has joined #openstack-horizon14:52
*** radez is now known as radez_g0n314:56
*** absubram has quit IRC14:57
*** mpavlase has joined #openstack-horizon15:02
*** lyanchih has joined #openstack-horizon15:03
*** ttrifonov is now known as zz_ttrifonov15:04
*** bpokorny has joined #openstack-horizon15:04
*** petertr7 is now known as petertr7_away15:06
*** absubram has joined #openstack-horizon15:06
*** radez_g0n3 is now known as radez15:08
*** bpokorny has quit IRC15:08
*** lsmola has quit IRC15:13
*** jcoufal has joined #openstack-horizon15:17
*** kmartin has joined #openstack-horizon15:19
*** Piet has quit IRC15:19
*** TravT_ has joined #openstack-horizon15:19
openstackgerritMartin Hickey proposed openstack/horizon: Adds button to disable more than one domain at a time  https://review.openstack.org/21319315:20
*** KunalGan_ has quit IRC15:20
*** TravT has quit IRC15:21
*** TravT_ is now known as TravT15:21
*** tyr has joined #openstack-horizon15:21
*** rdopiera has quit IRC15:23
*** bpokorny has joined #openstack-horizon15:24
*** yamamoto has quit IRC15:25
*** sayan has joined #openstack-horizon15:27
*** esp has left #openstack-horizon15:28
*** mpavlase has quit IRC15:30
*** openstackgerrit has quit IRC15:31
*** openstackgerrit has joined #openstack-horizon15:32
*** absubram has quit IRC15:32
*** yamamoto has joined #openstack-horizon15:35
*** esp has joined #openstack-horizon15:37
*** nlahouti has joined #openstack-horizon15:38
*** absubram has joined #openstack-horizon15:38
*** radez is now known as radez_g0n315:38
openstackgerritRajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services  https://review.openstack.org/21283815:39
*** lapalm has quit IRC15:41
*** lapalm has joined #openstack-horizon15:41
*** zhenguo has quit IRC15:43
openstackgerritRajat Vig proposed openstack/horizon: Use the JP Style Guide for Nova Service  https://review.openstack.org/21178315:44
openstackgerritDan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token  https://review.openstack.org/19632815:46
*** hurgleburgler has joined #openstack-horizon15:49
openstackgerritRajat Vig proposed openstack/horizon: Use the JP Style Guide for KeyStone Service  https://review.openstack.org/21178215:50
*** dsneddon has joined #openstack-horizon15:53
openstackgerritRajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services  https://review.openstack.org/21283815:54
openstackgerritRajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model  https://review.openstack.org/21174115:55
*** jprovazn has joined #openstack-horizon15:58
*** kyleolivo has joined #openstack-horizon15:59
*** jcoufal has quit IRC16:00
*** vgridnev has quit IRC16:00
*** jprovazn has quit IRC16:01
*** jcoufal has joined #openstack-horizon16:02
*** kyleolivo has quit IRC16:04
*** markus_z has quit IRC16:07
*** jcoufal has quit IRC16:07
*** akrivoka has quit IRC16:08
*** KunalGandhi has joined #openstack-horizon16:16
*** Sukhdev has joined #openstack-horizon16:22
*** dsneddon has quit IRC16:29
ducttape_did the display of the region recently change in the top navbar?16:30
hurgleburglerThere's a fix for that16:32
ducttape_does it involve software ?16:32
hurgleburglerhttps://review.openstack.org/#/c/212682/16:32
hurgleburglerRegions and Domains got no love in my recent refactor of the topbar :(16:32
hurgleburglermy bad16:32
ducttape_ugg.  how did this get merged?16:32
*** Piet has joined #openstack-horizon16:33
david-lyleducttape_: do you have the original review link?16:35
david-lyleI thought I was having CSS problems16:35
ducttape_I probably +1 that thing, didn't I.... as I hand-wring16:36
*** MaxV has quit IRC16:36
ducttape_hurgleburgler probably has it16:36
*** petertr7_away is now known as petertr716:36
*** gyee has joined #openstack-horizon16:37
ducttape_was this it?  https://review.openstack.org/#/c/207660/16:37
ducttape_hurgleburgler ^16:37
david-lyleyeah, I found it16:37
hurgleburglerYes, that's the one16:37
david-lyle:(16:37
hurgleburglerI opened a bug and put a fix out for it already16:37
*** sayan has quit IRC16:37
hurgleburglersorry 。゜゜(´O`)°゜。16:37
*** rajatvig has joined #openstack-horizon16:37
david-lylehurgleburgler: my concern, and not just for you, is that we're breaking things faster than we're fixing them16:38
ducttape_http://pasteboard.co/2IuqjpGW.png  shows how special it looks16:38
*** tjones has quit IRC16:39
david-lyleyup that's what I saw. like I said that is was a stale static problem16:39
ducttape_david-lyle - this is up to the pace of accepting / merging stuff without personally doing more tests.  I +1 this thing so I am at fault.... but so is everyone on the review16:39
david-lyleI'm about to take horizon and go home16:39
ducttape_and you can't have nice things, you should know16:40
ducttape_even if you take it home, your kids will destroy it16:40
*** MaxV has joined #openstack-horizon16:40
*** kmARC_ has quit IRC16:40
david-lylewhat exactly are people testing with?16:40
hurgleburglerI didn't have my setup with multiple regions16:41
sjmc7lynx16:41
* ducttape_ coughs devstack16:41
hurgleburgler^16:41
*** kmARC has quit IRC16:41
david-lyleyou can configure devstack16:41
david-lyleto be a full environment16:41
hurgleburglerI know that now! ;)16:41
*** yamamoto has quit IRC16:41
sjmc7ducttape_ - it is on my list to get some hardware set up here to keep bleeding edge, but i'm not there yet16:41
*** yamamoto has joined #openstack-horizon16:41
hurgleburglerI had to also configure it for domains16:41
david-lylehurgleburgler: IMO everyone should be testing with v3 by default16:42
ducttape_sjmc7 - careful near that edge.  like me, you will end up a bloody mess16:42
sjmc7i'll wear gloves16:42
ducttape_shark cage is recomended16:42
hurgleburglerYou guys are the front line16:42
david-lylehurgleburgler: again, not calling you out personally16:42
*** yamamoto has quit IRC16:42
hurgleburglerI'm calling me out personally, lolz16:42
david-lylewell in that case...16:43
*** mwhagedorn has quit IRC16:43
hurgleburgleri gotta go flog myself now (╯_╰)16:43
sjmc7hurgelburgler, remind me next week about this. we should have a proper test setup16:43
* ducttape_ prepares an invoice for hurgleburgler, re: QA services 16:43
david-lylehurgleburgler: I'll try you fix in a minute, deep in writing d-o-a tests16:44
david-lylelest you want to understand pain16:44
hurgleburglertsufiev made some comments on it, I need to address … will get on it right after I address david-lyle 's pyscss comments16:44
rajatvigdavid-lyle: is there a document about making the DevStack a full environment?16:45
*** mwhagedorn has joined #openstack-horizon16:45
david-lylerajatvig: there is an example devstack local.conf in the horizon tree16:46
*** stevemar has joined #openstack-horizon16:46
david-lyleI should probably write a script for setting up multiple regions and configuring multidomain16:47
david-lylebut I likely won't get to that any time soon16:47
david-lylerajatvig: https://github.com/openstack/horizon/blob/master/doc/source/ref/local_conf.rst is the file16:47
david-lylewell, the contents of that file are the file16:47
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui: Disable button 'create snapshot' if share not snapshottable  https://review.openstack.org/21324216:48
*** stevemar has quit IRC16:49
tsufievdavid-lyle, what's about a script for setting up Keystone/LDAP w several thousands of users :)?16:51
david-lyletsufiev: do you have such a thing?16:51
tsufievbtw, that's quite common setup in production (not the number of users, but LDAP itself)16:51
david-lyletsufiev: I understand16:52
*** skylerberg has joined #openstack-horizon16:52
tsufievdavid-lyle, unfortunately, no :(. We're starting to do this internally16:52
david-lylewould be a great script to have16:52
*** MaxV has quit IRC16:52
*** romainh has left #openstack-horizon16:52
david-lyleplugins to devstack would be the best way, I imagine16:53
david-lyleif only there was group of developers on projects whose focus was stability and quality16:54
ducttape_#dreamer16:54
* david-lyle cues charlie brown music16:56
*** cardeois_ has joined #openstack-horizon16:56
david-lylehttps://www.youtube.com/watch?v=oabcM9SOF-E16:57
*** cardeois_ has quit IRC16:58
*** cardeois has quit IRC16:59
*** cardeois_ has joined #openstack-horizon16:59
*** cardeois_ has quit IRC16:59
openstackgerritKBrown proposed openstack/horizon: WIP: Add angular system information panel  https://review.openstack.org/20473117:00
*** jtriley has quit IRC17:04
*** lhcheng has joined #openstack-horizon17:04
*** vgridnev has joined #openstack-horizon17:05
*** KunalGandhi has quit IRC17:07
*** lhcheng has quit IRC17:09
*** rajatvig has quit IRC17:11
*** jingjing_ren has joined #openstack-horizon17:12
*** jingjing_ren has quit IRC17:12
*** rajatvig has joined #openstack-horizon17:12
*** jingjing_ren has joined #openstack-horizon17:13
*** mhorban has quit IRC17:16
*** mhorban has joined #openstack-horizon17:16
*** david-lyle is now known as cbrown17:17
*** stevemar has joined #openstack-horizon17:19
*** kyleolivo has joined #openstack-horizon17:20
*** neelashah has joined #openstack-horizon17:21
openstackgerritTimur Sufiev proposed openstack/horizon: Do not make unnecessary calls to Nova from FIPs and Volumes tabs  https://review.openstack.org/21326017:23
*** ekarlso has joined #openstack-horizon17:25
openstackgerritRichard Hagarty proposed openstack/horizon: Added volume type description for volume type  https://review.openstack.org/13387217:26
openstackgerritPaulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Table  https://review.openstack.org/19956717:27
* ducttape_ welcomes our new charlie brown overloard17:27
ducttape_cbrown17:27
*** lapalm has quit IRC17:27
ducttape_overlord17:27
ducttape_jeez I can't spell17:28
*** lapalm has joined #openstack-horizon17:28
*** radez_g0n3 is now known as radez17:28
*** lhcheng_ has joined #openstack-horizon17:29
*** tqtran has joined #openstack-horizon17:30
*** sayan has joined #openstack-horizon17:30
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui: Disable button 'create snapshot' if share not snapshottable  https://review.openstack.org/21324217:32
*** jtriley has joined #openstack-horizon17:32
*** lapalm has quit IRC17:32
*** jwy has joined #openstack-horizon17:36
*** tosky has quit IRC17:36
*** jtriley has quit IRC17:37
*** kmARC has joined #openstack-horizon17:39
*** kmARC_ has joined #openstack-horizon17:39
*** yamamoto has joined #openstack-horizon17:43
*** lhcheng_ has quit IRC17:45
*** yamamoto has quit IRC17:48
openstackgerritDiana Whitten proposed openstack/horizon: Horizon Context Selection should be to the right  https://review.openstack.org/21268217:49
*** TravT_ has joined #openstack-horizon17:50
*** TravT has quit IRC17:50
*** Ephur has joined #openstack-horizon17:51
*** ybathia has joined #openstack-horizon17:51
*** lyanchih has quit IRC17:54
*** lhcheng has joined #openstack-horizon17:54
*** Piet has quit IRC17:55
*** kmARC has quit IRC17:56
*** kmARC_ has quit IRC17:56
hurgleburglertsufiev : addressed your comments in the Context Selection patch above ^17:57
*** kyleolivo has quit IRC17:58
ducttape_ok, so that looks more better, but still kinda weird18:02
ducttape_just a bit more to the right, not sure why that is or what the orig problem with the orig placement of the menu hurgleburgler18:02
hurgleburglerwait18:03
hurgleburglerwhat needs to be a bit more to the right?18:03
hurgleburglerThere wasn't anything wrong with the original placement … I tried to keep it in the same location, I thought18:03
hurgleburglerBut, are you using a different logo?18:04
ducttape_this is what it looks like, before and after   http://pasteboard.co/2IA1tGSi.png18:04
*** ybathia has quit IRC18:04
*** ybathia has joined #openstack-horizon18:04
ducttape_see what I mean?18:05
hurgleburglerYeah, different logo18:05
ducttape_no, that logo is the same in both versions tho18:05
ducttape_newer changes have moved the menu over18:05
ducttape_ok, so the placement of the logo is now different b/c it is not a background image18:07
hurgleburglerThe way the logo works is a bit different18:07
hurgleburglerBefore, the logo was being set with background-image18:07
openstackgerritDuk Loi proposed openstack/horizon: Updated cassandra database details overview port  https://review.openstack.org/21328218:07
hurgleburglerwhich is a terrible way to do it, because you can't dynamically scale a background-image, it retains the resolution of the image18:07
hurgleburglerwhich means, that if your logo was bigger than your navbar, it would just look wonky18:08
hurgleburglernow, its using an <img> tag, which is the right way to have dynamic images inside of your html18:08
openstackgerritShaoquan Chen proposed openstack/horizon: Dashboard ReOrg - retiring dashboard.scss  https://review.openstack.org/20934618:08
tqtranrajatvig: ping ping18:08
hurgleburglerNOW, the logo, regardless of the actual image size, resizes itself to fit inside of your navbar, constrained by the navbar height value of your bootstrap variable18:08
hurgleburglerSo, it might push your context_selection over now, because its of a dynamic width … but that's an easy fix18:09
tqtranrajatvig: when you get the chance, could you update https://review.openstack.org/#/c/199345/ ? we only have 9 errors left18:10
ducttape_my logo is not extra wide, it's just big boned18:10
hurgleburglercheck out18:10
hurgleburglerthemes/default/horizon/styles.scss18:10
hurgleburglerI had to hard code that padding-right in there, to retain the exact same location given the default logo18:10
hurgleburglerIf you want to tweak it because your logo is big boned, then that's where that tweakage will go18:11
ducttape_thanks hurgleburgler, that helps18:11
hurgleburglerMaking it an <img> also sets us up to do funner, responsive things with it in the future too :)18:12
hurgleburglernp, sorry for any confusion that caused18:13
*** shivrao has joined #openstack-horizon18:13
hurgleburglerI need to start documenting all of this stuff … and a proper location to document it … maybe I should start making a new wiki page for customizing horizon18:13
hurgleburgleror expand on the one that already exists18:13
openstackgerritRajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt  https://review.openstack.org/19934518:14
*** kzaitsev_mb has quit IRC18:14
rajatvigtqtran: I just did. I was trying to get it done yesterday but it was failing when I live tested it.18:15
*** saksham has joined #openstack-horizon18:15
rajatvigtqtran: I kept the same file name for now as then it won't conflict with changes that Travis is proposing as those just delete these files.18:15
*** Piet has joined #openstack-horizon18:16
tqtranok, i'll wait for gate to pass it18:16
*** cody-somerville has quit IRC18:17
tqtranthen will talk to TravT_ and see if we can push it through and have the other patch rebase on top of it instead18:17
ducttape_hurgleburgler - you are correct with that change to move the menu over.  thanks for the explanation18:17
rajatvigalso, the remaining eslint errors are all in horizon/static/horizon/js and they are to do with comments. Is anyone working on those?18:17
cbrownhurgleburgler: not wiki, horizon/docs18:17
hurgleburglerducttape_ np18:17
cbrownthat gets published to docs.openstack.org/developer/horizon anyway18:18
cbrownmore broadly accessible18:18
hurgleburglercbrown Thanks!18:18
*** lapalm has joined #openstack-horizon18:19
*** stevemar has quit IRC18:19
ducttape_cbrown -   https://i.imgflip.com/pjrhs.jpg18:21
mfischdave you look good in that shirt18:22
*** Sukhdev has quit IRC18:22
cbrownperfect18:22
ducttape_he even looks like dave18:22
*** cody-somerville has joined #openstack-horizon18:24
*** jtriley has joined #openstack-horizon18:26
rajatvigtqtran: for the remaining violations, is there a patch in play or should I create one?18:28
tqtranI think your patch might just do the trick, the remaining ones are just warnings18:28
rajatvignice. now we can turn the gate on for lint errors then18:31
*** mdavid has joined #openstack-horizon18:31
*** ephrem has joined #openstack-horizon18:36
tqtranyup thats the idea18:38
TravT_tqtran: how about push that other patch on through18:39
TravT_and rebase this one on that one18:39
tqtrani left comments on it, seems like there are a few spec files missing18:40
tqtranand it didn't resolve the eslint errors either18:40
TravT_ok, will look at those....18:40
TravT_but i'd rather rajat doesn't push conflicts at all in an eslint cleanup.18:41
*** mdavid has quit IRC18:41
TravT_on that set of files18:42
*** stevemar has joined #openstack-horizon18:42
*** skylerberg has left #openstack-horizon18:43
tqtranim ok with either as long as we fix the eslint in one of those patches18:43
*** mdavid has joined #openstack-horizon18:43
tqtranwe shouldn't be pushing in new patches that arent passing eslint18:43
TravT_i think the eslint is fixed in the child patch.18:44
TravT_let me look18:44
*** TravT_ is now known as TravT18:44
rajatvigbased on what I saw the commits in the dependent deletes one of the controllers and an html that uses it but does't fix the other bits. considering I kept the same name of the file, conflict resolution should be easy if this one merges before.18:46
rajatvigI meant one of the dependent patches deletes the controller.18:47
*** mrunge has quit IRC18:53
*** mdavid has quit IRC18:56
*** mdavid has joined #openstack-horizon18:57
tqtranr1chardj0n3s or neillc: i found a bug with the translation extraction, you guys want to tackle it?18:58
*** TravT_ has joined #openstack-horizon19:01
*** TravT has quit IRC19:01
tqtranhttps://bugs.launchpad.net/horizon/+bug/148508419:02
openstackLaunchpad bug 1485084 in OpenStack Dashboard (Horizon) "Babel angular extract fails on newline and inner tags" [High,New]19:02
gyeeoh pagination, my favorite topic :)19:05
gyeewhere's david-lyle?19:06
tqtrangyee: lol i thought we were done talking about it? hahahaha19:08
gyeeyeah, I though the horse was dead too19:09
*** ephrem has quit IRC19:09
cbrowngyee: hi19:09
cbrownlooking for me?19:10
gyeecbrown, soo you want pagination?19:10
*** ephrem has joined #openstack-horizon19:10
*** ephrem has quit IRC19:10
cbrownI think not providing is a copout but yeah19:10
cbrownI've been living with it19:10
*** ephrem has joined #openstack-horizon19:10
*** ephrem has quit IRC19:10
cbrownless for Horizon more for Searchlight19:10
cbrownwhich in turn would be used by Horizon19:11
gyeeI completely agree19:11
*** ephrem has joined #openstack-horizon19:11
gyeeI am trying to figure out how to map LDAP pagination19:12
gyeebut if we are moving away from identity management, then it will be a non-issue19:13
cbrownbut it's the only interface to the IdP in openstack19:13
cbrownso if not keystone who?19:13
gyeethat's an issue we need to figure out19:14
gyeeif we don't provide identity, then who19:14
stevemarwhy not just filter?19:14
stevemarmake the user search for a name / attribute of the user they want to find19:14
cbrownstevemar: if I'm building an index to speed up results, how does filtering allow that?19:15
gyeestevemar, "API uniformity"19:15
stevemarpagination will be nuts if you want to list 400K users19:15
*** ephrem has quit IRC19:15
stevemarour ldap will blow up19:15
cbrownwalk aimlessly in the tree via filter won't be super productive19:15
*** ephrem has joined #openstack-horizon19:15
cbrownstevemar ok, I filter by a then b, then c, then d19:16
cbrowncan I do that19:16
cbrownonly as long as I don't more than 500 a's19:16
*** rajatvig has quit IRC19:16
gyeesure, keep building your filters till you hit something you like :)19:16
cbrownthe problem is, I like everything19:17
stevemarprobably need to filter by 'aa', 'ab', 'ac' :P19:17
cbrownso I have to dynamically create filters until I hit you magic max return #19:17
cbrown*your19:17
*** rajatvig has joined #openstack-horizon19:18
gyeeto me, "API uniformity" is a powerful argument19:18
cbrownit's hard, seems like the easy way out19:18
cbrownvalid, but easy19:18
gyeeif I am writing an app (like horizon), I don't want different ways to invoke the APIs19:18
stevemarits not our magic max return19:18
stevemarits the ldap itself, the connection will time out19:19
cbrownso there's no way to dump the list of users in ldap?19:19
* cbrown is dubious19:19
gyeestevemar, convention wisdom is that we should always program to the interface, not an implementation19:20
gyeeseem like for the case of LDAP, we let the implementation dictate the interface19:20
gyeewhich is bad19:20
stevemarcbrown: gyee i still dont understand the point, why do you want to list *all* the users for?19:21
cbrownstevemar I want to use searchlight to build an index of all users and projects so I don't have to go through keystone19:21
gyeenot so much as list all, its list the results19:21
gyeehow to *consistently* present the result19:22
stevemarbiab, switching locations19:22
*** stevemar has quit IRC19:22
*** stevemar has joined #openstack-horizon19:23
ducttape_hurgleburgler  - I think you want to update docs with your change https://review.openstack.org/#/c/212682/19:24
gyeefer crying out loud, we have pep8 check for coding standard, but nothing for API standard :)19:25
hurgleburglerducttape_ k19:25
*** kyleolivo has joined #openstack-horizon19:25
*** lapalm has quit IRC19:26
ducttape_gyee - do you think having heterogenous api formats is new to this room?  ;)19:26
gyeeducttape_, nah, business as usual19:27
*** stevemar has quit IRC19:28
* ducttape_ haz a sad19:28
gyeejust stfu and everything will work itself out19:28
ducttape_that should be the license agreement for using openstack ®™19:29
*** kyleolivo has quit IRC19:29
gyeeI do remember signing it19:30
*** stevemar has joined #openstack-horizon19:32
*** kmARC has joined #openstack-horizon19:49
*** kmARC_ has joined #openstack-horizon19:49
*** vijendar has quit IRC19:52
*** nlahouti has quit IRC19:57
*** stevemar_ has joined #openstack-horizon19:58
*** stevemar has quit IRC20:00
*** doug-fis_ has joined #openstack-horizon20:02
openstackgerritMerged openstack/horizon: Use the JP Style Guide for Nova Service  https://review.openstack.org/21178320:02
openstackgerritDuk Loi proposed openstack/horizon: Add support for root enable and show  https://review.openstack.org/18319620:04
*** alejandrito has quit IRC20:04
*** neelashah has quit IRC20:04
*** doug-fish has left #openstack-horizon20:05
*** petertr7 is now known as petertr7_away20:05
*** kzaitsev_mb has joined #openstack-horizon20:08
openstackgerritMerged openstack/horizon: Move magic_search.js in _scripts.html to after Angular files  https://review.openstack.org/21230820:13
openstackgerritMerged openstack/horizon: Imported Translations from Transifex  https://review.openstack.org/21299520:14
*** kyleolivo has joined #openstack-horizon20:15
*** doug-fis_ is now known as doug-fish20:16
*** kyleolivo has quit IRC20:18
espping doug-fish20:18
openstackgerritMerged openstack/horizon: Add example keystone v3 policy file to horizon  https://review.openstack.org/16232520:18
doug-fishesp: thanks!20:19
espnp :)20:19
*** esp has left #openstack-horizon20:19
*** esp has joined #openstack-horizon20:21
*** mdavid has quit IRC20:23
rhagarty__ducttape_: ping20:23
*** ephrem has quit IRC20:24
ducttape_yo20:24
ducttape_rhagarty__20:25
rhagarty__ducttape_: remember the discussion at the last horizon mtg about overrides? Was it you who suggested putting the overrides code into _init_.py to avoid issues with handling multiple overrides?20:25
ducttape_yes, did that work / not work ?20:25
rhagarty__it did work, at least for my plug-in. thank you for that20:25
ducttape_sure, hold on a sec20:26
ducttape_I tried to capture that discussion at  https://review.openstack.org/#/c/212683/20:26
rhagarty__ducttape_: well, I know it's not a long term solution, but do you think I should change the manila-ui also?20:26
ducttape_ah, I see you have reviewed it20:26
* cbrown records this small ducttape_ victory20:26
cbrownrhagarty__: yes !20:26
* ducttape_ is done. goes home for another 9 months until the next victory will roll around20:26
rhagarty__ok, was just wondering if moving a bad idea from overrides to a new location was a good thing20:27
*** jwy has quit IRC20:27
ducttape_I see this seems like we have about 10% less bad, and about +5% mo betta.  I'll take it20:27
rhagarty__great - I will add a bug and make the fix. thanks20:28
cbrownrhagarty__: well, it's python, there is always the opportunity to monkey patch, but overrides.py has an intended purpose and a plugin using it is not it20:28
ducttape_rhagarty__ - It's really up to the plugin to carry as much ugly code as they like.  Ideally, this stuff would go into horizon fixes to make other things more extensible20:28
ducttape_but sometimes ya gotta do what ya gotta do20:29
rhagarty__agree with all on this. I think the new docs help clarify this20:29
*** mrunge has joined #openstack-horizon20:31
*** ephrem has joined #openstack-horizon20:35
*** crobertsrh is now known as _crobertsrh20:37
*** jwy has joined #openstack-horizon20:42
tqtranTravT_: https://review.openstack.org/#/c/199345/ can we push this through? I prefer we do this first and let szymon/sqchen rebase on top of this.20:43
tqtranthis way we can enable eslint as a voting job and not have to worry20:43
TravT_that's the last eslint thing?20:45
tqtranyes20:45
TravT_well, that makes for a stronger argument...20:46
TravT_so, it looks like the conflict doesn't happen until this child patch20:48
TravT_https://review.openstack.org/#/c/184275/20:48
*** mdavid has joined #openstack-horizon20:48
TravT_ok, let me look back through 19934520:48
*** bpokorny has quit IRC20:49
*** bpokorny has joined #openstack-horizon20:50
TravT_I'm trying that patch out under devstack now.20:55
*** nlahouti has joined #openstack-horizon20:58
*** kzaitsev_mb has quit IRC21:00
*** kzaitsev_mb has joined #openstack-horizon21:01
*** stevemar_ has quit IRC21:01
*** stevemar has joined #openstack-horizon21:02
*** mrunge has quit IRC21:03
*** yamamoto has joined #openstack-horizon21:06
*** stevemar has quit IRC21:06
*** TravT_ is now known as TravT21:09
*** gyee has quit IRC21:09
*** radez is now known as radez_g0n321:11
*** yamamoto has quit IRC21:11
openstackgerritRajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services  https://review.openstack.org/21283821:14
*** ducttape_ has quit IRC21:15
*** kyleolivo has joined #openstack-horizon21:18
cbrowncbrown out, have a good weekend everyone21:20
*** cbrown is now known as david-lyle21:20
tqtranlol21:20
*** jtriley has quit IRC21:22
*** kyleolivo has quit IRC21:23
*** jerrygb has joined #openstack-horizon21:23
*** vgridnev has quit IRC21:26
*** jerrygb has quit IRC21:30
*** pauloewerton has quit IRC21:30
*** lblanchard has quit IRC21:30
*** kmARC has quit IRC21:31
*** kmARC_ has quit IRC21:31
*** doug-fish has quit IRC21:35
*** bpokorny_ has joined #openstack-horizon21:39
*** bpokorny has quit IRC21:42
*** rajatvig has quit IRC21:43
*** vgridnev has joined #openstack-horizon21:51
*** rajatvig has joined #openstack-horizon21:54
*** kyleolivo has joined #openstack-horizon21:56
*** kyleolivo has quit IRC21:57
*** kyleolivo has joined #openstack-horizon21:58
*** kyleolivo has quit IRC22:03
*** kyleolivo has joined #openstack-horizon22:03
*** Drago has quit IRC22:12
*** kyleolivo has quit IRC22:21
*** kyleolivo has joined #openstack-horizon22:22
*** stevemar has joined #openstack-horizon22:29
*** nlahouti has quit IRC22:31
*** stevemar has quit IRC22:33
*** lhcheng has quit IRC22:33
*** lhcheng has joined #openstack-horizon22:35
*** nlahouti has joined #openstack-horizon22:37
*** kyleolivo has quit IRC22:41
*** TravT_ has joined #openstack-horizon22:41
*** kyleolivo has joined #openstack-horizon22:43
*** TravT has quit IRC22:43
*** ephrem has quit IRC22:46
openstackgerritShaoquan Chen proposed openstack/horizon: Moving inline html code out of spec  https://review.openstack.org/21336722:48
*** sqchen has joined #openstack-horizon22:50
sqchentqtran: TravT: Hi guys.22:51
tqtranhi sqchen22:51
*** nlahouti has quit IRC22:51
sqchentake a look at this: https://review.openstack.org/#/c/213367/22:51
*** stevemar has joined #openstack-horizon22:51
sqchenyou might be interested.22:52
tqtranquestion, how is the templatecache storing the template?22:53
tqtranah nvm i see what you did there22:54
*** nlahouti has joined #openstack-horizon22:55
tqtranvery cool, will take a look at it next week. trying to wrap up an i18n bug22:55
sqchenyes, it use the current mechanism of loading and caching htnl partials, we can later change the mechanism as you suggested.22:56
tqtranso right now, theres no use for external_html?22:56
sqchensure, take your time. :)22:57
sqchenthis are using  external_templates22:57
sqchenall the html files are auto-collected by the auto-collecting mechanism.22:58
sqchenThe patch works for the refactored spec.22:59
tqtrani dont think the html files are auto-collected sean :P23:00
tqtranonly the JS files are, the html files are accessible only because they are inside of a static folder23:01
sqchenthe name of the html files are auto-collected.23:01
tqtrancan you show me this in code? i dont see it23:02
sqchenI was not very acurate23:02
sqchenok23:02
sqchenlet me find the code...23:02
sqchenhttps://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L9623:03
sqchenand https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/jasmine/jasmine.html#L60-L7623:07
*** jingjing_ren has quit IRC23:09
sqchenyou can print the markup variable in the spec.js file by using console.log, they has the same value as they have when it is written inline.23:09
*** vgridnev has quit IRC23:10
*** kyleolivo has quit IRC23:12
openstackgerritMerged openstack/horizon: JSCS Cleanup - horizon/ tech-debt  https://review.openstack.org/19934523:12
*** TravT has joined #openstack-horizon23:17
tqtrani see i see23:19
tqtranbut thats not auto-discovery right?23:20
tqtranyou have to add files manually to the external_templates list?23:20
*** TravT_ has quit IRC23:20
*** lhcheng has quit IRC23:22
sqchenyou do not need to add them manually. the patch does’t include any code like that. The html file/s names are auto-collected into external-templates, and in Jasmine.html, they are cached into the templatechche serivice. all the mechanism already exists.23:25
*** ybathia has quit IRC23:25
*** kzaitsev_mb has quit IRC23:29
*** julim has quit IRC23:30
openstackgerritMerged openstack/horizon: Updating docs for customization  https://review.openstack.org/21268323:32
*** jingjing_ren has joined #openstack-horizon23:39
*** hurgleburgler has quit IRC23:42
*** jingjing_ren has quit IRC23:44
openstackgerritShaoquan Chen proposed openstack/horizon: Moving inline html code out of spec  https://review.openstack.org/21336723:45
openstackgerritShaoquan Chen proposed openstack/horizon: Moving inline html code out of transfer-table.spec.js  https://review.openstack.org/21336723:46
tqtransqchen: ok :P i understand that mechanism exist, but i dont think we're auto collecting html files are we?23:50
tqtrani know we're auto collecting js, but not sure we are doing the same for html and scss?23:50
openstackgerritTravis Tripp proposed openstack/horizon: Refactor angular cloud services utilities  https://review.openstack.org/17951623:50
sqchenwe are auto-collecting html file names, just as we do for JS file names. We do not manually add html file names to the external_templates, the html file names are auto-collected into external_templates array. We don’t need to do auto-collecting for scss files, all scss files are manully add into their parent scss files by using @imprt directive.23:54
*** kzaitsev_mb has joined #openstack-horizon23:55
*** eroussel has joined #openstack-horizon23:56
sqchenwe auto-collect both js and html files.23:56
*** stevemar has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!