esp | don’t mess up your env :) | 00:00 |
---|---|---|
tqtran | lol try this instead | 00:00 |
tqtran | ./tools/with_venv.sh python manage.py collectstatic | 00:01 |
esp | ah, right | 00:01 |
tqtran | assuming you're in the horizon folder | 00:01 |
esp | I forgot about that | 00:01 |
esp | here goes | 00:01 |
tqtran | keep your fingers crossed lol | 00:01 |
openstackgerrit | Travis Tripp proposed openstack/horizon: Refactor angular cloud services utilities https://review.openstack.org/179516 | 00:02 |
*** stevemar has joined #openstack-horizon | 00:02 | |
esp | that did it! thx tqtran | 00:03 |
esp | I need to write that down | 00:03 |
*** tjones has quit IRC | 00:04 | |
*** jamielennox is now known as jamielennox|away | 00:05 | |
tqtran | lol you're welcome | 00:06 |
*** rajatvig has quit IRC | 00:07 | |
*** jamielennox|away is now known as jamielennox | 00:07 | |
*** nlahouti has quit IRC | 00:08 | |
*** geoffarnold has quit IRC | 00:08 | |
*** jamielennox is now known as jamielennox|away | 00:10 | |
*** jingjing_ren has quit IRC | 00:10 | |
*** yamamoto has joined #openstack-horizon | 00:11 | |
*** yamamoto has quit IRC | 00:16 | |
*** geoffarnold has joined #openstack-horizon | 00:17 | |
*** wolverineav has joined #openstack-horizon | 00:24 | |
*** Sukhdev has quit IRC | 00:27 | |
*** SimonChung has quit IRC | 00:29 | |
*** tqtran has quit IRC | 00:30 | |
*** tjones has joined #openstack-horizon | 00:34 | |
*** geoffarnold has quit IRC | 00:38 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: Move magic_search.js in _scripts.html to after Angular files https://review.openstack.org/212308 | 00:43 |
*** tjones has quit IRC | 00:44 | |
*** zhenguo has joined #openstack-horizon | 00:49 | |
openstackgerrit | Merged openstack/horizon: Delete VIP action refactoring https://review.openstack.org/184776 | 00:51 |
*** mwhagedorn has quit IRC | 00:53 | |
*** dsneddon has quit IRC | 00:54 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon's scss webroot should come from settings.py https://review.openstack.org/206592 | 00:55 |
*** juggler has joined #openstack-horizon | 00:57 | |
*** yingjun has joined #openstack-horizon | 00:59 | |
*** bpokorny has quit IRC | 01:06 | |
*** ybathia has quit IRC | 01:07 | |
*** hhuang has joined #openstack-horizon | 01:11 | |
*** jwy has quit IRC | 01:13 | |
*** hurgleburgler has quit IRC | 01:13 | |
*** jtriley has quit IRC | 01:22 | |
*** jtriley has joined #openstack-horizon | 01:23 | |
*** skylerberg has quit IRC | 01:27 | |
*** bharath_ has joined #openstack-horizon | 01:32 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: Use security group id for launch instance https://review.openstack.org/212279 | 01:34 |
*** lyanchih has joined #openstack-horizon | 01:38 | |
*** bharath_ has quit IRC | 01:41 | |
*** bharath_ has joined #openstack-horizon | 01:43 | |
*** jwy has joined #openstack-horizon | 01:44 | |
*** shivrao has quit IRC | 02:01 | |
*** jamielennox|away is now known as jamielennox | 02:08 | |
*** bharath_ has quit IRC | 02:09 | |
*** bharath_ has joined #openstack-horizon | 02:11 | |
*** Ephur has quit IRC | 02:11 | |
*** jtriley has quit IRC | 02:23 | |
zhenguo | lhcheng: could you have a look at this https://review.openstack.org/#/c/186810/ please? | 02:23 |
lhcheng | zhenguo: I'm heading out now, but will review it when get home | 02:25 |
zhenguo | lhcheng: ok, thanks. | 02:25 |
* lhcheng starred the patch | 02:26 | |
lhcheng | zhenguo: later | 02:26 |
lhcheng | zhenguo: have to get food :) | 02:26 |
*** lhcheng has quit IRC | 02:27 | |
*** bharath_ has quit IRC | 02:27 | |
openstackgerrit | Merged openstack/horizon: Revert patch of bug #1445055 https://review.openstack.org/211001 | 02:28 |
openstack | bug 1445055 in OpenStack Dashboard (Horizon) "Misleading message on project create" [Low,Fix released] https://launchpad.net/bugs/1445055 - Assigned to Dimitri Mazmanov (sorantis) | 02:28 |
*** gyee_500 has quit IRC | 02:29 | |
*** eroussel has joined #openstack-horizon | 02:36 | |
*** ducttape_ has joined #openstack-horizon | 02:39 | |
*** jwy has quit IRC | 02:43 | |
*** KunalGandhi has quit IRC | 02:46 | |
*** fedexo has joined #openstack-horizon | 02:46 | |
*** yamamoto has joined #openstack-horizon | 02:48 | |
*** masco has joined #openstack-horizon | 02:49 | |
openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/212217 | 02:50 |
*** saksham has quit IRC | 02:52 | |
*** bpokorny has joined #openstack-horizon | 02:52 | |
*** fedexo has quit IRC | 02:56 | |
*** stevemar has quit IRC | 02:58 | |
*** stevemar has joined #openstack-horizon | 02:59 | |
*** ducttape_ has quit IRC | 03:02 | |
*** julim has quit IRC | 03:03 | |
*** ducttape_ has joined #openstack-horizon | 03:04 | |
*** eroussel has quit IRC | 03:09 | |
*** KunalGandhi has joined #openstack-horizon | 03:10 | |
*** saksham has joined #openstack-horizon | 03:14 | |
*** saksham has quit IRC | 03:16 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: Move magic_search.js in _scripts.html to after Angular files https://review.openstack.org/212308 | 03:17 |
openstackgerrit | Kelly Domico proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 03:18 |
*** jingjing_ren has joined #openstack-horizon | 03:27 | |
*** jingjing_ren has quit IRC | 03:32 | |
*** ducttape_ has quit IRC | 03:37 | |
*** shivrao has joined #openstack-horizon | 03:37 | |
*** tjones has joined #openstack-horizon | 03:38 | |
*** KunalGandhi has quit IRC | 03:43 | |
*** KunalGandhi has joined #openstack-horizon | 03:43 | |
*** shivrao has quit IRC | 03:44 | |
*** shivrao has joined #openstack-horizon | 03:45 | |
*** kyleolivo has joined #openstack-horizon | 03:47 | |
*** shivrao has quit IRC | 03:50 | |
*** KunalGan_ has joined #openstack-horizon | 03:52 | |
*** yingjun has quit IRC | 03:54 | |
*** KunalGandhi has quit IRC | 03:56 | |
*** Sukhdev has joined #openstack-horizon | 03:57 | |
*** sambetts has joined #openstack-horizon | 03:59 | |
*** KingKhan has joined #openstack-horizon | 04:00 | |
*** lyanchih has quit IRC | 04:02 | |
*** jamielennox is now known as jamielennox|away | 04:02 | |
*** fedexo has joined #openstack-horizon | 04:05 | |
*** KingKhan has quit IRC | 04:06 | |
*** KunalGan_ has quit IRC | 04:09 | |
*** lhcheng has joined #openstack-horizon | 04:17 | |
lhcheng | zhenguo: patch reviewed, added my comments | 04:18 |
*** SimonChung has joined #openstack-horizon | 04:19 | |
*** SimonChung1 has joined #openstack-horizon | 04:20 | |
*** yamamoto has quit IRC | 04:21 | |
*** KingKhan has joined #openstack-horizon | 04:24 | |
*** SimonChung has quit IRC | 04:24 | |
*** yamamoto has joined #openstack-horizon | 04:25 | |
*** KingKhan has quit IRC | 04:28 | |
*** KunalGandhi has joined #openstack-horizon | 04:29 | |
openstackgerrit | Merged openstack/horizon: JSCS Cleanup - Use mock module to avoid using window https://review.openstack.org/199333 | 04:33 |
*** KingKhan has joined #openstack-horizon | 04:35 | |
*** KingKhan_ has joined #openstack-horizon | 04:36 | |
*** KingKhan has left #openstack-horizon | 04:40 | |
*** KingKhan has joined #openstack-horizon | 04:41 | |
*** KingKhan_ has quit IRC | 04:41 | |
*** early has quit IRC | 04:42 | |
*** morgan_404 is now known as morgan_204 | 04:42 | |
*** morgan_204 is now known as morgan_206 | 04:44 | |
*** morgan_206 is now known as morgan_503 | 04:45 | |
*** jamielennox|away is now known as jamielennox | 04:46 | |
*** tjones has quit IRC | 04:47 | |
*** bharath_ has joined #openstack-horizon | 04:48 | |
*** fedexo has quit IRC | 04:51 | |
*** yamamoto has quit IRC | 04:54 | |
*** fedexo has joined #openstack-horizon | 04:55 | |
*** bharath_ has quit IRC | 04:59 | |
*** KunalGandhi has quit IRC | 05:00 | |
*** early has joined #openstack-horizon | 05:00 | |
*** yamamoto has joined #openstack-horizon | 05:00 | |
*** fedexo has quit IRC | 05:02 | |
*** lhcheng has quit IRC | 05:03 | |
*** fedexo has joined #openstack-horizon | 05:03 | |
*** bharath_ has joined #openstack-horizon | 05:06 | |
*** shivrao has joined #openstack-horizon | 05:12 | |
*** Drago1 has quit IRC | 05:13 | |
*** kyleolivo has quit IRC | 05:15 | |
*** bpokorny has quit IRC | 05:17 | |
*** bpokorny has joined #openstack-horizon | 05:18 | |
*** bpokorny has quit IRC | 05:18 | |
*** bpokorny has joined #openstack-horizon | 05:19 | |
*** bpokorny has quit IRC | 05:24 | |
*** yamamoto has quit IRC | 05:25 | |
*** mrunge has joined #openstack-horizon | 05:28 | |
*** yamamoto has joined #openstack-horizon | 05:29 | |
*** kmARC_ has joined #openstack-horizon | 05:31 | |
*** kmARC has joined #openstack-horizon | 05:31 | |
*** bharath_ has quit IRC | 05:32 | |
*** fedexo has quit IRC | 05:34 | |
*** kyleolivo has joined #openstack-horizon | 05:38 | |
*** chlong has quit IRC | 05:41 | |
*** kyleolivo has quit IRC | 05:42 | |
*** chlong has joined #openstack-horizon | 05:44 | |
*** masco has quit IRC | 05:48 | |
*** jprovazn has joined #openstack-horizon | 05:48 | |
*** yingjun has joined #openstack-horizon | 05:54 | |
*** Sukhdev has quit IRC | 05:57 | |
*** fifieldt_ has quit IRC | 06:00 | |
*** shivrao has quit IRC | 06:02 | |
*** masco has joined #openstack-horizon | 06:05 | |
*** bharath_ has joined #openstack-horizon | 06:05 | |
*** e0ne has joined #openstack-horizon | 06:08 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/212995 | 06:12 |
*** peristeri has joined #openstack-horizon | 06:15 | |
zhenguo | lhcheng: thanks for the review and will address your comments soon :) | 06:18 |
*** e0ne has quit IRC | 06:27 | |
*** lyanchih has joined #openstack-horizon | 06:33 | |
*** kmARC_ has quit IRC | 06:37 | |
*** kmARC has quit IRC | 06:39 | |
*** KingKhan_ has joined #openstack-horizon | 06:42 | |
*** KingKhan_ has quit IRC | 06:42 | |
*** jprovazn has quit IRC | 06:42 | |
*** KingKhan has quit IRC | 06:42 | |
*** kyleolivo has joined #openstack-horizon | 06:42 | |
*** nlahouti has joined #openstack-horizon | 06:43 | |
*** kyleolivo has quit IRC | 06:49 | |
*** e0ne has joined #openstack-horizon | 06:51 | |
*** kmARC_ has joined #openstack-horizon | 06:56 | |
*** kmARC has joined #openstack-horizon | 06:56 | |
*** nlahouti has quit IRC | 07:00 | |
*** e0ne has quit IRC | 07:04 | |
mrunge | zhenguo, thank you for your +2 on https://review.openstack.org/#/c/201066/ | 07:06 |
mrunge | zhenguo, would you set +A there too, or don't you feel comfortable with that? | 07:06 |
*** yingjun has quit IRC | 07:09 | |
*** rdopiera has joined #openstack-horizon | 07:10 | |
*** yingjun has joined #openstack-horizon | 07:12 | |
*** masco has quit IRC | 07:15 | |
*** jamielennox is now known as jamielennox|away | 07:17 | |
openstackgerrit | Albert Tu proposed openstack/horizon: Add i18n support to Angular humanizeNumbers helper https://review.openstack.org/199997 | 07:24 |
openstackgerrit | Zhenguo Niu proposed openstack/horizon: Add volume migration support https://review.openstack.org/186810 | 07:31 |
*** chlong has quit IRC | 07:36 | |
*** chlong has joined #openstack-horizon | 07:39 | |
*** MaxV has joined #openstack-horizon | 07:40 | |
*** kmARC_ has quit IRC | 07:47 | |
*** kmARC has quit IRC | 07:47 | |
christophs | Is there a way to get this issue handled? https://bugs.launchpad.net/horizon/+bug/1482657 | 07:48 |
openstack | Launchpad bug 1482657 in OpenStack Dashboard (Horizon) "Attribute error on virtual_size" [Undecided,New] | 07:48 |
*** kzaitsev_mb has joined #openstack-horizon | 07:49 | |
*** MaxV has quit IRC | 07:50 | |
mrunge | christophs, you should propose your patch on gerrit | 07:50 |
zhenguo | mrunge: sure, will +A that :) | 07:50 |
mrunge | christophs, https://wiki.openstack.org/wiki/How_To_Contribute | 07:51 |
mrunge | zhenguo, thank you | 07:51 |
christophs | mrunge, Okay will do this. Thanks | 07:51 |
zhenguo | mrunge: np | 07:51 |
mrunge | christophs, thank you, and thank you for your patch proposed in launchpad. usually it's easier to review in gerrit, it get's tested there as well. | 07:52 |
mrunge | christophs, feel free to ask here, if there are issues around the process | 07:53 |
*** shivrao has joined #openstack-horizon | 07:54 | |
*** wolverineav has quit IRC | 07:57 | |
*** stevemar has quit IRC | 07:58 | |
*** akrivoka has joined #openstack-horizon | 08:05 | |
*** jcoufal has joined #openstack-horizon | 08:05 | |
*** romainh has joined #openstack-horizon | 08:07 | |
*** kyleolivo has joined #openstack-horizon | 08:10 | |
*** shivrao has quit IRC | 08:10 | |
*** kmARC_ has joined #openstack-horizon | 08:11 | |
*** kmARC has joined #openstack-horizon | 08:12 | |
*** kyleolivo has quit IRC | 08:14 | |
*** kzaitsev_mb has quit IRC | 08:15 | |
*** MaxV has joined #openstack-horizon | 08:16 | |
*** kzaitsev_mb has joined #openstack-horizon | 08:17 | |
openstackgerrit | ziyu032 proposed openstack/horizon: Filter out networks that have no subnets when launch instance https://review.openstack.org/213027 | 08:18 |
*** MaxV has quit IRC | 08:21 | |
*** MaxV has joined #openstack-horizon | 08:21 | |
*** kzaitsev_mb has quit IRC | 08:24 | |
*** kzaitsev_mb has joined #openstack-horizon | 08:25 | |
*** lyanchih has quit IRC | 08:26 | |
*** MaxV has quit IRC | 08:31 | |
*** MaxV has joined #openstack-horizon | 08:31 | |
openstackgerrit | Merged openstack/horizon: remove django<1.7 from tests https://review.openstack.org/201066 | 08:42 |
*** masco has joined #openstack-horizon | 09:00 | |
christophs | mrunge, I need to be a foundation member to submit code? | 09:03 |
*** kzaitsev_mb has quit IRC | 09:04 | |
mrunge | christophs, I don't think so | 09:04 |
mrunge | but you need to sign the CLA (iirc) | 09:05 |
christophs | Yes I did this. But I can't add contact data to my gerrit account. So I found this: https://ask.openstack.org/en/question/56720/cannot-store-contact-information-when-updating-info-in-openstack-gerrit/ | 09:05 |
mrunge | hmmm, according to that, you'd need to be a member then | 09:07 |
mrunge | whatever that means... | 09:07 |
christophs | Who know :D... will try it. | 09:07 |
mrunge | christophs, as long as you're trying to become an indiviual member, you should be safe | 09:08 |
*** jcoufal_ has joined #openstack-horizon | 09:12 | |
*** vgridnev has joined #openstack-horizon | 09:13 | |
*** jcoufal has quit IRC | 09:15 | |
openstackgerrit | Christoph Seifert proposed openstack/horizon: Fix attribute error with old glance backend https://review.openstack.org/213054 | 09:18 |
christophs | mrunge, Finally it worked. Thank you. | 09:22 |
mrunge | christophs, great, glad you figured it out | 09:26 |
mrunge | christophs, for what version would you need your patch? | 09:27 |
christophs | For the kilo release. Should the patch be against stable/kilo? | 09:29 |
mrunge | christophs, nope. master is fine. after is was merged, we need to cherry-pick it into stable/kilo as well | 09:30 |
mrunge | just to be sure not to create a regression in a later version | 09:30 |
christophs | mrunge, That's great. Thank you. | 09:32 |
*** yingjun has quit IRC | 09:34 | |
*** tosky has joined #openstack-horizon | 09:34 | |
openstackgerrit | Merged openstack/manila-ui: Add extend support to manila-ui https://review.openstack.org/185352 | 09:34 |
*** yingjun has joined #openstack-horizon | 09:35 | |
*** yingjun has quit IRC | 09:35 | |
*** yingjun has joined #openstack-horizon | 09:35 | |
*** yingjun has quit IRC | 09:40 | |
*** markus_z has joined #openstack-horizon | 09:43 | |
*** BobBall has quit IRC | 09:51 | |
*** lyanchih has joined #openstack-horizon | 09:54 | |
*** marlinc has quit IRC | 09:55 | |
*** marlinc has joined #openstack-horizon | 09:58 | |
*** marlinc has joined #openstack-horizon | 09:59 | |
*** jcoufal has joined #openstack-horizon | 10:01 | |
*** jcoufal_ has quit IRC | 10:04 | |
*** marlinc has quit IRC | 10:10 | |
*** kyleolivo has joined #openstack-horizon | 10:10 | |
*** marlinc has joined #openstack-horizon | 10:12 | |
*** kyleolivo has quit IRC | 10:14 | |
*** romainh has quit IRC | 10:14 | |
*** sayan has joined #openstack-horizon | 10:15 | |
*** ttrifonov is now known as zz_ttrifonov | 10:16 | |
*** kmartin has quit IRC | 10:18 | |
*** kzaitsev_mb has joined #openstack-horizon | 10:22 | |
*** zhenguo has quit IRC | 10:26 | |
*** bharath_ has quit IRC | 10:35 | |
openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move node processes selection to own tab https://review.openstack.org/197018 | 10:38 |
vgridnev | hey mrunge, could you please take a look on it ^^ | 10:39 |
mrunge | vgridnev, I'm quite busy now | 10:39 |
*** yamamoto has quit IRC | 10:44 | |
*** zz_ttrifonov is now known as ttrifonov | 10:44 | |
*** yamamoto has joined #openstack-horizon | 10:46 | |
*** MaxV has quit IRC | 11:00 | |
*** yamamoto has quit IRC | 11:11 | |
*** _crobertsrh is now known as crobertsrh | 11:14 | |
*** sambetts has quit IRC | 11:24 | |
*** MaxV has joined #openstack-horizon | 11:27 | |
*** jcoufal_ has joined #openstack-horizon | 11:28 | |
*** sambetts has joined #openstack-horizon | 11:29 | |
*** linkedinyou has quit IRC | 11:29 | |
*** jcoufal has quit IRC | 11:31 | |
*** masco has quit IRC | 11:35 | |
*** MaxV has quit IRC | 11:37 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Fix set/unset extra specs for share type update form https://review.openstack.org/213106 | 11:39 |
*** akrivoka has quit IRC | 11:42 | |
*** lyanchih has quit IRC | 11:45 | |
*** kzaitsev_mb has quit IRC | 11:50 | |
*** lyanchih has joined #openstack-horizon | 11:53 | |
*** masco has joined #openstack-horizon | 11:55 | |
*** kyleolivo has joined #openstack-horizon | 11:58 | |
*** vgridnev has quit IRC | 12:01 | |
*** kyleolivo has quit IRC | 12:02 | |
*** romainh has joined #openstack-horizon | 12:03 | |
*** yamamoto has joined #openstack-horizon | 12:03 | |
*** MaxV has joined #openstack-horizon | 12:04 | |
*** vgridnev has joined #openstack-horizon | 12:07 | |
*** vgridnev has quit IRC | 12:07 | |
*** masco has quit IRC | 12:12 | |
*** yamamoto has quit IRC | 12:20 | |
*** kzaitsev_mb has joined #openstack-horizon | 12:21 | |
*** ducttape_ has joined #openstack-horizon | 12:22 | |
*** mwhagedorn has joined #openstack-horizon | 12:22 | |
*** lblanchard has joined #openstack-horizon | 12:23 | |
*** petertr7_away is now known as petertr7 | 12:29 | |
*** MaxV has quit IRC | 12:36 | |
*** tosky has quit IRC | 12:38 | |
*** linkedinyou has joined #openstack-horizon | 12:40 | |
*** ducttape_ has quit IRC | 12:41 | |
*** tosky has joined #openstack-horizon | 12:41 | |
*** jcoufal_ has quit IRC | 12:43 | |
*** jcoufal has joined #openstack-horizon | 12:43 | |
*** markus_z has quit IRC | 12:47 | |
*** radez is now known as radez_g0n3 | 12:48 | |
*** doug-fish has joined #openstack-horizon | 12:49 | |
*** peristeri_ has joined #openstack-horizon | 12:49 | |
*** peristeri has quit IRC | 12:50 | |
*** yamamoto has joined #openstack-horizon | 12:51 | |
*** vgridnev has joined #openstack-horizon | 12:51 | |
*** crobertsrh has left #openstack-horizon | 12:53 | |
*** crobertsrh has joined #openstack-horizon | 12:58 | |
*** MaxV has joined #openstack-horizon | 13:03 | |
*** kzaitsev_mb has quit IRC | 13:06 | |
*** kzaitsev_mb has joined #openstack-horizon | 13:08 | |
openstackgerrit | Karthik Suresh proposed openstack/horizon: Added small block to remove default panels https://review.openstack.org/213139 | 13:09 |
*** KunalGandhi has joined #openstack-horizon | 13:12 | |
*** rodrigods has quit IRC | 13:13 | |
*** KunalGan_ has joined #openstack-horizon | 13:14 | |
*** markus_z has joined #openstack-horizon | 13:15 | |
*** julim has joined #openstack-horizon | 13:16 | |
*** KunalGandhi has quit IRC | 13:17 | |
*** cardeois has joined #openstack-horizon | 13:19 | |
*** MaxV has quit IRC | 13:20 | |
*** rodrigods has joined #openstack-horizon | 13:20 | |
*** MaxV has joined #openstack-horizon | 13:22 | |
*** tjones has joined #openstack-horizon | 13:23 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Enable pagination for Project->Images view https://review.openstack.org/207812 | 13:24 |
*** akrivoka has joined #openstack-horizon | 13:28 | |
*** zhenguo has joined #openstack-horizon | 13:28 | |
*** fifieldt has joined #openstack-horizon | 13:30 | |
openstackgerrit | Florian Fuchs proposed openstack/horizon: Add default sorting to the Security Groups table. https://review.openstack.org/213143 | 13:31 |
*** jtriley has joined #openstack-horizon | 13:40 | |
*** MaxV has quit IRC | 13:41 | |
*** radez_g0n3 is now known as radez | 13:41 | |
*** MaxV has joined #openstack-horizon | 13:42 | |
openstackgerrit | Michael Hagedorn proposed openstack/horizon: Neutron Quota Settings Flag Disables Neutron GUI https://review.openstack.org/210100 | 13:43 |
openstackgerrit | Michael Hagedorn proposed openstack/horizon: enable_quotas=False breaks Neutron usage https://review.openstack.org/211310 | 13:44 |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Table https://review.openstack.org/199567 | 13:45 |
*** lyanchih has quit IRC | 13:48 | |
*** ducttape_ has joined #openstack-horizon | 13:52 | |
*** jcoufal has quit IRC | 13:55 | |
*** MaxV has quit IRC | 13:56 | |
*** petertr7 is now known as petertr7_away | 13:58 | |
*** peristeri_ has quit IRC | 13:58 | |
*** kyleolivo has joined #openstack-horizon | 13:58 | |
*** MaxV has joined #openstack-horizon | 13:59 | |
*** petertr7_away is now known as petertr7 | 14:00 | |
*** MaxV has quit IRC | 14:00 | |
*** MaxV has joined #openstack-horizon | 14:00 | |
*** kyleolivo has quit IRC | 14:03 | |
*** lapalm has joined #openstack-horizon | 14:04 | |
*** tvanderwiel has joined #openstack-horizon | 14:06 | |
*** tvanderwiel has left #openstack-horizon | 14:06 | |
ducttape_ | last 100 commits, about 20% have cleanup in the commit message. confidence | 14:10 |
*** tosky has quit IRC | 14:12 | |
*** vijendar has joined #openstack-horizon | 14:15 | |
openstackgerrit | Tracy Jones proposed openstack/horizon: code cleanup from commits on https://review.openstack.org/#/c/195751/ https://review.openstack.org/200301 | 14:16 |
*** Drago has joined #openstack-horizon | 14:17 | |
*** Drago has quit IRC | 14:17 | |
*** lapalm has quit IRC | 14:19 | |
*** chlong has quit IRC | 14:19 | |
*** lapalm has joined #openstack-horizon | 14:20 | |
openstackgerrit | Ryan Brady proposed openstack/tuskar-ui: Add discovery on demand https://review.openstack.org/211816 | 14:20 |
*** tosky has joined #openstack-horizon | 14:22 | |
*** Drago has joined #openstack-horizon | 14:23 | |
*** Drago has quit IRC | 14:23 | |
*** pauloewerton has joined #openstack-horizon | 14:23 | |
*** MaxV has quit IRC | 14:25 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Fix set/unset extra specs for share type update form https://review.openstack.org/213106 | 14:26 |
*** rdopiera has quit IRC | 14:26 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Fix set/unset extra specs for share type update form https://review.openstack.org/213106 | 14:27 |
*** absubram has joined #openstack-horizon | 14:30 | |
*** sayan has quit IRC | 14:32 | |
*** rdopiera has joined #openstack-horizon | 14:34 | |
*** geoffarnold has joined #openstack-horizon | 14:35 | |
*** Drago has joined #openstack-horizon | 14:37 | |
*** Drago has quit IRC | 14:38 | |
*** Drago has joined #openstack-horizon | 14:38 | |
*** absubram has quit IRC | 14:38 | |
*** geoffarnold has quit IRC | 14:39 | |
*** geoffarnold has joined #openstack-horizon | 14:41 | |
*** absubram has joined #openstack-horizon | 14:41 | |
*** alejandrito has joined #openstack-horizon | 14:44 | |
*** yamamoto has quit IRC | 14:48 | |
*** MaxV has joined #openstack-horizon | 14:52 | |
*** yamamoto has joined #openstack-horizon | 14:52 | |
*** radez is now known as radez_g0n3 | 14:56 | |
*** absubram has quit IRC | 14:57 | |
*** mpavlase has joined #openstack-horizon | 15:02 | |
*** lyanchih has joined #openstack-horizon | 15:03 | |
*** ttrifonov is now known as zz_ttrifonov | 15:04 | |
*** bpokorny has joined #openstack-horizon | 15:04 | |
*** petertr7 is now known as petertr7_away | 15:06 | |
*** absubram has joined #openstack-horizon | 15:06 | |
*** radez_g0n3 is now known as radez | 15:08 | |
*** bpokorny has quit IRC | 15:08 | |
*** lsmola has quit IRC | 15:13 | |
*** jcoufal has joined #openstack-horizon | 15:17 | |
*** kmartin has joined #openstack-horizon | 15:19 | |
*** Piet has quit IRC | 15:19 | |
*** TravT_ has joined #openstack-horizon | 15:19 | |
openstackgerrit | Martin Hickey proposed openstack/horizon: Adds button to disable more than one domain at a time https://review.openstack.org/213193 | 15:20 |
*** KunalGan_ has quit IRC | 15:20 | |
*** TravT has quit IRC | 15:21 | |
*** TravT_ is now known as TravT | 15:21 | |
*** tyr has joined #openstack-horizon | 15:21 | |
*** rdopiera has quit IRC | 15:23 | |
*** bpokorny has joined #openstack-horizon | 15:24 | |
*** yamamoto has quit IRC | 15:25 | |
*** sayan has joined #openstack-horizon | 15:27 | |
*** esp has left #openstack-horizon | 15:28 | |
*** mpavlase has quit IRC | 15:30 | |
*** openstackgerrit has quit IRC | 15:31 | |
*** openstackgerrit has joined #openstack-horizon | 15:32 | |
*** absubram has quit IRC | 15:32 | |
*** yamamoto has joined #openstack-horizon | 15:35 | |
*** esp has joined #openstack-horizon | 15:37 | |
*** nlahouti has joined #openstack-horizon | 15:38 | |
*** absubram has joined #openstack-horizon | 15:38 | |
*** radez is now known as radez_g0n3 | 15:38 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services https://review.openstack.org/212838 | 15:39 |
*** lapalm has quit IRC | 15:41 | |
*** lapalm has joined #openstack-horizon | 15:41 | |
*** zhenguo has quit IRC | 15:43 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for Nova Service https://review.openstack.org/211783 | 15:44 |
openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 15:46 |
*** hurgleburgler has joined #openstack-horizon | 15:49 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for KeyStone Service https://review.openstack.org/211782 | 15:50 |
*** dsneddon has joined #openstack-horizon | 15:53 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services https://review.openstack.org/212838 | 15:54 |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 15:55 |
*** jprovazn has joined #openstack-horizon | 15:58 | |
*** kyleolivo has joined #openstack-horizon | 15:59 | |
*** jcoufal has quit IRC | 16:00 | |
*** vgridnev has quit IRC | 16:00 | |
*** jprovazn has quit IRC | 16:01 | |
*** jcoufal has joined #openstack-horizon | 16:02 | |
*** kyleolivo has quit IRC | 16:04 | |
*** markus_z has quit IRC | 16:07 | |
*** jcoufal has quit IRC | 16:07 | |
*** akrivoka has quit IRC | 16:08 | |
*** KunalGandhi has joined #openstack-horizon | 16:16 | |
*** Sukhdev has joined #openstack-horizon | 16:22 | |
*** dsneddon has quit IRC | 16:29 | |
ducttape_ | did the display of the region recently change in the top navbar? | 16:30 |
hurgleburgler | There's a fix for that | 16:32 |
ducttape_ | does it involve software ? | 16:32 |
hurgleburgler | https://review.openstack.org/#/c/212682/ | 16:32 |
hurgleburgler | Regions and Domains got no love in my recent refactor of the topbar :( | 16:32 |
hurgleburgler | my bad | 16:32 |
ducttape_ | ugg. how did this get merged? | 16:32 |
*** Piet has joined #openstack-horizon | 16:33 | |
david-lyle | ducttape_: do you have the original review link? | 16:35 |
david-lyle | I thought I was having CSS problems | 16:35 |
ducttape_ | I probably +1 that thing, didn't I.... as I hand-wring | 16:36 |
*** MaxV has quit IRC | 16:36 | |
ducttape_ | hurgleburgler probably has it | 16:36 |
*** petertr7_away is now known as petertr7 | 16:36 | |
*** gyee has joined #openstack-horizon | 16:37 | |
ducttape_ | was this it? https://review.openstack.org/#/c/207660/ | 16:37 |
ducttape_ | hurgleburgler ^ | 16:37 |
david-lyle | yeah, I found it | 16:37 |
hurgleburgler | Yes, that's the one | 16:37 |
david-lyle | :( | 16:37 |
hurgleburgler | I opened a bug and put a fix out for it already | 16:37 |
*** sayan has quit IRC | 16:37 | |
hurgleburgler | sorry 。゜゜(´O`)°゜。 | 16:37 |
*** rajatvig has joined #openstack-horizon | 16:37 | |
david-lyle | hurgleburgler: my concern, and not just for you, is that we're breaking things faster than we're fixing them | 16:38 |
ducttape_ | http://pasteboard.co/2IuqjpGW.png shows how special it looks | 16:38 |
*** tjones has quit IRC | 16:39 | |
david-lyle | yup that's what I saw. like I said that is was a stale static problem | 16:39 |
ducttape_ | david-lyle - this is up to the pace of accepting / merging stuff without personally doing more tests. I +1 this thing so I am at fault.... but so is everyone on the review | 16:39 |
david-lyle | I'm about to take horizon and go home | 16:39 |
ducttape_ | and you can't have nice things, you should know | 16:40 |
ducttape_ | even if you take it home, your kids will destroy it | 16:40 |
*** MaxV has joined #openstack-horizon | 16:40 | |
*** kmARC_ has quit IRC | 16:40 | |
david-lyle | what exactly are people testing with? | 16:40 |
hurgleburgler | I didn't have my setup with multiple regions | 16:41 |
sjmc7 | lynx | 16:41 |
* ducttape_ coughs devstack | 16:41 | |
hurgleburgler | ^ | 16:41 |
*** kmARC has quit IRC | 16:41 | |
david-lyle | you can configure devstack | 16:41 |
david-lyle | to be a full environment | 16:41 |
hurgleburgler | I know that now! ;) | 16:41 |
*** yamamoto has quit IRC | 16:41 | |
sjmc7 | ducttape_ - it is on my list to get some hardware set up here to keep bleeding edge, but i'm not there yet | 16:41 |
*** yamamoto has joined #openstack-horizon | 16:41 | |
hurgleburgler | I had to also configure it for domains | 16:41 |
david-lyle | hurgleburgler: IMO everyone should be testing with v3 by default | 16:42 |
ducttape_ | sjmc7 - careful near that edge. like me, you will end up a bloody mess | 16:42 |
sjmc7 | i'll wear gloves | 16:42 |
ducttape_ | shark cage is recomended | 16:42 |
hurgleburgler | You guys are the front line | 16:42 |
david-lyle | hurgleburgler: again, not calling you out personally | 16:42 |
*** yamamoto has quit IRC | 16:42 | |
hurgleburgler | I'm calling me out personally, lolz | 16:42 |
david-lyle | well in that case... | 16:43 |
*** mwhagedorn has quit IRC | 16:43 | |
hurgleburgler | i gotta go flog myself now (╯_╰) | 16:43 |
sjmc7 | hurgelburgler, remind me next week about this. we should have a proper test setup | 16:43 |
* ducttape_ prepares an invoice for hurgleburgler, re: QA services | 16:43 | |
david-lyle | hurgleburgler: I'll try you fix in a minute, deep in writing d-o-a tests | 16:44 |
david-lyle | lest you want to understand pain | 16:44 |
hurgleburgler | tsufiev made some comments on it, I need to address … will get on it right after I address david-lyle 's pyscss comments | 16:44 |
rajatvig | david-lyle: is there a document about making the DevStack a full environment? | 16:45 |
*** mwhagedorn has joined #openstack-horizon | 16:45 | |
david-lyle | rajatvig: there is an example devstack local.conf in the horizon tree | 16:46 |
*** stevemar has joined #openstack-horizon | 16:46 | |
david-lyle | I should probably write a script for setting up multiple regions and configuring multidomain | 16:47 |
david-lyle | but I likely won't get to that any time soon | 16:47 |
david-lyle | rajatvig: https://github.com/openstack/horizon/blob/master/doc/source/ref/local_conf.rst is the file | 16:47 |
david-lyle | well, the contents of that file are the file | 16:47 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Disable button 'create snapshot' if share not snapshottable https://review.openstack.org/213242 | 16:48 |
*** stevemar has quit IRC | 16:49 | |
tsufiev | david-lyle, what's about a script for setting up Keystone/LDAP w several thousands of users :)? | 16:51 |
david-lyle | tsufiev: do you have such a thing? | 16:51 |
tsufiev | btw, that's quite common setup in production (not the number of users, but LDAP itself) | 16:51 |
david-lyle | tsufiev: I understand | 16:52 |
*** skylerberg has joined #openstack-horizon | 16:52 | |
tsufiev | david-lyle, unfortunately, no :(. We're starting to do this internally | 16:52 |
david-lyle | would be a great script to have | 16:52 |
*** MaxV has quit IRC | 16:52 | |
*** romainh has left #openstack-horizon | 16:52 | |
david-lyle | plugins to devstack would be the best way, I imagine | 16:53 |
david-lyle | if only there was group of developers on projects whose focus was stability and quality | 16:54 |
ducttape_ | #dreamer | 16:54 |
* david-lyle cues charlie brown music | 16:56 | |
*** cardeois_ has joined #openstack-horizon | 16:56 | |
david-lyle | https://www.youtube.com/watch?v=oabcM9SOF-E | 16:57 |
*** cardeois_ has quit IRC | 16:58 | |
*** cardeois has quit IRC | 16:59 | |
*** cardeois_ has joined #openstack-horizon | 16:59 | |
*** cardeois_ has quit IRC | 16:59 | |
openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 17:00 |
*** jtriley has quit IRC | 17:04 | |
*** lhcheng has joined #openstack-horizon | 17:04 | |
*** vgridnev has joined #openstack-horizon | 17:05 | |
*** KunalGandhi has quit IRC | 17:07 | |
*** lhcheng has quit IRC | 17:09 | |
*** rajatvig has quit IRC | 17:11 | |
*** jingjing_ren has joined #openstack-horizon | 17:12 | |
*** jingjing_ren has quit IRC | 17:12 | |
*** rajatvig has joined #openstack-horizon | 17:12 | |
*** jingjing_ren has joined #openstack-horizon | 17:13 | |
*** mhorban has quit IRC | 17:16 | |
*** mhorban has joined #openstack-horizon | 17:16 | |
*** david-lyle is now known as cbrown | 17:17 | |
*** stevemar has joined #openstack-horizon | 17:19 | |
*** kyleolivo has joined #openstack-horizon | 17:20 | |
*** neelashah has joined #openstack-horizon | 17:21 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Do not make unnecessary calls to Nova from FIPs and Volumes tabs https://review.openstack.org/213260 | 17:23 |
*** ekarlso has joined #openstack-horizon | 17:25 | |
openstackgerrit | Richard Hagarty proposed openstack/horizon: Added volume type description for volume type https://review.openstack.org/133872 | 17:26 |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Table https://review.openstack.org/199567 | 17:27 |
* ducttape_ welcomes our new charlie brown overloard | 17:27 | |
ducttape_ | cbrown | 17:27 |
*** lapalm has quit IRC | 17:27 | |
ducttape_ | overlord | 17:27 |
ducttape_ | jeez I can't spell | 17:28 |
*** lapalm has joined #openstack-horizon | 17:28 | |
*** radez_g0n3 is now known as radez | 17:28 | |
*** lhcheng_ has joined #openstack-horizon | 17:29 | |
*** tqtran has joined #openstack-horizon | 17:30 | |
*** sayan has joined #openstack-horizon | 17:30 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Disable button 'create snapshot' if share not snapshottable https://review.openstack.org/213242 | 17:32 |
*** jtriley has joined #openstack-horizon | 17:32 | |
*** lapalm has quit IRC | 17:32 | |
*** jwy has joined #openstack-horizon | 17:36 | |
*** tosky has quit IRC | 17:36 | |
*** jtriley has quit IRC | 17:37 | |
*** kmARC has joined #openstack-horizon | 17:39 | |
*** kmARC_ has joined #openstack-horizon | 17:39 | |
*** yamamoto has joined #openstack-horizon | 17:43 | |
*** lhcheng_ has quit IRC | 17:45 | |
*** yamamoto has quit IRC | 17:48 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Context Selection should be to the right https://review.openstack.org/212682 | 17:49 |
*** TravT_ has joined #openstack-horizon | 17:50 | |
*** TravT has quit IRC | 17:50 | |
*** Ephur has joined #openstack-horizon | 17:51 | |
*** ybathia has joined #openstack-horizon | 17:51 | |
*** lyanchih has quit IRC | 17:54 | |
*** lhcheng has joined #openstack-horizon | 17:54 | |
*** Piet has quit IRC | 17:55 | |
*** kmARC has quit IRC | 17:56 | |
*** kmARC_ has quit IRC | 17:56 | |
hurgleburgler | tsufiev : addressed your comments in the Context Selection patch above ^ | 17:57 |
*** kyleolivo has quit IRC | 17:58 | |
ducttape_ | ok, so that looks more better, but still kinda weird | 18:02 |
ducttape_ | just a bit more to the right, not sure why that is or what the orig problem with the orig placement of the menu hurgleburgler | 18:02 |
hurgleburgler | wait | 18:03 |
hurgleburgler | what needs to be a bit more to the right? | 18:03 |
hurgleburgler | There wasn't anything wrong with the original placement … I tried to keep it in the same location, I thought | 18:03 |
hurgleburgler | But, are you using a different logo? | 18:04 |
ducttape_ | this is what it looks like, before and after http://pasteboard.co/2IA1tGSi.png | 18:04 |
*** ybathia has quit IRC | 18:04 | |
*** ybathia has joined #openstack-horizon | 18:04 | |
ducttape_ | see what I mean? | 18:05 |
hurgleburgler | Yeah, different logo | 18:05 |
ducttape_ | no, that logo is the same in both versions tho | 18:05 |
ducttape_ | newer changes have moved the menu over | 18:05 |
ducttape_ | ok, so the placement of the logo is now different b/c it is not a background image | 18:07 |
hurgleburgler | The way the logo works is a bit different | 18:07 |
hurgleburgler | Before, the logo was being set with background-image | 18:07 |
openstackgerrit | Duk Loi proposed openstack/horizon: Updated cassandra database details overview port https://review.openstack.org/213282 | 18:07 |
hurgleburgler | which is a terrible way to do it, because you can't dynamically scale a background-image, it retains the resolution of the image | 18:07 |
hurgleburgler | which means, that if your logo was bigger than your navbar, it would just look wonky | 18:08 |
hurgleburgler | now, its using an <img> tag, which is the right way to have dynamic images inside of your html | 18:08 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - retiring dashboard.scss https://review.openstack.org/209346 | 18:08 |
tqtran | rajatvig: ping ping | 18:08 |
hurgleburgler | NOW, the logo, regardless of the actual image size, resizes itself to fit inside of your navbar, constrained by the navbar height value of your bootstrap variable | 18:08 |
hurgleburgler | So, it might push your context_selection over now, because its of a dynamic width … but that's an easy fix | 18:09 |
tqtran | rajatvig: when you get the chance, could you update https://review.openstack.org/#/c/199345/ ? we only have 9 errors left | 18:10 |
ducttape_ | my logo is not extra wide, it's just big boned | 18:10 |
hurgleburgler | check out | 18:10 |
hurgleburgler | themes/default/horizon/styles.scss | 18:10 |
hurgleburgler | I had to hard code that padding-right in there, to retain the exact same location given the default logo | 18:10 |
hurgleburgler | If you want to tweak it because your logo is big boned, then that's where that tweakage will go | 18:11 |
ducttape_ | thanks hurgleburgler, that helps | 18:11 |
hurgleburgler | Making it an <img> also sets us up to do funner, responsive things with it in the future too :) | 18:12 |
hurgleburgler | np, sorry for any confusion that caused | 18:13 |
*** shivrao has joined #openstack-horizon | 18:13 | |
hurgleburgler | I need to start documenting all of this stuff … and a proper location to document it … maybe I should start making a new wiki page for customizing horizon | 18:13 |
hurgleburgler | or expand on the one that already exists | 18:13 |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 18:14 |
*** kzaitsev_mb has quit IRC | 18:14 | |
rajatvig | tqtran: I just did. I was trying to get it done yesterday but it was failing when I live tested it. | 18:15 |
*** saksham has joined #openstack-horizon | 18:15 | |
rajatvig | tqtran: I kept the same file name for now as then it won't conflict with changes that Travis is proposing as those just delete these files. | 18:15 |
*** Piet has joined #openstack-horizon | 18:16 | |
tqtran | ok, i'll wait for gate to pass it | 18:16 |
*** cody-somerville has quit IRC | 18:17 | |
tqtran | then will talk to TravT_ and see if we can push it through and have the other patch rebase on top of it instead | 18:17 |
ducttape_ | hurgleburgler - you are correct with that change to move the menu over. thanks for the explanation | 18:17 |
rajatvig | also, the remaining eslint errors are all in horizon/static/horizon/js and they are to do with comments. Is anyone working on those? | 18:17 |
cbrown | hurgleburgler: not wiki, horizon/docs | 18:17 |
hurgleburgler | ducttape_ np | 18:17 |
cbrown | that gets published to docs.openstack.org/developer/horizon anyway | 18:18 |
cbrown | more broadly accessible | 18:18 |
hurgleburgler | cbrown Thanks! | 18:18 |
*** lapalm has joined #openstack-horizon | 18:19 | |
*** stevemar has quit IRC | 18:19 | |
ducttape_ | cbrown - https://i.imgflip.com/pjrhs.jpg | 18:21 |
mfisch | dave you look good in that shirt | 18:22 |
*** Sukhdev has quit IRC | 18:22 | |
cbrown | perfect | 18:22 |
ducttape_ | he even looks like dave | 18:22 |
*** cody-somerville has joined #openstack-horizon | 18:24 | |
*** jtriley has joined #openstack-horizon | 18:26 | |
rajatvig | tqtran: for the remaining violations, is there a patch in play or should I create one? | 18:28 |
tqtran | I think your patch might just do the trick, the remaining ones are just warnings | 18:28 |
rajatvig | nice. now we can turn the gate on for lint errors then | 18:31 |
*** mdavid has joined #openstack-horizon | 18:31 | |
*** ephrem has joined #openstack-horizon | 18:36 | |
tqtran | yup thats the idea | 18:38 |
TravT_ | tqtran: how about push that other patch on through | 18:39 |
TravT_ | and rebase this one on that one | 18:39 |
tqtran | i left comments on it, seems like there are a few spec files missing | 18:40 |
tqtran | and it didn't resolve the eslint errors either | 18:40 |
TravT_ | ok, will look at those.... | 18:40 |
TravT_ | but i'd rather rajat doesn't push conflicts at all in an eslint cleanup. | 18:41 |
*** mdavid has quit IRC | 18:41 | |
TravT_ | on that set of files | 18:42 |
*** stevemar has joined #openstack-horizon | 18:42 | |
*** skylerberg has left #openstack-horizon | 18:43 | |
tqtran | im ok with either as long as we fix the eslint in one of those patches | 18:43 |
*** mdavid has joined #openstack-horizon | 18:43 | |
tqtran | we shouldn't be pushing in new patches that arent passing eslint | 18:43 |
TravT_ | i think the eslint is fixed in the child patch. | 18:44 |
TravT_ | let me look | 18:44 |
*** TravT_ is now known as TravT | 18:44 | |
rajatvig | based on what I saw the commits in the dependent deletes one of the controllers and an html that uses it but does't fix the other bits. considering I kept the same name of the file, conflict resolution should be easy if this one merges before. | 18:46 |
rajatvig | I meant one of the dependent patches deletes the controller. | 18:47 |
*** mrunge has quit IRC | 18:53 | |
*** mdavid has quit IRC | 18:56 | |
*** mdavid has joined #openstack-horizon | 18:57 | |
tqtran | r1chardj0n3s or neillc: i found a bug with the translation extraction, you guys want to tackle it? | 18:58 |
*** TravT_ has joined #openstack-horizon | 19:01 | |
*** TravT has quit IRC | 19:01 | |
tqtran | https://bugs.launchpad.net/horizon/+bug/1485084 | 19:02 |
openstack | Launchpad bug 1485084 in OpenStack Dashboard (Horizon) "Babel angular extract fails on newline and inner tags" [High,New] | 19:02 |
gyee | oh pagination, my favorite topic :) | 19:05 |
gyee | where's david-lyle? | 19:06 |
tqtran | gyee: lol i thought we were done talking about it? hahahaha | 19:08 |
gyee | yeah, I though the horse was dead too | 19:09 |
*** ephrem has quit IRC | 19:09 | |
cbrown | gyee: hi | 19:09 |
cbrown | looking for me? | 19:10 |
gyee | cbrown, soo you want pagination? | 19:10 |
*** ephrem has joined #openstack-horizon | 19:10 | |
*** ephrem has quit IRC | 19:10 | |
cbrown | I think not providing is a copout but yeah | 19:10 |
cbrown | I've been living with it | 19:10 |
*** ephrem has joined #openstack-horizon | 19:10 | |
*** ephrem has quit IRC | 19:10 | |
cbrown | less for Horizon more for Searchlight | 19:10 |
cbrown | which in turn would be used by Horizon | 19:11 |
gyee | I completely agree | 19:11 |
*** ephrem has joined #openstack-horizon | 19:11 | |
gyee | I am trying to figure out how to map LDAP pagination | 19:12 |
gyee | but if we are moving away from identity management, then it will be a non-issue | 19:13 |
cbrown | but it's the only interface to the IdP in openstack | 19:13 |
cbrown | so if not keystone who? | 19:13 |
gyee | that's an issue we need to figure out | 19:14 |
gyee | if we don't provide identity, then who | 19:14 |
stevemar | why not just filter? | 19:14 |
stevemar | make the user search for a name / attribute of the user they want to find | 19:14 |
cbrown | stevemar: if I'm building an index to speed up results, how does filtering allow that? | 19:15 |
gyee | stevemar, "API uniformity" | 19:15 |
stevemar | pagination will be nuts if you want to list 400K users | 19:15 |
*** ephrem has quit IRC | 19:15 | |
stevemar | our ldap will blow up | 19:15 |
cbrown | walk aimlessly in the tree via filter won't be super productive | 19:15 |
*** ephrem has joined #openstack-horizon | 19:15 | |
cbrown | stevemar ok, I filter by a then b, then c, then d | 19:16 |
cbrown | can I do that | 19:16 |
cbrown | only as long as I don't more than 500 a's | 19:16 |
*** rajatvig has quit IRC | 19:16 | |
gyee | sure, keep building your filters till you hit something you like :) | 19:16 |
cbrown | the problem is, I like everything | 19:17 |
stevemar | probably need to filter by 'aa', 'ab', 'ac' :P | 19:17 |
cbrown | so I have to dynamically create filters until I hit you magic max return # | 19:17 |
cbrown | *your | 19:17 |
*** rajatvig has joined #openstack-horizon | 19:18 | |
gyee | to me, "API uniformity" is a powerful argument | 19:18 |
cbrown | it's hard, seems like the easy way out | 19:18 |
cbrown | valid, but easy | 19:18 |
gyee | if I am writing an app (like horizon), I don't want different ways to invoke the APIs | 19:18 |
stevemar | its not our magic max return | 19:18 |
stevemar | its the ldap itself, the connection will time out | 19:19 |
cbrown | so there's no way to dump the list of users in ldap? | 19:19 |
* cbrown is dubious | 19:19 | |
gyee | stevemar, convention wisdom is that we should always program to the interface, not an implementation | 19:20 |
gyee | seem like for the case of LDAP, we let the implementation dictate the interface | 19:20 |
gyee | which is bad | 19:20 |
stevemar | cbrown: gyee i still dont understand the point, why do you want to list *all* the users for? | 19:21 |
cbrown | stevemar I want to use searchlight to build an index of all users and projects so I don't have to go through keystone | 19:21 |
gyee | not so much as list all, its list the results | 19:21 |
gyee | how to *consistently* present the result | 19:22 |
stevemar | biab, switching locations | 19:22 |
*** stevemar has quit IRC | 19:22 | |
*** stevemar has joined #openstack-horizon | 19:23 | |
ducttape_ | hurgleburgler - I think you want to update docs with your change https://review.openstack.org/#/c/212682/ | 19:24 |
gyee | fer crying out loud, we have pep8 check for coding standard, but nothing for API standard :) | 19:25 |
hurgleburgler | ducttape_ k | 19:25 |
*** kyleolivo has joined #openstack-horizon | 19:25 | |
*** lapalm has quit IRC | 19:26 | |
ducttape_ | gyee - do you think having heterogenous api formats is new to this room? ;) | 19:26 |
gyee | ducttape_, nah, business as usual | 19:27 |
*** stevemar has quit IRC | 19:28 | |
* ducttape_ haz a sad | 19:28 | |
gyee | just stfu and everything will work itself out | 19:28 |
ducttape_ | that should be the license agreement for using openstack ®™ | 19:29 |
*** kyleolivo has quit IRC | 19:29 | |
gyee | I do remember signing it | 19:30 |
*** stevemar has joined #openstack-horizon | 19:32 | |
*** kmARC has joined #openstack-horizon | 19:49 | |
*** kmARC_ has joined #openstack-horizon | 19:49 | |
*** vijendar has quit IRC | 19:52 | |
*** nlahouti has quit IRC | 19:57 | |
*** stevemar_ has joined #openstack-horizon | 19:58 | |
*** stevemar has quit IRC | 20:00 | |
*** doug-fis_ has joined #openstack-horizon | 20:02 | |
openstackgerrit | Merged openstack/horizon: Use the JP Style Guide for Nova Service https://review.openstack.org/211783 | 20:02 |
openstackgerrit | Duk Loi proposed openstack/horizon: Add support for root enable and show https://review.openstack.org/183196 | 20:04 |
*** alejandrito has quit IRC | 20:04 | |
*** neelashah has quit IRC | 20:04 | |
*** doug-fish has left #openstack-horizon | 20:05 | |
*** petertr7 is now known as petertr7_away | 20:05 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:08 | |
openstackgerrit | Merged openstack/horizon: Move magic_search.js in _scripts.html to after Angular files https://review.openstack.org/212308 | 20:13 |
openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/212995 | 20:14 |
*** kyleolivo has joined #openstack-horizon | 20:15 | |
*** doug-fis_ is now known as doug-fish | 20:16 | |
*** kyleolivo has quit IRC | 20:18 | |
esp | ping doug-fish | 20:18 |
openstackgerrit | Merged openstack/horizon: Add example keystone v3 policy file to horizon https://review.openstack.org/162325 | 20:18 |
doug-fish | esp: thanks! | 20:19 |
esp | np :) | 20:19 |
*** esp has left #openstack-horizon | 20:19 | |
*** esp has joined #openstack-horizon | 20:21 | |
*** mdavid has quit IRC | 20:23 | |
rhagarty__ | ducttape_: ping | 20:23 |
*** ephrem has quit IRC | 20:24 | |
ducttape_ | yo | 20:24 |
ducttape_ | rhagarty__ | 20:25 |
rhagarty__ | ducttape_: remember the discussion at the last horizon mtg about overrides? Was it you who suggested putting the overrides code into _init_.py to avoid issues with handling multiple overrides? | 20:25 |
ducttape_ | yes, did that work / not work ? | 20:25 |
rhagarty__ | it did work, at least for my plug-in. thank you for that | 20:25 |
ducttape_ | sure, hold on a sec | 20:26 |
ducttape_ | I tried to capture that discussion at https://review.openstack.org/#/c/212683/ | 20:26 |
rhagarty__ | ducttape_: well, I know it's not a long term solution, but do you think I should change the manila-ui also? | 20:26 |
ducttape_ | ah, I see you have reviewed it | 20:26 |
* cbrown records this small ducttape_ victory | 20:26 | |
cbrown | rhagarty__: yes ! | 20:26 |
* ducttape_ is done. goes home for another 9 months until the next victory will roll around | 20:26 | |
rhagarty__ | ok, was just wondering if moving a bad idea from overrides to a new location was a good thing | 20:27 |
*** jwy has quit IRC | 20:27 | |
ducttape_ | I see this seems like we have about 10% less bad, and about +5% mo betta. I'll take it | 20:27 |
rhagarty__ | great - I will add a bug and make the fix. thanks | 20:28 |
cbrown | rhagarty__: well, it's python, there is always the opportunity to monkey patch, but overrides.py has an intended purpose and a plugin using it is not it | 20:28 |
ducttape_ | rhagarty__ - It's really up to the plugin to carry as much ugly code as they like. Ideally, this stuff would go into horizon fixes to make other things more extensible | 20:28 |
ducttape_ | but sometimes ya gotta do what ya gotta do | 20:29 |
rhagarty__ | agree with all on this. I think the new docs help clarify this | 20:29 |
*** mrunge has joined #openstack-horizon | 20:31 | |
*** ephrem has joined #openstack-horizon | 20:35 | |
*** crobertsrh is now known as _crobertsrh | 20:37 | |
*** jwy has joined #openstack-horizon | 20:42 | |
tqtran | TravT_: https://review.openstack.org/#/c/199345/ can we push this through? I prefer we do this first and let szymon/sqchen rebase on top of this. | 20:43 |
tqtran | this way we can enable eslint as a voting job and not have to worry | 20:43 |
TravT_ | that's the last eslint thing? | 20:45 |
tqtran | yes | 20:45 |
TravT_ | well, that makes for a stronger argument... | 20:46 |
TravT_ | so, it looks like the conflict doesn't happen until this child patch | 20:48 |
TravT_ | https://review.openstack.org/#/c/184275/ | 20:48 |
*** mdavid has joined #openstack-horizon | 20:48 | |
TravT_ | ok, let me look back through 199345 | 20:48 |
*** bpokorny has quit IRC | 20:49 | |
*** bpokorny has joined #openstack-horizon | 20:50 | |
TravT_ | I'm trying that patch out under devstack now. | 20:55 |
*** nlahouti has joined #openstack-horizon | 20:58 | |
*** kzaitsev_mb has quit IRC | 21:00 | |
*** kzaitsev_mb has joined #openstack-horizon | 21:01 | |
*** stevemar_ has quit IRC | 21:01 | |
*** stevemar has joined #openstack-horizon | 21:02 | |
*** mrunge has quit IRC | 21:03 | |
*** yamamoto has joined #openstack-horizon | 21:06 | |
*** stevemar has quit IRC | 21:06 | |
*** TravT_ is now known as TravT | 21:09 | |
*** gyee has quit IRC | 21:09 | |
*** radez is now known as radez_g0n3 | 21:11 | |
*** yamamoto has quit IRC | 21:11 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services https://review.openstack.org/212838 | 21:14 |
*** ducttape_ has quit IRC | 21:15 | |
*** kyleolivo has joined #openstack-horizon | 21:18 | |
cbrown | cbrown out, have a good weekend everyone | 21:20 |
*** cbrown is now known as david-lyle | 21:20 | |
tqtran | lol | 21:20 |
*** jtriley has quit IRC | 21:22 | |
*** kyleolivo has quit IRC | 21:23 | |
*** jerrygb has joined #openstack-horizon | 21:23 | |
*** vgridnev has quit IRC | 21:26 | |
*** jerrygb has quit IRC | 21:30 | |
*** pauloewerton has quit IRC | 21:30 | |
*** lblanchard has quit IRC | 21:30 | |
*** kmARC has quit IRC | 21:31 | |
*** kmARC_ has quit IRC | 21:31 | |
*** doug-fish has quit IRC | 21:35 | |
*** bpokorny_ has joined #openstack-horizon | 21:39 | |
*** bpokorny has quit IRC | 21:42 | |
*** rajatvig has quit IRC | 21:43 | |
*** vgridnev has joined #openstack-horizon | 21:51 | |
*** rajatvig has joined #openstack-horizon | 21:54 | |
*** kyleolivo has joined #openstack-horizon | 21:56 | |
*** kyleolivo has quit IRC | 21:57 | |
*** kyleolivo has joined #openstack-horizon | 21:58 | |
*** kyleolivo has quit IRC | 22:03 | |
*** kyleolivo has joined #openstack-horizon | 22:03 | |
*** Drago has quit IRC | 22:12 | |
*** kyleolivo has quit IRC | 22:21 | |
*** kyleolivo has joined #openstack-horizon | 22:22 | |
*** stevemar has joined #openstack-horizon | 22:29 | |
*** nlahouti has quit IRC | 22:31 | |
*** stevemar has quit IRC | 22:33 | |
*** lhcheng has quit IRC | 22:33 | |
*** lhcheng has joined #openstack-horizon | 22:35 | |
*** nlahouti has joined #openstack-horizon | 22:37 | |
*** kyleolivo has quit IRC | 22:41 | |
*** TravT_ has joined #openstack-horizon | 22:41 | |
*** kyleolivo has joined #openstack-horizon | 22:43 | |
*** TravT has quit IRC | 22:43 | |
*** ephrem has quit IRC | 22:46 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Moving inline html code out of spec https://review.openstack.org/213367 | 22:48 |
*** sqchen has joined #openstack-horizon | 22:50 | |
sqchen | tqtran: TravT: Hi guys. | 22:51 |
tqtran | hi sqchen | 22:51 |
*** nlahouti has quit IRC | 22:51 | |
sqchen | take a look at this: https://review.openstack.org/#/c/213367/ | 22:51 |
*** stevemar has joined #openstack-horizon | 22:51 | |
sqchen | you might be interested. | 22:52 |
tqtran | question, how is the templatecache storing the template? | 22:53 |
tqtran | ah nvm i see what you did there | 22:54 |
*** nlahouti has joined #openstack-horizon | 22:55 | |
tqtran | very cool, will take a look at it next week. trying to wrap up an i18n bug | 22:55 |
sqchen | yes, it use the current mechanism of loading and caching htnl partials, we can later change the mechanism as you suggested. | 22:56 |
tqtran | so right now, theres no use for external_html? | 22:56 |
sqchen | sure, take your time. :) | 22:57 |
sqchen | this are using external_templates | 22:57 |
sqchen | all the html files are auto-collected by the auto-collecting mechanism. | 22:58 |
sqchen | The patch works for the refactored spec. | 22:59 |
tqtran | i dont think the html files are auto-collected sean :P | 23:00 |
tqtran | only the JS files are, the html files are accessible only because they are inside of a static folder | 23:01 |
sqchen | the name of the html files are auto-collected. | 23:01 |
tqtran | can you show me this in code? i dont see it | 23:02 |
sqchen | I was not very acurate | 23:02 |
sqchen | ok | 23:02 |
sqchen | let me find the code... | 23:02 |
sqchen | https://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L96 | 23:03 |
sqchen | and https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/jasmine/jasmine.html#L60-L76 | 23:07 |
*** jingjing_ren has quit IRC | 23:09 | |
sqchen | you can print the markup variable in the spec.js file by using console.log, they has the same value as they have when it is written inline. | 23:09 |
*** vgridnev has quit IRC | 23:10 | |
*** kyleolivo has quit IRC | 23:12 | |
openstackgerrit | Merged openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 23:12 |
*** TravT has joined #openstack-horizon | 23:17 | |
tqtran | i see i see | 23:19 |
tqtran | but thats not auto-discovery right? | 23:20 |
tqtran | you have to add files manually to the external_templates list? | 23:20 |
*** TravT_ has quit IRC | 23:20 | |
*** lhcheng has quit IRC | 23:22 | |
sqchen | you do not need to add them manually. the patch does’t include any code like that. The html file/s names are auto-collected into external-templates, and in Jasmine.html, they are cached into the templatechche serivice. all the mechanism already exists. | 23:25 |
*** ybathia has quit IRC | 23:25 | |
*** kzaitsev_mb has quit IRC | 23:29 | |
*** julim has quit IRC | 23:30 | |
openstackgerrit | Merged openstack/horizon: Updating docs for customization https://review.openstack.org/212683 | 23:32 |
*** jingjing_ren has joined #openstack-horizon | 23:39 | |
*** hurgleburgler has quit IRC | 23:42 | |
*** jingjing_ren has quit IRC | 23:44 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Moving inline html code out of spec https://review.openstack.org/213367 | 23:45 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Moving inline html code out of transfer-table.spec.js https://review.openstack.org/213367 | 23:46 |
tqtran | sqchen: ok :P i understand that mechanism exist, but i dont think we're auto collecting html files are we? | 23:50 |
tqtran | i know we're auto collecting js, but not sure we are doing the same for html and scss? | 23:50 |
openstackgerrit | Travis Tripp proposed openstack/horizon: Refactor angular cloud services utilities https://review.openstack.org/179516 | 23:50 |
sqchen | we are auto-collecting html file names, just as we do for JS file names. We do not manually add html file names to the external_templates, the html file names are auto-collected into external_templates array. We don’t need to do auto-collecting for scss files, all scss files are manully add into their parent scss files by using @imprt directive. | 23:54 |
*** kzaitsev_mb has joined #openstack-horizon | 23:55 | |
*** eroussel has joined #openstack-horizon | 23:56 | |
sqchen | we auto-collect both js and html files. | 23:56 |
*** stevemar has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!