| sqchen | auto-collect mechanism doen’t change the way Django use to find static files, it just give a list and file names to _script.html to populate them. | 00:00 |
|---|---|---|
| david-lyle | sqchen: yes, I understand | 00:01 |
| david-lyle | I've put it in openstack_dashboard/contrib/sahara/content/data_processing/static | 00:02 |
| david-lyle | so openstack_dashboard is already an app | 00:02 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP Adding actions to angular images panel https://review.openstack.org/217422 | 00:02 |
| david-lyle | I also tried adding the subtree as an app | 00:02 |
| david-lyle | but that doesn't make sense | 00:03 |
| david-lyle | just trying things | 00:03 |
| david-lyle | no, it is necessary | 00:04 |
| david-lyle | pure plugin model changed that | 00:04 |
| david-lyle | but still doesn't work | 00:04 |
| *** rajatvig has quit IRC | 00:05 | |
| sqchen | A staic folder directly under a Django application module is considered a Djanog static folder. | 00:05 |
| david-lyle | right so it should be collected | 00:05 |
| david-lyle | not so much though | 00:06 |
| *** ybathia has quit IRC | 00:06 | |
| sqchen | but, you put the static foler somewhere deep in openstack_dashboard/contrib/sahara/content/data_processing/, it is not consider a staic folder any more. | 00:07 |
| sqchen | though you name it static. | 00:08 |
| david-lyle | I might be an idiot | 00:08 |
| sqchen | only openstack_dashboard/static/ is the static folder for openstack_dashboard application. | 00:08 |
| david-lyle | well I am | 00:08 |
| *** jwy has joined #openstack-horizon | 00:09 | |
| david-lyle | ok it's working | 00:09 |
| sqchen | packages under openstack_dashboard/dashboards/ are also installed as Django applications, I think. | 00:10 |
| david-lyle | sqchen: thanks for your help, I had a mismatched path in my series of changes | 00:10 |
| david-lyle | by the enabled files yes | 00:10 |
| david-lyle | so settings project and admin | 00:10 |
| david-lyle | and now contrib/sahara/content/data_processing | 00:11 |
| david-lyle | rolls off the tongue | 00:11 |
| sqchen | hehe | 00:11 |
| david-lyle | dare I try autodiscovery? | 00:11 |
| david-lyle | I actually think it's unwarranted in this case | 00:12 |
| david-lyle | since it may move and is one file | 00:12 |
| david-lyle | I appreciate your help sqchen | 00:12 |
| sqchen | I think in you case, you can ignore the new auto-collecting mechanism. | 00:12 |
| david-lyle | long day and easily frustrated | 00:12 |
| sqchen | np. :) | 00:12 |
| david-lyle | me too | 00:13 |
| david-lyle | about no auto-collect | 00:13 |
| *** mtanino_ has quit IRC | 00:13 | |
| sqchen | sorry for so many typo, btw. :) | 00:14 |
| david-lyle | I'm not doing any better ;) | 00:14 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Misc Python 3 fixes in horizon https://review.openstack.org/217444 | 00:15 |
| *** sqchen has left #openstack-horizon | 00:18 | |
| openstackgerrit | David Lyle proposed openstack/horizon: [Sahara] Add support for event logs https://review.openstack.org/158715 | 00:24 |
| *** cloudtrainme has joined #openstack-horizon | 00:29 | |
| *** jbell8 has joined #openstack-horizon | 00:30 | |
| *** shivrao has quit IRC | 00:30 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Richard messes with Selenium https://review.openstack.org/217448 | 00:41 |
| *** asd112z has joined #openstack-horizon | 00:41 | |
| r1chardj0n3s | david-lyle: that change ^^ includes some debugging to dump the environment out to confirm it's what we expect, and also includes an explicit FAIL in one of the selenium tests | 00:47 |
| david-lyle | ok, I context-switched to some tasks I've been trying to finish | 00:48 |
| *** lblanchard has joined #openstack-horizon | 00:56 | |
| *** cloudtrainme has quit IRC | 01:01 | |
| *** saksham has quit IRC | 01:02 | |
| r1chardj0n3s | david-lyle: yep, no worries, I'll keep banging away at this until something falls out :) | 01:02 |
| *** liangbo has joined #openstack-horizon | 01:04 | |
| *** zhenguo has joined #openstack-horizon | 01:05 | |
| *** yamamoto has joined #openstack-horizon | 01:06 | |
| *** garthb_ has quit IRC | 01:07 | |
| *** KunalGandhi has quit IRC | 01:08 | |
| *** dsneddon is now known as dsneddon_away | 01:12 | |
| *** jpomeroy has quit IRC | 01:15 | |
| *** ducttape_ has joined #openstack-horizon | 01:19 | |
| *** jtriley has joined #openstack-horizon | 01:19 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Allowing job binaries to be edited https://review.openstack.org/197204 | 01:21 |
| *** yamamoto has quit IRC | 01:22 | |
| *** ianbrown has joined #openstack-horizon | 01:23 | |
| *** yamamoto has joined #openstack-horizon | 01:24 | |
| *** ducttape_ has quit IRC | 01:25 | |
| *** jcoufal has joined #openstack-horizon | 01:25 | |
| *** yamamoto has quit IRC | 01:28 | |
| *** zhurong has joined #openstack-horizon | 01:28 | |
| *** jcoufal has quit IRC | 01:29 | |
| *** Daisy has joined #openstack-horizon | 01:29 | |
| *** Daisy has quit IRC | 01:31 | |
| *** Daisy has joined #openstack-horizon | 01:31 | |
| david-lyle | kfox1111: you have your votes from me | 01:31 |
| * david-lyle is walking away now | 01:31 | |
| *** doug-fish has joined #openstack-horizon | 01:31 | |
| david-lyle | good night everyone | 01:31 |
| tqtran | gnite | 01:32 |
| tqtran | taking off as well, kfox1111 you're good to go | 01:32 |
| *** jpomeroy has joined #openstack-horizon | 01:34 | |
| *** Daisy has quit IRC | 01:34 | |
| *** Daisy has joined #openstack-horizon | 01:34 | |
| *** tqtran has quit IRC | 01:35 | |
| *** btully has quit IRC | 01:35 | |
| *** kzaitsev_mb has quit IRC | 01:35 | |
| *** doug-fish has quit IRC | 01:36 | |
| r1chardj0n3s | night david-lyle & tq | 01:36 |
| r1chardj0n3s | hmm | 01:36 |
| r1chardj0n3s | so horizon's setup.cfg sets nosetest verbosity to 2, but when you run tests there's a --verbosity=1 but I can't find where that's coming from... | 01:36 |
| *** Daisy has quit IRC | 01:39 | |
| r1chardj0n3s | oh! django/core/management/commands/test.py :/ | 01:39 |
| *** Daisy has joined #openstack-horizon | 01:40 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Richard messes with Selenium https://review.openstack.org/217448 | 01:42 |
| *** kzaitsev_mb has joined #openstack-horizon | 01:43 | |
| *** Daisy has quit IRC | 01:44 | |
| *** lawrance_ has joined #openstack-horizon | 01:45 | |
| *** Daisy has joined #openstack-horizon | 01:45 | |
| *** cloudtrainme has joined #openstack-horizon | 01:48 | |
| *** lblanchard has quit IRC | 01:50 | |
| *** Daisy has quit IRC | 01:50 | |
| *** Daisy has joined #openstack-horizon | 01:51 | |
| *** doug-fish has joined #openstack-horizon | 01:52 | |
| *** lhcheng has quit IRC | 01:53 | |
| *** Daisy has quit IRC | 01:55 | |
| *** doug-fish has quit IRC | 01:56 | |
| *** lhcheng has joined #openstack-horizon | 01:56 | |
| *** kzaitsev_mb has quit IRC | 01:56 | |
| *** lhcheng has quit IRC | 01:57 | |
| *** Daisy has joined #openstack-horizon | 01:57 | |
| *** lhcheng has joined #openstack-horizon | 01:57 | |
| *** cloudtrainme has quit IRC | 01:58 | |
| *** lhcheng has quit IRC | 01:59 | |
| openstackgerrit | Allen proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 01:59 |
| *** btully has joined #openstack-horizon | 02:00 | |
| *** Daisy_ has joined #openstack-horizon | 02:00 | |
| *** lawrance_ has quit IRC | 02:01 | |
| *** Daisy_ has quit IRC | 02:02 | |
| *** arxcruz has quit IRC | 02:02 | |
| *** Daisy has quit IRC | 02:02 | |
| *** Daisy_ has joined #openstack-horizon | 02:02 | |
| *** Daisy has joined #openstack-horizon | 02:03 | |
| *** Daisy_ has quit IRC | 02:03 | |
| *** btully has quit IRC | 02:04 | |
| *** Drago has quit IRC | 02:05 | |
| *** cloudtrainme has joined #openstack-horizon | 02:06 | |
| *** Daisy has quit IRC | 02:06 | |
| *** Daisy has joined #openstack-horizon | 02:06 | |
| *** btully has joined #openstack-horizon | 02:06 | |
| *** Daisy has quit IRC | 02:06 | |
| *** Daisy has joined #openstack-horizon | 02:06 | |
| *** zhurong has quit IRC | 02:07 | |
| *** lhcheng has joined #openstack-horizon | 02:09 | |
| *** yamamoto has joined #openstack-horizon | 02:10 | |
| *** zhurong has joined #openstack-horizon | 02:16 | |
| *** lyanchih has joined #openstack-horizon | 02:16 | |
| *** zhurong has quit IRC | 02:16 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Richard messes with Selenium https://review.openstack.org/217448 | 02:18 |
| *** zhurong has joined #openstack-horizon | 02:20 | |
| *** KunalGandhi has joined #openstack-horizon | 02:28 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Richard messes with Selenium https://review.openstack.org/217448 | 02:30 |
| *** KunalGandhi has quit IRC | 02:33 | |
| *** KunalGandhi has joined #openstack-horizon | 02:34 | |
| *** shivrao has joined #openstack-horizon | 02:39 | |
| *** shivrao has quit IRC | 02:44 | |
| *** jtriley has quit IRC | 02:44 | |
| *** jwy has quit IRC | 02:48 | |
| *** asd112z has quit IRC | 02:50 | |
| *** jingjing_ren has quit IRC | 02:55 | |
| *** lawrance_ has joined #openstack-horizon | 02:59 | |
| *** TravT has quit IRC | 03:10 | |
| *** Daisy has quit IRC | 03:10 | |
| *** TravT has joined #openstack-horizon | 03:10 | |
| *** Daisy has joined #openstack-horizon | 03:11 | |
| *** Daisy has quit IRC | 03:15 | |
| *** lhcheng has quit IRC | 03:17 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Richard messes with Selenium https://review.openstack.org/217448 | 03:17 |
| openstackgerrit | Allen proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 03:18 |
| *** esp has left #openstack-horizon | 03:20 | |
| *** ianbrown has quit IRC | 03:20 | |
| openstackgerrit | Allen proposed openstack/horizon: Implementation inline table editing for Networks https://review.openstack.org/209850 | 03:21 |
| *** esp has joined #openstack-horizon | 03:22 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Richard messes with Selenium https://review.openstack.org/217448 | 03:26 |
| *** Daisy has joined #openstack-horizon | 03:27 | |
| *** SimonChung has joined #openstack-horizon | 03:30 | |
| esp | nice one r1chardj0n3s :) | 03:30 |
| *** vgridnev has joined #openstack-horizon | 03:30 | |
| r1chardj0n3s | esp: trying out all manner of things to figure out why the selenium tests appear to just be ignored in the gate | 03:30 |
| esp | oh man… | 03:31 |
| *** SimonChung1 has joined #openstack-horizon | 03:31 | |
| esp | I thought majority of them were disabled on purpose but maybe I got it wrong | 03:31 |
| *** Daisy has quit IRC | 03:32 | |
| r1chardj0n3s | nope, not disabled. they just aren't being run, and everyone just assumed someone had disabled them ;) | 03:32 |
| esp | gotcha | 03:32 |
| *** Daisy has joined #openstack-horizon | 03:33 | |
| *** linkedinyou has quit IRC | 03:33 | |
| r1chardj0n3s | oooh, I might have figured it out, finally | 03:34 |
| *** SimonChung has quit IRC | 03:34 | |
| r1chardj0n3s | next step: git blame ;) | 03:34 |
| esp | lol | 03:35 |
| r1chardj0n3s | (that's not really the next step) | 03:35 |
| esp | is the version of the firefox plugin? | 03:35 |
| esp | *is it | 03:35 |
| r1chardj0n3s | I think it might be that the tests aren't being run headless | 03:35 |
| *** lhcheng has joined #openstack-horizon | 03:35 | |
| * esp man my english gets worse by the day | 03:35 | |
| r1chardj0n3s | \o/ I got the tests running | 03:36 |
| *** vgridnev has quit IRC | 03:36 | |
| esp | that was fast | 03:36 |
| r1chardj0n3s | so, at some point someone added the --selenium-headless switch, and forgot to tell the gate job | 03:36 |
| r1chardj0n3s | um | 03:36 |
| r1chardj0n3s | I've been trying to crack this nut since 7am :P | 03:37 |
| *** Daisy has quit IRC | 03:37 | |
| esp | good find | 03:37 |
| r1chardj0n3s | yep, so mid last year? is about when people thought the selenium tests were "disabled"? | 03:38 |
| r1chardj0n3s | hmm | 03:40 |
| *** lhcheng_ has joined #openstack-horizon | 03:40 | |
| r1chardj0n3s | except the gate job *appears* to already be configured to use xvfb, but clearly it's not working | 03:40 |
| *** lhcheng has quit IRC | 03:42 | |
| *** vgridnev has joined #openstack-horizon | 03:44 | |
| *** Daisy has joined #openstack-horizon | 03:44 | |
| *** dsneddon_away has quit IRC | 03:48 | |
| *** Daisy has quit IRC | 03:48 | |
| *** Daisy has joined #openstack-horizon | 03:50 | |
| *** Daisy has quit IRC | 03:54 | |
| *** Daisy has joined #openstack-horizon | 03:55 | |
| *** Daisy has quit IRC | 04:00 | |
| *** dsneddon_away has joined #openstack-horizon | 04:00 | |
| *** Daisy has joined #openstack-horizon | 04:01 | |
| *** jamielennox is now known as jamielennox|away | 04:04 | |
| *** jamielennox|away is now known as jamielennox | 04:05 | |
| *** Daisy has quit IRC | 04:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/217146 | 04:13 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/217149 | 04:14 |
| *** Daisy has joined #openstack-horizon | 04:17 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Add support for event logs https://review.openstack.org/158715 | 04:18 |
| vgridnev | david-lyle, change https://review.openstack.org/#/c/158715/25 was verified, (right now I'm support Nikita's changes) | 04:21 |
| *** Daisy has quit IRC | 04:22 | |
| *** Daisy has joined #openstack-horizon | 04:29 | |
| *** Daisy has quit IRC | 04:33 | |
| *** shivrao has joined #openstack-horizon | 04:37 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Richard messes with Selenium https://review.openstack.org/217448 | 04:37 |
| *** yamamoto has quit IRC | 04:40 | |
| r1chardj0n3s | david-lyle: related to getting selenium tests working again, I've proposed https://review.openstack.org/#/c/217509/ which removes the current (not working) selenium gate job and replaces it with something that (should, tested) work but will be experimental until confirmed | 04:40 |
| *** Daisy has joined #openstack-horizon | 04:45 | |
| *** shivrao has quit IRC | 04:46 | |
| *** shivrao has joined #openstack-horizon | 04:47 | |
| *** Daisy has quit IRC | 04:50 | |
| *** Daisy has joined #openstack-horizon | 04:57 | |
| *** KingKhan has joined #openstack-horizon | 05:00 | |
| *** Daisy has quit IRC | 05:01 | |
| *** lyanchih has quit IRC | 05:05 | |
| *** yamamoto has joined #openstack-horizon | 05:05 | |
| *** TravT has quit IRC | 05:06 | |
| *** liangbo has quit IRC | 05:07 | |
| *** TravT has joined #openstack-horizon | 05:08 | |
| *** TravT has quit IRC | 05:09 | |
| *** TravT has joined #openstack-horizon | 05:11 | |
| *** Daisy has joined #openstack-horizon | 05:13 | |
| *** openstackgerrit has quit IRC | 05:16 | |
| *** openstackgerrit has joined #openstack-horizon | 05:17 | |
| *** Daisy has quit IRC | 05:17 | |
| *** ankit_ag has joined #openstack-horizon | 05:24 | |
| *** Daisy has joined #openstack-horizon | 05:25 | |
| *** liangbo has joined #openstack-horizon | 05:27 | |
| *** Daisy has quit IRC | 05:29 | |
| *** albertom has quit IRC | 05:29 | |
| *** albertom has joined #openstack-horizon | 05:31 | |
| *** Daisy has joined #openstack-horizon | 05:41 | |
| *** rdopiera has joined #openstack-horizon | 05:44 | |
| *** Daisy has quit IRC | 05:45 | |
| *** Daisy has joined #openstack-horizon | 05:48 | |
| *** shivrao has quit IRC | 05:58 | |
| *** lyanchih has joined #openstack-horizon | 06:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/217532 | 06:07 |
| *** ttrifonov is now known as zz_ttrifonov | 06:07 | |
| *** KunalGandhi has quit IRC | 06:07 | |
| *** Daisy has quit IRC | 06:10 | |
| *** Daisy has joined #openstack-horizon | 06:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/217533 | 06:14 |
| *** Daisy has quit IRC | 06:15 | |
| *** btully has quit IRC | 06:16 | |
| *** mrunge has joined #openstack-horizon | 06:19 | |
| *** Daisy has joined #openstack-horizon | 06:22 | |
| *** linkedinyou has joined #openstack-horizon | 06:25 | |
| *** Daisy has quit IRC | 06:27 | |
| *** Daisy has joined #openstack-horizon | 06:27 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Support autoconfiguration for templates https://review.openstack.org/207399 | 06:31 |
| *** peristeri has joined #openstack-horizon | 06:32 | |
| *** albertom has quit IRC | 06:34 | |
| *** mflobo has joined #openstack-horizon | 06:38 | |
| *** albertom has joined #openstack-horizon | 06:40 | |
| *** vgridnev has quit IRC | 06:45 | |
| *** btully has joined #openstack-horizon | 06:47 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 06:51 |
| *** doug-fish has joined #openstack-horizon | 06:56 | |
| *** markus_z has joined #openstack-horizon | 07:00 | |
| *** doug-fish has quit IRC | 07:01 | |
| mflobo | Morning everyone | 07:03 |
| *** KunalGandhi has joined #openstack-horizon | 07:03 | |
| mflobo | question, I want to add an extra validation to the new Launch Instance (AngularJS) panel. The extra validation is for instance-name https://github.com/openstack/horizon/blob/stable/kilo/openstack_dashboard/static/dashboard/launch-instance/source/source.html#L22 | 07:04 |
| *** Daisy has quit IRC | 07:04 | |
| mflobo | where should I add the new validation function?. With "where" I mean the JS file | 07:05 |
| mflobo | thanks | 07:05 |
| *** Daisy has joined #openstack-horizon | 07:05 | |
| *** markus_z has quit IRC | 07:07 | |
| *** Daisy has quit IRC | 07:08 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 07:09 |
| *** KunalGandhi has quit IRC | 07:09 | |
| *** Daisy has joined #openstack-horizon | 07:09 | |
| *** Daisy has quit IRC | 07:13 | |
| *** e0ne has joined #openstack-horizon | 07:18 | |
| *** Daisy has joined #openstack-horizon | 07:25 | |
| *** vgridnev has joined #openstack-horizon | 07:28 | |
| *** dulek has joined #openstack-horizon | 07:28 | |
| *** Daisy has quit IRC | 07:30 | |
| *** KingKhan has quit IRC | 07:33 | |
| *** Daisy has joined #openstack-horizon | 07:36 | |
| *** wimdc has joined #openstack-horizon | 07:39 | |
| *** Daisy has quit IRC | 07:40 | |
| *** Daisy has joined #openstack-horizon | 07:42 | |
| *** KingKhan has joined #openstack-horizon | 07:44 | |
| *** Daisy has quit IRC | 07:46 | |
| *** Daisy has joined #openstack-horizon | 07:47 | |
| *** mpavlase has joined #openstack-horizon | 07:51 | |
| *** Daisy has quit IRC | 07:52 | |
| *** fedexo has joined #openstack-horizon | 07:52 | |
| *** lhcheng has joined #openstack-horizon | 07:59 | |
| *** e0ne has quit IRC | 08:01 | |
| *** lhcheng_ has quit IRC | 08:03 | |
| *** Daisy has joined #openstack-horizon | 08:04 | |
| *** Ala has joined #openstack-horizon | 08:07 | |
| *** Daisy has quit IRC | 08:08 | |
| *** Daisy has joined #openstack-horizon | 08:08 | |
| *** Daisy has quit IRC | 08:09 | |
| *** Daisy has joined #openstack-horizon | 08:10 | |
| *** fedexo has quit IRC | 08:10 | |
| zigo | Hi. In Sid, I now have Horizon doing: compile() got an unexpected keyword argument 'relative_to' | 08:10 |
| *** ygbo has joined #openstack-horizon | 08:10 | |
| zigo | What's doing this? | 08:11 |
| *** kiran-r has joined #openstack-horizon | 08:11 | |
| mrunge | zigo, do you have a bit more logs? | 08:12 |
| zigo | Hi there! Sure... | 08:13 |
| zigo | mrunge: http://paste.debian.net/306917/ | 08:13 |
| *** tosky has joined #openstack-horizon | 08:13 | |
| zigo | That's probably a Django 1.8 issue. | 08:13 |
| zigo | Ah no. | 08:13 |
| zigo | I still got 1.7.9 | 08:13 |
| *** Daisy has quit IRC | 08:14 | |
| mrunge | which version of python-django-pyscss and pyScss do you have? | 08:14 |
| zigo | mrunge: 1.0.3 | 08:14 |
| mrunge | of python-django-pyscss? | 08:14 |
| zigo | Yup. | 08:15 |
| zigo | 1.3.4 for python-pyscss | 08:15 |
| mrunge | and pyScss? | 08:15 |
| mrunge | ugh, really? | 08:15 |
| mrunge | https://github.com/openstack/horizon/blob/stable/kilo/requirements.txt | 08:16 |
| mrunge | your pyScss is too new | 08:16 |
| mrunge | but: I debugged that yesterday, there is a patch | 08:16 |
| mrunge | let me look that up | 08:16 |
| zigo | Ok, after downgrading it to what's in Jessie, now I get: http://paste.debian.net/306918/ | 08:17 |
| mrunge | yupp, already seen that too | 08:17 |
| zigo | Which was reported to the Debian BTS... :/ | 08:17 |
| *** MaxV has joined #openstack-horizon | 08:17 | |
| mrunge | zigo, you should pull in this patch: https://github.com/redhat-openstack/horizon/commit/c398152d22eefe1bb21c5ef7a800da2f0cfc21fb | 08:19 |
| zigo | Ah, cool ! :) | 08:19 |
| zigo | Thanks. | 08:19 |
| zigo | mrunge: Will this solve both issues? | 08:19 |
| mrunge | this is upstream as well | 08:19 |
| mrunge | zigo, I got latest kilo to compress with pyScss 1.3.4 and later python-django-pyscss | 08:19 |
| mrunge | (my python-django-pyscss is 2.0.2) | 08:20 |
| mrunge | zigo, btw, 2015.1.1 is already released, there are a few interesting fixes contained | 08:20 |
| zigo | python-django-pyscss is currently in Debian Experimental only, but I can upload it to Sid if I can fix Horizon to use it. | 08:20 |
| *** Daisy has joined #openstack-horizon | 08:21 | |
| mrunge | I would guess, your python-django-pyscss is too old for your version of pyScss | 08:21 |
| mrunge | python-django-pyscss is a bit picky | 08:21 |
| zigo | I'll try with the latest one in Experimental. Thanks so much! | 08:23 |
| mrunge | you're welcome | 08:23 |
| *** Daisy has quit IRC | 08:25 | |
| *** bluex-pl has joined #openstack-horizon | 08:28 | |
| *** Daisy has joined #openstack-horizon | 08:30 | |
| zigo | mrunge: It seems like this fixed everything, but now I have another issue with libjs-magic-search. I should be able to fix that one rather easily. | 08:31 |
| *** Daisy_ has joined #openstack-horizon | 08:31 | |
| mrunge | zigo, great | 08:31 |
| zigo | Hum... | 08:31 |
| *** Daisy__ has joined #openstack-horizon | 08:32 | |
| zigo | Oh, there's no magic_search.scss in my system. This should be the issue. | 08:33 |
| mrunge | ah yes, I seem to remmeber that | 08:33 |
| mrunge | I think it's an upstream packaging issue | 08:34 |
| mrunge | it might be fixed in a later version of maigc-search | 08:34 |
| *** Daisy has quit IRC | 08:34 | |
| *** sayan has quit IRC | 08:35 | |
| * zigo is the package maintainer for libjs-magic-search in Debian and can fix that. | 08:36 | |
| *** Daisy_ has quit IRC | 08:36 | |
| zigo | YEAH FIXED !!! \o/ :) | 08:36 |
| *** Daisy__ has quit IRC | 08:37 | |
| zigo | mrunge: Thanks again. | 08:37 |
| *** Daisy has joined #openstack-horizon | 08:37 | |
| mrunge | :D | 08:37 |
| zigo | mrunge: My Horizon in Sid is version 2015.1.0+2015.06.09.git15.e63af6c598, so last upstram commit from 9th of June. Is there any fix which would be a good enough reason to upgrade to latest commit? | 08:38 |
| mrunge | zigo is there a reason not to take 2015.1.1 ? | 08:39 |
| zigo | Well, not sure if it breaks something! :) | 08:39 |
| mrunge | it should not | 08:39 |
| *** KingKhan has quit IRC | 08:40 | |
| mrunge | zigo your last commit is from tsufiev (Fix Create User form's fields...)? | 08:40 |
| mrunge | that was merged upstream on Jul 14th | 08:41 |
| mrunge | zigo: in short: you should cherry pick more fixes | 08:41 |
| mrunge | there are quite a few you really want | 08:41 |
| zigo | Ok. | 08:41 |
| zigo | Will do. | 08:41 |
| *** KingKhan has joined #openstack-horizon | 08:43 | |
| *** Daisy has quit IRC | 08:44 | |
| *** lhcheng has quit IRC | 08:44 | |
| *** Daisy has joined #openstack-horizon | 08:44 | |
| r1chardj0n3s | david-lyle: that experimental job merged and has been tested successfully by my test patch \o/ going to check it against the in-flight selenium fix patches too | 08:45 |
| *** Daisy has quit IRC | 08:49 | |
| *** mpavlase has quit IRC | 08:50 | |
| *** Daisy has joined #openstack-horizon | 08:50 | |
| *** Daisy has quit IRC | 08:53 | |
| *** Daisy has joined #openstack-horizon | 08:53 | |
| *** Daisy has quit IRC | 08:56 | |
| *** Daisy has joined #openstack-horizon | 08:56 | |
| *** Daisy has quit IRC | 08:58 | |
| *** MaxV has quit IRC | 08:58 | |
| *** Daisy has joined #openstack-horizon | 08:58 | |
| *** Daisy has quit IRC | 08:59 | |
| *** Daisy has joined #openstack-horizon | 08:59 | |
| *** e0ne has joined #openstack-horizon | 08:59 | |
| *** wuhg has joined #openstack-horizon | 09:00 | |
| *** akrivoka has joined #openstack-horizon | 09:01 | |
| *** Daisy has quit IRC | 09:02 | |
| *** Daisy has joined #openstack-horizon | 09:03 | |
| *** lyanchih has quit IRC | 09:03 | |
| robcresswell | r1chardj0n3s: Richard messes with Selenium | 09:06 |
| robcresswell | +2 | 09:06 |
| *** zhurong has quit IRC | 09:06 | |
| *** Daisy has quit IRC | 09:07 | |
| *** Daisy has joined #openstack-horizon | 09:08 | |
| *** lyanchih has joined #openstack-horizon | 09:12 | |
| *** Daisy has quit IRC | 09:13 | |
| *** Daisy has joined #openstack-horizon | 09:14 | |
| *** Daisy has quit IRC | 09:18 | |
| *** Daisy has joined #openstack-horizon | 09:19 | |
| *** ShivsharanRahul has joined #openstack-horizon | 09:21 | |
| tsufiev | r1chardj0n3s, so the main different with the existing selenium job is that the new one is headless and thus runs faster? | 09:21 |
| tsufiev | *difference | 09:22 |
| *** Daisy has quit IRC | 09:23 | |
| openstackgerrit | Merged openstack/horizon: Move i18n to HTML for launch-instance source step https://review.openstack.org/216230 | 09:23 |
| robcresswell | Wow that patch took like 15 hours in the gate | 09:25 |
| *** Daisy has joined #openstack-horizon | 09:25 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:27 | |
| *** kiran-r has quit IRC | 09:27 | |
| *** lawrance_ has quit IRC | 09:28 | |
| *** sayan has joined #openstack-horizon | 09:29 | |
| tsufiev | robcresswell, the integrated queue at zuul's gate looks strange | 09:29 |
| *** Daisy has quit IRC | 09:29 | |
| tsufiev | I wonder whether it should have so many patches from different projects tied together | 09:29 |
| robcresswell | tsufiev: I've not really looked into how it functions | 09:34 |
| robcresswell | So slow this time of the cycle though | 09:34 |
| robcresswell | What they need is some kind of cloud deployment that could scale better as demand goes up... anyone know of any software? :) | 09:34 |
| openstackgerrit | Doug Fish proposed openstack/horizon: Put back fixed Sahara integration tests https://review.openstack.org/215127 | 09:34 |
| *** Daisy has joined #openstack-horizon | 09:35 | |
| *** Drago has joined #openstack-horizon | 09:36 | |
| *** Drago has quit IRC | 09:36 | |
| *** Drago has joined #openstack-horizon | 09:36 | |
| *** Daisy_ has joined #openstack-horizon | 09:38 | |
| *** Daisy_ has quit IRC | 09:38 | |
| *** Daisy_ has joined #openstack-horizon | 09:38 | |
| *** lhcheng has joined #openstack-horizon | 09:39 | |
| *** Daisy_ has joined #openstack-horizon | 09:39 | |
| *** liangbo has quit IRC | 09:39 | |
| *** Daisy has quit IRC | 09:40 | |
| *** Daisy_ has quit IRC | 09:44 | |
| *** Daisy has joined #openstack-horizon | 09:45 | |
| *** Daisy has quit IRC | 09:49 | |
| *** akrivoka has quit IRC | 09:53 | |
| *** akrivoka has joined #openstack-horizon | 09:53 | |
| *** btully has quit IRC | 09:54 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/217532 | 10:01 |
| *** lyanchih has quit IRC | 10:04 | |
| *** lhcheng has quit IRC | 10:07 | |
| *** kzaitsev_mb has quit IRC | 10:07 | |
| *** eandersson has joined #openstack-horizon | 10:10 | |
| *** zhenguo has quit IRC | 10:10 | |
| openstackgerrit | Brad Pokorny proposed openstack/horizon: (WIP) Choose a server group when booting a VM https://review.openstack.org/217617 | 10:14 |
| *** wimdc has quit IRC | 10:27 | |
| *** KingKhan has quit IRC | 10:27 | |
| *** KingKhan has joined #openstack-horizon | 10:27 | |
| *** lawrance_ has joined #openstack-horizon | 10:30 | |
| *** liangbo has joined #openstack-horizon | 10:33 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/217146 | 10:34 |
| *** kiran-r has joined #openstack-horizon | 10:40 | |
| ^Gal^ | Hi guys, I have an Horizon table question. I've added a row button which should exclusively make an API call, and that only . I don't need any modals nor views. | 10:41 |
| ^Gal^ | I figured that probably I should use a "LinkAction" but that navigates to a URL and utilizing some view mechanism what I don't need. If I understand correctly Django forces me to use a view. | 10:41 |
| ^Gal^ | I'm not sure how to implement my code as I don't want any redirects or screen changes making the call.. | 10:41 |
| *** sayan has quit IRC | 10:48 | |
| *** sayan has joined #openstack-horizon | 10:48 | |
| *** KingKhan has quit IRC | 10:51 | |
| *** KingKhan has joined #openstack-horizon | 10:55 | |
| *** yamamoto has quit IRC | 10:56 | |
| *** KingKhan has quit IRC | 10:56 | |
| *** aix has quit IRC | 11:02 | |
| *** ShivsharanRahul has quit IRC | 11:03 | |
| *** ShivsharanRahul has joined #openstack-horizon | 11:05 | |
| *** lyanchih has joined #openstack-horizon | 11:08 | |
| *** kzaitsev_mb has joined #openstack-horizon | 11:14 | |
| *** aix has joined #openstack-horizon | 11:33 | |
| *** lyanchih has quit IRC | 11:40 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Replace ironic_discoverd.client with ironic_inspector_client https://review.openstack.org/206088 | 11:40 |
| *** yamamoto has joined #openstack-horizon | 11:41 | |
| *** yamamoto has joined #openstack-horizon | 11:41 | |
| *** yamamoto_ has joined #openstack-horizon | 11:42 | |
| *** zhurong has joined #openstack-horizon | 11:42 | |
| *** e0ne has quit IRC | 11:42 | |
| *** yamamoto has quit IRC | 11:46 | |
| robcresswell | tsufiev: I just realised something odd. All the details pages are at <panel>/<id>/detail. Shouldnt it just be <panel>/<id>? | 11:49 |
| *** haypo has joined #openstack-horizon | 11:52 | |
| openstackgerrit | Bradley Jones proposed openstack/horizon: Add Curvature topology https://review.openstack.org/141078 | 11:52 |
| *** zhurong has quit IRC | 11:52 | |
| haypo | david-lyle, rdopiera: hi. you approved https://review.openstack.org/#/c/214902/ but i had to rebase it. can you please re-approve it? | 11:52 |
| *** kzaitsev1ws has joined #openstack-horizon | 11:53 | |
| *** kzaitsev1ws has quit IRC | 11:53 | |
| *** lhcheng has joined #openstack-horizon | 11:55 | |
| robcresswell | haypo: What was the difference between 3 and 4? | 11:56 |
| robcresswell | I see the conflict at 2 | 11:56 |
| haypo | robcresswell: "I rebased the patch. There was a single and simple conflict on imports because "import six" was added." | 11:57 |
| mrunge | robcresswell, https://review.openstack.org/#/c/214902/3..4/openstack_dashboard/dashboards/admin/metering/tables.py | 11:57 |
| haypo | robcresswell: that's all | 11:57 |
| tsufiev | robcresswell, don't know, hadn't invested much thought into me. But, to me it seems like the possibility to add something other than /details page for every entity in panel | 11:57 |
| haypo | there was also a pep8 error because "import six" was written twice | 11:57 |
| mrunge | +2'ed that patch, looks good to me haypo | 11:58 |
| haypo | mrunge: cool | 11:58 |
| *** kiran-r has quit IRC | 11:58 | |
| robcresswell | Approved. | 11:58 |
| haypo | mrunge: such patch is annoying because it modifies a lot of files. it's likely to conflict ... | 11:58 |
| mrunge | yes I know haypo | 11:58 |
| mrunge | thanks for the heads-up here | 11:58 |
| mrunge | and thank you robcresswell for ack! | 11:59 |
| robcresswell | mrunge: Yeah, I checked 2..4 first to see how merge was resolved, but was confused by there being 2 patchsets... thought it was faster just to ask since haypo was here | 11:59 |
| robcresswell | mrunge: Np :) | 11:59 |
| haypo | i'm now working on openstack_auth. python3 support is announced, but there are 3 obvious issues with python3 | 11:59 |
| haypo | i have a patch, but i'm trying to write a test for them | 12:00 |
| robcresswell | I'm a big fan of all the fixes recently; Py3, integration tests, npm lint and minimum test coverage... | 12:00 |
| *** lhcheng has quit IRC | 12:00 | |
| robcresswell | And docs warnings fixed too. | 12:00 |
| robcresswell | Looks like we will have a more stable horizon next cycle. | 12:00 |
| tsufiev | robcresswell, or the one that "breaks" more often :) | 12:01 |
| robcresswell | glass half full tsufiev, not half empty!! :p | 12:03 |
| *** gparaskevas has joined #openstack-horizon | 12:04 | |
| r1chardj0n3s | tsufiev: the old one tried to be headless, but in a way that was incompatible with our test suite (a way that we couldn't determine) | 12:05 |
| r1chardj0n3s | tsufiev: the big change is that the new job actually runs the tests :) | 12:05 |
| tsufiev | r1chardj0n3s, btw, are your able to debug these headless tests locally? | 12:06 |
| tsufiev | or even run | 12:06 |
| r1chardj0n3s | tsufiev: yes, using the existing Horizon ./run_tests.py --only-selenium [--selenium-headless] | 12:06 |
| tsufiev | I tried running integration tests (by default tox uses --selenium-headless) and had some weird error which I had no time investigate | 12:07 |
| r1chardj0n3s | which is what the new gate job uses | 12:07 |
| tsufiev | with opening some files | 12:07 |
| r1chardj0n3s | I've not looked into the integration tests, but I can do tomorrow if you like? It's 10pm here and I'm about to go to bed | 12:07 |
| tsufiev | r1chardj0n3s, oh, sorry. Sure, I don't mind ) | 12:07 |
| r1chardj0n3s | no worries mate :) | 12:07 |
| r1chardj0n3s | I'm just glad we have a path to more selenium tests for the new functionality | 12:08 |
| r1chardj0n3s | night :) | 12:08 |
| *** ducttape_ has joined #openstack-horizon | 12:09 | |
| *** yamamoto_ has quit IRC | 12:10 | |
| *** liangbo has quit IRC | 12:11 | |
| *** yamamoto has joined #openstack-horizon | 12:11 | |
| *** ShivsharanRahul has quit IRC | 12:15 | |
| *** yamamoto has quit IRC | 12:16 | |
| *** Daisy has joined #openstack-horizon | 12:17 | |
| *** jcoufal has joined #openstack-horizon | 12:19 | |
| *** ShivsharanRahul has joined #openstack-horizon | 12:24 | |
| *** mtanino has joined #openstack-horizon | 12:24 | |
| *** Daisy has quit IRC | 12:26 | |
| *** Daisy has joined #openstack-horizon | 12:26 | |
| *** ducttape_ has quit IRC | 12:27 | |
| *** openstackgerrit has quit IRC | 12:31 | |
| *** openstackgerrit has joined #openstack-horizon | 12:32 | |
| *** btully has joined #openstack-horizon | 12:33 | |
| *** jcoufal has quit IRC | 12:35 | |
| *** amotoki_ has quit IRC | 12:37 | |
| *** btully has quit IRC | 12:37 | |
| openstackgerrit | Victor Stinner proposed openstack/django_openstack_auth: Fix Python 3 issues https://review.openstack.org/217687 | 12:38 |
| haypo | ah, openstack/django_openstack_auth is also tracked on this channel. so here is my patch for python 3 ^^ | 12:38 |
| *** vgridnev has quit IRC | 12:40 | |
| *** wuhg has quit IRC | 12:41 | |
| *** doug-fish has joined #openstack-horizon | 12:41 | |
| *** vgridnev has joined #openstack-horizon | 12:43 | |
| *** e0ne has joined #openstack-horizon | 12:44 | |
| *** cloudtrainme has quit IRC | 12:46 | |
| openstackgerrit | Merged openstack/horizon: Revert "Fix broken header dropdowns" https://review.openstack.org/217331 | 12:46 |
| robcresswell | pkarikh: Just an FYI, one of your changes was reverted; my be worth looking in to. https://review.openstack.org/#/c/165893/ | 12:48 |
| *** jcoufal has joined #openstack-horizon | 12:49 | |
| openstackgerrit | Merged openstack/horizon: Cleaning up the Transfer Table https://review.openstack.org/208867 | 12:52 |
| *** cloudtrainme has joined #openstack-horizon | 12:53 | |
| *** Daisy has quit IRC | 12:57 | |
| *** Daisy has joined #openstack-horizon | 12:58 | |
| *** yamamoto has joined #openstack-horizon | 13:00 | |
| *** zhurong has joined #openstack-horizon | 13:00 | |
| * robcresswell is suddenly realising half the URL patterns in Horizon make zero sense | 13:00 | |
| *** Daisy has quit IRC | 13:03 | |
| *** ShivsharanRahul has left #openstack-horizon | 13:03 | |
| *** jpomeroy has quit IRC | 13:03 | |
| *** ducttape_ has joined #openstack-horizon | 13:04 | |
| *** ducttape_ has quit IRC | 13:07 | |
| *** yamamoto has quit IRC | 13:08 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 13:09 |
| *** mtanino has quit IRC | 13:11 | |
| *** ankit_ag has quit IRC | 13:12 | |
| *** cloudtrainme has quit IRC | 13:12 | |
| *** ducttape_ has joined #openstack-horizon | 13:14 | |
| *** doug-fish has quit IRC | 13:15 | |
| *** neelashah has joined #openstack-horizon | 13:15 | |
| *** doug-fish has joined #openstack-horizon | 13:15 | |
| *** neelabh__ has joined #openstack-horizon | 13:16 | |
| neelabh__ | Guys Please tell me how to access nova.servers.list() through only token.... | 13:16 |
| ducttape_ | neelabh__ - the horizon api wrappers all use / need a request | 13:16 |
| ducttape_ | if you only have a token, you'd need to redo the same stuff currently in the openstack_dashboard/api/nova.py stuff | 13:17 |
| ducttape_ | you need more than just a token, if you have multiple regions (something else to think of) | 13:18 |
| *** doug-fish has quit IRC | 13:19 | |
| *** doug-fish has joined #openstack-horizon | 13:22 | |
| *** ducttape_ has quit IRC | 13:22 | |
| *** jpomeroy has joined #openstack-horizon | 13:22 | |
| *** zz_ttrifonov is now known as ttrifonov | 13:23 | |
| neelabh__ | ducttape: please see this https://ask.openstack.org/en/question/80901/how-to-get-list-of-all-servers-through-token-based-authetication/ | 13:23 |
| *** cloudtrainme has joined #openstack-horizon | 13:25 | |
| *** zhenguo has joined #openstack-horizon | 13:25 | |
| *** cloudtrainme has quit IRC | 13:26 | |
| *** julim has joined #openstack-horizon | 13:28 | |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Add support for creating subnets with Neutron subnet allocation https://review.openstack.org/203570 | 13:34 |
| *** yamamoto has joined #openstack-horizon | 13:37 | |
| *** pauloewerton has joined #openstack-horizon | 13:39 | |
| *** jtriley has joined #openstack-horizon | 13:40 | |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Add support for creating subnets with Neutron subnet allocation https://review.openstack.org/203570 | 13:43 |
| *** lhcheng has joined #openstack-horizon | 13:45 | |
| *** radez has joined #openstack-horizon | 13:48 | |
| *** lhcheng has quit IRC | 13:49 | |
| *** petertr7_away is now known as petertr7 | 13:51 | |
| *** lblanchard has joined #openstack-horizon | 13:52 | |
| *** mtanino has joined #openstack-horizon | 13:52 | |
| *** Piet has quit IRC | 13:56 | |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Add support for creating subnets with Neutron subnet allocation https://review.openstack.org/203570 | 13:57 |
| *** yamamoto has quit IRC | 13:57 | |
| *** exploreshaifali has joined #openstack-horizon | 13:59 | |
| *** ducttape_ has joined #openstack-horizon | 14:00 | |
| *** petertr7 is now known as petertr7_away | 14:01 | |
| *** lyanchih has joined #openstack-horizon | 14:03 | |
| *** doug-fish has quit IRC | 14:04 | |
| lawrance_ | hello Cinder Lu, there? | 14:05 |
| *** doug-fish has joined #openstack-horizon | 14:05 | |
| *** doug-fish has quit IRC | 14:05 | |
| tsufiev | lawrance_, her nick is clu | 14:05 |
| *** doug-fish has joined #openstack-horizon | 14:06 | |
| tsufiev | usually it's too early for her since she is at PST | 14:06 |
| *** doug-fish has quit IRC | 14:07 | |
| openstackgerrit | Victor Stinner proposed openstack/django_openstack_auth: Fix Python 3 issues https://review.openstack.org/217687 | 14:07 |
| *** doug-fish has joined #openstack-horizon | 14:07 | |
| *** lhcheng has joined #openstack-horizon | 14:09 | |
| *** lyanchih has quit IRC | 14:09 | |
| *** shivrao has joined #openstack-horizon | 14:10 | |
| *** lhcheng has quit IRC | 14:14 | |
| *** jprovazn has joined #openstack-horizon | 14:14 | |
| *** shivrao_ has joined #openstack-horizon | 14:15 | |
| *** shivrao has quit IRC | 14:18 | |
| *** cloudtrainme has joined #openstack-horizon | 14:21 | |
| *** shivrao_ has quit IRC | 14:21 | |
| *** romainh has joined #openstack-horizon | 14:21 | |
| *** jtriley has quit IRC | 14:24 | |
| robcresswell | Cinder :p hehe. It's Cindy, and she'll not likely be around for another couple hours | 14:30 |
| *** jtriley has joined #openstack-horizon | 14:32 | |
| openstackgerrit | David Lyle proposed openstack/horizon: [Sahara] Add support for event logs https://review.openstack.org/158715 | 14:33 |
| *** zhurong has quit IRC | 14:33 | |
| *** vijendar has joined #openstack-horizon | 14:34 | |
| *** dfisher has joined #openstack-horizon | 14:35 | |
| *** romainh has left #openstack-horizon | 14:36 | |
| *** doug-fish has quit IRC | 14:36 | |
| *** doug-fish has joined #openstack-horizon | 14:37 | |
| dfisher | I know this probably isn't a horizon-specific question but it does affect horizon on devstack deployments. I've got an ubuntu devstack rig with a stock configuration of Apache (runs it as the user/group of www-data). How exactly is Ubuntu allowing the WSGIDaemonProcess to switch users? doesn't mod_wsgi explicitly prohibit this? | 14:37 |
| *** petertr7_away is now known as petertr7 | 14:40 | |
| *** pauloegf has joined #openstack-horizon | 14:43 | |
| *** pauloegf has quit IRC | 14:43 | |
| *** pauloegf has joined #openstack-horizon | 14:44 | |
| *** pauloegf has quit IRC | 14:44 | |
| *** pauloewerton has quit IRC | 14:45 | |
| *** pauloewerton has joined #openstack-horizon | 14:46 | |
| *** doug-fish has quit IRC | 14:46 | |
| *** hinnant_ has joined #openstack-horizon | 14:52 | |
| *** KunalGandhi has joined #openstack-horizon | 14:52 | |
| pkarikh | robcresswell: yep, thanks. Can't find out how could I miss it (or when it was broken). | 14:56 |
| *** KunalGandhi has quit IRC | 14:57 | |
| *** yamamoto has joined #openstack-horizon | 14:58 | |
| *** vgridnev has quit IRC | 15:00 | |
| *** yamamoto has quit IRC | 15:02 | |
| *** itisha has joined #openstack-horizon | 15:07 | |
| *** itisha_ has joined #openstack-horizon | 15:09 | |
| *** SimonChung1 has quit IRC | 15:09 | |
| *** petertr7 is now known as petertr7_away | 15:11 | |
| itisha_ | Hi, my name is Itisha, I am interested in working in Openstack and learning more about cloud services. I find that I can contribute to Horizon easily since I like web development. Can someone please guide me on how to start contributing? Thanks | 15:13 |
| *** petertr7_away is now known as petertr7 | 15:15 | |
| *** peristeri has quit IRC | 15:17 | |
| gparaskevas | Hello i believe you can start from here | 15:18 |
| gparaskevas | http://docs.openstack.org/developer/horizon/contributing.html | 15:18 |
| gparaskevas | wellcome BTW | 15:18 |
| *** exploreshaifali has quit IRC | 15:22 | |
| *** ttrifonov is now known as zz_ttrifonov | 15:28 | |
| *** vgridnev has joined #openstack-horizon | 15:30 | |
| *** vgridnev has quit IRC | 15:31 | |
| *** vgridnev has joined #openstack-horizon | 15:31 | |
| *** gparaskevas has quit IRC | 15:32 | |
| *** vgridnev has quit IRC | 15:36 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add Angular Table Footer Directive https://review.openstack.org/207631 | 15:39 |
| *** ccesario has quit IRC | 15:41 | |
| *** sayan has quit IRC | 15:41 | |
| itisha | Thanks gparaskevas | 15:44 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add Angular Table Footer Directive https://review.openstack.org/207631 | 15:46 |
| *** dfisher has left #openstack-horizon | 15:50 | |
| *** dsneddon_away is now known as dsneddon | 15:50 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Adding clone feature to Transfer Table https://review.openstack.org/211345 | 15:52 |
| *** doug-fish has joined #openstack-horizon | 16:01 | |
| *** Daisy has joined #openstack-horizon | 16:04 | |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Add support for creating subnets with Neutron subnet allocation https://review.openstack.org/203570 | 16:08 |
| *** btully has joined #openstack-horizon | 16:09 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 16:10 |
| *** ccesario has joined #openstack-horizon | 16:10 | |
| *** rajatvig has joined #openstack-horizon | 16:10 | |
| *** ygbo has quit IRC | 16:10 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 16:11 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 16:11 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for Metadata Definitions https://review.openstack.org/215721 | 16:11 |
| *** btully has quit IRC | 16:14 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for Metadata Definitions https://review.openstack.org/215721 | 16:14 |
| *** doug-fish has quit IRC | 16:14 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 16:15 |
| *** doug-fish has joined #openstack-horizon | 16:15 | |
| *** SimonChung has joined #openstack-horizon | 16:15 | |
| *** e0ne has quit IRC | 16:18 | |
| *** doug-fish has quit IRC | 16:19 | |
| *** vgridnev has joined #openstack-horizon | 16:19 | |
| *** sayan has joined #openstack-horizon | 16:19 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 16:21 |
| *** bluex-pl has quit IRC | 16:24 | |
| *** exploreshaifali has joined #openstack-horizon | 16:26 | |
| *** garthb_ has joined #openstack-horizon | 16:26 | |
| *** garthb has joined #openstack-horizon | 16:26 | |
| *** garthb has quit IRC | 16:27 | |
| *** lhcheng has joined #openstack-horizon | 16:27 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 16:35 |
| *** doug-fish has joined #openstack-horizon | 16:36 | |
| *** jprovazn has quit IRC | 16:37 | |
| *** Ala has quit IRC | 16:38 | |
| *** doug-fis_ has joined #openstack-horizon | 16:39 | |
| *** doug-fish has quit IRC | 16:41 | |
| *** zhenguo has quit IRC | 16:41 | |
| itisha | Hello, I was trying to setup dev environment for horizon and in the step where i need to run run_tests.sh which builds a virtualenv with all horizon deps. I am unable to run this succesfully and get errors which might be due to me working behind a proxy. Is there a workaround for it? | 16:42 |
| robcresswell | itisha: What are the errors? Can you hit external repos normally? | 16:44 |
| itisha | https://www.irccloud.com/pastebin/i6Gbyf9H/Error | 16:45 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add API services for system information https://review.openstack.org/205196 | 16:45 |
| *** jtriley has quit IRC | 16:45 | |
| itisha | @robcresswell This is one of the errors I am getting | 16:45 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 16:45 |
| *** vijendar1 has joined #openstack-horizon | 16:46 | |
| *** petertr7 is now known as petertr7_away | 16:46 | |
| *** Daisy has quit IRC | 16:48 | |
| *** Daisy has joined #openstack-horizon | 16:48 | |
| *** petertr7_away is now known as petertr7 | 16:48 | |
| *** vijendar has quit IRC | 16:48 | |
| itisha | @robcresswell by external repos do you mean ppa etc? I need to use -E flag with commands when I clone external repos which includes my environments variables like proxy settings in the command | 16:48 |
| *** Daisy has quit IRC | 16:49 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Moving inline html code out of login.spec.js https://review.openstack.org/216517 | 16:49 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 16:50 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 16:50 |
| *** KunalGandhi has joined #openstack-horizon | 16:50 | |
| *** KunalGandhi has quit IRC | 16:50 | |
| *** KunalGandhi has joined #openstack-horizon | 16:50 | |
| robcresswell | in IRC, just tab complete the name, I don't think the @ symbol notifies | 16:52 |
| robcresswell | itisha: ^^ | 16:52 |
| *** cloudtrainme has quit IRC | 16:52 | |
| *** lyanchih has joined #openstack-horizon | 16:52 | |
| *** jtriley has joined #openstack-horizon | 16:52 | |
| itisha | robcresswell: alright! | 16:53 |
| openstackgerrit | Merged openstack/horizon: Update Table to Single HTML for Readability https://review.openstack.org/216977 | 16:53 |
| *** harlowja has joined #openstack-horizon | 16:55 | |
| *** jingjing_ren has joined #openstack-horizon | 16:55 | |
| robcresswell | Using Horizon behind a proxy, I'm not sure about. It's not something I've had to do before. | 16:56 |
| *** aix has quit IRC | 16:58 | |
| *** jpomeroy has quit IRC | 16:58 | |
| neelabh__ | What is use of additional_query in class ProjectAggregatesQuery in metering.py.. | 17:01 |
| itisha | robcresswell: I looked through the file run_tests.sh and basically for some of the commands called in it I might need to explicitly supply the proxy settings | 17:01 |
| *** lyanchih has quit IRC | 17:02 | |
| *** lawrance_ has quit IRC | 17:02 | |
| *** jpomeroy has joined #openstack-horizon | 17:02 | |
| *** doug-fis_ has quit IRC | 17:04 | |
| *** doug-fish has joined #openstack-horizon | 17:04 | |
| *** doug-fish has quit IRC | 17:04 | |
| *** doug-fish has joined #openstack-horizon | 17:05 | |
| robcresswell | neelabh__: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/ceilometer.py#L337 | 17:07 |
| *** ybathia has joined #openstack-horizon | 17:08 | |
| neelabh__ | robcresswell: "additional_query`: Additional query for the statistics." I am not getting it properly what is usage of it, thanks.. | 17:09 |
| neelabh__ | what is 'op': 'ge' in additional query... | 17:10 |
| *** garthb has joined #openstack-horizon | 17:10 | |
| *** garthb_ has quit IRC | 17:10 | |
| *** petertr7 is now known as petertr7_away | 17:11 | |
| openstackgerrit | Merged openstack/tuskar-ui: Use textfield for public interface in simplified config https://review.openstack.org/217318 | 17:14 |
| *** doug-fish has quit IRC | 17:14 | |
| *** doug-fish has joined #openstack-horizon | 17:14 | |
| openstackgerrit | Merged openstack/horizon: [Sahara] Added volume type and instance locality support https://review.openstack.org/172416 | 17:14 |
| *** cloudtrainme has joined #openstack-horizon | 17:15 | |
| *** yamamoto has joined #openstack-horizon | 17:20 | |
| itisha | I have got a local server of horizon running and can access dashboard in my browser. Can someone point me to getting started by solving beginner bugs? | 17:22 |
| *** hinnant_ has quit IRC | 17:22 | |
| *** kzaitsev_mb has quit IRC | 17:30 | |
| *** rdopiera has quit IRC | 17:34 | |
| itisha | https://bugs.launchpad.net/horizon/+bug/1395897 This bug looks good. Can someone help me get started on solving this? | 17:36 |
| openstack | Launchpad bug 1395897 in OpenStack Dashboard (Horizon) "Database Instance Status confusion" [Wishlist,New] - Assigned to Itisha Dewan (ishadewan07) | 17:36 |
| *** SimonChung1 has joined #openstack-horizon | 17:41 | |
| *** SimonChung has quit IRC | 17:41 | |
| *** shivrao has joined #openstack-horizon | 17:43 | |
| *** e0ne has joined #openstack-horizon | 17:45 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Fix table _get_rows() - always return None https://review.openstack.org/207491 | 17:47 |
| *** exploreshaifali has quit IRC | 17:48 | |
| *** cloudtrainme has quit IRC | 17:50 | |
| *** cloudtrainme has joined #openstack-horizon | 17:51 | |
| *** tqtran has joined #openstack-horizon | 17:51 | |
| *** btully has joined #openstack-horizon | 17:57 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP Adding action to delete multiple images to angular images panel https://review.openstack.org/217422 | 18:00 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP Adding Create Image Action to angular images panel https://review.openstack.org/217828 | 18:00 |
| *** saksham has joined #openstack-horizon | 18:01 | |
| *** garthb has quit IRC | 18:01 | |
| *** btully has quit IRC | 18:02 | |
| *** garthb has joined #openstack-horizon | 18:02 | |
| openstackgerrit | Merged openstack/horizon: Allowing data sources to be edited https://review.openstack.org/195282 | 18:03 |
| *** Piet has joined #openstack-horizon | 18:03 | |
| *** garthb has quit IRC | 18:09 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Adding download for openrc file for keystone v3 https://review.openstack.org/186846 | 18:10 |
| openstackgerrit | Duk Loi proposed openstack/horizon: Enable Redis database cluster support https://review.openstack.org/204630 | 18:11 |
| *** jbell8 has quit IRC | 18:19 | |
| *** jwy has joined #openstack-horizon | 18:20 | |
| *** Samos123 has quit IRC | 18:27 | |
| *** Samos123 has joined #openstack-horizon | 18:29 | |
| *** jingjing_ren has quit IRC | 18:29 | |
| *** vgridnev has quit IRC | 18:31 | |
| *** petertr7_away is now known as petertr7 | 18:33 | |
| *** jingjing_ren has joined #openstack-horizon | 18:35 | |
| *** jingjing_ren has quit IRC | 18:39 | |
| *** shivrao_ has joined #openstack-horizon | 18:39 | |
| *** exploreshaifali has joined #openstack-horizon | 18:40 | |
| *** shivrao has quit IRC | 18:41 | |
| *** shivrao_ is now known as shivrao | 18:41 | |
| *** saksham has left #openstack-horizon | 18:41 | |
| tqtran | david-lyle: could you help push this one through? https://review.openstack.org/#/c/211741/ just a few jscs fixes that would then allow us to enable linting in dashboards folder as well https://review.openstack.org/#/c/214057/ | 18:45 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Moving inline html code out of login.spec.js https://review.openstack.org/216517 | 18:52 |
| *** TravT has quit IRC | 18:52 | |
| *** e0ne has quit IRC | 18:53 | |
| *** mrunge has quit IRC | 18:55 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Creating new user does not require project https://review.openstack.org/215389 | 18:55 |
| *** TravT has joined #openstack-horizon | 18:56 | |
| *** garthb has joined #openstack-horizon | 18:56 | |
| *** lapalm has joined #openstack-horizon | 18:56 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Creating new user does not require project https://review.openstack.org/215389 | 18:56 |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Add support for creating subnets with Neutron subnet allocation https://review.openstack.org/203570 | 18:58 |
| openstackgerrit | Merged openstack/horizon: Javascript Heat API https://review.openstack.org/216443 | 18:59 |
| *** rajatvig has quit IRC | 19:00 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:02 | |
| Piet | Please provide feedback on searchlight concept - https://openstack.invisionapp.com/d/main/#/console/4342648/98035025/comments | 19:04 |
| *** rajatvig has joined #openstack-horizon | 19:04 | |
| *** dsneddon is now known as dsneddon_bbiab | 19:06 | |
| openstackgerrit | KBrown proposed openstack/horizon: Adding action to delete multiple images to angular images panel https://review.openstack.org/217422 | 19:07 |
| *** rajatvig has quit IRC | 19:07 | |
| *** rajatvig has joined #openstack-horizon | 19:07 | |
| *** btully has joined #openstack-horizon | 19:09 | |
| *** aix has joined #openstack-horizon | 19:11 | |
| *** btully has quit IRC | 19:14 | |
| *** vgridnev has joined #openstack-horizon | 19:22 | |
| *** rajatvig has quit IRC | 19:28 | |
| *** rajatvig has joined #openstack-horizon | 19:34 | |
| *** rajatvig has quit IRC | 19:34 | |
| *** angvp has quit IRC | 19:36 | |
| *** e0ne has joined #openstack-horizon | 19:37 | |
| *** stevemar has joined #openstack-horizon | 19:43 | |
| *** tqtran_ has joined #openstack-horizon | 19:45 | |
| tqtran_ | TravT: https://review.openstack.org/#/c/212125/7/openstack_dashboard/static/app/core/cloud-services/hz-service-enabled.directive.spec.js L63 | 19:45 |
| kfox1111 | ~. | 19:46 |
| kfox1111 | ~> | 19:46 |
| kfox1111 | ~> | 19:46 |
| tqtran_ | im running it on local and finding that it does not do anything | 19:46 |
| tqtran_ | futhermore, shouldnt the things returned in success be a response object and not a function? | 19:47 |
| *** hinnant_ has joined #openstack-horizon | 19:47 | |
| kfox1111 | tqtran_: so, https://review.openstack.org/#/c/206773/ looks to have failed due to a gate issue. do we just 'recheck' it? | 19:50 |
| tqtran_ | looks like gate reported that it failed npm run test but log shows nothing | 19:51 |
| tqtran_ | try to run "npm run test' locally and see if anything turns up, if not, then do a recheck | 19:52 |
| *** dsneddon_bbiab is now known as dsneddon | 19:53 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Directive to check if policy check passes https://review.openstack.org/214815 | 19:53 |
| kfox1111 | tqtran_: the logs show it failed to contact ubuntu's mirror. :/ | 19:59 |
| kfox1111 | http://logs.openstack.org/73/206773/23/gate/gate-horizon-npm-run-test/b0131c6/console.html at the bottom. | 20:00 |
| *** rajatvig has joined #openstack-horizon | 20:00 | |
| *** sayan has quit IRC | 20:00 | |
| kfox1111 | triggering recheck. | 20:02 |
| *** doug-fish has quit IRC | 20:07 | |
| *** doug-fish has joined #openstack-horizon | 20:07 | |
| *** jwy has quit IRC | 20:08 | |
| *** jbell8 has joined #openstack-horizon | 20:08 | |
| *** tqtran has quit IRC | 20:10 | |
| *** sambetts has quit IRC | 20:10 | |
| *** doug-fish has quit IRC | 20:12 | |
| *** jbell8 has quit IRC | 20:12 | |
| *** e0ne has quit IRC | 20:13 | |
| *** sambetts has joined #openstack-horizon | 20:17 | |
| openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 20:17 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 20:18 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 20:18 |
| openstackgerrit | Duk Loi proposed openstack/horizon: Initial support for database clustering in Horizon https://review.openstack.org/110411 | 20:18 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 20:20 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add API services for system information https://review.openstack.org/205196 | 20:20 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 20:20 |
| *** tqtran has joined #openstack-horizon | 20:21 | |
| *** rhagarty__ has quit IRC | 20:23 | |
| *** jwy has joined #openstack-horizon | 20:23 | |
| *** rhagarty_ has quit IRC | 20:23 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 20:24 |
| tqtran_ | rajatvig: https://review.openstack.org/#/c/212125/7/openstack_dashboard/static/app/core/cloud-services/hz-service-enabled.directive.spec.js L64 | 20:25 |
| tqtran_ | do you know what is going on there? | 20:26 |
| rajatvig | tqtran_: let me check on that. Just looked at your comment | 20:26 |
| *** rhagarty has joined #openstack-horizon | 20:29 | |
| *** rhagarty_ has joined #openstack-horizon | 20:30 | |
| openstackgerrit | Merged openstack/horizon: [Sahara] Add missing job type in libs selection https://review.openstack.org/216384 | 20:30 |
| openstackgerrit | Merged openstack/horizon: Delete redundant 'CreateVolumeTypeView' class https://review.openstack.org/215555 | 20:30 |
| *** exploreshaifali has quit IRC | 20:30 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding manila shares as an option for data sources https://review.openstack.org/214754 | 20:31 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 20:32 |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Support docker image type in ng launch instance wizard https://review.openstack.org/217894 | 20:37 |
| rajatvig | tqtran_: nice catch. I don't need the callback there. | 20:37 |
| tqtran_ | so the question is... how do i know that it is getting resolved? | 20:37 |
| rajatvig | tqtran_: just updated the test and added another to test when the service returns an error | 20:37 |
| *** kristinebrown has joined #openstack-horizon | 20:38 | |
| tqtran_ | ok, i'll wait for your update, but the central question we are asking is, if settings or policies or whatever passes, then the content should be there. right now, that question isn't answered because we aren't triggering the success call | 20:38 |
| tqtran_ | so unless we know it is successful, the test isn't really useful... | 20:39 |
| *** exploreshaifali has joined #openstack-horizon | 20:39 | |
| *** jingjing_ren has joined #openstack-horizon | 20:39 | |
| *** jingjing_ren has quit IRC | 20:39 | |
| rajatvig | makes sense. I understand what you're saying and I don't think the test captures it well. | 20:40 |
| *** akrivoka has quit IRC | 20:40 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding manila shares as an option for data sources https://review.openstack.org/214754 | 20:42 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Update User Table to Single HTML for Readability https://review.openstack.org/217901 | 20:43 |
| *** crobertsrh is now known as _crobertsrh | 20:44 | |
| *** exploreshaifali has quit IRC | 20:45 | |
| *** cloudtrainme has quit IRC | 20:49 | |
| *** julim has quit IRC | 20:50 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Fix Users table to use hz-table-footer directive https://review.openstack.org/217903 | 20:51 |
| *** gyee has joined #openstack-horizon | 20:51 | |
| *** julim has joined #openstack-horizon | 20:54 | |
| *** cloudtrainme has joined #openstack-horizon | 20:55 | |
| *** sqchen has joined #openstack-horizon | 20:57 | |
| david-lyle | tqtran_: what lint issue does https://review.openstack.org/#/c/211741/15/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/import-keypair-help.controller.js fix? | 20:58 |
| david-lyle | tqtran_: nevermind | 20:58 |
| TravT | tqtran_: rajatvig: | 20:58 |
| TravT | just reading back. | 20:58 |
| TravT | you need to read this line of the comments in the test | 20:58 |
| david-lyle | I see the end tag includes things it shouldn't | 20:59 |
| TravT | hmmm. | 20:59 |
| openstackgerrit | Darren Shaw proposed openstack/horizon: Fix local_settings.py.example to be consistently styled https://review.openstack.org/212041 | 20:59 |
| TravT | rajatvig: you didn't include those comments from the other patches | 20:59 |
| *** yamamoto has quit IRC | 21:00 | |
| TravT | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/cloud-services/hz-nova-extension.directive.spec.js#L59-L62 | 21:00 |
| TravT | all the actual promise testing is done in the common spec | 21:01 |
| TravT | https://github.com/openstack/horizon/blob/master/horizon/static/framework/util/promise-toggle/hz-promise-toggle.directive.spec.js | 21:01 |
| TravT | for the directive | 21:01 |
| rajatvig | TravT: I'll add the comments per the other patches. | 21:01 |
| rajatvig | I was testing what tqtran_ asked me to | 21:01 |
| david-lyle | rajatvig: tqtran_: one issue on https://review.openstack.org/#/c/211741/ | 21:02 |
| TravT | and all the actual testing for the specific promise for service catalog is here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/service-catalog.service.spec.js | 21:02 |
| rajatvig | tqtran_: the serviceCatalog.ifTypeEnabled does not resolve the promise if the service is not enabled. I added a test for the case when the promise is rejected | 21:02 |
| rajatvig | david-lyle: I'll try and fix that issue | 21:03 |
| *** jtriley has quit IRC | 21:03 | |
| TravT | rajatvig: thanks for that other test case. | 21:05 |
| *** lblanchard has quit IRC | 21:05 | |
| *** julim has quit IRC | 21:07 | |
| *** pauloewerton has quit IRC | 21:08 | |
| rajatvig | david-lyle: As I changed the file and renamed it, git is assuming it's a new file and marks the old one as deleted. | 21:09 |
| *** saksham has joined #openstack-horizon | 21:09 | |
| *** petertr7 is now known as petertr7_away | 21:09 | |
| david-lyle | rajatvig: git mv, then change | 21:10 |
| david-lyle | wonder if the move has to go first :/ | 21:10 |
| *** jcoufal has quit IRC | 21:10 | |
| rajatvig | david-lyle: I just did git mv and then changed it. on a git add, it marks the old as deleted. | 21:12 |
| *** btully has joined #openstack-horizon | 21:12 | |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: Remove controller reference in ng launch instance https://review.openstack.org/217913 | 21:12 |
| tqtran_ | david-lyle: ah good point | 21:12 |
| *** kristinebrown has quit IRC | 21:12 | |
| openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 21:13 |
| david-lyle | rajatvig: why add? | 21:13 |
| *** Piet has quit IRC | 21:13 | |
| david-lyle | the old file is already in git, you are just renaming it | 21:14 |
| *** tjones has joined #openstack-horizon | 21:14 | |
| tqtran_ | TravT: i understand that we have tests for service-catalog but i still think we should mock the results and have the trigger the success call | 21:14 |
| tqtran_ | otherwise, there is no correlation between the success and the rendering of the transcluded content | 21:14 |
| rajatvig | david-lyle: when I change it, it marks it modified. I need to git add the new file it to make it part of the commit | 21:14 |
| tqtran_ | right now, all the test is doing is rendering and assuming the call is a success | 21:15 |
| tqtran_ | defer.resolve doesn't do anything | 21:15 |
| TravT | that makes sense, but what I'm saying is testing the transcluded content is all done in the directive testing that actually does that | 21:15 |
| david-lyle | rajatvig: to prove it's possible see https://review.openstack.org/#/c/211741/15/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.spec.js | 21:15 |
| david-lyle | which may look familiar | 21:15 |
| TravT | https://github.com/openstack/horizon/blob/master/horizon/static/framework/util/promise-toggle/hz-promise-toggle.directive.spec.js | 21:15 |
| david-lyle | git commit -a --amend | 21:15 |
| david-lyle | that's it | 21:15 |
| david-lyle | but now that you've done an add git can get wonky | 21:16 |
| david-lyle | that's the technical term | 21:16 |
| david-lyle | wonky | 21:16 |
| *** btully has quit IRC | 21:16 | |
| rajatvig | david-lyle: let me try once again. for some strange inexplicable reason, git assumes the spec file is renamed and changed while the service isn't even while I do the same operation on them. | 21:17 |
| TravT | this directive is simply specifying the promise to call and the name of the directive and we want to make sure both match. | 21:17 |
| rajatvig | and I do the same set of things on them | 21:17 |
| tqtran_ | TravT: hold on, let me look at your hz-promise-toggle spec | 21:17 |
| david-lyle | git doesn't forget our mistakes | 21:17 |
| david-lyle | it makes us relive them | 21:17 |
| tqtran_ | i dont quite agree with how we're testing it, in principle, it seems wrong | 21:18 |
| david-lyle | maybe clone a fresh repo and replay the changes there | 21:18 |
| david-lyle | I've had this issue too | 21:18 |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/217149 | 21:18 |
| tqtran_ | the premise is, if i have a hz-if-policies directive, it should only render content IF the response is a success | 21:18 |
| rajatvig | david-lyle: ok | 21:18 |
| tqtran_ | so what i should mock is a success response containing the object { allowed: true } | 21:18 |
| tqtran_ | and ONLY then should i see the content | 21:19 |
| rajatvig | tqtran_: the way the service catalog and the other services used by the directives are constructed, they resolve the promise if ok and reject if not | 21:19 |
| TravT | that sounds right | 21:19 |
| r1chardj0n3s | morning | 21:19 |
| david-lyle | shouldn't it be only THEN? | 21:19 |
| tqtran_ | i understand we have test for the services themselves and the parent directive, but i still think we need to test the individual hz-if directives as appropriate to them | 21:19 |
| rajatvig | so they capture the result of the service and reject the promise if the api returns false | 21:19 |
| * david-lyle continues to provide optimal help | 21:19 | |
| TravT | policy is a bit different that the others | 21:20 |
| tqtran_ | david-lyle: what about ONLY THEN | 21:20 |
| TravT | i think you'd have to have a wrapper promise | 21:20 |
| david-lyle | too much EMPHASIS | 21:20 |
| TravT | and in that case you will need more testing | 21:20 |
| rajatvig | tqtran_: look at https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/service-catalog.service.js#L113 | 21:21 |
| TravT | tqtran: serviceCatalog, novaExtensions, settingsService are wrappers on top of lower level direct API calls (like the policy call) | 21:21 |
| tqtran_ | ok thanks for the pointer guys, i'll take a look | 21:22 |
| tqtran_ | if policies need more testing, i'll add to it | 21:22 |
| TravT | if you add a similar ifPolicyAllowed to the API directly that works like those, then it would be similar. | 21:22 |
| *** kristinebrown has joined #openstack-horizon | 21:23 | |
| *** lapalm has quit IRC | 21:23 | |
| *** neelashah has quit IRC | 21:23 | |
| tqtran_ | TravT: lol just saw your comment on mering the table html | 21:23 |
| tqtran_ | i had no idea clu had one already lol | 21:23 |
| TravT | yeah, so you guys can go arm wrestle or something | 21:23 |
| tqtran_ | sounds like i will win | 21:24 |
| TravT | maybe it should be a sight seeing competition... first one to need a break loses | 21:24 |
| *** SimonChung1 has quit IRC | 21:24 | |
| *** SimonChung has joined #openstack-horizon | 21:24 | |
| tqtran_ | lol | 21:24 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Moving inline html code out of login.spec.js https://review.openstack.org/216517 | 21:25 |
| tqtran_ | TravT: ok, i'll add her as co-author to mine and you guys can just review mine, just spoke to her, shes ok with it | 21:26 |
| TravT | ok. | 21:26 |
| r1chardj0n3s | hmm, david-lyle, the run of selenium in the gate seems to show issues with the file selector widget https://review.openstack.org/#/c/215408/ :/ I think we might have to reconsider that test | 21:27 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 21:27 |
| r1chardj0n3s | (the file selector widget is the only reason why we can't use phantomjs as a selenium webdriver) | 21:27 |
| david-lyle | r1chardj0n3s: what's the alternative? | 21:28 |
| *** SimonChung has quit IRC | 21:29 | |
| *** SimonChung1 has joined #openstack-horizon | 21:29 | |
| r1chardj0n3s | not sure at this point; there might be a work-around that doesn't involve trying to interact with the file selector widget | 21:30 |
| r1chardj0n3s | maybe using a secondary hidden form field. it's a bit convoluted though | 21:30 |
| *** Piet has joined #openstack-horizon | 21:30 | |
| r1chardj0n3s | we could just consider whether that test is necessary | 21:30 |
| r1chardj0n3s | I will look into what might be done to get it to work in the gate - though the gate is a bit... weird :) | 21:31 |
| *** jpomeroy has quit IRC | 21:31 | |
| *** clu_ has joined #openstack-horizon | 21:31 | |
| david-lyle | +100 | 21:31 |
| *** ducttape_ has quit IRC | 21:32 | |
| r1chardj0n3s | in *theory* there's no reason the test shouldn't work in the gate, but .... | 21:32 |
| r1chardj0n3s | (I will work under the assumption that I don't have all the facts) | 21:32 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 21:34 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/217922 | 21:34 |
| rajatvig | david-lyle: I gave up. I created a new patch just to rename the two files. | 21:34 |
| rajatvig | david-lyle: I tried a fresh clone, replayed the changes. Same result. | 21:35 |
| *** kristinebrown has quit IRC | 21:35 | |
| david-lyle | rajatvig: look at gerrit | 21:38 |
| david-lyle | different result | 21:38 |
| david-lyle | oh but not the move | 21:39 |
| david-lyle | I see | 21:39 |
| rajatvig | david-lyle: I'll rename the other patch. I mentioned in the detail only | 21:40 |
| tqtran_ | TravT, rajatvig: ok, so im reading through the code now, and i see that service-catalog ifTypeEnabled either resolve or reject, but regardless it returns the promise | 21:40 |
| tqtran_ | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/service-catalog.service.js#L136 | 21:40 |
| tqtran_ | which i would assume can be handled in whatever service invoked it | 21:41 |
| tqtran_ | so going back to my original question, https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/cloud-services/hz-nova-extension.directive.spec.js#L66 | 21:41 |
| tqtran_ | i still don't understand what that does exactly.... | 21:41 |
| tqtran_ | if you put a breakpoint there, you'll see that the success handler was never called | 21:41 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Cloud Service directive to check if Service is enabled https://review.openstack.org/212125 | 21:42 |
| tqtran_ | ok nvm, rajatvig answered it :) thanks | 21:43 |
| TravT | haha | 21:43 |
| tqtran_ | great timing there rajatvig, i see what you did | 21:43 |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Add support for creating subnets with Neutron subnet allocation https://review.openstack.org/203570 | 21:43 |
| TravT | tqtran: i'd rather not change the name in this patch | 21:44 |
| TravT | https://review.openstack.org/#/c/216949/ | 21:44 |
| TravT | i'd rather do in a follow up patch | 21:44 |
| TravT | because I need to change html in LI config step too | 21:45 |
| kfox1111 | what might cause sahara not to show up in the dashboard when its enabled on the cloud? | 21:45 |
| tqtran_ | arent you changing the name in it? hz-nova-extension --> hz-nova-extensions | 21:45 |
| kfox1111 | we just upgraded from juno->kilo and it disapeared from horizon. | 21:45 |
| TravT | just the file name didn't match.... | 21:45 |
| *** kristinebrown has joined #openstack-horizon | 21:45 | |
| TravT | didn't actually change the directive | 21:45 |
| TravT | hmmm.. | 21:45 |
| TravT | how about I don't fix the file name | 21:46 |
| david-lyle | kfox1111: not in the service catalog | 21:46 |
| TravT | in that patch | 21:46 |
| TravT | and do a dependent patch that changes the name | 21:46 |
| tqtran_ | so just update the patch with docs, then do the rename in a follow on? | 21:46 |
| tqtran_ | im fine with that | 21:47 |
| TravT | ok, make sense. | 21:47 |
| david-lyle | the API tab would show it in projects | 21:47 |
| TravT | i have to change the names on hz-settings as well. | 21:47 |
| david-lyle | *project dashboard | 21:47 |
| *** doug-fish has joined #openstack-horizon | 21:50 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Rename launch instance model file https://review.openstack.org/217922 | 21:50 |
| kfox1111 | | 2913a92b7e48499eb97608bd55c5cae0 | sahara | data_processing | Sahara Data Processing | | 21:50 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 21:51 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 21:51 |
| kfox1111 | which is listed in horizon in SAHARA_SERVICE_FALLBACK | 21:51 |
| robcresswell | tqtran_: Did you get my hangout message about breadcrumb nav btw? | 21:51 |
| tqtran_ | robcresswell: looking at it now | 21:52 |
| tqtran_ | whats the issue with the url? | 21:52 |
| rajatvig | tqtran_: you're welcome | 21:52 |
| robcresswell | I had one of the typical programmer days. Rewrite Task A. A doesnt work because B is broken, rewrite B. B doesnt work because C is broken.. etc. | 21:53 |
| robcresswell | Anyway, a lot of the URL patterns in Horizon, especially with nested patterns, are very odd. | 21:54 |
| robcresswell | Like you'd expect networks/<id> to show info about <id> network | 21:54 |
| robcresswell | but its at network/<id>/detail | 21:54 |
| *** doug-fish has quit IRC | 21:54 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Improve Cloud Service Directive Documentation https://review.openstack.org/216949 | 21:54 |
| robcresswell | And adding a port isn't network/<id>/ports/create. its networks/ports/addport or something. | 21:55 |
| tqtran_ | lol yes | 21:55 |
| tqtran_ | that was essentially some of the issues i ran into when i started this work | 21:55 |
| robcresswell | Thing is, this breaks your breadcrumb pattern | 21:55 |
| robcresswell | The request.path idea is actually fine | 21:55 |
| robcresswell | but the URLs are so friggin stupidly designed | 21:55 |
| tqtran_ | there is also no consistency, like some views have something/id/details while some doesn't | 21:56 |
| robcresswell | I had a cup of tea and a scone to calm down because it was so annoying. | 21:56 |
| robcresswell | And then set about fixing it. | 21:56 |
| robcresswell | :D | 21:56 |
| tqtran_ | lol so typically british of you | 21:56 |
| kfox1111 | hmm... it should be falling back but working. any other ideas? | 21:56 |
| kfox1111 | the cli seems to work ok. | 21:57 |
| robcresswell | It's on the backburner till M anyway... but I've got soo much code sitting on my laptop now. I've been writing a lot of the networks stuff in angular. | 21:57 |
| robcresswell | Need to get some patches up. | 21:57 |
| david-lyle | kfox1111: ah, data-processing went to data_processing for the service type | 21:57 |
| david-lyle | maybe that? | 21:57 |
| david-lyle | what horizon version? | 21:58 |
| kfox1111 | kilo. | 21:58 |
| david-lyle | thought we backported the fix | 21:58 |
| david-lyle | looking | 21:58 |
| kfox1111 | I could set it manually in the catalog. it looks like it should fall back to the old name though. | 21:58 |
| david-lyle | kfox1111: does your panel look like https://github.com/openstack/horizon/blob/stable/kilo/openstack_dashboard/dashboards/project/data_processing/cluster_templates/panel.py#L24 | 21:59 |
| david-lyle | e.g. | 21:59 |
| david-lyle | just one panel of many | 21:59 |
| david-lyle | looks like initial kilo may not have had that | 22:00 |
| *** yamamoto has joined #openstack-horizon | 22:00 | |
| david-lyle | kfox1111: maybe it did | 22:01 |
| david-lyle | I see it in 2015.1.0 | 22:01 |
| kfox1111 | we're on 2015.1.1. | 22:01 |
| kfox1111 | (broke many other things. :/) | 22:01 |
| kfox1111 | 2015.1.0 was better aparently... | 22:01 |
| david-lyle | from a horizon standpoint? | 22:01 |
| kfox1111 | let me double check horizon's version. | 22:02 |
| kfox1111 | hmm. no. horizon's 2015.1.0. | 22:02 |
| david-lyle | it's there too though | 22:02 |
| kfox1111 | yeah, the file you posted looks the same. | 22:03 |
| david-lyle | if there is a data_processing or data-processing in your catalog then those panels should show up | 22:04 |
| david-lyle | even if something else was broken | 22:04 |
| kfox1111 | k... not sure why its not then... | 22:04 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 22:05 |
| kfox1111 | are there any other ways panels can get disabled? | 22:05 |
| *** yamamoto has quit IRC | 22:05 | |
| david-lyle | https://github.com/openstack/horizon/blob/2015.1.0/openstack_dashboard/api/sahara.py#L65 is also tolerant of the change | 22:06 |
| kfox1111 | yeah. | 22:06 |
| david-lyle | not unless you've unregistered them in an overrides.py file or something | 22:07 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Improve Cloud Service Directive Documentation https://review.openstack.org/216949 | 22:07 |
| kfox1111 | I'm going to switch the service catalog to the new name and see if that helps. | 22:08 |
| openstackgerrit | Duk Loi proposed openstack/horizon: Enable Redis database cluster support https://review.openstack.org/204630 | 22:08 |
| kfox1111 | that did fix it for some unknown reason. :/ | 22:09 |
| kfox1111 | looks like the failback code isn't entirely working. | 22:09 |
| *** rajatvig has quit IRC | 22:10 | |
| david-lyle | kfox1111: not a good stance for a fallback | 22:10 |
| david-lyle | hmm | 22:10 |
| kfox1111 | heh. yeah. :) | 22:10 |
| kfox1111 | its been one of those few days. :/ | 22:10 |
| kfox1111 | 2015.1.1 rdo somehow introduced some oslo breakage. | 22:11 |
| kfox1111 | oslo_config vs oslo.config being different namespaces but oslo.messaging sharing namespaces with oslo_messaging which uses oslo_config. | 22:11 |
| kfox1111 | really ugly. :/ | 22:11 |
| *** jpomeroy has joined #openstack-horizon | 22:12 | |
| kfox1111 | havent figured out if its an rdo or an upstream thing yet. | 22:12 |
| kfox1111 | wow. in kilo switching projects if you have more then 30 is a lot of steps. :/ | 22:12 |
| lhcheng | kfox1111: I've been hit some oslo breakage too, and xstatic-angular in Juno | 22:13 |
| kfox1111 | I had to patch cinder, ceilometer and trove. Its looking like maybe horizon too. :/ | 22:13 |
| lhcheng | kfox1111: are you getting oslo warning or just error? | 22:14 |
| kfox1111 | errors. its looking for config entries that were registered into oslo_config.cfg in oslo.config.cfg and they are different namespaces. :/ | 22:14 |
| *** vijendar1 has quit IRC | 22:14 | |
| kfox1111 | I'm not sure if its an oslo_config or an oslo_messaging bug either. | 22:15 |
| kfox1111 | and I saw at least one project having both oslo.config and oslo_config imports in the same code base. :/ | 22:15 |
| david-lyle | kfox1111: the OR in the permission check for the panel is right | 22:16 |
| david-lyle | so really not sure why it's not showing up | 22:16 |
| kfox1111 | yeah. really strange. | 22:18 |
| kfox1111 | strange... so if I set webroot = /dashboard, js files break. | 22:21 |
| kfox1111 | but if I set webroot=/ it works but some ajax refresh calls fail... | 22:21 |
| david-lyle | kfox1111: that should have been backported | 22:22 |
| *** SimonChung1 has quit IRC | 22:22 | |
| *** SimonChung has joined #openstack-horizon | 22:22 | |
| david-lyle | but probably to 2015.1.1 | 22:23 |
| david-lyle | IIRC | 22:23 |
| *** SimonChung has quit IRC | 22:23 | |
| *** SimonChung1 has joined #openstack-horizon | 22:23 | |
| kfox1111 | yeah. I just stuck in an extra /dashboard/static link and it fixed it. | 22:24 |
| vishwanathj | david-lyle, lhcheng, I am looking for guidance on how to approach fixing the bug https://bugs.launchpad.net/horizon/+bug/1484723 before I assign it to myself | 22:24 |
| openstack | Launchpad bug 1484723 in OpenStack Dashboard (Horizon) "Form errors does not propogate to the user" [High,Confirmed] | 22:24 |
| kfox1111 | yeah... horizon's mixing oslo_config and oslo.config too. :/ | 22:25 |
| *** btully has joined #openstack-horizon | 22:26 | |
| david-lyle | kfox1111: yeah that was out of our control, dependencies had varying levels of support | 22:26 |
| kfox1111 | k. it really snarled up things. :( | 22:27 |
| kfox1111 | I've got patches. | 22:27 |
| david-lyle | was told it was not a bug at the time that the two version couldn't coexist | 22:28 |
| david-lyle | or something along those lines | 22:28 |
| david-lyle | details now fuzzy, was in the ML | 22:28 |
| david-lyle | go join openstack they said, it will be and adventure they said, see the world | 22:29 |
| david-lyle | s/and/an | 22:29 |
| kfox1111 | here's another one: NetworkError: 404 Not Found - https://dashboard.cloud.pnnl.gov/project/stacks/get_d3_data/d3481bf8-f22f-48a7-b94c-8b0ec6e14799/ | 22:29 |
| kfox1111 | its not putting in /dashboard | 22:29 |
| kfox1111 | but the webroot is /dashboard | 22:29 |
| david-lyle | I fixed that later, may not have backported, checking, will backport if omitted | 22:30 |
| kfox1111 | k. thanks. | 22:30 |
| *** btully has quit IRC | 22:30 | |
| *** hurgleburgler has quit IRC | 22:31 | |
| *** hurgleburgler has joined #openstack-horizon | 22:31 | |
| *** sqchen has quit IRC | 22:34 | |
| *** clu_ has quit IRC | 22:35 | |
| *** Ephur has quit IRC | 22:36 | |
| *** rajatvig has joined #openstack-horizon | 22:39 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Adding row action to delete single image to angular images panel https://review.openstack.org/217949 | 22:39 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: hz-if prefix change to promise directives https://review.openstack.org/217952 | 22:43 |
| david-lyle | kfox1111: https://review.openstack.org/#/c/217951/ | 22:44 |
| tqtran_ | david-lyle: https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/policy.service.js#L75 | 22:46 |
| david-lyle | vishwanathj: actually, can you reproduce on trunk? | 22:46 |
| tqtran_ | im wondering if it makes more sense to just have the server return ok or rejects the call | 22:47 |
| tqtran_ | its a bit cleaner i think, since you dont have to check the response for allowed: true or allowed: false | 22:47 |
| david-lyle | I may have inadvertently fixed that | 22:47 |
| david-lyle | vishwanathj: ^^ | 22:47 |
| david-lyle | tqtran_: the reason that value was in the response was to try and pool the requests later | 22:48 |
| david-lyle | but that could be a separate call | 22:48 |
| tqtran_ | pool the requests? | 22:48 |
| david-lyle | if I ever get back to batch request | 22:48 |
| david-lyle | s/pool/batch/ | 22:48 |
| david-lyle | at this rate looking like 2018 | 22:49 |
| david-lyle | maybe | 22:49 |
| tqtran_ | hm... still not clear how you would batch them together | 22:49 |
| openstackgerrit | KBrown proposed openstack/horizon: Adding row action to delete single image to angular images panel https://review.openstack.org/217949 | 22:49 |
| openstackgerrit | KBrown proposed openstack/horizon: Adding action to delete multiple images to angular images panel https://review.openstack.org/217422 | 22:49 |
| tqtran_ | doesn't the policyRules allow you to batch things already? | 22:49 |
| *** stevemar has quit IRC | 22:50 | |
| tqtran_ | like in your example, you could just add an array of rules. is that what you mean by batching? | 22:50 |
| david-lyle | did I add that? can't remember | 22:50 |
| david-lyle | :( | 22:50 |
| tqtran_ | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/policy.service.js#L48 | 22:50 |
| tqtran_ | yeah line 48 | 22:51 |
| david-lyle | so I did | 22:51 |
| tqtran_ | i guess the reason why im bringing this up now is because im going to write a hz-if-policies directive | 22:51 |
| david-lyle | ok well if you batch, one yes or no may not be enough | 22:52 |
| david-lyle | unless you're asking for all | 22:52 |
| tqtran_ | i think im asking for all | 22:52 |
| david-lyle | some policy checks are ORs | 22:52 |
| tqtran_ | right now, the only response is allowed: true or allowed: false | 22:52 |
| david-lyle | I think the batching in there is just AND and then 200, 401 is fine | 22:53 |
| tqtran_ | so... how would a response look like for an OR | 22:53 |
| *** jwy has quit IRC | 22:53 | |
| david-lyle | I was thinking with a batch request you would take all the actions on a table e.g. and ask at once | 22:53 |
| tqtran_ | couldn't it still be just 200 if ok and 401 if not? | 22:53 |
| david-lyle | less roundtrips | 22:54 |
| tqtran_ | i see.... but that wouldn't work because each step is independent from the table | 22:54 |
| david-lyle | then you would have the response locally cached and just refer to that to show actions | 22:54 |
| david-lyle | step? | 22:54 |
| tqtran_ | ah ok caching.... that would work | 22:54 |
| tqtran_ | https://drive.google.com/file/d/0B5nlaOV3OEj5aVpRaC1sdlgtQ28/view?usp=sharing | 22:54 |
| david-lyle | like I said, never got back to the grander vision | 22:54 |
| tqtran_ | hm.... | 22:56 |
| *** vgridnev has quit IRC | 22:56 | |
| *** stevemar has joined #openstack-horizon | 22:56 | |
| tqtran_ | can we write a batchCheck method for that instead? | 22:57 |
| tqtran_ | so for now, check is only for AND | 22:57 |
| *** cloudtrainme has quit IRC | 22:58 | |
| tqtran_ | and is use for checking for a set of rules that you want either a YES or NO to | 22:58 |
| *** cloudtrainme has joined #openstack-horizon | 22:58 | |
| tqtran_ | the other solution is to write a wrapper for your check method. something like isAllowed which would trigger the check call but use promises to either resolve it or reject it | 22:59 |
| tqtran_ | this way, it works almost like a 200 or a 401 | 23:00 |
| tqtran_ | and would allow me to write the hz-if-policies directive | 23:00 |
| *** jingjing_ren has joined #openstack-horizon | 23:00 | |
| tqtran_ | the directive basically expects a yes or no, and depending on the answer, show the content or not | 23:00 |
| david-lyle | yes, I think it could be a separate method later | 23:01 |
| *** stevemar has quit IRC | 23:01 | |
| *** jwy has joined #openstack-horizon | 23:02 | |
| david-lyle | batch and existing different REST calls that is | 23:02 |
| *** cloudtrainme has quit IRC | 23:04 | |
| tqtran | ok cool, then i'll make those changes | 23:04 |
| *** SimonChung has joined #openstack-horizon | 23:05 | |
| *** SimonChung1 has quit IRC | 23:05 | |
| vishwanathj | david-lyle, sorry was out to go pick up my son from his school, I will try to see if I can reproduce from the trunk | 23:05 |
| *** SimonChung1 has joined #openstack-horizon | 23:06 | |
| *** SimonChung has quit IRC | 23:06 | |
| *** SimonChung has joined #openstack-horizon | 23:06 | |
| *** SimonChung1 has quit IRC | 23:06 | |
| david-lyle | vishwanathj: I'm trying now | 23:09 |
| david-lyle | vishwanathj: what type of errors? | 23:10 |
| david-lyle | for the bug | 23:10 |
| lhcheng | I think just any server side exception in the forms.handle | 23:12 |
| david-lyle | https://github.com/openstack/horizon/blob/master/horizon/forms/__init__.py#L52 | 23:12 |
| david-lyle | was wondering if the fixed comma would help | 23:12 |
| david-lyle | probably not | 23:12 |
| vishwanathj | "Danger: There was an error submitting the form ....." | 23:13 |
| david-lyle | but if it was a validation error, it might make sense | 23:13 |
| lhcheng | something like "try <raise err> except: exception.handle(req, e.message)" | 23:13 |
| david-lyle | coding and stuff? | 23:14 |
| lhcheng | the exception.handle is not rendering the e.message | 23:14 |
| david-lyle | WTH | 23:14 |
| lhcheng | just the message vishwanathj mentioned above | 23:14 |
| david-lyle | ok still there | 23:19 |
| david-lyle | :( | 23:19 |
| *** jpomeroy has quit IRC | 23:19 | |
| david-lyle | it logs the error just fine | 23:20 |
| openstackgerrit | KBrown proposed openstack/horizon: Adding row action to update metadata for an image https://review.openstack.org/217964 | 23:22 |
| david-lyle | vishwanathj: I believe the problem is in horizon/exceptions.py handle() | 23:24 |
| vishwanathj | david-lyle, i see....last time I tried using pycharm debugger, i remember going to that file, but was not sure what the right behavior was supposed to be in that code | 23:28 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Cloud Service directive to check if Service is enabled https://review.openstack.org/212125 | 23:29 |
| *** KunalGandhi has quit IRC | 23:31 | |
| *** kristinebrown has quit IRC | 23:32 | |
| openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 23:33 |
| *** SimonChung1 has joined #openstack-horizon | 23:34 | |
| *** SimonChung has quit IRC | 23:34 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for Metadata Definitions https://review.openstack.org/215721 | 23:34 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 23:35 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Make NG Users table details drawer responsive https://review.openstack.org/217968 | 23:35 |
| *** kristinebrown has joined #openstack-horizon | 23:35 | |
| *** KunalGandhi has joined #openstack-horizon | 23:36 | |
| *** tosky has quit IRC | 23:37 | |
| *** jpomeroy has joined #openstack-horizon | 23:40 | |
| tqtran_ | r1chardj0n3s: ping | 23:40 |
| r1chardj0n3s | tqtran_: hai | 23:40 |
| tqtran_ | r1chardj0n3s: whats the best way to raise an error in the rest api? | 23:40 |
| r1chardj0n3s | tqtran_: which half, server or client? who's to consume the error? | 23:40 |
| tqtran_ | server side | 23:40 |
| tqtran_ | basically, i want to have policy check return either a 200 or a 406 | 23:41 |
| tqtran_ | 401 cant be use because we use that for authorized, which we proceed to kick them out | 23:41 |
| *** kristinebrown has quit IRC | 23:41 | |
| tqtran_ | *unauthored | 23:41 |
| tqtran_ | *unauthorized | 23:41 |
| tqtran_ | >_> i cant spell today | 23:41 |
| r1chardj0n3s | ok, so this is an error to be handled on the client side, raised by the server side | 23:42 |
| tqtran_ | correct | 23:42 |
| r1chardj0n3s | right, so pycharm just crashed ;) | 23:42 |
| r1chardj0n3s | gimme a sec :) | 23:42 |
| tqtran_ | right now, if i return nothing, it defaults to 204 which is ok | 23:42 |
| tqtran_ | no content is fine | 23:42 |
| tqtran_ | but if the result of the policy check is False, then i want to raise this error | 23:43 |
| r1chardj0n3s | yep, this is a case the code implements, I just need to see the code to tell you how, gimme a sec | 23:43 |
| tqtran_ | omg nvm.... | 23:43 |
| tqtran_ | i just saw the code like 3 lines above lol | 23:43 |
| r1chardj0n3s | right, so JSONResponse | 23:43 |
| r1chardj0n3s | you can return one of those with whatever data and response code you wish | 23:43 |
| tqtran_ | rest_utils.AjaxError(406, 'not allowed') | 23:44 |
| tqtran_ | this is what im using | 23:44 |
| r1chardj0n3s | *or* you could raise an AjaxError(status_code, message) if that's easier | 23:44 |
| r1chardj0n3s | ok | 23:44 |
| r1chardj0n3s | returning is cleaner, if you have the option, but if raising is easier then use that :) | 23:45 |
| tqtran_ | :) coolios, thanks | 23:45 |
| *** kristinebrown has joined #openstack-horizon | 23:46 | |
| *** kristinebrown has quit IRC | 23:52 | |
| *** kzaitsev_mb has quit IRC | 23:59 | |
| *** itisha_ has quit IRC | 23:59 | |
| *** itisha has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!