*** ybathia has quit IRC | 00:04 | |
*** rajatvig has quit IRC | 00:04 | |
*** rajatvig has joined #openstack-horizon | 00:06 | |
*** rajatvig has quit IRC | 00:10 | |
*** mtanino has quit IRC | 00:12 | |
*** btully has joined #openstack-horizon | 00:14 | |
*** KunalGandhi has quit IRC | 00:17 | |
*** hinnant_ has quit IRC | 00:17 | |
*** btully has quit IRC | 00:19 | |
*** KunalGandhi has joined #openstack-horizon | 00:22 | |
*** btully has joined #openstack-horizon | 00:22 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Policy check returns HTTP status instead of JSON https://review.openstack.org/217982 | 00:24 |
---|---|---|
*** SimonChung1 has quit IRC | 00:26 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Update Users Table to single HTML https://review.openstack.org/217879 | 00:32 |
*** hurgleburgler has quit IRC | 00:33 | |
*** garthb has quit IRC | 00:34 | |
openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/217533 | 00:36 |
*** jtriley has joined #openstack-horizon | 00:38 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Directive to check if policy check passes https://review.openstack.org/214815 | 00:39 |
*** tqtran_ has quit IRC | 00:41 | |
*** tjones has left #openstack-horizon | 00:46 | |
*** shivrao has quit IRC | 00:53 | |
*** kzaitsev_mb has joined #openstack-horizon | 00:56 | |
openstackgerrit | Merged openstack/horizon: Add 'reverse_lazy' for 'success_url' in admin volume type panel https://review.openstack.org/215426 | 00:57 |
*** zhenguo has joined #openstack-horizon | 00:57 | |
openstackgerrit | Merged openstack/horizon: Moving translation to HTML for launch-instance security-group step https://review.openstack.org/216593 | 00:59 |
*** kzaitsev_mb has quit IRC | 01:00 | |
*** jtriley has quit IRC | 01:00 | |
*** jingjing_ren has quit IRC | 01:06 | |
*** juggler_ has joined #openstack-horizon | 01:07 | |
openstackgerrit | Merged openstack/horizon: Integration tests no longer use form's fields ordering for matching https://review.openstack.org/214238 | 01:07 |
*** juggler_ is now known as juggler | 01:08 | |
*** rajatvig has joined #openstack-horizon | 01:11 | |
*** tqtran has quit IRC | 01:14 | |
*** zhurong has joined #openstack-horizon | 01:14 | |
*** rajatvig has quit IRC | 01:16 | |
openstackgerrit | Merged openstack/manila-ui: Fix set/unset extra specs for share type update form https://review.openstack.org/213106 | 01:16 |
*** DeathScythe74 has joined #openstack-horizon | 01:19 | |
*** jwy has quit IRC | 01:19 | |
DeathScythe74 | Could some one review my fix. https://review.openstack.org/#/c/211242/ | 01:21 |
openstackgerrit | Saksham Varma proposed openstack/horizon: Removing cisco n1kv profile support https://review.openstack.org/218021 | 01:22 |
openstackgerrit | Saksham Varma proposed openstack/horizon: Removing cisco n1kv profile support https://review.openstack.org/218021 | 01:25 |
*** kzaitsev_mb has joined #openstack-horizon | 01:26 | |
*** DeathScythe74 has quit IRC | 01:26 | |
*** darrenc is now known as darrenc_afk | 01:31 | |
*** Daisy has joined #openstack-horizon | 01:33 | |
*** lawrance_ has joined #openstack-horizon | 01:36 | |
*** Daisy has quit IRC | 01:38 | |
*** ducttape_ has joined #openstack-horizon | 01:42 | |
*** jwy has joined #openstack-horizon | 01:44 | |
*** jtriley has joined #openstack-horizon | 01:45 | |
*** darrenc_afk is now known as darrenc | 01:47 | |
*** Daisy_ has joined #openstack-horizon | 01:50 | |
*** jtriley has quit IRC | 01:50 | |
*** lyanchih has joined #openstack-horizon | 01:51 | |
*** liangbo has joined #openstack-horizon | 01:51 | |
*** kzaitsev_mb has quit IRC | 01:52 | |
*** stevemar has joined #openstack-horizon | 01:53 | |
*** Daisy_ has quit IRC | 01:54 | |
openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 01:55 |
*** tjones has joined #openstack-horizon | 01:56 | |
*** sqchen has joined #openstack-horizon | 01:56 | |
*** stevemar has quit IRC | 01:57 | |
*** Daisy_ has joined #openstack-horizon | 01:57 | |
*** Daisy_ has quit IRC | 01:59 | |
*** jingjing_ren has joined #openstack-horizon | 02:00 | |
*** yamamoto has joined #openstack-horizon | 02:03 | |
*** jingjing_ren has quit IRC | 02:04 | |
*** stevemar has joined #openstack-horizon | 02:05 | |
*** htruta has quit IRC | 02:05 | |
*** boltR has quit IRC | 02:05 | |
*** stevemar has quit IRC | 02:07 | |
*** lyanchih has quit IRC | 02:08 | |
*** htruta has joined #openstack-horizon | 02:09 | |
*** KunalGandhi has quit IRC | 02:09 | |
*** shivrao_ has joined #openstack-horizon | 02:10 | |
openstackgerrit | Merged openstack/horizon: py3: Replace unicode with six.text_type https://review.openstack.org/214902 | 02:10 |
*** zhurong_ has joined #openstack-horizon | 02:10 | |
*** lawranc__ has joined #openstack-horizon | 02:10 | |
*** lyanchih has joined #openstack-horizon | 02:12 | |
*** boltR has joined #openstack-horizon | 02:13 | |
*** lawrance_ has quit IRC | 02:13 | |
*** zhurong has quit IRC | 02:13 | |
*** clu_ has joined #openstack-horizon | 02:16 | |
*** yamamoto has quit IRC | 02:17 | |
*** clu_ has quit IRC | 02:18 | |
*** clu_ has joined #openstack-horizon | 02:20 | |
*** raginbajin has quit IRC | 02:23 | |
*** tjones has left #openstack-horizon | 02:23 | |
*** ducttape_ has quit IRC | 02:24 | |
*** sqchen has quit IRC | 02:25 | |
*** raginbajin has joined #openstack-horizon | 02:28 | |
*** saksham has quit IRC | 02:28 | |
*** Drago has quit IRC | 02:35 | |
*** sqchen has joined #openstack-horizon | 02:44 | |
*** sqchen has quit IRC | 02:45 | |
*** lhcheng has quit IRC | 02:46 | |
*** gyee has quit IRC | 02:51 | |
*** yamamoto has joined #openstack-horizon | 02:56 | |
*** rajatvig has joined #openstack-horizon | 02:59 | |
*** jwy has quit IRC | 03:01 | |
*** shivrao_ has quit IRC | 03:03 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 03:06 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 03:07 |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Rename launch instance model file https://review.openstack.org/217922 | 03:07 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 03:08 |
*** lyanchih has quit IRC | 03:08 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Cloud Service directive to check if Service is enabled https://review.openstack.org/212125 | 03:09 |
*** rajatvig has quit IRC | 03:09 | |
*** lyanchih has joined #openstack-horizon | 03:11 | |
*** shivrao has joined #openstack-horizon | 03:20 | |
*** Daisy has joined #openstack-horizon | 03:22 | |
openstackgerrit | Wang Wei proposed openstack/horizon: Fix some grammar mistakes in messages https://review.openstack.org/218074 | 03:26 |
*** Samos123 has quit IRC | 03:26 | |
*** jroll has quit IRC | 03:28 | |
*** mgagne has quit IRC | 03:28 | |
*** darrenc_ has joined #openstack-horizon | 03:28 | |
*** asahlin has quit IRC | 03:28 | |
*** darrenc has quit IRC | 03:28 | |
*** freyes has quit IRC | 03:28 | |
*** neillc has quit IRC | 03:28 | |
*** neillc has joined #openstack-horizon | 03:30 | |
openstackgerrit | Travis Tripp proposed openstack/horizon: Make NG Users table details drawer responsive https://review.openstack.org/217968 | 03:31 |
*** asahlin has joined #openstack-horizon | 03:31 | |
*** Samos123 has joined #openstack-horizon | 03:32 | |
*** jroll has joined #openstack-horizon | 03:32 | |
*** hurgleburgler has joined #openstack-horizon | 03:33 | |
*** freyes has joined #openstack-horizon | 03:33 | |
*** mgagne has joined #openstack-horizon | 03:34 | |
*** lhcheng has joined #openstack-horizon | 03:38 | |
*** lhcheng_ has joined #openstack-horizon | 03:40 | |
*** shivrao has quit IRC | 03:42 | |
*** lawranc__ has quit IRC | 03:43 | |
*** lhcheng has quit IRC | 03:43 | |
*** Daisy has quit IRC | 03:48 | |
*** Daisy has joined #openstack-horizon | 03:49 | |
*** clu_ has quit IRC | 03:51 | |
*** SimonChung has joined #openstack-horizon | 03:52 | |
*** Daisy has quit IRC | 03:53 | |
*** SimonChung1 has joined #openstack-horizon | 03:54 | |
*** SimonChung has quit IRC | 03:57 | |
*** doug-fish has joined #openstack-horizon | 03:58 | |
*** doug-fish has quit IRC | 04:03 | |
*** Daisy has joined #openstack-horizon | 04:05 | |
*** Daisy has quit IRC | 04:10 | |
*** tjones has joined #openstack-horizon | 04:10 | |
*** zhurong_ has quit IRC | 04:13 | |
*** Daisy has joined #openstack-horizon | 04:16 | |
*** Daisy has quit IRC | 04:21 | |
*** Daisy has joined #openstack-horizon | 04:21 | |
*** sqchen has joined #openstack-horizon | 04:21 | |
*** darrenc_ is now known as darrenc | 04:22 | |
*** tjones has left #openstack-horizon | 04:26 | |
*** sayan has joined #openstack-horizon | 04:30 | |
*** frickler has quit IRC | 04:30 | |
*** lyanchih has quit IRC | 04:33 | |
*** amotoki has joined #openstack-horizon | 04:33 | |
TravT | r1chardj0n3s: are you around? | 04:44 |
r1chardj0n3s | TravT: hey | 04:45 |
TravT | i just pulled master | 04:45 |
r1chardj0n3s | yup? | 04:45 |
TravT | ./run_tests.sh --runserver | 04:45 |
TravT | it updated env | 04:45 |
TravT | Collecting XStatic-Angular-Bootstrap>=0.11.0.2 (from -r /home/ttripp/opensource/horizon/requirements.txt (line 36)) | 04:46 |
TravT | Downloading XStatic-angular-bootstrap-0.13.3.1.tar.gz (123kB) | 04:46 |
TravT | 100% |████████████████████████████████| 126kB 4.5MB/s | 04:46 |
r1chardj0n3s | oh ffs, we don't cap | 04:46 |
r1chardj0n3s | I should have checked, I suppose | 04:46 |
r1chardj0n3s | um, so that makes *upgrading to that version* very difficult | 04:46 |
TravT | yeah, so now, i get errors | 04:47 |
r1chardj0n3s | yeah | 04:47 |
r1chardj0n3s | ok, so I'll remove that version and put in a requirements.txt change to limit the versions and then we can sort out the mess | 04:48 |
TravT | ok, sounds lovely | 04:49 |
r1chardj0n3s | "lovely" indeed | 04:49 |
openstackgerrit | Bryan Jen proposed openstack/horizon: Styles and Asset No Longer Necessary https://review.openstack.org/218088 | 04:49 |
*** vgridnev has joined #openstack-horizon | 04:50 | |
*** boltR has quit IRC | 04:51 | |
*** fedexo has joined #openstack-horizon | 04:51 | |
r1chardj0n3s | TravT: release nuked | 04:52 |
TravT | cool. let me retry that... | 04:52 |
openstackgerrit | vishwanath jayaraman proposed openstack/horizon: Add tacker-horizon plugin to plugins registry https://review.openstack.org/218089 | 04:53 |
openstackgerrit | vishwanath jayaraman proposed openstack/horizon: Add tacker-horizon plugin to plugins registry https://review.openstack.org/218089 | 04:55 |
*** vgridnev has quit IRC | 04:55 | |
*** sqchen has quit IRC | 04:56 | |
TravT | r1chardj0n3s: getting error. let me dig further | 04:56 |
TravT | 'horizon/lib/angular/angular-bootstrap.js' could not be found in the COMPRESS_ROOT '/home/ttripp/opensource/horizon/static' or with staticfiles. | 04:56 |
r1chardj0n3s | I've just un-hidden the old release. maybe? | 04:57 |
TravT | scroll buffer too far back for me to see what it pulled | 04:57 |
TravT | i guess i'l just nuke .venv and try again | 04:58 |
*** sqchen has joined #openstack-horizon | 04:59 | |
*** lhcheng has joined #openstack-horizon | 05:00 | |
*** vgridnev has joined #openstack-horizon | 05:00 | |
*** lhcheng_ has quit IRC | 05:01 | |
TravT | r1chardj0n3s: happier now. | 05:01 |
r1chardj0n3s | ok | 05:01 |
TravT | error gone | 05:01 |
r1chardj0n3s | I'm gonna be stopping for the week soon, I'll put "do something about it" on the TODO next week | 05:01 |
*** KingKhan has joined #openstack-horizon | 05:02 | |
TravT | well, i'm thankful you were still on just now. | 05:02 |
r1chardj0n3s | yeah | 05:03 |
*** hurgleburgler has quit IRC | 05:05 | |
*** lyanchih has joined #openstack-horizon | 05:06 | |
*** lhcheng has quit IRC | 05:06 | |
*** zhurong has joined #openstack-horizon | 05:09 | |
*** sqchen has quit IRC | 05:09 | |
*** sqchen has joined #openstack-horizon | 05:10 | |
*** sqchen has quit IRC | 05:13 | |
*** liangbo has quit IRC | 05:14 | |
*** cloudtrainme has joined #openstack-horizon | 05:15 | |
*** liangbo has joined #openstack-horizon | 05:16 | |
*** akrivoka has joined #openstack-horizon | 05:16 | |
*** sqchen has joined #openstack-horizon | 05:16 | |
*** shivrao has joined #openstack-horizon | 05:20 | |
*** Daisy has quit IRC | 05:21 | |
*** Daisy has joined #openstack-horizon | 05:21 | |
*** sqchen has quit IRC | 05:23 | |
*** sqchen has joined #openstack-horizon | 05:24 | |
openstackgerrit | Wang Wei proposed openstack/horizon: Fix some grammar mistakes in messages https://review.openstack.org/218074 | 05:25 |
*** Daisy has quit IRC | 05:26 | |
*** doug-fish has joined #openstack-horizon | 05:27 | |
*** doug-fish has quit IRC | 05:32 | |
*** Daisy has joined #openstack-horizon | 05:32 | |
*** ShivsharanRahul has joined #openstack-horizon | 05:36 | |
*** Daisy has quit IRC | 05:37 | |
*** yamamoto has quit IRC | 05:40 | |
*** Daisy has joined #openstack-horizon | 05:44 | |
*** kzaitsev_mb has joined #openstack-horizon | 05:48 | |
*** yamamoto has joined #openstack-horizon | 05:48 | |
*** Daisy has quit IRC | 05:48 | |
*** Daisy has joined #openstack-horizon | 05:50 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Pin version of Angular-Bootstrap https://review.openstack.org/218102 | 05:52 |
*** Daisy has quit IRC | 05:55 | |
*** Daisy has joined #openstack-horizon | 06:02 | |
*** sqchen has quit IRC | 06:03 | |
*** Daisy has quit IRC | 06:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/218114 | 06:13 |
*** Daisy has joined #openstack-horizon | 06:13 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Add mechanism for hiding multiple failure messages for workflows https://review.openstack.org/140708 | 06:15 |
*** Daisy has quit IRC | 06:18 | |
*** Daisy has joined #openstack-horizon | 06:20 | |
*** zhurong has quit IRC | 06:22 | |
*** Daisy has quit IRC | 06:24 | |
*** zz_ttrifonov is now known as ttrifonov | 06:27 | |
*** Daisy has joined #openstack-horizon | 06:31 | |
*** Daisy has quit IRC | 06:35 | |
*** Daisy has joined #openstack-horizon | 06:36 | |
*** akanksha has joined #openstack-horizon | 06:46 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Put back fixed Sahara integration tests https://review.openstack.org/215127 | 06:46 |
*** mrunge has joined #openstack-horizon | 06:53 | |
*** kzaitsev_mb has quit IRC | 06:55 | |
*** lhcheng has joined #openstack-horizon | 06:55 | |
*** peristeri has joined #openstack-horizon | 06:55 | |
*** lhcheng has quit IRC | 06:59 | |
*** lawrance_ has joined #openstack-horizon | 07:12 | |
*** ygbo has joined #openstack-horizon | 07:30 | |
*** vgridnev has quit IRC | 07:31 | |
*** Daisy has quit IRC | 07:31 | |
*** sayan has quit IRC | 07:40 | |
*** Ala has joined #openstack-horizon | 07:40 | |
*** KingKhan has quit IRC | 07:42 | |
*** bluex-pl has joined #openstack-horizon | 07:42 | |
*** bluex-pl has quit IRC | 07:42 | |
*** Daisy has joined #openstack-horizon | 07:43 | |
*** bluex-pl has joined #openstack-horizon | 07:43 | |
*** Daisy has quit IRC | 07:47 | |
*** Daisy has joined #openstack-horizon | 07:54 | |
*** Daisy has quit IRC | 07:58 | |
*** shivrao has quit IRC | 07:59 | |
*** Daisy has joined #openstack-horizon | 08:10 | |
*** Daisy has quit IRC | 08:10 | |
*** Daisy has joined #openstack-horizon | 08:11 | |
*** cloudtrainme has quit IRC | 08:12 | |
*** Daisy has quit IRC | 08:12 | |
*** ShivsharanRahul has quit IRC | 08:13 | |
*** Daisy_ has joined #openstack-horizon | 08:13 | |
*** KingKhan has joined #openstack-horizon | 08:17 | |
*** kzaitsev_mb has joined #openstack-horizon | 08:17 | |
*** bfic has joined #openstack-horizon | 08:18 | |
*** sayan has joined #openstack-horizon | 08:21 | |
openstackgerrit | Merged openstack/django_openstack_auth: Removing hack for python 2.6 support https://review.openstack.org/178884 | 08:21 |
*** rdopiera has joined #openstack-horizon | 08:25 | |
*** rdopiera has quit IRC | 08:25 | |
*** rdopiera has joined #openstack-horizon | 08:26 | |
*** fedexo has quit IRC | 08:26 | |
*** rdopiera has quit IRC | 08:28 | |
*** rdopiera has joined #openstack-horizon | 08:28 | |
*** lyanchih has quit IRC | 08:29 | |
*** Daisy has joined #openstack-horizon | 08:31 | |
*** Daisy_ has quit IRC | 08:31 | |
*** Daisy has quit IRC | 08:34 | |
*** Daisy has joined #openstack-horizon | 08:35 | |
*** Daisy has quit IRC | 08:39 | |
*** Daisy has joined #openstack-horizon | 08:39 | |
*** bfic has quit IRC | 08:40 | |
*** bfic has joined #openstack-horizon | 08:41 | |
*** bfic1 has joined #openstack-horizon | 08:42 | |
*** zhurong has joined #openstack-horizon | 08:43 | |
*** vgridnev has joined #openstack-horizon | 08:44 | |
*** lhcheng has joined #openstack-horizon | 08:44 | |
*** bfic has quit IRC | 08:45 | |
*** lyanchih has joined #openstack-horizon | 08:47 | |
*** lhcheng has quit IRC | 08:48 | |
*** amit213 has quit IRC | 08:50 | |
*** amit213 has joined #openstack-horizon | 08:51 | |
*** Daisy has quit IRC | 08:52 | |
*** Daisy has joined #openstack-horizon | 08:53 | |
*** Daisy has quit IRC | 08:53 | |
*** Daisy_ has joined #openstack-horizon | 08:53 | |
*** e0ne has joined #openstack-horizon | 08:54 | |
*** kzaitsev_mb has quit IRC | 08:54 | |
*** vgridnev has quit IRC | 09:02 | |
*** e0ne has quit IRC | 09:03 | |
*** exploreshaifali has joined #openstack-horizon | 09:04 | |
*** gparaskevas has joined #openstack-horizon | 09:06 | |
*** tosky has joined #openstack-horizon | 09:07 | |
*** Daisy_ has quit IRC | 09:08 | |
*** Daisy has joined #openstack-horizon | 09:08 | |
*** zhurong has quit IRC | 09:09 | |
*** lyanchih has quit IRC | 09:11 | |
*** Daisy has quit IRC | 09:13 | |
*** ShivsharanRahul has joined #openstack-horizon | 09:14 | |
*** lyanchih has joined #openstack-horizon | 09:14 | |
openstackgerrit | Merged openstack/horizon: SCSS $webroot should inherit from settings.py https://review.openstack.org/206592 | 09:15 |
openstackgerrit | Wang Wei proposed openstack/horizon: Fix some description/grammar mistakes in messages https://review.openstack.org/218074 | 09:19 |
*** Daisy has joined #openstack-horizon | 09:21 | |
*** amotoki has quit IRC | 09:25 | |
*** Daisy has quit IRC | 09:25 | |
*** e0ne has joined #openstack-horizon | 09:25 | |
openstackgerrit | Merged openstack/manila-ui: Remove overrides reference from Manila-UI plug-in https://review.openstack.org/215781 | 09:35 |
*** lyanchih has quit IRC | 09:38 | |
*** akanksha has quit IRC | 09:38 | |
*** lyanchih has joined #openstack-horizon | 09:43 | |
*** wimdc has joined #openstack-horizon | 09:43 | |
openstackgerrit | Merged openstack/horizon: [Sahara] Add support for event logs https://review.openstack.org/158715 | 09:44 |
wimdc | how do I get jenkins checks to run again for https://review.openstack.org/#/c/193079/ -- I tried commenting 'recheck' but that didn't do anything I think | 09:44 |
*** vgridnev has joined #openstack-horizon | 09:56 | |
*** bfic1 has quit IRC | 09:58 | |
*** kiran-r has joined #openstack-horizon | 09:59 | |
*** bfic has joined #openstack-horizon | 10:01 | |
*** bluex-pl has quit IRC | 10:06 | |
*** lawrance_ has quit IRC | 10:06 | |
*** bluex-pl has joined #openstack-horizon | 10:06 | |
*** bluex-pl has quit IRC | 10:07 | |
*** lawrance_ has joined #openstack-horizon | 10:07 | |
*** bluex-pl has joined #openstack-horizon | 10:08 | |
*** bluex-pl has quit IRC | 10:08 | |
*** bluex-pl has joined #openstack-horizon | 10:08 | |
*** bfic has quit IRC | 10:11 | |
openstackgerrit | shubham chitranshi proposed openstack/horizon: Adding Ceilometer Alarm API https://review.openstack.org/215569 | 10:12 |
*** liangbo has quit IRC | 10:15 | |
*** akrivoka has quit IRC | 10:17 | |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Disable button 'create snapshot' if share not snapshottable https://review.openstack.org/213242 | 10:17 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Disable button 'create snapshot' if share not snapshottable https://review.openstack.org/213242 | 10:19 |
openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Disable button 'create snapshot' if share not snapshottable https://review.openstack.org/213242 | 10:20 |
*** mgagne has quit IRC | 10:27 | |
*** Samos123 has quit IRC | 10:27 | |
*** asahlin has quit IRC | 10:27 | |
*** neillc has quit IRC | 10:27 | |
*** darrenc has quit IRC | 10:27 | |
*** juggler has quit IRC | 10:27 | |
*** aix has quit IRC | 10:27 | |
*** neelabh__ has quit IRC | 10:27 | |
*** dsneddon has quit IRC | 10:27 | |
*** jamielennox has quit IRC | 10:27 | |
*** vishwanathj has quit IRC | 10:27 | |
*** rbertram has quit IRC | 10:27 | |
*** kzaitsev_ws has quit IRC | 10:27 | |
*** sayali has quit IRC | 10:27 | |
*** early has quit IRC | 10:27 | |
*** d0ugal has quit IRC | 10:27 | |
*** svasheka has quit IRC | 10:27 | |
*** dguerri` has quit IRC | 10:27 | |
*** ShivsharanRahul has quit IRC | 10:27 | |
*** freyes has quit IRC | 10:27 | |
*** jroll has quit IRC | 10:27 | |
*** btully has quit IRC | 10:27 | |
*** NikitaKonovalov has quit IRC | 10:27 | |
*** krotscheck has quit IRC | 10:27 | |
*** katyafervent has quit IRC | 10:27 | |
*** ShivsharanRahul has joined #openstack-horizon | 10:29 | |
*** freyes has joined #openstack-horizon | 10:29 | |
*** jroll has joined #openstack-horizon | 10:29 | |
*** btully has joined #openstack-horizon | 10:29 | |
*** NikitaKonovalov has joined #openstack-horizon | 10:29 | |
*** krotscheck has joined #openstack-horizon | 10:29 | |
*** katyafervent has joined #openstack-horizon | 10:29 | |
*** kzaitsev_mb has joined #openstack-horizon | 10:29 | |
*** mgagne has joined #openstack-horizon | 10:30 | |
*** Samos123 has joined #openstack-horizon | 10:30 | |
*** asahlin has joined #openstack-horizon | 10:30 | |
*** neillc has joined #openstack-horizon | 10:30 | |
*** darrenc has joined #openstack-horizon | 10:30 | |
*** juggler has joined #openstack-horizon | 10:30 | |
*** aix has joined #openstack-horizon | 10:30 | |
*** neelabh__ has joined #openstack-horizon | 10:30 | |
*** dsneddon has joined #openstack-horizon | 10:30 | |
*** jamielennox has joined #openstack-horizon | 10:30 | |
*** vishwanathj has joined #openstack-horizon | 10:30 | |
*** rbertram has joined #openstack-horizon | 10:30 | |
*** kzaitsev_ws has joined #openstack-horizon | 10:30 | |
*** sayali has joined #openstack-horizon | 10:30 | |
*** early has joined #openstack-horizon | 10:30 | |
*** d0ugal has joined #openstack-horizon | 10:30 | |
*** svasheka has joined #openstack-horizon | 10:30 | |
*** dguerri` has joined #openstack-horizon | 10:30 | |
*** mgagne has quit IRC | 10:30 | |
*** Samos123 has quit IRC | 10:30 | |
*** asahlin has quit IRC | 10:30 | |
*** neillc has quit IRC | 10:30 | |
*** darrenc has quit IRC | 10:30 | |
*** juggler has quit IRC | 10:30 | |
*** aix has quit IRC | 10:30 | |
*** neelabh__ has quit IRC | 10:30 | |
*** dsneddon has quit IRC | 10:30 | |
*** jamielennox has quit IRC | 10:30 | |
*** vishwanathj has quit IRC | 10:30 | |
*** rbertram has quit IRC | 10:30 | |
*** kzaitsev_ws has quit IRC | 10:30 | |
*** sayali has quit IRC | 10:30 | |
*** early has quit IRC | 10:30 | |
*** d0ugal has quit IRC | 10:30 | |
*** svasheka has quit IRC | 10:30 | |
*** dguerri` has quit IRC | 10:30 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: py3: Add json attribute to HTTP response objects https://review.openstack.org/218196 | 10:32 |
*** mgagne has joined #openstack-horizon | 10:32 | |
*** Samos123 has joined #openstack-horizon | 10:32 | |
*** asahlin has joined #openstack-horizon | 10:32 | |
*** neillc has joined #openstack-horizon | 10:32 | |
*** darrenc has joined #openstack-horizon | 10:32 | |
*** juggler has joined #openstack-horizon | 10:32 | |
*** aix has joined #openstack-horizon | 10:32 | |
*** neelabh__ has joined #openstack-horizon | 10:32 | |
*** dsneddon has joined #openstack-horizon | 10:32 | |
*** jamielennox has joined #openstack-horizon | 10:32 | |
*** vishwanathj has joined #openstack-horizon | 10:32 | |
*** rbertram has joined #openstack-horizon | 10:32 | |
*** kzaitsev_ws has joined #openstack-horizon | 10:32 | |
*** sayali has joined #openstack-horizon | 10:32 | |
*** early has joined #openstack-horizon | 10:32 | |
*** d0ugal has joined #openstack-horizon | 10:32 | |
*** svasheka has joined #openstack-horizon | 10:32 | |
*** dguerri` has joined #openstack-horizon | 10:32 | |
*** Samos123 has quit IRC | 10:34 | |
*** Samos123 has joined #openstack-horizon | 10:34 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: Fix Python 3 issues in openstack_dashboard tests https://review.openstack.org/218198 | 10:38 |
robcresswell | wimdc: It looks like it did it. "Jenkins check (1 rechecks)" | 10:39 |
robcresswell | wimdc: It looks like the test failures are relevant too | 10:40 |
*** zhenguo has quit IRC | 10:40 | |
wimdc | yeah, I see now. I was expecting a new folder at http://logs.openstack.org/79/193079/ - was looking wrong | 10:41 |
haypo | rdopiera: hi. i lost your vote when i added the "Partial-Implements: blueprint porting-python3" tag in https://review.openstack.org/#/c/217687/ | 10:43 |
robcresswell | haypo: Patience :p that patch only went up yesterday. | 10:46 |
robcresswell | Cores have lots to do right now. | 10:47 |
*** gparaskevas has quit IRC | 10:47 | |
haypo | robcresswell: ah? you are not paid to review my patches? :-D | 10:47 |
robcresswell | I wish :( | 10:48 |
haypo | rdopiera is now my colleague, it doesn't allow me to harass him? :-D | 10:48 |
robcresswell | lol | 10:48 |
*** bluex-pl has quit IRC | 10:51 | |
*** ShivsharanRahul has quit IRC | 10:51 | |
*** KingKhan has quit IRC | 10:56 | |
*** bfic has joined #openstack-horizon | 10:58 | |
*** akrivoka has joined #openstack-horizon | 11:00 | |
*** bluex-pl has joined #openstack-horizon | 11:01 | |
*** bluex-pl has quit IRC | 11:02 | |
*** bfic has quit IRC | 11:02 | |
*** bluex-pl has joined #openstack-horizon | 11:03 | |
*** bluex-pl has quit IRC | 11:04 | |
*** bluex-pl has joined #openstack-horizon | 11:04 | |
*** bfic has joined #openstack-horizon | 11:05 | |
*** lawrance_ has quit IRC | 11:07 | |
*** ShivsharanRahul has joined #openstack-horizon | 11:09 | |
*** aix has quit IRC | 11:14 | |
*** gparaskevas_ has joined #openstack-horizon | 11:14 | |
*** bfic has quit IRC | 11:15 | |
openstackgerrit | Merged openstack/horizon: Add Storm Job to UI https://review.openstack.org/204647 | 11:19 |
*** bfic has joined #openstack-horizon | 11:19 | |
*** yamamoto has quit IRC | 11:21 | |
*** lyanchih has quit IRC | 11:21 | |
openstackgerrit | Vitaly Gridnev proposed openstack/horizon: Allow multiple clusters creation https://review.openstack.org/198847 | 11:38 |
*** ttrifonov is now known as zz_ttrifonov | 11:49 | |
*** kiran-r has quit IRC | 11:51 | |
*** julim has joined #openstack-horizon | 11:51 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Pay attention to Nova disabled quotas defined in a config file https://review.openstack.org/215277 | 11:52 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Escape RegEx characters from table quick search text https://review.openstack.org/113932 | 11:53 |
*** lawrance_ has joined #openstack-horizon | 11:55 | |
*** petertr7_away is now known as petertr7 | 12:04 | |
*** yamamoto has joined #openstack-horizon | 12:04 | |
*** lblanchard has joined #openstack-horizon | 12:04 | |
*** yamamoto has quit IRC | 12:05 | |
*** yamamoto has joined #openstack-horizon | 12:05 | |
*** yamamoto_ has joined #openstack-horizon | 12:05 | |
*** yamamoto has quit IRC | 12:10 | |
*** ducttape_ has joined #openstack-horizon | 12:13 | |
*** vgridnev has quit IRC | 12:14 | |
*** vgridnev_ has joined #openstack-horizon | 12:14 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Display admin users in project table and detail pages https://review.openstack.org/214220 | 12:15 |
*** ShivsharanRahul has quit IRC | 12:17 | |
*** lawrance_ has quit IRC | 12:19 | |
*** aix has joined #openstack-horizon | 12:24 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Minor refactoring of integration tests https://review.openstack.org/218243 | 12:28 |
*** ducttape_ has quit IRC | 12:32 | |
*** exploreshaifali has quit IRC | 12:32 | |
*** bfic has quit IRC | 12:32 | |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Moving translation to HTML for launch-instance key pair step https://review.openstack.org/215740 | 12:33 |
*** chlong has joined #openstack-horizon | 12:34 | |
*** exploreshaifali has joined #openstack-horizon | 12:37 | |
*** yamamoto_ has quit IRC | 12:39 | |
*** yamamoto has joined #openstack-horizon | 12:39 | |
openstackgerrit | Wim De Clercq proposed openstack/horizon: Add allowed address pair extension UI for neutron ports. https://review.openstack.org/193079 | 12:40 |
*** yamamoto has quit IRC | 12:40 | |
*** exploreshaifali has quit IRC | 12:40 | |
*** exploreshaifali has joined #openstack-horizon | 12:41 | |
*** exploreshaifali has quit IRC | 12:41 | |
*** bluex-pl has quit IRC | 12:42 | |
*** bluex-pl has joined #openstack-horizon | 12:43 | |
*** bluex-pl has quit IRC | 12:43 | |
*** bluex-pl has joined #openstack-horizon | 12:44 | |
*** ShivsharanRahul has joined #openstack-horizon | 12:44 | |
*** bfic has joined #openstack-horizon | 12:44 | |
openstackgerrit | Wim De Clercq proposed openstack/horizon: Add allowed address pair extension UI for neutron ports. https://review.openstack.org/193079 | 12:46 |
*** zul has quit IRC | 12:49 | |
robcresswell | mrunge: Is there a reason why the page headers use different fonts to everything elsee? | 12:49 |
*** zul has joined #openstack-horizon | 12:52 | |
*** pauloewerton has joined #openstack-horizon | 12:53 | |
*** jcoufal has joined #openstack-horizon | 12:53 | |
mrunge | robcresswell, I don't know a reason for this | 12:53 |
robcresswell | :( | 12:55 |
mrunge | robcresswell, I would argue: headers should use the same font | 12:56 |
mrunge | but obviously, I'm not a typographer | 12:56 |
robcresswell | mrunge: Yeah I just reverted it, it is weird that it was ever used. | 12:59 |
robcresswell | Will see what people say | 13:01 |
*** matt-borland has joined #openstack-horizon | 13:04 | |
openstackgerrit | Merged openstack/horizon: Adding clone feature to Transfer Table https://review.openstack.org/211345 | 13:05 |
*** Ephur has joined #openstack-horizon | 13:07 | |
*** lyanchih has joined #openstack-horizon | 13:07 | |
*** Ephur_ has joined #openstack-horizon | 13:08 | |
*** petertr7 is now known as petertr7_away | 13:08 | |
*** lyanchih has quit IRC | 13:08 | |
*** wimdc has quit IRC | 13:08 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Remove secondary font https://review.openstack.org/218260 | 13:09 |
*** bfic has quit IRC | 13:10 | |
*** aix has quit IRC | 13:10 | |
*** Ephur has quit IRC | 13:12 | |
*** petertr7_away is now known as petertr7 | 13:14 | |
*** lapalm has joined #openstack-horizon | 13:15 | |
*** Drago1 has joined #openstack-horizon | 13:16 | |
openstackgerrit | Merged openstack/django_openstack_auth: Fix Python 3 issues https://review.openstack.org/217687 | 13:17 |
*** zz_ttrifonov is now known as ttrifonov | 13:20 | |
*** neelashah has joined #openstack-horizon | 13:22 | |
*** ShivsharanRahul has left #openstack-horizon | 13:23 | |
*** _crobertsrh is now known as crobertsrh | 13:27 | |
*** hurgleburgler has joined #openstack-horizon | 13:29 | |
*** aix has joined #openstack-horizon | 13:29 | |
*** amotoki has joined #openstack-horizon | 13:32 | |
*** gparaskevas_ has quit IRC | 13:33 | |
*** clu_ has joined #openstack-horizon | 13:34 | |
*** clu_ has quit IRC | 13:36 | |
*** jtriley has joined #openstack-horizon | 13:41 | |
openstackgerrit | Merged openstack/tuskar-ui: Replace ironic_discoverd.client with ironic_inspector_client https://review.openstack.org/206088 | 13:42 |
*** garthb has joined #openstack-horizon | 13:45 | |
*** yamamoto has joined #openstack-horizon | 13:46 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Adding option for name and uuid substitution https://review.openstack.org/188422 | 13:47 |
*** gparaskevas has joined #openstack-horizon | 13:47 | |
*** peristeri has quit IRC | 13:49 | |
*** bfic has joined #openstack-horizon | 13:51 | |
*** yamamoto has quit IRC | 13:51 | |
*** bfic has quit IRC | 13:53 | |
*** vgridnev_ has quit IRC | 13:54 | |
*** vgridnev_ has joined #openstack-horizon | 13:54 | |
*** ducttape_ has joined #openstack-horizon | 14:01 | |
*** lyanchih has joined #openstack-horizon | 14:05 | |
openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Support autoconfiguration for templates https://review.openstack.org/207399 | 14:06 |
*** Piet has quit IRC | 14:07 | |
*** exploreshaifali has joined #openstack-horizon | 14:08 | |
*** yamamoto has joined #openstack-horizon | 14:10 | |
*** cloudtrainme has joined #openstack-horizon | 14:15 | |
*** zhenguo has joined #openstack-horizon | 14:22 | |
*** aix has quit IRC | 14:25 | |
openstackgerrit | Matthew D. Wood proposed openstack/horizon: Ajax errors should return correctly. https://review.openstack.org/218293 | 14:26 |
*** yamamoto has quit IRC | 14:28 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: Run a subset of tests on Python 3 https://review.openstack.org/218298 | 14:31 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Do not match table actions by ordering in integration tests https://review.openstack.org/218301 | 14:36 |
*** sayan has quit IRC | 14:38 | |
*** aix has joined #openstack-horizon | 14:38 | |
*** exploreshaifali has quit IRC | 14:39 | |
openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move node processes selection to own tab https://review.openstack.org/197018 | 14:41 |
*** julim has quit IRC | 14:43 | |
*** mtanino has joined #openstack-horizon | 14:44 | |
*** aix has quit IRC | 14:48 | |
*** vijendar has joined #openstack-horizon | 14:50 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Adding manila shares as an option for data sources https://review.openstack.org/214754 | 14:50 |
*** vijendar has quit IRC | 14:50 | |
*** vijendar1 has joined #openstack-horizon | 14:50 | |
*** clu_ has joined #openstack-horizon | 14:51 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Do not match table actions by ordering in integration tests https://review.openstack.org/218301 | 14:51 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Do not match table actions by ordering in integration tests https://review.openstack.org/218301 | 14:59 |
*** aix has joined #openstack-horizon | 15:00 | |
*** vgridnev_ has quit IRC | 15:02 | |
*** gparaskevas has quit IRC | 15:02 | |
*** SimonChung1 has quit IRC | 15:02 | |
*** julim has joined #openstack-horizon | 15:02 | |
*** mtanino has quit IRC | 15:03 | |
*** petertr7 is now known as petertr7_away | 15:04 | |
*** garthb has quit IRC | 15:06 | |
*** jbell8 has joined #openstack-horizon | 15:10 | |
*** rajatvig has joined #openstack-horizon | 15:11 | |
openstackgerrit | Duk Loi proposed openstack/horizon: Trove add cluster grow and shrink support https://review.openstack.org/204743 | 15:12 |
*** geoffarnold has joined #openstack-horizon | 15:13 | |
*** zhenguo has quit IRC | 15:14 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Cloud Service directive to check if Service is enabled https://review.openstack.org/212125 | 15:14 |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Rename launch instance model file https://review.openstack.org/217922 | 15:19 |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 15:19 |
*** cloudtrainme has quit IRC | 15:25 | |
*** cloudtrainme has joined #openstack-horizon | 15:25 | |
*** lhcheng has joined #openstack-horizon | 15:26 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: Fix Python 3 issues in openstack_dashboard tests https://review.openstack.org/218198 | 15:26 |
*** lhcheng has quit IRC | 15:26 | |
*** lhcheng has joined #openstack-horizon | 15:26 | |
*** rajatvig has quit IRC | 15:27 | |
*** yamamoto has joined #openstack-horizon | 15:29 | |
*** jbell8 has quit IRC | 15:31 | |
*** jbell8 has joined #openstack-horizon | 15:31 | |
*** neelabh__ has quit IRC | 15:33 | |
*** yamamoto has quit IRC | 15:34 | |
*** sqchen has joined #openstack-horizon | 15:35 | |
*** jbell8_ has joined #openstack-horizon | 15:36 | |
*** jbell8 has quit IRC | 15:36 | |
*** chlong has quit IRC | 15:39 | |
*** tjones has joined #openstack-horizon | 15:39 | |
openstackgerrit | Matthew D. Wood proposed openstack/horizon: Horizon's list of http exceptions is incomplete https://review.openstack.org/218360 | 15:40 |
*** bluex-pl has quit IRC | 15:40 | |
*** mtanino has joined #openstack-horizon | 15:46 | |
*** sayan has joined #openstack-horizon | 15:46 | |
haypo | rdopiera, robcresswell, david-lyle: what do you think of running a subset of tests which pass on Python 3 for "tox -e py34"? https://review.openstack.org/#/c/218298/ | 15:50 |
haypo | i'm asking because i have a patch serie of 10 patches which depend on this one, and i hesitate to send it | 15:51 |
haypo | all patches are based on https://review.openstack.org/#/c/218298/ :) | 15:51 |
*** sqchen has quit IRC | 15:51 | |
*** sqchen has joined #openstack-horizon | 15:57 | |
*** rajatvig has joined #openstack-horizon | 15:59 | |
*** matt-borland has quit IRC | 15:59 | |
rdopiera | haypo: I'm not sure this is the best way to list those tests | 16:00 |
haypo | rdopiera: ah? | 16:00 |
haypo | rdopiera: do you prefer to list them differently? | 16:00 |
haypo | i just saw that gate-horizon-python34 succeeded with https://review.openstack.org/#/c/218298/ : great! | 16:01 |
rdopiera | haypo: not sure if nose has this, but py.test had a @skipif() decorator | 16:01 |
*** rajatvig has quit IRC | 16:01 | |
haypo | rdopiera: oh wow, you would prefer a blacklist? | 16:01 |
haypo | rdopiera: almost all tests should currently be skipped on python 3 | 16:01 |
rdopiera | haypo: that could be used to skip broken tests for python version >=3.4 | 16:01 |
haypo | rdopiera: the blacklist approach puts more pressure on developers writing new tests | 16:01 |
rdopiera | haypo: or even better, xfail | 16:01 |
*** shivrao has joined #openstack-horizon | 16:02 | |
haypo | rdopiera: they will be "annoyed" by python 3, whereas horizon is not compatible with python 3 | 16:02 |
haypo | well, i'm discussing the case where the py34 gate becomes voting | 16:02 |
rdopiera | well, just adding an @xfail_python3 decorator at the top of a test shouldn't be such an annoyance | 16:02 |
*** shivrao_ has joined #openstack-horizon | 16:03 | |
haypo | rdopiera: i really prefer the whitelist approach. it's easier to maintain the list of tests in a single file (tox.ini) | 16:03 |
rdopiera | it xfail has the additional plus, that when it becomes fixed, the gate will tell you to remove it | 16:03 |
*** Ala has quit IRC | 16:03 | |
haypo | rdopiera: adding a decorator would require to modify too many tests | 16:03 |
*** rajatvig has joined #openstack-horizon | 16:03 | |
haypo | rdopiera: i don't know xfail. what is it? | 16:03 |
rdopiera | haypo: it makes the tests fail if that test passes | 16:04 |
rdopiera | "expected to fail" | 16:04 |
haypo | rdopiera: does it mean that i will break the gate if i port more code to python3? | 16:04 |
*** jbell8_ has quit IRC | 16:04 | |
rdopiera | yes, you will have to unlock the tests that you fix | 16:05 |
rdopiera | that's the advantage | 16:05 |
rdopiera | you won't have tests that you forgot to enable | 16:05 |
*** jbell8 has joined #openstack-horizon | 16:05 | |
*** shivrao has quit IRC | 16:06 | |
*** shivrao_ has quit IRC | 16:07 | |
haypo | rdopiera: it seems more annoying to me :-/ | 16:07 |
rdopiera | embrace the pain ;) | 16:08 |
haypo | rdopiera: i don't care if a test pass but it's not executed by tox | 16:08 |
haypo | rdopiera: there are more practical issues. for example, there 2 bugs in openstack_auth and babel | 16:08 |
haypo | rdopiera: i will have to wait until these modules are fixed | 16:08 |
haypo | rdopiera: if a new version with the fix is released, it will break the gate too. right? | 16:08 |
rdopiera | yeah, I can see how just putting it in a single file is more convenient from the workflow point of view | 16:09 |
rdopiera | and avoids conflicts, etc. | 16:09 |
*** jbell8 has quit IRC | 16:09 | |
haypo | rdopiera: FYI the same whitelist approach is used in all other openstack projects. nova, glance, cinder, heat, keystone, etc. | 16:11 |
*** kzaitsev_mb has quit IRC | 16:11 | |
haypo | with a similir syntax in tox.ini | 16:11 |
haypo | ceilometer used the whitelist approach. good news: they removed the list because all tests now pass on Python 3 ;) | 16:12 |
*** kiran-r has joined #openstack-horizon | 16:13 | |
*** SimonChung has joined #openstack-horizon | 16:15 | |
rdopiera | haypo: yeah, I guess I still can't switch from the mindset of a single developer working on his own code | 16:16 |
openstackgerrit | Victor Stinner proposed openstack/horizon: py3: Add json attribute to HTTP response objects https://review.openstack.org/218196 | 16:18 |
haypo | rdopiera: ok, here is an example. the idea is that following patches will add new tests to tox.ini: https://review.openstack.org/#/c/218196/2/tox.ini | 16:20 |
haypo | the major issue with that is that concurrent patches are likely to conflict on tox.ini... | 16:20 |
haypo | a workaround is to work on a patch serie | 16:21 |
haypo | but i prefer to work on "independent" patches | 16:21 |
rdopiera | you can always add the passing tests in a separate patch | 16:21 |
rdopiera | when a particular serie has been merged | 16:22 |
haypo | rdopiera: no. i want to use gerrit py34 gate to ensure that my patch fixes a real test file | 16:22 |
*** chlong has joined #openstack-horizon | 16:22 | |
*** petertr7_away is now known as petertr7 | 16:22 | |
haypo | the idea is to show that we slowly increase the test coverage on python3, and each change contributes to that | 16:22 |
*** garthb has joined #openstack-horizon | 16:23 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: Port dashboard api access tests to Python 3 https://review.openstack.org/218381 | 16:23 |
*** yamamoto has joined #openstack-horizon | 16:24 | |
*** vgridnev has joined #openstack-horizon | 16:24 | |
*** kiran-r has quit IRC | 16:25 | |
lhcheng | david-lyle: ping | 16:26 |
haypo | rdopiera: ok, i have 3 pending patches. i keep the other ones locally before seeing what happens on these patches ;) | 16:27 |
haypo | https://review.openstack.org/218298 https://review.openstack.org/218381 https://review.openstack.org/218196 | 16:27 |
haypo | the latest is the largest one, it ports 9 test files: all xxx_rest_tests | 16:27 |
*** e0ne has quit IRC | 16:28 | |
*** doug-fish has joined #openstack-horizon | 16:29 | |
*** doug-fish has quit IRC | 16:30 | |
*** exploreshaifali has joined #openstack-horizon | 16:34 | |
*** tqtran has joined #openstack-horizon | 16:34 | |
*** mrunge has quit IRC | 16:37 | |
*** matt-borland has joined #openstack-horizon | 16:37 | |
*** tqtran_ has joined #openstack-horizon | 16:37 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Cloud Service directive to check if Service is enabled https://review.openstack.org/212125 | 16:39 |
*** clu_ has quit IRC | 16:42 | |
*** chlong has quit IRC | 16:45 | |
*** sqchen has quit IRC | 16:50 | |
*** petertr7 is now known as petertr7_away | 16:50 | |
*** petertr7_away is now known as petertr7 | 16:52 | |
*** tjones has left #openstack-horizon | 16:52 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 16:57 |
*** mtanino has quit IRC | 17:00 | |
*** SimonChung1 has joined #openstack-horizon | 17:02 | |
*** SimonChung has quit IRC | 17:02 | |
*** julim has quit IRC | 17:06 | |
*** julim has joined #openstack-horizon | 17:09 | |
*** woodm19791 has joined #openstack-horizon | 17:10 | |
woodm19791 | Is there anyone here that can take a look at a review for me. I'm not looking for +2s or anything like that, I'm more looking for "this is not a good idea at all" or "Don't forget about this case…" type suggestions. https://review.openstack.org/#/c/218293/ | 17:12 |
kfox1111 | has anyone sen creating a sahara node group template take a very long time to show the dialog in chrome but not firefox on a kilo horizon? | 17:13 |
*** shivrao has joined #openstack-horizon | 17:15 | |
*** lapalm has quit IRC | 17:15 | |
*** lapalm has joined #openstack-horizon | 17:15 | |
*** rajatvig_ has joined #openstack-horizon | 17:16 | |
*** rajatvig has quit IRC | 17:16 | |
*** e0ne has joined #openstack-horizon | 17:18 | |
*** lapalm has quit IRC | 17:20 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add API services for system information https://review.openstack.org/205196 | 17:20 |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 17:20 |
*** aix has quit IRC | 17:20 | |
*** jbell8 has joined #openstack-horizon | 17:22 | |
*** kristinebrown has joined #openstack-horizon | 17:27 | |
*** sqchen has joined #openstack-horizon | 17:27 | |
*** ericpeterson has joined #openstack-horizon | 17:28 | |
*** eandersson has quit IRC | 17:29 | |
woodm19791 | Whoa, thanks for the once-over Thai. | 17:30 |
woodm19791 | Much appreciated. | 17:30 |
*** ducttape_ has quit IRC | 17:30 | |
tqtran_ | drive by as travis puts it lol | 17:32 |
*** jbell8 has quit IRC | 17:32 | |
*** e0ne has quit IRC | 17:33 | |
*** jingjing_ren has joined #openstack-horizon | 17:33 | |
*** jingjing_ren has quit IRC | 17:33 | |
*** ericpeterson has quit IRC | 17:34 | |
*** jingjing_ren has joined #openstack-horizon | 17:34 | |
*** ducttape_ has joined #openstack-horizon | 17:34 | |
*** jbell8 has joined #openstack-horizon | 17:34 | |
*** ducttape_ has quit IRC | 17:40 | |
*** ducttape_ has joined #openstack-horizon | 17:41 | |
*** rdopiera has quit IRC | 17:43 | |
*** ybathia has joined #openstack-horizon | 17:43 | |
openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Support autoconfiguration for templates https://review.openstack.org/207399 | 17:48 |
*** e0ne has joined #openstack-horizon | 17:55 | |
*** jingjing_ren has quit IRC | 18:00 | |
*** jingjing_ren has joined #openstack-horizon | 18:02 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 18:06 |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Add angular defaults panel for admin https://review.openstack.org/205296 | 18:06 |
*** tjones has joined #openstack-horizon | 18:11 | |
openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Move cluster configuration to separate tab https://review.openstack.org/197965 | 18:13 |
*** aix has joined #openstack-horizon | 18:14 | |
*** ygbo has quit IRC | 18:15 | |
*** wolverineav has joined #openstack-horizon | 18:18 | |
*** exploreshaifali has quit IRC | 18:21 | |
*** dsneddon has quit IRC | 18:21 | |
*** saksham has joined #openstack-horizon | 18:23 | |
*** mtanino has joined #openstack-horizon | 18:23 | |
*** rajatvig_ has quit IRC | 18:23 | |
*** akrivoka has quit IRC | 18:25 | |
*** kristinebrown has quit IRC | 18:25 | |
*** rajatvig has joined #openstack-horizon | 18:26 | |
*** lapalm has joined #openstack-horizon | 18:26 | |
*** dsneddon has joined #openstack-horizon | 18:26 | |
*** amotoki has quit IRC | 18:31 | |
*** lyanchih has quit IRC | 18:32 | |
*** lyanchih has joined #openstack-horizon | 18:33 | |
openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Adding ability to update is_proxy_gateway field https://review.openstack.org/207893 | 18:34 |
*** jwy has joined #openstack-horizon | 18:36 | |
*** rajatvig has quit IRC | 18:36 | |
*** rajatvig has joined #openstack-horizon | 18:38 | |
*** e0ne has quit IRC | 18:42 | |
*** jbell8 has quit IRC | 18:42 | |
*** clu_ has joined #openstack-horizon | 18:45 | |
*** woodm19791 has quit IRC | 18:46 | |
*** exploreshaifali has joined #openstack-horizon | 18:47 | |
*** ducttape_ has quit IRC | 18:49 | |
*** jingjing_ren has quit IRC | 18:49 | |
*** jbell8 has joined #openstack-horizon | 18:50 | |
*** jingjing_ren has joined #openstack-horizon | 18:51 | |
*** jingjing_ren has quit IRC | 18:55 | |
*** Drago1 has quit IRC | 18:58 | |
*** jcoufal has quit IRC | 18:59 | |
*** tjones has left #openstack-horizon | 19:00 | |
*** jbell8 has quit IRC | 19:01 | |
*** saksham has quit IRC | 19:02 | |
*** jbell8 has joined #openstack-horizon | 19:03 | |
*** ducttape_ has joined #openstack-horizon | 19:04 | |
*** stevemar has joined #openstack-horizon | 19:08 | |
openstackgerrit | David Lyle proposed openstack/django_openstack_auth: Add domain scoped token to session in multidomain https://review.openstack.org/141153 | 19:10 |
*** Drago has joined #openstack-horizon | 19:15 | |
*** ducttape_ has quit IRC | 19:16 | |
*** lyanchih has quit IRC | 19:17 | |
tqtran_ | TravT, rajatvig: any patches you guys need reviews on? i am waiting on a patch to merge before i can do anything | 19:19 |
TravT | yes | 19:19 |
TravT | let me give you a few | 19:20 |
*** jingjing_ren has joined #openstack-horizon | 19:20 | |
TravT | i addressed you comments on this one: | 19:21 |
TravT | https://review.openstack.org/#/c/216949/ | 19:21 |
TravT | and broke out the dependent patch as discussed | 19:21 |
TravT | https://review.openstack.org/#/c/217952/ | 19:21 |
openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 19:24 |
*** jingjing_ren has quit IRC | 19:25 | |
tqtran_ | done BAM! | 19:27 |
TravT | tqtran_: i also put an initial pass at magic search on images: https://review.openstack.org/#/c/217437/ | 19:29 |
tqtran_ | i'll take a look and steal the code if it works :P | 19:29 |
TravT | i'm going through the action comments you left on that action patches last night right now. | 19:30 |
*** jbell8 has quit IRC | 19:31 | |
rajatvig | tqtran_: I've magic search related patch up at https://review.openstack.org/#/c/201582/ | 19:35 |
openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 19:35 |
rajatvig | I've enough feedback on the Images related patches to work for. | 19:35 |
*** devlaps has joined #openstack-horizon | 19:37 | |
rajatvig | tqtran_: I could also do with a review on https://review.openstack.org/#/c/212125/ | 19:38 |
tqtran_ | ok looking | 19:38 |
openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Adding ability to update is_proxy_gateway field https://review.openstack.org/207893 | 19:38 |
rajatvig | tqtran_: thanks | 19:40 |
*** ducttape_ has joined #openstack-horizon | 19:41 | |
*** Piet has joined #openstack-horizon | 19:42 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: Remove unused LaunchInstanceSourceHelpController in HTML https://review.openstack.org/218444 | 19:43 |
*** stevemar has quit IRC | 19:44 | |
*** stevemar has joined #openstack-horizon | 19:44 | |
*** stevemar has quit IRC | 19:44 | |
*** jingjing_ren has joined #openstack-horizon | 19:48 | |
*** stevemar has joined #openstack-horizon | 19:49 | |
*** stevemar has quit IRC | 19:49 | |
*** jcoufal has joined #openstack-horizon | 19:52 | |
*** stevemar has joined #openstack-horizon | 19:55 | |
*** tjones has joined #openstack-horizon | 19:59 | |
*** ericpeterson has joined #openstack-horizon | 20:01 | |
*** amrith has joined #openstack-horizon | 20:02 | |
*** amrith has left #openstack-horizon | 20:03 | |
*** ducttape_ has quit IRC | 20:04 | |
sjmc7 | hi david-lyle! i have a question about the enabled/ and local/enabled/ system. if, for a given distribution, i want to disable one of the in-built panels ('network' to pick a random example) | 20:05 |
sjmc7 | what's the recommended way to do it? drop a file in local/enabled disabling it? | 20:05 |
*** ducttape_ has joined #openstack-horizon | 20:06 | |
sjmc7 | previously i'd have probably added a 'remove' file to enabled/ but that gets a bit odd if there are explicit enabling files as well | 20:06 |
*** petertr7 is now known as petertr7_away | 20:06 | |
sjmc7 | and i'm not keen on editing stuff that's in source control | 20:06 |
*** kzaitsev_mb has joined #openstack-horizon | 20:07 | |
*** ericpeterson has quit IRC | 20:08 | |
*** hurgleburgler has quit IRC | 20:08 | |
ducttape_ | https://github.com/openstack/horizon/blob/master/openstack_dashboard/enabled/_60_admin_remove_panel.py.example sjmc7 | 20:08 |
*** hurgleburgler has joined #openstack-horizon | 20:09 | |
ducttape_ | you'd make a copy of that file, rename it to .py file, and modify as needed | 20:09 |
sjmc7 | networks was a bad example. if it's one that already exists in there, say for databases | 20:09 |
sjmc7 | would you edit the one that's in there already? | 20:09 |
david-lyle | sjmc7: no local should override | 20:10 |
sjmc7 | ok, so i can leave _1720_project_databases_panel.py and add one in local/enabled that'll remove it? | 20:10 |
david-lyle | been a little bit since I played with it | 20:10 |
david-lyle | let me dig up my slides | 20:10 |
david-lyle | see if I made it clear to myself :P | 20:10 |
sjmc7 | i can test it out, didn't mean to distract you | 20:10 |
david-lyle | sjmc7: yeah same file name in local with DISABLED = True should do the trick | 20:12 |
sjmc7 | ok | 20:13 |
sjmc7 | thanks! | 20:13 |
*** sqchen has quit IRC | 20:14 | |
*** jtomasek has quit IRC | 20:15 | |
kfox1111 | has anyone seen creating a sahara node group template take a very long time to show the dialog in chrome but not firefox on a kilo horizon? | 20:15 |
*** lhcheng has quit IRC | 20:15 | |
david-lyle | kfox1111: I have not, but I can try in a sec | 20:16 |
kfox1111 | k. thx. | 20:16 |
* david-lyle mostly using ff | 20:16 | |
kfox1111 | yeah. me too. didn't notice until a user mentioned it. | 20:16 |
david-lyle | kfox1111: as part of the guide or not? | 20:21 |
david-lyle | and you're probably on Kilo not master :( | 20:21 |
david-lyle | worked fine in guide on master in chrome | 20:21 |
david-lyle | will try standalone | 20:21 |
david-lyle | standalone fast too | 20:22 |
david-lyle | but again on master | 20:22 |
david-lyle | debugging something now, but can try on kilo in a bit | 20:22 |
kfox1111 | non guide, node group templates -> create template, | 20:23 |
kfox1111 | vanilla 1.2.1 next, then pausees for a while with a spinner. | 20:23 |
kfox1111 | yeah. horizon 2015.1.0. :/ | 20:23 |
david-lyle | will try with hadoop | 20:23 |
kfox1111 | k. | 20:23 |
david-lyle | bingo hadoop slower | 20:24 |
kfox1111 | hmm... | 20:24 |
david-lyle | but not super slow | 20:24 |
kfox1111 | yeah. was a little slow in firefox, | 20:25 |
kfox1111 | it was over a minute on chrome. | 20:25 |
*** julim has quit IRC | 20:25 | |
kfox1111 | hmm.. jus ttried it again, and it was like 10 seconds... | 20:26 |
david-lyle | making a nova flavors call before loading | 20:26 |
david-lyle | and az call | 20:26 |
kfox1111 | maybe a user was just hammering it at just the wrong times. | 20:26 |
david-lyle | but that's the same across browsers | 20:26 |
kfox1111 | it was consistant for a little while there though. | 20:27 |
*** exploreshaifali has quit IRC | 20:28 | |
david-lyle | taking long time for me now | 20:28 |
kfox1111 | wonder if chrome's serializing more the firefox or something. | 20:28 |
david-lyle | hanging badly now | 20:29 |
kfox1111 | leave it for a bit. | 20:29 |
kfox1111 | it eventually seems to recover. | 20:29 |
kfox1111 | but its long enough that a user wrote me a while email before seeign it recover. | 20:30 |
david-lyle | got the XHR response | 20:30 |
david-lyle | just hanging | 20:30 |
david-lyle | now it's up | 20:30 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Adding row action to delete single image to angular images panel https://review.openstack.org/217949 | 20:30 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Adding row action to update metadata for an image https://review.openstack.org/217964 | 20:30 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Adding action to delete multiple images to angular images panel https://review.openstack.org/217422 | 20:30 |
kfox1111 | yeah. very strange. | 20:30 |
david-lyle | my system is low on memory though, could be worse memory wise | 20:31 |
david-lyle | (shrug) | 20:31 |
david-lyle | I didn't see any JS errors or network glitches though | 20:31 |
david-lyle | I think Chrome is just "optimizing" | 20:31 |
kfox1111 | yeah. its seems to be done doing whatever its doing. it just pauses for a while and then recovers. | 20:34 |
kfox1111 | its almost like something times out, then continues on. | 20:34 |
kfox1111 | but doesn't look like there are any outstanding requests. | 20:35 |
*** tjones has quit IRC | 20:36 | |
*** sqchen has joined #openstack-horizon | 20:37 | |
*** tjones has joined #openstack-horizon | 20:38 | |
*** stevemar has quit IRC | 20:39 | |
*** kzaitsev_mb has quit IRC | 20:43 | |
*** SimonChung has joined #openstack-horizon | 20:43 | |
*** SimonChung1 has quit IRC | 20:43 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:44 | |
*** SimonChung1 has joined #openstack-horizon | 20:44 | |
*** SimonChung has quit IRC | 20:44 | |
kfox1111 | has anyone throught through how one plugin might optionaly depend on another's angular services? | 20:48 |
*** lhcheng has joined #openstack-horizon | 20:48 | |
*** kzaitsev_mb has quit IRC | 20:50 | |
*** saksham has joined #openstack-horizon | 20:52 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:54 | |
*** kzaitsev_mb has quit IRC | 21:00 | |
*** tjones has left #openstack-horizon | 21:01 | |
*** jtriley has quit IRC | 21:02 | |
*** SimonChung1 has quit IRC | 21:04 | |
*** SimonChung has joined #openstack-horizon | 21:04 | |
*** kzaitsev_mb has joined #openstack-horizon | 21:04 | |
*** lblanchard has quit IRC | 21:07 | |
tqtran_ | kfox1111: as in you have more than 1 plugins and they have an inner dependence? | 21:13 |
*** ducttape_ has quit IRC | 21:13 | |
*** jingjing_ren has quit IRC | 21:17 | |
*** stevemar has joined #openstack-horizon | 21:18 | |
*** crobertsrh is now known as _crobertsrh | 21:19 | |
*** sqchen has quit IRC | 21:21 | |
*** lapalm has quit IRC | 21:22 | |
*** jingjing_ren has joined #openstack-horizon | 21:23 | |
kfox1111 | tqtran_: more specifically, say murano-dashboard plugin provides an angular rest based service. | 21:23 |
kfox1111 | and the app catalog ui plugin wants to use it, if its loaded. but its ok if its not. | 21:24 |
*** matt-borland has quit IRC | 21:24 | |
tqtran_ | you can attempt to load the module via an injector | 21:25 |
tqtran_ | and surround that with try/catch | 21:25 |
kfox1111 | yeah. I did find http://stackoverflow.com/questions/18542032/optional-dependencies-in-angularjs a few minutes ago. was going to try it. | 21:25 |
*** kzaitsev_mb has quit IRC | 21:29 | |
*** tjones has joined #openstack-horizon | 21:29 | |
*** kzaitsev_mb has joined #openstack-horizon | 21:35 | |
*** neelashah has quit IRC | 21:37 | |
*** cbader has quit IRC | 21:40 | |
*** sqchen has joined #openstack-horizon | 21:45 | |
*** jingjing_ren has quit IRC | 21:52 | |
*** clu_ has quit IRC | 21:53 | |
TravT | https://review.openstack.org/#/c/217968/ | 21:58 |
*** tjones has quit IRC | 21:59 | |
*** jingjing_ren has joined #openstack-horizon | 22:02 | |
*** alanf has joined #openstack-horizon | 22:04 | |
*** vijendar1 has quit IRC | 22:05 | |
*** tjones has joined #openstack-horizon | 22:06 | |
*** ybathia has quit IRC | 22:06 | |
*** tjones has left #openstack-horizon | 22:09 | |
*** kzaitsev_mb has quit IRC | 22:15 | |
*** kzaitsev_mb has joined #openstack-horizon | 22:16 | |
*** jingjing_ren has quit IRC | 22:17 | |
*** vgridnev has quit IRC | 22:19 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Limit version of Angular-Bootstrap https://review.openstack.org/218102 | 22:26 |
*** kzaitsev_mb has quit IRC | 22:26 | |
r1chardj0n3s | if cores who are waiting for patches to gate could glance at that it'd be nice :) | 22:26 |
*** kzaitsev_mb has joined #openstack-horizon | 22:26 | |
r1chardj0n3s | also, david-lyle, I think I forgot to mention https://review.openstack.org/#/c/218068/ which promotes the working experimental selenium zuul job up to non-voting | 22:28 |
r1chardj0n3s | needs another infra core tho | 22:29 |
kfox1111 | is there a prefered way to register a rest api with horizon in a plugin? | 22:29 |
r1chardj0n3s | (so it turns out that no-one actually disabled selenium, it just broke one day and I think everyone just assumed that someone had disabled it...) | 22:29 |
*** SimonChung1 has joined #openstack-horizon | 22:31 | |
*** SimonChung has quit IRC | 22:31 | |
*** SimonChung has joined #openstack-horizon | 22:33 | |
*** SimonChung1 has quit IRC | 22:33 | |
TravT | david-lyle | 22:34 |
TravT | tqtran_ is proposing some changes on the policy check | 22:34 |
TravT | maybe you can take a look before i do? | 22:35 |
TravT | https://review.openstack.org/#/c/217982/ | 22:35 |
kfox1111 | so, for example, I'm trying to port the api/rest/glance.py to a murano one, living in the murano plugin. | 22:35 |
kfox1111 | how would I register that url handler since its not in a panel? | 22:35 |
*** kristinebrown has joined #openstack-horizon | 22:36 | |
tqtran_ | if you installed murano plugin, the path should be available | 22:36 |
tqtran_ | its a python file, so not sure what you mean by path? | 22:36 |
TravT | kfox1111: not sure what you mean? | 22:36 |
tqtran_ | oh i see, place rest api | 22:37 |
tqtran_ | *glance | 22:37 |
david-lyle | TravT: we talked about it yesterday, but I'm wonder if 406 is a misuse of the HTTP code, as it has to do with accept headers | 22:37 |
tqtran_ | so yeah, if you install the murano plugin, the path should be available | 22:37 |
david-lyle | it's simpler, just not sure it's correct | 22:37 |
david-lyle | after more thought | 22:38 |
kfox1111 | so, I made a directory: | 22:38 |
kfox1111 | kfox2@mantis:~/svn/murano-dashboard/muranodashboard$ ls api/rest/ | 22:38 |
kfox1111 | __init__.py packages.py urls.py | 22:38 |
tqtran_ | david-lyle: what is it usually? | 22:38 |
*** kristinebrown has quit IRC | 22:38 | |
tqtran_ | 401? | 22:38 |
kfox1111 | how do I ensure it gets loaded? or does horizon when loading a plugin search for all url.py's? | 22:38 |
TravT | 403? | 22:39 |
david-lyle | problem with 401 is you are actually authorized to make the call, it just happens that the response is false | 22:39 |
tqtran_ | right, so im not sure which code to use | 22:39 |
tqtran_ | http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html | 22:39 |
david-lyle | that's what I'm saying, I think that's a misuse of REST | 22:39 |
kfox1111 | all the other urls.py files I think are loaded through having them registered in dashboard.py | 22:40 |
tqtran_ | well maybe, for calls that are OK, rest can return nothing | 22:40 |
david-lyle | you are misappropriating an HTTP result code to convey a different meaning | 22:40 |
*** kristinebrown has joined #openstack-horizon | 22:41 | |
*** kristinebrown has quit IRC | 22:41 | |
tqtran_ | so lets say when i perform a delete action, and rest returns blank with a 204 | 22:42 |
tqtran_ | what if i dont have permission to perform this action? | 22:42 |
tqtran_ | how does rest normally handle this? | 22:43 |
TravT | does this change make the batch policy checks harder (in the future)? | 22:43 |
*** ducttape_ has joined #openstack-horizon | 22:44 | |
*** jingjing_ren has joined #openstack-horizon | 22:44 | |
david-lyle | 204 could be success, but there is no HTTP status code for just "no" or false | 22:45 |
tqtran_ | right, ok so another way is to just write a wrapper for your response and use defer to either resolve or reject | 22:45 |
tqtran_ | would you prefer that solution more? | 22:46 |
*** ybathia has joined #openstack-horizon | 22:46 | |
tqtran_ | http://chariotsolutions.com/blog/post/angularjs-corner-using-promises-q-handle-asynchronous-calls/ | 22:48 |
tqtran_ | heres a good article explaning what defer and promises do | 22:48 |
*** ducttape_ has quit IRC | 22:48 | |
*** jingjing_ren has quit IRC | 22:49 | |
*** kristinebrown has joined #openstack-horizon | 22:49 | |
*** ducttape_ has joined #openstack-horizon | 22:49 | |
david-lyle | tqtran_: but that's still status code based, no? | 22:49 |
tqtran_ | nope | 22:49 |
*** Drago has quit IRC | 22:49 | |
*** ybathia has quit IRC | 22:49 | |
tqtran_ | its base on your response | 22:49 |
tqtran_ | so basically, it catches your response, checks if it is true or false | 22:50 |
tqtran_ | then return defer.resolve() for true and defer.reject() for false | 22:50 |
tqtran_ | then subsequent handlers can deal with it | 22:50 |
TravT | tqtran, i think you'd be able to just copy the following lines | 22:50 |
TravT | https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/nova-extensions.service.js#L64-L85 | 22:50 |
TravT | you can just wrap the existing API | 22:51 |
openstackgerrit | Merged openstack/horizon: A few fixes to make the App Catalog plugin work. https://review.openstack.org/206773 | 22:51 |
TravT | and not argue over response codes... | 22:51 |
*** ybathia has joined #openstack-horizon | 22:52 | |
*** stevemar has quit IRC | 22:52 | |
*** kristinebrown has quit IRC | 22:52 | |
TravT | of course change to look at the response of success or not... not the nova extension. | 22:53 |
david-lyle | I'm ok with doing a response based switch | 22:53 |
*** stevemar has joined #openstack-horizon | 22:53 | |
david-lyle | and leave the status at 200 | 22:53 |
tqtran_ | ok, so keep policy the same then and just have a wrapper | 22:53 |
david-lyle | I have to run for the evening, sorry for change of mind tqtran_ | 22:53 |
david-lyle | yeah, what you just said | 22:54 |
TravT | ifPolicyAllowed | 22:54 |
tqtran_ | np im just crying a littlie inside | 22:54 |
TravT | .then | 22:54 |
david-lyle | I'm ok with that :D | 22:54 |
david-lyle | have a good weekend | 22:54 |
tqtran_ | lol | 22:54 |
tqtran_ | you too | 22:54 |
david-lyle | thanks | 22:54 |
david-lyle | later | 22:54 |
TravT | have a good weekend | 22:55 |
*** alanf has quit IRC | 22:56 | |
*** stevemar has quit IRC | 22:57 | |
*** ericpeterson has joined #openstack-horizon | 22:58 | |
*** ducttape_ has quit IRC | 22:58 | |
*** hurgleburgler has left #openstack-horizon | 23:00 | |
*** jamielennox is now known as jamielennox|away | 23:00 | |
kfox1111 | david-lyle/tqtran: the app catalog patches just merged! Thanks for all the help, and putting up with me. :) | 23:02 |
*** alanf has joined #openstack-horizon | 23:04 | |
*** sayan has quit IRC | 23:12 | |
haypo | david-lyle: hi. are you still around? i would like to know your opinion on https://review.openstack.org/#/c/218298/ : having a whitelist of tests which pass on Python 3.4 in tox.ini | 23:13 |
*** ericpeterson has quit IRC | 23:14 | |
*** mtanino has quit IRC | 23:21 | |
*** SimonChung has quit IRC | 23:21 | |
*** david-lyle has quit IRC | 23:24 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Adding action to delete multiple images to angular images panel https://review.openstack.org/217422 | 23:24 |
*** tosky has quit IRC | 23:26 | |
*** tjones has joined #openstack-horizon | 23:27 | |
*** vishwanathj has quit IRC | 23:28 | |
*** garthb has quit IRC | 23:32 | |
kfox1111 | tqtran_: https://review.openstack.org/218515 can you please have a look. I'm trying to hook up muranodashboard/api/rest/* into horizon so anuglarjs can call it. I'm not sure where to hook it in though. | 23:32 |
tqtran_ | kfox1111: question, is the murano rest api in the murano plugin? | 23:35 |
kfox1111 | yeah. | 23:35 |
kfox1111 | this patch is to the murano plugin itself, so that it provides a rest service for murano. | 23:37 |
*** lhcheng has quit IRC | 23:37 | |
kfox1111 | once thats working, I'll further extend it to provide an angularjs service to match. | 23:37 |
*** stevemar has joined #openstack-horizon | 23:42 | |
*** ybathia has quit IRC | 23:43 | |
tqtran_ | hm... that is a good question kevin | 23:43 |
kfox1111 | may not currently be possible? :/ | 23:43 |
tqtran_ | i dont know, have to try and see for myself | 23:44 |
tqtran_ | :P | 23:44 |
TravT | kfox1111: I believe so, but haven't tested it. | 23:44 |
kfox1111 | TravT: whatcha thinking? | 23:44 |
kfox1111 | I'd be happy to test. :) | 23:44 |
TravT | the rest decorator is just registering a url that django responds on. | 23:45 |
kfox1111 | how does openstack_dashboard/api/rest/urls.py hook into djanogo? | 23:46 |
kfox1111 | I see it building urlpatterns, but not where urlpatterns somehow get sent to django. | 23:46 |
*** shivrao has quit IRC | 23:47 | |
kfox1111 | oh. openstack_dashboard/urls.py maybe? | 23:47 |
TravT | well, it is registering a view. | 23:47 |
*** saksham has quit IRC | 23:47 | |
TravT | sorry, wrong terminology | 23:47 |
tqtran_ | kfox1111: so i think it should work base on what im seeing in monasca | 23:47 |
tqtran_ | https://github.com/stackforge/monasca-ui/blob/master/monitoring/api/monitor.py#L19 | 23:47 |
kfox1111 | yeah. I think thats all I have to do, is get the rest view registered. | 23:47 |
TravT | but @register | 23:47 |
tqtran_ | they are able to reference openstack_dashboard.api | 23:48 |
tqtran_ | similiarly, you can do the same for your own rest api | 23:48 |
tqtran_ | https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/keystone.py#L23 | 23:48 |
tqtran_ | then after that, you should be free to use the decorators | 23:48 |
tqtran_ | https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/keystone.py#L26 | 23:48 |
kfox1111 | that looks like a python api, not a rest api. I think? | 23:49 |
TravT | no. | 23:49 |
tqtran_ | once you install murano plugin, you'll should have access to the url_regex provided by that view | 23:49 |
TravT | note the /rest on the end | 23:49 |
kfox1111 | but rest api should exist outside of all the panels, since its not a panel? | 23:49 |
kfox1111 | so how do you register a non panel in a plugin? | 23:49 |
tqtran_ | you dont need to? | 23:50 |
tqtran_ | the rest api is not specific to a panel like you said | 23:50 |
TravT | we have some rest apis that are "core" services if you will | 23:51 |
tqtran_ | so no need to register it, once you install murano plugin, it will be available to all panels | 23:51 |
kfox1111 | not really. its as specific as the glance rest api is to the glance panel. | 23:51 |
TravT | but this is just registering an endpoint that the rest api will respond on. | 23:52 |
TravT | are you building a panel or a dashboard? | 23:52 |
kfox1111 | neither. a rest api. | 23:52 |
TravT | for what? | 23:52 |
kfox1111 | so that an angularjs service can use it. | 23:52 |
tqtran_ | for example, if i wanted to have a panel to display users and instances at the same time, i can do so | 23:52 |
TravT | which is going to be in a panel within the projects dashboard? | 23:52 |
tqtran_ | and the panel would use 2 different apis to get data from and render | 23:52 |
kfox1111 | horizon puts its rest services under /api/rest/<servicename>/... which is different then the user facing views, which are dashboards/panels. | 23:53 |
kfox1111 | I could try and graft it in there, or like /murano/api/rest/... | 23:54 |
*** tjones has quit IRC | 23:54 | |
tqtran_ | i think we are probably miscommunicating some key points here | 23:54 |
tqtran_ | so let me get this straight: | 23:54 |
kfox1111 | k. | 23:54 |
tqtran_ | you want to write a rest api for murano and put it in the murano plugin project? | 23:54 |
tqtran_ | then you have another plugin that wants to use this rest api in murano plugin? | 23:55 |
kfox1111 | the first is correct. Once I get that working, I'll add an angular js service to the murano plugin too. | 23:55 |
tqtran_ | ah ok, i think i know where you are going with this. | 23:55 |
kfox1111 | then, from a different plugin, I want to use the angularjs service. | 23:55 |
*** tjones has joined #openstack-horizon | 23:56 | |
tqtran_ | so the issue is, you have angularjs services that you want to use in murano not python rest api | 23:56 |
tqtran_ | the python part should work fine | 23:56 |
tqtran_ | but the angular part requires that you include it manually in your own plugin | 23:56 |
kfox1111 | yes, but I'm not through the python part yet. | 23:56 |
kfox1111 | I cant figure out how to make the python code hook up to the webserver. | 23:56 |
*** tjones has left #openstack-horizon | 23:57 | |
kfox1111 | since I have no example of a non dashboard/panel python service. | 23:57 |
kfox1111 | in a plugin. | 23:57 |
tqtran_ | just install it via pip and it should be fine | 23:57 |
tqtran_ | you dont need to include the enabled file | 23:57 |
kfox1111 | I still don't know how this works. | 23:57 |
tqtran_ | https://github.com/tqtran7/mon-ext | 23:58 |
tqtran_ | follow the instructions at the bottom | 23:58 |
kfox1111 | how do I get the rest/project.py file I showed you, showing up at "/murano/api/rest/..." on the horizon server? | 23:58 |
tqtran_ | but skip step 4 | 23:58 |
kfox1111 | that registers a visible thing in the dashboard. | 23:59 |
tqtran_ | so first thing first, your project.py should probably be named murano.py | 23:59 |
kfox1111 | it shows up as a panel. | 23:59 |
kfox1111 | I want to register a non user/ui view, aka, a rest service. | 23:59 |
tqtran_ | secondly, its url_regex should be /murano/whatever, and the final url would be /api/rest/murano/whatever | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!