| david-lyle | lhcheng_: no, haven't even finished reading the email :P | 00:00 |
|---|---|---|
| *** amotoki has joined #openstack-horizon | 00:00 | |
| *** david_cu has quit IRC | 00:03 | |
| *** willsama has quit IRC | 00:04 | |
| *** tqtran has quit IRC | 00:21 | |
| *** bpokorny has quit IRC | 00:23 | |
| *** jbell8 has quit IRC | 00:26 | |
| *** garthb__ has quit IRC | 00:27 | |
| *** garthb__ has joined #openstack-horizon | 00:29 | |
| *** nlahouti has quit IRC | 00:29 | |
| *** memogarcia has quit IRC | 00:35 | |
| *** nlahouti has joined #openstack-horizon | 00:36 | |
| *** adelia has joined #openstack-horizon | 00:36 | |
| *** memogarcia has joined #openstack-horizon | 00:37 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels https://review.openstack.org/243880 | 00:41 |
| *** ducttape_ has joined #openstack-horizon | 00:42 | |
| *** saksham has joined #openstack-horizon | 00:44 | |
| *** adelia_ has joined #openstack-horizon | 00:47 | |
| *** mpavlase has joined #openstack-horizon | 00:47 | |
| *** david_cu has joined #openstack-horizon | 00:49 | |
| *** adelia has quit IRC | 00:49 | |
| *** mpavlase has quit IRC | 00:52 | |
| *** jwy has quit IRC | 00:55 | |
| *** gyee has joined #openstack-horizon | 00:56 | |
| *** flwang1 has quit IRC | 00:58 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 01:00 |
| *** raz_ has joined #openstack-horizon | 01:03 | |
| *** alexvictorchan has quit IRC | 01:04 | |
| *** SimonChung has quit IRC | 01:13 | |
| *** jwy has joined #openstack-horizon | 01:13 | |
| *** _ducttape_ has joined #openstack-horizon | 01:15 | |
| *** cody-somerville has joined #openstack-horizon | 01:17 | |
| *** ducttape_ has quit IRC | 01:18 | |
| *** garthb__ has quit IRC | 01:22 | |
| *** raz_ has quit IRC | 01:23 | |
| *** zhenguo has joined #openstack-horizon | 01:23 | |
| *** _ducttape_ has quit IRC | 01:29 | |
| *** mtanino has quit IRC | 01:30 | |
| *** memogarcia has quit IRC | 01:35 | |
| *** harlowja has quit IRC | 01:38 | |
| *** memogarcia has joined #openstack-horizon | 01:38 | |
| *** harlowja_ has joined #openstack-horizon | 01:38 | |
| *** ybathia has quit IRC | 01:52 | |
| *** nlahouti has quit IRC | 01:54 | |
| *** memogarcia has quit IRC | 02:02 | |
| *** zhurong has joined #openstack-horizon | 02:05 | |
| *** wolverin_ has joined #openstack-horizon | 02:05 | |
| *** wolverin_ has quit IRC | 02:07 | |
| *** wolverineav has quit IRC | 02:08 | |
| *** wolverin_ has joined #openstack-horizon | 02:08 | |
| *** cody-somerville has quit IRC | 02:09 | |
| *** jwy has quit IRC | 02:18 | |
| *** raz_ has joined #openstack-horizon | 02:24 | |
| *** raz_ has quit IRC | 02:39 | |
| *** raz_ has joined #openstack-horizon | 02:41 | |
| *** jwy has joined #openstack-horizon | 02:41 | |
| *** saksham has quit IRC | 02:43 | |
| *** raz_ has quit IRC | 02:45 | |
| *** rebase has quit IRC | 02:48 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add reno for release notes management https://review.openstack.org/243897 | 02:50 |
| *** Ephur has joined #openstack-horizon | 02:55 | |
| *** Ephur has quit IRC | 02:56 | |
| *** lhcheng_ has quit IRC | 02:58 | |
| *** jamielennox is now known as jamielennox|away | 03:00 | |
| *** jamielennox|away is now known as jamielennox | 03:10 | |
| *** jwy has quit IRC | 03:11 | |
| *** sshen has joined #openstack-horizon | 03:18 | |
| *** sshen has left #openstack-horizon | 03:19 | |
| *** sshen has joined #openstack-horizon | 03:19 | |
| *** david_cu has quit IRC | 03:20 | |
| *** sshen has quit IRC | 03:22 | |
| *** hightall has joined #openstack-horizon | 03:22 | |
| *** sshen has joined #openstack-horizon | 03:23 | |
| *** gyee has quit IRC | 03:23 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: WIP: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 03:25 |
| *** adelia_ has quit IRC | 03:25 | |
| *** pumaranikar has joined #openstack-horizon | 03:29 | |
| *** adelia has joined #openstack-horizon | 03:30 | |
| *** btully has quit IRC | 03:32 | |
| *** errolpais has quit IRC | 03:32 | |
| *** jerrygb has quit IRC | 03:33 | |
| *** jerrygb has joined #openstack-horizon | 03:34 | |
| *** agireud has joined #openstack-horizon | 03:34 | |
| *** adelia has quit IRC | 03:35 | |
| *** wolverin_ has quit IRC | 03:37 | |
| *** agireud has quit IRC | 03:39 | |
| *** wolverineav has joined #openstack-horizon | 03:39 | |
| *** agireud has joined #openstack-horizon | 03:41 | |
| *** wolverineav has quit IRC | 03:44 | |
| *** pumaranikar has quit IRC | 03:49 | |
| *** adelia has joined #openstack-horizon | 03:49 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Adding angular prompt service https://review.openstack.org/241399 | 03:50 |
| *** hightall has quit IRC | 03:50 | |
| *** adelia has quit IRC | 03:55 | |
| *** zhurong has quit IRC | 03:56 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Adding a long-running anguar service [WIP] https://review.openstack.org/241400 | 03:57 |
| *** zhurong has joined #openstack-horizon | 03:57 | |
| *** adelia has joined #openstack-horizon | 03:58 | |
| *** nlahouti has joined #openstack-horizon | 03:59 | |
| *** nlahouti1 has joined #openstack-horizon | 04:00 | |
| *** wolverineav has joined #openstack-horizon | 04:01 | |
| *** nlahouti has quit IRC | 04:03 | |
| *** adelia has quit IRC | 04:04 | |
| *** wolverineav has quit IRC | 04:06 | |
| *** jbell8 has joined #openstack-horizon | 04:07 | |
| *** adelia has joined #openstack-horizon | 04:08 | |
| *** raz_ has joined #openstack-horizon | 04:09 | |
| *** alexvictorchan has joined #openstack-horizon | 04:10 | |
| *** adelia has quit IRC | 04:13 | |
| *** stevemar_ has joined #openstack-horizon | 04:13 | |
| *** lhcheng has joined #openstack-horizon | 04:14 | |
| *** stevemar_ has quit IRC | 04:16 | |
| lhcheng | david-lyle: patch submitted to get reno going^ | 04:27 |
| openstackgerrit | Merged openstack/horizon: Port dashboard stack tests to Python 3 https://review.openstack.org/234866 | 04:30 |
| openstackgerrit | Merged openstack/horizon: Port network topology tests to Python 3 https://review.openstack.org/234867 | 04:34 |
| openstackgerrit | Merged openstack/horizon: Fix Python 3 issues in dashboard image tests https://review.openstack.org/234868 | 04:34 |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add reno for release notes management https://review.openstack.org/243897 | 04:37 |
| *** wolverineav has joined #openstack-horizon | 04:37 | |
| r1chardj0n3s | zigo: integrating phantomjs as a selenium webdriver https://review.openstack.org/#/c/242926/ | 04:38 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Merge the two webdrivers https://review.openstack.org/243946 | 04:38 |
| *** lhcheng has quit IRC | 04:39 | |
| *** hightall has joined #openstack-horizon | 04:39 | |
| *** wolverineav has quit IRC | 04:39 | |
| *** wolverin_ has joined #openstack-horizon | 04:39 | |
| *** raz_ has quit IRC | 04:40 | |
| *** lhcheng has joined #openstack-horizon | 04:41 | |
| *** crobertsrh is now known as _crobertsrh | 04:43 | |
| *** lhcheng has quit IRC | 04:43 | |
| *** raz_ has joined #openstack-horizon | 04:43 | |
| *** lhcheng has joined #openstack-horizon | 04:44 | |
| *** wolverin_ has quit IRC | 04:47 | |
| *** wolverineav has joined #openstack-horizon | 04:47 | |
| openstackgerrit | Shu Muto proposed openstack/horizon: Remove unnecessary ugettext_lazy https://review.openstack.org/243950 | 04:49 |
| *** jbell8 has quit IRC | 04:51 | |
| *** adelia has joined #openstack-horizon | 04:52 | |
| *** saksham has joined #openstack-horizon | 04:53 | |
| *** vishwanathj has quit IRC | 04:57 | |
| *** wolverineav has quit IRC | 05:03 | |
| *** wolverineav has joined #openstack-horizon | 05:04 | |
| *** wolverineav has joined #openstack-horizon | 05:04 | |
| *** saksham has quit IRC | 05:04 | |
| *** lhcheng has quit IRC | 05:06 | |
| *** wolverineav has quit IRC | 05:06 | |
| *** btully has joined #openstack-horizon | 05:07 | |
| *** wolverineav has joined #openstack-horizon | 05:08 | |
| *** btully has quit IRC | 05:11 | |
| openstackgerrit | Merged openstack/horizon: Add firewall detail actions and breadcrumb nav https://review.openstack.org/234315 | 05:12 |
| *** raz_ has quit IRC | 05:13 | |
| *** btully has joined #openstack-horizon | 05:13 | |
| *** jerrygb has quit IRC | 05:28 | |
| *** stevemar_ has joined #openstack-horizon | 05:29 | |
| *** jerrygb has joined #openstack-horizon | 05:29 | |
| *** stevemar_ has quit IRC | 05:31 | |
| *** jerrygb has quit IRC | 05:33 | |
| *** alexvictorchan has quit IRC | 05:35 | |
| *** shu has joined #openstack-horizon | 05:37 | |
| *** wolverin_ has joined #openstack-horizon | 05:43 | |
| *** wolverineav has quit IRC | 05:46 | |
| *** davidmichaelkarr has quit IRC | 05:50 | |
| toabctl | david-lyle: so any conclusion howto proceed with the CUSTOM_THEME_PATH setting for non-plugins? | 05:51 |
| toabctl | I read the backlog but seems that there wasn't a plan howto continue now. | 05:51 |
| *** alexvictorchan has joined #openstack-horizon | 06:01 | |
| *** errolpais has joined #openstack-horizon | 06:03 | |
| *** bttully has joined #openstack-horizon | 06:06 | |
| *** nlahouti has joined #openstack-horizon | 06:06 | |
| *** nlahouti1 has quit IRC | 06:07 | |
| *** btully has quit IRC | 06:07 | |
| *** hurgleburgler1 has joined #openstack-horizon | 06:07 | |
| *** bttully is now known as btully | 06:07 | |
| *** btully is now known as Guest80839 | 06:08 | |
| *** hurgleburgler has quit IRC | 06:08 | |
| *** hurgleburgler1 has quit IRC | 06:15 | |
| *** alexvictorchan has quit IRC | 06:18 | |
| *** jamielennox is now known as jamielennox|away | 06:29 | |
| *** aortega has quit IRC | 06:30 | |
| *** jbell8 has joined #openstack-horizon | 06:30 | |
| *** sqchen has left #openstack-horizon | 06:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/243973 | 06:33 |
| *** sayan has joined #openstack-horizon | 06:35 | |
| openstackgerrit | Merged openstack/horizon: Directive to check if policy check passes https://review.openstack.org/214815 | 06:40 |
| *** adelia has quit IRC | 06:45 | |
| *** ^Gal^ has quit IRC | 06:45 | |
| *** wolverineav has joined #openstack-horizon | 06:47 | |
| *** wolverin_ has quit IRC | 06:47 | |
| openstackgerrit | Thomas Bechtold proposed openstack/horizon: Add local_settings.d/ dir for settings snippets https://review.openstack.org/243974 | 06:47 |
| *** vgridnev has joined #openstack-horizon | 06:48 | |
| *** ^Gal^ has joined #openstack-horizon | 06:49 | |
| *** saksham has joined #openstack-horizon | 06:56 | |
| *** saksham has quit IRC | 06:56 | |
| *** hurgleburgler has joined #openstack-horizon | 07:01 | |
| *** lsmola has joined #openstack-horizon | 07:16 | |
| *** adelia has joined #openstack-horizon | 07:22 | |
| *** rdopiera has joined #openstack-horizon | 07:24 | |
| openstackgerrit | Zhenguo Niu proposed openstack/horizon: Revert "Fixes Broken Error Message on Subnet Creation" https://review.openstack.org/243983 | 07:24 |
| *** stevemar_ has joined #openstack-horizon | 07:29 | |
| *** jerrygb has joined #openstack-horizon | 07:30 | |
| *** jhesketh has quit IRC | 07:31 | |
| *** jhesketh has joined #openstack-horizon | 07:31 | |
| *** stevemar_ has quit IRC | 07:32 | |
| *** jerrygb has quit IRC | 07:36 | |
| openstackgerrit | Thomas Bechtold proposed openstack/horizon: Add local_settings.d/ dir for settings snippets https://review.openstack.org/243974 | 07:39 |
| *** logan2 has quit IRC | 07:40 | |
| *** logan2 has joined #openstack-horizon | 07:40 | |
| *** jamielennox|away has quit IRC | 07:41 | |
| *** yamamoto has quit IRC | 07:43 | |
| *** mordred has quit IRC | 07:44 | |
| *** adelia has quit IRC | 07:47 | |
| *** Liuqing has joined #openstack-horizon | 07:47 | |
| *** wolverineav has quit IRC | 07:48 | |
| *** neillc is now known as neillc_away | 07:49 | |
| zhenguo | robcresswell: hi, please help to check one revert patch https://review.openstack.org/#/c/243983/ , which will break subnet creation. | 07:50 |
| robcresswell | lhcheng: Just saw the reno patch, looks good at first glance, will review later | 07:53 |
| robcresswell | zhenguo: How did that get merged if it breaks subnet create?? | 07:54 |
| zhenguo | robcresswell: sorry, it's approved by me as not fully test. but seems our UT can't cover that | 07:56 |
| robcresswell | :( | 07:57 |
| robcresswell | Just reviewing now | 07:57 |
| toabctl | robcresswell: hey. I proposed a patchfor the "override settings" thing from yesterday evening (at least for me eveing): https://review.openstack.org/#/c/243974/ | 07:57 |
| zhenguo | robcresswell: thanks | 07:57 |
| * zhenguo brb | 07:59 | |
| *** wolverineav has joined #openstack-horizon | 08:10 | |
| *** nlahouti has quit IRC | 08:13 | |
| *** errolpais has quit IRC | 08:16 | |
| *** vgridnev has quit IRC | 08:17 | |
| *** vgridnev has joined #openstack-horizon | 08:18 | |
| *** yamamoto_ has joined #openstack-horizon | 08:23 | |
| *** mpavlase has joined #openstack-horizon | 08:24 | |
| robcresswell | toabctl: Yup, I saw it | 08:24 |
| toabctl | robcresswell: not exactly what we talked about but imo that's the easiest and clearest way todo it.. | 08:25 |
| robcresswell | toabctl: I think the issue is having multiple ways to do overrides. It would be nicer to just drop a file into the `enabled/` folder. | 08:25 |
| toabctl | robcresswell: but enabled/ is for plugins. my proposal is just adding a mechanism to split local_settings.py into multiple files. that's it | 08:26 |
| toabctl | robcresswell: imho that's a well known mechanism used by many other software projects | 08:26 |
| toabctl | robcresswell: if you want to avoid multiple overrides, than you should drop local_settings.py , too. | 08:27 |
| *** ^Gal^ has quit IRC | 08:27 | |
| toabctl | robcresswell: but I think it's different usecases for enabled/ and local_settings{.py,.d} | 08:28 |
| *** vgridnev has quit IRC | 08:29 | |
| *** jamielennox|away has joined #openstack-horizon | 08:31 | |
| *** jamielennox|away is now known as jamielennox | 08:31 | |
| robcresswell | toabctl: So the suggestion is more like, replace local_settings.py with the dir entirely? | 08:32 |
| toabctl | robcresswell: I guess that would be a problem for backward compat | 08:32 |
| robcresswell | toabctl: Also I'm curious, how is local_settings presented to you? A file that can't be altered? | 08:32 |
| toabctl | robcresswell: no., the file can be altered. but not via i.e. RPM . | 08:33 |
| robcresswell | toabctl: Ah, understood | 08:33 |
| toabctl | robcresswell: so just adding a file to local_settings.d/ during package install and removing it during package removal is easy | 08:33 |
| toabctl | changing local_settings.py is forbidden and even if it would be allowed, it would be much more complicated (with some regex) | 08:34 |
| *** Guest80839 has quit IRC | 08:34 | |
| toabctl | robcresswell: so the local_settings.d/ is just an addition you *can* you, but you don't have to. it's totally fine to just use local_settings.py if that's all what you want | 08:35 |
| robcresswell | Sure | 08:35 |
| robcresswell | I need to have a think on it | 08:35 |
| *** stevemar_ has joined #openstack-horizon | 08:35 | |
| toabctl | robcresswell: sure | 08:35 |
| robcresswell | What I don't like is, this means you can now do some customisation (as a higher level concept, covering plugins, settings etc) via enabled/, some via local_settings.py, and some via local_settings.d | 08:36 |
| *** aortega has joined #openstack-horizon | 08:36 | |
| robcresswell | It would be nicer, IMO, to just drop in a file to enabled/ folder with a LOCAL_SETTINGS_OVERRIDE = {...} attribute. | 08:37 |
| *** vgridnev has joined #openstack-horizon | 08:37 | |
| robcresswell | Then its a bit more of a consistent "this folder is used for altering Horizon with external components" | 08:37 |
| robcresswell | whether they are content plugins, or themes, or settings overrides. | 08:38 |
| toabctl | robcresswell: but with local_settings, you can alter all your django settings. not sure if that's possible with enabled/ | 08:38 |
| *** stevemar_ has quit IRC | 08:38 | |
| toabctl | and as I already said, you already have local_settings.py . so my suggestion is to just make this a bit more flexible. it's not something new I would say. | 08:39 |
| toabctl | you could also write a management command to collect files from a directory, concatenate all files and write the output to local_settings.py . same effect(but ugly:)) | 08:40 |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/243973 | 08:44 |
| *** Axwell has joined #openstack-horizon | 08:45 | |
| *** ^Gal^ has joined #openstack-horizon | 08:46 | |
| Axwell | Hello guys, trying to upgrade my horizon modification from juno to kilo, the following function horizon.get_dashboard('project') return me NotRegistered: Dashboard with slug "project" is not registered. | 08:46 |
| Axwell | doest it make sense? | 08:46 |
| mrunge | Axwell, did you upgrade all your dependencies, too | 08:48 |
| mrunge | ? | 08:48 |
| *** jbell8 has quit IRC | 08:48 | |
| Axwell | yes yes | 08:49 |
| robcresswell | Axwell: That code is right, so something is wrong with the dashboard I think | 08:49 |
| Axwell | what is strange is that others modification I did to horizon like overiding the logic os create_instance is perfectly working | 08:49 |
| mrunge | so, it already works without your modification? | 08:49 |
| robcresswell | Does it run fine without your patch? | 08:49 |
| Axwell | yes | 08:49 |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Modify the regular expression when you create Pseudo-folder. https://review.openstack.org/243625 | 08:50 |
| Axwell | mrunge: I got the same behaviour when running this code fragment in python /usr/share/openstack-dashboard/manage.py shell | 08:51 |
| mrunge | Axwell, that is expected... | 08:51 |
| mrunge | Axwell, all this points to your modification, which we don't know | 08:52 |
| Axwell | ok so I will try to disable my modification and run the same things again | 08:52 |
| Axwell | in the local settings file, I commented the cusotmization module line | 08:54 |
| Axwell | import horizon | 08:54 |
| Axwell | horizon.get_dashboards() | 08:54 |
| Axwell | NotRegistered: Dashboard with slug "project" is not registered. | 08:54 |
| Axwell | But the UI is properly rendered | 08:54 |
| *** jbell8 has joined #openstack-horizon | 08:56 | |
| Axwell | Any idea where to look since I am now customization free | 08:56 |
| *** e0ne has joined #openstack-horizon | 08:59 | |
| robcresswell | customization_module line? | 08:59 |
| robcresswell | afaik customization module pulls in a package | 08:59 |
| robcresswell | It sounds like you're probably trying to load a dashboard before the dashboard has been registered with horizon | 09:00 |
| robcresswell | So the UI will be fine, because by that point it has all been registered | 09:00 |
| Axwell | Does this behavior change since juno? | 09:01 |
| robcresswell | I can't recall | 09:02 |
| *** zhurong has quit IRC | 09:03 | |
| *** mpavlase has quit IRC | 09:03 | |
| *** zhurong has joined #openstack-horizon | 09:03 | |
| *** zhurong has quit IRC | 09:04 | |
| openstackgerrit | Merged openstack/horizon: Remove unnecessary ugettext_lazy https://review.openstack.org/243950 | 09:04 |
| *** mpavlase has joined #openstack-horizon | 09:04 | |
| *** hurgleburgler has quit IRC | 09:05 | |
| *** wolverineav has quit IRC | 09:09 | |
| *** Axwell has quit IRC | 09:16 | |
| *** wolverineav has joined #openstack-horizon | 09:16 | |
| toabctl | mrunge: what do you think about https://review.openstack.org/#/c/243974 ? | 09:20 |
| *** vgridnev has quit IRC | 09:20 | |
| mrunge | toabctl, sorry, I haven't had the time to look at it more deeply | 09:20 |
| mrunge | first of all: yes! I like the idea | 09:20 |
| toabctl | mrunge: np | 09:20 |
| mrunge | for whom it concerns, there is the vitrage meeting in openstack-meeting-3, they have vitrage-ui on their agenda | 09:21 |
| *** mpavlase has quit IRC | 09:22 | |
| *** mpavlase has joined #openstack-horizon | 09:23 | |
| *** hightall has quit IRC | 09:30 | |
| robcresswell | AJaeger: ping | 09:34 |
| *** btully has joined #openstack-horizon | 09:39 | |
| *** belmoreira has joined #openstack-horizon | 09:41 | |
| *** AlonHeller has joined #openstack-horizon | 09:42 | |
| *** nitzikow has joined #openstack-horizon | 09:42 | |
| *** Liuqing has quit IRC | 09:42 | |
| *** emalin has joined #openstack-horizon | 09:42 | |
| AlonHeller | I need some help with starting an AngularJS project (Vitrage) as an Horizon Plugin. Do you have any good references for me ? | 09:43 |
| *** btully has quit IRC | 09:44 | |
| mrunge | AlonHeller, https://developer.ibm.com/opentech/2015/10/08/add-angularjs-dashboard-plugin-openstack-horizon/ | 09:44 |
| mrunge | that's a starter | 09:44 |
| *** mordred has joined #openstack-horizon | 09:45 | |
| *** omer_etrog_ has joined #openstack-horizon | 09:45 | |
| *** omer_etrog has joined #openstack-horizon | 09:46 | |
| *** omer_etrog_ has quit IRC | 09:47 | |
| *** omer_etrog has quit IRC | 09:51 | |
| *** omer_etrog has joined #openstack-horizon | 09:52 | |
| *** yamamoto_ has quit IRC | 09:54 | |
| AlonHeller | Can you develop with webstorm on devstack with a network drive ? | 09:55 |
| mrunge | I'm using a horizon git checkout on my local machine | 09:56 |
| mrunge | and pointing my install via local_settings to a keystone in a real deployment | 09:56 |
| mrunge | works well for me, no need to fiddle around with devstack | 09:56 |
| *** zhenguo has quit IRC | 09:56 | |
| *** yamamoto has joined #openstack-horizon | 09:58 | |
| AlonHeller | OK, I'll start with the "Hello World" plugin, and will ask more relevant question in the near future | 09:59 |
| mrunge | sure | 09:59 |
| omer_etrog | Which version on Angular is used now? 1.4.2? | 09:59 |
| *** wolverineav has quit IRC | 10:00 | |
| *** ZZelle has joined #openstack-horizon | 10:00 | |
| *** amotoki has quit IRC | 10:00 | |
| mrunge | currently in horizon: 1.3.7 | 10:00 |
| mrunge | ok, anything greater than 1.3.7: https://github.com/openstack/horizon/blob/master/requirements.txt#L45 | 10:01 |
| *** vgridnev has joined #openstack-horizon | 10:01 | |
| AlonHeller | Did you tried D3 in your AngularJS project ? | 10:02 |
| omer_etrog | Any thoughts of upgrading to latest version? | 10:02 |
| mrunge | we're using d3 in horizon, too | 10:02 |
| mrunge | omer_etrog, you mean, to angular2? | 10:02 |
| mrunge | we're using xstatic packaged versions of d3 and angular | 10:03 |
| *** yamamoto has quit IRC | 10:03 | |
| mrunge | I think we had upgrading to latest on the agenda for mitaka | 10:04 |
| robcresswell | omer_etrog: By latest version, I assume you mean 1.4.x? | 10:04 |
| omer_etrog | Angular2 is still in alpha, but yes, to 1.4.x | 10:04 |
| robcresswell | omer_etrog: Indeed, but its surprising how often people tell us to look at 2.x | 10:05 |
| *** emalin has quit IRC | 10:05 | |
| robcresswell | As if we're going to run an Alpha JS framework >.< | 10:05 |
| mrunge | yupp | 10:05 |
| robcresswell | insanity. but hey. | 10:05 |
| mrunge | and it requires a compile step | 10:05 |
| robcresswell | 1.4 would be good, but doesn't appear to be a priority | 10:05 |
| omer_etrog | we can think of moving to TypeScript and ecmascript6 | 10:07 |
| AlonHeller | Is it OK to use other dependencies in a bower.json file ? | 10:07 |
| omer_etrog | then it will be easier to move to Angular 2.x once it will be ready | 10:08 |
| *** aix has joined #openstack-horizon | 10:08 | |
| mrunge | typescript is a superset of javascript, it's not supported in many browsers | 10:08 |
| mrunge | AlonHeller, you can do that in your project. but in horizon: no | 10:09 |
| *** Liuqing has joined #openstack-horizon | 10:09 | |
| mrunge | dependencies need to be packaged as xstatic packages for many reasons | 10:09 |
| AlonHeller | mrunge, My project will be as Horizon plugin. So does it mean yes or no ? | 10:10 |
| ^Gal^ | AlonHeller: I would use ecma5 for the dashboard | 10:10 |
| mrunge | AlonHeller, then: I don't care | 10:10 |
| robcresswell | If its a plugin, do whatever you like | 10:10 |
| *** yamamoto has joined #openstack-horizon | 10:11 | |
| AlonHeller | Now I'm not sure what it should be. Plugin or part of Horizon :) | 10:12 |
| *** omer_etrog has quit IRC | 10:12 | |
| *** omer_etrog_ has joined #openstack-horizon | 10:12 | |
| mrunge | AlonHeller, well, in current status: plugin | 10:13 |
| mrunge | currently, we (horizoners) are removing stuff from horizon | 10:13 |
| robcresswell | There are a lot of factors to consider with plugins | 10:14 |
| *** omer_etrog has joined #openstack-horizon | 10:14 | |
| robcresswell | If you want wide adoption, I'd advise sticking to the Horizon requirements | 10:14 |
| AlonHeller | Can I find these requirments in the link you sent me ? | 10:15 |
| mrunge | requirements are in horizon source tree, requirements.txt | 10:15 |
| mrunge | ;-) | 10:15 |
| robcresswell | https://github.com/openstack/horizon/blob/master/requirements.txt | 10:16 |
| nitzikow | we have screens for the vitrage project and screens for the ceilometer alarms. so the vitrage screens will be plugin. what about the alarms screen? | 10:16 |
| AlonHeller | :) | 10:16 |
| mrunge | nitzikow, it still depends.... | 10:16 |
| mrunge | My guess would be, if alarms is usable quickly, it might become integrated | 10:16 |
| *** omer_etrog_ has quit IRC | 10:17 | |
| mrunge | quickly usable, I meant | 10:17 |
| nitzikow | if we target to have it up and running in Mitaka, is it quick enough? | 10:17 |
| mrunge | I still can't tell. | 10:18 |
| mrunge | fact is, we need to do something about the current metering dashboard; whether removing or refreshing that | 10:18 |
| mrunge | so, if you're refreshing that, it's in | 10:19 |
| mrunge | new functionality can be added via blueprint process | 10:19 |
| mrunge | that'll be discussed in our weekly and public meetings | 10:20 |
| omer_etrog | we are in the process to add new blueprints for Vitrage | 10:20 |
| AlonHeller | What is XStatic ? | 10:20 |
| nitzikow | ok mrunge, we will join those discussions | 10:20 |
| mrunge | a wrapper and container for bundling static files via python modules | 10:21 |
| mrunge | ^^ AlonHeller | 10:21 |
| mrunge | that makes static files available on the gate | 10:21 |
| mrunge | and available in distributions | 10:21 |
| AlonHeller | 2 more questions, and then I'll get my coffee :) Do you have any reference to other Horizon AngularJS plugins ? | 10:21 |
| AlonHeller | :) | 10:21 |
| AlonHeller | What about testing. Are you using Karma & Protractor ? | 10:22 |
| robcresswell | Karma/ Jasmine/ ESLint for testing/ linting | 10:22 |
| mrunge | there are more or less new features added via angular; you should have a look at gerrit | 10:22 |
| mrunge | https://review.openstack.org/#/q/status:open+project:openstack/horizon,n,z | 10:23 |
| mrunge | e.g https://review.openstack.org/#/c/217422/ | 10:23 |
| mrunge | it becomes a common pattern | 10:23 |
| *** tosky has joined #openstack-horizon | 10:24 | |
| *** yamamoto has quit IRC | 10:27 | |
| *** stevemar_ has joined #openstack-horizon | 10:36 | |
| *** lhcheng has joined #openstack-horizon | 10:37 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:38 | |
| *** stevemar_ has quit IRC | 10:38 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add reno for release notes management https://review.openstack.org/243897 | 10:39 |
| robcresswell | lhcheng: So is the idea with reno, an extra yaml per patch? | 10:41 |
| lhcheng | robcresswell: I think more of feature set or per bp | 10:42 |
| robcresswell | lhcheng: What about bugs? | 10:42 |
| lhcheng | robcresswell: I don't think so, we only release notes new features before? I guess unless the bug fix is impactful or has docimpact | 10:43 |
| robcresswell | lhcheng: Sure, I was unsure if we were supposed to govern its usage or the infra guys. | 10:44 |
| robcresswell | But if we control it, we can just do it with bps etc | 10:44 |
| lhcheng | yup, same type of content you had for our last release notes. just important stuff that ops needs to be aware of: new features and upgrade impacting stuff | 10:45 |
| *** nitzikow has quit IRC | 10:48 | |
| *** yamamoto has joined #openstack-horizon | 10:49 | |
| robcresswell | Ah okay. Thats fine then. | 10:49 |
| *** wolverineav has joined #openstack-horizon | 11:00 | |
| *** wolverineav has quit IRC | 11:05 | |
| *** amotoki has joined #openstack-horizon | 11:22 | |
| *** stevemar_ has joined #openstack-horizon | 11:23 | |
| *** stevemar_ has quit IRC | 11:26 | |
| *** btully has joined #openstack-horizon | 11:27 | |
| lhcheng | robcresswell: I'm off, will try to sleep again. jetlag is killing me. | 11:30 |
| *** btully has quit IRC | 11:32 | |
| *** lhcheng has quit IRC | 11:33 | |
| *** akrivoka has joined #openstack-horizon | 11:38 | |
| *** memogarcia has joined #openstack-horizon | 11:38 | |
| *** memogarcia has quit IRC | 11:48 | |
| r1chardj0n3s | hullo | 11:51 |
| *** kmartin has quit IRC | 11:52 | |
| robcresswell | r1chardj0n3s: o/ | 11:54 |
| mrunge | o/ | 11:55 |
| robcresswell | Is the meeting in 5 mins or 1h 5 mins? | 11:56 |
| r1chardj0n3s | 5 mins | 11:56 |
| r1chardj0n3s | just playing some Fallout 4 while I wait :-) | 11:56 |
| robcresswell | Great | 11:56 |
| robcresswell | Ah, how is it? | 11:56 |
| robcresswell | Horizon meeting in #openstack-meeting-3 in 5 minutes, everyone welcome! :p | 11:56 |
| r1chardj0n3s | it's very Fallout :-) | 11:56 |
| r1chardj0n3s | I'm enjoying it | 11:56 |
| r1chardj0n3s | also my old PC is coping quite well! | 11:56 |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Modify the regular expression when you create Pseudo-folder. https://review.openstack.org/243625 | 11:57 |
| robcresswell | Its quite an old engine right? They've been reusing it for a while now iirc | 11:57 |
| robcresswell | mrunge: Have you seen intermittent errors during tests? | 11:58 |
| robcresswell | Http302 | 11:58 |
| robcresswell | Error while checking action permissions. | 11:58 |
| r1chardj0n3s | robcresswell: yeah, same old engine :-) | 11:58 |
| openstackgerrit | Merged openstack/horizon: Revert "Fixes Broken Error Message on Subnet Creation" https://review.openstack.org/243983 | 11:59 |
| mrunge | robcresswell, I have seen errors yesterday, yes | 11:59 |
| mrunge | but they were due to infra glitches, afaik | 11:59 |
| *** nitzikow has joined #openstack-horizon | 11:59 | |
| *** stevemar_ has joined #openstack-horizon | 12:00 | |
| r1chardj0n3s | lots of network issues in infra yesterday | 12:00 |
| robcresswell | Mine are local, not upstream | 12:00 |
| mrunge | but I must admit, I'm currently downstream focused | 12:01 |
| *** doug-fis_ is now known as doug-fish | 12:02 | |
| *** omer_etrog has left #openstack-horizon | 12:04 | |
| *** omer_etrog has joined #openstack-horizon | 12:04 | |
| *** neillc_away is now known as neillc | 12:05 | |
| *** vgridnev has quit IRC | 12:08 | |
| amotoki | doug-fish: I checked lbaas v2 panel review on invision. It looks good to me and i think we can go forward :) | 12:10 |
| doug-fish | amotoki: great! | 12:11 |
| *** e0ne has quit IRC | 12:11 | |
| amotoki | doug-fish: I am not sure where I can put a general comment as a whole in Invision. | 12:11 |
| *** aheller has joined #openstack-horizon | 12:12 | |
| doug-fish | sometimes I just make general comments, but tack then to a specific spot; I don't know if there is a better way | 12:12 |
| *** omer_etrog is now known as oetrog | 12:16 | |
| *** e0ne has joined #openstack-horizon | 12:18 | |
| *** nitzikow has quit IRC | 12:27 | |
| *** nitzikow has joined #openstack-horizon | 12:27 | |
| *** openstackgerrit has quit IRC | 12:31 | |
| *** openstackgerrit has joined #openstack-horizon | 12:31 | |
| *** jerrygb has joined #openstack-horizon | 12:37 | |
| openstackgerrit | Di XiaoLi proposed openstack/horizon: Add handle get_file when launch stack from horizon https://review.openstack.org/241700 | 12:39 |
| *** nitzikow has quit IRC | 12:44 | |
| *** nitzikow has joined #openstack-horizon | 12:45 | |
| *** oetrog_ has joined #openstack-horizon | 12:48 | |
| *** oetrog has quit IRC | 12:48 | |
| *** wolverineav has joined #openstack-horizon | 12:49 | |
| *** vgridnev has joined #openstack-horizon | 12:49 | |
| *** lblanchard has joined #openstack-horizon | 12:52 | |
| *** wolverineav has quit IRC | 12:53 | |
| *** jhesketh has quit IRC | 12:58 | |
| *** pauloewerton has joined #openstack-horizon | 12:59 | |
| *** ^Gal^ has quit IRC | 13:00 | |
| *** jhesketh has joined #openstack-horizon | 13:00 | |
| *** ^Gal^ has joined #openstack-horizon | 13:03 | |
| nitzikow | hi all, | 13:04 |
| *** zhurong has joined #openstack-horizon | 13:04 | |
| nitzikow | following a chat we had earlier on the vitrage irc we want to add an alarms page to horizon | 13:04 |
| nitzikow | we saw there is an open blueprint: https://blueprints.launchpad.net/horizon/+spec/ceilometer-alarm-management-page | 13:04 |
| nitzikow | what will be the best way to do that? as a plugin? | 13:05 |
| nitzikow | or as a page in horizon? | 13:06 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Create Action - Details https://review.openstack.org/215352 | 13:06 |
| *** memogarcia has joined #openstack-horizon | 13:07 | |
| *** _crobertsrh is now known as crobertsrh | 13:09 | |
| *** yamamoto has quit IRC | 13:11 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/django_openstack_auth: Refactor d-o-a to use keystoneauth library https://review.openstack.org/205251 | 13:12 |
| *** ducttape_ has joined #openstack-horizon | 13:13 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add breadcrumbs to final details pages https://review.openstack.org/243566 | 13:13 |
| robcresswell | doug-fish: That's the final breadcrumb patch, aside from the tabbed network patch which I'm still working on. | 13:13 |
| david-lyle | nitzikow: I believe that blueprint is in progress. please coordinate with the current owner | 13:14 |
| david-lyle | where the content should live is another question | 13:14 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add breadcrumbs to final details pages https://review.openstack.org/243566 | 13:14 |
| doug-fish | robcresswell: one more final patch? :-) | 13:15 |
| david-lyle | if we are not using ceilometer to show metrics, then I could see just making ceilometer content a plugin | 13:15 |
| robcresswell | doug-fish: My commit message was 7 characters too long :( | 13:15 |
| doug-fish | well that's a good reason to slow down development. :\ | 13:15 |
| david-lyle | need to figure out where we are headed with metrics | 13:15 |
| robcresswell | doug-fish: Yeah, but I know I'll get called on it >.< | 13:16 |
| doug-fish | understood | 13:16 |
| nitzikow | you are not using ceilometer to show metrics? | 13:16 |
| david-lyle | nitzikow: there is currently a panel but most find it not worthwhile | 13:17 |
| *** memogarcia has quit IRC | 13:17 | |
| david-lyle | and the telemetry team is not overly in favor of us using the telemetry data in this way | 13:17 |
| nitzikow | ok, we will start with talking with the current owner of the blueprint. | 13:19 |
| nitzikow | thanks | 13:19 |
| david-lyle | nitzikow: thanks | 13:19 |
| *** tmazur_ has joined #openstack-horizon | 13:28 | |
| *** matt-borland has joined #openstack-horizon | 13:33 | |
| *** ducttape_ has quit IRC | 13:34 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Separate subnets tests from networks tests file https://review.openstack.org/244104 | 13:36 |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Inline editing for LBaaS tables https://review.openstack.org/242100 | 13:45 |
| *** nitzikow has quit IRC | 13:52 | |
| matt-borland | TravT, let's do a screenhero session to try to definitively troubleshoot the error with Launch Instance source/detail split that you're seeing. | 13:54 |
| matt-borland | robcresswell, FYI "Dropdowns should have a consistent design" merged, if you want to remove from the bug list | 13:55 |
| matt-borland | I'd be happy to update as well if I know where to do so :) | 13:55 |
| *** akulshin has joined #openstack-horizon | 14:01 | |
| *** sambetts_ has joined #openstack-horizon | 14:02 | |
| *** josecastroleon has joined #openstack-horizon | 14:04 | |
| toabctl | david-lyle: hey. I proposed a patch for the custom theme settings thingy from yesterday: https://review.openstack.org/#/c/243974 | 14:05 |
| *** petertr7_away is now known as petertr7 | 14:05 | |
| toabctl | david-lyle: not exacltly what we discused but imho a simple and clean way to split local_settings.py config if needed. | 14:06 |
| *** ^Gal^ has quit IRC | 14:08 | |
| *** agireud has quit IRC | 14:08 | |
| *** NightKhaos has quit IRC | 14:08 | |
| *** sambetts has quit IRC | 14:08 | |
| *** robcresswell has quit IRC | 14:08 | |
| *** yamamoto has joined #openstack-horizon | 14:11 | |
| *** matt-borland has quit IRC | 14:12 | |
| *** matt-borland has joined #openstack-horizon | 14:12 | |
| *** tmazur_ has quit IRC | 14:14 | |
| *** Liuqing has quit IRC | 14:14 | |
| *** ^Gal^ has joined #openstack-horizon | 14:15 | |
| *** agireud has joined #openstack-horizon | 14:15 | |
| *** NightKhaos has joined #openstack-horizon | 14:15 | |
| *** tosky has quit IRC | 14:17 | |
| *** yamamoto has quit IRC | 14:17 | |
| *** Piet has quit IRC | 14:17 | |
| *** AlonHeller has quit IRC | 14:18 | |
| *** aix has quit IRC | 14:18 | |
| *** tosky has joined #openstack-horizon | 14:18 | |
| akulshin | guys, anyone use Horizon under Internet Explorer? | 14:22 |
| *** jpomeroy has joined #openstack-horizon | 14:25 | |
| *** Piet has joined #openstack-horizon | 14:25 | |
| *** sambetts_ is now known as sambetts | 14:27 | |
| *** itisha has joined #openstack-horizon | 14:29 | |
| *** rebase has joined #openstack-horizon | 14:30 | |
| *** lapalm has joined #openstack-horizon | 14:31 | |
| *** adelia has joined #openstack-horizon | 14:31 | |
| *** wolverineav has joined #openstack-horizon | 14:37 | |
| *** robcresswell has joined #openstack-horizon | 14:38 | |
| *** Piet has quit IRC | 14:40 | |
| *** bradjones|away is now known as bradjones | 14:40 | |
| *** btully has joined #openstack-horizon | 14:40 | |
| *** david-ly_ has joined #openstack-horizon | 14:41 | |
| *** raz_ has joined #openstack-horizon | 14:41 | |
| *** wolverineav has quit IRC | 14:42 | |
| *** david-lyle has quit IRC | 14:42 | |
| *** neelashah has joined #openstack-horizon | 14:43 | |
| doug-fish | akulshin: I haven't for a while, but it should be reasonable to do so ... are you having some trouble? | 14:45 |
| akulshin | yes, i have a bug with environment topology SVG | 14:46 |
| *** ducttape_ has joined #openstack-horizon | 14:46 | |
| doug-fish | which panel is that? | 14:46 |
| akulshin | please check out launchpad https://bugs.launchpad.net/horizon/+bug/1515243 | 14:47 |
| openstack | Launchpad bug 1515243 in OpenStack Dashboard (Horizon) "environment topology rendered incorrectly in ie 10 and 11" [Undecided,New] | 14:47 |
| *** cbader has quit IRC | 14:47 | |
| akulshin | it is Murano Environment, and when you go to any Ready environment, there is a tab called Topology | 14:48 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 14:48 |
| *** _ducttape_ has joined #openstack-horizon | 14:48 | |
| *** aix has joined #openstack-horizon | 14:49 | |
| doug-fish | akulshin: yep got it - I was just looking at the screen shot you included | 14:50 |
| doug-fish | looks like a problem with the Murano plugin | 14:50 |
| akulshin | doug-fish any suggestions? | 14:50 |
| *** ducttape_ has quit IRC | 14:50 | |
| akulshin | Somehow it is working fine under Windows 10 | 14:51 |
| doug-fish | akulshin: your bug needs to get associated with that project. I don't know the murano dashboard project offhand, let me see if I can dig it up | 14:51 |
| kzaitsev_mb | akulshin: murano uses, almost without adjustments stacks topology code | 14:51 |
| kzaitsev_mb | akulshin: does the same happen for stack topology? | 14:52 |
| akulshin | the stacks is fine | 14:52 |
| akulshin | there are no arrows in stacks... | 14:52 |
| kzaitsev_mb | k, so probably not a horizon issue then | 14:52 |
| doug-fish | kzaitsev_mb: sounds like you might now where to find the murano dashboard plugin? | 14:52 |
| kzaitsev_mb | doug-fish: sure. https://github.com/openstack/murano-dashboard =) | 14:53 |
| doug-fish | kzaitsev_mb: does it share a launchpad project with murano? | 14:54 |
| kzaitsev_mb | doug-fish: yep, it dies | 14:54 |
| kzaitsev_mb | https://wiki.openstack.org/wiki/Horizon/BrowserSupport | 14:54 |
| kzaitsev_mb | time to update it for L =) | 14:54 |
| *** aheller has quit IRC | 14:55 | |
| *** cloudtrainme has joined #openstack-horizon | 14:55 | |
| kzaitsev_mb | I would wish to not support IE at all =/ it's always a pain to even test anything in it =/ | 14:55 |
| *** ^Gal^ has quit IRC | 14:55 | |
| akulshin | kzaitsev_mb yes, i think so too, but clients think different... | 14:58 |
| *** ^Gal^ has joined #openstack-horizon | 14:59 | |
| akulshin | guys, i need to go offline, please comment to the bug if any suggestions | 15:04 |
| akulshin | thanks in advance! | 15:04 |
| *** akulshin has quit IRC | 15:05 | |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/horizon: No hostname validation in launch instance angularjs panel https://review.openstack.org/244145 | 15:06 |
| *** yamamoto has joined #openstack-horizon | 15:07 | |
| *** vgridnev has quit IRC | 15:08 | |
| *** ducttape_ has joined #openstack-horizon | 15:09 | |
| *** oetrog_ has quit IRC | 15:10 | |
| *** oetrog has joined #openstack-horizon | 15:11 | |
| *** akrivoka has left #openstack-horizon | 15:12 | |
| *** _ducttape_ has quit IRC | 15:13 | |
| *** mpavlase has quit IRC | 15:13 | |
| *** oetrog has quit IRC | 15:15 | |
| *** mpavlase has joined #openstack-horizon | 15:16 | |
| *** zhurong has quit IRC | 15:17 | |
| *** petertr7 is now known as petertr7_away | 15:24 | |
| *** matt-borland has quit IRC | 15:25 | |
| *** vgridnev has joined #openstack-horizon | 15:26 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Separate agents tests from networks tests file https://review.openstack.org/244159 | 15:28 |
| *** matt-borland has joined #openstack-horizon | 15:29 | |
| *** crobertsrh has quit IRC | 15:30 | |
| *** cbader has joined #openstack-horizon | 15:30 | |
| *** jprovazn has joined #openstack-horizon | 15:32 | |
| *** HenryG has quit IRC | 15:34 | |
| *** HenryG has joined #openstack-horizon | 15:38 | |
| *** adelia_ has joined #openstack-horizon | 15:38 | |
| *** vijendar has joined #openstack-horizon | 15:38 | |
| *** mpavlase has quit IRC | 15:38 | |
| *** adelia has quit IRC | 15:41 | |
| *** memogarcia has joined #openstack-horizon | 15:42 | |
| *** sayan has quit IRC | 15:42 | |
| *** sayan has joined #openstack-horizon | 15:44 | |
| *** mpavlase has joined #openstack-horizon | 15:44 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels https://review.openstack.org/243880 | 15:51 |
| *** yamamoto has quit IRC | 15:53 | |
| *** davidmichaelkarr has joined #openstack-horizon | 15:53 | |
| *** mtanino has joined #openstack-horizon | 15:56 | |
| *** aortega has quit IRC | 15:57 | |
| *** Piet has joined #openstack-horizon | 16:01 | |
| *** _ducttape_ has joined #openstack-horizon | 16:02 | |
| *** hurgleburgler has joined #openstack-horizon | 16:02 | |
| *** openstackgerrit has quit IRC | 16:02 | |
| *** openstackgerrit has joined #openstack-horizon | 16:02 | |
| *** kmartin has joined #openstack-horizon | 16:04 | |
| *** ducttape_ has quit IRC | 16:04 | |
| *** wolverineav has joined #openstack-horizon | 16:05 | |
| *** adelia_ has quit IRC | 16:06 | |
| *** raz_ has quit IRC | 16:07 | |
| *** adelia has joined #openstack-horizon | 16:07 | |
| *** david-ly_ is now known as david-lyle | 16:07 | |
| *** ChanServ sets mode: +o david-lyle | 16:07 | |
| *** cloudtrainme has quit IRC | 16:09 | |
| *** wolverineav has quit IRC | 16:09 | |
| robcresswell | doug-fish: FYI, there is still some debate over the design of the details/breadcrumbs, but its all rapped up in a single template so easy to change them all at once. | 16:12 |
| doug-fish | robcresswell: having *any* breadcrumbs is such an improvement I'm happy to see that code go in now | 16:12 |
| doug-fish | but thanks for sharing! | 16:13 |
| *** belmoreira has quit IRC | 16:13 | |
| *** rhagarty__ has joined #openstack-horizon | 16:13 | |
| robcresswell | doug-fish: Heh, yeah I didn't want to hold up all the logic on the design phase. Its trivial to alter. Thanks for helping to review. | 16:13 |
| *** aorourke_ has joined #openstack-horizon | 16:13 | |
| *** garthb__ has joined #openstack-horizon | 16:15 | |
| *** cloudtrainme has joined #openstack-horizon | 16:16 | |
| *** EmilienM has quit IRC | 16:17 | |
| *** rhagarty_ has quit IRC | 16:17 | |
| *** aorourke has quit IRC | 16:17 | |
| *** patk has quit IRC | 16:17 | |
| *** EmilienM_ has joined #openstack-horizon | 16:17 | |
| *** patk has joined #openstack-horizon | 16:17 | |
| *** EmilienM_ is now known as EmilienM | 16:18 | |
| *** vgridnev has quit IRC | 16:23 | |
| *** gyee has joined #openstack-horizon | 16:28 | |
| matt-borland | pauloewerton, thanks for the reviews! Do you think we need an eslint rule for anonymous functions? It seems either we should add a rule to flag them if they're worth a -1 to reviews. | 16:31 |
| *** masco__ has joined #openstack-horizon | 16:31 | |
| *** aortega has joined #openstack-horizon | 16:31 | |
| *** josecastroleon has quit IRC | 16:32 | |
| *** Drago has joined #openstack-horizon | 16:35 | |
| *** mounica has joined #openstack-horizon | 16:37 | |
| *** sayan has quit IRC | 16:39 | |
| *** akulshin has joined #openstack-horizon | 16:40 | |
| *** nlahouti has joined #openstack-horizon | 16:41 | |
| *** nlahouti has quit IRC | 16:43 | |
| *** memogarcia has quit IRC | 16:44 | |
| *** ducttape_ has joined #openstack-horizon | 16:45 | |
| *** alexvictorchan has joined #openstack-horizon | 16:46 | |
| *** _ducttape_ has quit IRC | 16:46 | |
| *** _ducttape_ has joined #openstack-horizon | 16:47 | |
| *** nlahouti has joined #openstack-horizon | 16:48 | |
| *** ducttap__ has joined #openstack-horizon | 16:49 | |
| *** ducttape_ has quit IRC | 16:49 | |
| *** ducttape_ has joined #openstack-horizon | 16:51 | |
| *** _ducttape_ has quit IRC | 16:51 | |
| *** crobertsrh has joined #openstack-horizon | 16:53 | |
| *** _ducttape_ has joined #openstack-horizon | 16:53 | |
| *** yamamoto has joined #openstack-horizon | 16:53 | |
| *** ducttap__ has quit IRC | 16:54 | |
| *** ducttape_ has quit IRC | 16:56 | |
| *** _ducttape_ has quit IRC | 16:56 | |
| *** akulshin has quit IRC | 16:57 | |
| *** ducttape_ has joined #openstack-horizon | 16:57 | |
| *** tqtran has joined #openstack-horizon | 16:57 | |
| *** tqtran has quit IRC | 16:57 | |
| *** bpokorny has joined #openstack-horizon | 16:58 | |
| *** yamamoto has quit IRC | 16:58 | |
| *** sayan has joined #openstack-horizon | 17:03 | |
| openstackgerrit | Merged openstack/horizon: Retire the reference of StackForge https://review.openstack.org/243761 | 17:07 |
| *** petertr7_away is now known as petertr7 | 17:11 | |
| *** masco__ has quit IRC | 17:13 | |
| *** mounica has quit IRC | 17:14 | |
| zigo | r1chardj0n3s: Whohooo! This completely rox! :) | 17:17 |
| zigo | Thanks for this. | 17:17 |
| robcresswell | zigo: ? | 17:18 |
| *** vgridnev has joined #openstack-horizon | 17:18 | |
| zigo | robcresswell: About phantomjs integration patch at https://review.openstack.org/#/c/242926/ | 17:19 |
| *** ttrifonov has joined #openstack-horizon | 17:19 | |
| zigo | This opens the door to running Selenium tests at package build time, which is a really nice improvement from my perspective. | 17:19 |
| robcresswell | Ahh I see | 17:20 |
| robcresswell | yes, that is good | 17:20 |
| *** petertr7 is now known as petertr7_away | 17:22 | |
| *** petertr7_away is now known as petertr7 | 17:22 | |
| *** sayali has quit IRC | 17:24 | |
| john5223 | upgrading from kilo to liberty i get this : AUTH_USER_MODEL refers to model 'openstack_auth.User' that has not been installed | 17:26 |
| john5223 | i've tried adding that to local_settings.py as openstack_auth.user.User but i still get an error | 17:27 |
| *** aortega_ has joined #openstack-horizon | 17:28 | |
| *** SimonChung has joined #openstack-horizon | 17:28 | |
| david-lyle | john5223: you need to upgrade django_openstack_auth as well | 17:28 |
| john5223 | yes | 17:30 |
| david-lyle | for liberty, the minimum version is 2.0.0 | 17:30 |
| david-lyle | https://github.com/openstack/horizon/blob/stable/liberty/requirements.txt#L17 | 17:30 |
| *** aortega has quit IRC | 17:30 | |
| *** akulshin has joined #openstack-horizon | 17:31 | |
| *** kmartin has quit IRC | 17:31 | |
| *** cloudtrainme has quit IRC | 17:34 | |
| *** flwang1 has joined #openstack-horizon | 17:35 | |
| *** cloudtrainme has joined #openstack-horizon | 17:36 | |
| john5223 | ah. forgot i had a different version installed via pip. thanks | 17:36 |
| *** sayali has joined #openstack-horizon | 17:36 | |
| pauloewerton | matt-borland, yeah, I agree that would be useful. it's a style guide issue, so it sounds appropriate to enforce it via an eslint rule | 17:39 |
| pauloewerton | matt-borland, sorry, I tend to focus on style issues when I review an angular patch the first time ^.^ | 17:40 |
| matt-borland | no problem :) | 17:40 |
| matt-borland | I don't know if Krotscheck has that rule in his list; if so we should clamor to add it (or at least discuss it more actively to make a decision). | 17:41 |
| matt-borland | thanks! | 17:41 |
| pauloewerton | that'd be great, thx | 17:41 |
| krotscheck | Eh, wha? | 17:41 |
| matt-borland | thanks for all the reviews pauloewerton | 17:42 |
| matt-borland | krotscheck, just talking about if we'd like the eslint rule to enforce non-anonymous functions | 17:42 |
| *** wolverineav has joined #openstack-horizon | 17:42 | |
| matt-borland | (the topic surfaced after it coming up in a number of reviews) | 17:42 |
| krotscheck | matt-borland: Let me take a look if we already have that approved - there's a new version of eslint-config-openstack out there that horizon hasn't adopted yet. | 17:42 |
| *** nitzikow has joined #openstack-horizon | 17:43 | |
| matt-borland | ok, cool, thanks! | 17:43 |
| krotscheck | matt-borland: We don't, at this time, have an opinion on that rule. | 17:44 |
| krotscheck | It's called "func-names". | 17:44 |
| matt-borland | cool, thanks! we'll get a discussion on it. | 17:45 |
| krotscheck | matt-borland: Feel free to submit a patch and hold the discussion there. At the moment, the eslint +A policy is "at least +5 with no -1's" | 17:45 |
| krotscheck | matt-borland: I can cut a release anytime you'd like :) | 17:46 |
| *** e0ne has quit IRC | 17:47 | |
| matt-borland | cool, pauloewerton , do you want to spearhead that patch? | 17:47 |
| matt-borland | since it's a major nit that has come up? | 17:47 |
| *** neelashah has quit IRC | 17:48 | |
| pauloewerton | matt-borland, sure, I'll submit a patch :) | 17:49 |
| matt-borland | awesome, thanks! | 17:49 |
| pauloewerton | np | 17:49 |
| *** petertr7 is now known as petertr7_away | 17:50 | |
| *** petertr7_away is now known as petertr7 | 17:51 | |
| *** neelashah has joined #openstack-horizon | 17:51 | |
| *** kzaitsev_mb has quit IRC | 17:52 | |
| *** cloudtrainme has quit IRC | 17:54 | |
| *** tosky has quit IRC | 17:54 | |
| *** errolpais has joined #openstack-horizon | 17:59 | |
| *** flwang1 has quit IRC | 18:00 | |
| *** lapalm has quit IRC | 18:02 | |
| *** lapalm has joined #openstack-horizon | 18:02 | |
| *** akulshin has quit IRC | 18:02 | |
| *** ducttape_ has quit IRC | 18:05 | |
| *** lapalm has quit IRC | 18:06 | |
| *** harlowja_ has quit IRC | 18:08 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add unit tests for load-edit directive https://review.openstack.org/237788 | 18:11 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add unit tests for load-edit directive https://review.openstack.org/237788 | 18:12 |
| *** errolpais has quit IRC | 18:17 | |
| *** nitzikow has quit IRC | 18:20 | |
| *** e0ne has joined #openstack-horizon | 18:22 | |
| *** saksham has joined #openstack-horizon | 18:23 | |
| *** neelashah has quit IRC | 18:23 | |
| *** jpomeroy has quit IRC | 18:24 | |
| *** ccesario has joined #openstack-horizon | 18:24 | |
| *** ducttape_ has joined #openstack-horizon | 18:25 | |
| *** mpavlase has quit IRC | 18:35 | |
| *** ybathia has joined #openstack-horizon | 18:39 | |
| *** harlowja has joined #openstack-horizon | 18:42 | |
| *** harlowja_ has joined #openstack-horizon | 18:44 | |
| *** harlowja has quit IRC | 18:44 | |
| *** akulshin has joined #openstack-horizon | 18:45 | |
| *** nlahouti has quit IRC | 18:46 | |
| *** akulshin has quit IRC | 18:46 | |
| *** vgridnev has quit IRC | 18:49 | |
| *** nlahouti has joined #openstack-horizon | 18:51 | |
| *** _ducttape_ has joined #openstack-horizon | 18:52 | |
| *** vgridnev has joined #openstack-horizon | 18:52 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Plugin Docs https://review.openstack.org/233709 | 18:54 |
| *** ducttape_ has quit IRC | 18:54 | |
| *** doug-fish has quit IRC | 18:56 | |
| *** memogarcia has joined #openstack-horizon | 18:56 | |
| *** doug-fish has joined #openstack-horizon | 18:57 | |
| *** tqtran has joined #openstack-horizon | 18:57 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 18:57 |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 18:58 |
| *** saksham has quit IRC | 18:59 | |
| *** petertr7 is now known as petertr7_away | 18:59 | |
| *** Piet has quit IRC | 19:01 | |
| *** petertr7_away is now known as petertr7 | 19:02 | |
| *** doug-fish has quit IRC | 19:02 | |
| *** lapalm has joined #openstack-horizon | 19:04 | |
| *** neelashah has joined #openstack-horizon | 19:04 | |
| *** lapalm_ has joined #openstack-horizon | 19:06 | |
| *** lapalm_ has quit IRC | 19:06 | |
| *** lapalm_ has joined #openstack-horizon | 19:07 | |
| *** jprovazn has quit IRC | 19:07 | |
| *** lapalm has quit IRC | 19:09 | |
| *** errolpais has joined #openstack-horizon | 19:10 | |
| *** rebase has quit IRC | 19:11 | |
| *** lapalm has joined #openstack-horizon | 19:11 | |
| *** wolverineav has quit IRC | 19:12 | |
| *** lapalm_ has quit IRC | 19:12 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: Fix CSS classes for delete button in action delete template https://review.openstack.org/243796 | 19:12 |
| *** wolverineav has joined #openstack-horizon | 19:12 | |
| *** wolverin_ has joined #openstack-horizon | 19:13 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: WIP: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 19:15 |
| *** doug-fish has joined #openstack-horizon | 19:16 | |
| *** petertr7 is now known as petertr7_away | 19:20 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels https://review.openstack.org/243880 | 19:21 |
| *** kmartin has joined #openstack-horizon | 19:23 | |
| *** lexholden has joined #openstack-horizon | 19:23 | |
| *** flwang1 has joined #openstack-horizon | 19:23 | |
| *** memogarcia has quit IRC | 19:24 | |
| *** saksham has joined #openstack-horizon | 19:25 | |
| *** cloudtrainme has joined #openstack-horizon | 19:25 | |
| *** lhcheng has joined #openstack-horizon | 19:29 | |
| *** lhcheng_ has joined #openstack-horizon | 19:30 | |
| *** josecastroleon has joined #openstack-horizon | 19:32 | |
| *** lhcheng has quit IRC | 19:33 | |
| *** Piet has joined #openstack-horizon | 19:33 | |
| *** aix has quit IRC | 19:33 | |
| *** rebase has joined #openstack-horizon | 19:36 | |
| *** josecastroleon has quit IRC | 19:36 | |
| *** petertr7_away is now known as petertr7 | 19:38 | |
| *** rdopiera has quit IRC | 19:40 | |
| *** wolverin_ has quit IRC | 19:45 | |
| *** swebb has joined #openstack-horizon | 19:46 | |
| *** wolverin_ has joined #openstack-horizon | 19:49 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 19:50 |
| *** lhcheng_ is now known as lhcheng | 19:54 | |
| *** wolverineav has joined #openstack-horizon | 19:56 | |
| *** wolverin_ has quit IRC | 19:59 | |
| *** itisha has quit IRC | 20:01 | |
| *** ducttape_ has joined #openstack-horizon | 20:01 | |
| *** _ducttape_ has quit IRC | 20:05 | |
| *** e0ne has quit IRC | 20:06 | |
| pauloewerton | david-lyle, hello. can you please take another look at https://review.openstack.org/#/c/215352/ and consider removing your -2? I guess your concern was the integration tests | 20:06 |
| *** _ducttape_ has joined #openstack-horizon | 20:07 | |
| *** ducttape_ has quit IRC | 20:08 | |
| *** jpomeroy has joined #openstack-horizon | 20:08 | |
| *** saksham has quit IRC | 20:09 | |
| *** petertr7 is now known as petertr7_away | 20:13 | |
| *** petertr7_away is now known as petertr7 | 20:13 | |
| *** memogarcia has joined #openstack-horizon | 20:14 | |
| *** lexholden has quit IRC | 20:19 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/django_openstack_auth: Refactor d-o-a to use keystoneauth library https://review.openstack.org/205251 | 20:20 |
| *** memogarcia has quit IRC | 20:23 | |
| *** petertr7 is now known as petertr7_away | 20:23 | |
| *** petertr7_away is now known as petertr7 | 20:23 | |
| *** petertr7 is now known as petertr7_away | 20:25 | |
| *** petertr7_away is now known as petertr7 | 20:28 | |
| *** nlahouti has quit IRC | 20:28 | |
| *** nlahouti has joined #openstack-horizon | 20:34 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:35 | |
| *** memogarcia has joined #openstack-horizon | 20:35 | |
| hurgleburgler | who's able to update XStatic-Bootstrap-SCSS ? | 20:35 |
| hurgleburgler | we need to move to 3.3.5 | 20:35 |
| mrunge | we can not, r1chardj0n3s has dirty details | 20:36 |
| hurgleburgler | I found some fixes we will need … I'll reach out to him to see what the details are :) | 20:38 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 20:38 |
| *** wolverineav has quit IRC | 20:38 | |
| *** wolverineav has joined #openstack-horizon | 20:39 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: hz-page-header should allow string interpolations https://review.openstack.org/223793 | 20:40 |
| mrunge | hurgleburgler, basically, we're blocked by pbr | 20:40 |
| mrunge | which can not handle versions like 1.2.3.4 | 20:40 |
| mrunge | the corresponding blueprint is blocked. | 20:40 |
| hurgleburgler | mrunge how does that affect updating from Bootstrap 3.2.0 to 3.3.5 ? | 20:41 |
| mrunge | sure | 20:41 |
| mrunge | it affects our ability to release basically anything with 4 version numbers | 20:41 |
| *** nitzikow has joined #openstack-horizon | 20:42 | |
| *** wolverin_ has joined #openstack-horizon | 20:43 | |
| *** wolverineav has quit IRC | 20:44 | |
| *** nitzikow has quit IRC | 20:46 | |
| mrunge | hurgleburgler, ah, sorry. a bit too late for me here. that update should work | 20:48 |
| hurgleburgler | :-D | 20:48 |
| hurgleburgler | thanks mrunge | 20:48 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 20:50 |
| r1chardj0n3s | morning | 20:50 |
| TravT | morning | 20:50 |
| r1chardj0n3s | so, what's this about xstatic mrunge and hurgleburgler? | 20:51 |
| *** kmartin has quit IRC | 20:52 | |
| hurgleburgler | we're running bootstrap-scss 3.2.0, but I've found some fixes in 3.3.5 we need | 20:52 |
| hurgleburgler | plus, we are running bootswatch 3.3.5 … that might cause some … strangeness | 20:52 |
| hurgleburgler | was just wondering who could update the xstatic package | 20:52 |
| hurgleburgler | looks like its owned by radomir | 20:52 |
| r1chardj0n3s | ok, I can "fix" that | 20:53 |
| hurgleburgler | :-D | 20:53 |
| *** belmoreira has joined #openstack-horizon | 20:53 | |
| r1chardj0n3s | it's a temporary fix, but it's all we have right now | 20:53 |
| *** nlahouti has quit IRC | 20:54 | |
| hurgleburgler | k | 20:54 |
| r1chardj0n3s | wait, radomir doesn't go by the username "sheep" on pypi, does he? | 20:54 |
| r1chardj0n3s | that's someone else? | 20:54 |
| hurgleburgler | hold on | 20:55 |
| hurgleburgler | https://pypi.python.org/pypi/XStatic-Bootstrap-SCSS/3.2.0.0 | 20:56 |
| hurgleburgler | —> Author: Radomir Dopieralski | 20:56 |
| hurgleburgler | do you see somethign different? | 20:56 |
| mrunge | I think radomir uses sheep on pypi | 20:57 |
| r1chardj0n3s | huh, there you go | 20:58 |
| hurgleburgler | \o/ | 20:58 |
| r1chardj0n3s | so, has anyone contacted radomir about it, and if he's not going to do it, who's going to create the new XStatic-Bootstrap-SCSS | 20:58 |
| *** zao has left #openstack-horizon | 20:59 | |
| *** lnxnut has joined #openstack-horizon | 20:59 | |
| hurgleburgler | I haven't … I can though | 21:00 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/django_openstack_auth: Refactor d-o-a to use keystoneauth library https://review.openstack.org/205251 | 21:01 |
| hurgleburgler | to both of those questions | 21:01 |
| r1chardj0n3s | \o/ hurgleburgler | 21:01 |
| doug-fish | I think it's important that a deployer is able to make any final adjustments to their settings by editing local_settings.py - they shouldn't be editing enabled files | 21:04 |
| doug-fish | and if we have values specified in local_settings that plugins need to override that's probably a mistake | 21:05 |
| david-lyle | doug-fish: in reality it's python, you can override anything at any time | 21:05 |
| robcresswell | Yeah, I think that makes sense. Otherwise plugins could have the final say on the setting you're using locally | 21:05 |
| doug-fish | david-lyle: well I'm glad that's fixed when we go to JavaScript | 21:06 |
| david-lyle | :D | 21:06 |
| mrunge | doug-fish, what about adding a super cool plugin for caching? | 21:06 |
| robcresswell | ahaha | 21:06 |
| tqtran | how about moving local_settings to local_settings.d folder? | 21:06 |
| tqtran | it will have the last say | 21:06 |
| *** memogarcia has quit IRC | 21:06 | |
| mrunge | and the deployer is the person to install/remove plugins | 21:06 |
| tqtran | but will allow other folks to drop in their settings override | 21:06 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 21:06 |
| david-lyle | again, I'm not sure general plugins should be overriding most local_settings | 21:07 |
| robcresswell | tqtran: Well, you'd just change the load order. Settings -> local.d -> local.py | 21:07 |
| david-lyle | but in same cases it will be invaluable | 21:07 |
| robcresswell | I'm just not sold on having a drop in mechanism for some stuff, and another mechanism for some other stuff | 21:07 |
| *** saksham has joined #openstack-horizon | 21:07 | |
| doug-fish | david-lyle: is there a reason we have INSTALLED_APPS in local_settings, not settings? | 21:07 |
| *** jwy has joined #openstack-horizon | 21:07 | |
| tqtran | so now that i think about it, what setting other than custom theme do we want to allow overrides? | 21:08 |
| robcresswell | When we could, in theory, just have an enabled file with SETTINGS = {'foo': 'bar'} | 21:08 |
| mrunge | I'd say: basically all settings to override | 21:08 |
| tqtran | that seems kind of dangerous.... | 21:09 |
| sjmc7 | doug-fish - it is in settings.py | 21:09 |
| *** pauloewerton has quit IRC | 21:09 | |
| mrunge | but why? | 21:09 |
| david-lyle | doug-fish: actually it's in settings.py, I miswrote | 21:09 |
| doug-fish | sjmc7: good! | 21:09 |
| david-lyle | doug-fish: O_o | 21:09 |
| robcresswell | tqtran: Things like the various IMAGES config, or OPENSTACK_NEUTRON_NETWORK I suppose | 21:09 |
| tqtran | this would give plugin the power to mess up horizon completely wouldnt it? | 21:09 |
| mrunge | the deployer is going to add a plugin. if horizon doesn't work afterwards, remove the plugin, no harm is done | 21:10 |
| doug-fish | so that's what I'd hoped - settings.py has the default - the yet to be decided plugin mechanism can update those, and local_settings lets the user set final choices | 21:10 |
| mrunge | yes, it does, tqtran | 21:10 |
| david-lyle | tqtran: it has it now | 21:10 |
| mrunge | but since we're not changing any file previously installed on the system, we just remove it | 21:10 |
| david-lyle | include and overrides.py and set the customization_module | 21:10 |
| *** yamamoto has joined #openstack-horizon | 21:10 | |
| robcresswell | btw, why is OPENSTACK_NEUTRON_NETWORK in local_settings but not settings? | 21:11 |
| mrunge | that's what package managers are doing | 21:11 |
| david-lyle | in HORIZON_CONFIG | 21:11 |
| *** wolverineav has joined #openstack-horizon | 21:11 | |
| tqtran | hm.... seems like I could introduce a malicious plugin to end all things | 21:11 |
| mrunge | tqtran, yes | 21:11 |
| robcresswell | Yup | 21:11 |
| david-lyle | robcresswell: very deployment specific | 21:11 |
| sjmc7 | if you’re able to write to the filesystem you can do all kinds of things :) | 21:11 |
| mrunge | you can. but it's easy to remove it | 21:12 |
| doug-fish | frankly, I'm more worried about poorly written plugins | 21:12 |
| robcresswell | david-lyle: Ah, I see | 21:12 |
| mrunge | take LOGIN_URL as example | 21:12 |
| mrunge | I could imagine, deployers would like to add a plugin to handle login/logout differently | 21:12 |
| mrunge | via plugin | 21:13 |
| robcresswell | doug-fish: This is what I said before about controlling what can be overriden; we could just put more settings into HORIZON_CONFIG, which can already be updated. | 21:13 |
| robcresswell | That way, we limit the scope | 21:13 |
| *** wolverin_ has quit IRC | 21:13 | |
| david-lyle | robcresswell: I don't think you do | 21:13 |
| *** wolverin_ has joined #openstack-horizon | 21:13 | |
| david-lyle | but I like the notion | 21:13 |
| robcresswell | I don't know if thats necessarily desirable though, its just a suggestion | 21:13 |
| robcresswell | david-lyle: How so? | 21:13 |
| *** wolverineav has quit IRC | 21:14 | |
| tqtran | I dont think that is a good idea, we are already shoving tons of client-side settings into HORIZON_CONFIG, its like a config object within a config file | 21:14 |
| mrunge | still I'm not convinced, we should limit overriding at all | 21:14 |
| tqtran | right now, we have to whitelist the damn thing in order to pass some of the settings along to client-side | 21:14 |
| robcresswell | Seems like if load specific keys from HORIZON_CONFIG and allow updating of that dict, they can't get outside of that (aside from cuistomization_module hackery) | 21:14 |
| robcresswell | mrunge: No, I'm not either. It's just an idea :) | 21:15 |
| david-lyle | robcresswell: https://github.com/openstack/horizon/blob/master/doc/source/topics/customizing.rst#horizon-customization-module-overrides | 21:15 |
| david-lyle | that's the mother of all backdoors | 21:15 |
| mrunge | I see the possibility to completely mess up things | 21:15 |
| david-lyle | and it's been completely open since we included plugins | 21:16 |
| mrunge | but that can be done with malicious plugins today | 21:16 |
| robcresswell | david-lyle: Yeah, I mentioned it above. But, I'm just focusing on the settings idea for now. | 21:16 |
| david-lyle | robcresswell: I can override settings module to load whatever the heck I want | 21:16 |
| david-lyle | just saying | 21:16 |
| robcresswell | david-lyle: Yeah, sure. I'm just talking about how to handle settings overrides regardless of the existence of monkey-patch-module-backdoor | 21:17 |
| david-lyle | but even aside from that | 21:17 |
| *** memogarcia has joined #openstack-horizon | 21:17 | |
| david-lyle | I can put an enabled file to override any panel/dashboard/etc | 21:18 |
| david-lyle | there has to be some trust in the system | 21:18 |
| *** kmartin has joined #openstack-horizon | 21:18 | |
| robcresswell | Yeah, true. | 21:19 |
| robcresswell | Also, all of the plugins are totally open source | 21:19 |
| david-lyle | I don't want to over-engineer a solution in the name of security and then not be able to provide it anyway | 21:20 |
| david-lyle | not even security I guess | 21:20 |
| robcresswell | Fair enough | 21:20 |
| david-lyle | to insure the kids play nice together | 21:20 |
| robcresswell | It was more about the ease of use, because the mechanism to override that is already in place | 21:21 |
| robcresswell | So its trivial to add to it. Doesnt solve the content-less part though, as you pointed out yesterday. | 21:21 |
| david-lyle | robcresswell: that part I understand | 21:21 |
| robcresswell | :D | 21:21 |
| *** yamamoto has quit IRC | 21:22 | |
| david-lyle | I think it requires more thought either way for sure | 21:22 |
| *** wolverineav has joined #openstack-horizon | 21:22 | |
| *** wolverin_ has quit IRC | 21:22 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Separate agents tests from networks tests file https://review.openstack.org/244159 | 21:23 |
| robcresswell | Indeed | 21:23 |
| robcresswell | Is anyone actively working on it right now? | 21:23 |
| *** lhcheng has quit IRC | 21:23 | |
| robcresswell | I can free up some time next week probably, but just curious | 21:24 |
| *** memogarcia has quit IRC | 21:24 | |
| *** crobertsrh has left #openstack-horizon | 21:25 | |
| *** sayan has quit IRC | 21:27 | |
| *** crobertsrh has joined #openstack-horizon | 21:27 | |
| *** lnxnut has quit IRC | 21:29 | |
| Piet | Unfortunately, "openstack-ux" was already registered by Jaromir Coufal about two years ago | 21:29 |
| Piet | Sorry...wrong channel | 21:30 |
| *** wolverin_ has joined #openstack-horizon | 21:30 | |
| *** wolverineav has quit IRC | 21:30 | |
| *** memogarcia has joined #openstack-horizon | 21:34 | |
| *** wolverineav has joined #openstack-horizon | 21:38 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 21:38 |
| *** wolverin_ has quit IRC | 21:39 | |
| *** wolverin_ has joined #openstack-horizon | 21:41 | |
| *** lapalm has quit IRC | 21:41 | |
| *** wolverineav has quit IRC | 21:42 | |
| *** belmoreira has quit IRC | 21:46 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 21:48 |
| *** nlahouti has joined #openstack-horizon | 21:51 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 21:51 |
| *** emilyw has joined #openstack-horizon | 21:55 | |
| *** matt-borland has quit IRC | 21:57 | |
| *** neelashah has quit IRC | 22:02 | |
| *** memogarcia has quit IRC | 22:02 | |
| *** vgridnev has quit IRC | 22:02 | |
| *** crobertsrh is now known as _crobertsrh | 22:02 | |
| *** memogarcia has joined #openstack-horizon | 22:04 | |
| *** lhcheng has joined #openstack-horizon | 22:07 | |
| *** SimonChung1 has joined #openstack-horizon | 22:07 | |
| *** SimonChung1 has quit IRC | 22:08 | |
| *** SimonChung2 has joined #openstack-horizon | 22:08 | |
| *** SimonChung has quit IRC | 22:08 | |
| *** memogarcia has quit IRC | 22:08 | |
| *** yamamoto has joined #openstack-horizon | 22:10 | |
| lhcheng | has the npm test been failing? | 22:12 |
| lhcheng | its not clear what's the caused of failure: http://logs.openstack.org/97/243897/3/check/gate-horizon-npm-run-test/73c64cd/console.html | 22:13 |
| *** memogarcia has joined #openstack-horizon | 22:14 | |
| david-lyle | lhcheng: simple, PhantomJS crashed ;) | 22:14 |
| david-lyle | is 1.9.8 new? | 22:15 |
| lhcheng | david-lyle: been crashing consistently for my patch :( | 22:15 |
| lhcheng | no idea what's the latest version | 22:16 |
| david-lyle | nope a year old | 22:17 |
| david-lyle | hmm | 22:17 |
| lhcheng | other tests are failing too | 22:17 |
| lhcheng | I meant other patches | 22:17 |
| *** petertr7 is now known as petertr7_away | 22:17 | |
| lhcheng | \o/ | 22:17 |
| r1chardj0n3s | \o/ | 22:18 |
| david-lyle | fail them all | 22:18 |
| lhcheng | but this passed: https://review.openstack.org/#/c/223793/ , so its random, but high chance.. :P | 22:19 |
| *** lblanchard has quit IRC | 22:21 | |
| r1chardj0n3s | it's a good thing I have patches in for MOAR PHANTOM | 22:21 |
| *** memogarcia has quit IRC | 22:23 | |
| *** alexvictorchan has quit IRC | 22:25 | |
| *** doug-fish has quit IRC | 22:27 | |
| *** jpomeroy has quit IRC | 22:27 | |
| *** doug-fish has joined #openstack-horizon | 22:28 | |
| *** wolverin_ has quit IRC | 22:28 | |
| *** wolverineav has joined #openstack-horizon | 22:28 | |
| *** doug-fis_ has joined #openstack-horizon | 22:30 | |
| *** kyleolivo has joined #openstack-horizon | 22:32 | |
| *** doug-fish has quit IRC | 22:32 | |
| *** kyleolivo has quit IRC | 22:33 | |
| * lhcheng loads a lot "recheck" to shoot gerrit with | 22:33 | |
| *** doug-fis_ has quit IRC | 22:34 | |
| *** memogarcia has joined #openstack-horizon | 22:35 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: New Theme Work Needs Better Documentation https://review.openstack.org/238723 | 22:35 |
| *** wolverineav has quit IRC | 22:37 | |
| *** wolverineav has joined #openstack-horizon | 22:37 | |
| *** doug-fish has joined #openstack-horizon | 22:43 | |
| *** jpomeroy has joined #openstack-horizon | 22:46 | |
| *** doug-fish has quit IRC | 22:47 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Basic tables now inherit from Bootstrap Theme https://review.openstack.org/218608 | 22:47 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Login now inherits from Bootstrap Theme https://review.openstack.org/219881 | 22:49 |
| *** memogarcia has quit IRC | 22:53 | |
| *** kyleolivo has joined #openstack-horizon | 22:55 | |
| *** kyleolivo has quit IRC | 22:56 | |
| *** kyleolivo has joined #openstack-horizon | 22:57 | |
| lhcheng | ^Gal^ ping | 22:58 |
| *** ducttape_ has joined #openstack-horizon | 23:01 | |
| lhcheng | ^Gal^: we're also interested on adding support for nested stack in the ui, let me know if you need help. | 23:02 |
| *** _ducttape_ has quit IRC | 23:04 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Add Developer Dashboard + Bootstrap Theme Preview https://review.openstack.org/209631 | 23:06 |
| *** Piet has quit IRC | 23:06 | |
| *** SimonChung2 has quit IRC | 23:08 | |
| *** SimonChung has joined #openstack-horizon | 23:08 | |
| *** amotoki has quit IRC | 23:10 | |
| *** rebase has quit IRC | 23:10 | |
| *** ybathia has quit IRC | 23:12 | |
| *** ZZelle has quit IRC | 23:13 | |
| *** memogarcia has joined #openstack-horizon | 23:13 | |
| *** ZZelle has joined #openstack-horizon | 23:17 | |
| *** vijendar has quit IRC | 23:17 | |
| *** jpomeroy has quit IRC | 23:17 | |
| *** adelia has quit IRC | 23:18 | |
| *** adelia has joined #openstack-horizon | 23:18 | |
| *** ZZelle has quit IRC | 23:21 | |
| *** adelia has quit IRC | 23:23 | |
| *** DaveJ__ has joined #openstack-horizon | 23:23 | |
| *** errolpais has quit IRC | 23:23 | |
| *** Piet has joined #openstack-horizon | 23:25 | |
| *** memogarcia has quit IRC | 23:27 | |
| *** memogarcia has joined #openstack-horizon | 23:31 | |
| *** ducttape_ has quit IRC | 23:39 | |
| *** cloudtrainme has quit IRC | 23:39 | |
| *** rebase has joined #openstack-horizon | 23:39 | |
| *** ducttape_ has joined #openstack-horizon | 23:39 | |
| *** wolverineav has quit IRC | 23:42 | |
| *** kmartin has quit IRC | 23:46 | |
| *** kmartin has joined #openstack-horizon | 23:46 | |
| *** doug-fish has joined #openstack-horizon | 23:47 | |
| *** doug-fish has quit IRC | 23:50 | |
| *** memogarcia has quit IRC | 23:53 | |
| *** memogarcia has joined #openstack-horizon | 23:55 | |
| ducttape_ | lhcheng - ping | 23:56 |
| lhcheng | ducttape_: pong | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!