ducttape_ | I have a super ugly patch / fix | 00:00 |
---|---|---|
ducttape_ | I bring this up in this room, for public shaming | 00:00 |
hurgleburgler | Ooo, now i want to see it too | 00:01 |
*** Piet has quit IRC | 00:02 | |
*** doug-fish has joined #openstack-horizon | 00:02 | |
ducttape_ | for some reason gerrit it being slow on my vm | 00:02 |
ducttape_ | did I not get the memo??? | 00:03 |
openstackgerrit | Eric Peterson proposed openstack/horizon: Prevent project detail link result in user log out https://review.openstack.org/222437 | 00:03 |
*** wolverineav has joined #openstack-horizon | 00:03 | |
ducttape_ | boom! there you go. lhcheng - I think I might need to add more context to the policy check for projects | 00:03 |
ducttape_ | for key v3 that is | 00:03 |
ducttape_ | but keystone v3 is like writing code for bigfoot, amirite !? | 00:04 |
*** doug-fish has quit IRC | 00:06 | |
*** jamielennox is now known as jamielennox|away | 00:08 | |
lhcheng | hah | 00:11 |
lhcheng | code looks good to me, just need to replace the commit summary of the patch | 00:11 |
lhcheng | bpokorny esp_ may be able to respond more accurately about using v3:P | 00:13 |
esp_ | heya | 00:13 |
esp_ | who woke me up :) | 00:14 |
bpokorny | Heh | 00:14 |
*** _ducttape_ has joined #openstack-horizon | 00:14 | |
_ducttape_ | yeah, i thought I saw the policy for it, it looked up something like domain or project id or something | 00:15 |
bpokorny | Yeah, there's a patch out to add a v3 sample policy. | 00:15 |
esp_ | yeah, we have something like that here | 00:16 |
_ducttape_ | this is for a particular check, the one for identity:get_project | 00:16 |
esp_ | https://review.openstack.org/#/c/196328/ | 00:16 |
_ducttape_ | https://review.openstack.org/#/c/222437/ is the check I speak of | 00:17 |
*** doug-fish has joined #openstack-horizon | 00:17 | |
*** ducttape_ has quit IRC | 00:17 | |
* esp_ lookin’ | 00:17 | |
_ducttape_ | I think I need to add project to the context for the policy check | 00:17 |
_ducttape_ | but really, I like to claim ignorance of the policy engine.... thus I let other people tell me what's wrong ;) | 00:18 |
esp_ | hehe | 00:18 |
* _ducttape_ has a policy engine badge of honor | 00:18 | |
*** kzaitsev_mb has quit IRC | 00:19 | |
*** kzaitsev_mb has joined #openstack-horizon | 00:20 | |
esp_ | _ducttape_: is this the hyper link in the projects table? | 00:20 |
_ducttape_ | yep | 00:20 |
esp_ | supposed to go to project details but only admin can ever see it? | 00:20 |
_ducttape_ | if you click on the link, as a member - we log you out | 00:20 |
esp_ | right | 00:20 |
*** doug-fish has quit IRC | 00:21 | |
esp_ | so, I recall david-lyle or lhcheng telling me… | 00:21 |
_ducttape_ | don't trust either of those guys | 00:21 |
esp_ | that *feature* made it’s way into horizon under the cover of darkness | 00:21 |
lhcheng | hah | 00:21 |
*** jamielennox|away is now known as jamielennox | 00:21 | |
_ducttape_ | yeah, and it's fine.... except that its broken 95% of the time | 00:22 |
lhcheng | those two are all crazy talks | 00:22 |
esp_ | I always thought that maybe it should be a full blown action in the dropdown button control on the right | 00:22 |
_ducttape_ | I like the link, it follows the other ux patterns | 00:22 |
stevemar_ | lhcheng: you're like 50% crazy talk | 00:22 |
_ducttape_ | having the table drop down is a lazy way to fix it, I think | 00:22 |
esp_ | yeah, but it’s hard to control the link with policy checks, permissions | 00:23 |
_ducttape_ | esp_ - not with a healthy amount of monkey patching and ducttape | 00:23 |
esp_ | yeah, it might be lazy, but the actions have full support of the policy checks | 00:23 |
_ducttape_ | #branding | 00:23 |
esp_ | links do not | 00:23 |
_ducttape_ | mine does ;) | 00:23 |
esp_ | hehe | 00:23 |
*** memogarcia has quit IRC | 00:23 | |
esp_ | well, I guess if you can get it in there somehow… | 00:24 |
_ducttape_ | if you see the wright way to setup the policy check for v3 esp_ - please review and correct me as needed | 00:25 |
bpokorny | _ducttape_: The policy check as you have it looks right to me for v3. | 00:26 |
esp_ | k, I think I tried it once a while a go with no success but I’ll take a look at what you got. | 00:26 |
lhcheng | stevemar_: I agree, I do my crazy talk when I am on the other room (keystone) :P | 00:26 |
bpokorny | _ducttape_: Did you see some issue with that when using v3? | 00:26 |
_ducttape_ | ok. thanks bpokorny esp_ | 00:26 |
lhcheng | _ducttape_: I think you need to pass a third argument to policy.check(..) | 00:26 |
_ducttape_ | thats my concern lhcheng, but I am not sure | 00:26 |
lhcheng | _ducttape_: so that value of the target is accessible | 00:26 |
esp_ | thx bpokorny :) I’m useless | 00:26 |
lhcheng | _ducttape_: to make this check work: https://github.com/openstack/keystone/blob/master/etc/policy.v3cloudsample.json#L38 | 00:27 |
_ducttape_ | exactly, that is my concern. but I don't have a rich keystone v3 setup to test that with. | 00:27 |
bpokorny | np, esp_ . How many engineers does it take to make a policy check ;) | 00:28 |
_ducttape_ | I'll correct the comments later, but right now you guys can see if what I have is close or if I need that target arg | 00:28 |
_ducttape_ | bpokorny - we have a memo, some new cover sheets for the policy checks. did you get that memo? | 00:29 |
*** Piet has joined #openstack-horizon | 00:29 | |
bpokorny | I think I forgot the TPS report. | 00:29 |
bpokorny | I swear I'll remember next time though. | 00:29 |
* bpokorny looking for whether we have an example in the domains patch. | 00:31 | |
esp_ | _ducttape_: my memory just came back. I had a bug from QA that said they wanted to display that link as plain text if the user (Member) didn’t have permissions. | 00:31 |
lhcheng | _ducttape_: I think what you have is very close | 00:31 |
esp_ | I don’t know if you will try that route, I don’t recommend it :) | 00:31 |
lhcheng | _ducttape_: does passing the target arg blow up when using v2? | 00:31 |
_ducttape_ | not sure. I'm ready to kill a few braincells at this point | 00:32 |
*** kzaitsev_mb has quit IRC | 00:32 | |
*** ybathia has joined #openstack-horizon | 00:32 | |
*** memogarcia has joined #openstack-horizon | 00:32 | |
*** kzaitsev_mb has joined #openstack-horizon | 00:33 | |
_ducttape_ | I'll check it more tomorrow lhcheng, also I really should try our keystone v3 endpoint with this. that endpoint is very lonely | 00:33 |
lhcheng | I'm fine with the code as is, since esp_ got a bug to fix that for v3 anyway :P | 00:33 |
esp_ | +1 | 00:34 |
lhcheng | _ducttape_: cool | 00:34 |
*** _ducttape_ has quit IRC | 00:35 | |
bpokorny | I see we're doing similar checks in the domains patch: https://review.openstack.org/#/c/148082/86/openstack_dashboard/dashboards/identity/domains/tables.py | 00:35 |
bpokorny | policy_rules = (("identity", "identity:update_domain"),) | 00:35 |
bpokorny | For example. | 00:35 |
esp_ | yeh, it’s all coming back to me now | 00:37 |
bpokorny | So I'm thinking the way Eric has it is correct. | 00:37 |
*** kzaitsev_mb has quit IRC | 00:38 | |
*** kzaitsev_mb has joined #openstack-horizon | 00:39 | |
*** amotoki has joined #openstack-horizon | 00:41 | |
*** alexvictorchan has joined #openstack-horizon | 00:46 | |
*** kzaitsev_mb has quit IRC | 00:46 | |
*** kzaitsev_mb has joined #openstack-horizon | 00:48 | |
*** nlahouti has quit IRC | 00:52 | |
*** nlahouti has joined #openstack-horizon | 00:52 | |
lhcheng | bpokorny: the policy check for v3 get_project requires a target.project, thinking it had to be passed somehow | 00:53 |
lhcheng | https://github.com/openstack/keystone/blob/master/etc/policy.v3cloudsample.json#L38 | 00:53 |
bpokorny | lhcheng: I see what you're saying now. Yeah, it looks like the target would have to be passed as well. | 00:54 |
*** memogarcia has quit IRC | 00:55 | |
*** doug-fish has joined #openstack-horizon | 00:56 | |
openstackgerrit | Kyle Olivo proposed openstack/horizon: Split instance details and source in Launch Instance wizard. https://review.openstack.org/235004 | 00:57 |
*** aorourke_ is now known as aorourke | 00:57 | |
*** emilyw has quit IRC | 00:58 | |
lhcheng | bpokorny: yeah, I can't recall if it needs to be wrapped in a dict, but something have to be passed. | 00:58 |
*** ybathia has quit IRC | 00:59 | |
*** aorourke is now known as aorourke-afk | 00:59 | |
*** doug-fish has quit IRC | 01:00 | |
bpokorny | ok. I'll have to check if we need to make some changes for that for the domains patch as well. | 01:00 |
*** kyleolivo has quit IRC | 01:00 | |
*** memogarcia has joined #openstack-horizon | 01:02 | |
lhcheng | ok | 01:02 |
*** julim has quit IRC | 01:02 | |
*** kzaitsev_mb has quit IRC | 01:04 | |
*** kzaitsev_mb has joined #openstack-horizon | 01:04 | |
*** saksham has left #openstack-horizon | 01:07 | |
*** rhagarty_ has joined #openstack-horizon | 01:07 | |
*** kmartin_ has joined #openstack-horizon | 01:09 | |
*** btully has quit IRC | 01:10 | |
*** garthb__ has quit IRC | 01:10 | |
*** rhagarty__ has quit IRC | 01:11 | |
*** kzaitsev_mb has quit IRC | 01:11 | |
*** wolverineav has quit IRC | 01:12 | |
*** kmartin has quit IRC | 01:13 | |
*** SimonChung has quit IRC | 01:13 | |
*** raz_ has joined #openstack-horizon | 01:15 | |
*** zhenguo has joined #openstack-horizon | 01:18 | |
*** wolverineav has joined #openstack-horizon | 01:21 | |
*** kzaitsev_mb has joined #openstack-horizon | 01:22 | |
*** doug-fish has joined #openstack-horizon | 01:22 | |
*** reedip has joined #openstack-horizon | 01:23 | |
reedip | Dear All, Can you help with the review of the following gerrit IDs? | 01:23 |
reedip | https://review.openstack.org/#/c/238778/ | 01:23 |
*** errolpais has joined #openstack-horizon | 01:25 | |
reedip | https://review.openstack.org/#/c/232382/ | 01:25 |
reedip | It would be great help , thanks in advance | 01:26 |
*** doug-fish has quit IRC | 01:27 | |
lhcheng | reedip: comments added | 01:27 |
lhcheng | code looks good, just have a minor issue on loading the update form | 01:27 |
reedip | lhcheng: thanks..... Got it , will update the new code | 01:28 |
reedip | thanks a lot for your comments.. | 01:28 |
*** nlahouti has quit IRC | 01:29 | |
lhcheng | reedip: anytime | 01:33 |
*** kzaitsev_mb has quit IRC | 01:34 | |
*** jbell8 has quit IRC | 01:35 | |
*** itisha has joined #openstack-horizon | 01:39 | |
*** mtanino has quit IRC | 01:45 | |
*** kyleolivo has joined #openstack-horizon | 01:48 | |
*** kyleolivo has quit IRC | 01:48 | |
*** bpokorny has quit IRC | 01:53 | |
*** btully has joined #openstack-horizon | 01:57 | |
*** davidmichaelkarr has quit IRC | 02:00 | |
*** doug-fish has joined #openstack-horizon | 02:02 | |
openstackgerrit | Travis Tripp proposed openstack/horizon: Support docker image type in ng launch instance wizard https://review.openstack.org/217894 | 02:06 |
*** doug-fish has quit IRC | 02:06 | |
*** memogarcia has quit IRC | 02:08 | |
*** memogarcia has joined #openstack-horizon | 02:10 | |
*** wolverin_ has joined #openstack-horizon | 02:11 | |
*** wolverineav has quit IRC | 02:12 | |
*** gyee has quit IRC | 02:14 | |
*** errolpais has quit IRC | 02:15 | |
*** davidmichaelkarr has joined #openstack-horizon | 02:17 | |
*** raz_ has quit IRC | 02:17 | |
*** raz_ has joined #openstack-horizon | 02:19 | |
reedip | lhcheng: ping | 02:22 |
*** doug-fish has joined #openstack-horizon | 02:28 | |
*** kzaitsev_mb has joined #openstack-horizon | 02:30 | |
*** wolverineav has joined #openstack-horizon | 02:30 | |
*** doug-fish has quit IRC | 02:33 | |
*** wolverin_ has quit IRC | 02:33 | |
*** kzaitsev_mb has quit IRC | 02:34 | |
*** lnxnut has joined #openstack-horizon | 02:37 | |
*** rebase has quit IRC | 02:41 | |
*** zhurong has joined #openstack-horizon | 02:42 | |
*** hurgleburgler has quit IRC | 02:43 | |
*** wolverineav has quit IRC | 02:45 | |
*** kyleolivo has joined #openstack-horizon | 02:49 | |
*** jwy has quit IRC | 02:51 | |
*** DaveJ__ has quit IRC | 02:55 | |
*** Liuqing has joined #openstack-horizon | 02:59 | |
*** kzaitsev_mb has joined #openstack-horizon | 03:00 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Tutorial for extending a workflow https://review.openstack.org/244407 | 03:02 |
*** kmartin__ has joined #openstack-horizon | 03:03 | |
*** rhagarty__ has joined #openstack-horizon | 03:03 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Support angular workflow extension as a feature plugin https://review.openstack.org/214306 | 03:04 |
*** kzaitsev_mb has quit IRC | 03:06 | |
*** kmartin_ has quit IRC | 03:06 | |
*** rhagarty_ has quit IRC | 03:06 | |
*** doug-fish has joined #openstack-horizon | 03:07 | |
*** tqtran has quit IRC | 03:08 | |
openstackgerrit | Justin Pomeroy proposed openstack/horizon: Support docker image type in ng launch instance wizard https://review.openstack.org/217894 | 03:08 |
*** shu has quit IRC | 03:08 | |
*** memogarcia has quit IRC | 03:09 | |
*** kyleolivo has quit IRC | 03:10 | |
*** memogarcia has joined #openstack-horizon | 03:11 | |
*** doug-fish has quit IRC | 03:11 | |
lhcheng | reedip: pong | 03:17 |
reedip | lhcheng: I answered one of your comments | 03:17 |
reedip | for https://review.openstack.org/#/c/232382/ | 03:17 |
reedip | Seems an issue with pep8 | 03:17 |
*** zhurong_ has joined #openstack-horizon | 03:18 | |
lhcheng | try indenting it this way: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/network.py#L36-L37 | 03:19 |
lhcheng | reedip: yeah, some times pep8 is too picky with indention.. | 03:20 |
reedip | lhcheng: Ok, lemme try | 03:20 |
reedip | Done | 03:21 |
*** zhurong has quit IRC | 03:21 | |
reedip | :), thanks, creating the new patch | 03:21 |
openstackgerrit | Reedip proposed openstack/horizon: Add support for IP Version in Horizon FW-Rule https://review.openstack.org/232382 | 03:22 |
*** memogarcia has quit IRC | 03:23 | |
*** neelashah has joined #openstack-horizon | 03:24 | |
*** memogarcia has joined #openstack-horizon | 03:25 | |
*** raz_ has quit IRC | 03:27 | |
*** raz_ has joined #openstack-horizon | 03:29 | |
*** doug-fish has joined #openstack-horizon | 03:34 | |
*** doug-fish has quit IRC | 03:38 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Remove usage of user project caching https://review.openstack.org/244420 | 03:40 |
*** wolverineav has joined #openstack-horizon | 03:42 | |
openstackgerrit | Lin Hua Cheng proposed openstack/django_openstack_auth: Revert - Cache the User's Project by Token ID https://review.openstack.org/235609 | 03:42 |
*** doug-fish has joined #openstack-horizon | 03:45 | |
*** wolverineav has quit IRC | 03:47 | |
*** doug-fish has quit IRC | 03:49 | |
*** stevemar_ has quit IRC | 03:49 | |
*** stevemar_ has joined #openstack-horizon | 03:50 | |
*** zhurong has joined #openstack-horizon | 03:51 | |
*** itisha has quit IRC | 03:51 | |
*** stevemar_ has quit IRC | 03:53 | |
*** memogarcia has quit IRC | 03:54 | |
*** fedexo has joined #openstack-horizon | 03:54 | |
*** zhurong_ has quit IRC | 03:54 | |
*** memogarcia has joined #openstack-horizon | 03:56 | |
*** flwang1 has quit IRC | 03:57 | |
*** tonyb has joined #openstack-horizon | 03:57 | |
openstackgerrit | Merged openstack/horizon: hz-page-header should allow string interpolations https://review.openstack.org/223793 | 03:57 |
*** kzaitsev_mb has joined #openstack-horizon | 04:02 | |
*** kyleolivo has joined #openstack-horizon | 04:07 | |
*** tqtran has joined #openstack-horizon | 04:07 | |
*** tqtran has quit IRC | 04:08 | |
*** kyleolivo has quit IRC | 04:12 | |
*** lhcheng has quit IRC | 04:13 | |
reedip | lhcheng: ping | 04:14 |
*** btully has quit IRC | 04:15 | |
*** alexvictorchan has quit IRC | 04:21 | |
*** alexvictorchan has joined #openstack-horizon | 04:21 | |
*** hurgleburgler has joined #openstack-horizon | 04:23 | |
*** saksham has joined #openstack-horizon | 04:25 | |
openstackgerrit | Di XiaoLi proposed openstack/horizon: Add handle get_file when launch stack from horizon https://review.openstack.org/241700 | 04:27 |
*** zhurong has quit IRC | 04:28 | |
*** lhcheng has joined #openstack-horizon | 04:28 | |
*** masco__ has joined #openstack-horizon | 04:30 | |
*** Liuqing has quit IRC | 04:31 | |
*** saksham has left #openstack-horizon | 04:31 | |
*** memogarcia has quit IRC | 04:39 | |
*** memogarcia has joined #openstack-horizon | 04:41 | |
*** wolverineav has joined #openstack-horizon | 04:44 | |
*** wolverineav has quit IRC | 04:49 | |
*** lhcheng has quit IRC | 04:49 | |
*** rebase has joined #openstack-horizon | 04:50 | |
*** lhcheng has joined #openstack-horizon | 05:01 | |
openstackgerrit | Reedip proposed openstack/horizon: Adding support for shared option in Network https://review.openstack.org/238778 | 05:05 |
*** Liuqing has joined #openstack-horizon | 05:16 | |
*** btully has joined #openstack-horizon | 05:21 | |
*** btully has quit IRC | 05:25 | |
*** kzaitsev_mb has quit IRC | 05:27 | |
*** reedip has quit IRC | 05:32 | |
*** neelashah1 has joined #openstack-horizon | 05:41 | |
*** neelashah has quit IRC | 05:41 | |
*** fedexo has quit IRC | 05:42 | |
*** mflobo has joined #openstack-horizon | 05:44 | |
*** neelashah has joined #openstack-horizon | 05:44 | |
*** neelashah1 has quit IRC | 05:45 | |
*** neelashah1 has joined #openstack-horizon | 05:47 | |
*** neelashah has quit IRC | 05:48 | |
*** neelashah1 has quit IRC | 05:50 | |
*** Liuqing_ has joined #openstack-horizon | 05:50 | |
*** Liuqing has quit IRC | 05:52 | |
*** btully has joined #openstack-horizon | 05:54 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/horizon: Add Geneve support https://review.openstack.org/233933 | 05:59 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/horizon: Add network types used by midonet https://review.openstack.org/232975 | 05:59 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/horizon: Make neutron provider network configuration more flexible https://review.openstack.org/233932 | 05:59 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/horizon: Sync segmentation ID ranges with Neutron https://review.openstack.org/233934 | 05:59 |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Remove usage of user project caching https://review.openstack.org/244420 | 06:06 |
*** kyleolivo has joined #openstack-horizon | 06:09 | |
*** doug-fish has joined #openstack-horizon | 06:10 | |
*** raz_ has quit IRC | 06:12 | |
*** lhcheng has quit IRC | 06:13 | |
*** jerrygb has quit IRC | 06:14 | |
*** kyleolivo has quit IRC | 06:14 | |
*** doug-fish has quit IRC | 06:15 | |
*** wolverineav has joined #openstack-horizon | 06:32 | |
*** tqtran has joined #openstack-horizon | 06:33 | |
*** tqtran has quit IRC | 06:34 | |
*** jbell8 has joined #openstack-horizon | 06:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/244461 | 06:35 |
*** wolverineav has quit IRC | 06:37 | |
*** errolpais has joined #openstack-horizon | 06:43 | |
*** nlahouti has joined #openstack-horizon | 06:44 | |
*** nlahouti1 has joined #openstack-horizon | 06:46 | |
*** nlahouti has quit IRC | 06:48 | |
*** jhesketh has quit IRC | 06:54 | |
*** Liuqing_ has quit IRC | 06:55 | |
*** zhurong has joined #openstack-horizon | 06:56 | |
*** sayan has joined #openstack-horizon | 06:57 | |
*** jhesketh has joined #openstack-horizon | 06:59 | |
*** alexvictorchan has quit IRC | 07:02 | |
*** alexvictorchan has joined #openstack-horizon | 07:02 | |
*** josecastroleon has joined #openstack-horizon | 07:03 | |
*** mflobo has left #openstack-horizon | 07:10 | |
*** wolverineav has joined #openstack-horizon | 07:14 | |
*** aortega_ has quit IRC | 07:20 | |
*** stevemar_ has joined #openstack-horizon | 07:21 | |
*** Liuqing has joined #openstack-horizon | 07:22 | |
*** yamamoto has quit IRC | 07:22 | |
*** stevemar_ has quit IRC | 07:24 | |
*** Liuqing has quit IRC | 07:26 | |
*** wolverin_ has joined #openstack-horizon | 07:32 | |
*** wolverineav has quit IRC | 07:35 | |
*** rdopiera has joined #openstack-horizon | 07:43 | |
*** Liuqing has joined #openstack-horizon | 07:44 | |
*** wolverin_ has quit IRC | 07:47 | |
*** wolverineav has joined #openstack-horizon | 07:48 | |
*** wolverineav has quit IRC | 07:48 | |
*** aix has joined #openstack-horizon | 07:55 | |
*** errolpais has quit IRC | 07:57 | |
*** josecastroleon has quit IRC | 07:59 | |
*** yamamoto has joined #openstack-horizon | 08:01 | |
*** Liuqing has quit IRC | 08:06 | |
*** josecastroleon has joined #openstack-horizon | 08:08 | |
*** lhcheng has joined #openstack-horizon | 08:09 | |
*** Ala has joined #openstack-horizon | 08:09 | |
*** Ala has quit IRC | 08:10 | |
*** Ala has joined #openstack-horizon | 08:11 | |
*** kyleolivo has joined #openstack-horizon | 08:13 | |
*** kyleolivo has quit IRC | 08:18 | |
*** nlahouti1 has quit IRC | 08:19 | |
*** akanksha_ has joined #openstack-horizon | 08:22 | |
*** rebase has quit IRC | 08:28 | |
*** rebase has joined #openstack-horizon | 08:28 | |
*** rebase has quit IRC | 08:29 | |
*** yamamoto has quit IRC | 08:29 | |
*** btully has quit IRC | 08:36 | |
*** amotoki has quit IRC | 08:40 | |
*** Pablo|off| has joined #openstack-horizon | 08:40 | |
*** aortega has joined #openstack-horizon | 08:42 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Separate agents tests from networks tests file https://review.openstack.org/244159 | 08:47 |
*** yamamoto has joined #openstack-horizon | 08:47 | |
*** saksham has joined #openstack-horizon | 08:48 | |
*** saksham has left #openstack-horizon | 08:48 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Separate subnets tests from networks tests file https://review.openstack.org/244104 | 08:48 |
*** mpavlase has joined #openstack-horizon | 08:48 | |
*** Pablo|off| is now known as pcaruana | 08:48 | |
*** ygbo has joined #openstack-horizon | 08:48 | |
*** romainh has joined #openstack-horizon | 08:49 | |
*** wolverineav has joined #openstack-horizon | 08:49 | |
*** rcernin has joined #openstack-horizon | 08:50 | |
*** lhcheng has quit IRC | 08:53 | |
*** wolverineav has quit IRC | 08:55 | |
*** yamamoto has quit IRC | 08:56 | |
*** jbell8 has quit IRC | 08:56 | |
*** Liuqing has joined #openstack-horizon | 09:03 | |
*** kzaitsev_mb has joined #openstack-horizon | 09:11 | |
*** yamamoto has joined #openstack-horizon | 09:12 | |
*** kyleolivo has joined #openstack-horizon | 09:14 | |
*** yamamoto has quit IRC | 09:16 | |
*** aix has quit IRC | 09:19 | |
*** kyleolivo has quit IRC | 09:19 | |
openstackgerrit | Di XiaoLi proposed openstack/horizon: Add handle get_file when launch stack from horizon https://review.openstack.org/241700 | 09:20 |
*** aix has joined #openstack-horizon | 09:21 | |
*** btully has joined #openstack-horizon | 09:23 | |
*** Liuqing has quit IRC | 09:23 | |
robcresswell | lhcheng_: Good call on the copyright, I've fixed another than I accidentally broke too. | 09:23 |
*** memogarcia has quit IRC | 09:25 | |
*** btully has quit IRC | 09:27 | |
*** memogarcia has joined #openstack-horizon | 09:32 | |
*** JeanBriceCombebi has joined #openstack-horizon | 09:32 | |
*** ygbo has quit IRC | 09:32 | |
*** vgridnev has joined #openstack-horizon | 09:37 | |
*** zhurong has quit IRC | 09:41 | |
*** ygbo has joined #openstack-horizon | 09:45 | |
*** zhurong has joined #openstack-horizon | 09:46 | |
*** openstackgerrit has quit IRC | 09:46 | |
*** openstackgerrit has joined #openstack-horizon | 09:46 | |
*** JeanBriceCombebi has quit IRC | 09:47 | |
*** JeanBriceCombebi has joined #openstack-horizon | 09:53 | |
*** tosky has joined #openstack-horizon | 09:55 | |
*** Drago has quit IRC | 09:56 | |
*** Liuqing has joined #openstack-horizon | 09:57 | |
*** memogarcia has quit IRC | 09:58 | |
*** sayan has quit IRC | 09:58 | |
*** ZZelle has joined #openstack-horizon | 10:02 | |
*** ^Gal^ has quit IRC | 10:04 | |
*** ^Gal^ has joined #openstack-horizon | 10:05 | |
*** ^Gal^ has quit IRC | 10:06 | |
*** memogarcia has joined #openstack-horizon | 10:06 | |
*** ^Gal^ has joined #openstack-horizon | 10:06 | |
*** sayan has joined #openstack-horizon | 10:13 | |
*** openstackgerrit has quit IRC | 10:16 | |
*** openstackgerrit has joined #openstack-horizon | 10:16 | |
*** yamamoto has joined #openstack-horizon | 10:17 | |
*** yamamoto has quit IRC | 10:22 | |
*** kzaitsev_mb has quit IRC | 10:28 | |
*** vgridnev has left #openstack-horizon | 10:29 | |
*** vgridnev has quit IRC | 10:29 | |
*** vgridnev has joined #openstack-horizon | 10:29 | |
*** yamamoto has joined #openstack-horizon | 10:37 | |
*** akanksha_ has quit IRC | 10:38 | |
*** JeanBriceCombebi has quit IRC | 10:40 | |
*** JeanBriceCombebi has joined #openstack-horizon | 10:40 | |
*** memogarcia has quit IRC | 10:41 | |
*** woo has quit IRC | 10:41 | |
*** yamamoto has quit IRC | 10:45 | |
*** vgridnev has quit IRC | 10:45 | |
*** aix_ has joined #openstack-horizon | 10:48 | |
*** mpavlase1 has joined #openstack-horizon | 10:49 | |
*** vgridnev has joined #openstack-horizon | 10:49 | |
*** rcernin has quit IRC | 10:49 | |
*** rcernin has joined #openstack-horizon | 10:50 | |
*** memogarcia has joined #openstack-horizon | 10:51 | |
*** mpavlase has quit IRC | 10:51 | |
*** aix has quit IRC | 10:51 | |
*** aix_ has quit IRC | 10:53 | |
*** memogarcia has quit IRC | 10:55 | |
*** masco__ has quit IRC | 10:56 | |
*** memogarcia has joined #openstack-horizon | 10:57 | |
robcresswell | amotoki, zhenguo: I put up the other patches to split up the Network tests btw. I saw you both reviewed the past ones :) | 11:02 |
*** aix_ has joined #openstack-horizon | 11:05 | |
*** zhenguo has quit IRC | 11:07 | |
*** e0ne has joined #openstack-horizon | 11:09 | |
*** jamielennox is now known as jamielennox|away | 11:12 | |
*** jerrygb has joined #openstack-horizon | 11:15 | |
*** memogarcia has quit IRC | 11:16 | |
*** romainh has left #openstack-horizon | 11:16 | |
*** kyleolivo has joined #openstack-horizon | 11:16 | |
*** jerrygb has quit IRC | 11:19 | |
*** kyleolivo has quit IRC | 11:22 | |
*** memogarcia has joined #openstack-horizon | 11:23 | |
robcresswell | >.< PhantomJS keeps crashing on the npm-run-test gate | 11:26 |
*** josecastroleon has quit IRC | 11:30 | |
*** JeanBriceCombebi has quit IRC | 11:37 | |
*** lnxnut has quit IRC | 11:39 | |
*** memogarcia has quit IRC | 11:41 | |
*** memogarcia has joined #openstack-horizon | 11:42 | |
*** cloudtrainme has joined #openstack-horizon | 11:44 | |
*** yamamoto has joined #openstack-horizon | 11:46 | |
*** yamamoto has quit IRC | 11:51 | |
openstackgerrit | Merged openstack/horizon: New Theme Work Needs Better Documentation https://review.openstack.org/238723 | 11:53 |
*** Liuqing has quit IRC | 12:03 | |
*** zhurong has quit IRC | 12:08 | |
*** romainh has joined #openstack-horizon | 12:10 | |
*** memogarcia has quit IRC | 12:11 | |
*** nitzikow has joined #openstack-horizon | 12:11 | |
robcresswell | r1chardj0n3s: npm-run-test has become my nemesis https://review.openstack.org/#/c/244159/ | 12:13 |
mrunge | just drop it robcresswell | 12:16 |
mrunge | nobody cares about npm apparently | 12:16 |
* mrunge hides | 12:16 | |
*** memogarcia has joined #openstack-horizon | 12:19 | |
*** josecastroleon has joined #openstack-horizon | 12:19 | |
*** yamamoto has joined #openstack-horizon | 12:23 | |
*** wolverineav has joined #openstack-horizon | 12:26 | |
robcresswell | mrunge: :p | 12:27 |
robcresswell | mrunge: It's not even a JS patch and its totally blocked by phantomjs! So annoying :( | 12:28 |
mrunge | robcresswell, interesting question is, how that phantomjs could merge then | 12:29 |
*** wolverineav has quit IRC | 12:30 | |
*** memogarcia has quit IRC | 12:43 | |
*** pauloewerton has joined #openstack-horizon | 12:44 | |
robcresswell | mrunge: Its a very useful tool, but its unusually unstable right now. | 12:45 |
mrunge | I'm not disagreeing here | 12:46 |
*** memogarcia has joined #openstack-horizon | 12:50 | |
*** cloudtrainme has quit IRC | 12:58 | |
*** cloudtrainme has joined #openstack-horizon | 13:00 | |
*** sayan has quit IRC | 13:05 | |
*** ducttape_ has joined #openstack-horizon | 13:08 | |
*** jpomeroy has joined #openstack-horizon | 13:09 | |
*** jerrygb has joined #openstack-horizon | 13:15 | |
*** ducttape_ has quit IRC | 13:17 | |
*** jerrygb_ has joined #openstack-horizon | 13:18 | |
*** zhurong has joined #openstack-horizon | 13:19 | |
*** kyleolivo has joined #openstack-horizon | 13:20 | |
*** jerrygb has quit IRC | 13:22 | |
*** zhurong has quit IRC | 13:24 | |
*** kyleolivo has quit IRC | 13:25 | |
*** doug-fish has joined #openstack-horizon | 13:26 | |
*** nitzikow has quit IRC | 13:27 | |
*** sayan has joined #openstack-horizon | 13:27 | |
*** memogarcia has quit IRC | 13:27 | |
*** memogarcia has joined #openstack-horizon | 13:29 | |
*** nitzikow has joined #openstack-horizon | 13:31 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add dev docs for SCSS/and styling in Horizon https://review.openstack.org/244652 | 13:31 |
*** zhurong has joined #openstack-horizon | 13:31 | |
robcresswell | david-lyle: Dev docs on styling, first draft ^^ | 13:31 |
robcresswell | Damn whitespace. | 13:32 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add dev docs for SCSS/and styling in Horizon https://review.openstack.org/244652 | 13:32 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add dev docs for SCSS/and styling in Horizon https://review.openstack.org/244652 | 13:34 |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects REST API https://review.openstack.org/208581 | 13:34 |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Angular API https://review.openstack.org/209073 | 13:35 |
*** zhurong has quit IRC | 13:36 | |
*** stevemar_ has joined #openstack-horizon | 13:38 | |
*** jerrygb_ has quit IRC | 13:39 | |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects API https://review.openstack.org/208581 | 13:40 |
*** memogarcia has quit IRC | 13:42 | |
*** jprovazn has joined #openstack-horizon | 13:44 | |
*** Piet has quit IRC | 13:45 | |
*** lhcheng has joined #openstack-horizon | 13:45 | |
*** nitzikow has quit IRC | 13:48 | |
*** lhcheng has quit IRC | 13:49 | |
*** nitzikow has joined #openstack-horizon | 13:50 | |
*** e0ne has quit IRC | 13:51 | |
*** memogarcia has joined #openstack-horizon | 13:51 | |
*** e0ne has joined #openstack-horizon | 13:52 | |
*** nitzikow has quit IRC | 13:53 | |
*** nitzikow has joined #openstack-horizon | 13:53 | |
*** oetrog has joined #openstack-horizon | 13:56 | |
*** nitzikow has quit IRC | 13:57 | |
*** _crobertsrh is now known as crobertsrh | 13:58 | |
*** nitzikow has joined #openstack-horizon | 13:59 | |
*** oetrog_ has joined #openstack-horizon | 14:00 | |
*** oetrog has quit IRC | 14:00 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:00 | |
*** julim has joined #openstack-horizon | 14:00 | |
*** nitzikow has quit IRC | 14:02 | |
*** e0ne has quit IRC | 14:04 | |
*** cloudtrainme has quit IRC | 14:04 | |
*** nitzikow_ has joined #openstack-horizon | 14:04 | |
*** oetrog_ has quit IRC | 14:04 | |
*** yamamoto has quit IRC | 14:06 | |
*** lapalm has joined #openstack-horizon | 14:06 | |
*** lhcheng has joined #openstack-horizon | 14:08 | |
*** nitzikow_ has quit IRC | 14:10 | |
*** cloudtrainme has joined #openstack-horizon | 14:12 | |
*** memogarcia has quit IRC | 14:12 | |
openstackgerrit | Ciaran O Tuathail proposed openstack/horizon: Updates how 0 usage is displayed https://review.openstack.org/244676 | 14:13 |
*** lhcheng has quit IRC | 14:13 | |
*** nitzikow has joined #openstack-horizon | 14:13 | |
*** e0ne has joined #openstack-horizon | 14:13 | |
*** wolverineav has joined #openstack-horizon | 14:14 | |
*** ducttape_ has joined #openstack-horizon | 14:15 | |
*** memogarcia has joined #openstack-horizon | 14:17 | |
*** JeanBriceCombebi has quit IRC | 14:17 | |
*** adelia has joined #openstack-horizon | 14:17 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:18 | |
*** wolverineav has quit IRC | 14:19 | |
*** ducttape_ has quit IRC | 14:20 | |
*** nitzikow has quit IRC | 14:21 | |
*** nitzikow_ has joined #openstack-horizon | 14:21 | |
*** jerrygb has joined #openstack-horizon | 14:22 | |
*** nitzikow_ has quit IRC | 14:24 | |
*** lblanchard has joined #openstack-horizon | 14:24 | |
*** memogarcia has quit IRC | 14:26 | |
*** nitzikow has joined #openstack-horizon | 14:27 | |
openstackgerrit | Justin Pomeroy proposed openstack/horizon: Add action for editing instance metadata https://review.openstack.org/243624 | 14:27 |
*** nitzikow has quit IRC | 14:27 | |
*** nitzikow has joined #openstack-horizon | 14:28 | |
*** matt-borland has joined #openstack-horizon | 14:28 | |
*** adelia has quit IRC | 14:30 | |
*** nitzikow has quit IRC | 14:30 | |
*** adelia has joined #openstack-horizon | 14:30 | |
*** adelia has quit IRC | 14:32 | |
*** memogarcia has joined #openstack-horizon | 14:32 | |
*** adelia has joined #openstack-horizon | 14:32 | |
*** petertr7_away is now known as petertr7 | 14:33 | |
*** nitzikow has joined #openstack-horizon | 14:35 | |
*** nitzikow_ has joined #openstack-horizon | 14:36 | |
*** nitzikow has quit IRC | 14:36 | |
*** neelashah has joined #openstack-horizon | 14:38 | |
*** adelia has quit IRC | 14:38 | |
*** adelia has joined #openstack-horizon | 14:39 | |
*** memogarcia has quit IRC | 14:40 | |
*** ^Gal^ has quit IRC | 14:40 | |
*** memogarcia has joined #openstack-horizon | 14:42 | |
*** peristeri has joined #openstack-horizon | 14:43 | |
*** adelia has quit IRC | 14:43 | |
*** raz_ has joined #openstack-horizon | 14:44 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 14:44 |
openstackgerrit | Thomas Bechtold proposed openstack/horizon: Add local_settings.d/ dir for settings snippets https://review.openstack.org/243974 | 14:47 |
*** petertr7 is now known as petertr7_away | 14:47 | |
*** petertr7_away is now known as petertr7 | 14:49 | |
*** memogarcia has quit IRC | 14:56 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Add unit tests for load-edit directive https://review.openstack.org/237788 | 14:56 |
*** ducttape_ has joined #openstack-horizon | 14:57 | |
*** ducttape_ has quit IRC | 14:57 | |
*** ducttape_ has joined #openstack-horizon | 14:58 | |
*** memogarcia has joined #openstack-horizon | 14:59 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Split instance details and source in Launch Instance wizard. https://review.openstack.org/235004 | 15:02 |
*** ducttape_ has quit IRC | 15:03 | |
*** oetrog has joined #openstack-horizon | 15:04 | |
*** oetrog has quit IRC | 15:04 | |
matt-borland | robcresswell, how's it going? It seems things are on a roll! | 15:04 |
*** crobertsrh has left #openstack-horizon | 15:05 | |
*** yamamoto has joined #openstack-horizon | 15:06 | |
*** ducttape_ has joined #openstack-horizon | 15:06 | |
*** crobertsrh has joined #openstack-horizon | 15:07 | |
*** stevemar_ has quit IRC | 15:08 | |
*** adelia has joined #openstack-horizon | 15:08 | |
robcresswell | matt-borland: On a review spree today, moving through priorities. | 15:10 |
robcresswell | matt-borland: Just put up some dev docs for styling, so thats a bit more on our criticals too | 15:11 |
*** yamamoto has quit IRC | 15:11 | |
*** btully has joined #openstack-horizon | 15:12 | |
*** memogarcia has quit IRC | 15:13 | |
*** lnxnut has joined #openstack-horizon | 15:16 | |
*** memogarcia has joined #openstack-horizon | 15:16 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add dev docs for SCSS/and styling in Horizon https://review.openstack.org/244652 | 15:21 |
*** kyleolivo has joined #openstack-horizon | 15:22 | |
*** mpavlase1 has quit IRC | 15:22 | |
*** kyleolivo has quit IRC | 15:26 | |
*** garthb has joined #openstack-horizon | 15:28 | |
*** memogarcia has quit IRC | 15:29 | |
*** stevemar_ has joined #openstack-horizon | 15:29 | |
*** mtanino has joined #openstack-horizon | 15:31 | |
ducttape_ | david-lyle - was there some keystone v3 issues with horizon right now? I'm seeing v3 not working too | 15:31 |
*** vgridnev has quit IRC | 15:32 | |
david-lyle | ducttape_: orly? | 15:33 |
david-lyle | I use v3 by default, albeit with a jokingly small setup | 15:33 |
ducttape_ | yep. I updated the two spots in local_settings. something isn't right. I'm still digging into it, but I know there was recent chatter about this | 15:33 |
david-lyle | the OPENSTACK_API_VERSION bit is the only real requirement | 15:34 |
david-lyle | are you looking for multidomain or single? | 15:34 |
david-lyle | my general usage is multi | 15:34 |
matt-borland | robcresswell, yeah, saw that...awesome | 15:35 |
*** memogarcia has joined #openstack-horizon | 15:35 | |
david-lyle | ducttape_: what is the symptom you are seeing? | 15:37 |
ducttape_ | david-lyle - just trying to login w v3, working on something to support v3 policy file | 15:37 |
ducttape_ | can't login | 15:37 |
david-lyle | the v3 policy file is a train-wreck IMHO | 15:37 |
david-lyle | and will not work without esp's patches | 15:37 |
* ducttape_ pulls out import pdb; pdb.set_trace() | 15:37 | |
ducttape_ | orly? | 15:37 |
david-lyle | and the d-o-a patches | 15:38 |
ducttape_ | fml | 15:38 |
david-lyle | yup | 15:38 |
ducttape_ | holy jebus | 15:38 |
david-lyle | in this case "sample" is latin for "crappy example" | 15:38 |
ducttape_ | so then, it seems like going too far with v3 policy file support, is a bit premature for my fix | 15:38 |
ducttape_ | I speak more french than latin, and my french is very rusty | 15:39 |
david-lyle | yes, v3 policy file will not work without fundamental changes. dead stop. | 15:39 |
*** aortega has quit IRC | 15:39 | |
ducttape_ | you'll have to pardon my french, most of the time | 15:39 |
*** vijendar has joined #openstack-horizon | 15:39 | |
ducttape_ | david-lyle - this is a important change, in regards to | 15:39 |
david-lyle | If you are really gungho on v3 policy file, I'd try the patch chain esp has proposed | 15:40 |
ducttape_ | https://review.openstack.org/#/c/222437/ - it is for the stupid links on the project page, how they log out people | 15:40 |
ducttape_ | or they log out 90% of the users | 15:40 |
david-lyle | ducttape_: yeah I haven't gotten back to fixing that | 15:41 |
david-lyle | :( | 15:41 |
ducttape_ | I did | 15:41 |
ducttape_ | there is a fix for it, works -except for the v3 policy file support | 15:41 |
david-lyle | I'd ignore the v3 policy aspect | 15:42 |
david-lyle | patch looks sane | 15:42 |
ducttape_ | well, tell that to lhcheng then :P | 15:42 |
david-lyle | oh I'll tell him | 15:42 |
*** adelia_ has joined #openstack-horizon | 15:42 | |
david-lyle | passing in the target is not bad form though | 15:42 |
*** lhcheng has joined #openstack-horizon | 15:42 | |
ducttape_ | I was willing to spend time to get v3 policy file supported, but I didn't recall that keystone v3 policy file support was such a sweet hot mess | 15:43 |
david-lyle | ducttape_: SWEET HOT MESS | 15:43 |
ducttape_ | adding in the target is pretty much harmless, fine enough | 15:43 |
david-lyle | more emphasis | 15:43 |
david-lyle | ducttape_: it's more accurate | 15:43 |
ducttape_ | you are lucky I didn't use my french to describe it | 15:43 |
* david-lyle feels lucky | 15:44 | |
ducttape_ | this brings up another issue / rant | 15:44 |
ducttape_ | if you want policy files to be flexible, it seems like you need to constantly make code changes - right? | 15:45 |
*** lhcheng has quit IRC | 15:45 | |
ducttape_ | in order to pass in these extra args ? | 15:45 |
ducttape_ | amirite david-lyle ? | 15:45 |
david-lyle | ducttape_: if you change the rule to require a target, then yes | 15:45 |
*** adelia has quit IRC | 15:46 | |
david-lyle | but if you change the rule to a role, no | 15:46 |
ducttape_ | yeah, thats my point. what if I wanted policy to check region, for example | 15:46 |
*** memogarcia has quit IRC | 15:46 | |
*** ^Gal^ has joined #openstack-horizon | 15:46 | |
*** petertr7 is now known as petertr7_away | 15:46 | |
ducttape_ | it's better than nothing, but it's still not quite all that flexible | 15:46 |
david-lyle | target is a region? | 15:46 |
ducttape_ | sure, why not? | 15:47 |
ducttape_ | or some other piece of information | 15:47 |
ducttape_ | something that is in the current context / thread local scope | 15:47 |
*** lhcheng has joined #openstack-horizon | 15:47 | |
ducttape_ | lhcheng you following us? | 15:47 |
david-lyle | lhcheng: is bouncing in and out | 15:48 |
ducttape_ | at least for v3 support, I'll add the target - but I didn't know / forgot v3 policy file support reqd so many patches | 15:48 |
*** petertr7_away is now known as petertr7 | 15:49 | |
*** JeanBriceCombebi has quit IRC | 15:49 | |
*** tosky has quit IRC | 15:50 | |
david-lyle | I'm not sure a way to support without code changes, suggestions? | 15:51 |
*** memogarcia has joined #openstack-horizon | 15:51 | |
ducttape_ | a way to support more dynamic policy files you mean david-lyle ? | 15:51 |
*** Piet has joined #openstack-horizon | 15:51 | |
Piet | UX Cores - can you review https://invis.io/4U4WTZ426 and approve or not approve? | 15:52 |
david-lyle | more flexible targets | 15:52 |
ducttape_ | right | 15:52 |
ducttape_ | I'm not sure either, and you'd likely have to make code changes in several projects | 15:52 |
*** aix_ has quit IRC | 15:52 | |
ducttape_ | unless you make this some type of remote api (yuck) | 15:52 |
*** JeanBriceCombebi has joined #openstack-horizon | 15:53 | |
david-lyle | the policy scheme is rather limited, but not sure how to improve | 15:53 |
ducttape_ | but even then, it wouldn't really fix this, the more I think about it | 15:53 |
ducttape_ | I have the answer! | 15:53 |
david-lyle | really dynamic policy isn't going to work | 15:53 |
ducttape_ | keystone v4 ! | 15:53 |
* david-lyle runs | 15:53 | |
* ducttape_ clears the room | 15:54 | |
*** lapalm has quit IRC | 15:54 | |
*** jtriley has joined #openstack-horizon | 15:54 | |
*** lapalm has joined #openstack-horizon | 15:54 | |
*** alexvictorchan has quit IRC | 15:56 | |
*** memogarcia has quit IRC | 15:56 | |
*** alexvictorchan has joined #openstack-horizon | 15:56 | |
*** aix has joined #openstack-horizon | 15:56 | |
*** cloudtrainme has quit IRC | 15:56 | |
* robcresswell opens IRC, reads chat, pretends he isn't here | 15:56 | |
sjmc7 | i just got cold shivers. what’s going on? | 15:57 |
*** JeanBriceCombebi has quit IRC | 15:57 | |
ducttape_ | we are going straight to keystone v4 | 15:58 |
ducttape_ | damn the consequences | 15:58 |
*** ^Gal^ has quit IRC | 15:58 | |
*** alexvictorchan has quit IRC | 15:59 | |
*** aorourke-afk is now known as aorourke | 15:59 | |
*** lapalm has quit IRC | 15:59 | |
sjmc7 | i’m going back to bed | 15:59 |
*** ^Gal^ has joined #openstack-horizon | 16:00 | |
*** adelia_ has quit IRC | 16:00 | |
*** adelia has joined #openstack-horizon | 16:01 | |
sjmc7 | oh, the policy files? yes, they are slippery | 16:01 |
*** wolverineav has joined #openstack-horizon | 16:02 | |
*** JeanBriceCombebi has joined #openstack-horizon | 16:02 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add dev docs for SCSS/and styling in Horizon https://review.openstack.org/244652 | 16:02 |
*** memogarcia has joined #openstack-horizon | 16:03 | |
*** crobertsrh has quit IRC | 16:04 | |
*** Ala has quit IRC | 16:05 | |
*** crobertsrh has joined #openstack-horizon | 16:06 | |
*** wolverineav has quit IRC | 16:07 | |
matt-borland | TravT, when you're available, let's confer briefly re: https://review.openstack.org/#/c/236832/ and 'visibility' | 16:07 |
*** jbell8 has joined #openstack-horizon | 16:08 | |
iurygregory | hey people, how can i have access to openstack invision? | 16:09 |
david-lyle | iurygregory: PM me or Piet your email | 16:10 |
*** neelashah1 has joined #openstack-horizon | 16:11 | |
*** neelashah has quit IRC | 16:13 | |
*** Ala has joined #openstack-horizon | 16:13 | |
*** nlahouti has joined #openstack-horizon | 16:16 | |
*** memogarcia has quit IRC | 16:16 | |
*** stevemar_ has quit IRC | 16:17 | |
*** stevemar_ has joined #openstack-horizon | 16:18 | |
*** nlahouti has quit IRC | 16:18 | |
Piet | Do we need to revisit Quick Launch? | 16:20 |
Piet | I feel like there is kind of a battle between shortening workflows for experts and keeping them long for novies | 16:21 |
*** vgridnev has joined #openstack-horizon | 16:21 | |
matt-borland | I would vote against looking at quick launch just now. | 16:22 |
*** nlahouti has joined #openstack-horizon | 16:22 | |
TravT | matt-borland: re vsibility? | 16:23 |
matt-borland | ah, yeah! | 16:23 |
matt-borland | TravT, just wondering, did you want the the change to only affect > Glance v1 | 16:23 |
*** memogarcia has joined #openstack-horizon | 16:23 | |
matt-borland | that is, glance v1 -> is_public and > v1 -> visibility? | 16:24 |
TravT | i think the horizion rest api should just be visbility | 16:24 |
TravT | and on horizon server side do the mapping | 16:24 |
matt-borland | gotcha, that makes sense | 16:24 |
TravT | to is_public if needed for glance v1 | 16:24 |
matt-borland | yep, cool | 16:24 |
matt-borland | thanks | 16:25 |
TravT | np | 16:25 |
*** crobertsrh has left #openstack-horizon | 16:25 | |
*** Ala has quit IRC | 16:25 | |
*** memogarcia has quit IRC | 16:26 | |
*** kyleolivo has joined #openstack-horizon | 16:29 | |
*** memogarcia has joined #openstack-horizon | 16:30 | |
robcresswell | Piet: Quick launch? | 16:31 |
Piet | Yeah...accommodates both Adv and Novice users in the workflows | 16:32 |
*** aortega has joined #openstack-horizon | 16:32 | |
*** Drago has joined #openstack-horizon | 16:33 | |
*** Drago has quit IRC | 16:33 | |
*** neelashah has joined #openstack-horizon | 16:33 | |
*** Drago has joined #openstack-horizon | 16:33 | |
*** kyleolivo has quit IRC | 16:34 | |
*** neelashah1 has quit IRC | 16:34 | |
*** Drago1 has joined #openstack-horizon | 16:34 | |
*** Drago1 has quit IRC | 16:35 | |
*** Drago1 has joined #openstack-horizon | 16:35 | |
*** nlahouti has quit IRC | 16:35 | |
*** Drago has quit IRC | 16:36 | |
*** kmartin__ has quit IRC | 16:36 | |
*** nlahouti has joined #openstack-horizon | 16:37 | |
*** neelashah1 has joined #openstack-horizon | 16:37 | |
*** neelashah has quit IRC | 16:38 | |
hurgleburgler | It'd be nice if the wizards had a short circuit option | 16:39 |
hurgleburgler | and an Advanced View | 16:39 |
hurgleburgler | probably something that we can store as a user preference also | 16:39 |
robcresswell | Wait I'm unsure what we're referring to by quick launch | 16:39 |
*** rdopiera has quit IRC | 16:39 | |
*** neelashah has joined #openstack-horizon | 16:40 | |
*** memogarcia has quit IRC | 16:41 | |
*** neelashah1 has quit IRC | 16:41 | |
*** romainh has left #openstack-horizon | 16:42 | |
*** kmartin has joined #openstack-horizon | 16:42 | |
ducttape_ | Piet - our issue w new launch instance is that it is too noisy / too busy. that is the feedback our support team provides me. so then I wouldn't move it to prod | 16:44 |
ducttape_ | fwiw | 16:44 |
*** wolverineav has joined #openstack-horizon | 16:44 | |
*** bpokorny has joined #openstack-horizon | 16:46 | |
*** mpavlase has joined #openstack-horizon | 16:47 | |
*** aix has quit IRC | 16:49 | |
*** memogarcia has joined #openstack-horizon | 16:49 | |
*** kzaitsev_mb has joined #openstack-horizon | 16:49 | |
*** rcernin has quit IRC | 16:50 | |
*** lapalm has joined #openstack-horizon | 16:50 | |
*** petertr7 is now known as petertr7_away | 16:52 | |
*** memogarcia has quit IRC | 16:54 | |
robcresswell | ducttape_: That primarily the transfer tables? I think they are very info-dense for a simple selection. | 16:55 |
*** kyleolivo has joined #openstack-horizon | 16:55 | |
openstackgerrit | Justin Pomeroy proposed openstack/horizon: Support angular workflow extension as a feature plugin https://review.openstack.org/214306 | 16:56 |
*** gyee has joined #openstack-horizon | 16:56 | |
*** saksham has joined #openstack-horizon | 16:57 | |
ducttape_ | robcresswell - I'm not sure there is any one thing. It's more of all the screens you start out with, the warning icons right off the bat. It's just more to deal with (vs the old one) | 16:57 |
ducttape_ | It's probably a bunch of aspects together, that causes the concern | 16:58 |
*** memogarcia has joined #openstack-horizon | 16:58 | |
ducttape_ | Right now it seems like we are trying to expose all the things to users. I'm not sure that helps, UX wise | 16:58 |
*** petertr7_away is now known as petertr7 | 16:59 | |
ducttape_ | but no easy / clear answer | 16:59 |
*** mohankumar has joined #openstack-horizon | 16:59 | |
*** josecastroleon has quit IRC | 16:59 | |
*** kyleolivo has quit IRC | 17:00 | |
robcresswell | ducttape_: True. There may be better ways to give feedback than what appears to be a danger sign. | 17:00 |
*** crobertsrh has joined #openstack-horizon | 17:02 | |
sjmc7 | i think we enabled the new one so we should start getting feedback soon | 17:02 |
*** e0ne has quit IRC | 17:02 | |
robcresswell | It still really needs to disable the Launch button after one click | 17:03 |
robcresswell | You can still spam it to do multiple | 17:04 |
sjmc7 | users all behave exactly as we expect them to. | 17:04 |
robcresswell | lol | 17:04 |
*** garthb has quit IRC | 17:05 | |
sjmc7 | i do agree the warning signs right off the bat are a bit intimidating | 17:05 |
robcresswell | The big one though is that people will definitely double click it, whether by accident, or because it doesnt respond in 200ms | 17:05 |
*** pcaruana has quit IRC | 17:06 | |
ducttape_ | make it so it has a 5 click minimum, that should help | 17:06 |
robcresswell | With a pop up modal that says how many more times you must click | 17:06 |
ducttape_ | maybe something like up up down down, left right left right..... etc. like a nintendo cheat code | 17:07 |
robcresswell | haha | 17:07 |
sjmc7 | FINISH HIM! | 17:07 |
*** kyleolivo has joined #openstack-horizon | 17:07 | |
*** kyleolivo has quit IRC | 17:07 | |
*** JeanBriceCombebi has quit IRC | 17:07 | |
hurgleburgler | ducttape_ +1 | 17:07 |
*** kyleolivo has joined #openstack-horizon | 17:07 | |
*** kyleolivo has quit IRC | 17:08 | |
Piet | It interesting because I spoke with someone that moves between the workflows based on the use case. In one case, the work was repetitive and new what choices he was making. In another case, he wasn't quite sure what he needed and used the longer workflow. | 17:09 |
*** mpavlase has quit IRC | 17:10 | |
Piet | "knew" what choices he was making | 17:10 |
*** memogarcia has quit IRC | 17:10 | |
ducttape_ | I could see that, each one is a bit clearer for certain choices vs others | 17:10 |
hurgleburgler | That's why it would be nice to store the short circuit or preference per use | 17:10 |
hurgleburgler | local storage or something… | 17:10 |
hurgleburgler | per workflow* | 17:11 |
Piet | The problem is that we're trying to consolidate two use cases. | 17:11 |
Piet | Which hurts everyone | 17:11 |
hurgleburgler | 'the last time, for this wizard, the user selected the condensed workflow … show him that one this time too' | 17:11 |
hurgleburgler | or her :-D | 17:11 |
Piet | Travis was suggesting that we revisit Quick Launch or possibly giving a choice between a wizard and long form | 17:12 |
robcresswell | There's a lot of things we could do if Horizon had some db storage behind it. Like designing a networking topology by dragging and dropping and storing it, that would be kinda nice. | 17:12 |
*** memogarcia has joined #openstack-horizon | 17:13 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 17:13 |
Piet | We could also have your previous choices preselected in the workflow | 17:13 |
*** lhcheng has quit IRC | 17:13 | |
hurgleburgler | TravT also wanted to allow table column configuration per user | 17:13 |
*** exploreshaifali has joined #openstack-horizon | 17:13 | |
* TravT huh, what? | 17:14 | |
hurgleburgler | we can store all of that in local storage | 17:14 |
TravT | Yeah, we can start with local storage for user prefs | 17:14 |
robcresswell | Oh great, this guy | 17:14 |
TravT | which would surely lead to bug reports of "my prefs don't save!" | 17:14 |
robcresswell | :) | 17:14 |
TravT | when they switch computer machines. | 17:15 |
hurgleburgler | so we'd need export/import user preferences functionality | 17:15 |
hurgleburgler | export it to a json file or something | 17:15 |
Piet | Also, one word of warning...most people in this room are advanced users. Newbies are generally not represented | 17:15 |
hurgleburgler | it'd be nice to configure that offline in a json file too | 17:15 |
*** lhcheng has joined #openstack-horizon | 17:15 | |
*** alexvictorchan has joined #openstack-horizon | 17:15 | |
TravT | yeah, i was just telling Piet how when I created the searchlight demo I was creating a bunch of images, bunch of instances, etc. | 17:16 |
TravT | at first i used new launch instance | 17:16 |
TravT | then since i was doing the same thing, i switched to old launch instance | 17:16 |
TravT | then i added a ton of images and some other stuff | 17:16 |
TravT | and i found the drop downs hard to find my stuff in | 17:17 |
TravT | so went back to new launch instance | 17:17 |
*** jtriley has quit IRC | 17:17 | |
TravT | and then when i built a new devstack, said, screw this, and just scripted it | 17:17 |
david-lyle | another horizon success story :-D | 17:18 |
*** SimonChung has joined #openstack-horizon | 17:18 | |
TravT | hehe | 17:18 |
Piet | It kind of makes sense though, different UIs for different needs | 17:19 |
TravT | well, for me the moral was that when i know exactly what i'm going to pick and there aren't a lot of choices to pick from, the simplicity of old launch instance worked. | 17:19 |
*** Drago1 has quit IRC | 17:19 | |
david-lyle | "horizon, so the CLIs don't seem so bad" ™ | 17:19 |
TravT | once there were a lot of choices, i found the searching and more info on new launch instance to be handy | 17:20 |
Piet | david-lyle LMAO | 17:20 |
lhcheng | ducttape_: sorry, was on a call awhile ago. | 17:20 |
TravT | but then at some point when you are doing the same thing over and over, scripting works... which is what we already know. | 17:20 |
* lhcheng reads logs | 17:20 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 17:20 |
ducttape_ | lhcheng - let me save you the time. | 17:21 |
Piet | Ohhhhh oh | 17:21 |
ducttape_ | I'll get the target in that patch, but keystone v3 policy support, it's not a huge blocker right now. not really worth -1 | 17:21 |
ducttape_ | since keystone v3 and policy support is not really there yet | 17:22 |
ducttape_ | make sense ? | 17:22 |
ducttape_ | seem ok? | 17:22 |
david-lyle | well keystone v3 and the v3SAMPLE policy file support is not there | 17:22 |
ducttape_ | right, kv3 kinda works | 17:22 |
ducttape_ | as long as you treat it like v2 policy files | 17:23 |
ducttape_ | which is like keystone v2.653465 | 17:23 |
lhcheng | ducttape_: yup, the -1 was for the wrong commit msg | 17:23 |
*** flwang1 has joined #openstack-horizon | 17:23 | |
lhcheng | makes sense to me | 17:23 |
ducttape_ | ok. Ill add target too, just need 20 minutes of not being interrupted by fire drills | 17:24 |
lhcheng | esp_ will take care of fixing that for v3 policy file anyway ;) | 17:24 |
* ducttape_ spits out his cereal, makes a mess of his monitor | 17:24 | |
*** rcernin has joined #openstack-horizon | 17:24 | |
*** kyleolivo has joined #openstack-horizon | 17:25 | |
lhcheng | they have a big patch for making horizon work with v3 policy file | 17:25 |
robcresswell | Hey awesome my patch got past npm-run-test gate | 17:25 |
robcresswell | Only took 5 rechecks | 17:25 |
lhcheng | robcresswell: how many rechecks did you have to run? :P | 17:25 |
lhcheng | lol | 17:25 |
robcresswell | I gave up and lapalm took over | 17:25 |
robcresswell | lhcheng: https://review.openstack.org/#/c/244159/ | 17:26 |
lhcheng | robcresswell: why did you gave up on my patch? | 17:26 |
lapalm | robcresswell: o hey it worked.... | 17:26 |
ducttape_ | recheck as a service - big tent this | 17:26 |
lhcheng | robcresswell: https://review.openstack.org/#/c/243897/ | 17:26 |
lapalm | robcresswell: Looks like I have the magic touch ;) | 17:27 |
lhcheng | robcresswell: npm passed at one run, but then grenda failed | 17:27 |
lhcheng | (facepalm) | 17:27 |
david-lyle | is anyone looking at the npm job? | 17:27 |
robcresswell | lhcheng: hahaha, I was just commenting that I thought we were doomed | 17:27 |
lapalm | ducttape_: RaaS, I like it | 17:27 |
Piet | ducttape_ I'll buy you a growler of beer if you approve the LBaaS | 17:27 |
robcresswell | david-lyle: There's a bug out, but I dont think so. It's an intermitted PhantomJS crash | 17:27 |
robcresswell | intermittent* | 17:27 |
lhcheng | lapalm: does your service offer have free trial period? | 17:27 |
david-lyle | robcresswell: still likely something we can do to address it | 17:28 |
ducttape_ | Piet - lbaas being a trainwreck, is not worth bribery. it is a mess today, and the review makes it worse | 17:28 |
david-lyle | the version of phantomjs hasn't changed | 17:28 |
robcresswell | david-lyle: I wasn't disagreeing, just updating you. Bug is here: https://bugs.launchpad.net/horizon/+bug/1514734 | 17:28 |
openstack | Launchpad bug 1514734 in OpenStack Dashboard (Horizon) "gate-horizon-npm-run-lint times out" [Critical,New] | 17:28 |
ducttape_ | the stuff already in the new repo, is in the right direction, for lbaas | 17:28 |
robcresswell | Oh no wait, I think thats separate | 17:28 |
lapalm | lhcheng: 1st one is free, no guarantees, 100% no money back | 17:29 |
lhcheng | lapalm: hah | 17:29 |
*** ygbo has quit IRC | 17:29 | |
robcresswell | Sometimes I think we should just replace zuul with a coin flip, same success rate | 17:29 |
lhcheng | lapalm: if you have the magic touch, I only need the first recheck. | 17:29 |
Piet | ducttape_ You circumvented to proposed design? | 17:29 |
ducttape_ | horizon and UX are two different things. lbaas already had changes underway | 17:30 |
lapalm | lhcheng: I like to have it almost work on the first try to get my customers hooked | 17:30 |
*** Drago has joined #openstack-horizon | 17:30 | |
ducttape_ | and what they have right now, is in a better direction | 17:30 |
*** Drago has quit IRC | 17:31 | |
*** Drago has joined #openstack-horizon | 17:31 | |
Piet | ducttape_ based on your opinion n=1 | 17:31 |
ducttape_ | Piet - if you want to go ahead and merge UX stuff, you can always proceed (even with me objecting) | 17:31 |
Piet | ducttape_ We will | 17:32 |
*** josecastroleon has joined #openstack-horizon | 17:32 | |
matt-borland | TravT, you probably noticed, kyleolivo may have fixed the problem you were encountering with the Launch Instance source split. | 17:34 |
TravT | matt-borland: oh, ok | 17:35 |
TravT | i'll take a look | 17:35 |
matt-borland | thanks! | 17:35 |
Piet | ducttape_ BTW - I did take the time to review with another operator who completely disagrees with you. Again, n=1 but it is another data point | 17:36 |
ducttape_ | thats fine. there are 4 of us already working on the new stuff, contributing code | 17:36 |
*** kyleolivo has quit IRC | 17:36 | |
*** wolverineav has quit IRC | 17:37 | |
ducttape_ | there was an ebay session at the summit, I think what they have is where we would like to go. but I get it.... lots of different actors | 17:37 |
TravT | so, i don't have a rat in the race, but it does seem that if there are alternate designs they should be shared in mocks if available. | 17:39 |
*** mohankumar has quit IRC | 17:40 | |
*** petertr7 is now known as petertr7_away | 17:40 | |
*** memogarcia has quit IRC | 17:41 | |
*** ccesario has quit IRC | 17:42 | |
ducttape_ | https://github.com/openstack/neutron-lbaas-dashboard - TravT | 17:43 |
*** aix has joined #openstack-horizon | 17:43 | |
*** memogarcia has joined #openstack-horizon | 17:43 | |
ducttape_ | thats the first work to support lbaas v2 | 17:43 |
ducttape_ | it was reviewed in earlier revisions | 17:43 |
*** mohankumar has joined #openstack-horizon | 17:44 | |
*** jtriley has joined #openstack-horizon | 17:44 | |
ducttape_ | the problem with lbaas (in its current form and what is under review), is that users need to setup tons of discrete little items. the pool, the vip, the members, the health checks.... these are all separate steps | 17:44 |
ducttape_ | and if a users just wants an http/https load balancer, its a mess of steps with little insight to where you are in the process | 17:45 |
sjmc7 | i find neutron to be much the same in general | 17:45 |
ducttape_ | the new code tries to combine a lot of that into a single (give me a lb) screen / workflow | 17:45 |
ducttape_ | sjmc7 - yep, it is | 17:46 |
openstackgerrit | Shu Shen proposed openstack/horizon: Use a new token for heat client https://review.openstack.org/244788 | 17:46 |
*** david-lyle has quit IRC | 17:46 | |
sjmc7 | there’s definitely a case for networkign for simplifying but with an ‘advanced’ view | 17:47 |
*** ccesario has joined #openstack-horizon | 17:48 | |
sjmc7 | i should take a look at the lbaas stuff | 17:48 |
ducttape_ | yep sjmc7. I think this is a big part of the new launch instance stuff. I think there was a misunderstanding - when people complained it is hard to launch an instance, really this was b/c neutron required 20 steps before you could launch an instance | 17:49 |
ducttape_ | instead of fixing the network setup, we worked on something else | 17:49 |
sjmc7 | :) | 17:49 |
sjmc7 | this is why i wanted a ‘give me a floating ip’ checkbox | 17:49 |
*** e0ne has joined #openstack-horizon | 17:50 | |
sjmc7 | too many things to remember to do first | 17:50 |
ducttape_ | oh, you need to make 20 neutron and nova api calls for that, 6 screen minimum | 17:50 |
*** jtriley has quit IRC | 17:50 | |
ducttape_ | ;) | 17:50 |
hurgleburgler | lol | 17:50 |
sjmc7 | you’re only barely exaggerating | 17:50 |
ducttape_ | I KNOW! | 17:50 |
sjmc7 | actually, that’s one area where horizon can be much more convenient than the CLIs | 17:51 |
ducttape_ | It's funny b/c it's true | 17:51 |
ducttape_ | also, It's sad b/c it's true | 17:51 |
*** tqtran has joined #openstack-horizon | 17:51 | |
sjmc7 | are all the new neutron sub-services going to have their own repos? | 17:51 |
sjmc7 | for dashboard components? | 17:51 |
*** saksham has quit IRC | 17:51 | |
sjmc7 | i haven’t paid enough attention, someone’s going to ask me to pull them into our deployments soon | 17:52 |
ducttape_ | sjmc7 - yes, the move is for horizon plugins, and many of them will be in different repos | 17:52 |
ducttape_ | though core stuff like nova / neutron / swift will likely remain in the horizon repo | 17:53 |
sjmc7 | yeah, i remember those conversations | 17:53 |
*** memogarcia has quit IRC | 17:53 | |
*** kyleolivo has joined #openstack-horizon | 17:55 | |
*** tosky has joined #openstack-horizon | 17:56 | |
*** memogarcia has joined #openstack-horizon | 18:00 | |
*** lapalm has quit IRC | 18:01 | |
*** errolpais has joined #openstack-horizon | 18:01 | |
*** kzaitsev_mb has quit IRC | 18:04 | |
*** wolverineav has joined #openstack-horizon | 18:06 | |
*** garthb has joined #openstack-horizon | 18:06 | |
*** memogarcia has quit IRC | 18:11 | |
*** memogarcia has joined #openstack-horizon | 18:13 | |
*** TravT has quit IRC | 18:14 | |
*** memogarcia has quit IRC | 18:16 | |
*** josecastroleon has quit IRC | 18:16 | |
*** memogarcia has joined #openstack-horizon | 18:23 | |
*** memogarcia has quit IRC | 18:26 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 18:27 |
*** mohankumar has quit IRC | 18:27 | |
*** flwang1 has quit IRC | 18:28 | |
*** memogarcia has joined #openstack-horizon | 18:29 | |
*** petertr7_away is now known as petertr7 | 18:32 | |
*** raz_ has quit IRC | 18:33 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Plugin Docs https://review.openstack.org/233709 | 18:37 |
*** zul has quit IRC | 18:41 | |
*** jbell8 has quit IRC | 18:42 | |
*** zul has joined #openstack-horizon | 18:42 | |
*** EmilienM has quit IRC | 18:42 | |
*** EmilienM has joined #openstack-horizon | 18:45 | |
*** e0ne has quit IRC | 18:47 | |
*** saksham has joined #openstack-horizon | 18:47 | |
*** wolverineav has quit IRC | 18:47 | |
*** petertr7 is now known as petertr7_away | 18:47 | |
*** wolverineav has joined #openstack-horizon | 18:47 | |
*** saksham has left #openstack-horizon | 18:50 | |
*** tosky has quit IRC | 18:53 | |
*** petertr7_away is now known as petertr7 | 18:56 | |
*** gyee has quit IRC | 18:56 | |
*** Piet has quit IRC | 18:57 | |
*** memogarcia has quit IRC | 18:58 | |
*** memogarcia has joined #openstack-horizon | 19:01 | |
*** lapalm has joined #openstack-horizon | 19:02 | |
*** Piet has joined #openstack-horizon | 19:04 | |
*** kmartin has quit IRC | 19:05 | |
*** kmartin has joined #openstack-horizon | 19:06 | |
*** Piet has quit IRC | 19:09 | |
*** neelashah has quit IRC | 19:11 | |
*** neelashah1 has joined #openstack-horizon | 19:11 | |
*** lapalm has quit IRC | 19:11 | |
*** lapalm has joined #openstack-horizon | 19:12 | |
*** aix has quit IRC | 19:15 | |
*** sweetJeebus has joined #openstack-horizon | 19:15 | |
*** bpokorny_ has joined #openstack-horizon | 19:15 | |
sweetJeebus | good day everyone. | 19:17 |
*** bpokorny has quit IRC | 19:19 | |
*** nlahouti has quit IRC | 19:24 | |
*** nlahouti has joined #openstack-horizon | 19:24 | |
*** memogarcia has quit IRC | 19:27 | |
*** bpokorny_ has quit IRC | 19:29 | |
*** bpokorny has joined #openstack-horizon | 19:29 | |
sweetJeebus | I'm working on an interesting configuration for horizon. We have kilo-keystone, liberty-horizon, and icehouse everything else. I'm moving to the v3 api, which is giving me mixed results. I've actually had a fair amount of success, but it hasn't been complete. | 19:30 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add breadcrumbs to final details pages https://review.openstack.org/243566 | 19:31 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Separate subnets tests from networks tests file https://review.openstack.org/244104 | 19:31 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Separate agents tests from networks tests file https://review.openstack.org/244159 | 19:31 |
sweetJeebus | I thought I'd ask y'all for some advice while I put together a test matrix for further investigation. Of particular interest to me is the policy files. I've come under the impression that the various horizon policy files need to mirror the various controller policy files (like a nova.policy and neutron.policy) | 19:32 |
sweetJeebus | is that true? | 19:33 |
sjmc7 | david-lyle’s the best person to ask, although ducttape_ was discussing this earlier | 19:35 |
sjmc7 | but yes, that is the case | 19:35 |
ducttape_ | sweetJeebus - awesome nic | 19:35 |
ducttape_ | I use your name quite frequently, truth be told | 19:35 |
sweetJeebus | nice | 19:36 |
ducttape_ | the policy files for keystone v3 are a bit of a mess, in my experience | 19:37 |
ducttape_ | and require some extra patches in various spots | 19:37 |
mfisch | even Jeebus can't figure out KeystoneV3 | 19:37 |
ducttape_ | but if you want to use keystone v3 endpoint with v2 policy, that works ok | 19:37 |
sweetJeebus | okay, so I'm going to compare the horizon policy files vs the various services and make sure they're the same (ish) | 19:37 |
sweetJeebus | okay | 19:37 |
*** flwang1 has joined #openstack-horizon | 19:37 | |
ducttape_ | rofl mfisch +1000 | 19:37 |
ducttape_ | stevemar_ can you see above? | 19:38 |
ducttape_ | even Jebus can't use keystone v3 ;) | 19:38 |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Fix config ordering for identity plugin file https://review.openstack.org/244839 | 19:38 |
*** med_ is now known as openstackgerrit_ | 19:39 | |
openstackgerrit_ | David Lyle proposed oepnstack/horizon: Roll keystone back to v2 forever. | 19:40 |
*** openstackgerrit_ is now known as med_ | 19:40 | |
stevemar_ | ducttape_: let me get y'all my small violin | 19:40 |
sweetJeebus | so I take the v2 policies defined in the other services and make sure to have the same policies in my horizon-liberty install. Is there anything else I should be aware of? | 19:40 |
ducttape_ | hah | 19:40 |
sweetJeebus | Again, I'll figure everything out, but maybe I can save some time by consulting the oracles ;) | 19:41 |
ducttape_ | sweetJeebus - I would say you should be able to make the 2 changes in local_settings.py to switch over to v3. keep all the policy files as is | 19:41 |
ducttape_ | that *should* work fine | 19:41 |
ducttape_ | but if you want keystone v3 policy type stuff, you are in for some more serious "opportunities" | 19:42 |
sweetJeebus | hrm... sorry ducttape_... I don't think the 2 changes thing worked for me. Which 2 did you have in mind? | 19:42 |
sweetJeebus | I'll also happily give you a report of what I had to do to make this work | 19:42 |
ducttape_ | https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L51 is one | 19:43 |
ducttape_ | https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L143 is the other | 19:43 |
*** errolpais has quit IRC | 19:43 | |
sweetJeebus | right now, our controllers run nova-scheduler, neutron, glance, and horizon. I just recently untangled keystone from it ('tangled' meaning 'chef cookbooks') | 19:43 |
sweetJeebus | thanks ducttape_ | 19:44 |
sweetJeebus | I'll let you know what happens with those | 19:44 |
ducttape_ | sweetJeebus - if you get keystone v3 working with policy files, then please let us know. "sweetJeebus! u can get keystone v3 working!" I can see the marketing memos now | 19:44 |
sweetJeebus | awesome | 19:45 |
sweetJeebus | s/if/when/, bro ;) | 19:45 |
ducttape_ | no doubt | 19:45 |
*** sayan has quit IRC | 19:46 | |
*** sayan has joined #openstack-horizon | 19:47 | |
ducttape_ | I wonder if sweetJeebus has any kids..... maybe sweetBabyJeebus ??? | 19:49 |
*** kyleolivo has quit IRC | 19:49 | |
mfisch | someone is making eric's day | 19:50 |
ducttape_ | * 100 | 19:50 |
med_ | <snort> | 19:50 |
* med_ hears the LOL on both sides of the room | 19:50 | |
med_ | he calls his kid Junior (but birth cert says sweetBabyJeebus) | 19:51 |
sweetJeebus | 3 sweetBabyJeebuses | 19:52 |
*** sweetJeebus_ has joined #openstack-horizon | 19:55 | |
sweetJeebus_ | Back | 19:56 |
*** sweetJeebus has quit IRC | 19:57 | |
sweetJeebus_ | so I did make both of those changes, ducttape_ | 19:57 |
sweetJeebus_ | and found I could log in after altering the endpoints in the keystone db (they had to roll to v3) | 19:57 |
sweetJeebus_ | but I'm running into problems with volumes and networks as I try to navigate through | 19:58 |
ducttape_ | hmm, ok. any more detail on that? | 19:58 |
ducttape_ | I wonder if you have a v3 token or something, and those services don't like that? | 19:59 |
ducttape_ | didn't you have something like icehouse for those services? | 19:59 |
sweetJeebus_ | yeah, its all icehouse | 20:00 |
sweetJeebus_ | except keystone and horizon | 20:00 |
sweetJeebus_ | as for details... here's my plan | 20:00 |
*** doug-fish has quit IRC | 20:01 | |
sweetJeebus_ | I'm going to go ahead and execute a test matrix and then fill y'all in on the results. That way we can have something documented to work on | 20:02 |
sweetJeebus_ | it seems like my biggest problems, however, are cinder and neutron.. though it may be a nova scheduling thing. I'm not sure | 20:03 |
*** jbell8 has joined #openstack-horizon | 20:03 | |
sweetJeebus_ | I have a whole dashboard to test, and the problems desperately need me to organize them before I address them | 20:03 |
*** pauloewerton has quit IRC | 20:04 | |
*** iurygregory has quit IRC | 20:04 | |
*** kyleolivo has joined #openstack-horizon | 20:05 | |
*** ericksonsantos has quit IRC | 20:05 | |
*** doug-fish has joined #openstack-horizon | 20:05 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Tutorial for extending a workflow https://review.openstack.org/244407 | 20:08 |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding CREATE action to identity users panel https://review.openstack.org/222297 | 20:11 |
openstackgerrit | Eric Peterson proposed openstack/horizon: Prevent project detail link result in user log out https://review.openstack.org/222437 | 20:15 |
*** jtriley has joined #openstack-horizon | 20:17 | |
*** ongk has joined #openstack-horizon | 20:19 | |
ducttape_ | lhcheng - online? | 20:20 |
*** nitzikow_ has quit IRC | 20:28 | |
*** ducttape_ has quit IRC | 20:31 | |
*** nitzikow has joined #openstack-horizon | 20:31 | |
*** kmartin has quit IRC | 20:35 | |
*** memogarcia has joined #openstack-horizon | 20:40 | |
*** neelashah has joined #openstack-horizon | 20:40 | |
*** neelashah1 has quit IRC | 20:43 | |
*** neelashah1 has joined #openstack-horizon | 20:44 | |
*** neelashah has quit IRC | 20:45 | |
*** memogarcia has quit IRC | 20:46 | |
*** neelashah has joined #openstack-horizon | 20:47 | |
*** neelashah1 has quit IRC | 20:48 | |
*** errolpais has joined #openstack-horizon | 20:49 | |
*** nlahouti has quit IRC | 20:50 | |
*** davidmichaelkarr has quit IRC | 20:50 | |
*** neelashah has quit IRC | 20:51 | |
*** neelashah has joined #openstack-horizon | 20:52 | |
*** neelashah has quit IRC | 20:54 | |
*** memogarcia has joined #openstack-horizon | 20:55 | |
*** cloudtrainme has joined #openstack-horizon | 20:55 | |
*** matt-borland has quit IRC | 20:57 | |
*** memogarcia has quit IRC | 20:57 | |
r1chardj0n3s | morning | 20:57 |
*** gyee has joined #openstack-horizon | 20:58 | |
*** dsneddon is now known as dsneddon_lunch | 20:58 | |
*** crobertsrh has quit IRC | 21:01 | |
*** ducttape_ has joined #openstack-horizon | 21:01 | |
*** clu_ has joined #openstack-horizon | 21:04 | |
*** kmartin has joined #openstack-horizon | 21:07 | |
*** jprovazn has quit IRC | 21:08 | |
*** kmartin has quit IRC | 21:08 | |
*** kmartin has joined #openstack-horizon | 21:08 | |
*** davidmichaelkarr has joined #openstack-horizon | 21:11 | |
*** nitzikow has quit IRC | 21:13 | |
*** aortega_ has joined #openstack-horizon | 21:15 | |
*** aortega has quit IRC | 21:16 | |
*** yamamoto has joined #openstack-horizon | 21:16 | |
*** aortega has joined #openstack-horizon | 21:18 | |
*** TravT has joined #openstack-horizon | 21:18 | |
*** sweetJeebus_ has quit IRC | 21:18 | |
*** aortega_ has quit IRC | 21:19 | |
*** aortega has quit IRC | 21:19 | |
*** aortega has joined #openstack-horizon | 21:19 | |
*** aortega has quit IRC | 21:21 | |
*** aortega has joined #openstack-horizon | 21:21 | |
*** Piet has joined #openstack-horizon | 21:22 | |
*** wolverin_ has joined #openstack-horizon | 21:23 | |
*** aortega has quit IRC | 21:24 | |
*** jbell8 has quit IRC | 21:24 | |
*** aortega has joined #openstack-horizon | 21:24 | |
*** yamamoto has quit IRC | 21:24 | |
*** stevemar_ has quit IRC | 21:25 | |
*** wolverineav has quit IRC | 21:27 | |
*** petertr7 is now known as petertr7_away | 21:28 | |
*** mpavlase has joined #openstack-horizon | 21:29 | |
*** petertr7_away is now known as petertr7 | 21:32 | |
*** memogarcia has joined #openstack-horizon | 21:35 | |
*** crobertsrh has joined #openstack-horizon | 21:35 | |
*** adelia_ has joined #openstack-horizon | 21:36 | |
*** wolverin_ has quit IRC | 21:36 | |
*** wolverineav has joined #openstack-horizon | 21:37 | |
*** adelia has quit IRC | 21:39 | |
*** adelia_ has quit IRC | 21:45 | |
*** adelia has joined #openstack-horizon | 21:46 | |
*** matt-borland has joined #openstack-horizon | 21:47 | |
*** memogarcia has quit IRC | 21:48 | |
*** nlahouti has joined #openstack-horizon | 21:49 | |
*** neelashah has joined #openstack-horizon | 21:49 | |
*** jhesketh has quit IRC | 21:50 | |
*** memogarcia has joined #openstack-horizon | 21:51 | |
*** ZZelle has quit IRC | 21:51 | |
*** ZZelle has joined #openstack-horizon | 21:53 | |
*** jhesketh has joined #openstack-horizon | 21:53 | |
*** dsneddon_lunch is now known as dsneddon | 21:54 | |
*** e0ne has joined #openstack-horizon | 21:54 | |
*** sayan_ has joined #openstack-horizon | 21:54 | |
*** sayan has quit IRC | 21:55 | |
*** jbell8 has joined #openstack-horizon | 21:58 | |
*** jtriley_ has joined #openstack-horizon | 21:58 | |
*** memogarcia has quit IRC | 21:58 | |
*** lhcheng has quit IRC | 21:59 | |
*** lhcheng has joined #openstack-horizon | 22:00 | |
*** jtriley has quit IRC | 22:00 | |
*** jtriley_ has quit IRC | 22:02 | |
*** nlahouti has quit IRC | 22:03 | |
*** lblanchard has quit IRC | 22:04 | |
*** petertr7 is now known as petertr7_away | 22:04 | |
*** jamielennox|away is now known as jamielennox | 22:05 | |
*** exploreshaifali has quit IRC | 22:05 | |
*** vgridnev has quit IRC | 22:05 | |
*** nlahouti has joined #openstack-horizon | 22:05 | |
*** yamamoto has joined #openstack-horizon | 22:05 | |
*** kyleolivo has quit IRC | 22:06 | |
lhcheng | ducttape_: back, but on a meeting.. | 22:07 |
ducttape_ | review updated for that project thing. I thought the commit message was ok. | 22:07 |
ducttape_ | not sure what you were looking for? | 22:08 |
*** matt-borland has quit IRC | 22:10 | |
*** matt-borland has joined #openstack-horizon | 22:10 | |
*** matt-borland has quit IRC | 22:11 | |
*** matt-borland has joined #openstack-horizon | 22:12 | |
lhcheng | the commit msg described the bug but not the patch | 22:13 |
lhcheng | something like don't display project link if user does not have privilege? | 22:13 |
ducttape_ | sure. I can do that. I see your point | 22:13 |
ducttape_ | keep in mind - if we start bike shedding about commit messages, last time this meant 10 patches in about 10 minutes. :P | 22:14 |
*** julim has quit IRC | 22:14 | |
lhcheng | we don't need to describe the bug again in detail. yeah but this commit is way off from the patch | 22:15 |
lhcheng | *commit msg | 22:15 |
openstackgerrit | Eric Peterson proposed openstack/horizon: Prevent project detail link result in user log out https://review.openstack.org/222437 | 22:15 |
ducttape_ | there we go.... now it's time for others to change the commit message | 22:16 |
*** david-lyle has joined #openstack-horizon | 22:16 | |
*** ChanServ sets mode: +o david-lyle | 22:16 | |
ducttape_ | we need to have at least 10 changes in the next 10 minutes for this | 22:16 |
ducttape_ | the clock is ticking now | 22:16 |
sjmc7 | you can edit the commit message inline! | 22:16 |
ducttape_ | I know | 22:16 |
ducttape_ | last time, we went bananas going back and forth on this | 22:16 |
sjmc7 | … but you are a purist? | 22:16 |
ducttape_ | with a name like ducttape_ , no, I am not a purist | 22:17 |
sjmc7 | touche | 22:17 |
ducttape_ | and lhcheng knows this about me, he has low expectations | 22:18 |
doug-fish | looking at this change https://review.openstack.org/#/c/244864/1 IMO it's a suitable change to backport, but I'm not sure sure how the new configuration option should be tagged. Suggestions? | 22:20 |
*** crobertsrh is now known as _crobertsrh | 22:21 | |
ducttape_ | david-lyle - is there a way for you to set the room topic? | 22:22 |
*** kyleolivo has joined #openstack-horizon | 22:23 | |
*** memogarcia has joined #openstack-horizon | 22:23 | |
ducttape_ | doug-fish - that seems like backporting a new feature. I think that is frowned upon | 22:24 |
krotscheck | matt-borland: Whatever happened to that eslint rule that was going to be added? | 22:26 |
doug-fish | ducttape_: well that's a fair discussion to have (I disagree) ... but let's say we did agree it was a bug best handled by a new config option - do we know how to do that? | 22:26 |
ducttape_ | this is why we have the rule of not backporting, so we avoid these talks | 22:27 |
doug-fish | ducttape_: are you saying you don't want to talk to me? | 22:28 |
doug-fish | :-( | 22:28 |
doug-fish | ;-( | 22:28 |
ducttape_ | doug-fish - I understand the desire to have this backported | 22:28 |
ducttape_ | but be ready to have a strange discussion | 22:28 |
* doug-fish ready | 22:29 | |
ducttape_ | of "this is ok to backport a feature and this is not" | 22:29 |
ducttape_ | what is worth it and what is not? | 22:29 |
ducttape_ | what about the new network topology? could you backport that? | 22:29 |
ducttape_ | it gets weird, and arbitrary | 22:30 |
doug-fish | ducttape_: well that's easy: no - it changed behavior without any explicit config selection | 22:30 |
doug-fish | plus translation | 22:30 |
*** ducttape_ has quit IRC | 22:31 | |
doug-fish | ducttape_: I'd agree ultimately it is arbitrary. | 22:31 |
*** ducttape_ has joined #openstack-horizon | 22:31 | |
ducttape_ | sorry, was bounced | 22:32 |
*** lapalm has quit IRC | 22:32 | |
doug-fish | but conditionally hiding a field that should be conditionally hidden + requiring a specific config choice to have a behavior change seems pretty safe to me. | 22:32 |
ducttape_ | pandora's box..... when will it end | 22:32 |
openstackgerrit | Reedip proposed openstack/horizon: Adding support for shared option in Network https://review.openstack.org/238778 | 22:32 |
*** lnxnut has quit IRC | 22:32 | |
doug-fish | liberty-eol | 22:33 |
ducttape_ | thats not what I mean | 22:34 |
doug-fish | I know | 22:34 |
ducttape_ | ;) | 22:34 |
ducttape_ | TOPIC #openstack-horizon | 22:34 |
ducttape_ | I've tried to get david-lyle to change the topic, to match our conversation from earlier http://eavesdrop.openstack.org/irclogs/%23openstack-horizon/%23openstack-horizon.2015-11-12.log.html#t2015-11-12T19:37:32 | 22:36 |
ducttape_ | :( | 22:37 |
TravT | ducttape_: you can change, but you have to be channel op | 22:40 |
TravT | david-lyle: Here's the patch we were talking about a bit ago with the DOM manipulation thing. https://review.openstack.org/#/c/219925/ | 22:40 |
*** david-lyle changes topic to "even sweetJebus can't make keystone v3 work" | 22:41 | |
ducttape_ | YAY! | 22:41 |
*** david-lyle changes topic to "OpenStack Horizon" | 22:42 | |
matt-borland | lol | 22:42 |
*** memogarcia has quit IRC | 22:43 | |
ducttape_ | too bad sweetJebus is no longer with us, would have found it pretty funny | 22:44 |
ducttape_ | and no, that's not religious commentary | 22:44 |
*** peristeri has quit IRC | 22:48 | |
*** matt-borland has quit IRC | 22:52 | |
*** ducttape_ has quit IRC | 22:56 | |
*** ducttape_ has joined #openstack-horizon | 22:56 | |
*** stevemar_ has joined #openstack-horizon | 22:56 | |
*** pumaranikar has joined #openstack-horizon | 22:57 | |
*** stevemar_ has quit IRC | 22:59 | |
*** ducttape_ has quit IRC | 23:01 | |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Upgraded eslint-config-openstack to 1.2.3 https://review.openstack.org/244908 | 23:03 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable no-multi-spaces https://review.openstack.org/244909 | 23:03 |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable no-unused-vars https://review.openstack.org/244910 | 23:03 |
*** memogarcia has joined #openstack-horizon | 23:03 | |
krotscheck | robcresswell: ^^ Started working on the list of new rules. I fyou get time, feel free to pick one and enable it. | 23:03 |
*** neelashah has quit IRC | 23:04 | |
*** vijendar has quit IRC | 23:05 | |
krotscheck | (Note, there's about 1000 new linting errors) | 23:07 |
*** ZZelle has quit IRC | 23:08 | |
*** jpomeroy has quit IRC | 23:09 | |
*** jamielennox is now known as jamielennox|away | 23:13 | |
david-lyle | tqtran: ping | 23:13 |
*** memogarcia has quit IRC | 23:16 | |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable radix https://review.openstack.org/244914 | 23:17 |
*** aix has joined #openstack-horizon | 23:18 | |
*** darrenc is now known as darrenc_afk | 23:18 | |
*** gyee has quit IRC | 23:19 | |
*** gyee has joined #openstack-horizon | 23:21 | |
*** jamielennox|away is now known as jamielennox | 23:22 | |
*** kmartin has quit IRC | 23:23 | |
*** wolverin_ has joined #openstack-horizon | 23:25 | |
*** wolverineav has quit IRC | 23:29 | |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Enable semi-spacing https://review.openstack.org/244920 | 23:29 |
*** jbell8 has quit IRC | 23:32 | |
*** nlahouti has quit IRC | 23:35 | |
*** darrenc_afk is now known as darrenc | 23:39 | |
*** nlahouti has joined #openstack-horizon | 23:39 | |
*** adelia_ has joined #openstack-horizon | 23:40 | |
*** nlahouti has quit IRC | 23:40 | |
*** nlahouti1 has joined #openstack-horizon | 23:40 | |
*** SimonChung has quit IRC | 23:42 | |
*** SimonChung1 has joined #openstack-horizon | 23:42 | |
*** SimonChung has joined #openstack-horizon | 23:43 | |
*** SimonChung has quit IRC | 23:43 | |
*** SimonChung2 has joined #openstack-horizon | 23:43 | |
*** SimonChung1 has quit IRC | 23:43 | |
*** adelia has quit IRC | 23:44 | |
*** SimonChung has joined #openstack-horizon | 23:44 | |
*** SimonChung2 has quit IRC | 23:44 | |
*** adelia_ has quit IRC | 23:45 | |
*** ongk has quit IRC | 23:46 | |
*** ducttape_ has joined #openstack-horizon | 23:47 | |
*** pumaranikar has quit IRC | 23:50 | |
bpokorny | ducttape_: Have you tested this patch with Keystone v2 in a situation where a user is admin on some projects and just Member on others? https://review.openstack.org/#/c/222437/ | 23:50 |
*** jbell8 has joined #openstack-horizon | 23:50 | |
bpokorny | I was just testing it with v3 and saw some issues in that situation, but not sure if it's only related to v3. | 23:51 |
ducttape_ | I tested it where I was admin in one project, _member_ in the other | 23:52 |
bpokorny | What I saw was the links show or are text only for all projects, based on just whether the user is an admin on the currently scoped project. | 23:52 |
bpokorny | ok. If that worked fine for you, it must be just something with v3 or my setup. | 23:52 |
ducttape_ | if you are in keystone v2, the links should only work when you are scoped to a project where you also have admin | 23:52 |
ducttape_ | I hooked up against v3 for auth etc.... but I did not get all the policy patches in place | 23:53 |
ducttape_ | also hooked up for v2 | 23:53 |
bpokorny | Just to make sure I understand what you tested - In v2, if you're scoped to a project where you have admin, the links are text only for any projects you only have _member_ on? | 23:55 |
*** e0ne has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!