*** Mounica has quit IRC | 00:01 | |
*** Mounica has joined #openstack-horizon | 00:02 | |
andrewbogott | robcresswell: I have a panel now! Adding the service to the keystone catalog got me there. Thanks again | 00:05 |
---|---|---|
*** bpokorny has quit IRC | 00:05 | |
r1chardj0n3s | robcresswell: you're still awake - can I ask a question? | 00:06 |
r1chardj0n3s | actually david-lyle might be able to answer too | 00:06 |
david-lyle | O_o | 00:07 |
r1chardj0n3s | hi :-) | 00:07 |
r1chardj0n3s | so I've been talking to people about requirements constraints | 00:07 |
r1chardj0n3s | I'm wondering whether constraints have come up before in Horizon discussions | 00:08 |
*** mpavlase has quit IRC | 00:08 | |
david-lyle | constraints as in upper-constraints? | 00:08 |
r1chardj0n3s | (this is all related to "don't break Horizon when a new xstatic package is released") | 00:08 |
r1chardj0n3s | yes | 00:08 |
*** piet has quit IRC | 00:08 | |
r1chardj0n3s | (upper-constraints is a new thing to me) | 00:09 |
david-lyle | there is nothing in that system that will block horizon from being broken | 00:09 |
david-lyle | what it does do is allow for a range of releases | 00:10 |
david-lyle | that we deem compatibile | 00:10 |
david-lyle | *compatible | 00:10 |
r1chardj0n3s | hmm https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt is a *fixed* set of versions, not a range | 00:11 |
david-lyle | works well on stable, but for master all the interdependencies make the xstatic a mess | 00:11 |
david-lyle | that's the upper limit | 00:11 |
r1chardj0n3s | no, it's *the* version | 00:11 |
david-lyle | look for example at d-o-a in there | 00:11 |
david-lyle | no it's not | 00:11 |
david-lyle | global-requirements provides a min and blocks specific versions | 00:11 |
david-lyle | upper-constraints is the cap | 00:12 |
david-lyle | so for d-o-a in Mitaka | 00:12 |
*** manjeets has joined #openstack-horizon | 00:12 | |
* tonyb wakes up | 00:12 | |
*** manjeets has left #openstack-horizon | 00:12 | |
david-lyle | the range is 2.0.0 to 2.2.0 | 00:13 |
r1chardj0n3s | assuming that it's used *correctly* (which is a patch I will propose) then upper-constraints will mean Mitaka will *only* install 2.2.0 d-o-a | 00:13 |
david-lyle | anything in that range is ok | 00:13 |
david-lyle | r1chardj0n3s: that's not correctly | 00:13 |
r1chardj0n3s | it's as intended | 00:13 |
david-lyle | it's call upper-constraints for a reason | 00:13 |
tonyb | david-lyle: no g-r is the range u-c is the pinned *exact* version | 00:13 |
tonyb | david-lyle: current;y u-c is used for all dsvm tests | 00:14 |
r1chardj0n3s | I've just had a long conversation with folks here about how it works :-) | 00:14 |
david-lyle | tonyb: yes for tests | 00:14 |
tonyb | and tox is in flight | 00:14 |
david-lyle | but d-o-a 2.0.0 is perfectly acceptable | 00:14 |
tonyb | david-lyle: sure. | 00:14 |
david-lyle | so stating that upper is the exact version misses the mark IMO | 00:14 |
r1chardj0n3s | if the constraints file is supplied to pip install -c then it will use the pinned versions in that constraints file | 00:15 |
david-lyle | r1chardj0n3s: sure which is great if I'm doing an install from scratch | 00:15 |
r1chardj0n3s | yup | 00:16 |
*** Ephur has quit IRC | 00:16 | |
r1chardj0n3s | and I would like to propose a patch to our tox to use constraints file | 00:16 |
tonyb | david-lyle: distros that u-c ar the time we cut a release as the base | 00:16 |
david-lyle | r1chardj0n3s: for testing, that's fine | 00:16 |
r1chardj0n3s | I'm also looking to have our docs patched to include mention of constraints | 00:17 |
r1chardj0n3s | for the poor folks who pip install or install from git | 00:17 |
r1chardj0n3s | (I'm not sure exactly what that patch will look like yet) | 00:17 |
*** jrist has quit IRC | 00:17 | |
*** dan_nguyen has left #openstack-horizon | 00:17 | |
*** jrist has joined #openstack-horizon | 00:18 | |
david-lyle | you're taking on a mess, because you'll have to edit the run_tests tooling | 00:18 |
david-lyle | the pip install is buried in there | 00:18 |
r1chardj0n3s | so I'm rooting for the patch that kills run_tests :-) | 00:18 |
robcresswell | killing run tests is all good, as long as we've got everything that relies on it fixed too | 00:19 |
r1chardj0n3s | yep | 00:19 |
robcresswell | I don't know if translations have been finalised yet. IIRC they call run_tests, or did. | 00:19 |
*** dan_nguyen has joined #openstack-horizon | 00:19 | |
r1chardj0n3s | but basically, without this constraints change we will run into the ongoing issue of releases of xstatic packages potentially breaking Horizon all over the place | 00:20 |
*** mrrowden has joined #openstack-horizon | 00:20 | |
r1chardj0n3s | (just like releases of other libraries have a history of breaking Horizon all over the place...) | 00:20 |
robcresswell | Don't we control all of them? | 00:20 |
david-lyle | r1chardj0n3s: I think we still have that problem just not in the isolated test world | 00:20 |
r1chardj0n3s | (I'm looking at you, heatclient) | 00:20 |
robcresswell | or are some external | 00:20 |
david-lyle | heatclient would have still broken us, upper-constraints was updated | 00:21 |
r1chardj0n3s | david-lyle: so yeah, we need constraints to be used/usable everywhere, yes | 00:21 |
robcresswell | Hmm. | 00:21 |
robcresswell | Summit topic? | 00:21 |
r1chardj0n3s | upper-constraints only gets updated when things are proven to work, right? | 00:21 |
david-lyle | nope | 00:21 |
david-lyle | it has to be updated for it to be usable | 00:21 |
david-lyle | otherwise tests won't use it | 00:22 |
*** bpokorny has joined #openstack-horizon | 00:22 | |
r1chardj0n3s | no, depends-on can route around constraints | 00:22 |
david-lyle | r1chardj0n3s: but so few things are tested | 00:24 |
david-lyle | but your concern is xstatic which is our mess not the inherited mess of other projects so we can limit to that | 00:24 |
r1chardj0n3s | but we can use constraints to control it | 00:25 |
r1chardj0n3s | this is the story I've been told by lifeless & co | 00:25 |
david-lyle | control what exactly? | 00:26 |
robcresswell | I'm a little lost on how this factors into xstatic. | 00:26 |
david-lyle | we got into the details before the problem | 00:26 |
david-lyle | you're welcome | 00:26 |
david-lyle | :P | 00:26 |
*** k-ishii has quit IRC | 00:26 | |
r1chardj0n3s | ok, how about I write up what I've learned, and the propsed xstatic release model, and how constraints fits in :-) | 00:26 |
r1chardj0n3s | my query before was I just wanted to know whether anyone else was/had looked into it | 00:27 |
robcresswell | Yeah having a version thats too high for stability is far from the problem with xstatic right now | 00:27 |
robcresswell | r1chardj0n3s: That would be excellent | 00:27 |
r1chardj0n3s | we also don't want to eg. break liberty by releasing a new xstatic, which is a real problem right now | 00:27 |
david-lyle | aren't the xstatic patches in u-c ? | 00:27 |
r1chardj0n3s | yes but we don't use constraints | 00:27 |
r1chardj0n3s | we == horizon | 00:27 |
david-lyle | ok, I finally see where you're going | 00:28 |
r1chardj0n3s | It's a very simple change to our tox.ini to use it | 00:28 |
david-lyle | but we don't sync the u-c part | 00:28 |
r1chardj0n3s | I will write up an email with the "plan" so this will hopefully become clearer :-) | 00:28 |
tonyb | david-lyle: Yes xstatic is in g-r and u-c but at least xstatic-angular-bootstrap has identical entries in kilo, libert and mitaka | 00:28 |
robcresswell | Ohh, so the u-c work is to solve not-breaking-stable-versions | 00:29 |
r1chardj0n3s | robcresswell: it's also to not make the unrelated horizon gate jobs fall about laughing | 00:29 |
*** tjones_zzzz has left #openstack-horizon | 00:30 | |
david-lyle | tonyb: but we have to have a local copy to honor it | 00:30 |
david-lyle | right now only g-r gets synced | 00:31 |
tonyb | david-lyle: Not sure U follow that. | 00:31 |
tonyb | *I* | 00:31 |
*** k-ishii has joined #openstack-horizon | 00:31 | |
david-lyle | how can I use the upper constraints file in the horizon pip install if I don't have a copy in horizon. I have a copy of g-r, but not u-c | 00:32 |
david-lyle | unless we're assuming devstack, but then I wish we weren't assuming that | 00:32 |
r1chardj0n3s | david-lyle: you pull u-c straight from git | 00:32 |
r1chardj0n3s | https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt or the branch-specific version | 00:32 |
david-lyle | things is g-r is already pushed automatically, why not u-c? | 00:33 |
tonyb | david-lyle: because that gets us back to the sycn probelsm we have/gad with g-r | 00:33 |
tonyb | it's 'supposed' to be single central copy with no syncs | 00:34 |
tonyb | pip install -c https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt -r requirements.txt | 00:34 |
david-lyle | so everytime I install the horizon dependencies I have to pull from requirements to see what I can? | 00:34 |
tonyb | david-lyle: I agree that if you have no web access then you have a problem but | 00:34 |
david-lyle | then it's just pre-packages like everything else | 00:35 |
tonyb | david-lyle: s/pull from requirements/grab a txt file/ | 00:35 |
david-lyle | sure | 00:36 |
tonyb | david-lyle: I'm not certain I understand the problem. | 00:38 |
david-lyle | no problem, I think we can't figure out what we want to be when we grow up (we = OpenStack) | 00:39 |
david-lyle | it's all good | 00:39 |
*** ducttape_ has joined #openstack-horizon | 00:40 | |
tonyb | david-lyle: ok | 00:40 |
*** pushkaru has quit IRC | 00:41 | |
david-lyle | for a kit it's awfully intertwined | 00:41 |
tonyb | david-lyle: Yeah, it is tightly coupled which moves the complexity but doesn't eliminate it | 00:42 |
r1chardj0n3s | david-lyle: I'm hoping my (currently being compose) email will help clarify ;-) | 00:42 |
david-lyle | r1chardj0n3s: I fully understand, and I'm fine with it, just the mechanism seems cumbersome, but it's not to the level of past nonsense | 00:44 |
david-lyle | my only real concern is that g-r is rather meaningless and has no hope to be true | 00:46 |
david-lyle | but that's no less true because of your proposed change | 00:46 |
david-lyle | just reinforces it | 00:46 |
r1chardj0n3s | david-lyle: so there still needs to be a non-constrained env in tox for reasons that I don't understand that just uses requirements.txt as-is | 00:48 |
david-lyle | r1chardj0n3s: right, but there will be things in g-r that don't actually work together | 00:50 |
david-lyle | the freeze approach has more likelihood | 00:50 |
david-lyle | which u-c provides | 00:50 |
* david-lyle has to run | 00:52 | |
*** hurgleburgler has quit IRC | 00:54 | |
*** mrrowden has quit IRC | 00:54 | |
*** slunkad has quit IRC | 01:01 | |
*** slunkad has joined #openstack-horizon | 01:02 | |
*** alexvictorchan has quit IRC | 01:05 | |
*** weezS has quit IRC | 01:06 | |
*** ZZelle_ has quit IRC | 01:08 | |
*** gyee has quit IRC | 01:11 | |
*** donu7 has quit IRC | 01:15 | |
*** ducttape_ has quit IRC | 01:15 | |
*** ducttape_ has joined #openstack-horizon | 01:22 | |
*** shu-mutou-OFF is now known as shu-mutou | 01:22 | |
*** clu_ has quit IRC | 01:23 | |
*** harlowja has quit IRC | 01:23 | |
*** yamamoto_ has joined #openstack-horizon | 01:25 | |
*** zzxwill has joined #openstack-horizon | 01:26 | |
*** ducttape_ has quit IRC | 01:26 | |
*** pushkaru has joined #openstack-horizon | 01:31 | |
*** donu7 has joined #openstack-horizon | 01:38 | |
*** donu7 has quit IRC | 01:38 | |
*** liuyulong_ has joined #openstack-horizon | 01:40 | |
*** Mounica has quit IRC | 01:40 | |
*** mtanino has quit IRC | 01:47 | |
openstackgerrit | Dan Nguyen proposed openstack/horizon: Disable Glance option to publicize image on Update https://review.openstack.org/288814 | 01:53 |
*** ducttape_ has joined #openstack-horizon | 01:58 | |
*** alexvictorchan has joined #openstack-horizon | 02:02 | |
*** sjmc7 has quit IRC | 02:08 | |
*** peristeri has quit IRC | 02:08 | |
openstackgerrit | Ankur proposed openstack/horizon: Add Network IP Availability Extension https://review.openstack.org/283171 | 02:10 |
*** ducttape_ has quit IRC | 02:17 | |
*** ducttape_ has joined #openstack-horizon | 02:19 | |
r1chardj0n3s | david-lyle: you about still? | 02:20 |
*** bpokorny_ has joined #openstack-horizon | 02:22 | |
*** dan_nguyen has quit IRC | 02:24 | |
*** bpokorny has quit IRC | 02:24 | |
*** ducttape_ has quit IRC | 02:28 | |
*** itisha has quit IRC | 02:29 | |
*** jtriley has joined #openstack-horizon | 02:30 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Replace top nav icons with text for clarity https://review.openstack.org/286041 | 02:31 |
*** pushkaru has quit IRC | 02:36 | |
*** liuyulong_ has quit IRC | 02:39 | |
*** wangbo has joined #openstack-horizon | 02:52 | |
*** jtriley has quit IRC | 02:54 | |
*** jamielennox is now known as jamielennox|away | 02:56 | |
*** jamielennox|away is now known as jamielennox | 03:01 | |
*** jamielennox is now known as jamielennox|away | 03:05 | |
*** Drago1 has quit IRC | 03:07 | |
*** bpokorny_ has quit IRC | 03:08 | |
*** deray has joined #openstack-horizon | 03:11 | |
*** hurgleburgler has joined #openstack-horizon | 03:11 | |
*** ducttape_ has joined #openstack-horizon | 03:13 | |
*** ducttape_ has quit IRC | 03:14 | |
*** jamielennox|away is now known as jamielennox | 03:15 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon select-inputs are now themable: Volumes https://review.openstack.org/263817 | 03:15 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Launch Instance https://review.openstack.org/289679 | 03:15 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 03:17 |
*** lhcheng_ has joined #openstack-horizon | 03:23 | |
*** lhcheng has quit IRC | 03:26 | |
*** ducttape_ has joined #openstack-horizon | 03:27 | |
*** masco has joined #openstack-horizon | 03:29 | |
*** lhcheng_ has quit IRC | 03:32 | |
*** ccard_ has quit IRC | 03:35 | |
*** kzaitsev_mb has quit IRC | 03:39 | |
*** hurgleburgler has quit IRC | 03:39 | |
*** zzxwill has quit IRC | 03:47 | |
*** ccard_ has joined #openstack-horizon | 03:50 | |
*** dan_nguyen has joined #openstack-horizon | 03:57 | |
*** deray has quit IRC | 03:57 | |
*** deray has joined #openstack-horizon | 03:57 | |
*** deray has quit IRC | 03:57 | |
openstackgerrit | Wang Bo proposed openstack/horizon: Add policy checks in images panels https://review.openstack.org/261967 | 04:09 |
*** lhcheng has joined #openstack-horizon | 04:10 | |
openstackgerrit | hanjiabao proposed openstack/horizon: Show Public images first after creating an image https://review.openstack.org/289694 | 04:12 |
*** bapalm has quit IRC | 04:13 | |
*** neelashah has joined #openstack-horizon | 04:13 | |
*** ducttape_ has quit IRC | 04:24 | |
*** hurgleburgler has joined #openstack-horizon | 04:28 | |
*** bapalm has joined #openstack-horizon | 04:30 | |
*** dan_nguyen has quit IRC | 04:31 | |
*** kzaitsev_mb has joined #openstack-horizon | 04:35 | |
openstackgerrit | hanjiabao proposed openstack/horizon: Show Public images first after subbitting creating https://review.openstack.org/289699 | 04:35 |
*** xinwu has quit IRC | 04:36 | |
*** lhcheng_ has joined #openstack-horizon | 04:40 | |
*** lhcheng has quit IRC | 04:43 | |
*** kzaitsev_mb has quit IRC | 04:49 | |
*** wolverineav has quit IRC | 04:51 | |
*** vishwanathj is now known as vishwanathj_zzz | 04:59 | |
*** zzxwill has joined #openstack-horizon | 05:01 | |
*** hurgleburgler has quit IRC | 05:02 | |
*** xinwu has joined #openstack-horizon | 05:08 | |
*** zzxwill has quit IRC | 05:21 | |
*** zzxwill has joined #openstack-horizon | 05:22 | |
*** wolverineav has joined #openstack-horizon | 05:22 | |
*** zul has quit IRC | 05:23 | |
*** wolverineav has quit IRC | 05:27 | |
*** wolverineav has joined #openstack-horizon | 05:29 | |
*** wolverineav has quit IRC | 05:31 | |
*** belmoreira has joined #openstack-horizon | 05:31 | |
*** wolverineav has joined #openstack-horizon | 05:33 | |
*** kzaitsev_mb has joined #openstack-horizon | 05:45 | |
*** kzaitsev_mb has quit IRC | 05:50 | |
*** rcernin has joined #openstack-horizon | 06:02 | |
*** roxanagh_ has joined #openstack-horizon | 06:06 | |
*** jamielennox is now known as jamielennox|away | 06:08 | |
*** neelashah has quit IRC | 06:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/289729 | 06:15 |
*** shu-mutou is now known as shu-mutou-AFK | 06:21 | |
*** kevchentw has joined #openstack-horizon | 06:21 | |
*** kevchentw has quit IRC | 06:23 | |
*** belmoreira has quit IRC | 06:24 | |
*** kevchentw has joined #openstack-horizon | 06:25 | |
*** wangbo has quit IRC | 06:26 | |
*** vgridnev has joined #openstack-horizon | 06:30 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Zanata https://review.openstack.org/288851 | 06:33 |
*** roxanagh_ has quit IRC | 06:37 | |
*** wangbo has joined #openstack-horizon | 06:38 | |
*** patk has joined #openstack-horizon | 06:40 | |
*** david-lyle_ has joined #openstack-horizon | 06:44 | |
*** david-lyle has quit IRC | 06:44 | |
*** jtomasek has joined #openstack-horizon | 06:49 | |
*** vgridnev has quit IRC | 06:52 | |
*** pcaruana has quit IRC | 06:57 | |
*** lhcheng has joined #openstack-horizon | 07:23 | |
*** lhcheng_ has quit IRC | 07:27 | |
*** wangbo has quit IRC | 07:28 | |
*** aortega has quit IRC | 07:29 | |
*** belmoreira has joined #openstack-horizon | 07:31 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: Pagination for flavor - prev link https://review.openstack.org/288228 | 07:37 |
*** rdopiera has joined #openstack-horizon | 07:45 | |
*** wangbo has joined #openstack-horizon | 07:47 | |
*** kzaitsev_mb has joined #openstack-horizon | 07:47 | |
*** bsv has left #openstack-horizon | 07:47 | |
*** e0ne has joined #openstack-horizon | 07:48 | |
*** e0ne has quit IRC | 07:49 | |
*** kzaitsev_mb has quit IRC | 07:52 | |
*** itxaka has joined #openstack-horizon | 07:58 | |
*** vgridnev has joined #openstack-horizon | 08:00 | |
*** vgridnev has quit IRC | 08:14 | |
*** permalac has joined #openstack-horizon | 08:15 | |
*** aortega has joined #openstack-horizon | 08:32 | |
*** zzxwill has quit IRC | 08:32 | |
*** mvk has joined #openstack-horizon | 08:41 | |
*** pece has joined #openstack-horizon | 08:46 | |
*** kzaitsev_mb has joined #openstack-horizon | 08:47 | |
*** mpavlase has joined #openstack-horizon | 09:03 | |
*** kzaitsev_mb has quit IRC | 09:04 | |
*** reedip is now known as reedip_away | 09:04 | |
*** wolverineav has quit IRC | 09:30 | |
*** mpavlase has quit IRC | 09:32 | |
*** kevchentw has quit IRC | 09:45 | |
*** ygbo has joined #openstack-horizon | 09:55 | |
*** mpavlase has joined #openstack-horizon | 10:01 | |
openstackgerrit | hanjiabao proposed openstack/horizon: Create project but no display and an error https://review.openstack.org/289828 | 10:02 |
slunkad | mrunge: do you know if this is still a valid bug https://bugs.launchpad.net/horizon/+bug/1432810 | 10:04 |
openstack | Launchpad bug 1432810 in OpenStack Dashboard (Horizon) "[Launch Instance Fix] Focus should be trapped in modal dialog box when popping up" [Low,Confirmed] - Assigned to Sayali Lunkad (sayalilunkad) | 10:04 |
mrunge | slunkad, sorry, I don't know | 10:04 |
*** tosky has joined #openstack-horizon | 10:06 | |
openstackgerrit | hanjiabao proposed openstack/horizon: Create project but no display and an error https://review.openstack.org/289828 | 10:07 |
*** zul has joined #openstack-horizon | 10:07 | |
*** yamamoto_ has quit IRC | 10:09 | |
*** _pece has joined #openstack-horizon | 10:10 | |
*** mpavlase has quit IRC | 10:10 | |
*** pece has quit IRC | 10:11 | |
*** mvk has quit IRC | 10:14 | |
*** mvk has joined #openstack-horizon | 10:15 | |
*** xinwu has quit IRC | 10:15 | |
*** wolverineav has joined #openstack-horizon | 10:30 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: [WIP] Fix non-working Angular actions in jquery modified tables https://review.openstack.org/289849 | 10:32 |
*** openstackgerrit has quit IRC | 10:33 | |
*** openstackgerrit has joined #openstack-horizon | 10:34 | |
*** wolverineav has quit IRC | 10:35 | |
tsufiev | TravT, a crude fix for the Angular actions issue after jquery table row update - https://review.openstack.org/#/c/289849/1 | 10:37 |
tsufiev | but you guys will probably make it better :) | 10:37 |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 10:44 |
*** lhcheng has quit IRC | 10:47 | |
*** yamamoto has joined #openstack-horizon | 10:59 | |
*** mpavlase has joined #openstack-horizon | 11:03 | |
*** yamamoto has quit IRC | 11:05 | |
*** yamamoto has joined #openstack-horizon | 11:06 | |
*** yamamoto has quit IRC | 11:10 | |
*** amotoki has joined #openstack-horizon | 11:10 | |
*** ^Gal^ has quit IRC | 11:21 | |
*** ^Gal^ has joined #openstack-horizon | 11:26 | |
*** deray has joined #openstack-horizon | 11:28 | |
*** itisha has joined #openstack-horizon | 11:31 | |
*** yamamoto has joined #openstack-horizon | 11:37 | |
*** permalac has quit IRC | 11:55 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix empty 'href' in link actions after AJAX actions_update https://review.openstack.org/289337 | 12:03 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor some table rows & cells waits in i9n tests https://review.openstack.org/289882 | 12:03 |
*** rodrigods has quit IRC | 12:11 | |
*** rodrigods has joined #openstack-horizon | 12:12 | |
*** pece has joined #openstack-horizon | 12:15 | |
*** _pece has quit IRC | 12:16 | |
*** yamamoto has quit IRC | 12:23 | |
*** slunkad has quit IRC | 12:24 | |
*** slunkad has joined #openstack-horizon | 12:25 | |
*** yamamoto has joined #openstack-horizon | 12:25 | |
*** zzxwill has joined #openstack-horizon | 12:28 | |
*** wolverineav has joined #openstack-horizon | 12:32 | |
*** leitan has joined #openstack-horizon | 12:33 | |
*** yamamoto has quit IRC | 12:34 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 12:34 |
*** yamamoto has joined #openstack-horizon | 12:35 | |
*** zhurong has joined #openstack-horizon | 12:35 | |
*** wolverineav has quit IRC | 12:37 | |
*** wangbo has quit IRC | 12:39 | |
*** jpomeroy has joined #openstack-horizon | 12:45 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out integration tests scaffolds from Horizon production code https://review.openstack.org/287793 | 12:50 |
*** masco has quit IRC | 12:52 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Added test for check stacks creation and deletion functionality https://review.openstack.org/266368 | 12:53 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Added test for check stacks creation and deletion functionality https://review.openstack.org/266368 | 12:56 |
*** mpavlase has quit IRC | 13:04 | |
*** ducttape_ has joined #openstack-horizon | 13:06 | |
*** doug-fish has joined #openstack-horizon | 13:07 | |
*** jtriley has joined #openstack-horizon | 13:11 | |
*** mpavlase has joined #openstack-horizon | 13:14 | |
*** yamamoto has quit IRC | 13:15 | |
robcresswell | tsufiev: I think I found a bug in test settings :D | 13:16 |
tsufiev | oh | 13:16 |
tsufiev | robcresswell, what is it? | 13:16 |
robcresswell | They import local.enabled | 13:16 |
robcresswell | Which it shouldnt do for Horizon tests | 13:16 |
*** itxaka is now known as itxaka|afk | 13:17 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor some table rows & cells waits in i9n tests https://review.openstack.org/289882 | 13:17 |
*** yamamoto has joined #openstack-horizon | 13:18 | |
tsufiev | robcresswell, yes, seems like it shouldn't. | 13:19 |
* tsufiev wonders how many tests will fail if it's fixed :) | 13:19 | |
robcresswell | shouldnt make a difference since local.enabled is empty by default | 13:20 |
robcresswell | but if you carry anything in there, I imagine tests would fall over laughing | 13:20 |
robcresswell | either way, there is no need to import them | 13:20 |
*** yamamoto has quit IRC | 13:21 | |
*** ducttape_ has quit IRC | 13:22 | |
*** jtriley has quit IRC | 13:25 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor some table rows & cells waits in i9n tests https://review.openstack.org/289882 | 13:27 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix empty 'href' in link actions after AJAX actions_update https://review.openstack.org/289337 | 13:28 |
*** jtriley has joined #openstack-horizon | 13:30 | |
*** wolverineav has joined #openstack-horizon | 13:34 | |
*** lapalm has joined #openstack-horizon | 13:35 | |
*** jtriley has quit IRC | 13:35 | |
*** peristeri has joined #openstack-horizon | 13:37 | |
openstackgerrit | Matthias Runge proposed openstack/horizon: take time zone into account https://review.openstack.org/289920 | 13:37 |
*** cbader has joined #openstack-horizon | 13:38 | |
*** wolverineav has quit IRC | 13:39 | |
*** Mounica has joined #openstack-horizon | 13:42 | |
*** neelashah has joined #openstack-horizon | 13:43 | |
*** matt-borland has joined #openstack-horizon | 13:45 | |
*** zzxwill has quit IRC | 13:46 | |
robcresswell | mrunge: Doesn't Django already use settings.TIME_ZONE as the django_timezone value? | 13:46 |
* robcresswell is digging through docs | 13:46 | |
*** Mounica has quit IRC | 13:47 | |
*** zhurong has quit IRC | 13:49 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 13:50 |
*** zhurong has joined #openstack-horizon | 13:50 | |
*** Ephur has joined #openstack-horizon | 13:53 | |
*** zzxwill has joined #openstack-horizon | 13:54 | |
*** jtriley has joined #openstack-horizon | 13:56 | |
mrunge | robcresswell, according to my tests, it does not | 13:59 |
mrunge | robcresswell, and, if the cookie is not set, it defaults to UTC in our case | 13:59 |
*** jtriley has quit IRC | 14:04 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 14:04 |
*** ducttape_ has joined #openstack-horizon | 14:07 | |
*** petertr7_away is now known as petertr7 | 14:08 | |
*** yamamoto has joined #openstack-horizon | 14:08 | |
robcresswell | mrunge: Why does that cookie setting even exist? It seems like you could just have `self.request.session.get( 'django_timezone', default_tz)` | 14:11 |
*** pauloewerton has joined #openstack-horizon | 14:11 | |
robcresswell | Thats how django appears to address the timezone. I'm not sure that the cookie get/set is actually required... Need to dig into the object structure more. | 14:11 |
mrunge | robcresswell, you 'can' set the timezone for your user to something else | 14:11 |
*** yamamoto has quit IRC | 14:11 | |
mrunge | i.e if your specific user lives in a different time zone | 14:11 |
robcresswell | But, isn't that still in request.session? | 14:12 |
mrunge | but you can set a default in local_settings | 14:12 |
mrunge | we (Horizon) nailed the default to be UTC | 14:12 |
robcresswell | trying to figure out why we have request.session(django_timezone) and request.cookies(django_timezone) | 14:12 |
*** ducttape_ has quit IRC | 14:12 | |
mrunge | anyways: both does not take into account, what you set in local_settings | 14:14 |
mrunge | i.e. django settings | 14:14 |
*** neelashah has quit IRC | 14:16 | |
robcresswell | yes | 14:16 |
robcresswell | strange | 14:16 |
*** yamamoto has joined #openstack-horizon | 14:19 | |
*** lblanchard has joined #openstack-horizon | 14:21 | |
*** zhurong has quit IRC | 14:29 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Policy should support AND and OR checks for panels https://review.openstack.org/175982 | 14:30 |
*** doug-fish has quit IRC | 14:32 | |
openstackgerrit | Steve Martinelli proposed openstack/django-openstack-auth-kerberos: switch to ksa https://review.openstack.org/289945 | 14:32 |
mrunge | robcresswell, if you don't take cookies into account, time zone setting is not saved between sessions | 14:32 |
mrunge | robcresswell, not everybody uses database saved sessions | 14:33 |
*** doug-fish has joined #openstack-horizon | 14:33 | |
*** doug-fish has quit IRC | 14:37 | |
*** neelashah has joined #openstack-horizon | 14:43 | |
openstackgerrit | Steve Martinelli proposed openstack/django-openstack-auth-kerberos: switch to ksa https://review.openstack.org/289945 | 14:44 |
openstackgerrit | Matt Borland proposed openstack/horizon: Cleaning up lint warnings for Image work https://review.openstack.org/289570 | 14:45 |
*** doug-fish has joined #openstack-horizon | 14:46 | |
matt-borland | robcresswell, ^^ I replied also to Itxaca's patch about eslint warnings. I see a problem. | 14:48 |
matt-borland | Perhaps I'm overlooking something simple. | 14:49 |
robcresswell | mrunge: But in that case, isn't the session already stored in the cookie anyway? I don't think there is any need to explicitly set cookie info | 14:51 |
robcresswell | unless its something that needs persist outside of a session... like a logout reason, or somethign | 14:52 |
*** hurgleburgler has joined #openstack-horizon | 14:52 | |
*** tjones_zzzz has joined #openstack-horizon | 14:52 | |
robcresswell | wait, I just answered my own question. | 14:52 |
robcresswell | matt-borland: looking | 14:53 |
robcresswell | mrunge: Yeah, your approach makes sense, I see now :p | 14:53 |
mrunge | robcresswell, hahaha. glad to make sense once :P | 14:54 |
*** tjones_zzzz has left #openstack-horizon | 14:54 | |
*** Daisy has joined #openstack-horizon | 14:56 | |
*** yamamoto has quit IRC | 14:56 | |
*** Daisy has quit IRC | 14:59 | |
*** Daisy has joined #openstack-horizon | 14:59 | |
robcresswell | matt-borland: You may have to fight with krotscheck on the JSDoc rule for that one | 15:00 |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Add "prev" to instance list pagination https://review.openstack.org/289314 | 15:01 |
matt-borland | I don't think there's a good answer. | 15:01 |
matt-borland | robcresswell ^^ | 15:01 |
matt-borland | I don't want to get rid of the jsdocs rule. | 15:01 |
robcresswell | I'm assuming it has ignores though | 15:01 |
robcresswell | for repeated vars | 15:01 |
matt-borland | hm. I'll look. | 15:01 |
*** deray has quit IRC | 15:02 | |
matt-borland | yeah. requireParamDescription option. | 15:02 |
matt-borland | er, maybe not. I' | 15:03 |
krotscheck | matt-borland: I feel like the injectable documentation thing you mentioned is.... well, it's a particular feature of using the papa rules - maybe the jsdoc rule has an equivalent in eslint-plugin-angular that's more lenient? | 15:04 |
*** kzaitsev_mb has joined #openstack-horizon | 15:05 | |
matt-borland | krotscheck, yeah, I'll look. In a way, it comes down to...what *does* JSDoc want? | 15:05 |
krotscheck | matt-borland: Yeah, took me a while to figure that out ;) | 15:05 |
krotscheck | matt-borland: Also, I can see a strong case for adjusting requireParamDescription to exclude params based on a regex? Things that are angular specific ($scope, etc) don't seem like things we want to document every time. | 15:06 |
krotscheck | Or just by name | 15:06 |
matt-borland | could be | 15:07 |
krotscheck | Is horizon master newton already? | 15:07 |
*** itxaka|afk is now known as itxaka | 15:13 | |
*** kzaitsev_mb has quit IRC | 15:13 | |
*** aortega has quit IRC | 15:20 | |
*** sjmc7 has joined #openstack-horizon | 15:21 | |
*** pushkaru has joined #openstack-horizon | 15:26 | |
*** zul has quit IRC | 15:28 | |
*** mrrowden has joined #openstack-horizon | 15:28 | |
*** zul has joined #openstack-horizon | 15:29 | |
*** Daisy has quit IRC | 15:34 | |
*** wolverineav has joined #openstack-horizon | 15:36 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 15:36 |
*** wolverineav has quit IRC | 15:40 | |
*** piet has joined #openstack-horizon | 15:41 | |
*** Qingqing has joined #openstack-horizon | 15:44 | |
*** Qingqing has left #openstack-horizon | 15:44 | |
*** xinwu has joined #openstack-horizon | 15:44 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Policy should support AND and OR checks for panels https://review.openstack.org/175982 | 15:45 |
*** permalac has joined #openstack-horizon | 15:46 | |
*** ducttape_ has joined #openstack-horizon | 15:47 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 15:47 |
*** Drago has joined #openstack-horizon | 15:52 | |
*** mrrowden has quit IRC | 15:52 | |
*** Drago has quit IRC | 15:53 | |
*** Drago has joined #openstack-horizon | 15:53 | |
*** zzxwill has quit IRC | 15:56 | |
*** permalac_ has joined #openstack-horizon | 15:56 | |
*** yamamoto has joined #openstack-horizon | 15:57 | |
*** permalac has quit IRC | 16:00 | |
*** zul has quit IRC | 16:05 | |
*** zul has joined #openstack-horizon | 16:06 | |
*** rhagarty_ has quit IRC | 16:09 | |
*** yamamoto has quit IRC | 16:10 | |
*** rhagarty has joined #openstack-horizon | 16:10 | |
*** kzaitsev_mb has joined #openstack-horizon | 16:11 | |
*** itxaka has quit IRC | 16:13 | |
*** itxaka has joined #openstack-horizon | 16:14 | |
*** david_cu has joined #openstack-horizon | 16:15 | |
*** zzxwill has joined #openstack-horizon | 16:17 | |
*** aortega has joined #openstack-horizon | 16:18 | |
*** vijendar has joined #openstack-horizon | 16:19 | |
*** vijendar1 has joined #openstack-horizon | 16:20 | |
*** mtanino has joined #openstack-horizon | 16:20 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Cleaning up lint warnings for Image work https://review.openstack.org/289570 | 16:20 |
*** vijendar has quit IRC | 16:23 | |
*** petertr7 is now known as petertr7_away | 16:24 | |
david-lyle_ | krotscheck: no, not until RC-1 is tagged | 16:27 |
krotscheck | david-lyle_: Thanks | 16:27 |
*** david-lyle_ is now known as david-lyle | 16:28 | |
*** ChanServ sets mode: +o david-lyle | 16:28 | |
*** belmoreira has quit IRC | 16:29 | |
*** zhurong has joined #openstack-horizon | 16:29 | |
*** absubram has joined #openstack-horizon | 16:29 | |
openstackgerrit | Marcellin Fom Tchassem proposed openstack/horizon: Rename methods's name to add consistan https://review.openstack.org/290003 | 16:29 |
*** eroussel has joined #openstack-horizon | 16:32 | |
*** rhagarty_ has joined #openstack-horizon | 16:32 | |
*** alexvictorchan has quit IRC | 16:32 | |
*** Mounica has joined #openstack-horizon | 16:34 | |
*** rhagarty has quit IRC | 16:34 | |
*** weezS has joined #openstack-horizon | 16:34 | |
*** gyee has joined #openstack-horizon | 16:34 | |
*** weezS has quit IRC | 16:36 | |
*** petertr7_away is now known as petertr7 | 16:41 | |
*** xinwu has quit IRC | 16:45 | |
amotoki | david-lyle: could you review i18n related patches? https://review.openstack.org/289039, https://review.openstack.org/288947 | 16:46 |
amotoki | david-lyle: and hopefully https://review.openstack.org/284066 it helps me check generated POT files. | 16:47 |
*** bpokorny has joined #openstack-horizon | 16:47 | |
david-lyle | amotoki: on it | 16:49 |
amotoki | david-lyle: thanks! | 16:49 |
robcresswell | Just +2'd the interpolation one... | 16:50 |
robcresswell | I'll let you look at the comments for translators one david-lyle :p | 16:51 |
amotoki | I should write some devref to encourage interpolate usage for JS i18n. | 16:52 |
*** rdopiera has quit IRC | 16:53 | |
*** ediardo has joined #openstack-horizon | 16:54 | |
matt-borland | TravT, mind if I rebase/deconflict https://review.openstack.org/#/c/286268/ | 16:55 |
dani_castellanos | @robcresswell: I didn't thank you for pointing me to the pagination patch yesterday :)... thanks! | 16:55 |
robcresswell | dani_castellanos: No problem! If you get chance to try it out and leave a review, that'd be much appreciated. | 16:56 |
*** jprovazn has joined #openstack-horizon | 16:56 | |
TravT | matt-borland: please do! | 16:57 |
dani_castellanos | already did that! | 16:57 |
TravT | just got done doing a hangout on air | 16:57 |
*** zzxwill has quit IRC | 16:57 | |
robcresswell | TravT: How was that? | 16:57 |
TravT | went pretty well | 16:57 |
robcresswell | I'm curious if there would be any benefit to doing something like that at the summit | 16:57 |
TravT | i think there would be... but you need to have headsets for people i think | 16:58 |
TravT | the summit already records conference sessions | 16:58 |
TravT | for youtube. | 16:58 |
TravT | but we could try something for design sessions | 16:58 |
robcresswell | Yeah, I was thinking of the design sessions | 16:58 |
*** ediardo has quit IRC | 16:58 | |
*** ygbo has quit IRC | 16:58 | |
robcresswell | Mic in middle of room, camera up on top of whiteboard, or similar. | 16:58 |
david-lyle | better in theory than practice | 16:59 |
robcresswell | Slight concern about people feeling uneasy about being watched etc. | 16:59 |
TravT | well, this one was just slide and demo | 16:59 |
TravT | so, i didn't have to get on camera. | 17:00 |
david-lyle | it's more the communication model breaks down | 17:00 |
david-lyle | think remotely attending a corporate team meeting but 30 times worse, more frustrating that worth it for the remote people | 17:00 |
robcresswell | Yeah, I think it would be more a way for people to follow discussion than contribute back to it. | 17:00 |
robcresswell | Unless we had someone monitoring chat or IRC or something. | 17:01 |
david-lyle | mic'ing is never done right so you hear 1/4 the conversation | 17:01 |
*** vishwanathj_zzz is now known as vishwanathj | 17:01 | |
TravT | i've been in several glance sessions (mid-cycle and summit) where video conferencing was attempted | 17:01 |
TravT | and the big problem was not being able to hear | 17:01 |
* david-lyle checks that he is actually typing | 17:01 | |
TravT | that's why i think you'd need a mic for input | 17:01 |
*** vijendar1 has quit IRC | 17:02 | |
david-lyle | ASDFG | 17:02 |
TravT | yes, you are typing | 17:02 |
*** vijendar has joined #openstack-horizon | 17:02 | |
TravT | i think | 17:02 |
david-lyle | :D | 17:02 |
robcresswell | haha | 17:02 |
TravT | unless it is one of your kids | 17:02 |
david-lyle | no the grammar would be better | 17:02 |
TravT | sometimes i re-read what i type into IRC and wonder if I should just be banned | 17:02 |
TravT | its like i send a message to my fingers to type and by the time it gets to them i'm three thoughts later and they forgot what they are doing | 17:03 |
robcresswell | lol | 17:03 |
*** xinwu has joined #openstack-horizon | 17:03 | |
robcresswell | dani_castellanos: Sorry, just noticed the reply. Thanks! | 17:04 |
TravT | i got luck on today's presentation. | 17:04 |
TravT | i just borrowed some of Tyr's slides and then merged in some from Tokyo. | 17:04 |
robcresswell | nicely done | 17:05 |
*** alexvictorchan has joined #openstack-horizon | 17:05 | |
*** lhcheng has joined #openstack-horizon | 17:05 | |
*** eroussel has quit IRC | 17:06 | |
*** dan_nguyen has joined #openstack-horizon | 17:06 | |
*** cloudtrainme has joined #openstack-horizon | 17:07 | |
*** zzxwill has joined #openstack-horizon | 17:09 | |
*** alexvictorchan has quit IRC | 17:09 | |
*** zzxwill has quit IRC | 17:10 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Angular Policy Caching https://review.openstack.org/286268 | 17:10 |
*** alexvictorchan has joined #openstack-horizon | 17:11 | |
*** kzaitsev_mb has quit IRC | 17:11 | |
*** wolverineav has joined #openstack-horizon | 17:12 | |
*** ducttape_ has quit IRC | 17:16 | |
*** ediardo has joined #openstack-horizon | 17:17 | |
*** ducttape_ has joined #openstack-horizon | 17:20 | |
*** ducttape_ has quit IRC | 17:21 | |
*** ducttape_ has joined #openstack-horizon | 17:22 | |
*** permalac_ has quit IRC | 17:22 | |
*** ducttape_ has quit IRC | 17:22 | |
*** ducttape_ has joined #openstack-horizon | 17:22 | |
*** sjmc7_ has joined #openstack-horizon | 17:24 | |
*** pece has quit IRC | 17:25 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Cleaning up lint warnings for Image work https://review.openstack.org/289570 | 17:25 |
*** zhurong has quit IRC | 17:26 | |
*** sjmc7 has quit IRC | 17:27 | |
*** sjmc7_ is now known as sjmc7 | 17:27 | |
*** zhurong has joined #openstack-horizon | 17:29 | |
*** harlowja has joined #openstack-horizon | 17:29 | |
matt-borland | itxaka, I'm going to hunt down some areas for cleaning eslint problems. Is it OK if I work on some of the Launch Instance features? | 17:32 |
itxaka | yup yup! | 17:32 |
matt-borland | thanks, sounds good! | 17:32 |
itxaka | let me knowif I can help you with that, or what warning I can clean up as to not overlap, I would really love to get those warnings to (almost) zero! | 17:33 |
*** piet has quit IRC | 17:33 | |
*** zhurong has quit IRC | 17:33 | |
*** rcernin has quit IRC | 17:34 | |
*** xinwu has quit IRC | 17:41 | |
*** neelashah has quit IRC | 17:42 | |
*** slunkad has quit IRC | 17:44 | |
*** wolverineav has quit IRC | 17:44 | |
*** Daisy has joined #openstack-horizon | 17:45 | |
robcresswell | itxaka, matt-borland: Any chance I could persuade you guys to look into some of the RC1 bugs before fixing linting? That can wait till next cycle, but there are a couple of angular bugs interfering with Launch instance right now : https://launchpad.net/horizon/+milestone/mitaka-rc1 | 17:47 |
robcresswell | Would be great to make this a bug success. | 17:47 |
*** exploreshaifali has joined #openstack-horizon | 17:47 | |
robcresswell | big* | 17:47 |
matt-borland | yeah, that was an in-between activity :) | 17:47 |
matt-borland | good redirect, robcresswell | 17:48 |
matt-borland | ignore the following as I move on: | 17:48 |
openstackgerrit | Merged openstack/horizon: Use interpolate in JS to allow translators to control word order https://review.openstack.org/288947 | 17:48 |
openstackgerrit | Matt Borland proposed openstack/horizon: Cleaning code to remove eslint warnings from Launch Instance https://review.openstack.org/290041 | 17:50 |
*** Daisy has quit IRC | 17:50 | |
matt-borland | robcresswell, have you looked at my bugfix: https://review.openstack.org/#/c/289379/ | 17:51 |
matt-borland | that addresses one of the bugs | 17:51 |
openstackgerrit | Merged openstack/horizon: Honor comments for translators when extracting messages https://review.openstack.org/289039 | 17:51 |
robcresswell | matt-borland: Looking now | 17:52 |
*** Drago has quit IRC | 17:52 | |
matt-borland | thanks robcresswell | 17:52 |
*** neelashah has joined #openstack-horizon | 17:52 | |
*** mvk has quit IRC | 18:00 | |
*** zul has quit IRC | 18:00 | |
*** zul has joined #openstack-horizon | 18:01 | |
*** zul_ has joined #openstack-horizon | 18:01 | |
*** zul has quit IRC | 18:01 | |
*** zul_ is now known as zul | 18:01 | |
*** e0ne has joined #openstack-horizon | 18:03 | |
robcresswell | matt-borland: Looks about right. The logic for adding the launch_actions is a liiittle messy | 18:04 |
matt-borland | sure is! | 18:04 |
robcresswell | matt-borland: Same as the other patch though, seems like the first call to + launch_actions could just ignored. It'll always be empty | 18:05 |
matt-borland | true. happy to fix if it poses a problem. | 18:05 |
*** petertr7 is now known as petertr7_away | 18:06 | |
*** mpavlase has quit IRC | 18:07 | |
robcresswell | While you're around, if you could tidy it up quickly that would be good | 18:07 |
robcresswell | I can +2 straight after | 18:07 |
*** Guest40848 has quit IRC | 18:09 | |
*** bpokorny has quit IRC | 18:12 | |
*** bpokorny has joined #openstack-horizon | 18:12 | |
*** clu_ has joined #openstack-horizon | 18:14 | |
robcresswell | jpomeroy: Did your LBaaS styling patch merge btw? | 18:15 |
*** tosky has quit IRC | 18:15 | |
*** e0ne has quit IRC | 18:17 | |
*** e0ne has joined #openstack-horizon | 18:17 | |
*** e0ne has quit IRC | 18:17 | |
*** wolverineav has joined #openstack-horizon | 18:19 | |
*** Drago has joined #openstack-horizon | 18:24 | |
*** wolverineav has quit IRC | 18:24 | |
*** Drago has quit IRC | 18:25 | |
*** jbell8 has joined #openstack-horizon | 18:25 | |
*** Drago has joined #openstack-horizon | 18:25 | |
*** petertr7_away is now known as petertr7 | 18:26 | |
*** kzaitsev_mb has joined #openstack-horizon | 18:27 | |
*** jbell8 has quit IRC | 18:33 | |
*** ducttape_ has quit IRC | 18:33 | |
*** ybathia has joined #openstack-horizon | 18:34 | |
*** tosky has joined #openstack-horizon | 18:36 | |
*** mpavlase has joined #openstack-horizon | 18:45 | |
*** neelashah has quit IRC | 18:45 | |
itxaka | robcresswell, I will have a look but Im not sure Im the correct person for angular patches lol | 18:45 |
*** ducttape_ has joined #openstack-horizon | 18:46 | |
robcresswell | itxaka: Ha, you're being too humble. If you do get time to pick up any RC1 bugs, or review any RC1 patches, it'd be very helpful. | 18:48 |
*** jtriley has joined #openstack-horizon | 18:51 | |
matt-borland | doug-fish, I was unable to replicate the Launch Instance bug when relaunching "too quickly," but based on what you have, proposed a WIP bug fix. | 18:52 |
*** ducttape_ has quit IRC | 18:52 | |
*** belmoreira has joined #openstack-horizon | 18:52 | |
matt-borland | I have another scenario where this comes up, and I see a similar behavior (outside of Horizon/master) | 18:52 |
matt-borland | The possible fix is: https://review.openstack.org/#/c/290072/ | 18:53 |
*** wolverineav has joined #openstack-horizon | 18:53 | |
doug-fish | matt-borland: excellent! I'll try it out. FWIW ajmiller saw the same bug indpenantly and might have an environment where you could see it | 18:53 |
*** petertr7 is now known as petertr7_away | 18:53 | |
jpomeroy | robcresswell, yes it went in yesterday. thanks for you feedback by the way. | 18:53 |
*** xinwu has joined #openstack-horizon | 18:54 | |
robcresswell | jpomeroy: Ah, great. Was going to review it again if it was still around. Let me know if there's anything else I can help with. | 18:54 |
jpomeroy | will do, thanks | 18:54 |
*** petertr7_away is now known as petertr7 | 18:54 | |
matt-borland | doug-fish, I think I'm just not executing the re-creation properly, and/or the slowness of my system causes it not to occur. | 18:57 |
matt-borland | either way I can see a similar problem which I needed to fix anyway, from another patch. | 18:57 |
matt-borland | jpomeroy, I +1d that LBaaS Edit Pool patch | 18:58 |
*** david_cu has quit IRC | 18:59 | |
matt-borland | I just hadn't known the correct behavior | 18:59 |
*** neelashah has joined #openstack-horizon | 18:59 | |
*** doug-fis_ has joined #openstack-horizon | 18:59 | |
jpomeroy | matt-borland, thanks. the behavior is a bit unusual compared to most of horizon, so it is a but funny. | 18:59 |
matt-borland | I've been using the Material theme to test, and the LBaaS work looks reasonable with that theme. | 19:00 |
jpomeroy | oh good. we just yesterday merged updated styles to fall in line with where horizon is at now, based on robcresswell recent changes. | 19:01 |
jpomeroy | i haven't tried it with another theme though, good to hear it's not broken. i will have to do that. | 19:01 |
*** bapalm has quit IRC | 19:02 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 19:02 |
matt-borland | The Actions button on a details page (e.g. Pool detail) sort of hangs off the breadcrumb bar oddly, | 19:02 |
*** doug-fish has quit IRC | 19:02 | |
*** doug-fish has joined #openstack-horizon | 19:03 | |
*** ybathia has quit IRC | 19:03 | |
matt-borland | and the help panel closure looks a little odd, but not in any way that I think is substantively bad :) | 19:03 |
*** doug-fish has quit IRC | 19:03 | |
matt-borland | otherwise things look pretty good. | 19:03 |
*** doug-fish has joined #openstack-horizon | 19:03 | |
*** doug-fis_ has quit IRC | 19:04 | |
jpomeroy | matt-borland, going to try it with material theme now | 19:05 |
hurgleburgler | :-O | 19:05 |
matt-borland | Just use the menu to switch it! | 19:05 |
hurgleburgler | ٩(͡๏̮͡๏)۶ | 19:05 |
*** ducttape_ has joined #openstack-horizon | 19:05 | |
*** jbell8 has joined #openstack-horizon | 19:05 | |
*** vijendar has quit IRC | 19:06 | |
jpomeroy | oh sweet, i didn't realize that was implemented | 19:07 |
*** vijendar has joined #openstack-horizon | 19:07 | |
*** Qingqing has joined #openstack-horizon | 19:07 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 19:08 |
itxaka | How long until RC-1? | 19:10 |
itxaka | wop, found it, sorry :D | 19:11 |
itxaka | ouch netx week, this one does not seem plausible https://bugs.launchpad.net/horizon/+bug/1491997 robcresswell | 19:12 |
openstack | Launchpad bug 1491997 in OpenStack Dashboard (Horizon) "require keypair follow on for ng launch instance" [Medium,In progress] - Assigned to Eric Peterson (ericpeterson-l) | 19:12 |
*** kzaitsev_mb has quit IRC | 19:14 | |
*** Qingqing has quit IRC | 19:15 | |
robcresswell | itxaka: Looks like quite a small change | 19:15 |
itxaka | angular != small | 19:15 |
itxaka | :D :D | 19:15 |
robcresswell | I mean the setting already exists | 19:16 |
robcresswell | controller could just set a variable for that setting, html accesses it via ng-required. | 19:17 |
*** bapalm has joined #openstack-horizon | 19:19 | |
*** zul has quit IRC | 19:20 | |
matt-borland | yeah, I don't think it's a lot of code, but I'll have to take a look at it | 19:20 |
matt-borland | usually the "angular = large" is frankly just the tests...which is good :) | 19:21 |
robcresswell | Just realised its slightly different than I originally thought. but still an if on the setting, and validate-number-min to be 0 or 1 depending on the setting | 19:21 |
robcresswell | and a test, ofc. | 19:22 |
matt-borland | and docs! | 19:22 |
robcresswell | should already be documented | 19:22 |
itxaka | yeah, seems easier | 19:22 |
itxaka | already testing it to see if indeed its as it seems | 19:23 |
robcresswell | nice :D | 19:23 |
*** Drago has quit IRC | 19:23 | |
robcresswell | Making Horizon Drumpf again | 19:23 |
*** Drago has joined #openstack-horizon | 19:23 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Launch Instance https://review.openstack.org/289679 | 19:25 |
*** ankurgupta has joined #openstack-horizon | 19:26 | |
*** exploreshaifali has quit IRC | 19:33 | |
*** kzaitsev_mb has joined #openstack-horizon | 19:36 | |
*** zul has joined #openstack-horizon | 19:36 | |
*** lhcheng_ has joined #openstack-horizon | 19:37 | |
r1chardj0n3s | morning | 19:40 |
*** lhcheng has quit IRC | 19:41 | |
hurgleburgler | morning | 19:41 |
TravT | morning | 19:41 |
r1chardj0n3s | itxaka: I would like to help clean up eslint warnings; do you have patches in play so I can know what bits are already done? | 19:41 |
openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/289729 | 19:41 |
itxaka | r1chardj0n3s, nope, nothing yet, was waiting for the --max-warnings patch to get in before starting the cleanup | 19:41 |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 19:42 |
r1chardj0n3s | itxaka: ok, if you don't have anything in play I'll just start at the top or something | 19:42 |
r1chardj0n3s | also | 19:43 |
r1chardj0n3s | \o/ I win the pool here. I bet that no-one would respond to my [Horizon] email overnight. | 19:43 |
*** doug-fish has quit IRC | 19:45 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Fix property safety on magic search controller https://review.openstack.org/290072 | 19:45 |
*** doug-fish has joined #openstack-horizon | 19:45 | |
*** kzaitsev_mb has quit IRC | 19:48 | |
*** doug-fish has quit IRC | 19:50 | |
*** ducttape_ has quit IRC | 19:51 | |
*** ducttape_ has joined #openstack-horizon | 19:52 | |
*** vijendar has quit IRC | 19:55 | |
*** ediardo has quit IRC | 19:56 | |
*** zul has quit IRC | 19:58 | |
*** david_cu has joined #openstack-horizon | 20:00 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:01 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: WIP: Optionaly require keypair on ng-launch-instance https://review.openstack.org/243762 | 20:02 |
*** zul has joined #openstack-horizon | 20:02 | |
*** neelashah has quit IRC | 20:02 | |
*** petertr7 is now known as petertr7_away | 20:03 | |
*** Ephur has quit IRC | 20:03 | |
itxaka | matt-borland, would be really nice if you looked at that patch https://review.openstack.org/243762 so I can refine it in the morning while adding the test | 20:04 |
itxaka | thanks! | 20:04 |
*** david_cu has quit IRC | 20:04 | |
itxaka | and gooood nigth! The Division is calling me :D | 20:04 |
*** itxaka has quit IRC | 20:05 | |
*** neelashah has joined #openstack-horizon | 20:05 | |
*** petertr7_away is now known as petertr7 | 20:05 | |
*** vijendar has joined #openstack-horizon | 20:06 | |
*** gyee has quit IRC | 20:10 | |
*** david_cu has joined #openstack-horizon | 20:14 | |
*** gariveradlt has joined #openstack-horizon | 20:17 | |
*** piet has joined #openstack-horizon | 20:18 | |
*** aortega has quit IRC | 20:19 | |
*** aortega has joined #openstack-horizon | 20:22 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Policy should support AND and OR checks for panels https://review.openstack.org/175982 | 20:26 |
*** aortega has quit IRC | 20:29 | |
*** jbell8 has quit IRC | 20:29 | |
*** aortega has joined #openstack-horizon | 20:29 | |
*** aortega has quit IRC | 20:34 | |
*** ZZelle_ has joined #openstack-horizon | 20:35 | |
*** belmoreira has quit IRC | 20:37 | |
*** zul has quit IRC | 20:42 | |
*** ducttape_ has quit IRC | 20:42 | |
*** ducttape_ has joined #openstack-horizon | 20:44 | |
leitan | Guys, is there any way to dynamic manipulate the default_panel of a dashboard | 20:45 |
*** Daisy has joined #openstack-horizon | 20:46 | |
*** ediardo has joined #openstack-horizon | 20:46 | |
*** gariveradlt has quit IRC | 20:47 | |
*** sergio_ has joined #openstack-horizon | 20:49 | |
*** sergio_ is now known as Guest16535 | 20:49 | |
*** Daisy has quit IRC | 20:51 | |
*** ZZelle__ has joined #openstack-horizon | 20:51 | |
*** ZZelle__ has quit IRC | 20:51 | |
david-lyle | leitan: what do you mean by dynamic? | 20:54 |
*** zul has joined #openstack-horizon | 20:55 | |
*** aortega has joined #openstack-horizon | 20:55 | |
TravT | david-lyle r1chardj0n3s robcresswell if you have a minute, can you look at this one? | 20:56 |
TravT | https://review.openstack.org/#/c/286268/ | 20:56 |
r1chardj0n3s | TravT: I've spent the last day and a half trying to figure out a plan to ever be able to release xstatic packages again (hence the wall of text email yesterday) :-( | 20:56 |
*** ediardo has quit IRC | 20:56 | |
r1chardj0n3s | I expect to be doing the same thing today | 20:56 |
r1chardj0n3s | since I have several folks locked in a room with me | 20:57 |
TravT | ok. that seems pretty important! | 20:57 |
*** vijendar has quit IRC | 20:57 | |
david-lyle | you can alter the files in openstack_dashboard/enabled and set DEFAULT_PANEL=True on the desired panel https://github.com/openstack/horizon/blob/master/doc/source/topics/settings.rst#default_panel | 20:57 |
r1chardj0n3s | it also seems unsolvable :-( | 20:57 |
leitan | david-lyle, i mean that for example if i want to enable an installed app, and based on what its installed the default panel of a dashboard changes dynamically | 20:57 |
david-lyle | see ^^^ | 20:57 |
TravT | r1chardj0n3s: if you are saying that, then i'm scared... very, very scared | 20:57 |
r1chardj0n3s | well, that email lists all the flawed options we could think of | 20:58 |
*** bapalm has quit IRC | 20:58 | |
r1chardj0n3s | I'm hoping we haven't thought of something | 20:58 |
r1chardj0n3s | which is why the email | 20:59 |
TravT | okay, i saw it, but brain has been fairly occupied. | 20:59 |
r1chardj0n3s | yup | 20:59 |
TravT | i will try to absorb it... will be late today if not tomorrow. | 20:59 |
TravT | seems like mrunge might have some opinion here | 21:00 |
r1chardj0n3s | yup, I hope to walk through it in the meeting tomorrow | 21:00 |
leitan | david-lyle, i know, its the way that were doing it know, just wondering ifs theres a way to react to a settings.py variable to default panel X or panel Y | 21:00 |
r1chardj0n3s | Well, it's ultimately the OS packagers who are to blame. Oh and the people who want to be able to Continuous Deployment. Them too. | 21:00 |
r1chardj0n3s | But the combination of Continuous Deployement and One Big Installation (ie. no venvs) is what's killing us | 21:01 |
r1chardj0n3s | every single commit in OpenStack has to result in a completely working integrated system | 21:01 |
r1chardj0n3s | and we can't guarantee that with xstatic without doing something, and we just don't know what that something should be yet | 21:01 |
TravT | yeah, that seems to be the general idea... | 21:02 |
*** Mounica has quit IRC | 21:02 | |
david-lyle | leitan: those files in /enabled are python, you can put whatever python you want in there to decide if the value should be set | 21:02 |
r1chardj0n3s | hell we couldn't guarantee that with *heatclient* if you recall :/ | 21:02 |
r1chardj0n3s | but that was because Horizon doesn't currently use upper-constraints, which I have on my TODO | 21:02 |
TravT | fyi, gotta be in another call | 21:04 |
r1chardj0n3s | one thing I'm unsure of, which TravT or david-lyle might be able to help with, is the relationship between horizon plugins and horizon - do the plugins list all the xstatic packages they use, even if horizon already installs them? | 21:04 |
david-lyle | we can't guarantee it | 21:04 |
david-lyle | we don't properly test clients or horizon end to end | 21:04 |
david-lyle | and even if we could, we can guarantee that tests will pass and that's the best we'll ever be able to do | 21:04 |
*** ediardo has joined #openstack-horizon | 21:05 | |
*** xinwu has quit IRC | 21:06 | |
*** wolverineav has quit IRC | 21:06 | |
david-lyle | r1chardj0n3s: they should, but don't I believe | 21:06 |
david-lyle | assuming horizon pulls them in | 21:06 |
david-lyle | they should if they require something specific that is | 21:06 |
*** gariveradlt has joined #openstack-horizon | 21:06 | |
r1chardj0n3s | yeah. hmm | 21:06 |
* r1chardj0n3s disappears for a bit | 21:06 | |
*** jprovazn has quit IRC | 21:06 | |
*** wolverineav has joined #openstack-horizon | 21:06 | |
david-lyle | actually, sadly they don't even require horizon | 21:07 |
* david-lyle may be responsible for some of those | 21:07 | |
*** xenogear has joined #openstack-horizon | 21:09 | |
*** wolverineav has quit IRC | 21:10 | |
*** ducttape_ has quit IRC | 21:13 | |
*** ediardo has quit IRC | 21:14 | |
*** bapalm has joined #openstack-horizon | 21:14 | |
openstackgerrit | Merged openstack/horizon: Add missing column rxtx_factor to ng flavors table https://review.openstack.org/281494 | 21:14 |
*** ducttape_ has joined #openstack-horizon | 21:17 | |
r1chardj0n3s | david-lyle: yeah, if we could just say that Horizon was the only consumer of xstatic package upper-constraints (which is stupidly named, it should be called "pinned-constraints") then we could just put the constraints in Horizon repos and BOOM we can atomically update Horizon and its xstatic dependency versions and no breakage. Sadly... | 21:18 |
r1chardj0n3s | I'm starting to think that vendoring the xstatic packages (or all Horizon plugins) is the way to go | 21:18 |
r1chardj0n3s | </wink> | 21:19 |
*** jtomasek has quit IRC | 21:20 | |
*** wolverineav has joined #openstack-horizon | 21:21 | |
*** ediardo has joined #openstack-horizon | 21:23 | |
*** zul has quit IRC | 21:25 | |
*** neelashah has quit IRC | 21:26 | |
* david-lyle so sad | 21:31 | |
*** cloudtrainme has quit IRC | 21:31 | |
*** cloudtrainme has joined #openstack-horizon | 21:33 | |
leitan | david-lyle, that will do i guess, i can react there | 21:35 |
leitan | david-lyle, thanks | 21:36 |
*** lblanchard has quit IRC | 21:38 | |
*** jtriley has quit IRC | 21:38 | |
*** zul has joined #openstack-horizon | 21:39 | |
*** leitan has quit IRC | 21:41 | |
*** ediardo has quit IRC | 21:42 | |
*** tqtran has joined #openstack-horizon | 21:42 | |
*** lapalm has quit IRC | 21:49 | |
*** neelashah has joined #openstack-horizon | 21:50 | |
*** ediardo has joined #openstack-horizon | 21:53 | |
*** ducttape_ has quit IRC | 21:53 | |
*** xinwu has joined #openstack-horizon | 21:54 | |
*** ducttape_ has joined #openstack-horizon | 21:54 | |
*** TravT_ has joined #openstack-horizon | 21:55 | |
*** ducttape_ has quit IRC | 21:56 | |
*** ducttape_ has joined #openstack-horizon | 21:56 | |
*** TravT has quit IRC | 21:56 | |
*** Mounica has joined #openstack-horizon | 21:59 | |
*** pauloewerton has quit IRC | 22:02 | |
*** alexvictorchan has quit IRC | 22:08 | |
*** Mounica has quit IRC | 22:11 | |
*** ediardo has quit IRC | 22:12 | |
*** petertr7 is now known as petertr7_away | 22:12 | |
*** rhagarty_ has quit IRC | 22:25 | |
*** rhagarty_ has joined #openstack-horizon | 22:25 | |
*** rhagarty_ has quit IRC | 22:25 | |
*** rhagarty_ has joined #openstack-horizon | 22:25 | |
*** rhagarty_ has quit IRC | 22:26 | |
*** rhagarty_ has joined #openstack-horizon | 22:26 | |
*** rhagarty_ has quit IRC | 22:27 | |
*** rhagarty__ has joined #openstack-horizon | 22:27 | |
*** ducttape_ has quit IRC | 22:27 | |
*** rhagarty__ has quit IRC | 22:27 | |
*** rhagarty__ has joined #openstack-horizon | 22:27 | |
*** rhagarty__ has quit IRC | 22:27 | |
*** jpomeroy has quit IRC | 22:27 | |
*** rhagarty__ has joined #openstack-horizon | 22:28 | |
*** rhagarty__ has quit IRC | 22:28 | |
*** rhagarty__ has joined #openstack-horizon | 22:28 | |
*** rhagarty_ has joined #openstack-horizon | 22:29 | |
*** rhagarty__ has quit IRC | 22:29 | |
*** rhagarty_ has quit IRC | 22:29 | |
*** rhagarty__ has joined #openstack-horizon | 22:29 | |
*** jamielennox|away is now known as jamielennox | 22:29 | |
*** rhagarty__ has quit IRC | 22:30 | |
*** rhagarty__ has joined #openstack-horizon | 22:30 | |
*** rhagarty__ has quit IRC | 22:30 | |
*** rhagarty_ has joined #openstack-horizon | 22:30 | |
*** rhagarty_ has quit IRC | 22:31 | |
*** rhagarty__ has joined #openstack-horizon | 22:31 | |
*** rhagarty__ has quit IRC | 22:31 | |
*** rhagarty_ has joined #openstack-horizon | 22:31 | |
*** rhagarty_ has quit IRC | 22:32 | |
*** rhagarty__ has joined #openstack-horizon | 22:32 | |
*** ducttape_ has joined #openstack-horizon | 22:32 | |
*** rhagarty__ has quit IRC | 22:32 | |
*** rhagarty__ has joined #openstack-horizon | 22:32 | |
*** rhagarty__ has quit IRC | 22:32 | |
*** rhagarty__ has joined #openstack-horizon | 22:33 | |
*** rhagarty__ has quit IRC | 22:33 | |
*** rhagarty__ has joined #openstack-horizon | 22:33 | |
*** Mounica has joined #openstack-horizon | 22:34 | |
*** rhagarty__ has quit IRC | 22:34 | |
*** rhagarty_ has joined #openstack-horizon | 22:34 | |
*** rhagarty__ has joined #openstack-horizon | 22:34 | |
*** rhagarty_ has quit IRC | 22:34 | |
*** gariveradlt has quit IRC | 22:35 | |
*** rhagarty__ has quit IRC | 22:35 | |
*** rhagarty__ has joined #openstack-horizon | 22:35 | |
*** rhagarty__ has quit IRC | 22:35 | |
*** rhagarty_ has joined #openstack-horizon | 22:35 | |
*** rhagarty_ has quit IRC | 22:35 | |
*** rhagarty_ has joined #openstack-horizon | 22:36 | |
*** rhagarty__ has joined #openstack-horizon | 22:36 | |
*** rhagarty_ has quit IRC | 22:36 | |
*** rhagarty__ has quit IRC | 22:37 | |
*** rhagarty_ has joined #openstack-horizon | 22:37 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 22:37 |
*** ediardo has joined #openstack-horizon | 22:37 | |
*** rhagarty__ has joined #openstack-horizon | 22:37 | |
*** rhagarty_ has quit IRC | 22:37 | |
*** rhagarty__ has quit IRC | 22:38 | |
*** rhagarty__ has joined #openstack-horizon | 22:38 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 22:38 |
*** rhagarty__ has quit IRC | 22:38 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Launch Instance https://review.openstack.org/289679 | 22:38 |
*** rhagarty__ has joined #openstack-horizon | 22:38 | |
*** rhagarty__ has quit IRC | 22:38 | |
*** rhagarty__ has joined #openstack-horizon | 22:39 | |
*** rhagarty__ has quit IRC | 22:39 | |
*** rhagarty_ has joined #openstack-horizon | 22:39 | |
*** piet has quit IRC | 22:39 | |
*** rhagarty_ has quit IRC | 22:39 | |
*** rhagarty__ has joined #openstack-horizon | 22:39 | |
*** rhagarty__ has quit IRC | 22:40 | |
*** rhagarty_ has joined #openstack-horizon | 22:40 | |
*** piet has joined #openstack-horizon | 22:40 | |
*** rhagarty_ has quit IRC | 22:40 | |
*** rhagarty_ has joined #openstack-horizon | 22:40 | |
*** rhagarty__ has joined #openstack-horizon | 22:41 | |
*** rhagarty_ has quit IRC | 22:41 | |
*** rhagarty_ has joined #openstack-horizon | 22:41 | |
*** rhagarty__ has quit IRC | 22:41 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Cleaning code to remove eslint warnings from Launch Instance https://review.openstack.org/290041 | 22:42 |
*** rhagarty_ has quit IRC | 22:42 | |
*** rhagarty_ has joined #openstack-horizon | 22:42 | |
*** rhagarty__ has joined #openstack-horizon | 22:43 | |
*** rhagarty_ has quit IRC | 22:43 | |
*** rhagarty__ has quit IRC | 22:43 | |
*** rhagarty__ has joined #openstack-horizon | 22:43 | |
matt-borland | r1chardj0n3s, I've been working on cleaning up eslint warnings: | 22:43 |
matt-borland | in Image and Launch Instance | 22:43 |
matt-borland | just read back now | 22:43 |
*** rhagarty__ has quit IRC | 22:43 | |
*** rhagarty__ has joined #openstack-horizon | 22:44 | |
matt-borland | https://review.openstack.org/#/c/289570/ and https://review.openstack.org/#/c/290041/ | 22:44 |
*** rhagarty__ has quit IRC | 22:44 | |
*** rhagarty__ has joined #openstack-horizon | 22:44 | |
*** rhagarty__ has quit IRC | 22:44 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Launch Instance: Metadata should inherit from theme https://review.openstack.org/289093 | 22:44 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Branding: Workflow cancel btn should be themable https://review.openstack.org/286313 | 22:44 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Branding: Create Network should inherit from theme https://review.openstack.org/289067 | 22:44 |
*** rhagarty__ has joined #openstack-horizon | 22:44 | |
*** rhagarty__ has quit IRC | 22:45 | |
*** rhagarty__ has joined #openstack-horizon | 22:45 | |
*** ducttape_ has quit IRC | 22:45 | |
*** rhagarty__ has quit IRC | 22:45 | |
*** rhagarty__ has joined #openstack-horizon | 22:45 | |
*** rhagarty_ has joined #openstack-horizon | 22:46 | |
*** rhagarty__ has quit IRC | 22:46 | |
*** rhagarty_ has quit IRC | 22:46 | |
*** rhagarty_ has joined #openstack-horizon | 22:46 | |
matt-borland | r1chardj0n3s, I suggested in those patches that we use "requireParamDescription: false" | 22:46 |
*** rhagarty__ has joined #openstack-horizon | 22:47 | |
*** rhagarty_ has quit IRC | 22:47 | |
*** rhagarty_ has joined #openstack-horizon | 22:47 | |
*** rhagarty__ has quit IRC | 22:47 | |
*** rhagarty__ has joined #openstack-horizon | 22:48 | |
*** rhagarty_ has quit IRC | 22:48 | |
*** rhagarty__ has quit IRC | 22:48 | |
*** rhagarty__ has joined #openstack-horizon | 22:48 | |
*** rhagarty_ has joined #openstack-horizon | 22:49 | |
*** rhagarty__ has quit IRC | 22:49 | |
*** rhagarty__ has joined #openstack-horizon | 22:49 | |
*** rhagarty_ has quit IRC | 22:49 | |
*** rhagarty_ has joined #openstack-horizon | 22:50 | |
*** rhagarty__ has quit IRC | 22:50 | |
*** ducttape_ has joined #openstack-horizon | 22:50 | |
*** rhagarty_ has quit IRC | 22:50 | |
*** ducttape_ has quit IRC | 22:50 | |
*** rhagarty_ has joined #openstack-horizon | 22:51 | |
*** rhagarty_ has quit IRC | 22:51 | |
r1chardj0n3s | matt-borland: ok, cool. I will avoid the code in those patches (and read them for that thing) | 22:51 |
*** rhagarty_ has joined #openstack-horizon | 22:51 | |
*** ducttape_ has joined #openstack-horizon | 22:51 | |
*** rhagarty_ has quit IRC | 22:51 | |
*** ducttape_ has quit IRC | 22:51 | |
*** rhagarty_ has joined #openstack-horizon | 22:51 | |
*** rhagarty_ has quit IRC | 22:52 | |
*** rhagarty_ has joined #openstack-horizon | 22:52 | |
*** rhagarty__ has joined #openstack-horizon | 22:52 | |
*** rhagarty_ has quit IRC | 22:52 | |
*** rhagarty_ has joined #openstack-horizon | 22:53 | |
*** rhagarty__ has quit IRC | 22:53 | |
*** ducttape_ has joined #openstack-horizon | 22:53 | |
*** rhagarty_ has quit IRC | 22:53 | |
*** ducttape_ has quit IRC | 22:53 | |
*** rhagarty__ has joined #openstack-horizon | 22:53 | |
*** rhagarty__ has quit IRC | 22:54 | |
*** rhagarty__ has joined #openstack-horizon | 22:54 | |
*** rhagarty_ has joined #openstack-horizon | 22:55 | |
*** rhagarty__ has quit IRC | 22:55 | |
*** ducttape_ has joined #openstack-horizon | 22:55 | |
*** rhagarty__ has joined #openstack-horizon | 22:55 | |
*** rhagarty_ has quit IRC | 22:55 | |
*** rhagarty__ has quit IRC | 22:55 | |
*** rhagarty__ has joined #openstack-horizon | 22:56 | |
*** rhagarty__ has quit IRC | 22:56 | |
*** rhagarty__ has joined #openstack-horizon | 22:56 | |
*** rhagarty_ has joined #openstack-horizon | 22:57 | |
*** rhagarty__ has quit IRC | 22:57 | |
*** rhagarty_ has quit IRC | 22:57 | |
*** rhagarty_ has joined #openstack-horizon | 22:57 | |
*** rhagarty__ has joined #openstack-horizon | 22:58 | |
*** rhagarty_ has quit IRC | 22:58 | |
*** rhagarty__ has quit IRC | 22:58 | |
*** rhagarty_ has joined #openstack-horizon | 22:58 | |
*** rhagarty_ has quit IRC | 22:58 | |
*** rhagarty_ has joined #openstack-horizon | 22:59 | |
*** alexvictorchan has joined #openstack-horizon | 22:59 | |
*** rhagarty_ has quit IRC | 22:59 | |
*** rhagarty_ has joined #openstack-horizon | 22:59 | |
*** rhagarty_ has quit IRC | 23:00 | |
*** rhagarty__ has joined #openstack-horizon | 23:00 | |
*** rhagarty__ has quit IRC | 23:00 | |
*** rhagarty__ has joined #openstack-horizon | 23:00 | |
*** rhagarty__ has quit IRC | 23:00 | |
*** rhagarty__ has joined #openstack-horizon | 23:01 | |
*** rhagarty_ has joined #openstack-horizon | 23:01 | |
*** rhagarty__ has quit IRC | 23:01 | |
*** rhagarty_ has quit IRC | 23:02 | |
*** rhagarty_ has joined #openstack-horizon | 23:02 | |
*** rhagarty_ has quit IRC | 23:02 | |
*** rhagarty_ has joined #openstack-horizon | 23:02 | |
*** rhagarty_ has quit IRC | 23:03 | |
*** rhagarty_ has joined #openstack-horizon | 23:03 | |
*** rhagarty_ has quit IRC | 23:03 | |
*** david_cu has quit IRC | 23:03 | |
*** rhagarty_ has joined #openstack-horizon | 23:03 | |
*** rhagarty_ has quit IRC | 23:04 | |
*** rhagarty__ has joined #openstack-horizon | 23:04 | |
*** rhagarty__ has quit IRC | 23:04 | |
*** rhagarty__ has joined #openstack-horizon | 23:04 | |
*** rhagarty__ has quit IRC | 23:05 | |
*** ediardo has quit IRC | 23:05 | |
*** rhagarty__ has joined #openstack-horizon | 23:05 | |
*** rhagarty__ has quit IRC | 23:06 | |
*** rhagarty__ has joined #openstack-horizon | 23:06 | |
*** rhagarty__ has quit IRC | 23:06 | |
*** rhagarty__ has joined #openstack-horizon | 23:06 | |
*** rhagarty_ has joined #openstack-horizon | 23:07 | |
*** rhagarty__ has quit IRC | 23:07 | |
*** rhagarty_ has quit IRC | 23:07 | |
*** rhagarty_ has joined #openstack-horizon | 23:07 | |
*** rhagarty_ has quit IRC | 23:08 | |
*** rhagarty__ has joined #openstack-horizon | 23:08 | |
*** rhagarty_ has joined #openstack-horizon | 23:08 | |
*** rhagarty__ has quit IRC | 23:08 | |
*** rhagarty__ has joined #openstack-horizon | 23:09 | |
*** rhagarty_ has quit IRC | 23:09 | |
*** cloudtrainme has quit IRC | 23:09 | |
*** rhagarty__ has quit IRC | 23:09 | |
*** rhagarty__ has joined #openstack-horizon | 23:09 | |
*** rhagarty__ has quit IRC | 23:10 | |
*** rhagarty__ has joined #openstack-horizon | 23:10 | |
*** rhagarty__ has quit IRC | 23:10 | |
*** rhagarty__ has joined #openstack-horizon | 23:10 | |
*** rhagarty__ has quit IRC | 23:11 | |
*** rhagarty__ has joined #openstack-horizon | 23:11 | |
*** rhagarty__ has quit IRC | 23:11 | |
*** rhagarty__ has joined #openstack-horizon | 23:11 | |
*** rhagarty__ has quit IRC | 23:11 | |
*** rhagarty__ has joined #openstack-horizon | 23:12 | |
*** rhagarty__ has quit IRC | 23:12 | |
*** rhagarty__ has joined #openstack-horizon | 23:12 | |
*** rhagarty_ has joined #openstack-horizon | 23:13 | |
*** rhagarty__ has quit IRC | 23:13 | |
*** rhagarty__ has joined #openstack-horizon | 23:13 | |
*** rhagarty_ has quit IRC | 23:13 | |
*** rhagarty__ has quit IRC | 23:13 | |
*** rhagarty__ has joined #openstack-horizon | 23:14 | |
*** rhagarty_ has joined #openstack-horizon | 23:14 | |
*** rhagarty__ has quit IRC | 23:14 | |
*** rhagarty_ has quit IRC | 23:15 | |
*** rhagarty_ has joined #openstack-horizon | 23:15 | |
*** rhagarty_ has quit IRC | 23:15 | |
*** rhagarty_ has joined #openstack-horizon | 23:15 | |
*** rhagarty_ has quit IRC | 23:16 | |
*** rhagarty_ has joined #openstack-horizon | 23:16 | |
*** rhagarty__ has joined #openstack-horizon | 23:16 | |
*** rhagarty_ has quit IRC | 23:16 | |
*** rhagarty_ has joined #openstack-horizon | 23:17 | |
*** rhagarty__ has quit IRC | 23:17 | |
*** rhagarty__ has joined #openstack-horizon | 23:17 | |
*** rhagarty_ has quit IRC | 23:17 | |
openstackgerrit | Dan Nguyen proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 23:17 |
*** rhagarty__ has quit IRC | 23:18 | |
*** rhagarty__ has joined #openstack-horizon | 23:18 | |
*** rhagarty__ has quit IRC | 23:18 | |
*** rhagarty_ has joined #openstack-horizon | 23:18 | |
*** rhagarty__ has joined #openstack-horizon | 23:19 | |
*** rhagarty_ has quit IRC | 23:19 | |
*** rhagarty_ has joined #openstack-horizon | 23:19 | |
*** rhagarty__ has quit IRC | 23:19 | |
*** rhagarty_ has quit IRC | 23:20 | |
*** rhagarty_ has joined #openstack-horizon | 23:20 | |
*** rhagarty_ has quit IRC | 23:20 | |
*** rhagarty_ has joined #openstack-horizon | 23:20 | |
*** rhagarty_ has quit IRC | 23:21 | |
*** rhagarty__ has joined #openstack-horizon | 23:21 | |
*** rhagarty__ has quit IRC | 23:21 | |
*** rhagarty__ has joined #openstack-horizon | 23:21 | |
*** rhagarty__ has quit IRC | 23:22 | |
*** rhagarty_ has joined #openstack-horizon | 23:22 | |
*** kzaitsev_mb has quit IRC | 23:22 | |
*** rhagarty_ has quit IRC | 23:22 | |
*** garthb has joined #openstack-horizon | 23:22 | |
*** rhagarty_ has joined #openstack-horizon | 23:22 | |
*** peristeri has quit IRC | 23:22 | |
*** rhagarty__ has joined #openstack-horizon | 23:23 | |
*** rhagarty_ has quit IRC | 23:23 | |
*** neelashah has quit IRC | 23:23 | |
*** rhagarty__ has quit IRC | 23:23 | |
*** rhagarty__ has joined #openstack-horizon | 23:23 | |
*** rhagarty_ has joined #openstack-horizon | 23:24 | |
*** rhagarty__ has quit IRC | 23:24 | |
*** rhagarty_ has quit IRC | 23:24 | |
*** rhagarty_ has joined #openstack-horizon | 23:24 | |
*** rhagarty_ has quit IRC | 23:25 | |
*** rhagarty_ has joined #openstack-horizon | 23:25 | |
*** rhagarty_ has quit IRC | 23:25 | |
*** rhagarty_ has joined #openstack-horizon | 23:25 | |
*** rhagarty_ has quit IRC | 23:25 | |
*** rhagarty_ has joined #openstack-horizon | 23:26 | |
*** rhagarty_ has quit IRC | 23:26 | |
*** rhagarty_ has joined #openstack-horizon | 23:26 | |
*** rhagarty_ has quit IRC | 23:26 | |
*** rhagarty_ has joined #openstack-horizon | 23:27 | |
*** rhagarty__ has joined #openstack-horizon | 23:27 | |
*** rhagarty_ has quit IRC | 23:27 | |
*** rhagarty__ has quit IRC | 23:27 | |
*** rhagarty__ has joined #openstack-horizon | 23:28 | |
*** rhagarty__ has quit IRC | 23:28 | |
*** rhagarty__ has joined #openstack-horizon | 23:28 | |
*** rhagarty_ has joined #openstack-horizon | 23:28 | |
*** rhagarty__ has quit IRC | 23:28 | |
*** rhagarty_ has quit IRC | 23:29 | |
*** rhagarty_ has joined #openstack-horizon | 23:29 | |
*** rhagarty__ has joined #openstack-horizon | 23:30 | |
*** rhagarty_ has quit IRC | 23:30 | |
*** rhagarty__ has quit IRC | 23:30 | |
*** rhagarty__ has joined #openstack-horizon | 23:30 | |
*** rhagarty__ has quit IRC | 23:31 | |
*** rhagarty_ has joined #openstack-horizon | 23:31 | |
*** rhagarty_ has quit IRC | 23:31 | |
*** rhagarty_ has joined #openstack-horizon | 23:31 | |
*** rhagarty_ has quit IRC | 23:32 | |
*** rhagarty_ has joined #openstack-horizon | 23:32 | |
*** rhagarty_ has quit IRC | 23:32 | |
*** rhagarty_ has joined #openstack-horizon | 23:32 | |
*** rhagarty_ has quit IRC | 23:32 | |
*** rhagarty_ has joined #openstack-horizon | 23:33 | |
*** sjmc7 has quit IRC | 23:33 | |
*** rhagarty_ has quit IRC | 23:33 | |
*** rhagarty_ has joined #openstack-horizon | 23:33 | |
*** rhagarty__ has joined #openstack-horizon | 23:34 | |
*** rhagarty_ has quit IRC | 23:34 | |
*** Drago has quit IRC | 23:34 | |
*** rhagarty__ has quit IRC | 23:34 | |
*** rhagarty__ has joined #openstack-horizon | 23:34 | |
*** rhagarty__ has quit IRC | 23:34 | |
*** rhagarty__ has joined #openstack-horizon | 23:35 | |
*** rhagarty__ has quit IRC | 23:35 | |
*** rhagarty__ has joined #openstack-horizon | 23:35 | |
*** rhagarty__ has quit IRC | 23:35 | |
*** rhagarty__ has joined #openstack-horizon | 23:36 | |
*** rhagarty__ has quit IRC | 23:36 | |
*** rhagarty__ has joined #openstack-horizon | 23:36 | |
*** rhagarty__ has quit IRC | 23:36 | |
*** rhagarty_ has joined #openstack-horizon | 23:36 | |
*** rhagarty__ has joined #openstack-horizon | 23:37 | |
*** rhagarty_ has quit IRC | 23:37 | |
*** rhagarty__ has quit IRC | 23:37 | |
*** rhagarty__ has joined #openstack-horizon | 23:38 | |
*** rhagarty__ has quit IRC | 23:38 | |
*** rhagarty__ has joined #openstack-horizon | 23:38 | |
*** matt-borland has quit IRC | 23:38 | |
*** rhagarty__ has quit IRC | 23:38 | |
*** rhagarty__ has joined #openstack-horizon | 23:38 | |
*** rhagarty__ has quit IRC | 23:39 | |
*** rhagarty_ has joined #openstack-horizon | 23:39 | |
*** rhagarty_ has quit IRC | 23:39 | |
*** rhagarty_ has joined #openstack-horizon | 23:39 | |
*** rhagarty_ has quit IRC | 23:40 | |
*** rhagarty_ has joined #openstack-horizon | 23:40 | |
*** amotoki has quit IRC | 23:40 | |
*** rhagarty_ has quit IRC | 23:40 | |
*** rhagarty_ has joined #openstack-horizon | 23:40 | |
*** rhagarty__ has joined #openstack-horizon | 23:41 | |
*** rhagarty_ has quit IRC | 23:41 | |
*** rhagarty_ has joined #openstack-horizon | 23:41 | |
*** rhagarty__ has quit IRC | 23:41 | |
*** rhagarty_ has quit IRC | 23:42 | |
*** rhagarty_ has joined #openstack-horizon | 23:42 | |
*** rhagarty__ has joined #openstack-horizon | 23:42 | |
*** rhagarty_ has quit IRC | 23:43 | |
*** rhagarty__ has quit IRC | 23:43 | |
*** rhagarty__ has joined #openstack-horizon | 23:43 | |
*** rhagarty_ has joined #openstack-horizon | 23:44 | |
*** rhagarty__ has quit IRC | 23:44 | |
*** rhagarty_ has quit IRC | 23:44 | |
*** rhagarty__ has joined #openstack-horizon | 23:44 | |
*** rhagarty__ has quit IRC | 23:44 | |
*** rhagarty__ has joined #openstack-horizon | 23:45 | |
*** rhagarty_ has joined #openstack-horizon | 23:45 | |
*** rhagarty__ has quit IRC | 23:45 | |
*** rhagarty__ has joined #openstack-horizon | 23:46 | |
*** rhagarty_ has quit IRC | 23:46 | |
*** rhagarty__ has quit IRC | 23:46 | |
*** rhagarty__ has joined #openstack-horizon | 23:46 | |
*** rhagarty__ has quit IRC | 23:46 | |
*** rhagarty__ has joined #openstack-horizon | 23:47 | |
*** rhagarty__ has quit IRC | 23:47 | |
*** rhagarty__ has joined #openstack-horizon | 23:47 | |
*** ducttape_ has quit IRC | 23:47 | |
*** rhagarty__ has quit IRC | 23:47 | |
*** rhagarty__ has joined #openstack-horizon | 23:48 | |
*** rhagarty__ has quit IRC | 23:48 | |
*** rhagarty__ has joined #openstack-horizon | 23:48 | |
*** rhagarty_ has joined #openstack-horizon | 23:49 | |
*** rhagarty__ has quit IRC | 23:49 | |
*** rhagarty_ has quit IRC | 23:49 | |
*** rhagarty_ has joined #openstack-horizon | 23:49 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Document additional release process for xstatic https://review.openstack.org/289142 | 23:50 |
*** rhagarty__ has joined #openstack-horizon | 23:50 | |
*** rhagarty_ has quit IRC | 23:50 | |
*** rhagarty__ has quit IRC | 23:51 | |
*** rhagarty__ has joined #openstack-horizon | 23:51 | |
*** rhagarty__ has quit IRC | 23:51 | |
*** rhagarty__ has joined #openstack-horizon | 23:51 | |
*** rhagarty__ has quit IRC | 23:52 | |
*** rhagarty__ has joined #openstack-horizon | 23:52 | |
*** rhagarty_ has joined #openstack-horizon | 23:52 | |
*** rhagarty__ has quit IRC | 23:52 | |
*** rhagarty_ has quit IRC | 23:53 | |
*** rhagarty_ has joined #openstack-horizon | 23:53 | |
*** rhagarty_ has quit IRC | 23:53 | |
*** rhagarty_ has joined #openstack-horizon | 23:53 | |
*** rhagarty_ has quit IRC | 23:54 | |
*** rhagarty_ has joined #openstack-horizon | 23:54 | |
*** rhagarty_ has quit IRC | 23:54 | |
*** rhagarty_ has joined #openstack-horizon | 23:54 | |
*** rhagarty__ has joined #openstack-horizon | 23:55 | |
*** rhagarty_ has quit IRC | 23:55 | |
*** rhagarty_ has joined #openstack-horizon | 23:55 | |
*** rhagarty__ has quit IRC | 23:55 | |
*** rhagarty__ has joined #openstack-horizon | 23:56 | |
*** rhagarty_ has quit IRC | 23:56 | |
*** rhagarty__ has quit IRC | 23:57 | |
*** absubram has quit IRC | 23:57 | |
*** rhagarty_ has joined #openstack-horizon | 23:57 | |
*** rhagarty_ has quit IRC | 23:57 | |
*** rhagarty_ has joined #openstack-horizon | 23:57 | |
*** rhagarty_ has quit IRC | 23:57 | |
*** rhagarty_ has joined #openstack-horizon | 23:57 | |
*** rhagarty__ has joined #openstack-horizon | 23:58 | |
*** rhagarty_ has quit IRC | 23:58 | |
*** rhagarty_ has joined #openstack-horizon | 23:58 | |
*** rhagarty__ has quit IRC | 23:58 | |
*** rhagarty__ has joined #openstack-horizon | 23:59 | |
*** rhagarty_ has quit IRC | 23:59 | |
*** rhagarty__ has quit IRC | 23:59 | |
*** rhagarty__ has joined #openstack-horizon | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!