| *** rhagarty__ has quit IRC | 00:00 | |
| *** rhagarty__ has joined #openstack-horizon | 00:00 | |
| *** rhagarty__ has quit IRC | 00:00 | |
| *** k-ishii has quit IRC | 00:00 | |
| *** rhagarty__ has joined #openstack-horizon | 00:00 | |
| *** piet has quit IRC | 00:01 | |
| *** rhagarty__ has quit IRC | 00:01 | |
| *** rhagarty__ has joined #openstack-horizon | 00:01 | |
| *** k-ishii has joined #openstack-horizon | 00:01 | |
| *** rhagarty__ has quit IRC | 00:01 | |
| *** rhagarty__ has joined #openstack-horizon | 00:01 | |
| *** rhagarty__ has quit IRC | 00:02 | |
| *** rhagarty_ has joined #openstack-horizon | 00:02 | |
| *** rhagarty_ has quit IRC | 00:02 | |
| *** rhagarty_ has joined #openstack-horizon | 00:02 | |
| *** rhagarty_ has quit IRC | 00:03 | |
| *** rhagarty_ has joined #openstack-horizon | 00:03 | |
| *** rhagarty_ has quit IRC | 00:03 | |
| *** rhagarty_ has joined #openstack-horizon | 00:03 | |
| *** rhagarty_ has quit IRC | 00:04 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Launch Instance https://review.openstack.org/289679 | 00:04 |
|---|---|---|
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Volumes https://review.openstack.org/263817 | 00:04 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Table Actions https://review.openstack.org/289525 | 00:04 |
| *** rhagarty_ has joined #openstack-horizon | 00:04 | |
| *** rhagarty_ has quit IRC | 00:04 | |
| *** rhagarty_ has joined #openstack-horizon | 00:04 | |
| *** rhagarty_ has quit IRC | 00:05 | |
| *** rhagarty_ has joined #openstack-horizon | 00:05 | |
| *** rhagarty_ has quit IRC | 00:05 | |
| *** rhagarty_ has joined #openstack-horizon | 00:05 | |
| *** rhagarty_ has quit IRC | 00:06 | |
| *** rhagarty_ has joined #openstack-horizon | 00:06 | |
| *** rhagarty_ has quit IRC | 00:06 | |
| *** rhagarty_ has joined #openstack-horizon | 00:06 | |
| *** rhagarty__ has joined #openstack-horizon | 00:07 | |
| *** rhagarty_ has quit IRC | 00:07 | |
| *** rhagarty__ has quit IRC | 00:07 | |
| *** rhagarty__ has joined #openstack-horizon | 00:07 | |
| *** rhagarty__ has quit IRC | 00:08 | |
| *** gyee has joined #openstack-horizon | 00:10 | |
| *** gyee has quit IRC | 00:11 | |
| *** doug-fish has joined #openstack-horizon | 00:11 | |
| *** xenogear has quit IRC | 00:13 | |
| *** gyee has joined #openstack-horizon | 00:15 | |
| *** jtriley has joined #openstack-horizon | 00:15 | |
| *** jtriley has quit IRC | 00:22 | |
| *** eroussel has joined #openstack-horizon | 00:29 | |
| *** eroussel has quit IRC | 00:29 | |
| *** zzxwill has joined #openstack-horizon | 00:30 | |
| *** zzxwill has quit IRC | 00:30 | |
| *** zzxwill has joined #openstack-horizon | 00:31 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Use upper-constraints in tox test environments https://review.openstack.org/290203 | 00:34 |
| *** tosky has quit IRC | 00:34 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Admin Hypervisors https://review.openstack.org/290204 | 00:35 |
| *** bapalm has quit IRC | 00:37 | |
| *** Guest16535 has quit IRC | 00:41 | |
| *** zzxwill has quit IRC | 00:42 | |
| *** zzxwill has joined #openstack-horizon | 00:43 | |
| *** zzxwill has quit IRC | 00:52 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: Admin Panels https://review.openstack.org/290204 | 00:53 |
| *** jtriley has joined #openstack-horizon | 00:54 | |
| *** bapalm has joined #openstack-horizon | 00:54 | |
| *** harlowja has quit IRC | 00:55 | |
| *** zzxwill has joined #openstack-horizon | 00:56 | |
| *** mtanino has quit IRC | 01:02 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Cleaning up lint warnings for Image work https://review.openstack.org/289570 | 01:03 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Cleaning code to remove eslint warnings from Launch Instance https://review.openstack.org/290041 | 01:03 |
| *** zzxwill has quit IRC | 01:04 | |
| *** zzxwill has joined #openstack-horizon | 01:11 | |
| *** ZZelle_ has quit IRC | 01:16 | |
| *** ducttape_ has joined #openstack-horizon | 01:24 | |
| *** zzxwill has quit IRC | 01:25 | |
| *** clu_ has quit IRC | 01:27 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: WIP Searchlight Search Panel https://review.openstack.org/227036 | 01:35 |
| *** mpavlase has quit IRC | 01:38 | |
| *** Mounica has quit IRC | 01:44 | |
| *** ducttape_ has quit IRC | 01:52 | |
| *** mtanino has joined #openstack-horizon | 01:53 | |
| *** cloudtrainme has joined #openstack-horizon | 01:55 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP Images Actions Return Promises https://review.openstack.org/290225 | 01:55 |
| *** ducttape_ has joined #openstack-horizon | 01:57 | |
| *** lhcheng_ has quit IRC | 01:58 | |
| *** bpokorny has quit IRC | 02:02 | |
| *** wangbo has joined #openstack-horizon | 02:04 | |
| *** yamamoto_ has joined #openstack-horizon | 02:06 | |
| openstackgerrit | Merged openstack/horizon: Fixed a few missed translation strings on Theme preview page https://review.openstack.org/271453 | 02:08 |
| *** zzxwill has joined #openstack-horizon | 02:09 | |
| *** reedip_away is now known as reedip | 02:09 | |
| *** zzxwill has quit IRC | 02:12 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Turn off JSDoc linting https://review.openstack.org/290235 | 02:13 |
| *** pushkaru has quit IRC | 02:14 | |
| *** ducttape_ has quit IRC | 02:15 | |
| *** dsneddon has quit IRC | 02:18 | |
| *** doug-fish has quit IRC | 02:19 | |
| *** doug-fish has joined #openstack-horizon | 02:19 | |
| *** doug-fis_ has joined #openstack-horizon | 02:23 | |
| *** doug-fish has quit IRC | 02:24 | |
| *** jtriley has quit IRC | 02:25 | |
| *** doug-fis_ has quit IRC | 02:27 | |
| *** lhcheng has joined #openstack-horizon | 02:28 | |
| *** doug-fish has joined #openstack-horizon | 02:29 | |
| *** john51 has quit IRC | 02:31 | |
| *** john51 has joined #openstack-horizon | 02:33 | |
| *** doug-fish has quit IRC | 02:35 | |
| *** zzxwill has joined #openstack-horizon | 02:35 | |
| *** dan_nguyen has quit IRC | 02:39 | |
| *** shu-mutou-AFK is now known as shu-mutou | 02:40 | |
| *** doug-fish has joined #openstack-horizon | 02:40 | |
| *** Drago1 has joined #openstack-horizon | 02:43 | |
| *** Drago1 has quit IRC | 02:43 | |
| *** Drago1 has joined #openstack-horizon | 02:44 | |
| *** doug-fish has quit IRC | 02:45 | |
| *** jtriley has joined #openstack-horizon | 02:47 | |
| *** doug-fish has joined #openstack-horizon | 02:50 | |
| *** zzxwill has quit IRC | 02:53 | |
| *** doug-fish has quit IRC | 02:55 | |
| *** yamamoto_ has quit IRC | 02:56 | |
| *** itisha has quit IRC | 02:59 | |
| *** tqtran has quit IRC | 03:00 | |
| *** gyee has quit IRC | 03:02 | |
| *** lhcheng has quit IRC | 03:24 | |
| *** ducttape_ has joined #openstack-horizon | 03:25 | |
| *** wolverineav has quit IRC | 03:32 | |
| *** xenogear has joined #openstack-horizon | 03:36 | |
| *** yamamoto_ has joined #openstack-horizon | 03:39 | |
| *** xinwu has quit IRC | 03:39 | |
| *** fedexo has joined #openstack-horizon | 03:40 | |
| *** Drago1 has quit IRC | 03:42 | |
| *** jtriley has quit IRC | 03:43 | |
| *** jtriley has joined #openstack-horizon | 03:43 | |
| *** cloudtrainme has quit IRC | 03:43 | |
| *** jtriley has quit IRC | 03:44 | |
| *** cloudtrainme has joined #openstack-horizon | 03:44 | |
| *** cloudtrainme has quit IRC | 03:49 | |
| *** xenogear has quit IRC | 03:49 | |
| *** garthb has quit IRC | 03:52 | |
| *** jamielennox is now known as jamielennox|away | 03:54 | |
| *** ducttape_ has quit IRC | 03:55 | |
| *** wolverineav has joined #openstack-horizon | 03:57 | |
| *** wolverineav has quit IRC | 03:58 | |
| *** wolverineav has joined #openstack-horizon | 03:59 | |
| *** wolverineav has quit IRC | 04:02 | |
| *** wolverineav has joined #openstack-horizon | 04:02 | |
| *** masco has joined #openstack-horizon | 04:09 | |
| *** ducttape_ has joined #openstack-horizon | 04:10 | |
| *** neelashah has joined #openstack-horizon | 04:18 | |
| *** xinwu has joined #openstack-horizon | 04:19 | |
| *** sayalilunkad has quit IRC | 04:22 | |
| *** wangbo has quit IRC | 04:23 | |
| *** sayalilunkad has joined #openstack-horizon | 04:34 | |
| *** xinwu has quit IRC | 04:34 | |
| *** ducttape_ has quit IRC | 04:40 | |
| *** neelashah has quit IRC | 04:41 | |
| *** Drago has joined #openstack-horizon | 04:45 | |
| *** Drago has quit IRC | 04:46 | |
| *** Drago has joined #openstack-horizon | 04:46 | |
| *** fifieldt has joined #openstack-horizon | 04:47 | |
| *** zzxwill has joined #openstack-horizon | 04:48 | |
| *** sayalilunkad has quit IRC | 04:50 | |
| *** sayalilunkad has joined #openstack-horizon | 04:51 | |
| *** zzxwill has quit IRC | 04:52 | |
| *** zzxwill has joined #openstack-horizon | 05:01 | |
| *** zzxwill has quit IRC | 05:18 | |
| *** zzxwill has joined #openstack-horizon | 05:26 | |
| *** xinwu has joined #openstack-horizon | 05:29 | |
| *** lhcheng_ has joined #openstack-horizon | 05:34 | |
| *** wolverineav has quit IRC | 05:37 | |
| openstackgerrit | Merged openstack/horizon: Added test for check QoS Spec creation and deletion functionality https://review.openstack.org/267361 | 05:38 |
| *** zzxwill_ has joined #openstack-horizon | 05:42 | |
| *** zzxwill has quit IRC | 05:42 | |
| *** zzxwill_ has quit IRC | 05:44 | |
| *** zzxwill has joined #openstack-horizon | 05:46 | |
| *** wolverineav has joined #openstack-horizon | 05:48 | |
| *** k-ishii has quit IRC | 05:53 | |
| *** zzxwill has quit IRC | 05:53 | |
| *** garthb has joined #openstack-horizon | 05:59 | |
| *** zzxwill has joined #openstack-horizon | 06:00 | |
| *** garthb has quit IRC | 06:06 | |
| *** rcernin has joined #openstack-horizon | 06:09 | |
| *** zzxwill has quit IRC | 06:10 | |
| *** wangbo has joined #openstack-horizon | 06:12 | |
| *** zzxwill has joined #openstack-horizon | 06:12 | |
| *** k-ishii has joined #openstack-horizon | 06:13 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/290290 | 06:15 |
| *** k-ishii has quit IRC | 06:19 | |
| *** jtomasek has joined #openstack-horizon | 06:20 | |
| *** k-ishii has joined #openstack-horizon | 06:21 | |
| *** lhcheng has joined #openstack-horizon | 06:23 | |
| *** zzxwill has quit IRC | 06:23 | |
| *** amotoki has joined #openstack-horizon | 06:25 | |
| *** exploreshaifali has joined #openstack-horizon | 06:26 | |
| *** lhcheng_ has quit IRC | 06:26 | |
| *** zzxwill has joined #openstack-horizon | 06:31 | |
| *** k-ishii has quit IRC | 06:32 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Zanata https://review.openstack.org/288851 | 06:33 |
| *** fedexo has quit IRC | 06:41 | |
| *** vishwanathj has quit IRC | 06:49 | |
| *** vishwanathj has joined #openstack-horizon | 06:51 | |
| *** chlong has quit IRC | 06:54 | |
| *** zzxwill has quit IRC | 06:54 | |
| *** zzxwill has joined #openstack-horizon | 06:57 | |
| *** chlong has joined #openstack-horizon | 07:08 | |
| *** vishwana_ has joined #openstack-horizon | 07:10 | |
| *** vishwanathj has quit IRC | 07:13 | |
| *** zzxwill has quit IRC | 07:13 | |
| *** zzxwill has joined #openstack-horizon | 07:14 | |
| *** wangbo has quit IRC | 07:15 | |
| *** aortega has quit IRC | 07:18 | |
| *** zzxwill has quit IRC | 07:20 | |
| *** zzxwill has joined #openstack-horizon | 07:20 | |
| *** zzxwill has quit IRC | 07:25 | |
| *** zzxwill has joined #openstack-horizon | 07:34 | |
| *** rdopiera has joined #openstack-horizon | 07:35 | |
| *** zzxwill has quit IRC | 07:36 | |
| *** ygbo has joined #openstack-horizon | 07:38 | |
| openstackgerrit | javeme proposed openstack/horizon: Use timedelta.total_seconds instead of calculating https://review.openstack.org/258375 | 07:39 |
| openstackgerrit | hanjiabao proposed openstack/horizon: Create project but no display and an error https://review.openstack.org/289828 | 07:40 |
| *** zzxwill has joined #openstack-horizon | 07:41 | |
| openstackgerrit | hanjiabao proposed openstack/horizon: Create project but no display and an error https://review.openstack.org/289828 | 07:42 |
| openstackgerrit | javeme proposed openstack/horizon: Avoid warnings caused by the positional args https://review.openstack.org/255061 | 07:45 |
| *** kzaitsev_mb has joined #openstack-horizon | 07:48 | |
| openstackgerrit | hanjiabao proposed openstack/horizon: Create project but no display and an error https://review.openstack.org/289828 | 07:49 |
| *** itxaka has joined #openstack-horizon | 07:55 | |
| *** belmoreira has joined #openstack-horizon | 07:56 | |
| *** k-ishii has joined #openstack-horizon | 07:57 | |
| *** zzxwill has quit IRC | 08:05 | |
| *** zzxwill has joined #openstack-horizon | 08:06 | |
| *** itisha has joined #openstack-horizon | 08:07 | |
| *** zzxwill_ has joined #openstack-horizon | 08:09 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Policy should support AND and OR checks for panels https://review.openstack.org/175982 | 08:10 |
| *** zzxwill has quit IRC | 08:10 | |
| *** e0ne has joined #openstack-horizon | 08:10 | |
| *** lhcheng_ has joined #openstack-horizon | 08:14 | |
| *** lhcheng has quit IRC | 08:17 | |
| *** xinwu has quit IRC | 08:17 | |
| *** e0ne has quit IRC | 08:19 | |
| *** zzxwill_ has quit IRC | 08:20 | |
| *** exploreshaifali has quit IRC | 08:21 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Optionaly require keypair on ng-launch-instance https://review.openstack.org/243762 | 08:26 |
| *** zzxwill has joined #openstack-horizon | 08:26 | |
| *** pece has joined #openstack-horizon | 08:31 | |
| *** josecastroleon has quit IRC | 08:32 | |
| *** lhcheng_ has quit IRC | 08:32 | |
| *** kzaitsev_mb has quit IRC | 08:32 | |
| *** josecastroleon has joined #openstack-horizon | 08:33 | |
| *** mpavlase has joined #openstack-horizon | 08:36 | |
| *** zzxwill has quit IRC | 08:39 | |
| openstackgerrit | Bhavna Saini proposed openstack/horizon: Replacing 'GB' with 'GiB'. https://review.openstack.org/290329 | 08:41 |
| *** zzxwill has joined #openstack-horizon | 08:43 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/290290 | 08:44 |
| *** openstackgerrit has quit IRC | 08:47 | |
| *** zzxwill has quit IRC | 08:48 | |
| *** openstackgerrit has joined #openstack-horizon | 08:48 | |
| *** zzxwill has joined #openstack-horizon | 08:51 | |
| *** doug-fish has joined #openstack-horizon | 08:52 | |
| *** doug-fish has quit IRC | 08:57 | |
| *** aortega has joined #openstack-horizon | 08:58 | |
| *** zzxwill has quit IRC | 09:00 | |
| openstackgerrit | Sanjana proposed openstack/horizon: Adding Ceilometer Alarms page https://review.openstack.org/251644 | 09:00 |
| *** oetrog has joined #openstack-horizon | 09:07 | |
| *** oetrog is now known as omer_etrog | 09:08 | |
| *** wolverineav has quit IRC | 09:10 | |
| *** amotoki has quit IRC | 09:10 | |
| *** wolverineav has joined #openstack-horizon | 09:10 | |
| *** zzxwill has joined #openstack-horizon | 09:13 | |
| *** bapalm has quit IRC | 09:14 | |
| *** wolverineav has quit IRC | 09:15 | |
| *** gberginc has joined #openstack-horizon | 09:16 | |
| *** exploreshaifali has joined #openstack-horizon | 09:18 | |
| *** slunkad has joined #openstack-horizon | 09:21 | |
| *** amotoki has joined #openstack-horizon | 09:25 | |
| *** bapalm has joined #openstack-horizon | 09:27 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix empty 'href' in link actions after AJAX actions_update https://review.openstack.org/289337 | 09:34 |
| *** amotoki has quit IRC | 09:34 | |
| *** slunkad has quit IRC | 09:34 | |
| *** sayalilunkad_lap has joined #openstack-horizon | 09:35 | |
| *** zzxwill has quit IRC | 09:43 | |
| *** amotoki has joined #openstack-horizon | 09:43 | |
| *** reedip is now known as reedip_away | 09:44 | |
| openstackgerrit | Ilya Alekseyev (irc:adiantum) proposed openstack/horizon: Fixes truncated string in details overview table. https://review.openstack.org/289346 | 09:46 |
| *** amotoki has quit IRC | 09:51 | |
| *** e0ne has joined #openstack-horizon | 09:51 | |
| tsufiev | robcresswell, morning! Have you noticed recently that Legacy LI->Select Network is broken? | 09:54 |
| *** zzxwill has joined #openstack-horizon | 09:55 | |
| *** amotoki has joined #openstack-horizon | 09:55 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:56 | |
| *** amotoki has quit IRC | 09:56 | |
| *** e0ne has quit IRC | 10:01 | |
| *** zzxwill has quit IRC | 10:03 | |
| *** e0ne has joined #openstack-horizon | 10:04 | |
| *** amotoki has joined #openstack-horizon | 10:06 | |
| *** omer_etrog has quit IRC | 10:07 | |
| *** omer_etrog has joined #openstack-horizon | 10:07 | |
| *** zzxwill has joined #openstack-horizon | 10:08 | |
| *** zzxwill has quit IRC | 10:10 | |
| *** zzxwill has joined #openstack-horizon | 10:11 | |
| *** omer_etrog has quit IRC | 10:12 | |
| *** mvk has joined #openstack-horizon | 10:21 | |
| mrunge | tsufiev, do you have a bug for this? | 10:26 |
| robcresswell | tsufiev: I had not noticed this | 10:32 |
| robcresswell | tsufiev: Target a bug to RC1 please | 10:32 |
| tsufiev | mrunge, robcresswell: double-checking... | 10:35 |
| itxaka | happens here too :( | 10:38 |
| tsufiev | itxaka, do you confirm it? | 10:38 |
| mrunge | yes, please file a bug, target to rc1, that's a regression... | 10:38 |
| * tsufiev filing a bug | 10:38 | |
| itxaka | yup, list is empty, no errors | 10:38 |
| robcresswell | confirmed | 10:39 |
| robcresswell | same here | 10:40 |
| *** tosky has joined #openstack-horizon | 10:41 | |
| *** yamamoto_ has quit IRC | 10:42 | |
| tsufiev | here it is https://bugs.launchpad.net/horizon/+bug/1555018 | 10:42 |
| openstack | Launchpad bug 1555018 in OpenStack Dashboard (Horizon) "Select Network widget in Legacy LI is empty" [High,New] | 10:42 |
| *** Drago has quit IRC | 10:44 | |
| itxaka | bisect blames this https://review.openstack.org/#/c/252161/ | 10:46 |
| robcresswell | well | 10:49 |
| itxaka | makes changing network to be a CheckboxSelectMultiple instead of ThemableCheckboxSelectMultiple makes it work again | 10:49 |
| itxaka | at a first glance | 10:49 |
| itxaka | or a a first neutron more like, badum tish | 10:50 |
| tsufiev | itxaka, that's weird, because create_instance integration tests should have failed for that commit | 10:50 |
| robcresswell | -.- | 10:50 |
| robcresswell | tsufiev: That depends. That create net widget works by hiding the django created widget and doing some hackery over the top IIRC | 10:50 |
| itxaka | tsufiev, maybe the network selection works internally by selecting the first network automatically | 10:50 |
| robcresswell | tsufiev: So if the integration test is testing the hidden widget, it may still work | 10:50 |
| itxaka | if you have 2, no network would be selected no? | 10:51 |
| robcresswell | Also, TIL about bisect. Thats so useful. | 10:51 |
| itxaka | yup, if you have only one network it will work | 10:52 |
| itxaka | so its a display issue, internally it still moves the proper network to the allocated if you only have one, that would make the integration tests pass tsufiev ? | 10:52 |
| robcresswell | Yes, exactly | 10:53 |
| tsufiev | checking right now | 10:53 |
| robcresswell | if you inspect the form HTML and remove the display:none, you can still see the network is checked | 10:53 |
| robcresswell | but checking/unchecking does nothing | 10:53 |
| robcresswell | because the JS is looking for particular values to scrape, but cant find them | 10:53 |
| robcresswell | This is likely broken for other forms too. There are 3 using this widget I believe. | 10:54 |
| *** exploreshaifali has quit IRC | 10:54 | |
| *** dsneddon has joined #openstack-horizon | 10:56 | |
| tsufiev | yes, that's true - even with empty widget and one existing network it works | 10:56 |
| tsufiev | another funny thing - did you know that if an admin creates a shared network from Project->Networks, he cannot delete it from that page :)? | 10:57 |
| robcresswell | oh I think I fixed it | 10:57 |
| tsufiev | nope | 10:57 |
| robcresswell | Although I wonder if a better solution is to revert the class to a standard checkbox input... | 10:58 |
| robcresswell | hmm | 10:58 |
| tsufiev | well, perhaps it's a different issue - the 'Delete Network' action is not available then | 10:58 |
| tsufiev | robcresswell, I think we can do better :) | 10:59 |
| robcresswell | I meant just for the dragndrop widget | 11:00 |
| robcresswell | I hate that widget, tried to block it getting used again in Kilo for fw and my -1 got squished :( | 11:00 |
| itxaka | well, if we are trying to phase out the legacy launch instance it makes sense to have a quick fix for it | 11:02 |
| itxaka | and then let it rot forever :D | 11:02 |
| * tsufiev is going to look into network widget js code to see if it could be fixed there | 11:05 | |
| robcresswell | tsufiev: Already on it | 11:06 |
| robcresswell | tsufiev: Its just because the markup has changed | 11:06 |
| robcresswell | its not longer finding the elements correctly | 11:06 |
| robcresswell | tsufiev: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.instances.js#L43 | 11:06 |
| tsufiev | oh | 11:07 |
| tsufiev | robcresswell, are you going to update selectors in JS? | 11:07 |
| robcresswell | yup | 11:07 |
| tsufiev | awesome! | 11:07 |
| tsufiev | meanwhile we should improve integration test for create_instance | 11:08 |
| tsufiev | to not rely on one network being selected by default | 11:08 |
| *** wolverineav has joined #openstack-horizon | 11:12 | |
| robcresswell | thanks tsufiev | 11:15 |
| *** wolverineav has quit IRC | 11:17 | |
| *** doug-fish has joined #openstack-horizon | 11:17 | |
| robcresswell | I fix'd it | 11:19 |
| *** vgridnev has joined #openstack-horizon | 11:22 | |
| *** doug-fish has quit IRC | 11:22 | |
| *** Daisy has joined #openstack-horizon | 11:25 | |
| tsufiev | robcresswell, could you please take a look in your review hours at https://review.openstack.org/#/c/289337/ (and its dependency)? | 11:26 |
| robcresswell | tsufiev: Yessir, its on my list | 11:26 |
| robcresswell | atm my list == anything on https://launchpad.net/horizon/+milestone/mitaka-rc1 | 11:27 |
| tsufiev | robcresswell, ok | 11:27 |
| * tsufiev is ready to review Select Network fix | 11:27 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fix legacy drag and drop widgets https://review.openstack.org/290413 | 11:27 |
| robcresswell | oo wait, thats only half done it | 11:28 |
| *** Daisy has quit IRC | 11:29 | |
| *** Daisy has joined #openstack-horizon | 11:30 | |
| *** kmartin has quit IRC | 11:33 | |
| *** yamamoto_ has joined #openstack-horizon | 11:33 | |
| *** Daisy has quit IRC | 11:34 | |
| *** Daisy has joined #openstack-horizon | 11:34 | |
| *** Daisy has quit IRC | 11:41 | |
| *** Daisy has joined #openstack-horizon | 11:41 | |
| *** chlong has quit IRC | 11:42 | |
| *** exploreshaifali has joined #openstack-horizon | 11:45 | |
| *** masco has quit IRC | 11:46 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out integration tests scaffolds from Horizon production code https://review.openstack.org/287793 | 11:46 |
| *** Daisy has quit IRC | 11:46 | |
| *** wangbo has joined #openstack-horizon | 11:50 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fix legacy drag and drop widgets https://review.openstack.org/290413 | 11:50 |
| robcresswell | tsufiev: That should do it ^^ | 11:50 |
| robcresswell | Right, every bug for RC1 is in flight now, except for one | 11:53 |
| *** cloudtrainme has joined #openstack-horizon | 12:03 | |
| *** zhurong_ has joined #openstack-horizon | 12:07 | |
| *** amotoki has quit IRC | 12:10 | |
| tsufiev | robcresswell, works for LI, but I cannot check Firewalls :/ | 12:10 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test case add subnet to the network https://review.openstack.org/273644 | 12:13 |
| *** cloudtrainme has quit IRC | 12:13 | |
| *** wolverineav has joined #openstack-horizon | 12:13 | |
| *** chlong has joined #openstack-horizon | 12:14 | |
| *** yamamoto_ has quit IRC | 12:16 | |
| itxaka | tsufiev, I tested on both firewalls and networks, looks good! | 12:17 |
| *** wolverineav has quit IRC | 12:18 | |
| tsufiev | itxaka, thanks! | 12:18 |
| *** mvk has quit IRC | 12:20 | |
| *** amotoki has joined #openstack-horizon | 12:24 | |
| *** dank__ has joined #openstack-horizon | 12:26 | |
| *** dank_ has quit IRC | 12:27 | |
| *** chlong has quit IRC | 12:27 | |
| *** dank__ is now known as dank_ | 12:27 | |
| *** bapalm has quit IRC | 12:27 | |
| *** bapalm has joined #openstack-horizon | 12:27 | |
| *** amotoki has quit IRC | 12:29 | |
| *** zzxwill has quit IRC | 12:30 | |
| *** doug-fish has joined #openstack-horizon | 12:31 | |
| *** Daisy has joined #openstack-horizon | 12:31 | |
| *** rodrigods has quit IRC | 12:37 | |
| *** rodrigods has joined #openstack-horizon | 12:37 | |
| openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 12:37 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Added test for check stacks creation and deletion functionality https://review.openstack.org/266368 | 12:38 |
| robcresswell | itxaka, tsufiev: Thanks for testing | 12:38 |
| *** Daisy has quit IRC | 12:39 | |
| *** omer_etrog has joined #openstack-horizon | 12:39 | |
| *** Daisy has joined #openstack-horizon | 12:39 | |
| *** chlong has joined #openstack-horizon | 12:40 | |
| *** Daisy has quit IRC | 12:41 | |
| *** Daisy has joined #openstack-horizon | 12:41 | |
| *** vgridnev has quit IRC | 12:42 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out integration tests scaffolds from Horizon production code https://review.openstack.org/287793 | 12:44 |
| *** yamamoto has joined #openstack-horizon | 12:45 | |
| *** vgridnev has joined #openstack-horizon | 12:45 | |
| *** Daisy has quit IRC | 12:47 | |
| *** yamamoto has quit IRC | 12:47 | |
| *** omer_etrog has quit IRC | 12:47 | |
| *** Daisy has joined #openstack-horizon | 12:48 | |
| *** yamamoto has joined #openstack-horizon | 12:48 | |
| *** doug-fish has quit IRC | 12:48 | |
| *** leitan has joined #openstack-horizon | 12:50 | |
| *** mvk has joined #openstack-horizon | 12:51 | |
| *** Daisy has quit IRC | 12:53 | |
| *** yamamoto has quit IRC | 12:53 | |
| *** zzxwill has joined #openstack-horizon | 12:56 | |
| *** xenogear has joined #openstack-horizon | 13:01 | |
| *** pauloewerton has joined #openstack-horizon | 13:01 | |
| *** petertr7_away is now known as petertr7 | 13:10 | |
| *** ducttape_ has joined #openstack-horizon | 13:12 | |
| *** itxaka is now known as itxaka|lunch | 13:14 | |
| *** wolverineav has joined #openstack-horizon | 13:15 | |
| *** yamamoto has joined #openstack-horizon | 13:17 | |
| *** yamamoto has quit IRC | 13:17 | |
| *** yamamoto has joined #openstack-horizon | 13:19 | |
| *** wolverineav has quit IRC | 13:20 | |
| *** sergio_nubeliu has joined #openstack-horizon | 13:27 | |
| *** ducttape_ has quit IRC | 13:27 | |
| *** doug-fish has joined #openstack-horizon | 13:29 | |
| *** doug-fish has quit IRC | 13:31 | |
| *** doug-fish has joined #openstack-horizon | 13:32 | |
| *** jtriley has joined #openstack-horizon | 13:35 | |
| *** neelashah has joined #openstack-horizon | 13:37 | |
| *** omer_etrog has joined #openstack-horizon | 13:38 | |
| *** omer_etrog has quit IRC | 13:38 | |
| *** jpomeroy has joined #openstack-horizon | 13:40 | |
| *** pkarikh has quit IRC | 13:41 | |
| *** katyafervent_awa has quit IRC | 13:41 | |
| *** kzaitsev_ws has quit IRC | 13:41 | |
| *** tsufiev has quit IRC | 13:41 | |
| *** kzaitsev_mb has quit IRC | 13:41 | |
| *** vgridnev has quit IRC | 13:43 | |
| leitan | Hi guys quick question, im using RBAC, i setted up a new dashboard and a certain role is required to access/show the panel, this works ok, but when i manually type the url on the browser, it doenst redirect the user to the login screen, instead of that it shows a 403 error django stacktrace, am i missing something ? | 13:43 |
| *** vgridnev has joined #openstack-horizon | 13:44 | |
| robcresswell | Shouldnt that be throwing a 401? | 13:45 |
| robcresswell | leitan: Difficult to debug without knowing the context. It sounds more like there is a different issue, and debug mode is just showing the trace. | 13:46 |
| *** Mounica has joined #openstack-horizon | 13:46 | |
| leitan | robcresswell, it trows a 403 because im returning that on my API, that is queried by that panel | 13:47 |
| leitan | robcresswell, if i change the response code of that action to 401 | 13:47 |
| leitan | will trigger a redirect ? | 13:47 |
| leitan | to the login screen ? | 13:48 |
| robcresswell | 403 is the wrong error code anyway, I think. Are you sure its being thrown correctly? Both 401 and 403 should throw to the login screen IIRC. | 13:48 |
| *** zhurong_ has quit IRC | 13:48 | |
| *** matt-borland has joined #openstack-horizon | 13:49 | |
| robcresswell | leitan: See https://github.com/openstack/horizon/blob/master/horizon/middleware.py#L114 | 13:50 |
| leitan | robcresswell, hmmm ok, 403 not doing it so far, ill check how im returning it, and test with 401 | 13:50 |
| *** Mounica has quit IRC | 13:50 | |
| leitan | robcresswell, and let you know, thanks for the pinpoints | 13:50 |
| *** amotoki has joined #openstack-horizon | 13:54 | |
| *** yamamoto has quit IRC | 13:56 | |
| *** yamamoto has joined #openstack-horizon | 13:57 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Cleaning up lint warnings for Image work https://review.openstack.org/289570 | 13:57 |
| *** exploreshaifali has quit IRC | 14:00 | |
| openstackgerrit | Ilya Alekseyev (irc:adiantum) proposed openstack/horizon: Fixes truncated string in details overview table. https://review.openstack.org/289346 | 14:05 |
| *** jtriley has quit IRC | 14:10 | |
| *** ducttape_ has joined #openstack-horizon | 14:12 | |
| openstackgerrit | allenwhale proposed openstack/horizon: Add Save/Cancel icon to every modals https://review.openstack.org/290520 | 14:14 |
| *** katyafervent_awa has joined #openstack-horizon | 14:16 | |
| *** lblanchard has joined #openstack-horizon | 14:16 | |
| *** pkarikh has joined #openstack-horizon | 14:16 | |
| *** fifieldt has quit IRC | 14:16 | |
| *** mtanino has quit IRC | 14:19 | |
| *** zzxwill has quit IRC | 14:20 | |
| *** tsufiev has joined #openstack-horizon | 14:23 | |
| *** zzxwill has joined #openstack-horizon | 14:24 | |
| *** itxaka|lunch has quit IRC | 14:24 | |
| leitan | robcresswell, i tried changing the policy rules on an existing panel, the panel gets hidden ok, but if i access the url directly no matter what i return as response code, it depends on how that dashboard/view reacts to the code, to do something, should i handle that in the view to redirect it to the login ? i was hoping that the horizon policys can do that automatically | 14:25 |
| leitan | robcresswell, no matter if i return 403 or 401 | 14:26 |
| *** itxaka has joined #openstack-horizon | 14:26 | |
| *** peristeri has joined #openstack-horizon | 14:27 | |
| *** ducttape_ has quit IRC | 14:34 | |
| *** adiantum has joined #openstack-horizon | 14:35 | |
| *** wangbo has quit IRC | 14:39 | |
| *** zzxwill has quit IRC | 14:40 | |
| *** ducttape_ has joined #openstack-horizon | 14:42 | |
| *** zzxwill has joined #openstack-horizon | 14:42 | |
| *** Daisy has joined #openstack-horizon | 14:43 | |
| *** wangbo has joined #openstack-horizon | 14:45 | |
| matt-borland | itxaka, having some trouble with https://review.openstack.org/#/c/289379/ (Launch Instance from Vol Snapshots) | 14:46 |
| matt-borland | I replicated the problem; notes in the comments on the patch. | 14:46 |
| tsufiev | matt-borland, hello! Have you looked at https://review.openstack.org/#/c/289849/ ? | 14:50 |
| tsufiev | I'm curious what do you think of it | 14:50 |
| matt-borland | oh, interesting! tsufiev, I'll take a look in a few minutes... | 14:51 |
| tsufiev | sure | 14:51 |
| *** Daisy has quit IRC | 14:51 | |
| matt-borland | that may be the cure I was looking for :) | 14:51 |
| tsufiev | but that doesn't work with ng-app ng-strict-di mode | 14:52 |
| tsufiev | still need to somehow inject $compile service into legacy code | 14:52 |
| tsufiev | then, if tyr's patch merges and body.scope() no longer works, we'll need to work around this issue as well | 14:53 |
| *** cloudtrainme has joined #openstack-horizon | 14:54 | |
| *** Daisy has joined #openstack-horizon | 14:55 | |
| itxaka | matt-borland, thats a very nice bug :D | 14:55 |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check instance creation when several networks are present https://review.openstack.org/276075 | 14:58 |
| *** cloudtrainme has quit IRC | 14:59 | |
| *** cloudtrainme has joined #openstack-horizon | 15:01 | |
| openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check instance creation when several networks are present https://review.openstack.org/276075 | 15:02 |
| *** vgridnev has quit IRC | 15:03 | |
| *** Daisy has quit IRC | 15:04 | |
| robcresswell | krotscheck: Thoughts? https://review.openstack.org/#/c/290235/ | 15:05 |
| robcresswell | Assumed you'd want to be involved in the discussion on that one | 15:05 |
| *** pushkaru has joined #openstack-horizon | 15:06 | |
| *** mtanino has joined #openstack-horizon | 15:06 | |
| *** lapalm has joined #openstack-horizon | 15:06 | |
| *** xenogear has quit IRC | 15:07 | |
| *** xenogear has joined #openstack-horizon | 15:08 | |
| *** BigWillie has joined #openstack-horizon | 15:08 | |
| krotscheck | robcresswell: Comments provided. | 15:08 |
| krotscheck | robcresswell: Long story short- even if we use sphinx, we still want it to parse jsdoc using something like https://github.com/debrouwere/jsdoc-for-sphinx | 15:09 |
| krotscheck | Whether or not horizon considers API documentation a necessary thing though is an entirely different discussion. Does it make sense to write documentation for something that is not really designed for consumption by other engineers? | 15:10 |
| *** Mounica has joined #openstack-horizon | 15:10 | |
| robcresswell | krotscheck: I think its more for things like reusable widgets and consumption by plugins/newcomers to Horizon. | 15:11 |
| robcresswell | krotscheck: Thanks for the comments btw. Just didn't want that to zoom through without discussion. | 15:13 |
| *** Daisy has joined #openstack-horizon | 15:14 | |
| *** pushkaru has quit IRC | 15:14 | |
| *** sjmc7 has joined #openstack-horizon | 15:14 | |
| openstackgerrit | Sayali Lunkad proposed openstack/horizon: Confirm Dialog for Delete operation in Network Topology https://review.openstack.org/290574 | 15:15 |
| krotscheck | robcresswell: Thanks for the heads up, doc generation is on my roadmap, there's just a herd of yaks in the way | 15:16 |
| *** wolverineav has joined #openstack-horizon | 15:16 | |
| *** Daisy has quit IRC | 15:19 | |
| *** Mounica has quit IRC | 15:19 | |
| *** pushkaru has joined #openstack-horizon | 15:19 | |
| *** vijendar has joined #openstack-horizon | 15:19 | |
| *** matt-borland has quit IRC | 15:21 | |
| *** zzxwill has quit IRC | 15:21 | |
| *** matt-borland has joined #openstack-horizon | 15:21 | |
| *** wolverineav has quit IRC | 15:21 | |
| *** zzxwill has joined #openstack-horizon | 15:23 | |
| *** vijendar1 has joined #openstack-horizon | 15:25 | |
| *** vijendar has quit IRC | 15:28 | |
| *** vgridnev has joined #openstack-horizon | 15:29 | |
| *** zzxwill has quit IRC | 15:29 | |
| *** zzxwill has joined #openstack-horizon | 15:30 | |
| *** vgridnev has quit IRC | 15:30 | |
| *** jprovazn has joined #openstack-horizon | 15:31 | |
| *** vgridnev has joined #openstack-horizon | 15:35 | |
| *** vgridnev has quit IRC | 15:35 | |
| *** zzxwill has quit IRC | 15:36 | |
| *** zzxwill_ has joined #openstack-horizon | 15:36 | |
| *** ankurgupta has quit IRC | 15:37 | |
| *** vijendar1 has quit IRC | 15:40 | |
| *** vijendar has joined #openstack-horizon | 15:40 | |
| *** wangbo has quit IRC | 15:42 | |
| *** xinwu has joined #openstack-horizon | 15:43 | |
| sergio_nubeliu | Hi robcresswell, is it possible to set permissions to a panel for users having role1 or role2 (not role1 and role2)? | 15:44 |
| sergio_nubeliu | We've tried with policy_rules but it only hides the panel (you can acces it via url without restrictions) | 15:46 |
| *** sayalilunkad_lap has quit IRC | 15:48 | |
| *** zzxwill_ has quit IRC | 15:49 | |
| *** sayalilunkad_lap has joined #openstack-horizon | 15:49 | |
| *** zzxwill has joined #openstack-horizon | 15:51 | |
| *** kmartin has joined #openstack-horizon | 15:55 | |
| *** matt-borland has quit IRC | 16:05 | |
| *** ankurgupta has joined #openstack-horizon | 16:05 | |
| sergio_nubeliu | Hi guys, is it possible to set permissions to a panel for users having role1 or role2 (not role1 and role2)? | 16:06 |
| sergio_nubeliu | We've tried with policy_rules but it only hides the panel (you can acces it via url without restrictions) | 16:06 |
| *** aortega has quit IRC | 16:08 | |
| *** zzxwill has quit IRC | 16:13 | |
| *** zzxwill has joined #openstack-horizon | 16:14 | |
| *** adiantum has quit IRC | 16:15 | |
| *** wolverineav has joined #openstack-horizon | 16:15 | |
| *** absubram has joined #openstack-horizon | 16:17 | |
| *** Drago1 has joined #openstack-horizon | 16:17 | |
| *** matt-borland has joined #openstack-horizon | 16:18 | |
| *** sergio_nubeliu has quit IRC | 16:18 | |
| *** itisha has quit IRC | 16:19 | |
| *** david_cu has joined #openstack-horizon | 16:20 | |
| *** BigWillie has quit IRC | 16:20 | |
| *** roxanagh_ has joined #openstack-horizon | 16:21 | |
| pece | In keystone_policy.v3cloudsample.json identity:create_grant check is supposed to work in Horizon / Keystone v3 / domains? Right now it seems it prevents displaying "Create user" link when domain admin (not cloud admin) is logged in in Horizon. | 16:22 |
| *** sergio_nubeliu has joined #openstack-horizon | 16:22 | |
| *** ediardo has joined #openstack-horizon | 16:25 | |
| matt-borland | itxaka, I found a cheating solution for the loading problem | 16:25 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Allow Launch Instance (Angular) from Volume Snapshots https://review.openstack.org/289379 | 16:27 |
| robcresswell | Horizon is doing something weeeird when it loads. Is anyone else seeing a kind of double-load? | 16:28 |
| itxaka | oh my, the preload stuff :( | 16:31 |
| matt-borland | itxaka, yeah :( | 16:31 |
| *** itxaka has quit IRC | 16:32 | |
| *** cloudtrainme has quit IRC | 16:34 | |
| *** zzxwill has quit IRC | 16:34 | |
| *** itxaka has joined #openstack-horizon | 16:34 | |
| *** bpokorny has joined #openstack-horizon | 16:36 | |
| *** zzxwill has joined #openstack-horizon | 16:37 | |
| *** wolverineav has quit IRC | 16:39 | |
| *** bpokorny has quit IRC | 16:39 | |
| sergio_nubeliu | Hi guys, we're trying to set permissions to a panel for users having role1 or role2 (not role1 and role2) | 16:39 |
| *** gyee has joined #openstack-horizon | 16:39 | |
| sergio_nubeliu | We've tried with policy_rules but it only hides the panel (you can acces it via url without restrictions) | 16:39 |
| *** bpokorny has joined #openstack-horizon | 16:39 | |
| david-lyle | sergio_nubeliu: a nested tuple will do the trick | 16:40 |
| david-lyle | sergio_nubeliu: so instead of (role1, role2) use ((role1, role2),) | 16:41 |
| david-lyle | the inner tuple is an OR the outer is AND | 16:41 |
| david_cu | sergio_nubeliu: here's an example of how we did it https://github.com/blueboxgroup/horizon-customization/blob/master/horizon-customization/horizon_customization.py | 16:42 |
| david_cu | with the help from david-lyle a few months back :) | 16:43 |
| david-lyle | overrides file FTW | 16:44 |
| sergio_nubeliu | david-lyle, david-cu: thank you! | 16:44 |
| *** ygbo has quit IRC | 16:45 | |
| *** cloudtrainme has joined #openstack-horizon | 16:46 | |
| *** Mounica has joined #openstack-horizon | 16:46 | |
| *** vishwana_ is now known as vishwanathj | 16:48 | |
| *** e0ne has quit IRC | 16:50 | |
| *** xinwu has quit IRC | 16:51 | |
| *** xinwu has joined #openstack-horizon | 16:51 | |
| *** belmoreira has quit IRC | 16:52 | |
| *** eugeniato has joined #openstack-horizon | 16:53 | |
| *** xinwu has joined #openstack-horizon | 16:57 | |
| *** tosky has quit IRC | 16:57 | |
| *** vijendar1 has joined #openstack-horizon | 16:58 | |
| *** vijendar has quit IRC | 16:59 | |
| *** alexvictorchan has quit IRC | 17:00 | |
| *** piet has joined #openstack-horizon | 17:04 | |
| *** xinwu has quit IRC | 17:04 | |
| piet | Table proposals (Network, Flavors, etc) https://openstack.invisionapp.com/d/main/#/projects/6582861 | 17:05 |
| *** kzaitsev_mb has joined #openstack-horizon | 17:05 | |
| *** dan_nguyen has joined #openstack-horizon | 17:06 | |
| *** BigWillie has joined #openstack-horizon | 17:06 | |
| *** kzaitsev_ws has joined #openstack-horizon | 17:07 | |
| *** cloudtra_ has joined #openstack-horizon | 17:08 | |
| *** rcernin has quit IRC | 17:09 | |
| *** wolverineav has joined #openstack-horizon | 17:09 | |
| *** cloudtrainme has quit IRC | 17:10 | |
| *** ediardo has quit IRC | 17:10 | |
| *** Mounica has quit IRC | 17:16 | |
| *** aortega has joined #openstack-horizon | 17:16 | |
| *** Mounica has joined #openstack-horizon | 17:20 | |
| *** sayalilunkad_lap has quit IRC | 17:27 | |
| *** zzxwill has quit IRC | 17:34 | |
| *** rdopiera has quit IRC | 17:34 | |
| *** alexvictorchan has joined #openstack-horizon | 17:35 | |
| *** cloudtra_ has quit IRC | 17:39 | |
| *** clu_ has joined #openstack-horizon | 17:40 | |
| *** wolverineav has quit IRC | 17:40 | |
| *** cloudtrainme has joined #openstack-horizon | 17:42 | |
| *** kzaitsev_mb has quit IRC | 17:45 | |
| *** david_cu has quit IRC | 17:48 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Zanata https://review.openstack.org/288851 | 17:48 |
| *** sergio_nubeliu has quit IRC | 17:54 | |
| *** vijendar1 has quit IRC | 17:55 | |
| *** amotoki has quit IRC | 17:57 | |
| matt-borland | itxaka, working on de-linting the openstack-service-api area. | 17:58 |
| *** vijendar has joined #openstack-horizon | 17:58 | |
| *** petertr7 is now known as petertr7_away | 18:00 | |
| openstackgerrit | Merged openstack/horizon: Add function to recreate ec2 credential https://review.openstack.org/252190 | 18:01 |
| *** vijendar has quit IRC | 18:03 | |
| *** vijendar has joined #openstack-horizon | 18:04 | |
| openstackgerrit | Merged openstack/horizon: Fix legacy drag and drop widgets https://review.openstack.org/290413 | 18:05 |
| *** neelashah has quit IRC | 18:05 | |
| *** sergio_nubeliu has joined #openstack-horizon | 18:05 | |
| *** tosky has joined #openstack-horizon | 18:05 | |
| *** zzxwill has joined #openstack-horizon | 18:06 | |
| *** xinwu has joined #openstack-horizon | 18:10 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Cleaning up eslint warnings in the openstack-service-api directory https://review.openstack.org/290738 | 18:11 |
| *** neelashah has joined #openstack-horizon | 18:18 | |
| *** cloudtrainme has quit IRC | 18:22 | |
| *** mpavlase has quit IRC | 18:23 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Handle non ASCII tenant names gracefully when downloading RC file https://review.openstack.org/279573 | 18:24 |
| *** mvk has quit IRC | 18:27 | |
| *** cloudtrainme has joined #openstack-horizon | 18:27 | |
| *** e0ne has joined #openstack-horizon | 18:29 | |
| *** vijendar1 has joined #openstack-horizon | 18:33 | |
| *** vijendar has quit IRC | 18:33 | |
| *** zzxwill has quit IRC | 18:37 | |
| *** pece has quit IRC | 18:42 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:43 | |
| *** yamamoto has quit IRC | 18:45 | |
| *** vijendar1 has quit IRC | 18:52 | |
| *** jtriley has joined #openstack-horizon | 18:56 | |
| *** petertr7_away is now known as petertr7 | 18:57 | |
| *** jpomeroy has quit IRC | 18:58 | |
| *** jpomeroy has joined #openstack-horizon | 19:02 | |
| *** ducttape_ has quit IRC | 19:02 | |
| *** jpomeroy has quit IRC | 19:03 | |
| *** jpomeroy has joined #openstack-horizon | 19:03 | |
| *** lapalm_ has joined #openstack-horizon | 19:04 | |
| *** lapalm_ has quit IRC | 19:04 | |
| *** lapalm_ has joined #openstack-horizon | 19:05 | |
| *** garthb has joined #openstack-horizon | 19:05 | |
| *** petertr7 is now known as petertr7_away | 19:07 | |
| *** ducttape_ has joined #openstack-horizon | 19:07 | |
| *** clu_ has quit IRC | 19:07 | |
| *** lapalm has quit IRC | 19:08 | |
| *** lapalm has joined #openstack-horizon | 19:08 | |
| *** kzaitsev_mb has quit IRC | 19:09 | |
| *** lapalm_ has quit IRC | 19:09 | |
| *** zzxwill has joined #openstack-horizon | 19:12 | |
| *** zzxwill_ has joined #openstack-horizon | 19:14 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:15 | |
| *** tqtran has joined #openstack-horizon | 19:15 | |
| *** yamamoto has joined #openstack-horizon | 19:15 | |
| *** zzxwill has quit IRC | 19:17 | |
| *** NikitaKonovalov has quit IRC | 19:18 | |
| *** adiantum has joined #openstack-horizon | 19:19 | |
| *** doug-fis_ has joined #openstack-horizon | 19:19 | |
| *** doug-fis_ is now known as doug-fish_ | 19:20 | |
| *** NikitaKonovalov has joined #openstack-horizon | 19:20 | |
| *** doug-fish has quit IRC | 19:21 | |
| *** yamamoto has quit IRC | 19:21 | |
| openstackgerrit | vpluzhnikov@gmail.com proposed openstack/horizon: Clarifying Project Overview usage labels https://review.openstack.org/79688 | 19:28 |
| openstackgerrit | vpluzhnikov@gmail.com proposed openstack/horizon: mend https://review.openstack.org/290797 | 19:28 |
| *** neelashah has quit IRC | 19:32 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Images Actions Return Promises https://review.openstack.org/290800 | 19:33 |
| *** neelashah has joined #openstack-horizon | 19:36 | |
| *** wolverineav has joined #openstack-horizon | 19:37 | |
| *** mvk has joined #openstack-horizon | 19:39 | |
| *** zzxwill_ has quit IRC | 19:40 | |
| *** petertr7_away is now known as petertr7 | 19:40 | |
| *** lhcheng has joined #openstack-horizon | 19:40 | |
| *** wolverineav has quit IRC | 19:41 | |
| *** jprovazn has quit IRC | 19:43 | |
| *** david_cu has joined #openstack-horizon | 19:44 | |
| *** pushkaru has quit IRC | 19:48 | |
| *** cloudtrainme has quit IRC | 19:48 | |
| *** pushkaru has joined #openstack-horizon | 19:48 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Cleaning up eslint warnings in the openstack-service-api directory https://review.openstack.org/290738 | 19:52 |
| *** tyr_ has joined #openstack-horizon | 19:52 | |
| matt-borland | r1chardj0n3s, itxaka: https://review.openstack.org/#/c/290738/ ^^ cleans up about 100 warnings. | 19:53 |
| matt-borland | eslint warnings | 19:54 |
| *** BigWillie has quit IRC | 19:54 | |
| matt-borland | all in the openstack-service-api dir | 19:54 |
| *** doug-fish has joined #openstack-horizon | 19:55 | |
| *** doug-fish_ has quit IRC | 19:55 | |
| itxaka | \o/ | 19:55 |
| *** piet has quit IRC | 19:56 | |
| *** piet has joined #openstack-horizon | 19:58 | |
| robcresswell | david-lyle: Left a review on the Volume Consistency Groups patch (the first in the chain) | 19:59 |
| robcresswell | Meeting over in #openstack-meeting-3 | 19:59 |
| *** piet has quit IRC | 19:59 | |
| *** piet has joined #openstack-horizon | 20:00 | |
| *** TravT_ is now known as TravT | 20:00 | |
| *** rhagarty has joined #openstack-horizon | 20:01 | |
| *** pauloewerton has quit IRC | 20:02 | |
| *** sjmc7 has quit IRC | 20:02 | |
| matt-borland | krotscheck, I'm on board with you about https://review.openstack.org/#/c/290235/ | 20:03 |
| matt-borland | partly because I've spent about 4 hours cleaning up about 50% of the jsdoc warnings. | 20:03 |
| *** olivia__ has joined #openstack-horizon | 20:03 | |
| *** neelashah1 has joined #openstack-horizon | 20:03 | |
| matt-borland | I'd much prefer to leave the setting (with one adjustment) and clean the jsdocs up. | 20:03 |
| *** vijendar has joined #openstack-horizon | 20:06 | |
| *** neelashah has quit IRC | 20:06 | |
| *** olivia__ has left #openstack-horizon | 20:07 | |
| *** gyee has quit IRC | 20:08 | |
| *** mrrowden has joined #openstack-horizon | 20:08 | |
| *** garthb has quit IRC | 20:09 | |
| *** pushkaru has quit IRC | 20:09 | |
| *** pumarani__ has joined #openstack-horizon | 20:09 | |
| krotscheck | matt-borland: woot! | 20:16 |
| krotscheck | matt-borland: I have to say though, that rule is _obnoxious_ | 20:16 |
| matt-borland | it's pretty broad. it took me a while to figure out all it wanted. | 20:17 |
| robcresswell | rhagarty: Left a review on the first of your consistency group patches | 20:18 |
| robcresswell | rhagarty: I'll be around to review it a lot, would like to land the feature soon if you have the time to iterate on it | 20:18 |
| *** sjmc7 has joined #openstack-horizon | 20:19 | |
| itxaka | agreed with matt-borland on this, jsdoc is good for developers, the more info the better. If we can clean up and at the same time provide *some* documentation, its great | 20:20 |
| itxaka | some of those jsdocs are very useful for noobs like me :D | 20:21 |
| matt-borland | yeah, that is true itxaka | 20:21 |
| matt-borland | and of course they're not required... | 20:22 |
| *** zzxwill has joined #openstack-horizon | 20:22 | |
| matt-borland | but I think it's fair to say, we want at least to match the boilerplate when we think we're writing jsdocs | 20:22 |
| matt-borland | and whether those are useful or not is up to the devs | 20:22 |
| david-lyle | it was the tooling/format that was the question I thought, not the existence of docs | 20:24 |
| *** pumarani__ has quit IRC | 20:25 | |
| *** eugeniato has quit IRC | 20:25 | |
| *** pumarani__ has joined #openstack-horizon | 20:25 | |
| *** cloudtrainme has joined #openstack-horizon | 20:41 | |
| *** zzxwill has quit IRC | 20:42 | |
| *** zzxwill has joined #openstack-horizon | 20:42 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add getUrl to resource-type-registry https://review.openstack.org/290839 | 20:43 |
| r1chardj0n3s | matt-borland: I think you might have missed the discussion about jsdoc in the horizon meeting just now? | 20:48 |
| r1chardj0n3s | (the ongoing meeting) | 20:48 |
| *** doug-fish has quit IRC | 20:49 | |
| *** Ephur has joined #openstack-horizon | 20:49 | |
| *** mpavlase has joined #openstack-horizon | 20:50 | |
| *** mpavlase has left #openstack-horizon | 20:51 | |
| *** e0ne has quit IRC | 20:53 | |
| *** ediardo has joined #openstack-horizon | 20:54 | |
| *** tqtran has quit IRC | 20:54 | |
| *** wolverineav has joined #openstack-horizon | 20:54 | |
| *** tqtran has joined #openstack-horizon | 20:55 | |
| *** Mounica has quit IRC | 20:55 | |
| *** wolverineav has quit IRC | 20:56 | |
| *** wolverineav has joined #openstack-horizon | 20:56 | |
| *** pumarani__ has quit IRC | 20:57 | |
| *** pushkaru has joined #openstack-horizon | 20:57 | |
| *** petertr7 is now known as petertr7_away | 21:00 | |
| *** wolverineav has quit IRC | 21:01 | |
| matt-borland | r1chardj0n3s, I was only 1/2 tuned into it | 21:01 |
| *** wolverineav has joined #openstack-horizon | 21:02 | |
| *** pushkaru has quit IRC | 21:02 | |
| matt-borland | wrt fixing jsdocs, I dunno, I'd rather just sit down and clean up what is here | 21:02 |
| *** pushkaru has joined #openstack-horizon | 21:02 | |
| *** itxaka has quit IRC | 21:02 | |
| r1chardj0n3s | matt-borland: but there might be no point | 21:03 |
| matt-borland | r1chardj0n3s, but, if there's truly something imminent to change our docs. | 21:03 |
| r1chardj0n3s | that's what I'm getting at | 21:03 |
| matt-borland | ...right | 21:03 |
| r1chardj0n3s | you might be doing all that work for no reason | 21:03 |
| r1chardj0n3s | which would make me sad | 21:03 |
| matt-borland | NOW you've convinced me! :P | 21:03 |
| r1chardj0n3s | I should note that getting ndgoc working in sphinx is the ideal solution | 21:03 |
| matt-borland | Yeah, I mean, it doesn't hurt us to turn it off now if only to focus on the more important warnings. | 21:04 |
| r1chardj0n3s | but also that jsdoc and ngdoc don't agree on everything (or at least the eslint jsdoc rules don't) | 21:04 |
| matt-borland | is there a good processor for ngdocs? | 21:04 |
| r1chardj0n3s | no | 21:04 |
| r1chardj0n3s | that's the problem | 21:04 |
| matt-borland | right, that's why I thought we just plowed (ploughed) ahead with jsdocs | 21:04 |
| r1chardj0n3s | dgeni is just horrible and broken and no-one uses it any more except the angularjs project themselves | 21:05 |
| r1chardj0n3s | grunt-ngdocs works, but is very limited in capability and doesn't handle the scale of our docs at all | 21:05 |
| matt-borland | we have a scale of docs? | 21:05 |
| r1chardj0n3s | we have a scale of codebase | 21:05 |
| r1chardj0n3s | :-) | 21:05 |
| r1chardj0n3s | (srsly, have you *seen* how much code we have OMG) | 21:06 |
| matt-borland | OK...well, I guess if the goal is to make it easier to see warnings, | 21:06 |
| matt-borland | most of the jsdocs cleanup I did was crappy boilerplate stuff | 21:06 |
| matt-borland | not terribly useful. | 21:06 |
| r1chardj0n3s | the meeting logs aren't up yet and I think I missed the easy link to finding RC1 bugs so does anyone have that handy? | 21:06 |
| matt-borland | You mean: https://launchpad.net/horizon/+milestone/mitaka-rc1 ? | 21:07 |
| r1chardj0n3s | thanks matt-borland | 21:07 |
| r1chardj0n3s | ooh, I have a lot of feedback on my swift patch | 21:08 |
| r1chardj0n3s | I'll just ignore that TravT guy tho | 21:08 |
| r1chardj0n3s | what a pain | 21:08 |
| TravT | yeah, he's a real jerk | 21:08 |
| TravT | ;) | 21:08 |
| r1chardj0n3s | dammit, you're in channel again? :-P | 21:09 |
| *** mrrowden has quit IRC | 21:09 | |
| *** vijendar has quit IRC | 21:09 | |
| TravT | only to harass you | 21:10 |
| *** wolverineav has quit IRC | 21:10 | |
| r1chardj0n3s | cool review comments thanks robcresswell and TravT, will get right on them (but Travis, I'm unlikely to make large architectural changes at this point, I think) | 21:12 |
| *** vijendar has joined #openstack-horizon | 21:12 | |
| *** wolverineav has joined #openstack-horizon | 21:14 | |
| *** cloudtrainme has quit IRC | 21:14 | |
| TravT | r1chardj0n3s i'd choose getting a better swift user experience in for mitaka than making the code perfect, but also don't want it to just get dropped once it is in. | 21:14 |
| r1chardj0n3s | yep, completely understood (with the understanding that I have no intention of dropping it) | 21:15 |
| matt-borland | so r1chardj0n3s, is anyone planning on fixing the warnings other than the valid-jsdocs? I've been doing menial tasks, so I could do that. | 21:25 |
| *** cloudtrainme has joined #openstack-horizon | 21:25 | |
| *** doug-fish has joined #openstack-horizon | 21:25 | |
| r1chardj0n3s | matt-borland: just itxaka | 21:26 |
| r1chardj0n3s | I was also, but there's not that many to fix once you ignore jsdoc | 21:26 |
| matt-borland | ok, I'll just relax for now, then | 21:26 |
| *** gberginc has quit IRC | 21:31 | |
| *** Drago1 has quit IRC | 21:32 | |
| matt-borland | jpomeroy, I don't know if you've seen https://review.openstack.org/#/c/286268/ yet, | 21:33 |
| matt-borland | it might help clean up a lot of LBaaS pages where there are dozens of policy calls | 21:34 |
| jpomeroy | matt-borland, yep I noticed it but haven't tried it out yet. definitely sounds like an improvement. | 21:35 |
| matt-borland | doug-fish, ^^ may be good for performance for LBaaS | 21:36 |
| *** sergio_nubeliu has quit IRC | 21:38 | |
| doug-fish | matt-borland: thanks! | 21:38 |
| *** Mounica has joined #openstack-horizon | 21:40 | |
| *** zzxwill has quit IRC | 21:42 | |
| *** jtriley has quit IRC | 21:48 | |
| *** gyee has joined #openstack-horizon | 21:51 | |
| *** leitan has quit IRC | 21:53 | |
| *** cloudtrainme has quit IRC | 21:57 | |
| *** garthb has joined #openstack-horizon | 21:58 | |
| *** Mounica has quit IRC | 21:58 | |
| *** clu_ has joined #openstack-horizon | 21:59 | |
| *** ducttape_ has quit IRC | 21:59 | |
| *** cloudtrainme has joined #openstack-horizon | 21:59 | |
| *** ediardo has quit IRC | 22:00 | |
| *** Drago1 has joined #openstack-horizon | 22:00 | |
| *** ducttape_ has joined #openstack-horizon | 22:01 | |
| *** vijendar has quit IRC | 22:01 | |
| *** vijendar has joined #openstack-horizon | 22:02 | |
| *** zzxwill has joined #openstack-horizon | 22:03 | |
| *** Drago2 has joined #openstack-horizon | 22:04 | |
| *** Drago2 has quit IRC | 22:05 | |
| *** Drago1 has quit IRC | 22:05 | |
| *** Drago1 has joined #openstack-horizon | 22:05 | |
| *** absubram has quit IRC | 22:06 | |
| *** lblanchard has quit IRC | 22:08 | |
| matt-borland | doug-fish, jpomeroy, that LBaaS set of patches failed jenkins, you might want to check on that...a node died in the docs | 22:08 |
| matt-borland | sadly it was the lead patch | 22:08 |
| matt-borland | that node was running abysmally slow | 22:09 |
| *** vijendar has quit IRC | 22:11 | |
| doug-fish | jenkins! *shakes fist* | 22:14 |
| * r1chardj0n3s has a clear mental image of doug-fish shaking his fist at a Jenkins now | 22:16 | |
| *** david-lyle has quit IRC | 22:19 | |
| *** david-lyle has joined #openstack-horizon | 22:20 | |
| *** ChanServ sets mode: +o david-lyle | 22:20 | |
| *** xenogear has quit IRC | 22:21 | |
| *** matt-borland has quit IRC | 22:22 | |
| *** peristeri has quit IRC | 22:30 | |
| sjmc7 | i can only think of laurel and hardy now | 22:31 |
| *** roxanagh_ has quit IRC | 22:33 | |
| *** pushkaru has quit IRC | 22:34 | |
| *** piet has quit IRC | 22:36 | |
| *** piet has joined #openstack-horizon | 22:37 | |
| *** jtomasek has quit IRC | 22:39 | |
| *** Mounica has joined #openstack-horizon | 22:40 | |
| *** zzxwill has quit IRC | 22:40 | |
| *** ybathia has joined #openstack-horizon | 22:41 | |
| *** ybathia has quit IRC | 22:42 | |
| *** wolverineav has quit IRC | 22:46 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Images Actions Return Promises https://review.openstack.org/290800 | 22:52 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Launch Instance Wizard - Avail items count doesn't update https://review.openstack.org/246698 | 22:55 |
| *** bpokorny_ has joined #openstack-horizon | 22:58 | |
| *** wolverineav has joined #openstack-horizon | 23:01 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add Horizon support for volume consistency groups https://review.openstack.org/257630 | 23:01 |
| *** garthb_ has joined #openstack-horizon | 23:01 | |
| *** mariusv has quit IRC | 23:01 | |
| *** lunarlamp is now known as mariusv | 23:01 | |
| *** garthb has quit IRC | 23:01 | |
| *** bpokorny has quit IRC | 23:01 | |
| *** wolverineav has quit IRC | 23:01 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!