| *** ArcTanSusan has quit IRC | 00:01 | |
| *** darrenc is now known as darrenc_afk | 00:26 | |
| *** wolverineav has joined #openstack-horizon | 00:29 | |
| *** sdake has joined #openstack-horizon | 00:31 | |
| *** sdake_ has quit IRC | 00:34 | |
| *** wolverineav has quit IRC | 00:34 | |
| *** darrenc_afk is now known as darrenc | 00:53 | |
| openstackgerrit | yuki kasuya proposed openstack/horizon: Remove repetition of "Attached to" in table https://review.openstack.org/300290 | 00:57 |
|---|---|---|
| *** sdake_ has joined #openstack-horizon | 01:17 | |
| *** sdake has quit IRC | 01:18 | |
| *** weezS has joined #openstack-horizon | 01:21 | |
| *** wolverineav has joined #openstack-horizon | 01:31 | |
| *** kenji-i has quit IRC | 01:33 | |
| *** kenji-i has joined #openstack-horizon | 01:35 | |
| *** wolverineav has quit IRC | 01:36 | |
| *** bapalm has joined #openstack-horizon | 01:51 | |
| *** dan_nguyen has joined #openstack-horizon | 01:51 | |
| *** sdake has joined #openstack-horizon | 01:53 | |
| *** sdake_ has quit IRC | 01:54 | |
| *** ducttape_ has joined #openstack-horizon | 01:54 | |
| *** ducttape_ has quit IRC | 01:55 | |
| *** ducttape_ has joined #openstack-horizon | 01:55 | |
| *** hurgleburgler1 is now known as hurgleburgler | 01:57 | |
| *** ChanServ sets mode: +v hurgleburgler | 01:57 | |
| *** sdake has quit IRC | 02:03 | |
| *** sdake has joined #openstack-horizon | 02:06 | |
| *** cshahani has quit IRC | 02:09 | |
| *** cshahani has joined #openstack-horizon | 02:12 | |
| *** akulshin has joined #openstack-horizon | 02:24 | |
| *** hurgleburgler has quit IRC | 02:24 | |
| *** hurgleburgler has joined #openstack-horizon | 02:24 | |
| *** ChanServ sets mode: +v hurgleburgler | 02:24 | |
| *** yamamoto has quit IRC | 02:27 | |
| *** roxanaghe has joined #openstack-horizon | 02:27 | |
| *** akulshin has quit IRC | 02:28 | |
| *** roxanaghe has quit IRC | 02:31 | |
| *** yamamoto has joined #openstack-horizon | 02:31 | |
| *** weezS has quit IRC | 02:32 | |
| *** wolverineav has joined #openstack-horizon | 02:32 | |
| *** ducttape_ has quit IRC | 02:33 | |
| *** ducttape_ has joined #openstack-horizon | 02:34 | |
| *** ducttape_ has quit IRC | 02:34 | |
| *** ducttape_ has joined #openstack-horizon | 02:34 | |
| *** wolverineav has quit IRC | 02:37 | |
| *** lblanchard has joined #openstack-horizon | 02:47 | |
| *** yamamoto has quit IRC | 02:50 | |
| *** dan_nguyen has quit IRC | 02:54 | |
| *** ducttape_ has quit IRC | 02:57 | |
| *** ducttape_ has joined #openstack-horizon | 02:58 | |
| *** ducttape_ has quit IRC | 02:58 | |
| *** wolverineav has joined #openstack-horizon | 03:06 | |
| *** weezS has joined #openstack-horizon | 03:09 | |
| *** lblanchard has quit IRC | 03:12 | |
| *** jamielennox is now known as jamielennox|away | 03:27 | |
| *** sdake_ has joined #openstack-horizon | 03:29 | |
| *** fedexo has joined #openstack-horizon | 03:30 | |
| *** sdake has quit IRC | 03:32 | |
| *** ArcTanSusan has joined #openstack-horizon | 03:36 | |
| *** jamielennox|away is now known as jamielennox | 03:37 | |
| *** dan_nguyen has joined #openstack-horizon | 03:37 | |
| *** x00350071 has quit IRC | 03:38 | |
| *** x00350071 has joined #openstack-horizon | 03:39 | |
| *** lblanchard has joined #openstack-horizon | 03:41 | |
| *** lblanchard has quit IRC | 03:45 | |
| *** yamamoto has joined #openstack-horizon | 04:01 | |
| *** roxanaghe has joined #openstack-horizon | 04:08 | |
| *** sdake_ is now known as sdake | 04:12 | |
| *** roxanaghe has quit IRC | 04:12 | |
| *** masco has joined #openstack-horizon | 04:16 | |
| *** weezS has quit IRC | 04:35 | |
| *** weezS has joined #openstack-horizon | 04:35 | |
| *** dan_nguyen has quit IRC | 04:39 | |
| *** weezS has quit IRC | 04:39 | |
| *** weezS has joined #openstack-horizon | 04:40 | |
| *** weezS has quit IRC | 04:44 | |
| *** weezS has joined #openstack-horizon | 04:45 | |
| *** shu-mutou has joined #openstack-horizon | 04:51 | |
| *** weezS has quit IRC | 04:52 | |
| *** cshahani has quit IRC | 05:07 | |
| *** amotoki has joined #openstack-horizon | 05:11 | |
| *** amotoki has quit IRC | 05:18 | |
| *** hurgleburgler has quit IRC | 05:26 | |
| *** amotoki has joined #openstack-horizon | 05:37 | |
| *** roxanaghe has joined #openstack-horizon | 05:56 | |
| *** ArcTanSusan has quit IRC | 06:00 | |
| *** roxanaghe has quit IRC | 06:01 | |
| *** wolverineav has quit IRC | 06:12 | |
| *** wolverineav has joined #openstack-horizon | 06:13 | |
| *** aortega_ has quit IRC | 06:16 | |
| *** Shahid_ has joined #openstack-horizon | 06:18 | |
| *** jtomasek has joined #openstack-horizon | 06:20 | |
| Shahid_ | Hi Team, | 06:20 |
| *** dratushnyy has joined #openstack-horizon | 06:20 | |
| mrunge | good morning | 06:21 |
| Shahid_ | i wanna implement BGP Dynamic Routing, could you recommend whether i should use angularjs or Django framework ? | 06:21 |
| mrunge | Shahid_, please use angular | 06:21 |
| Shahid_ | mrunge, thanks for the reply , so Horizon will port all existing horizon project to AngularJS ? , Django is deprecated ? | 06:24 |
| mrunge | Shahid_, no and yes | 06:24 |
| mrunge | (may port to Angular, and it's discouraged to develop new things in Django= | 06:24 |
| *** Upama has joined #openstack-horizon | 06:24 | |
| Shahid_ | mrunge , great ! | 06:25 |
| *** sdake has quit IRC | 06:48 | |
| *** Drago has joined #openstack-horizon | 06:49 | |
| *** sdake has joined #openstack-horizon | 06:50 | |
| *** Drago has quit IRC | 06:50 | |
| *** Drago has joined #openstack-horizon | 06:51 | |
| *** rdopiera has joined #openstack-horizon | 06:51 | |
| *** sdake_ has joined #openstack-horizon | 06:54 | |
| *** sdake has quit IRC | 06:56 | |
| *** sdake has joined #openstack-horizon | 07:00 | |
| *** sdake_ has quit IRC | 07:00 | |
| *** yamamoto has quit IRC | 07:04 | |
| *** sayalilunkad has joined #openstack-horizon | 07:05 | |
| *** yamamoto has joined #openstack-horizon | 07:06 | |
| *** Drago has quit IRC | 07:07 | |
| *** fedexo has quit IRC | 07:08 | |
| *** wolverineav has joined #openstack-horizon | 07:13 | |
| -openstackstatus- NOTICE: Gerrit is going to be restarted due to bad performance | 07:14 | |
| *** Shahid_ has quit IRC | 07:15 | |
| *** mpavlase has joined #openstack-horizon | 07:17 | |
| *** wolverineav has quit IRC | 07:19 | |
| *** yamamoto has quit IRC | 07:29 | |
| *** yamamoto has joined #openstack-horizon | 07:30 | |
| *** akulshin has joined #openstack-horizon | 07:32 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add feature to log operations of users to Horizon https://review.openstack.org/272935 | 07:33 |
| *** mrunge has quit IRC | 07:37 | |
| *** ejat has quit IRC | 07:37 | |
| *** ejat has joined #openstack-horizon | 07:38 | |
| *** agireud has quit IRC | 07:40 | |
| *** rcernin has joined #openstack-horizon | 07:43 | |
| *** agireud has joined #openstack-horizon | 07:43 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:44 | |
| *** sdake has quit IRC | 07:53 | |
| *** jamielennox is now known as jamielennox|away | 08:01 | |
| *** e0ne has joined #openstack-horizon | 08:02 | |
| *** aortega has joined #openstack-horizon | 08:12 | |
| *** wolverineav has joined #openstack-horizon | 08:15 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: add test for keypair import https://review.openstack.org/300972 | 08:16 |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: add test for keypair import https://review.openstack.org/300972 | 08:17 |
| *** Shahid_ has joined #openstack-horizon | 08:19 | |
| *** wolverineav has quit IRC | 08:20 | |
| *** x00350071_ has joined #openstack-horizon | 08:21 | |
| *** x00350071 has quit IRC | 08:23 | |
| *** dratushnyy has quit IRC | 08:35 | |
| *** mdavidson has quit IRC | 08:39 | |
| *** amotoki has quit IRC | 08:49 | |
| *** amotoki has joined #openstack-horizon | 08:49 | |
| *** itxaka has joined #openstack-horizon | 08:55 | |
| *** ccesario has quit IRC | 08:57 | |
| *** ccesario has joined #openstack-horizon | 08:57 | |
| *** akulshin_ has joined #openstack-horizon | 09:01 | |
| *** cshahani has joined #openstack-horizon | 09:03 | |
| *** akulshin has quit IRC | 09:05 | |
| *** cshahani has quit IRC | 09:08 | |
| *** akulshin has joined #openstack-horizon | 09:10 | |
| *** schipiga has joined #openstack-horizon | 09:10 | |
| *** akulshin_ has quit IRC | 09:14 | |
| *** amotoki has quit IRC | 09:17 | |
| *** amotoki has joined #openstack-horizon | 09:18 | |
| *** mpavlase has left #openstack-horizon | 09:21 | |
| *** mpavlase has joined #openstack-horizon | 09:21 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add feature to log operations of users to Horizon https://review.openstack.org/272935 | 09:27 |
| *** exploreshaifali has joined #openstack-horizon | 09:28 | |
| *** roxanaghe has joined #openstack-horizon | 09:32 | |
| *** mdavidson has joined #openstack-horizon | 09:35 | |
| *** roxanaghe has quit IRC | 09:36 | |
| *** tosky has joined #openstack-horizon | 09:39 | |
| robcresswell | o/ | 09:42 |
| pkarikh | robcresswell: morning! | 09:55 |
| *** vgridnev has joined #openstack-horizon | 09:59 | |
| *** Upama has quit IRC | 10:01 | |
| *** yamamoto has quit IRC | 10:03 | |
| *** yamamoto has joined #openstack-horizon | 10:04 | |
| *** yamamoto has quit IRC | 10:16 | |
| *** wolverineav has joined #openstack-horizon | 10:17 | |
| *** yamamoto has joined #openstack-horizon | 10:17 | |
| *** wolverineav has quit IRC | 10:21 | |
| *** yamamoto has quit IRC | 10:26 | |
| tsufiev | robcresswell, morning! | 10:37 |
| tsufiev | robcresswell, https://launchpadlibrarian.net/251638546/Screen%20Shot%202016-04-04%20at%2012.32.29.png - have you encountered this glitch? | 10:37 |
| *** vgridnev has quit IRC | 10:41 | |
| *** vgridnev has joined #openstack-horizon | 10:42 | |
| robcresswell | tsufiev: Hmm | 10:45 |
| robcresswell | I assume its the long strings on Network and Subnets? | 10:45 |
| tsufiev | yes, I think so | 10:45 |
| robcresswell | damn unbroken UUIDs :p | 10:47 |
| *** openstackgerrit has quit IRC | 10:48 | |
| *** openstackgerrit has joined #openstack-horizon | 10:49 | |
| tsufiev | robcresswell, just another place where we need to truncate text and show tooltips instead | 10:49 |
| *** rodrigods has quit IRC | 10:50 | |
| robcresswell | just needs a title attribute | 10:50 |
| *** rodrigods has joined #openstack-horizon | 10:51 | |
| tsufiev | yes, that's what I meant :) | 10:51 |
| robcresswell | tsufiev: Want to patch ir, or shall I? | 10:51 |
| robcresswell | it* | 10:51 |
| *** Shahid_ has quit IRC | 10:52 | |
| tsufiev | robcresswell, won't mind if you take it. I'm going to delve into Swift UI/Ceph issue | 10:52 |
| robcresswell | Cool, will do that now | 10:52 |
| tsufiev | robcresswell, actually there is another issue with LI layout (less major): https://launchpadlibrarian.net/251639246/Screen%20Shot%202016-04-04%20at%2013.00.35.png | 10:53 |
| tsufiev | look at description next to '?' button | 10:54 |
| robcresswell | tsufiev: There's a bug for that | 10:54 |
| tsufiev | robcresswell, could you find a link? | 10:54 |
| robcresswell | tsufiev: https://bugs.launchpad.net/horizon/+bug/1557817 | 10:55 |
| openstack | Launchpad bug 1557817 in OpenStack Dashboard (Horizon) "A part of description text in "Launch Instance" is hidden by "?" button" [Low,In progress] - Assigned to Kenji Ishii (ken-ishii) | 10:55 |
| tsufiev | robcresswell, thanks! | 10:55 |
| *** exploreshaifali has quit IRC | 10:55 | |
| tsufiev | the first issue is from our downstream project, https://bugs.launchpad.net/mos/+bug/1565692, I presume an upstream bug doesn't exist yet | 10:56 |
| openstack | Launchpad bug 1565692 in Mirantis OpenStack "[Horizon] Form with selecting networks is a wry" [Medium,New] - Assigned to MOS Horizon (mos-horizon) | 10:56 |
| tsufiev | will file a bug in a moment | 10:56 |
| robcresswell | tsufiev: Couldnt you just add Horizon under "Also affects project" ? Saves you time | 10:58 |
| tsufiev | robcresswell, if everyone is okay with receiving our internal CI bot notifications, I | 10:59 |
| tsufiev | I'll do it | 10:59 |
| tsufiev | in the past we separated upstream/downstream bugs because CI generated a lot of noise | 10:59 |
| tsufiev | hm... on the second thought I prefer to still keep it separate because of our tags taxonomy - it may look weird in upstream | 11:00 |
| robcresswell | Oh right | 11:02 |
| tsufiev | robcresswell, here you are https://bugs.launchpad.net/horizon/+bug/1565724 | 11:02 |
| openstack | Launchpad bug 1565724 in OpenStack Dashboard (Horizon) "Launch Instance layout breaks on long names in transfer table" [Medium,New] | 11:02 |
| *** krotscheck_vaca is now known as krotscheck | 11:13 | |
| *** masco has quit IRC | 11:13 | |
| *** yamamoto has joined #openstack-horizon | 11:14 | |
| *** yamamoto_ has joined #openstack-horizon | 11:15 | |
| *** kenji-i has quit IRC | 11:18 | |
| openstackgerrit | Sayali Lunkad proposed openstack/horizon: Confirm Dialog for Delete operation in Network Topology https://review.openstack.org/290574 | 11:18 |
| *** yamamoto has quit IRC | 11:19 | |
| *** roxanaghe has joined #openstack-horizon | 11:20 | |
| pkarikh | Do we have a filed bug for this issue? http://i.imgur.com/tIIK2ja.png | 11:23 |
| pkarikh | I believe it's low, but anyway. | 11:23 |
| *** exploreshaifali has joined #openstack-horizon | 11:24 | |
| *** roxanaghe has quit IRC | 11:25 | |
| amotoki | pkarikh: i am not sure it is filed. the issue is that the description is hidden by the question mark at the right? | 11:26 |
| openstackgerrit | Merged openstack/horizon: Set mandatory fields https://review.openstack.org/245792 | 11:28 |
| pkarikh | amotoki: nope. A question mark icon overlays end of the description line. | 11:28 |
| amotoki | pkarikh: my poor english vocabulary... we are in the sam page | 11:29 |
| *** mpavlase has quit IRC | 11:30 | |
| robcresswell | pkarikh: scroll upp :p | 11:30 |
| *** Shahid_ has joined #openstack-horizon | 11:30 | |
| robcresswell | https://bugs.launchpad.net/horizon/+bug/1557817 | 11:31 |
| openstack | Launchpad bug 1557817 in OpenStack Dashboard (Horizon) "A part of description text in "Launch Instance" is hidden by "?" button" [Low,In progress] - Assigned to Kenji Ishii (ken-ishii) | 11:31 |
| amotoki | https://bugs.launchpad.net/horizon/+bug/1557817 | 11:31 |
| amotoki | oh.... rob beat me | 11:31 |
| *** mpavlase has joined #openstack-horizon | 11:32 | |
| *** sdake has joined #openstack-horizon | 11:34 | |
| pkarikh | amotoki: I believe your english is better than mine :) | 11:34 |
| pkarikh | Yep, this is the bug I tried to find. Thanks robcresswell and amotoki. :) | 11:34 |
| amotoki | pkarikh: it is not easy to find GUI bugs by words :) | 11:34 |
| *** lblanchard has joined #openstack-horizon | 11:35 | |
| robcresswell | Aha, sorry amotoki! Thanks for following up though | 11:35 |
| *** sdake_ has joined #openstack-horizon | 11:36 | |
| *** jtomasek_ has joined #openstack-horizon | 11:36 | |
| pkarikh | amotoki: yes! While I searched and installed screenshot tool for linux which is able to draw arrows, Rob has already found a bug. :) | 11:36 |
| amotoki | btw, it seems we need to check translatability for JS pages by using pseudo translations. | 11:37 |
| amotoki | during mitaka translations, we found a lot of untranslated strings or strings which are translated in Zanata but not used. | 11:37 |
| *** sdake has quit IRC | 11:38 | |
| robcresswell | Agreed | 11:40 |
| *** mpavlase has quit IRC | 11:42 | |
| *** mpavlase has joined #openstack-horizon | 11:44 | |
| *** jtomasek_ has quit IRC | 11:50 | |
| *** mvk_ has joined #openstack-horizon | 11:57 | |
| *** neelashah has joined #openstack-horizon | 11:58 | |
| *** mvk has quit IRC | 12:00 | |
| *** akulshin has quit IRC | 12:01 | |
| *** mvk_ has quit IRC | 12:03 | |
| itxaka | pkarikh, are you on windows/linux/mac? | 12:06 |
| pkarikh | itxaka:linux | 12:06 |
| itxaka | Im trying to reproduce your issues with the network topology center button but I am unable | 12:06 |
| itxaka | I dont even get the javascript error! :s | 12:06 |
| pkarikh | hmm | 12:06 |
| pkarikh | I found out that it is d3.js error. | 12:06 |
| itxaka | did you clean up your static folder? | 12:07 |
| pkarikh | It looks very similar to this one: http://stackoverflow.com/questions/23870388/d3-js-throwing-error-invalid-value-for-g-attribute-transform-null-on-transi | 12:07 |
| itxaka | Im gonna do that, becuase lately it has given me a lot of false errors :( | 12:07 |
| pkarikh | nope, I just recollected static. but I going to try in now | 12:07 |
| itxaka | thanks! | 12:08 |
| itxaka | tried on Firefox and got the same result | 12:10 |
| pkarikh | itxaka: nope, it is still here. I deleted static dir and runned collectstatic again. And also I cleaned my cache. It is still here. | 12:11 |
| pkarikh | itxaka, are you sure about this syntax: .attr('transform', 'translate(0,0)scale(1)'); Especially about 'translate(0,0)scale(1)'? | 12:11 |
| itxaka | weeeeeeeeird | 12:11 |
| itxaka | mmmh, now I cant remember, but I think that is correct, even if it looks wrong | 12:12 |
| pkarikh | look like no. :D | 12:12 |
| itxaka | had me scratching my head for a while but some examples showed it like that | 12:12 |
| pkarikh | I'm trying to find a d3.js file on github to point you the like where it breaks | 12:13 |
| *** erlon has joined #openstack-horizon | 12:13 | |
| itxaka | from here I got the translate+scale all close and intimate with each other: http://bl.ocks.org/linssen/7352810 | 12:13 |
| itxaka | ouch, maybe that example code is wrooong | 12:14 |
| itxaka | ahh see, another example here: https://bl.ocks.org/mbostock/1345853 | 12:16 |
| pkarikh | itxaka: here is this line: https://github.com/mbostock/d3/blob/v3.1.6/d3.js#L4636 | 12:16 |
| pkarikh | here I get Invalid value for <g> attribute transform="null" | 12:17 |
| *** wolverineav has joined #openstack-horizon | 12:18 | |
| itxaka | is that line the correct one? because this is a transition, which Im guessing its treated differently? | 12:19 |
| itxaka | disclaimer: my js is as poor as possible | 12:19 |
| itxaka | may be different xstatic-d3 versions? | 12:21 |
| itxaka | gonna recreate my venv | 12:21 |
| pkarikh | Mine is XStatic-D3==3.1.6.2 | 12:22 |
| itxaka | same :( | 12:22 |
| *** wolverineav has quit IRC | 12:23 | |
| itxaka | I even get the proper <g> element when clicking the button: <g transform="translate(0,0)scale(1)"> | 12:24 |
| pkarikh | itxaka: I disabled all my chrome plugins but I have still the same error. And I my FF I got the same error. :D | 12:27 |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: add test for keypair import https://review.openstack.org/300972 | 12:28 |
| *** sdake_ has quit IRC | 12:30 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Prevent transfer tables expanding out of modal https://review.openstack.org/301089 | 12:31 |
| robcresswell | tsufiev: ^^ | 12:32 |
| itxaka | pkarikh, thanks, will investigate further to see if I can reproduce it somewhere else | 12:32 |
| itxaka | or will trick someone else to try it... :D | 12:32 |
| *** josecastroleon has joined #openstack-horizon | 12:32 | |
| *** lapalm has joined #openstack-horizon | 12:33 | |
| *** sdake has joined #openstack-horizon | 12:34 | |
| pkarikh | itxaka, yes, I believe someone else's env is a good idea. :) Maybe there is something wrong with mine. | 12:37 |
| itxaka | or mine | 12:38 |
| *** mvk_ has joined #openstack-horizon | 12:39 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Add test for keypair import https://review.openstack.org/300972 | 12:39 |
| itxaka | https://review.openstack.org/#/c/283704/ this is the patch if anyone has 5 minutes to spare testing it and reporting any issues, thanks! | 12:40 |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: WIP: Add test for backups pagination https://review.openstack.org/301099 | 12:45 |
| *** Murad has joined #openstack-horizon | 12:47 | |
| Murad | Hi | 12:47 |
| *** zul has quit IRC | 12:48 | |
| Murad | is there a tutorial or something for creating service in horizon dashboard, in the file : my_rest_api.py | 12:48 |
| *** zul has joined #openstack-horizon | 12:50 | |
| *** jpomeroy has joined #openstack-horizon | 12:50 | |
| *** kzaitsev_mb has quit IRC | 12:52 | |
| *** kzaitsev_mb has joined #openstack-horizon | 12:52 | |
| itxaka | Murad, doesnt seem to :( | 12:55 |
| itxaka | but Im guessing you can check something like magnum-ui to get a feel on how to create the rest api calls | 12:56 |
| itxaka | like this: https://github.com/openstack/magnum-ui/blob/master/magnum_ui/api/rest/magnum.py | 12:56 |
| *** peristeri has joined #openstack-horizon | 13:03 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix new Swift UI to work with Ceph backend https://review.openstack.org/301110 | 13:06 |
| tsufiev | robcresswell, looking. Meanwhile, I did fix Swift/Ceph issue ^^ | 13:07 |
| robcresswell | tsufiev: Nice! | 13:08 |
| *** roxanaghe has joined #openstack-horizon | 13:08 | |
| robcresswell | tsufiev: That looks fairly tidy too. Good job. | 13:09 |
| tsufiev | robcresswell, would be nice if somebody outside Mirantis could test it | 13:09 |
| tsufiev | giving the fix the bigger variety of Ceph deployments | 13:10 |
| *** roxanaghe has quit IRC | 13:13 | |
| *** matt-borland has joined #openstack-horizon | 13:15 | |
| robcresswell | I'll see what I can do. I'm not aware off the top of my head who has access to a Ceph deployment | 13:20 |
| *** mtanino has joined #openstack-horizon | 13:24 | |
| robcresswell | tsufiev: Cherry picked the tables fix to stable too: https://review.openstack.org/#/c/301124/ | 13:25 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Move magic-search bar out of the smart-table structure https://review.openstack.org/297291 | 13:29 |
| *** neelashah has quit IRC | 13:30 | |
| tsufiev | robcresswell, is WF-1 set for some reason? | 13:37 |
| robcresswell | tsufiev: On the backport? Waiting for master to merge | 13:37 |
| *** al_indigo has joined #openstack-horizon | 13:38 | |
| tsufiev | robcresswell, ah, ok | 13:38 |
| *** hurgleburgler has joined #openstack-horizon | 13:47 | |
| *** ChanServ sets mode: +v hurgleburgler | 13:47 | |
| amotoki | hi, does anyone explain me the role of "next" and "ongoing" milestone and when we should use them? | 13:48 |
| robcresswell | amotoki: Ongoing refers to efforts that may spen multiple cycles | 13:49 |
| amotoki | I see some bugs are targeted to "next" or "ongoing", and it seems they are not take care of well. | 13:49 |
| robcresswell | Well, thats na understatement | 13:49 |
| robcresswell | an* | 13:49 |
| *** SimonChung has joined #openstack-horizon | 13:49 | |
| robcresswell | I'm in the process of sorting out our bugs | 13:50 |
| robcresswell | Generally im targeting to N-1 for bugs likely to make it, and Next for those unlikely. If anything in Next merges, I target it to N-1 | 13:50 |
| robcresswell | So at each Milestone, we'll end up with an accurate bug list for that cycle, once I've finish triage work. | 13:50 |
| robcresswell | amotoki: ^^ | 13:51 |
| amotoki | robcresswell: thanks. I see some bugs are targeted to "next"/"ongoing" around RC phase. | 13:51 |
| robcresswell | IIRC I moved all bugs from ongoing to Next now | 13:51 |
| robcresswell | I had been targeting to Ongoing, but then realised that was wrong | 13:51 |
| amotoki | robcresswell: generally sounds good. I am fine with either way as long as the meaning of next/ongoing is clear. | 13:52 |
| robcresswell | "Next" is effectively just a backlog and means "in the future" | 13:52 |
| *** SimonChung1 has joined #openstack-horizon | 13:52 | |
| robcresswell | Whereas ongoing would be something like tox randomhashseed, where it may take a very long time to close out | 13:52 |
| amotoki | it is my long term question I forgot to raise... | 13:52 |
| *** ppiela has joined #openstack-horizon | 13:53 | |
| *** mrunge has joined #openstack-horizon | 13:53 | |
| *** ChanServ sets mode: +v mrunge | 13:53 | |
| *** SimonChung has quit IRC | 13:54 | |
| amotoki | so my understanding is we need to check next/ongoing milestone regularly (e.g. per milestone) | 13:54 |
| robcresswell | Yeah, I believe so. I'm checking once every few days. | 13:55 |
| robcresswell | Much more important is to triage the existing bugs though; pulling them in to N-* from Next is trivial :) | 13:55 |
| amotoki | yeah | 13:55 |
| *** yamamoto_ has quit IRC | 13:56 | |
| *** yamamoto has joined #openstack-horizon | 13:56 | |
| robcresswell | amotoki: BTW, most of those Neutron configuration patches look good to me (Adding Geneve etc) | 13:58 |
| robcresswell | amotoki: Would be great if you could give us some more expert reviews on those :) | 13:58 |
| andrewbogott | Could I get a core review of https://review.openstack.org/#/c/298002/ ? It's very simple! | 13:58 |
| matt-borland | andrewbogott, be happy to :) | 13:58 |
| andrewbogott | thanks! | 13:58 |
| amotoki | robcresswell: sure for d.o.a patch | 13:58 |
| *** josecastroleon has quit IRC | 13:59 | |
| amotoki | i am confused..... | 13:59 |
| robcresswell | amotoki: I think you're confusing two comments :p | 13:59 |
| amotoki | robcresswell: re the neutron configuration patch, i am a co-author of the first one. | 13:59 |
| robcresswell | Ah, I see | 14:00 |
| matt-borland | andrewbogott, are there any existing tests for backend.py? | 14:00 |
| robcresswell | I'll pester others then, thanks amotoki | 14:00 |
| amotoki | robcresswell: what i can do is to wait :) | 14:00 |
| amotoki | robcresswell: thnx for your attention | 14:00 |
| andrewbogott | matt-borland: I think there are tests but (obviously) none that try a session time of > 8000. I can write one if you think it's necessary. | 14:01 |
| robcresswell | It'd certainly prevent regression ;) | 14:01 |
| andrewbogott | yeah, looking... | 14:01 |
| robcresswell | amotoki: No problem. Trying to address bugs that have been left a long time. | 14:01 |
| matt-borland | andrewbogott, I think it's probably good to pair a change like this with a test if possible. | 14:01 |
| matt-borland | I've seen variants of this problem going back for years, across many languages :) | 14:02 |
| *** woodburn has joined #openstack-horizon | 14:05 | |
| *** sjmc7 has joined #openstack-horizon | 14:10 | |
| *** pushkaru has joined #openstack-horizon | 14:13 | |
| *** gariveradlt has joined #openstack-horizon | 14:13 | |
| *** Shahid_ has quit IRC | 14:14 | |
| *** doug-fish has joined #openstack-horizon | 14:15 | |
| *** itxaka has quit IRC | 14:18 | |
| Murad | can anybody help in creating a service in Horizon plugin ? | 14:19 |
| *** wolverineav has joined #openstack-horizon | 14:20 | |
| *** neelashah has joined #openstack-horizon | 14:21 | |
| *** pauloewerton has joined #openstack-horizon | 14:21 | |
| robcresswell | Murad: Sorry, not sure what you mean. What kind of service? | 14:24 |
| *** wolverineav has quit IRC | 14:24 | |
| *** exploreshaifali has quit IRC | 14:30 | |
| Murad | I just need to call a login service and pass password and user with the service with the request to do the login automatically | 14:31 |
| robcresswell | Sure. So what part are you stuck on? | 14:32 |
| *** piet has joined #openstack-horizon | 14:32 | |
| Murad | all I know is the I need to do something inside the /api folder, but I don't know how that work and how can I use it | 14:33 |
| robcresswell | Did you look at the examples in Magnum-UI that were linked earlier? | 14:33 |
| Murad | yes its complex I didn't understand alot, what I need is much simpler | 14:34 |
| *** amotoki has quit IRC | 14:35 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add feature to log operations of users to Horizon https://review.openstack.org/272935 | 14:37 |
| robcresswell | Murad: Complex? How so? | 14:38 |
| robcresswell | Thats how Horizon provides its APIs currently, so its either that, or write your own. | 14:38 |
| robcresswell | I can't really offer much help otherwise, I'm afraid. There are a number of examples in the Horizon code too at openstack_dashboard/api/ | 14:40 |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Checkbox for inline edit is themable https://review.openstack.org/296251 | 14:40 |
| Murad | ok, in api/magnum.py -> from magnumclient.v1 import client as magnum_client | 14:41 |
| *** ducttape_ has joined #openstack-horizon | 14:41 | |
| Murad | where is the "magnumclient" is defined | 14:41 |
| robcresswell | Ah I see. So, this is importing and wrapping the python client for the Magnumclient service | 14:41 |
| robcresswell | In your case, you'd either be wrapping your own SDK, or you'd just point your angular service directly at your existing API URL. | 14:42 |
| Murad | the service is on another server, so I have the cross domain issue and want to do it in backend | 14:43 |
| Murad | still I didn't get answer, where is "magnumclient.v1" is defined? | 14:44 |
| robcresswell | Murad: https://github.com/openstack/python-magnumclient | 14:45 |
| robcresswell | Its a dependency | 14:45 |
| Murad | so magnum is a python package | 14:45 |
| robcresswell | yes | 14:46 |
| *** jprovazn has joined #openstack-horizon | 14:48 | |
| Murad | ok, for this function for example : def baymodel_delete(request, id): return magnumclient(request).baymodels.delete(id) | 14:48 |
| Murad | how is "magnumclient(request)" have attribute .baymodels.delete(id) | 14:49 |
| *** david_cu has joined #openstack-horizon | 14:50 | |
| robcresswell | https://github.com/openstack/python-magnumclient/blob/master/magnumclient/v1/baymodels.py#L98 Is the function being called, I assume | 14:50 |
| *** hurgleburgler has quit IRC | 14:53 | |
| *** hurgleburgler has joined #openstack-horizon | 14:53 | |
| *** ChanServ sets mode: +v hurgleburgler | 14:53 | |
| Murad | I see that it has specific function, I don't if I can use it to call other services | 14:53 |
| *** hurgleburgler has quit IRC | 14:56 | |
| *** hurgleburgler has joined #openstack-horizon | 14:56 | |
| *** ChanServ sets mode: +v hurgleburgler | 14:56 | |
| *** gariveradlt has quit IRC | 15:03 | |
| *** vishwanathj has joined #openstack-horizon | 15:03 | |
| *** itxaka has joined #openstack-horizon | 15:05 | |
| *** neelashah has quit IRC | 15:08 | |
| *** garthb has joined #openstack-horizon | 15:09 | |
| *** Drago1 has joined #openstack-horizon | 15:10 | |
| *** Drago1 has quit IRC | 15:10 | |
| *** Drago1 has joined #openstack-horizon | 15:10 | |
| *** cshahani has joined #openstack-horizon | 15:12 | |
| *** pushkaru has quit IRC | 15:16 | |
| *** pushkaru has joined #openstack-horizon | 15:16 | |
| *** SimonChung1 has quit IRC | 15:19 | |
| *** vgridnev has quit IRC | 15:22 | |
| *** vgridnev has joined #openstack-horizon | 15:22 | |
| *** vgridnev has quit IRC | 15:24 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix new Swift UI to work with Ceph backend https://review.openstack.org/301110 | 15:24 |
| *** vgridnev has joined #openstack-horizon | 15:26 | |
| *** vgridnev has quit IRC | 15:26 | |
| *** neelashah has joined #openstack-horizon | 15:27 | |
| *** Mounica has joined #openstack-horizon | 15:31 | |
| *** TravT_ has quit IRC | 15:33 | |
| *** weezS has joined #openstack-horizon | 15:33 | |
| *** fedexo has joined #openstack-horizon | 15:37 | |
| *** aortega has quit IRC | 15:40 | |
| *** bpokorny has joined #openstack-horizon | 15:46 | |
| *** lhcheng has joined #openstack-horizon | 15:48 | |
| *** ChanServ sets mode: +v lhcheng | 15:48 | |
| *** david-lyle_ has quit IRC | 15:48 | |
| *** david-lyle has joined #openstack-horizon | 15:48 | |
| *** ChanServ sets mode: +o david-lyle | 15:48 | |
| *** amotoki has joined #openstack-horizon | 15:48 | |
| *** mpavlase has quit IRC | 15:49 | |
| *** josecastroleon has joined #openstack-horizon | 15:51 | |
| *** tosky has quit IRC | 15:52 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon: Add strip() to filter string in instances https://review.openstack.org/300446 | 15:52 |
| openstackgerrit | Ying Zuo proposed openstack/horizon: Pass environment data to update stack action https://review.openstack.org/300214 | 15:53 |
| *** piet has quit IRC | 15:53 | |
| *** kzaitsev_mb has quit IRC | 16:04 | |
| *** e0ne has quit IRC | 16:07 | |
| *** TravT has joined #openstack-horizon | 16:07 | |
| *** ChanServ sets mode: +v TravT | 16:07 | |
| *** SimonChung has joined #openstack-horizon | 16:11 | |
| *** TravT has quit IRC | 16:11 | |
| *** TravT has joined #openstack-horizon | 16:12 | |
| *** ChanServ sets mode: +v TravT | 16:12 | |
| *** SimonChung has quit IRC | 16:13 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: WIP: Add test for backups pagination https://review.openstack.org/301099 | 16:14 |
| *** dan_nguyen has joined #openstack-horizon | 16:14 | |
| *** SimonChung has joined #openstack-horizon | 16:15 | |
| *** wolverineav has joined #openstack-horizon | 16:22 | |
| *** fedexo has quit IRC | 16:22 | |
| *** josecastroleon has quit IRC | 16:23 | |
| *** wolverineav has quit IRC | 16:26 | |
| *** josecastroleon has joined #openstack-horizon | 16:29 | |
| *** hurgleburgler1 has joined #openstack-horizon | 16:31 | |
| *** clu_ has joined #openstack-horizon | 16:32 | |
| *** ChanServ sets mode: +v clu_ | 16:32 | |
| *** hurgleburgler has quit IRC | 16:32 | |
| *** hurgleburgler1 is now known as hurgleburgler | 16:33 | |
| *** ChanServ sets mode: +v hurgleburgler | 16:33 | |
| *** aortega has joined #openstack-horizon | 16:35 | |
| *** Mounica has quit IRC | 16:36 | |
| *** Mounica has joined #openstack-horizon | 16:38 | |
| *** Mounica_ has joined #openstack-horizon | 16:39 | |
| *** Mounica has quit IRC | 16:39 | |
| *** wolverineav has joined #openstack-horizon | 16:40 | |
| openstackgerrit | Merged openstack/horizon: Fix CheckBoxMixin:is_marked behavior https://review.openstack.org/297587 | 16:42 |
| openstackgerrit | Merged openstack/horizon: Refactor of BaseTestCase https://review.openstack.org/190077 | 16:43 |
| *** rcernin has quit IRC | 16:48 | |
| *** Drago1 has quit IRC | 16:48 | |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: WIP: Add test for backups pagination https://review.openstack.org/301099 | 16:54 |
| openstackgerrit | Sergei Chipiga proposed openstack/horizon: Add test for backups pagination https://review.openstack.org/301099 | 16:56 |
| *** hurgleburgler has quit IRC | 16:56 | |
| *** hurgleburgler has joined #openstack-horizon | 16:56 | |
| *** ChanServ sets mode: +v hurgleburgler | 16:56 | |
| *** exploreshaifali has joined #openstack-horizon | 16:58 | |
| *** josecastroleon has quit IRC | 16:59 | |
| *** weezS has quit IRC | 17:00 | |
| *** TravT has quit IRC | 17:04 | |
| *** tqtran has joined #openstack-horizon | 17:06 | |
| *** itxaka has quit IRC | 17:07 | |
| *** Drago1 has joined #openstack-horizon | 17:08 | |
| *** Drago1 has quit IRC | 17:10 | |
| *** Drago1 has joined #openstack-horizon | 17:10 | |
| openstackgerrit | David Cusatis proposed openstack/horizon: Add event broadcast to table row expansion https://review.openstack.org/287473 | 17:12 |
| *** prometheanfire has joined #openstack-horizon | 17:13 | |
| prometheanfire | does the vnc console type mean that I have to click the link to open the console in a new tab every time? Never gotten it to work in an embedded way. | 17:13 |
| prometheanfire | on stable/mitaka btw | 17:13 |
| *** neelashah has quit IRC | 17:14 | |
| *** wolverineav has quit IRC | 17:15 | |
| *** josecastroleon has joined #openstack-horizon | 17:15 | |
| openstackgerrit | Merged openstack/horizon: Prevent transfer tables expanding out of modal https://review.openstack.org/301089 | 17:21 |
| *** amotoki has quit IRC | 17:23 | |
| *** akulshin has joined #openstack-horizon | 17:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 17:25 | |
| *** jpomeroy has quit IRC | 17:28 | |
| *** akulshin has quit IRC | 17:29 | |
| *** schipiga has quit IRC | 17:33 | |
| *** mvk_ has quit IRC | 17:42 | |
| *** piet has joined #openstack-horizon | 17:42 | |
| *** josecastroleon has quit IRC | 17:45 | |
| *** wolverineav has joined #openstack-horizon | 17:46 | |
| *** wolverineav has quit IRC | 17:46 | |
| *** wolverineav has joined #openstack-horizon | 17:46 | |
| *** bpokorny has quit IRC | 17:59 | |
| *** jpomeroy has joined #openstack-horizon | 17:59 | |
| *** yamamoto has quit IRC | 18:01 | |
| *** yamamoto has joined #openstack-horizon | 18:01 | |
| *** doug-fish has quit IRC | 18:03 | |
| *** doug-fish has joined #openstack-horizon | 18:03 | |
| *** doug-fish has quit IRC | 18:03 | |
| *** lapalm_ has joined #openstack-horizon | 18:04 | |
| *** e0ne has joined #openstack-horizon | 18:06 | |
| *** lapalm has quit IRC | 18:08 | |
| *** lapalm has joined #openstack-horizon | 18:08 | |
| *** lapalm_ has quit IRC | 18:09 | |
| *** neelashah has joined #openstack-horizon | 18:11 | |
| *** akulshin has joined #openstack-horizon | 18:13 | |
| *** rdopiera has quit IRC | 18:15 | |
| *** neelashah has quit IRC | 18:15 | |
| tsufiev | robcresswell, I have a feeling that I have a fix for this kind of mysterious failure: http://logs.openstack.org/04/244104/6/gate/gate-horizon-dsvm-integration/0ed38e6/ | 18:20 |
| tsufiev | namely, https://review.openstack.org/#/c/299934/ | 18:20 |
| lcastell | Does a code reviewer needs to "recheck" this patch? https://review.openstack.org/#/c/295964/ or can I do it myself? | 18:21 |
| tsufiev | lcastell, you can do it | 18:21 |
| tsufiev | not recheck, but reverify | 18:22 |
| *** TravT has joined #openstack-horizon | 18:22 | |
| *** ChanServ sets mode: +v TravT | 18:22 | |
| *** TravT has quit IRC | 18:22 | |
| *** e0ne has quit IRC | 18:22 | |
| *** neelashah has joined #openstack-horizon | 18:22 | |
| *** TravT has joined #openstack-horizon | 18:22 | |
| *** ChanServ sets mode: +v TravT | 18:22 | |
| lcastell | thanks tsufiev! I'm asking because I just got a +2 on that and I wasn't sure :-) | 18:23 |
| lcastell | I was exited but then saw that it failed at the gate :( | 18:23 |
| *** akulshin has quit IRC | 18:23 | |
| *** jprovazn has quit IRC | 18:23 | |
| tsufiev | lcastell, that happens often with npm-based jobs :( | 18:23 |
| *** akulshin has joined #openstack-horizon | 18:25 | |
| openstackgerrit | Brian Stajkowski proposed openstack/horizon: Add Network IP Availability Extension to Subnet Table https://review.openstack.org/298498 | 18:25 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: WIP Searchlight Search Panel https://review.openstack.org/227036 | 18:26 |
| *** hurgleburgler1 has joined #openstack-horizon | 18:29 | |
| *** bpokorny has joined #openstack-horizon | 18:30 | |
| *** akulshin has quit IRC | 18:31 | |
| *** hurgleburgler has quit IRC | 18:32 | |
| robcresswell | I asked about reverify in infra once, they said its been deprecated for ages and just aliased to recheck. | 18:32 |
| tsufiev | lol ) | 18:33 |
| tsufiev | that knowledge is worth of sharing in mailing list, robcresswell :) | 18:33 |
| *** Ephur has joined #openstack-horizon | 18:34 | |
| tsufiev | robcresswell, have you seen http://lists.openstack.org/pipermail/openstack-dev/2016-April/091265.html ? | 18:35 |
| tsufiev | I'm wondering what's the right solution here... | 18:35 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: WIP Searchlight Search Panel https://review.openstack.org/227036 | 18:37 |
| david-lyle | tsufiev: on https://review.openstack.org/#/c/295964/ any concern on the integration job failing? | 18:38 |
| sjmc7 | tsufiev: for searchlight we’ve got the tarball in test-requirements | 18:38 |
| tsufiev | david-lyle, tests just timed out http://logs.openstack.org/64/295964/3/gate/gate-horizon-dsvm-integration/0798980/console.html#_2016-04-04_17_44_33_711 | 18:39 |
| tsufiev | I have a suspect :) | 18:39 |
| david-lyle | tsufiev: ok, I didn't investigate, figure it was some fragility rearing its head | 18:40 |
| david-lyle | *figured | 18:40 |
| tsufiev | david-lyle, it may have been fixed here https://review.openstack.org/#/c/299934/ (the sentence starting with 'Second,' in commit message) | 18:40 |
| tsufiev | so if it fails 3rd time, let's rebase it onto that fix and see what happens | 18:41 |
| david-lyle | tsufiev: sounds good | 18:41 |
| *** hurgleburgler1 is now known as hurgleburgler | 18:42 | |
| *** ChanServ sets mode: +v hurgleburgler | 18:42 | |
| tsufiev | sjmc7, did you change the tarball link during the split between master and stable/mitaka? | 18:42 |
| robcresswell | tsufiev: I saw that. I've been using the tarball. | 18:42 |
| sjmc7 | yeah | 18:42 |
| sjmc7 | not sure it’s merged yet but there’s a review up | 18:42 |
| *** weezS has joined #openstack-horizon | 18:43 | |
| tsufiev | hm... smelikyan states that https://github.com/openstack/monasca-ui/blob/8861bede7e06d19b265d3425208b4865c480eb69/test-requirements.txt#L25 is ignored by update.py in openstack/requirements | 18:43 |
| *** e0ne has joined #openstack-horizon | 18:43 | |
| sjmc7 | yeah… but it’s not versioned | 18:44 |
| tsufiev | unfortunately, I don't possess enough expertise to reason about dependency resolving :/ | 18:44 |
| *** tosky has joined #openstack-horizon | 18:44 | |
| robcresswell | Yeah, that just means global-reqs wont try and do anything fancy to it I thought. | 18:44 |
| sjmc7 | it will need a manual change when stable branches are made, but there’s not really a better solution given horizon’s not available through pip | 18:44 |
| tsufiev | agree, at least not until we publish every openstack component on pip | 18:45 |
| robcresswell | The request is for horizon, not o_d and horizon | 18:46 |
| robcresswell | thing is, they aren't correctly decoupled, so its not that simple | 18:47 |
| tsufiev | I doubt that horizon can be harmlessly separated from o_d at this point | 18:47 |
| robcresswell | Exactly | 18:47 |
| tsufiev | yeah | 18:47 |
| robcresswell | I tend to still hop between importing from o_d and horizon | 18:47 |
| prometheanfire | does the vnc console type mean that I have to click the link to open the console in a new tab every time? Never gotten it to work in an embedded way. | 18:47 |
| tsufiev | I remember that topic had been raised in Paris, but then it was considered that it's too much hassle vs too little benefit | 18:47 |
| robcresswell | prometheanfire: Not sure what you mean by embedded way? | 18:48 |
| david-lyle | in the horizon tabs on the details page IIUC | 18:48 |
| david-lyle | sounds like he's launching a new browser tab, but I could be worng | 18:48 |
| david-lyle | *wrong | 18:48 |
| robcresswell | tsufiev: Pretty much. Plus its not entirely clear where the split should always be. | 18:48 |
| robcresswell | david-lyle: Ah, I see | 18:49 |
| david-lyle | robcresswell: I think a split makes sense, but it's a really big lift | 18:49 |
| david-lyle | and I'm not sure we'd pull it off | 18:49 |
| david-lyle | so again back to the gain vs effort | 18:49 |
| david-lyle | we don't need to package in our toolkit | 18:50 |
| tsufiev | I guess it's 10 times harder than Django19 preparations :) | 18:50 |
| david-lyle | I don't even have a guess | 18:50 |
| david-lyle | destabilization is my biggest concern | 18:50 |
| robcresswell | I agree on all those points. | 18:50 |
| prometheanfire | robcresswell: david-lyle: when I click on the console tab nothing shows up but the option to open a new tab with the vnc url directly | 18:51 |
| robcresswell | There are bigger priority items for us and plugins too | 18:51 |
| prometheanfire | the vnc session is not embedded into the page as anything other than a link | 18:51 |
| david-lyle | prometheanfire: I have not tried that recently | 18:52 |
| tsufiev | robcresswell, should we articulate that POV in ML? I could just reply with IRC log excerpt | 18:52 |
| prometheanfire | running stable/mitaka as well | 18:52 |
| david-lyle | tsufiev: isn't the ask to deliver Horizon as a whole to pypi? | 18:52 |
| robcresswell | tsufiev: I'll reply tomorrow either way | 18:53 |
| tsufiev | david-lyle, it's ambigious :) | 18:53 |
| david-lyle | I suppose we could deliver both | 18:53 |
| tsufiev | I'm not sure if it's just about horizon or horizon + o_d | 18:53 |
| david-lyle | since that's how it's typically packaged | 18:53 |
| tsufiev | +1 to delivering both | 18:53 |
| prometheanfire | if that happens I might be able to re-package horizon, unless all those js deps are not bundled | 18:53 |
| *** kzaitsev_mb has quit IRC | 18:53 | |
| robcresswell | Frankly, the tarball include and manually altering it for a stable branch is not a huge issue. | 18:53 |
| david-lyle | there was concern before about publishing services to pypi | 18:53 |
| david-lyle | prometheanfire: still not bundled | 18:54 |
| *** jaimguer has joined #openstack-horizon | 18:54 | |
| tsufiev | david-lyle, I'd rather treat o_d as an application than as a service | 18:54 |
| prometheanfire | oh boo | 18:55 |
| tsufiev | the distinction seems so... theoretical :/ | 18:55 |
| *** pushkaru has quit IRC | 18:58 | |
| *** pushkaru has joined #openstack-horizon | 19:00 | |
| robcresswell | I suppose also it should be in requirements, not test-requirements | 19:02 |
| *** vgridnev has joined #openstack-horizon | 19:02 | |
| david-lyle | robcresswell: should yes | 19:03 |
| andrewbogott | matt-borland: I'm pretty much lost. The backend monkeys with request.session but doesn't pass it on to anyone, so I assume it's modifying the passed in arg, which is then used by a parent method? Anyway I have no idea how to access that object from the test framework. Any suggestions? | 19:04 |
| *** kzaitsev_mb has joined #openstack-horizon | 19:08 | |
| *** akulshin has joined #openstack-horizon | 19:08 | |
| *** sdake_ has joined #openstack-horizon | 19:12 | |
| *** sdake has quit IRC | 19:15 | |
| *** ArcTanSusan has joined #openstack-horizon | 19:19 | |
| *** dratushnyy has joined #openstack-horizon | 19:20 | |
| *** hurgleburgler1 has joined #openstack-horizon | 19:22 | |
| *** hurgleburgler has quit IRC | 19:22 | |
| *** hurgleburgler1 is now known as hurgleburgler | 19:22 | |
| *** ChanServ sets mode: +v hurgleburgler | 19:22 | |
| openstackgerrit | Brian Stajkowski proposed openstack/horizon: Add Network IP Availability Extension https://review.openstack.org/283171 | 19:26 |
| david-lyle | andrewbogott: I've written more d-o-a tests than I want to remember, where are you having a problem | 19:27 |
| *** hurgleburgler1 has joined #openstack-horizon | 19:29 | |
| *** hurgleburgler has quit IRC | 19:29 | |
| andrewbogott | david-lyle: big picture: I want to twiddle settings.SESSION_TIMEOUT and verify that the changes are accurately reflected in later calls to request.session.set_expiry() | 19:29 |
| *** akulshin has quit IRC | 19:31 | |
| andrewbogott | Maybe I can just mock out that exact function and check the args… will give that a go | 19:32 |
| david-lyle | andrewbogott: I would suggest adding a new token in say https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/tests/data_v3.py where the expiration is | 19:32 |
| david-lyle | either programmatic or more inline with the value you're wanting to test | 19:32 |
| david-lyle | that may get involved though | 19:32 |
| david-lyle | I like mocking the method itself | 19:33 |
| david-lyle | much simpler | 19:33 |
| david-lyle | test would be somewhat vacuous though | 19:36 |
| david-lyle | probably better to mock getting the user property and having it return a custom token | 19:36 |
| *** akulshin has joined #openstack-horizon | 19:37 | |
| david-lyle | andrewbogott: I'm really not sure a test is warranted | 19:38 |
| *** hurgleburgler1 is now known as hurgleburgler | 19:38 | |
| *** ChanServ sets mode: +v hurgleburgler | 19:38 | |
| *** cloudtrainme has joined #openstack-horizon | 19:39 | |
| david-lyle | just seems like a bug in expected return value, but once you're returning an int, checking the min method in python seems of little value | 19:39 |
| andrewbogott | david-lyle: this is https://review.openstack.org/#/c/298002/ | 19:39 |
| david-lyle | yeah, I saw it in the scrollback | 19:40 |
| david-lyle | I'm not commenting glibly :) | 19:40 |
| andrewbogott | Ah, ok, sorry. | 19:40 |
| david-lyle | you're going to mock a lot, or mock to the point that you're controlling total_seconds | 19:41 |
| david-lyle | which both eventually test min() | 19:41 |
| *** piet has quit IRC | 19:41 | |
| andrewbogott | I have no objection to the patch being merged without a test, but given that it was wrong, it's clearly /possible/ to do wrong | 19:42 |
| david-lyle | I will comment on the review | 19:42 |
| david-lyle | andrewbogott: no doubt, but what test is going to prevent it from being wrong in the future | 19:42 |
| david-lyle | ? | 19:42 |
| david-lyle | that's a thing that once you have it right should just work | 19:43 |
| *** exploreshaifali has quit IRC | 19:44 | |
| andrewbogott | Agreed that it's not at all clear how/what to test | 19:44 |
| andrewbogott | And writing a test for three lines of date math is a bit excessive anyway | 19:44 |
| *** ArcTanSusan has quit IRC | 19:47 | |
| david-lyle | andrewbogott: review added | 19:48 |
| *** ArcTanSusan has joined #openstack-horizon | 19:48 | |
| andrewbogott | david-lyle: thank you! | 19:49 |
| *** neelashah1 has joined #openstack-horizon | 19:59 | |
| *** Mounica_ has quit IRC | 19:59 | |
| *** tqtran is now known as tqtran-afk | 20:00 | |
| *** neelashah has quit IRC | 20:02 | |
| *** SimonChung1 has joined #openstack-horizon | 20:03 | |
| *** SimonChung has quit IRC | 20:03 | |
| *** weezS has quit IRC | 20:06 | |
| *** hurgleburgler1 has joined #openstack-horizon | 20:08 | |
| *** weezS has joined #openstack-horizon | 20:08 | |
| *** hurgleburgler has quit IRC | 20:08 | |
| *** e0ne has quit IRC | 20:11 | |
| *** TravT has quit IRC | 20:13 | |
| *** sdake_ is now known as sdake | 20:14 | |
| *** vgridnev has quit IRC | 20:15 | |
| *** Mounica has joined #openstack-horizon | 20:23 | |
| *** ZZelle_ has joined #openstack-horizon | 20:24 | |
| *** neelashah1 has quit IRC | 20:30 | |
| *** ArcTanSusan has quit IRC | 20:32 | |
| *** ArcTanSusan has joined #openstack-horizon | 20:32 | |
| *** ArcTanSusan has quit IRC | 20:34 | |
| *** sdake_ has joined #openstack-horizon | 20:34 | |
| *** sdake has quit IRC | 20:34 | |
| *** tqtran-afk is now known as tqtran | 20:36 | |
| *** Qingqing has joined #openstack-horizon | 20:41 | |
| *** TravT has joined #openstack-horizon | 20:47 | |
| *** ChanServ sets mode: +v TravT | 20:47 | |
| *** lblanchard has quit IRC | 20:53 | |
| *** Mounica has quit IRC | 20:54 | |
| *** mvk_ has joined #openstack-horizon | 20:57 | |
| *** lapalm has quit IRC | 21:01 | |
| *** mpavlase has joined #openstack-horizon | 21:02 | |
| *** vgridnev has joined #openstack-horizon | 21:02 | |
| *** SimonChung has joined #openstack-horizon | 21:04 | |
| *** SimonChung1 has quit IRC | 21:04 | |
| *** jpomeroy has quit IRC | 21:04 | |
| *** SimonChung1 has joined #openstack-horizon | 21:04 | |
| *** SimonChung has quit IRC | 21:04 | |
| r1chardj0n3s | morning | 21:05 |
| *** SimonChung1 has quit IRC | 21:05 | |
| *** SimonChung has joined #openstack-horizon | 21:05 | |
| david-lyle | morning r1chardj0n3s | 21:06 |
| *** jpomeroy has joined #openstack-horizon | 21:07 | |
| lcastell | morning! | 21:08 |
| *** TravT has quit IRC | 21:11 | |
| *** sdake_ has quit IRC | 21:14 | |
| *** Mounica has joined #openstack-horizon | 21:18 | |
| *** pauloewerton has quit IRC | 21:20 | |
| *** mrkz has joined #openstack-horizon | 21:21 | |
| *** pushkaru has quit IRC | 21:24 | |
| jlopezgu | morning | 21:24 |
| *** ChanServ sets mode: +v tqtran | 21:27 | |
| *** peristeri has quit IRC | 21:35 | |
| *** bpokorny has quit IRC | 21:35 | |
| *** vgridnev has quit IRC | 21:36 | |
| openstackgerrit | Merged openstack/horizon: fix-legend-overflow https://review.openstack.org/252036 | 21:39 |
| openstackgerrit | Merged openstack/horizon: Fix typos in Horizon files https://review.openstack.org/299709 | 21:41 |
| *** akulshin has quit IRC | 21:43 | |
| *** jpomeroy has quit IRC | 21:43 | |
| *** Raildo has joined #openstack-horizon | 21:44 | |
| *** akulshin has joined #openstack-horizon | 21:48 | |
| openstackgerrit | Marcellin Fom Tchassem proposed openstack/horizon: Paragraph on Developer tab not translated https://review.openstack.org/301362 | 21:51 |
| *** akulshin has quit IRC | 21:53 | |
| *** Raildo_ has joined #openstack-horizon | 21:53 | |
| *** sdake has joined #openstack-horizon | 21:54 | |
| openstackgerrit | Merged openstack/horizon: Fix some trivial errors in plugin.rst https://review.openstack.org/299468 | 21:56 |
| *** Raildo has quit IRC | 21:57 | |
| *** Raildo_ is now known as raildo | 21:58 | |
| *** jpomeroy has joined #openstack-horizon | 21:58 | |
| *** matt-borland has quit IRC | 21:58 | |
| *** david_cu has quit IRC | 21:59 | |
| *** pushkaru has joined #openstack-horizon | 21:59 | |
| *** david-lyle_ has joined #openstack-horizon | 22:02 | |
| *** hurgleburgler1 has quit IRC | 22:02 | |
| *** hurgleburgler has joined #openstack-horizon | 22:02 | |
| *** ChanServ sets mode: +v hurgleburgler | 22:02 | |
| *** david-lyle has quit IRC | 22:03 | |
| *** david-lyle_ is now known as david-lyle | 22:03 | |
| *** ChanServ sets mode: +o david-lyle | 22:03 | |
| *** pumarani__ has joined #openstack-horizon | 22:04 | |
| *** ArcTanSusan has joined #openstack-horizon | 22:06 | |
| *** pushkaru has quit IRC | 22:07 | |
| *** ducttape_ has quit IRC | 22:12 | |
| *** Qingqing has quit IRC | 22:18 | |
| *** Mounica has quit IRC | 22:21 | |
| *** TravT has joined #openstack-horizon | 22:21 | |
| *** ChanServ sets mode: +v TravT | 22:21 | |
| *** TravT has quit IRC | 22:22 | |
| *** TravT has joined #openstack-horizon | 22:24 | |
| *** ChanServ sets mode: +v TravT | 22:24 | |
| *** jpomeroy has quit IRC | 22:25 | |
| *** cloudtrainme has quit IRC | 22:27 | |
| *** Mounica has joined #openstack-horizon | 22:31 | |
| *** sdake has quit IRC | 22:36 | |
| *** ArcTanSusan has quit IRC | 22:38 | |
| *** pumarani__ has quit IRC | 22:40 | |
| *** ybathia has joined #openstack-horizon | 22:43 | |
| *** rebase has joined #openstack-horizon | 22:44 | |
| *** david-lyle has quit IRC | 22:44 | |
| *** david-lyle has joined #openstack-horizon | 22:47 | |
| *** ChanServ sets mode: +o david-lyle | 22:47 | |
| *** mrkz has quit IRC | 22:51 | |
| *** weezS has quit IRC | 23:00 | |
| *** mpavlase has quit IRC | 23:02 | |
| *** pushkaru has joined #openstack-horizon | 23:14 | |
| *** chlong has joined #openstack-horizon | 23:18 | |
| *** Mounica has quit IRC | 23:18 | |
| *** Mounica has joined #openstack-horizon | 23:22 | |
| *** ybathia has quit IRC | 23:22 | |
| *** rebase_ has joined #openstack-horizon | 23:25 | |
| *** ducttape_ has joined #openstack-horizon | 23:26 | |
| *** rebase has quit IRC | 23:27 | |
| *** ducttape_ has quit IRC | 23:28 | |
| *** TravT has quit IRC | 23:29 | |
| *** rebase_ has quit IRC | 23:29 | |
| *** TravT has joined #openstack-horizon | 23:32 | |
| *** ChanServ sets mode: +v TravT | 23:32 | |
| *** TravT has quit IRC | 23:40 | |
| *** TravT has joined #openstack-horizon | 23:50 | |
| *** ChanServ sets mode: +v TravT | 23:50 | |
| *** pushkaru has quit IRC | 23:51 | |
| *** ybathia has joined #openstack-horizon | 23:59 | |
| *** Drago1 has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
