*** tosky has quit IRC | 00:08 | |
*** jaimguer has quit IRC | 00:14 | |
*** garthb has quit IRC | 00:14 | |
*** ybathia has quit IRC | 00:19 | |
*** pushkaru has joined #openstack-horizon | 00:19 | |
*** ZZelle_ has quit IRC | 00:22 | |
*** Mounica has quit IRC | 00:36 | |
*** jamielennox|away is now known as jamielennox | 00:41 | |
*** julim has quit IRC | 00:43 | |
*** SimonChung has quit IRC | 00:44 | |
*** clu_ has quit IRC | 00:44 | |
*** lhcheng has quit IRC | 00:48 | |
*** dratushnyy has quit IRC | 00:59 | |
*** sdake has joined #openstack-horizon | 00:59 | |
*** dratushnyy has joined #openstack-horizon | 01:00 | |
*** dratushnyy has quit IRC | 01:00 | |
*** kzaitsev_mb has quit IRC | 01:03 | |
*** ducttape_ has joined #openstack-horizon | 01:07 | |
*** dan_nguyen has quit IRC | 01:26 | |
*** pushkaru has quit IRC | 01:26 | |
*** ducttape_ has quit IRC | 01:37 | |
*** Drago has joined #openstack-horizon | 01:37 | |
*** Drago has quit IRC | 01:37 | |
*** Drago has joined #openstack-horizon | 01:37 | |
*** jamielennox is now known as jamielennox|away | 01:41 | |
*** jamielennox|away is now known as jamielennox | 01:44 | |
*** Drago has quit IRC | 01:44 | |
*** weezS has joined #openstack-horizon | 01:46 | |
*** ducttape_ has joined #openstack-horizon | 01:55 | |
*** ducttape_ has quit IRC | 01:55 | |
*** pushkaru has joined #openstack-horizon | 01:56 | |
*** wolverin_ has joined #openstack-horizon | 01:59 | |
*** ducttape_ has joined #openstack-horizon | 02:00 | |
*** wolverin_ has quit IRC | 02:01 | |
*** wolverineav has quit IRC | 02:02 | |
*** lcastell_ has joined #openstack-horizon | 02:04 | |
*** lcastell_ has quit IRC | 02:05 | |
*** wolverineav has joined #openstack-horizon | 02:05 | |
*** lcastell_ has joined #openstack-horizon | 02:09 | |
*** wolverineav has quit IRC | 02:10 | |
*** zhurong has joined #openstack-horizon | 02:14 | |
*** lcastell_ has quit IRC | 02:15 | |
*** raildo has quit IRC | 02:19 | |
*** wolverineav has joined #openstack-horizon | 02:21 | |
*** wolverin_ has joined #openstack-horizon | 02:22 | |
*** ducttape_ has quit IRC | 02:23 | |
*** pushkaru has quit IRC | 02:24 | |
*** wolverineav has quit IRC | 02:25 | |
*** zhurong has quit IRC | 02:26 | |
*** ducttape_ has joined #openstack-horizon | 02:27 | |
*** kzaitsev_mb has joined #openstack-horizon | 02:28 | |
*** wolverin_ has quit IRC | 02:29 | |
*** yamamoto has quit IRC | 02:32 | |
*** kzaitsev_mb has quit IRC | 02:34 | |
*** ducttape_ has quit IRC | 02:34 | |
*** zhurong has joined #openstack-horizon | 02:40 | |
*** yamamoto has joined #openstack-horizon | 02:40 | |
*** ducttape_ has joined #openstack-horizon | 02:40 | |
openstackgerrit | Shan Guo proposed openstack/horizon: Add popular ip protocols name in security group https://review.openstack.org/286430 | 02:46 |
---|---|---|
*** weezS has quit IRC | 02:46 | |
*** yamamoto has quit IRC | 02:48 | |
*** weezS has joined #openstack-horizon | 02:50 | |
*** ducttape_ has quit IRC | 02:51 | |
*** yamamot__ has joined #openstack-horizon | 02:51 | |
*** lhcheng has joined #openstack-horizon | 02:52 | |
*** ChanServ sets mode: +v lhcheng | 02:52 | |
*** weezS has quit IRC | 02:54 | |
*** wangbo has joined #openstack-horizon | 02:57 | |
*** tqtran has quit IRC | 03:01 | |
*** yamamot__ has quit IRC | 03:02 | |
*** sdake has quit IRC | 03:02 | |
*** ducttape_ has joined #openstack-horizon | 03:02 | |
*** ducttape_ has quit IRC | 03:13 | |
*** sekrit has joined #openstack-horizon | 03:17 | |
*** erlon has quit IRC | 03:17 | |
*** neelashah has joined #openstack-horizon | 03:21 | |
*** neelashah has quit IRC | 03:23 | |
*** wolverineav has joined #openstack-horizon | 03:24 | |
*** wolverineav has quit IRC | 03:29 | |
*** kzaitsev_mb has joined #openstack-horizon | 03:30 | |
*** SimonChung has joined #openstack-horizon | 03:31 | |
*** SimonChung1 has joined #openstack-horizon | 03:35 | |
*** SimonChung has quit IRC | 03:38 | |
openstackgerrit | Allen proposed openstack/horizon: Make the volume transfer name field required https://review.openstack.org/301432 | 03:42 |
*** SimonChung1 has quit IRC | 03:46 | |
*** fedexo has joined #openstack-horizon | 03:47 | |
*** dan_nguyen has joined #openstack-horizon | 03:47 | |
*** yamamot__ has joined #openstack-horizon | 03:48 | |
*** wolverineav has joined #openstack-horizon | 03:50 | |
*** tqtran has joined #openstack-horizon | 03:59 | |
*** masco has joined #openstack-horizon | 04:02 | |
*** tqtran has quit IRC | 04:03 | |
*** garthb has joined #openstack-horizon | 04:09 | |
*** cshahani has quit IRC | 04:09 | |
*** dratushnyy has joined #openstack-horizon | 04:11 | |
*** dan_nguyen has quit IRC | 04:11 | |
*** kzaitsev_mb has quit IRC | 04:18 | |
*** patk has quit IRC | 04:33 | |
*** patk has joined #openstack-horizon | 04:37 | |
*** akulshin has joined #openstack-horizon | 04:44 | |
*** akulshin has quit IRC | 04:45 | |
*** akulshin has joined #openstack-horizon | 04:45 | |
*** garthb has quit IRC | 04:46 | |
*** mtanino has quit IRC | 04:53 | |
*** Shahid_ has joined #openstack-horizon | 04:58 | |
*** tqtran has joined #openstack-horizon | 05:00 | |
*** akulshin has quit IRC | 05:03 | |
*** tqtran has quit IRC | 05:04 | |
*** akulshin has joined #openstack-horizon | 05:06 | |
*** kzaitsev_mb has joined #openstack-horizon | 05:14 | |
*** cshahani has joined #openstack-horizon | 05:16 | |
*** kzaitsev_mb has quit IRC | 05:19 | |
*** jamielennox is now known as jamielennox|away | 05:27 | |
openstackgerrit | Merged openstack/horizon: Optimize "open" method with context manager https://review.openstack.org/250693 | 05:32 |
*** akulshin has quit IRC | 05:32 | |
*** akulshin has joined #openstack-horizon | 05:33 | |
openstackgerrit | Merged openstack/horizon: Fixing the deprecated library function. https://review.openstack.org/262727 | 05:34 |
*** akulshin has quit IRC | 05:38 | |
*** fedexo has quit IRC | 05:51 | |
*** rcernin has joined #openstack-horizon | 05:51 | |
*** dratushnyy has quit IRC | 05:53 | |
*** josecastroleon has joined #openstack-horizon | 06:00 | |
*** vgridnev has joined #openstack-horizon | 06:08 | |
*** lhcheng has quit IRC | 06:10 | |
*** cshahani has quit IRC | 06:14 | |
*** kzaitsev_mb has joined #openstack-horizon | 06:15 | |
*** kzaitsev_mb has quit IRC | 06:20 | |
*** aortega has quit IRC | 06:20 | |
*** hurgleburgler has quit IRC | 06:27 | |
*** ArcTanSusan has joined #openstack-horizon | 06:30 | |
*** ArcTanSusan has quit IRC | 06:37 | |
Murad | HEllo | 06:42 |
*** vgridnev has quit IRC | 06:47 | |
*** mpavlase has joined #openstack-horizon | 06:47 | |
*** vgridnev has joined #openstack-horizon | 06:47 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 06:49 | |
*** rdopiera has joined #openstack-horizon | 06:51 | |
*** rdopiera has quit IRC | 06:56 | |
*** rdopiera has joined #openstack-horizon | 06:57 | |
*** x00350071_ is now known as xiangxinyong | 07:06 | |
*** akulshin_ has joined #openstack-horizon | 07:09 | |
*** Shahid_ has quit IRC | 07:13 | |
*** kzaitsev_mb has joined #openstack-horizon | 07:16 | |
*** wolverineav has quit IRC | 07:17 | |
*** kzaitsev_mb has quit IRC | 07:21 | |
*** wangbo has quit IRC | 07:25 | |
*** aortega has joined #openstack-horizon | 07:37 | |
*** pcaruana has joined #openstack-horizon | 07:37 | |
*** wangbo has joined #openstack-horizon | 07:38 | |
*** lhcheng has joined #openstack-horizon | 07:43 | |
*** ChanServ sets mode: +v lhcheng | 07:43 | |
robcresswell | Murad: Morning. How can I help? | 07:50 |
Murad | I am trying to implement rest service in horizon plugin, I want to share code | 07:54 |
*** lhcheng has quit IRC | 07:54 | |
Murad | here : http://paste2.org/Ga4zK9N1 is a very basic file in /api folder | 07:55 |
Murad | I tried to test it in browser : 10.224.14.78/dashboard/api/murano/packages but give 404, maybe its not the proper way to use it | 07:56 |
Murad | maybe I need to register the api or something | 07:57 |
*** tqtran has joined #openstack-horizon | 08:01 | |
*** tqtran has quit IRC | 08:05 | |
*** exploreshaifali has joined #openstack-horizon | 08:11 | |
robcresswell | Murad: Hmm, looking | 08:15 |
*** kzaitsev_mb has joined #openstack-horizon | 08:17 | |
*** wolverineav has joined #openstack-horizon | 08:18 | |
*** mvk_ has quit IRC | 08:19 | |
*** kzaitsev_mb has quit IRC | 08:21 | |
*** wolverineav has quit IRC | 08:23 | |
*** vgridnev has quit IRC | 08:24 | |
*** Shahid_ has joined #openstack-horizon | 08:24 | |
*** JeanBriceCombebi has joined #openstack-horizon | 08:24 | |
*** mpavlase has quit IRC | 08:26 | |
*** mpavlase has joined #openstack-horizon | 08:31 | |
*** mpavlase has left #openstack-horizon | 08:31 | |
*** chlong has quit IRC | 08:35 | |
*** e0ne has joined #openstack-horizon | 08:37 | |
*** Shahid_ has quit IRC | 08:37 | |
*** wangbo has quit IRC | 08:42 | |
*** mvk_ has joined #openstack-horizon | 08:45 | |
*** Shahid_ has joined #openstack-horizon | 08:51 | |
*** Liuqing has joined #openstack-horizon | 08:54 | |
rdopiera | in case someone wonders why we don't use standard node tools to install js dependencies -- github is down :D | 08:59 |
*** itxaka has joined #openstack-horizon | 09:00 | |
*** wangbo has joined #openstack-horizon | 09:02 | |
*** zhurong has quit IRC | 09:04 | |
pkarikh | Hmm, our npm-run-lint job is failing again? | 09:04 |
robcresswell | Yup | 09:05 |
robcresswell | Murad: That URL should be correct. You can try hitting things like /api/policy and see that it ownt 404 | 09:09 |
robcresswell | wont* | 09:09 |
*** JeanBriceCombebi has quit IRC | 09:10 | |
Murad | yes I know, other APIs works | 09:10 |
tsufiev | seriously, we need to do something about npm-* jobs | 09:12 |
tsufiev | I got an impression that they are failing in 50% of the cases | 09:12 |
robcresswell | tsufiev: More than that | 09:13 |
robcresswell | tsufiev: if you look at the front page of horizon right now its constant failures | 09:13 |
tsufiev | robcresswell, you mean, jobs always fail on npm, 100%? | 09:13 |
tsufiev | robcresswell, all *-npm-run-* jobs are affected, not only horizon ones | 09:17 |
*** kzaitsev_mb has joined #openstack-horizon | 09:17 | |
*** vgridnev has joined #openstack-horizon | 09:20 | |
*** tosky has joined #openstack-horizon | 09:20 | |
*** tosky has quit IRC | 09:20 | |
*** tosky has joined #openstack-horizon | 09:21 | |
*** Liuqing has quit IRC | 09:21 | |
robcresswell | I hadnt checked the non-horizon jobs | 09:22 |
r1chardj0n3s_afk | github is down, that might maybe affect npm?? | 09:22 |
r1chardj0n3s_afk | it would affect bower | 09:22 |
r1chardj0n3s_afk | hmm, github less down that twitter might think | 09:23 |
robcresswell | Does npm just pull its packages from github? I've not looking into how npm works. | 09:23 |
*** JeanBriceCombebi has joined #openstack-horizon | 09:23 | |
*** ygbo has joined #openstack-horizon | 09:23 | |
tsufiev | r1chardj0n3s_afk, it seems we need a mirror | 09:23 |
pkarikh | I'n not sure about github | 09:23 |
r1chardj0n3s_afk | I thought npm had local packages and github references, but I've not really looked that closely :/ | 09:23 |
itxaka | phantomjs is pulled from bitbucket and that failed in one job | 09:23 |
itxaka | http://logs.openstack.org/54/276654/19/gate/gate-horizon-npm-run-lint/5fa10f9/console.html#_2016-04-04_21_05_03_752 | 09:23 |
itxaka | npmgate | 09:24 |
itxaka | :D | 09:24 |
r1chardj0n3s_afk | but yes, we really do need mirror of npm :/ | 09:24 |
pkarikh | itxaka: :D | 09:24 |
itxaka | something like npm-local would be great | 09:26 |
itxaka | so it doesnt replicate the whole npm registry | 09:26 |
robcresswell | That exists already | 09:26 |
robcresswell | I think | 09:26 |
itxaka | weeeelll | 09:26 |
itxaka | actually npm-local is the name of it :P | 09:26 |
robcresswell | There you go :p | 09:27 |
r1chardj0n3s_afk | there you go :-) | 09:27 |
itxaka | deja-vu | 09:27 |
r1chardj0n3s_afk | again | 09:27 |
r1chardj0n3s_afk | ;-) | 09:27 |
itxaka | but we dont have a pypi mirror anyway so not sure how feasible an npm one is :( | 09:28 |
r1chardj0n3s_afk | sure we have pypi mirrors | 09:29 |
r1chardj0n3s_afk | well, #infra does | 09:29 |
itxaka | but our jobs dont point to them no? | 09:30 |
r1chardj0n3s_afk | they should | 09:30 |
mrunge | yeah, that's my understanding | 09:30 |
mrunge | but iirc that does not work with npm at all | 09:31 |
r1chardj0n3s_afk | it's part of the Devstack Magic(tm) | 09:31 |
itxaka | ohh | 09:31 |
robcresswell | They should rename it to magicstack | 09:31 |
robcresswell | thats a great name | 09:31 |
r1chardj0n3s_afk | productionstack would be appropriate also ;-) | 09:31 |
robcresswell | haha | 09:31 |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 09:40 |
tsufiev | r1chardj0n3s_afk, could you take a look at https://review.openstack.org/#/c/301110/ when you're less away )? | 09:45 |
tsufiev | it's a fix for Swift UI to work on Ceph | 09:45 |
*** JeanBriceCombebi has quit IRC | 09:53 | |
*** JeanBriceCombebi has joined #openstack-horizon | 09:56 | |
*** Liuqing has joined #openstack-horizon | 09:57 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Handle non ASCII tenant names gracefully when downloading RC file https://review.openstack.org/279573 | 10:00 |
*** schipiga has joined #openstack-horizon | 10:03 | |
*** JeanBriceCombebi has quit IRC | 10:04 | |
*** JeanBriceCombebi has joined #openstack-horizon | 10:04 | |
openstackgerrit | LIU Yulong proposed openstack/horizon: Add help text to some DeleteAction https://review.openstack.org/139920 | 10:04 |
*** kzaitsev_mb has quit IRC | 10:15 | |
openstackgerrit | Allen proposed openstack/horizon: Make the volume transfer name field required https://review.openstack.org/301432 | 10:17 |
pkarikh | itxaka: did you tried your "center the network topology" patch on someone's env? | 10:17 |
itxaka | pkarikh, nope | 10:17 |
itxaka | was goping trougth my other patches first, lots of -1 while I was on PTO :) | 10:18 |
itxaka | After that I will totally kill my env and reproduce it again | 10:18 |
itxaka | *try to reproduce it | 10:19 |
*** eandersson has joined #openstack-horizon | 10:19 | |
*** wolverineav has joined #openstack-horizon | 10:20 | |
pkarikh | itxaka: ok. I'm just going to try one idea | 10:23 |
*** wolverineav has quit IRC | 10:24 | |
*** yamamot__ has quit IRC | 10:34 | |
openstackgerrit | Sergei Chipiga proposed openstack/horizon: Add test for backups pagination https://review.openstack.org/301099 | 10:37 |
itxaka | argh, sometime pycharm just chokes on the javascript files :( | 10:41 |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Validate minimum RAM for snapshot source https://review.openstack.org/257489 | 10:42 |
r1chardj0n3s_afk | tsufiev: done! thanks :-_) | 10:43 |
r1chardj0n3s_afk | nn | 10:43 |
tsufiev | r1chardj0n3s_afk, I hope we'll amend this to RC3, it's really critical for Ceph backed deployments | 10:44 |
* tsufiev wonders if it's possible to unit-test new Swift UI both against Swift and Ceph... | 10:45 | |
*** ygbo has quit IRC | 10:46 | |
itxaka | Stable team, would something like this be considered critical enough to get into liberty? https://bugs.launchpad.net/horizon/+bug/1553978 | 10:50 |
openstack | Launchpad bug 1553978 in OpenStack Dashboard (Horizon) "create subnet dialogue - inaccessible Next/Submit button" [Undecided,Confirmed] - Assigned to Itxaka Serrano (itxakaserrano) | 10:50 |
*** exploreshaifali has quit IRC | 10:53 | |
*** sdake has joined #openstack-horizon | 11:00 | |
*** akulshin_ has quit IRC | 11:01 | |
itxaka | pkarikh, thanks! great finding, I can now reproduce it and thanks for also posting the solution! | 11:05 |
pkarikh | itxaka: so, looks like I found out why I got that error in your patch. There is nothing wrong with 'translate(0,0)scale(1)'. See my comment there. | 11:05 |
*** akulshin has joined #openstack-horizon | 11:05 | |
pkarikh | itxaka: you are faster. :D | 11:05 |
tsufiev | robcresswell, do you think it makes sense to temporarily make npm-run jobs non-voting? | 11:05 |
pkarikh | np. :) | 11:05 |
robcresswell | itxaka: That does seem like a major bug. I'll discuss with david and others later | 11:07 |
itxaka | robcresswell, thanks | 11:07 |
itxaka | are you part of the stable team? | 11:07 |
robcresswell | tsufiev: Do we have a reason for this? | 11:07 |
itxaka | I didnt knew that, that means I can spam you on EU hours :D | 11:07 |
robcresswell | itxaka: I haven't been, no, although given the number of cores we have its probably worthwhile | 11:08 |
mrunge | itxaka, robcresswell is part of the stable team, even if he doesn't know | 11:08 |
itxaka | I'll spam you anyway, no problem | 11:08 |
mrunge | ptl is part of stable team by default :P | 11:08 |
tsufiev | robcresswell, all npm-run jobs are failing, and ETA for fixing it are unknown. But you're right, we have to wait at least one day before considering them as broken | 11:09 |
robcresswell | mrunge: Not true, I can only +1/-1 | 11:09 |
mrunge | really? | 11:09 |
robcresswell | mrunge: Yup :) | 11:09 |
mrunge | robcresswell, I didn't knew | 11:09 |
robcresswell | tsufiev: Yes, I'd rather not react too suddenly. If we don't merge for a day its not a huge problem at this point in the cycle. | 11:09 |
tsufiev | robcresswell, I'm more concerned with landing Swift UI fix into RC3 | 11:10 |
tsufiev | as well as a couple of other fixes | 11:11 |
tsufiev | Apr 8 is the deadline, IIUC, so not much time left | 11:12 |
robcresswell | Yep | 11:12 |
*** akulshin has quit IRC | 11:14 | |
*** akulshin has joined #openstack-horizon | 11:17 | |
*** ccesario has quit IRC | 11:18 | |
robcresswell | itxaka: Is this the same bug? https://bugs.launchpad.net/horizon/+bug/1530729 | 11:18 |
openstack | Launchpad bug 1530729 in OpenStack Dashboard (Horizon) "Create button in "Create Subnet" dialog on "Subnet Details" tab is disabled when "Disable Gateway" is selected" [Undecided,In progress] - Assigned to Wang Bo (chestack) | 11:18 |
itxaka | robcresswell, yes! | 11:19 |
robcresswell | itxaka: If so, we should backport that fix | 11:19 |
itxaka | only better done :P | 11:19 |
*** yamamoto has joined #openstack-horizon | 11:20 | |
robcresswell | itxaka: Lets follow proper backport procedure here | 11:20 |
robcresswell | Merge to master etc | 11:20 |
itxaka | actually that bug is no longer reproducible on master | 11:21 |
itxaka | due to the changes of Diana I think | 11:21 |
itxaka | but yes, indeed lets follow proper procedure! | 11:21 |
robcresswell | Hmm, I can still recreate it | 11:22 |
robcresswell | Yeah, I can recreate it exactly in master. Disable Gateway, hit subnet details. | 11:23 |
itxaka | thensomething broke between my last check and now :o | 11:25 |
itxaka | waaait | 11:25 |
itxaka | dont mind me, Im dumb today | 11:25 |
robcresswell | \o/ | 11:26 |
itxaka | was reading another bug, stupid 50 tabs | 11:26 |
robcresswell | 299 bugs to go | 11:26 |
itxaka | oh wait, no I wasnt | 11:26 |
itxaka | I couldnt really trigger this on master on 10 of March | 11:26 |
itxaka | :/ | 11:26 |
itxaka | Ill recheck it | 11:27 |
robcresswell | I reviewed it on the 18th, and I could recreate it at that point | 11:27 |
*** akulshin has quit IRC | 11:27 | |
robcresswell | There are actually 3 bugs that will be solved by this | 11:28 |
robcresswell | even more if you include duplicates | 11:28 |
*** exploreshaifali has joined #openstack-horizon | 11:28 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Provide a button to center the network topology https://review.openstack.org/283704 | 11:28 |
openstackgerrit | Raga lahari proposed openstack/horizon: Reset flavors for other than "Boot from Image" source type. https://review.openstack.org/221758 | 11:31 |
*** rodrigods has quit IRC | 11:32 | |
itxaka | robcresswell, 9 of May it was fixed somehow | 11:32 |
itxaka | you can test with this commit: https://github.com/openstack/horizon/commit/20f00de21c32fc9eacc31b7ceda82146e3e42380 | 11:32 |
*** rodrigods has joined #openstack-horizon | 11:32 | |
itxaka | and then it broke again :D :D | 11:33 |
robcresswell | Hey thats my commit | 11:34 |
robcresswell | Oh it broke after that | 11:34 |
itxaka | ;) | 11:34 |
robcresswell | go go gadget bisect | 11:34 |
*** mvk_ has quit IRC | 11:35 | |
itxaka | bisect is awesome, it points to this -> 54b9506ed5f51ea1f13a1df1a105d5d7e6452289 | 11:42 |
itxaka | which is not that difficult to get even without bisect :P Branding: Create Network should inherit from theme | 11:42 |
robcresswell | I just tried that patch, it seemed to work... | 11:42 |
robcresswell | Oh no, cache was messing me around | 11:43 |
itxaka | are you doubting the power of BISECT! | 11:44 |
robcresswell | hahaha | 11:44 |
*** yamamoto has quit IRC | 11:45 | |
robcresswell | It looks like there may be a cleaner fix then... | 11:46 |
*** yamamoto has joined #openstack-horizon | 11:47 | |
*** mvk_ has joined #openstack-horizon | 11:48 | |
robcresswell | itxaka: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.forms.js#L317 This line is probably just incorrect, the rest of the patch was SCSS removal and a single changed class | 11:49 |
*** sdake_ has joined #openstack-horizon | 11:54 | |
itxaka | yup, seems that you are rigth, bringing that line back to what it was before fixes the issue | 11:54 |
*** kzaitsev_mb has joined #openstack-horizon | 11:55 | |
*** sdake has quit IRC | 11:55 | |
robcresswell | itxaka: That breaks the create subnet button though | 11:56 |
itxaka | yup | 11:57 |
robcresswell | I think Dianas patch is actually correct, but was just highlighting a different issue | 11:57 |
robcresswell | Gah I despise this workflow | 11:57 |
robcresswell | Too much complexity :p | 11:58 |
*** ygbo has joined #openstack-horizon | 11:58 | |
*** ygbo has quit IRC | 11:58 | |
*** ygbo has joined #openstack-horizon | 11:58 | |
*** yamamoto has quit IRC | 11:59 | |
*** yamamoto has joined #openstack-horizon | 12:00 | |
*** masco has quit IRC | 12:01 | |
*** yamamoto has quit IRC | 12:06 | |
*** exploreshaifali has quit IRC | 12:06 | |
*** yamamoto has joined #openstack-horizon | 12:09 | |
*** yamamoto has quit IRC | 12:13 | |
*** yamamoto has joined #openstack-horizon | 12:15 | |
itxaka | ugh, this thing is difficult to wrap around | 12:16 |
itxaka | I think the issue is that we are hiding fields _and_ tabs in the same function, instead of checking both things separatedly | 12:17 |
robcresswell | Yep | 12:17 |
robcresswell | If you look at L340 I think it is | 12:17 |
robcresswell | It seems like it may just be searching for Next and hiding it when switchable is toggled | 12:18 |
robcresswell | regardless of *why* its switchable | 12:18 |
*** erlon has joined #openstack-horizon | 12:18 | |
*** yamamoto has quit IRC | 12:18 | |
*** exploreshaifali has joined #openstack-horizon | 12:18 | |
openstackgerrit | Sergei Chipiga proposed openstack/horizon: Add test for backups pagination https://review.openstack.org/301099 | 12:19 |
*** matt-borland has joined #openstack-horizon | 12:19 | |
itxaka | well better wait for the experts to check it | 12:20 |
* itxaka hides slowly in the shadows | 12:20 | |
*** wolverineav has joined #openstack-horizon | 12:21 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Heat Template Versions panel https://review.openstack.org/295884 | 12:21 |
*** wolverineav has quit IRC | 12:26 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Provide a button to center the network topology https://review.openstack.org/283704 | 12:28 |
*** yamamoto has joined #openstack-horizon | 12:31 | |
*** mtanino has joined #openstack-horizon | 12:34 | |
*** JeanBriceCombebi has quit IRC | 12:35 | |
*** yamamoto has quit IRC | 12:36 | |
robcresswell | itxaka: Okay, I think the current patch is correct: https://review.openstack.org/#/c/263249 | 12:37 |
robcresswell | itxaka: The line at 329 is key `if ($switchable.data('hide-tab'))` | 12:38 |
robcresswell | That stops the switchable just handling everything | 12:38 |
*** jtriley has joined #openstack-horizon | 12:39 | |
itxaka | indeed, it seems so | 12:41 |
itxaka | before it was just doing it anyway with no checks | 12:42 |
robcresswell | yup | 12:45 |
robcresswell | I'm gonna step away for an hour or so, back in a bit. | 12:45 |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 12:48 |
*** julim has joined #openstack-horizon | 12:52 | |
*** sdake_ has quit IRC | 12:57 | |
*** yamamoto has joined #openstack-horizon | 12:58 | |
*** zhurong has joined #openstack-horizon | 13:06 | |
*** zhurong has quit IRC | 13:06 | |
*** wangbo has quit IRC | 13:06 | |
*** pauloewerton has joined #openstack-horizon | 13:07 | |
*** mgagne_ has joined #openstack-horizon | 13:20 | |
*** agireud has quit IRC | 13:21 | |
*** katyafervent_awa has quit IRC | 13:21 | |
*** dsneddon has quit IRC | 13:21 | |
*** BlackDex has quit IRC | 13:21 | |
*** lcastell has quit IRC | 13:21 | |
*** mgagne has quit IRC | 13:21 | |
*** ericksonsantos has quit IRC | 13:21 | |
*** sballe_ has quit IRC | 13:21 | |
*** darrenc has quit IRC | 13:21 | |
*** mtanino has quit IRC | 13:21 | |
*** clayton has quit IRC | 13:21 | |
*** trams has quit IRC | 13:21 | |
*** schipiga has quit IRC | 13:21 | |
*** Murad has quit IRC | 13:21 | |
*** shu-mutou has quit IRC | 13:21 | |
*** pauloewerton has quit IRC | 13:21 | |
*** amit213 has quit IRC | 13:21 | |
*** cbader has quit IRC | 13:21 | |
*** jgrassler has quit IRC | 13:21 | |
*** marlinc has quit IRC | 13:21 | |
*** lunarlamp has quit IRC | 13:21 | |
*** matt-borland has quit IRC | 13:21 | |
*** Liuqing has quit IRC | 13:21 | |
*** rcernin has quit IRC | 13:21 | |
*** vishwanathj has quit IRC | 13:21 | |
*** harlowja has quit IRC | 13:21 | |
*** raginbajin has quit IRC | 13:21 | |
*** _stowa has quit IRC | 13:21 | |
*** tonyb has quit IRC | 13:21 | |
*** e0ne has quit IRC | 13:21 | |
*** josecastroleon has quit IRC | 13:21 | |
*** zul has quit IRC | 13:21 | |
*** mdavidson has quit IRC | 13:21 | |
*** andrewbogott has quit IRC | 13:21 | |
*** DuncanT has quit IRC | 13:21 | |
*** zhenguo_ has quit IRC | 13:21 | |
*** bradjones has quit IRC | 13:21 | |
*** tmazur_ has quit IRC | 13:21 | |
*** jroll has quit IRC | 13:21 | |
*** EmilienM has quit IRC | 13:21 | |
*** ccard has quit IRC | 13:21 | |
*** kzaitsev_mb has quit IRC | 13:21 | |
*** jtomasek has quit IRC | 13:21 | |
*** bapalm has quit IRC | 13:21 | |
*** logan- has quit IRC | 13:21 | |
*** davidmichaelkarr has quit IRC | 13:21 | |
*** onovy has quit IRC | 13:21 | |
*** krotscheck has quit IRC | 13:21 | |
*** vkramskikh has quit IRC | 13:21 | |
*** pumaranikar has quit IRC | 13:21 | |
*** jmccrory has quit IRC | 13:21 | |
*** pcaruana has quit IRC | 13:21 | |
*** Ephur has quit IRC | 13:21 | |
*** ppiela has quit IRC | 13:21 | |
*** openstackgerrit has quit IRC | 13:21 | |
*** hogepodge has quit IRC | 13:21 | |
*** ttrifonov has quit IRC | 13:21 | |
*** tsufiev has quit IRC | 13:21 | |
*** sjmc7 has quit IRC | 13:21 | |
*** brad[] has quit IRC | 13:21 | |
*** kmartin has quit IRC | 13:21 | |
*** NightKhaos has quit IRC | 13:21 | |
*** jhesketh has quit IRC | 13:21 | |
*** yamamoto has quit IRC | 13:21 | |
*** jtriley has quit IRC | 13:21 | |
*** mvk_ has quit IRC | 13:21 | |
*** early has quit IRC | 13:21 | |
*** mflobo has quit IRC | 13:21 | |
*** mordred has quit IRC | 13:21 | |
*** hughhalf has quit IRC | 13:21 | |
*** yottatsa has quit IRC | 13:21 | |
*** reedip has quit IRC | 13:21 | |
*** HenryG has quit IRC | 13:21 | |
*** john5223 has quit IRC | 13:21 | |
*** julim has quit IRC | 13:21 | |
*** itxaka has quit IRC | 13:21 | |
*** Shahid_ has quit IRC | 13:21 | |
*** xiangxinyong has quit IRC | 13:21 | |
*** kmARC has quit IRC | 13:21 | |
*** boltR has quit IRC | 13:21 | |
*** zigo has quit IRC | 13:21 | |
*** sekrit has quit IRC | 13:21 | |
*** rdopiera has quit IRC | 13:21 | |
*** david-lyle has quit IRC | 13:21 | |
*** sayalilunkad has quit IRC | 13:21 | |
*** mnaser has quit IRC | 13:22 | |
*** lifeless has quit IRC | 13:22 | |
*** kzaitsev_ws has quit IRC | 13:22 | |
*** v12aml has quit IRC | 13:22 | |
*** r1chardj0n3s_afk has quit IRC | 13:22 | |
*** binBASH has quit IRC | 13:22 | |
*** erlon has quit IRC | 13:22 | |
*** ygbo has quit IRC | 13:22 | |
*** al_indigo has quit IRC | 13:22 | |
*** stevemar has quit IRC | 13:22 | |
*** aorourke_ has quit IRC | 13:22 | |
*** jlopezgu has quit IRC | 13:22 | |
*** jasondotstar has quit IRC | 13:22 | |
*** mfisch has quit IRC | 13:22 | |
*** kfox1111 has quit IRC | 13:22 | |
*** AlexOughton has quit IRC | 13:22 | |
*** ameade has quit IRC | 13:22 | |
*** mariusv has quit IRC | 13:22 | |
*** rodrigods has quit IRC | 13:22 | |
*** vgridnev has quit IRC | 13:22 | |
*** Anticimex has quit IRC | 13:22 | |
*** m3m0 has quit IRC | 13:22 | |
*** abramley has quit IRC | 13:22 | |
*** fnordahl has quit IRC | 13:22 | |
*** dloi has quit IRC | 13:22 | |
*** morgan has quit IRC | 13:22 | |
*** htruta has quit IRC | 13:22 | |
*** sshen has quit IRC | 13:22 | |
*** robcresswell has quit IRC | 13:22 | |
*** tosky has quit IRC | 13:22 | |
*** aortega has quit IRC | 13:22 | |
*** woodburn has quit IRC | 13:22 | |
*** mrunge has quit IRC | 13:22 | |
*** med_ has quit IRC | 13:22 | |
*** exploreshaifali has quit IRC | 13:22 | |
*** eandersson has quit IRC | 13:22 | |
*** ejat has quit IRC | 13:22 | |
*** john51 has quit IRC | 13:22 | |
*** jrist has quit IRC | 13:22 | |
*** ZZelle has quit IRC | 13:22 | |
*** rhagarty__ has quit IRC | 13:22 | |
*** NikitaKonovalov has quit IRC | 13:22 | |
*** jidar has quit IRC | 13:22 | |
*** katyafervent_awa has joined #openstack-horizon | 13:24 | |
*** dani_castellanos has joined #openstack-horizon | 13:24 | |
*** neelashah has joined #openstack-horizon | 13:24 | |
*** BlackDex_ has joined #openstack-horizon | 13:24 | |
*** jpomeroy has joined #openstack-horizon | 13:24 | |
*** darrenc_ has joined #openstack-horizon | 13:24 | |
*** sballe__ has joined #openstack-horizon | 13:24 | |
*** peristeri has joined #openstack-horizon | 13:24 | |
*** pauloewerton has joined #openstack-horizon | 13:24 | |
*** yamamoto has joined #openstack-horizon | 13:24 | |
*** julim has joined #openstack-horizon | 13:24 | |
*** jtriley has joined #openstack-horizon | 13:24 | |
*** matt-borland has joined #openstack-horizon | 13:24 | |
*** erlon has joined #openstack-horizon | 13:24 | |
*** ygbo has joined #openstack-horizon | 13:24 | |
*** kzaitsev_mb has joined #openstack-horizon | 13:24 | |
*** mvk_ has joined #openstack-horizon | 13:24 | |
*** rodrigods has joined #openstack-horizon | 13:24 | |
*** eandersson has joined #openstack-horizon | 13:24 | |
*** schipiga has joined #openstack-horizon | 13:24 | |
*** Liuqing has joined #openstack-horizon | 13:24 | |
*** tosky has joined #openstack-horizon | 13:24 | |
*** itxaka has joined #openstack-horizon | 13:24 | |
*** Shahid_ has joined #openstack-horizon | 13:24 | |
*** e0ne has joined #openstack-horizon | 13:24 | |
*** pcaruana has joined #openstack-horizon | 13:24 | |
*** aortega has joined #openstack-horizon | 13:24 | |
*** rdopiera has joined #openstack-horizon | 13:24 | |
*** josecastroleon has joined #openstack-horizon | 13:24 | |
*** rcernin has joined #openstack-horizon | 13:24 | |
*** sekrit has joined #openstack-horizon | 13:24 | |
*** david-lyle has joined #openstack-horizon | 13:24 | |
*** Ephur has joined #openstack-horizon | 13:24 | |
*** vishwanathj has joined #openstack-horizon | 13:24 | |
*** sjmc7 has joined #openstack-horizon | 13:24 | |
*** woodburn has joined #openstack-horizon | 13:24 | |
*** mrunge has joined #openstack-horizon | 13:24 | |
*** ppiela has joined #openstack-horizon | 13:24 | |
*** al_indigo has joined #openstack-horizon | 13:24 | |
*** zul has joined #openstack-horizon | 13:24 | |
*** Murad has joined #openstack-horizon | 13:24 | |
*** openstackgerrit has joined #openstack-horizon | 13:24 | |
*** mdavidson has joined #openstack-horizon | 13:24 | |
*** xiangxinyong has joined #openstack-horizon | 13:24 | |
*** ejat has joined #openstack-horizon | 13:24 | |
*** wolfe.freenode.net sets mode: +ov david-lyle mrunge | 13:24 | |
*** sayalilunkad has joined #openstack-horizon | 13:24 | |
*** jtomasek has joined #openstack-horizon | 13:24 | |
*** shu-mutou has joined #openstack-horizon | 13:24 | |
*** bapalm has joined #openstack-horizon | 13:24 | |
*** Anticimex has joined #openstack-horizon | 13:24 | |
*** amit213 has joined #openstack-horizon | 13:24 | |
*** john51 has joined #openstack-horizon | 13:24 | |
*** stevemar has joined #openstack-horizon | 13:24 | |
*** jrist has joined #openstack-horizon | 13:24 | |
*** logan- has joined #openstack-horizon | 13:24 | |
*** harlowja has joined #openstack-horizon | 13:24 | |
*** hogepodge has joined #openstack-horizon | 13:24 | |
*** cbader has joined #openstack-horizon | 13:24 | |
*** kmARC has joined #openstack-horizon | 13:24 | |
*** early has joined #openstack-horizon | 13:24 | |
*** kfox1111 has joined #openstack-horizon | 13:24 | |
*** yottatsa has joined #openstack-horizon | 13:24 | |
*** ZZelle has joined #openstack-horizon | 13:24 | |
*** jgrassler has joined #openstack-horizon | 13:24 | |
*** andrewbogott has joined #openstack-horizon | 13:24 | |
*** davidmichaelkarr has joined #openstack-horizon | 13:24 | |
*** aorourke_ has joined #openstack-horizon | 13:24 | |
*** onovy has joined #openstack-horizon | 13:24 | |
*** krotscheck has joined #openstack-horizon | 13:24 | |
*** marlinc has joined #openstack-horizon | 13:24 | |
*** rhagarty__ has joined #openstack-horizon | 13:24 | |
*** jlopezgu has joined #openstack-horizon | 13:24 | |
*** mflobo has joined #openstack-horizon | 13:24 | |
*** mnaser has joined #openstack-horizon | 13:24 | |
*** raginbajin has joined #openstack-horizon | 13:24 | |
*** jasondotstar has joined #openstack-horizon | 13:24 | |
*** vkramskikh has joined #openstack-horizon | 13:24 | |
*** mfisch has joined #openstack-horizon | 13:24 | |
*** lifeless has joined #openstack-horizon | 13:24 | |
*** pumaranikar has joined #openstack-horizon | 13:24 | |
*** morgan has joined #openstack-horizon | 13:24 | |
*** ttrifonov has joined #openstack-horizon | 13:24 | |
*** tsufiev has joined #openstack-horizon | 13:24 | |
*** DuncanT has joined #openstack-horizon | 13:24 | |
*** trams has joined #openstack-horizon | 13:24 | |
*** clayton has joined #openstack-horizon | 13:24 | |
*** AlexOughton has joined #openstack-horizon | 13:24 | |
*** brad[] has joined #openstack-horizon | 13:24 | |
*** ameade has joined #openstack-horizon | 13:24 | |
*** mordred has joined #openstack-horizon | 13:24 | |
*** kzaitsev_ws has joined #openstack-horizon | 13:24 | |
*** wolfe.freenode.net sets mode: +v tsufiev | 13:24 | |
*** _stowa has joined #openstack-horizon | 13:24 | |
*** NightKhaos has joined #openstack-horizon | 13:24 | |
*** jmccrory has joined #openstack-horizon | 13:24 | |
*** kmartin has joined #openstack-horizon | 13:24 | |
*** m3m0 has joined #openstack-horizon | 13:24 | |
*** zhenguo_ has joined #openstack-horizon | 13:24 | |
*** bradjones has joined #openstack-horizon | 13:24 | |
*** tmazur_ has joined #openstack-horizon | 13:24 | |
*** jroll has joined #openstack-horizon | 13:24 | |
*** lunarlamp has joined #openstack-horizon | 13:24 | |
*** mariusv has joined #openstack-horizon | 13:24 | |
*** hughhalf has joined #openstack-horizon | 13:24 | |
*** EmilienM has joined #openstack-horizon | 13:24 | |
*** abramley has joined #openstack-horizon | 13:24 | |
*** reedip has joined #openstack-horizon | 13:24 | |
*** med_ has joined #openstack-horizon | 13:24 | |
*** NikitaKonovalov has joined #openstack-horizon | 13:24 | |
*** HenryG has joined #openstack-horizon | 13:24 | |
*** tonyb has joined #openstack-horizon | 13:24 | |
*** v12aml has joined #openstack-horizon | 13:24 | |
*** john5223 has joined #openstack-horizon | 13:24 | |
*** ccard has joined #openstack-horizon | 13:24 | |
*** r1chardj0n3s_afk has joined #openstack-horizon | 13:24 | |
*** binBASH has joined #openstack-horizon | 13:24 | |
*** fnordahl has joined #openstack-horizon | 13:24 | |
*** boltR has joined #openstack-horizon | 13:24 | |
*** zigo has joined #openstack-horizon | 13:24 | |
*** dloi has joined #openstack-horizon | 13:24 | |
*** jidar has joined #openstack-horizon | 13:24 | |
*** jhesketh has joined #openstack-horizon | 13:24 | |
*** htruta has joined #openstack-horizon | 13:24 | |
*** sshen has joined #openstack-horizon | 13:24 | |
*** robcresswell has joined #openstack-horizon | 13:24 | |
*** wolfe.freenode.net sets mode: +vov r1chardj0n3s_afk robcresswell robcresswell | 13:24 | |
*** openstackstatus has quit IRC | 13:24 | |
*** mgagne_ has quit IRC | 13:24 | |
*** mgagne_ has joined #openstack-horizon | 13:24 | |
*** sballe__ is now known as sballe_ | 13:24 | |
openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Tests for instance filtering are added https://review.openstack.org/271204 | 13:24 |
*** openstackstatus has joined #openstack-horizon | 13:26 | |
*** ChanServ sets mode: +v openstackstatus | 13:26 | |
*** dsneddon has joined #openstack-horizon | 13:27 | |
*** agireud has joined #openstack-horizon | 13:27 | |
*** ericksonsantos has joined #openstack-horizon | 13:28 | |
*** cloudtrainme has joined #openstack-horizon | 13:31 | |
*** vgridnev has joined #openstack-horizon | 13:31 | |
*** tqtran has joined #openstack-horizon | 13:33 | |
*** yamamoto has quit IRC | 13:34 | |
*** JeanBriceCombebi has joined #openstack-horizon | 13:34 | |
openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Add test for volumes attach/detach https://review.openstack.org/275231 | 13:34 |
*** tqtran has quit IRC | 13:38 | |
*** itxaka is now known as itxaka|lunch | 13:40 | |
*** yamamoto has joined #openstack-horizon | 13:41 | |
*** ametts has joined #openstack-horizon | 13:42 | |
*** Qingqing has joined #openstack-horizon | 13:47 | |
*** lblanchard has joined #openstack-horizon | 13:58 | |
*** Shahid_ has quit IRC | 13:59 | |
*** aortega has quit IRC | 14:01 | |
*** pushkaru has joined #openstack-horizon | 14:02 | |
*** BlackDex_ is now known as BlackDex | 14:02 | |
*** pushkaru has quit IRC | 14:04 | |
*** pushkaru has joined #openstack-horizon | 14:04 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 14:04 |
*** dani_castellanos is now known as lcastell | 14:10 | |
lcastell | /msg nickserv identify 50TacosAlVapor! | 14:10 |
*** hurgleburgler has joined #openstack-horizon | 14:10 | |
*** ChanServ sets mode: +v hurgleburgler | 14:10 | |
eandersson | Is there a reason why in the new Launch Instance, Instance Snapshots and Images are always separated, while in the old Launch Instance you see Images + Snapshots under "Boot from image"? | 14:12 |
eandersson | but on the old Launch Instance, under Snapshots only would see Snapshots. | 14:14 |
*** sdake has joined #openstack-horizon | 14:15 | |
*** Drago has joined #openstack-horizon | 14:17 | |
*** Drago has quit IRC | 14:17 | |
*** Drago has joined #openstack-horizon | 14:18 | |
*** julim has quit IRC | 14:21 | |
openstackgerrit | Dmitry Ratushnyy proposed openstack/horizon: Fix actions inside instance details view page https://review.openstack.org/289932 | 14:23 |
*** lapalm has joined #openstack-horizon | 14:24 | |
*** mtanino has joined #openstack-horizon | 14:25 | |
*** ediardo has joined #openstack-horizon | 14:27 | |
*** itxaka|lunch is now known as itxaka | 14:32 | |
*** ankurgupta has joined #openstack-horizon | 14:34 | |
*** kzaitsev_mb has quit IRC | 14:35 | |
*** ducttape_ has joined #openstack-horizon | 14:36 | |
*** aortega has joined #openstack-horizon | 14:40 | |
*** kzaitsev_mb has joined #openstack-horizon | 14:43 | |
*** rebase has joined #openstack-horizon | 14:46 | |
*** ankurgupta has quit IRC | 14:49 | |
*** ankurgupta has joined #openstack-horizon | 14:51 | |
*** Murad has quit IRC | 14:51 | |
*** sdake_ has joined #openstack-horizon | 14:54 | |
*** josecastroleon has quit IRC | 14:54 | |
*** sdake has quit IRC | 14:57 | |
*** ediardo has quit IRC | 14:57 | |
*** ametts has quit IRC | 15:00 | |
*** hurgleburgler1 has joined #openstack-horizon | 15:01 | |
*** cloudtrainme has quit IRC | 15:03 | |
*** cloudtra_ has joined #openstack-horizon | 15:03 | |
*** hurgleburgler has quit IRC | 15:04 | |
*** hurgleburgler1 has quit IRC | 15:04 | |
*** JeanBriceCombebi has quit IRC | 15:04 | |
*** hurgleburgler has joined #openstack-horizon | 15:05 | |
*** ChanServ sets mode: +v hurgleburgler | 15:05 | |
*** pcaruana has quit IRC | 15:06 | |
*** lblanchard has quit IRC | 15:07 | |
*** garthb has joined #openstack-horizon | 15:08 | |
*** jprovazn has joined #openstack-horizon | 15:10 | |
*** ametts has joined #openstack-horizon | 15:13 | |
*** vgridnev has quit IRC | 15:18 | |
*** schipiga has quit IRC | 15:18 | |
*** ZZelle has quit IRC | 15:18 | |
*** vgridnev has joined #openstack-horizon | 15:19 | |
*** ZZelle has joined #openstack-horizon | 15:20 | |
*** weezS has joined #openstack-horizon | 15:20 | |
*** david_cu has joined #openstack-horizon | 15:22 | |
*** jaimguer has joined #openstack-horizon | 15:22 | |
robcresswell | lcastell: May want to change your password :) | 15:23 |
lcastell | Oops!! | 15:23 |
lcastell | I knew it! | 15:23 |
lcastell | Thanks robcresswell | 15:24 |
lcastell | (I feel stupid now haha) | 15:24 |
robcresswell | lcastell: haha, no problem | 15:24 |
robcresswell | Happens to people all the time. | 15:24 |
*** wolverineav has joined #openstack-horizon | 15:25 | |
*** sdake_ has quit IRC | 15:27 | |
*** sdake has joined #openstack-horizon | 15:27 | |
*** cloudtra_ has quit IRC | 15:28 | |
*** wolverineav has quit IRC | 15:29 | |
*** fedexo has joined #openstack-horizon | 15:29 | |
*** cloudtrainme has joined #openstack-horizon | 15:35 | |
itxaka | 50 tacos al vapor lmao, I love it lcastell! | 15:36 |
lcastell | hahaha | 15:36 |
lcastell | easy to remember itxaka | 15:36 |
itxaka | now Im gonna remember it for the rest of my life | 15:36 |
*** mvk_ has quit IRC | 15:37 | |
*** Liuqing has quit IRC | 15:38 | |
openstackgerrit | Justin Pomeroy proposed openstack/horizon: Add support for detail actions https://review.openstack.org/301770 | 15:38 |
*** Mounica has joined #openstack-horizon | 15:38 | |
robcresswell | eandersson: I'm not sure :( | 15:41 |
*** bpokorny has joined #openstack-horizon | 15:45 | |
*** ygbo has quit IRC | 15:48 | |
*** kzaitsev_mb has quit IRC | 15:51 | |
*** ccesario has joined #openstack-horizon | 15:54 | |
eandersson | robcresswell: So I located all the code, and the way that the images are listed is done differently. | 15:54 |
eandersson | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L433 | 15:55 |
eandersson | In the old modal we did not check if it was a snapshot. | 15:55 |
*** kzaitsev_mb has joined #openstack-horizon | 15:56 | |
eandersson | While in the new modal it does. | 15:57 |
eandersson | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js#L464 | 15:57 |
eandersson | I just find it odd that there isn't consistency between the two. | 15:57 |
robcresswell | Ah, I meant that I'm not sure why that decision was made | 15:57 |
*** prometheanfire has left #openstack-horizon | 15:58 | |
eandersson | Yea, I understand that, but maybe something that should be reviewed. I mean at least the two should have the same behavior imo. :D | 15:58 |
eandersson | I am pretty sure I won't be the only one to find this confusing. | 15:58 |
robcresswell | Probably not, no, but there's little motivation to fix it | 16:00 |
robcresswell | As in, there are higher priorities issues | 16:00 |
eandersson | Of course =] | 16:00 |
eandersson | Understandable. | 16:01 |
*** lhcheng has joined #openstack-horizon | 16:03 | |
*** ChanServ sets mode: +v lhcheng | 16:03 | |
*** vgridnev has quit IRC | 16:04 | |
*** dan_nguyen has joined #openstack-horizon | 16:05 | |
*** kzaitsev_mb has quit IRC | 16:06 | |
*** weezS has quit IRC | 16:08 | |
*** kzaitsev_mb has joined #openstack-horizon | 16:09 | |
*** cshahani has joined #openstack-horizon | 16:13 | |
*** mvk_ has joined #openstack-horizon | 16:14 | |
*** ediardo has joined #openstack-horizon | 16:19 | |
*** Qingqing has quit IRC | 16:19 | |
*** woodburn has quit IRC | 16:20 | |
*** wolverineav has joined #openstack-horizon | 16:21 | |
ducttape_ | david-lyle / robcresswell I had another request today, this has existed for like forever ..... horizon should have some console view to say to users "we made the following api calls / rest calls to produce this page" - request by mfisch | 16:27 |
*** woodburn has joined #openstack-horizon | 16:28 | |
*** weezS has joined #openstack-horizon | 16:30 | |
*** piet has joined #openstack-horizon | 16:33 | |
*** cshahani has quit IRC | 16:33 | |
david-lyle | ducttape_: that assumes we know | 16:36 |
david-lyle | I've been going through the tests, and apparently we don't | 16:36 |
ducttape_ | you could be 50% accurate and still be more halpful than the docs ;) | 16:36 |
*** cloudtra_ has joined #openstack-horizon | 16:36 | |
david-lyle | to generate the page, or perform the action? | 16:37 |
* david-lyle waits to hear both | 16:37 | |
ducttape_ | I know, the tests have lots of silent failures we are not mocking, and I'd bet some are mocked that are not needed etc | 16:37 |
ducttape_ | all the things david-lyle | 16:37 |
david-lyle | it's a glorious mess | 16:37 |
david-lyle | that would take some rigor to keep up to date | 16:37 |
ducttape_ | it's like this - I log into horizon, so I can do X..... I'd like to capture the rest conversation so I can automate it and never return back to horizon ;) | 16:38 |
david-lyle | we don't excel at rigor | 16:38 |
david-lyle | debug log | 16:38 |
david-lyle | gives you most of that now | 16:38 |
*** cloudtrainme has quit IRC | 16:38 | |
ducttape_ | yep, it's all there in logs if you turn it on. but mfisch is not ready to go through that, and his horizon support guy is super lazy | 16:38 |
david-lyle | I'll see your lazy and raise you an unmotivated | 16:39 |
david-lyle | I do think it would be nice, but a fairly significant effort to get off the ground in a meaningful way | 16:40 |
sjmc7 | might be more attainable to have a setting to output those commands in the logs without enabling debug | 16:41 |
david-lyle | sjmc7: it's pretty noisy though | 16:42 |
sjmc7 | yeah, the python client debug is noisy | 16:42 |
*** cloudtra_ has quit IRC | 16:45 | |
*** ybathia has joined #openstack-horizon | 16:47 | |
*** ArcTanSusan has joined #openstack-horizon | 16:49 | |
*** ArcTanSusan has quit IRC | 16:50 | |
tsufiev | ducttape_, profiler feature aims to provide something like that | 16:50 |
ducttape_ | cool | 16:52 |
*** ArcTanSusan has joined #openstack-horizon | 16:53 | |
*** lblanchard has joined #openstack-horizon | 16:53 | |
*** cshahani has joined #openstack-horizon | 16:57 | |
*** fedexo has quit IRC | 16:57 | |
*** weezS has quit IRC | 16:59 | |
*** exploreshaifali has joined #openstack-horizon | 17:01 | |
*** vgridnev has joined #openstack-horizon | 17:02 | |
*** lblanchard has quit IRC | 17:02 | |
*** eandersson has quit IRC | 17:07 | |
*** clu_ has joined #openstack-horizon | 17:07 | |
*** ChanServ sets mode: +v clu_ | 17:07 | |
*** sdake_ has joined #openstack-horizon | 17:10 | |
*** masco has joined #openstack-horizon | 17:10 | |
*** ybathia has quit IRC | 17:10 | |
*** ybathia has joined #openstack-horizon | 17:10 | |
*** sdake has quit IRC | 17:10 | |
*** Mounica has quit IRC | 17:11 | |
*** wolverineav has quit IRC | 17:13 | |
*** Mounica has joined #openstack-horizon | 17:13 | |
*** dratushnyy has joined #openstack-horizon | 17:19 | |
*** morgan is now known as notnotmyname | 17:21 | |
*** notnotmyname is now known as morgan | 17:21 | |
*** ZZelle_ has joined #openstack-horizon | 17:24 | |
*** ybathia has quit IRC | 17:26 | |
*** cloudtrainme has joined #openstack-horizon | 17:27 | |
robcresswell | NPM 1, Gate 0 | 17:31 |
*** ybathia has joined #openstack-horizon | 17:31 | |
*** itisha has joined #openstack-horizon | 17:33 | |
*** weezS has joined #openstack-horizon | 17:34 | |
*** Qingqing has joined #openstack-horizon | 17:35 | |
openstackgerrit | David Cusatis proposed openstack/horizon: Add event broadcast to table row expansion https://review.openstack.org/287473 | 17:37 |
*** tqtran has joined #openstack-horizon | 17:37 | |
*** vgridnev has quit IRC | 17:39 | |
*** davidlenwell has quit IRC | 17:42 | |
*** garthb has quit IRC | 17:47 | |
*** TravT has quit IRC | 17:48 | |
*** julim has joined #openstack-horizon | 17:48 | |
*** davidlenwell has joined #openstack-horizon | 17:49 | |
*** ArcTanSusan has quit IRC | 17:49 | |
*** TravT has joined #openstack-horizon | 17:50 | |
*** ChanServ sets mode: +v TravT | 17:50 | |
*** wolverineav has joined #openstack-horizon | 17:51 | |
*** hurgleburgler1 has joined #openstack-horizon | 18:01 | |
*** hurgleburgler has quit IRC | 18:01 | |
*** lblanchard has joined #openstack-horizon | 18:01 | |
*** Qingqing has quit IRC | 18:02 | |
*** ArcTanSusan has joined #openstack-horizon | 18:02 | |
*** masco has quit IRC | 18:03 | |
*** vgridnev has joined #openstack-horizon | 18:05 | |
*** hurgleburgler has joined #openstack-horizon | 18:06 | |
*** ChanServ sets mode: +v hurgleburgler | 18:06 | |
*** hurgleburgler1 has quit IRC | 18:06 | |
*** ArcTanSusan has quit IRC | 18:09 | |
*** e0ne has quit IRC | 18:10 | |
*** yamamoto has quit IRC | 18:12 | |
*** kzaitsev_mb has quit IRC | 18:14 | |
*** pushkaru has quit IRC | 18:15 | |
*** yamamoto has joined #openstack-horizon | 18:16 | |
*** zul has quit IRC | 18:19 | |
*** piet has quit IRC | 18:21 | |
*** yamamoto has quit IRC | 18:21 | |
*** cbader has quit IRC | 18:22 | |
openstackgerrit | David Lyle proposed openstack/horizon: removing httplib2 test dependency https://review.openstack.org/301862 | 18:22 |
*** weezS has quit IRC | 18:25 | |
robcresswell | david-lyle: That patch is awesome | 18:26 |
david-lyle | robcresswell: painful if nothing else | 18:27 |
*** piet has joined #openstack-horizon | 18:27 | |
*** pushkaru has joined #openstack-horizon | 18:27 | |
robcresswell | david-lyle: Would that fix https://bugs.launchpad.net/horizon/+bug/1517704 too? | 18:29 |
openstack | Launchpad bug 1517704 in OpenStack Dashboard (Horizon) "Test still passes even with tests failure" [High,Triaged] - Assigned to David Lyle (david-lyle) | 18:29 |
openstackgerrit | David Lyle proposed openstack/horizon: removing httplib2 test dependency https://review.openstack.org/301862 | 18:29 |
*** weezS has joined #openstack-horizon | 18:30 | |
david-lyle | so unmocked calls will still not cause failures | 18:30 |
robcresswell | ah :( | 18:30 |
david-lyle | I can add something to trigger a failure | 18:30 |
david-lyle | easy enough | 18:30 |
robcresswell | Yep, I think thats right | 18:31 |
david-lyle | after I print the stack trace, I can just assert | 18:31 |
david-lyle | want me to add it? | 18:31 |
robcresswell | Yeah | 18:31 |
david-lyle | ok, just a sec | 18:31 |
robcresswell | tag that bug in it too so we can close that out | 18:31 |
david-lyle | ok | 18:32 |
david-lyle | robcresswell: also | 18:34 |
david-lyle | did the django 1.9 patch land? | 18:35 |
david-lyle | manage.py is less forgiving than 2 weeks ago, not sure why exacly | 18:36 |
robcresswell | Nope, its still sitting with its tests passed. | 18:36 |
robcresswell | https://review.openstack.org/#/c/280222/ | 18:36 |
robcresswell | david-lyle: less forgiving? | 18:36 |
david-lyle | well | 18:37 |
david-lyle | I was using ./run_tests.sh openstack_dashboard.dashboards.project.instances | 18:38 |
*** ybathia has quit IRC | 18:38 | |
david-lyle | I had to change to ./run_tests.sh openstack_dashboard.dashboards.project.instances.tests once I rebased on master | 18:38 |
david-lyle | not really sure as to why | 18:38 |
david-lyle | manage.py pitching a file about imports | 18:39 |
david-lyle | *fit | 18:39 |
*** ybathia has joined #openstack-horizon | 18:40 | |
*** rebase has quit IRC | 18:40 | |
*** rcernin has quit IRC | 18:41 | |
*** ybathia has quit IRC | 18:41 | |
robcresswell | ./run_tests.sh openstack_dashboard.dashboards.project.instances runs fine for me locally; are you sure its not part of the patch change? | 18:41 |
*** rebase has joined #openstack-horizon | 18:41 | |
*** cbader has joined #openstack-horizon | 18:42 | |
david-lyle | I don't think so because it was working fine until I rebased | 18:43 |
david-lyle | and I'm not touching settings or manage | 18:43 |
david-lyle | :/ | 18:43 |
robcresswell | :/ indeed | 18:43 |
robcresswell | I'll investigate when I review that patch | 18:43 |
david-lyle | probably not a big deal | 18:44 |
david-lyle | just threw me at first | 18:44 |
robcresswell | Yeah, understandable | 18:45 |
robcresswell | Who's been working on V3 support btw? dan_nguyen, bpokorny right? | 18:45 |
dan_nguyen | yep | 18:46 |
bpokorny | robcresswell: Yep | 18:46 |
robcresswell | Straight into the trap... | 18:46 |
*** yamamoto has joined #openstack-horizon | 18:46 | |
robcresswell | dan_nguyen, bpokorny: Any chance I could ask you to glance over the bugs here? https://bugs.launchpad.net/horizon/+bugs?field.tag=keystone | 18:46 |
robcresswell | There's a handful on V3 that are very recent. | 18:46 |
dan_nguyen | sure | 18:46 |
robcresswell | Thanks! | 18:47 |
bpokorny | Yep, will look those over as well. | 18:47 |
dan_nguyen | looks like some of them are likely config | 18:47 |
*** weezS has quit IRC | 18:49 | |
*** lblanchard has quit IRC | 18:51 | |
robcresswell | I just noticed one of them mentions being on Kilo -.- | 18:51 |
*** jtriley has quit IRC | 18:52 | |
robcresswell | If it seems config related, if you could a drop a comment in prodding them in the right direction I'd appreciate that. | 18:52 |
bpokorny | Heh. That's going to work well. | 18:52 |
bpokorny | Yep, will do. | 18:52 |
bpokorny | I know what the issue in this one is: https://bugs.launchpad.net/horizon/+bug/1553904 | 18:52 |
openstack | Launchpad bug 1553904 in OpenStack Dashboard (Horizon) "cloud_admin not work in Horizon" [Undecided,New] - Assigned to Dan Nguyen (daniel-a-nguyen) | 18:52 |
bpokorny | Will let them know. | 18:52 |
robcresswell | Ha looks like dan_nguyen already jumped on to solve it | 18:53 |
bpokorny | oh, sorry, I meant this one: https://bugs.launchpad.net/horizon/+bug/1564851 | 18:53 |
openstack | Launchpad bug 1564851 in OpenStack Dashboard (Horizon) "Using the latest keystone V3 policy throws a TypeError" [Undecided,New] | 18:53 |
bpokorny | Too many links open :) | 18:53 |
*** yamamoto has quit IRC | 18:54 | |
dan_nguyen | hmm, let check that out, thx bpokorny | 18:55 |
*** e0ne has joined #openstack-horizon | 18:55 | |
dan_nguyen | oh yeah. I think we said to leave out that ‘token.is_admin_project:True’ of the horizon copy of the policy file | 18:56 |
dan_nguyen | horizon doesnt’ know what to do with that atm | 18:56 |
bpokorny | Yep, and there's a duplicate bug out there to fix the root cause. | 18:58 |
*** itxaka has quit IRC | 18:58 | |
lcastell | question... is it valid to set the bug status from "new" to "invalid"? can anyone can do that? or just bug supervisors? | 18:59 |
*** weezS has joined #openstack-horizon | 19:01 | |
*** ankurgupta has quit IRC | 19:02 | |
*** e0ne has quit IRC | 19:05 | |
robcresswell | bpokorny: Sorry, which is a duplicate of which bug? | 19:05 |
robcresswell | Cause we can close them down if so | 19:06 |
robcresswell | lcastell: I can't remember who has what permissions. If its definitely not a bug, then go ahead with Invalid. If the bug report isnt up to scratch, use Incomplete. | 19:06 |
bpokorny | robcresswell: https://bugs.launchpad.net/horizon/+bug/1564851 is a duplicate of https://bugs.launchpad.net/oslo.policy/+bug/1547684 | 19:07 |
openstack | Launchpad bug 1547684 in oslo.policy "duplicate for #1564851 Attribute error on Token object when using domain scoped token" [Undecided,New] | 19:07 |
openstack | Launchpad bug 1547684 in oslo.policy "Attribute error on Token object when using domain scoped token" [Undecided,New] | 19:07 |
bpokorny | So I marked 1564851 as a dupe. | 19:07 |
robcresswell | Awesome, thanks | 19:07 |
bpokorny | No problem! | 19:07 |
robcresswell | A mere 264 bugs to go. | 19:08 |
robcresswell | ...until we have a triaged list. | 19:08 |
lcastell | Thanks robcresswell! Another question... what if the bug is really old and can't not reproduce because maybe the fix was released already (maybe a duplicated bug)... will the bug go to "invalid" or "Fix Released"? | 19:10 |
robcresswell | lcastell: Invalid. | 19:10 |
lcastell | cool, thanks | 19:10 |
robcresswell | Total bugs has also fallen by nearly 200 since Christmas due to triage and patches :) | 19:11 |
robcresswell | Even more when you factor in all the incomplete bugs that have yet to expire. | 19:12 |
*** vgridnev has quit IRC | 19:15 | |
*** JeanBriceCombebi has joined #openstack-horizon | 19:16 | |
*** vgridnev has joined #openstack-horizon | 19:16 | |
*** ediardo has quit IRC | 19:16 | |
*** ametts has quit IRC | 19:17 | |
*** e0ne has joined #openstack-horizon | 19:18 | |
*** yamamoto has joined #openstack-horizon | 19:24 | |
*** Mounica has quit IRC | 19:24 | |
*** yamamoto has quit IRC | 19:24 | |
*** erlon has quit IRC | 19:27 | |
*** weezS has quit IRC | 19:29 | |
*** julim has quit IRC | 19:30 | |
*** yamamoto has joined #openstack-horizon | 19:31 | |
*** ametts has joined #openstack-horizon | 19:31 | |
*** sdake_ has quit IRC | 19:31 | |
*** zul has joined #openstack-horizon | 19:32 | |
*** Mounica has joined #openstack-horizon | 19:32 | |
*** Mounica_ has joined #openstack-horizon | 19:34 | |
*** dratushnyy has quit IRC | 19:34 | |
*** Mounica_ has quit IRC | 19:34 | |
*** jprovazn has quit IRC | 19:34 | |
*** e0ne has quit IRC | 19:35 | |
*** yamamoto has quit IRC | 19:36 | |
*** Mounica has quit IRC | 19:37 | |
*** Mounica has joined #openstack-horizon | 19:38 | |
dan_nguyen | robcresswell: I think this is a dup https://bugs.launchpad.net/horizon/+bug/1564354 of https://bugs.launchpad.net/horizon/+bug/1494287 | 19:38 |
openstack | Launchpad bug 1564354 in OpenStack Dashboard (Horizon) "Horizon + Multiple Regions + Keystone API v3" [Undecided,New] | 19:38 |
*** Mounica has quit IRC | 19:38 | |
openstack | Launchpad bug 1494287 in OpenStack Dashboard (Horizon) "Urls in AVAILABLE_REGIONS setting fail to match against Keystone API endpoint in catalog" [Undecided,Confirmed] | 19:38 |
*** sdake has joined #openstack-horizon | 19:40 | |
tsufiev | robcresswell: sorry, i totally forgot about a bug day today :( | 19:41 |
robcresswell | :( | 19:41 |
* tsufiev sees their internal SCF tomorrow as a weak excuse | 19:42 | |
*** david_cu has quit IRC | 19:42 | |
*** ankurgupta1 has joined #openstack-horizon | 19:43 | |
*** sdake has quit IRC | 19:44 | |
robcresswell | dan_nguyen: Thanks, I've marked it | 19:44 |
*** sdake has joined #openstack-horizon | 19:46 | |
dan_nguyen | thx robcresswell | 19:49 |
*** Mounica has joined #openstack-horizon | 19:50 | |
robcresswell | There's an NPM bug for our issue it seems https://github.com/npm/npm/issues/12196 | 19:52 |
robcresswell | Its unclear to me if its solved and we're waiting for caches to clear, or if we need to look into our versioning more | 19:52 |
*** weezS has joined #openstack-horizon | 19:56 | |
*** Mounica has quit IRC | 19:57 | |
*** sdake_ has joined #openstack-horizon | 19:58 | |
*** david_cu has joined #openstack-horizon | 20:00 | |
*** sdake has quit IRC | 20:01 | |
*** hurgleburgler1 has joined #openstack-horizon | 20:02 | |
*** hurgleburgler has quit IRC | 20:05 | |
*** tqtran has quit IRC | 20:06 | |
*** pushkaru has quit IRC | 20:06 | |
*** pushkaru has joined #openstack-horizon | 20:08 | |
*** cloudtrainme has quit IRC | 20:12 | |
*** sdake_ has quit IRC | 20:12 | |
*** sdake has joined #openstack-horizon | 20:13 | |
*** david_cu has quit IRC | 20:17 | |
*** bpokorny has quit IRC | 20:18 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:18 | |
*** cloudtrainme has joined #openstack-horizon | 20:19 | |
*** ediardo has joined #openstack-horizon | 20:20 | |
tsufiev | robcresswell: I'm still considering de-vote these 2 jobs to give us a window for merging important fixes into mitaka before release is cut | 20:24 |
tsufiev | krotscheck: do you think there a chance that the problem ^^^ dissolves before Apr 8? | 20:26 |
krotscheck | tsufiev: I have _no_ idea. | 20:26 |
*** bpokorny has joined #openstack-horizon | 20:26 | |
*** david_cu has joined #openstack-horizon | 20:26 | |
tsufiev | Then I'm for de-voting them | 20:27 |
krotscheck | If anyone knows what "��YKo�6�+�Α,�)�" actually means, I'd love help decoding it. | 20:27 |
krotscheck | To me, the repeated characters make me suspect it's some kind of a large-byte haracter encoding. | 20:28 |
tsufiev | Isn't that just raw binary from gzip? | 20:28 |
*** david-lyle_ has joined #openstack-horizon | 20:28 | |
tsufiev | See https://github.com/npm/npm/issues/12196 | 20:28 |
krotscheck | tsufiev: Maube? | 20:28 |
*** cloudtrainme has quit IRC | 20:29 | |
*** david-lyle has quit IRC | 20:29 | |
*** hurgleburgler1 is now known as hurgleburgler | 20:29 | |
*** ChanServ sets mode: +v hurgleburgler | 20:29 | |
krotscheck | tsufiev: Oh, nice find. | 20:29 |
*** david-lyle_ is now known as david-lyle | 20:29 | |
*** ChanServ sets mode: +o david-lyle | 20:30 | |
tsufiev | Kudos to robcresswell | 20:30 |
matt-borland | we probably should get a newer npm... | 20:30 |
*** yamamoto has joined #openstack-horizon | 20:30 | |
matt-borland | our version has become nearly non-operational | 20:31 |
*** vgridnev_ has joined #openstack-horizon | 20:32 | |
*** david_cu has quit IRC | 20:33 | |
*** tqtran has joined #openstack-horizon | 20:34 | |
tsufiev | matt-borland: that's the second item in todo list after 'wait patiently for registry caches to expire' :) | 20:36 |
*** yamamoto has quit IRC | 20:36 | |
matt-borland | :) tsufiev | 20:36 |
*** jaimguer has quit IRC | 20:36 | |
*** Mounica has joined #openstack-horizon | 20:38 | |
*** vgridnev_ has quit IRC | 20:42 | |
*** cloudtrainme has joined #openstack-horizon | 20:43 | |
*** JeanBriceCombebi has quit IRC | 20:49 | |
*** jamielennox|away is now known as jamielennox | 20:49 | |
*** cshahani has quit IRC | 20:56 | |
*** erlon has joined #openstack-horizon | 20:56 | |
*** vgridnev_ has joined #openstack-horizon | 21:01 | |
*** yamamoto has joined #openstack-horizon | 21:01 | |
*** pauloewerton has quit IRC | 21:03 | |
*** mpavlase has joined #openstack-horizon | 21:04 | |
*** darrenc_ is now known as darrenc | 21:05 | |
*** yamamoto has quit IRC | 21:06 | |
*** lhcheng has quit IRC | 21:06 | |
*** Mounica has quit IRC | 21:09 | |
*** lhcheng has joined #openstack-horizon | 21:11 | |
*** ChanServ sets mode: +v lhcheng | 21:11 | |
*** clu_ has quit IRC | 21:11 | |
*** Mounica has joined #openstack-horizon | 21:12 | |
*** Mounica has quit IRC | 21:12 | |
*** vgridnev has quit IRC | 21:15 | |
*** peristeri has quit IRC | 21:17 | |
*** piet has quit IRC | 21:17 | |
*** david_cu has joined #openstack-horizon | 21:20 | |
*** Mounica has joined #openstack-horizon | 21:21 | |
*** kzaitsev_mb has quit IRC | 21:21 | |
*** exploreshaifali has quit IRC | 21:23 | |
*** pushkaru has quit IRC | 21:26 | |
*** sdake_ has joined #openstack-horizon | 21:30 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 21:30 | |
*** sdake has quit IRC | 21:33 | |
*** lapalm has quit IRC | 21:34 | |
r1chardj0n3s | tsufiev: hey do you have a link to your integration test list etherpad handy? | 21:36 |
*** clu_ has joined #openstack-horizon | 21:36 | |
*** ChanServ sets mode: +v clu_ | 21:36 | |
*** sdake_ has quit IRC | 21:37 | |
*** sdake has joined #openstack-horizon | 21:38 | |
*** sdake has quit IRC | 21:39 | |
openstackgerrit | Brad Pokorny proposed openstack/horizon: DO NOT REVIEW - TEST ONLY https://review.openstack.org/301934 | 21:41 |
*** cshahani has joined #openstack-horizon | 21:41 | |
*** aortega_ has joined #openstack-horizon | 21:45 | |
*** aortega has quit IRC | 21:45 | |
*** yamamoto has joined #openstack-horizon | 21:46 | |
*** clayton has quit IRC | 21:47 | |
*** clayton has joined #openstack-horizon | 21:47 | |
*** yamamoto has quit IRC | 21:50 | |
*** matt-borland has quit IRC | 21:52 | |
*** Mounica has quit IRC | 21:53 | |
*** neelashah has quit IRC | 21:53 | |
*** Mounica has joined #openstack-horizon | 21:54 | |
*** rebase_ has joined #openstack-horizon | 21:54 | |
*** david_cu has quit IRC | 21:55 | |
*** ducttape_ has quit IRC | 21:56 | |
*** david_cu has joined #openstack-horizon | 21:56 | |
*** rebase has quit IRC | 21:57 | |
*** bpokorny_ has joined #openstack-horizon | 21:59 | |
*** bpokorny_ has quit IRC | 22:00 | |
*** bpokorny_ has joined #openstack-horizon | 22:01 | |
*** david_cu has quit IRC | 22:01 | |
tsufiev | r1chardj0n3s: https://etherpad.openstack.org/p/horizon-integration-tests enjoy ;) | 22:01 |
r1chardj0n3s | tsufiev: cool, looks like we've got some extra hands to help out there \o/ | 22:02 |
*** bpokorny has quit IRC | 22:02 | |
*** Mounica has quit IRC | 22:03 | |
*** Mounica has joined #openstack-horizon | 22:04 | |
*** ediardo has quit IRC | 22:06 | |
openstackgerrit | Brad Pokorny proposed openstack/horizon: Add support for volume consistency group snapshots https://review.openstack.org/268368 | 22:08 |
*** vgridnev_ has quit IRC | 22:09 | |
*** mpavlase has quit IRC | 22:15 | |
*** rebase_ has quit IRC | 22:21 | |
*** rebase has joined #openstack-horizon | 22:22 | |
*** jamielennox is now known as jamielennox|away | 22:26 | |
*** Mounica has quit IRC | 22:28 | |
*** yamamoto_ has joined #openstack-horizon | 22:31 | |
*** bpokorny_ has quit IRC | 22:35 | |
*** yamamoto_ has quit IRC | 22:35 | |
*** bpokorny has joined #openstack-horizon | 22:35 | |
*** bpokorny has quit IRC | 22:35 | |
*** bpokorny has joined #openstack-horizon | 22:36 | |
*** jpomeroy has quit IRC | 22:41 | |
*** wolverineav has quit IRC | 22:42 | |
*** Ephur has quit IRC | 22:44 | |
*** Drago has quit IRC | 22:44 | |
*** weezS has quit IRC | 22:45 | |
openstackgerrit | David Lyle proposed openstack/horizon: removing httplib2 test dependency https://review.openstack.org/301862 | 22:49 |
andrewbogott | After I change a .scss file, what do I need to do to have the change picked up in my browser? (I'm restarting Apache, that seems insufficient.) | 22:52 |
andrewbogott | Also I have COMPRESS_OFFLINE = False | 22:53 |
openstackgerrit | David Lyle proposed openstack/horizon: removing httplib2 test dependency https://review.openstack.org/301862 | 22:54 |
david-lyle | andrewbogott: you're developing under apache? | 22:54 |
andrewbogott | correct | 22:55 |
hurgleburgler | Try also | 22:55 |
hurgleburgler | COMPRESS_ENABLED = False | 22:55 |
david-lyle | other than restarting | 22:55 |
david-lyle | just shift-reload | 22:55 |
david-lyle | did you have COMPRESS_ENABLED = True before in the same direction | 22:56 |
david-lyle | *directory | 22:57 |
andrewbogott | I didn't have COMPRESS_ENABLED set at all, but I've now set it to false | 22:57 |
andrewbogott | 'directory'? That's a setting in local_settings.py, right? | 22:57 |
david-lyle | andrewbogott: same clone of horizon | 22:57 |
andrewbogott | ah, then yes | 22:57 |
david-lyle | switching back and forth seems to mess up the static folder | 22:58 |
*** ametts has quit IRC | 22:58 | |
david-lyle | I would remove all files under the static folder in the top level directory (e.g., /opt/stack/horizon/static) and restart again | 22:59 |
*** wolverineav has joined #openstack-horizon | 23:00 | |
*** wolverineav has quit IRC | 23:02 | |
*** wolverineav has joined #openstack-horizon | 23:02 | |
andrewbogott | hm, well that broke everything. Guess I'll reinstall the package | 23:04 |
david-lyle | ? | 23:07 |
david-lyle | just under static? | 23:07 |
*** tosky has quit IRC | 23:07 | |
david-lyle | those files are generated | 23:08 |
david-lyle | did you do /opt/stack/horizon/horizon/static or something? | 23:08 |
andrewbogott | I'm using the debian packages, so the paths are different | 23:08 |
andrewbogott | I probably did the wrong thing; it doesn't matter, everything is back | 23:09 |
andrewbogott | I am trying to follow the suggestion about the dropdown css here: https://bugs.launchpad.net/horizon/+bug/1498039 | 23:09 |
openstack | Launchpad bug 1498039 in OpenStack Dashboard (Horizon) "projects drop-down broken for large numbers of projects" [Undecided,Confirmed] | 23:09 |
andrewbogott | Which I'm poking at by editing /usr/share/openstack-dashboard/static/dashboard/scss/horizon.scss | 23:10 |
andrewbogott | is that a generated file? And if so, can you suggest where the css change might properly go? | 23:10 |
david-lyle | no, but it will be compress and compiled to css | 23:10 |
andrewbogott | ok, that's what I expected. | 23:11 |
david-lyle | is the link not there? | 23:11 |
david-lyle | the more link? | 23:11 |
david-lyle | which takes you to the projects page? | 23:11 |
andrewbogott | It was there in kilo, it's no longer present in liberty | 23:11 |
hurgleburgler | That drop down uses the _selection_menu.scss stuff | 23:11 |
andrewbogott | but with or without, either way it's not very usable | 23:12 |
david-lyle | who broke the link | 23:12 |
hurgleburgler | you can generalize the change and add it to that file, but if you want it to specifically only work for the project one, then you can add a new component scss file | 23:12 |
david-lyle | neither is a dropdown of 500-1000 items | 23:12 |
andrewbogott | regardless it needs to be a menu with a scrollbar to be actually useful | 23:12 |
hurgleburgler | is the link broken? It sounds like the experience is just flawed? | 23:12 |
hurgleburgler | its been discussed quite a bit | 23:12 |
hurgleburgler | it should probably be a limited dropdown, but with a combobox feature that will allow a typed filter | 23:13 |
david-lyle | type filter would be workable | 23:13 |
andrewbogott | hurgleburgler: if you look at the top of that bug, you will see the description of how it acted in kilo | 23:13 |
andrewbogott | the current experience in liberty is different, slightly worse | 23:13 |
andrewbogott | if there are other bugs tracking this issue then I can close my bug or consolidate or something... | 23:14 |
hurgleburgler | something like this: | 23:14 |
hurgleburgler | http://bootstrap-combobox-test.herokuapp.com/ | 23:14 |
hurgleburgler | or selectize | 23:14 |
hurgleburgler | Not sure if there are other bugs, but there haven't been complaints about the scale concern | 23:14 |
andrewbogott | both of those drop-downs have scrollbars, so both are already way better | 23:15 |
hurgleburgler | http://selectize.github.io/selectize.js/ —> the Single Item Select | 23:15 |
andrewbogott | Any of these options look good to me :) | 23:16 |
*** yamamoto_ has joined #openstack-horizon | 23:16 | |
david-lyle | andrewbogott: why not just set the max to 1000 | 23:17 |
david-lyle | ? | 23:17 |
david-lyle | it is configurable after all | 23:18 |
*** ybathia has joined #openstack-horizon | 23:18 | |
*** Mounica has joined #openstack-horizon | 23:18 | |
hurgleburgler | That works too | 23:18 |
*** garthb has joined #openstack-horizon | 23:18 | |
andrewbogott | that makes a scroll bar that is taller than my screen. I can scroll the whole browser window down (causing the Horizon gui to vanish in the distance) to see remaining items in the list... | 23:18 |
andrewbogott | it's slightly better than the status quo but also kind of silly :) | 23:18 |
hurgleburgler | we can set the max-height on that thing to be 100vh | 23:19 |
hurgleburgler | or something like calc(100vh - navheight) | 23:19 |
hurgleburgler | then, it would scroll better | 23:19 |
hurgleburgler | or 50vh would work too | 23:19 |
andrewbogott | that's approximately what the next-to-last comment on that bug suggests, right? | 23:19 |
TravT | david-lyle: is there a way to add policy files via the enabled file? | 23:20 |
TravT | i'm not seeing it in documentation | 23:20 |
*** yamamoto_ has quit IRC | 23:21 | |
hurgleburgler | Yeah, its what Tyr is suggesting, but I wouldn't hard code the height like that | 23:21 |
hurgleburgler | make it something that is dynamic based on the view height | 23:21 |
hurgleburgler | and that would need to go in _navbar.scss | 23:21 |
*** cloudtrainme has quit IRC | 23:21 | |
andrewbogott | that would be… one of these? | 23:22 |
andrewbogott | https://www.irccloud.com/pastebin/9T7QErea/ | 23:22 |
*** clu_ has quit IRC | 23:22 | |
hurgleburgler | dashboard/scss/components/_navbar.scss | 23:22 |
hurgleburgler | but, any change that you make, be sure to test it against the responsive behavior for both 'default' and 'material' | 23:23 |
*** sdake has joined #openstack-horizon | 23:23 | |
hurgleburgler | *meaning make the screen really narrow to make sure it works properly still* | 23:23 |
*** jamielennox|away is now known as jamielennox | 23:23 | |
hurgleburgler | it may need a media query around it, but I'll leave that to you to figure out :) | 23:24 |
andrewbogott | ok, so back to my original issue of 'nothing I change in scss seems to do anything' | 23:25 |
*** cloudtrainme has joined #openstack-horizon | 23:25 | |
*** rebase has quit IRC | 23:25 | |
andrewbogott | https://www.irccloud.com/pastebin/z9ZKhyjs/ | 23:26 |
andrewbogott | ^ this change does nothing | 23:26 |
david-lyle | TravT: no | 23:26 |
david-lyle | .d file yes | 23:26 |
andrewbogott | Keep in mind that I'm totally new to this framework and only barely know what css is, so feel free to point out obvious mistsakes | 23:26 |
*** cloudtrainme has quit IRC | 23:26 | |
david-lyle | TravT, but it will only work for one plugin | 23:27 |
david-lyle | well, scratch that | 23:27 |
*** cloudtrainme has joined #openstack-horizon | 23:27 | |
david-lyle | will work for more than one plugin | 23:27 |
TravT | okay, do you have an example of that? | 23:27 |
hurgleburgler | andrewbogott I don't run with apache, but the django development server usually and whenever I make a change, I always | 23:28 |
TravT | i'm looking at http://docs.openstack.org/developer/horizon/topics/settings.html#openstack-settings-partial | 23:28 |
hurgleburgler | rm -rf static/;python manage.py collectstatic --noinput; python manage.py compress; | 23:28 |
TravT | it says "override" | 23:28 |
david-lyle | TravT: can't you just add a new string to the dict? | 23:29 |
* david-lyle has to look more closely | 23:29 | |
TravT | in local_settings.py? | 23:29 |
TravT | yes, i can do that | 23:30 |
TravT | but in creating a devstack plugin | 23:30 |
TravT | don't see an existing way to do that | 23:30 |
david-lyle | TravT: to do what? | 23:31 |
david-lyle | oh, missed first sentence | 23:31 |
*** cloudtrainme has quit IRC | 23:32 | |
david-lyle | I was thinking putting policy_files["search"] = <path to file> | 23:32 |
david-lyle | in your .d file | 23:32 |
TravT | okay yeah, i can try that | 23:33 |
david-lyle | sorry POLICY_FILES['search'] = <file name> | 23:33 |
*** clu_ has joined #openstack-horizon | 23:36 | |
*** ChanServ sets mode: +v clu_ | 23:36 | |
andrewbogott | ok, hurgleburgler, by changing the height of the navbar brand image I've found an incantation that regenerates css. Nonetheless, changing the .dropdown-menu settings has no effect on the project selector. Is it possible that that widget is something other than a dropdown-menu? | 23:39 |
*** itisha has quit IRC | 23:39 | |
hurgleburgler | Its a dropdown :) | 23:41 |
hurgleburgler | in fact, its a double dropdown | 23:42 |
hurgleburgler | you'll wanna grab the right one | 23:42 |
hurgleburgler | also, is your setup running domains or regions? | 23:42 |
TravT | david-lyle: that seemed to do the trick. | 23:43 |
david-lyle | \o/ | 23:43 |
andrewbogott | hurgleburgler: regions | 23:43 |
andrewbogott | Ah, if I do 'dropdown' rather than 'dropdown-menu' I see results. | 23:44 |
hurgleburgler | works for me | 23:44 |
hurgleburgler | https://i.imgur.com/oQO3r8c.png | 23:44 |
hurgleburgler | (the scroll hides on osx) | 23:44 |
hurgleburgler | .context-selection .dropdown-menu { | 23:45 |
hurgleburgler | max-height: 50vh; | 23:45 |
hurgleburgler | overflow-x: hidden; | 23:45 |
hurgleburgler | overflow-y: scroll; | 23:45 |
hurgleburgler | } | 23:45 |
andrewbogott | huh | 23:45 |
* andrewbogott tries it | 23:45 | |
hurgleburgler | that's not gonna work for 'material' though | 23:46 |
hurgleburgler | probably best to put it on the parent dropdown-menu like you mentioned | 23:46 |
andrewbogott | hm, nope, cutting and pasting your code definitely doesn't work for me | 23:47 |
andrewbogott | must be version differences since I'm using liberty code | 23:48 |
hurgleburgler | .context-selection { | 23:48 |
hurgleburgler | max-height: 50vh; | 23:48 |
hurgleburgler | overflow-x: hidden; | 23:48 |
hurgleburgler | overflow-y: scroll; | 23:48 |
hurgleburgler | } | 23:48 |
hurgleburgler | that's what it should be | 23:48 |
hurgleburgler | Oh, liberty?? | 23:48 |
hurgleburgler | yeah, that navbar was refactored | 23:48 |
*** SimonChung has joined #openstack-horizon | 23:49 | |
*** yamamoto_ has joined #openstack-horizon | 23:50 | |
*** jamielennox is now known as jamielennox|away | 23:51 | |
*** sdake_ has joined #openstack-horizon | 23:53 | |
*** sdake has quit IRC | 23:56 | |
*** hurgleburgler has quit IRC | 23:56 | |
*** hurgleburgler has joined #openstack-horizon | 23:57 | |
*** ChanServ sets mode: +v hurgleburgler | 23:57 | |
*** jamielennox|away is now known as jamielennox | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!