vishalmanchanda | #startmeeting horizon | 15:00 |
---|---|---|
opendevmeet | Meeting started Wed Jun 23 15:00:48 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
rdopiera | o/ | 15:02 |
e0ne | hi | 15:02 |
vishalmanchanda | Hi everyone | 15:02 |
tmazur | o/ | 15:03 |
vishalmanchanda | #topic Notices | 15:03 |
vishalmanchanda | Just an reminder next milestone i.e. Xena-2 is in week of Jul 12 - Jul 16. | 15:04 |
vishalmanchanda | Xena Schedule https://releases.openstack.org/xena/schedule.html | 15:05 |
vishalmanchanda | #topic stable branches | 15:05 |
vishalmanchanda | Does anybody have environment with stable/stein or stable/train branch? | 15:06 |
rdopiera | I do | 15:07 |
vishalmanchanda | I am asking because we have two backport purposed to those branches but it is abandoned by owner due to no reviews on those patches. | 15:07 |
amotoki | I prepare them when they are needed per review. | 15:07 |
vishalmanchanda | patch link https://review.opendev.org/c/openstack/horizon/+/781805 https://review.opendev.org/c/openstack/horizon/+/781804 | 15:07 |
vishalmanchanda | rdopiera: amotoki : Could you please tests those patches. | 15:07 |
amotoki | I noticed these backports but I intentionlly wait for other reviews. | 15:07 |
amotoki | I usually review backports first but I would like to know what happens when I do not. | 15:08 |
vishalmanchanda | Now a days I am having bad-luck in setting devstack env. It always with new errors. | 15:08 |
vishalmanchanda | Also my OS is focal(20.04) and I can't those patches with current env. | 15:09 |
amotoki | I usually use VMs for testing, so I prepare required ubuntu versions depending on branches. | 15:10 |
amotoki | but I think horizon stable/stein or train works on focal too. | 15:10 |
rdopiera | I use a vm for the openstack, but run horizon itself with tox straight from the repository | 15:11 |
rdopiera | in this case it shouldn't matter what version of openstack horizon is connecting to | 15:11 |
vishalmanchanda | amotoki: really but when I try to test those patches horizon fails to run with python errors I think. | 15:11 |
vishalmanchanda | amotoki: with devstack on focal OS. | 15:12 |
amotoki | vishalmanchanda: it's not surprising as devstack target is only the latest ubuntu lts. | 15:12 |
amotoki | okay anyway let's check backports related to the material theme. | 15:13 |
vishalmanchanda | amotoki: rdopiera thanks, please restore and review those patches. | 15:14 |
amotoki | regarding queens, are we going to EOL queens? | 15:14 |
rdopiera | I'm fine with that | 15:14 |
amotoki | rdopiera: what is the current min release you would like to keep from RH perspective? | 15:15 |
rdopiera | amotoki: train | 15:15 |
amotoki | rdopiera: thanks. sounds good :) | 15:16 |
rdopiera | and then wallaby | 15:16 |
vishalmanchanda | I am also okay to move queen to EOL if nobody have any issue with that. | 15:17 |
amotoki | I am okay with it too | 15:17 |
vishalmanchanda | In that case I'll push a patch to release and sent a announcement mail about that on open-discuss. | 15:18 |
vishalmanchanda | Next one is https://review.opendev.org/c/openstack/horizon/+/725785 | 15:20 |
vishalmanchanda | Could stable cores abandon this patch as there is no activity on this patch from long. | 15:20 |
vishalmanchanda | I am asking because I have purposed a patch to move stable/pike to EOL and for that this patch either need to merged or abandon. | 15:21 |
vishalmanchanda | Move pike to EOL patch link https://review.opendev.org/c/openstack/releases/+/791707 | 15:22 |
amotoki | the author responded very slow and the patch stays for long. It was proposed just one year ago. so I think we can abandon this. | 15:23 |
tmazur | I've tried to fix the tests for that patch and apparently it's not that simple, a lot of code has been changed. | 15:23 |
tmazur | So +1 for abandoning | 15:23 |
opendevreview | Radomir Dopieralski proposed openstack/horizon stable/pike: Allow OVA upload for images https://review.opendev.org/c/openstack/horizon/+/725785 | 15:24 |
rdopiera | just fixed the indentation, but that's probably not enough | 15:25 |
*** ianychoi_ is now known as ianychoi | 15:25 | |
rdopiera | +1 for abandon as well | 15:25 |
amotoki | IIRCthe related code was changed between pike and queens so UT is failing. | 15:26 |
rdopiera | right, it was just my OCD with the indentation | 15:27 |
vishalmanchanda | ok Stable cores please abandon above patch as discussed. | 15:27 |
amotoki | okay, I will take care of it with a comment | 15:27 |
vishalmanchanda | amotoki: thanks. | 15:27 |
rdopiera | oops, done already | 15:28 |
amotoki | rdopiera: np | 15:28 |
vishalmanchanda | I have no more specific topic to discuss for this week. | 15:29 |
vishalmanchanda | #topic open-discussion | 15:29 |
vishalmanchanda | amotoki: I left a comment on your patch https://review.opendev.org/c/openstack/horizon/+/777390. | 15:29 |
vishalmanchanda | Could you respond on that once you have time. | 15:30 |
rdopiera | I have two topics | 15:30 |
vishalmanchanda | rdopiera: please go ahead. | 15:30 |
amotoki | rdopiera: horizon-non-primary-django-jobs is to check non-default django version. it is not specific to pre-django 3.x. | 15:31 |
amotoki | rdopiera: sorry. | 15:31 |
amotoki | I meant vishalmanchanda :p | 15:31 |
rdopiera | We finally made progress with running the upstream integration tests on our downstream repo, but we face some problems because of our custom theme has different html structure and some of the CSS selectors need to be changed. | 15:32 |
rdopiera | We can do it with a downstream patch, but we think that a cleaner solution would be to make those selectors configurable in the local-horiozn.conf file. | 15:32 |
rdopiera | I proposed a blueprint for this: https://blueprints.launchpad.net/horizon/+spec/configurable-selectors-in-integration-tests | 15:32 |
e0ne | rdopiera: +1 on this. we'd got such issue in the past | 15:34 |
vishalmanchanda | rdopiera: cool.. | 15:34 |
rdopiera | This would allow us to share the tests directly, and to make our QE write upstream tests | 15:34 |
amotoki | it would be nice if the problem description covers some examples. | 15:34 |
rdopiera | amotoki: I will add that | 15:34 |
ikanias | +1 | 15:35 |
amotoki | anyway sharing integration tests is nice | 15:35 |
rdopiera | ikanias is our QE, by the way | 15:36 |
ikanias | :-) | 15:36 |
rdopiera | Second think is a question to amotoki. I know you wanted to write the base for the system-scope token yourself, but would you mind if I started with some simple proof of concept for that? I wanted to give it a try, but I'm not confident I can make it good enough. | 15:37 |
rdopiera | s/think/thing | 15:37 |
amotoki | I had some progress but my base machine was crusshed and lost the code.... | 15:38 |
amotoki | am recovering my memory | 15:38 |
rdopiera | sorry for your loss | 15:38 |
amotoki | rdopiera: your POC is fine too. | 15:39 |
rdopiera | thanks, I will look into that then | 15:39 |
vishalmanchanda | great work team:) | 15:40 |
vishalmanchanda | talking about integration-test one of my college trying to add a integration job for tacker-horizon. | 15:41 |
vishalmanchanda | but it as of now it is failing due to some errors. | 15:41 |
vishalmanchanda | patch link https://review.opendev.org/c/openstack/tacker-horizon/+/790958 | 15:41 |
vishalmanchanda | It would be great if anyone know the issue and help her to fix it. | 15:43 |
rdopiera | RuntimeError: Could not find firefox in your system PATH. Please specify the firefox binary location or install firefox | 15:43 |
rdopiera | hmmm | 15:43 |
amotoki | how is bindep.txt configured? | 15:44 |
e0ne | vishalmanchanda: I just setup env to test it. will to it tonight | 15:44 |
vishalmanchanda | e0ne: thanks Ivan. | 15:44 |
amotoki | vishalmanchanda: do you mean a failure in pre-run phase? | 15:46 |
vishalmanchanda | amotoki: yeah that one also. | 15:47 |
vishalmanchanda | amotoki: Also got ``RuntimeError: Could not find firefox in your system PATH. Please specify the firefox binary location or install firefox`` error. | 15:48 |
amotoki | vishalmanchanda: in which log? | 15:49 |
amotoki | vishalmanchanda: in the log of the last run, it failed with retry limit in pre-run phase. | 15:49 |
amotoki | woops. what I looked was not the last run.. | 15:51 |
vishalmanchanda | current error log for integration-job https://zuul.opendev.org/t/openstack/build/b682dd24be274f0db624a389ff6cb681/log/job-output.txt#30449 | 15:52 |
vishalmanchanda | amotoki: before that it is failing with OVN issues then I disable OVN. | 15:53 |
vishalmanchanda | ok does anyone have more topic to discuss? | 15:57 |
amotoki | none from me | 15:58 |
vishalmanchanda | Let's end this meeting. | 15:59 |
vishalmanchanda | Thanks everyone for joining, see you next week. | 15:59 |
vishalmanchanda | TC! | 15:59 |
vishalmanchanda | Just an reminder we have many open patches with no review from long. | 15:59 |
vishalmanchanda | Please take a look.. | 16:00 |
vishalmanchanda | #endmeeting | 16:00 |
opendevmeet | Meeting ended Wed Jun 23 16:00:21 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-06-23-15.00.html | 16:00 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-06-23-15.00.txt | 16:00 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-06-23-15.00.log.html | 16:00 |
amotoki | vishalmanchanda: regarding devstack log, tacker or tacker-horizon log is hard to read. It seems xtrace is disabled somewhere in tacker or tacker-horizon devstack plugin. | 16:00 |
vishalmanchanda | amotoki: hmm. | 16:01 |
amotoki | vishalmanchanda: which phase of destack plugin is failing? | 16:02 |
vishalmanchanda | amotoki: https://zuul.opendev.org/t/openstack/build/b682dd24be274f0db624a389ff6cb681/console | 16:04 |
vishalmanchanda | Play: all run-devstack: Run devstack | 16:05 |
amotoki | vishalmanchanda: apparently it is failing in the install phase in devstack plugin looking at tacker/devstack plugin. | 16:07 |
amotoki | vishalmanchanda: is it the first time that the tacker team runs devstack with tacker-horizon in the gate? | 16:08 |
vishalmanchanda | amotoki: yes I think so https://github.com/openstack/tacker-horizon/blob/master/.zuul.yaml | 16:09 |
amotoki | vishalmanchanda: if so, the next question is whether devstack run with a same local.conf in a local env. | 16:09 |
amotoki | s/run/can run/ | 16:09 |
vishalmanchanda | amotoki: ok my local.conf is different. | 16:10 |
amotoki | vishalmanchanda: there is no silver bullet to debug it. you need to do it step by step. | 16:11 |
amotoki | vishalmanchanda: especially I recommend to use a fresh ubuntu env. | 16:11 |
vishalmanchanda | amotoki: so do you mean I should use my local env. local.conf file in .zuul.yaml for setting tacker-horizon-integration-tests job | 16:14 |
amotoki | vishalmanchanda: what i can say at least is that it is a problem in devstack run, so in most cases local devstack run heps a lot when debugging such issue from my experience in neutron. | 16:15 |
amotoki | vishalmanchanda: I don't know the sitaution in tacker/tacker-horizon, so my advise is just general. | 16:15 |
vishalmanchanda | amotoki: ohh I see. | 16:15 |
vishalmanchanda | Let me try that. | 16:15 |
amotoki | I can help from POV of zuul configuration or gate specific points but as far as I see I don't think it is such thing. | 16:16 |
opendevreview | Merged openstack/horizon stable/victoria: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/797185 | 17:02 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!