| opendevreview | Akihiro Motoki proposed openstack/horizon master: instance UT: Recover mock_server_get.return_value https://review.opendev.org/c/openstack/horizon/+/832735 | 00:52 |
|---|---|---|
| opendevreview | Akihiro Motoki proposed openstack/horizon stable/wallaby: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/829663 | 00:56 |
| opendevreview | Akihiro Motoki proposed openstack/horizon stable/victoria: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/829686 | 01:12 |
| opendevreview | Akihiro Motoki proposed openstack/horizon stable/ussuri: Fix for "Resize instance" button https://review.opendev.org/c/openstack/horizon/+/829706 | 01:14 |
| vishalmanchanda | a#startmeeting horizon | 15:01 |
| vishalmanchanda | #startmeeting horizon | 15:01 |
| opendevmeet | Meeting started Wed Mar 9 15:01:47 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:01 |
| vishalmanchanda | Hi, anyone around for horizon weekly meeting. | 15:03 |
| e0ne | hi | 15:03 |
| rdopiera | hi | 15:04 |
| vishalmanchanda | I can't find any topic to discuss for today's meeting in our etherpad. | 15:05 |
| vishalmanchanda | https://etherpad.opendev.org/p/horizon-release-priorities (at line 32) | 15:05 |
| vishalmanchanda | Also Not any updates from my side for this week. | 15:05 |
| vishalmanchanda | I just want to remind about some patches which are good to have in yoga release. | 15:06 |
| vishalmanchanda | So moving directly to open-discussion. | 15:06 |
| vishalmanchanda | #topic open-discussion | 15:06 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/832735 (trivial patch) | 15:07 |
| vishalmanchanda | Can I have quick approval on this one. | 15:07 |
| vishalmanchanda | Next I am waiting for patch which hides System Scope menu. | 15:08 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/818763 | 15:08 |
| vishalmanchanda | rdopiera: Is it ready for review? | 15:08 |
| rdopiera | vishalmanchanda: I need to add docs and release note, I'm working on it | 15:09 |
| rdopiera | vishalmanchanda: but I would be grateful for any feedback on what is there so far | 15:09 |
| vishalmanchanda | rdopiera: ok, thanks | 15:10 |
| vishalmanchanda | rdopiera: I tested your patch today | 15:10 |
| vishalmanchanda | rdopiera: but It also hided the Identity dashboard which is wrong. | 15:10 |
| vishalmanchanda | hides* | 15:10 |
| rdopiera | it just moves it between the system scope and admin menus | 15:11 |
| rdopiera | depending on whether identity is enabled or not | 15:11 |
| rdopiera | by default, with the list empty, there should be no change from previous versions of horizon | 15:13 |
| vishalmanchanda | rdopiera: So I have do some changes to see identity dashboard after applying your patch | 15:13 |
| vishalmanchanda | ? | 15:13 |
| rdopiera | with SYSTEM_SCOPE_SERVICES = [] the behavior of horizon should be exactly the same as before the system scope patche3s | 15:14 |
| vishalmanchanda | rdopiera: but it is different for me | 15:15 |
| rdopiera | that's a bug in my code then | 15:16 |
| vishalmanchanda | rdopiera: It look like this https://ibb.co/2qgjVKx to me | 15:17 |
| vishalmanchanda | rdopiera: after applying your patch | 15:17 |
| vishalmanchanda | rdopiera: No Identity dashboard. | 15:17 |
| rdopiera | I will check it, thanks | 15:18 |
| vishalmanchanda | Maybe tmazur or e0ne can test your patch and let's see. | 15:18 |
| vishalmanchanda | rdopiera: cool. | 15:19 |
| vishalmanchanda | Next one is https://review.opendev.org/c/openstack/horizon/+/819725 | 15:19 |
| vishalmanchanda | some minor comments from amotoki otherwise LGTM | 15:19 |
| tmazur | I'll address them asap | 15:21 |
| vishalmanchanda | Last one in my list series to fix Django4 deprecation warning. | 15:21 |
| vishalmanchanda | tmazur: thanks:) | 15:21 |
| vishalmanchanda | https://review.opendev.org/q/topic:django40-warnings+status:open | 15:21 |
| vishalmanchanda | Please a look at above patches, once you have time. | 15:22 |
| -amotoki- ignores all DeprecationWarning in my local test env now :p | 15:22 | |
| vishalmanchanda | Most of them look into good shape to merge in yoga cycle except System Scope hide Menu | 15:23 |
| vishalmanchanda | I hope rdopiera fix that issue I mentioned above soon in his patch. | 15:24 |
| vishalmanchanda | Otherwise we will backport it to stable/yoga once merged in the master branch. | 15:24 |
| vishalmanchanda | Also, we follow cycle with intermediary releases, So either me or release team cut a final release for horizon with latest patch in week of Mar 21 - Mar 25. | 15:26 |
| vishalmanchanda | that's all update from my side for this week. | 15:27 |
| vishalmanchanda | If anyone like to raise any other topic here, please go ahead. | 15:27 |
| amotoki | one question on an old backport patch https://review.opendev.org/c/openstack/horizon/+/797104 | 15:28 |
| amotoki | Do you think it is feasible to backport or is it a feature backport? | 15:28 |
| vishalmanchanda | amotoki: Looking at this patch now, I am not in favor of backporting this to stable/wallaby. | 15:31 |
| vishalmanchanda | If stable cores want to merge this in stable/wallaby, please go ahead. | 15:32 |
| amotoki | I was waiting for feedbacks from other reviewers for over 6 months but did not get any, so i am raising it here. | 15:32 |
| e0ne | amotoki: it's a good question. it changes defaults so I'm going put -2 on it | 15:33 |
| vishalmanchanda | If we support this now, we see more features backport into stable branches which doesn't look good to me. | 15:33 |
| e0ne | amotoki: it does really good thing, some some users could expect their current 'random default' | 15:33 |
| vishalmanchanda | although it's a minor feature. | 15:33 |
| amotoki | one reason I think it is a kind of bug too is that the current implementation does not allow users to specify "any" as AZ. | 15:34 |
| amotoki | Once a user selects AZ, theree is no way to cancel the selection (i.e. "any") | 15:34 |
| e0ne | hm... interesting | 15:34 |
| amotoki | only way is to close the form and re-open it. | 15:35 |
| e0ne | amotoki: now I'm ok to have this fix with a propper commit message | 15:36 |
| amotoki | if ok, I can update the commit mesasge to explain why. | 15:37 |
| vishalmanchanda | ok if stable core have no objection with merging into stable/wallaby, please go ahead. | 15:38 |
| vishalmanchanda | One more question here. | 15:38 |
| vishalmanchanda | Are we going to backport it into more stable branches like ussuri, victoria? | 15:39 |
| amotoki | I think the implementation is same for such branches, so if we accept the backport in wallaby there is no reason to reject it. | 15:40 |
| vishalmanchanda | ok thanks for clarifying. | 15:40 |
| amotoki | thanks all. I will follow it up including the commit mesasge and the release note to describe the situation. | 15:41 |
| vishalmanchanda | If nothing more to discuss, we can end this meeting. | 15:43 |
| vishalmanchanda | thanks everyone for joining. | 15:43 |
| amotoki | nothing more from me | 15:43 |
| vishalmanchanda | TC. | 15:43 |
| vishalmanchanda | #endmeeting | 15:44 |
| opendevmeet | Meeting ended Wed Mar 9 15:44:10 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:44 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-03-09-15.01.html | 15:44 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-03-09-15.01.txt | 15:44 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-03-09-15.01.log.html | 15:44 |
| amotoki | technical committee? :-) | 15:44 |
| amotoki | i know what it means though | 15:44 |
| vishalmanchanda | I mean Take Care:) | 15:45 |
| vishalmanchanda | 🙂 | 15:45 |
| opendevreview | Merged openstack/horizon master: instance UT: Recover mock_server_get.return_value https://review.opendev.org/c/openstack/horizon/+/832735 | 15:49 |
| opendevreview | Radomir Dopieralski proposed openstack/horizon master: WIP Add SYSTEM_SCOPE_SERVICES setting that hides panels https://review.opendev.org/c/openstack/horizon/+/818763 | 15:59 |
| rdopiera | vishalmanchanda: ^^ this should fix the bug you saw, thanks again for catching it | 15:59 |
| rdopiera | I should add the docs today | 15:59 |
| rdopiera | really sorry for the delays | 15:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!