vishalmanchanda | #startmeeting horizon | 15:00 |
---|---|---|
opendevmeet | Meeting started Wed Jul 27 15:00:18 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
rdopiera | o/ | 15:01 |
vishalmanchanda | Hello everyone | 15:01 |
tmazur | o/ | 15:01 |
vishalmanchanda | let's start the meeting | 15:02 |
vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39 | 15:02 |
vishalmanchanda | #topic Notices | 15:03 |
vishalmanchanda | A casual reminder about schedule. | 15:03 |
vishalmanchanda | This week is R-10 week. | 15:03 |
vishalmanchanda | For more info about schedule please refer https://releases.openstack.org/zed/schedule.html | 15:03 |
amotoki | hi | 15:03 |
vishalmanchanda | moving to next announcement | 15:04 |
vishalmanchanda | OpenStack next release name is announced and it is Antelope. | 15:04 |
vishalmanchanda | https://lists.openstack.org/pipermail/openstack-discuss/2022-July/029672.html | 15:04 |
vishalmanchanda | I have no other announcements to make, if anyone have any announcement to make. please go ahead. | 15:06 |
amotoki | i have one | 15:06 |
amotoki | as discussed last week, I added you horizon cores to horizon-coresec lp team. | 15:06 |
amotoki | you can now check private sec bugs. | 15:06 |
amotoki | non-active members are clean up too. | 15:06 |
vishalmanchanda | amotoki: thanks, I can see private sec bug now. | 15:07 |
amotoki | I also adjusted member list of other launchpad teams like horizon-bugs and horizon-drivers. | 15:07 |
amotoki | horizon-drivers members are updated to have active members only | 15:08 |
amotoki | horizon-bugs includes horizon-drivers team, so members of horizon-drivers (i.e. horizon-cores) are now removed from horizon-bugs to avoid duplications. | 15:09 |
amotoki | that's all from me. | 15:09 |
amotoki | one note: you can find info on lp teams in https://docs.openstack.org/horizon/latest/contributor/policies/horizon-groups.html | 15:10 |
vishalmanchanda | amotoki: ack. | 15:10 |
vishalmanchanda | I am not having many updates for this week because I was on Sick leave and joined today. | 15:12 |
vishalmanchanda | moving to next topic | 15:12 |
vishalmanchanda | #topic Bug deputy report | 15:12 |
vishalmanchanda | There are some new bugs reported in the last few weeks. | 15:12 |
vishalmanchanda | Dropping bug links here https://bugs.launchpad.net/horizon/+bug/1980214 | 15:13 |
amotoki | it is specific to django 4 | 15:14 |
vishalmanchanda | yeah... | 15:15 |
amotoki | I don't think we need to include a fix for django 4 in stable/yoga. | 15:16 |
vishalmanchanda | amotoki: make sense. | 15:16 |
amotoki | I think it is better to have a fix/workaround in master and let zigo to backport it to stable/yoga. | 15:16 |
amotoki | * stable/yoga in Debian | 15:16 |
vishalmanchanda | amotoki: +1. | 15:17 |
vishalmanchanda | Next bug link https://bugs.launchpad.net/horizon/+bug/1979662 | 15:18 |
vishalmanchanda | It looks difficult to reproduce this bug for me in local env. | 15:19 |
amotoki | vishalmanchanda: don't you hit any change around apache reload? | 15:20 |
amotoki | I wonder apache reload happens around log rotation | 15:21 |
zigo | amotoki: If you send me patches, that's fine enough to me ! :) | 15:21 |
zigo | (just pointing me to the review URL) | 15:22 |
zigo | Zed is comming fast anyways... | 15:22 |
vishalmanchanda | amotoki: hmm, I never noticed that so far. | 15:23 |
amotoki | zigo: ack, but it is totally on best effort basis. I am not sure I can work on it soon :p | 15:23 |
vishalmanchanda | Next bug is https://bugs.launchpad.net/horizon/+bug/1981165 | 15:26 |
vishalmanchanda | It will check and confirm this one after the meeting. | 15:27 |
vishalmanchanda | next bug link https://bugs.launchpad.net/horizon/+bug/1982836 | 15:28 |
vishalmanchanda | bug 1982836 looks invalid to me becuase error msg metioned in bug summary look valid deprecation warning to me. | 15:31 |
amotoki | it is not so straight-forward. | 15:31 |
amotoki | the deprecation warnings happen even when horizon default policies. | 15:32 |
amotoki | it is not a neglect of operators. they can do nothing. | 15:32 |
amotoki | I know it is very noisy | 15:32 |
vishalmanchanda | Can't someone disable these warning by changing some setting in conf. file? | 15:32 |
amotoki | it can, but I think the default setting (or example settings) should have it. | 15:33 |
amotoki | it sounds a kind of bad default settings to me. | 15:34 |
amotoki | in addition, I haven't check there is a negative impact when dsiabling DeprecationWarning for oslo.policy. | 15:37 |
vishalmanchanda | I'll check that and add my thoughts in bug summary. | 15:38 |
vishalmanchanda | Next bug link https://bugs.launchpad.net/horizon/+bug/1982944 | 15:38 |
vishalmanchanda | bug 1982944 needs to check and confirm. | 15:40 |
vishalmanchanda | I'll check and try to reproduce it tommorow. | 15:40 |
rdopiera | it's because horizon doesn't actually check detailed policies | 15:41 |
rdopiera | it just checks if it's an admin | 15:41 |
rdopiera | we have a lot of places where the policies are super-detailed, but horizon simply ignores them | 15:42 |
rdopiera | like, in neutron you can practically change access to individual form fields per user, but horizon just displays them all regardless | 15:42 |
rdopiera | I have a patch for review changing that for a single field that was roblematic, in routers, but I'm not sure we should actually be checking all those policies all the time | 15:43 |
vishalmanchanda | rdopiera: ack. | 15:48 |
amotoki | yeah, we have many hard-coded access checks | 15:48 |
amotoki | honestly I tried to clean them up several years ago, but complexity around mixied situation of Django vs AngularJS and it was on-going and I gave it up :p | 15:50 |
rdopiera | one problem with implementing more detailed checks is that they usually require additional information - like the owner of the network etc. - and that's additional api calls | 15:50 |
amotoki | rdopiera: perhaps we can split problesm into two categories: the one is policy checks based on fields, the other is our hard-coded rules. | 15:51 |
amotoki | the first one requires additional information which leads to extra API calls as you said | 15:52 |
rdopiera | amotoki: by the way, if you have a moment, I would really appreciate if you could take a look and say if I'm doing the check correctly here: https://review.opendev.org/c/openstack/horizon/+/810224 | 15:52 |
amotoki | rdopiera: ah, really sorry. I totally forgot it. | 15:52 |
rdopiera | no worries, me too :D | 15:53 |
amotoki | rdopiera: I starred it in gerrit | 15:53 |
rdopiera | sorry for the plug | 15:54 |
rdopiera | going back, I think we are pretty good at least at the menu-level checks | 15:54 |
rdopiera | the actions could use work | 15:55 |
vishalmanchanda | moving to next topic. | 15:55 |
vishalmanchanda | #topic open-discussion | 15:56 |
vishalmanchanda | Does anyone have any other topic to discuss? | 15:56 |
rdopiera | are we doing anything for the ptg? | 15:57 |
rdopiera | is anyone even going? | 15:57 |
vishalmanchanda | I was thinking if we can do it virtually but need to check the process for the same. | 15:58 |
rdopiera | if not, should we arrange a remote planning session shortly after? | 15:58 |
vishalmanchanda | rdopiera: yeah, we can definitely do that. | 15:59 |
rdopiera | doing it during the ptg would have the advantage of making it possible for people from other teams to find us, but then we are also comppeting for time with other sessions | 15:59 |
vishalmanchanda | rdopiera: let's wait for other project team how they plan PTG. | 16:01 |
vishalmanchanda | I just heard from one of my colleagues they will discuss about it in tomorrow's TC meeting. | 16:03 |
vishalmanchanda | then we can also decide. | 16:03 |
vishalmanchanda | anything else to discuss? | 16:03 |
vishalmanchanda | ok let's end this meeting. | 16:05 |
vishalmanchanda | Thanks everyone for joining! | 16:06 |
vishalmanchanda | #endmeeting | 16:06 |
opendevmeet | Meeting ended Wed Jul 27 16:06:18 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:06 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-07-27-15.00.html | 16:06 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-07-27-15.00.txt | 16:06 |
opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-07-27-15.00.log.html | 16:06 |
sdrozdov | Would anyone be able to take a look at the following: https://blueprints.launchpad.net/horizon/+spec/load-balancers-in-admin-tab , https://bugs.launchpad.net/horizon/+bug/1982966 | 18:09 |
sdrozdov | amotoki: The https://bugs.launchpad.net/horizon/+bug/1982966 follows on from our discussion yesterday, it would be very kind of you if you could take a look at it. | 18:10 |
opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Fix "Set admin password" checkbox visibility https://review.opendev.org/c/openstack/horizon/+/851258 | 20:22 |
opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Fix flavor specification at instance overview page https://review.opendev.org/c/openstack/horizon/+/848905 | 20:25 |
opendevreview | Akihiro Motoki proposed openstack/horizon master: Preparation for Django 4.0 https://review.opendev.org/c/openstack/horizon/+/851261 | 21:31 |
opendevreview | Akihiro Motoki proposed openstack/horizon master: Make site_branding tag work with Django 4.0 https://review.opendev.org/c/openstack/horizon/+/851262 | 21:31 |
opendevreview | Akihiro Motoki proposed openstack/horizon master: Preparation for Django 4.0 https://review.opendev.org/c/openstack/horizon/+/851261 | 23:24 |
opendevreview | Akihiro Motoki proposed openstack/horizon master: Make site_branding tag work with Django 4.0 https://review.opendev.org/c/openstack/horizon/+/851262 | 23:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!