| opendevreview | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/851333 | 04:18 |
|---|---|---|
| opendevreview | Merged openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/851333 | 06:25 |
| zigo | rdopiera: amotoki: When you have time, please review these: https://review.opendev.org/q/topic:django-4 | 14:48 |
| zigo | I'm likely to write some more, as many plugins are affected. | 14:48 |
| rdopiera | didn't we just migrate to django D | 14:56 |
| rdopiera | to django 3 | 14:56 |
| rdopiera | zigo: they are all failing pep8 tests | 14:57 |
| rdopiera | and there are some undefined variables caught by those tests too | 14:58 |
| zigo | rdopiera: Not really, there's a POST_FAILURE, meaning the infra couldn't post its log, no ? | 14:58 |
| rdopiera | https://review.opendev.org/c/openstack/trove-dashboard/+/851415/1/trove_dashboard/test/urls.py#18 | 14:58 |
| rdopiera | zigo: did you actually test those changes? | 14:58 |
| zigo | Yep, in my packaging ... | 14:58 |
| zigo | So not functional tests. | 14:59 |
| zigo | Looks like it's missing the from django.url import include then. | 14:59 |
| zigo | I'll fix it. | 14:59 |
| zigo | Fixed. :) | 15:03 |
| rdopiera | and the others? | 15:13 |
| amotoki | zigo: regarding trove-dashboard, you patches duplicatges a patch from coreycb before. Isn't it enough? | 16:04 |
| amotoki | zigo: also we hvae similar patches from tkajinam in trove-dashboard before you. I am not sure which one should go. many duplicates. | 16:04 |
| amotoki | I am concerning the situation that nobody from plugin team (or corresponding server project team) reviews for such plugin. | 16:10 |
| amotoki | can't we say such horizon plugins are already inactive (or dead)? | 16:10 |
| amotoki | horizon team is not a maintainer of all pluigns. | 16:10 |
| amotoki | zigo: there are duplicates in trove-dashboard patches around Djnago 3.2 deprecation warnings. I checked the deplicates and picked up more perfect one. | 16:40 |
| amotoki | zigo: ugettext_lazy() one landed and I also +2'ed to your urls() one. Please wait for other reviews. | 16:40 |
| coreycb | amotoki: zigo: there are some outstanding issues for sahara-dashboard that need fixing and I haven't been able to get to them. they are documented here: https://storyboard.openstack.org/#!/story/2010191 | 17:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!