| opendevreview | Victor Coutellier proposed openstack/horizon master: Adapt panel display based on enabled extensions https://review.opendev.org/c/openstack/horizon/+/851914 | 08:02 |
|---|---|---|
| *** tosky_ is now known as tosky | 08:47 | |
| *** lifeless_ is now known as lifeless | 13:51 | |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Aug 3 15:00:10 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| e0ne_ | hi | 15:01 |
| vishalmanchanda | e0ne_: hello, how you doing? | 15:01 |
| e0ne_ | I'm still alive and pretty secure | 15:01 |
| e0ne_ | and I'm going to start contribution asap | 15:02 |
| vishalmanchanda | e0ne_: nice, good to see you back. | 15:02 |
| vishalmanchanda | tmazur: rdoperia: ping for horizon weekly meeting. | 15:02 |
| tmazur | o/ | 15:03 |
| vishalmanchanda | ok let's start the meeting. | 15:03 |
| alistarle | o/ | 15:03 |
| vishalmanchanda | agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39 | 15:03 |
| vishalmanchanda | There is nothing much on etherpad, but let's start the meeting. | 15:04 |
| vishalmanchanda | #topic Notices | 15:04 |
| vishalmanchanda | A casual reminder about schedule. | 15:04 |
| vishalmanchanda | This week is R-9 week. | 15:05 |
| vishalmanchanda | So we have only 1 month left before the feature freeze. | 15:05 |
| vishalmanchanda | For more info about schedule please refer https://releases.openstack.org/zed/schedule.html | 15:06 |
| vishalmanchanda | moving to next announcement | 15:06 |
| vishalmanchanda | announcement about the PTG | 15:07 |
| vishalmanchanda | I remember radomir asking about this. I was thinking if we can do it virtually as most of us not travelling this time. | 15:08 |
| vishalmanchanda | e0ne_: what about you, any travel plans for ptg? | 15:08 |
| amotoki | hi | 15:09 |
| amotoki | e0ne_: very good to hear from you | 15:09 |
| e0ne_ | vishalmanchanda: unfortunately, I can't leave Ukraine until the end of the war | 15:09 |
| vishalmanchanda | e0ne_: ack. | 15:10 |
| e0ne_ | amotoki: thanks. I'm glad to be here too | 15:10 |
| vishalmanchanda | There is no option for virtual signup of PTG, so we have to arrange a zoom session on our own. | 15:10 |
| vishalmanchanda | What we can do, is decide a date for PTG discussion that works for all of us and share the same on open-discuss ML. | 15:11 |
| vishalmanchanda | Does anyone have any issues with that? | 15:12 |
| tmazur | Works for me | 15:12 |
| vishalmanchanda | ok, I guess no one has any issues here. | 15:14 |
| vishalmanchanda | JFYI I am not going to do team signup for the horizon as we are going to do it virtually. | 15:15 |
| vishalmanchanda | https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029831.html | 15:15 |
| vishalmanchanda | I have no other announcements to make, if anyone have any announcement to make. please go ahead | 15:16 |
| vishalmanchanda | moving to next topic | 15:17 |
| vishalmanchanda | #topic Release priorities | 15:17 |
| vishalmanchanda | Xstatic angular migartion to 1.8.2 | 15:18 |
| vishalmanchanda | As some of you already know that many horizon plugins are broken after we migrated to xstatic-angular 1.8.2.2 | 15:20 |
| vishalmanchanda | You can check the status here https://etherpad.opendev.org/p/Fix_Horizon_Plugins_With_Angularjs_v1.8.2.2 | 15:21 |
| amotoki | my question is which plugins really need for a help to catch up with AngularJS 1.8.2.2 and which pluigns are actually unmaintained.... | 15:22 |
| vishalmanchanda | Last time I checked there are some unit test failing for openstack/octavia-dashboard. | 15:22 |
| vishalmanchanda | amotoki: I'll come to your point. | 15:22 |
| amotoki | IMHO horizon team is NOT a maintainer for plugins. we just help it if needed. | 15:22 |
| vishalmanchanda | amotoki: yes, agreed. | 15:23 |
| vishalmanchanda | If I switch to firefox then only 2 npm tests which fails. | 15:23 |
| vishalmanchanda | tmazur: Do you get time to look into that issue? | 15:24 |
| amotoki | vishalmanchanda: which plugin are you talking about? octavia-dashboard? | 15:24 |
| vishalmanchanda | amotoki: yes, octavia-dashboard | 15:24 |
| vishalmanchanda | https://review.opendev.org/c/openstack/octavia-dashboard/+/850528 | 15:24 |
| johnsom | Yeah, I have seen a recent issue with phantomjs jobs. I thought someone had an idea of what was wrong there: SyntaxError: Invalid character: '`' | 15:24 |
| tmazur | vishalmanchanda: about octavia-dashboard it's hard to tell without running it. I had no issues like these with horizon while working on the migration | 15:28 |
| tmazur | And yes, it's phantomjs issue with backticks | 15:28 |
| vishalmanchanda | amotoki: about your point on unmaintained plugins, let's consider, we figure out that this plugin is unmainted then what should be our next step as horizon team? | 15:30 |
| johnsom | Are we moving everything to use the firefox engine for testing? I.e. is the phantomjs issue not going to be resolved? I think we switched from firefox to phantomjs in history due to some issue. But if that is resolved now we can move back. | 15:30 |
| amotoki | vishalmanchanda: according to the recent test result, we hit 5 failures and 2 errors. you said only 2 npm tests failed with firefox. have other 5 failures gone after switching to firefox? | 15:33 |
| vishalmanchanda | amotoki: yes, after switching to firefox only 2 errors left. | 15:36 |
| vishalmanchanda | johnsom: yes, we can switch back to firefox or even try chrome I guess. | 15:37 |
| johnsom | Ok, I have no problem with that. It would be nice to be consistent across horizon and the plugins which engine we use. | 15:39 |
| vishalmanchanda | johnsom: +1 | 15:39 |
| vishalmanchanda | johnsom: Could you take a look at https://review.opendev.org/c/openstack/octavia-dashboard/+/850528 once you have time. | 15:39 |
| johnsom | Yeah, I can update that for merge. I can also attempt a look at those two unit test failures, but sadly my skills in this area are light. | 15:40 |
| johnsom | We have people for reviews, etc. but not many with node/angular experience in the current Octavia community. | 15:41 |
| amotoki | Syntax error has gone, so perhaps it was due to phantomjs. failures we still have seem to related to AngularJS 1.8.2. | 15:42 |
| vishalmanchanda | johnsom: thanks. | 15:43 |
| vishalmanchanda | I will take a another look at failed test after the meeting. | 15:43 |
| johnsom | Thank you for your help! | 15:43 |
| vishalmanchanda | e0ne_: tmazur : you guys also take a look, maybe you find something! | 15:44 |
| tmazur | vishalmanchanda: sure | 15:44 |
| vishalmanchanda | error logs https://zuul.opendev.org/t/openstack/build/4c96982091bc45a89d774d3caa3c66eb/log/job-output.txt#3285 | 15:44 |
| vishalmanchanda | tmazur: thanks. | 15:44 |
| vishalmanchanda | ok do we have anything else to discuss about this topic? | 15:45 |
| amotoki | https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029825.html | 15:45 |
| amotoki | perhaps we also need to tackle jquery | 15:46 |
| vishalmanchanda | yeah, that's in my TODO list, once we done with this angular migration. | 15:47 |
| amotoki | I might post a wrong URL. this is another one https://lists.openstack.org/pipermail/openstack-discuss/2022-August/029796.html which I would like to share initially. | 15:47 |
| amotoki | the first link (029825) is about a generic issue around xstatic and the latter is specific to jquery | 15:49 |
| vishalmanchanda | amotoki: ack, I'll push a WIP in gate which migrate jquery-migrate version to 3.3.2.1 in horizon and then we can investigate what need to be fixed. | 15:54 |
| vishalmanchanda | moving to next topic | 15:57 |
| vishalmanchanda | #topic open-discussion | 15:57 |
| alistarle | Hi, I just revived a bug about panel dispaly when l3-extension is not enabled: https://bugs.launchpad.net/horizon/+bug/1389489 | 15:58 |
| vishalmanchanda | Does anyone wants to any other topic? | 15:58 |
| alistarle | I was struggling with unit test a lot, but I think I finally found somewhere to mock the allowed() method easily, like we do for the volume_group and vg_snapshot panels, just tell me if you agree with the approach :) | 15:59 |
| amotoki | alistarle: thanks for the fix. I agree with the direction as I commented in the bug long ago, but I am not a fan to mocking is_extension_list() globally. | 15:59 |
| amotoki | alistarle: I will look into the patch. | 15:59 |
| alistarle | yeah thats what I changed | 16:00 |
| alistarle | I mock the allowed() method instead in my local env, and it seams to work far better | 16:00 |
| vishalmanchanda | alistarle: thanks for fix, will take a look asap. | 16:00 |
| alistarle | I will update this in a few minutes | 16:00 |
| alistarle | great, thanks :D | 16:00 |
| amotoki | alistarle: I don't suggest to mock allowed() completely.... it does not test the logic proposed... I will explore an approach too | 16:01 |
| alistarle | can't be mock allowed() by default, and override it for tests specific to this part of the code ? | 16:03 |
| alistarle | issue is is_extension_list heavily used, mocked, with a lot of assert, so it manually require to fix about 200 tests | 16:03 |
| amotoki | alistarle: yes, I think it is better. | 16:03 |
| alistarle | cool, I just need to find if TEST_GLOBAL_MOCKS_ON_PANELS is overridable for a single test | 16:04 |
| vishalmanchanda | amotoki: I need your help in fixing gate for openstack/ui-cookiecutter. | 16:04 |
| vishalmanchanda | amotoki: I tried to fix it locally, but not succeded. | 16:04 |
| amotoki | vishalmanchanda: are we still interested in maintaining ui-cookiecutter? | 16:04 |
| vishalmanchanda | https://review.opendev.org/c/openstack/ui-cookiecutter/+/839978 | 16:05 |
| vishalmanchanda | amotoki: we can make that job as non-voting🙂) | 16:06 |
| opendevreview | Victor Coutellier proposed openstack/horizon master: Adapt panel display based on enabled extensions https://review.opendev.org/c/openstack/horizon/+/851914 | 16:06 |
| e0ne_ | need to drop. see you | 16:07 |
| vishalmanchanda | e0ne_: thanks for joining, see you. | 16:07 |
| amotoki | who needs ui-cookiecutter? if needed it is worth maintaining it but if not it just wastes our time. | 16:08 |
| amotoki | this is the only job in ui-cookiecutter, so making it non-voting is meaningless. | 16:09 |
| amotoki | non voting job means it is not tested unfrotunately..... | 16:09 |
| amotoki | s/non voting/no voting/ | 16:09 |
| vishalmanchanda | amotoki: make sense. | 16:11 |
| amotoki | looking at the failure log, I see "Syntax error" in karma-local tox env. perhaps it is due to the same reason as we see in octavita-dashboard with phantomjs. | 16:11 |
| vishalmanchanda | amotoki: hmm. | 16:12 |
| vishalmanchanda | amotoki: It fails for me with different error in local-env. | 16:12 |
| vishalmanchanda | ok let's end this meeting. | 16:12 |
| vishalmanchanda | Thanks everyone for joining, See you next week! | 16:13 |
| amotoki | o/ | 16:13 |
| alistarle | \o | 16:13 |
| vishalmanchanda | #endmeeting | 16:13 |
| opendevmeet | Meeting ended Wed Aug 3 16:13:26 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:13 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-08-03-15.00.html | 16:13 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-08-03-15.00.txt | 16:13 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-08-03-15.00.log.html | 16:13 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon master: Integration test navigation machinery for Angular pages https://review.opendev.org/c/openstack/horizon/+/819725 | 17:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!