| elodilles | vishalmanchanda: hi, sorry, one release related question: we see xstatic-angular-fileupload as a new thing in governance repo. do you want to release from it in 2023.2 bobcat series? | 12:45 |
|---|---|---|
| elodilles | vishalmanchanda: if yes, then a yaml file needs to be added under deliverables/bobcat in releases repository | 12:45 |
| elodilles | vishalmanchanda: the deadline is Bobcat-2 milestone until all the deliverables have to be added to the releases repo, and that milestone is in this week o:) | 12:47 |
| vishalmanchanda | elodilles: hello, I will check what we do in other xstatic pypi , willfollow the same for xstatic-angular-fileupload pypi. | 12:47 |
| vishalmanchanda | elodilles: In case of pypi horizon is using, we only create a new release when we update it to next version or higher version otherwise we don't release it. | 12:49 |
| elodilles | vishalmanchanda: oh, yes i see that all of the *xstatic* deliverables are under deliverables/_independent/ in release repo | 12:51 |
| elodilles | vishalmanchanda: that means probably the bobcat deadline is not that strict, but i think that it is still worth a release soon, so that we see that releasing from the repo works and also it can be tested with Bobcat deliverables i guess | 12:53 |
| elodilles | vishalmanchanda: if i'm not mistaken nothing else is needed for a release, just a new yaml file has to be created with the proper details and release tools will handle the release to pypi (i.e. nothing needs to be done on pypi, if i remember correctly) | 12:55 |
| vishalmanchanda | elodilles: yes, right a new yaml files needs to be created. | 12:56 |
| elodilles | ++ | 12:56 |
| vishalmanchanda | I think i have to do the same thing for xstatic-angular-fileupload which was done here for other xstatic packages https://review.opendev.org/c/openstack/releases/+/718593 | 12:59 |
| elodilles | vishalmanchanda: yepp, that will do | 13:03 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test chromedriver with integartion job https://review.opendev.org/c/openstack/horizon/+/886867 | 14:25 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Jul 5 15:00:13 2023 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| tmazur | o/ | 15:00 |
| vishalmanchanda | hello everyone | 15:00 |
| rdopiera | o/ | 15:01 |
| vishalmanchanda | let's start the meeting | 15:02 |
| vishalmanchanda | agenda of meeting can be find here https://etherpad.opendev.org/p/horizon-release-priorities#L32 | 15:02 |
| vishalmanchanda | #topic Notices | 15:03 |
| vishalmanchanda | I am not having any announcements for this week. | 15:03 |
| vishalmanchanda | Just a casual reminder about schedule. | 15:03 |
| vishalmanchanda | This week is R-13 week. Bobcat-2 milestone | 15:04 |
| vishalmanchanda | moving to the next topic | 15:04 |
| vishalmanchanda | #topic Release priorities | 15:04 |
| vishalmanchanda | Any updates on integration job failure. | 15:05 |
| rdopiera | I have some good news | 15:05 |
| vishalmanchanda | I can see 3 tests are failing now in https://review.opendev.org/c/openstack/horizon/+/886867 | 15:05 |
| rdopiera | we have found the reason for the javascript errors | 15:05 |
| vishalmanchanda | ohh nice🙂) | 15:06 |
| rdopiera | it's this patch https://review.opendev.org/c/openstack/requirements/+/883402 | 15:06 |
| rdopiera | the problem is that jquery-migrate 3.x requires jquery 3.x or newer to work | 15:06 |
| vishalmanchanda | ok | 15:06 |
| rdopiera | but only jquery-migrate was updated, jquery is still at 1.2 | 15:06 |
| vishalmanchanda | ohh I missed that | 15:06 |
| rdopiera | the solution is either to rollback that rollback of a rollback again, or to upgrade jquery to 3.x | 15:07 |
| vishalmanchanda | beacuse in my local env. the series of patch I purposed I updated jQuery version to 3.x | 15:07 |
| rdopiera | I tried to do that yesterday with some patches, but I hit a dependency cycle between the global requirements and horizon's requirements.txt | 15:08 |
| vishalmanchanda | rdopiera: ok that I will update | 15:08 |
| rdopiera | basically the patch to global requirements fails, becase horizon requires jquery < 2 | 15:08 |
| vishalmanchanda | but are you sure that will fix the issue, I mean upgrading jQuery version to 3.x? | 15:08 |
| rdopiera | and the patch to horizon fails, becase global requirements has the version pinned | 15:09 |
| rdopiera | it will fix the issue with the menu not working on a click | 15:09 |
| vishalmanchanda | ok | 15:09 |
| rdopiera | there might be further issues that we didn't see yet | 15:09 |
| vishalmanchanda | yeah | 15:09 |
| rdopiera | but I guess we will handle them as they come | 15:09 |
| vishalmanchanda | ok, one question here any specific reason you updated to XStatic-jQuery===2.2.4.1 | 15:11 |
| vishalmanchanda | not 3.3.2.1 | 15:11 |
| vishalmanchanda | ? | 15:11 |
| vishalmanchanda | This patch https://review.opendev.org/c/openstack/requirements/+/887607/1/upper-constraints.txt#80 I am talking about | 15:11 |
| vishalmanchanda | rdopiera: ^^ | 15:14 |
| rdopiera | vishalmanchanda: I wanted to upgrade it as little as possible, which in hindsight was a mistake | 15:19 |
| rdopiera | vishalmanchanda: we should upgrade to the latest available, probably also upgrade the xstatic | 15:19 |
| vishalmanchanda | ok | 15:19 |
| vishalmanchanda | I will purpose a patch to update Xstatic-Jquery version to 3.3.2.1 in openstack/requirements | 15:22 |
| vishalmanchanda | after that let's see what more issue we get. | 15:26 |
| vishalmanchanda | your patch is failing due to version dependency issues | 15:29 |
| vishalmanchanda | we have to do that step by step | 15:29 |
| vishalmanchanda | like first we need to raise the version in ``gloabl-requirements.txt`` | 15:30 |
| vishalmanchanda | then we can bump jQuery version in upper-constraints.txt`` file. | 15:31 |
| rdopiera | I see, thank you | 15:32 |
| vishalmanchanda | I just purposed a patch for that in openstack/requirements https://review.opendev.org/c/openstack/requirements/+/887720 | 15:33 |
| vishalmanchanda | let see if CI is pass for that. | 15:34 |
| vishalmanchanda | if this pass https://review.opendev.org/c/openstack/requirements/+/887720 | 15:37 |
| vishalmanchanda | then we will update jQuery version in horizon ``requirements.txt`` | 15:39 |
| vishalmanchanda | then in ``upper.constraints.txt`` | 15:39 |
| vishalmanchanda | we done the same when we bump django version in the past. | 15:40 |
| vishalmanchanda | https://review.opendev.org/c/openstack/requirements/+/813405 | 15:40 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/815393 | 15:41 |
| vishalmanchanda | https://review.opendev.org/c/openstack/requirements/+/815096 | 15:41 |
| vishalmanchanda | Let see | 15:42 |
| vishalmanchanda | I have one more update | 15:42 |
| vishalmanchanda | I missed to add "xstatic-angular-fileupload pypi" under Openstack release process. | 15:44 |
| vishalmanchanda | I got know it today from release team. | 15:45 |
| vishalmanchanda | I will push the patch to fix it asap. | 15:45 |
| vishalmanchanda | I have no other topic to discuss for today. | 15:45 |
| vishalmanchanda | #topic open-discussion | 15:45 |
| vishalmanchanda | Do we have any other topic to discuss? | 15:46 |
| vishalmanchanda | If no other topic to discuss, let's end this meeting | 15:49 |
| vishalmanchanda | thanks everyone for joining. | 15:49 |
| vishalmanchanda | #endmeeting | 15:49 |
| opendevmeet | Meeting ended Wed Jul 5 15:49:48 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:49 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-07-05-15.00.html | 15:49 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-07-05-15.00.txt | 15:49 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2023/horizon.2023-07-05-15.00.log.html | 15:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!