| greghaynes | SpamapS: Is the thinking that drop database is inherently not a performant thing? | 00:00 |
|---|---|---|
| SpamapS | it's precisely how the mysql test suite itself does things. | 00:00 |
| clarkb | greghaynes: the two considerations are 1) py26 cannot do setup/teardown class | 00:00 |
| SpamapS | greghaynes: It is inherently serialized. | 00:00 |
| clarkb | greghaynes: and 2) you would run it per process | 00:00 |
| SpamapS | and waits for files to be unlinked fully.. | 00:00 |
| clarkb | SpamapS: we don't run mysql directly | 00:00 |
| clarkb | SpamapS: so we can do things that way but would require completely chaning how we test | 00:01 |
| SpamapS | clarkb: yeah, it was just a thought. So without that, yeah, you need to be dropping. | 00:01 |
| SpamapS | is there any reason any of the tables gets big? | 00:01 |
| clarkb | and then changing every openstack project to match | 00:01 |
| SpamapS | they should be tiny | 00:01 |
| clarkb | they should be tiny | 00:01 |
| SpamapS | so then I don't see much reason for it to take a long time. | 00:01 |
| clarkb | greghaynes: also if you do it that way you have to drop all the tables between tests anyways | 00:02 |
| clarkb | greghaynes: not sure that really fixes the problem | 00:02 |
| greghaynes | clarkb: py26 shouldnt be an issue - I am not sure why youd need to do that | 00:02 |
| clarkb | greghaynes: otherwise you lose test case isolation which will be even more fun to work around | 00:02 |
| clarkb | greghaynes: we don't need it anymore but needed it until decemberish | 00:02 |
| greghaynes | clarkb: oh, right | 00:03 |
| clarkb | greghaynes: its just a reason why things are the way thing sare | 00:03 |
| SpamapS | dropping all the tables is the same as dropping the db | 00:03 |
| greghaynes | clarkb: actually, I am thinking in class set up pick a random db prefix. in test setup create db under that prefix, dont delete in test cleanup, in class cleanup delete all databases starting with that prefix | 00:03 |
| clarkb | ok then those are equivalent | 00:03 |
| *** Kennan_Vacation is now known as Kennan | 00:03 | |
| SpamapS | though at least you'd have n statements to timeout instead of one. ;) | 00:03 |
| greghaynes | clarkb: its not a huge win but it would group deletes | 00:03 |
| clarkb | greghaynes: which would also be subject to the timeout I think | 00:04 |
| greghaynes | clarkb: it would | 00:04 |
| greghaynes | clarkb: so it may not help | 00:04 |
| *** dims has quit IRC | 00:04 | |
| *** piet has quit IRC | 00:05 | |
| SpamapS | The one thing I'd say is if you go ahead and drop all the tables one by one, at least you have more granularity on what is causing the problem if there is in fact a problem beyond "that is slow" | 00:05 |
| greghaynes | SpamapS: ++ | 00:05 |
| SpamapS | and it's possible it fixes the problem because each table drop has its own timeout | 00:05 |
| clarkb | is mysql already logging that? I wonder if we can just grab the mysql log for that granularity | 00:05 |
| clarkb | SpamapS: no its the timeout in python not mysql | 00:05 |
| SpamapS | not be default | 00:05 |
| SpamapS | not by default rather | 00:06 |
| SpamapS | but you can turn on logging | 00:06 |
| SpamapS | you can even have it log to a table | 00:06 |
| SpamapS | http://dev.mysql.com/doc/refman/5.5/en/log-destinations.html | 00:07 |
| SpamapS | That would actually be _super_ useful in debugging anything SQL related | 00:07 |
| clarkb | we had it enabled but then we wrote 1GB log files or something | 00:08 |
| clarkb | on devstack runs | 00:08 |
| SpamapS | yeah no surprise there | 00:09 |
| clarkb | ok all jenkinses should be updated | 00:09 |
| SpamapS | still, that's not a useless 1GB and probably xz's down to a at most 100MB ;) | 00:09 |
| SpamapS | since it is likely to be a _lot_ of the same thing over and over. | 00:09 |
| *** sflanigan has joined #openstack-infra | 00:10 | |
| *** sflanigan has joined #openstack-infra | 00:10 | |
| *** dims has joined #openstack-infra | 00:11 | |
| clarkb | SpamapS: ya now run it 25k times per day :) | 00:11 |
| openstackgerrit | Colleen Murphy proposed openstack-infra/puppet-infracloud: Use SSL for rabbitmq traffic https://review.openstack.org/276375 | 00:11 |
| openstackgerrit | Colleen Murphy proposed openstack-infra/puppet-infracloud: Setup rabbit user/pass for keystone https://review.openstack.org/278482 | 00:11 |
| *** thorst has joined #openstack-infra | 00:11 | |
| clarkb | but ya having a single periodic job that collected that info would likely be beneficial and not hurt the log disks too much | 00:11 |
| *** gildub has joined #openstack-infra | 00:12 | |
| openstackgerrit | Merged openstack-infra/nodepool: Dont connect to gearman in cmd unless needed https://review.openstack.org/279829 | 00:13 |
| *** thorst_ has joined #openstack-infra | 00:14 | |
| openstackgerrit | Colleen Murphy proposed openstack-infra/puppet-infracloud: Use SSL for rabbitmq traffic https://review.openstack.org/276375 | 00:15 |
| *** thorst has quit IRC | 00:17 | |
| clarkb | nibalizer: mordred our time between puppet runs is pretty long now, upwards of an hour. Maybe we should increase the number of concurrent puppet applies? | 00:28 |
| *** pradk has quit IRC | 00:30 | |
| nibalizer | maybe | 00:30 |
| nibalizer | we've added what 40 new hosts w/ infracloud? | 00:31 |
| nibalizer | and it runs those as a separate step | 00:31 |
| nibalizer | so its all git servers, all afs servers, all infracloud, everyone else | 00:31 |
| clarkb | ya | 00:31 |
| clarkb | and infracloud seems to update a lot rather than nop | 00:31 |
| clarkb | also there are failures that we need to track down and puppetboard doesn't learn about them | 00:32 |
| nibalizer | yep | 00:32 |
| nibalizer | the whole system needs attention and feeding to get it to a place thats better | 00:32 |
| nibalizer | are the errors just nodes that do not exist? | 00:32 |
| clarkb | some of them are but others are real fails on real nodes I think | 00:32 |
| clarkb | I am only just now sort of looking | 00:32 |
| nibalizer | https://review.openstack.org/#/c/278769/ | 00:33 |
| Sam-I-Am | moo. | 00:33 |
| nibalizer | also https://review.openstack.org/#/c/278841/ is a no brainer | 00:33 |
| clarkb | nibalizer: done, though that doens't explain why puppetboard doesn't learn about failures | 00:34 |
| nibalizer | well depending on what you're seeing | 00:34 |
| nibalizer | you may actually be seeing the puppetboard post is the only failure | 00:34 |
| clarkb | nibalizer: puppet ran into exec timeout on jenkins* an dreutrned 6 | 00:35 |
| *** markvoelker has joined #openstack-infra | 00:35 | |
| clarkb | nibalizer: that puppet run was not recordred in puppetboard | 00:35 |
| *** rajinir has quit IRC | 00:35 | |
| nibalizer | yea | 00:35 |
| nibalizer | im not sure whats going on there | 00:35 |
| nibalizer | none of the infracloud hosts appear in puppetboard | 00:35 |
| clarkb | http://puppetboard.openstack.org/node/jenkins02.openstack.org there is a gap between 10:23 and 1:23 pt where things actually failed | 00:35 |
| fungi | after combing all 950 repos in gerrit, there were only 16 others with malformed groups files | 00:36 |
| clarkb | nibalizer: looks like the old pypi mirror hosts fail in ansible because they were deleted | 00:36 |
| clarkb | nibalizer: I think that is due to caching | 00:37 |
| *** shashank_hegde has quit IRC | 00:37 | |
| clarkb | fungi: ^ you ran into caching before right? what is the process there ? wait longer or ? | 00:37 |
| nibalizer | ok | 00:37 |
| nibalizer | we also have all those uuid-hosts still | 00:37 |
| nibalizer | despite them not being real or useful | 00:37 |
| *** salv-orl_ has quit IRC | 00:38 | |
| fungi | clarkb: i thought the daily cache update was supposed to clear them out | 00:38 |
| clarkb | fungi: it doesn't appear to be working | 00:38 |
| clarkb | I don't even know what the daily cache update is | 00:38 |
| clarkb | so thats the extent of my knowledge | 00:38 |
| fungi | nibalizer: most of the uuids mentioned there are actually servers in dfw but for some reason half the time our ansible inventory on the puppetmaster is ending up with all hosts in dfw identified by instance uuid instead of instance name | 00:38 |
| nibalizer | yes | 00:39 |
| fungi | clarkb: supposedly it's that when we call ansible it's calling into shade for the openstack role, and shade caches its inventory (refreshing it by default only if it's >24 hours old) | 00:39 |
| *** markvoelker has quit IRC | 00:39 | |
| clarkb | nibalizer: oh! I see the problem Ithink we doubletap the compute hosts | 00:39 |
| clarkb | nibalizer: :) | 00:39 |
| nibalizer | clarkb: https://review.openstack.org/#/c/278855/ | 00:40 |
| clarkb | nibalizer: it is definitely intermixing compute hosts and everything else | 00:40 |
| nibalizer | credit goes to crinkle for figuring that one out first | 00:40 |
| *** gildub has quit IRC | 00:40 | |
| clarkb | ok that will likely fix things a bunch | 00:40 |
| fungi | clarkb: er, no wait, it's the ansible dynamic inventory script, sorry | 00:40 |
| openstackgerrit | Merged openstack-infra/system-config: Disable nonfunctional infracloud hosts https://review.openstack.org/278769 | 00:41 |
| *** denisra has quit IRC | 00:41 | |
| fungi | clarkb: the /etc/ansible/hosts/openstack script on the puppetmaster uses shade | 00:41 |
| *** denisra has joined #openstack-infra | 00:41 | |
| clarkb | gotcha and shade is supposed to expire those things on a 24 hour timeout? | 00:42 |
| fungi | and that's how the cache is getting populated | 00:42 |
| clarkb | it definitely isn't if that is the case, pypi.*.openstack.org are all failing | 00:42 |
| clarkb | due to connection errors | 00:42 |
| fungi | yeah, unless configured otherwise default is supposedly 24 hours | 00:42 |
| clarkb | I am going to restart nodepool now | 00:42 |
| openstackgerrit | Merged openstack-infra/system-config: Delete json reports when we delete yaml reports https://review.openstack.org/278841 | 00:42 |
| fungi | clarkb: anyway, mordred would probably appreciate knowing that the inventory doesn't seem to be removing hosts deleted from nova | 00:42 |
| fungi | possible my understanding is incorrect and there's something else we're supposed to be doing instead | 00:43 |
| clarkb | nodepoold and builder have been restarted | 00:43 |
| clarkb | fungi: it would not surprise me if shade caching is busted | 00:44 |
| clarkb | that code is complicated | 00:44 |
| fungi | well, also the inventory script has some of its own logic around caches from the looks of it | 00:44 |
| clarkb | openstackid.org is one of the failing hosts | 00:45 |
| clarkb | ConnectFailure: Unable to establish connection to http://localhost:5000/v2.0/tokens | 00:45 |
| clarkb | uh | 00:45 |
| clarkb | 2016-02-16 00:45:30,363 ERROR nodepool.NodeLauncher: ConnectFailure launching node id: 7975788 in provider: tripleo-test-cloud-rh1 error | 00:45 |
| fungi | i approved a change earlier today to upgrade openstackid on production openstackid.org to the same release that's been running on openstackid-dev.o.o for a while | 00:45 |
| clarkb | not sure yet if that is the cloud saying it can't connectto localohost or if nodepool can't connect to localhost | 00:46 |
| clarkb | seems like nodepool :( | 00:46 |
| clarkb | that'll leran me to restart services at the end of the day | 00:46 |
| mordred | fungi, clarkb: when did you delete the hosts? | 00:47 |
| mordred | and when you did, did you delete the inventory cache? | 00:47 |
| clarkb | mordred: last week | 00:47 |
| mordred | ah | 00:47 |
| mordred | then they should not be in the inventory anymore | 00:47 |
| clarkb | mordred: als see above I think oscc/shade may be broken | 00:47 |
| fungi | clarkb: also, did not delete the inventory cache. was thinking it was supposed to update itself at least daily anyway? | 00:47 |
| openstackgerrit | Spencer Krum proposed openstack-infra/ansible-puppet: Don't post data from uuid hosts https://review.openstack.org/280457 | 00:47 |
| fungi | mordred: ^ | 00:47 |
| clarkb | fungi: yes that is what I would expect | 00:47 |
| nibalizer | clarkb: ^^ that would likely fix it | 00:47 |
| nibalizer | even if not the right way | 00:48 |
| mordred | yes. it should update daily | 00:48 |
| nibalizer | also that will fail lint based on line lenght | 00:48 |
| nibalizer | so i'd love some info on how to split that line up to be not so long | 00:48 |
| fungi | nibalizer: well, that keeps us from dirtying the puppetdb data, but of course doesn't solve the ineventory ending up all uuids in dfw sometimes | 00:48 |
| *** nibz has joined #openstack-infra | 00:49 | |
| clarkb | auth_url is set in our clouds.yaml | 00:49 |
| clarkb | and it isn't localhost:5000 | 00:49 |
| *** nibalizer is now known as nibz_irssi | 00:49 | |
| clarkb | bluebox also sets it and I haven't seen any bluebox errors | 00:49 |
| *** nibz is now known as nibalizer | 00:49 | |
| fungi | mordred: nibalizer: i still have a feeling it's something nova list for rax-dfw is doing weird sometimes to cause us to not end up with instance names | 00:49 |
| nibalizer | fungi:yep | 00:50 |
| fungi | though i have no proof--haven't caught it red handed | 00:50 |
| nibalizer | but that is one example of making it a little bit better | 00:50 |
| fungi | sure, i don't object | 00:50 |
| openstackgerrit | Merged openstack-infra/system-config: Don't run infracloud puppet twice https://review.openstack.org/278855 | 00:51 |
| clarkb | localhost:5000 don't show up in shade or oscc or nodepool | 00:52 |
| *** nibz_irssi has quit IRC | 00:53 | |
| clarkb | can reproduce with openstack --os-cloud tripleo-test-cloud-rh1 catalog list | 00:53 |
| clarkb | so it isn't a nodepool bug | 00:54 |
| clarkb | mordred: ^ any ideas? | 00:54 |
| mordred | clarkb: it's 1am here - can you tl;dr me - I can't process the whole scrollback | 00:55 |
| clarkb | mordred: `openstack --os-cloud tripleo-test-cloud-rh1 catalog list` says Unable to establish connection to http://localhost:5000/v2.0/tokens | 00:55 |
| greghaynes | clarkb: did tripleo-test-cloud-rh1 show up somewhere in logs? | 00:55 |
| clarkb | mordred: nodepool is also failing on that | 00:56 |
| *** yamamoto has joined #openstack-infra | 00:56 | |
| greghaynes | Wondering why you think that is the cloud causing the error | 00:56 |
| clarkb | greghaynes: yes it is only hosts in that cloud failing | 00:56 |
| greghaynes | Ok | 00:56 |
| *** gildub has joined #openstack-infra | 00:56 | |
| mordred | clarkb: from puppetmaster as root? | 00:57 |
| greghaynes | Its probably not too important to fix immediately, then - I doubt they will care too much if they miss one day of images | 00:57 |
| clarkb | mordred: on nodepool.o.o as nodepool | 00:57 |
| clarkb | greghaynes: its all things so no testing can happen | 00:57 |
| greghaynes | oh :( | 00:57 |
| clarkb | on tripleo cloud | 00:57 |
| greghaynes | Yea, I forgot that we boot up the worker nodes there | 00:58 |
| openstackgerrit | Thanh Ha proposed openstack-infra/zuul: Add quick-start guide https://review.openstack.org/271872 | 00:58 |
| mordred | auth_url: 'https://ci-overcloud.rh1.tripleo.org:13000/v2.0' | 00:58 |
| clarkb | mordred: yup | 00:58 |
| clarkb | it is almost like that is a keystone auth default | 00:58 |
| *** rfolco has quit IRC | 00:58 | |
| clarkb | since oscc and shade don't have localhost in their repos | 00:58 |
| clarkb | mordred: bluebox appears to work which similarly sets the auth_url | 00:59 |
| *** thorst_ has quit IRC | 00:59 | |
| mordred | clarkb: REQ: curl -g -i -X GET https://ci-overcloud.rh1.tripleo.org:13000/v2.0 -H "Accept: application/json" -H "User-Agent: python-openstackclient keystoneauth1/2.2.0 python-requests/2.9.1 CPython/2.7.6" | 01:00 |
| mordred | clarkb: is the first thing openstack is doing there | 01:00 |
| fungi | codesearch turns up waaaay too many false-positives due to that being used in install and api docs, keystone tests, documentation and sample configs, examples in python-openstackclient documentation and tests... | 01:00 |
| *** thorst has joined #openstack-infra | 01:00 | |
| mordred | that's returning this: | 01:00 |
| greghaynes | mordred: that points to localhost | 01:00 |
| mordred | RESP BODY: {"version": {"status": "deprecated", "updated": "2014-04-17T00:00:00Z", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.identity-v2.0+json"}, {"base": "application/xml", "type": "application/vnd.openstack.identity-v2.0+xml"}], "id": "v2.0", "links": [{"href": "http://localhost:5000/v2.0/", "rel": "self"}, {"href": | 01:00 |
| mordred | "http://docs.openstack.org/api/openstack-identity-service/2.0/content/", "type": "text/html", "rel": "describedby"}, {"href": "http://docs.openstack.org/api/openstack-identity-service/2.0/identity-dev-guide-2.0.pdf", "type": "application/pdf", "rel": "describedby"}]}} | 01:00 |
| greghaynes | jinx | 01:00 |
| mordred | yah | 01:00 |
| fungi | oh, ouch | 01:00 |
| mordred | so tripleo test cloud is broken | 01:00 |
| clarkb | wow | 01:00 |
| fungi | so very, very broken | 01:00 |
| clarkb | that error message is really confusing in this context | 01:01 |
| *** ZZelle_ has quit IRC | 01:01 | |
| fungi | so busted keystone v2 entry in the catalog i guess? | 01:01 |
| greghaynes | Yep | 01:01 |
| clarkb | which somehow overrides the auth url | 01:01 |
| clarkb | that is a weird chicke nand eg | 01:02 |
| fungi | thank you mario, but our princess is in another castle? | 01:02 |
| clarkb | no gearman connections to get listings \o/ | 01:02 |
| *** yamamoto has quit IRC | 01:03 | |
| *** [1]Thelo has joined #openstack-infra | 01:03 | |
| mordred | the auth url triggers version discover | 01:04 |
| mordred | the auth url triggers version discovery | 01:04 |
| clarkb | has someone joined #tripleo to let them know? | 01:04 |
| clarkb | I can do that if not | 01:04 |
| *** dims has quit IRC | 01:04 | |
| mordred | the version discovery gets the list of urls that keystone is serving | 01:04 |
| openstackgerrit | Thanh Ha proposed openstack-infra/zuul: Add quick-start guide https://review.openstack.org/271872 | 01:04 |
| clarkb | mordred: that makes sense excet that I already have to know the version and location of keystone :/ | 01:04 |
| mordred | yes | 01:04 |
| mordred | I'm not disagreeing with you | 01:04 |
| clarkb | so it is a weird chickenand egg where I must know the info ahead of time but we allow it to override and break me even if I know | 01:05 |
| mordred | give me a sec -I'm poking at workarounds | 01:05 |
| clarkb | I can see both sides of an argument for why you would want this, but based on this issue I lean towards using the info as laready supplied bceause it is required info | 01:05 |
| mordred | modern keystoneclient expects unversioned auth urls | 01:05 |
| greghaynes | clarkb: mordred I poked slagle in -tripleo | 01:05 |
| mordred | I'm going to see if I can tell it to not do discovery though | 01:05 |
| clarkb | other than that we look good on nodepool | 01:06 |
| *** Thelo has quit IRC | 01:06 | |
| *** [1]Thelo is now known as Thelo | 01:06 | |
| *** mtanino has quit IRC | 01:06 | |
| mordred | jamielennox: ^^ got a sec to look at scrollback? | 01:06 |
| clarkb | and I will leave ansible inventory caching for another day | 01:06 |
| mordred | jamielennox: the tripleo test cloud has a broken setting for keystone version discovery | 01:06 |
| mordred | jamielennox: but we know the version | 01:07 |
| jamielennox | how far back? | 01:07 |
| clarkb | mordred: the other thing is failed puppet runs don't get puppetboarded | 01:07 |
| mordred | jamielennox: one or two screens | 01:07 |
| mordred | clarkb: k. we should fix that - I can work on it when it's not 1am where I am :) | 01:07 |
| clarkb | mordred: yup I don't expect you to work on it now | 01:07 |
| clarkb | mordred: just wanted to make you aware | 01:07 |
| clarkb | I also merged some cleanup changes for ansibling that crinkle and nibalizer pushed which should make debugging the remaining things easier tomorrow | 01:08 |
| clarkb | (less overall noise) | 01:08 |
| mordred | clarkb: cool | 01:08 |
| nibalizer | so should we disable the tripleo cloud? | 01:08 |
| jamielennox | so the GET / on some cloud is reporting localhost as the URL? | 01:08 |
| *** dims has joined #openstack-infra | 01:08 | |
| mordred | jamielennox: tl;dr - how do we get python-openstackclient to _not_ do version discovery for keystone | 01:08 |
| clarkb | jamielennox: yes | 01:08 |
| *** thorst has quit IRC | 01:08 | |
| mordred | jamielennox: GET https://ci-overcloud.rh1.tripleo.org:13000/v2.0 | 01:08 |
| jamielennox | osc had a fix for this i think but we didn't backport it because essentially the cloud is misconfigured | 01:09 |
| mordred | kk | 01:09 |
| jamielennox | instead of auth_type=password and the unveresioned url do auth_type=v2password and the /v2.0 url | 01:09 |
| mordred | so best bet is just get slagle to update the config there | 01:09 |
| jamielennox | that will skip version discovery | 01:09 |
| clarkb | except v2password is broken for other reasons | 01:09 |
| * clarkb gets a drink | 01:09 | |
| jamielennox | or /v3 if possible | 01:09 |
| jamielennox | clarkb: v2password is broken? | 01:09 |
| greghaynes | clarkb: this aged cachaca is pretty good | 01:10 |
| clarkb | jamielennox: the interface to that class is different than the interface to the generic password class | 01:10 |
| mordred | jamielennox: openstack --debug --os-auth-type=v2password --os-cloud=tripleo-test-cloud-rh1 server list | 01:10 |
| mordred | is what I'm doing | 01:10 |
| mordred | clarkb: it's ok - that's all fixed now | 01:10 |
| mordred | clarkb: specifying v2passwd is possible these days | 01:10 |
| clarkb | ok | 01:10 |
| *** bkero has joined #openstack-infra | 01:10 | |
| mordred | jamielennox: that command above still does discovery | 01:10 |
| jamielennox | clarkb: it is different becase the params to v2 and v3 auth are different | 01:10 |
| mordred | clarkb: oscc munges your parameters properly if you request v2password | 01:10 |
| clarkb | ok | 01:11 |
| jamielennox | mordred: oh, maybe it does for the CRUD stuff | 01:11 |
| jamielennox | you can use bypass-url or whatever for that bit | 01:11 |
| jamielennox | but i wouldn't think the server list part would do that | 01:12 |
| openstackgerrit | Thanh Ha proposed openstack-infra/zuul: Add additional zuul.conf information https://review.openstack.org/271868 | 01:12 |
| clarkb | anyways once the cloud is fixed nodepool should just start working with it again | 01:13 |
| *** achanda has quit IRC | 01:13 | |
| clarkb | so I don't hink we need to do anything special with them | 01:13 |
| mordred | ++ | 01:13 |
| clarkb | and if it isn't fixed in a few days we can remove that cloud | 01:14 |
| clarkb | and figure out what we do from there | 01:14 |
| fungi | yeah, seems unnecessary to jump through hoops so as to work around an obvious misconfiguration | 01:14 |
| nibalizer | clarkb: cool | 01:14 |
| greghaynes | clarkb: Why did this only show up after a nodepool restart? | 01:14 |
| greghaynes | clarkb: Is that the only time we do the endpoint discovery? | 01:14 |
| openstackgerrit | Tony Breeds proposed openstack-infra/project-config: Enable trove in devstack on stable/kilo https://review.openstack.org/280461 | 01:14 |
| clarkb | greghaynes: because you only do this listing when you start | 01:14 |
| fungi | i'm guessing some nodepool dependency updated since the prior restart | 01:14 |
| clarkb | greghaynes: you don't ask for the catalog each time | 01:14 |
| greghaynes | clarkb: hrm, I guess on client creation | 01:14 |
| nibalizer | there aren't any non tripleo tests that require nodes in the tripleo cloud right? | 01:15 |
| clarkb | greghaynes: yup | 01:15 |
| fungi | or else they changed their config since the last restart | 01:15 |
| greghaynes | fun | 01:15 |
| clarkb | nibalizer: nothing that should be voting | 01:15 |
| greghaynes | Yea, so probably they redeployed with the catalog changing since out last restart | 01:15 |
| greghaynes | fungi: yep | 01:15 |
| mordred | well - this isn't actually the catalog, fwiw | 01:15 |
| mordred | it's the keysotne config | 01:15 |
| clarkb | whatever it is you only ask for it when creating a new client | 01:16 |
| mordred | the config of what the self-url is | 01:16 |
| fungi | ayup, before even being able to get the catalog | 01:16 |
| nibalizer | looks like the only jobs using the tripleo-f22 nodes are the ironic openstack-releasenotes-jobs | 01:16 |
| fungi | got it | 01:16 |
| nibalizer | which I assume we only need when releasing? | 01:16 |
| clarkb | nibalizer: that doens't sound right, that job should run where the other release notes jobs run | 01:16 |
| mordred | I agree with that | 01:16 |
| nibalizer | i could be interpreting that wrong | 01:16 |
| mordred | jroll, devananda ^^ ? | 01:16 |
| nibalizer | oh i misparsed some yaml | 01:17 |
| nibalizer | its just a job called - '{trigger}-tripleo-ci-{jobname}' | 01:17 |
| nibalizer | and the node is tripleo-f22 | 01:17 |
| mordred | greghaynes, clarkb #public_endpoint = <None> | 01:17 |
| *** achanda has joined #openstack-infra | 01:17 | |
| mordred | that's the setting in keystone.conf ^^ | 01:17 |
| clarkb | mordred: that causes a localhost entry? | 01:17 |
| mordred | jamielennox: do I have that right? | 01:18 |
| jamielennox | mordred, clarkb: how old is this install? for a couple of cycles now if you don't set public_endpoint it will default to the value from the request | 01:18 |
| mordred | jamielennox: might be a bit old | 01:18 |
| clarkb | except it was working last week | 01:18 |
| jamielennox | if it's new to get that discovery entry they'd have to do public_endpoint = http://localhost:5000 | 01:18 |
| greghaynes | jamielennox: Unsure, it really is just when/what tripleo folks deployed | 01:18 |
| mordred | oh ... you know what | 01:18 |
| jamielennox | was working last week? what's changed? | 01:18 |
| mordred | nah. nevermind. I have no cule | 01:19 |
| clarkb | jamielennox: no idea, they run the cloud | 01:19 |
| openstackgerrit | Qiming Teng proposed openstack/requirements: Bump python-senlinclient version to 0.3.0 https://review.openstack.org/263598 | 01:19 |
| clarkb | its fine, they will sort it out I am sure | 01:19 |
| *** nelsnelson has joined #openstack-infra | 01:19 | |
| *** achanda has quit IRC | 01:20 | |
| *** david-lyle has joined #openstack-infra | 01:23 | |
| *** pvaneck has quit IRC | 01:24 | |
| openstackgerrit | Bertrand Roussel proposed openstack-infra/jenkins-job-builder: Description Setter Plugin support as builder https://review.openstack.org/280416 | 01:25 |
| *** tzn has joined #openstack-infra | 01:26 | |
| clarkb | nibalizer: fyi we no longer mix the hosts but now we aren't running against the compute nodes from what I can see | 01:29 |
| clarkb | and controller00 west is failing on some ssl thing | 01:29 |
| *** kzaitsev_mb has quit IRC | 01:29 | |
| nibalizer | clarkb: hrm let me view the log | 01:30 |
| *** rlandy has quit IRC | 01:31 | |
| clarkb | nibalizer: it is actually probably ok to mix them in with everything else as after the compute host | 01:32 |
| clarkb | but a distinct log section may make debug simpler | 01:32 |
| nibalizer | yes | 01:33 |
| nibalizer | I think for speed reasons we'll want to put all the compute hosts in the everything blob | 01:33 |
| *** weshay has quit IRC | 01:34 | |
| *** sam_wan has joined #openstack-infra | 01:34 | |
| *** ddieterly has quit IRC | 01:35 | |
| nibalizer | clarkb: so the controller error is just that it can't post to puppetdb | 01:36 |
| *** ddieterly has joined #openstack-infra | 01:36 | |
| nibalizer | oh you know what | 01:36 |
| *** yonglihe has joined #openstack-infra | 01:36 | |
| nibalizer | is that the controller fails on posting to puppetdb so ansible probably aborts the play | 01:36 |
| nibalizer | because the second step in that playbook is to run the compute hosts | 01:36 |
| clarkb | ah | 01:36 |
| clarkb | that makes sense | 01:36 |
| nibalizer | which is kinda what we want tb | 01:36 |
| nibalizer | tbh | 01:36 |
| *** jaypipes has quit IRC | 01:36 | |
| *** eil397 has quit IRC | 01:39 | |
| *** ddieterly has quit IRC | 01:40 | |
| *** yamamoto has joined #openstack-infra | 01:48 | |
| *** bpokorny has joined #openstack-infra | 01:49 | |
| *** tiswanso has joined #openstack-infra | 01:51 | |
| *** tiswanso has quit IRC | 01:51 | |
| *** tiswanso has joined #openstack-infra | 01:52 | |
| *** edmondsw_ has quit IRC | 01:56 | |
| *** EricGonczer_ has joined #openstack-infra | 02:00 | |
| *** yamamoto has quit IRC | 02:00 | |
| *** tzn has quit IRC | 02:00 | |
| *** zz_dimtruck is now known as dimtruck | 02:00 | |
| *** zhurong has joined #openstack-infra | 02:01 | |
| lifeless | tonyb: ok os | 02:01 |
| * tonyb suspects lifeless is trying to explain complex thoughts in a way I'll understand :D | 02:05 | |
| lifeless | failing at multiplexing :) | 02:06 |
| *** thorst has joined #openstack-infra | 02:07 | |
| tonyb | lifeless: :D | 02:07 |
| lifeless | tonyb: so, I'll poke around doing a release to help you out | 02:07 |
| lifeless | but I think its entirely bogus | 02:07 |
| tonyb | thorst: where is the powervm channel? | 02:07 |
| tonyb | lifeless: firstly thanks. | 02:07 |
| tonyb | lifeless: next, do you want to talk it through? I agree that it's *somewhat* bogus but not entirely wrong. | 02:08 |
| tonyb | lifeless: we can always talk it over at the bugsmash | 02:09 |
| lifeless | doing a change of something just to declare something else has changed because a third thing doesn't handle the interaction well | 02:10 |
| lifeless | tonyb: -> bogus | 02:10 |
| *** MarkAtwood has joined #openstack-infra | 02:11 | |
| *** EricGonczer_ has quit IRC | 02:11 | |
| *** thorst has quit IRC | 02:14 | |
| tonyb | lifeless: ok. I s'pose that's one way to describe it. | 02:17 |
| *** ganso has quit IRC | 02:19 | |
| *** krtaylor has quit IRC | 02:20 | |
| *** zhurong has quit IRC | 02:22 | |
| *** rhallisey has quit IRC | 02:22 | |
| *** zhurong has joined #openstack-infra | 02:22 | |
| *** armax has joined #openstack-infra | 02:26 | |
| *** EricGonczer_ has joined #openstack-infra | 02:27 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder: Don't remove python3 & grubby in 99-remove-extra-packages https://review.openstack.org/249541 | 02:30 |
| *** tphummel has quit IRC | 02:30 | |
| *** krtaylor has joined #openstack-infra | 02:31 | |
| jroll | mordred: ping me tomorrow? not sure if you needed something and only here for a sec | 02:33 |
| clarkb | jroll: this reminds me where is that change you need? | 02:33 |
| clarkb | the one that we held off on earlier? it can go in now | 02:34 |
| jroll | clarkb: oh, sec | 02:34 |
| jroll | clarkb: https://review.openstack.org/#/c/265311/ ty in advance | 02:34 |
| *** markvoelker has joined #openstack-infra | 02:36 | |
| lifeless | tonyb: how would you describe it? | 02:38 |
| *** markvoelker has quit IRC | 02:40 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder: Don't remove python3 & grubby in 99-remove-extra-packages https://review.openstack.org/249541 | 02:40 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder: Update default to F23 https://review.openstack.org/247296 | 02:42 |
| *** shashank_hegde has joined #openstack-infra | 02:42 | |
| openstackgerrit | Merged openstack-infra/project-config: Allow ironic jobs to run with tempest plugin https://review.openstack.org/265311 | 02:44 |
| *** _sarob has quit IRC | 02:46 | |
| *** 18VAAAIFD has joined #openstack-infra | 02:47 | |
| *** binbincong has quit IRC | 02:48 | |
| *** EricGonczer_ has quit IRC | 02:50 | |
| tonyb | lifeless: your desription is fine, but I think it lacks the nuance that "something" and "something else" have a circular relationship and "third thing" is setuptools | 02:51 |
| *** tzn has joined #openstack-infra | 02:57 | |
| *** rossella_s has quit IRC | 02:57 | |
| *** rossella_s has joined #openstack-infra | 02:58 | |
| *** changzhi has joined #openstack-infra | 02:58 | |
| *** gildub has quit IRC | 02:59 | |
| *** binbincong has joined #openstack-infra | 03:01 | |
| *** shashank_hegde has quit IRC | 03:02 | |
| *** Thelo has quit IRC | 03:02 | |
| *** armax has quit IRC | 03:03 | |
| *** rguillebert has quit IRC | 03:07 | |
| *** fedexo has joined #openstack-infra | 03:08 | |
| *** shashank_hegde has joined #openstack-infra | 03:10 | |
| *** thorst has joined #openstack-infra | 03:12 | |
| *** gongysh has joined #openstack-infra | 03:14 | |
| *** shashank_hegde has quit IRC | 03:15 | |
| *** salv-orlando has joined #openstack-infra | 03:16 | |
| *** thorst has quit IRC | 03:18 | |
| *** shashank_hegde has joined #openstack-infra | 03:19 | |
| *** changzhi has quit IRC | 03:22 | |
| *** changzhi has joined #openstack-infra | 03:22 | |
| *** shashank_hegde has quit IRC | 03:25 | |
| *** gildub has joined #openstack-infra | 03:28 | |
| *** salv-orlando has quit IRC | 03:28 | |
| *** tzn has quit IRC | 03:30 | |
| *** shashank_hegde has joined #openstack-infra | 03:37 | |
| *** dims has quit IRC | 03:37 | |
| tonyb | jhesketh: can you look at: http://logs.openstack.org/96/274796/1/gate/gate-nova-python34/d298d96/console.html | 03:43 |
| tonyb | jhesketh: specifically: http://logs.openstack.org/96/274796/1/gate/gate-nova-python34/d298d96/console.html#_2016-02-16_03_22_50_670 | 03:44 |
| tonyb | jhesketh: "Build timed out (after 40 minutes). Marking the build as failed." zuul-cloner to 40mins to clone the nova repo? | 03:44 |
| jhesketh | tonyb: hmm okay | 03:44 |
| *** esikachev has joined #openstack-infra | 03:45 | |
| tonyb | jhesketh: Just thought I'd flag it in case it's a early warning sign of $trouble | 03:45 |
| jhesketh | thanks | 03:46 |
| * jhesketh looks | 03:46 | |
| *** piet has joined #openstack-infra | 03:47 | |
| *** esikachev has quit IRC | 03:49 | |
| *** KanagarajM has joined #openstack-infra | 03:51 | |
| openstackgerrit | Craig Vyvial proposed openstack-infra/project-config: run trove experimental run scenario tests https://review.openstack.org/278095 | 03:53 |
| *** piet has quit IRC | 03:53 | |
| *** amotoki has joined #openstack-infra | 03:56 | |
| *** amotoki has quit IRC | 03:56 | |
| jhesketh | tonyb: so I can't see which git mirror you were actually bounced to but they all look okay according to cacti and the replication appears to be running without issue.. it also seems that most other clones are working | 03:56 |
| tonyb | jhesketh: Thanks for looking. | 03:57 |
| *** daemontool has quit IRC | 04:02 | |
| *** david-lyle has quit IRC | 04:03 | |
| openstackgerrit | Merged openstack-infra/project-config: Remove restrict-memory https://review.openstack.org/280364 | 04:04 |
| *** ccrouch has quit IRC | 04:09 | |
| *** gildub has quit IRC | 04:09 | |
| *** thorst has joined #openstack-infra | 04:16 | |
| jhesketh | tonyb: seems to be a few occurances over the last week http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22*ERROR%3Azuul.Repo%3AUnable*%5C%22 | 04:17 |
| *** sam_wan has quit IRC | 04:18 | |
| jhesketh | doesn't appear to be due to any particular jenkins master or region (well all the regions are rax, but because of the low number of failures and limited nodes I'm not sure if that's a correlation) | 04:19 |
| tonyb | jhesketh: okay, the frequency seems to be increasing | 04:19 |
| tonyb | look at 7 days worth of data | 04:20 |
| openstackgerrit | Bertrand Roussel proposed openstack-infra/jenkins-job-builder: Description Setter Plugin support as builder https://review.openstack.org/280416 | 04:20 |
| *** smanjara has joined #openstack-infra | 04:21 | |
| jhesketh | tonyb: right, it looks that way but we may just not have enough data from earlier | 04:22 |
| tonyb | jhesketh: okay. | 04:22 |
| tonyb | jhesketh: I might and an eleastic-recheck rule for it | 04:23 |
| *** dimtruck is now known as zz_dimtruck | 04:23 | |
| jhesketh | tonyb: good idea | 04:23 |
| *** thorst has quit IRC | 04:24 | |
| openstackgerrit | Merged openstack-infra/project-config: Cleanup the early devstack clone script https://review.openstack.org/268888 | 04:25 |
| *** sam_wan has joined #openstack-infra | 04:26 | |
| *** MarkAtwood has quit IRC | 04:26 | |
| *** sputnik13 has joined #openstack-infra | 04:27 | |
| *** tzn has joined #openstack-infra | 04:27 | |
| *** sabeen1 has quit IRC | 04:28 | |
| *** sputnik13 has quit IRC | 04:31 | |
| jhesketh | tonyb: there are some weird git average server times here http://grafana.openstack.org/dashboard/db/git-load-balancer (very last graph) | 04:32 |
| jhesketh | but it's across multiple backends and it's not clear what that might imply | 04:32 |
| *** changzhi has quit IRC | 04:32 | |
| openstackgerrit | Thanh Ha proposed openstack-infra/zuul: Add additional zuul.conf information https://review.openstack.org/271868 | 04:34 |
| *** gildub has joined #openstack-infra | 04:34 | |
| *** smanjara has quit IRC | 04:35 | |
| *** markvoelker has joined #openstack-infra | 04:36 | |
| tonyb | jhesketh: Yeah there's a lot of data there, I'd need more context to pull in information out. | 04:36 |
| jhesketh | probably the most interesting thing is that there isn't obviously one node doing something different | 04:37 |
| jhesketh | so either it's very subtle or across all the backends | 04:37 |
| tonyb | jhesketh: I'm assuming that I can't tell which server I got directed to? | 04:37 |
| jhesketh | sadly no | 04:37 |
| jhesketh | that'd make things too easy | 04:37 |
| tonyb | :) | 04:37 |
| tonyb | Yeah there are some strange peaks there but nothing clearly and massivly wrong. | 04:38 |
| jhesketh | and where there are peaks it's different nodes | 04:38 |
| jhesketh | sadly I'm out of ideas where to look from here sorry :-s | 04:39 |
| jhesketh | tonyb: fwiw the recheck looks like it'll work | 04:40 |
| jhesketh | or at least not fail for any git reasons | 04:40 |
| *** markvoelker has quit IRC | 04:41 | |
| *** tiswanso has quit IRC | 04:44 | |
| *** achanda has joined #openstack-infra | 04:48 | |
| tonyb | jhesketh: Yeah, Thanks for lettign me distract you. | 04:52 |
| *** fawadkhaliq has joined #openstack-infra | 04:52 | |
| *** oomichi has joined #openstack-infra | 04:55 | |
| jhesketh | no worries | 04:55 |
| *** david-lyle has joined #openstack-infra | 04:55 | |
| *** tzn has quit IRC | 05:00 | |
| *** shashank_hegde has quit IRC | 05:10 | |
| *** fedexo has quit IRC | 05:18 | |
| *** thorst has joined #openstack-infra | 05:21 | |
| *** baoli_ has quit IRC | 05:26 | |
| *** tphummel has joined #openstack-infra | 05:28 | |
| *** oomichi has quit IRC | 05:29 | |
| *** thorst has quit IRC | 05:29 | |
| *** tphummel has quit IRC | 05:30 | |
| *** changzhi has joined #openstack-infra | 05:32 | |
| *** bpokorny has quit IRC | 05:40 | |
| *** kushal has joined #openstack-infra | 05:41 | |
| *** coolsvap|away is now known as coolsvap | 05:56 | |
| *** tzn has joined #openstack-infra | 05:57 | |
| clarkb | tonyb: jhesketh was that job in ovh? | 06:01 |
| clarkb | I wonder if the network trouble is back | 06:01 |
| tonyb | rax | 06:01 |
| clarkb | huh | 06:01 |
| tonyb | clarkb: 2nd thing I checked :) | 06:01 |
| jhesketh | clarkb: yeah all rax by the looks | 06:04 |
| *** piet has joined #openstack-infra | 06:06 | |
| *** Sukhdev has joined #openstack-infra | 06:07 | |
| *** sridhar_ram has joined #openstack-infra | 06:10 | |
| *** piet has quit IRC | 06:11 | |
| *** MarkAtwood has joined #openstack-infra | 06:15 | |
| *** MarkAtwood has quit IRC | 06:19 | |
| *** gildub has quit IRC | 06:20 | |
| *** jaosorior has joined #openstack-infra | 06:20 | |
| *** vgridnev has joined #openstack-infra | 06:20 | |
| *** vgridnev has quit IRC | 06:21 | |
| *** vgridnev has joined #openstack-infra | 06:22 | |
| *** vgridnev_ has joined #openstack-infra | 06:23 | |
| *** vgridnev has quit IRC | 06:26 | |
| *** thorst has joined #openstack-infra | 06:27 | |
| *** tzn has quit IRC | 06:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/requirements: Updated from generate-constraints https://review.openstack.org/279926 | 06:33 |
| *** smanjara has joined #openstack-infra | 06:33 | |
| *** thorst has quit IRC | 06:34 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/project-config: Normalize projects.yaml https://review.openstack.org/280516 | 06:37 |
| *** markvoelker has joined #openstack-infra | 06:37 | |
| openstackgerrit | Omer Anson proposed openstack/requirements: Add scapy and python-pytun https://review.openstack.org/277893 | 06:37 |
| *** [HeOS] is now known as HeOS | 06:38 | |
| *** achanda has quit IRC | 06:39 | |
| *** david-lyle has quit IRC | 06:39 | |
| *** sridhar_ram has quit IRC | 06:40 | |
| *** david-lyle has joined #openstack-infra | 06:40 | |
| *** k4n0 has joined #openstack-infra | 06:42 | |
| *** markvoelker has quit IRC | 06:42 | |
| *** salv-orlando has joined #openstack-infra | 06:43 | |
| *** zzzeek has quit IRC | 06:44 | |
| *** k4n0 has quit IRC | 06:44 | |
| *** tzn has joined #openstack-infra | 06:45 | |
| *** tzn has quit IRC | 06:45 | |
| *** tzn has joined #openstack-infra | 06:46 | |
| *** salv-orlando has quit IRC | 06:46 | |
| *** _nadya_ has joined #openstack-infra | 06:53 | |
| *** tzn has quit IRC | 06:55 | |
| *** MarkAtwood has joined #openstack-infra | 06:57 | |
| *** rossella_s has quit IRC | 06:57 | |
| *** coolsvap is now known as coolsvap|away | 06:58 | |
| *** rossella_s has joined #openstack-infra | 06:58 | |
| openstackgerrit | Akihiro Motoki proposed openstack-infra/project-config: Enable translation jobs for sahara-dashboard https://review.openstack.org/280520 | 06:59 |
| *** achanda has joined #openstack-infra | 06:59 | |
| *** e0ne has joined #openstack-infra | 07:02 | |
| *** Liuqing has joined #openstack-infra | 07:05 | |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder: Move hook generation in to python https://review.openstack.org/271139 | 07:06 |
| *** wolverineav has quit IRC | 07:08 | |
| *** smanjara has quit IRC | 07:10 | |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder: Move hook generation in to python https://review.openstack.org/271139 | 07:10 |
| *** abregman has joined #openstack-infra | 07:13 | |
| openstackgerrit | Merged openstack-infra/project-config: puppet-ceph: do not run integ jobs for scenario002 https://review.openstack.org/278072 | 07:14 |
| openstackgerrit | Merged openstack-infra/project-config: Change networking-ovn rally job to use devstackgaterc https://review.openstack.org/279927 | 07:14 |
| openstackgerrit | Merged openstack-infra/project-config: Normalize projects.yaml https://review.openstack.org/280516 | 07:17 |
| *** nmagnezi has joined #openstack-infra | 07:19 | |
| openstackgerrit | Merged openstack-infra/project-config: Specify master branch for the devstack plugins periodic job https://review.openstack.org/280425 | 07:20 |
| *** wolverineav has joined #openstack-infra | 07:21 | |
| *** smanjara has joined #openstack-infra | 07:24 | |
| *** scheuran has joined #openstack-infra | 07:25 | |
| *** kiranr_ has joined #openstack-infra | 07:32 | |
| *** thorst has joined #openstack-infra | 07:32 | |
| *** _nadya_ has quit IRC | 07:32 | |
| *** gongysh has quit IRC | 07:33 | |
| *** kiranr_ is now known as kiran-r | 07:33 | |
| *** gsagie has joined #openstack-infra | 07:34 | |
| *** gsagie has left #openstack-infra | 07:34 | |
| *** rcernin has joined #openstack-infra | 07:37 | |
| *** thorst has quit IRC | 07:38 | |
| *** sbadia has quit IRC | 07:42 | |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder: Move hook generation in to python https://review.openstack.org/271139 | 07:43 |
| *** jbernard has quit IRC | 07:43 | |
| *** jbernard has joined #openstack-infra | 07:43 | |
| *** ekarlso has quit IRC | 07:44 | |
| *** ruhe has quit IRC | 07:44 | |
| *** ruhe has joined #openstack-infra | 07:45 | |
| *** Anticimex has quit IRC | 07:45 | |
| *** vponomaryov has quit IRC | 07:45 | |
| *** vponomaryov has joined #openstack-infra | 07:45 | |
| *** loquacities has quit IRC | 07:45 | |
| *** aarefiev has quit IRC | 07:45 | |
| *** jeblair has quit IRC | 07:45 | |
| *** aarefiev has joined #openstack-infra | 07:46 | |
| *** kragniz has quit IRC | 07:46 | |
| *** Sukhdev has quit IRC | 07:46 | |
| *** kragniz has joined #openstack-infra | 07:46 | |
| *** Anticimex has joined #openstack-infra | 07:46 | |
| *** jeblair has joined #openstack-infra | 07:46 | |
| *** sbadia has joined #openstack-infra | 07:47 | |
| *** kozhukal` has joined #openstack-infra | 07:47 | |
| *** loquacities has joined #openstack-infra | 07:48 | |
| *** piet has joined #openstack-infra | 07:49 | |
| *** kozhukal` is now known as kozhukalov | 07:49 | |
| *** tzn has joined #openstack-infra | 07:50 | |
| *** fawadkhaliq has quit IRC | 07:51 | |
| *** fawadkhaliq has joined #openstack-infra | 07:52 | |
| *** fawadkhaliq has quit IRC | 07:52 | |
| *** fawadkhaliq has joined #openstack-infra | 07:52 | |
| *** fawadkhaliq has quit IRC | 07:53 | |
| *** flepied has quit IRC | 07:53 | |
| *** fawadkhaliq has joined #openstack-infra | 07:53 | |
| *** piet has quit IRC | 07:54 | |
| yolanda | good morning | 07:55 |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder: Don't cache debootstrap rootfs by default https://review.openstack.org/280536 | 07:56 |
| *** samuelBartel has joined #openstack-infra | 07:56 | |
| yolanda | greghaynes, around? | 07:56 |
| *** ekarlso has joined #openstack-infra | 07:57 | |
| *** piet has joined #openstack-infra | 07:59 | |
| *** sorantis has joined #openstack-infra | 08:00 | |
| AJaeger | good morning, yolanda ! | 08:00 |
| yolanda | how are things today? | 08:01 |
| AJaeger | could you review https://review.openstack.org/278588 and https://review.openstack.org/280290 , please? | 08:02 |
| *** sorantis_ has joined #openstack-infra | 08:02 | |
| yolanda | sure | 08:02 |
| AJaeger | yolanda: everything fine so far ;) Hope we don't have bad surprises ;) | 08:02 |
| openstackgerrit | Merged openstack-infra/puppet-infracloud: Setup rabbit user/pass for keystone https://review.openstack.org/278482 | 08:02 |
| openstackgerrit | Merged openstack-infra/system-config: Send keystone_rabbit_password parameter https://review.openstack.org/278485 | 08:03 |
| yolanda | yesterday was crazy | 08:03 |
| AJaeger | yolanda: yeah ;( clarkb had some fun later as well since we noticed that some of the constraint macros were broken ;( | 08:04 |
| AJaeger | and he needed to manually run jjb again... | 08:04 |
| AJaeger | and restart jenkins04... | 08:04 |
| AJaeger | yolanda: https://review.openstack.org/280369 would be nice as well | 08:04 |
| *** sorantis has quit IRC | 08:04 | |
| yolanda | AJaeger, why were they broken? some bug on the jobs? or a malfunction of jjb? | 08:04 |
| *** sorantis_ has quit IRC | 08:05 | |
| *** sorantis has joined #openstack-infra | 08:06 | |
| openstackgerrit | Merged openstack-infra/project-config: Promote neutron-src-neutron-lib job to check/gate https://review.openstack.org/280443 | 08:06 |
| openstackgerrit | Merged openstack-infra/project-config: Check for astra misspelling https://review.openstack.org/279143 | 08:07 |
| AJaeger | yolanda: I863de2c3d5847e9c1943bb25e28b86a68871693f - the checkout of constraints file was broken for requiremetns repo. See 280369 as well. WE had one if in there but needed the second as well - and this macro was used in far too many jobs... | 08:07 |
| *** jed56 has joined #openstack-infra | 08:08 | |
| openstackgerrit | Merged openstack-infra/project-config: Enable gate-infra-ansible on check and gate pipelines https://review.openstack.org/280197 | 08:08 |
| AJaeger | So, everything fine for all repos except requirements - but that fix touched all of them ;( | 08:08 |
| yolanda | oh, when there is a massive job reconfig, it's really a pain | 08:08 |
| *** coolsvap|away is now known as coolsvap | 08:09 | |
| AJaeger | yes. | 08:10 |
| openstackgerrit | Merged openstack-infra/project-config: Revert "Support stable requirements" https://review.openstack.org/278588 | 08:10 |
| AJaeger | So, yesterday we cut down number of total jobs from 8700 to 8001 - that might help a tiny bit... | 08:10 |
| openstackgerrit | Merged openstack-infra/project-config: Remove check requirements from Kingbird https://review.openstack.org/280290 | 08:10 |
| *** MarkAtwood has quit IRC | 08:11 | |
| openstackgerrit | Merged openstack-infra/project-config: Sync zuul-git-branch-prep-upper-constraints https://review.openstack.org/280369 | 08:11 |
| *** ociuhandu has joined #openstack-infra | 08:11 | |
| openstackgerrit | Merged openstack-infra/infra-ansible: Pin ansible package to stable 2.0.0.2 https://review.openstack.org/280173 | 08:12 |
| openstackgerrit | Merged openstack-infra/infra-ansible: Refactor setup_env.sh to use virtualenvs https://review.openstack.org/280172 | 08:12 |
| *** infra-red has joined #openstack-infra | 08:13 | |
| *** e0ne has quit IRC | 08:13 | |
| AJaeger | Oh,NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO ;( | 08:13 |
| *** sshnaidm has quit IRC | 08:14 | |
| AJaeger | This one is old: https://jenkins07.openstack.org/job/gate-nova-pep8/configure | 08:14 |
| AJaeger | yolando, could you manually run jjb on jenkins07 again, please? | 08:14 |
| AJaeger | clarkb, I thought you updated all jenkins. What happened with 07? ^ | 08:15 |
| *** shardy has joined #openstack-infra | 08:16 | |
| yolanda | ok i'll run again if you don't call me yolando any more :) | 08:16 |
| *** smanjara has quit IRC | 08:16 | |
| * AJaeger apologices | 08:17 | |
| AJaeger | yolanda: I'm sorry | 08:17 |
| yolanda | heh, you are not the first calling me like that :) | 08:17 |
| yolanda | so i had a similar problem yesterday on some jenkins. Ansible was saying ok, but jjb had not run | 08:18 |
| yolanda | i wonder how it traps the errors | 08:18 |
| AJaeger | yolanda, it was really a typo. | 08:18 |
| *** mikelk has joined #openstack-infra | 08:18 | |
| * AJaeger just checked jenkins 01-07 - only 07 had this job wrong | 08:18 | |
| yolanda | ok running on 07 | 08:19 |
| *** tzn has quit IRC | 08:19 | |
| *** tzn has joined #openstack-infra | 08:20 | |
| *** smanjara has joined #openstack-infra | 08:21 | |
| AJaeger | thanks | 08:21 |
| nibalizer | AJaeger: yolanda good morning | 08:21 |
| yolanda | hi nibalizer | 08:21 |
| *** kushal has quit IRC | 08:21 | |
| *** ociuhandu has quit IRC | 08:21 | |
| AJaeger | morning, nibalizer ! | 08:22 |
| *** zeih has joined #openstack-infra | 08:24 | |
| *** ihrachys has joined #openstack-infra | 08:25 | |
| *** vgridnev has joined #openstack-infra | 08:26 | |
| *** coolsvap is now known as coolsvap|away | 08:26 | |
| openstackgerrit | Andrey Pavlov proposed openstack-infra/puppet-refstack: use specific tag version of refstack for installation. https://review.openstack.org/279511 | 08:26 |
| *** vgridnev has quit IRC | 08:27 | |
| yolanda | AJaeger, in the case of neutron jobs, but related to non-neutron projects, like gate-tempest-dsvm-neutron-src-oslo.service , do we need +1 from neutron liaison? | 08:27 |
| *** flepied has joined #openstack-infra | 08:28 | |
| *** matrohon has joined #openstack-infra | 08:28 | |
| *** mikelk has quit IRC | 08:28 | |
| zeih | AJaeger: around? | 08:29 |
| *** vgridnev has joined #openstack-infra | 08:29 | |
| *** salv-orlando has joined #openstack-infra | 08:30 | |
| yolanda | btw, AJaeger, cache corruption again on jenkins07 | 08:30 |
| yolanda | we'll need to launch a massive reconfig again :( | 08:30 |
| AJaeger | yolanda: I don't think so, it'S a job for a non-neutron repo... | 08:30 |
| AJaeger | yolanda: :( | 08:30 |
| AJaeger | But you can run that only on jenkins07... | 08:31 |
| AJaeger | zeih: yes, what's up? | 08:31 |
| yolanda | AJaeger yes, i'll do only on jenkins07 | 08:31 |
| *** vgridnev has quit IRC | 08:31 | |
| zeih | AJaeger: I have a question about https://review.openstack.org/#/c/278459/ | 08:31 |
| AJaeger | yolanda: clarkb mentioned yesterday not approving changes while doing a manual jjb run. | 08:32 |
| yolanda | ok let's not approve anything else until it's done | 08:32 |
| *** salv-orlando has quit IRC | 08:32 | |
| AJaeger | yolanda: you might want to wait utnil 280328 has merged *and* puppet has moved the new files to jenkins07 | 08:33 |
| *** oomichi has joined #openstack-infra | 08:33 | |
| zeih | AJaeger: There is a question regarding the OpenStack Proposal Bot. His use in non-master branches. | 08:33 |
| * AJaeger abstains from +A now as well... | 08:33 | |
| AJaeger | zeih: let me check | 08:33 |
| zeih | AJaeger: thx | 08:33 |
| *** vgridnev_ has quit IRC | 08:33 | |
| *** smanjara has quit IRC | 08:34 | |
| *** tzn has quit IRC | 08:34 | |
| AJaeger | zeih: what's the problem exactly? Not getting it quickly | 08:34 |
| *** vgridnev has joined #openstack-infra | 08:34 | |
| *** tzn has joined #openstack-infra | 08:34 | |
| *** tzn has quit IRC | 08:34 | |
| AJaeger | ah, see it. You hvae "hacking<0.9,>=0.8.0" in https://review.openstack.org/#/c/278487/1/test-requirements.txt and that causes the failure. | 08:35 |
| zeih | AJaeger: After we updated requirements in master branch and enabled the job in project config, we enabled the Bot in global requirements repo. Now we want to update the reqs in stable/liberty branch too | 08:36 |
| AJaeger | Do the following: Manually update 278487 and update the hacking line as well to newer version | 08:36 |
| yolanda | AJaeger, i am worried but these daily cache problems. Seems that jjb is running in top of another on consecutive puppet runs, because we are hitting these invalid cache problems quite often | 08:36 |
| AJaeger | yolanda: best talk with clarkb and fungi later today - yes, this is really strange... | 08:36 |
| openstackgerrit | Merged openstack-infra/project-config: Exlude gate-tempest-dsvm-neutron-src-oslo.service from stable/liberty https://review.openstack.org/280328 | 08:37 |
| *** oomichi has quit IRC | 08:37 | |
| zeih | AJaeger: Is the Bot resposible for updating in stable branches as well? | 08:37 |
| AJaeger | zeih: yes, it is. | 08:37 |
| AJaeger | but updates happen rarely on these. | 08:38 |
| AJaeger | You're still in the bootstrapping phase ;) | 08:38 |
| *** jlanoux has joined #openstack-infra | 08:38 | |
| zeih | AJaeger: yes we are :) | 08:38 |
| *** vgridnev has quit IRC | 08:38 | |
| *** thorst has joined #openstack-infra | 08:39 | |
| *** ihrachys has quit IRC | 08:39 | |
| zeih | AJaeger: So do I need to do this manually or do we just have to wait? | 08:39 |
| *** vgridnev_ has joined #openstack-infra | 08:39 | |
| *** mikelk has joined #openstack-infra | 08:39 | |
| AJaeger | zeih: you have to do it manually, the bot is not updating the hacking line | 08:39 |
| AJaeger | so, amend that change with changing the hacking line and merge it... | 08:40 |
| AJaeger | yolanda: I don't know either why this suddenly pops up... | 08:40 |
| yolanda | AJaeger, if jjb runs fast with small changes it should be ok. But with these jobs reconfigs of the latest days it fails, so i'm thinking that this can be the reason, jjb still running for long, and puppet executing again | 08:42 |
| *** jlanoux has quit IRC | 08:42 | |
| AJaeger | yolanda: what about disabling puppet for the manual run? | 08:42 |
| *** vgridnev_ has quit IRC | 08:42 | |
| *** vgridnev has joined #openstack-infra | 08:43 | |
| yolanda | AJaeger i did it on jenkins07 | 08:43 |
| AJaeger | ;) | 08:44 |
| *** jlanoux has joined #openstack-infra | 08:44 | |
| zeih | AJaeger: so.. I have to update hacking>=0.10.2,<0.11 like https://github.com/openstack/requirements/blob/stable/liberty/global-requirements.txt#L331 ? | 08:44 |
| yolanda | but yes, doing that when running the plays seems a good idea | 08:44 |
| AJaeger | zeih: yes | 08:44 |
| *** jordanP has joined #openstack-infra | 08:44 | |
| *** vgridnev has quit IRC | 08:44 | |
| zeih | AJaeger: thx. will try | 08:44 |
| *** thorst has quit IRC | 08:44 | |
| *** yaume has joined #openstack-infra | 08:45 | |
| *** smanjara has joined #openstack-infra | 08:46 | |
| openstackgerrit | Dimitri Mazmanov proposed openstack-infra/project-config: Add check-requirements job https://review.openstack.org/280550 | 08:46 |
| *** piet has quit IRC | 08:47 | |
| AJaeger | yolanda: wow, the temporary removal was really short - only an hour or so ^ | 08:49 |
| *** wolverineav has quit IRC | 08:49 | |
| yolanda | oh dear | 08:49 |
| yolanda | ok let's wait for jjb to finish on jenkins07 and we'll review again | 08:49 |
| AJaeger | yolanda: no worries, that one has time - they were blocked since they had a broken requirements file and the check job tests both the original file and the new one - and failed on the original one, so they had not chance to get it fixed ;( | 08:50 |
| *** hashar has joined #openstack-infra | 08:50 | |
| yolanda | AJaeger yes, i can understand that these things happen, we've hit this quite often downstream | 08:51 |
| yolanda | sometimes the only way to fix a problem is disabling the jobs, or if you have powers, force pushing | 08:51 |
| AJaeger | yep | 08:51 |
| * AJaeger will be back later, thanks yolanda for keeping our CI running! | 08:51 | |
| yolanda | AJaeger no problem, glad to help. I will be leaving in an hour as well, will be out for a pair of hours | 08:52 |
| yolanda | AJaeger, you seem to be always working, early in the morning until late at night... | 08:52 |
| *** fhubik has joined #openstack-infra | 08:53 | |
| *** fhubik is now known as fhubik_brb | 08:53 | |
| *** max_lobur has quit IRC | 08:56 | |
| anteaya | fungi: thank you | 08:58 |
| *** jlanoux has quit IRC | 08:59 | |
| *** wolverineav has joined #openstack-infra | 09:01 | |
| *** jlanoux has joined #openstack-infra | 09:02 | |
| *** fhubik_brb is now known as fhubik | 09:03 | |
| *** achanda has quit IRC | 09:03 | |
| *** ihrachys has joined #openstack-infra | 09:03 | |
| *** wolverineav has quit IRC | 09:04 | |
| *** zeih has quit IRC | 09:05 | |
| *** |-paul-| has joined #openstack-infra | 09:05 | |
| *** bexelbie has quit IRC | 09:06 | |
| *** bexelbie has joined #openstack-infra | 09:06 | |
| *** achanda has joined #openstack-infra | 09:06 | |
| *** ifarkas has joined #openstack-infra | 09:07 | |
| *** zeih has joined #openstack-infra | 09:08 | |
| *** salv-orlando has joined #openstack-infra | 09:08 | |
| *** kiran-r has quit IRC | 09:08 | |
| *** max_lobur has joined #openstack-infra | 09:09 | |
| *** kiran-r has joined #openstack-infra | 09:09 | |
| *** sshnaidm has joined #openstack-infra | 09:16 | |
| *** e0ne has joined #openstack-infra | 09:16 | |
| *** _nadya_ has joined #openstack-infra | 09:18 | |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/infra-ansible: Create other required openstack resources https://review.openstack.org/280561 | 09:19 |
| *** d0ugal has quit IRC | 09:21 | |
| *** d0ugal has joined #openstack-infra | 09:21 | |
| *** yamahata has quit IRC | 09:22 | |
| openstackgerrit | Stefan Andres proposed openstack-infra/shade: Fix lookup for network parameter in neutron_available_floating_ips This change attempts to fix the network parameter in neutron_available_floating_ips: * old behavior ignores network parameter and guesses external net * new behavior takes name or id and s https://review.openstack.org/280178 | 09:22 |
| *** max_lobur has quit IRC | 09:24 | |
| *** lucas-dinner is now known as lucasagomes | 09:24 | |
| *** achanda has quit IRC | 09:28 | |
| *** zhurong has quit IRC | 09:28 | |
| *** wwwbukolaycom has joined #openstack-infra | 09:28 | |
| *** dtantsur|afk is now known as dtantsur | 09:30 | |
| *** max_lobur has joined #openstack-infra | 09:32 | |
| *** akscram has quit IRC | 09:33 | |
| *** akscram has joined #openstack-infra | 09:33 | |
| *** sfinucan has joined #openstack-infra | 09:34 | |
| *** Thelo has joined #openstack-infra | 09:35 | |
| *** wewe0901 has joined #openstack-infra | 09:36 | |
| *** tpsilva has joined #openstack-infra | 09:37 | |
| *** zeih has quit IRC | 09:38 | |
| *** electrofelix has joined #openstack-infra | 09:38 | |
| anteaya | fungi madorn I am able to vote +2, +A on the sandbox repo: https://review.openstack.org/#/c/279763/1 | 09:39 |
| AJaeger | anteaya: yippie! | 09:39 |
| anteaya | yippie! | 09:39 |
| *** ihrachys has quit IRC | 09:39 | |
| anteaya | :) | 09:39 |
| *** zeih has joined #openstack-infra | 09:39 | |
| anteaya | ops meetup is going well | 09:40 |
| AJaeger | glad to hear! | 09:40 |
| AJaeger | how many are there? | 09:40 |
| anteaya | the european operators have a very different approach to how they use openstack | 09:40 |
| AJaeger | Interesting - can you explain the difference? | 09:40 |
| anteaya | 80 in the room right now? | 09:40 |
| anteaya | they _want_ to work with other openstack providers collaboratively | 09:41 |
| AJaeger | great! | 09:41 |
| anteaya | it is part of their business model | 09:41 |
| anteaya | it is a lovely atmosphere to be in | 09:41 |
| *** Liuqing has quit IRC | 09:41 | |
| *** thorst has joined #openstack-infra | 09:42 | |
| AJaeger | and productive I guess? | 09:42 |
| anteaya | well it is a different paradigm so they have challenges it meeting rquirements for tenders since the evaluators are using old mental models | 09:42 |
| *** ociuhandu has joined #openstack-infra | 09:43 | |
| anteaya | but the long term view is very practical and very beneficial for providers and customers | 09:43 |
| *** kushal has joined #openstack-infra | 09:43 | |
| AJaeger | cool | 09:45 |
| anteaya | I agree | 09:45 |
| anteaya | it is highly enjoyable room to e sitting in | 09:46 |
| mordred | anteaya: yay! | 09:46 |
| anteaya | *be | 09:46 |
| anteaya | yay! | 09:46 |
| anteaya | mordred: morning | 09:46 |
| *** fawadkhaliq has quit IRC | 09:48 | |
| *** ihrachys has joined #openstack-infra | 09:48 | |
| *** fawadkhaliq has joined #openstack-infra | 09:48 | |
| *** thorst has quit IRC | 09:49 | |
| AJaeger | morning, mordred ! | 09:49 |
| *** tzn has joined #openstack-infra | 09:49 | |
| *** ociuhandu has quit IRC | 09:50 | |
| *** fawadkhaliq has quit IRC | 09:50 | |
| *** fawadkhaliq has joined #openstack-infra | 09:50 | |
| *** tzn has quit IRC | 09:51 | |
| *** tzn has joined #openstack-infra | 09:51 | |
| mordred | anteaya, AJaeger: morning! | 09:51 |
| *** ociuhandu has joined #openstack-infra | 09:53 | |
| *** fawadkhaliq has quit IRC | 09:54 | |
| *** fawadkhaliq has joined #openstack-infra | 09:55 | |
| AJaeger | yolanda: did jenkins07 manual jjb run finish already? | 09:56 |
| yolanda | AJaeger, still running | 09:57 |
| openstackgerrit | Jesse Keating proposed openstack-infra/project-config: Add giftwrap to OpenStack https://review.openstack.org/280305 | 09:58 |
| yolanda | i'd expect at least one hour, it's on "gate-x*" jobs now | 09:58 |
| AJaeger | yolanda: I looked at the wrong job and that one is updated already, so moving in the right direction... | 09:59 |
| *** ganso has joined #openstack-infra | 09:59 | |
| *** tzn has quit IRC | 09:59 | |
| AJaeger | yolanda: gate-x is 5000 of 8000 - yeah, so indeed another hour | 10:00 |
| yolanda | i'm leaving now, the jjb reconfig is running on a screen session, and i'll check when i come back so i can reenable puppet on jenkins07 | 10:00 |
| AJaeger | thanks, yolanda | 10:00 |
| *** tzn has joined #openstack-infra | 10:01 | |
| *** salv-orl_ has joined #openstack-infra | 10:02 | |
| *** wolverineav has joined #openstack-infra | 10:04 | |
| *** salv-orlando has quit IRC | 10:05 | |
| *** piet has joined #openstack-infra | 10:06 | |
| *** Liuqing has joined #openstack-infra | 10:06 | |
| *** jcoufal has joined #openstack-infra | 10:07 | |
| *** placko_ has joined #openstack-infra | 10:07 | |
| *** andymaier has joined #openstack-infra | 10:09 | |
| *** wolverineav has quit IRC | 10:09 | |
| *** vgridnev has joined #openstack-infra | 10:14 | |
| *** vgridnev has quit IRC | 10:14 | |
| *** vgridnev has joined #openstack-infra | 10:15 | |
| trash | Can someone tell me what the exact pep8 error in http://logs.openstack.org/78/280178/4/check/gate-shade-pep8/e293a01/console.html shall be? I cannot find one | 10:19 |
| *** rguillebert has joined #openstack-infra | 10:19 | |
| anteaya | trash: how interesting, the log doesn't share what the error is, just that flake8 was the command that errored: http://logs.openstack.org/78/280178/4/check/gate-shade-pep8/e293a01/console.html#_2016-02-16_09_28_17_097 | 10:21 |
| *** fhubik is now known as fhubik_brb | 10:21 | |
| *** fhubik_brb is now known as fhubik | 10:21 | |
| anteaya | but the error didn't get reported back to the log | 10:21 |
| trash | Yeah, strange. flake8 doesn't report any errors locally. | 10:21 |
| anteaya | :( | 10:21 |
| anteaya | makes it difficult to fix the code so it passes | 10:22 |
| *** yaume has quit IRC | 10:22 | |
| trash | Totally :/ | 10:23 |
| *** andymaier has quit IRC | 10:23 | |
| *** yaume has joined #openstack-infra | 10:23 | |
| *** sorantis has quit IRC | 10:23 | |
| trash | It's guessing time I guess. | 10:24 |
| anteaya | mordred: the shade pep8 test calls flake8 and flake8 doesn't report errors back up to be logged making it challenging for devs to have compliant patches, have you any recommendations? | 10:24 |
| openstackgerrit | Stefan Andres proposed openstack-infra/shade: Fix lookup for network parameter in neutron_available_floating_ips This change attempts to fix the network parameter in neutron_available_floating_ips: * old behavior ignores network parameter and guesses external net * new behavior takes name or id and s https://review.openstack.org/280178 | 10:24 |
| *** yaume has quit IRC | 10:24 | |
| trash | I am also wondering why the description isn't updated anymore when I push an updated code set | 10:24 |
| anteaya | trash: have you an example? | 10:25 |
| trash | The link openstackgerrit just pasted | 10:25 |
| *** yaume has joined #openstack-infra | 10:25 | |
| *** yaume has quit IRC | 10:25 | |
| trash | It misses the line below the last '*' => https://github.com/syseleven/shade/commit/4fea2bd790918fe191f7efa59131f42a3fcfa8c6 | 10:25 |
| *** zeih has quit IRC | 10:26 | |
| *** vgridnev has quit IRC | 10:26 | |
| *** jlanoux has quit IRC | 10:26 | |
| *** jlanoux has joined #openstack-infra | 10:27 | |
| anteaya | trash: oh you are stefan, 280178 is your patch | 10:28 |
| trash | anteaya: Yep | 10:28 |
| trash | (trying to add unit tests this afternoon) | 10:29 |
| anteaya | are you talking about the commit message? | 10:29 |
| anteaya | trash: have you read: http://docs.openstack.org/infra/manual/developers.html#updating-a-change | 10:30 |
| *** sam_wan has quit IRC | 10:30 | |
| *** zeih has joined #openstack-infra | 10:30 | |
| trash | I have 3 topics to this change :-) 1. the commit msg is not the one I put in git (see the original github one) 2. the last build did not show the actual flake8 error. Waiting on current build 3. (my task) I will write unit tests later today hopefully | 10:31 |
| anteaya | what do you mean the original github one? | 10:31 |
| AJaeger | trash: github? I'm confused. Github is just a mirror.... | 10:31 |
| anteaya | are you submitting patches to github? | 10:31 |
| trash | Yes, original is the wrong word for it | 10:31 |
| trash | I've also pushed it to github so that I have a pip source to install this version from | 10:32 |
| trash | (besides the actual original openstack-infra one) | 10:32 |
| trash | Sorry to have confused you. | 10:32 |
| anteaya | I think we need to use gerrit for reference for the patch: https://review.openstack.org/#/c/280178/5 | 10:32 |
| anteaya | we support patches submitted to gerrit | 10:32 |
| trash | Ah, now it shows the correct commit msg. | 10:32 |
| anteaya | we have no support for patches submitted to github | 10:32 |
| trash | Yes. | 10:32 |
| mordred | anteaya: uh. that's weird - have you seen anything lke that AJaeger ? | 10:33 |
| trash | I know, I know. We just misunderstood. That part is clear. | 10:33 |
| anteaya | trash: great | 10:33 |
| mordred | trash: next time you update the patch, could you put a blank line in between the first and second lines of the commit message - otherwise things get confused and think the entire commit message is the subject :) | 10:33 |
| mordred | trash: no rush or anything | 10:33 |
| mordred | trash: I tried your patch locally with 'tox -epep8' and it ran fine | 10:33 |
| *** jlanoux has quit IRC | 10:33 | |
| mordred | so I'm not sure what the issue is in the CI job :( | 10:33 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/diskimage-builder: Install IPA in a virtual enviroment https://review.openstack.org/235843 | 10:34 |
| anteaya | trash: mordred's comment is the same as the one I left on your patch | 10:34 |
| *** vgridnev has joined #openstack-infra | 10:34 | |
| trash | mordred: Yeah, I did that initiall but then the update did not update, so I thought it had a problem with it :-) | 10:34 |
| *** jlanoux has joined #openstack-infra | 10:34 | |
| *** zeih has quit IRC | 10:35 | |
| trash | The only "rush" is my company, this bug prevents ansible working for us with the offical ansible openstack module, so we want it upstream as soon as possible :-) | 10:35 |
| mordred | trash: heh :) | 10:35 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/diskimage-builder: Install IPA in a virtual environment https://review.openstack.org/235843 | 10:35 |
| AJaeger | mordred: no, haven't see that pep error | 10:35 |
| mordred | trash: the patch looks good in general -I'm just waking up but will review in just a bit | 10:36 |
| trash | mordred: Thank you for your time | 10:36 |
| Zara | anyone want to virtually attend tomorrow's storyboard meetup? there's no cake, but there could be ascii. | 10:36 |
| AJaeger | tox -e pep8 works for me locally as well on the change | 10:36 |
| AJaeger | Zara: no cake? That's sad :(( | 10:36 |
| Zara | AJaeger: there's cake in-person! I'm just not mailing it out. :P | 10:37 |
| Zara | it has icing; I'd be banned from using the postal service ever again. | 10:37 |
| anteaya | cake! | 10:37 |
| anteaya | cake with icing! | 10:38 |
| anteaya | mmmmm | 10:38 |
| *** dosaboy has quit IRC | 10:38 | |
| * AJaeger is envious ;) and thinks you'll have a great storyboard meeting tomorrow! | 10:38 | |
| *** gongysh has joined #openstack-infra | 10:38 | |
| Zara | :) thanks, hope so | 10:39 |
| mordred | trash: oh - you're at syseleven. say hello to martin and kristian for me | 10:39 |
| anteaya | Zara: you will be there, it already is a success in my mind :) | 10:40 |
| Zara | aw, that's so nice of you! :') | 10:40 |
| anteaya | :) | 10:40 |
| mordred | trash: I wonder if maybe the logic shouldn't be inverted | 10:41 |
| *** dosaboy has joined #openstack-infra | 10:41 | |
| trash | mordred: hehe, will do | 10:41 |
| *** asettle has joined #openstack-infra | 10:41 | |
| mordred | trash: like, if you provide a network name, there is no need to have shade look for a network - perhaps put the networks = self.get_external_networks() in the else block? | 10:41 |
| Zara | anteaya: same to you, btw. | 10:41 |
| anteaya | :) | 10:42 |
| *** rfolco has joined #openstack-infra | 10:45 | |
| jlk | Hi folks, I could use a hand with something. I'm working on bringing a new project in, giftwrap, but I have to publish it to pypi as "python-giftwrap". I can't figure out what I need to change in my project-config PR to indicate that the pypi name doesn't exactly match the project name. | 10:45 |
| trash | mordred: Ah, good point. I can do that. | 10:46 |
| jlk | https://review.openstack.org/#/c/280305/ is the review for it. | 10:46 |
| mordred | jlk: it's ok - as long as setup.cfg is correct, the publication system will do the right thing | 10:46 |
| AJaeger | jlk: just mention it in the project-config review | 10:47 |
| AJaeger | Add it to commit message | 10:47 |
| *** thorst has joined #openstack-infra | 10:47 | |
| jlk | okay. | 10:47 |
| mordred | jlk: you'll want to change https://github.com/blueboxgroup/giftwrap/blob/master/setup.cfg#L2 to name = python-giftwrap | 10:47 |
| AJaeger | And we trust that you set up your actual repo so that it does publish that way | 10:47 |
| openstackgerrit | Jesse Keating proposed openstack-infra/project-config: Add giftwrap to OpenStack https://review.openstack.org/280305 | 10:48 |
| *** erlon has joined #openstack-infra | 10:48 | |
| jlk | AJaeger: thanks. I'm poking at setup.cfg now | 10:49 |
| mordred | jlk: I sent you PR | 10:49 |
| jlk | Looks like I need to... | 10:50 |
| jlk | oh | 10:50 |
| mordred | jlk: but feel free to ignore it :) | 10:50 |
| *** yaume has joined #openstack-infra | 10:50 | |
| *** ldnunes has joined #openstack-infra | 10:50 | |
| AJaeger | jlk: Would be also great if the commit message would contain more information about what giftwrap is and how it fits into the OpenStack Ecosystem. | 10:50 |
| jlk | AJaeger: sure, let me do that too | 10:51 |
| AJaeger | jlk, I'll review at a later time in more details... | 10:51 |
| *** dims has joined #openstack-infra | 10:51 | |
| openstackgerrit | Max Lobur proposed openstack-infra/project-config: Create openstack/ramdisk-func-test repository https://review.openstack.org/279120 | 10:52 |
| anteaya | jlk: here is the patch for a project that got accepted by the tc: https://review.openstack.org/#/c/213183/ | 10:54 |
| anteaya | jlk: as an example of the commit message and discussion | 10:54 |
| *** thorst has quit IRC | 10:54 | |
| jlk | thanks, I'll amend a bit more. | 10:56 |
| * anteaya nods | 10:56 | |
| *** rossella_s has quit IRC | 10:57 | |
| *** rossella_s has joined #openstack-infra | 10:58 | |
| AJaeger | jlk, also I suggest you start first with becoming part of OpenSTack - meetings, discussions etc in the open and then apply. Right now nobody has ever heard of giftwrap... With your change in, you can start to change that and show that there's a team that works the OpenStack way | 10:58 |
| openstackgerrit | Stefan Andres proposed openstack-infra/shade: Fix lookup for network parameter in neutron_available_floating_ips https://review.openstack.org/280178 | 10:58 |
| anteaya | trash: nice commit title | 10:58 |
| *** zeih has joined #openstack-infra | 10:59 | |
| trash | :-) | 10:59 |
| *** piet has quit IRC | 10:59 | |
| jlk | AJaeger: yeah, it's known within the operator community, just not in the wider dev community | 10:59 |
| AJaeger | ah... | 10:59 |
| mordred | trash: looks great. Shrews and SpamapS will want a unit test - but I think the substance of your patch is solid | 11:00 |
| *** notnownikki has joined #openstack-infra | 11:01 | |
| openstackgerrit | Max Lobur proposed openstack-infra/project-config: Create openstack/ramdisk-func-test repository https://review.openstack.org/279120 | 11:01 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/requirements: Updated from generate-constraints https://review.openstack.org/279926 | 11:02 |
| *** zeih has quit IRC | 11:03 | |
| trash | mordred: Thanks. Yeah, I'll take a look at unit tests later. Unfortunately this part was not covered before, so it's more work for me | 11:04 |
| trash | anteaya: I found out why my commit msg was not updated in gerrit. The selection of the patch set was still set to 2/6, instead of the latest one in the UI ;-) | 11:05 |
| mordred | trash: oh bother. we don't have any unittests in that stack? that's an ugly stack to ask you to put a new unit test on | 11:05 |
| anteaya | trash: yeah that fun feature trips up a lot of us :( | 11:05 |
| trash | mordred: You do, but not for those functions | 11:05 |
| *** changzhi has quit IRC | 11:05 | |
| openstackgerrit | Merged openstack-infra/shade: Add test option to use Ansible source repo https://review.openstack.org/279646 | 11:06 |
| *** aysyd has joined #openstack-infra | 11:06 | |
| trash | https://github.com/openstack-infra/shade/blob/master/shade/tests/functional/test_network.py is the closest one I can find, I have even no idea what environment I need to actually run those tests. Is there any documentation on that? I cannot find anything in the repo itself. | 11:06 |
| openstackgerrit | Jesse Keating proposed openstack-infra/project-config: Add giftwrap to OpenStack https://review.openstack.org/280305 | 11:07 |
| mordred | trash: it's done in a devstack plugin | 11:12 |
| *** dims has quit IRC | 11:12 | |
| *** piet has joined #openstack-infra | 11:13 | |
| trash | mordred: How is that usually used? I mean, while developing the test, I probably want to trigger it multiple times. I would not want to spam the gerrit with it | 11:13 |
| BobBall | Where does zuul get the required node from? I'm getting a NOT_REGISTERED however my projects.yaml has node: 'ds-xen' which is the same name as nodepool creates and the label showing in jenkins | 11:14 |
| mordred | trash: test_add_auto_ip in shade/tests/unit/test_floating_ip_common.py might be an easier thing to start from | 11:14 |
| *** fhubik has quit IRC | 11:14 | |
| mordred | trash: you can also run functional tests against an existing cloud - but I realize I do not have documentation for doing thtat | 11:15 |
| mordred | trash: (I will add that to my todo list :) ) | 11:15 |
| *** ildikov_ has quit IRC | 11:15 | |
| trash | mordred: This part is even more related, yep - I'll see what I can do with that | 11:15 |
| mordred | trash: oh - or test_available_floating_ip_existing | 11:15 |
| mordred | in shade/tests/unit/test_floating_ip_neutron.py | 11:15 |
| mordred | is even closer | 11:16 |
| *** vgridnev_ has joined #openstack-infra | 11:16 | |
| *** tzn has quit IRC | 11:16 | |
| *** vgridnev_ has quit IRC | 11:16 | |
| trash | Cool, thanks for looking it up. | 11:16 |
| anteaya | BobBall: what project and can you link to the patch wtih NOT_REGISTERED? | 11:16 |
| *** esikachev has joined #openstack-infra | 11:17 | |
| *** asettle has quit IRC | 11:17 | |
| anteaya | BobBall: I know yolanda was updating the jjb jobs manually on at least one jenkins, not sure if this is related or not | 11:17 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/diskimage-builder: Install IPA in a virtual environment https://review.openstack.org/235843 | 11:17 |
| BobBall | 3rd party CI - https://review.openstack.org/#/c/279661/1 | 11:17 |
| anteaya | oh i see | 11:17 |
| anteaya | okay well our experience of not registered happens when the node the jenkins believes the test should run on and the node that zuul thinks the job should run on are mutually exclusive | 11:18 |
| *** vgridnev has quit IRC | 11:19 | |
| anteaya | do you run a xml diff test on your yaml files to ensure they are resulting in the xml you are expecting? | 11:19 |
| *** vgridnev has joined #openstack-infra | 11:19 | |
| BobBall | Yup; but where does zuul know about the node? I have the right node (ds-xen) in nodepool and jenkins_jobs but there is no reference to the node in zuul's layout.yaml afaict | 11:20 |
| *** hashar has quit IRC | 11:23 | |
| *** dims has joined #openstack-infra | 11:24 | |
| anteaya | there isn't that is true | 11:24 |
| anteaya | do you run anything like http://logs.openstack.org/60/280360/1/check/gate-project-config-compare-xml/b421787/console.html on your yaml files? | 11:24 |
| *** zeih has joined #openstack-infra | 11:25 | |
| *** vgridnev has quit IRC | 11:25 | |
| anteaya | this log tells us what assigned node the xml believes is correct: http://logs.openstack.org/60/280360/1/check/gate-project-config-compare-xml/b421787/console.html#_2016-02-15_19_02_28_287 | 11:25 |
| eantyshev | BobBall: Are you talking of 3rd-party CI? We see this problem when somehow Jenkins doesn't see required nodes. do you see "ds-xen" registered in your Jenkins? | 11:26 |
| anteaya | eantyshev: thank you | 11:26 |
| BobBall | eantyshev: yes | 11:26 |
| BobBall | eantyshev: to both | 11:26 |
| *** jlanoux has quit IRC | 11:27 | |
| BobBall | anteaya: And I've checked in jenkisn and the xml and the assignedNode is ds-xen in both cases. | 11:27 |
| eantyshev | Does this node have the tags which are set in JJB? | 11:27 |
| *** vgridnev has joined #openstack-infra | 11:27 | |
| *** sdague has joined #openstack-infra | 11:27 | |
| BobBall | Not sure what you mean by that eantyshev | 11:27 |
| *** jlanoux has joined #openstack-infra | 11:28 | |
| anteaya | BobBall: great thank you | 11:28 |
| *** achanda has joined #openstack-infra | 11:28 | |
| *** wznoinsk has joined #openstack-infra | 11:28 | |
| eantyshev | BobBall: node tags are constrains you specify in you jobs | 11:28 |
| wznoinsk | hi guys, I'm about to install downstream-ci/puppet as you call it | 11:29 |
| anteaya | so if the xml believes the assignedNode is ds-xen and ds-xen is registered in your Jenkins I'm at a loss as to what is causing the NOT_REGISTERED :( | 11:29 |
| *** ociuhandu has quit IRC | 11:29 | |
| eantyshev | anteaya, BobBall: AFAIU, node names are irrelevant, only tags matter | 11:29 |
| *** zeih has quit IRC | 11:30 | |
| *** tzn has joined #openstack-infra | 11:30 | |
| eantyshev | BobBall: tags = labels | 11:30 |
| eantyshev | sorry for misnaming them | 11:30 |
| wznoinsk | could you tell me that's the guide I should follow? : http://docs.openstack.org/infra/openstackci/third_party_ci.html | 11:30 |
| *** zeih has joined #openstack-infra | 11:30 | |
| *** piet has quit IRC | 11:31 | |
| BobBall | eantyshev: I don't see a "label" in any of the config files ? | 11:31 |
| wznoinsk | or is there any more recent guide I should follow? | 11:31 |
| BobBall | eantyshev: http://paste.openstack.org/show/487088/ is a reduced config | 11:31 |
| eantyshev | BobBall: what labels are there for "ds-xen" you see in Jenkins? | 11:31 |
| BobBall | eantyshev: the job dsvm-tempest-xen has "label expression" ds-xen and "Label is serviced by 2 nodes" comment (showing it matches up with the nodes created by nodepool) | 11:32 |
| eantyshev | BobBall: "ds-xen" is a label, true | 11:33 |
| eantyshev | wznoinsk: I don't remember anything more actual | 11:34 |
| *** achanda has quit IRC | 11:34 | |
| wznoinsk | eantyshev, thanks | 11:34 |
| *** esikachev has quit IRC | 11:34 | |
| *** esikachev has joined #openstack-infra | 11:35 | |
| *** d0ugal has quit IRC | 11:36 | |
| eantyshev | BobBall: "Label is serviced by 2 nodes" means "ds-xen"-named Jenkins node really has this label? | 11:36 |
| BobBall | yes eantyshev | 11:36 |
| BobBall | Slave ds-xen-rax-iad-772 (Dynamic single use ds-xen node) indeed has "Labels ds-xen" | 11:37 |
| eantyshev | BobBall: then AFAIU it should work, at least I have similar layout and it works | 11:38 |
| *** dims has quit IRC | 11:38 | |
| *** dizquierdo has joined #openstack-infra | 11:39 | |
| *** gibi has quit IRC | 11:39 | |
| *** gibi has joined #openstack-infra | 11:39 | |
| *** asettle has joined #openstack-infra | 11:39 | |
| *** sdague has quit IRC | 11:39 | |
| BobBall | yeah... I used to have a very similar setup working, but it got destroyed, and now I can't figure out the missing magic glue | 11:40 |
| *** 18VAAAIFD has quit IRC | 11:40 | |
| *** Douhet has quit IRC | 11:41 | |
| eantyshev | BobBall: have no thoughts, sorry :( | 11:43 |
| *** sambetts has quit IRC | 11:43 | |
| *** sdague has joined #openstack-infra | 11:44 | |
| *** ildikov_ has joined #openstack-infra | 11:44 | |
| *** sambetts has joined #openstack-infra | 11:44 | |
| *** fawadkhaliq has quit IRC | 11:45 | |
| *** fawadkhaliq has joined #openstack-infra | 11:45 | |
| *** fawadkhaliq has quit IRC | 11:46 | |
| *** Qiming has joined #openstack-infra | 11:46 | |
| *** fawadkhaliq has joined #openstack-infra | 11:46 | |
| *** fawadkhaliq has quit IRC | 11:47 | |
| *** fawadkhaliq has joined #openstack-infra | 11:47 | |
| *** jlanoux has quit IRC | 11:47 | |
| *** fawadkhaliq has quit IRC | 11:47 | |
| *** fawadkhaliq has joined #openstack-infra | 11:48 | |
| *** thorst has joined #openstack-infra | 11:52 | |
| openstackgerrit | Jesse Keating proposed openstack-infra/project-config: Add giftwrap to OpenStack https://review.openstack.org/280305 | 11:52 |
| *** Daisy has joined #openstack-infra | 11:54 | |
| anteaya | reed: have you a link to the etherpad with all the other links to the etherpads for the ops meetup? | 11:55 |
| anteaya | reed: I can't seem to find tom on irc | 11:55 |
| *** abregman is now known as abregman|brb | 11:56 | |
| AJaeger | sdague: your constraints change plus a fix for it merged and nova should be able to use it now for more jobs. | 11:57 |
| AJaeger | sdague: what should be done with other repos that are doing constraints already - or want to go there? | 11:57 |
| *** ildikov_ has quit IRC | 11:59 | |
| *** jlanoux has joined #openstack-infra | 11:59 | |
| *** thorst has quit IRC | 11:59 | |
| *** infra-re_ has joined #openstack-infra | 12:00 | |
| *** d0ugal has joined #openstack-infra | 12:00 | |
| *** d0ugal has quit IRC | 12:00 | |
| *** d0ugal has joined #openstack-infra | 12:00 | |
| *** Douhet has joined #openstack-infra | 12:01 | |
| *** Daisy has quit IRC | 12:01 | |
| *** dprince has joined #openstack-infra | 12:01 | |
| *** Daisy has joined #openstack-infra | 12:02 | |
| *** infra-red has quit IRC | 12:03 | |
| *** ociuhandu has joined #openstack-infra | 12:04 | |
| *** kzaitsev_mb has joined #openstack-infra | 12:05 | |
| *** sdake has quit IRC | 12:06 | |
| anteaya | reed: found it: https://etherpad.openstack.org/p/MAN-ops-meetup | 12:06 |
| *** fawadkhaliq has quit IRC | 12:06 | |
| *** fawadk has joined #openstack-infra | 12:06 | |
| *** sdake has joined #openstack-infra | 12:06 | |
| *** Qiming has quit IRC | 12:08 | |
| *** fawadk has quit IRC | 12:11 | |
| anteaya | the amount of folks putting their name in the etherpad for the ops meetup is impressive | 12:12 |
| *** Qiming has joined #openstack-infra | 12:12 | |
| anteaya | I made an announcement the first day asking them to do so and telling them the benefits and they are adding their names \o/ | 12:12 |
| *** ericksonsantos has joined #openstack-infra | 12:13 | |
| *** smarcet has joined #openstack-infra | 12:17 | |
| *** Qiming has quit IRC | 12:17 | |
| *** jcoufal has quit IRC | 12:17 | |
| *** zeih has quit IRC | 12:18 | |
| *** Jeffrey4l has quit IRC | 12:18 | |
| *** pcaruana has joined #openstack-infra | 12:18 | |
| *** asettle has quit IRC | 12:20 | |
| *** Daisy has quit IRC | 12:22 | |
| *** Daisy has joined #openstack-infra | 12:23 | |
| jlk | My projects review is failing a test, http://logs.openstack.org/05/280305/8/check/gate-project-config-layout/d5f8445/console.html and I think its "2016-02-16 12:12:22.078 | Job giftwrap-docs not defined" but I'm not sure. I'm also not sure how to define that, or if I need to. | 12:23 |
| AJaeger | jlk, let me check and comment... | 12:26 |
| *** Daisy has quit IRC | 12:27 | |
| sdague | jlk: I just commented on your governance change. I think you should just work on the project-config bits first and get the project off and running that way. | 12:28 |
| *** [HeOS] has joined #openstack-infra | 12:28 | |
| jlk | sdague: I've just replied, but the docs I've been following told me to get the governance merged first, as did AJaeger in my project-config review. | 12:29 |
| jlk | I'm just trying to follow the directions... | 12:29 |
| *** HeOS has quit IRC | 12:29 | |
| sdague | jlk: ok, which directions are these? | 12:29 |
| *** yamamoto has joined #openstack-infra | 12:30 | |
| sdague | there is also probably nuance missing in them | 12:30 |
| jlk | http://docs.openstack.org/infra/manual/creators.html#add-new-repository-to-the-governance-repository | 12:30 |
| *** Jeffrey4l has joined #openstack-infra | 12:31 | |
| *** achanda has joined #openstack-infra | 12:31 | |
| sdague | Adding a new top level effort under the big tent is still kind of a big process. And based on the last 6 months, needs a contribution history in the open. | 12:32 |
| *** tiswanso has joined #openstack-infra | 12:32 | |
| *** tiswanso has quit IRC | 12:33 | |
| jlk | is github "in the open" enough? | 12:33 |
| *** tiswanso has joined #openstack-infra | 12:34 | |
| sdague | no. In the open means "acts like openstack", so the review process, testing model, etc (in this context) | 12:34 |
| jlk | alright. | 12:34 |
| sdague | sorry, still caffinating, so words aren't always as clear as they should be | 12:34 |
| *** lucasagomes is now known as lucas-hungry | 12:35 | |
| jlk | What's not clear to me is how I enter the "do things in the open" phase. I'm only marginally distracted here at ops meet up, but I'll do whatever we need to do, I just need to know how to do it. | 12:35 |
| yolanda | hi AJaeger, i'm back. And jenkins07 is still building | 12:35 |
| * jlk is grabbing lunch | 12:35 | |
| yolanda | it should be nearly finished,it's removing old jobs. It seems that yesterday it didn't finish properly | 12:36 |
| AJaeger | jlk, talk with mordred or anteaya ;) | 12:36 |
| *** zeih has joined #openstack-infra | 12:36 | |
| AJaeger | yolanda: is there an ansible timeout it run into as well? This is strange ;( | 12:36 |
| sdague | jlk: my recommendation. Drop the governance change for now, get things imported into gerrit with project-config. Get the testing setup and working over there. Once that is all sorted and running, circle back around on goverance is that's your intent | 12:37 |
| *** achanda has quit IRC | 12:37 | |
| sdague | also, as I see mordred is proposing commits, he should also be able to advise, shephard here | 12:38 |
| sdague | jlk: also, that explains why you are awake :) | 12:38 |
| *** Daisy has joined #openstack-infra | 12:39 | |
| *** thiagop has joined #openstack-infra | 12:40 | |
| AJaeger | I agree with sdague. | 12:41 |
| *** andrey-mp has joined #openstack-infra | 12:41 | |
| jlk | I can do that. Was there some part of the docs that would have guided me through this? | 12:41 |
| jlk | I kind of feel like I fell into a trap :) | 12:41 |
| AJaeger | anteaya, can you sit together with jlk and review the Creator's Guide page - and see whether there's anything to improve? | 12:42 |
| *** Daisy has quit IRC | 12:43 | |
| *** rhallisey has joined #openstack-infra | 12:43 | |
| samueldmq | hi | 12:45 |
| samueldmq | I don't know if it's the rigth channel to ask, but someone here might know | 12:45 |
| samueldmq | is there a schedule already set for Newton midcycle? | 12:45 |
| *** abregman|brb is now known as abregman | 12:45 | |
| AJaeger | samueldmq: which project? | 12:46 |
| AJaeger | samueldmq: I haven't seen any project discussion a Newton midcycle yet... | 12:46 |
| samueldmq | AJaeger: there is a general schedule projects follow right ? I am talking about that | 12:47 |
| *** zeih has quit IRC | 12:48 | |
| *** baoli has joined #openstack-infra | 12:48 | |
| *** _sarob has joined #openstack-infra | 12:48 | |
| samueldmq | AJaeger: something like https://wiki.openstack.org/wiki/Liberty_Release_Schedule | 12:49 |
| *** weshay has joined #openstack-infra | 12:49 | |
| AJaeger | samueldmq: but that page has nothing to do with midcycles | 12:49 |
| AJaeger | samueldmq: Sorry, I cannot help you. | 12:49 |
| samueldmq | AJaeger: oh I said midcycle | 12:50 |
| samueldmq | AJaeger: I meant Newton cycle, not midcycle | 12:50 |
| samueldmq | AJaeger: sorry | 12:50 |
| *** thorst has joined #openstack-infra | 12:50 | |
| *** thorst_ has joined #openstack-infra | 12:51 | |
| openstackgerrit | Kanagaraj Manickam proposed openstack-infra/project-config: Adds new project os-namos https://review.openstack.org/280662 | 12:51 |
| *** gordc has joined #openstack-infra | 12:51 | |
| thorst_ | tonyb: Sorry - didn't see your q till now. The PowerVM channel is #openstack-powervm | 12:52 |
| AJaeger | samueldmq: ask on #openstack-release | 12:52 |
| *** ildikov has joined #openstack-infra | 12:52 | |
| *** baoli has quit IRC | 12:53 | |
| *** _sarob has quit IRC | 12:53 | |
| samueldmq | AJaeger: perfect, that should be the right place, thanks! | 12:53 |
| AJaeger | sdague: your nova change is broken, did you check the coverage and api changes? | 12:54 |
| sdague | AJaeger: ? it passed | 12:54 |
| sdague | oh, api-guide did not | 12:54 |
| AJaeger | sdague: and you changed the coverage job that you did not test | 12:55 |
| *** zeih has joined #openstack-infra | 12:55 | |
| sdague | right | 12:55 |
| *** thorst has quit IRC | 12:55 | |
| *** weshay has quit IRC | 12:55 | |
| AJaeger | sdague: what should be done with other repos that are doing constraints already - or want to go there? | 12:55 |
| *** dtardivel has joined #openstack-infra | 12:56 | |
| AJaeger | sdague: one example https://review.openstack.org/261982 | 12:56 |
| AJaeger | sdague: but there's also glance, neutron that are playing with constraints - or have gone there | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Support GitHub PR webhooks https://review.openstack.org/163117 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Make the string representation of change transparent https://review.openstack.org/238948 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Lower the log level in tests https://review.openstack.org/263364 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Merge pull requests from github reporter https://review.openstack.org/243250 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Encapsulate determining the event purpose https://review.openstack.org/247487 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Fix job hierarchy bug. https://review.openstack.org/192457 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: support github pull reqeust labels https://review.openstack.org/247421 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Add 'push' and 'tag' github webhook events. https://review.openstack.org/191207 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Add 'pr-comment' github webhook event https://review.openstack.org/239203 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Support for dependent pipelines with github https://review.openstack.org/247500 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Configurable SSH access to GitHub https://review.openstack.org/239138 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Allow github trigger to match on branches/refs https://review.openstack.org/258448 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Allow using webapp from connections https://review.openstack.org/215642 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Allow list values in template parameters. https://review.openstack.org/191208 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Add basic Github Zuul Reporter. https://review.openstack.org/191312 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Support for github commit status https://review.openstack.org/239303 | 12:56 |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Better merge message for GitHub pull reqeusts https://review.openstack.org/280667 | 12:56 |
| *** boris-42 has joined #openstack-infra | 12:56 | |
| *** rlandy has joined #openstack-infra | 12:57 | |
| sdague | AJaeger: honestly, I was not solving up for fixing the universe here | 12:57 |
| *** weshay has joined #openstack-infra | 12:58 | |
| * AJaeger had hoped so ;) | 12:58 | |
| AJaeger | could you at least write a short email, pointing to your nova change, to explain what projects can do? | 12:58 |
| sdague | once it works | 12:58 |
| AJaeger | ;) | 12:59 |
| sdague | or I'll nudge lifeless to, as this was really part of his larger constraints effort | 12:59 |
| jlk | AJaeger: your comment cut off. "To fix your problem,add" and nothing else. | 12:59 |
| jlk | https://review.openstack.org/#/c/280305/8/jenkins/jobs/projects.yaml@1708 | 13:00 |
| yolanda | AJaeger, jenkins07 finished | 13:00 |
| *** |-paul-| has quit IRC | 13:00 | |
| AJaeger | yippie, yolanda ! | 13:00 |
| yolanda | i reenabled puppet on it | 13:00 |
| AJaeger | jlk: I forgot to delete that part of the sentence, ignore it. The fix is on the next file... | 13:01 |
| AJaeger | thanks, yolanda | 13:01 |
| jlk | okay | 13:01 |
| yolanda | no problem | 13:01 |
| AJaeger | sdague: yes, asking lifeless and Nakato (?) is another option | 13:02 |
| *** edmondsw has joined #openstack-infra | 13:03 | |
| *** ihrachys has quit IRC | 13:04 | |
| *** julim has joined #openstack-infra | 13:05 | |
| *** vgridnev has quit IRC | 13:05 | |
| *** zhurong has joined #openstack-infra | 13:05 | |
| *** dizquierdo has quit IRC | 13:07 | |
| *** dkranz has joined #openstack-infra | 13:08 | |
| *** ihrachys has joined #openstack-infra | 13:08 | |
| *** vgridnev has joined #openstack-infra | 13:10 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder: Add force-confdef in debian package install https://review.openstack.org/280682 | 13:10 |
| openstackgerrit | Stephen Gordon proposed openstack-infra/project-config: Skip magnum functional test jobs on docs changes https://review.openstack.org/277892 | 13:11 |
| *** doug-fish has joined #openstack-infra | 13:14 | |
| *** ildikov has quit IRC | 13:18 | |
| *** ddieterly has joined #openstack-infra | 13:18 | |
| openstackgerrit | Jan Hruban proposed openstack-infra/zuul: Better merge message for GitHub pull reqeusts https://review.openstack.org/280667 | 13:19 |
| *** tiswanso has quit IRC | 13:19 | |
| *** tiswanso has joined #openstack-infra | 13:20 | |
| *** KanagarajM has quit IRC | 13:21 | |
| andrey-mp | Hello! | 13:22 |
| andrey-mp | Could anybody help us with https://review.openstack.org/#/c/279511/ ? | 13:22 |
| *** [1]Thelo has joined #openstack-infra | 13:22 | |
| *** Thelo has quit IRC | 13:24 | |
| *** [1]Thelo is now known as Thelo | 13:24 | |
| andrey-mp | we want to separate Refstack releases from development | 13:25 |
| *** zeih has quit IRC | 13:25 | |
| mordred | andrey-mp: can I make a suggestion to achieve your goal differently? | 13:25 |
| andrey-mp | yeah | 13:26 |
| smarcet | fungi: morning, seems that openstackid production deployment is stuck since yesterday http://puppetboard.openstack.org/node/openstackid.org | 13:26 |
| smarcet | dont know why | 13:26 |
| smarcet | please advice | 13:26 |
| mordred | andrey-mp: instead of putting version to deploy into the puppet - why not start making pypi releases from tags and set the puppet to install latest from pypi? | 13:26 |
| mordred | andrey-mp: that way you do not need to get an infra patch approved to bump a release | 13:26 |
| mordred | you only have to make the tag on the refstack repo | 13:27 |
| openstackgerrit | Jesse Keating proposed openstack-infra/project-config: Add giftwrap to OpenStack https://review.openstack.org/280305 | 13:27 |
| mordred | but you can still make multiple commits into the refstack repo without having them deploy immediately | 13:27 |
| *** lucas-hungry is now known as lucasagomes | 13:27 | |
| andrey-mp | mordred: sure, this is a better way. I think that we will do it. But I think that it will be not so fast... | 13:29 |
| *** Aegil has joined #openstack-infra | 13:30 | |
| andrey-mp | mordred: is it possible to add pypi jobs to refstack and after merge this patch infrastructure will build ppi package? or we will need one more tag? | 13:30 |
| mordred | cool. I'm fine with the patch you have right now - I mostly just think you'll get annoying having to get +2s every time you want to release - so figured I'd suggest a way for you to not need them | 13:30 |
| *** vgridnev has quit IRC | 13:30 | |
| *** vgridnev has joined #openstack-infra | 13:31 | |
| mordred | andrey-mp: infra will only upload new tags - but we could upload the current 1.0.0 tag by hand | 13:31 |
| andrey-mp | cool | 13:31 |
| pabelanger | yolanda: when you have free time, do you mind adding me to https://review.openstack.org/#/admin/groups/1284,members https://review.openstack.org/#/admin/groups/1285,members https://review.openstack.org/#/admin/groups/1291,members https://review.openstack.org/#/admin/groups/1292,members ? | 13:32 |
| *** salv-orl_ has quit IRC | 13:32 | |
| *** baoli has joined #openstack-infra | 13:32 | |
| andrey-mp | mordred: I think that we can start with this patch and after it we add pypi jobs to refstack. and after next release change puppet module to deploy from pypi | 13:33 |
| yolanda | hi pabelanger sure | 13:34 |
| *** ildikov has joined #openstack-infra | 13:34 | |
| mordred | andrey-mp: cool | 13:34 |
| *** doug-fish has quit IRC | 13:34 | |
| *** tiswanso has quit IRC | 13:35 | |
| *** thorst_ is now known as thorst | 13:35 | |
| andrey-mp | mordred: thank you for help! | 13:36 |
| *** salv-orlando has joined #openstack-infra | 13:36 | |
| *** zeih has joined #openstack-infra | 13:38 | |
| pabelanger | yolanda: danke | 13:38 |
| *** markvoelker has joined #openstack-infra | 13:39 | |
| *** piet has joined #openstack-infra | 13:39 | |
| *** jcoufal has joined #openstack-infra | 13:39 | |
| *** andrey-mp has left #openstack-infra | 13:40 | |
| yolanda | mordred, around? i'm running a test nodepool for infracloud, and i'm stuck at uploading the image to glance | 13:44 |
| yolanda | i have the image on dib, then i executed a nodepool image-upload infracloud ubuntu-trusty, but job seems to be stuck there, glance not even receiving any call to upload | 13:45 |
| *** dims has joined #openstack-infra | 13:45 | |
| *** smanjara has quit IRC | 13:46 | |
| *** dims has quit IRC | 13:51 | |
| *** hichihara has joined #openstack-infra | 13:51 | |
| *** HeOS_ has joined #openstack-infra | 13:52 | |
| *** [HeOS] has quit IRC | 13:54 | |
| *** yaume_ has joined #openstack-infra | 13:54 | |
| *** yaume has quit IRC | 13:57 | |
| *** edleafe has joined #openstack-infra | 13:59 | |
| *** SAshish has joined #openstack-infra | 13:59 | |
| SAshish | Hi.. Anybody there? | 14:00 |
| *** kgiusti has joined #openstack-infra | 14:00 | |
| *** zz_dimtruck is now known as dimtruck | 14:01 | |
| *** ddieterly has quit IRC | 14:01 | |
| openstackgerrit | Akihiro Motoki proposed openstack-infra/project-config: Translation job scripts support multiple python modules https://review.openstack.org/280711 | 14:02 |
| *** ddieterly has joined #openstack-infra | 14:02 | |
| *** claudiub has joined #openstack-infra | 14:02 | |
| *** doug-fish has joined #openstack-infra | 14:02 | |
| *** piet has quit IRC | 14:02 | |
| *** zhurong has quit IRC | 14:02 | |
| *** moravec has joined #openstack-infra | 14:03 | |
| BobBall | asselin_: Any chance you can help with a NOT_REGISTERED error that I can't figure out? | 14:03 |
| *** changbl has quit IRC | 14:04 | |
| *** amitgandhinz has joined #openstack-infra | 14:04 | |
| *** ddieterly has quit IRC | 14:06 | |
| *** zhurong has joined #openstack-infra | 14:08 | |
| *** salv-orlando has quit IRC | 14:08 | |
| *** kiran-r has quit IRC | 14:08 | |
| *** yaume_ has quit IRC | 14:08 | |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/infra-ansible: Create and attach other required openstack resources https://review.openstack.org/280561 | 14:09 |
| *** xyang1 has joined #openstack-infra | 14:09 | |
| *** alivigni has joined #openstack-infra | 14:09 | |
| *** yaume has joined #openstack-infra | 14:09 | |
| *** Guest76507 is now known as med_ | 14:12 | |
| *** med_ has quit IRC | 14:12 | |
| *** med_ has joined #openstack-infra | 14:12 | |
| *** yaume has quit IRC | 14:13 | |
| *** zhurong has quit IRC | 14:14 | |
| *** yaume has joined #openstack-infra | 14:14 | |
| *** MCoLo__ has quit IRC | 14:14 | |
| *** MCoLo has joined #openstack-infra | 14:15 | |
| *** jcoufal has quit IRC | 14:15 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/puppet-infracloud: Reduce mysql max-connections https://review.openstack.org/280720 | 14:15 |
| *** jaosorior has quit IRC | 14:16 | |
| *** asettle has joined #openstack-infra | 14:17 | |
| *** jaosorior has joined #openstack-infra | 14:17 | |
| *** yaume has quit IRC | 14:20 | |
| *** yaume has joined #openstack-infra | 14:21 | |
| *** annegentle has joined #openstack-infra | 14:24 | |
| *** yaume has quit IRC | 14:25 | |
| *** yaume has joined #openstack-infra | 14:26 | |
| *** regXboi has joined #openstack-infra | 14:26 | |
| *** eharney has quit IRC | 14:26 | |
| SAshish | Errors running git rebase -i remotes/gerrit/master error: could not apply 5062288... <my previous commit> When you have resolved this problem, run "git rebase --continue". If you prefer to skip this patch, run "git rebase --skip" instead. To check out the original branch and stop rebasing, run "git rebase --abort". Could not apply 5062288.. <my previous commit> | 14:26 |
| SAshish | hi all | 14:26 |
| SAshish | can anybody tell me | 14:27 |
| SAshish | how to fix gthis.. | 14:27 |
| *** zeih has quit IRC | 14:27 | |
| SAshish | I am struggling with this | 14:27 |
| SAshish | when I do git review it says this | 14:27 |
| *** SAshish has quit IRC | 14:27 | |
| *** smarcet has quit IRC | 14:28 | |
| *** wshao has joined #openstack-infra | 14:28 | |
| *** wshao has quit IRC | 14:28 | |
| *** wshao has joined #openstack-infra | 14:28 | |
| *** zeih has joined #openstack-infra | 14:29 | |
| *** ccrouch has joined #openstack-infra | 14:29 | |
| *** yaume has quit IRC | 14:30 | |
| *** tiswanso has joined #openstack-infra | 14:30 | |
| *** yaume has joined #openstack-infra | 14:31 | |
| BobBall | Awesome... Clearly SAshish didn't want an answer :) | 14:32 |
| *** mriedem_away has quit IRC | 14:32 | |
| *** amitgandhinz has quit IRC | 14:32 | |
| anteaya | I guess not | 14:32 |
| *** amitgandhinz has joined #openstack-infra | 14:33 | |
| anteaya | http://gitimmersion.com/ was what I was going to suggest as a way to build some foundational git skills | 14:33 |
| *** achanda has joined #openstack-infra | 14:35 | |
| *** zzzeek has joined #openstack-infra | 14:35 | |
| *** tiswanso has quit IRC | 14:35 | |
| *** yaume has quit IRC | 14:35 | |
| *** ildikov has quit IRC | 14:36 | |
| *** sabeen1 has joined #openstack-infra | 14:36 | |
| *** vgridnev has quit IRC | 14:37 | |
| *** hashar has joined #openstack-infra | 14:38 | |
| *** vgridnev has joined #openstack-infra | 14:38 | |
| *** sabeen3 has joined #openstack-infra | 14:39 | |
| *** achanda has quit IRC | 14:40 | |
| *** sabeen1 has quit IRC | 14:41 | |
| *** smarcet has joined #openstack-infra | 14:43 | |
| *** dimtruck is now known as zz_dimtruck | 14:44 | |
| *** HeOS has joined #openstack-infra | 14:45 | |
| *** vgridnev has quit IRC | 14:47 | |
| *** HeOS_ has quit IRC | 14:47 | |
| *** ildikov has joined #openstack-infra | 14:48 | |
| *** mdenny has quit IRC | 14:49 | |
| *** vgridnev has joined #openstack-infra | 14:49 | |
| *** piet has joined #openstack-infra | 14:50 | |
| *** vgridnev has quit IRC | 14:52 | |
| anteaya | ironic is using the conferencing system for their virtual sprint which just started | 14:52 |
| anteaya | so far so good I do believe | 14:53 |
| *** ihrachys has quit IRC | 14:53 | |
| *** pradk has joined #openstack-infra | 14:53 | |
| BobBall | asselin_: Sorry - my bad - ignore me. | 14:53 |
| anteaya | BobBall: did you figure out the issue? | 14:54 |
| *** vgridnev has joined #openstack-infra | 14:54 | |
| *** aarefiev has quit IRC | 14:54 | |
| openstackgerrit | Merged openstack-infra/subunit2sql: Add optional run_metadata filter to get_test_runs_by_test_test_id https://review.openstack.org/269950 | 14:54 |
| *** rbrndt_ has joined #openstack-infra | 14:55 | |
| BobBall | I had reinstalled jenkins and forgotten to re-follow part of the instructions. | 14:55 |
| *** mriedem has joined #openstack-infra | 14:55 | |
| *** aarefiev has joined #openstack-infra | 14:55 | |
| *** aarefiev has quit IRC | 14:55 | |
| *** nmagnezi has quit IRC | 14:55 | |
| *** aarefiev has joined #openstack-infra | 14:55 | |
| anteaya | BobBall: okay, glad you figured it out | 14:55 |
| *** thorst_ has joined #openstack-infra | 14:56 | |
| *** mtanino has joined #openstack-infra | 14:57 | |
| *** rossella_s has quit IRC | 14:57 | |
| *** coolsvap|away has quit IRC | 14:57 | |
| *** rossella_s has joined #openstack-infra | 14:58 | |
| *** haypo has left #openstack-infra | 14:59 | |
| openstackgerrit | Merged openstack-infra/project-config: Add giftwrap to OpenStack https://review.openstack.org/280305 | 14:59 |
| *** thorst has quit IRC | 14:59 | |
| *** zeih has quit IRC | 15:00 | |
| *** piet has quit IRC | 15:01 | |
| *** coolsvap|away has joined #openstack-infra | 15:01 | |
| *** wshao has quit IRC | 15:01 | |
| *** sfinucan has quit IRC | 15:01 | |
| fungi | smarcet: it's hard to tell what happened to the deployment, because update-site output is so verbose it overruns rsyslog (imuxsock begins to drop messages from pid [...] due to rate-limiting) and so i can't see all of the output from it | 15:03 |
| fungi | smarcet: i have a feeling it's failing somewhere in the update-site exec, but i'll need to run it by hand to find out what's going on | 15:04 |
| *** tiswanso has joined #openstack-infra | 15:05 | |
| fungi | hopefully i can find a few minutes to try that during my next meeting | 15:05 |
| fungi | er, i mean after my next meeting | 15:05 |
| *** wolverineav has joined #openstack-infra | 15:10 | |
| *** gongysh has quit IRC | 15:11 | |
| *** slogan621 has joined #openstack-infra | 15:12 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:13 | |
| *** wolverineav has quit IRC | 15:15 | |
| slogan621 | clarkb: https://review.openstack.org/#/c/275873 has two +2, what is next? | 15:16 |
| *** mkoderer__ has quit IRC | 15:16 | |
| *** bhunter_ has joined #openstack-infra | 15:17 | |
| *** mkoderer__ has joined #openstack-infra | 15:17 | |
| mordred | fungi: I'm in opposite-side-street land and likely may not be at today's meeting | 15:17 |
| *** vgridnev_ has joined #openstack-infra | 15:17 | |
| *** zz_dimtruck is now known as dimtruck | 15:18 | |
| fungi | mordred: or attend from the pub! | 15:19 |
| mordred | fungi: well, I | 15:19 |
| mordred | fungi: I'm attending irc from a nice bar right now | 15:19 |
| fungi | bully | 15:19 |
| mordred | fungi: so I _might_ be at the meeting - but I might not | 15:20 |
| mordred | fungi: and mostly just wanted to let you know priorities :) | 15:20 |
| fungi | this is the state of the world, yes. thanks for the heads up! | 15:20 |
| *** vgridnev has quit IRC | 15:21 | |
| *** Liuqing has quit IRC | 15:21 | |
| *** piet has joined #openstack-infra | 15:22 | |
| *** Liuqing has joined #openstack-infra | 15:22 | |
| *** Liuqing has quit IRC | 15:22 | |
| AJaeger | mordred: we hear you that a British beer is more important ;) | 15:23 |
| AJaeger | mordred: drink one on us ;) | 15:23 |
| *** hichihara has quit IRC | 15:24 | |
| *** tongli has joined #openstack-infra | 15:25 | |
| *** piet has quit IRC | 15:25 | |
| *** _ody_ is now known as _ody | 15:26 | |
| *** sshnaidm has quit IRC | 15:26 | |
| AJaeger | slogan621: you ask here to get added to the ACL group - an infra-root can do this for you. And then you can submit changes and add more core reviewers | 15:28 |
| *** bpokorny has joined #openstack-infra | 15:29 | |
| *** bpokorny has quit IRC | 15:30 | |
| JayF | Is there any way to see statistics on an infra Asterisk conference? i.e. number of people in a conference; sip usernames of people in, etc | 15:30 |
| *** vgridnev_ has quit IRC | 15:32 | |
| *** eharney has joined #openstack-infra | 15:32 | |
| slogan621 | AJaeger: ok | 15:32 |
| *** vgridnev has joined #openstack-infra | 15:32 | |
| *** EricGonczer_ has joined #openstack-infra | 15:33 | |
| slogan621 | AJaeger: I don't recall reading about ACL in the project creator's docs, is this something I need to understand or should I just ask? I was under the impression that once the project got 2 core reviews then it would just get created. | 15:33 |
| *** fawadkhaliq has joined #openstack-infra | 15:34 | |
| *** fawadkhaliq has quit IRC | 15:34 | |
| *** dprince has quit IRC | 15:35 | |
| *** fawadkhaliq has joined #openstack-infra | 15:35 | |
| jlk | ohai. My project-config review merged, now I need to ask you to add me to some new groups | 15:36 |
| *** smarcet has quit IRC | 15:36 | |
| jlk | can I be added to "giftwrap-release" and "giftwrap-core" ? | 15:36 |
| *** yamahata has joined #openstack-infra | 15:36 | |
| jlk | or show me how to request this through a review? | 15:37 |
| pabelanger | fungi: do you happen to know if any projects that are open to testing bindep jobs? I mean, I can continue on nova or pick some other random project, but figured I'd ask first | 15:37 |
| pabelanger | jlk: usually asking here or -infra ML works | 15:38 |
| *** dizquierdo has joined #openstack-infra | 15:38 | |
| pabelanger | since it is a manual process | 15:38 |
| jlk | alright | 15:38 |
| jlk | So I'd like to have myself added to those two groups, and I'd like to add Craig Tracey to giftwrap-core | 15:39 |
| *** jlanoux has quit IRC | 15:39 | |
| pabelanger | jlk: I actually looked at giftwrap over the weekend. Curious if you've looked a delorean before? | 15:39 |
| *** sshnaidm has joined #openstack-infra | 15:39 | |
| jlk | briefly, but it's been a while | 15:39 |
| *** ajmiller has joined #openstack-infra | 15:39 | |
| pabelanger | If I understand, they look to do the same idea | 15:40 |
| pabelanger | I am sure there are some differences | 15:40 |
| AJaeger | slogan621: the patch merged and your project is created. | 15:40 |
| *** salv-orl_ has joined #openstack-infra | 15:40 | |
| *** salv-orl_ has quit IRC | 15:40 | |
| jlk | yeah, giftwrap doesn't do the yum part, but it can make RPMs. And Docker. | 15:40 |
| slogan621 | AJaeger: oh :-) | 15:41 |
| *** salv-orlando has joined #openstack-infra | 15:41 | |
| *** asettle has quit IRC | 15:41 | |
| AJaeger | slogan621: http://docs.openstack.org/infra/manual/creators.html#wait-here and you moved on to http://docs.openstack.org/infra/manual/creators.html#update-the-gerrit-group-members | 15:41 |
| AJaeger | http://git.openstack.org/cgit/openstack/broadview-lib | 15:42 |
| AJaeger | slogan621: your change says " Merged" | 15:42 |
| *** smarcet has joined #openstack-infra | 15:42 | |
| slogan621 | sweet. And I see something on github. | 15:42 |
| slogan621 | thanks! | 15:42 |
| AJaeger | jlk: you get added and then can add anybody else... | 15:43 |
| jlk | AJaeger: perfect. | 15:43 |
| AJaeger | jlk, slogan621: Both of you need to wait for a gerrit admin to do it - pabelanger and myself can't help further | 15:43 |
| fungi | pabelanger: i've already uploaded a change to create experimental bindep jobs on 14 more projects. lemme see if that merged yet | 15:44 |
| *** sfinucan has joined #openstack-infra | 15:44 | |
| fungi | pabelanger: added about half a dozen different bindep-using job equivalents from the python-jobs group too | 15:44 |
| fungi | pabelanger: 278798 but looks like it hasn't merged yet because nobody has approved its parent change 278793 | 15:45 |
| pabelanger | fungi: okay, but if I understand bindep. Each project should create a other-requirements.txt file too? | 15:45 |
| AJaeger | fungi: hasn't merged... | 15:45 |
| *** jcoufal has joined #openstack-infra | 15:45 | |
| fungi | pabelanger: it's optional. if they don't then the jobs run with the bindep fallback list from project-config | 15:45 |
| fungi | which should closely emulate a bare-trusty or whatever worker | 15:46 |
| pabelanger | fungi: great | 15:46 |
| fungi | pabelanger: the only reason i had one proposed in a do-not-merge change to nova is so that i could make sure the machinery properly used project-specific other-requirements.txt files when present | 15:47 |
| pabelanger | fungi: sure. Do you have an use case in mind when a project would use other-requirements.txt? | 15:47 |
| fungi | pabelanger: when they want to start using bindep the way it's intended (to indicate what distro-supplied packages are necessary for installing or testing their project) | 15:48 |
| jlk | pabelanger: One thing I'm not sure I'm seeing in delorean, the ability to specify pre/post extras to install into the venv, which is kind of important sometimes. | 15:48 |
| clarkb | yolanda ajaeger I dont think puppet runs are running over each other, but we could add a lockfile if that is the case | 15:48 |
| clarkb | 07 was fine when I left it yesterday | 15:48 |
| *** nmagnezi has joined #openstack-infra | 15:49 | |
| fungi | pabelanger: it also allows them to avoid installing packages that we would otherwise install by default during the course of a job | 15:49 |
| AJaeger | clarkb: the corrupted caches really surprised us... | 15:49 |
| AJaeger | clarkb: but 07 did not have the latest gate-nova-pep8, it missed the change for the if. | 15:49 |
| clarkb | AJaeger: I am fairly sure I updated it, maybe there is a bug in jjb? | 15:50 |
| AJaeger | clarkb: I have no idea what broke, but this was much more painfull than I remember | 15:50 |
| AJaeger | clarkb: regarding update: Might also have been old sources? | 15:50 |
| clarkb | AJaeger: ya maybe I ran it before puppet could update it | 15:51 |
| pabelanger | jlk: Ya, I could be wrong, but I believe the main thing delorean does, is expects all dependencies to be packaged. So, if something needs to be installed into the venv, then it should also likely be a package. | 15:51 |
| AJaeger | clarkb: best ask yolanda whether she has any more insights | 15:51 |
| pabelanger | jlk: but, don't quote me on that, still a new user of it. RDO is really driving it | 15:51 |
| jeblair | 17:35 < yolanda> as this can cause potential problems, such as jenkins trying to run jobs on projects that don't exist, or the one i hit with image builds, i think is important to reenable | 15:51 |
| jeblair | 17:35 < pabelanger> AJaeger: Yup, I just think puppet-gerrit was over looked, since we stop it for renames. The emergency fix jeblair was working on, that's the first time I seen us run out of inodes. What should likely happen, just thoughts after the fact, create / update the emergency server maintenance docs, and always add host to ansible emergency list. Then you 100% know nothing with | 15:51 |
| jeblair | canwge while you are working | 15:51 |
| pabelanger | fungi: okay, that's what I figured | 15:52 |
| jlk | pabelanger: well, I'm not sure that delorean does anything with a virtualenv | 15:53 |
| pabelanger | JayF: There is, we could pipe the data into grafana.o.o via statsd. Haven't done the work yet. | 15:53 |
| * AJaeger will be back later... | 15:53 | |
| pabelanger | JayF: maybe a friday afternoon hack | 15:53 |
| jlk | a python virtualenv. That's the main thing that giftwrap does, all the python bits are installed (via pip) into a virtualenv, and that virtualenv tree is what's wrapped into a package. | 15:53 |
| JayF | pabelanger: I meant more realtime :) | 15:53 |
| JayF | pabelanger: but no is an okay answer :) | 15:53 |
| *** infra-re_ has quit IRC | 15:53 | |
| pabelanger | JayF: yes it call be realtime | 15:53 |
| pabelanger | JayF: simple way would be to use starpy to connect to AMI, then dump info to statsd | 15:54 |
| JayF | pabelanger: it's fine; I was asking more from the perspective of someone trying to find out info about a mid-cycle that's asking right now :P | 15:54 |
| pabelanger | jlk: Right, and I think the main thing for delorean is to packaging everything and remove the dependency on pip | 15:55 |
| pabelanger | JayF: well, I could manually do it. | 15:55 |
| pabelanger | JayF: what do you want / need to know | 15:55 |
| fungi | JayF: any performance issues on the bridge? | 15:55 |
| JayF | fungi: not afaict | 15:55 |
| fungi | awesome | 15:55 |
| JayF | pabelanger: it's not a big deal :) just wanted to make sure there wasn't some sweet dashboard somewhere we were missing out on (we were all speculating at the time how many people were on the call) | 15:56 |
| *** kozhukal` has joined #openstack-infra | 15:56 | |
| *** changbl has joined #openstack-infra | 15:56 | |
| jlk | pabelanger: definitely different use cases | 15:57 |
| pabelanger | well, aside from the fact somebody is trying to brute force the asterisk server. Looks to be 33 people on the server ATM | 15:57 |
| *** kozhukalov has quit IRC | 15:57 | |
| pabelanger | guess we should install fail2ban | 15:58 |
| jeblair | pabelanger: they're trying to brute force passwords; they won't get far. | 15:58 |
| pabelanger | JayF: nope, but going to hack on it now :) | 15:59 |
| JayF | :) | 15:59 |
| jeblair | what's the call? | 15:59 |
| *** kzaitsev_mb has quit IRC | 15:59 | |
| pabelanger | jeblair: indeed, since we allow anonymous users to connect | 15:59 |
| JayF | jeblair: Ironic virtual mid-cycle meetup. https://etherpad.openstack.org/p/ironic-mitaka-midcycle | 15:59 |
| jlk | oh hey, is jeblair elevated enough to add my user to gerrit? | 15:59 |
| jeblair | jlk: whatcha need? | 16:00 |
| jlk | jeblair: myself added to giftwrap-release and giftwrap-core | 16:00 |
| jeblair | jlk: done! | 16:00 |
| *** ddecapit has joined #openstack-infra | 16:01 | |
| *** baoli has quit IRC | 16:01 | |
| *** ddecapit is now known as DuaneDeC7 | 16:02 | |
| jlk | sweet | 16:02 |
| *** salv-orl_ has joined #openstack-infra | 16:02 | |
| *** esikachev has quit IRC | 16:03 | |
| *** baoli has joined #openstack-infra | 16:03 | |
| *** dkranz has quit IRC | 16:03 | |
| *** dkranz has joined #openstack-infra | 16:04 | |
| slogan621 | AJaeger: so, the gerrit-group members would be the developers listed here: https://launchpad.net/~broadview-drivers/+members#active? | 16:04 |
| mugsie | a/win 53 | 16:04 |
| *** salv-orlando has quit IRC | 16:05 | |
| jlk | jeblair: thanks. Now how do I manage adding other people to -core ? | 16:05 |
| jeblair | jlk: with the menu at the top: People -> List Groups -> Filter: giftwrap -> click on the group | 16:06 |
| jlk | jeblair: top of gerrit? | 16:07 |
| *** EricGonczer_ has quit IRC | 16:07 | |
| jeblair | jlk: yep | 16:08 |
| jeblair | jlk: should ultimately get you to this page: https://review.openstack.org/#/admin/groups/1293,members | 16:08 |
| fungi | pabelanger: if the concern is over people trying to brute-force ssh passwords on the pbx server, it can just be ignored. we have password logins entirely disabled in ssh | 16:08 |
| slogan621 | AJaeger: it appears you need just one, if so, please add volodymyr.samotiy@axilera.com (sorry if I am going about this in the wrong way). | 16:09 |
| pabelanger | fungi: no, this was via SIP. | 16:09 |
| pabelanger | fungi: eg: trying to register an extension, so they can try to make long distance calls | 16:10 |
| Clint | yeah, fail2ban is good for that | 16:10 |
| pabelanger | yup | 16:10 |
| fungi | pabelanger: oh, fun! | 16:10 |
| * fungi misses the days of hackable telephony networks | 16:10 | |
| pabelanger | ya, not concerned | 16:11 |
| jlk | jeblair: neat, thanks! | 16:11 |
| pabelanger | pretty sure we don't even have outbound setup | 16:11 |
| *** DuaneDeC7 has quit IRC | 16:12 | |
| slogan621 | how can I view who is in the ACL list for my project? | 16:12 |
| *** rbrndt_ has quit IRC | 16:13 | |
| fungi | slogan621: follow the directions jeblair just gave jlk above | 16:13 |
| fungi | but of course type in your project name instead of giftwrap | 16:13 |
| *** kozhukal` has quit IRC | 16:13 | |
| openstackgerrit | Matthew Treinish proposed openstack-infra/shade: Add a method to download an image from glance https://review.openstack.org/278816 | 16:14 |
| mtreinish | SpamapS: ^^^ that should address your concerns | 16:14 |
| *** rbrndt_ has joined #openstack-infra | 16:15 | |
| fungi | slogan621: i suppose http://docs.openstack.org/infra/manual/creators.html#update-the-gerrit-group-members would be a good place to add a couple sentences about that. doing now | 16:16 |
| slogan621 | ah | 16:16 |
| *** EricGonczer_ has joined #openstack-infra | 16:16 | |
| slogan621 | jeblair: are you available to add me to broadview-lib-core and broadview-lib-release? | 16:17 |
| slogan621 | fungi: yep, sounds like a great idea | 16:17 |
| * slogan621 sees the fog clear a bit | 16:17 | |
| *** pcaruana has quit IRC | 16:18 | |
| jeblair | slogan621: done! | 16:18 |
| slogan621 | oh, oops :-) wrong user, I'm actually syd.logan@broadcom.com - I suppose I can authenticate as the other user and add myself now, right? | 16:20 |
| *** EricGonczer_ has quit IRC | 16:20 | |
| openstackgerrit | Jesse Keating proposed openstack-infra/project-config: Announce giftwrap gerret into our channel. https://review.openstack.org/280797 | 16:23 |
| openstackgerrit | Vincent Françoise proposed openstack-infra/project-config: Watcher multinode Tempest job fixup https://review.openstack.org/277923 | 16:24 |
| *** sshnaidm has quit IRC | 16:25 | |
| jeblair | slogan621: i switched them | 16:25 |
| fungi | smarcet: wow, no wonder this overran rsyslog's rate-limiter. about 8k lines into the update output, i have a node.js exception in bower-config | 16:26 |
| jeblair | slogan621: your bcom aaccount is added now | 16:26 |
| fungi | smarcet: paste coming in a moment | 16:26 |
| *** jpr has joined #openstack-infra | 16:26 | |
| slogan621 | jeblair: awesome. I'll now add the other project members myself | 16:27 |
| fungi | smarcet: http://paste.openstack.org/show/487139/ | 16:27 |
| *** jlanoux has joined #openstack-infra | 16:28 | |
| *** _nadya_ has quit IRC | 16:28 | |
| fungi | smarcet: if you want the full deploy.sh log, i'll have to copy it somewhere for you to retrieve. it's many times too long to be able to post to paste.openstack.org | 16:28 |
| fungi | smarcet: separately, it may be better to redirect or silence most of the output from that script | 16:29 |
| fungi | so that what ends up in syslog is useful | 16:29 |
| *** tiswanso has quit IRC | 16:31 | |
| *** sdague has quit IRC | 16:31 | |
| *** esikachev has joined #openstack-infra | 16:32 | |
| *** Swami has joined #openstack-infra | 16:32 | |
| *** tiswanso has joined #openstack-infra | 16:32 | |
| *** smarcet has quit IRC | 16:33 | |
| *** boris-42 has quit IRC | 16:34 | |
| *** sputnik13 has joined #openstack-infra | 16:34 | |
| *** sdague has joined #openstack-infra | 16:34 | |
| *** sabeen3 has quit IRC | 16:35 | |
| *** jcoufal has quit IRC | 16:35 | |
| *** slogan621 has quit IRC | 16:35 | |
| pabelanger | So, I was thinking about this last night, if I wanted to use DIBs in the gate, loaded into devstack, I sure I could. But is there any projects doing this today? I mean, could a periodic job be created to create a DIB, which is stored on static.o.o to then be used by a job? | 16:37 |
| *** sputnik13 has quit IRC | 16:37 | |
| greghaynes | pabelanger: the issue is that you would be qemu booting | 16:37 |
| greghaynes | pabelanger: so the perf is extremely slow | 16:37 |
| greghaynes | pabelanger: but, nodepool func testing does this | 16:37 |
| *** rcernin has quit IRC | 16:37 | |
| pabelanger | greghaynes: Right, I would expect some perf issues | 16:38 |
| openstackgerrit | Pierre Mathieu proposed openstack-infra/project-config: Creation of a dedicated repo for API and media storage client https://review.openstack.org/255349 | 16:38 |
| *** achanda has joined #openstack-infra | 16:38 | |
| pabelanger | another option would be 3rd party CI for baremetal provisioning | 16:38 |
| *** armax has joined #openstack-infra | 16:38 | |
| *** placko_ has quit IRC | 16:41 | |
| *** placko_ has joined #openstack-infra | 16:41 | |
| clarkb | pabelanger: yes the nodepool dsvm tests do this today | 16:42 |
| openstackgerrit | Jeremy Stanley proposed openstack-infra/puppet-openstackid: Put /usr/local/bin first in paths https://review.openstack.org/280810 | 16:42 |
| clarkb | they build one image, upload it to devstack, then boot a VM off of that image | 16:42 |
| fungi | smarcet: ^ | 16:42 |
| *** sridhar_ram has joined #openstack-infra | 16:42 | |
| pabelanger | clarkb: but each patchset is creating an image right? | 16:43 |
| *** annegent_ has joined #openstack-infra | 16:43 | |
| *** placko_ has quit IRC | 16:43 | |
| *** achanda has quit IRC | 16:44 | |
| *** EricGonczer_ has joined #openstack-infra | 16:44 | |
| clarkb | pabelanger: yes | 16:44 |
| fungi | infra-puppet-core reviewers, https://review.openstack.org/280810 addresses a deployment issue on openstackid.org (incorrect path order in a couple of execs) | 16:45 |
| *** baoli has quit IRC | 16:45 | |
| pabelanger | clarkb: So, if I wanted the image build to happen outside of the patchset, maybe a periodic job. Could that dib be hosted on some infra FS to be used later? Trying to see if it is worth the time and energy to just build the DIB each time or externalize it | 16:46 |
| *** baoli has joined #openstack-infra | 16:46 | |
| pabelanger | having AFS mirrors help with build times now | 16:46 |
| *** annegentle has quit IRC | 16:46 | |
| *** ajmiller has quit IRC | 16:47 | |
| *** annegent_ has quit IRC | 16:48 | |
| greghaynes | pabelanger: whats the purpose? | 16:48 |
| greghaynes | pabelanger: or goal | 16:48 |
| *** smarcet has joined #openstack-infra | 16:48 | |
| electrofelix | Anyone here able to help out with a summit talk going astray? Who should I be talking to about finding out what happened and how to get it fixed? | 16:49 |
| *** esikachev has quit IRC | 16:49 | |
| *** vgridnev has quit IRC | 16:49 | |
| *** zeih has joined #openstack-infra | 16:49 | |
| smarcet | fungi: ok thx for the info and support :) | 16:50 |
| jeblair | pabelanger: yes, periodic jobs can upload artifacts to tarballs.o.o that can then be fetched later. it would be better if we put that into afs so it can be fetched locally. | 16:50 |
| *** tzn has quit IRC | 16:50 | |
| pabelanger | greghaynes: mostly for some ansible testing. Our devstack DIBs work fine, but there are some trivial things installed that I wanted to remove. Right now considering adding a pre_tasks to just purge them, but also thought about a using a ubuntu-minimal dib with just SSH keys. | 16:50 |
| openstackgerrit | Craig Vyvial proposed openstack-infra/project-config: run trove experimental run scenario tests https://review.openstack.org/278095 | 16:51 |
| *** tphummel has joined #openstack-infra | 16:51 | |
| pabelanger | greghaynes: nothing super important, just brainstorming | 16:51 |
| pabelanger | jeblair: Right, AFS would like be better. | 16:51 |
| pabelanger | either way, just something I am thinking about | 16:51 |
| *** HeOS has quit IRC | 16:52 | |
| *** DuaneDeC7 has joined #openstack-infra | 16:52 | |
| *** HeOS has joined #openstack-infra | 16:52 | |
| fungi | pabelanger: ironic-python-agent does this, i believe | 16:52 |
| pabelanger | fungi: cool, will check it out | 16:52 |
| fungi | pabelanger: they build updated test images in the post pipeline iirc, and stash them on tarballs.o.o | 16:53 |
| fungi | and then use them in subsequent jobs | 16:53 |
| *** eharney has quit IRC | 16:53 | |
| *** vincentfrancoise has joined #openstack-infra | 16:53 | |
| *** mikelk has quit IRC | 16:53 | |
| fungi | pabelanger: they build https://tarballs.openstack.org/ironic-python-agent/coreos/ | 16:54 |
| fungi | pabelanger: i think at least one other project does something similar, though i don't recall which at the moment | 16:54 |
| pabelanger | Right, I figured other projects were doing it, just couldn't remember which ones. Will google around | 16:56 |
| *** matrohon has quit IRC | 16:57 | |
| *** kzaitsev_mb has joined #openstack-infra | 16:58 | |
| pleia2 | good morning | 16:59 |
| *** madhu_ak has joined #openstack-infra | 17:00 | |
| *** sabeen has joined #openstack-infra | 17:01 | |
| openstackgerrit | Jeremy Stanley proposed openstack-infra/infra-manual: Add URL for Gerrit group self-management https://review.openstack.org/280823 | 17:02 |
| *** asselin has quit IRC | 17:03 | |
| *** sabeen3 has joined #openstack-infra | 17:04 | |
| *** e0ne has quit IRC | 17:04 | |
| *** dprince has joined #openstack-infra | 17:04 | |
| fungi | something's going down in rax-ord... lots of nodes piling up in delete state there | 17:05 |
| *** madhu_ak has quit IRC | 17:05 | |
| fungi | oh, in rax-dfw too actually, just not rax-iad (yet anyway) | 17:05 |
| *** sabeen has quit IRC | 17:05 | |
| *** gyee has joined #openstack-infra | 17:05 | |
| fungi | also, any word from the tripleo crowd on whether or not they're going to fix their keystone config? | 17:06 |
| *** apoorvad has joined #openstack-infra | 17:07 | |
| *** apoorvad has quit IRC | 17:08 | |
| openstackgerrit | Jordan Pittier proposed openstack-infra/elastic-recheck: Add query for Heat booting a VM on a network w/o subnet https://review.openstack.org/280824 | 17:08 |
| mgagne | clarkb: found the cause of my issue with change stuck in gate pipeline in Zuul status interface | 17:09 |
| *** eharney has joined #openstack-infra | 17:09 | |
| *** vincentfrancoise has quit IRC | 17:09 | |
| *** rcernin has joined #openstack-infra | 17:09 | |
| mgagne | clarkb: it was a bad Gerrit URL in the config. URL didn't return 404 but "00000020ERR Git repository not found" in the body. | 17:09 |
| *** shashank_hegde has joined #openstack-infra | 17:10 | |
| *** apoorvad has joined #openstack-infra | 17:10 | |
| *** asselin has joined #openstack-infra | 17:10 | |
| *** annegentle has joined #openstack-infra | 17:10 | |
| *** d0ugal has quit IRC | 17:11 | |
| openstackgerrit | James E. Blair proposed openstack-infra/infra-manual: Fix typos and clarify project retirement https://review.openstack.org/280826 | 17:11 |
| *** wolverineav has joined #openstack-infra | 17:12 | |
| greghaynes | clarkb: Looks like tripleo fixed their cloud https://ci-overcloud.rh1.tripleo.org:13000/v2.0 | 17:12 |
| greghaynes | clarkb: so nodepool needs a restat | 17:12 |
| clarkb | greghaynes: oh right because we only grab the listing on new client | 17:12 |
| greghaynes | restart | 17:12 |
| greghaynes | yep | 17:12 |
| openstackgerrit | Merged openstack-infra/infra-manual: Add section on retiring a project https://review.openstack.org/210638 | 17:13 |
| *** scheuran has quit IRC | 17:13 | |
| *** samuelBartel has quit IRC | 17:13 | |
| cody-somerville | anteaya: Is the snow falling as fast for you as it is here? I think we're going to get 40cm here today. | 17:13 |
| *** gordc has quit IRC | 17:14 | |
| *** roxanaghe has joined #openstack-infra | 17:15 | |
| *** wolverineav has quit IRC | 17:16 | |
| jeblair | greghaynes: can you look at https://review.openstack.org/226114 ? | 17:16 |
| * greghaynes looks | 17:17 | |
| jeblair | who's running solum these days? | 17:18 |
| greghaynes | jeblair: so part of that is identical to https://review.openstack.org/#/c/273703/10/nodepool/nodepool.py | 17:18 |
| *** hashar has quit IRC | 17:18 | |
| clarkb | jamielennox: for when you wake, is there a concrete answer to "can we prevent keystoneauth/keystoneclient from logging passwords and tokens?" looks like not logging at debug level may be sufficient? can you confirm? also how new of a keystoneauth/client is required for that to be the case | 17:19 |
| *** EricGonczer_ has quit IRC | 17:19 | |
| jeblair | greghaynes: i'm not seeing it... | 17:19 |
| greghaynes | jeblair: the cleanupOneImage deleting images in state DELETE | 17:19 |
| fungi | jeblair: devkulkarni, so says http://governance.openstack.org/reference/projects/solum.html (possibly in #solum according to that) | 17:20 |
| greghaynes | jeblair: oh, cleanupOneImage vs cleanupOneDibImage | 17:20 |
| *** sshnaidm has joined #openstack-infra | 17:20 | |
| greghaynes | jeblair: nvm | 17:20 |
| clarkb | jeblair: looks like http://git.openstack.org/cgit/openstack/election/plain//candidates/mitaka/Solum/Devdatta_Kulkarni.txt is ptl of solum | 17:20 |
| jeblair | they have let the ERROR_ON_CLONE volkswagen patch sit for 5 months | 17:21 |
| jordanP | I noticed that we have a lot of old queries in https://github.com/openstack-infra/elastic-recheck/tree/master/queries Do we have a script to check if old queries are still relevant ? | 17:22 |
| fungi | jeblair: we were eventually going to remove any jobs relying on that, right? | 17:22 |
| clarkb | jordanP: the results page tells you if a query matches or not | 17:22 |
| jeblair | fungi: yeah, i'm about to propose that | 17:22 |
| clarkb | jordanP: they get faded out at the end of the list | 17:22 |
| greghaynes | jeblair: lgtm | 17:22 |
| jordanP | clarkb, great, thanks | 17:23 |
| jordanP | did you know we can have a direct URL to a logstash query like : http://logstash.openstack.org/#/dashboard/script/logstash.js?query=message:%22requires%20a%20subnet%20in%20order%20to%20boot%20instances%20on%22 | 17:23 |
| *** EricGonczer_ has joined #openstack-infra | 17:23 | |
| jordanP | I spend 30min on that :p | 17:23 |
| jordanP | *spent | 17:23 |
| clarkb | ya I hacked on the js to make that work (its not perfect) | 17:24 |
| *** alkhodos has joined #openstack-infra | 17:24 | |
| jordanP | ohh that's you, okay :) | 17:24 |
| greghaynes | clarkb: we believe in your js skills | 17:24 |
| *** shashank_hegde has quit IRC | 17:25 | |
| fungi | that was a regression/feature loss in kibana right? | 17:25 |
| clarkb | kibana 3 by default writes stuff to the index which doesn't work for our read only api access | 17:25 |
| clarkb | fungi: yes, I had to have it accept hte parameters | 17:25 |
| *** _nadya_ has joined #openstack-infra | 17:25 | |
| clarkb | but kibana is on v4 already (which I still hope to upgrade to if I can get logstash upgraded first) | 17:25 |
| clarkb | v4 goes bcak to the v2 way of things which should be better | 17:25 |
| *** ybathia has joined #openstack-infra | 17:26 | |
| *** smanjara has joined #openstack-infra | 17:26 | |
| alkhodos | Hi everyone. Is there a way to configure tempest.conf values via local.conf ? | 17:27 |
| jeblair | clarkb, fungi: i'm going to force-merge https://review.openstack.org/227010 and https://review.openstack.org/227011 | 17:27 |
| fungi | alkhodos: sounds like a question for #openstack-qa | 17:27 |
| jeblair | fungi: should i remove you from bootstrappers while i'm here? | 17:27 |
| alkhodos | fungi: ah, ok, sorry | 17:27 |
| fungi | jeblair: you can. i stopped last night in the middle of cleaning up the registered users groups breakage but can add myself back when i resume shortly | 17:28 |
| *** sfinucan has quit IRC | 17:28 | |
| jeblair | fungi: oh, i'll leave you then if you're about to resume | 17:28 |
| BobBall | asselin_: What's the correct line for the new gerrit_ssh_host_key? Seems that single_node_ci_site.pp hasn't been updated since gerrit was moved? | 17:28 |
| *** EricGonczer_ has quit IRC | 17:28 | |
| clarkb | jeblair: ok | 17:28 |
| asselin | BobBall, well the default should work | 17:29 |
| fungi | jeblair: yeah, i'll take myself out when i'm done. luckily we only had 17 projects impacted by that bug | 17:29 |
| fungi | so i should be done before meeting time | 17:29 |
| BobBall | asselin: I think it's wrong though? still has review.openstack.org pointing to 23.253.232.87 but it's now at 104.130.159.134 | 17:29 |
| *** tqtran has joined #openstack-infra | 17:30 | |
| *** tiswanso has quit IRC | 17:30 | |
| BobBall | asselin: I'm getting errors from zuul-merger saying host key verification failed | 17:30 |
| *** annegentle has quit IRC | 17:30 | |
| jeblair | huh, i can't submit https://review.openstack.org/#/c/227011/ | 17:30 |
| jeblair | infra-root: has anyone force-sumbitted a change since the gerrit upgrade? | 17:31 |
| fungi | jeblair: yep | 17:31 |
| clarkb | I have not | 17:31 |
| *** DuaneDeC7 has quit IRC | 17:31 | |
| fungi | jeblair: you have to vote first, and then the submit button appears on the change screen after you commit your votes | 17:31 |
| jeblair | what am i missing on that change then...? | 17:31 |
| fungi | it's a behavior change | 17:31 |
| jeblair | fungi: i have voted but i don't see it | 17:31 |
| BobBall | asselin: http://paste.openstack.org/show/487147/ | 17:31 |
| jeblair | fungi: the change is 'Ready to Submit'... | 17:32 |
| *** tiswanso has joined #openstack-infra | 17:32 | |
| clarkb | jeblair: https://review.openstack.org/#/c/273703/ does other related image clenaup if you have time to revie that when done merging magnetodb changes | 17:32 |
| fungi | jeblair: yeah, usually it appeared for me where the cherry pick, abandon and follow-up buttons are | 17:32 |
| jeblair | fungi: do you see one there? | 17:33 |
| fungi | i definitely do not | 17:33 |
| jeblair | neat. | 17:33 |
| *** annegentle has joined #openstack-infra | 17:33 | |
| jeblair | gertty got: 2016-02-16 09:30:49,235 Received: submit not permitted | 17:33 |
| zaro | morning | 17:33 |
| BobBall | asselin: Actually maybe this is because zuul-merger doesn't know that the private key is in /var/lib/zuul/ssh/id_rsa when doing git commands? (how does that happen?) | 17:33 |
| fungi | jeblair: oh! | 17:33 |
| fungi | jeblair: it's read-only already | 17:33 |
| jeblair | fungi: ha! thanks :) | 17:33 |
| fungi | jeblair: you can't submit any changes on a project without making it active first (and possibly also giving it a semi-functional acl) | 17:34 |
| jeblair | fungi: just active is enough apparently | 17:34 |
| *** dims has joined #openstack-infra | 17:34 | |
| BobBall | asselin: if I copy /var/lib/zuul/ssh/id_rsa to ~zuul/.ssh/id_rsa then zuul-merger is happy and can clone repos? | 17:35 |
| zaro | fungi: finally back from weekend trip. do we still need to fix the gerrit groups issude? | 17:35 |
| asselin | BobBall, no...hold on | 17:35 |
| *** ociuhandu has quit IRC | 17:35 | |
| openstackgerrit | Craig Vyvial proposed openstack-infra/project-config: run trove experimental run scenario tests https://review.openstack.org/278095 | 17:36 |
| *** wolverineav has joined #openstack-infra | 17:36 | |
| fungi | zaro: i was able to confirm my suspicion that removing the group from the database did not fix the acls, but that individually updating the groups files in all affected repos does and can be done without taking gerrit back offline | 17:38 |
| asselin | BobBall, can you try this https://review.openstack.org/#/c/266041/2/contrib/single_node_ci_site.pp | 17:38 |
| *** d0ugal has joined #openstack-infra | 17:38 | |
| fungi | zaro: the database update was really just cleanup. which groups the acls use is definitely determined by the groups files, and gerrit doesn't fall back to using the internal group with the same name if the uuid in the groups file refers to a nonexistent database entry | 17:39 |
| clarkb | fungi: and were you able to get jeepyb to update all the groups files for you? oh I bet it doesn't bceause they already hvae failues | 17:39 |
| clarkb | failues? == values | 17:39 |
| BobBall | asselin: Tried that - it wasn't sufficient. It does seems that zuul-merger can't get hold of id_rsa from /var/lib/zuul/ssh/id_rsa (hence copying the file to ~zuul/.ssh/id_rsa actually fixes the problem) | 17:39 |
| fungi | clarkb: since i had to work out the steps to test updating the groups files anyway, it's easier to just loop over the affected repos doing that | 17:40 |
| *** Jeffrey4l has quit IRC | 17:40 | |
| asselin | BobBall, I haven't seen that before... I though the path was set in the config file or the code | 17:40 |
| BobBall | asselin: It seems that zuul-merger doesn't need the host key to be in ~zuul/.ssh/known_hosts to function correctly | 17:40 |
| fungi | i also wanted to check which repos were actually affected so we could figure out how widespread the issue was (answer is 17 repos, definitely looks like any which had their acls created/altered after the 2.11 upgrade) | 17:40 |
| *** infra-red has joined #openstack-infra | 17:41 | |
| *** roxanaghe has quit IRC | 17:42 | |
| clarkb | just 17 that isn't too bad | 17:42 |
| clarkb | fungi: we are separately remove registered users from where it is unnecessary right? | 17:43 |
| zaro | fungi, clarkb : ahh yeah, that's right. I thought manage_projeects would replace the exiting one with 'glabl:Registered-Users' but I think i'm mistaken there. | 17:43 |
| fungi | zaro: it might if we forced updates of those acls | 17:43 |
| clarkb | Ithink it sees that the uuid already exists and passes it over | 17:43 |
| zaro | yeah, can we force update? | 17:43 |
| clarkb | the regex grabs the existing uuid and assumes it is correct | 17:44 |
| zaro | clarkb: yeah, i think that is correct | 17:44 |
| fungi | zaro: i'm just editing them by hand. there's not that many | 17:44 |
| clarkb | which reduces the cost of checking against gerrit and is generally good enough :) | 17:44 |
| zaro | fungi: coolio, sorry about that. | 17:45 |
| *** sabeen3 has quit IRC | 17:45 | |
| fungi | zaro: no worries, got it figured out | 17:45 |
| fungi | glad it turned out to be fairly simple | 17:45 |
| *** dprince has quit IRC | 17:45 | |
| *** esikachev has joined #openstack-infra | 17:46 | |
| *** sabeen1 has joined #openstack-infra | 17:46 | |
| BobBall | asselin: it's listed in /etc/zuul/zuul.conf... seems that the ssh wrapper code isn't working in my environment for some reason... maybe... | 17:46 |
| clarkb | jeblair: would you be open to adding a test to https://review.openstack.org/#/c/226114/1 ? I think you can invoke the nodepool class, let it make an image, stop the nodepool object/thread, set image state to delete, start a new nodepool instance and wait for image to go away | 17:46 |
| *** dprince has joined #openstack-infra | 17:46 | |
| *** ajmiller has joined #openstack-infra | 17:46 | |
| *** e0ne has joined #openstack-infra | 17:47 | |
| fungi | okay, the affected groups files are all fixed now | 17:48 |
| *** shardy has quit IRC | 17:48 | |
| *** mriedem is now known as mriedem_lunch | 17:49 | |
| jeblair | clarkb: i am not opposed to that but do not expect to have time to do so this week. or next. | 17:49 |
| clarkb | ok I will add it as a followup change then | 17:50 |
| *** _nadya_ has quit IRC | 17:50 | |
| *** sabeen3 has joined #openstack-infra | 17:51 | |
| zaro | fungi: thanks. i can do -2..+2 range on sandbox. | 17:52 |
| *** sabeen1 has quit IRC | 17:53 | |
| BobBall | Does anyone know why GIT_SSH might work with zuul-merger's wrapper from the command line, but not when zuul-merger is running itself? | 17:53 |
| clarkb | BobBall: file permissions? | 17:54 |
| BobBall | I'd hope not... since zuul-merger created the wrapper file | 17:55 |
| greghaynes | mordred: Hey, do you know what the state of the nodepool + shade patches are? I am having a hard time figuring that out based on outstanding changes (theres a lot of them in various states) | 17:57 |
| dprince | hi, trying to figure out why TripleO jobs are queued. I just fixed an issue 2 hours ago where the keystone endpoint was getting set to locahost:5000. That should be resolved now. Any idea on why jobs are still queued? | 17:57 |
| greghaynes | mordred: I might have some time to bang my head against it now that builders arent OMG ON FIRE | 17:57 |
| *** achanda has joined #openstack-infra | 17:59 | |
| greghaynes | https://review.openstack.org/#/c/226751/48 seems to be the new uberpatch? | 18:00 |
| *** gangil has joined #openstack-infra | 18:01 | |
| *** gangil has quit IRC | 18:01 | |
| *** gangil has joined #openstack-infra | 18:01 | |
| greghaynes | dprince: nodepool needs to be restarted | 18:02 |
| fungi | dprince: we need a nodepoold restart so it rereads your keystone api response | 18:02 |
| dprince | fungi: ah, cool. Thanks for this. I was still wondering if there was something else on my side | 18:02 |
| fungi | as far as it knows, your correctly-discovered keystone v2 endpoint url is hosted on its loopback | 18:02 |
| dprince | greghaynes: thanks | 18:02 |
| *** mayurig has joined #openstack-infra | 18:03 | |
| fungi | but next time it starts and hits the initial api url again, it should get directed to the correctly configured one | 18:03 |
| openstackgerrit | Merged openstack-infra/puppet-infracloud: Add class to deal with cacert on infra cloud https://review.openstack.org/278362 | 18:03 |
| *** vgridnev has joined #openstack-infra | 18:04 | |
| dprince | fungi: do we know when the next restart happens? | 18:04 |
| fungi | dprince: it'll be manual | 18:04 |
| clarkb | I can get to it once I finish up these nodepool reviews and writing nodepool tests | 18:04 |
| fungi | someone needs to take a few minutes to attempt a minimally-impacting restart of the daemon | 18:04 |
| *** flepied has quit IRC | 18:04 | |
| fungi | thanks clarkb! | 18:04 |
| clarkb | though if we have running image builds we will want the change I am reviewing :/ | 18:04 |
| clarkb | so maybe let that merge first | 18:04 |
| greghaynes | clarkb: which change? | 18:05 |
| clarkb | greghaynes: the one jeblair wrote to change status to delete on start if building | 18:05 |
| fungi | yeah, right now restarting nodepoold means any queued/in-flight image builds will be lost for the day | 18:05 |
| clarkb | I am writing tests for that now and if they pass I will approve | 18:05 |
| greghaynes | clarkb: Ah, that is just for snapshots, but they happen at the same time I suppose | 18:05 |
| *** yamamoto has quit IRC | 18:05 | |
| *** smanjara has quit IRC | 18:05 | |
| clarkb | greghaynes: yup all related | 18:06 |
| *** achanda has quit IRC | 18:06 | |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/infra-manual: Add URL for Gerrit group self-management https://review.openstack.org/280823 | 18:06 |
| greghaynes | clarkb: If builds are running really we want https://review.openstack.org/#/c/273703/ too | 18:06 |
| openstackgerrit | Doug Hellmann proposed openstack/requirements: update constraints to cliff 1.17.0 https://review.openstack.org/280853 | 18:06 |
| *** jcoufal has joined #openstack-infra | 18:06 | |
| clarkb | greghaynes: and uploads go in that table too | 18:06 |
| clarkb | greghaynes: ya I asked jeblair to review that one | 18:06 |
| *** annegentle has quit IRC | 18:06 | |
| *** haypo has joined #openstack-infra | 18:06 | |
| *** mriedem_lunch is now known as mriedem | 18:06 | |
| haypo | tonyb: would you mind to bless https://review.openstack.org/280854 liberty: release oslo.service 0.9.1 ? | 18:07 |
| haypo | #openstack-oslo: 19:02 < dhellmann> haypo : ping mriedem_lunch to review the release request | 18:07 |
| jeblair | clarkb, greghaynes: i am reviewing it now | 18:09 |
| *** yamamoto has joined #openstack-infra | 18:10 | |
| openstackgerrit | Merged openstack/requirements: Bump yaql version to 1.1.0 https://review.openstack.org/278983 | 18:10 |
| *** annegentle has joined #openstack-infra | 18:11 | |
| *** bpokorny has joined #openstack-infra | 18:11 | |
| greghaynes | clarkb: jeblair actually, https://review.openstack.org/#/c/273703/ is only useful if its merged before we shutdown. Still, good to get in regardless | 18:11 |
| clarkb | woot have working test for the nodes get cleaned up on start, now to do images | 18:12 |
| *** zeih has quit IRC | 18:13 | |
| fungi | woah! new wiki theme? when did that happen? | 18:13 |
| jeblair | greghaynes, clarkb: see comment in https://review.openstack.org/273703 | 18:13 |
| fungi | no. nevermind. somehow it got stuck on the mobile view for me | 18:13 |
| jeblair | fungi: looks the same... ah | 18:13 |
| *** sabeen3 has quit IRC | 18:15 | |
| openstackgerrit | Merged openstack-infra/infra-specs: Update unified mirror spec to support AFS https://review.openstack.org/273673 | 18:15 |
| lifeless | sdague: you want an email written? | 18:15 |
| openstackgerrit | Merged openstack-infra/infra-specs: Update docs-publishing spec to catch up to reality https://review.openstack.org/276481 | 18:16 |
| devananda | question related to virtual sprints and the SIP line -- is there a max # of participants? we're getting a report of line-busy | 18:16 |
| *** jlanoux has quit IRC | 18:16 | |
| *** chaustin has joined #openstack-infra | 18:16 | |
| jeblair | devananda: not that we've encountered, and we tested to several hundred... | 18:17 |
| jeblair | pabelanger: ^ | 18:17 |
| chaustin | Hi Folks, I am attempting to dial into the Asterisk conferencing system and getting a busy tone. | 18:17 |
| chaustin | I'm using the number 512-808-5750 | 18:18 |
| pabelanger | devananda: are you using PSTN? | 18:18 |
| pabelanger | or actually a SIP client | 18:18 |
| *** davideagnello has joined #openstack-infra | 18:18 | |
| pabelanger | we don't actually do any Busy() over SIP | 18:18 |
| sdague | lifeless: lets actually make sure the nova change works first | 18:19 |
| *** dizquierdo has quit IRC | 18:19 | |
| *** wolverineav has quit IRC | 18:19 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/gear: Remove shebang as the script is managed by an entry_point https://review.openstack.org/186889 | 18:19 |
| *** bpokorny has quit IRC | 18:19 | |
| openstackgerrit | greghaynes proposed openstack-infra/nodepool: Handle dib image deletion during periodic cleanup https://review.openstack.org/273703 | 18:20 |
| *** bpokorny has joined #openstack-infra | 18:20 | |
| greghaynes | jeblair: clarkb ^ | 18:20 |
| devananda | pabelanger: phone #, not SIP client | 18:21 |
| jeblair | devananda, pabelanger: our account balance with voip.ms is negative. i will pay the phone bill. :) | 18:21 |
| devananda | jeblair: lol :p | 18:22 |
| pabelanger | jeblair: devananda: Ya, that would do it | 18:22 |
| clarkb | jeblair: I can probably quickly do it if you want ot avoid doing it | 18:22 |
| clarkb | but I have never done it before so no idea | 18:22 |
| devananda | many of us are dialed in to the ph# now, but chaustin is getting busy signal | 18:22 |
| clarkb | would be a new number too right? | 18:22 |
| *** kzaitsev_mb has quit IRC | 18:23 | |
| *** achanda has joined #openstack-infra | 18:23 | |
| jeblair | clarkb: i'm paying it so we can keep the number and hopefully get it working quickly | 18:24 |
| clarkb | the new number was something I wanted to figure out | 18:24 |
| clarkb | we could have two numbers until old one ran out of funds | 18:24 |
| clarkb | maybe they allow transfers but my wiki reading hasn't shown anything | 18:24 |
| jeblair | it will probably be a few years until it runs out of funds now | 18:25 |
| *** shashank_hegde has joined #openstack-infra | 18:25 | |
| *** rvasilets_ has joined #openstack-infra | 18:25 | |
| jeblair | clarkb: so we may want to see if we can get the name/email addr on the existing account updated | 18:26 |
| *** rvasilets_ has left #openstack-infra | 18:26 | |
| jeblair | okay, it thinks we have a positive balance again | 18:26 |
| pabelanger | jeblair: clarkb: Ya, you won't lose the number. They give you ample warnings about a negative account. Should take 10mins to come back online after account filled | 18:26 |
| *** david-lyle has quit IRC | 18:27 | |
| clarkb | pabelanger: talking about switching theaccount details. If we make a new account I haven't seen a way to transfre a number but maybe I wsn't reading the right docs | 18:27 |
| jeblair | pabelanger: yeah, this all ties in with the foundation's executive director quietly deleting my jeblair@openstack.org email alias in december. | 18:27 |
| chaustin | Thank you folks! I'm in. | 18:27 |
| jeblair | chaustin: great, sorry for the inconvenience. | 18:27 |
| pabelanger | jeblair: clarkb: you'll be able to port the number, there is some paper work for that | 18:28 |
| jeblair | pabelanger: that's where account balance notifications were being delivered. | 18:28 |
| fungi | jeblair: jbryce was travelling when i caught up with him about the jeblair@o.o issue, and he indicated that he didn't intentionally delete it but may have removed it thinking it was inactive and overlooked any existing forward. it didn't sound like he was opposed to the idea of putting it back | 18:28 |
| *** d0ugal has quit IRC | 18:28 | |
| chaustin | jeblair: No worries, it was minor from my perspective. | 18:28 |
| fungi | he said something about having deleted e-mail accounts which had not been logged into for months that he thought were abandoned | 18:28 |
| jeblair | pabelanger, clarkb: as long as we're talking to voip.ms/filing paperwork, maybe we can see if we can get it set up as a proper role account | 18:29 |
| *** d0ugal has joined #openstack-infra | 18:29 | |
| jeblair | we have $22.89 of runway to do that :) | 18:29 |
| clarkb | jeblair: ++ I think that would be ideal | 18:29 |
| *** chaustin has left #openstack-infra | 18:29 | |
| clarkb | I can rebug scott aout not using personal CC if we go that route too | 18:30 |
| pabelanger | jeblair: Ya, I found that very easy to work with. Should be a simply support ticket to move things between accounts | 18:30 |
| jeblair | we do pay like $0.01/min for incoming calls on this plan | 18:31 |
| *** _nadya_ has joined #openstack-infra | 18:31 | |
| jeblair | which is why the $2 we had in the account was suddenly no longer sufficient | 18:31 |
| *** sridhar_ram is now known as sridhar_ram_afk | 18:31 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/gear: Switch to six for configparser https://review.openstack.org/280876 | 18:31 |
| AJaeger | team, rossella_s asked us in http://lists.openstack.org/pipermail/openstack-dev/2016-February/086392.html for an idea on how to setup a job. Has any of you some directions for her? | 18:33 |
| *** _sarob has joined #openstack-infra | 18:33 | |
| *** e0ne has quit IRC | 18:33 | |
| dims | jeblair : i believe this is one from mtreinish is ready to merge https://review.openstack.org/#/c/279299/ (helps with the oslo master jobs on health check, has clarkb's +2 on it). please peek when you get a chance | 18:34 |
| jeblair | dims: ack | 18:34 |
| *** kushal has quit IRC | 18:34 | |
| *** mriedem has quit IRC | 18:35 | |
| dims | thanks jeblair | 18:35 |
| *** Madasi has joined #openstack-infra | 18:35 | |
| *** jcoufal has quit IRC | 18:35 | |
| *** edunham has left #openstack-infra | 18:35 | |
| *** david-lyle has joined #openstack-infra | 18:35 | |
| *** kzaitsev_mb has joined #openstack-infra | 18:36 | |
| openstackgerrit | Ondřej Nový proposed openstack/requirements: Bump PyECLib global-requirement to >= 1.2.0 https://review.openstack.org/278945 | 18:37 |
| *** jordanP has quit IRC | 18:39 | |
| *** flepied has joined #openstack-infra | 18:39 | |
| *** qb_ has joined #openstack-infra | 18:41 | |
| clarkb | hrm this code is racier than I thought | 18:41 |
| *** wolverineav has joined #openstack-infra | 18:41 | |
| jeblair | clarkb: if you need to kick it back to me, that's cool. | 18:41 |
| *** EricGonczer_ has joined #openstack-infra | 18:42 | |
| *** wolverineav has quit IRC | 18:42 | |
| *** wolverineav has joined #openstack-infra | 18:42 | |
| clarkb | I think I am very close, basically need to make periodic cleanup run with a config after starting the nodepool thread | 18:42 |
| *** mriedem has joined #openstack-infra | 18:42 | |
| clarkb | because periodic cleanup is what will clear out that image and make way for a new one via check for missing images | 18:42 |
| clarkb | calling periodicCleanup() directly after pool.start() results in self.config NoneType has no attribute db | 18:43 |
| *** EricGonczer_ has quit IRC | 18:43 | |
| clarkb | I knoiw | 18:43 |
| *** abregman has quit IRC | 18:43 | |
| clarkb | but thats hacky ( could make wait for images invoke a cleanup) | 18:44 |
| *** ajmiller has quit IRC | 18:44 | |
| *** ajmiller_ has joined #openstack-infra | 18:44 | |
| *** mayurig has quit IRC | 18:44 | |
| jeblair | oh, it's the tests | 18:45 |
| clarkb | I think so | 18:45 |
| jeblair | clarkb: add a wait for self.config.db method? | 18:45 |
| *** roxanaghe has joined #openstack-infra | 18:48 | |
| *** hashar has joined #openstack-infra | 18:49 | |
| *** yamamoto has quit IRC | 18:49 | |
| *** nmagnezi has quit IRC | 18:50 | |
| clarkb | ya then wait for startup to update the db | 18:51 |
| openstackgerrit | James E. Blair proposed openstack-infra/system-config: Add storyboard exim router/transports https://review.openstack.org/270331 | 18:51 |
| *** roxanaghe has quit IRC | 18:51 | |
| *** esikachev has quit IRC | 18:52 | |
| jeblair | greghaynes: onFailed will all dib_image.delete() | 18:52 |
| jeblair | greghaynes: i'm typing more things into the review | 18:54 |
| openstackgerrit | Merged openstack-infra/system-config: Remove wheel_mirror known hosts https://review.openstack.org/278473 | 18:55 |
| clarkb | AJaeger: that seems equivalent to http://status.openstack.org//reviews/ | 18:55 |
| clarkb | AJaeger: maybe just suggest neutron use that? | 18:55 |
| jeblair | greghaynes: okay, left more comments | 18:56 |
| AJaeger | clarkb: Not really, they look at critical bugs, then create a URL for that - and thus it changes daily | 18:57 |
| clarkb | AJaeger: that is whay the review day thing does | 18:57 |
| *** rossella_s has quit IRC | 18:57 | |
| clarkb | AJaeger: it runs periodically and updates the list based on bug information | 18:57 |
| *** sridhar_ram_afk has quit IRC | 18:57 | |
| *** rossella_s has joined #openstack-infra | 18:58 | |
| AJaeger | clarkb: Ok, I'll talk with her about it. Thanks for the hint | 18:58 |
| *** notnownikki has quit IRC | 18:58 | |
| clarkb | AJaeger: it is possible we want to add gerrit dashboard links to that tool, but all of the base infrastructure fo rthat exists | 18:59 |
| clarkb | AJaeger: repo is called reviewday iirc | 18:59 |
| *** max_lobur has quit IRC | 18:59 | |
| pleia2 | meeting time :) | 19:00 |
| *** tiswanso has quit IRC | 19:00 | |
| *** edleafe has left #openstack-infra | 19:00 | |
| *** esikachev has joined #openstack-infra | 19:00 | |
| AJaeger | thanks, pleia2 | 19:00 |
| *** tiswanso has joined #openstack-infra | 19:01 | |
| openstackgerrit | Merged openstack-infra/puppet-openstackid: Put /usr/local/bin first in paths https://review.openstack.org/280810 | 19:03 |
| fungi | yolanda: nibalizer: you seem to have dropped off #-meeting | 19:03 |
| nibalizer | oh noes | 19:04 |
| nibalizer | switching irc clients: risky | 19:04 |
| *** pvaneck has joined #openstack-infra | 19:04 | |
| *** kzaitsev_mb has quit IRC | 19:04 | |
| *** sabeen1 has joined #openstack-infra | 19:05 | |
| *** gibi has quit IRC | 19:06 | |
| *** infra-red has quit IRC | 19:07 | |
| openstackgerrit | Dmitry Tantsur proposed openstack-infra/project-config: Make postgres job non-voting on Ironic https://review.openstack.org/280888 | 19:07 |
| *** gibi has joined #openstack-infra | 19:07 | |
| *** sabeen2 has joined #openstack-infra | 19:07 | |
| *** gibi has quit IRC | 19:08 | |
| *** infra-red has joined #openstack-infra | 19:09 | |
| *** sabeen1 has quit IRC | 19:10 | |
| openstackgerrit | Dmitry Tantsur proposed openstack-infra/project-config: Make postgres job non-voting on Ironic and switch it to IPA https://review.openstack.org/280888 | 19:11 |
| *** mtanino__ has quit IRC | 19:12 | |
| *** gibi has joined #openstack-infra | 19:12 | |
| *** notnownikki has joined #openstack-infra | 19:12 | |
| *** ybathia has quit IRC | 19:13 | |
| *** daemontool has joined #openstack-infra | 19:14 | |
| *** vgridnev has quit IRC | 19:14 | |
| *** esikachev has quit IRC | 19:15 | |
| *** sputnik13 has joined #openstack-infra | 19:15 | |
| openstackgerrit | Aliaksandr Buhayeu proposed openstack/python-jenkins: Adds method to retrieve all jobs from the specific view https://review.openstack.org/279750 | 19:16 |
| AJaeger | andreaf: could you review https://review.openstack.org/#/c/278091/ , please? | 19:16 |
| *** daemontool_ has joined #openstack-infra | 19:16 | |
| *** dimtruck is now known as zz_dimtruck | 19:17 | |
| *** infra-re_ has joined #openstack-infra | 19:17 | |
| *** eharney has quit IRC | 19:17 | |
| *** esikachev has joined #openstack-infra | 19:18 | |
| openstackgerrit | Erno Kuvaja proposed openstack/requirements: glance-store 0.11.0 https://review.openstack.org/280891 | 19:18 |
| *** daemontool has quit IRC | 19:19 | |
| *** gsagie_ has joined #openstack-infra | 19:19 | |
| *** infra-red has quit IRC | 19:21 | |
| *** zz_dimtruck is now known as dimtruck | 19:21 | |
| lifeless | sdague: sure; I presume this is about constraints? | 19:26 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/project-config: Remove unused periodic-pbr-installation-dsvm-upstream https://review.openstack.org/280894 | 19:27 |
| *** ajmiller has joined #openstack-infra | 19:27 | |
| *** jtomasek_ has joined #openstack-infra | 19:28 | |
| AJaeger | lifeless: this was about change I150640990fb900318878563544af91e0a6043882 - and how to move forward with constraints | 19:28 |
| AJaeger | lifeless: with that change in, we don't need a separate gate-{name}-pep8-constraints anymore | 19:29 |
| *** SumitNaiksatam has joined #openstack-infra | 19:29 | |
| *** infra-red has joined #openstack-infra | 19:29 | |
| AJaeger | lifeless: see also https://review.openstack.org/267096 | 19:29 |
| AJaeger | lifeless: and to me the constraints move looks stale right now - with some projects having them non-voting but not making progress. | 19:30 |
| *** ajmiller_ has quit IRC | 19:30 | |
| AJaeger | lifeless: so, I'd like to see some guidance on how to move forward, please | 19:30 |
| *** sridhar_ram has joined #openstack-infra | 19:30 | |
| *** infra-re_ has quit IRC | 19:32 | |
| *** EricGonczer_ has joined #openstack-infra | 19:33 | |
| *** ifarkas has quit IRC | 19:33 | |
| *** EricGonczer_ has quit IRC | 19:34 | |
| *** roxanaghe has joined #openstack-infra | 19:34 | |
| *** roxanaghe has quit IRC | 19:36 | |
| *** eharney has joined #openstack-infra | 19:37 | |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/project-config: Fix name of ha-guide post job https://review.openstack.org/280899 | 19:38 |
| *** max_lobur has joined #openstack-infra | 19:39 | |
| *** gsagie_ has quit IRC | 19:40 | |
| *** electrofelix has quit IRC | 19:42 | |
| *** roxanaghe has joined #openstack-infra | 19:42 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/puppet-infracloud: Parameterize entries for neutron subnet https://review.openstack.org/266902 | 19:43 |
| *** eil397 has joined #openstack-infra | 19:44 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/puppet-infracloud: Remove dummy default password from keystone https://review.openstack.org/280903 | 19:45 |
| *** Sukhdev has joined #openstack-infra | 19:47 | |
| annegentle | fungi: if a spec is under consideration, which section to add it to? | 19:48 |
| *** weshay has quit IRC | 19:48 | |
| annegentle | looking at doc/source/index.rst | 19:48 |
| *** roxanaghe has left #openstack-infra | 19:49 | |
| *** weshay has joined #openstack-infra | 19:50 | |
| *** yamamoto has joined #openstack-infra | 19:50 | |
| AJaeger | annegentle: add to "Approved Design Specifications" | 19:53 |
| annegentle | AJaeger: hehe but it's not approved so I got confused :) | 19:53 |
| AJaeger | because once it's approved, that's the right place | 19:53 |
| AJaeger | annegentle: having it approved is your goal ;) | 19:53 |
| AJaeger | you propose a change so that it gets approved :) | 19:53 |
| *** vgridnev has joined #openstack-infra | 19:54 | |
| *** EricGonczer_ has joined #openstack-infra | 19:54 | |
| openstackgerrit | Anne Gentle proposed openstack-infra/infra-specs: Adds specification for serving REST API info on developer.openstack.org https://review.openstack.org/276484 | 19:54 |
| openstackgerrit | greghaynes proposed openstack-infra/nodepool: Handle dib image deletion during periodic cleanup https://review.openstack.org/273703 | 19:54 |
| annegentle | AJaeger: :) | 19:54 |
| greghaynes | jeblair: clarkb ^ | 19:54 |
| *** yamamoto has quit IRC | 19:56 | |
| fungi | annegentle: yeah, once the change adding it to approved merges, it will actually be approved, so ina mind-bending future-past sort of way it makes sense? | 19:56 |
| annegentle | fungi: sure does. Plus, positive thinking! | 19:57 |
| clarkb | jeblair: there is a bug in your change, do you want me to push a new patchset with the fix and test? | 19:57 |
| *** infra-re_ has joined #openstack-infra | 19:57 | |
| clarkb | s/in/with/ might be a better way to describe it | 19:57 |
| jeblair | clarkb: yes please, thanks | 19:58 |
| *** infra-r__ has joined #openstack-infra | 19:59 | |
| *** infra-red has quit IRC | 20:00 | |
| *** rfolco has quit IRC | 20:01 | |
| fungi | pabelanger: clarkb: did the additional jobs at https://review.openstack.org/278793 make sense from the perspective of getting a broader idea of impact of the bindep addition to most of our bare worker job templates? have suggestions for others i should add? maybe some infra puppet jobs? | 20:01 |
| *** vgridnev has quit IRC | 20:01 | |
| *** e0ne has joined #openstack-infra | 20:02 | |
| *** gnuoy_ has joined #openstack-infra | 20:02 | |
| fungi | i've also realized we probably need to either hurry up our transition off of bare-precise or get dib-based ubuntu-precise images working | 20:02 |
| *** infra-re_ has quit IRC | 20:03 | |
| clarkb | fungi: I havne't looked but mordred has a change to oscc that should make our uploads to rax work | 20:03 |
| clarkb | so that portion of the ubuntu-trusty work is making progress | 20:03 |
| *** e0ne has quit IRC | 20:05 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Delete building images on startup https://review.openstack.org/226114 | 20:05 |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Test building node cleanup on startup https://review.openstack.org/280909 | 20:05 |
| clarkb | jeblair: ^ there we go | 20:05 |
| jeblair | clarkb: rebase :( | 20:06 |
| pabelanger | fungi: Ya, it helped a bit. | 20:06 |
| clarkb | jeblair: yup the old base was really old | 20:06 |
| clarkb | and conflicted in the tests | 20:06 |
| jeblair | clarkb: could you do it as 2 patchsets please? | 20:07 |
| *** gnuoy_ has quit IRC | 20:07 | |
| *** dtantsur is now known as dtantsur|afk | 20:07 | |
| jeblair | clarkb: you say there's a problem with the first patchset, but i can't see what you did to fix it | 20:07 |
| clarkb | jeblair: do what as two patchsets? | 20:07 |
| jeblair | clarkb: the rebase and whatever change you made | 20:07 |
| openstackgerrit | Chuck Short proposed openstack/requirements: Add requests-unixsocket as a requirement https://review.openstack.org/280911 | 20:08 |
| clarkb | jeblair: ok... | 20:08 |
| clarkb | I am not sure thats a thing we have ever asked for before? | 20:08 |
| jeblair | clarkb: i ask for it all the time | 20:08 |
| *** flepied1 has joined #openstack-infra | 20:08 | |
| *** jaosorior has quit IRC | 20:09 | |
| *** flepied has quit IRC | 20:10 | |
| jeblair | clarkb: if someone updates a change with a new patchset, i want to be able to see the difference between them, but if there is a rebase *plus* a change, it is nearly impossible to do so. the inter-patch-set-diff is thousands of lines long. | 20:10 |
| pabelanger | fungi: let me know what I should be working on to help escalate the bare-precise migration. So far, I've just been monitoring bindep non-voting jobs and seem to be fine for project-config. Same for nova | 20:10 |
| greghaynes | jeblair: that'll merge a bug in our git history | 20:10 |
| clarkb | greghaynes: two patchsets not changes | 20:10 |
| greghaynes | Ah | 20:11 |
| openstackgerrit | yolanda.robla proposed openstack-infra/puppet-infracloud: Add element to bring up bridge on infra cloud https://review.openstack.org/276292 | 20:11 |
| clarkb | jeblair: I get that... but that is a problem with how we tell people to use gerrit | 20:11 |
| pc_m | Does anyone know if we are supposed to be using otestr instead of testr now for test jobs? | 20:11 |
| *** eil397 has quit IRC | 20:11 | |
| clarkb | I don't know that any of our docs say do an intermediate patchset for the rebase | 20:11 |
| *** sabeen2 has quit IRC | 20:11 | |
| jeblair | clarkb: i don't know that we tell people to rebase and make changes at the same time. in fact, we tell them to try not to rebase. i wrote a tool to make that easier. | 20:11 |
| clarkb | in this case the rebase was required | 20:12 |
| jeblair | clarkb: i agree, we don't go out of our way to say "upload 2 patchsets if you need to do this" but maybe we should start | 20:12 |
| clarkb | due to conflicts | 20:12 |
| jeblair | clarkb: i get it | 20:12 |
| *** sambetts is now known as sambetts|afk | 20:12 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Delete building images on startup https://review.openstack.org/226114 | 20:13 |
| clarkb | there is the rebase | 20:13 |
| jeblair | clarkb: but here's my mental state: "clarkb said there's something wrong with a patch i wrote. i do not know what that thing is. if i want to understand the change he made to fix that, i need to either look at 4000 lines of diff, or mentally interdiff, or ask clarkb to explain it" | 20:13 |
| jeblair | clarkb: it's not an ideal state for a reviewer (or author) to be in | 20:13 |
| *** aysyd has quit IRC | 20:13 | |
| clarkb | believe me I understand the issues. There are ways around them, most of them don't involve completely respinning patches | 20:14 |
| jeblair | clarkb: i'm open to alternative suggestions | 20:14 |
| *** lucasagomes is now known as lucas-dinner | 20:14 | |
| fungi | pabelanger: yeah, i think in the interest of time i'm going to take the one +2 on 278793 (thanks AJaeger!) as an indication it's a good start, self-approve it and then as soon as that and its child change merge in a little while, upload some do-not-merge changes for the 15 projects using that project-template and do a check experimental on them | 20:14 |
| jeblair | clarkb: and i hope it's a checkout, rebase, and cherry-pick. if you want, i can do it. | 20:15 |
| clarkb | jeblair: I am doing it, currently running into no changes rejection from gerrit | 20:15 |
| *** sdake_ has joined #openstack-infra | 20:15 | |
| clarkb | I think for the child change | 20:15 |
| *** wolverin_ has joined #openstack-infra | 20:17 | |
| *** sdake has quit IRC | 20:17 | |
| clarkb | oh it is mad about the old patchset I see, one sec | 20:18 |
| *** suhani has joined #openstack-infra | 20:18 | |
| *** ldnunes has quit IRC | 20:18 | |
| pabelanger | fungi: sure, that works for me | 20:18 |
| *** infra-red has joined #openstack-infra | 20:18 | |
| *** david-lyle has quit IRC | 20:18 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Delete building images on startup https://review.openstack.org/226114 | 20:19 |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Test building node cleanup on nodepool startup https://review.openstack.org/280909 | 20:19 |
| clarkb | there we go | 20:19 |
| clarkb | I think | 20:19 |
| fungi | yeah, i think every time gerrit has ever rejected a change of mine for duplication reasons, it's actually been pebcak/id10t on my part | 20:20 |
| *** smarcet has quit IRC | 20:20 | |
| clarkb | well it wasn't pebkac | 20:20 |
| fungi | just sometimes takes me a few minutes to figure out what it was i was actually doing wrong | 20:20 |
| *** wolverineav has quit IRC | 20:20 | |
| clarkb | gerrit doesn't allow what jeblair asked for unless you do some really forceful things | 20:20 |
| *** infra-r__ has quit IRC | 20:20 | |
| *** wolverin_ has quit IRC | 20:21 | |
| clarkb | cherry pick qualifies which I didn't use | 20:21 |
| clarkb | rebasing doesn't sufficiently change the patch diff which gerrit uses to see if things are differnet | 20:21 |
| *** annegentle has quit IRC | 20:21 | |
| jeblair | clarkb: (a rebase is a series of cherry-picks) | 20:21 |
| *** esikachev has quit IRC | 20:21 | |
| clarkb | jeblair: but cherry picks rewrite the commit timestamp | 20:21 |
| clarkb | rebase won't | 20:21 |
| clarkb | which I think is the difference here | 20:22 |
| *** annegentle has joined #openstack-infra | 20:22 | |
| fungi | clarkb: oh, even if the commit sha is different that's not enough to satiafy gerrit? | 20:22 |
| suhani | hi | 20:22 |
| fungi | er, satisfy | 20:23 |
| clarkb | fungi: correct because it looks at a diff that doesn't include the sha | 20:23 |
| clarkb | or rather looks at a different sha that doesn't include the commit sha | 20:23 |
| clarkb | which is the sha of that diff | 20:23 |
| clarkb | suhani: hello | 20:23 |
| suhani | I have a question | 20:24 |
| jeblair | clarkb: a rebase will rewrite any commits it needs to.... | 20:24 |
| jeblair | clarkb: ('pick' in interactive rebase means 'cherry-pick') | 20:24 |
| clarkb | jeblair: yup but in this case it was a fast forward because I hadn't included my changes | 20:24 |
| suhani | I used my personal account for third party CI and has been disabled because of that | 20:24 |
| *** claudiub has quit IRC | 20:24 | |
| fungi | clarkb: i'm failing to understand how your rebase could result in a fast-forward from your previous patchset | 20:24 |
| suhani | clarkb: I now know that we shouldn't use personal account for the same | 20:24 |
| openstackgerrit | Merged openstack-infra/project-config: Add experimental bindep for the python-jobs group https://review.openstack.org/278793 | 20:24 |
| clarkb | jeblair: and then the end ps was identical to the earlier ps | 20:24 |
| suhani | clarkb: is it possible to enable it again | 20:25 |
| clarkb | fungi: the first rebase, to just do the reabse was a fast forward, that worked fine | 20:25 |
| clarkb | fungi: the second rebase is identical to the preexisting patchset we don't want | 20:25 |
| *** miqui has joined #openstack-infra | 20:25 | |
| clarkb | because it was rebased | 20:25 |
| *** mayurig has joined #openstack-infra | 20:25 | |
| clarkb | the diff sha is the same | 20:25 |
| openstackgerrit | Merged openstack-infra/project-config: Extend experimental-bindep-jobs to 14 projects https://review.openstack.org/278798 | 20:25 |
| clarkb | because timestamps are preserved I think | 20:26 |
| clarkb | yup | 20:26 |
| fungi | suhani: it wasn't just that you used your account for a third-party ci system, but that you were leaving automated comments on all sorts of changes for different projects who hadn't asked you to do so and didn't have a public policy encouraging third-party testing comments | 20:26 |
| fungi | suhani: so the main reason we disabled the account was to get it to stop spamming | 20:27 |
| suhani | fungi: yes I now know that and won't be doing that again | 20:27 |
| *** notnownikki has quit IRC | 20:27 | |
| *** dtardivel has quit IRC | 20:28 | |
| clarkb | basically you need some change in the commit message or the code diff, and rebase by default preserves the timestamp and author | 20:28 |
| clarkb | so that isn't sufficient in this case | 20:28 |
| *** tiswanso has quit IRC | 20:28 | |
| pleia2 | suhani: we can re-enable your account then, but we will have to shut it off if we see more automated comments | 20:28 |
| *** mdenny has joined #openstack-infra | 20:28 | |
| clarkb | cherry pick will update the timestamp | 20:29 |
| jeblair | clarkb: your solution is a good one anyway. :) | 20:29 |
| clarkb | ya I just edited the commit message | 20:30 |
| suhani | pleia2: i agree | 20:30 |
| suhani | pleia2: and i assure that it won't be happening again | 20:31 |
| fungi | suhani: pleia2: i just did it and replied to the ml | 20:31 |
| pleia2 | suhani: your account is now activated | 20:31 |
| *** gnuoy_ has joined #openstack-infra | 20:31 | |
| pleia2 | fungi: oops | 20:31 |
| *** gnuoy_ has quit IRC | 20:31 | |
| suhani | thank you everyone | 20:31 |
| fungi | doubly-activated! | 20:31 |
| *** sdake_ has quit IRC | 20:32 | |
| pleia2 | :) | 20:32 |
| fungi | like baking powder? | 20:32 |
| fungi | no, wait, that's double-acting | 20:32 |
| *** sdake has joined #openstack-infra | 20:32 | |
| jeblair | clarkb: thank you for the update, i can see clearly the change now. | 20:32 |
| *** asselin_ has quit IRC | 20:33 | |
| clarkb | great. The test logs pointed out that we weren't flipping any image states which was odd and led me to that | 20:33 |
| *** qb_ has quit IRC | 20:36 | |
| *** sabeen has joined #openstack-infra | 20:37 | |
| clarkb | jeblair: as for alternatives `diff <(git show $ref) <(git show $other_ref)` works reasonably well | 20:38 |
| fungi | that's a useful one-liner. i didn't realize git could take two stdin redirections | 20:39 |
| clarkb | fungi: diff does not git | 20:39 |
| *** wolverineav has joined #openstack-infra | 20:39 | |
| fungi | i meant diff, yeah | 20:39 |
| *** |-paul-| has joined #openstack-infra | 20:40 | |
| *** kzaitsev_mb has joined #openstack-infra | 20:40 | |
| *** sabeen3 has joined #openstack-infra | 20:41 | |
| *** tiswanso has joined #openstack-infra | 20:41 | |
| openstackgerrit | Paul Michali proposed openstack-infra/project-config: Cleanup of constraint based jobs for neutron-vpnaas https://review.openstack.org/280922 | 20:41 |
| *** sabeen has quit IRC | 20:42 | |
| *** rkukura has joined #openstack-infra | 20:42 | |
| fungi | that's awesome. where has this been all my life! | 20:42 |
| fungi | goodbye tempfiles to perform sorted diffs | 20:43 |
| *** wolverineav has quit IRC | 20:43 | |
| pleia2 | hehe | 20:43 |
| *** wolverineav has joined #openstack-infra | 20:43 | |
| clarkb | I can write a shell script to do it | 20:43 |
| clarkb | and fetch the thingsfrom gerrit | 20:43 |
| *** thorst_ is now known as thorst | 20:44 | |
| jeblair | clarkb: that seems to work well in this case, though i know in the past i've tried it and it's produced some pretty unreadable stuff. it does have the disadvantage of not making it particularly easy to review the result. | 20:44 |
| tonyb | haypo: I can look at it but I'm not in a position to bless it. | 20:45 |
| AJaeger | sdague, lifeless : FYI, here's a first constraints change https://review.openstack.org/#/c/280922 | 20:46 |
| tonyb | thorst: Thanks | 20:46 |
| haypo | tonyb: for https://review.openstack.org/280854 (oslo.service release in liberty), sorry, i don't know the status of oslo lib in liberty, except that it looks to be a mess :) | 20:47 |
| haypo | tonyb: i saw that upper-constraints.txt of liberty uses an oslo.service version of mitaka... | 20:47 |
| tonyb | haypo: Oh wow, that seems like a bug. | 20:48 |
| jeblair | clarkb: have you found that process to be fairly reliable and comprehensible? | 20:48 |
| clarkb | jeblair: for me at least | 20:48 |
| AJaeger | fungi, ok to approve tonyb's change for removal of registered users? Or do you want to review it? https://review.openstack.org/#/c/280439 | 20:48 |
| clarkb | jeblair: you just map the > side diff onto the base..newps diff | 20:48 |
| clarkb | and comment there | 20:48 |
| tonyb | haypo: Oh are you thining about the *-src-$library jobs on liberty that pull $library from master? | 20:48 |
| jeblair | clarkb: aside from whether this technique is effective; do you think we should not ask reviewers to separate rebase and change patchsets? | 20:50 |
| haypo | tonyb: i'm talking about https://github.com/openstack/requirements/blob/stable/liberty/upper-constraints.txt#L201 | 20:50 |
| jeblair | clarkb: sorry, ask submitters | 20:50 |
| haypo | mriedem knows maybe more about this issue ^^ | 20:50 |
| clarkb | jeblair: I do not, in ~4 years of using gerrit I haven't felt that that was required | 20:51 |
| jeblair | clarkb: my thinking is that i'd really like change history to be easily viewable in gerrit, and i want things to be as easy as possible for reviewers | 20:51 |
| clarkb | sometimes it is difficult to read the diffs but there are easier ways of working through that then waiting on an asnyc process that may never happen | 20:51 |
| jeblair | clarkb: yeah, so i'm not actually suggesting that the process be that reviewers ask developers to go back and do things again, but rather that we ask developers to do this in the first place, when it's much simpler | 20:52 |
| clarkb | jeblair: the problem that is you will get lots of gratuitous rebase patchsets because it is easier to do the rebase before yo umake changes than after | 20:53 |
| *** Sukhdev has quit IRC | 20:54 | |
| jeblair | i know i try to do it when i submit changes; and i think other gerrit communities have adopted it explicitly as a best practice | 20:54 |
| *** gyee has quit IRC | 20:54 | |
| clarkb | ideal situaton would just be to support the interdiff in gerrit | 20:54 |
| clarkb | or gertty | 20:54 |
| jeblair | clarkb: you only did the rebase after you tried to push the change, right? | 20:55 |
| *** gordc has joined #openstack-infra | 20:55 | |
| jeblair | clarkb: so that's still the same point in the process -- you have already written the change. the question is, once git-review tells you you need to rebase, what do you do? | 20:55 |
| mriedem | haypo: short story is that the bot was proposing updates to u-c in liberty and those were approved willy nilly | 20:55 |
| mriedem | haypo: those haven't been unwound yet | 20:55 |
| tonyb | haypo: Ahh I see what you mean. | 20:55 |
| mriedem | some of that was being talked about in https://etherpad.openstack.org/p/stable-liberty-constraints-sanity | 20:55 |
| fungi | AJaeger: tonyb: should be fine. it's also just cleanup now, the issue in the groups files has been corrected manually | 20:56 |
| jeblair | clarkb: i'm suggesting that one could, at that point, rebase the original patchset, push, cherry-pick the change, push | 20:56 |
| * tonyb just volenteered to try and unwind some/all of that. | 20:56 | |
| tonyb | fungi: Thanks. | 20:56 |
| clarkb | jeblair: right the difference is in juggling old and new | 20:56 |
| clarkb | you don't have to do that if you just explicitl deal with old first | 20:56 |
| AJaeger | fungi: approved... | 20:57 |
| jeblair | clarkb: you're saying people will want to pro-actively rebase to avoid the chance of having to do what i described? | 20:57 |
| clarkb | yes | 20:57 |
| jeblair | clarkb: that seems even more reviewer unfriendly | 20:58 |
| clarkb | yes | 20:58 |
| jeblair | i dunno | 20:58 |
| jeblair | i guess i'm trying to suggest that maybe we could try to do a little more work to make things easier for reviewers | 20:58 |
| jeblair | clarkb: but i guess you and i have had radically different experiences over the last 4 years | 20:58 |
| *** jsavak has joined #openstack-infra | 20:58 | |
| jeblair | (i've tried to do this when i submit changes, and i often do it on changes i'm reviewing to help both myself and other reviewers) | 20:59 |
| openstackgerrit | Matthew Treinish proposed openstack-infra/system-config: Remove retry-get param from subunit file collection https://review.openstack.org/280924 | 20:59 |
| *** suhani has quit IRC | 21:00 | |
| clarkb | jeblair: mostly I see it as a tool problem not a rpocess problem | 21:00 |
| clarkb | we already have a hrad enough time explaining to people how to update old patchsets | 21:00 |
| jeblair | clarkb: i agree; if interdiff were reliable, i'd use it in a heartbeat. i have not figured out how to make it so. | 21:00 |
| jeblair | clarkb: interdiff <(git show 318e6e41bdc6c9d4d8eb77e475bd360fb0345687) <(git show 055c0064442bf4f7c08d6692a7ad86eb50182f90) | 21:01 |
| jeblair | clarkb: that showed the changes you made, but also, some rebase stuff leaked in there | 21:01 |
| jeblair | clarkb: diff <(git show 318e6e41bdc6c9d4d8eb77e475bd360fb0345687) <(git show 055c0064442bf4f7c08d6692a7ad86eb50182f90) | 21:01 |
| jeblair | clarkb: that shows exactly what we want to see | 21:02 |
| *** sarob_ has joined #openstack-infra | 21:02 | |
| *** _sarob has quit IRC | 21:02 | |
| jeblair | clarkb: but if you want to leave a review comment, it involves opening things up in multiple windows and trying to map between them | 21:03 |
| clarkb | ya line numbers in the header for diff | 21:03 |
| clarkb | is hwy there is leakage | 21:03 |
| *** _sarob has joined #openstack-infra | 21:03 | |
| clarkb | there is probably a flag to diff to avoid that | 21:03 |
| *** sarob_ has quit IRC | 21:03 | |
| clarkb | jeblair: that wouldn't be necessary if gerrit/gertty did it for you | 21:03 |
| *** haypo has left #openstack-infra | 21:03 | |
| openstackgerrit | Dan Prince proposed openstack-infra/project-config: Add puppet-zaqar to tripleo jobs https://review.openstack.org/280928 | 21:03 |
| *** apoorvad has quit IRC | 21:04 | |
| * clarkb is reading git diff-tree manpage to see if the leakage can be cleaned up | 21:04 | |
| jeblair | clarkb: yeah, i'd love to add it to gertty, but i haven't seen how without getting a working/reliable interdiff | 21:04 |
| openstackgerrit | Merged openstack-infra/project-config: Remove Registered Users from seeting -1..1 in Code-Review https://review.openstack.org/280439 | 21:04 |
| clarkb | I mean even with that leakge it is really readable | 21:05 |
| *** sarob_ has joined #openstack-infra | 21:06 | |
| jeblair | clarkb: yeah, but it's not correct -- it's suggesting something changed in the update when it really came from the rebase | 21:06 |
| *** sputnik13 has quit IRC | 21:06 | |
| clarkb | but only because git diff is smart and showing us a bunch of unnecessary context | 21:06 |
| lifeless | aaron bentley solved this comprehensively for bzr | 21:07 |
| clarkb | which should be toggleable (looking for that now) | 21:07 |
| *** sputnik13 has joined #openstack-infra | 21:07 | |
| lifeless | but you need to track where the lines came from, and only show lines - added or removed - that originated in the patch side, not the mainline | 21:07 |
| *** sdague has quit IRC | 21:07 | |
| lifeless | I'm not aware of an implementation of that for git; be happy to find out I'm just ignorant :) | 21:08 |
| *** sputnik13 has quit IRC | 21:08 | |
| clarkb | lifeless: isn't the inner diff doing that? gives you the lines from the patches | 21:08 |
| *** _sarob has quit IRC | 21:09 | |
| openstackgerrit | Colleen Murphy proposed openstack-infra/puppet-infracloud: Update SSL configuration https://review.openstack.org/279286 | 21:10 |
| lifeless | clarkb: well you need to mask out the line offset hunks for instance | 21:11 |
| lifeless | clarkb: because if e.g. master adds 5 lines, but the patches only change was the hunk offset, you shouldn't show that in a diff of the two versions of the patch | 21:11 |
| *** kgiusti has left #openstack-infra | 21:11 | |
| lifeless | clarkb: but if the patch was actually changed to apply to a matching context 15 lines down, you should show that | 21:11 |
| *** wolverineav has quit IRC | 21:11 | |
| lifeless | even if the only change is the hunk offset | 21:12 |
| *** asselin_ has joined #openstack-infra | 21:12 | |
| *** apoorvad has joined #openstack-infra | 21:12 | |
| tristanC | ttx: (and interested folks too): for the Newton PTL/TC election, here is the proposed timeline: https://review.openstack.org/#/c/278102/2/events.yaml | 21:12 |
| *** jsavak has quit IRC | 21:14 | |
| *** bpokorny has quit IRC | 21:14 | |
| clarkb | yup I thought there was a way to set the git diff format but it seems to insist on those (which make sense in the context of diff I suppose) | 21:14 |
| *** sarob_ has quit IRC | 21:15 | |
| *** _sarob has joined #openstack-infra | 21:15 | |
| *** daemontool__ has joined #openstack-infra | 21:17 | |
| *** austin81 has joined #openstack-infra | 21:17 | |
| jeblair | lifeless: git->bzr and then ask bzr for the result? :) | 21:17 |
| lifeless | jeblair: it would work :) | 21:17 |
| lifeless | jeblair: but, maybe a tad slow | 21:17 |
| clarkb | you can format git diff output but not the diff itself looks like | 21:18 |
| fungi | tristanC: so ideally ptls have at most 3 more tc meeting sessions/weeks to get extra-atcs entries added before voting begins (but probably only 2 if they also want those extra-atcs to get summit registration discount codes) | 21:18 |
| *** fawadkhaliq has quit IRC | 21:18 | |
| *** daemontool_ has quit IRC | 21:20 | |
| jeblair | clarkb: i wonder if this is perhaps becoming more of an issue because we were less likely in the past to make a new revision of a patch that has been sitting unreviewed for 5 months. | 21:20 |
| *** alivigni has quit IRC | 21:20 | |
| tristanC | fungi: alright, to avoid last time liberty-mitaka timeframe overlapping with elections, we defined the mitaka-newton timeframe to end right before candidacy submission, so atc roll should be extracted from contribution made between March 4, 2015 00:00 UTC and March 3, 2016 23:59 UTC | 21:20 |
| jeblair | (or partially reviewed) | 21:21 |
| tristanC | fungi: (if that works for you) | 21:21 |
| fungi | tristanC: that sounds good. that's right after feature freeze too | 21:22 |
| tristanC | hum, that's 3 week sharp from now, so that could be adjusted to right before actual election, so March 10 | 21:22 |
| fungi | tristanC: also fine, but we should get ttx to add the election tag to the governance repo on whatever date that is | 21:23 |
| *** sdake_ has joined #openstack-infra | 21:24 | |
| fungi | tristanC: something like 24 hours before election starting is appreciated because that allows me to get you the rolls in advance | 21:24 |
| *** dprince has quit IRC | 21:24 | |
| fungi | rather than delaying the start of the election while you wait for me to generate them | 21:24 |
| *** sdake has quit IRC | 21:25 | |
| tristanC | fungi: noted, so March 4 deadline seems the more convenient | 21:25 |
| fungi | tristanC: yeah, sounds a little better | 21:27 |
| *** baoli has quit IRC | 21:29 | |
| jeblair | clarkb: i don't understand why interdiff is confused about the second and third hunks -- is it the line numbers? | 21:31 |
| ianw | greghaynes: do you know off-hand if 1.11.0 dib release got last night's builds? (i haven't done the timestamp analysis yet) | 21:31 |
| greghaynes | ianw: very unlikely | 21:32 |
| greghaynes | ianw: I did it a few hours ago and builds happen very late PST night IIRC | 21:32 |
| ianw | greghaynes: ok, cool, just noticed the tag when i pulled | 21:32 |
| clarkb | jeblair: yes that code moved and the lin numbers changed, it is the thing lifeless was tlaking about | 21:32 |
| clarkb | jeblair: basically if we filter out line numbers for viewing but preserve them for commenting this should work | 21:33 |
| clarkb | but does require more processing than git seems t provide out of the bix | 21:33 |
| *** Sukhdev has joined #openstack-infra | 21:33 | |
| lifeless | that heuristic can be wrong too, but as a first approximation it would be pretty good | 21:34 |
| *** bpokorny has joined #openstack-infra | 21:34 | |
| *** Sukhdev has quit IRC | 21:35 | |
| *** infra-red has quit IRC | 21:35 | |
| openstackgerrit | Austin Clark proposed openstack-infra/project-config: Create stackviz element and script in nodepool (WIP) https://review.openstack.org/279317 | 21:35 |
| *** dims has quit IRC | 21:37 | |
| *** daemontool has joined #openstack-infra | 21:38 | |
| *** jtomasek_ has quit IRC | 21:39 | |
| *** daemontool__ has quit IRC | 21:42 | |
| openstackgerrit | Ian Cordasco proposed openstack-dev/pbr: Include wsgi_scripts in generated wheels https://review.openstack.org/280270 | 21:43 |
| *** weshay has quit IRC | 21:44 | |
| austin81 | ianw: Thanks for the comment on https://review.openstack.org/#/c/279317/ . Do you think it should be a separate element? | 21:44 |
| sigmavirus24 | lifeless: added a test but I'm not sure if I need more than that. I didn't see any tests for the other internal functions in pbr.packaging so I didn't add any for the functions I made | 21:44 |
| ianw | austin81: i feel like it's probably a separate thing enough to justify one. greghaynes might have an opinion too | 21:45 |
| jeblair | clarkb: i don't see how to accomplish this by removing line numbers...... | 21:46 |
| *** wolverineav has joined #openstack-infra | 21:46 | |
| clarkb | jeblair: you would filter those lines out of thediffs before interdiffing | 21:46 |
| *** wolverineav has quit IRC | 21:46 | |
| jeblair | clarkb: but i think interdiff parses those? | 21:46 |
| clarkb | its just diff | 21:46 |
| clarkb | so if those lines are different they show up | 21:46 |
| *** wolverineav has joined #openstack-infra | 21:46 | |
| jeblair | clarkb: oh you're saying diff | 21:46 |
| clarkb | grep -v ^@@ | 21:46 |
| clarkb | orsometing | 21:46 |
| openstackgerrit | Merged openstack/requirements: update docker-py to 1.6.0 https://review.openstack.org/270625 | 21:47 |
| jeblair | clarkb: well we don't have to do anything with diff, except that diff of a diff doesn't output a diff that we can understand | 21:47 |
| jeblair | programatically... | 21:47 |
| openstackgerrit | Merged openstack/requirements: Try to avoid future attempts to 'fix' usage of mock https://review.openstack.org/279329 | 21:47 |
| greghaynes | austin81: Yea, I would recommend making another element | 21:47 |
| jeblair | clarkb: we just get this: | 21:47 |
| jeblair | < + exp = exp.filter(node_table.c.state == state) | 21:47 |
| jeblair | > + exp = exp.filter(snapshot_image_table.c.state == state) | 21:47 |
| clarkb | right thats prorammtically parseable | 21:48 |
| clarkb | means left side used the first line and right side used second line | 21:48 |
| jeblair | clarkb: yeah, but which lines in the patch are those? | 21:48 |
| clarkb | you retain the line number information you just don't use it in calculating then interdiff which allows you to determine the line numbers for each of those | 21:48 |
| clarkb | jeblair: whatever the @@ line says it is | 21:48 |
| *** |-paul-| has quit IRC | 21:49 | |
| jeblair | clarkb: this s the relevant section of the diff output: http://paste.openstack.org/show/487182/ | 21:49 |
| austin81 | ianw, greghaynes: Ok great I'll get to work on that. Is there a way to tell packages.yaml to install nodejs-legacy on ubuntu and just nodejs on others? | 21:49 |
| greghaynes | austin81: yes, check out http://docs.openstack.org/developer/diskimage-builder/elements/pkg-map/README.html | 21:50 |
| *** dims has joined #openstack-infra | 21:50 | |
| openstackgerrit | Merged openstack-infra/project-config: Make postgres job non-voting on Ironic and switch it to IPA https://review.openstack.org/280888 | 21:50 |
| *** gyee has joined #openstack-infra | 21:50 | |
| jeblair | clarkb: but nothing there tells me how to get to that part of the inter-patchset-diff | 21:50 |
| clarkb | jeblair: what I am trying to say is that the interdiff (outer diff call) has to be smart | 21:50 |
| clarkb | jeblair: the diff utility is not smart like that | 21:51 |
| clarkb | but it is doable | 21:51 |
| jeblair | clarkb: okay, i'm trying to understand how to implement "smart" | 21:51 |
| clarkb | jeblair: for each line in either inner diff annotate with meta data, line no, add minus etc | 21:51 |
| clarkb | jeblair: then diff them, show the differences with the preparsed metadata | 21:51 |
| openstackgerrit | Merged openstack/requirements: Add watcher and python-watcherclient to projects.txt https://review.openstack.org/278321 | 21:52 |
| jeblair | clarkb: the inner diff is the patchset diff? eg, 'git show patchset1' and 'git show patchset2'? | 21:53 |
| clarkb | jeblair: yes | 21:53 |
| jhesketh | Morning | 21:53 |
| clarkb | that gives you the difference between that patchset and its parent | 21:53 |
| jeblair | clarkb: and you are suggesting annotating every line of that with metadata? | 21:54 |
| clarkb | jeblair: doesn't have to be every line but every line makes it easier to do the interdiff | 21:54 |
| *** mriedem has quit IRC | 21:55 | |
| jeblair | clarkb: https://etherpad.openstack.org/p/FAN6LW3B5c | 21:55 |
| *** roxanaghe has joined #openstack-infra | 21:55 | |
| *** rhallisey has quit IRC | 21:55 | |
| *** _sarob has quit IRC | 21:56 | |
| *** roxanaghe has quit IRC | 21:56 | |
| jeblair | clarkb: you're creating a data structure, and i'm creating a text file..... | 21:57 |
| jeblair | clarkb: when you said "annotate the lines before running a diff" i thuoght you meant run diff | 21:57 |
| *** roxanaghe has joined #openstack-infra | 21:57 | |
| clarkb | no | 21:57 |
| clarkb | that is what I was saying | 21:57 |
| clarkb | diff cannot do this | 21:58 |
| clarkb | but that doens't mean somethingelse can't | 21:58 |
| *** jtomasek has quit IRC | 21:58 | |
| jeblair | clarkb: okay, a while back you said something about preprocessing things... | 21:58 |
| jeblair | clarkb: are you saying all we have to do is implement diff? | 21:58 |
| *** tongli has quit IRC | 21:59 | |
| clarkb | not necessarily, you likely can use existing diffing tools if you maintain the metadata elsewhere and can map back to it | 21:59 |
| jeblair | clarkb: do you have an idea of how to do that? | 21:59 |
| jeblair | clarkb: because i'm really serious about implementing this, and it sounded like you have figured out a way, and i'm trying really hard to understand what that is. | 22:00 |
| lifeless | there is python code to parse diffs around | 22:00 |
| jeblair | lifeless: i know, i use a lot of it in gertty | 22:00 |
| *** annegent_ has joined #openstack-infra | 22:00 | |
| clarkb | jeblair: one way would be to do like you were saying, create a new string representation, diff that, then do extra parsing around the results to decide if something should be present or not | 22:01 |
| *** arxcruz has joined #openstack-infra | 22:01 | |
| clarkb | basically there has to be a way to carry the information forward | 22:01 |
| jeblair | clarkb: maybe we're focusing on the wrong thing | 22:01 |
| jeblair | because this conversation has turned toward parsing diffs, which is a pretty easy problem | 22:02 |
| clarkb | right so steps are parse first diffs to know what line numbers and such are before they get lost interdiffing. Then diff the diffs, map the parsed info onto the interdiff | 22:03 |
| *** salv-orlando has joined #openstack-infra | 22:03 | |
| *** thorst has quit IRC | 22:03 | |
| jeblair | okay, so when you diff the diff, how do you map the results of that back to the hunks you parsed in step 1? | 22:03 |
| *** sridhar_ram1 has joined #openstack-infra | 22:03 | |
| jeblair | from what i see, we've lost the identifying information | 22:03 |
| clarkb | the way I would do it is by diffing the data structures and not the text | 22:03 |
| *** thorst has joined #openstack-infra | 22:03 | |
| *** sridhar_ram has quit IRC | 22:04 | |
| clarkb | naive way of doing that is find difference between two sets, sort by line no, filename print | 22:04 |
| clarkb | probably not very performant but should be correct | 22:04 |
| *** annegentle has quit IRC | 22:05 | |
| *** daemontool has quit IRC | 22:05 | |
| *** salv-orl_ has quit IRC | 22:05 | |
| *** annegent_ has quit IRC | 22:05 | |
| lifeless | sigmavirus24: the helper /should/ be unit tested please. | 22:06 |
| *** ZZelle_ has joined #openstack-infra | 22:06 | |
| *** annegentle has joined #openstack-infra | 22:06 | |
| lifeless | sigmavirus24: I'll look in a bit to assess the exterior coverage | 22:06 |
| sigmavirus24 | lifeless: the generate_script helper? | 22:06 |
| *** tpsilva has quit IRC | 22:06 | |
| greghaynes | clarkb: Sorry to interrupt, but are you planning to restart nodepool still? | 22:07 |
| lifeless | sigmavirus24: please. pbr has a history of poor coverage and we've been lifting the bar incrementally | 22:07 |
| clarkb | jeblair: if this was C you could use pointers into the same list of strings | 22:07 |
| clarkb | greghaynes: I wanted to get these fixes in but maybe that isn't happening | 22:07 |
| *** thorst_ has joined #openstack-infra | 22:07 | |
| greghaynes | clarkb: Yea, I think tripleo is :( | 22:07 |
| *** jdurgin has quit IRC | 22:07 | |
| sigmavirus24 | lifeless: certainly. I know some people think things can be tested too much and I wasn't sure if that was pbr's philosophy | 22:07 |
| *** thorst has quit IRC | 22:08 | |
| jeblair | clarkb: still comparing a hunk at a time? | 22:08 |
| clarkb | jeblair: that would probably keep the code more manageable and possible let you to leave out some state like filename | 22:09 |
| jeblair | clarkb: i guess i'm wondering how do you decide which line record to compare another one too? | 22:10 |
| clarkb | yup you would do that by hunk | 22:10 |
| *** _sarob has joined #openstack-infra | 22:10 | |
| *** thorst_ has quit IRC | 22:11 | |
| *** baoli has joined #openstack-infra | 22:12 | |
| lifeless | sigmavirus24: I think they can be too; but we're not at that point :) | 22:12 |
| *** baoli_ has joined #openstack-infra | 22:12 | |
| lifeless | sigmavirus24: my threshould is about 10K unit tests for a mid-sized CLI program. | 22:12 |
| clarkb | jeblair: another approach more similar to what you had in mind the first time is the parse the outer diff to map back to inner diffs | 22:13 |
| clarkb | actually that might be ebtter in general | 22:13 |
| clarkb | so first diff the inner diffs, parse the inner diffs and remove any information whihc is not required (like commit shas and so on) | 22:14 |
| clarkb | then diff the two diffs, use metdata data in interdiff to map lines in interdiff back to their respective diffs | 22:14 |
| *** thiagop has quit IRC | 22:15 | |
| clarkb | that is likely more memory but easier to reason about? | 22:15 |
| clarkb | since you need to keep all three "files" in memory | 22:16 |
| *** sputnik13 has joined #openstack-infra | 22:16 | |
| jeblair | clarkb: i don't see how to annotate the diffs in a way to do that though -- the metadata would be different for either side | 22:16 |
| *** baoli has quit IRC | 22:16 | |
| clarkb | let me try pasting an example | 22:16 |
| jeblair | clarkb: and if you knew two lines in each side were actually the same (and could therefore put in the same metadata), you'd be done already. i'm struggling with a similar situation in the data-structure version of this -- how do you decide which 2 lines to compare at any point. | 22:17 |
| jeblair | clarkb: oh, i see what you pasted... lemme digest | 22:18 |
| clarkb | jeblair: you do have to maintain externa lstate as you go because the diff output is not sufficient, but if you do that I think it will work | 22:19 |
| clarkb | *because the interdiff output is not sufficient | 22:20 |
| clarkb | it essentially becomes file by file diffing with pointer arithmetic back to the original content | 22:21 |
| openstackgerrit | Austin Clark proposed openstack-infra/project-config: Create stackviz element and script in nodepool (WIP) https://review.openstack.org/279317 | 22:23 |
| austin81 | ianw, greghaynes: ^ think I got it | 22:23 |
| sigmavirus24 | lifeless: good to know | 22:23 |
| sigmavirus24 | lifeless: do you want me to test private methods too? | 22:24 |
| *** onovy has quit IRC | 22:24 | |
| *** peterlisak has quit IRC | 22:24 | |
| *** sabeen3 has quit IRC | 22:24 | |
| *** thorst has joined #openstack-infra | 22:24 | |
| clarkb | grr my tests broke on a thing that I thouht I had tested | 22:25 |
| * clarkb fixes then will restart nodepool | 22:25 | |
| *** tzn has joined #openstack-infra | 22:25 | |
| *** flepied1 is now known as flepied | 22:26 | |
| *** sabeen1 has joined #openstack-infra | 22:26 | |
| lifeless | sigmavirus24: maybe? :) | 22:27 |
| *** onovy has joined #openstack-infra | 22:28 | |
| *** dkranz has quit IRC | 22:28 | |
| *** sabeen3 has joined #openstack-infra | 22:28 | |
| *** thorst has quit IRC | 22:28 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Delete building images on startup https://review.openstack.org/226114 | 22:30 |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Test building node cleanup on nodepool startup https://review.openstack.org/280909 | 22:30 |
| clarkb | now hopefully with working tests | 22:30 |
| *** miqui has quit IRC | 22:30 | |
| *** tzn has quit IRC | 22:30 | |
| *** peterlisak has joined #openstack-infra | 22:30 | |
| *** sabeen1 has quit IRC | 22:30 | |
| *** annegentle has quit IRC | 22:31 | |
| *** annegentle has joined #openstack-infra | 22:31 | |
| *** qb_ has joined #openstack-infra | 22:31 | |
| *** tykeal has joined #openstack-infra | 22:32 | |
| clarkb | we have one building image in nodepool still, so either we get that first change merged then restart or we wait for build to finish | 22:33 |
| clarkb | greghaynes: ^ | 22:33 |
| tykeal | I have a question about zuul and nodepool. I see nothing in the docs that inform when a given slave VM gets disposed of. Is it after a job is completed on the slave VM that was triggered by zuul? Do all slaves operate as single-use slaves then? | 22:34 |
| openstackgerrit | Merged openstack-infra/nodepool: Deprecated tox -downloadcache option removed https://review.openstack.org/256755 | 22:34 |
| clarkb | tykeal: if you attach nodepool to jenkins via the zmq event plugin then any build finished events that nodepool can find a matching node for will result in that node being deleted | 22:35 |
| *** annegentle has quit IRC | 22:35 | |
| tykeal | clarkb: even if that build wasn't initiated by zuul? | 22:36 |
| clarkb | yes | 22:36 |
| openstackgerrit | Tim Burke proposed openstack-dev/hacking: Run all flake8 checks https://review.openstack.org/276500 | 22:36 |
| austin81 | ianw: In reference to https://review.openstack.org/#/c/279317/5/nodepool/elements/stackviz/install.d/99-prepare-stackviz was there a patch that fixed this issue? Seemed like it was included in all the other elements to get around some sort of lint bug? | 22:37 |
| tykeal | hrmm... doesn't seem to be working for me then. I'm bringing up a nodepool system for the first time and have a test slave configured that properly connects to jenkins. If I build a simple job that executes on that slave it doesn't seem to delete it after completion | 22:37 |
| *** rhallisey has joined #openstack-infra | 22:38 | |
| clarkb | tykeal: do you have the zmq event plugin running against your jobs? | 22:38 |
| tykeal | I've got it enabled globally. Does it need to be enabled per job? | 22:38 |
| clarkb | nodepool relies on that for the information | 22:38 |
| clarkb | globally should be sufficient | 22:38 |
| clarkb | tykeal: can nodepool connect to it? eg no firewall in the way? | 22:38 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/requirements: Upperbound on pysaml2 to avoid pycryptodome https://review.openstack.org/280968 | 22:38 |
| clarkb | tykeal: telnet $jenkinshost $portinuse | 22:38 |
| tykeal | hmm... let me verify that I actually have it enabled globally, I've already check firewall | 22:38 |
| tonyb | When/how does gerrit decide to remove prior +2's? I see one that survived a manual edit which doesn't seem right to me. | 22:39 |
| tykeal | ah... no it wasn't globally enabled. let me retry | 22:39 |
| clarkb | tonyb: it retains them on what it considers a trivial rebase | 22:39 |
| clarkb | tonyb: no commit message changes and the sha1 of the diff remains the same ignoring whitespace | 22:39 |
| clarkb | tonyb: the ignoring whitespace bit because git is C centric | 22:39 |
| jeblair | clarkb: okay, so that process would tell us which of the hunks in the patches are different, but we still need to actually run the interdiff command to generate a diff to get something to display | 22:40 |
| tonyb | clarkb: Hmm okay, I added a whole new line but perhaps it's a special case as my my PS (4) matches PS2 which is the one that was +2'd PS3 was uplaoded by the propsals bot and l=missed a manually added line | 22:41 |
| clarkb | jeblair: yes you need a thing (call it interdiff) implemented somewhere that knows how to display the interdiff based on the 3 diffs | 22:41 |
| jeblair | clarkb: you know about the interdiff command, right? | 22:41 |
| clarkb | jeblair: no | 22:41 |
| clarkb | is hat already a thing? | 22:41 |
| tonyb | clarkb: yeah. | 22:42 |
| jeblair | omg no wonder we've been talking around each other. :) | 22:42 |
| jeblair | 21:01 < jeblair> clarkb: interdiff <(git show 318e6e41bdc6c9d4d8eb77e475bd360fb0345687) <(git show 055c0064442bf4f7c08d6692a7ad86eb50182f90) | 22:42 |
| clarkb | jeblair: ya looking at that now | 22:43 |
| tykeal | ah, sweet. thanks clarkb that was the key. | 22:43 |
| clarkb | jeblair: now I am really confused on what is missing | 22:43 |
| *** tiswanso has quit IRC | 22:43 | |
| clarkb | jeblair: that seems to give you what I have been talking about? file, line no, context, etc | 22:43 |
| *** gordc has quit IRC | 22:43 | |
| jeblair | 21:31 < jeblair> clarkb: i don't understand why interdiff is confused about the second and third hunks -- is it the line numbers? | 22:43 |
| jeblair | clarkb: when i said that (and you responded!) i literally meant i ran the interdiff command and the output is not what we want | 22:44 |
| openstackgerrit | Tim Buckley proposed openstack-infra/devstack-gate: Install and run StackViz during devstack-gate host cleanup. (WIP) https://review.openstack.org/212207 | 22:44 |
| jeblair | clarkb: this is the output: http://paste.openstack.org/show/487198/ | 22:44 |
| *** dingyichen has joined #openstack-infra | 22:44 | |
| clarkb | oh I thought you meant you ran an interdiff with diff which is what my example command was | 22:44 |
| clarkb | in any case I do not know why interdiff is doing that, oyu can completely work around it using what I have described | 22:45 |
| jeblair | clarkb: it had no third hunk | 22:45 |
| *** EricGonczer_ has quit IRC | 22:45 | |
| jeblair | clarkb: interdiff produces 4 hunks, the middle 2 of which are erroneous | 22:45 |
| clarkb | right that should all be fixable by not using interdiff | 22:46 |
| jeblair | oh, sorry... 6 and middle 4 | 22:46 |
| clarkb | which is what I have been trying to explain all along | 22:46 |
| clarkb | ya its two pairs of hunks | 22:46 |
| clarkb | that are inverses of each other on different lines | 22:46 |
| clarkb | which I think is a move | 22:46 |
| jeblair | clarkb: i've seriously been trying to understand your explanation | 22:47 |
| *** j_king has quit IRC | 22:47 | |
| clarkb | jeblair: use diff | 22:47 |
| clarkb | to get the interdiff | 22:47 |
| *** dims has quit IRC | 22:47 | |
| clarkb | then you can map from that interdiff back to the original diffs and figure out the details youself | 22:47 |
| clarkb | diff does not erroneously do this | 22:48 |
| jeblair | clarkb: "figure out the details yourself" ? | 22:48 |
| *** daemontool has joined #openstack-infra | 22:48 | |
| clarkb | jeblair: in gertty or gerrit do what I describe on the etherpad | 22:48 |
| jeblair | clarkb: right, so... as i was saying... you have mapped back to the original patchsets | 22:49 |
| jeblair | clarkb: but not to a diff between them | 22:49 |
| clarkb | jeblair: the diff between them is the 3rd diff | 22:49 |
| clarkb | jeblair: you display that third diff with line numbers determined by mapping back | 22:50 |
| *** Nakato has quit IRC | 22:50 | |
| *** Nakato has joined #openstack-infra | 22:50 | |
| jeblair | clarkb: and generate context lines ourselves too? | 22:50 |
| clarkb | yes | 22:50 |
| clarkb | but then you can avoid interdiffs super correct behavior | 22:51 |
| clarkb | I am sure it is hsowing you code moves now | 22:51 |
| *** regXboi has quit IRC | 22:52 | |
| clarkb | woo rax upload timed out :/ | 22:52 |
| *** changbl has quit IRC | 22:52 | |
| clarkb | we may still have trouble with uploads once the token stuff is working | 22:52 |
| clarkb | but this means I can restart the service now | 22:52 |
| clarkb | jeblair: now that I understand whta you were saying you have two choices, do interdiffing yourself to avoid code moves like that or use interdiff and accept that as overhead for correctness | 22:53 |
| jeblair | clarkb: well, it's not correct -- it is not actually a change introduced by the patchset author. so it would be a disservice to show it to the user. | 22:54 |
| clarkb | it is correct in that it is a difference between the two diffs but you are right it is unrelated to the current changes | 22:54 |
| clarkb | this is what lifeless was talking abut earlier though | 22:54 |
| clarkb | you can fudge around the lin number moves | 22:55 |
| *** pradk has quit IRC | 22:55 | |
| clarkb | I am restarting nodepool now | 22:55 |
| jeblair | if you can identify them | 22:55 |
| *** rossella_s has quit IRC | 22:57 | |
| clarkb | bluebox just had a bunch of launch status errors | 22:58 |
| *** rossella_s has joined #openstack-infra | 22:58 | |
| jeblair | clarkb: i don't think we have arrived at a solution that will reliably show the actual difference in patchsets. we are either faced with showing extra hunks from moves from the rebase, or not showing potentially legitimate moves (like if you move the same code down 15 lines as lifeless says) | 22:59 |
| clarkb | I do not see tripleo cloud errors | 22:59 |
| clarkb | jeblair: we could hsow the moves and let the reviewer sort it out? | 22:59 |
| clarkb | that seems the most conservative | 22:59 |
| clarkb | gerrit's trivial rebase ignores moves iirc which is the other end of the spectrum | 23:00 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:00 | |
| openstackgerrit | Austin Clark proposed openstack-infra/project-config: Create stackviz element and script in nodepool (WIP) https://review.openstack.org/279317 | 23:00 |
| clarkb | I think you could argue it either way | 23:01 |
| fungi | it only ignores moves if the context lines all also match, but patch has similar issues when you get into situations like that, as does git cherry-pick/rebase/merge | 23:01 |
| *** wolverin_ has joined #openstack-infra | 23:02 | |
| jeblair | and in this case, interdiff produced 4 nonsense hunks | 23:02 |
| clarkb | they aren't nonsense | 23:02 |
| mordred | clarkb: "rax upload timed out" - is that with oscc patch? or without? | 23:03 |
| clarkb | they show that modified code in the old version is still modified in the new version but at a different location | 23:03 |
| lifeless | all diff tools are essentially heuristics | 23:03 |
| clarkb | mordred: without | 23:03 |
| *** wolverin_ has quit IRC | 23:03 | |
| clarkb | mordred: builder wouldn't have been restrated recently enough to pick up any new oscc releases | 23:04 |
| *** shashank_hegde has quit IRC | 23:04 | |
| mordred | clarkb: hasn't released - I wasn't sure if you happened to be trying the patch | 23:04 |
| *** wolverineav has quit IRC | 23:04 | |
| jeblair | clarkb: well, what we actually, _actually_ need to display, is a subset of what we get from 'git diff ps1 ps2' | 23:04 |
| clarkb | mordred: nope this is just production, that is a different error than the auth fail though | 23:05 |
| mordred | clarkb: I think I'm waiting on feedback from you to merge it - but I can merge it before feedback if that makes more sense | 23:05 |
| clarkb | mordred: oh huh I had no idea | 23:05 |
| mordred | clarkb: well - i've been in and out :) | 23:05 |
| openstackgerrit | Merged openstack-infra/irc-meetings: A meeting for discussing and coordinating routed networks https://review.openstack.org/278114 | 23:05 |
| clarkb | mordred: the feedback you were getting from swift peoples was good and I had nothing to add really | 23:05 |
| openstackgerrit | Matthew Treinish proposed openstack-infra/shade: Add a method to download an image from glance https://review.openstack.org/278816 | 23:05 |
| mordred | clarkb: kk | 23:05 |
| mtreinish | mordred, SpamapS: ^^^ should pass tests now | 23:05 |
| mordred | Shrews, notmorgan: when you have a sec: https://review.openstack.org/#/c/278797/ | 23:06 |
| clarkb | mordred: if you want to test the trivial reproduction would be get_swift_client(), time.time = time.time + token_expiry + 1, upload object | 23:06 |
| clarkb | mordred: though that may work if the only token checking is server side hrm | 23:06 |
| clarkb | mordred: you could put a really long sleep in your test <_< | 23:06 |
| mordred | clarkb: ew gross | 23:06 |
| clarkb | jeblair: right the most interesting information isn't what common edited code was moved | 23:07 |
| clarkb | jeblair: however that information is still valuable | 23:07 |
| clarkb | potentially | 23:07 |
| pleia2 | mordred: happy england to you | 23:07 |
| mordred | pleia2: thanks! | 23:07 |
| mordred | pleia2: I'm certainly englanding | 23:07 |
| pleia2 | :) | 23:07 |
| mordred | pleia2: so far today I have tube-d and gin-d | 23:07 |
| notmorgan | mordred: ++ to englandling | 23:07 |
| *** Sukhdev has joined #openstack-infra | 23:07 | |
| *** shashank_hegde has joined #openstack-infra | 23:07 | |
| mordred | pleia2: I showed your opensourceinfra.org thing to robyn bergeron a little earlier today, btw | 23:08 |
| clarkb | jeblair: at least for this example my idea would work if you ignored file line diffs | 23:08 |
| pleia2 | mordred: cool, it has a pretty layout now | 23:08 |
| *** sdake_ has quit IRC | 23:09 | |
| *** apoorvad has quit IRC | 23:09 | |
| jeblair | clarkb: so if we view the output of the interdiff program as our very conservative superset of what we should display -- how do we map that output back to an accurate diff between the two patchsets (with correct line numbers, etc)? | 23:09 |
| clarkb | jeblair: http://paste.openstack.org/show/487202/ is what the raw output looks like and you would just treat that as no delta | 23:09 |
| mordred | pleia2: yes - I noticed the difference | 23:09 |
| clarkb | jeblair: for your interdiff example you would show the move, data is removed over here and added over there. For the idea I have about ignoring it you just wouldn't show those line number only differences | 23:10 |
| *** wolverineav has joined #openstack-infra | 23:11 | |
| clarkb | jeblair: note that I still like using diff here so that you can produce the interdiff without working aorund the decisions interdiff has made for you, unless you wish to stick with the decisions it has made | 23:11 |
| *** apoorvad has joined #openstack-infra | 23:12 | |
| notmorgan | mordred: wow, looking at the diff and... ugh. | 23:12 |
| notmorgan | mordred: at least it's not unreadable. | 23:12 |
| notmorgan | mordred: but... bleh on not havving session support (I've taken a couple stabs and it's a bit of work) | 23:13 |
| jeblair | clarkb: okay, but of all the diffs we've talked about, only 'git diff ps1..ps2' has the actual information needed to display a diff to the user (lines changed with old and new line numbers). | 23:13 |
| jeblair | clarkb: if you work back to the patchset diffs, you could probably reconstruct that | 23:13 |
| clarkb | I don't follow that | 23:14 |
| clarkb | each of the initial diff has the information to display a diff doesn't it? | 23:14 |
| *** wolverineav has quit IRC | 23:14 | |
| clarkb | for each side you get the offsets | 23:14 |
| mordred | notmorgan: yah - I mean, I think the team there groks/desires adding session support | 23:14 |
| notmorgan | mordred: they do. | 23:14 |
| mordred | notmorgan: so it's not anything they're opposed to | 23:14 |
| notmorgan | mordred: but it's a lot of unwinding requests-specific code and layering it into ksa session code | 23:15 |
| notmorgan | mordred: subtle differences that aren't hard to do,just time consuming to hit every case where a ksa session != requests session perfectly | 23:15 |
| mordred | yup | 23:17 |
| notmorgan | mordred: if ksa session were an adapter mounted to a requests session... this would be tons easier to do/support. but that isn't really "doable | 23:17 |
| notmorgan | " | 23:17 |
| notmorgan | either. | 23:17 |
| *** rcernin has quit IRC | 23:18 | |
| mordred | notmorgan: what if we wrote an adapter which took a ksa session and mounted it to a requests session? | 23:18 |
| mordred | notmorgan: that was not the new interface for things | 23:19 |
| mordred | notmorgan: but was like LegacyJSONAdapter | 23:19 |
| notmorgan | mordred: the ksa stuff does some things you can't do with request session iirc | 23:19 |
| jeblair | clarkb: yes, i think we're on the same page there -- using diff against the two patches, you can construct a synthetic diff of the lines that have changed. you will need to map back to get the correct old/new line numbers. | 23:19 |
| notmorgan | adapters | 23:19 |
| mordred | notmorgan: in that it's a stepping stone from the old to the new | 23:19 |
| mordred | notmorgan: oh, bother | 23:19 |
| notmorgan | we'd still need some wrapping of methods directly i think. | 23:19 |
| notmorgan | we could simplify it and make it a subclass probably | 23:19 |
| *** flwang has quit IRC | 23:19 | |
| notmorgan | rather than a object that has a .session on it | 23:19 |
| jeblair | clarkb: this approach will not show you any extra information, but it may also not show you a relevant change if someone, say, moves where they added a function. | 23:20 |
| clarkb | jeblair: correct | 23:20 |
| jeblair | clarkb: if we say we want to be conservative and show potentially extra information in case a move is relevant, we can use interdiff | 23:20 |
| clarkb | jeblair: yup | 23:20 |
| jeblair | clarkb: but i don't see how to make sense of the 4 hunks i keep calling nonsense :) | 23:21 |
| clarkb | jeblair: you just display them | 23:21 |
| clarkb | on the old side you will have removals and on the new side you will have additions | 23:21 |
| *** [1]Thelo has joined #openstack-infra | 23:22 | |
| *** wolverineav has joined #openstack-infra | 23:22 | |
| clarkb | that show code was at old location and now resides at new location | 23:22 |
| jeblair | clarkb: i must be reading the output wrong, because it looks like it says change A->B at 1423 and change B->A at 1858 | 23:23 |
| openstackgerrit | Colleen Murphy proposed openstack-infra/puppet-infracloud: Use SSL for rabbitmq traffic https://review.openstack.org/276375 | 23:24 |
| *** Thelo has quit IRC | 23:24 | |
| *** [1]Thelo is now known as Thelo | 23:24 | |
| clarkb | jeblair: it is showing you the code on A was at line 1858 and was removed from there and on the B side is added at 1423 | 23:25 |
| clarkb | which is a move | 23:25 |
| jeblair | clarkb: except that it's also saying the code from B was added to A line 1858 | 23:26 |
| jeblair | and vice versa | 23:26 |
| jeblair | clarkb: so i think if we just naively displayed it, it would not actually look like a move | 23:26 |
| clarkb | jeblair: no it is saying the code was already there | 23:26 |
| clarkb | (because it was your first patchset included that code) | 23:26 |
| jeblair | clarkb: if this were a side-by-side diff, it would look like this: | 23:27 |
| clarkb | by removing the lines from 1858 the implication is this code already existed at this location and does not now | 23:27 |
| *** bdemers has joined #openstack-infra | 23:27 | |
| *** _ody_ has joined #openstack-infra | 23:27 | |
| jeblair | 1423 A B | 23:27 |
| jeblair | 1858 B A | 23:27 |
| *** tojuvone_ has joined #openstack-infra | 23:27 | |
| jeblair | and that doesn't look like a move to me | 23:27 |
| clarkb | right because it is a nested diff | 23:28 |
| clarkb | but that is what it is saying | 23:28 |
| jeblair | right, so how do we make sense of that? | 23:28 |
| *** eil397 has joined #openstack-infra | 23:28 | |
| *** max_lobur1 has joined #openstack-infra | 23:29 | |
| *** xyang1_ has joined #openstack-infra | 23:29 | |
| *** ashtokolov_ has joined #openstack-infra | 23:29 | |
| clarkb | by showing all of the info? | 23:29 |
| *** mwhahaha_ has joined #openstack-infra | 23:30 | |
| *** wewe0901_ has joined #openstack-infra | 23:30 | |
| clarkb | you cannot write a single version of this file. With an interdiff you would have to review on the interdiff | 23:30 |
| *** gyee_ has joined #openstack-infra | 23:30 | |
| *** maximov_ has joined #openstack-infra | 23:30 | |
| *** mgkwill_ has joined #openstack-infra | 23:30 | |
| *** DuncanT_ has joined #openstack-infra | 23:30 | |
| *** mkj_wk has quit IRC | 23:31 | |
| clarkb | hrm ok I see the issue with where do you post a review comment | 23:31 |
| *** markvan_ has joined #openstack-infra | 23:31 | |
| clarkb | depending on which of the two gets comments | 23:31 |
| *** tpeoples_ has joined #openstack-infra | 23:31 | |
| jeblair | clarkb: well, that's easy -- either the old side or the new | 23:31 |
| clarkb | right but determining which is which from interdiff ins't easy | 23:32 |
| *** gibi_ has joined #openstack-infra | 23:32 | |
| *** mkj_wk has joined #openstack-infra | 23:32 | |
| *** Vivek_ has joined #openstack-infra | 23:32 | |
| *** nelsnels_ has joined #openstack-infra | 23:33 | |
| *** flwang has joined #openstack-infra | 23:33 | |
| *** kgalanov_ has joined #openstack-infra | 23:33 | |
| *** dham1_ has joined #openstack-infra | 23:33 | |
| notmorgan | Shrews, mordred: ok this is complex enough i can't eyeball it so will score it as soon as i get through it [the .get_swift_client patchset] | 23:33 |
| *** sylwesterB_ has joined #openstack-infra | 23:33 | |
| *** Ryan_Lane_ has joined #openstack-infra | 23:33 | |
| clarkb | I think you could get this info from the diff diff | 23:33 |
| clarkb | maybe | 23:33 |
| clarkb | yes because you know which is which there | 23:34 |
| *** jpmaxman_ has joined #openstack-infra | 23:34 | |
| clarkb | due to the < and ? | 23:34 |
| clarkb | er < and > | 23:34 |
| *** sridhar_ram1 has quit IRC | 23:34 | |
| *** ruhe2 has joined #openstack-infra | 23:35 | |
| *** sweston_ has joined #openstack-infra | 23:35 | |
| *** dimtruck is now known as zz_dimtruck | 23:35 | |
| *** iremizov_ has joined #openstack-infra | 23:35 | |
| *** Ng_ has joined #openstack-infra | 23:35 | |
| *** cburgess has joined #openstack-infra | 23:35 | |
| *** EmilienM_ has joined #openstack-infra | 23:35 | |
| *** itsuugo_ has joined #openstack-infra | 23:35 | |
| *** fbo_ has joined #openstack-infra | 23:35 | |
| *** sridhar_ram has joined #openstack-infra | 23:35 | |
| jeblair | clarkb: wait, this doesn't show up in the diff diff... | 23:36 |
| clarkb | jeblair: it does | 23:36 |
| *** clayton_ has joined #openstack-infra | 23:36 | |
| clarkb | jeblair: http://paste.openstack.org/show/487202/ is how it shows up | 23:36 |
| clarkb | but from that you can tell which is which | 23:36 |
| *** gnuoy` has joined #openstack-infra | 23:36 | |
| *** cgross- has joined #openstack-infra | 23:36 | |
| *** jamespag` has joined #openstack-infra | 23:36 | |
| *** qb_ has quit IRC | 23:37 | |
| *** gyee has quit IRC | 23:37 | |
| *** max_lobur has quit IRC | 23:37 | |
| *** gibi has quit IRC | 23:37 | |
| *** jpr has quit IRC | 23:37 | |
| *** bhunter_ has quit IRC | 23:37 | |
| *** xyang1 has quit IRC | 23:37 | |
| *** wewe0901 has quit IRC | 23:37 | |
| *** ekarlso has quit IRC | 23:37 | |
| *** ruhe has quit IRC | 23:37 | |
| *** nelsnelson has quit IRC | 23:37 | |
| *** nibalizer has quit IRC | 23:37 | |
| *** itsuugo has quit IRC | 23:37 | |
| *** markvan has quit IRC | 23:37 | |
| *** camunoz has quit IRC | 23:37 | |
| *** bdemers_ has quit IRC | 23:37 | |
| *** clayton has quit IRC | 23:37 | |
| *** Vivek has quit IRC | 23:37 | |
| *** sylwesterB has quit IRC | 23:37 | |
| *** ashtokolov has quit IRC | 23:37 | |
| *** Ng has quit IRC | 23:37 | |
| *** tpeoples has quit IRC | 23:37 | |
| *** mwhahaha has quit IRC | 23:37 | |
| *** mkwiek has quit IRC | 23:37 | |
| *** niska has quit IRC | 23:37 | |
| *** EmilienM has quit IRC | 23:37 | |
| *** fbo has quit IRC | 23:37 | |
| *** acabot has quit IRC | 23:37 | |
| *** AJaeger has quit IRC | 23:37 | |
| *** zxiiro has quit IRC | 23:37 | |
| *** iremizov has quit IRC | 23:37 | |
| *** Ryan_Lane has quit IRC | 23:37 | |
| *** _ody has quit IRC | 23:37 | |
| *** tojuvone has quit IRC | 23:37 | |
| *** bswartz has quit IRC | 23:37 | |
| *** cgross has quit IRC | 23:37 | |
| *** clif_h has quit IRC | 23:37 | |
| *** jpmaxman has quit IRC | 23:37 | |
| *** anthonyper has quit IRC | 23:37 | |
| *** cburgess_ has quit IRC | 23:37 | |
| *** jamespage has quit IRC | 23:37 | |
| *** gnuoy has quit IRC | 23:37 | |
| *** Hunner has quit IRC | 23:37 | |
| *** DuncanT has quit IRC | 23:37 | |
| *** dham1 has quit IRC | 23:37 | |
| *** kgalanov has quit IRC | 23:37 | |
| *** sweston has quit IRC | 23:37 | |
| *** ameade has quit IRC | 23:37 | |
| *** monester has quit IRC | 23:37 | |
| *** maximov has quit IRC | 23:37 | |
| *** verdurin has quit IRC | 23:37 | |
| *** vdrok has quit IRC | 23:37 | |
| *** mgkwill has quit IRC | 23:37 | |
| *** johnthetubaguy has quit IRC | 23:37 | |
| *** ruhe2 is now known as ruhe | 23:37 | |
| *** xyang1_ is now known as xyang1 | 23:37 | |
| *** clayton_ is now known as clayton | 23:37 | |
| *** EmilienM_ is now known as EmilienM | 23:37 | |
| openstackgerrit | Colleen Murphy proposed openstack-infra/system-config: Use SSL for rabbitmq https://review.openstack.org/277605 | 23:37 |
| *** wewe0901_ is now known as wewe0901 | 23:37 | |
| *** jamespag` has quit IRC | 23:37 | |
| *** jamespag` has joined #openstack-infra | 23:37 | |
| *** itsuugo_ is now known as itsuugo | 23:37 | |
| *** sylwesterB_ is now known as sylwesterB | 23:37 | |
| *** jpmaxman_ is now known as jpmaxman | 23:37 | |
| clarkb | which clearly shows lhs is 1858 and rhs is 1423 | 23:37 |
| *** EmilienM is now known as Guest28836 | 23:37 | |
| *** iremizov_ is now known as iremizov | 23:37 | |
| clarkb | so you would show the 1858 diff on the lhs and the 1423 diff on the rhs | 23:37 |
| *** roxanaghe has quit IRC | 23:38 | |
| *** ashtokolov_ is now known as ashtokolov | 23:38 | |
| clarkb | then dpeending on where comments go post to the appropriate patchset and line number | 23:38 |
| *** clif_h has joined #openstack-infra | 23:38 | |
| *** kgalanov_ is now known as kgalanov | 23:38 | |
| *** Hunner has joined #openstack-infra | 23:38 | |
| *** Hunner has quit IRC | 23:38 | |
| *** Hunner has joined #openstack-infra | 23:38 | |
| *** Ryan_Lane_ is now known as Ryan_Lane | 23:38 | |
| *** maximov_ is now known as maximov | 23:38 | |
| *** mwhahaha_ is now known as mwhahaha | 23:38 | |
| *** niska has joined #openstack-infra | 23:38 | |
| *** dham1_ is now known as dham1 | 23:38 | |
| openstackgerrit | Colleen Murphy proposed openstack-infra/puppet-infracloud: Use SSL for rabbitmq traffic https://review.openstack.org/276375 | 23:38 |
| *** wolverineav has quit IRC | 23:39 | |
| *** wolverineav has joined #openstack-infra | 23:39 | |
| *** mkwiek has joined #openstack-infra | 23:39 | |
| *** sweston_ is now known as sweston | 23:39 | |
| *** mgkwill_ is now known as mgkwill | 23:39 | |
| *** Ng_ is now known as Ng | 23:39 | |
| *** verdurin has joined #openstack-infra | 23:40 | |
| *** tpeoples_ is now known as tpeoples | 23:40 | |
| *** Guest28836 has quit IRC | 23:41 | |
| *** Guest28836 has joined #openstack-infra | 23:41 | |
| *** roxanaghe has joined #openstack-infra | 23:41 | |
| clarkb | https://review.openstack.org/#/c/226114/5 passed python27 but failed on the coverage job due to the mysql drop db | 23:41 |
| clarkb | so I rechecked it | 23:41 |
| *** Guest28836 is now known as EmilienM | 23:42 | |
| clarkb | time to see if increasing the timeout makes this go away (would imply mysql is just slow) | 23:42 |
| *** zxiiro has joined #openstack-infra | 23:42 | |
| clarkb | and also reduce concurrency | 23:42 |
| *** ameade has joined #openstack-infra | 23:43 | |
| *** camunoz has joined #openstack-infra | 23:43 | |
| *** acabot has joined #openstack-infra | 23:43 | |
| *** DuncanT_ is now known as DuncanT | 23:43 | |
| *** dims_ has joined #openstack-infra | 23:44 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Increase timeout to give mysql more time https://review.openstack.org/280988 | 23:44 |
| *** bhunter_ has joined #openstack-infra | 23:44 | |
| jeblair | clarkb: okay, so diff tells us to display the hunks at 1858 and 1423 -- what do we display? our two original patchsets both have the same thing. basically, they both add the line "image.state = nodedb.DELETE" | 23:44 |
| *** monester has joined #openstack-infra | 23:44 | |
| openstackgerrit | Merged openstack/diskimage-builder: Fix tar listing in functional tests https://review.openstack.org/276037 | 23:45 |
| jeblair | clarkb: do we just ignore what's in the patchsets and simply fetch the contents of the lines in those ranges? | 23:45 |
| mugsie | and/win 21 | 23:45 |
| clarkb | jeblair: you display both adds at different line numbers on either side | 23:45 |
| clarkb | jeblair: or you don't display them at all | 23:45 |
| *** xyang1 has quit IRC | 23:46 | |
| *** jpr has joined #openstack-infra | 23:46 | |
| clarkb | jeblair: I am not sure you display the actual file contents anywhere in an interdiff | 23:46 |
| clarkb | jeblair: you only show the diff | 23:46 |
| jeblair | clarkb: but that's not what a move looks like in a diff -- it looks like a removal on the old side and an add on the new | 23:46 |
| clarkb | jeblair: right but this is an interdiff | 23:46 |
| clarkb | which is different | 23:47 |
| jeblair | clarkb: no, the thing we need to display to the user is the difference between the two patchsets | 23:47 |
| jeblair | clarkb: so if something moved, it should be a removal on the old/left/red side and an addition on the new/right/green side | 23:47 |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool: Test if reducing concurrency makes mysql drops work https://review.openstack.org/280989 | 23:47 |
| *** ekarlso has joined #openstack-infra | 23:47 | |
| *** AJaeger has joined #openstack-infra | 23:47 | |
| *** nibalizer has joined #openstack-infra | 23:47 | |
| *** johnthetubaguy has joined #openstack-infra | 23:47 | |
| *** anthonyper has joined #openstack-infra | 23:47 | |
| *** AJaeger has quit IRC | 23:47 | |
| *** AJaeger has joined #openstack-infra | 23:47 | |
| jeblair | clarkb: i would not know what to make of a green line on the left side. :) | 23:47 |
| *** ekarlso has quit IRC | 23:48 | |
| clarkb | jeblair: I think you show the diffs not a red green delta | 23:48 |
| *** ekarlso has joined #openstack-infra | 23:48 | |
| clarkb | and you show the diffs where they differ | 23:48 |
| *** AJaeger is now known as Guest22736 | 23:48 | |
| jeblair | clarkb: i thought this exercise was to try to make the non-rebase differences between patchsets visible to users in gerrit/gertty so that they could view and comment on them. | 23:49 |
| clarkb | it is | 23:49 |
| clarkb | but you do that via showing them where the diffs are different | 23:49 |
| clarkb | you aren't required to use the same exact ui that exists today | 23:49 |
| clarkb | say I comment on a + line on the lhs, that comment would be made on the rhs of the normal git view at that number | 23:50 |
| *** vdrok has joined #openstack-infra | 23:50 | |
| clarkb | if you comment on a - line on the lhs, that comment would be made on the lhs of the normal git view at that line number | 23:50 |
| clarkb | and similarly for the rhs of the interdiff | 23:50 |
| jeblair | clarkb: there is no reason this requires a ui difference. the existing ui is perfectly adequate for showing a diff between two things and allowing comments. | 23:51 |
| clarkb | I think some of the problems in solving this are related to trying to treat a diff as the same as a diff between diffs | 23:51 |
| jeblair | the only thing driving in that direction is the fact that git does not make factoring out a rebase easy. | 23:52 |
| *** sdake has joined #openstack-infra | 23:53 | |
| clarkb | hrm nodepool unittests don't print out slowtests, I suppose I can get that from subunit log | 23:55 |
| clarkb | (to confirm if increasing the timeout helped it pass or not) | 23:55 |
| *** harlowja_at_home has joined #openstack-infra | 23:55 | |
| clarkb | oh thats coverage | 23:55 |
| *** yuanying has quit IRC | 23:56 | |
| *** yuanying has joined #openstack-infra | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!