| *** ysandeep|away is now known as ysandeep | 06:31 | |
| *** jpena|off is now known as jpena | 07:36 | |
| *** ysandeep is now known as ysandeep|lunch | 07:53 | |
| opendevreview | Merged openstack/project-config master: Ensure promote-tox-docs-infra runs only on master https://review.opendev.org/c/openstack/project-config/+/806012 | 10:23 |
|---|---|---|
| *** rlandy is now known as rlandy|rover | 10:37 | |
| *** sshnaidm is now known as sshnaidm|off | 10:46 | |
| *** jcapitao is now known as jcapitao_lunch | 11:14 | |
| *** ysandeep|lunch is now known as ysandeep | 11:16 | |
| *** jpena is now known as jpena|lunch | 11:30 | |
| *** jpena|lunch is now known as jpena | 12:22 | |
| *** jcapitao_lunch is now known as jcapitao | 12:23 | |
| zul | hi, this is not obvious to me on why its failing: https://review.opendev.org/c/starlingx/distcloud-client/+/804128 and https://zuul.opendev.org/t/openstack/build/f04a06b121164b89bad6b4eec04f572a | 13:04 |
| *** ysandeep is now known as ysandeep|afk | 13:39 | |
| fungi | zul: looks like it's trying to build cffi 1.12.2 against python 3.9 but isn't compatible with it maybe? | 14:06 |
| zul | fungi: thats what i see, but the fix isnt obvious to me | 14:06 |
| fungi | cffi 1.12.2 was released 2019-02-26, well before python 3.9 existed, so being unable to build that is not too surprising. i guess you're trying to figure out why it's selecting such an old cffi version? | 14:07 |
| zul | yeah thats exactly what im trying to figure out | 14:08 |
| fungi | zul: found it, pretty sure | 14:17 |
| fungi | https://zuul.opendev.org/t/openstack/build/f04a06b121164b89bad6b4eec04f572a/log/tox/py39-1.log#3 | 14:17 |
| fungi | pip install -chttps://opendev.org/openstack/requirements/raw/branch/stable/stein/upper-constraints.txt | 14:17 |
| fungi | stein is... old | 14:17 |
| fungi | https://opendev.org/openstack/requirements/src/branch/stable/stein/upper-constraints.txt#L529 | 14:18 |
| fungi | cffi===1.12.2 | 14:18 |
| zul | yeah but python3.9 should be using victoria | 14:18 |
| zul | https://review.opendev.org/c/starlingx/distcloud-client/+/804128/13/distributedcloud-client/tox.ini#43 | 14:19 |
| fungi | https://review.opendev.org/c/starlingx/distcloud-client/+/804128/13/distributedcloud-client/tox.ini | 14:22 |
| fungi | okay so the idea is that the install_command in testenv:py39 should replace the inherited one from the generic testenv section | 14:22 |
| fungi | so two possibilities, either it's not selecting the right testenv or it's not using the correct tox.ini file (there is also one in the root of the project) | 14:23 |
| zul | ok | 14:23 |
| zul | yeah thats what i thought as well | 14:23 |
| fungi | i would expect the tox_extra_args string to be appended to the cmd logged here: https://zuul.opendev.org/t/openstack/build/f04a06b121164b89bad6b4eec04f572a/console#3/0/7/debian-bullseye | 14:25 |
| fungi | leading me to suspect it's just defaulting to using the tox.ini in the root of the repository instead | 14:25 |
| fungi | worth noting, the default tox_extra_args is -vv so by overriding it you could also be reducing verbosity if you don't include -vv in your override: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/tox/defaults/main.yaml#L4 | 14:34 |
| zul | the min version is like 3.2, maybe that has something to do with it? | 14:35 |
| fungi | nah, i see it... it's actually dying here before it would get to the second invocation of tox where tox_extra_args would be consumed: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/tox/tasks/siblings.yaml#L1-L11 | 14:38 |
| fungi | i think the tox role in zuul-jobs isn't (yet at least) compatible with overriding the tox.ini path that way | 14:39 |
| zul | well f*ck | 14:39 |
| fungi | it may make more sense to turn the path into a separate rolevar | 14:39 |
| zul | how do i do that? | 14:40 |
| fungi | so that it can be used in all places in the role where tox might be invoked, though maybe there's not a reason tox_extra_args isn't added in the siblings tasks and it can just be added there like it is in the main tasks for the role | 14:40 |
| zul | ok | 14:41 |
| *** akekane_ is now known as abhishekk | 14:41 | |
| fungi | i can bring it up in the #zuul:opendev.org matrix channel in a bit, or i can use the zuul-discuss@lists.zuul-ci.org ml instead if that's easier for you to follow | 14:45 |
| fungi | zul: a couple of alternatives which would work now though... | 14:46 |
| fungi | https://zuul-ci.org/docs/zuul-jobs/python-jobs.html#jobvar-tox.tox_constraints_file | 14:46 |
| fungi | that can be used to tell it the path to the constraints file, usually used in conjunction with making the requirements project which constains that file a required-projects addition for the job you're running | 14:46 |
| zul | ok ill take a nother look at it, thanks for the help | 14:47 |
| fungi | or you could try turning off https://zuul-ci.org/docs/zuul-jobs/python-jobs.html#jobvar-tox.tox_install_siblings though that cuts out a good chunk of functionality for cross-repository testing when you're pip installing multiple projects from source | 14:47 |
| fungi | anyway, i'll push up a change in a bit to add tox_extra_args to the sibling tasks where tox is invoked and test the waters with zuul reviewers to see if it's intentionally omitted there | 14:49 |
| *** ysandeep|afk is now known as ysandeep | 14:55 | |
| opendevreview | Slawek Kaplonski proposed openstack/openstack-zuul-jobs master: Remove neutron and networking-midonet Ocata jobs definitions https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/791364 | 14:59 |
| fungi | zul: i've pushed https://review.opendev.org/806612 and https://review.opendev.org/806613 for the two changes i suggested to the tox role | 15:36 |
| fungi | we'll see what the other zuul-jobs maintainers have to say about them | 15:36 |
| *** jpena is now known as jpena|off | 15:37 | |
| *** ysandeep is now known as ysandeep|afk | 15:48 | |
| *** ysandeep|afk is now known as ysandeep | 16:52 | |
| *** ysandeep is now known as ysandeep|away | 17:21 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!