| *** ministry is now known as __ministry | 05:51 | |
| vishalmanchanda | Hello Infra team, I am trying to rename x/xstatic-angular-fileupload->openstack/xstatic-angular-fileupload but getting Zuul syntax error. | 13:38 |
|---|---|---|
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/883995 | 13:38 |
| vishalmanchanda | anyone have any idea how can I fix it. | 13:39 |
| vishalmanchanda | I think it is related to Remove usage of openstack/xstatic-font-awesome https://review.opendev.org/c/openstack/horizon/+/875326 which needs to merged in stable branches but not sure how to proceed further. | 13:40 |
| frickler | vishalmanchanda: looks like that may be another deadlock situation like what lead me to force merge https://review.opendev.org/c/openstack/horizon/+/875326 earlier | 13:44 |
| frickler | in the future, this could be avoided by removing required-projects before the rename is executed and re-add with the new name afterwards | 13:46 |
| frickler | for the current situation, possibly another set of merges avoiding zuul is needed, as the stack of https://review.opendev.org/q/I9c75b084705dfdc6df52aca1659f89444c8a1728 now also seems to be blocked by this new issue | 13:47 |
| frickler | so my suggestion would be to prepare one patch per branch that fixes both of these issues and then we can force-merge them | 13:47 |
| frickler | there are also some other errors like "extra keys not allowed @ data['gate']['queue']" for older horizon branches, would be good to fix those at the same time, too, see https://zuul.opendev.org/t/openstack/config-errors | 13:50 |
| frickler | infra-root: ^^ do we need to add a note about "required-projects" issues in our renaming guide? | 13:52 |
| fungi | i thought we included guidance to check and clean up resulting zuul config errors after renaming, but seems like that's not necessarily doable if it deadlocks those branches such that the fixes can't be merged normally | 14:03 |
| fungi | but also not finding the wording i thought we had in there either | 14:04 |
| frickler | are you looking at https://files.openstack.org/project/opendev.org/docs/opendev/infra-manual/latest/creators.html#project-renames or something else? I can try to formulate some update for it | 14:10 |
| fungi | aha, yes sorry i was looking at https://docs.opendev.org/opendev/system-config/latest/gerrit.html#renaming-a-project not in the manual | 14:19 |
| fungi | i agree the manual is a good place to document additional job config related issues | 14:20 |
| fungi | particularly recommending that the team check for references to that project name in configuration on other projects (including the various branches thereof) and temporarily remove them so they can be added back later with the new name | 14:22 |
| fungi | https://docs.openstack.org/project-team-guide/repository.html#project-renames has the content i was remembering about checking job configs | 14:22 |
| fungi | that's openstack-focused documentation, but also openstack is the main place we see this issue crop up | 14:23 |
| frickler | I think step 5 and 6 would need to be switched in https://docs.openstack.org/project-team-guide/repository.html#project-renames | 15:31 |
| frickler | I'll prep some patch tomorrow | 15:32 |
| vishalmanchanda | frickler: thanks I will prepare that patch which fixes both the issues in stable branches and let you know. | 15:32 |
| *** tosky_ is now known as tosky | 16:20 | |
| vishalmanchanda | frickler: the series of patches is ready for review https://review.opendev.org/q/I9c75b084705dfdc6df52aca1659f89444c8a1728 please take a look once you have time. | 16:22 |
| frickler | vishalmanchanda: I can take a closer look tomorrow, stable/2023.1 patch lgtm at least, maybe you can try to get some review within horizon first so we can directly proceed with merging, then? | 16:52 |
| frickler | vishalmanchanda: also, slightly unrelated, are you aware that horizon is failing with the latest font-awesome release? cf. the reqs bump patch https://zuul.opendev.org/t/openstack/build/e5dd3c8fced64cf2b95ecc2d50bc0827 | 16:52 |
| frickler | vishalmanchanda: I think force-merging https://review.opendev.org/c/openstack/horizon/+/883995 may actually be enough, added a comment on the patch. it will still be necessary to have the other patches combining both fixes like you did, but they should pass zuul after the master fix is merged | 17:29 |
| opendevreview | Merged openstack/project-config master: Add Kubernetes Power Manager app to StarlingX https://review.opendev.org/c/openstack/project-config/+/884250 | 19:29 |
| opendevreview | Merged openstack/ptgbot master: Revert "Migrate ptgbot to quay.io" https://review.opendev.org/c/openstack/ptgbot/+/884288 | 19:41 |
| opendevreview | Merged openstack/openstack-zuul-jobs master: Revert "Pull grafyaml from quay.io" https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/884294 | 21:02 |
| opendevreview | Merged openstack/project-config master: Revert "Pull grafyaml from quay.io" https://review.opendev.org/c/openstack/project-config/+/884293 | 21:24 |
| *** sfinucan is now known as stephenfin | 21:52 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!