| vishalmanchanda | frickler: hello, I am agreed with you about force merge of https://review.opendev.org/c/openstack/horizon/+/883995 please proceed and let me know if any other thing need to be take care before approving this patch. | 06:42 |
|---|---|---|
| vishalmanchanda | frickler: I am looking at your comment on https://review.opendev.org/c/openstack/horizon/+/878846 but little confuse now about which CI job I should make non-voting because right now CI not able to run on the patch. | 06:45 |
| frickler | vishalmanchanda: for 883995 if you could add a matching comment on the patch just for documentation that would be great and then also add a CR+2 and W+1 | 07:25 |
| frickler | vishalmanchanda: for 878846 my comment was just based on the old CI results. we can recheck after the other patch is merged, if that doesn't help either, we can do another force-merge | 07:27 |
| vishalmanchanda | frickler: done for 883995. | 07:28 |
| vishalmanchanda | frickler: ack, for 878846 | 07:29 |
| frickler | vishalmanchanda: cool, I'll proceed with merging now | 07:31 |
| vishalmanchanda | frickler: thanks for the help. | 07:32 |
| frickler | #status log force-merged https://review.opendev.org/c/openstack/horizon/+/883995 to unblock horizon CI at PTL request | 07:34 |
| opendevstatus | frickler: finished logging | 07:34 |
| frickler | vishalmanchanda: rechecked 878846 and it looks like it is starting check jobs now | 07:36 |
| vishalmanchanda | frickler: yeah. | 07:37 |
| frickler | same for 878831, so let's wait for those results now | 07:37 |
| frickler | vishalmanchanda: status on https://review.opendev.org/c/openstack/horizon/+/878846 seems unchanged, let me know if I should force-merge that one, too, to speed things up | 09:49 |
| frickler | vishalmanchanda: the other patches should be able to be handled by the normal workflow now, would be great if you could ensure that that doesn't take months again | 09:50 |
| frickler | at least we're down from 260 to 255 config errors now <small>\o/</small> | 09:51 |
| *** hberaud_ is now known as hberaud | 13:34 | |
| *** ministry is now known as __ministry | 20:38 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!