opendevreview | Matthias Runge proposed openstack/project-config master: Panko has been deprecated and moved to unmaintained https://review.opendev.org/c/openstack/project-config/+/921090 | 06:03 |
---|---|---|
*** elodilles_ooo is now known as elodilles | 06:32 | |
opendevreview | Merged openstack/project-config master: Set inmotion max servers to 0 https://review.opendev.org/c/openstack/project-config/+/921072 | 07:10 |
opendevreview | Jan Marchel proposed openstack/project-config master: Add Ai Anomaly Detection component to NebulOuS https://review.opendev.org/c/openstack/project-config/+/920996 | 07:51 |
opendevreview | James Page proposed openstack/project-config master: Prep sunbeam single charm repos for retirement https://review.opendev.org/c/openstack/project-config/+/917827 | 09:11 |
opendevreview | Merged openstack/pbr master: Add openstack-tox-py312 as non-voting job https://review.opendev.org/c/openstack/pbr/+/920595 | 10:51 |
fungi | skimming https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/ORQB3WFFA67UUAF5JNRKGYWB2U2MXHGJ/ i'm worried there's some misunderstanding | 20:20 |
fungi | zuul's regex negate directive is intended to provide an alternative to negative lookahead expressions, not to enable their use | 20:21 |
fungi | haleyb: mnaser: ^ it doesn't look to me like the irrelevant-files regex changes caused this... the one for neutron ran all jobs, and the revert for neutron-tempest-plugin isn't running the missing jobs | 20:28 |
mnaser | fungi: yeah.. but for example this here seems to have ran nothing (except pep8 and docs) - https://review.opendev.org/c/openstack/neutron/+/907382 | 20:30 |
mnaser | https://review.opendev.org/q/project:openstack/neutron+is:merged+branch:master look at the history the only relevant change is the re2 change.. but I mean, could be something else, but seems unlikely | 20:31 |
mnaser | https://review.opendev.org/c/openstack/neutron/+/917430 example of a change that just ran those | 20:32 |
fungi | oh, though also i wonder why zuul config files were being excluded in the first place | 20:32 |
mnaser | fungi: my guess is to avoid retriggering all jobs if you make a change to the project config (aka enable or disable a job) | 20:35 |
fungi | looks like zuul currently considers openstack-tox-py311 to be undefined: https://zuul.opendev.org/t/openstack/job/openstack-tox-py311 | 20:36 |
fungi | this may be an issue in a parent job definition | 20:37 |
fungi | or else my internet connection is acting up (i'm not at home, so all bets are off) | 20:37 |
clarkb | fungi: mnaser the change is responsible bceause the regexes were not equivalent | 20:38 |
clarkb | at least in the ironic caseI looked at hwich refered to the neutron stuff | 20:39 |
clarkb | basically rules were created saying anything not tools/foo.yml is an irrelevant file which is everything but that source file. The old negative lookahead said anything in tools/ except foo.yml is irrelevant | 20:39 |
clarkb | I guess I need to respodnd to the thread becuse the assertion in that email is false. negative lookaheads work just fine | 20:40 |
clarkb | the expression was different | 20:40 |
fungi | aha, yes looking at https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/920979/1/zuul.d/master_jobs.yaml it seems to be the same problem | 20:43 |
fungi | ^zuul.d/project.*\.yaml is not the inverse of ^zuul.d/(?!(project)).*\.yaml | 20:45 |
fungi | clarkb: ^ | 20:45 |
clarkb | yes | 20:47 |
fungi | so the reverts are still an okay short-term approach, but the solution to the zuul reex warnings is to make negated regexes that are actually the inverse of their negative lookahead predecessors | 20:48 |
clarkb | yes | 20:49 |
fungi | or to remove the offending expressions if that's easier | 20:49 |
clarkb | I've just responded to the thread | 20:49 |
fungi | thanks! | 20:52 |
haleyb | fungi: i did start working on a fix, but couldn't get it right so went for revert since we already merged one change without any useful gate jobs. i will have to look tomorrow but will admit sometimes regex is my kryptonite | 21:38 |
haleyb | but it seemed clear they were not equivalent | 21:39 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!