| *** croeland1 is now known as croelandt | 14:00 | |
| *** croelandt is now known as croeland1 | 14:48 | |
| *** croeland1 is now known as croelandt | 14:48 | |
| opendevreview | Clark Boylan proposed openstack/project-config master: Update Jeepyb's Gerrit builds to Gerrit 3.11 https://review.opendev.org/c/openstack/project-config/+/969846 | 19:43 |
|---|---|---|
| sean-k-mooney | by the way we have been noticing strage behvior with gerrit comment not properly beign render and poping in if you referesh for at least the last few days | 19:53 |
| fungi | sean-k-mooney: that could be a browser permissions problem, i think gerrit needs notify perms to immediately receive updates in an already open page | 19:54 |
| sean-k-mooney | fungi: this is not for already opened pages | 19:56 |
| sean-k-mooney | this is on opening a page for the first time | 19:56 |
| fungi | oh, interesting | 19:56 |
| clarkb | sean-k-mooney: is that something you might be able to shrae a screenshot of? I'm not sure I fully understand | 19:57 |
| sean-k-mooney | i was still wonderign if it was a caching issue | 19:57 |
| fungi | i wonder if some rest api calls being made by the js frontend are failing silently. maybe a js console in the browser would show them if so | 19:57 |
| clarkb | is it basically an empty yellow comment box? | 19:57 |
| clarkb | but yes the next step is likely opening the browser console to see if there was a failed request for data | 19:58 |
| sean-k-mooney | no comment form previous revsiosn are not show at all | 19:58 |
| sean-k-mooney | only the comemnt form the current patchset | 19:58 |
| sean-k-mooney | then you refresh and they are all there | 19:58 |
| clarkb | oh got it. I think there is actually some algorithm there. Like it only shows unresolved comments from old patchsets by default | 19:58 |
| sean-k-mooney | right its the unresloved ones im refering too | 19:59 |
| clarkb | and then I think if you drop a file from the change you can only see those comments by loading the old patchset (this might be a bug) | 19:59 |
| clarkb | sean-k-mooney: do you have an example change? I'm curious if I can reproduce it in one of the three browsers I'm currently running | 19:59 |
| clarkb | but yes, if a refresh fixes it then a likely problem is failed network requests | 20:00 |
| clarkb | and I think those should show up in your browser console log | 20:00 |
| sean-k-mooney | i was seeing it on https://review.opendev.org/c/openstack/nova-specs/+/967712/9/specs/2026.1/approved/resource-notifications.rst bu ti have resove most of the older commeents at thsi point | 20:00 |
| clarkb | the comments from ps7 and ps8 appear to load for me on initial load (ps9 is latest) in firefox. | 20:01 |
| clarkb | though I guess I don't know how many there should be just that there are non zero quantities | 20:01 |
| clarkb | chrome and chromium seem to match firefox. | 20:01 |
| clarkb | If you see it happen again can you check your console and share any tracebacks if they exist? And maybe also see if anyone can reproduce for that change? if it is a cache issue I would expect it to be global for a specific change | 20:02 |
| clarkb | since there aren't user specific caches for things like that | 20:02 |
| sean-k-mooney | yes they loaded for me as weel this time | 20:03 |
| sean-k-mooney | although 8 https://review.opendev.org/c/openstack/nova-specs/+/967712/8/specs/2026.1/approved/resource-notifications.rst | 20:04 |
| sean-k-mooney | has no comment form 7 when i loaded it just now | 20:04 |
| sean-k-mooney | v9 has comemnt form v8 and v7 | 20:04 |
| sean-k-mooney | so v8 shoudl have the coment form v7 too | 20:05 |
| sean-k-mooney | that was repatable for me and then i refest v8 and now the v7 comment are thre too | 20:06 |
| sean-k-mooney | and if i go back go v8 they are missing again | 20:07 |
| sean-k-mooney | https://imgur.com/a/sZxE4Hg | 20:11 |
| clarkb | the two commetn chains from ps7 loaded for me in firefox when I pulled up the ps8 link above | 20:11 |
| clarkb | I have lunch now but can look closer after | 20:11 |
| sean-k-mooney | ack no worries | 20:12 |
| clarkb | anything in your browser console? | 20:12 |
| sean-k-mooney | it actully yes | 20:13 |
| sean-k-mooney | thre is a lot of output form somethign call gr-app.js | 20:14 |
| sean-k-mooney | and some warning about preloading fonts | 20:14 |
| sean-k-mooney | "The resource at “https://review.opendev.org/changes/?q=change:967712” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly" | 20:14 |
| clarkb | while I could see font loading affectin comments I would be surprised if any comments load at all | 20:22 |
| clarkb | let me see if I get that message (fwiw I have a long standing change upstream to not use web fonts but now I don't have a valid cla with google...) | 20:22 |
| sean-k-mooney | well i think the font message is just saying this was preloaded but not required | 20:23 |
| sean-k-mooney | or similar so i dont think thats is realted | 20:23 |
| sean-k-mooney | so on firefox i see lots of debug logs form gr-app.js which i assume is gerrti javascrip component | 20:24 |
| clarkb | ya I get the same thing in my console where the comments have loaded | 20:24 |
| clarkb | yes I believe that is the part of gerrit that acts like a single page app or whatever | 20:26 |
| sean-k-mooney | ya it odd i can get back to the "missing v7" state just by uing the drop down to go form v9 to v8 | 20:26 |
| clarkb | sean-k-mooney: let me try that | 20:27 |
| sean-k-mooney | i wonder are they trying to be fancy and not actully reirect the page | 20:27 |
| clarkb | yes that reproduces | 20:27 |
| clarkb | so loading the expected patchset directly seems to work fine | 20:27 |
| clarkb | but using the in diff view patchset selector seems to lose some comments. | 20:28 |
| sean-k-mooney | yep | 20:28 |
| clarkb | and doing that produces no tracebacks in the console | 20:28 |
| clarkb | sean-k-mooney: I don't know what is happening and without tracebacks we probably have to go and read and understand some js/ts code. Probably best to start with a bug report. Is that something you want to do or would you prefer I do it? I think due to spam there might be initial submission issues for new users so may be best if I do it | 20:30 |
| clarkb | sean-k-mooney: it looks like if you view the file at the top level of the chagn and then change patchsets there that comments render properly in that view | 20:33 |
| clarkb | sean-k-mooney: so it seems like this could be specific to the file view. But also ^ may be a workaround? | 20:33 |
| clarkb | (I personally prefer view things in distinct file views as I think it helps me organize better, but I know top level view is something people like too so maybe its good enough for now) | 20:34 |
| clarkb | I'll go ahead and do my best to file an issue when I'm back from todays school run | 21:05 |
| sean-k-mooney | clarkb: thanks its normally not an isseu | 21:08 |
| sean-k-mooney | we were tryign to do a spec freeze today | 21:09 |
| sean-k-mooney | so i kept jumpin gbetween revisoins of sepc to adress diffent comments | 21:09 |
| sean-k-mooney | hitting F5 or ctrl-R whatever refhest is bound too works find too | 21:10 |
| clarkb | sean-k-mooney: I spent a bit more time fiddling with it to try and write a complete bug report and now I can't reproduce anymore | 22:52 |
| clarkb | sean-k-mooney: I think what was happenign was the line numbers were shifting and I wasn't checking comment content properly but when I do what we thought reproduced it the comments are all there now | 22:53 |
| clarkb | the first moves from line 206 to 213 and the other from 226 to 232 | 22:53 |
| clarkb | based on your screenshot it does seem like something is happening but I don't think this is a reliable reproduction case | 22:54 |
| clarkb | I'm going to hold off on filing a bug to avoid leading gerrit down some dead end path. If you think you see it again can we double check the console log again? | 22:55 |
| clarkb | mostly I'm just hoping that if it isn't a consistent problem then finding some error would be really helpful (if there is one anyway) | 22:55 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!