| sean-k-mooney | clarkb: sure, its hard to notice that it happened because the effect is comments are not there and if you don tknow they should be then you completely miss the probelem. honestly when they changed how comment worked a few years ago we all hateded it intially and i still think the way resoultion work is a bad ux and regress form old gerrit. but it was workabole if we could | 11:14 |
|---|---|---|
| sean-k-mooney | rely on the comment beign there or not consitently. if we cant rely on that its a pretty big regression. still not github levels of terrible review ux but its significnat | 11:14 |
| opendevreview | Lajos Katona proposed openstack/openstack-zuul-jobs master: Add py313 periodic jobs: https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/969911 | 12:49 |
| opendevreview | Ghanshyam proposed openstack/openstack-zuul-jobs master: Remove arm64 unit tests job from stable branches https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/954781 | 13:04 |
| frickler | gmaan: elodilles: ^^ this was never merged because of a missing rebase, sorry we didn't notice earlier. also it seems like some further cleanup for stable/2024.1 is needed, maybe one of you has a bit of time to look into that? | 13:10 |
| elodilles | frickler: what stable/2024.1 clean up do you mean? i think i ran a clean up some days ago, if you mean deleting stable/2024.1 branches of cycle-trailing projects that moved to unmaintained | 13:13 |
| opendevreview | Merged openstack/openstack-zuul-jobs master: Remove arm64 unit tests job from stable branches https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/954781 | 13:17 |
| frickler | elodilles: sorry, I should have been more precise, there are some references in this file: https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/project-templates.yaml#L685 etc. | 13:42 |
| elodilles | frickler: oh, i see, i'll propose a patch for that | 13:52 |
| opendevreview | Dr. Jens Harbott proposed openstack/openstack-zuul-jobs master: DNM: Testing Debian Trixie https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/967582 | 13:53 |
| opendevreview | Elod Illes proposed openstack/openstack-zuul-jobs master: Update 2024.1 Caracal related filters https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/969949 | 15:13 |
| elodilles | frickler: ^^^ | 15:13 |
| elodilles | and let me fix it quickly... -.- | 15:16 |
| opendevreview | Elod Illes proposed openstack/openstack-zuul-jobs master: Update 2024.1 Caracal related filters https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/969949 | 15:18 |
| frickler | thx, will review in a bit | 15:18 |
| frickler | tkajinam: did you have some testing patches for https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/967582 yet? I think we should try to use trixie as much as possible in order to avoid having to compile python on noble everywhere | 15:19 |
| fungi | well, also the pti says we're testing 3.13 because it's the default on trixie, which is a target platform for the upcoming release | 15:24 |
| fungi | so testing it on some other platform instead where it's not even available normally is a pathological choice | 15:25 |
| clarkb | sean-k-mooney: yes it is definitely a bug and an issue. One idea that occurs to me is if we assume it is a network load problem maybe we can convince upstream to add a warning flag to the page that content may not be complete and a refresh may be required. Something to make it more apparent if they can't sort out the underlying issue | 15:51 |
| clarkb | but also the underlying issue could be "the internet is flaky" and that isn't something gerrit will solve so a warning would help there | 15:51 |
| clarkb | sean-k-mooney: the other thing to keep in mind is we're upgrading to 3.11 on Sunday | 15:57 |
| clarkb | while they typically backport (actually they forward port) bug fixes it is possioble that this issue is version specific | 15:57 |
| fungi | yeah, would be good to try reproducing it next week | 15:58 |
| tkajinam | frickler, sorry it dropped off from my memory. I'll resume my work on it. Strange thing is that all of my existing transition patches are not related to the functional job template (there are all related to base py313 template) and I have to restore my memory about my next step (probably bump the upper func job in nova...) | 16:03 |
| *** darmach9 is now known as darmach | 16:04 | |
| sean-k-mooney | clarkb: th thing is i was not seeing any fialing network request either | 17:41 |
| sean-k-mooney | there was no error in the console but also no failed requests in teh netwrok tab | 17:42 |
| sean-k-mooney | lets se if if just goes away after the 3.11 upgrade | 17:42 |
| sean-k-mooney | clarkb: thanks for takign time to look into this in anycase | 17:43 |
| sean-k-mooney | clarkb: maybe i shoudl pull out gerrty and give it another try instead :) | 17:43 |
| sean-k-mooney | i spend far to much time in a borwser these days then is proably good for me | 17:44 |
| clarkb | I use the browser rather than gertty because I found it helps me understand better how most people are using gerrit. That said I know people continue to use gertty and enjoy doing so so definitely won't stop you | 17:47 |
| sean-k-mooney | i generally like the gerrit web ui | 17:48 |
| sean-k-mooney | partly beacuse it allows me to read the code in a very diffent way then in my editor or terminal | 17:48 |
| sean-k-mooney | i find that allows me to find thing i would not have otherwise postted | 17:49 |
| sean-k-mooney | *spotted | 17:49 |
| sean-k-mooney | i.e. i make the changes in emacs or cursor dependign on my mood. then i review the git diff quickly in my terminal and push | 17:50 |
| sean-k-mooney | then i open the reveiw in gerrit and confirm its correct | 17:50 |
| sean-k-mooney | i trieed doign code reviews in my editor before and while i can see the appeal there is somethign about changign the modality that i found help me actully read the code better | 17:51 |
| clarkb | sean-k-mooney: I too find doing code review of my own code valuable at times. Though I never considered that hte change of "venue" may be part of the value there | 17:59 |
| clarkb | but it wouldn't surprise me if that is the case | 18:00 |
| fungi | i always assumed it was related to my neurovisual challenges, but i too find that reviewing in a different viewer, format, or even just a different font/typeface helps me catch things i miss just rereading in my editor | 18:01 |
| sean-k-mooney | i find the change of venue helps me actully read the code rather then read what i think the code is. that might just be a dyslexic thing but it turns off my workarounds | 18:01 |
| fungi | that's a good summary for why i find it helpful too | 18:02 |
| fungi | as far as relying on gertty, it's a matter of convenience. i have established workflows that allow me to float from computer to computer and roam from network to network multi-attaching to a remote tmux session over mosh (and wireguard when necessary). a lightweight console application is accessible and responsive even from very underpowered thin client machines, small screen | 18:15 |
| fungi | resolutions, systems with inconvenient or no pointer device, et cetera | 18:15 |
| fungi | i can quickly review and approve a change in a terminal session on my phone in a bar over flaky wifi or a trickle of cell data | 18:16 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!