| Haomeng | devananda, see your code to provide Conductors backend database layer support, should we expose Conductors api?if yes, I want to try to add these new API | 00:00 |
|---|---|---|
| devananda | Haomeng: not yet | 00:00 |
| Haomeng | ok | 00:00 |
| devananda | Haomeng: see lucas' patch to expose /drivers -- this is the result of the conductor work | 00:01 |
| Haomeng | ok, got | 00:01 |
| Haomeng | :) | 00:01 |
| devananda | basically, conductor table stores what drivers each conductor can service. user only cares about what drivers are available | 00:01 |
| devananda | and eventually, user may want to send request to specific driver | 00:02 |
| devananda | so API will do something like, POST /drivers/my-driver | 00:02 |
| devananda | and route the request to any conductor which runs my-driver | 00:02 |
| devananda | but ... later :) | 00:02 |
| Haomeng | got, understand, thank you devananda | 00:02 |
| Haomeng | I understand, almost Ironic API are ready, will intergated with nova-ironic driver, right? | 00:04 |
| devananda | Haomeng: yep. i've been slowly working on that driver | 00:05 |
| devananda | WIP patch is up, but many things are missing still | 00:06 |
| Haomeng | ok, sorry, just want to know our progress:) | 00:07 |
| Haomeng | and want to know how our nova schedule know the boot need our Ironic support? need a new schedule involved? | 00:09 |
| Haomeng | schedule filter | 00:10 |
| devananda | hmmm | 00:10 |
| devananda | i am hoping to be able to use the baremetal scheduler bits | 00:10 |
| devananda | that will require the ironic driver to expose the same data to the scheduler, which seems reasonable to me | 00:10 |
| Haomeng | yes, agree with you | 00:10 |
| Haomeng | and if our nova-baremetal will be support in icehourse release? almost same function with our Ironic I think | 00:11 |
| Haomeng | icehouse | 00:12 |
| Haomeng | devananda: I searched code find more i18n issue without "_" for some log message string, I see you have some fix already, should I fix the rest of them with new changeid? | 00:14 |
| devananda | Haomeng: sure | 00:15 |
| *** anniec has quit IRC | 00:16 | |
| devananda | Haomeng: re: icehouse, if all goes well, ironic will be included and the default in icehouse. baremetal will also be included but marked as deprecated, to give deployers one cycle to migrate off of it. then removed in "J" release | 00:16 |
| Haomeng | ok, thank you devananda | 00:17 |
| devananda | Haomeng: fyi, https://review.openstack.org/#/c/51328/ | 00:18 |
| NobodyCam | deva question | 00:18 |
| devananda | ? | 00:19 |
| NobodyCam | nm | 00:19 |
| NobodyCam | :-p | 00:19 |
| devananda | :p | 00:19 |
| Haomeng | ok | 00:20 |
| Haomeng | this ironic driver change is in Abandoned status now | 00:20 |
| Haomeng | anyway I will see your code to get more understanding about our Ironic | 00:21 |
| Haomeng | thank you | 00:21 |
| Haomeng | brb | 00:21 |
| NobodyCam | devananda: line 29 of https://review.openstack.org/#/c/51743/14/ironic/objects/conductor.py | 00:22 |
| devananda | ya | 00:22 |
| NobodyCam | list ? drivers = Column(JSONEncodedDict) | 00:22 |
| devananda | yep | 00:25 |
| devananda | JSONEncodedDict works on lists too | 00:25 |
| NobodyCam | k | 00:25 |
| NobodyCam | :) | 00:25 |
| devananda | afaict, anyway :) | 00:25 |
| devananda | it turns <list ['foo', 'bar']> into u"{['foo', 'bar']}" | 00:25 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Conductors maintan driver list in the DB https://review.openstack.org/51743 | 00:28 |
| devananda | just fixing typos | 00:28 |
| NobodyCam | https://review.openstack.org/#/c/51743/14/ironic/objects/utils.py | 00:28 |
| NobodyCam | look like it returns a [list] | 00:29 |
| NobodyCam | line 118 of ironic/tests/db/utils.py | 00:35 |
| devananda | ....? | 00:41 |
| NobodyCam | returns a list | 00:42 |
| * devananda is multitaskign heavily | 00:42 | |
| NobodyCam | not json which is what will be in the db | 00:42 |
| devananda | and just found a bug in how we associate instance<->node | 00:42 |
| devananda | NobodyCam: the db/sqla layer converts to/from lists | 00:42 |
| NobodyCam | ahh ok | 00:43 |
| NobodyCam | :) | 00:43 |
| devananda | so it's transparently stored as a JSON string, but any code -- even the code in db/sqlalchemy/api will only see it as a list | 00:43 |
| NobodyCam | john has started dinner ... need to help him.. | 00:44 |
| NobodyCam | bbl | 00:44 |
| WillOchanda | hi devananda, i'm almost there with the vendor_passthrough :), getting this error - | 00:45 |
| WillOchanda | WARNING wsme.api [-] Client-side error: Missing argument: "data" | 00:45 |
| WillOchanda | how should the POST data be formatted? | 00:45 |
| devananda | ahhhh! | 00:45 |
| WillOchanda | "POST /v1/nodes/db811f96-980f-4acb-ba7c-95a391413d9b/vendor_passthru?method=set_disk_size | 00:46 |
| devananda | right. so *that* isn't in the client yet | 00:46 |
| devananda | nope | 00:46 |
| devananda | try this | 00:46 |
| devananda | POST -d "{'some': 'data'}" /v1/nodes/xxxx/vendor_passthru/method | 00:46 |
| devananda | POST -d "{'some': 'data'}" /v1/nodes/xxxx/vendor_passthru/set_disk_size | 00:46 |
| devananda | the last field of the URI is mapped to the method | 00:46 |
| WillOchanda | alright | 00:46 |
| devananda | any remaining params will get mapped to the data, but it seems to prefer body over args | 00:47 |
| devananda | (that might have been fixed) | 00:47 |
| WillOchanda | works! | 00:48 |
| WillOchanda | this looks cleaner anyway, i was interpreting the code wrong | 00:48 |
| WillOchanda | very nice | 00:48 |
| *** nosnos has joined #openstack-ironic | 00:49 | |
| devananda | awesome!!! | 00:50 |
| devananda | NobodyCam: ^ | 00:50 |
| *** pky has quit IRC | 00:53 | |
| devananda | Haomeng: updated https://review.openstack.org/#/c/51328/ with a smattering of small changes | 01:13 |
| devananda | still no where near ready | 01:13 |
| openstackgerrit | A change was merged to openstack/ironic: Fix a few missing i18n https://review.openstack.org/53491 | 01:17 |
| *** WillOchanda has quit IRC | 01:20 | |
| *** pky has joined #openstack-ironic | 01:20 | |
| Haomeng | devananda: thanks for the reminder, will review the code and study the Ironic workflow | 01:21 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Regenerate the sample config file https://review.openstack.org/53702 | 01:25 |
| devananda | silly pep n | 01:25 |
| openstackgerrit | A change was merged to openstack/ironic: Fix status codes in node controller https://review.openstack.org/52920 | 01:25 |
| *** anniec has joined #openstack-ironic | 01:26 | |
| openstackgerrit | A change was merged to openstack/ironic: Group and unify ipmi configurations https://review.openstack.org/52615 | 01:31 |
| openstackgerrit | A change was merged to openstack/ironic: Regenerate the sample config file https://review.openstack.org/53702 | 01:31 |
| *** anniec has quit IRC | 01:34 | |
| *** rloo has quit IRC | 01:38 | |
| *** sjing has joined #openstack-ironic | 01:47 | |
| *** sjing has quit IRC | 02:00 | |
| *** sjing has joined #openstack-ironic | 02:00 | |
| *** anteaya has quit IRC | 02:23 | |
| *** CerealBox has quit IRC | 02:41 | |
| *** lnxnut has joined #openstack-ironic | 02:43 | |
| *** albionandrew has joined #openstack-ironic | 03:14 | |
| *** albionandrew has quit IRC | 03:22 | |
| *** prekarat has joined #openstack-ironic | 03:41 | |
| *** lnxnut has quit IRC | 04:22 | |
| *** r-mibu has joined #openstack-ironic | 04:22 | |
| *** WillOchanda has joined #openstack-ironic | 04:59 | |
| *** WillOchanda has quit IRC | 05:00 | |
| *** WillOchanda has joined #openstack-ironic | 05:01 | |
| *** WillOchanda has quit IRC | 05:06 | |
| *** matsuhashi has joined #openstack-ironic | 06:07 | |
| GheRivero | morning ironic | 06:47 |
| devananda | g'night! lol | 06:48 |
| GheRivero | :) | 06:50 |
| *** michchap has quit IRC | 06:51 | |
| *** michchap has joined #openstack-ironic | 06:52 | |
| *** matsuhashi has quit IRC | 07:18 | |
| *** matsuhashi has joined #openstack-ironic | 07:18 | |
| *** ndipanov has joined #openstack-ironic | 07:37 | |
| r-mibu | Hi, folks! | 07:41 |
| r-mibu | I wrote a patch to nova-bm, but not approved for 2 weeks. | 07:41 |
| r-mibu | https://review.openstack.org/#/c/51121/ | 07:41 |
| r-mibu | Is there any core reviewer can check virt/baremetal tree? | 07:42 |
| GheRivero | devananda, but he is off now. Try during the afternoon. | 07:47 |
| *** romcheg has joined #openstack-ironic | 07:47 | |
| r-mibu | thanks, I'll ping him later. | 07:49 |
| *** jistr has joined #openstack-ironic | 07:50 | |
| GheRivero | btw, I'm afraid that the same issue could be in ironic | 07:52 |
| GheRivero | https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L53 | 07:53 |
| r-mibu | yes... | 07:54 |
| r-mibu | ok, i will do | 07:55 |
| GheRivero | cool | 07:55 |
| lifeless | r-mibu: please do ping here for such reviews, we are interested in bare metal. | 07:57 |
| lifeless | r-mibu: I've reviewed (-1, but easy fixes) | 07:57 |
| r-mibu | lifeless: ok. I will check your comments. | 08:00 |
| *** derekh has joined #openstack-ironic | 08:05 | |
| *** lucasagomes has joined #openstack-ironic | 08:34 | |
| *** sjing has quit IRC | 08:35 | |
| *** matsuhashi has quit IRC | 08:46 | |
| *** matsuhashi has joined #openstack-ironic | 08:46 | |
| *** martyntaylor has joined #openstack-ironic | 08:54 | |
| lucasagomes | thanks devananda for the nomination and everyone else in the project :) | 09:01 |
| *** martyntaylor has quit IRC | 09:07 | |
| *** matsuhashi has quit IRC | 09:34 | |
| *** matsuhashi has joined #openstack-ironic | 09:34 | |
| *** matsuhashi has quit IRC | 09:39 | |
| *** martyntaylor has joined #openstack-ironic | 09:40 | |
| *** romcheg1 has joined #openstack-ironic | 09:46 | |
| *** romcheg has quit IRC | 09:51 | |
| *** prekarat has quit IRC | 10:06 | |
| *** ekarlso has quit IRC | 10:17 | |
| *** ekarlso has joined #openstack-ironic | 10:17 | |
| *** matsuhashi has joined #openstack-ironic | 10:27 | |
| *** jianingy_afk has quit IRC | 10:30 | |
| *** nosnos has quit IRC | 10:31 | |
| rameshg87 | Hi | 10:32 |
| rameshg87 | i have a question regarding the deployement by the ironic pxe driver | 10:32 |
| GheRivero | shoot | 10:33 |
| rameshg87 | the pxe driver seems to implement the deploy() method and return with states.DEPLOYING | 10:33 |
| rameshg87 | and the rest of the deployement seems to continue in the vendor_passthru method (with pass_deploy_info) | 10:34 |
| rameshg87 | looking at ironic/drivers/modules/pxe.py | 10:34 |
| rameshg87 | am i correct ? | 10:34 |
| rameshg87 | but i am unable to figure out who will finally call vendor_passthru with 'pass_deploy_info' as the method | 10:37 |
| GheRivero | let me revise... | 10:37 |
| GheRivero | uhm... maybe is not implemented yet. Before that, in nova bm, there was a deploy_helper who was responsible of that | 10:41 |
| rameshg87 | okay | 10:42 |
| GheRivero | anyway, ironic is not fully functional, and are areas to be done | 10:43 |
| rameshg87 | so the general strategy for any driver is that, when deploy() method of driver is called by ConductorManager | 10:43 |
| rameshg87 | if the deployment takes time, it returns states.DEPLOYING | 10:43 |
| rameshg87 | and then | 10:44 |
| lucasagomes | afaict | 10:44 |
| GheRivero | maybe is in ironic/drivers/pxe.py | 10:44 |
| lucasagomes | so deploy helper was merged into pxe | 10:44 |
| rameshg87 | who is supposed to finally check and set the status to states.DEPLOYDONE ? | 10:45 |
| lucasagomes | the call to deploy will actually boots the deploy ramdisk to the baremetal machine and the deployment will continue there | 10:45 |
| GheRivero | https://github.com/openstack/ironic/blob/master/ironic/drivers/pxe.py#L41 | 10:45 |
| lucasagomes | the deploy ramdisk then will sinalize ironic via the API (vendor_passthru) to inform the iscsi target that the image should be copied onto | 10:46 |
| *** matsuhashi has quit IRC | 10:46 | |
| lucasagomes | and that's the second part of the deployment that will set the deploydone after the imagine is copied to the disk | 10:46 |
| *** matsuhashi has joined #openstack-ironic | 10:47 | |
| lucasagomes | rameshg87, the pxe driver should set the DEPLOYDONE | 10:48 |
| rameshg87 | yeah, i got it now | 10:48 |
| lucasagomes | after it formats and copy the image to the iscsi disk (which was mounted by the deploy ramdisk) | 10:48 |
| rameshg87 | i was able to figure out pxe driver does it, but couldn't find who calls it | 10:49 |
| rameshg87 | so during the creation of deploy ramdisk, we make it such that it calls the ironic api at the end of loading it ? | 10:50 |
| *** matsuhashi has quit IRC | 10:51 | |
| lucasagomes | rameshg87, yes | 10:51 |
| lucasagomes | so it needs to be changed in the diskimage-builder | 10:52 |
| lucasagomes | as ironic is not working yet, it's not upstream, but you could customize one to test it urself | 10:52 |
| lucasagomes | we need a way to inform the ramdisk also | 10:52 |
| lucasagomes | what's the ironic api url | 10:52 |
| lucasagomes | etc | 10:52 |
| lucasagomes | probably using the kernel cmdline | 10:52 |
| lucasagomes | I'm not sure how people r thinking about implementing it | 10:53 |
| rameshg87 | okay | 10:54 |
| lucasagomes | rameshg87, https://github.com/openstack/diskimage-builder/blob/master/elements/deploy/init.d/deploy#L28-L29 that's need to change | 10:54 |
| GheRivero | well, it depends if we continue to retrieve images via iscsi (looks like for now) or do something else (glance, swift, torrent...) | 10:56 |
| GheRivero | in that case, not only ironic credentials should be passed, but also glance/swift to get the object | 10:56 |
| GheRivero | but yes, kernel cmd line looks like the most appropiate | 10:57 |
| rameshg87 | hmm..okay | 10:57 |
| rameshg87 | so in any case, we require those to be passed in the ramdisk depending on the method chosen | 10:57 |
| GheRivero | since we don't do file injectin anymore, the image will be the same for all the deployments | 10:57 |
| GheRivero | for nowm is going to be the same method, iscsi + dd | 10:58 |
| lucasagomes | yea I think for the first tests we will still use iscsi + dd | 10:58 |
| lucasagomes | but indeed it should change in the future | 10:59 |
| GheRivero | it doesn't scale so bad just for 1 rack | 10:59 |
| lucasagomes | yea | 10:59 |
| rameshg87 | okay | 11:00 |
| *** matsuhashi has joined #openstack-ironic | 11:20 | |
| *** matsuhashi has quit IRC | 11:23 | |
| *** matsuhashi has joined #openstack-ironic | 11:24 | |
| *** matsuhashi has quit IRC | 11:24 | |
| *** matsuhashi has joined #openstack-ironic | 11:25 | |
| *** romcheg has joined #openstack-ironic | 11:26 | |
| *** matsuhashi has quit IRC | 11:29 | |
| *** romcheg1 has quit IRC | 11:30 | |
| *** lucasagomes is now known as lucas-hungry | 11:36 | |
| Haomeng | good morning Ironic | 12:06 |
| Haomeng | lucasagomes:ping | 12:06 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Remove unnecessary check from manager https://review.openstack.org/53830 | 12:11 |
| openstackgerrit | Ryota MIBU proposed a change to openstack/ironic: Ensure ipmitool module is not to hang with empty password https://review.openstack.org/53832 | 12:17 |
| *** jbjohnso has joined #openstack-ironic | 12:18 | |
| *** jdob has joined #openstack-ironic | 12:22 | |
| *** r-mibu has left #openstack-ironic | 12:22 | |
| *** yuriyz has joined #openstack-ironic | 12:39 | |
| *** romcheg has quit IRC | 12:53 | |
| *** lucas-hungry is now known as lucasagomes | 13:00 | |
| *** anteaya has joined #openstack-ironic | 13:08 | |
| *** sjing has joined #openstack-ironic | 13:12 | |
| *** russellb is now known as rustlebee | 13:12 | |
| lucasagomes | Haomeng, hey man sorry missed ur ping (my nick was lucas-hungry when you pinged me) | 13:29 |
| lucasagomes | how r u? | 13:29 |
| *** romcheg has joined #openstack-ironic | 13:37 | |
| Haomeng | dont worry, no problem | 13:40 |
| Haomeng | I have a finding, not sure if it is valid defect - https://bugs.launchpad.net/ironic/+bug/1244637, Lucas, canyou help to review? | 13:40 |
| lucasagomes | Haomeng, I see, we might have to dig a bit in the openstack common libraries for that | 13:48 |
| lucasagomes | this options are generated using the decorators (guessing) take a look at | 13:48 |
| lucasagomes | ironicclient/v1/port_shell.py | 13:48 |
| lucasagomes | do_port_create will have some decorators with the options it accepts | 13:48 |
| *** linggao has joined #openstack-ironic | 13:52 | |
| *** epim has joined #openstack-ironic | 13:54 | |
| *** lnxnut has joined #openstack-ironic | 13:54 | |
| Haomeng | ok, ifthis is auto-generated, we cannot fix now I think | 13:58 |
| Haomeng | thank you lucasagomes, this is minor issue | 13:58 |
| Haomeng | :) | 13:58 |
| lucasagomes | Haomeng, oh I mean, we can fix it yes, just saying that maybe the problem is not on the python-ironicclient itself | 13:59 |
| lucasagomes | but in the common libs it uses, so we might need to fix it in oslo (if the libs r there) the worst case would be fixing on all the projects that uses it | 14:00 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Add context to TaskManager https://review.openstack.org/53145 | 14:09 |
| Haomeng | ok, let me check oslo code | 14:10 |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Expose created_at/updated_at properties in the REST API https://review.openstack.org/53627 | 14:10 |
| *** jdob has quit IRC | 14:10 | |
| *** jdob has joined #openstack-ironic | 14:10 | |
| Haomeng | thank you lucasagomes:) | 14:11 |
| lucasagomes | Haomeng, no problemo :) | 14:13 |
| Haomeng | :) | 14:14 |
| *** ndipanov is now known as nick_long | 14:20 | |
| *** jbjohnso has quit IRC | 14:22 | |
| anteaya | morning lucasagomes | 14:26 |
| anteaya | morning Haomeng | 14:26 |
| lucasagomes | morning anteaya how r u? | 14:26 |
| Haomeng | morning anteary:) | 14:26 |
| anteaya | good thanks | 14:26 |
| anteaya | Friday already, where does the time go? | 14:26 |
| Haomeng | what is your local time, I guss is 8:26am? | 14:26 |
| anteaya | snow yesterday morning? | 14:26 |
| anteaya | I am 10:26am | 14:27 |
| Haomeng | :) | 14:27 |
| anteaya | :D | 14:27 |
| anteaya | how about you? | 14:27 |
| Haomeng | I am in 10:27pm:) | 14:27 |
| anteaya | not much snow, but snow just the same | 14:27 |
| Haomeng | :) | 14:27 |
| anteaya | the same | 14:27 |
| Haomeng | yes, my TZ is +8, you are -8 | 14:27 |
| Haomeng | :) | 14:27 |
| NobodyCam | good morning Ironic | 14:27 |
| Haomeng | morning NobodyCam | 14:27 |
| anteaya | ah yes, the pm | 14:28 |
| anteaya | morning NobodyCam | 14:28 |
| anteaya | actually I am UTC -4 | 14:28 |
| anteaya | so it works out to 12 hours | 14:28 |
| NobodyCam | morning anteaya Haomeng | 14:28 |
| anteaya | are you in China? | 14:28 |
| Haomeng | yes, I am from China Beijing | 14:28 |
| Haomeng | :) | 14:28 |
| anteaya | great | 14:28 |
| anteaya | :D | 14:28 |
| anteaya | are you coming to the summit? | 14:28 |
| Haomeng | for each day, I'd like to say morning to every, but I will go to sleep soon:) | 14:29 |
| Haomeng | maybe will not | 14:29 |
| anteaya | I bet | 14:29 |
| Haomeng | you will go Hongkong summit? | 14:29 |
| anteaya | yes | 14:29 |
| NobodyCam | :) Haomeng :) | 14:29 |
| anteaya | would be so close for you | 14:29 |
| anteaya | well closer than for me | 14:29 |
| anteaya | please consider attending if you can | 14:29 |
| NobodyCam | :) | 14:30 |
| Haomeng | there are 8+ guys from our team will come to Hongkong summit, but not including me :< | 14:30 |
| anteaya | :( | 14:30 |
| anteaya | I'm glad your team is sending some people though | 14:30 |
| Haomeng | yes, if I attend, will invite all of you Foreign friends | 14:31 |
| NobodyCam | :) we'll be there | 14:31 |
| Haomeng | :) | 14:31 |
| anteaya | sounds good! | 14:31 |
| anteaya | would enjoy meeting someone who lived close | 14:32 |
| anteaya | when I was in Budapest I meet someone who lived in the city who took me to this lovely market for just local people | 14:32 |
| Haomeng | so far the plan is Freeze for me,because I am late in our openstack project | 14:32 |
| anteaya | it was so calm and quiet, I'm so glad I saw it | 14:32 |
| Haomeng | :) | 14:32 |
| anteaya | well it will be a long time before it is so cheap to send you to a summit | 14:33 |
| *** jdob has quit IRC | 14:33 | |
| anteaya | the next will be in Chicago and then in Europe after that | 14:33 |
| *** jdob has joined #openstack-ironic | 14:33 | |
| anteaya | and it would be a great way for you to learn about openstack quickly | 14:33 |
| Haomeng | I hope will attend Chicago summit:( | 14:33 |
| Haomeng | yes | 14:34 |
| anteaya | that would be great | 14:34 |
| *** epim has quit IRC | 14:34 | |
| Haomeng | I focus on Ceilometer project several month | 14:34 |
| Haomeng | and move to Ironic after oct | 14:34 |
| Haomeng | our team need to focus on such new project | 14:35 |
| Haomeng | :) | 14:35 |
| NobodyCam | anteaya: do we know the dates for chicago? | 14:35 |
| Haomeng | I am full time to contribute Ironic proect, are you fulltime? | 14:36 |
| NobodyCam | Haomeng: yes. | 14:36 |
| anteaya | I do not know the dates for Chicago | 14:36 |
| anteaya | If they are known, I don't have that info | 14:36 |
| NobodyCam | Haomeng: who do work for? (sorry if I missed it) | 14:36 |
| anteaya | Haomeng: I am full time with mordred's team and I float around, infra, ironic, refstack, storyboard | 14:37 |
| Haomeng | great | 14:37 |
| anteaya | I am fairly new to the team and trying to find my home | 14:37 |
| NobodyCam | :) | 14:37 |
| Haomeng | I amfulltime on Ironic now | 14:37 |
| anteaya | awesome | 14:37 |
| anteaya | you picked a great team | 14:37 |
| Haomeng | Lucas, see your comments on my defect, thank you | 14:38 |
| Haomeng | will commit new patch:) | 14:38 |
| NobodyCam | is lucasagomes here? | 14:38 |
| Haomeng | he is reviewing my code now:) | 14:38 |
| Haomeng | lucasagomes: new findings | 14:39 |
| NobodyCam | :) | 14:39 |
| NobodyCam | GheRivero: lol I grilled deva over that same line on 51743 last night | 14:40 |
| Haomeng | I put two fileds into our base.py, but only works with node object | 14:40 |
| lucasagomes | hey I'm sorry | 14:40 |
| lucasagomes | NobodyCam, how r u? | 14:40 |
| Haomeng | for portsand chassis , looks like it does not work | 14:40 |
| lucasagomes | anteaya, I'm good as well thanks ^^ | 14:41 |
| Haomeng | lucasagomes: do you have idea? | 14:41 |
| lucasagomes | Haomeng, only works with node you mean using the CLI isn't it? | 14:41 |
| Haomeng | API | 14:42 |
| Haomeng | I focus onAPI now | 14:42 |
| NobodyCam | you can read the the convo in http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2013-10-25.log arounf 00:22 | 14:42 |
| Haomeng | if APi does not work, cli will notwok | 14:42 |
| lucasagomes | cause the CLI filters what's displayed and the only resource that has those fields create_at and updated_at is the nodes | 14:42 |
| lucasagomes | Haomeng, oh yea, hmm should work for the other as well | 14:42 |
| Haomeng | lucasagomes, I mean API does not work for ports I found now | 14:42 |
| lucasagomes | off the top of my head idk why only nodes worked | 14:42 |
| NobodyCam | lucasagomes: doing good. can you 51743 | 14:42 |
| lucasagomes | have you checked the db? create_at and updated_at on the other resources are contains the dates as well? | 14:43 |
| Haomeng | ok, let me check the convo you pointed | 14:43 |
| NobodyCam | lucasagomes: can you take a look at 51743 | 14:43 |
| Haomeng | let mecheck db | 14:43 |
| lucasagomes | NobodyCam, will do | 14:43 |
| * NobodyCam goes to get coffee | 14:43 | |
| lucasagomes | :) | 14:43 |
| lucasagomes | NobodyCam, oh yea I gotta test it ^^ I was doing some internal stuff for rh this morning didn't had time to actually give it a go | 14:43 |
| lucasagomes | didnt have | 14:44 |
| lucasagomes | * | 14:44 |
| Haomeng | db is fine | 14:44 |
| Haomeng | we can find created_at value in db after the port is created | 14:44 |
| Haomeng | but the port API will notreturn created_at value , strange | 14:44 |
| Haomeng | will debug | 14:44 |
| lucasagomes | I see, hmm off the top of my head I don't really know why it just works for nodes then | 14:44 |
| Haomeng | no problem | 14:45 |
| Haomeng | tired,will go to sleep, nice day Ironic:) | 14:47 |
| Haomeng | good luck:) | 14:47 |
| *** prekarat has joined #openstack-ironic | 14:48 | |
| lucasagomes | Haomeng, g'night and awesome to have u onboard :) | 14:48 |
| NobodyCam | good night Haomeng | 14:48 |
| Haomeng | :) | 14:49 |
| romcheg | Good night Haomeng | 14:49 |
| NobodyCam | good morning romcheg | 14:49 |
| romcheg | Good afternoon lucasagomes | 14:49 |
| romcheg | Good morning NobodyCam | 14:49 |
| NobodyCam | :) | 14:49 |
| Haomeng | seeyou lucasagomes and NobodyCam | 14:50 |
| NobodyCam | :) have a good weekend Haomeng | 14:50 |
| lucasagomes | romcheg, dia dhuit :) how r u? | 14:51 |
| romcheg | lucasagomes: better than it can be. Hate doctors :) | 14:52 |
| NobodyCam | romcheg: ++++++++ | 14:52 |
| romcheg | How are you? | 14:52 |
| lucasagomes | hehe can imagine | 14:52 |
| lucasagomes | I'm fine thanks | 14:52 |
| lucasagomes | I hate dentists more than doctors | 14:52 |
| NobodyCam | oh yes | 14:52 |
| lucasagomes | I probably will have to remove a wisdom tooth I have | 14:52 |
| lucasagomes | urgh! | 14:52 |
| romcheg | Cannot drink alcohol until the new year. Can you please remind me why else do we gather on the summit? :D | 14:53 |
| NobodyCam | :( | 14:53 |
| NobodyCam | oh no | 14:53 |
| lucasagomes | oh damn | 14:53 |
| lucasagomes | btw, did you guys sign up for some of the parties? | 14:54 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Fix test node manager https://review.openstack.org/53877 | 14:54 |
| romcheg | lucasagomes: I've just tried to do ironic node-list and got "Invalid OpenStack Identity credentials." | 14:56 |
| romcheg | keystone endpoint-list worked well after that | 14:56 |
| lucasagomes | :D | 14:57 |
| lucasagomes | good stuff | 14:57 |
| romcheg | that's the master of ironic-client | 14:58 |
| openstackgerrit | A change was merged to openstack/ironic: Supports paginate query for two get nodes DB APIs https://review.openstack.org/53232 | 14:58 |
| romcheg | clear | 14:58 |
| romcheg | whoops, sorry | 14:58 |
| romcheg | confused terminal window and irc chat :) | 14:58 |
| *** WillOchanda has joined #openstack-ironic | 15:00 | |
| NobodyCam | $> | 15:01 |
| *** yuriyz has quit IRC | 15:02 | |
| *** pky has quit IRC | 15:06 | |
| *** pky has joined #openstack-ironic | 15:07 | |
| lucasagomes | NobodyCam, and the hoodies did you get to see then already? | 15:10 |
| NobodyCam | i have not. I'm in palm springs now. I expect that are in seattle | 15:11 |
| NobodyCam | that= they | 15:11 |
| lucasagomes | ah sometimes I forget that ur a nomade :) | 15:11 |
| lucasagomes | nomad* | 15:12 |
| NobodyCam | lol :) | 15:12 |
| NobodyCam | i will try and track them down | 15:12 |
| lucasagomes | cooleo :) | 15:13 |
| lucasagomes | looking fwd to get one | 15:13 |
| NobodyCam | ya | 15:14 |
| GheRivero | 'morning' all | 15:15 |
| NobodyCam | morning GheRivero :) | 15:15 |
| romcheg | Which hotel do you guys live during the summit? | 15:15 |
| NobodyCam | GheRivero: I replyed to your comment on 51743 | 15:16 |
| NobodyCam | romcheg: which ever is the host hotel | 15:16 |
| lucasagomes | romcheg, I delayed to book so I only found a room at novotel | 15:16 |
| NobodyCam | :-p | 15:16 |
| lucasagomes | which is an official hotel but a bit from the conference | 15:16 |
| romcheg | lucasagomes: I will also live in novotel | 15:17 |
| lucasagomes | ahh nice | 15:17 |
| GheRivero | NobodyCam: thanks, i was reading thtough that | 15:17 |
| NobodyCam | :) | 15:17 |
| lucasagomes | romcheg, we can meet before and find our way to the conference then | 15:17 |
| NobodyCam | i had the same thoughts GheRivero | 15:17 |
| NobodyCam | :) | 15:17 |
| romcheg | lucasagomes: looks like a nice idea. | 15:18 |
| GheRivero | it's ok... but not logical :) | 15:18 |
| NobodyCam | lol | 15:20 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Expose /drivers on the API https://review.openstack.org/53157 | 15:22 |
| lucasagomes | NobodyCam, 51743 reviwed and tested :) | 15:22 |
| NobodyCam | awesomes | 15:22 |
| NobodyCam | GheRivero: you still want to keep -1 on 51743? | 15:23 |
| GheRivero | nono, i-ll update it now | 15:24 |
| NobodyCam | awesome-ness | 15:25 |
| NobodyCam | WillOchanda: give it a few minutes to land but https://review.openstack.org/#/c/51743/ is approved now | 15:29 |
| openstackgerrit | A change was merged to openstack/ironic: Conductors maintan driver list in the DB https://review.openstack.org/51743 | 15:30 |
| devananda | morning, all | 15:35 |
| romcheg | Morning devananda | 15:35 |
| NobodyCam | Good morning devananda | 15:35 |
| devananda | \o/ | 15:36 |
| lucasagomes | devananda, morning :) | 15:37 |
| NobodyCam | lucasagomes: are you going to be able to address the comments on: 52902? | 15:38 |
| lucasagomes | NobodyCam, oh yes! | 15:38 |
| NobodyCam | :) | 15:38 |
| * lucasagomes loads of patches around | 15:38 | |
| NobodyCam | lol | 15:38 |
| NobodyCam | oh ya | 15:39 |
| devananda | lucasagomes: you might soon find yourself burdened with reviews and having to time to write code ;) | 15:39 |
| NobodyCam | hehehehehe | 15:40 |
| lucasagomes | devananda, haha yea! | 15:40 |
| devananda | lucasagomes: also, grats -- it's now official and stuff | 15:42 |
| NobodyCam | woo hoo !!!! congrats lucasagomes !!!! | 15:42 |
| lucasagomes | devananda, NobodyCam awesome! thank you!!! | 15:42 |
| NobodyCam | you deservie it. Awesome job buddy | 15:43 |
| lucasagomes | ah cheers man, I'm pretty happy! | 15:43 |
| NobodyCam | great way to start the weekend | 15:44 |
| lucasagomes | indeed! | 15:45 |
| lucasagomes | only one thing, monday is national holiday here, so I probably wont work | 15:45 |
| lucasagomes | but I will make it to the meeting at night | 15:45 |
| NobodyCam | you better :-p | 15:46 |
| NobodyCam | heheheh | 15:46 |
| lucasagomes | haha will do | 15:46 |
| devananda | lucasagomes: enjoy! don't spend all weekend reviewing code ;) | 15:47 |
| lucasagomes | hehe will try not to :) | 15:47 |
| devananda | anyone know if rloo had any code on https://bugs.launchpad.net/ironic/+bug/1237688 ? | 15:48 |
| *** sjing has quit IRC | 15:48 | |
| *** sjing has joined #openstack-ironic | 15:48 | |
| devananda | that one's nagging at me. power control is pretty badly broken right now, i'm bumping the bug to critical | 15:49 |
| lucasagomes | I'm not aware of any code no :/ | 15:50 |
| devananda | als, i'll bring this up at the meeting, but the nova blueprint discussion has me thinking it's time for a purge | 15:50 |
| devananda | clear out all BPs that aren't in progress, or have clearly stated goals, and then at the summit encourage everyone to lay out a clear plan for Icehouse | 15:51 |
| devananda | thoughts? | 15:53 |
| NobodyCam | devananda: I'd +1 | 15:54 |
| lucasagomes | devananda, yea +1, I think the tasks on that trello page are pretty straight forward, we can use that | 15:55 |
| devananda | cool | 15:56 |
| devananda | then maybe i'll start this weekend :) | 15:56 |
| lucasagomes | sweet | 15:56 |
| *** sjing has quit IRC | 15:56 | |
| NobodyCam | :) | 15:56 |
| NobodyCam | devananda: side note. have you seen the scroll back from this morning Haomeng is now full time on ironic | 15:57 |
| devananda | awesome | 15:59 |
| devananda | Haomeng: around? | 16:01 |
| *** lnxnut_ has joined #openstack-ironic | 16:02 | |
| *** lnxnut has quit IRC | 16:02 | |
| NobodyCam | devananda: I think he is asleep now | 16:04 |
| devananda | probably | 16:04 |
| devananda | lucasagomes: see -dev? | 16:04 |
| NobodyCam | he is utc +8 | 16:04 |
| *** martyntaylor has left #openstack-ironic | 16:04 | |
| lucasagomes | devananda, yup | 16:04 |
| devananda | right. eastern china | 16:04 |
| devananda | i think | 16:04 |
| NobodyCam | ya | 16:05 |
| devananda | lucasagomes: mind missing the opening tripleo session to represent us to pecan/wsme folks? | 16:05 |
| NobodyCam | devananda: have you been in contact with markAtWood | 16:05 |
| NobodyCam | of late.. | 16:05 |
| devananda | NobodyCam: he's been travelling for the last ~10 days. | 16:05 |
| devananda | NobodyCam: i'll probably see him tmw | 16:06 |
| lucasagomes | devananda, I'm grand with that | 16:06 |
| NobodyCam | ya looking for the hooodies | 16:06 |
| lucasagomes | I was planning to go to that section anyway | 16:06 |
| devananda | lucasagomes: awesome, tyvm | 16:06 |
| NobodyCam | bbt. and make more coffee... brb | 16:07 |
| *** WillOchanda has quit IRC | 16:15 | |
| *** jistr has quit IRC | 16:16 | |
| *** martyntaylor has joined #openstack-ironic | 16:17 | |
| *** prekarat has quit IRC | 16:25 | |
| romcheg | Trying to instal Ironic on all devstack gates | 16:29 |
| romcheg | https://review.openstack.org/#/c/53899/2 | 16:29 |
| NobodyCam | romcheg: :) | 16:30 |
| devananda | oooo :) | 16:30 |
| devananda | romcheg: how's the tempest API tests? | 16:30 |
| devananda | https://review.openstack.org/#/c/48109/ | 16:31 |
| romcheg | No one took a look at them | 16:31 |
| *** epim has joined #openstack-ironic | 16:31 | |
| devananda | hum | 16:32 |
| devananda | are they good to go? if so, i'll go poke people | 16:32 |
| romcheg | Gimme this afternoon pls | 16:33 |
| devananda | k | 16:33 |
| romcheg | I have made some other tchanges | 16:33 |
| devananda | so anytime we're waiting on another team for something important, feel free to ping me about it | 16:33 |
| romcheg | devananda: thanks | 16:34 |
| *** nick_long has quit IRC | 16:34 | |
| romcheg | brb | 16:35 |
| *** romcheg has quit IRC | 16:36 | |
| devananda | lucasagomes: question on the API & exceptions | 16:36 |
| lucasagomes | devananda, shoot | 16:37 |
| devananda | lucasagomes: are we not doing any wrapping so that pytho ntracebacks get squelched? | 16:37 |
| *** martyntaylor has quit IRC | 16:37 | |
| lucasagomes | I think that yuri will update that patch | 16:37 |
| lucasagomes | as I commented I would prefer to return a simple message | 16:38 |
| lucasagomes | and expect the admins to check the logs instead | 16:38 |
| lucasagomes | where he can see the tracebacks | 16:38 |
| devananda | eg,w hen testing the set-power-state patch, i was able tos ee the full SSH driver stack trace from the client, without even doing --debug | 16:38 |
| lucasagomes | that's bad imo | 16:38 |
| devananda | very very bad, IMO | 16:39 |
| lucasagomes | yea | 16:39 |
| devananda | and it's not a matter of fixing one or two spots. I thin kit's an issue with the middleware | 16:39 |
| lucasagomes | here is how I see it | 16:39 |
| lucasagomes | when some internal error happens I would say that in most cases we should just log it | 16:40 |
| lucasagomes | and return something simple | 16:40 |
| lucasagomes | unless the client can do something about it | 16:40 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement /nodes/UUID/vendor_passthru in the API https://review.openstack.org/53761 | 16:40 |
| devananda | there are rouighly two cases of exceptions to consider | 16:41 |
| devananda | a low-level one that we should catch at a higher level | 16:41 |
| linggao | NobodyCam, I am hopeless in resolving the merge conflict with lucasagomes patch. git rebase --continue keeps saying that I need to resolve all the conflicts. | 16:41 |
| lucasagomes | then (for known errors) we might want to expose some internal things on the message | 16:41 |
| lucasagomes | but we always need a wrapper to clean that up for sure | 16:41 |
| devananda | and any exception we dont expect and therefor dont catch | 16:41 |
| linggao | git is drving me crazy :( | 16:41 |
| devananda | linggao: you need to edit the files which have a conflict to manually resolve it | 16:42 |
| devananda | linggao: then "git add /path/to/file" before you "git rebase --continue" | 16:42 |
| lucasagomes | linggao, you should fix it and then add it with git add | 16:42 |
| lucasagomes | and then you --continue | 16:42 |
| lucasagomes | yea just deva said | 16:43 |
| linggao | ah, I did not do git add, let me try . Thanks guys. | 16:43 |
| devananda | lucasagomes: so, in either case (we catch, log, and reraise; we dont catch at all) I think the API should still never-ever expose the stack trace | 16:43 |
| NobodyCam | devananda: that patch is what WillOchanda needs? | 16:43 |
| devananda | lucasagomes: whether the API cleans up the exception or not is secondary (and important) | 16:43 |
| devananda | NobodyCam: yes | 16:43 |
| lucasagomes | devananda, oh yea I agree with that, tracebacks are awful to see on a body request | 16:44 |
| devananda | lucasagomes: AIUI, api/middleware/parsable_error.py is supposed to do that sort of thing | 16:44 |
| devananda | lucasagomes: not just awful to see, but totally inappropriate. clients should not see an application's internal stack trace :) | 16:45 |
| *** epim_ has joined #openstack-ironic | 16:45 | |
| devananda | I'm fine with users seeing the actual exception messages | 16:45 |
| lucasagomes | I see, I'll check it out in our API | 16:45 |
| lucasagomes | but not the traceback, yea +1 | 16:45 |
| devananda | right | 16:45 |
| *** epim has quit IRC | 16:46 | |
| *** epim_ is now known as epim | 16:46 | |
| lucasagomes | but in the case of yuriz patch, I tend to think that we should simple return some generic "Internal Error" message | 16:46 |
| devananda | lucasagomes: which one? | 16:46 |
| lucasagomes | assuming that admins should have access to the logs | 16:46 |
| lucasagomes | they can go and check it | 16:46 |
| devananda | lucasagomes: don't assume that | 16:46 |
| lucasagomes | the ones on the creation of the resources | 16:47 |
| devananda | ah, that | 16:47 |
| lucasagomes | yea, because, now it's just reraising the exception | 16:47 |
| devananda | it seems worth repeating -- we can't assume any user of ironic has access to the logs, or to the database | 16:48 |
| devananda | they must be a cloud admin, but for privilege separation, the guy who is enrolling the hardware (using the ironic CLI) may have no direct access to the hosts running the conductors | 16:49 |
| NobodyCam | devananda: question on the test in 53761.. test_vendor_passthru_without_method is testing the wsme.exc.ClientSideError that can be raised? | 16:49 |
| devananda | NobodyCam: ya? | 16:50 |
| lucasagomes | devananda, I see... so we might need to have a more elaborated output there, but not exposing any internal errors that might come with the exceptions the code is raising | 16:50 |
| lucasagomes | since he won't be able to do anything about it | 16:50 |
| devananda | lucasagomes: as far as exposing "DB error" to the user, I thin kthat's fine | 16:51 |
| *** romcheg has joined #openstack-ironic | 16:51 | |
| devananda | but something (midleware or ...?) needs to clean it up | 16:51 |
| linggao | lucasagomes, | 16:52 |
| devananda | in the case of https://review.openstack.org/#/c/53632/1, these are all dealing with the creation of new records | 16:52 |
| lucasagomes | devananda, yea now u mentioned that middleware, I will take a look | 16:52 |
| linggao | for i18n, you did not do the help part. is it needed? | 16:52 |
| devananda | so the internal error is probably very meaningful | 16:52 |
| lucasagomes | haven't tested that with our api at all | 16:52 |
| linggao | @utils.arg('node', | 16:52 |
| linggao | metavar='<node id>', | 16:52 |
| linggao | help="ID of node") | 16:52 |
| devananda | linggao: i looked at nova for comparison. it doesn't include _ for help either | 16:52 |
| devananda | linggao: so i suspect, but need to check with clarkb, that the help text is being translated another way | 16:53 |
| linggao | ok, so for now should I leave out the help part? | 16:53 |
| lucasagomes | yea also, I don't think that the clients are being i18n'ed to be honest | 16:53 |
| NobodyCam | devananda: linggao: seems every client i looked at does not handle i18n | 16:54 |
| lucasagomes | yea, we might start doing it and be a good example :) | 16:54 |
| NobodyCam | :) | 16:54 |
| devananda | even the help text in the services isn't _'d | 16:54 |
| NobodyCam | lucasagomes: +1 | 16:54 |
| NobodyCam | ya also what about stuff like https://github.com/openstack/python-ironicclient/blob/master/ironicclient/v1/node_shell.py#L100 | 16:56 |
| linggao | another interesting thing is the help for sub command. | 16:57 |
| linggao | def do_node_show(cc, args): | 16:57 |
| linggao | """Show a node.""" | 16:57 |
| linggao | that's where the help stores. | 16:57 |
| lucasagomes | yea it uses the docstrings | 16:57 |
| linggao | how do we i18n it? | 16:58 |
| romcheg | What gates should we test Ironic on? | 16:58 |
| lucasagomes | linggao, I don't know. But as a user I would like to have the help translated as well, we gotta do some research about it | 16:58 |
| romcheg | I propose the following ones | 16:58 |
| romcheg | - check-tempest-devstack-vm-smoke | 16:58 |
| romcheg | - check-tempest-devstack-vm-full | 16:58 |
| romcheg | - check-tempest-devstack-vm-postgres-full | 16:58 |
| romcheg | - check-tempest-devstack-vm-neutron | 16:58 |
| romcheg | - gate-tempest-devstack-vm-large-ops | 16:58 |
| romcheg | - gate-tempest-devstack-vm-neutron-large-ops | 16:58 |
| linggao | ok, let me give it a try... | 16:58 |
| devananda | romcheg: i'm not familiar with all teh current gate checks | 16:59 |
| devananda | clarkb or mordred ^^ ? | 16:59 |
| *** derekh has quit IRC | 16:59 | |
| clarkb | devananda: romcheg: so, are devstack and tempest capable of configuring and running ironic in a meaningful way? | 17:00 |
| devananda | romcheg: my inclination is, right now -smoke, -full, -postgres-full, is probably sufficient. we dont have neutron integration done in the pxe driver yet | 17:00 |
| clarkb | there isn't much sense in running those jobs if they never touch ironic | 17:00 |
| clarkb | but if they do then yes, the standard complement of tempest jobs makes sense | 17:00 |
| clarkb | devananda: you don't want -smoke that will die finally when folsom goes away | 17:01 |
| devananda | clarkb: to what degree of "meaningful"? | 17:01 |
| devananda | clarkb: ah. k | 17:01 |
| clarkb | devananda: is it installed and tested in any way? | 17:01 |
| romcheg | clarkb: devstack is able to configure and run Ironic already | 17:01 |
| clarkb | you can run those tests but if there is no intersection with ironic you don't get anything | 17:01 |
| devananda | clarkb: we have API and RPC services, and fake drivers, and a CLI, that should all get tested | 17:01 |
| devananda | clarkb: we don't have the sort of tripleo things yet to test actual creation of VMs | 17:02 |
| romcheg | And there is a patch to tempest that adds some tests for Ironic | 17:02 |
| clarkb | cool, I would start with the list under nova and we can prune that as necessary (eg remove smoke jobs because folsom is going away soon) | 17:02 |
| romcheg | So we leave -vm-full, vm-postgres-full and vm-large-ops, right? | 17:03 |
| clarkb | yup and the neutron jobs | 17:05 |
| romcheg | Neutron jobs might be added later IMO. We do not have any integration with neutron atm | 17:05 |
| clarkb | in that case they aren't necessary | 17:06 |
| clarkb | just be sure to add them when integration with neutron happens :) | 17:07 |
| romcheg | thanks for your help clarkb :) | 17:07 |
| devananda | clarkb: what does vm-large-ops do? | 17:10 |
| clarkb | devananda: it spins up nova with the fake libvirt driver and makes a bunch of requests to multiple nova api instances. Its aim is to stress nova intenrals without waiting for DB and hypervisor IO | 17:11 |
| devananda | lucasagomes: still around? | 17:11 |
| lucasagomes | devananda, yes | 17:11 |
| lucasagomes | looking at the manpage thing :) | 17:11 |
| devananda | clarkb: ahh. sweet. that'd be perfect for adding similar workload to test ironic with lots of fake instances | 17:11 |
| devananda | clarkb: should we (perhaps in the future) make some different tests that stress ironic in certain ways, without duplicating the time needed to stress unrelated things? | 17:13 |
| clarkb | devananda: you might be able to tack onto that job. I would speak to jog0 about it, he wrote the test | 17:17 |
| devananda | cool | 17:20 |
| openstackgerrit | A change was merged to openstack/ironic: Remove several old TODO messages https://review.openstack.org/53492 | 17:22 |
| openstackgerrit | A change was merged to openstack/ironic: Remove redundant test stubs from conductor/manager https://review.openstack.org/53493 | 17:23 |
| NobodyCam | lol | 17:24 |
| NobodyCam | lucasagomes: think some of those stubs may be needed | 17:26 |
| NobodyCam | see my comment on 53830 | 17:26 |
| lucasagomes | NobodyCam, ouch | 17:29 |
| lucasagomes | checking | 17:29 |
| NobodyCam | :-p | 17:29 |
| romcheg | Here we go | 17:31 |
| romcheg | https://review.openstack.org/#/c/53917/ | 17:31 |
| lucasagomes | NobodyCam, well ont a big deal tho, I mean people implemented other tests without even looking at those TODO's | 17:31 |
| NobodyCam | ya | 17:31 |
| linggao | devananda, NobodyCam lucasagomes, here is how to do i18n for command. | 17:32 |
| NobodyCam | I adjust my comment to request adding tests | 17:32 |
| linggao | for help on the subcommand, https://github.com/openstack/python-ironicclient/blob/master/ironicclient/common/utils.py#L46 | 17:32 |
| lucasagomes | so it was hanging there, it's kinda more natural to do ur change and create the tests instead of looking if there's some tests functions created but not implemented for ur changes | 17:32 |
| linggao | change help=... to help = _(..) | 17:32 |
| lucasagomes | NobodyCam, but thanks for pointing out :) | 17:32 |
| linggao | devananda, NobodyCam lucasagomes, the question is: shoule we go a head to it or leave it the command's i18n alone? | 17:35 |
| *** epim has quit IRC | 17:36 | |
| NobodyCam | linggao: I see value in it. but maybe a version 2 (after summit) thing? lucasagomes devananda thooughts? | 17:37 |
| devananda | linggao: i would not worry about i18n for help="" stuff right now | 17:37 |
| devananda | linggao: if you're looking for things to do, there aer open / unassigned bugs :) | 17:37 |
| lucasagomes | yea | 17:37 |
| linggao | I am holding node_shell.py in my patch. ok, I'll remove the changes and check it in. | 17:37 |
| lucasagomes | or if wanna play with the CLI | 17:38 |
| lucasagomes | consolidating the exceptions messages | 17:38 |
| lucasagomes | would be useful as well | 17:38 |
| * devananda should file a bug for that | 17:38 | |
| * NobodyCam brb | 17:39 | |
| linggao | no, no, no. I'll be pulled away by my company for a couple of weeks. Just want to finish up the current patch that has node_shell.py that NobodyCam asked me to do the i18n in it. :) | 17:39 |
| *** pky has quit IRC | 17:40 | |
| devananda | linggao: ah, i see | 17:41 |
| linggao | :) | 17:41 |
| linggao | anyway, I'll remove the _() on the help I did in it. | 17:42 |
| lucasagomes | alright people I'm done for today, have a great weekend! devananda NobodyCam linggao | 17:43 |
| linggao | have a good weekend lucausagomes. | 17:43 |
| lucasagomes | also, monday's national holiday here but I'll make it to the meeting! | 17:43 |
| devananda | cheers, lucasagomes. have a good weekend! | 17:44 |
| linggao | lucasagomes, do not work too hard. | 17:44 |
| linggao | oops, do not tell my boss I said that. :) | 17:45 |
| lucasagomes | haha | 17:45 |
| lucasagomes | aight, see ya folks! | 17:45 |
| *** lucasagomes has quit IRC | 17:45 | |
| linggao | ironic, how to remove a dependency from a patch? | 17:52 |
| NobodyCam | clarkb: mordred ^^^ how can one remove a dependency that was added review -d #### | 17:53 |
| devananda | linggao: you can rebase | 17:53 |
| NobodyCam | devananda: on master? | 17:54 |
| devananda | eg, if your git log looks like this: master->p1->yourpatch | 17:54 |
| devananda | and you want it to be master->yourpatch | 17:54 |
| devananda | then do this | 17:54 |
| devananda | git rebase -i | 17:54 |
| devananda | delete the line for "p1" | 17:54 |
| devananda | assuming the rebase has no errors, then you can do "git review -R" | 17:55 |
| NobodyCam | ahh the houses new sparkplug wires are in... /me knows what he is doing this weekend. replacing sparkplug wires on the house :- | 17:56 |
| mordred | NobodyCam: whatdo you want to do? | 17:56 |
| mordred | yes | 17:56 |
| mordred | listen to devananda | 17:56 |
| NobodyCam | mordred: devananda got the answer | 17:56 |
| NobodyCam | TY | 17:57 |
| openstackgerrit | linggao proposed a change to openstack/python-ironicclient: Modifies CLI to show nodes by instance uuid https://review.openstack.org/53485 | 17:57 |
| clarkb | devananda: don't use git review -R unless you really need it :) | 17:57 |
| linggao | devananda, thanks. I am so afraid of those options in git review :) | 17:58 |
| devananda | clarkb: i use it al lthe time :) | 17:58 |
| clarkb | devananda: if you have an up to date git review the -R option shouldn't be necessary in most cases | 17:58 |
| clarkb | git review now checks if there are conflicts and only rebasees by default if there are | 17:58 |
| linggao | what does -R do? | 17:58 |
| clarkb | otherwise the behavior is the same as -R and no rebasing happens | 17:58 |
| clarkb | linggao: prevents a rebase before pushing | 17:58 |
| devananda | clarkb: eg, i have a stack of patches and i only change the top one. git review -R saves teh others from needless spam | 17:58 |
| devananda | ah | 17:59 |
| devananda | so ^ is default now? | 17:59 |
| clarkb | devananda: ish, it will rebase if you need a rebase | 17:59 |
| linggao | I just did -R. Hope it is right. | 17:59 |
| devananda | speaking of, /me rebases one of lucas' patches | 18:00 |
| devananda | ugh, another big quake near japan | 18:02 |
| NobodyCam | devananda: when? | 18:04 |
| *** pky has joined #openstack-ironic | 18:04 | |
| NobodyCam | oh wow near Fukushima | 18:05 |
| devananda | <1hr ago | 18:06 |
| NobodyCam | ya just looked it up :( | 18:06 |
| linggao | M 7.3 Earthquake | 18:08 |
| linggao | Off the east coast of Honshu, Japan | 18:08 |
| linggao | . 44 mins ago – U.S. Geological Survey | 18:08 |
| NobodyCam | just watched pacific rim lastnight it could be a Kaiju | 18:08 |
| devananda | :p | 18:14 |
| NobodyCam | they distroy HK in that movie.. | 18:14 |
| devananda | stepping out for an errand, bbiah | 18:24 |
| NobodyCam | :) | 18:24 |
| *** pky has quit IRC | 18:34 | |
| *** lnxnut has joined #openstack-ironic | 18:35 | |
| *** lnxnut__ has joined #openstack-ironic | 18:37 | |
| *** lnxnut_ has quit IRC | 18:37 | |
| *** lnxnut has quit IRC | 18:40 | |
| openstackgerrit | A change was merged to openstack/ironic: Fix exceptions handling in controllers https://review.openstack.org/53632 | 18:42 |
| *** epim has joined #openstack-ironic | 18:44 | |
| *** pky has joined #openstack-ironic | 18:47 | |
| *** epim has quit IRC | 19:04 | |
| *** epim has joined #openstack-ironic | 19:10 | |
| *** epim_ has joined #openstack-ironic | 19:11 | |
| *** epim_ has quit IRC | 19:12 | |
| *** epim_ has joined #openstack-ironic | 19:14 | |
| *** epim has quit IRC | 19:14 | |
| *** epim_ is now known as epim | 19:14 | |
| *** WillOchanda has joined #openstack-ironic | 19:31 | |
| *** pky has quit IRC | 19:32 | |
| openstackgerrit | linggao proposed a change to openstack/ironic: Supports get node by instance uuid in API https://review.openstack.org/53262 | 19:32 |
| *** pky has joined #openstack-ironic | 19:53 | |
| *** pky has quit IRC | 19:59 | |
| *** pky has joined #openstack-ironic | 20:01 | |
| *** lnxnut__ has quit IRC | 20:25 | |
| *** epim has quit IRC | 20:30 | |
| *** epim has joined #openstack-ironic | 20:35 | |
| *** jdob has quit IRC | 20:37 | |
| *** romcheg has left #openstack-ironic | 20:47 | |
| *** linggao has quit IRC | 20:58 | |
| *** pky has quit IRC | 21:07 | |
| *** WillOchanda has quit IRC | 21:15 | |
| *** WillOchanda has joined #openstack-ironic | 21:22 | |
| *** pky has joined #openstack-ironic | 21:22 | |
| *** michchap has quit IRC | 21:51 | |
| *** michchap has joined #openstack-ironic | 21:53 | |
| *** pky has quit IRC | 21:57 | |
| *** pky has joined #openstack-ironic | 21:59 | |
| openstackgerrit | Kevin McDonald proposed a change to openstack/python-ironicclient: Fixes Auth Token being sent as lambda function https://review.openstack.org/53963 | 21:59 |
| *** epim has quit IRC | 22:16 | |
| *** pky has quit IRC | 23:03 | |
| NobodyCam | clarkb: you were not kidding when you said tox -r would be slower :-p | 23:11 |
| clarkb | NobodyCam: it has to build the venv each time | 23:11 |
| NobodyCam | :) | 23:12 |
| clarkb | NobodyCam: if you leave off the -r it should be faster but then you may fall a little behind on deps. lifeless and SpamapS combat this with a squid caching proxy | 23:12 |
| NobodyCam | question 'tox -r -e py33' would run only python 3.3 tests? | 23:12 |
| clarkb | yes | 23:13 |
| NobodyCam | sweet TY | 23:13 |
| clarkb | honestly -r is probably overkill for most cases, but when the question is "why did this fail in jenkins but not locally?" a good place to start is with -r | 23:13 |
| NobodyCam | :) | 23:14 |
| *** epim has joined #openstack-ironic | 23:14 | |
| *** jbjohnso has joined #openstack-ironic | 23:27 | |
| Haomeng | devananda: good afternoon:) | 23:30 |
| NobodyCam | hey good morning Haomeng | 23:31 |
| NobodyCam | what time is it there? | 23:31 |
| Haomeng | NobodyCam: good afternoon | 23:31 |
| Haomeng | I am on early morning, 7am:) | 23:32 |
| *** pky has joined #openstack-ironic | 23:35 | |
| NobodyCam | :-p | 23:35 |
| NobodyCam | I'm generaly online around 7:30 | 23:36 |
| NobodyCam | :) | 23:36 |
| NobodyCam | devananda: is out running earands ... can I help? | 23:36 |
| NobodyCam | errands even | 23:37 |
| Haomeng | :) | 23:38 |
| Haomeng | thank you NobodyCam | 23:38 |
| Haomeng | let me try again my code, and ask you if still not working:) | 23:39 |
| NobodyCam | :) sure | 23:39 |
| *** michchap has quit IRC | 23:43 | |
| *** michchap has joined #openstack-ironic | 23:43 | |
| Haomeng | NobodyCam, I have question about "response = self.patch_json('/ports/%s' % pdict['uuid']," in unittest code | 23:46 |
| Haomeng | not sure if such response just return http code no any port json returned, I try to get response.json string, can not retrieve | 23:47 |
| *** WillOchanda has quit IRC | 23:48 | |
| Haomeng | I want to test port object update API, but cannot get json returned by patch_json | 23:48 |
| *** pky has quit IRC | 23:48 | |
| NobodyCam | in the test framework? | 23:48 |
| *** epim has quit IRC | 23:51 | |
| *** WillOchanda has joined #openstack-ironic | 23:52 | |
| *** epim has joined #openstack-ironic | 23:52 | |
| Haomeng | yes, in our unittestcode | 23:52 |
| NobodyCam | one sec | 23:53 |
| Haomeng | let me try, maybe our update/patch api will not return the object json which isupdated | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!