Saturday, 2013-10-26

« Friday, 2013-10-25 Index Sunday, 2013-10-27 »
NobodyCamHaomeng: is this what you looking at? https://github.com/openstack/ironic/blob/master/ironic/tests/api/test_ports.py#L184-L18600:00
*** WillOchanda has quit IRC00:02
Haomengyes, our TestPatch will call patch_json to update object00:03
Haomengbut can not get the port json from  patch_json's response, just get 20000:04
HaomengI try to retrieve " response['created_at']" from the response, but we get "TypeError: 'TestResponse' object has no attribute '__getitem__'"00:05
Haomengnot  sure if this as design00:05
NobodyCamcan you paste the code so I can see.. .its after 5 on friday... brain mushy00:05
Haomengsorry00:05
Haomenglet me paste00:05
NobodyCamdon't be sorry00:06
NobodyCam:) its all good00:06
Haomenghttp://paste.openstack.org/show/49784/00:07
Haomengi pasted, help me take look00:07
NobodyCamsure :)00:08
Haomengthankyou:)00:08
HaomengI try with response.json['created_at'], still same error, so I think patch method can not response the port json, soquestion is how to verify the patch result?00:11
NobodyCamis this up for review? can I pull down the whole patch and run it localy00:13
NobodyCam?00:13
Haomengthis ut failed, so dont want to commit the code which has ut issue00:14
Haomengbut only two line change00:14
Haomengyou can apply00:14
NobodyCamjust the test then?00:14
NobodyCamthe one in the past00:15
Haomengno00:15
Haomengthis ismy defect00:16
Haomenghttps://review.openstack.org/#/c/53627/200:16
HaomengI want to expose created_at/updated_at properties in the REST API, so ut should cover these fields verification00:17
Haomengmy question is if patch_json doesnot return object json string, wehave to get/retireve it again to verify if the patch/update  works for our new fields00:19
HaomengNobodyCam, let me try again, thank you:)00:19
HaomengI think I can do:)00:19
Haomengthank you, good evening:)00:20
*** lifeless has quit IRC00:23
NobodyCamHaomeng: ok got the same error here00:24
NobodyCamlets see why00:24
HaomengI am debuging now:)00:25
Haomengto see what returned for patch call00:25
NobodyCamresult['created_at'] vs. response['created_at']00:27
*** michchap has quit IRC00:28
NobodyCamwhole new set of errors but they look real00:28
*** pky has joined #openstack-ironic00:28
Haomengyes00:28
HaomengNobodyCam, this is http://paste.openstack.org/show/49789/ - port-update api call details,fyi00:30
Haomengit return the update port already, but wecan not get from path_json result00:30
*** michchap has joined #openstack-ironic00:30
*** pky has quit IRC00:31
*** pky has joined #openstack-ironic00:32
Haomengand almost our  patch port/node code in unittest did not verify the update value from result00:34
Haomengthis should be ut gap00:34
NobodyCamyes we need better testing00:35
Haomengok, let me try to cover these patch result verify gap, thankyou NobodyCam, nice weekend, and good evening:)00:39
NobodyCamHaomeng: http://paste.openstack.org/show/Uwk6KDLJTM7IhvHtrbQD/00:44
Haomengyou mean we have to call "result = self.get_json('/ports/%s' % pdict['uuid']}" to getresult?00:47
Haomengok, thank you00:47
NobodyCam:)00:47
Haomengthat means patch_json willnot return port json whic is patched00:47
Haomengok, will addcode, thankyou00:48
HaomengI still understand patch_json will not return the json which is patched, so we have to retrieve again by get_json to verify00:51
NobodyCamHaomeng: try         self.assertTrue(timeutils.is_older_than(00:52
NobodyCam                          response.body['created_at'][:-6],00:52
NobodyCam                          0))00:52
NobodyCamdinner00:53
Haomengok, got, thanks00:57
HaomengI remenbered that i did thistry with response.body00:58
Haomenglet me double check00:58
Haomenghttp://paste.openstack.org/show/49796/   not working with response.body but looks like working with response.json01:04
SpamapSclarkb: re -r... why don't we have a --pip-install-U-but-dont-clear-out-venv ?01:08
clarkbSpamapS: because tox01:08
clarkbgetting patches in is almost impossible01:09
SpamapSwe added using develop to tox, right?01:09
clarkbyeah, after a year or so of trying by multiple people01:09
*** jbjohnso has quit IRC01:15
*** anteaya has quit IRC01:33
*** pky has quit IRC01:41
*** epim has quit IRC01:55
*** liteIRC has joined #openstack-ironic02:34
*** lnxnut has joined #openstack-ironic02:57
*** liteIRC has quit IRC03:09
*** lnxnut has quit IRC03:15
*** crandquist has joined #openstack-ironic03:28
*** kobier has quit IRC03:29
*** liteIRC has joined #openstack-ironic03:31
*** lnxnut has joined #openstack-ironic03:39
*** liteIRC has quit IRC04:02
*** lnxnut has quit IRC04:34
*** prekarat has joined #openstack-ironic04:56
*** crandquist has quit IRC05:16
*** lnxnut has joined #openstack-ironic05:45
*** lnxnut has quit IRC05:49
*** lifeless has joined #openstack-ironic05:55
*** Haomeng|2 has joined #openstack-ironic06:39
*** Haomeng has quit IRC06:39
*** Haomeng|2 has left #openstack-ironic06:41
*** Haomeng has joined #openstack-ironic06:43
*** romcheg has joined #openstack-ironic07:16
*** romcheg has left #openstack-ironic07:17
*** romcheg1 has joined #openstack-ironic08:41
*** romcheg has joined #openstack-ironic09:23
*** romcheg1 has quit IRC09:26
*** romcheg has quit IRC09:26
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Expose created_at/updated_at properties in the REST API  https://review.openstack.org/5362710:12
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Expose created_at/updated_at properties in the REST API  https://review.openstack.org/5362710:19
openstackgerritHaomeng,Wang proposed a change to openstack/python-ironicclient: Enable created_at/updated_at for port-show/chassis-show  https://review.openstack.org/5399110:42
*** romcheg has joined #openstack-ironic11:03
*** prekarat has quit IRC11:10
*** michchap_ has joined #openstack-ironic11:47
*** michchap has quit IRC11:47
*** jbjohnso has joined #openstack-ironic12:24
*** jbjohnso has quit IRC13:23
*** jbjohnso has joined #openstack-ironic14:03
*** datajerk has quit IRC14:12
*** Haomeng has quit IRC14:28
*** Haomeng has joined #openstack-ironic14:29
*** martyntaylor has joined #openstack-ironic14:30
*** martyntaylor has quit IRC14:40
clarkbSpamapS: it occurred to me that a pip install -U of the deps could be done as a test command prior to the actual tests14:40
clarkbbypasses regular tox dep management but should work14:41
*** jbjohnso has quit IRC14:50
NobodyCamHaomeng: wow busy day15:03
NobodyCamgood morning Ironic15:03
*** datajerk has joined #openstack-ironic15:15
*** WillOchanda has joined #openstack-ironic15:17
*** Haomeng has quit IRC15:32
*** Haomeng has joined #openstack-ironic15:33
*** michchap_ has quit IRC15:55
*** WillOchanda has quit IRC15:55
*** lnxnut has joined #openstack-ironic15:57
*** rustlebee is now known as russellb16:08
*** prekarat has joined #openstack-ironic16:19
*** Haomeng has quit IRC16:23
*** lnxnut has quit IRC16:24
*** lnxnut has joined #openstack-ironic16:25
*** michchap has joined #openstack-ironic16:25
*** michchap has quit IRC16:30
*** lnxnut has quit IRC16:30
*** ekarlso has quit IRC16:44
*** martyntaylor has joined #openstack-ironic16:47
*** pky has joined #openstack-ironic16:52
*** datajerk has quit IRC16:55
*** michchap has joined #openstack-ironic16:55
*** datajerk has joined #openstack-ironic16:57
*** michchap has quit IRC17:04
*** WillOchanda has joined #openstack-ironic17:07
*** datajerk has quit IRC17:08
devanandag'morning!17:13
*** WillOchanda has quit IRC17:16
*** prekarat has quit IRC17:17
*** michchap has joined #openstack-ironic17:50
*** michchap has quit IRC17:56
*** ekarlso has joined #openstack-ironic18:13
*** martyntaylor has quit IRC18:20
*** WillOchanda has joined #openstack-ironic18:27
*** martyntaylor has joined #openstack-ironic18:38
*** michchap has joined #openstack-ironic18:44
*** michchap has quit IRC18:49
*** WillOchanda has quit IRC18:53
*** SpamapS has quit IRC19:01
*** SpamapS has joined #openstack-ironic19:02
*** WillOchanda has joined #openstack-ironic19:21
*** WillOchanda has quit IRC19:28
*** WillOchanda has joined #openstack-ironic19:56
*** dkehn has quit IRC20:13
*** martyntaylor has left #openstack-ironic20:23
*** WillOchanda has quit IRC20:37
*** kobier has joined #openstack-ironic20:44
*** kobier has quit IRC20:45
*** dkehn has joined #openstack-ironic21:23
*** martyntaylor has joined #openstack-ironic21:24
*** martyntaylor has left #openstack-ironic21:28
*** martyntaylor has joined #openstack-ironic21:32
*** martyntaylor has left #openstack-ironic21:32
*** WillOchanda has joined #openstack-ironic21:36
*** martyntaylor has joined #openstack-ironic21:37
*** martyntaylor has left #openstack-ironic21:37
*** WillOchanda has quit IRC21:38
*** datajerk has joined #openstack-ironic22:09
*** WillOchanda has joined #openstack-ironic22:26
*** romcheg has quit IRC22:37
*** lnxnut has joined #openstack-ironic23:41
« Friday, 2013-10-25 Index Sunday, 2013-10-27 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!