| *** openstack has joined #openstack-ironic | 00:03 | |
| *** matsuhashi has joined #openstack-ironic | 00:09 | |
| max_lobur1 | looks like I won neutron :) | 00:13 |
|---|---|---|
| max_lobur1 | OPTION: 53 ( 1) DHCP message type 5 (DHCPACK) | 00:14 |
| mrda | max_lobur1: congratulations! (I think) | 00:14 |
| max_lobur1 | thx :) | 00:14 |
| max_lobur1 | will update patch tempest patch tomorrow | 00:14 |
| *** jcooley_ has quit IRC | 00:31 | |
| *** davidlenwell_ has joined #openstack-ironic | 00:48 | |
| *** pquerna_ has quit IRC | 00:49 | |
| *** davidlenwell has quit IRC | 00:49 | |
| *** pquerna_ has joined #openstack-ironic | 00:52 | |
| *** datajerk has joined #openstack-ironic | 00:56 | |
| *** nosnos has joined #openstack-ironic | 01:07 | |
| *** pquerna_ is now known as pquerna | 01:09 | |
| *** max_lobur1 has quit IRC | 01:15 | |
| *** rmiki has joined #openstack-ironic | 01:40 | |
| rmiki | hello | 01:41 |
| jroll | hiya rmiki | 01:43 |
| *** rmiki_ has joined #openstack-ironic | 01:44 | |
| rmiki_ | Does anyone attempt to cloud-init via Ironic? It doesn't work because nova-metadata seems can't lookup Ironic's instance-uuid. | 01:45 |
| rmiki_ | (I previously questioned before, but not responded.) | 01:45 |
| *** rmiki has quit IRC | 01:46 | |
| jroll | I'm not sure, I've heard chatter about using nova's metadata service | 01:48 |
| jroll | are you using the wip nova driver for ironic? | 01:48 |
| jroll | I would think that would put it in nova's DB | 01:48 |
| rmiki_ | No, I use Ironic directly. | 01:48 |
| jroll | ah, that might be why | 01:49 |
| jroll | are you using the standard ironic driver? (the pxe/iscsi thing) | 01:49 |
| rmiki_ | I didn't know about nova-ironic driver... | 01:50 |
| jroll | ahh | 01:50 |
| rmiki_ | I'll serch about this, thanks! | 01:51 |
| rmiki_ | search :) | 01:51 |
| jroll | here: https://review.openstack.org/#/c/71026/ | 01:51 |
| jroll | this is the latest version as of friday evening | 01:51 |
| jroll | I haven't personally used it, but I *think* it's working | 01:51 |
| jroll | devananda and NobodyCam have been working on it - I'm sure they'll be around tomorrow if you want to chat with them about it | 01:52 |
| jroll | rmiki_: ^ | 01:52 |
| rmiki_ | Okey, thank you. | 01:53 |
| jroll | no problem | 01:56 |
| *** vkozhukalov has joined #openstack-ironic | 02:35 | |
| *** rongze has joined #openstack-ironic | 03:12 | |
| *** lazy_prince has joined #openstack-ironic | 03:17 | |
| *** lazy_prince is now known as killer_prince | 03:17 | |
| *** coolsvap has joined #openstack-ironic | 03:20 | |
| *** SpamapS_ is now known as SpamapS | 03:30 | |
| *** SpamapS has quit IRC | 03:30 | |
| *** SpamapS has joined #openstack-ironic | 03:30 | |
| *** matsuhashi has quit IRC | 03:38 | |
| *** Kanagaraj has joined #openstack-ironic | 03:38 | |
| *** lnxnut has joined #openstack-ironic | 04:05 | |
| *** matsuhashi has joined #openstack-ironic | 04:22 | |
| *** sirushti is now known as shortstop | 04:45 | |
| *** matsuhas_ has joined #openstack-ironic | 05:14 | |
| *** lnxnut has quit IRC | 05:14 | |
| *** matsuhashi has quit IRC | 05:16 | |
| *** anniec has quit IRC | 05:18 | |
| *** lnxnut has joined #openstack-ironic | 05:22 | |
| *** lnxnut has quit IRC | 05:26 | |
| *** matsuhashi has joined #openstack-ironic | 05:27 | |
| *** matsuhas_ has quit IRC | 05:30 | |
| *** matsuhas_ has joined #openstack-ironic | 05:33 | |
| *** matsuhashi has quit IRC | 05:36 | |
| *** nosnos_ has joined #openstack-ironic | 05:43 | |
| *** nosnos has quit IRC | 05:43 | |
| *** jcooley_ has joined #openstack-ironic | 05:44 | |
| *** jcooley_ has quit IRC | 05:47 | |
| *** jcooley_ has joined #openstack-ironic | 05:49 | |
| *** jcooley_ has quit IRC | 05:49 | |
| *** killer_prince is now known as lazy_prince | 05:53 | |
| ekarlso | atop | 05:55 |
| *** matsuhas_ has quit IRC | 06:00 | |
| *** matsuhashi has joined #openstack-ironic | 06:01 | |
| *** mrda is now known as mrda_away | 06:03 | |
| *** lnxnut has joined #openstack-ironic | 06:05 | |
| *** matsuhas_ has joined #openstack-ironic | 06:05 | |
| *** matsuhashi has quit IRC | 06:05 | |
| *** lnxnut has quit IRC | 06:06 | |
| *** lnxnut has joined #openstack-ironic | 06:07 | |
| openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/71192 | 06:07 |
| *** lnxnut has quit IRC | 06:11 | |
| *** loki_ has joined #openstack-ironic | 06:19 | |
| *** matsuhas_ has quit IRC | 06:21 | |
| *** matsuhashi has joined #openstack-ironic | 06:22 | |
| *** matsuhashi has quit IRC | 06:22 | |
| *** matsuhashi has joined #openstack-ironic | 06:23 | |
| *** jcooley_ has joined #openstack-ironic | 06:25 | |
| *** rmiki_ has quit IRC | 06:30 | |
| *** lazy_prince2 has joined #openstack-ironic | 06:31 | |
| *** lazy_prince2 is now known as killer_prince | 06:32 | |
| *** nosnos_ has quit IRC | 06:32 | |
| *** nosnos has joined #openstack-ironic | 06:32 | |
| *** matsuhashi has quit IRC | 06:33 | |
| *** lazy_prince has quit IRC | 06:33 | |
| *** matsuhashi has joined #openstack-ironic | 06:38 | |
| *** jcooley_ has quit IRC | 06:42 | |
| *** vkozhukalov has quit IRC | 06:51 | |
| *** saju_m has joined #openstack-ironic | 06:58 | |
| *** lnxnut has joined #openstack-ironic | 07:05 | |
| *** lnxnut has quit IRC | 07:06 | |
| *** lnxnut has joined #openstack-ironic | 07:06 | |
| *** pradipta has joined #openstack-ironic | 07:08 | |
| *** lnxnut has quit IRC | 07:11 | |
| *** lazy_prince has joined #openstack-ironic | 07:13 | |
| zigo_ | lifeless: Can I add myself as uploader for subunit? | 07:41 |
| zigo_ | Jelmer Vernooij wrote to me that he wants to get removed. | 07:41 |
| zigo_ | Also, I know you love BZR (and that you've been upstream author of it), but it's currently a pain for me, I really would love to switch to Git, otherwise, I'm too scared to mess everything that I'd ask you to commit back to BZR... Your thoughts? | 07:42 |
| zigo_ | (otherwise, the package for 0.0.18 looks like ready for upload) | 07:44 |
| zigo_ | Ah no, it's creating python_subunit-0.0.egg-info ... :( | 07:46 |
| zigo_ | Not sure what's going on. | 07:46 |
| *** romcheg has joined #openstack-ironic | 07:51 | |
| *** romcheg has left #openstack-ironic | 07:51 | |
| *** ndipanov has joined #openstack-ironic | 07:51 | |
| *** matsuhashi has quit IRC | 07:52 | |
| *** matsuhashi has joined #openstack-ironic | 07:52 | |
| zigo_ | The ubuntu package has the same issue! :) | 07:53 |
| *** sanek12 is now known as agordeev | 07:57 | |
| *** pquerna_ has joined #openstack-ironic | 07:59 | |
| *** pradipta` has joined #openstack-ironic | 08:01 | |
| *** killer_p- has joined #openstack-ironic | 08:03 | |
| *** lazy_prince has quit IRC | 08:03 | |
| *** pradipta has quit IRC | 08:03 | |
| *** pquerna has quit IRC | 08:03 | |
| *** lnxnut has joined #openstack-ironic | 08:06 | |
| *** lnxnut has quit IRC | 08:11 | |
| *** Kanagaraj has quit IRC | 08:19 | |
| *** jcooley_ has joined #openstack-ironic | 08:21 | |
| *** yuriyz has joined #openstack-ironic | 08:24 | |
| *** jcooley_ has quit IRC | 08:28 | |
| *** lsmola has joined #openstack-ironic | 08:31 | |
| *** viktors has joined #openstack-ironic | 08:31 | |
| GheRivero | morning all | 08:36 |
| Haomeng | GheRivero: morning:) | 08:36 |
| *** vkozhukalov has joined #openstack-ironic | 08:37 | |
| *** dshulyak has joined #openstack-ironic | 08:37 | |
| *** mdurnosvistov_lt has joined #openstack-ironic | 08:41 | |
| *** ifarkas has joined #openstack-ironic | 08:44 | |
| shortstop | Haomeng, ping | 08:47 |
| Haomeng | shortstop: pong | 08:47 |
| shortstop | Haomeng, i was looking into your comment on 73054/4 in deploy_utils.py about creating separate temp dirs | 08:48 |
| Haomeng | shortstop: yes, I just suggest to create temp by api:) | 08:49 |
| Haomeng | shortstop: no worries:) | 08:49 |
| shortstop | Thanks for it :) but i was digging into a little more and needed to clarify | 08:49 |
| Haomeng | shortstop: np, thank you:) | 08:49 |
| *** mdurnosvistov_lt has quit IRC | 08:49 | |
| shortstop | Haomeng, Do we have to create them? as in we're patching all the functions | 08:50 |
| shortstop | So my doubt is I'm not sure if those directories are created at all | 08:50 |
| shortstop | for them to conflict when run parallely | 08:50 |
| shortstop | Is this the case or am i missing something? :) | 08:50 |
| Haomeng | shortstop: yes, that is just a case in parallely | 08:51 |
| Haomeng | shortstop: but that is not launched by our test code | 08:51 |
| Haomeng | shortstop: should be launched by testr or Jenkins | 08:51 |
| Haomeng | shortstop: so it is bettet we can make sure it works in parallely:) | 08:51 |
| Haomeng | shortstop: so no worries, this is just suggesttion, you can go ahead without any change for this comments:) | 08:52 |
| Haomeng | shortstop: I think , current, no such parallely issue, but maybe it will be invovled in the future:) | 08:52 |
| shortstop | Haomeng, I agree, when i started debugging across the tests, it seemed like there were no directories created nor are we even accessing them in the first place because the functions are all patched. | 08:53 |
| *** jistr has joined #openstack-ironic | 08:53 | |
| shortstop | So since we're not accessing the FS, i'm assuming no conflicts. No? | 08:53 |
| shortstop | Haomeng, Or are the tests actually accessing the filesystem to create the hardcoded temp file path and I failed to notice it? | 08:55 |
| *** mdurnosvistov_lt has joined #openstack-ironic | 08:56 | |
| zigo_ | GheRivero: Heya! | 08:58 |
| shortstop | Haomeng, but thanks anyway :) I'll investigate a little more on this. | 09:00 |
| *** mdurnosvistov_lt has quit IRC | 09:03 | |
| *** lnxnut has joined #openstack-ironic | 09:05 | |
| Haomeng | shortstop: ok, welcome, thank you:) | 09:07 |
| *** athomas has joined #openstack-ironic | 09:10 | |
| *** lnxnut has quit IRC | 09:10 | |
| *** derekh has joined #openstack-ironic | 09:17 | |
| *** lucasagomes has joined #openstack-ironic | 09:19 | |
| *** martyntaylor has joined #openstack-ironic | 09:27 | |
| *** martyntaylor has quit IRC | 09:32 | |
| *** saju_m has quit IRC | 09:46 | |
| *** martyntaylor has joined #openstack-ironic | 09:47 | |
| *** saju_m has joined #openstack-ironic | 09:50 | |
| *** tatyana has joined #openstack-ironic | 09:51 | |
| *** KanagarajM_ has joined #openstack-ironic | 09:55 | |
| *** mdurnosvistov has joined #openstack-ironic | 10:03 | |
| *** lnxnut has joined #openstack-ironic | 10:05 | |
| *** lnxnut has quit IRC | 10:10 | |
| *** athomas has quit IRC | 10:26 | |
| *** matsuhashi has quit IRC | 10:27 | |
| lifeless | zigo_: I'd be happy if you want to maintain subunit; I don't like maintaining my own things anyhow - hard to keep perspective | 10:28 |
| *** Haomeng has quit IRC | 10:31 | |
| *** athomas has joined #openstack-ironic | 10:33 | |
| *** aignatov is now known as aignatov_ | 10:40 | |
| *** rongze has quit IRC | 10:48 | |
| openstackgerrit | lokesh s proposed a change to openstack/ironic: Ironic deployment docs https://review.openstack.org/74282 | 10:57 |
| *** matsuhashi has joined #openstack-ironic | 10:59 | |
| *** ndipanov has quit IRC | 11:04 | |
| *** vkozhukalov has quit IRC | 11:12 | |
| *** saju_m has quit IRC | 11:12 | |
| *** vkozhukalov_ has joined #openstack-ironic | 11:12 | |
| *** jcooley_ has joined #openstack-ironic | 11:12 | |
| *** matsuhashi has quit IRC | 11:13 | |
| *** Manishanker_ has joined #openstack-ironic | 11:13 | |
| *** SpamapS_ has joined #openstack-ironic | 11:14 | |
| zigo_ | lifeless: Thanks. | 11:14 |
| *** zigo_ is now known as zigo | 11:14 | |
| *** matsuhashi has joined #openstack-ironic | 11:14 | |
| *** jcooley_ has quit IRC | 11:14 | |
| *** coolsvap has quit IRC | 11:15 | |
| *** athomas has quit IRC | 11:16 | |
| *** SpamapS has quit IRC | 11:17 | |
| *** dhellmann has quit IRC | 11:17 | |
| *** max_lobur has quit IRC | 11:19 | |
| *** coolsvap has joined #openstack-ironic | 11:20 | |
| *** athomas has joined #openstack-ironic | 11:20 | |
| *** dhellmann has joined #openstack-ironic | 11:20 | |
| *** aignatov_ is now known as aignatov | 11:20 | |
| *** max_lobur has joined #openstack-ironic | 11:20 | |
| *** Haomeng has joined #openstack-ironic | 11:22 | |
| *** saju_m has joined #openstack-ironic | 11:27 | |
| openstackgerrit | ramesh proposed a change to openstack/ironic: Add IloDriver for HP Proliant Servers https://review.openstack.org/73787 | 11:32 |
| *** KanagarajM__ has joined #openstack-ironic | 11:36 | |
| *** KanagarajM_ has quit IRC | 11:36 | |
| *** nosnos has quit IRC | 11:41 | |
| *** coolsvap has quit IRC | 11:45 | |
| *** loki_ has quit IRC | 11:56 | |
| *** jcooley_ has joined #openstack-ironic | 11:59 | |
| *** ndipanov has joined #openstack-ironic | 12:00 | |
| *** saju_m has quit IRC | 12:02 | |
| *** jcooley_ has quit IRC | 12:04 | |
| *** matsuhashi has quit IRC | 12:14 | |
| Manishanker_ | Hi i am trying to use Baremetal driver from the following guide https://wiki.openstack.org/wiki/Ironic/Devstack . I ended up with this error when i am trying to use ./stack.sh "ir-api failed to start" | 12:30 |
| Haomeng | Manishanker_: welcome:) | 12:31 |
| Haomeng | Manishanker_: you run devstack to install ironic right? | 12:31 |
| Manishanker_ | yeah | 12:31 |
| Haomeng | for your case, ironic-api process is not started as well | 12:31 |
| *** KanagarajM__ has quit IRC | 12:31 | |
| Haomeng | so please run by manually - 'ironic-api' to check the output | 12:32 |
| Manishanker_ | Thanks i will do that :) | 12:32 |
| Haomeng | welcome:) | 12:32 |
| Manishanker_ | 1821 Critical ironic [-] 'module' object has no attribute 'StringType ' | 12:34 |
| Manishanker_ | This is the output i get when i run ironic-api | 12:35 |
| Haomeng | this should be some lib issue | 12:38 |
| agordeev | Manishanker_: i'm sure it's WSME. What version do you have installed? | 12:38 |
| agordeev | Manishanker_: $ pip freeze | grep WSME | 12:39 |
| Manishanker_ | 1 sec | 12:39 |
| Haomeng | we require WSME>=0.6 | 12:40 |
| Haomeng | if it is low level, please upgrade or reinstall:) | 12:40 |
| Manishanker_ | Mine 0.5bs | 12:40 |
| Haomeng | wsme? | 12:40 |
| Manishanker_ | yeah | 12:40 |
| Manishanker_ | Can you please tell me whats wsme ? | 12:41 |
| Haomeng | https://pypi.python.org/pypi/WSME | 12:41 |
| Haomeng | Web Service Made Easy (WSME) simplify the writing of REST web services by providing simple yet powerful typing which removes the need to directly manipulate the request and the response objects. | 12:41 |
| lucasagomes | Manishanker_, you gotta update the wsme version, pip install -U wsme | 12:41 |
| Manishanker_ | Thanks guys i have upgraded it | 12:43 |
| Haomeng | Manishanker_: welcome:) | 12:43 |
| Manishanker_ | Right now i am running ./stack.sh again | 12:43 |
| Haomeng | Manishanker_: :) | 12:43 |
| Haomeng | it is better we enable the log | 12:44 |
| Haomeng | add "SCREEN_LOGDIR=/opt/stack/logs" into your localrc | 12:44 |
| Manishanker_ | Its struck again at the same point | 12:45 |
| Manishanker_ | Now i will add the LOGDIR and will paste the log | 12:45 |
| Haomeng | Manishanker_: :) | 12:45 |
| Haomeng | can you run 'ironic-api' again | 12:45 |
| Haomeng | to see if same error message | 12:45 |
| Manishanker_ | i ran the command | 12:46 |
| Haomeng | ensure wsme>=0.6 this time | 12:46 |
| Manishanker_ | wsme is still 0.5b5 :( | 12:46 |
| Haomeng | :) | 12:46 |
| Haomeng | you can remove and reinstall | 12:47 |
| Manishanker_ | i will do that | 12:47 |
| Haomeng | :) | 12:47 |
| Manishanker_ | Also when i try to run the command pip freeze | grep WSME i am getting a Warning Cannot find svn loaction for distribute ==0.6.24dev-r0 | 12:52 |
| Manishanker_ | Can you please tell me the command to remove wsme , i am using Ubuntu 12.04 LTS | 12:53 |
| *** mdurnosvistov has quit IRC | 12:55 | |
| *** saju_m has joined #openstack-ironic | 12:55 | |
| *** mdurnosvistov has joined #openstack-ironic | 12:57 | |
| *** jcooley_ has joined #openstack-ironic | 12:57 | |
| Haomeng | try "pip install https://pypi.python.org/packages/source/W/WSME/WSME-0.6.tar.gz" | 12:59 |
| Haomeng | tha is strange, our requirement define wsme>=0.6, why the 0.6 ver is not installed as well? | 13:00 |
| Manishanker_ | i will do that | 13:01 |
| Haomeng | good luck:) | 13:01 |
| Haomeng | should work:) | 13:02 |
| *** lucasagomes is now known as lucas-hungry | 13:02 | |
| Manishanker_ | WSME =0.6 now :) | 13:05 |
| agordeev | Manishanker_: also you can add version tag, e.g.: pip install -U 'WSME==0.6' | 13:05 |
| *** jcooley_ has quit IRC | 13:05 | |
| Haomeng | total counters = 15 | 13:08 |
| Manishanker_ | same error ironic.common.utils [-] Reloading cached file /etc/ironic/policy.json read_cached_file /opt/stack/ironic/common/utils.py:312 | 13:19 |
| *** aignatov is now known as aignatov_ | 13:19 | |
| Manishanker_ | ironic 'module' object has no attribute 'StringType' ir-api failed to start | 13:20 |
| *** aignatov_ is now known as aignatov | 13:21 | |
| *** jdob has joined #openstack-ironic | 13:22 | |
| Haomeng | what is current wsme version, "pip freeze | grep WSME" | 13:23 |
| Manishanker_ | i uninstalled ,installed the wsme from the tar you gave | 13:24 |
| Manishanker_ | Still its showing 0.5b5 | 13:25 |
| Manishanker_ | also with the warning cannot find svn location for distribute ==0.6.24dev-r0 | 13:25 |
| agordeev | good news everyone! finally got ironic working with neutron stuff | 13:26 |
| *** zul has joined #openstack-ironic | 13:27 | |
| agordeev | max_lobur: truly appeciate your help :) | 13:27 |
| max_lobur | w00ts! | 13:29 |
| *** sbadia_ has joined #openstack-ironic | 13:40 | |
| *** sbadia has quit IRC | 13:40 | |
| *** mrda_away has quit IRC | 13:40 | |
| *** pquerna has joined #openstack-ironic | 13:40 | |
| *** pquerna has quit IRC | 13:42 | |
| *** pquerna has joined #openstack-ironic | 13:42 | |
| *** sbadia_ is now known as sbadia | 13:42 | |
| *** sbadia has quit IRC | 13:43 | |
| *** saju_m has quit IRC | 13:43 | |
| *** shortstop has quit IRC | 13:43 | |
| *** sirushti has joined #openstack-ironic | 13:43 | |
| *** saju_m has joined #openstack-ironic | 13:44 | |
| *** aignatov is now known as aignatov_ | 13:44 | |
| sirushti | Manishanker_, there's a possibility your requirements are out of date. Do you have RECLONE=True in your localrc? If not, append it and try running stack.sh again :) This will update all the repositories! | 13:45 |
| *** mrda_away has joined #openstack-ironic | 13:51 | |
| *** dhellmann_ has joined #openstack-ironic | 13:51 | |
| *** sirushti is now known as shortstop | 13:51 | |
| *** aignatov_ is now known as aignatov | 13:51 | |
| *** Guest50062 has joined #openstack-ironic | 13:51 | |
| *** pquerna_ has quit IRC | 13:51 | |
| *** dhellmann has quit IRC | 13:51 | |
| *** dhellmann_ is now known as dhellmann | 13:51 | |
| Manishanker_ | Hi sirushti ,i have updated my WSMe verion from 0.5b5 to 0.6 using the command pip install -U 'WSME==0.6' ,i have checked the veriosn of the WSME and ir-api failed to start .So i started it manually now i had run finally. | 13:52 |
| Manishanker_ | Now i can see its screen and its working fine . | 13:52 |
| *** jcooley_ has joined #openstack-ironic | 13:56 | |
| *** Manishanker_ is now known as manishanker | 13:59 | |
| *** jcooley_ has quit IRC | 14:02 | |
| *** lucas-hungry is now known as lucasagomes | 14:04 | |
| lucasagomes | agordeev, w00t! | 14:04 |
| *** saju_m has quit IRC | 14:05 | |
| lucasagomes | agordeev, it was something in the ironic code? or in the way the enviroment was setup? | 14:05 |
| max_lobur | 2nd :) tricky network config to make neutron think that it's a OS vm requesting an ip | 14:08 |
| agordeev | lucasagomes: nothing wrong with ironic, just my dev environment issues | 14:09 |
| lucasagomes | cool! | 14:09 |
| lucasagomes | godd stuff | 14:09 |
| *** lnxnut has joined #openstack-ironic | 14:13 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Filtering nodes by maintenance mode https://review.openstack.org/75121 | 14:18 |
| *** matty_dubs|gone is now known as matty_dubs | 14:19 | |
| matty_dubs | Morning fellers | 14:25 |
| *** aignatov has quit IRC | 14:28 | |
| *** aignatov has joined #openstack-ironic | 14:29 | |
| *** rloo has joined #openstack-ironic | 14:34 | |
| *** blamar has joined #openstack-ironic | 14:38 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Do not use CONF as a default parameter value https://review.openstack.org/75883 | 14:38 |
| NobodyCam | Good morning says the making coffee... Nice to be back home! | 14:44 |
| rloo | morning NobodyCam! | 14:46 |
| NobodyCam | good morning rloo | 14:47 |
| *** jcooley_ has joined #openstack-ironic | 14:53 | |
| lucasagomes | NobodyCam, rloo morning | 14:56 |
| max_lobur | morning rloo, NobodyCam | 14:56 |
| rloo | hi lucasagomes ;) | 14:56 |
| NobodyCam | morning lucasagomes :) | 14:56 |
| lucasagomes | NobodyCam, check the scrollback :) agordeev and max_lobur got the neutron stuff workin! | 14:56 |
| NobodyCam | i saw.. :) | 14:56 |
| NobodyCam | lucasagomes: you see deva and i pushed up some patches to the Nova driver | 14:57 |
| lucasagomes | NobodyCam, oh will take a look | 14:57 |
| * NobodyCam hopes he got the rebasing corred | 14:58 | |
| NobodyCam | correct even | 14:58 |
| *** jcooley_ has quit IRC | 14:58 | |
| NobodyCam | everyone have a good weekend? | 14:59 |
| max_lobur | yup :) | 15:00 |
| NobodyCam | hey hey morning max_lobur | 15:00 |
| NobodyCam | how are things over there. US news channels say its been an active couple of days where you are | 15:01 |
| max_lobur | well, not so good as we wanted | 15:02 |
| max_lobur | they kicked out the old president | 15:02 |
| NobodyCam | ya :) | 15:02 |
| max_lobur | and most of his clerks run away too | 15:03 |
| max_lobur | but the new ones are not much better | 15:03 |
| NobodyCam | :( seems to be the way it is. | 15:03 |
| max_lobur | so many people just disappointed | 15:04 |
| max_lobur | yep, as always | 15:04 |
| NobodyCam | there was a song welcome to the new.... same as the old... | 15:04 |
| max_lobur | :) true | 15:04 |
| NobodyCam | :-p | 15:04 |
| NobodyCam | hope you and everyone over there are safe | 15:04 |
| max_lobur | yes, currently there are no conflicts | 15:05 |
| max_lobur | thanks :) | 15:05 |
| NobodyCam | :) | 15:05 |
| lucasagomes | max_lobur, :/ | 15:07 |
| *** linggao has joined #openstack-ironic | 15:07 | |
| *** rwsu has joined #openstack-ironic | 15:14 | |
| max_lobur | folks, I may late to review meeting today, hope to join ~ in a half hour after start | 15:16 |
| *** romcheg has joined #openstack-ironic | 15:17 | |
| NobodyCam | max_lobur: is romcheg back? | 15:17 |
| romcheg | Morning NobodyCam | 15:17 |
| max_lobur | yup | 15:17 |
| romcheg | I'm back | 15:17 |
| romcheg | Forgot to join the chat | 15:18 |
| NobodyCam | Woo hoo :) | 15:18 |
| *** jbjohnso has joined #openstack-ironic | 15:18 | |
| max_lobur | hehe :) | 15:18 |
| NobodyCam | good morning romcheg :) | 15:18 |
| romcheg | I'm really sorry for screwing up with the migrations | 15:18 |
| romcheg | Didn't manage to fix the conceptual problems | 15:18 |
| jbjohnso | NobodyCam, matty_dubs: FYI, I've replaced shellinabox's client code in my demo | 15:18 |
| jbjohnso | it's now much much faster | 15:18 |
| romcheg | I made a patch that convertd the DB and that whould work | 15:18 |
| NobodyCam | :) ww00t | 15:19 |
| jbjohnso | and you can hit '-' in firefox now | 15:19 |
| max_lobur | k, bbiaw | 15:19 |
| NobodyCam | jbjohnso: sweet.. was the - a FF issue or shellinabox? | 15:19 |
| romcheg | It's in draft now | 15:19 |
| *** manishanker has quit IRC | 15:19 | |
| NobodyCam | romcheg: is that up for review | 15:19 |
| romcheg | I'm going to re-upload it | 15:19 |
| jbjohnso | NobodyCam, shellinabox | 15:20 |
| NobodyCam | ahh | 15:20 |
| *** max_lobur has quit IRC | 15:20 | |
| jbjohnso | NobodyCam, I replaced shellinabox with some of my code and term.js | 15:20 |
| NobodyCam | :) ok very cool! | 15:21 |
| romcheg | NobodyCam: Yes, that is not all I have, but the other parts are not yet fixed | 15:21 |
| romcheg | Working on that | 15:21 |
| NobodyCam | hehee | 15:22 |
| *** killer_prince has quit IRC | 15:23 | |
| *** killer_p- is now known as killer_prince | 15:23 | |
| romcheg | NobodyCam: Uploaded the second part | 15:26 |
| romcheg | *the first | 15:27 |
| linggao | Morning NobodyCam. I have a conflict and cannot join the Ironic weekly meeting today. | 15:27 |
| openstackgerrit | ramesh proposed a change to openstack/ironic: Add IloDriver for HP Proliant Servers https://review.openstack.org/73787 | 15:27 |
| romcheg | NobodyCam: If everyone agrees with this approach I will continue to use it. | 15:27 |
| romcheg | This is actually the 4th approach I used :) | 15:28 |
| linggao | NobodyCam, status: for the console support, Sun Jing is still working on it. She will make sure it gets landed before I3 (march 6). | 15:29 |
| jbjohnso | shellinabox is a lot more cpu hungry than term.js.... it's nice.. | 15:29 |
| linggao | NobodayCam, there has been several iterations last week for patch https://review.openstack.org/#/c/64100/ | 15:30 |
| NobodyCam | linggao: Good Morning, and great I will take a look in a few. seems this was a busy weekend for my work email | 15:33 |
| NobodyCam | lol still catching up | 15:33 |
| linggao | sure. thanks. | 15:34 |
| NobodyCam | no no thank you :) | 15:37 |
| linggao | :) | 15:37 |
| *** jcooley_ has joined #openstack-ironic | 15:42 | |
| *** rameshg87 has joined #openstack-ironic | 15:47 | |
| rameshg87 | Hi | 15:49 |
| rameshg87 | i have a query regarding a review that i raised just now | 15:49 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Exclude nodes in DEPLOYWAIT state from _sync_power_states https://review.openstack.org/75904 | 15:50 |
| NobodyCam | rameshg87: Good morning (for me), sure,, | 15:54 |
| NobodyCam | what is your question | 15:54 |
| rameshg87 | Good morning NobodyCam | 15:55 |
| rameshg87 | i just raised a review for our code | 15:55 |
| rameshg87 | pep8 just failed with the error while running ./tools/config/check_uptodate.sh | 15:56 |
| NobodyCam | ahh the conf file | 15:56 |
| rameshg87 | here is the log: https://jenkins05.openstack.org/job/gate-ironic-pep8/14/console | 15:56 |
| rameshg87 | but on my system, it doesn't fail | 15:56 |
| rameshg87 | so i am just wondering what could be the reason | 15:56 |
| rameshg87 | when i run ./tools/config/check_uptodate.sh on my system, it exits normally with 0 exit code | 15:57 |
| NobodyCam | your patch added or changes a default conf value | 15:57 |
| rameshg87 | yes, it did | 15:57 |
| NobodyCam | rameshg87: :) | 15:57 |
| rameshg87 | hence i ran ./tools/config/generate_sample.sh | 15:57 |
| NobodyCam | did you include the ironic.conf file with the review? | 15:58 |
| rameshg87 | and updated the etc/ironic/ironic.conf.sample as well | 15:58 |
| NobodyCam | what is the review # | 15:58 |
| NobodyCam | also what command did you used when running generate_sample | 15:59 |
| rameshg87 | https://review.openstack.org/#/c/73787 | 15:59 |
| NobodyCam | Oh HI rameshg87 :) :-p doh | 16:00 |
| NobodyCam | I was just looking at 73790 :-p | 16:00 |
| rameshg87 | i ran ./tools/config/generate_sample.sh | 16:00 |
| rameshg87 | oh for that review, we just figured out we wouldn't need the scp module | 16:01 |
| rameshg87 | we could we the paramiko.SFTPClient as well instead of scp | 16:02 |
| rameshg87 | hence we just made that change in the newly posted patch | 16:02 |
| NobodyCam | rameshg87: great :) | 16:02 |
| rameshg87 | so we might not require 73790. i will just abandon the other review once jenkins goes through for this. | 16:02 |
| rameshg87 | seeing the changes to ironic.conf.sample in the review - https://review.openstack.org/#/c/73787/4/etc/ironic/ironic.conf.sample | 16:03 |
| NobodyCam | so for the command try: (from the ironic directory): ./tools/config/generate_sample.sh -b . -p ironic -o ./etc/ironic | 16:03 |
| rameshg87 | NobodyCam: just one question | 16:04 |
| NobodyCam | sure | 16:04 |
| rameshg87 | i guess we are not supposed to modify the file ironic.conf.sample by ourselves, right ? | 16:04 |
| NobodyCam | correct | 16:04 |
| rameshg87 | the script generate_sample.sh should generate in any case. am i correct ? | 16:04 |
| NobodyCam | yes | 16:05 |
| rameshg87 | okay | 16:05 |
| rameshg87 | let me just try this now | 16:05 |
| rameshg87 | NobodyCam: i just tried the command on top of my current changes | 16:06 |
| rameshg87 | it didn't produce any change in ironic.conf.sample file | 16:06 |
| rameshg87 | when i run git status after the command, it still says "working directory clean" | 16:06 |
| NobodyCam | ahh | 16:08 |
| NobodyCam | so | 16:08 |
| NobodyCam | looks like you need to rebase you patch on the latest in the repo.. another change has landed that is not in your patch | 16:09 |
| NobodyCam | have you done this before? | 16:09 |
| rameshg87 | yes, i did rebase the change some 3-4 hours back | 16:10 |
| rameshg87 | let me just check again.. | 16:10 |
| *** aignatov is now known as aignatov_ | 16:14 | |
| NobodyCam | let me see if I can link for you | 16:14 |
| NobodyCam | http://anteaya.info/blog/2013/03/25/please-rebase-your-change-and-upload-a-new-patchset/ | 16:14 |
| NobodyCam | anteaya: ^^ just used you as reff!!! ^^^ | 16:14 |
| anteaya | I see that | 16:14 |
| anteaya | hope it helps | 16:14 |
| NobodyCam | :) | 16:16 |
| NobodyCam | I have a bouncing bubbie so I need to do a quick brb... | 16:16 |
| *** davidlenwell_ is now known as davidlenwell | 16:18 | |
| rameshg87 | anteaya: NobodyCam: i had done the similar thing | 16:21 |
| rameshg87 | i just confirmed that my change is on top of the latest in the github | 16:21 |
| *** lsmola has quit IRC | 16:21 | |
| *** aignatov_ is now known as aignatov | 16:21 | |
| davidlenwell | devananda: will be wrapping up the db migration today .. as well as testing the ipmi console thing (my hardware arrived) but probably not until this afternoon.. just wanted to let you know it wasn't slipping under the rug | 16:22 |
| davidlenwell | morning NobodyCam | 16:22 |
| NobodyCam | morning davidlenwell :) | 16:23 |
| rameshg87 | one question - are we supposed to run ./tools/config/generate_sample.sh only within virtual environment ? | 16:26 |
| NobodyCam | yes ... source the venv first | 16:26 |
| NobodyCam | at least I do | 16:27 |
| rameshg87 | oh okay, i might have done that mistake | 16:27 |
| rameshg87 | i didn't expect generate_sample.sh should be run within that .. | 16:27 |
| *** hemna_ has quit IRC | 16:27 | |
| rameshg87 | let me just check if that makes any difference | 16:27 |
| NobodyCam | rameshg87: may be you need to run "git remote update"? | 16:29 |
| NobodyCam | speaking of git... /me git's some more coffee | 16:30 |
| *** athomas has quit IRC | 16:31 | |
| romcheg | NobodyCam: Do we have a review hour tonight/today? | 16:32 |
| devananda | morning, all | 16:33 |
| NobodyCam | romcheg: matty_dubs and devananda are running a bit late | 16:33 |
| NobodyCam | Good morning devananda :) | 16:33 |
| romcheg | Morning devananda | 16:33 |
| NobodyCam | devananda: Read the scroll back!!! | 16:33 |
| devananda | NobodyCam: how far back? | 16:34 |
| NobodyCam | 05:26 | agordeev > good news everyone! finally got ironic working with neutron stuff | 16:34 |
| matty_dubs | NobodyCam: Oh, is review hour for all? I thought it was just for cores. | 16:34 |
| *** aignatov is now known as aignatov_ | 16:35 | |
| *** viktors has quit IRC | 16:36 | |
| NobodyCam | matty_dubs: doh.. that should have been max_lobur | 16:37 |
| NobodyCam | sorry ... tab fail | 16:37 |
| *** jcooley_ has quit IRC | 16:38 | |
| matty_dubs | NobodyCam: Oh, ha! I have a perpetual fear that I'm late for something, so I was worried. ;) | 16:38 |
| NobodyCam | lol | 16:38 |
| NobodyCam | nope your all Good :) | 16:38 |
| * NobodyCam has same fear | 16:39 | |
| devananda | davidlenwell: thanks for the heads up | 16:39 |
| *** hemna_ has joined #openstack-ironic | 16:39 | |
| devananda | agordeev: is there a new devstack patch up with your changes? what ended up being wrong? | 16:40 |
| NobodyCam | agordeev: looks like pep8 failed on extras.d/50-ironic.sh with Trailing Whitespace :-p | 16:43 |
| *** bearhand1 is now known as comstud | 16:45 | |
| *** max_lobur has joined #openstack-ironic | 16:45 | |
| max_lobur | back | 16:45 |
| *** digambar has joined #openstack-ironic | 16:56 | |
| * NobodyCam need to step away for a couple of minutes | 16:57 | |
| *** zul has quit IRC | 17:00 | |
| *** jbjohnso has quit IRC | 17:01 | |
| *** jbjohnso has joined #openstack-ironic | 17:01 | |
| *** mdurnosvistov has quit IRC | 17:04 | |
| *** tatyana has quit IRC | 17:04 | |
| *** martyntaylor has quit IRC | 17:04 | |
| *** yuriyz has quit IRC | 17:04 | |
| *** davidlenwell has quit IRC | 17:04 | |
| *** max_lobur has quit IRC | 17:04 | |
| *** blamar has quit IRC | 17:04 | |
| *** rloo has quit IRC | 17:04 | |
| *** aignatov_ has quit IRC | 17:04 | |
| *** lnxnut has quit IRC | 17:04 | |
| *** dhellmann has quit IRC | 17:04 | |
| *** shortstop has quit IRC | 17:04 | |
| *** Guest50062 has quit IRC | 17:04 | |
| *** SpamapS_ has quit IRC | 17:04 | |
| *** jistr has quit IRC | 17:04 | |
| *** dshulyak has quit IRC | 17:04 | |
| *** hemna_ has quit IRC | 17:04 | |
| *** jdob has quit IRC | 17:04 | |
| *** killer_prince has quit IRC | 17:04 | |
| *** datajerk has quit IRC | 17:04 | |
| *** agordeev has quit IRC | 17:04 | |
| *** pradipta` has quit IRC | 17:04 | |
| *** early has quit IRC | 17:04 | |
| *** matty_dubs has quit IRC | 17:04 | |
| *** Xurong has quit IRC | 17:04 | |
| *** lifeless has quit IRC | 17:04 | |
| *** lynxman has quit IRC | 17:04 | |
| *** jrist_ has quit IRC | 17:04 | |
| *** BLZbubba_ has quit IRC | 17:04 | |
| *** dkehn_ has quit IRC | 17:04 | |
| *** GheRivero has quit IRC | 17:04 | |
| *** mordred has quit IRC | 17:04 | |
| *** Haomeng has quit IRC | 17:04 | |
| *** mrda_away has quit IRC | 17:04 | |
| *** lucasagomes has quit IRC | 17:04 | |
| *** derekh has quit IRC | 17:04 | |
| *** JayF has quit IRC | 17:04 | |
| *** EmilienM has quit IRC | 17:04 | |
| *** JoshNang has quit IRC | 17:04 | |
| *** rsacharya_ has quit IRC | 17:04 | |
| *** Shrews has quit IRC | 17:04 | |
| *** zigo has quit IRC | 17:04 | |
| *** jroll has quit IRC | 17:04 | |
| *** wendar has quit IRC | 17:04 | |
| *** russellb has quit IRC | 17:04 | |
| *** mikal has quit IRC | 17:04 | |
| *** digambar has quit IRC | 17:04 | |
| *** rameshg87 has quit IRC | 17:04 | |
| *** anteaya has quit IRC | 17:04 | |
| *** ekarlso has quit IRC | 17:04 | |
| *** pleia2 has quit IRC | 17:04 | |
| *** comstud has quit IRC | 17:04 | |
| *** NobodyCam has quit IRC | 17:04 | |
| *** devananda has quit IRC | 17:04 | |
| *** vkozhukalov_ has quit IRC | 17:04 | |
| *** openstackgerrit has quit IRC | 17:04 | |
| *** Hefeweizen has quit IRC | 17:04 | |
| *** russell_h has quit IRC | 17:04 | |
| *** 1JTAAFJP3 has quit IRC | 17:04 | |
| *** bigjools has quit IRC | 17:04 | |
| *** digambar has joined #openstack-ironic | 17:06 | |
| *** max_lobur has joined #openstack-ironic | 17:06 | |
| *** hemna_ has joined #openstack-ironic | 17:06 | |
| *** rameshg87 has joined #openstack-ironic | 17:06 | |
| *** blamar has joined #openstack-ironic | 17:06 | |
| *** rloo has joined #openstack-ironic | 17:06 | |
| *** aignatov has joined #openstack-ironic | 17:06 | |
| *** lnxnut has joined #openstack-ironic | 17:06 | |
| *** Guest50062 has joined #openstack-ironic | 17:06 | |
| *** dhellmann has joined #openstack-ironic | 17:06 | |
| *** mrda_away has joined #openstack-ironic | 17:06 | |
| *** shortstop has joined #openstack-ironic | 17:06 | |
| *** jdob has joined #openstack-ironic | 17:06 | |
| *** Haomeng has joined #openstack-ironic | 17:06 | |
| *** SpamapS_ has joined #openstack-ironic | 17:06 | |
| *** lucasagomes has joined #openstack-ironic | 17:06 | |
| *** derekh has joined #openstack-ironic | 17:06 | |
| *** jistr has joined #openstack-ironic | 17:06 | |
| *** dshulyak has joined #openstack-ironic | 17:06 | |
| *** killer_prince has joined #openstack-ironic | 17:06 | |
| *** pradipta` has joined #openstack-ironic | 17:06 | |
| *** datajerk has joined #openstack-ironic | 17:06 | |
| *** JayF has joined #openstack-ironic | 17:06 | |
| *** EmilienM has joined #openstack-ironic | 17:06 | |
| *** JoshNang has joined #openstack-ironic | 17:06 | |
| *** rsacharya_ has joined #openstack-ironic | 17:06 | |
| *** agordeev has joined #openstack-ironic | 17:06 | |
| *** anteaya has joined #openstack-ironic | 17:06 | |
| *** ekarlso has joined #openstack-ironic | 17:06 | |
| *** early has joined #openstack-ironic | 17:06 | |
| *** matty_dubs has joined #openstack-ironic | 17:06 | |
| *** Xurong has joined #openstack-ironic | 17:06 | |
| *** lifeless has joined #openstack-ironic | 17:06 | |
| *** lynxman has joined #openstack-ironic | 17:06 | |
| *** jrist_ has joined #openstack-ironic | 17:06 | |
| *** BLZbubba_ has joined #openstack-ironic | 17:06 | |
| *** dkehn_ has joined #openstack-ironic | 17:06 | |
| *** GheRivero has joined #openstack-ironic | 17:06 | |
| *** mordred has joined #openstack-ironic | 17:06 | |
| *** pleia2 has joined #openstack-ironic | 17:06 | |
| *** Shrews has joined #openstack-ironic | 17:06 | |
| *** zigo has joined #openstack-ironic | 17:06 | |
| *** jroll has joined #openstack-ironic | 17:06 | |
| *** wendar has joined #openstack-ironic | 17:06 | |
| *** russellb has joined #openstack-ironic | 17:06 | |
| *** comstud has joined #openstack-ironic | 17:06 | |
| *** mikal has joined #openstack-ironic | 17:06 | |
| *** NobodyCam has joined #openstack-ironic | 17:06 | |
| *** devananda has joined #openstack-ironic | 17:06 | |
| *** vkozhukalov_ has joined #openstack-ironic | 17:06 | |
| *** openstackgerrit has joined #openstack-ironic | 17:06 | |
| *** Hefeweizen has joined #openstack-ironic | 17:06 | |
| *** russell_h has joined #openstack-ironic | 17:06 | |
| *** 1JTAAFJP3 has joined #openstack-ironic | 17:06 | |
| *** bigjools has joined #openstack-ironic | 17:06 | |
| *** jistr has quit IRC | 17:06 | |
| *** JoshNang has quit IRC | 17:08 | |
| * devananda rebuilds devstack env | 17:09 | |
| *** zul has joined #openstack-ironic | 17:09 | |
| romcheg | Nice idea | 17:10 |
| *** JoshNang_ has joined #openstack-ironic | 17:11 | |
| *** davidlenwell has joined #openstack-ironic | 17:11 | |
| *** JoshNang_ is now known as JoshNang | 17:15 | |
| *** openstackgerrit has quit IRC | 17:20 | |
| *** martyntaylor has joined #openstack-ironic | 17:20 | |
| *** openstackgerrit has joined #openstack-ironic | 17:20 | |
| *** digambar has quit IRC | 17:22 | |
| *** matty_dubs is now known as matty_dubs|lunch | 17:24 | |
| devananda | agordeev: [ERROR] /home/deva/devstack/lib/ironic:327 Wrong driver power result | 17:33 |
| *** vkozhukalov_ has quit IRC | 17:37 | |
| max_lobur | hi devananda | 17:39 |
| max_lobur | I guess he's already out | 17:39 |
| openstackgerrit | ramesh proposed a change to openstack/ironic: Add IloDriver for HP Proliant Servers https://review.openstack.org/73787 | 17:39 |
| max_lobur | are you testing his new rev for tempest? | 17:39 |
| devananda | max_lobur: hi! yes | 17:39 |
| devananda | well, devstack | 17:39 |
| max_lobur | yes | 17:39 |
| max_lobur | k | 17:40 |
| max_lobur | I'll try to give it a go today as well | 17:40 |
| *** martyntaylor has left #openstack-ironic | 17:40 | |
| NobodyCam | rameshg87: you got generate_sample to work? | 17:41 |
| devananda | for local testing, i need a net bridge outside of the VM. for in-cloud testing (the way jenkins will do it) we need the net bridge *inside* the VM. | 17:41 |
| devananda | this is what i think i'll be fighting with | 17:41 |
| rameshg87 | NobodyCam: i think i got | 17:42 |
| devananda | max_lobur: also, https://review.openstack.org/#/c/75121/ could use another review | 17:42 |
| devananda | a few other client patches too, if you're around and doing reviews :) | 17:42 |
| NobodyCam | :) | 17:42 |
| max_lobur | yup | 17:42 |
| rameshg87 | i am just a little confused. i still haven't figured out what could be the reason | 17:42 |
| max_lobur | right now reviewing all the stuff around | 17:42 |
| max_lobur | I'll update our review doc with easy patches and the ones that I tested | 17:43 |
| max_lobur | so we'll quickly go over them | 17:43 |
| rameshg87 | i will keep fingers crossed until the jenkins pep8 goes through :-) | 17:44 |
| *** mdurnosvistov has joined #openstack-ironic | 17:44 | |
| *** tatyana has joined #openstack-ironic | 17:44 | |
| max_lobur | brb | 17:44 |
| devananda | lucasagomes: on rhel, do you "yum install mysql-server" then "service mysqld start"? that seems really awkward | 17:47 |
| lucasagomes | devananda, yes | 17:47 |
| devananda | lucasagomes: heh, k | 17:47 |
| lucasagomes | devananda, well ubuntu uses service mysql start | 17:47 |
| lucasagomes | it doesn't use mysql-server start as I know | 17:47 |
| lucasagomes | as far as I know* | 17:47 |
| devananda | ahh you're right | 17:48 |
| *** rameshg87 has quit IRC | 17:48 | |
| devananda | i'm still waking up >_< | 17:49 |
| lucasagomes | :D no worries | 17:49 |
| *** linggao has quit IRC | 17:52 | |
| *** rloo has quit IRC | 17:53 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Clarify and fix the dev-quickstart doc some more https://review.openstack.org/74909 | 17:54 |
| devananda | matty_dubs|lunch: I see your comment on https://review.openstack.org/#/c/72998/9/ironic/conductor/manager.py and I'm quite curious | 17:57 |
| devananda | matty_dubs|lunch: i would suggest sticking two LOG.info lines around driver.console.start() and see if the second one is called | 17:58 |
| devananda | eg, if driver.console.start() does not return, that's a big problem | 17:59 |
| *** tatyana has quit IRC | 17:59 | |
| lucasagomes | devananda, I was debugging this problem with him, the console_start() is from the ipmi console implementation is not returning | 18:00 |
| devananda | ooh. yea, i am just now reading your comment on sjing's patch | 18:01 |
| lucasagomes | tl;dr, the utils.execute hangs when executing background tasks | 18:01 |
| lucasagomes | yeah | 18:01 |
| *** derekh is now known as derekh_afk | 18:03 | |
| *** tatyana has joined #openstack-ironic | 18:04 | |
| devananda | lucasagomes: there's more than one way to address this | 18:07 |
| devananda | lucasagomes: simply firing off a bg process without keeping track of it, gathering the exit code, etc, is not good either | 18:08 |
| lucasagomes | devananda, right, maybe we should encapsulate it in a greenthread? | 18:09 |
| lucasagomes | that would manage the running process (using poll()) | 18:09 |
| lucasagomes | and setting last_error in case it fails? | 18:09 |
| *** harlowja has joined #openstack-ironic | 18:10 | |
| lucasagomes | I think ur correct, just firing Popen can be dangerous | 18:10 |
| devananda | lucasagomes: and what if conductor process is restarted? | 18:10 |
| lucasagomes | devananda, ah urgh... yeah then we lost track of it | 18:11 |
| romcheg | brb | 18:11 |
| devananda | lucasagomes: right | 18:11 |
| devananda | and it keeps running | 18:11 |
| *** rameshg87 has joined #openstack-ironic | 18:12 | |
| lucasagomes | yeah | 18:12 |
| lucasagomes | well, right now we are saving the pid of the process in a file | 18:13 |
| lucasagomes | <node_uuid>.pid | 18:13 |
| lucasagomes | and we the way we stop the terminal is killing that pid | 18:13 |
| devananda | ah, right | 18:14 |
| devananda | so that's a bit racy :) | 18:14 |
| lucasagomes | it could be trick in a case of take over for e.g | 18:14 |
| lucasagomes | yeah | 18:14 |
| lucasagomes | as part of the takeover we might want to call stop_console | 18:14 |
| devananda | why" | 18:15 |
| devananda | ? | 18:15 |
| devananda | takeover should be a different host. the PID file won't exist | 18:15 |
| devananda | ooh - you mean via the API | 18:15 |
| devananda | that won't route to the old conductor any more anyway | 18:15 |
| lucasagomes | devananda, right, but in the db the console_enabled field will still True | 18:15 |
| lucasagomes | so calling stop_console should reset that to False | 18:16 |
| devananda | as part of rebalance, when releasing nodes, the former conductor should call stop_console | 18:16 |
| devananda | lucasagomes: the new conductor should set up the console as part of takeover if the console_enabled=True | 18:16 |
| *** romcheg has quit IRC | 18:16 | |
| lucasagomes | devananda, ahh, yeah that would be even better | 18:16 |
| devananda | if the user asked for the console session to be open, and a rebalance happens, the user shouldn't have to restart the console... :) | 18:16 |
| *** jrist_ is now known as jrist | 18:16 | |
| lucasagomes | so user can reconnect to it | 18:16 |
| lucasagomes | devananda, sounds good! +1 | 18:17 |
| devananda | so yes, pidfile makes sense | 18:17 |
| devananda | killng those pids is fine, but right now it's run_as_root=True and that's dangerous | 18:17 |
| lucasagomes | yeah, matty_dubs|lunch was concerned about that | 18:17 |
| lucasagomes | since we started the shellinabox as a normal user, we should not need to kill it as root | 18:18 |
| devananda | yep | 18:18 |
| NobodyCam | at first it was mock vs mox.. now mock vs @mock..lol :-p | 18:21 |
| lucasagomes | NobodyCam, hah | 18:22 |
| lucasagomes | NobodyCam, actually the @mock decorator is pretty good | 18:22 |
| lucasagomes | I used it in the nova ironic volume driver tests | 18:22 |
| NobodyCam | anyone have /anything/ for the agenda? | 18:24 |
| *** matty_dubs|lunch is now known as matty_dubs | 18:24 | |
| * lucasagomes lucas-afk | 18:25 | |
| * lucasagomes afk until the meeting | 18:25 | |
| max_lobur | https://review.openstack.org/#/c/73322/ | 18:31 |
| max_lobur | folks take a look at the last comment, makes sense to you? | 18:31 |
| max_lobur | just trying to find a way to make our mixed vendor ifaces not so complex :) | 18:32 |
| NobodyCam | max my over arching question. is Nova does not allow drivers to mix and match pices, as an example with the nova driver we did this: https://review.openstack.org/#/c/72007 to move | 18:36 |
| NobodyCam | one of the libvirt methods to a common location | 18:36 |
| NobodyCam | would oit be better for us to enforce such things in Ironic | 18:37 |
| *** digambar has joined #openstack-ironic | 18:37 | |
| matty_dubs | devananda: lucasagomes: So I was afk during the earlier discussion re: the console patch. The threading stuff is a bit outside my expertise, but I wonder if there's a point at which we save that for a future enhancement? | 18:39 |
| *** jdob has quit IRC | 18:41 | |
| *** romcheg has joined #openstack-ironic | 18:42 | |
| *** SpamapS_ is now known as SpamapS | 18:43 | |
| *** martyntaylor has joined #openstack-ironic | 18:43 | |
| *** SpamapS has quit IRC | 18:43 | |
| *** SpamapS has joined #openstack-ironic | 18:43 | |
| digambar | Hi NobodyCam | 18:44 |
| *** killer_prince has quit IRC | 18:44 | |
| devananda | matty_dubs: I just posted comments to 64100 | 18:45 |
| * max_lobur looking to the nova | 18:45 | |
| *** killer_prince has joined #openstack-ironic | 18:45 | |
| *** aignatov is now known as aignatov_ | 18:45 | |
| NobodyCam | Good Morning digambar :) | 18:45 |
| devananda | matty_dubs: run_as_root and threading need to be done, as one is security and the other just prevents the feature from working (cant stop a console) | 18:45 |
| digambar | Good Morning | 18:45 |
| devananda | matty_dubs: the rest i think can wait | 18:45 |
| *** k4n0 has joined #openstack-ironic | 18:45 | |
| matty_dubs | devananda: Sounds quite reasonable to me! | 18:46 |
| matty_dubs | (and just saw your comments on the patch) | 18:46 |
| max_lobur | NobodyCam: looked to the nova | 18:47 |
| max_lobur | I think if we force that | 18:48 |
| lifeless | why does the ilo driver interact with nova at all ? | 18:48 |
| max_lobur | then most of the vendor code will go to utils | 18:48 |
| NobodyCam | lifeless: there is this file(https://review.openstack.org/#/c/51328/26/nova/virt/ironic/ironic_driver_fields.py) that mapps ironic fields to the nova fields | 18:49 |
| *** digambar_ has joined #openstack-ironic | 18:49 | |
| digambar_ | Hi | 18:49 |
| *** digambar has quit IRC | 18:49 | |
| digambar_ | got disconnted | 18:49 |
| NobodyCam | :) | 18:49 |
| digambar_ | Hey | 18:50 |
| digambar_ | Can you give one more bug ? | 18:50 |
| lifeless | NobodyCam: ah, so I think thats a bug :) | 18:50 |
| max_lobur | NobodyCam: and this will lead to vendor will implicitly call other's vendor's methods (implicitly because it looks like they just using the util). But our current approach is to prevent code calls between drivers - instead we tend to have common layer above both drivers which performs appropriate routing | 18:50 |
| max_lobur | so I tend to argue for the multiplexed interface approach | 18:51 |
| max_lobur | just to make it simpler as much as possible | 18:51 |
| NobodyCam | digambar_: pick one that looks fun to you... https://bugs.launchpad.net/ironic | 18:51 |
| digambar_ | ok | 18:51 |
| NobodyCam | :) | 18:51 |
| digambar_ | :) | 18:51 |
| lifeless | NobodyCam: will put some thoughts there, I may be totally wrong :) | 18:52 |
| NobodyCam | lifeless: :) perfect... Thank you!! :) | 18:53 |
| devananda | lifeless, NobodyCam: the PXE driver could have a hook to pull that info from glance. we should enable multiple image sources anyway (eg, http, glance, s3, etc) | 18:54 |
| NobodyCam | max_lobur: my thought was any code that would be called by more then one driver would be moved into a common area. so that unique drivers are not calling other drivers code. | 18:54 |
| devananda | lifeless: the assumption here is that different deploy drivers will need different info, which will need to be passed in by the client initiating the deploy (eg, nova in this case) | 18:56 |
| devananda | NobodyCam, max_lobur - so vendors definitely shouldn't be making drivers that explicitly call into other drivers, or implicitly depend upon specific drivers | 18:57 |
| devananda | *driver modules | 18:57 |
| NobodyCam | devananda: what fields like pxe_instance_name and pxe_root_gb | 18:57 |
| *** rloo has joined #openstack-ironic | 18:57 | |
| NobodyCam | yes that was my thinking | 18:57 |
| NobodyCam | FYI: Two minutes | 18:58 |
| devananda | NobodyCam: ah, right - so PXE driver could pull the pxe_deploy_[kernel|ramdisk] from glance. but not the root_gb, swap_mb, ephemeral_gb -- that comes from nova | 18:58 |
| lifeless | NobodyCam: so root GB is not pxe related... | 18:58 |
| devananda | but those should be set on node properties, not driver_info, because ^ | 18:58 |
| max_lobur | NobodyCam: yep, if this is driver independent code - let's move to a separate util | 18:59 |
| NobodyCam | devananda: ahh yes! I think that should be a quick refactor | 18:59 |
| *** coolsvap has joined #openstack-ironic | 18:59 | |
| max_lobur | but in our case looks like it's pure vendor code | 19:00 |
| max_lobur | meeting time! | 19:00 |
| *** max_lobur has left #openstack-ironic | 19:00 | |
| *** max_lobur has joined #openstack-ironic | 19:00 | |
| lifeless | NobodyCam: devananda: commented inline in the review. https://review.openstack.org/#/c/51328/ | 19:04 |
| NobodyCam | Thank you lifeless :) will look after the meeting | 19:04 |
| *** rloo has quit IRC | 19:04 | |
| *** rloo has joined #openstack-ironic | 19:05 | |
| max_lobur | NobodyCam: anyway you raised a good question, I think we need to keep an eye on what we can to reuse through utils, and what should be really mixed :) | 19:05 |
| *** rloo has quit IRC | 19:05 | |
| *** rloo has joined #openstack-ironic | 19:05 | |
| *** jdob has joined #openstack-ironic | 19:06 | |
| *** rameshg87 has quit IRC | 19:10 | |
| *** rloo has quit IRC | 19:10 | |
| *** rloo has joined #openstack-ironic | 19:11 | |
| *** ndipanov has quit IRC | 19:12 | |
| *** aignatov_ is now known as aignatov | 19:18 | |
| *** vkozhukalov_ has joined #openstack-ironic | 19:25 | |
| NobodyCam | #action devananda to -2 reviews that should be heald until after IceHouse is cut | 19:30 |
| devananda | wrong channel :p | 19:30 |
| NobodyCam | #action devananda to -2 reviews that should be held until after IceHouse is cut | 19:30 |
| NobodyCam | lol | 19:31 |
| lucasagomes | hah | 19:31 |
| max_lobur | ;D | 19:32 |
| *** mdurnosvistov_lt has joined #openstack-ironic | 19:36 | |
| *** jcooley_ has joined #openstack-ironic | 19:42 | |
| *** epim has joined #openstack-ironic | 19:43 | |
| k4n0 | Here | 20:00 |
| lucasagomes | devananda, are we going to have a meeting next week? | 20:00 |
| lucasagomes | thinking about the mid-cyle | 20:00 |
| NobodyCam | great meeting everyone | 20:00 |
| devananda | heh yes | 20:00 |
| lucasagomes | ack | 20:00 |
| max_lobur | k, so with call back approach | 20:00 |
| devananda | lucasagomes: even though most of us will be there, i think it's still good if we pop online | 20:00 |
| lucasagomes | ok, so we might maybe want to move the vendor_passhtru to / | 20:00 |
| devananda | and have a meeting for the folks not there | 20:00 |
| lucasagomes | and making node a parameter | 20:01 |
| max_lobur | if we looks that moment for callback (no connection etc) | 20:01 |
| lucasagomes | devananda, +1 | 20:01 |
| NobodyCam | lucasagomes: ++ we intend to be online | 20:01 |
| max_lobur | we will need re-discover and re-enroll all the nodes | 20:01 |
| max_lobur | right? | 20:01 |
| romcheg | y | 20:01 |
| NobodyCam | max_lobur: what burn-in testing | 20:01 |
| romcheg | Whoops, too much windows :) | 20:01 |
| *** wanyen has joined #openstack-ironic | 20:01 | |
| NobodyCam | gah | 20:01 |
| NobodyCam | max_lobur: what about things like burn in testing | 20:02 |
| max_lobur | sorry, I can't get you :) | 20:02 |
| lucasagomes | devananda, lifeless NobodyCam, quick thinking, why root_gb, swap_mb, ephemeral_mb should be part of properties? I think about properties as physical characteristics of the node | 20:02 |
| NobodyCam | some ops may what to discover a new node (server) and have it run burn in test for a week | 20:03 |
| lucasagomes | the size of the root partition is not a physical characteristic | 20:03 |
| lucasagomes | size of the disk yes | 20:03 |
| max_lobur | yep | 20:03 |
| max_lobur | I meant | 20:03 |
| lucasagomes | lifeless, if the pxe driver is partitioning the disk, the size of the partitions is pxe related | 20:03 |
| max_lobur | with polling approach we have a request id | 20:03 |
| max_lobur | and we can always re-issue the request | 20:04 |
| max_lobur | the result will not lost | 20:04 |
| NobodyCam | max_lobur: so the node is in a we know your there but we can't use you. but we need to be able to power on off/ control the node for the burn in test | 20:04 |
| NobodyCam | s | 20:04 |
| max_lobur | with callback - looks like there is only change to get a result | 20:04 |
| k4n0 | max_lobur: where do we store result? | 20:04 |
| max_lobur | in ironic db | 20:05 |
| max_lobur | nodes enrolled -> turned off | 20:05 |
| *** tatyana has quit IRC | 20:05 | |
| max_lobur | but they already registered in db | 20:05 |
| *** tatyana has joined #openstack-ironic | 20:06 | |
| NobodyCam | at this point if a node is enroled and has a valid power state.. Ie not none.. it will get exposed to nova | 20:06 |
| *** digambar_ has quit IRC | 20:06 | |
| max_lobur | NobodyCam: yes | 20:06 |
| lucasagomes | NobodyCam, we can set then as maintenance on | 20:07 |
| lucasagomes | nodes in maintenance mode should not be exposed to nova | 20:07 |
| max_lobur | we will need them set to maintenance | 20:07 |
| devananda | lucasagomes: ah, you're quite right that /properties is meant to be physical characteristics. but RAID config is both a physical characteristic AND something that a driver may be asked to change | 20:07 |
| devananda | just for example | 20:07 |
| k4n0 | autodiscover-disable-set-to-maintainence | 20:08 |
| max_lobur | ah, k, ignore my last comment | 20:08 |
| devananda | lucasagomes: if the PXE driver is using a whole-disk image, then size of root partition is not relevant any more | 20:08 |
| lucasagomes | devananda, I see | 20:08 |
| lucasagomes | yeah there's that about disk images as well | 20:08 |
| NobodyCam | brb | 20:10 |
| * devananda needs to think more on the boundary between /properties and /driver_info and what is set by nova each time an instance is provisioned | 20:10 | |
| lucasagomes | :) | 20:10 |
| devananda | max_lobur: with polling, we also need a separate area to store requests, delete old request results, etc | 20:11 |
| devananda | max_lobur: and a scheduling service to queue up incoming requests | 20:11 |
| devananda | max_lobur: this starts to look like gannt or taskflow very quickly | 20:11 |
| lucasagomes | yeah I think that right now, without any refactors we should leave the {root,swap,ephemeral}_[mb,gb] as part of the pxe parameters | 20:11 |
| *** rameshg87 has joined #openstack-ironic | 20:11 | |
| max_lobur | devananda: ack | 20:12 |
| max_lobur | I agree | 20:12 |
| k4n0 | callbacks with retry can be made to work well | 20:12 |
| lucasagomes | k4n0, +1 | 20:12 |
| max_lobur | that's a good point | 20:13 |
| max_lobur | Ideally would be good to have both scheduling service + callbacks mechanism | 20:13 |
| k4n0 | max_lobur: pluggable mechanism for talking to driver? | 20:14 |
| *** killer_prince has quit IRC | 20:14 | |
| max_lobur | I mean to mix both approaches | 20:14 |
| max_lobur | callbacks are good to decrease server load | 20:14 |
| *** wanyen_ has joined #openstack-ironic | 20:14 | |
| *** wanyen has quit IRC | 20:15 | |
| max_lobur | whereas scheduling good to queuing and tracking request process, | 20:15 |
| k4n0 | so important requests can go through scheduling and quick requests can go through callbacks? | 20:16 |
| *** ifarkas has quit IRC | 20:17 | |
| devananda | harlowja: hi! does/will taskflow support callbacks to external APIs when the task is complete? | 20:18 |
| max_lobur | k4n0: not exactly | 20:19 |
| devananda | max_lobur: we might just get both with the same library ... | 20:19 |
| max_lobur | :) | 20:19 |
| max_lobur | all requests have request id which can be used for tracking (if the user cannot wait and wan't to know what is going on); and all requests optionally take url callback if this is automated system and no one will hurry | 20:20 |
| k4n0 | max_lobur: got it :) | 20:21 |
| *** mrda_away is now known as mrda | 20:24 | |
| max_lobur | bbiaw | 20:25 |
| *** tatyana has quit IRC | 20:25 | |
| rameshg87 | Hi NobodyCam: | 20:27 |
| NobodyCam | rameshg87: Hi :) | 20:28 |
| mrda | lucasagomes: Just wondering whether you'd like me to fix https://bugs.launchpad.net/ironic/+bug/1282517 for you today? It's probably one I can work out, and I know you probably have a bit to do :) | 20:28 |
| rameshg87 | my submission failed again on jenkins with issues on generating the config file | 20:28 |
| lucasagomes | mrda, sure go ahead buddy :) | 20:28 |
| NobodyCam | let me take a look at the log | 20:28 |
| mrda | Ok, I'll grab it. Thanks. | 20:28 |
| rameshg87 | http://logs.openstack.org/87/73787/5/check/gate-ironic-pep8/ab50ea5/console.html | 20:29 |
| rameshg87 | i found the reason | 20:29 |
| NobodyCam | gah that is a bug | 20:29 |
| NobodyCam | devananda: rameshg87 just hit the hostname issue in jenkins | 20:29 |
| rameshg87 | https://github.com/openstack/ironic/blob/master/ironic/openstack/common/config/generator.py#L192-209 | 20:29 |
| NobodyCam | fyi | 20:30 |
| mrda | oh btw, sorry I missed the meeting. It started at 5:30am for me, and I slept in :) | 20:30 |
| rameshg87 | the hostname and fqdn wasn't set properly in my system | 20:30 |
| NobodyCam | mrda: ieek that early | 20:30 |
| lucasagomes | mrda, :D nothing to be sorry, 5:30am is really early | 20:30 |
| rameshg87 | when i set it correctly in my system (i.e when hostname = fqdn), the config is getting generated correctly | 20:30 |
| NobodyCam | oh | 20:31 |
| NobodyCam | devananda: ^^^^^ | 20:31 |
| mrda | well, I want to be part of this, so it's a small price. But late nights and early mornings..... | 20:31 |
| NobodyCam | mrda: ya!!! | 20:31 |
| rameshg87 | i think the config generator seems to be doing some magic to sanitize so that the configs generated across machines looks same | 20:31 |
| * NobodyCam now falls asleep by 11 weather he wants to or not :-p | 20:31 | |
| NobodyCam | don't get old | 20:32 |
| lucasagomes | devananda, just tested #71974 | 20:32 |
| lucasagomes | devananda, worked, +2 :) | 20:32 |
| rameshg87 | but its failing when hostname != fqdn | 20:32 |
| rameshg87 | https://github.com/openstack/ironic/blob/master/ironic/openstack/common/config/generator.py#L205-206 | 20:32 |
| lucasagomes | and now I'm done for today | 20:32 |
| NobodyCam | rameshg87: we were looking in to that failuar this weekend .... good catch | 20:32 |
| lucasagomes | have a good night NobodyCam devananda, max_lobur mrda rameshg87, everyone :D | 20:33 |
| matty_dubs | See ya, lucasagomes | 20:33 |
| NobodyCam | night lucasagomes :) | 20:33 |
| mrda | you too lucasagomes! | 20:33 |
| k4n0 | hey, cya guys, its too late in India, i will keep an eye on the this blueprint https://blueprints.launchpad.net/ironic/+spec/advanced-driver-api | 20:33 |
| k4n0 | devananda: Can you assign me this blueprint https://blueprints.launchpad.net/ironic/+spec/advanced-driver-api ? | 20:33 |
| rameshg87 | good night lucasagomes: | 20:33 |
| devananda | rameshg87: see bug https://bugs.launchpad.net/ironic/+bug/1282481 | 20:33 |
| NobodyCam | k4n0: great and thank you ! | 20:33 |
| devananda | rameshg87: you can trigger a recheck on your patch by posting a non-voting comment with the message "recheck bug 1282481" | 20:33 |
| devananda | k4n0: ac | 20:34 |
| devananda | ack | 20:34 |
| NobodyCam | devananda: he may have found the root cause | 20:34 |
| k4n0 | devananda: thanks, i will try to contribute to this bp | 20:34 |
| NobodyCam | 12:32 | rameshg87 > but its failing when hostname != fqdn | 20:34 |
| NobodyCam | could some of the jenkins server have bad names? | 20:35 |
| NobodyCam | *serverS* | 20:35 |
| *** k4n0 has left #openstack-ironic | 20:35 | |
| *** harlowja is now known as harlowja_away | 20:35 | |
| devananda | NobodyCam: it looks like yuriy proposed a fix to oslo | 20:35 |
| NobodyCam | :) w00t! | 20:36 |
| NobodyCam | linky? | 20:36 |
| NobodyCam | lol | 20:36 |
| devananda | NobodyCam: see the bug i linked already :) | 20:36 |
| NobodyCam | :) | 20:37 |
| rameshg87 | NobodyCam: devananda: yes, the review proposed should fix this issue | 20:37 |
| rameshg87 | https://review.openstack.org/#/c/75349/2/openstack/common/config/generator.py | 20:37 |
| rameshg87 | it adds a check for both hostname and fqdn, and will work in cases where hostname != fqdn | 20:37 |
| NobodyCam | :) | 20:38 |
| devananda | rameshg87: glad to hear that. mind adding a comment to the bug or review? | 20:38 |
| *** rameshg87_ has joined #openstack-ironic | 20:39 | |
| *** rloo has quit IRC | 20:39 | |
| rameshg87_ | sorry i got disconnected | 20:39 |
| rameshg87_ | devananda: if i just provide a non-voting comment "recheck bug 1282481", will jenkins run again on my patch | 20:39 |
| NobodyCam | rameshg87_: yes | 20:40 |
| devananda | yes | 20:40 |
| rameshg87_ | okay, thanks | 20:41 |
| rameshg87_ | i had one more query regarding my review | 20:41 |
| *** rameshg87 has quit IRC | 20:41 | |
| *** rloo has joined #openstack-ironic | 20:42 | |
| rameshg87_ | "Roman Prykhodchenko" had posted a comment to split the patch into smaller ones | 20:42 |
| NobodyCam | yep +1 the olso patch | 20:42 |
| NobodyCam | gah | 20:42 |
| rameshg87_ | i am not sure how to invoke him in irc :) | 20:42 |
| NobodyCam | romcheg: you here | 20:43 |
| *** coolsvap has quit IRC | 20:43 | |
| rameshg87_ | currently the ilo driver contains the power and deploy modules in it, and thats what the patch contains | 20:44 |
| rameshg87_ | since they have dependant functionality (common code, ribcl module for communicating with ilo, etc), we had decided to raise a single review for it | 20:44 |
| *** rloo has quit IRC | 20:45 | |
| rameshg87_ | the modules themselves are split in different files | 20:45 |
| rameshg87_ | so, is it required to raise the review separately ? :) | 20:45 |
| *** rloo has joined #openstack-ironic | 20:46 | |
| *** rameshg87 has joined #openstack-ironic | 20:48 | |
| devananda | rameshg87_: it is easier for reviewers to understand the implications of and interactions within smaller patches | 20:48 |
| devananda | rameshg87_: a decent rule-of-thumb is a few hundred lines per patch maximum | 20:49 |
| devananda | rameshg87_: there are occasionally exceptions, but it's tricky to review 2k lines at once | 20:49 |
| NobodyCam | rameshg87_: not speaking for romcheg but in general near 2k lines for code can be difficult to review | 20:49 |
| NobodyCam | lol devananda ++ | 20:50 |
| *** rameshg87_ has quit IRC | 20:50 | |
| rameshg87 | devananda: NobodyCam: okay | 20:50 |
| lifeless | lucasagomes: they are configuration on the node, not properties of the node | 20:50 |
| lifeless | lucasagomes: all drivers should be partitioning, so no, not pxe specific | 20:51 |
| devananda | lifeless: unless using a whole-disk image or there is no local disk | 20:52 |
| rameshg87 | so 1 option is i can raise a review request for power and deploy modules which are separate blueprints | 20:52 |
| rameshg87 | so i need to abandon this review and raise two separate reviews, right ? | 20:53 |
| devananda | lifeless: but regardless, configuration being passed to the driver goes in driver_info, which is not standardized across drivers | 20:53 |
| devananda | lifeless: thus the mapping in nova | 20:53 |
| lifeless | devananda: but whole disk or not, why is this driver specific | 20:57 |
| *** harlowja_away is now known as harlowja | 20:58 | |
| harlowja | devananda hey, just got back, so callbacks, to external APIs, like REST apis? | 20:58 |
| devananda | harlowja: yes | 20:59 |
| harlowja | in taskflow u can provide a way to get notified of all task transitions, including the completed transition, the notification mechanism can just be a callback that does what u are saying | 20:59 |
| devananda | lifeless: because it's passed via driver_info | 20:59 |
| harlowja | devananda https://github.com/openstack/taskflow/tree/master/taskflow/listeners (example of a few) | 20:59 |
| devananda | lifeless: i am aware of the tautology there | 20:59 |
| lifeless | devananda: ... :) | 21:00 |
| *** rameshg87_ has joined #openstack-ironic | 21:03 | |
| *** rameshg87 has quit IRC | 21:03 | |
| rameshg87_ | devananda: NobodyCam: please suggest regarding splitting of the patches for the ilo driver review | 21:04 |
| rameshg87_ | we will go by your suggestion | 21:04 |
| NobodyCam | devananda: max_lobur lucasagomes romcheg : quick question: Line #38 of https://review.openstack.org/#/c/73787/2/ironic/drivers/modules/ilo_common.py | 21:04 |
| NobodyCam | NM | 21:05 |
| devananda | NobodyCam: replied to your comemnt on https://review.openstack.org/#/c/72969/ | 21:05 |
| NobodyCam | answered my own question | 21:05 |
| rameshg87_ | we can split into separates patches into power and deploy modules if required | 21:05 |
| *** vkozhukalov_ has quit IRC | 21:06 | |
| NobodyCam | devananda: ack need get back on OoO bits | 21:06 |
| devananda | NobodyCam: i wouldn't worry much about adding more to that right now -- we have I3 to focus on | 21:06 |
| devananda | NobodyCam: but you -1'd for a question. so i answered it :P | 21:06 |
| devananda | NobodyCam: i want to unblock tripleo folks from using / exapnding on what we already have in tripleo | 21:07 |
| NobodyCam | lol ack.. I have the register node stuff almost ready just need to figure out how to get virt-type into it | 21:07 |
| lifeless | devananda: so that doesn't seem like a good reason to have it that way | 21:09 |
| NobodyCam | romcheg: looking over the review I see several places where i18n support is needed | 21:09 |
| NobodyCam | gah tab jsut not working for me today | 21:10 |
| NobodyCam | rameshg87_: looking over the review I see several places where i18n support is needed | 21:10 |
| NobodyCam | ie error_msg = "Missing " + license vs error_msg = _("Missing %s") % license | 21:11 |
| romcheg | NobodyCam: I'm trying to review that now but I think it's better for me to continue in the morning | 21:12 |
| rameshg87_ | NobodyCam: for this particular example that you just pointed out | 21:12 |
| devananda | lifeless: partition layout is a property of the deployment, yes? | 21:13 |
| NobodyCam | lol romcheg sorry pinged you by misstake | 21:13 |
| romcheg | NobodyCam: np | 21:13 |
| lifeless | devananda: yes (flavor specifally) | 21:13 |
| romcheg | have a good night guys | 21:13 |
| rameshg87_ | for i18n support, isn't it enough if we do _(<string>) once in the end | 21:13 |
| devananda | or to be more specific, s/property of/required info related to the/ | 21:13 |
| rameshg87_ | good night romcheg: | 21:13 |
| devananda | lifeless: so that needs to be passed to the deploy driver somehow | 21:13 |
| romcheg | Please check out the approach for the migrations | 21:13 |
| lifeless | devananda: but if nova has to have its driver change when someone adds a new deploy driver to ironic | 21:13 |
| lifeless | devananda: then we've not split them out | 21:13 |
| romcheg | If it's fine for you I'll quickly port the rest the same way | 21:14 |
| devananda | lifeless: which is why it is set on the driver_info | 21:14 |
| lifeless | devananda: thats a fundamental | 21:14 |
| lifeless | devananda: where is the why in that? | 21:14 |
| devananda | lifeless: geting there | 21:14 |
| NobodyCam | rameshg87_: in the above example licence is the data and will not get translated | 21:14 |
| devananda | lifeless: the client needs to pass that info to the driver, and ironic does not introspect driver-specific info | 21:15 |
| devananda | lifeless: drivers may require different information for provisioning | 21:15 |
| NobodyCam | if you do it once at the end it will never match as the string will look different each time | 21:15 |
| devananda | lifeless: nova happens to be A user of ironic, but not necessarily the only one | 21:15 |
| lifeless | devananda: this is like arguing that a user of nova should know whether the cloud uses KVM or Xen | 21:16 |
| rameshg87_ | NobodyCam: okay i got that one. but if we just check the below part | 21:16 |
| devananda | lifeless: are there not certain extensions only available with one or the other? | 21:16 |
| rameshg87_ | but finally "message = _("Invalid iLO license, error: %(msg)s")" is done for the exception. | 21:17 |
| rameshg87_ | <the last line> | 21:17 |
| rameshg87_ | isn't that enough for i18n ? | 21:17 |
| rameshg87_ | _() call is made for the exception itself. i wonder is not that enough ... | 21:18 |
| NobodyCam | yes! I missed that. thou Missing will not get translated | 21:18 |
| NobodyCam | it is | 21:18 |
| NobodyCam | I missed that | 21:18 |
| devananda | lifeless: IIUC your point, parameters common to all deployments should be fixed and not vary between drivers | 21:19 |
| devananda | lifeless: and other parameters should be somehow also abstracted / pulled from other sources / not visible to the end-user | 21:19 |
| rameshg87_ | even Missing should get translated i guess, because it is all part of the error_msg | 21:20 |
| rameshg87_ | devananda: NobodyCam: posting "recheck bug 1282481" didn't work and still i hit the "host" issue for my review in jenkins | 21:22 |
| devananda | s/be fixed/have standardized names/ | 21:23 |
| rameshg87_ | i think i have fixed the hostname != fqdn issue on my system, so i will post a new patch | 21:23 |
| lifeless | devananda: driver parameters shoud be for changing the behaviour of the drivers *unique* characteristics, not stock features. | 21:24 |
| *** rloo has quit IRC | 21:24 | |
| lifeless | partitioning is stock | 21:24 |
| lifeless | using iscsi for dd vs rsync might be an example of a unique characteristics | 21:24 |
| lifeless | (but why you'd want nova to know about it, I don't know) | 21:25 |
| *** rloo has joined #openstack-ironic | 21:25 | |
| lifeless | devananda: here is the acid test though - if Nova has to change *at all* when a new driver is added to Ironic, we've got a leaked abstraction. | 21:25 |
| lifeless | a 'pxe Ironic driver for Nova' makes no sense at all. | 21:25 |
| *** rloo has quit IRC | 21:26 | |
| *** rloo has joined #openstack-ironic | 21:27 | |
| devananda | lifeless: following this out in my head, it looks like pxe_deploy_[kernel|ramdisk] would need to be set by the user directly in Ironic | 21:28 |
| devananda | lifeless: as those are unique characteristics of the PXE driver | 21:28 |
| devananda | lifeless: and nova wouldn't be passing that info at all | 21:29 |
| openstackgerrit | ramesh proposed a change to openstack/ironic: Add IloDriver for HP Proliant Servers https://review.openstack.org/73787 | 21:30 |
| davidlenwell | devananda: they forgot to send me cpu's .. so it ends up I can't test the console thing until tomorrow or wednesday depending on shipping | 21:30 |
| devananda | lifeless: i don't agree with your leaked-abstraction view. different nova hypervisors expose different functionality via the nova API. | 21:31 |
| lifeless | devananda: but in a generic way | 21:32 |
| devananda | lifeless: though i think the boundary for what is required to be consistent across drivers is not in the right place | 21:32 |
| devananda | right | 21:32 |
| lifeless | you don't change novaclient when a new hypervisor is added unless the new hypervisor changes a fundamental feature | 21:32 |
| lifeless | equivalent but different are not visible over the API | 21:32 |
| devananda | and this isn't changing python-ironicclient for a new ironic driver | 21:32 |
| devananda | the client would just pass different info to USE that driver | 21:32 |
| lifeless | which is even worse | 21:33 |
| lifeless | because noone will be able to get any consistent behaviour out at all | 21:33 |
| devananda | IPMI vs SSH vs iLO require different kinds of information | 21:33 |
| lifeless | I am astounded that we're not connecting here | 21:33 |
| lifeless | power driver config, one time, not deploy time | 21:34 |
| devananda | right | 21:34 |
| devananda | i think we are thinking similar things and i'm not typing well | 21:34 |
| devananda | pxe_deploy_ramdisk should be a driver config time thing, not deploy time | 21:35 |
| devananda | that seems to be the practical matter | 21:35 |
| devananda | driver configuration shouldn't need to change each time an instance is provisioned | 21:36 |
| NobodyCam | can you tag a review with more then one blue print? | 21:45 |
| NobodyCam | ie a review that has common changes required for both BP's? | 21:45 |
| NobodyCam | s/has/would have/ | 21:46 |
| *** pmatulis1 has joined #openstack-ironic | 21:47 | |
| lifeless | devananda: can you give an example of something where nova *should* change when a new driver - say the ilo driver - is added to *Ironic*, and *why* Nova should change. | 21:48 |
| *** gQuigs has joined #openstack-ironic | 21:49 | |
| NobodyCam | rameshg87_: I asked in -infra and the safe is: No tag only one BP per review.. | 21:56 |
| rameshg87_ | NobodyCam: okay | 21:57 |
| NobodyCam | thou they were not 100% sure | 21:57 |
| rameshg87_ | so i needn't mention any blueprints in the common patch, correct ? | 21:58 |
| NobodyCam | rameshg87_: please do in just the text so the reviewers (ie. /me) know :-p | 21:58 |
| rameshg87_ | okay. i will not follow the format then. | 21:59 |
| rameshg87_ | thanks :-) | 21:59 |
| NobodyCam | Thank you :) | 21:59 |
| NobodyCam | romcheg: I asked rameshg87_ to split the Ilo patch up in to 3rds ... common changes... power ... and deploy | 22:00 |
| *** gQuigs has left #openstack-ironic | 22:00 | |
| romcheg | NobodyCam: thanks, I asked to do that earlier :-З | 22:00 |
| romcheg | :-P | 22:00 |
| romcheg | Now I really have to go | 22:01 |
| NobodyCam | :) ya he was question me on your comment | 22:01 |
| NobodyCam | have a good Night | 22:01 |
| max_lobur | night All | 22:01 |
| romcheg | Thanks | 22:01 |
| rameshg87_ | goodnight :romcheg | 22:01 |
| romcheg | See you guys | 22:01 |
| rameshg87_ | thanks for your comment :) | 22:01 |
| *** max_lobur has quit IRC | 22:01 | |
| romcheg | Ok, if I don't go now, I will have trouble with getting up again... | 22:03 |
| romcheg | Bye! | 22:03 |
| rameshg87_ | i will also leave. have goodnight/goodday wherever you are :) | 22:04 |
| *** rameshg87_ has quit IRC | 22:05 | |
| NobodyCam | missed rameshg | 22:06 |
| NobodyCam | :-p | 22:06 |
| *** jdob has quit IRC | 22:06 | |
| harlowja | devananda did that answer your taskflow question, maybe? :-P | 22:11 |
| harlowja | i volunteer rloo to fix it all | 22:13 |
| harlowja | lol | 22:13 |
| devananda | harlowja: so a listener would be created that on task-complete or task-fail, issues a HTTP POST to some other API | 22:13 |
| harlowja | devananda righto | 22:13 |
| rloo | yeah, and I'll make sure harlowja actually does the work :-) | 22:13 |
| harlowja | durn | 22:13 |
| harlowja | lol | 22:13 |
| devananda | harlowja: any odd squirly implications of that? | 22:13 |
| harlowja | devananda if the whole workflow gets reverted | 22:14 |
| harlowja | then your http post will have to handle that (depending on what that means) | 22:14 |
| devananda | harlowja: as long as there is an event for whole-workflow-reverted that can trigger a POST, that's fine | 22:15 |
| harlowja | yup, there is | 22:15 |
| devananda | great, that should work | 22:15 |
| devananda | are you coming to the sprint next week? | 22:16 |
| harlowja | i'll be there | 22:16 |
| harlowja | hiding in corner or something | 22:16 |
| harlowja | lol | 22:16 |
| harlowja | next to rloo | 22:16 |
| devananda | heh | 22:16 |
| * rloo makes a note to stay away from harlowja | 22:17 | |
| harlowja | ha | 22:17 |
| harlowja | u can't hide rloo ! | 22:17 |
| rloo | :D | 22:17 |
| * harlowja now i forgot what i am doing, bb | 22:18 | |
| devananda | so lets chat at some point in the week about adding that funtionality early in the juno cycle | 22:18 |
| harlowja | k | 22:19 |
| harlowja | devananda https://review.openstack.org/#/c/71167/, will help to have that i think also for irnoic usage | 22:19 |
| devananda | harlowja: zookeeper, hmmm | 22:20 |
| devananda | sure | 22:20 |
| *** martyntaylor has quit IRC | 22:20 | |
| harlowja | lol | 22:20 |
| harlowja | tooz i think its trying to abstract these apis, so that other than zookeeper can be used | 22:20 |
| harlowja | but its slow going it appears | 22:20 |
| *** antonym has joined #openstack-ironic | 22:29 | |
| *** lnxnut has quit IRC | 22:29 | |
| *** lynxman has quit IRC | 22:29 | |
| *** matty_dubs is now known as matty_dubs|gone | 22:31 | |
| *** jbjohnso has quit IRC | 22:34 | |
| *** lynxman has joined #openstack-ironic | 22:35 | |
| *** mdurnosvistov_lt has quit IRC | 22:41 | |
| *** romcheg1 has joined #openstack-ironic | 22:42 | |
| *** romcheg has quit IRC | 22:45 | |
| * NobodyCam looks for lunch | 22:55 | |
| *** aignatov is now known as aignatov_ | 23:01 | |
| *** romcheg1 has quit IRC | 23:05 | |
| *** lucasagomes has quit IRC | 23:15 | |
| *** derekh_afk is now known as derekh | 23:23 | |
| *** jrist has quit IRC | 23:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!