*** rloo has quit IRC | 00:09 | |
*** rloo has joined #openstack-ironic | 00:10 | |
*** jbjohnso has joined #openstack-ironic | 00:17 | |
*** matsuhashi has joined #openstack-ironic | 00:25 | |
*** lnxnut has joined #openstack-ironic | 00:30 | |
*** lnxnut has quit IRC | 00:34 | |
*** lnxnut has joined #openstack-ironic | 00:35 | |
*** jbjohnso has quit IRC | 00:37 | |
*** lnxnut has quit IRC | 00:40 | |
*** derekh has quit IRC | 00:43 | |
*** lnxnut has joined #openstack-ironic | 00:50 | |
*** lnxnut has quit IRC | 00:54 | |
*** lnxnut has joined #openstack-ironic | 00:54 | |
NobodyCam | about to call it a day | 00:58 |
---|---|---|
NobodyCam | devananda: did you have a list of bugs I could add to https://etherpad.openstack.org/p/IronicReviewDay | 00:59 |
*** lnxnut has quit IRC | 00:59 | |
NobodyCam | for the jam? | 00:59 |
openstackgerrit | A change was merged to openstack/ironic: Simplify locking around acquiring Node resources https://review.openstack.org/71974 | 00:59 |
NobodyCam | devananda: ^^^^^ w00t | 00:59 |
devananda | sweet | 01:00 |
devananda | i still need to go through the open reviews list :-/ | 01:01 |
*** lnxnut has joined #openstack-ironic | 01:01 | |
devananda | agordeev's devstack patch is still not quite happy | 01:01 |
NobodyCam | max may not make the jam tomorrow but he said he would look over the list if there any thing youd like his eye on please add to the ether pad for him | 01:01 |
lifeless | devananda: ok so I'm back; had a firedrill this morning | 01:02 |
lifeless | devananda: where did we get to ? | 01:02 |
NobodyCam | firedrill? at home office or did you go into the a real office? | 01:02 |
NobodyCam | lol | 01:03 |
NobodyCam | :) | 01:03 |
lifeless | NobodyCam: ci overcloud was dead | 01:03 |
lifeless | so we had no CI | 01:03 |
NobodyCam | ahh :) that sounds like a real fire, and a drill :O | 01:04 |
NobodyCam | gah ... /me has had worst day typing today. | 01:05 |
NobodyCam | ahh :) that sounds like a real fire, and NOT a drill :O | 01:05 |
NobodyCam | :-p | 01:05 |
*** epim has quit IRC | 01:06 | |
*** rloo has quit IRC | 01:19 | |
*** rloo has joined #openstack-ironic | 01:19 | |
*** rloo has quit IRC | 01:21 | |
*** rloo has joined #openstack-ironic | 01:22 | |
*** lnxnut has quit IRC | 01:38 | |
*** lnxnut has joined #openstack-ironic | 01:39 | |
*** lnxnut has quit IRC | 01:44 | |
*** nosnos has joined #openstack-ironic | 01:44 | |
*** rsacharya has joined #openstack-ironic | 01:56 | |
*** lnxnut has joined #openstack-ironic | 01:57 | |
*** rongze has joined #openstack-ironic | 01:57 | |
*** rsacharya has quit IRC | 02:02 | |
*** rsacharya_ is now known as rsacharya | 02:02 | |
*** rsacharya_ has joined #openstack-ironic | 02:02 | |
devananda | NobodyCam: ack, will do | 02:05 |
devananda | lifeless: i was articulating myself poorly. you were pointing at a layer violation. lets continue tomorrow | 02:07 |
lifeless | devananda: ok | 02:07 |
devananda | lifeless: side question - do you think anyone on the tripleo team will have time this week or next to cover the remainint distance of getting ironic into devtest / incubator? | 02:08 |
*** rsacharya_ has quit IRC | 02:08 | |
lifeless | devananda: I'm not sure what that distance is, so its a hard question to answer. | 02:10 |
*** rsacharya_ has joined #openstack-ironic | 02:10 | |
lifeless | devananda: did you have specific bits you need help on ? | 02:10 |
lifeless | I think sprinting on that next week would be a grand idea | 02:10 |
*** lazy_prince has joined #openstack-ironic | 02:10 | |
*** lazy_prince is now known as killer_prince | 02:10 | |
devananda | lifeless: afaik, there's not much distance left | 02:11 |
devananda | lifeless: the challenge has been the combination of two factors: other continual obligations on myself and NobodyCam, and the continuing changes to tripleo-incubator | 02:12 |
devananda | so we have been pretty slow to post new revs / finish the work | 02:12 |
devananda | so yes, sprinting next week on that would be grand | 02:13 |
*** rsacharya_ has quit IRC | 02:17 | |
*** rsacharya_ has joined #openstack-ironic | 02:18 | |
openstackgerrit | A change was merged to openstack/ironic: Do not use CONF as a default parameter value https://review.openstack.org/75883 | 02:22 |
*** rloo has quit IRC | 02:26 | |
*** rloo has joined #openstack-ironic | 02:26 | |
*** rsacharya_ has quit IRC | 02:26 | |
*** rsacharya_ has joined #openstack-ironic | 02:28 | |
*** rsacharya_ has quit IRC | 02:36 | |
*** rsacharya_ has joined #openstack-ironic | 02:36 | |
*** lnxnut has quit IRC | 02:39 | |
*** rsacharya_ has quit IRC | 02:39 | |
*** lnxnut has joined #openstack-ironic | 02:40 | |
*** rsacharya_ has joined #openstack-ironic | 02:40 | |
devananda | davidlenwell: this was posted this morning: https://review.openstack.org/#/c/75894/ | 02:41 |
*** lnxnut has quit IRC | 02:44 | |
*** rsacharya_ has quit IRC | 02:44 | |
*** rsacharya_ has joined #openstack-ironic | 02:45 | |
openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Implement API to get driver properties https://review.openstack.org/73005 | 02:45 |
*** rsacharya_ has quit IRC | 02:45 | |
*** rsacharya_ has joined #openstack-ironic | 02:46 | |
*** rloo has quit IRC | 02:48 | |
*** rloo has joined #openstack-ironic | 02:49 | |
*** matsuhashi has quit IRC | 02:50 | |
openstackgerrit | A change was merged to openstack/ironic: Sync Oslo service module to Ironic https://review.openstack.org/74025 | 02:50 |
*** rsacharya_ has quit IRC | 02:55 | |
*** matsuhashi has joined #openstack-ironic | 02:55 | |
openstackgerrit | yangxurong proposed a change to openstack/ironic: Fix params order in assertEqual https://review.openstack.org/76077 | 02:59 |
openstackgerrit | A change was merged to openstack/ironic: Removes use of timeutils.set_time_override https://review.openstack.org/67432 | 03:00 |
*** rloo has quit IRC | 03:05 | |
*** jcooley_ has quit IRC | 03:16 | |
*** lnxnut has joined #openstack-ironic | 03:19 | |
*** vkozhukalov_ has joined #openstack-ironic | 03:20 | |
*** matsuhashi has quit IRC | 03:23 | |
openstackgerrit | A change was merged to openstack/ironic: Improve help strings https://review.openstack.org/74822 | 03:34 |
*** lnxnut has quit IRC | 03:55 | |
*** lnxnut has joined #openstack-ironic | 03:56 | |
*** lnxnut has quit IRC | 04:00 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Get rid object model `dict` methods part 4 https://review.openstack.org/64251 | 04:03 |
*** jcooley_ has joined #openstack-ironic | 04:08 | |
*** lnxnut has joined #openstack-ironic | 04:11 | |
*** harlowja is now known as harlowja_away | 04:12 | |
*** lnxnut has quit IRC | 04:16 | |
*** lnxnut has joined #openstack-ironic | 04:26 | |
*** matsuhashi has joined #openstack-ironic | 04:31 | |
*** harlowja_away is now known as harlowja | 04:32 | |
*** jcooley_ has quit IRC | 04:32 | |
*** jcooley_ has joined #openstack-ironic | 04:33 | |
*** lnxnut has quit IRC | 04:40 | |
*** jcooley_ has quit IRC | 04:41 | |
*** dkehn__ has joined #openstack-ironic | 04:44 | |
*** dkehn__ has quit IRC | 04:46 | |
*** jcooley_ has joined #openstack-ironic | 04:46 | |
*** dkehn__ has joined #openstack-ironic | 04:46 | |
*** rongze has quit IRC | 04:47 | |
*** dkehn_ has quit IRC | 04:47 | |
*** rongze has joined #openstack-ironic | 04:48 | |
*** dkehn__ is now known as dkehn_ | 04:49 | |
*** rongze has quit IRC | 04:53 | |
*** KanagarajM_ has joined #openstack-ironic | 04:54 | |
*** jcooley_ has quit IRC | 04:58 | |
*** jcooley_ has joined #openstack-ironic | 04:59 | |
*** jcooley_ has quit IRC | 05:03 | |
*** jcooley_ has joined #openstack-ironic | 05:11 | |
*** rongze has joined #openstack-ironic | 05:18 | |
*** rongze has quit IRC | 05:21 | |
*** rongze has joined #openstack-ironic | 05:21 | |
*** rongze has quit IRC | 05:26 | |
*** killer_prince is now known as lazy_prince | 05:35 | |
*** lnxnut has joined #openstack-ironic | 05:36 | |
*** lnxnut has quit IRC | 05:41 | |
openstackgerrit | Michael Davies proposed a change to openstack/ironic: Prevent GET /v1/nodes returning maintenance field https://review.openstack.org/76094 | 05:48 |
*** killer_prince has joined #openstack-ironic | 05:53 | |
*** coolsvap has joined #openstack-ironic | 05:58 | |
*** loki_ has joined #openstack-ironic | 06:01 | |
*** jcooley_ has quit IRC | 06:01 | |
*** harlowja is now known as harlowja_away | 06:01 | |
*** aignatov_ is now known as aignatov | 06:01 | |
*** rongze has joined #openstack-ironic | 06:06 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/71192 | 06:07 |
*** Manishanker has joined #openstack-ironic | 06:08 | |
*** saju_m has joined #openstack-ironic | 06:21 | |
*** lnxnut has joined #openstack-ironic | 06:26 | |
*** Manishanker has quit IRC | 06:29 | |
*** saju_m has quit IRC | 06:29 | |
*** lnxnut has quit IRC | 06:31 | |
openstackgerrit | Jenkins proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/75565 | 06:31 |
*** romcheg has joined #openstack-ironic | 06:35 | |
*** loki_ has quit IRC | 06:40 | |
*** loki_ has joined #openstack-ironic | 06:41 | |
*** saju_m has joined #openstack-ironic | 06:42 | |
openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Sync Oslo rpc module to Ironic https://review.openstack.org/73971 | 06:44 |
*** vkozhukalov_ has quit IRC | 06:48 | |
openstackgerrit | lokesh s proposed a change to openstack/ironic: Ironic deployment docs https://review.openstack.org/74282 | 06:51 |
*** mrda is now known as mrda_away | 06:54 | |
*** ifarkas has joined #openstack-ironic | 06:56 | |
*** mdurnosvistov_lt has joined #openstack-ironic | 07:06 | |
openstackgerrit | Sun Jing proposed a change to openstack/ironic: Support serial console access https://review.openstack.org/64100 | 07:10 |
*** pradipta` is now known as pradipta | 07:11 | |
*** saju_m has quit IRC | 07:13 | |
*** saju_m has joined #openstack-ironic | 07:13 | |
*** mdurnosvistov_lt has quit IRC | 07:19 | |
*** lnxnut has joined #openstack-ironic | 07:26 | |
*** lnxnut has quit IRC | 07:31 | |
*** vkozhukalov_ has joined #openstack-ironic | 07:37 | |
*** lsmola has joined #openstack-ironic | 07:39 | |
*** jcooley_ has joined #openstack-ironic | 07:44 | |
*** romcheg has quit IRC | 07:49 | |
*** aignatov is now known as aignatov_ | 08:01 | |
*** jistr has joined #openstack-ironic | 08:19 | |
*** lnxnut has joined #openstack-ironic | 08:27 | |
*** lnxnut has quit IRC | 08:31 | |
*** pradipta has quit IRC | 08:32 | |
*** jcooley_ has quit IRC | 08:34 | |
*** Manishanker has joined #openstack-ironic | 08:41 | |
*** Manishanker has quit IRC | 08:41 | |
*** Manishanker has joined #openstack-ironic | 08:42 | |
*** yuriyz has joined #openstack-ironic | 08:44 | |
*** romcheg has joined #openstack-ironic | 08:45 | |
*** aignatov_ is now known as aignatov | 08:47 | |
openstackgerrit | Yongli He proposed a change to openstack/ironic: Remove extraneous vim configuration comments for ironic https://review.openstack.org/73160 | 08:50 |
*** vkozhukalov_ has quit IRC | 08:53 | |
*** ifarkas has quit IRC | 08:58 | |
*** ifarkas has joined #openstack-ironic | 09:01 | |
romcheg | Morning all | 09:07 |
Haomeng | romcheg: morning:) | 09:09 |
*** jcooley_ has joined #openstack-ironic | 09:10 | |
agordeev | romcheg and Haomeng, morning! | 09:11 |
Haomeng | agordeev: morning:) | 09:11 |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Exclude nodes in DEPLOYWAIT state from _sync_power_states https://review.openstack.org/75904 | 09:12 |
openstackgerrit | Victor Sergeyev proposed a change to openstack/ironic: Sync common config module from Oslo https://review.openstack.org/74760 | 09:14 |
*** derekh has joined #openstack-ironic | 09:17 | |
*** lucasagomes has joined #openstack-ironic | 09:22 | |
*** athomas has joined #openstack-ironic | 09:23 | |
*** lnxnut has joined #openstack-ironic | 09:26 | |
*** jcooley_ has quit IRC | 09:27 | |
*** pmatulis1 has left #openstack-ironic | 09:27 | |
*** lnxnut has quit IRC | 09:31 | |
*** matsuhashi has quit IRC | 09:31 | |
*** matsuhashi has joined #openstack-ironic | 09:34 | |
*** tatyana has joined #openstack-ironic | 09:36 | |
*** lsmola has quit IRC | 09:37 | |
*** aignatov is now known as aignatov_ | 09:41 | |
*** aignatov_ is now known as aignatov | 09:44 | |
*** max_lobur has joined #openstack-ironic | 09:48 | |
*** max_lobur has left #openstack-ironic | 09:48 | |
*** max_lobur has joined #openstack-ironic | 09:48 | |
*** martyntaylor has joined #openstack-ironic | 09:53 | |
*** lsmola has joined #openstack-ironic | 09:53 | |
*** ndipanov has joined #openstack-ironic | 09:54 | |
yuriyz | morning Ironic | 09:56 |
romcheg | Morning yuriyz agordeev Haomeng! How are you guys? | 09:57 |
yuriyz | morning romcheg | 09:59 |
*** Haomeng has quit IRC | 09:59 | |
*** matsuhashi has quit IRC | 09:59 | |
*** Haomeng has joined #openstack-ironic | 09:59 | |
*** matsuhashi has joined #openstack-ironic | 09:59 | |
*** ndipanov_ has joined #openstack-ironic | 10:01 | |
*** ndipanov_ has quit IRC | 10:03 | |
*** ndipanov_ has joined #openstack-ironic | 10:04 | |
*** ndipanov has quit IRC | 10:04 | |
yuriyz | lucasagomes, romcheg please look at https://review.openstack.org/74760 this fix frequent gates tests falling | 10:04 |
lucasagomes | yuriyz, romcheg morning folks! | 10:05 |
lucasagomes | yuriyz, will do | 10:05 |
romcheg | Morning lucasagomes! | 10:05 |
yuriyz | morning lucasagomes | 10:05 |
*** lsmola has quit IRC | 10:06 | |
*** coolsvap has quit IRC | 10:06 | |
max_lobur | morning All | 10:07 |
*** lucasagomes_ has joined #openstack-ironic | 10:12 | |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add IloDriver for HP Proliant Servers https://review.openstack.org/76144 | 10:12 |
*** lucasagomes has quit IRC | 10:13 | |
*** lucasagomes_ is now known as lucasagomes | 10:13 | |
lucasagomes | err my connection dropped | 10:13 |
lucasagomes | max_lobur, morning | 10:13 |
lucasagomes | yuriyz, +2'd | 10:13 |
*** nosnos has quit IRC | 10:14 | |
*** lazy_prince has quit IRC | 10:17 | |
*** matsuhashi has quit IRC | 10:17 | |
romcheg | lucasagomes: I'm about to +2 that as well | 10:18 |
lucasagomes | romcheg, yeah it's a sync, and that problem with the conf file is pretty annoying | 10:19 |
romcheg | Am I eligible to +A or should we wait for Devananda? | 10:19 |
openstackgerrit | A change was merged to openstack/ironic: Sync Oslo gettextutils module to Ironic https://review.openstack.org/74629 | 10:19 |
lucasagomes | romcheg, you are! Being core means that we trust ur reviews and all | 10:20 |
lucasagomes | no problem approving it | 10:20 |
*** lsmola has joined #openstack-ironic | 10:20 | |
romcheg | lucasagomes: First +A is always scaring I guess :) | 10:24 |
lucasagomes | romcheg, yeah | 10:24 |
lucasagomes | that's true :) | 10:24 |
lucasagomes | but think that we have to keep things moving | 10:24 |
lucasagomes | and in the worst case scenario we can revert a change | 10:24 |
romcheg | lucasagomes: makes sense | 10:25 |
*** lazy_prince has joined #openstack-ironic | 10:26 | |
*** lnxnut has joined #openstack-ironic | 10:26 | |
*** vkozhukalov_ has joined #openstack-ironic | 10:31 | |
*** lnxnut has quit IRC | 10:31 | |
*** coolsvap has joined #openstack-ironic | 10:36 | |
*** aignatov is now known as aignatov_ | 10:40 | |
*** lazy_prince has quit IRC | 10:42 | |
*** ndipanov_ has quit IRC | 10:45 | |
romcheg | lucasagomes: Isn't this the kind of patch that should have got a -2 from Deva? | 10:47 |
romcheg | If not, I can +2 it | 10:47 |
romcheg | https://review.openstack.org/#/c/74731/3 | 10:47 |
romcheg | I'm trying to check the queue before the review jam today | 10:47 |
openstackgerrit | yangxurong proposed a change to openstack/ironic: Fix params order in assertEqual https://review.openstack.org/76077 | 10:48 |
openstackgerrit | A change was merged to openstack/ironic: Sync common config module from Oslo https://review.openstack.org/74760 | 10:49 |
* lucasagomes looks | 10:49 | |
lucasagomes | romcheg, it's grand | 10:50 |
lucasagomes | I think the idea of the -2 is when it's a big patch or a series | 10:50 |
lucasagomes | cause that takes time to review | 10:50 |
*** KanagarajM__ has joined #openstack-ironic | 10:50 | |
lucasagomes | this patch is fine :) 1 min review | 10:50 |
*** KanagarajM_ has quit IRC | 10:53 | |
lucasagomes | romcheg, https://review.openstack.org/#/c/73896/ https://review.openstack.org/#/c/74465/ here are some patch you can take a look and use ur core power to press the final button if u wish :D | 10:54 |
romcheg | *looks* | 10:54 |
*** ndipanov_ has joined #openstack-ironic | 10:58 | |
*** ifarkas has quit IRC | 11:06 | |
*** ndipanov_ has quit IRC | 11:07 | |
*** ifarkas has joined #openstack-ironic | 11:08 | |
*** aignatov_ is now known as aignatov | 11:11 | |
*** ndipanov has joined #openstack-ironic | 11:11 | |
*** rongze has quit IRC | 11:12 | |
*** rongze has joined #openstack-ironic | 11:13 | |
*** rongze has quit IRC | 11:14 | |
Haomeng | lucasagomes: ping | 11:20 |
*** aignatov is now known as aignatov_ | 11:21 | |
lucasagomes | Haomeng, pong | 11:21 |
Haomeng | lucasagomes: morning:) | 11:22 |
Haomeng | lucasagomes: I am trying to fix this i3 bug - https://bugs.launchpad.net/bugs/1271317, but still has no solution, do you have any ideas? | 11:22 |
* lucasagomes looks | 11:23 | |
Haomeng | lucasagomes: looks it is assigned by IMichael Davies an hour ago:) | 11:23 |
Haomeng | lucasagomes: so let me check with him directly:) | 11:24 |
lucasagomes | hmmm, so one solution would be to create a hook and check for the "application/xml" but I don't think it would be the best | 11:24 |
lucasagomes | I think we can go to the #wsme channel | 11:24 |
lucasagomes | and ask the guys if there's a better one to do it | 11:24 |
lucasagomes | Haomeng, ack | 11:24 |
Haomeng | lucasagomes: :) | 11:24 |
Haomeng | lucasagomes: any way thanks:) | 11:24 |
lucasagomes | np | 11:24 |
Haomeng | lucasagomes: :) | 11:26 |
*** lnxnut has joined #openstack-ironic | 11:26 | |
lucasagomes | dhellmann, ping re disabling XML support in WSME | 11:27 |
*** lnxnut has quit IRC | 11:31 | |
*** loki_ has quit IRC | 11:34 | |
*** yuriyz has quit IRC | 11:36 | |
*** jcooley_ has joined #openstack-ironic | 11:41 | |
*** jcooley_ has quit IRC | 11:48 | |
*** viktors has joined #openstack-ironic | 11:49 | |
*** yuriyz has joined #openstack-ironic | 11:53 | |
openstackgerrit | A change was merged to openstack/ironic: Remove shebang lines from code https://review.openstack.org/74731 | 12:04 |
*** lnxnut has joined #openstack-ironic | 12:26 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Fix race condition when deleting a node https://review.openstack.org/76178 | 12:31 |
*** lnxnut has quit IRC | 12:31 | |
*** killer_prince has quit IRC | 12:39 | |
*** lucasagomes is now known as lucas-hungry | 12:39 | |
openstackgerrit | A change was merged to openstack/ironic: NodeLocked returns 503 error status https://review.openstack.org/74465 | 12:41 |
*** linggao has joined #openstack-ironic | 13:00 | |
*** coolsvap has quit IRC | 13:04 | |
*** lnxnut has joined #openstack-ironic | 13:26 | |
*** max_lobur has quit IRC | 13:31 | |
*** lnxnut has quit IRC | 13:31 | |
*** jcooley_ has joined #openstack-ironic | 13:31 | |
*** jdob has joined #openstack-ironic | 13:34 | |
*** rloo has joined #openstack-ironic | 13:36 | |
*** jcooley_ has quit IRC | 13:38 | |
*** rloo has quit IRC | 13:42 | |
*** max_lobur has joined #openstack-ironic | 13:43 | |
*** rloo has joined #openstack-ironic | 13:44 | |
*** rongze has joined #openstack-ironic | 13:45 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Exclude nodes in DEPLOYWAIT state from _sync_power_states https://review.openstack.org/75904 | 13:46 |
*** saju_m has quit IRC | 13:50 | |
*** rloo has quit IRC | 13:51 | |
*** rloo has joined #openstack-ironic | 13:51 | |
openstackgerrit | Victor Sergeyev proposed a change to openstack/ironic: WIP: sync oslo.db code https://review.openstack.org/76204 | 13:52 |
*** lucas-hungry is now known as lucasagomes | 13:52 | |
*** aignatov_ is now known as aignatov | 13:58 | |
*** lnxnut has joined #openstack-ironic | 14:02 | |
*** jbjohnso has joined #openstack-ironic | 14:05 | |
openstackgerrit | A change was merged to openstack/ironic: Use six.StringIO/BytesIO instead of StringIO.StringIO https://review.openstack.org/73896 | 14:16 |
*** KanagarajM__ has quit IRC | 14:20 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Add provision_updated_at field to nodes table https://review.openstack.org/74781 | 14:26 |
*** jcooley_ has joined #openstack-ironic | 14:28 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Add timeout for waiting callback from deploy ramdisk https://review.openstack.org/72395 | 14:29 |
*** lnxnut has quit IRC | 14:31 | |
*** jcooley_ has quit IRC | 14:36 | |
openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Implement API to get driver properties https://review.openstack.org/73005 | 14:38 |
*** lnxnut has joined #openstack-ironic | 14:48 | |
*** lnxnut has quit IRC | 14:48 | |
*** lnxnut has joined #openstack-ironic | 14:53 | |
* NobodyCam waves Good Morning on his was to start the coffee pot | 14:53 | |
*** Manishanker has quit IRC | 14:55 | |
*** Guest50062 is now known as sbadia | 15:01 | |
*** romcheg1 has joined #openstack-ironic | 15:02 | |
*** romcheg has quit IRC | 15:03 | |
*** jbjohnso has quit IRC | 15:05 | |
*** romcheg1 has quit IRC | 15:08 | |
*** rsacharya_ has joined #openstack-ironic | 15:08 | |
*** romcheg has joined #openstack-ironic | 15:11 | |
romcheg | MOrning NobodyCam | 15:11 |
NobodyCam | Good morning romcheg :) | 15:12 |
romcheg | How are you? | 15:12 |
romcheg | Please remind me when are we going to start our review jam? | 15:12 |
NobodyCam | Just awaking up :-p. but good so far :) | 15:12 |
NobodyCam | prob 8:00 am pst... so 45 minutes | 15:12 |
romcheg | cool | 15:13 |
NobodyCam | hey I wanted to setup a call with you and a couple of the devs who want to help with testing. | 15:14 |
NobodyCam | when is good for you, they are in India so they are closer to your TZ | 15:15 |
NobodyCam | we chatted awhile ago about it | 15:15 |
NobodyCam | man been reading http://www.kyivpost.com/ | 15:16 |
NobodyCam | hope all is goting okay for you and everyone there :) | 15:16 |
*** igor_ has joined #openstack-ironic | 15:17 | |
*** jbjohnso has joined #openstack-ironic | 15:20 | |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 3 https://review.openstack.org/64108 | 15:21 |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 1 https://review.openstack.org/60025 | 15:21 |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 2 https://review.openstack.org/62331 | 15:21 |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 5 https://review.openstack.org/64278 | 15:21 |
*** coolsvap has joined #openstack-ironic | 15:30 | |
*** matty_dubs|gone is now known as matty_dubs | 15:34 | |
lucasagomes | morning NobodyCam | 15:35 |
NobodyCam | morning lucasagomes :) | 15:35 |
lucasagomes | :) | 15:35 |
NobodyCam | lucasagomes: fyi I'm hacking the volume drive atm | 15:36 |
lucasagomes | NobodyCam, ack | 15:36 |
NobodyCam | brb | 15:37 |
openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Unused 'pxe_key_data' & 'pxe_instance_name' info https://review.openstack.org/75098 | 15:47 |
*** jistr has quit IRC | 15:49 | |
*** dtalton has joined #openstack-ironic | 15:52 | |
NobodyCam | Good morning Ironic | 15:59 |
NobodyCam | lucasagomes: max_lobur romcheg devananda you up and about? | 16:00 |
*** aignatov is now known as aignatov_ | 16:01 | |
lucasagomes | NobodyCam, I'm up | 16:01 |
max_lobur | morning Folks | 16:01 |
NobodyCam | hey hey max_lobur you did make it | 16:02 |
max_lobur | sorry, I have a spare call today so I won't be on the jam :/ | 16:02 |
NobodyCam | ahh see I was right :) | 16:02 |
NobodyCam | max_lobur: NP | 16:02 |
max_lobur | what I did? :) | 16:02 |
NobodyCam | just a quick question. did you look over any of items onthe etherpad? | 16:03 |
max_lobur | yep, looked yesterday, left some comments, also added a few easy patches | 16:03 |
max_lobur | did not look today yet | 16:03 |
NobodyCam | hehhee all good! | 16:03 |
max_lobur | probably there are a few new revs and also some of those easy patches may be already merged | 16:04 |
NobodyCam | :) | 16:04 |
*** romcheg has quit IRC | 16:04 | |
devananda | good morning, all | 16:05 |
NobodyCam | good morning devananda | 16:05 |
NobodyCam | jam in 20 minutes... give everyone time to get coffe and take care of morning tasks? | 16:08 |
devananda | NobodyCam: lemme get the coffee started, then dial me in when ever you are ready :) | 16:08 |
NobodyCam | :-p | 16:08 |
NobodyCam | devananda: 8:30 ok... still waiting for romchg | 16:08 |
NobodyCam | romcheg even | 16:09 |
*** romcheg has joined #openstack-ironic | 16:09 | |
romcheg | Argh! My wifi failed. Did we start? | 16:10 |
NobodyCam | lol not yet | 16:10 |
openstackgerrit | A change was merged to openstack/python-ironicclient: Remove shebang lines from code https://review.openstack.org/74648 | 16:10 |
NobodyCam | romcheg: lets say 8:30 | 16:11 |
romcheg | NobodyCam: Ok, no problem | 16:11 |
NobodyCam | gives everyone few minutes | 16:11 |
NobodyCam | :) | 16:11 |
romcheg | I have enough cider to wait :) | 16:11 |
NobodyCam | ummmm Cider..... /me has been hooked on cider of late | 16:12 |
devananda | mmm, cider! since I cant drink beer any more, cider++ | 16:14 |
*** dtalton has left #openstack-ironic | 16:14 | |
NobodyCam | devananda: no beer? :( | 16:15 |
romcheg | *is trying to set up devstack* | 16:15 |
devananda | NobodyCam: gluten ... | 16:15 |
NobodyCam | ahh | 16:15 |
NobodyCam | :( | 16:16 |
NobodyCam | easy one for lucasagomes & romcheg https://review.openstack.org/#/c/75121/ | 16:18 |
lucasagomes | heh won't approve my own patch :) | 16:18 |
*** jcooley_ has joined #openstack-ironic | 16:18 | |
romcheg | 3 +2s :) | 16:18 |
*** thedodd has joined #openstack-ironic | 16:20 | |
*** thedodd has quit IRC | 16:20 | |
*** jbjohnso has quit IRC | 16:22 | |
*** dhellmann is now known as dhellmann_ | 16:24 | |
NobodyCam | romcheg: did you +a? | 16:30 |
romcheg | NobodyCam: not yet | 16:31 |
romcheg | NobodyCam: Looks like devananda did | 16:32 |
*** rongze has quit IRC | 16:33 | |
openstackgerrit | A change was merged to openstack/python-ironicclient: Filtering nodes by maintenance mode https://review.openstack.org/75121 | 16:34 |
*** jbjohnso has joined #openstack-ironic | 16:35 | |
NobodyCam | otp sorry :( | 16:36 |
NobodyCam | I will be call core on google | 16:39 |
*** rsacharya_ has quit IRC | 16:42 | |
*** hemna_ has quit IRC | 16:43 | |
*** aignatov_ is now known as aignatov | 16:44 | |
devananda | lucasagomes: http://www.linuxtag.org/2014/ | 16:46 |
devananda | davidlenwell: get my message re: db sync patch? | 16:47 |
*** rsacharya_ has joined #openstack-ironic | 16:47 | |
NobodyCam | https://review.openstack.org/#/c/74909/ | 16:48 |
NobodyCam | morning davidlenwell | 16:48 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Do not delete a Node which is not powered off https://review.openstack.org/76258 | 16:48 |
devananda | NobodyCam: you dropped | 16:50 |
NobodyCam | oh | 16:51 |
NobodyCam | https://review.openstack.org/#/c/75904/ | 16:55 |
agordeev | good morning, Ironic | 16:55 |
NobodyCam | good morning agordeev | 16:55 |
devananda | https://blueprints.launchpad.net/ironic/+spec/keep-powered-off-nodes-off | 17:00 |
*** dshulyak has quit IRC | 17:01 | |
jroll | devananda: I'd like to be able to override that behavior somehow | 17:03 |
*** aignatov is now known as aignatov_ | 17:04 | |
devananda | jroll: what about a CONF option to toggle the source-of-truth | 17:05 |
devananda | eg, sync_or_set_node_power_state=(sync|set) | 17:05 |
devananda | if sync: update db | 17:05 |
devananda | if set: force node to state that is in the db | 17:05 |
jroll | I'm less concerned about who the source of truth is, and more concerned about being able to leave those servers on | 17:06 |
jroll | that might work, if I'm understanding it correctly | 17:06 |
jroll | or if I can override it in the deploy driver, that's fine | 17:07 |
devananda | jroll: the issue is when db state != actual hardware state | 17:07 |
devananda | that's clearly not a good thing, because the API will only show the DB state | 17:08 |
devananda | *only show the power staet recorded in the DB | 17:08 |
jroll | ohhh, I was looking at the blueprint, not the bug | 17:08 |
devananda | jroll: so the question is, when the state-in-DB != staet-of-hardware, do we update the DB? or do we set the hardware state | 17:08 |
jroll | right | 17:08 |
devananda | heh. yea, they relate :) | 17:08 |
jroll | right, but different goals | 17:09 |
jroll | :) | 17:09 |
devananda | so, CONF option good enough? | 17:09 |
*** morgabra has joined #openstack-ironic | 17:10 | |
jroll | yeah, I think so | 17:10 |
jroll | what lifeless said on that issue makes sense to me | 17:10 |
*** matty_dubs is now known as matty_dubs|lunch | 17:11 | |
devananda | it's too early for me to think of a good option name, lol | 17:11 |
jroll | heh, no worries | 17:11 |
*** rsacharya__ has joined #openstack-ironic | 17:16 | |
*** rsacharya__ has quit IRC | 17:17 | |
*** hemna has joined #openstack-ironic | 17:18 | |
lucasagomes | NobodyCam, https://review.openstack.org/#/c/72998/9/ironic/conductor/manager.py | 17:21 |
lucasagomes | 562 | 17:21 |
NobodyCam | https://etherpad.openstack.org/p/IronicReviewDay | 17:24 |
davidlenwell | devananda: are you reffereing to the comment on the blue print? | 17:25 |
*** martyntaylor has quit IRC | 17:25 | |
devananda | davidlenwell: romcheg posted a patch starting work on it | 17:25 |
devananda | https://review.openstack.org/#/c/75894/ | 17:25 |
davidlenwell | lovely .. So I can help review that | 17:25 |
*** tatyana has quit IRC | 17:25 | |
romcheg | davidlenwell: I would really appreciate that | 17:26 |
devananda | davidlenwell: also, romcheg is here today so you two might want to coordinate on that :) | 17:26 |
davidlenwell | absolutely | 17:26 |
davidlenwell | reviewing the patch now | 17:26 |
romcheg | Until I didn't drink too much cider :D | 17:26 |
davidlenwell | romcheg: does it work ? or is it sitll a work in progress? | 17:26 |
openstackgerrit | A change was merged to openstack/ironic: Clarify and fix the dev-quickstart doc some more https://review.openstack.org/74909 | 17:27 |
davidlenwell | devananda: in other news I should have my cpu's this afternoon .. so I'll be able to test console stuff | 17:27 |
romcheg | davidlenwell: That is a WIP. That is one of the revisions of the patch I have created. I would appreciate if you check the approach | 17:27 |
davidlenwell | sure | 17:27 |
davidlenwell | give me a few and I'll review and leave comments | 17:28 |
romcheg | davidlenwell: If you guys like it I will port the rest of the migration script according with it | 17:28 |
davidlenwell | romcheg: so far the one thing that stands out is that you seem to have coppied the nove bm models into your work rather than importing them form nova.. I suppose that insures that you have them on the machine that is running the migration... but for some reason it still bugs me to copy code | 17:29 |
*** aignatov_ is now known as aignatov | 17:29 | |
romcheg | One of the implementations I was working on actually imported objects from Nova | 17:30 |
davidlenwell | romcheg: that is how I was trying to do it | 17:30 |
davidlenwell | I'll read this a little closer .. stand by.. I might be able to let that go | 17:30 |
*** lazy_prince has joined #openstack-ironic | 17:31 | |
romcheg | davidlenwell: can we postpone that for about an hour please? | 17:31 |
davidlenwell | romcheg: absolutely | 17:31 |
romcheg | We are running review jam right now | 17:31 |
*** lazy_prince is now known as killer_prince | 17:31 | |
*** dhellmann_ is now known as dhellmann | 17:31 | |
romcheg | Thanks | 17:31 |
romcheg | Then we will figure everything out | 17:31 |
davidlenwell | romcheg: review jam .. now thats my jam | 17:31 |
davidlenwell | morning NobodyCam | 17:32 |
romcheg | https://review.openstack.org/#/c/75098 | 17:33 |
*** viktors has quit IRC | 17:34 | |
*** dkehn_ has quit IRC | 17:37 | |
*** killer_prince has quit IRC | 17:38 | |
openstackgerrit | A change was merged to openstack/ironic: Exclude nodes in DEPLOYWAIT state from _sync_power_states https://review.openstack.org/75904 | 17:39 |
openstackgerrit | A change was merged to openstack/ironic: Don't raise MySQL 2013 'Lost connection' errors https://review.openstack.org/73794 | 17:39 |
*** dkehn has joined #openstack-ironic | 17:40 | |
*** digambar has joined #openstack-ironic | 17:41 | |
digambar | Hi Stackers | 17:42 |
digambar | getting error while running below command | 17:43 |
devananda | DB issue: https://review.openstack.org/#/c/74781/3/ironic/db/sqlalchemy/api.py | 17:43 |
digambar | http://paste.openstack.org/show/69489/ | 17:43 |
devananda | we should not be trusting local clocks that much .... | 17:44 |
*** lazy_prince has joined #openstack-ironic | 17:44 | |
*** derekh has quit IRC | 17:44 | |
*** lazy_prince is now known as killer_prince | 17:44 | |
digambar | Hi Devananda, please look this error | 17:45 |
*** matty_dubs|lunch is now known as matty_dubs | 17:47 | |
devananda | digambar: you have either misconfigured the node's SSH power driver, or SSH is not working properly | 17:49 |
digambar | let me paste here whole output | 17:49 |
digambar | http://paste.openstack.org/show/69490/ | 17:49 |
*** killer_prince has quit IRC | 17:51 | |
*** harlowja_away is now known as harlowja | 17:55 | |
openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Old value 'updated_at' field returned after update https://review.openstack.org/75430 | 17:55 |
*** dkehn__ has joined #openstack-ironic | 17:55 | |
*** dkehn has quit IRC | 17:57 | |
*** lazy_prince has joined #openstack-ironic | 17:58 | |
*** lazy_prince is now known as killer_prince | 17:58 | |
*** dkehn__ is now known as dkehn_ | 17:59 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add option to sync node power state from DB https://review.openstack.org/76293 | 18:02 |
*** athomas has quit IRC | 18:04 | |
*** dkehn__ has joined #openstack-ironic | 18:04 | |
*** athomas has joined #openstack-ironic | 18:04 | |
openstackgerrit | A change was merged to openstack/ironic: Unused 'pxe_key_data' & 'pxe_instance_name' info https://review.openstack.org/75098 | 18:07 |
*** dkehn_ has quit IRC | 18:07 | |
*** athomas has quit IRC | 18:07 | |
*** martyntaylor has joined #openstack-ironic | 18:09 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Add option to sync node power state from DB https://review.openstack.org/76293 | 18:09 |
*** athomas has joined #openstack-ironic | 18:16 | |
openstackgerrit | A change was merged to openstack/ironic: Add provision_updated_at field to nodes table https://review.openstack.org/74781 | 18:17 |
devananda | romcheg: https://review.openstack.org/#/c/60025/ -- the patch with a hidden bug fix :) | 18:20 |
*** ndipanov_ has joined #openstack-ironic | 18:22 | |
*** ndipanov has quit IRC | 18:22 | |
*** JoshNang has quit IRC | 18:22 | |
*** JoshNang_ has joined #openstack-ironic | 18:22 | |
romcheg | mdurnosvistov: ^^] | 18:24 |
*** digambar has quit IRC | 18:25 | |
*** k4n0 has joined #openstack-ironic | 18:25 | |
*** jrist_ has joined #openstack-ironic | 18:25 | |
*** thedodd has joined #openstack-ironic | 18:30 | |
*** vkozhukalov_ has quit IRC | 18:34 | |
devananda | 2014-02-25 10:38:05.724 28568 WARNING wsme.api [-] Client-side error: '/maintenance' is an internal attribute and can not be updated | 18:38 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Use MB instead of GB for the root part size https://review.openstack.org/75464 | 18:38 |
*** igor_ has quit IRC | 18:39 | |
*** aignatov is now known as aignatov_ | 18:40 | |
lifeless | devananda: jroll: so jroll wants to leave *any* server that gets powered on out of band on? | 18:40 |
*** max_lobur has quit IRC | 18:40 | |
romcheg | https://review.openstack.org/#/c/76178/ | 18:41 |
devananda | yuriyz: your patch series to make some attrs readonly (73281 -> 73593) should have a third follow-on patch to remove teh internal_attrs() methods from the node, chassis, port, etc, API modules | 18:42 |
devananda | yuriyz: other than NobodyCam's nit (maintenance should NOT be readonly), I think the patches are good | 18:42 |
devananda | lifeless: IIUC, yes. he did not want ironic to enforce the power state, just to expose it | 18:42 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Use MB instead of GB for the root part size https://review.openstack.org/75464 | 18:43 |
devananda | lifeless: my patch to implement bp:keep-powered-off-nodes-off is above (needs unit tests but functionally complete). default is the behavior you expect (force nodes to the state recorded in the DB) | 18:43 |
devananda | yuriyz: i'm goign to fix up that nit and rebase your patch sets | 18:45 |
lifeless | devananda: cool; I guess I'm wondering if maintenance == do not enforce / do not monitor will meet his needs | 18:45 |
devananda | yuriyz: so we can land it today | 18:45 |
lifeless | devananda: rather than an option | 18:45 |
lifeless | his/her - oops :P | 18:45 |
devananda | jroll: ^ ? | 18:46 |
k4n0 | devananda: Hi there | 18:46 |
*** ndipanov_ has quit IRC | 18:47 | |
NobodyCam | https://review.openstack.org/#/c/74063/2/ironic/conductor/manager.py | 18:47 |
openstackgerrit | A change was merged to openstack/ironic: Sync Oslo rpc module to Ironic https://review.openstack.org/73971 | 18:48 |
devananda | k4n0: hi! | 18:48 |
NobodyCam | Thank you everyone! | 18:52 |
NobodyCam | brb.. | 18:52 |
lucasagomes | Thanks guys! | 18:52 |
lucasagomes | have a g'night romcheg devananda NobodyCam | 18:52 |
*** romcheg has quit IRC | 18:53 | |
*** lucasagomes has quit IRC | 18:53 | |
*** jistr has joined #openstack-ironic | 18:54 | |
*** romcheg has joined #openstack-ironic | 18:58 | |
*** mdurnosvistov_lt has joined #openstack-ironic | 19:00 | |
*** romcheg_ has joined #openstack-ironic | 19:00 | |
openstackgerrit | A change was merged to openstack/ironic: Get rid object model `dict` methods part 4 https://review.openstack.org/64251 | 19:02 |
jroll | lifeless: yes, we want to idle all of our servers | 19:02 |
*** dkehn__ is now known as dkehn_ | 19:03 | |
jroll | I want to control it with ironic | 19:03 |
*** romcheg has quit IRC | 19:03 | |
*** rsacharya has quit IRC | 19:03 | |
jroll | e.g. I'll still need to control power, but when I tear down a node I'm going to reboot it into a different image, not power it off | 19:03 |
*** rsacharya_ is now known as rsacharya | 19:03 | |
*** aignatov_ is now known as aignatov | 19:04 | |
mdurnosvistov_lt | devananda: ping | 19:04 |
*** romcheg_ has quit IRC | 19:05 | |
jroll | lifeless: I don't think "maintenance" mode will work for us - we'll be using maintenance status for actual maintenance and would want some sort of "decom" state for unused servers. life cycle is inactive -> deploying -> active -> decom -> inactive. or something like that | 19:05 |
jroll | devananda: ^ | 19:05 |
devananda | mdurnosvistov_lt: please see comments on patch https://review.openstack.org/#/c/60025/ | 19:05 |
*** rsacharya_ has joined #openstack-ironic | 19:05 | |
lifeless | jroll: so in what stages do you want power status not enforced? | 19:05 |
mdurnosvistov_lt | devananda: I saw =) In the first patch bug manifested if changes were in objects https://review.openstack.org/#/c/60025/25/ironic/objects/chassis.py https://review.openstack.org/#/c/60025/25/ironic/objects/conductor.py https://review.openstack.org/#/c/60025/25/ironic/objects/node.py https://review.openstack.org/#/c/60025/25/ironic/objects/port.py | 19:06 |
mdurnosvistov_lt | just don't split on another patch | 19:06 |
jroll | lifeless: it's more like, don't have ironic power off the node just because it's not in use by a "customer", for whatever definition of customer | 19:07 |
devananda | jroll: so you can ask ironic to power a node on, even without provisioning it | 19:08 |
lifeless | jroll: if a customer has the machine deployed | 19:08 |
lifeless | jroll: and they ask nova to turn the machine off | 19:08 |
*** aignatov has quit IRC | 19:08 | |
lifeless | jroll: do you want ironic to turn the machine off ? | 19:08 |
jroll | lifeless: yes | 19:08 |
lifeless | jroll: and if a dc tech bumps the power button | 19:08 |
*** aignatov_ has joined #openstack-ironic | 19:08 | |
lifeless | jroll: should ironic subsequently power it back off or leave the customers machine unexectedly running? | 19:08 |
*** aignatov_ is now known as aignatov | 19:09 | |
*** romcheg has joined #openstack-ironic | 19:09 | |
jroll | right, I guess I'm not sure there. I would probably want ironic to put it back in the state it should be in | 19:10 |
jroll | I *think* | 19:10 |
romcheg | davidlenwell: aroung? | 19:10 |
lifeless | jroll: right. | 19:11 |
jroll | so it sounds like we're on the same page | 19:11 |
lifeless | jroll: so, I think you need to be very specific about when you want the machines floating on | 19:11 |
lifeless | jroll: if its just 'we want them on all the time except when deployed by a customer (and then honour the customers request)' | 19:11 |
lifeless | jroll: then I would say write a little script to query undeployed machines and ask Ironic to power them up | 19:12 |
jroll | lifeless: right | 19:12 |
jroll | lifeless: we're writing our own driver | 19:12 |
* NobodyCam is back | 19:12 | |
lifeless | jroll: well it doesn't need to be a driver, this can easily live outside the core | 19:12 |
lifeless | jroll: and doesn't require a conf option at all | 19:12 |
lifeless | jroll: AFAICT | 19:12 |
jroll | lifeless: the blueprint I was reading made it sound like ironic would automatically power off any undeployed machines | 19:12 |
*** rameshg87 has joined #openstack-ironic | 19:13 | |
jroll | lifeless: sure | 19:13 |
lifeless | jroll: it will assert the recorded state | 19:13 |
*** igor_ has joined #openstack-ironic | 19:13 | |
lifeless | jroll: which is a little different :) | 19:13 |
jroll | yeah :) | 19:13 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Do not allow POST ports and chassis internal attributes https://review.openstack.org/73593 | 19:14 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Do not allow POST node's internal attributes https://review.openstack.org/73281 | 19:14 |
jroll | I think I was mistaken on the goal there. I think we'll be ok | 19:14 |
jroll | if not, we'll submit blueprints/patches as needed | 19:15 |
jroll | lifeless: ^ | 19:15 |
lifeless | jroll: cool | 19:17 |
*** igor_ has quit IRC | 19:18 | |
rameshg87 | Good morning devananda: | 19:20 |
devananda | rameshg87: good morning | 19:24 |
*** k4n0 has left #openstack-ironic | 19:32 | |
rameshg87 | devananda: i just had a question regarding one of your comment in ilo driver review | 19:37 |
openstackgerrit | Ruby Loo proposed a change to openstack/python-ironicclient: Add driver-properties command https://review.openstack.org/76338 | 19:37 |
* devananda fixes up one of lucas' patches | 19:38 | |
rameshg87 | this is related to the polling mechanism for status completion in the ilo-virtual-media deploy module | 19:38 |
rameshg87 | https://review.openstack.org/#/c/73787/6/ironic/drivers/modules/ilo_deploy.py | 19:38 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Fix race condition when deleting a node https://review.openstack.org/76178 | 19:39 |
rameshg87 | i think the major concern now is that we are polling for the status completion of deploy in the same rpc thread that triggered the deploy | 19:40 |
rameshg87 | so if we create a new thread, and poll for status completion in that thread; and let deploy continue, will that approach be fine ? | 19:40 |
devananda | rameshg87: nope | 19:41 |
devananda | rameshg87: think how this will perform at very large scale | 19:41 |
devananda | rameshg87: and how it will behave when a conductor fails while waiting for the deploy to finish. | 19:41 |
rameshg87 | hmm..okay...so all these factors suggest we go for a callback mechanism probably using a vendor passthru in the driver | 19:43 |
devananda | rameshg87: that is how the PXE driver works | 19:43 |
*** igor_ has joined #openstack-ironic | 19:44 | |
devananda | rameshg87: there is an alternative approach, but i don't think it is as good at scale -- we could add a periodic task that initiates the polling | 19:44 |
devananda | similar to _sync_power_state() | 19:44 |
devananda | that will be serialized, though, so again, not good at scale | 19:45 |
devananda | callback is the best | 19:45 |
rameshg87 | okay. so for callback we making a callback we will need to token | 19:45 |
rameshg87 | one thing the concerns us is, unlike deploy() in pxe, the virtual media deploy is completely done at the baremetal node | 19:46 |
rameshg87 | that means, writing the image to the disk is performed at the baremetal node itself (the diskimage-builder changes for this are underway) | 19:46 |
devananda | rameshg87: you are passing some unique information in via the "floppy" disk already, yes? | 19:47 |
rameshg87 | devananda: currently the status completion is passed through the virtual floppy from the baremetal node to the conductor node. the baremetal node is supposed to write the status into a file on the attached virtual floppy | 19:48 |
devananda | rameshg87: that (deploy is completely done at the baremetal node) is great! We've wanted to add that for a while -- can you link the diskimagebuilder changes? | 19:48 |
devananda | rameshg87: it would be better to issue an HTTP POST back to ironic-api, so there wouldn't be a need to keep re-reading the floppy drive | 19:49 |
rameshg87 | devananda: we are making the changes, we are planning to add a new element deploy-ironic-virtual-media which will contain a different init.d script than deploy-ironic | 19:49 |
devananda | rameshg87: but to do that, you'll need to pass a token securely to the deploy ramdisk. So, can the ironic-conductor write to that floppy before the deploy starts? | 19:49 |
rameshg87 | devananda: we thought about HTTP post back to ironic by the conductor writing to that floppy | 19:49 |
rameshg87 | devananda: but the concern that we had regarding the token expiration | 19:50 |
rameshg87 | devananda: from the time at which token is written to the floppy to the time when the HTTP POST back is made after deploy completion, there could be bigger time gap (the time it takes to write the image to the disk) | 19:50 |
rameshg87 | devananda: so we were wondering what if the token would expire in that timeframe | 19:51 |
rameshg87 | devananda: if it happens, the baremetal node wouldn't be able to make the HTTP post back | 19:51 |
rameshg87 | devananda: pxe seems to have a lesser duration because pxe makes the call before writing the image starts | 19:52 |
rameshg87 | am i correct ? | 19:52 |
devananda | rameshg87: you are correct that PXE makes the POST back after power on, and before image is written | 19:53 |
NobodyCam | devananda: quick question on friday we changed 'stats': in _node_resource on the nova driver from 'stats': nodes_extra_specs to 'stats': jsonutils.dumps(nodes_extra_specs)... this broke some of the test(which may be wrong) question is do you recall why we made the change? | 19:54 |
devananda | rameshg87: keystone token expiration can be set by the cloud operator | 19:54 |
devananda | rameshg87: what time do you see in testing the ilo deploy driver? I would expect the image transfer time to be very short -- a few minutes at most, and probably less than one minute | 19:55 |
rameshg87 | devananda: i am not sure about the exact time, but yes it will be few minutes at most | 19:56 |
devananda | NobodyCam: yes. the nova db was failing to write the node's data because it was getting an object instead of a string | 19:57 |
devananda | NobodyCam: so we need to convert that object (a dict) into a string (json'ify) | 19:57 |
devananda | lifeless: IIRC you guys have run into some keystone token expiry issues, so you may be able to address rameshg87's concern above | 19:58 |
lifeless | EDAYOFMEETINGS can you summarise please | 19:59 |
devananda | lifeless: tl;dr - I'm suggesting that iLO deploy driver rely on a POST back with a keystone token that might be a few minutes old. worst case, let's say it's an hour old | 19:59 |
devananda | yep :) | 19:59 |
devananda | lifeless: think that'll cause a problem? | 19:59 |
rameshg87 | lifeless: its like this: we let the conductor pass the token to baremetal node via floppy, baremetal node writes the image to the disk and then baremetal node makes an api call after writing the image to disk | 19:59 |
lifeless | oh right | 20:00 |
lifeless | so you don't want a token for that really | 20:00 |
*** jdob_ has joined #openstack-ironic | 20:00 | |
lifeless | because tokens may be stored in memcache where there is no guarantee that they will be usable at all | 20:00 |
lifeless | there's a thing heat does | 20:00 |
lifeless | to get long term signed urls | 20:00 |
lifeless | you should do that | 20:00 |
devananda | ahhh, thanks | 20:00 |
lifeless | needs the v3 keystone API | 20:01 |
devananda | which Ironic does not support | 20:01 |
devananda | yet | 20:01 |
rameshg87 | so regular tokens can expire in that timeframe "which it takes to reboot the node once and write the image to the disk" | 20:02 |
rameshg87 | am i correct ? | 20:02 |
*** jistr has quit IRC | 20:02 | |
devananda | rameshg87: the issue that lifeless is raising is not about expiration, which can be controlled by a setting in keystone, but by failure of the token caching | 20:05 |
devananda | rameshg87: if, during the time a deploy is running, the memcached service which keystone is using to cache tokens were to experience a failure/be restarted/etc, it would lose the existing tokens even though they had not yet reached the expiration time | 20:05 |
lifeless | or an admin going 'OMG we've got 150G of tokens -> truncate table tokens;' | 20:06 |
rameshg87 | devananda: okay, now i get it | 20:06 |
lifeless | (which we've had to do) | 20:06 |
devananda | lifeless: well, that's not memcache -- that's mysql. and that table should be trimmed regularly anyway | 20:06 |
*** igor_ has quit IRC | 20:07 | |
lifeless | devananda: should be | 20:07 |
NobodyCam | brb ... quick walkies | 20:07 |
rameshg87 | devananda: lifeless: this question might be stupid, so is there any other way to contact ironic without a token ? | 20:08 |
devananda | rameshg87: with username & password | 20:09 |
devananda | rameshg87: you need to authenticate withthe API in some way | 20:09 |
rameshg87 | ah okay .. | 20:09 |
lifeless | rameshg87: signed url as heat does. | 20:09 |
lifeless | rameshg87: which I said above. | 20:09 |
lifeless | some assembly required.d | 20:09 |
devananda | lifeless: does ironic need to implement keystone v3 for said urls to work, though? | 20:10 |
lifeless | devananda: yes, v2 is deprecated | 20:11 |
lifeless | ok, bbs | 20:11 |
rameshg87 | devananda: lifeless: okay. just one question, so does pxe driver also face the same problem now ? | 20:11 |
devananda | rameshg87: yep | 20:12 |
*** vkozhukalov_ has joined #openstack-ironic | 20:12 | |
rameshg87 | but the time duration is very small i guess | 20:12 |
rameshg87 | time it takes to power cycle and load kernel/ramdisk on the baremteal node | 20:12 |
devananda | right | 20:12 |
devananda | so ~5 minutes | 20:12 |
rameshg87 | okay | 20:13 |
devananda | also, the impact of this is fairly minimal IMO -- worst case is node sits in DEPLOYWAIT state until a timeout occurs, then the deploy fails, and user must retry | 20:13 |
devananda | it is not ideal, and there's a better way (signed URLs) | 20:13 |
devananda | but we won't be able to use taht until ironic implements suport for keysstone v3 in Juno | 20:14 |
rameshg87 | devananda: okay | 20:14 |
rameshg87 | devananda: i can check the timings for deploy, so if the order of time taken from the generation of token file to triggering of HTTP call back in ilo deploy dirver is similar to that of pxe | 20:15 |
rameshg87 | will it be acceptable in i3 ? | 20:15 |
*** coolsvap has quit IRC | 20:16 | |
devananda | rameshg87: i can't promise what will land this week. third party drivers are a lower priority than core functinoality and testing | 20:17 |
davidlenwell | romcheg: Im back now | 20:17 |
rameshg87 | devananda: okay | 20:18 |
rameshg87 | devananda: lifeless: thanks for your thoughts. we will consider the alternatives and get back | 20:22 |
davidlenwell | romcheg: I was putting together servers.. didn't look at irc for a few | 20:25 |
* devananda looks into lucas' patch, realizes that we can't release a resource *after* deleting it | 20:25 | |
*** epim has joined #openstack-ironic | 20:26 | |
*** rameshg87 has quit IRC | 20:26 | |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add IloPower module for IloDriver https://review.openstack.org/76352 | 20:28 |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Fix race condition when deleting a node https://review.openstack.org/76178 | 20:31 |
*** jdob_ has quit IRC | 20:32 | |
devananda | NobodyCam: romcheg: another good one to review, if you guys are around ^ | 20:33 |
lifeless | devananda: ok so layering and nova, go | 20:34 |
* NobodyCam looks | 20:34 | |
devananda | lifeless: https://etherpad.openstack.org/p/ironic-nova-layercake | 20:36 |
NobodyCam | devananda: +2 with comment asking lucas to bless with +1 | 20:41 |
devananda | lifeless: ok. thoughts? | 20:42 |
*** ekarlso has quit IRC | 20:43 | |
*** ekarlso has joined #openstack-ironic | 20:44 | |
*** mrda_away is now known as mrda | 20:46 | |
*** epim has quit IRC | 20:48 | |
*** rsacharya has quit IRC | 20:50 | |
*** rsacharya_ is now known as rsacharya | 20:50 | |
romcheg | davidlenwell: I'm back as well | 20:54 |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add IloDriver for HP Proliant Servers https://review.openstack.org/76144 | 20:54 |
*** ifarkas has quit IRC | 20:55 | |
*** rsacharya_ has joined #openstack-ironic | 20:55 | |
*** Haomeng has quit IRC | 21:00 | |
romcheg | davidlenwell: Let's have a chat tomorrow. It's 11PM now so I have to go | 21:00 |
romcheg | davidlenwell: As soon as you are available tomorrow, please poke me and I will be available to chat with you. | 21:01 |
*** thedodd has quit IRC | 21:02 | |
lifeless | devananda: thoughts there; sorry, meeting multiplexing going on | 21:03 |
devananda | lifeless: ack | 21:03 |
*** Haomeng has joined #openstack-ironic | 21:04 | |
mrda | morning all | 21:05 |
openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Add IloPower module for IloDriver https://review.openstack.org/76352 | 21:05 |
NobodyCam | morning mrda | 21:08 |
NobodyCam | morning davidlenwell :) | 21:08 |
devananda | g'morning, mrda | 21:08 |
NobodyCam | any ever encounter "DuplicateOptError: duplicate option: rpc_backend" running nova tests? | 21:12 |
NobodyCam | nova driver isn't doing anything with rpc_backend... | 21:14 |
davidlenwell | romcheg: I'll be up early tomorrow so we should have more overlap.. I'm all yours the first few hours of my day | 21:20 |
romcheg | davidlenwell: Please poke me as soon as you're available. | 21:21 |
romcheg | Thanks | 21:21 |
*** zul has quit IRC | 21:28 | |
*** lnxnut_ has joined #openstack-ironic | 21:48 | |
*** lnxnut has quit IRC | 21:51 | |
* devananda steps afk after the project meeting | 21:51 | |
*** jdob has quit IRC | 21:52 | |
*** mdurnosvistov_lt has quit IRC | 21:56 | |
*** mdurnosvistov_lt has joined #openstack-ironic | 21:58 | |
*** epim has joined #openstack-ironic | 22:03 | |
*** lnxnut_ has quit IRC | 22:03 | |
*** epim_ has joined #openstack-ironic | 22:03 | |
*** lnxnut has joined #openstack-ironic | 22:04 | |
NobodyCam | oh peeps.... ummmm | 22:06 |
*** epim has quit IRC | 22:07 | |
*** epim_ is now known as epim | 22:07 | |
*** lnxnut has quit IRC | 22:08 | |
*** jbjohnso has quit IRC | 22:16 | |
*** lnxnut has joined #openstack-ironic | 22:26 | |
*** linggao has quit IRC | 22:42 | |
*** martyntaylor has quit IRC | 22:47 | |
* NobodyCam goes to look for food | 22:52 | |
*** mdurnosvistov_lt has quit IRC | 22:53 | |
*** mdurnosvistov_lt has joined #openstack-ironic | 22:55 | |
*** vkozhukalov_ has quit IRC | 22:57 | |
*** mdurnosvistov_lt has quit IRC | 22:58 | |
*** mdurnosvistov_lt has joined #openstack-ironic | 22:59 | |
*** romcheg has quit IRC | 23:01 | |
*** mdurnosvistov_lt has quit IRC | 23:03 | |
*** mdurnosvistov_lt has joined #openstack-ironic | 23:05 | |
*** openstack has joined #openstack-ironic | 23:06 | |
*** matty_dubs is now known as matty_dubs|gone | 23:12 | |
NobodyCam | ahh bagel... almost back | 23:18 |
*** aignatov is now known as aignatov_ | 23:34 | |
*** mdurnosvistov_lt has quit IRC | 23:36 | |
*** epim has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!