| *** eghobo has quit IRC | 00:08 | |
| *** chuckC has joined #openstack-ironic | 00:09 | |
| *** derekh_ has joined #openstack-ironic | 00:12 | |
| devananda | mrda: around? | 00:53 |
|---|---|---|
| devananda | mrda: this concerns me: ic = __import__('ironicclient', globals(), locals(), ['client', 'exc'], -1) | 00:53 |
| devananda | mrda: and highlights my initial reaction to dansmith's request that ironicclient not be imported | 00:53 |
| devananda | mrda: also, why not use importutils? | 00:54 |
| mrda | devananda: hey | 00:55 |
| mrda | devananda: umm, that form is what's recommended in the python dics | 00:56 |
| mrda | devananda: but I can look at importutils too | 00:56 |
| devananda | mrda: so importutils is used throughout openstack to wrap that sort of thing | 00:56 |
| devananda | mrda: but more than that, I still disagree with the assertion that python-ironicclient SHOULDN"T be added to requirements.txt | 00:56 |
| * mrda is currently focusing on fixing the import on the new nova patch I pushed up after 107316 merged | 00:57 | |
| devananda | mrda: how will nova unit-test this code without allowing us to import that? | 00:57 |
| mrda | devananda: on point 1: I understand their retisence on importing ironicclient, but the consequences of that are 2) then Nova can't unit test, unlessw e add it to test-requirements.txt | 00:58 |
| devananda | mrda: what will cause devstack to install ironicclient when it's needed by Nova in the gate, if it's not in requirements? | 00:58 |
| mrda | devananda: we can go to test-requirements.txt | 00:58 |
| devananda | mrda: and how will packagers know what version of python-ironicclient to install? | 00:59 |
| devananda | but it's nto a test requirement | 00:59 |
| devananda | it's a functional requirement for an optional service | 00:59 |
| devananda | just like cinder and neutron | 00:59 |
| devananda | which are both optional service backends | 00:59 |
| mrda | ...which makes sense - you should be able to install nova with installing ironicclient, if you're not using ironic. But in test, we want to exercise that i/f | 00:59 |
| mrda | shall we go and have this argument with nova cores? | 00:59 |
| devananda | yah | 00:59 |
| devananda | also, i'll talk with danprince tomorrow -- he's in Raleigh too | 01:00 |
| devananda | i had thought the comment ws from dansmith (who's not here) | 01:00 |
| devananda | or I would have just poked danprince today | 01:00 |
| mrda | so, for now, keep going as is? And deal with this F2F (you & danprince tomorrow) and both of us next week in Hillsboro? | 01:00 |
| mrda | devananda: ^^ | 01:01 |
| devananda | mrda: what other work is in flight for the nova driver right now? | 01:03 |
| devananda | this seems like it | 01:03 |
| mrda | the whiteboard is your answer :) | 01:05 |
| devananda | :) | 01:07 |
| mrda | I'm keeping that up to date | 01:07 |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 01:09 |
| *** coolsvap has quit IRC | 01:12 | |
| devananda | mrda: take a look at nova/openstack/common/importutils | 01:12 |
| devananda | mrda: i think yous hould be using importutils.try_import | 01:13 |
| mrda | I'll take a look, once I fix the nova | 01:13 |
| *** rainya has quit IRC | 01:13 | |
| *** krtaylor has quit IRC | 01:13 | |
| *** rainya has joined #openstack-ironic | 01:14 | |
| mrda | devananda: also, we should look at synchronising our pep8 config against nova | 01:14 |
| devananda | mrda: yea, taht's be great | 01:14 |
| mrda | on my list - later today maybe | 01:15 |
| devananda | mrda: except for when we delete all that code soon | 01:15 |
| mrda | missing .'s on single line docstring breaking check gate is quite annoying :) | 01:15 |
| * mrda can never win :) | 01:15 | |
| devananda | heh | 01:16 |
| harlowja | devananda an idea, have nova have something like, https://github.com/openstack/taskflow/blob/master/optional-requirements.txt | 01:16 |
| *** coolsvap has joined #openstack-ironic | 01:16 | |
| * harlowja see there is chat about how optional requirements get actually used | 01:16 | |
| harlowja | without being so optional that they aren't tested | 01:17 |
| devananda | harlowja: see -nova ? | 01:17 |
| harlowja | checking | 01:17 |
| harlowja | arg, should not have looked | 01:19 |
| harlowja | lol | 01:19 |
| jroll | /b 76 | 01:21 |
| jroll | gah | 01:21 |
| mrda | jroll: what's so important on your 76th buffer? | 01:21 |
| mrda | ;) | 01:21 |
| jroll | lol | 01:21 |
| jroll | maybe nova :p | 01:21 |
| jroll | maybe teeth >.> | 01:22 |
| mrda | oh, so not important then | 01:22 |
| jroll | you'll never knowwww | 01:22 |
| jroll | nah, no idea where nova is... that gets the /b nova treatment | 01:22 |
| *** krtaylor has joined #openstack-ironic | 01:24 | |
| devananda | mrda: so sdague wants us to just put python-ironicclient in test-requirements in nova | 01:25 |
| devananda | mrda: and not worry about handling the import | 01:25 |
| mrda | umm | 01:25 |
| mrda | so assume that test-requirements are installed | 01:26 |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Backporting nova host manager changes into ironic https://review.openstack.org/108872 | 01:26 |
| mrda | devananda: I agree that we should do this for the sake of testing | 01:26 |
| mrda | but for production, we should still dynamically load, right? | 01:26 |
| jroll | seems reasonable | 01:26 |
| jroll | mrda: I think no | 01:27 |
| jroll | well, idk. | 01:27 |
| devananda | mrda: nope. | 01:27 |
| devananda | mrda: the driver itself is dynamiclly loaded | 01:27 |
| jroll | ImportErrors are pretty clear | 01:27 |
| devananda | mrda: if you configure nova to load nova.virt.ironic and DIDN"T instal the client, it'll importerror | 01:27 |
| jroll | nice error messages are better, but meh | 01:27 |
| devananda | i mean, sure. we can "cleint = importutils.try_import(ironicclient) ; if not client: raise Exception()" | 01:28 |
| mrda | This makes me sad, after the futzing around I've had to do. But if you want me to rip out utils.py then I shall. | 01:28 |
| jroll | (says the dev in me, the deployer would want nice errors but he is braindead at the moment) | 01:29 |
| * jroll is off for the night | 01:29 | |
| jroll | have a good one :) | 01:29 |
| mrda | jroll: night! | 01:29 |
| devananda | mrda: what you have proposed so far should, afaict, fail nova's unit test suite -- unless we add python-ironicclient to test-requirements anyway | 01:30 |
| mrda | btw ironic cores: This is a very easy +2 for you: https://review.openstack.org/#/c/108872 | 01:30 |
| mrda | devananda: right, so I think I should propose that to test_requirements | 01:30 |
| devananda | mrda: try uninstalling python-ironicclient from your venv and then just run the nova tets | 01:30 |
| devananda | right | 01:30 |
| mrda | no problems there. I quite like the dynamic load that we've got, tbh | 01:31 |
| mrda | but as I said, I'll look at importutils to see if that's cleaner and it gets the job done | 01:32 |
| devananda | mrda: except it's alredy here: http://git.openstack.org/cgit/openstack/nova/tree/nova/openstack/common/importutils.py#n55 | 01:32 |
| *** kevinbenton has quit IRC | 01:33 | |
| *** kevinbenton has joined #openstack-ironic | 01:33 | |
| * mrda goes back and makes another revision to client_wrapper | 01:33 | |
| devananda | mrda: see -nova | 01:39 |
| devananda | mrda: tldr - simply __import__ with no wrapper, and simply failing with an ImportError, is also OK apparently | 01:39 |
| mrda | yup, just there | 01:40 |
| mrda | thanks | 01:41 |
| mikal | So, that's what mrda has at the moment IIRC | 01:41 |
| mikal | It sounds like test-requiremtns is a thing too | 01:41 |
| mrda | so I'll push a new ironic review up for 107882 to change the stype of dynamically importing ironicclient, and I'll add a comment on 103167 that we'll update test-requirements | 01:43 |
| mrda | ...when we push a new nova patch set | 01:43 |
| mikal | mrda: there is apparently some oslo thing we should use instead | 01:44 |
| devananda | mikal: yea. i thought ya'll preferred importutils since i see it used throughout the nova code, whereas the only driver using __import__ is libvirt | 01:44 |
| mikal | This is probably just that I grepped the driver I was most familiar with and it's legacy | 01:44 |
| mikal | Its not a deliberate strategy to annoy mrda | 01:44 |
| mrda | mikal: :) | 01:44 |
| mikal | guestfs also uses __import__ on our side | 01:45 |
| mikal | But we can move over to importutils | 01:45 |
| devananda | cool | 01:46 |
| mrda | oh, but there's still the multiple imports problem | 01:46 |
| devananda | ? | 01:47 |
| mrda | we don't want to __import__ the module each time, because, umm, crazy | 01:47 |
| devananda | mrda: eh? | 01:47 |
| mrda | So I'm going to keep my utils.py module so as to only importutils.import_module if it hasn't already been imported | 01:47 |
| devananda | mrda: so if you're referring to getting the client and the exc modules, we can fix that in python-ironicclient | 01:48 |
| devananda | mrda: if you're referring to some other wierdness, i'm not sure what you mean | 01:48 |
| mrda | ok, so each time we get an IronicClientWrapper or call some functions in nova.virt.ironic.driver we don't want to import ironicclient each time | 01:49 |
| mrda | but if we just call import_module wherever we use ironicclient we will | 01:49 |
| mrda | so what I've done in utils.py is to save away the reference to the module, and if it's non-None, just return the reference rather than re-importing | 01:50 |
| *** nosnos has joined #openstack-ironic | 01:50 | |
| devananda | mrda: no, you import it once in IronicDriver.__init__ | 01:51 |
| mrda | except it is also used in the module function validate_instance_and_mode in driver.py | 01:52 |
| mrda | ...to get at the ironic_exception | 01:53 |
| devananda | in ironic/driver.IronicDriver.__init__(), do the import and set the module global | 01:53 |
| mrda | I get that, but if validate_instance_and_mode() is called first, it won't have been loaded | 01:54 |
| devananda | but it can't be | 01:54 |
| devananda | we can make that more clear by making it private | 01:55 |
| devananda | _validate_isntance_and_node | 01:55 |
| mrda | well, it could, but you wouldn't have the params needed to invoke it | 01:55 |
| mrda | right! | 01:56 |
| mrda | Good idea! | 01:56 |
| devananda | or even movign it into the class (though it doesn't need to be there, this protects against some eventual weird code that we dont haev today passing a client before importing it) | 01:56 |
| mrda | If you're happy with me moving it into the class, I will | 01:57 |
| devananda | making it private would be better IMO | 01:58 |
| mrda | ok, done - not fussed | 01:58 |
| devananda | :) | 01:58 |
| devananda | awesome | 01:59 |
| devananda | cafe is closing - i'm going to wander back to my hotel room | 01:59 |
| mrda | o/ | 01:59 |
| devananda | mrda: thanks for hammering away on this! | 01:59 |
| mrda | devananda: np :) | 01:59 |
| *** Haomeng|2 has joined #openstack-ironic | 01:59 | |
| *** Haomeng has quit IRC | 02:00 | |
| mikal | devananda: the comments in importutils kind of suck... I want import_object, right? | 02:01 |
| mrda | mikal: I'm going for import_module() | 02:02 |
| mikal | mrda: that has the side effect of polluting the global namespace, right? | 02:04 |
| mikal | Perhaps that's ok. I haven't really thought deeply about this | 02:04 |
| mrda | if you're importing a module I think you *want* to polute the global namespace | 02:05 |
| mrda | because things might get strange if you don't | 02:05 |
| mikal | Oh, importutils wants to parse the object path in import_object | 02:05 |
| mikal | There's a split on periods | 02:05 |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 02:13 |
| *** jcoufal has quit IRC | 02:13 | |
| *** radsy has quit IRC | 02:19 | |
| devananda | mikal: i would use try_import, which in turn uses import_module | 02:19 |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer https://review.openstack.org/72538 | 02:29 |
| devananda | mrda: back. mind if I toss anther iteration of 107882 up? | 02:34 |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer https://review.openstack.org/72538 | 02:36 |
| mrda | devananda: I'm just about to do the same | 02:42 |
| devananda | mrda: ok, go for it | 02:42 |
| mrda | there's some pep8 violations in the test_ file that i need to fix | 02:42 |
| devananda | yep | 02:42 |
| devananda | i was going to do that :) | 02:43 |
| devananda | then saw sometning else i wanted to fix, too | 02:43 |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 02:47 |
| mrda | devananda: all yours now, review -d and off you go for another revision :) | 02:51 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 02:58 |
| devananda | mrda: done. hope you like it. moved the imports around a bit | 02:58 |
| devananda | this also more closely resembles the way libvirt driver imports libvirt | 02:59 |
| *** vinbs has joined #openstack-ironic | 03:00 | |
| mrda | devananda: so has these been proposed into Nova yet? | 03:00 |
| devananda | nope | 03:00 |
| mrda | i.e. via 103167 | 03:00 |
| mrda | ok, I can add that in | 03:00 |
| devananda | https://review.openstack.org/#/c/107882/12..13/ironic/nova/virt/ironic/driver.py | 03:01 |
| mrda | I needs to fix the test in nova, so I'll propose these changes as well | 03:01 |
| mrda | it's in the spirit of the process, if not exactly following the process, that we've defined :) | 03:01 |
| devananda | aye | 03:01 |
| mrda | but I do think we're getting there | 03:02 |
| devananda | given the conversation we had a bit ago with folks in -nova, I've taken their feedback and simplified the importing of the python-ironicclient module | 03:02 |
| devananda | to be closer to the way libvirt does it | 03:02 |
| mrda | (if only Nova UTC would run *quicker*) | 03:02 |
| devananda | eg, "if ironic is None: ironic = importutils.import_module('ironicclient')" | 03:03 |
| mrda | ya | 03:03 |
| mrda | I'm not unhappy - I would have used _ironic, but it's a small thing | 03:03 |
| devananda | libvirt uses "libvirt" not "_libvirt" ... so that's what I followed | 03:04 |
| devananda | I agree, it's a private var | 03:04 |
| mrda | sure | 03:04 |
| devananda | *shrug* | 03:04 |
| devananda | mrda: cheers. thanks again :) | 03:04 |
| mrda | So the thing I liked about how it was before, is that ironci_client and ironic_exception *looked* like they might have been regularly imported. But either way is fine. Thanks for the your help devananda | 03:05 |
| *** rainya has quit IRC | 03:08 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Add drivers.base.BaseDriver.get_properties() https://review.openstack.org/107092 | 03:11 |
| *** harlowja is now known as harlowja_away | 03:15 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Implement API to get driver properties https://review.openstack.org/107096 | 03:21 |
| *** rloo has quit IRC | 03:22 | |
| *** nosnos has quit IRC | 03:29 | |
| *** nosnos has joined #openstack-ironic | 03:29 | |
| *** nosnos has quit IRC | 03:33 | |
| *** eghobo has joined #openstack-ironic | 03:35 | |
| *** ramineni has joined #openstack-ironic | 03:37 | |
| *** rainya has joined #openstack-ironic | 04:10 | |
| *** nosnos has joined #openstack-ironic | 04:14 | |
| *** rameshg87 has joined #openstack-ironic | 04:18 | |
| *** rainya has quit IRC | 04:28 | |
| *** Nisha has joined #openstack-ironic | 04:34 | |
| Nisha | JoshNang: hi | 04:34 |
| Nisha | JoshNang: Thanks for the review. i addressed your query in the spec https://review.openstack.org/#/c/100951/ Discover node properties at node-create / node-update | 04:35 |
| Nisha | JoshNang: Let me know if you have any other comments. | 04:35 |
| *** rainya has joined #openstack-ironic | 04:48 | |
| *** rakesh_hs has joined #openstack-ironic | 05:00 | |
| JoshNang | Nisha: thanks! | 05:13 |
| *** pradipta_away is now known as pradipta | 05:18 | |
| *** shausy has joined #openstack-ironic | 05:19 | |
| *** pradipta is now known as pradipta_away | 05:25 | |
| *** derekh_ has quit IRC | 05:31 | |
| *** k4n0 has joined #openstack-ironic | 05:33 | |
| *** pcrews has quit IRC | 05:34 | |
| *** nosnos has quit IRC | 05:35 | |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Backporting nova host manager changes into ironic https://review.openstack.org/108872 | 05:36 |
| *** nosnos has joined #openstack-ironic | 05:36 | |
| *** bmahalakshmi has joined #openstack-ironic | 05:40 | |
| *** nosnos has quit IRC | 05:41 | |
| *** amitpp has joined #openstack-ironic | 05:49 | |
| *** amitpp has quit IRC | 05:49 | |
| *** Poornima|mtg has joined #openstack-ironic | 05:55 | |
| *** Poornima|mtg is now known as Poornima_ | 05:56 | |
| *** nosnos has joined #openstack-ironic | 05:59 | |
| *** Poornima_ has quit IRC | 06:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/108901 | 06:14 |
| *** Poornima|mtg has joined #openstack-ironic | 06:25 | |
| *** Poornima|mtg is now known as Poornima_ | 06:26 | |
| *** Poornima_ has quit IRC | 06:26 | |
| *** saripurigopi has joined #openstack-ironic | 06:28 | |
| *** rainya has quit IRC | 06:33 | |
| *** eghobo has quit IRC | 06:37 | |
| *** Halacs has joined #openstack-ironic | 06:47 | |
| *** viktors|afk is now known as viktors | 06:54 | |
| *** poornima_ has joined #openstack-ironic | 06:57 | |
| *** poornima_ has quit IRC | 06:58 | |
| *** poornima_ has joined #openstack-ironic | 06:58 | |
| openstackgerrit | Rakesh H S proposed a change to openstack/ironic-specs: Enabling IPMI double bridge support https://review.openstack.org/98208 | 07:06 |
| *** romcheg1 has joined #openstack-ironic | 07:12 | |
| *** Nisha has quit IRC | 07:18 | |
| *** Haomeng|2 has quit IRC | 07:19 | |
| *** jistr has joined #openstack-ironic | 07:19 | |
| *** kpavel has joined #openstack-ironic | 07:22 | |
| *** Haomeng has joined #openstack-ironic | 07:22 | |
| openstackgerrit | Michael Davies proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 07:23 |
| *** Haomeng|2 has joined #openstack-ironic | 07:27 | |
| *** Haomeng has quit IRC | 07:28 | |
| openstackgerrit | Dongdong Zhou proposed a change to openstack/ironic: remove ironic-manage-ipmi.filters https://review.openstack.org/108913 | 07:44 |
| *** Mikhail_D_ltp has joined #openstack-ironic | 08:00 | |
| openstackgerrit | Dongdong Zhou proposed a change to openstack/ironic: remove ironic-manage-ipmi.filters https://review.openstack.org/108913 | 08:10 |
| mrda | Night ironic! | 08:14 |
| *** mrda is now known as mrda-away | 08:14 | |
| *** foexle has joined #openstack-ironic | 08:15 | |
| *** romcheg1 has quit IRC | 08:17 | |
| *** lucasagomes has joined #openstack-ironic | 08:17 | |
| *** athomas has joined #openstack-ironic | 08:27 | |
| *** romcheg1 has joined #openstack-ironic | 08:30 | |
| *** martyntaylor has joined #openstack-ironic | 08:38 | |
| *** pradipta_away is now known as pradipta | 08:41 | |
| *** romcheg1 has quit IRC | 08:50 | |
| *** martyntaylor has left #openstack-ironic | 08:51 | |
| *** bvivek has joined #openstack-ironic | 08:53 | |
| *** romcheg1 has joined #openstack-ironic | 08:59 | |
| *** pelix has joined #openstack-ironic | 09:01 | |
| *** dtantsur|afk is now known as dtantsur | 09:04 | |
| dtantsur | Morning, Ironic | 09:04 |
| romcheg1 | Morning dtantsur! | 09:05 |
| dtantsur | romcheg1, morning | 09:05 |
| *** Nisha has joined #openstack-ironic | 09:10 | |
| Nisha | dtantsur: hi | 09:12 |
| dtantsur | Nisha, hi | 09:12 |
| Nisha | dtantsur: Please could you review https://review.openstack.org/#/c/100951/ | 09:13 |
| Nisha | :) | 09:13 |
| Nisha | its already 23rd | 09:13 |
| Nisha | :) | 09:14 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to stackforge/pyghmi: Use get() to avoid KeyError on get_bootdev() https://review.openstack.org/108929 | 09:22 |
| *** romcheg1 has quit IRC | 09:23 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to stackforge/pyghmi: Raise IpmiException on an error setting/getting the boot device https://review.openstack.org/108932 | 09:32 |
| *** cdent has joined #openstack-ironic | 09:33 | |
| dtantsur | Nisha, it's on my radar, just have a lot of things to do as usual | 09:35 |
| dtantsur | stay tuned :) | 09:35 |
| *** bmahalakshmi has quit IRC | 09:38 | |
| openstackgerrit | A change was merged to openstack/ironic: remove ironic-manage-ipmi.filters https://review.openstack.org/108913 | 09:40 |
| Nisha | dtantsur: :) | 09:41 |
| *** bmahalakshmi has joined #openstack-ironic | 09:42 | |
| *** cdent_ has joined #openstack-ironic | 09:47 | |
| *** romcheg1 has joined #openstack-ironic | 09:48 | |
| *** cdent has quit IRC | 09:50 | |
| *** cdent_ is now known as cdent | 09:50 | |
| Nisha | dtantsur: one ques | 09:54 |
| Nisha | your one comment was to have --createports as create_ports or create-ports | 09:55 |
| Nisha | i had create_ports as the option earlier | 09:55 |
| Nisha | but one review comment earlier was to have it as create-ports which i was unable to parse in ironic client shell, hence i named it as --createports | 09:57 |
| dtantsur | Nisha, there was some trick with it, it should be possible to use create-ports, which will be internally mapped to ironic_ports | 09:58 |
| *** Nisha has quit IRC | 10:03 | |
| *** nosnos has quit IRC | 10:09 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Expose {set,get}_boot_device in the API https://review.openstack.org/90151 | 10:16 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SSH virsh to use the new ManagementInterface https://review.openstack.org/89884 | 10:16 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface https://review.openstack.org/86588 | 10:16 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic-specs: Move code to cleanup ImageCache to a common place https://review.openstack.org/107996 | 10:17 |
| openstackgerrit | Victor Sergeyev proposed a change to openstack/ironic: Catch oslo.db error instead of sqlalchemy error https://review.openstack.org/108943 | 10:17 |
| *** Nisha has joined #openstack-ironic | 10:18 | |
| rameshg87 | dtantsur: hi | 10:18 |
| dtantsur | rameshg87, hi | 10:18 |
| rameshg87 | dtantsur: have a few questions regarding setting up ironic to work with virsh and pxe_ssh driver | 10:19 |
| rameshg87 | dtantsur: i am just doing it for the first time | 10:19 |
| rameshg87 | dtantsur: i am just trying this out http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack | 10:19 |
| rameshg87 | dtantsur: the qemu instances brought up are not booting up :-( | 10:20 |
| rameshg87 | dtantsur: i just had some questions in this space. do you test out the changes the same way with qemu ? | 10:21 |
| dtantsur | rameshg87, I use devstack + tempest generally (and often rely on CI for trivial changes) | 10:21 |
| rameshg87 | dtantsur: i have a question, when i was triaging the issue | 10:22 |
| dtantsur | what's in logs? do the nodes pass PXE? | 10:22 |
| rameshg87 | dtantsur: no it doesn't pass pxe. ipxe fails to get an ip for node from n-dhcp | 10:22 |
| rameshg87 | dtantsur: i see that in the guest | 10:22 |
| rameshg87 | dtantsur: when i was triaging i find that the guest's tap interface connects to openvswitch named 'brbm' | 10:22 |
| rameshg87 | dtantsur: *openvswitch bridge named brbm | 10:23 |
| rameshg87 | dtantsur: and n-dhcp is listening on tap interface connected to ovs bridge 'br-int' | 10:23 |
| rameshg87 | dtantsur: i see the dhcp request packets coming on brbm using tcpdump | 10:23 |
| rameshg87 | dtantsur: but wondering how neutron will recieve those which has dnsmasq connected to a tap interface on br-int | 10:24 |
| dtantsur | rameshg87, honestly, I'm not strong in all these network-related things. You may even want to ask on #openstack-neutron | 10:24 |
| rameshg87 | dtantsur: okay :-) | 10:27 |
| rameshg87 | dtantsur: let me just try seeing again .. | 10:27 |
| rameshg87 | dtantsur: was wondering checking here because brbm seems to be created by devstack scripts related to ironic :-) | 10:29 |
| *** jistr has quit IRC | 10:29 | |
| *** dtantsur has quit IRC | 10:30 | |
| *** dtantsur has joined #openstack-ironic | 10:37 | |
| *** jistr has joined #openstack-ironic | 10:38 | |
| Nisha | dtantsur: Hi, saw ur comment | 10:41 |
| Nisha | i can make it create_ports again | 10:42 |
| Nisha | that works. | 10:42 |
| dtantsur | Nisha, it's ok for me. If people don't like it, they can explain you, how to do it better ;) | 10:44 |
| Nisha | ok i will post the spec with create_ports | 10:44 |
| openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties at node-create/node-update https://review.openstack.org/100951 | 10:46 |
| Nisha | Just posted it | 10:46 |
| dtantsur | ack, thanks | 10:46 |
| Nisha | dtantsur: just have a look and let know if any further comments | 10:46 |
| Nisha | if this looks ok, then plz review the follow up ilo spec too | 10:47 |
| Nisha | :) | 10:47 |
| *** chuckC has quit IRC | 10:48 | |
| *** pradipta is now known as pradipta_away | 10:53 | |
| *** ramineni has quit IRC | 11:01 | |
| *** foexle has quit IRC | 11:01 | |
| lifeless | lucasagomes: jay dobies was referring to tripleo specs, not ironic :) | 11:03 |
| lucasagomes | lifeless, oh... holy cow | 11:03 |
| lucasagomes | hah | 11:03 |
| lucasagomes | morning issues | 11:04 |
| *** bmahalakshmi has quit IRC | 11:04 | |
| lucasagomes | lifeless, heh replied... anyway that could be something that we could adopt here as well | 11:05 |
| lucasagomes | cheers for pointing that out | 11:05 |
| lucasagomes | we had a similar conversation about how to improve specs reviews on the ironic meeting | 11:06 |
| *** bmahalakshmi has joined #openstack-ironic | 11:07 | |
| *** romcheg1 has left #openstack-ironic | 11:08 | |
| *** bmahalakshmi has quit IRC | 11:09 | |
| *** bmahalakshmi has joined #openstack-ironic | 11:11 | |
| *** chuckC has joined #openstack-ironic | 11:12 | |
| *** bmahalakshmi has quit IRC | 11:13 | |
| *** bmahalakshmi has joined #openstack-ironic | 11:14 | |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Fix leaking DB details to API on error https://review.openstack.org/73121 | 11:19 |
| *** rameshg87 has left #openstack-ironic | 11:21 | |
| *** saripurigopi has quit IRC | 11:22 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Clean up calls to get_chassis() https://review.openstack.org/108959 | 11:26 |
| openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties for iLO driver https://review.openstack.org/103007 | 11:27 |
| *** chuckC has quit IRC | 11:27 | |
| *** lucasagomes is now known as lucas-hungry | 11:28 | |
| devananda | morning, all | 11:30 |
| dtantsur | devananda, morning | 11:38 |
| *** ChuckC has joined #openstack-ironic | 11:41 | |
| *** jcoufal has joined #openstack-ironic | 11:43 | |
| *** Haomeng has joined #openstack-ironic | 11:48 | |
| *** Haomeng|2 has quit IRC | 11:49 | |
| *** romcheg2 has joined #openstack-ironic | 11:50 | |
| openstackgerrit | Victor Sergeyev proposed a change to openstack/ironic: Use metadata.create_all() to get database schema https://review.openstack.org/107629 | 11:56 |
| openstackgerrit | Victor Sergeyev proposed a change to openstack/ironic: Add a test case for DB schema comparison https://review.openstack.org/107628 | 11:56 |
| openstackgerrit | Victor Sergeyev proposed a change to openstack/ironic: Catch oslo.db error instead of sqlalchemy error https://review.openstack.org/108943 | 12:04 |
| *** k4n0 has quit IRC | 12:05 | |
| *** bmahalakshmi has quit IRC | 12:07 | |
| *** viktors is now known as viktors|afk | 12:15 | |
| *** vinbs has quit IRC | 12:18 | |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Add newly_discovered column to Node object https://review.openstack.org/107389 | 12:21 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/python-ironicclient: Export 'client' and 'exc' modules https://review.openstack.org/108974 | 12:21 |
| *** romcheg2 has left #openstack-ironic | 12:23 | |
| *** lsmola has joined #openstack-ironic | 12:24 | |
| GheRivero | morning all | 12:29 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 12:32 |
| dtantsur | GheRivero, morning | 12:35 |
| *** jdob has joined #openstack-ironic | 12:41 | |
| *** poornima_ has quit IRC | 12:43 | |
| * devananda wanders over to the meetup | 12:45 | |
| *** lucas-hungry is now known as lucasagomes | 12:45 | |
| lucasagomes | GheRivero, devananda morning | 12:45 |
| devananda | lucasagomes: morning | 12:45 |
| *** Poornima|mtg has joined #openstack-ironic | 12:46 | |
| openstackgerrit | Ghe Rivero proposed a change to openstack/ironic: Raise MissingParameterValue instead of invalid https://review.openstack.org/108455 | 12:47 |
| *** Poornima|mtg has quit IRC | 12:48 | |
| *** Poornima_ has joined #openstack-ironic | 12:49 | |
| openstackgerrit | Ghe Rivero proposed a change to openstack/ironic: Raise MissingParameterValue when validating glance info https://review.openstack.org/108456 | 12:49 |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic-specs: Generic Hardware Discovery Bits https://review.openstack.org/107344 | 13:00 |
| *** rwsu has joined #openstack-ironic | 13:01 | |
| *** romcheg2 has joined #openstack-ironic | 13:01 | |
| romcheg2 | dtantsur: Gah, I didn't notice that important change between revisions. AFAIR API was involved previously | 13:02 |
| dtantsur | romcheg2, yeah, it was, things have changed again after one more discussion :) | 13:02 |
| *** Poornima_ has left #openstack-ironic | 13:03 | |
| openstackgerrit | A change was merged to openstack/ironic: Implement retry on NodeLocked exceptions https://review.openstack.org/107710 | 13:03 |
| *** jcoufal has quit IRC | 13:05 | |
| *** derekh_ has joined #openstack-ironic | 13:08 | |
| *** jcoufal has joined #openstack-ironic | 13:16 | |
| *** matty_dubs|gone is now known as matty_dubs | 13:18 | |
| *** Nisha has quit IRC | 13:25 | |
| openstackgerrit | A change was merged to openstack/ironic: Add drivers.base.BaseDriver.get_properties() https://review.openstack.org/107092 | 13:31 |
| devananda | back | 13:32 |
| *** rloo has joined #openstack-ironic | 13:33 | |
| *** notq has quit IRC | 13:37 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 13:42 |
| *** ChuckC has quit IRC | 13:55 | |
| *** Halacs has quit IRC | 13:58 | |
| rloo | hi ironickers. | 14:05 |
| matty_dubs | Morning rloo | 14:05 |
| romcheg2 | Hi rloo devananda matty_dubs! | 14:05 |
| matty_dubs | I've been dragged into some non-Ironic stuff for the time being, but g'morning all the same! | 14:06 |
| rloo | matty_dubs: was going to say, long time no hear ;) | 14:06 |
| rloo | lucasagomes: because 107092 merged, your new ManagementInterface changes will need to be rebased/updated to have a get_properties(). Did you want me to make that change for you? | 14:07 |
| lucasagomes | rloo, o/ well they are not completetly merged so I assume I will have to do it at least for the patches that still on the queue | 14:09 |
| lucasagomes | I don't mind if u wanna update the ones already merged, actually i would just thank you for that | 14:09 |
| dtantsur | rloo, matty_dubs, morning | 14:10 |
| rloo | lucasagomes: the ones that already merged have already been updated -- I had to do that cuz my patch kept failing w/o those changes ;) | 14:11 |
| *** Mikhail_D_ltp has quit IRC | 14:11 | |
| lucasagomes | rloo, ah, cheerios! alright I will rebase the ones in the queue and update it then | 14:11 |
| rloo | lucasagomes: the changes are straightforward. you'll know you need to do it cuz the unit tests will fail. | 14:11 |
| lucasagomes | rloo, thanks for pointing that | 14:12 |
| lucasagomes | rloo, ack :) | 14:12 |
| lucasagomes | devananda, pep8 is not working for the nova driver in our tree? | 14:17 |
| devananda | lucasagomes: no :( | 14:17 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Backporting nova host manager changes into ironic https://review.openstack.org/108872 | 14:18 |
| lucasagomes | devananda, :( cause there's one tiny nit on that #107882 patch, a trailing space and it will fail on pep8 | 14:18 |
| *** rakesh_hs has quit IRC | 14:19 | |
| *** shausy has quit IRC | 14:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/106569 | 14:20 |
| devananda | lucasagomes: I'm fine with that -- it'll get caught by Nova | 14:21 |
| *** dkehn_ has joined #openstack-ironic | 14:21 | |
| devananda | lucasagomes: it won't fail in our gate. it'll fail when ported to Nova, which is a manual process, and the only way for us, right now, to find pep8 issues | 14:22 |
| *** romcheg2 has quit IRC | 14:22 | |
| rloo | devananda: this dance with nova isn't that clear to me. if we don't fix any pep8 in ironic tree, and it fails in nova tree, do those changes then need to be made to both ironic and nova trees? | 14:23 |
| devananda | lucasagomes: but happy to fix now anyway | 14:23 |
| lucasagomes | devananda, right, so no need to fix it in our gate? if not the change lgtm | 14:23 |
| lucasagomes | I thought it wasn't that manual | 14:23 |
| devananda | it's totally manual | 14:23 |
| lucasagomes | I thought we did a diff from the ironic/nova dir | 14:23 |
| devananda | i was doing it for two weeks. mrda's been doing it for the last week | 14:23 |
| lucasagomes | to the real nova dir | 14:23 |
| devananda | except we need to munge imports when copying the files | 14:24 |
| lucasagomes | and applied the changes in that semi-automatic way | 14:24 |
| devananda | several import paths change,w hcih also changes the line order | 14:24 |
| lucasagomes | urgh | 14:24 |
| devananda | yep | 14:24 |
| lucasagomes | what a pain | 14:24 |
| devananda | it sucks | 14:24 |
| lucasagomes | I hear you | 14:24 |
| lucasagomes | ok changing my vote there | 14:24 |
| devananda | and nova reviewing the code there means a multi-step process to update our code then repropose it to nova | 14:24 |
| devananda | the faster we can iterate, the better | 14:24 |
| devananda | and this patch has been painful | 14:24 |
| *** dkehnx has quit IRC | 14:25 | |
| devananda | lucasagomes: i'm going to toss up one using hasattr | 14:25 |
| devananda | gimme 2 seconds | 14:25 |
| lucasagomes | devananda, aight | 14:25 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 14:28 |
| *** dkehn_ is now known as dkehnx | 14:29 | |
| devananda | lucasagomes: looks like https://blueprints.launchpad.net/ironic/+spec/add-node-instance-info wasn't targeted / updated properly. just updated it | 14:38 |
| *** jgrimm has joined #openstack-ironic | 14:38 | |
| devananda | lucasagomes: though the migration script https://review.openstack.org/#/c/96136/ isn't landed -- I think we should land that, but we still need to doc'n the change and new expectation | 14:39 |
| lucasagomes | devananda, oh cheers, that remings me the migration thing | 14:39 |
| lucasagomes | yeah... devananda will fix it now | 14:39 |
| lucasagomes | totally forgot it | 14:39 |
| devananda | cool, thx! | 14:39 |
| lucasagomes | comstud, ping u there? | 14:39 |
| comstud | lucasagomes: yep, sorta :) | 14:39 |
| lucasagomes | comstud, howdy, so you have any updates on the objects clean up? if you don't mind I started trying to do the same you did you nodes to the others resources like chassis and ports | 14:40 |
| lucasagomes | comstud, I did chassis only for now https://review.openstack.org/#/c/108959/ | 14:40 |
| *** cdent_ has joined #openstack-ironic | 14:41 | |
| *** kpavel has quit IRC | 14:41 | |
| lucasagomes | comstud, I added urself as co-author cause it was mostly copy&paste | 14:41 |
| lucasagomes | from ur patch for nodes | 14:41 |
| * lucasagomes dislike having incosistencies on the objects interfaces | 14:41 | |
| dtantsur | devananda, you didn't answer, is _LE usage in driver.py on lin #552 correct? | 14:42 |
| comstud | lucasagomes: oh, you didn't need to put me as co-author. :) thanks for doing that | 14:42 |
| dtantsur | it does not looks so | 14:42 |
| *** cdent has quit IRC | 14:42 | |
| *** cdent_ is now known as cdent | 14:42 | |
| comstud | lucasagomes: i have been way too busy lately and just haven't made it back to finishing that stuff | 14:42 |
| comstud | :-/ | 14:42 |
| lucasagomes | comstud, ack... alright I will try to get the rest of the resources at the same stage as the node | 14:43 |
| devananda | comstud: hey, since you're there, random question -- what do you think of making the nova baremetal api extension into a proxy for ironic's api? (see -nova cnoversation earlier) | 14:43 |
| lucasagomes | with create() and destroy() on the objects and avoid using the dbapi for everything | 14:43 |
| comstud | devananda: yeah, i was wondering about that some time ago | 14:43 |
| comstud | never persued the idea | 14:43 |
| comstud | so, i'm not sure what I think :) | 14:44 |
| comstud | haha | 14:44 |
| devananda | heh | 14:44 |
| devananda | dtantsur: ugh, no... | 14:44 |
| * comstud has about 5 seconds to give each thought | 14:44 | |
| comstud | devananda: i'll scroll back in a bit and read the convo | 14:44 |
| devananda | comstud: probably better for your sanity not to read it :) | 14:45 |
| comstud | hahaha | 14:46 |
| comstud | s'ok, i'm already not sane | 14:46 |
| *** Poornima_ has joined #openstack-ironic | 14:53 | |
| *** hemna has quit IRC | 14:55 | |
| *** MattMan has quit IRC | 14:55 | |
| *** lsmola has quit IRC | 14:55 | |
| rloo | I'm seeing some gate-tempest-dsvm-virtual-ironic failures, due to "Timed out waiting to get Ironic node by instance ..." | 15:01 |
| rloo | is that a known issue? | 15:01 |
| devananda | rloo: example? | 15:01 |
| rloo | http://logs.openstack.org/96/107096/8/gate/gate-tempest-dsvm-virtual-ironic/2a79841/console.html | 15:02 |
| devananda | rloo: i've seen that a few times as a cover for something more serious | 15:02 |
| rloo | http://logs.openstack.org/82/107882/15/check/check-tempest-dsvm-virtual-ironic/b60e5a3/console.html | 15:02 |
| rloo | devananda: recheck ?? | 15:02 |
| rloo | or 'gotta look into it'? | 15:02 |
| *** MattMan has joined #openstack-ironic | 15:03 | |
| devananda | gotta look | 15:03 |
| devananda | rloo: http://logs.openstack.org/96/107096/8/gate/gate-tempest-dsvm-virtual-ironic/2a79841/logs/screen-n-sch.txt.gz?level=DEBUG#_2014-07-23_14_16_22_044 | 15:04 |
| devananda | failed the scheduler | 15:04 |
| devananda | but I dont know why | 15:04 |
| rloo | devananda: that isn't good. did this start happening after some changes were made to the nova-ironic-driver? | 15:05 |
| devananda | checking | 15:08 |
| *** lazy_prince is now known as killer_prince | 15:12 | |
| *** bvivek has quit IRC | 15:17 | |
| devananda | rloo: logstash is behind. I don't see any other examples of that failure though | 15:22 |
| devananda | so it's either random or due to a fairly recent change | 15:22 |
| devananda | rloo: it is the first time I've seen it | 15:22 |
| rloo | devananda: I just saw those two instances. I'll do a recheck no bug then. | 15:22 |
| *** rameshg87 has joined #openstack-ironic | 15:24 | |
| *** pcrews has joined #openstack-ironic | 15:28 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/107882 | 15:31 |
| *** romcheg1 has joined #openstack-ironic | 15:34 | |
| *** romcheg1 has left #openstack-ironic | 15:34 | |
| *** romcheg1 has joined #openstack-ironic | 15:34 | |
| rameshg87 | devananda: request your review on ilo deploy driver spec review: https://review.openstack.org/97744 | 15:35 |
| *** mdorman has joined #openstack-ironic | 15:44 | |
| *** Poornima_ has quit IRC | 15:46 | |
| openstackgerrit | Adam Gandelman proposed a change to openstack/ironic: Generalize exception handling in Nova driver https://review.openstack.org/109022 | 15:48 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Use auth_token from keystonemiddleware https://review.openstack.org/107197 | 15:50 |
| *** ChuckC has joined #openstack-ironic | 15:52 | |
| jroll | mornin y'all | 15:54 |
| *** eghobo has joined #openstack-ironic | 16:00 | |
| *** eghobo has quit IRC | 16:00 | |
| *** eghobo has joined #openstack-ironic | 16:01 | |
| dtantsur | jroll, morning | 16:01 |
| dtantsur | and g'night actually :) | 16:01 |
| jroll | heh | 16:01 |
| jroll | good night! | 16:01 |
| rloo | good night dtantsur! | 16:02 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add migration script to instance_info https://review.openstack.org/96136 | 16:02 |
| devananda | lucasagomes: after I run that ^, do I need to edit the flavor to avoid the nova.virt.ironic driver replacing those params on the next deploy? | 16:05 |
| devananda | where I == a deployer of Juno or Kilo code bases | 16:05 |
| *** dtantsur is now known as dtantsur|afk | 16:06 | |
| *** kpavel has joined #openstack-ironic | 16:06 | |
| lucasagomes | devananda, oh I think that's correct for J, but Kilo we want to remove the backward compat no? so we are going to ignore what's in the flavor | 16:06 |
| lucasagomes | hmm | 16:06 |
| lucasagomes | it's tricky way to migrate really | 16:06 |
| lucasagomes | doesn't seem very helpful | 16:06 |
| devananda | indeed | 16:06 |
| lucasagomes | idk if I should remove it from the flavor as part of the migration script | 16:07 |
| devananda | lucasagomes: seen https://review.openstack.org/#/c/102563/? | 16:07 |
| devananda | lucasagomes: seen https://review.openstack.org/#/c/102563/ ? | 16:07 |
| * lucasagomes clicks | 16:08 | |
| *** matty_dubs is now known as matty_dubs|lunch | 16:12 | |
| lucasagomes | devananda, right uff... wondering if that tool should instead of update the flavor with the deploy kernel and ramdisk for ironic it should update the nodes in Ironic | 16:13 |
| lucasagomes | but still it would need to remove the current extra specs from the baremetal flavors :/ | 16:15 |
| lucasagomes | well I will think over, see if I have some ideas for it... right now it doesn't looks good really | 16:16 |
| lucasagomes | gotta go afk for a while | 16:20 |
| *** lucasagomes is now known as lucas-afk | 16:20 | |
| *** Nisha has joined #openstack-ironic | 16:21 | |
| devananda | https://review.openstack.org/#/c/71557/33 | 16:26 |
| devananda | rloo, lucas-afk - our gate is broken as a result of https://review.openstack.org/#/c/71557/33 | 16:27 |
| rloo | devananda: oh ... ugh... | 16:27 |
| * jroll cries | 16:27 | |
| rloo | devananda: broken cuz that change went in? :-( | 16:28 |
| devananda | yes | 16:28 |
| jroll | check-tempest-dsvm-virtual-ironic-nv FAILURE in 29m 22s (non-voting) | 16:28 |
| jroll | yay. | 16:28 |
| jroll | it would be really really great if nova would let us vote | 16:28 |
| jroll | well... ironic-specs gate isn't broken. could use a +2 here :) https://review.openstack.org/#/c/98506/ | 16:33 |
| *** krtaylor has quit IRC | 16:38 | |
| *** vinbs has joined #openstack-ironic | 16:39 | |
| openstackgerrit | Ghe Rivero proposed a change to openstack/ironic: Raise MissingParameterValue instead of invalid https://review.openstack.org/108455 | 16:40 |
| *** athomas has quit IRC | 16:41 | |
| *** vinbs_ has joined #openstack-ironic | 16:42 | |
| *** killer_prince is now known as lazy_prince | 16:43 | |
| *** vinbs has quit IRC | 16:44 | |
| *** vinbs_ is now known as vinbs | 16:44 | |
| *** vinbs has quit IRC | 16:49 | |
| *** athomas has joined #openstack-ironic | 16:53 | |
| *** jcoufal has quit IRC | 16:54 | |
| *** jcoufal has joined #openstack-ironic | 16:55 | |
| *** matty_dubs|lunch is now known as matty_dubs | 16:56 | |
| *** jcoufal has quit IRC | 16:56 | |
| *** jcoufal has joined #openstack-ironic | 16:57 | |
| *** krtaylor has joined #openstack-ironic | 17:01 | |
| *** rameshg87 has left #openstack-ironic | 17:02 | |
| *** jistr has quit IRC | 17:07 | |
| openstackgerrit | Victor Sergeyev proposed a change to openstack/ironic: Catch oslo.db error instead of sqlalchemy error https://review.openstack.org/108943 | 17:12 |
| *** jgrimm has quit IRC | 17:12 | |
| *** lazy_prince is now known as killer_prince | 17:17 | |
| rloo | lucas-afk or devananda: could one of you set the URL for the spec, for this BP: https://blueprints.launchpad.net/ironic/+spec/new-management-interface | 17:20 |
| *** harlowja_away is now known as harlowja | 17:20 | |
| *** tatyana has joined #openstack-ironic | 17:38 | |
| *** pelix has quit IRC | 17:39 | |
| *** Nisha_ has joined #openstack-ironic | 17:48 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding swift temp url support https://review.openstack.org/81391 | 17:51 |
| *** Nisha has quit IRC | 17:51 | |
| *** tatyana_ has joined #openstack-ironic | 18:01 | |
| *** romcheg1 has quit IRC | 18:02 | |
| *** bvivek has joined #openstack-ironic | 18:02 | |
| *** tatyana has quit IRC | 18:03 | |
| *** tatyana_ is now known as tatyana | 18:03 | |
| *** matty_dubs has quit IRC | 18:09 | |
| *** matty_dubs has joined #openstack-ironic | 18:10 | |
| *** rwsu_ has joined #openstack-ironic | 18:17 | |
| *** matty_dubs has quit IRC | 18:17 | |
| *** tatyana has quit IRC | 18:18 | |
| *** jcoufal has quit IRC | 18:20 | |
| *** jdob has quit IRC | 18:21 | |
| *** rwsu has quit IRC | 18:21 | |
| *** ChuckC has quit IRC | 18:21 | |
| *** derekh_ has quit IRC | 18:21 | |
| *** jcoufal has joined #openstack-ironic | 18:22 | |
| *** ChuckC has joined #openstack-ironic | 18:22 | |
| *** matty_dubs has joined #openstack-ironic | 18:23 | |
| *** jdob has joined #openstack-ironic | 18:28 | |
| *** derekh_ has joined #openstack-ironic | 18:28 | |
| *** eguz has joined #openstack-ironic | 18:33 | |
| *** jgrimm has joined #openstack-ironic | 18:34 | |
| *** jdob has quit IRC | 18:35 | |
| *** eghobo has quit IRC | 18:36 | |
| *** jdob has joined #openstack-ironic | 18:39 | |
| devananda | victor_lowther: https://review.openstack.org/#/c/99318/12 | 18:43 |
| *** rwsu_ is now known as rwsu | 19:01 | |
| *** dkehn_ has joined #openstack-ironic | 19:02 | |
| *** dkehnx has quit IRC | 19:05 | |
| *** jcoufal has quit IRC | 19:15 | |
| *** jcoufal has joined #openstack-ironic | 19:15 | |
| *** jcoufal has quit IRC | 19:16 | |
| *** jcoufal has joined #openstack-ironic | 19:17 | |
| *** rwsu has quit IRC | 19:18 | |
| *** cdent has quit IRC | 19:19 | |
| *** jdob has quit IRC | 19:19 | |
| *** athomas has quit IRC | 19:19 | |
| *** athomas has joined #openstack-ironic | 19:21 | |
| *** dkehn_ is now known as dkehnx | 19:26 | |
| *** Mikhail_D_ltp has joined #openstack-ironic | 19:27 | |
| openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: iLO Node discovery https://review.openstack.org/109088 | 19:27 |
| *** faizan has joined #openstack-ironic | 19:28 | |
| *** jdob has joined #openstack-ironic | 19:28 | |
| openstackgerrit | Nisha Agarwal proposed a change to openstack/ironic-specs: iLO Node discovery https://review.openstack.org/109088 | 19:31 |
| *** rwsu has joined #openstack-ironic | 19:32 | |
| rloo | devananda: any idea what/who/how/when/any update wrt a fix for https://review.openstack.org/#/c/71557/33 | 19:32 |
| devananda | rloo: nova is reverting it | 19:32 |
| rloo | devananda: thx. That's nice of them :-) | 19:32 |
| devananda | https://review.openstack.org/109033 | 19:33 |
| *** fausto has joined #openstack-ironic | 19:33 | |
| devananda | it broke the resource['stats'] interface which libvirt doesn't use, but we (and possibly other virt drivers) do | 19:34 |
| rloo | devananda: you'd think they'd have some sort of deprecation period. sheesh. | 19:34 |
| devananda | rloo: it wasn't obvious - the patch didn't claim to do that | 19:34 |
| rloo | [I'm sure ironic will do unintentional stuff like that too in the future...] | 19:35 |
| devananda | we brke the seamicro driver once :( | 19:35 |
| rloo | oh yeah... | 19:36 |
| rloo | devananda: are we trying to get stuff in for j2 still? Do you know the cutoff date/time? | 19:37 |
| devananda | rloo: I should be tagging it today, but with our gate broken, I might push it a bit | 19:37 |
| devananda | either that or we tag it now, basically | 19:37 |
| rloo | devananda: let me know either way. so I can prioritize what I review or not review anything for a bit ;) | 19:38 |
| devananda | rloo: I'd say keep reviewing the things which you'd like to land soon :) | 19:39 |
| rloo | devananda: sure. Me and my army! | 19:39 |
| devananda | jroll: you reviweing too, right? ;) | 19:39 |
| jroll | hi wat | 19:40 |
| * rloo hopes jroll isn't still crying | 19:40 | |
| * jroll reads | 19:40 | |
| jroll | I'm still crying... about other things :) | 19:40 |
| devananda | jroll: oh. what did I miss? | 19:40 |
| JayF | Running a large ironic installation ;) | 19:40 |
| jroll | lol | 19:40 |
| jroll | devananda: what do you want me reviewing? | 19:40 |
| JayF | we're wrestling the power status loop, like a bear | 19:40 |
| jroll | oh, ironic | 19:40 |
| JayF | rawr | 19:40 |
| * jroll sees | 19:40 | |
| rloo | oh, jroll is crying cuz he's happy! | 19:41 |
| devananda | jroll: things which are targeted to land in J2 | 19:41 |
| jroll | LOL | 19:41 |
| jroll | deva, right | 19:41 |
| jroll | devananda: since you're here... if the power status check loop overruns its 60 seconds... what kind of behavior might we see? | 19:41 |
| devananda | jroll: I think that's the iPXE driver, rloo's API changes, and lucas' management changes | 19:41 |
| devananda | jroll: the periodic job? | 19:41 |
| jroll | will it keep running over, or get killed and executed next time, or? | 19:41 |
| jroll | yes | 19:41 |
| devananda | eehhhh lemme see | 19:42 |
| devananda | i remember nova fixed something with their periodic jobs a while back | 19:42 |
| jroll | tldr, I have 11 nodes with responsive BMCs that have incorrect power state in the db :) | 19:42 |
| rloo | devananda, jroll: my API change was approved just not merged. And there's a CLI related but it is still WIP until the ironic changes are in. | 19:42 |
| devananda | rloo: so, why is that WIP? | 19:42 |
| rloo | devananda: can it go it before the code is in ironic? | 19:43 |
| devananda | rloo: we should be able to auto-discover features in the API, or at least write the client in such a way that it doesn't explode if a feature isn't present | 19:43 |
| devananda | rloo: why not? | 19:43 |
| rloo | devananda: dunno. thought it had to wait. | 19:43 |
| devananda | rloo: think about what happens when someone points your new client at an old deployment of ironic | 19:43 |
| devananda | rloo: it should still work (just not do the new thing) right? | 19:43 |
| devananda | i mean, in principle. i haven't reviewed it yet | 19:44 |
| rloo | devananda: oh, you want me to think? it probably returns some sort of error. good enough? :-) I'll check. Guess I will stop reviewing for a bit. | 19:44 |
| rloo | jroll: wrt lucas' mgt stuff, this is the next one in the series: https://review.openstack.org/#/c/86588/ | 19:44 |
| jroll | rloo: yeah, I'll take a look later... a bit occupied right now :) | 19:44 |
| rloo | devananda: but the client stuff isn't under the same j2 deadline. so maybe i'll review a bit more first ;) | 19:45 |
| *** Mikhail_D_ltp has quit IRC | 19:54 | |
| JayF | devananda: dig anything up re: the power status check loop? We're still digging over here | 20:00 |
| devananda | JayF: sorry. distracted. what are you finding? | 20:00 |
| JayF | I can tell you the end state and that we haven't nailed down a cause :) | 20:00 |
| devananda | great. what's the end? | 20:01 |
| JayF | up to around 500 nodes, 2 conductors | 20:01 |
| JayF | we have 11 servers (at least) with a power state mismatch in the DB (db says off, bmc says on) | 20:01 |
| devananda | what's the run time of that loop? | 20:01 |
| JayF | and we have reason to believe (from not finding those nodes' BMC IPs in the logs) that the power status loop is not making it around to them | 20:01 |
| devananda | ahhh | 20:01 |
| devananda | cool! | 20:01 |
| devananda | so | 20:01 |
| JayF | we don't see LOG.debug(_("Running periodic task %(full_task_name)s"), in our logs anywhere either, running in full debug mode | 20:02 |
| devananda | JayF: is it logging when that method starts? | 20:02 |
| devananda | huh :( | 20:02 |
| JayF | devananda: doesn't appear to be | 20:02 |
| *** bvivek has quit IRC | 20:08 | |
| *** kpavel has quit IRC | 20:09 | |
| devananda | JayF: try adding logging at conductor manager L 640 | 20:10 |
| devananda | JayF: inside the actual _sync_power_state method | 20:10 |
| devananda | JayF: also, try increasing the sync_power_state_interval setting | 20:10 |
| JayF | devananda: 10-4, I'll let you know how it goes | 20:13 |
| JayF | I think we'll add logging first; then look at the setting | 20:13 |
| *** faizan has quit IRC | 20:14 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Update_port should expect MACAlreadyExists https://review.openstack.org/109107 | 20:22 |
| *** Nisha_ has quit IRC | 20:24 | |
| *** ChuckC has quit IRC | 20:26 | |
| *** jdob has quit IRC | 20:27 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface https://review.openstack.org/86588 | 20:29 |
| devananda | heading out to dinner, will poke at reviews later | 20:30 |
| devananda | https://review.openstack.org/#/c/109033/ is still in nova's check queue, and our gate's blocked until that lands | 20:30 |
| *** derekh_ has quit IRC | 20:30 | |
| *** rwsu has quit IRC | 20:32 | |
| rloo | enjoy devananda. Hopefully the gate will be wide open when you get back. | 20:34 |
| -openstackstatus- NOTICE: nodepool is unable to build test nodes so check and gate tests are delayed | 20:40 | |
| *** ChanServ changes topic to "nodepool is unable to build test nodes so check and gate tests are delayed" | 20:40 | |
| *** chuckC has joined #openstack-ironic | 20:41 | |
| *** jcoufal has quit IRC | 20:44 | |
| *** krtaylor has quit IRC | 20:57 | |
| *** mrda-away is now known as mrda | 20:57 | |
| mrda | Morning Ironic! | 20:58 |
| openstackgerrit | Ruby Loo proposed a change to openstack/python-ironicclient: Add driver-properties command https://review.openstack.org/76338 | 21:00 |
| rloo | morning mrda! | 21:00 |
| mrda | hi rloo | 21:01 |
| *** athomas has quit IRC | 21:02 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/python-ironicclient: Add driver-properties command https://review.openstack.org/76338 | 21:02 |
| mrda | rloo: I see you've been caught up in the ironicclient client export sag. Thanks for your eyeballs :) | 21:05 |
| rloo | mrda. yw. and I thought it'd be a simple +2 ;) | 21:06 |
| mrda | Once I have some breakfast I'll look into it | 21:07 |
| *** fausto has quit IRC | 21:28 | |
| *** dkehn_ has joined #openstack-ironic | 21:43 | |
| *** dkehnx has quit IRC | 21:46 | |
| *** matty_dubs is now known as matty_dubs|gone | 21:48 | |
| *** dkehn_ is now known as dkehnx | 21:52 | |
| *** wanyen has joined #openstack-ironic | 21:55 | |
| wanyen | Per suggestion from last week’s IRC discussion, we have re-factored iLO virtual Media Deploy driver into the following specs: Move code to cleanup ImageCache to a common place https://review.openstack.org/#/c/107996/, iLO Virtual Media iSCSI Deploy Driver https://review.openstack.org/#/c/97744/, iLO IPA Deploy driver https://review.openstack.org/#/c/108445/. Please reviw them as soon as you can. Thanks! | 21:59 |
| -openstackstatus- NOTICE: zuul is working through a backlog of jobs due to an earlier problem with nodepool | 22:06 | |
| *** ChanServ changes topic to "zuul is working through a backlog of jobs due to an earlier problem with nodepool" | 22:06 | |
| *** wanyen has quit IRC | 22:09 | |
| *** shakamunyi has joined #openstack-ironic | 22:10 | |
| *** shakamunyi has quit IRC | 22:15 | |
| *** jgrimm has quit IRC | 22:22 | |
| *** shakamunyi has joined #openstack-ironic | 22:34 | |
| mikal | devananda: is bug https://bugs.launchpad.net/nova/+bug/1347795 the nova problem? | 23:20 |
| *** lucas-afk has quit IRC | 23:21 | |
| *** eguz has quit IRC | 23:36 | |
| mrda | rloo: So I commented on https://review.openstack.org/#/c/108974/ I'm not sure we we actually export the symbols we want | 23:56 |
| *** shakamunyi has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!