Thursday, 2014-07-24

*** killer_prince has quit IRC00:22
rloomrda: ha (or sob). I haven't yet gotten around to looking at the latest revision of the patch that 108974 is needed for.00:22
mrdayeah, me neither.  Currently chasing red herrings all around the floor here.00:26
*** derekh_ has joined #openstack-ironic00:28
rloomikal, 1347795 is a nova problem that is breaking things for tripleo and ironic. devananda said that this will fix (revert) so we're waiting... https://review.openstack.org/#/c/109033/00:34
rloomikal: I see from 1347795 that you probably got the info you wanted.00:35
mikalrloo: yeah, but the revert wasn't linked to the bug00:36
mikalSo I had trouble finding it00:36
mikalI did get there in the end though00:36
rloomikal: not sure why it wasn't linked to the bug in the first place but glad you found it!00:37
mikalrloo: the tag in the commit message is wrong is the problem00:37
rloomikal: yeah, just looked. Fixes-bug should be an alias to closes-bug!00:37
mikalrloo: I dare you to propose a patch to jeepyb to do that... They'd take it I think.00:38
JayFdevananda: tl;dr update from the issue we were looking at: we removed about 10 bad BMCs from that group of servers, and the power status loop started working better. Still taking on the realm of 3-5 minutes to run. I think comstud has a patch coming that will add some parallellism to that.00:38
comstudJayF, devananda: yes00:38
rloomikal: I learned many years ago, how to deal with dares. I ignore them. double-dares too ;)00:38
harlowjarloo is very wise00:39
JayFNow when I was a kid, I loved double-dare. Marc Summers was CRAZY! /s00:39
rlooalthough I suppose someone could submit a bug/wishlist thingy.00:39
comstudJayF, devananda: Essentially looking at something like this: http://paste.openstack.org/show/87861/00:40
mikalrloo: dammit00:42
mikalrloo: management by goading is all I've got00:42
mikalrloo: it would be impossible to handle to differnt but tags, totally impossible.00:43
rloomikal, how does mrda feel about that? :D00:43
mikalrloo: ^-- let's see how that one works00:43
*** shakamunyi has joined #openstack-ironic00:43
comstudmikal: when you gonna start helping with OnMetal, mann?00:43
mikalrloo: there is a high risk mrda will stab me in the neck with a pen sometime in the next week00:43
mikalcomstud: I am helping by stay a safe distance away00:43
comstud:)00:43
jrolllol00:44
* JayF adds mikal to the oncall rotation under 'third shift'00:44
rloohmm, there might be more excitement at the meetup next week than I had thought. sorry I'm not going now ;)00:45
mikalI am so busy that I am sure that if I signed up for anything I'd just be lying about my actual ability to contribute00:45
mikalI'm therefore setting expectations low00:46
JayFThe best way you can help onmetal is by merging the Ironic -> Nova virt driver00:46
JayF;)00:46
mrdamikal and rloo: there will be no stabbing, just rage quitting00:46
mikalJayF: so, that would require mrda's patches to ironic to merge00:46
rlooto be fair, mikal is helping. he's reviewed and provided comments.00:46
mikalJayF: so you should review those...00:46
* mrda appreciates mikal's reviews00:46
JayFI'm just kidding, mostly :)00:46
mikalI have also helped by not rage quitting00:47
mikalWhich has taken a lot of cups of tea00:47
jroll"tea"00:47
mikalHeh00:51
mikalI dunno why, but I've been in a wine mood recently00:52
mrdaso tl;dr, everyone go review 107882 and 108872.  Please :)00:52
mikalOld age perhaps00:52
mrdaI think it's spent 'whine', mikal00:54
mrdas/spent/spelt/00:54
mrda:-P00:54
rloos/spelt/spelled/00:54
rlooor did you mean spilt milk?00:54
mikalUgh01:00
mikalYou're driving me to Earl Gray here01:00
rloook, I looked at 108872. Just needs another +2 on it. Not sure I'll get to 107882 tonight, it doesn't seem like bedtime reading to me.01:03
*** Haomeng|2 has joined #openstack-ironic01:04
*** Haomeng has quit IRC01:05
mrdarloo: you are quite picky with your spelling, for an American.  I see hardly any stray z's or missing u's :)01:10
rloomrda. Maybe that's cuz I'm not an American.01:11
mrdathat explains it! :)01:11
rloomrda. Are you saying Americans can't spell. I know they cannot pronounce the letter z and they have other quirks but...01:11
mrdait's just the random substitution of z's for s's, and mostly the desire to drop u's out of words01:12
rloomrda. ha ha. yes, that's true.01:12
mrdaand I don't understand how 'caramel' can be pronounced as 'carmel'01:13
mikalI fixed a bug in nova the other day that was caused by an extra u01:13
mikalThe queen's english strieks again01:13
mrdastrieks?  Or shrieks?01:24
*** Haomeng|2 has quit IRC01:37
*** nosnos has joined #openstack-ironic01:43
rloomrda: I have a few minutes now. Are you OK with 107882? I don't want to look if you aren't.01:45
mrdaI always have time for you rloo :)01:46
mrdaI'm just lookin as to why the check-tempest-dvsm-virtual-ironic is afiling01:47
mrda^failing01:47
rlooha ha mrda. it looks like deva made changes to 107882. are you all ok with how the client is being imported etc?01:47
mrdaSo yes, it appears to be working (but was so my __import__ techniaue too :)01:47
mrdaIt's a good workaround until we can get those symbols exported from ironicclient01:48
rloomrda: so once those symbols are exported from ironicclient, then another change needs to be made?01:48
mrdawe have a python core contributor on my team, who unfortunately is at EuroPython right now.  but once he reappears I'll work out how to fix ironicclient01:48
mrdarloo: yes, we can unwind the hasattr01:49
mrdaor maybe not, because otherwise old ironicclients won't work01:49
mrdaso it'll have to stay for a while01:49
rloomrda: unwind in both nova/ironic trees?01:49
mrdaI still would like to fix ironicclient though01:49
*** jcoufal has joined #openstack-ironic01:49
mrdarloo: well, I think we leave it as is.  There's no harm in deva's solution remaining there as is01:50
rloomrda: just wondering if we can fix ironicclient soon, and have the 'right' solution in the driver soon. or if we need to go with the temporary solution in the driver now.01:50
mrdaso the summary is that we can go ahead with it as is01:50
rloomrda. ok, i'll look at the review then ;)01:51
mrdaI think we leave it there and just go ahead.  Old ironicclient's will still need support, for a hile, so it has to stay as is01:51
mrdathanks rloo - appreciated!01:51
rlooerr, i guess i'll review the patch then.01:51
mrdain the mean time, I'll look at -dvsm-virtual-ironic01:51
rloomrda: those tests are failing due to nova. unless they're failing for another reason too.01:52
rloomrda: waiting for https://review.openstack.org/#/c/109033/ to land.01:52
mrdaoh, I thought that had merged already01:52
* mrda looks01:52
rloomrda. you can take a break and have some tea then :-)01:52
mrdalol, coffee for me :)01:53
mrdaAnd there's still other nova ironic stuff to do anyways01:53
mrdathanks rloo for your help!01:54
rloomrda, glad to know you have stuff to do ;)01:54
rlooyw mrda01:54
* mrda notes that 109033 won't get through gate for another 30 mins at least01:55
*** mdorman has quit IRC02:29
*** killer_prince has joined #openstack-ironic02:33
*** killer_prince is now known as lazy_prince02:33
*** rloo has quit IRC02:43
*** pcrews has quit IRC02:45
*** vinbs has joined #openstack-ironic02:59
*** ramineni has joined #openstack-ironic03:02
*** derekh_ has quit IRC03:09
*** nosnos has quit IRC03:15
*** viktors|afk has quit IRC03:54
*** krtaylor has joined #openstack-ironic04:17
*** nosnos has joined #openstack-ironic04:18
*** lazy_prince is now known as killer_prince04:21
*** Poornima_ has joined #openstack-ironic04:26
*** eghobo has joined #openstack-ironic04:36
mikalhttps://review.openstack.org/#/c/109033 failed to merge05:03
openstackgerritMichael Davies proposed a change to openstack/ironic: Import fixes from the Nova driver reviews  https://review.openstack.org/10788205:03
mrdamikal: I cried when I saw that05:05
*** harlowja has quit IRC05:11
*** harlowja has joined #openstack-ironic05:11
*** eghobo has quit IRC05:19
*** k4n0 has joined #openstack-ironic05:24
*** bvivek has joined #openstack-ironic05:27
*** eghobo has joined #openstack-ironic05:29
openstackgerritMichael Davies proposed a change to openstack/ironic: Backporting nova host manager changes into ironic  https://review.openstack.org/10887205:35
mrdadevananda: Just on 103165 - I included Mikyung and Kurt because of their contributions to baremetal_host_manager.py ion the nova tree, which is a predecessor of the {base_baremetal, baremetal, and ironic}_host_manager.py in our tree05:38
*** rameshg87 has joined #openstack-ironic05:39
*** rakesh_hs has joined #openstack-ironic05:43
*** dkehn_ has joined #openstack-ironic05:45
*** dkehn__ has joined #openstack-ironic05:47
*** bmahalakshmi has joined #openstack-ironic05:47
*** dkehnx has quit IRC05:49
*** dkehn_ has quit IRC05:51
*** marios has quit IRC05:59
*** marios has joined #openstack-ironic06:02
*** Halacs has joined #openstack-ironic06:08
*** eghobo has quit IRC06:10
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/10890106:10
*** zigo has quit IRC06:27
rameshg87JoshNang: hi06:29
JoshNangrameshg87: hey, what's up?06:29
rameshg87JoshNang: :-)06:30
*** mitz has quit IRC06:30
rameshg87JoshNang: going good. how are you ?06:30
rameshg87JoshNang: had a question regarding the devstack script in ironic which creates the virsh baremetal vms for testing.06:31
rameshg87JoshNang: do you use this ?06:31
JoshNangpretty good!06:31
JoshNangi haven't really. i'm planning to mess with it in the next couple days06:31
*** mitz has joined #openstack-ironic06:32
rameshg87JoshNang: okay.06:32
rameshg87JoshNang: i was just trying out this: http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack06:32
*** zigo has joined #openstack-ironic06:32
rameshg87JoshNang: ends up in some issues for me.  i had some doubts on how this works.06:32
*** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic"06:33
rameshg87JoshNang: looks like lucasagomes wrote these. i think i can check with him then..06:33
JoshNangrameshg87: what issues are you having?06:34
rameshg87JoshNang: i tried to deploy a vm with pxe_ssh driver (as mentioned in the guide above)06:35
rameshg87JoshNang: the virsh vms are connected to a ovs bridge brbm06:36
rameshg87JoshNang: while n-dhcp of neutron is listening on br-int06:36
rameshg87JoshNang: this says brbm and br-int are connected - https://github.com/openstack-dev/devstack/blob/master/lib/ironic#L38206:36
*** Mikhail_D_ltp has joined #openstack-ironic06:36
rameshg87JoshNang: but unfortunately the pxe boot request from virsh vms doesn't go to n-dhcp, and pxe boot fails06:37
*** killer_prince is now known as lazy_prince06:37
JoshNanghmmmm. i can't say i've ever had that problem unfortuantely06:37
rameshg87JoshNang: hmm..okay06:38
rameshg87JoshNang: let me try hard if i can see something else ..06:38
*** viktors has joined #openstack-ironic06:40
*** harlowja is now known as harlowja_away06:42
JoshNangrameshg87: i'm gonna head to bed...early morning tomorrow. i'll be testing some stuff in devstack in the next couple days, so if you don't find a solution soon, maybe i'll be able to help more06:47
rameshg87JoshNang: thanks :-)06:47
rameshg87JoshNang: will continue to look more and ping you if i am still stuck up with issues06:48
JoshNangkk! good luck!06:48
*** shakamunyi has quit IRC07:03
*** jcoufal has quit IRC07:16
*** bvivek has quit IRC07:23
*** jistr has joined #openstack-ironic07:24
*** yuriyz has quit IRC07:25
*** krtaylor has quit IRC07:25
mrdaNight all08:05
*** mrda is now known as mrda-away08:05
*** romcheg1 has joined #openstack-ironic08:09
*** yuriyz has joined #openstack-ironic08:11
*** kpavel has joined #openstack-ironic08:15
*** pelix has joined #openstack-ironic08:23
*** lucasagomes has joined #openstack-ironic08:23
dtantsur|afkMorning, Ironic!08:23
*** dtantsur|afk is now known as dtantsur08:23
*** bvivek has joined #openstack-ironic08:25
jrollI know I'm up too late when I can say good morning to dtantsur :p08:50
dtantsurlol08:50
dtantsurg'evening, jroll, what's the time for you?08:50
romcheg1dtantsur: I think it's almost morning for jroll too :)08:51
jrollapproaching 2am, ha08:51
romcheg1Morning guys btw :)08:51
jrollheya romcheg108:51
dtantsurromcheg1, morning :)08:52
*** martyntaylor has joined #openstack-ironic09:20
*** kpavel has quit IRC09:38
*** Poornima_ has quit IRC09:46
*** foexle has joined #openstack-ironic09:46
*** datajerk has quit IRC09:49
*** datajerk has joined #openstack-ironic09:49
*** k4n0 has quit IRC10:07
*** romcheg1 has quit IRC10:08
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Expose {set,get}_boot_device in the API  https://review.openstack.org/9015110:12
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: SSH virsh to use the new ManagementInterface  https://review.openstack.org/8988410:12
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface  https://review.openstack.org/8658810:12
*** k4n0 has joined #openstack-ironic10:21
*** jbjohnso has quit IRC10:26
*** jbjohnso has joined #openstack-ironic10:26
*** krtaylor has joined #openstack-ironic10:33
*** jbjohnso has quit IRC10:47
*** jbjohnso has joined #openstack-ironic10:48
*** martyntaylor has left #openstack-ironic10:53
*** vinbs has quit IRC10:56
*** Alexei_9871 has joined #openstack-ironic10:58
*** harlowja_away has quit IRC10:59
*** Poornima_ has joined #openstack-ironic10:59
*** k4n0 has quit IRC11:01
*** ramineni has quit IRC11:02
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Clean up calls to get_chassis()  https://review.openstack.org/10895911:05
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Clean up calls to get_port()  https://review.openstack.org/10925211:05
rameshg87dtantsur: hi11:08
dtantsurrameshg87, hi11:08
*** vdrok has joined #openstack-ironic11:08
rameshg87dtantsur: i just encountered something which is thrown as a warning, but i feel it should be an error and should be caught in validate11:09
rameshg87dtantsur: https://github.com/openstack/ironic/blob/master/ironic/common/neutron.py#L148-L15311:09
rameshg87dtantsur: the code that updates neutron with the dhcp options when provisioning with pxe11:09
rameshg87dtantsur: shouldn't it be error, because unless we update neutron, the pxe boot is not going to work, right ?11:09
dtantsurrameshg87, not sure, but likely yes11:10
*** jcoufal has joined #openstack-ironic11:11
rameshg87dtantsur: i feel we should validate atleast one of the ironic ports have a vif_port_id set11:11
*** Poornima_ has quit IRC11:14
dtantsurbrb11:16
*** vdrok has quit IRC11:18
*** vdrok_ has joined #openstack-ironic11:18
*** k4n0 has joined #openstack-ironic11:19
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer  https://review.openstack.org/7253811:23
*** bvivek has quit IRC11:30
*** marzif has joined #openstack-ironic11:32
*** Poornima_ has joined #openstack-ironic11:40
*** lucasagomes is now known as lucas-hungry11:42
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer  https://review.openstack.org/7253811:50
*** bmahalakshmi has quit IRC11:54
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer  https://review.openstack.org/7253811:55
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer  https://review.openstack.org/7253811:56
*** k4n0 has quit IRC11:59
*** cdent has joined #openstack-ironic12:00
*** chuckC has quit IRC12:07
*** nosnos has quit IRC12:09
*** jcoufal has quit IRC12:19
*** cdent_ has joined #openstack-ironic12:21
*** rameshg87 has left #openstack-ironic12:22
*** cdent has quit IRC12:22
*** cdent_ is now known as cdent12:22
mariosdtantsur: hey bud12:35
dtantsurmarios, hi12:35
mariosdtantsur: so following http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack12:35
mariosdevtest completes fine, everything running ok12:35
marioscan't deploy instance (as per the instructions there) with baremetal flavor12:36
mariosimmediately goes to ERROR state12:36
dtantsurmarios, what ironic node-show shows about node? what nova show shows about instance?12:36
mariosdtantsur: ironic nodes are all powered-off12:37
mariosdtantsur: just wondering if you had seen this before mate (i am using one of our beaker boxes in brno for this)12:37
dtantsurmarios, I know quite a few reasons for this behavior, so trying to figure out which one you have :)12:38
dtantsurmarios, or you can give me access to the box and I'll investigate myself12:39
mariosdtantsur: i had a quick look through the screen sessions for n-cpu/i-api etc but couldn't see something obvious there12:39
dtantsurmarios, ir-cond logs are much more important12:40
dtantsurwell, may be12:40
*** ChuckC has joined #openstack-ironic12:40
mariosdtantsur: ah didn't check that, going to try it again and watch the log12:40
dtantsurmarios, also before trying to deploy anything, you may try ironic set-node-power-state on, that's a bit easier to check12:41
*** lucas-hungry is now known as lucasagomes12:41
dtantsuryou'll at least know, whether the driver can manager power12:41
lucasagomesyeah ir-cond logs12:41
lucasagomesalso our gate is broken due a change in nova12:41
dtantsurmarios, even before, try ironic node-validate on a node12:41
mariosdtantsur: great thanks will try this all12:42
lucasagomesthat may be the cause of the error as well (the gate does pretty much the same steps there ^)12:42
*** Poornima_ has quit IRC12:42
dtantsurlucasagomes, oh, makes a lot of sense12:43
lucasagomesyeah, it might worth try to reset nova12:43
lucasagomesto the commit before that change (will grab the link)12:43
lucasagomesand then run it12:43
lucasagomeshttps://review.openstack.org/#/c/71557/33 that's the commit that broke us12:44
lucasagomesmarios, ^12:44
marioslucasagomes: thx bud12:44
lucasagomesno worries12:44
*** jdob has joined #openstack-ironic12:48
*** rloo has joined #openstack-ironic13:00
*** zigo has quit IRC13:03
*** jcoufal has joined #openstack-ironic13:03
*** jcoufal has quit IRC13:04
*** zigo has joined #openstack-ironic13:04
*** jcoufal has joined #openstack-ironic13:07
*** athomas has joined #openstack-ironic13:07
*** _dguerri is now known as dguerri13:08
openstackgerritHaomeng,Wang proposed a change to openstack/ironic: Implements send-data-to-ceilometer  https://review.openstack.org/7253813:10
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Fix nodes left in an incosistent state if no workers  https://review.openstack.org/10095813:10
lucasagomesShrews, ^ had totally forgot to test it before... I left a comment with my findings inline13:10
jrollhey y'all... today is spec freeze day. gotta land https://review.openstack.org/#/c/98506/13:11
Shrewslucasagomes: ah, i'd forgotten about that  :)13:11
lucasagomesShrews, yeah me too, I just saw it and decided to give it a go here locally13:12
lucasagomesit works fine13:12
lucasagomesif u wanna try just register some machines and set the workers_pool_size=1 in the ironic.conf13:13
lucasagomesthen try to boot machine13:13
lucasagomess/boot/deploy13:13
*** matty_dubs|gone is now known as matty_dubs13:13
lucasagomesShrews, and cleaning the instance_uuid won't free the resources in nova13:14
rloojroll: I thought today was the deadline for any new specs. hmm, let me check.13:14
lucasagomesShrews, we need to deleted the failed instance in nova in order to free those13:14
jrollrloo: oh, maybe, idk13:14
lucasagomesrloo, yeah it's for new ones13:14
jrollrloo: we want to land the code next week, so in any case that spec needs to get through13:14
lucasagomesbut we gotta merge that anyway :)13:14
rloojroll: https://etherpad.openstack.org/p/3sxKH2po1o. "new spec proposal freeze"13:15
jroll:)13:15
marioslucasagomes: so, reverting nova has helped (nova list says 'spawning now', before was immediately error).13:15
lucasagomesmarios, ack... but it's stuck on the spawning ?13:15
lucasagomesor did you go through it?13:15
rloojroll: yeah, that and the swift url thing is on my list to look at today. although the quality of my reviews seems to be deteriorating. I think I need a break...13:15
mariosACTIVE \o/ thanks man13:15
lucasagomesmarios, :) no bothers13:15
lucasagomesyw13:15
jrollrloo: thanks :)13:15
lucasagomesmarios, that change in nova is being reverted because it also break nova bm13:16
lucasagomesand consequently tripleO13:16
mariosic13:16
devanandamorning, all13:16
lucasagomesdevananda, morning13:17
rloomorning devananda.13:17
*** dkehn__ is now known as dkehnx13:17
*** athomas has quit IRC13:21
NobodyCamgood morning Ironic13:24
lucasagomesmorning NobodyCam13:25
NobodyCam:) moring lucasagomes13:25
dtantsurNobodyCam, morning13:25
jrollmornin devananda13:25
NobodyCamjust walking up slowly and John out the door, on his way to the airport :-p13:25
NobodyCammornig dtantsur and jroll too :)13:26
dtantsurdevananda, jroll, rloo, morning as well13:26
rloomorning dtantsur and all Ironickers out there :)13:27
NobodyCamya morning rloo :)13:27
rlooincluding NobodyCam!13:27
NobodyCamhheeheh :)13:27
devanandaNobodyCam: g'morning!13:28
devanandaNobodyCam: also, wow, I forget how long it takes to get anywhere from the peninsula :(13:28
NobodyCamlol :)13:29
NobodyCamya13:29
jrollwhich peninsula?13:30
NobodyCamdevananda: are you on a red eye tonight?13:30
devanandaNobodyCam: no. I fly out of Raleigh in ~5hr, get in around 9pm13:30
NobodyCam:)13:30
NobodyCamJohns the Hilton?13:31
NobodyCamgah13:31
NobodyCamJohn at the hilton,13:32
NobodyCamhe like me to ask what time it all starts tomorrow?13:32
devanandaJohn's THE hilton sounds so much better :p13:32
NobodyCamlol13:32
devanandaNobodyCam: 8am13:32
NobodyCamack so will make sure his alarms are set befor leaving13:33
NobodyCam:)13:35
*** vdrok_ has quit IRC13:37
*** cflaskerud has joined #openstack-ironic13:41
NobodyCamjroll: olympic peninsula13:41
rlooJoshNang: if you get this, could you please set the url for the spec for your bp:  https://blueprints.launchpad.net/ironic/+spec/swift-temp-urls13:48
JoshNangrloo: np!13:50
rloothx JoshNang. (what are you doing up so early.)13:50
*** eghobo has joined #openstack-ironic13:50
Shrewsrloo: was there a bug for the nova revert that we could use for recheck?13:54
rlooShrews: yup. sec13:54
rloohttps://bugs.launchpad.net/ironic/+bug/134779513:54
rloo^^ Shrews.13:54
Shrewsrloo: gracias13:54
rlooShrews: but the patch didn't merge yet.13:55
Shrewsoh poo13:55
rlooShrews: so I don't see any reason to do a recheck. it'll still fail.13:55
JoshNangrloo: updated with the spec url and fixed the description to be more relevant13:55
JoshNang(getting an early start this morning)13:55
Shrewsrloo: ok. i was in and out yesterday dealing with a home situation, so i'm not fully up to speed on it. thx13:55
rlooShrews: looks like the patch needs to be rebased. So another day lost. And in the bug, someone says that the undo will fix the ci but there's a problem with the code still.13:56
rlooShrews. I've tried to keep our IronicWhiteBoard up-to-date. Sort of ;)13:56
Shrewsah, will read13:56
devanandaso don't bother rechecking yet13:57
devanandathe fix hasn't landed in nova yet and our tests are guaranteed to fail until it does13:58
Shrewspassing dicts of info around is destined for failure. that should be a proper object13:58
rloodevananda, Shrews: I just updated the etherpad to say don't bother to recheck ;)13:58
Shrewsobject == contract == less breakage13:59
rloothx JoshNang! Gonna review your patch soon...14:01
*** cflaskerud has left #openstack-ironic14:02
devanandaShrews: ++14:02
*** pcrews has joined #openstack-ironic14:03
*** eghobo has quit IRC14:08
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Add Conductor.discovery_driver field  https://review.openstack.org/10930414:14
JoshNangrloo: thanks! :)14:17
*** rakesh_hs has quit IRC14:22
*** jgrimm has joined #openstack-ironic14:26
*** rwsu has joined #openstack-ironic14:28
*** derekh_ has joined #openstack-ironic14:29
*** shakamunyi has joined #openstack-ironic14:31
ShrewsCan anyone explain the pep8 logic that says this import ordering makes sense? https://review.openstack.org/#/c/108872/4/ironic/nova/tests/scheduler/test_ironic_host_manager.py14:43
devanandaShrews: yes. if you s/ironic.nova/nova/ then it makes sense14:44
devanandaShrews: we aren't running pep8 on the nova code in our tree14:44
Shrewsdevananda: ok, makes sense with the substitution14:45
Shrewsand since you just +A'd it, i guess i no longer need to keep reviewing it  :)14:45
devanandaso I'm +A'ing several things, knowing that they won't pass right now14:46
NobodyCamack14:46
devanandanot until 109033 merges in Nova14:46
devanandathen we can reverify bug 1347795 on lots of things14:47
NobodyCam+++14:47
devanandaI'll be on a plane for ~10 hours, so want to get things in a state ya'll can finish merging them14:47
Shrews"ya'll"?  devananda, you've been in NC too long.  LOL14:47
devanandalol14:47
NobodyCamlol14:48
jrollnah, he would know it's spelled "y'all" if he had been there too long :P14:48
Shrewsif he knew what "you'uns" was, i'd be worried14:48
*** foexle has quit IRC14:48
devanandaShrews: that takes entirely too many letters14:48
jrollJayF taught me about "bo-fum" yesterday14:49
JayFyep because when you're fixing two things14:50
JayFyou gotta write configs to bo-fum14:50
*** romcheg1 has joined #openstack-ironic14:52
*** shakamunyi has quit IRC14:53
ShrewsJayF: that's again as much work to change bo-fum14:53
openstackgerritDmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Implement conductor part of hardware discovery  https://review.openstack.org/10931214:53
*** Mikhail_D_ltp has quit IRC14:54
dtantsurfolks, what are you talking about? :)14:54
Shrewslol14:55
*** dguerri is now known as _dguerri15:02
*** MattMan has quit IRC15:03
* rloo is happy to be an ironicker. Gets to learn stuff like bofum.15:04
*** MattMan has joined #openstack-ironic15:04
NobodyCam:)15:04
*** _dguerri is now known as dguerri15:07
*** lazy_prince is now known as killer_prince15:07
devanandarloo: testing your client change against an api server w/o the new api15:17
devanandarloo: i get this: Not Found (HTTP 404)15:17
devanandawhich isn't terrible, but wondering if we should do something a little mroe helpful for the client15:17
devanandaso, regarding our J2 milestone15:23
devanandaI'm holding off on tagging it until either: 109033 lands to fix our gate, and we land a bunch of outstanding fixes. OR Friday afternoon, which ever comes first.15:23
jrollonmetal just went live :)15:24
devanandajroll: \o/15:24
jrolly'all should try ironic in production15:24
JayFhttp://www.rackspace.com/blog/onmetal-shows-phenomenal-performance-in-early-benchmarks/ && http://www.marketwired.com/press-release/rackspace-announces-onmetal-cloud-servers-general-availability-and-pricing-nyse-rax-1932532.htm15:24
*** mdorman has joined #openstack-ironic15:24
comstuddevananda: your thing is a thing15:24
comstudnot that it wasn't a thing before15:24
jrolldevananda: right back at ya ^15:24
*** jistr has quit IRC15:24
JayFNow for the philosophical question: is true graduation productization?15:25
JayF:P15:25
jrolllol15:25
lucasagomeso/ nice one15:25
*** pradipta_away has quit IRC15:25
devanandacomstud: that's fantastic. I love that you have made my thing a thing.15:25
comstud:)15:25
devanandaJayF: no. but it further lends credence to the argument I've been making that graduation has NOTHING to do with quality of code or who in the community is (or should be) using what15:25
devanandaintegration is part of the development workflow, NOT a product statement15:26
devanandathough, today, it's often seen that way externally15:26
devanandaI want to decouple that15:26
NobodyCamjroll: awesome-ness \o/15:27
rlooJayF, comstud, jroll, JoshNang, etc: congrats!15:27
JoshNangrloo: thanks!15:27
comstudty15:27
JoshNangrloo: also, working on your comments on swift right now15:27
jrollthanks :)15:27
jrolllook at that15:27
comstudnow.. we do have some performance things to work on :)15:27
jrollcelebrating with an ironic patch15:27
lucasagomes:D15:28
rloodevananda: wrt the client change. what do you suggest? it'll be a similar problem with any new feature. Should that be a separate patch (or yikes a BP proposal)?15:28
devanandacomstud: definitely15:28
comstudthere's a big one15:28
comstudthat is in nova15:28
devanandarloo: I'm not sure. perhaps 404 is totally fine.15:28
rlooJoshNang: oh, I had another comment. I'll just ask you. Why do you use the swift_endpoint_url, instead of the one from the direct_url?15:28
devanandarloo: and certainly i'm not suggesting any more BPs for this15:28
devanandarloo: just wondering what the best clietn interaction is goign to be15:29
rloodevananda: yahoo. no more bps for it. The client can't know whether that feature is available or not. if the client is *sure* that the url it generated is correct, then I suppose it can replace the msg with something else. I could spend a bit of time looking at what other clients do.15:30
Shrewsdevananda: rloo: 404 seems reasonable to me15:36
rlooShrews: thx. Vote as you see fit. https://review.openstack.org/#/c/76338/ ;)15:38
*** rloo is now known as rloo_afk15:39
rloo_afkbbiab15:39
JoshNangrloo: the endpoint direct_url returns can be an auth url in some cases, which won't work for directly downloading from with a temp url. it's something i want to make better in time, but i don't think requiring a swift endpoint url is unreasonable. here's the code explaining it better: https://github.com/openstack/glance/blob/5148c9648fc959c1d807313176afe3fcf84b89cf/glance/store/swift.py#L15115:41
*** eghobo has joined #openstack-ironic15:41
*** eghobo has quit IRC15:41
*** eghobo has joined #openstack-ironic15:43
*** athomas has joined #openstack-ironic15:43
NobodyCambrb15:43
*** eghobo has quit IRC15:43
*** dkehn_ has joined #openstack-ironic15:45
*** eghobo has joined #openstack-ironic15:45
*** dkehnx has quit IRC15:49
devanandarloo_afk: after some mroe thought, +2'd15:50
*** Halacs has quit IRC15:50
NobodyCamlol got the recheck / reverify bug number all ready for 10903315:53
NobodyCam:(15:53
devanandaNobodyCam, Shrews: these are the reviews for BPs which we've targeted to J2 but have not landed yet -- https://etherpad.openstack.org/p/Du9hOAFg3d15:54
devanandaassuming the gate re-opens for us, it'd be great to get those landed today15:55
Shrewsdevananda: ack15:55
NobodyCamack :) will do our best to get them in15:55
devanandabut, like, it's also just a milestone, so meh. don't stress about it.15:56
NobodyCamlol /me still has to read the meeting notes from monday15:56
NobodyCam:(15:56
devanandaand thanks!15:56
*** hemna has joined #openstack-ironic15:58
dtantsurdevananda, https://review.openstack.org/#/c/86588/ actually could be approved already, just waiting for the gate to re-open16:02
NobodyCam109033 everifying now16:02
NobodyCamreverifying even16:02
*** Mikhail_D_ltp has joined #openstack-ironic16:07
devanandadtantsur: wait a sec. https://review.openstack.org/#/c/86588/27/ironic/conductor/utils.py is removing the old support BEFORE porting SSH driver to use the new interface16:08
devanandai think the patches are in the wrong order16:08
*** matty_dubs is now known as matty_dubs|lunch16:08
dtantsurdevananda, did SSH ever had this support?16:08
*** dkehn_ is now known as dkehnx16:08
dtantsurdevananda, judging by the SSH patch, no. So no need for old support there16:09
devanandadtantsur: ah, I see. since SSH did not have a ManagementInterface before, it wouldnt error either, as that's not a requried interface16:11
*** foexle has joined #openstack-ironic16:17
*** viktors is now known as viktors|afk16:20
*** rloo_afk is now known as rloo16:22
rloothx devananda ;)16:22
rlooJoshNang: thx. It seems to me that if there's a direct url and the user hasn't specified the swift_endpoint_url, then maybe using the endpoint from the direct url might work. And it makes it more consistent with the other url-related configs, but I don't feel strongly about it.16:24
NobodyCambrb16:24
JoshNangrloo: i might work, or it might cause a frustrating to debug 401 error when trying to download the image. i think its safer to require it for now. i know someone was evaluating how to get the swift endpoint from keystone, which would make this all much easier16:28
rlooJoshNang: fine with me then.16:29
Shrewsdevananda: some of the Mgmt Iface patches need to have comments addressed before landing16:33
Shrewsrloo's patches are good to go today though16:33
*** jcoufal has quit IRC16:34
devanandamrda-away: one more patch for the nova driver -- https://review.openstack.org/#/c/109022/16:34
devanandamrda-away: I've annotated it on the etherpad, too16:34
devanandaShrews: yea, it looks that way to me too. i just added some comments to https://etherpad.openstack.org/p/Du9hOAFg3d16:34
devanandaShrews: those might not quite be ready yet16:34
rlooShrews: there was that one bug of Lucas' too that was for J2. sec.16:35
rlooShrews: https://review.openstack.org/10095816:36
rlooShrews: I figured I'd wait for your comments first, before I looked again ;)16:36
Shrewsrloo: ah right. i'm satisfied by lucasagomes's comment. will re-review now. feel free to review it16:37
devanandaShrews: I also don't see any client patch for lucas' management api16:37
lucasagomesdevananda, yeah I'm waiting the api to be merged16:37
lucasagomesdevananda, gotta do tempest patches as well16:37
lucasagomesfor the api16:37
lucasagomeslemme take a look at it16:38
devanandalucasagomes: right. so without a client change proposed yet, i'm going to bump that BP to J316:39
lucasagomesdevananda, ack16:39
lucasagomesyeah makes sense16:39
lucasagomesI will work on the client asap16:39
Shrewslucasagomes: re 100958, shouldn't we be getting the _L* stuff from i18n.py now?16:40
lucasagomesShrews, oh, indeed we should16:40
devanandagotta run to the airport, bbl16:40
lucasagomesI just rebased16:40
lucasagomesurgh16:40
lucasagomesShrews, will put a patch up quickly for that16:41
Shrewslucasagomes: ok. +2 from me after that  :)16:41
Shrewsdevananda: have a good flight!16:41
lucasagomesdevananda, safe flight!16:41
lucasagomesShrews, :) ack16:41
*** jcoufal has joined #openstack-ironic16:43
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Fix nodes left in an incosistent state if no workers  https://review.openstack.org/10095816:45
lucasagomesShrews, ^ here we go :)16:45
Shrewslucasagomes: awesome16:46
*** rainya has joined #openstack-ironic16:46
*** rainya has quit IRC16:46
*** rainya has joined #openstack-ironic16:47
*** Alexei_9871 has quit IRC16:48
*** derekh_ has quit IRC16:49
*** jistr has joined #openstack-ironic16:50
lucasagomesShrews, rloo you won't join us for pizza on sunday?16:51
rloolucasagomes: nope. Would like to, but am going to be home ;)16:51
Shrewslucasagomes: i can't attend. :(   went to the tripleo meeting this week instead16:52
rloolucasagomes: will have a croissant with you in Paris instead.16:52
lucasagomesShrews, rloo oh :/16:52
lucasagomesrloo, deal :D16:52
lucasagomesgotta start practicing my french since now16:53
rloolucasagomes: some of us have to hold the fort down while you guys are partying ;)16:53
lucasagomeslol16:53
*** rwsu has quit IRC16:58
*** rwsu has joined #openstack-ironic16:59
*** jdob has quit IRC17:01
*** bvivek has joined #openstack-ironic17:02
*** jdob has joined #openstack-ironic17:03
*** matty_dubs|lunch is now known as matty_dubs17:05
lucasagomesaight, have a great night everyone17:05
lucasagomeswill call it a day, I still have to start packing my stuff and all17:05
*** Nisha has joined #openstack-ironic17:05
*** lucasagomes is now known as lucas-dinner17:05
NobodyCamnight lucas-dinner17:06
rloociao lucas-dinner.17:07
rlooadam_g: was wondering about 109022 and the reason for the patch.17:07
*** pelix has quit IRC17:07
rlooadam_g: I added a comment/my question to 109022.17:10
*** derekh_ has joined #openstack-ironic17:11
*** marzif has quit IRC17:12
*** wanyen has joined #openstack-ironic17:20
*** lsmola has joined #openstack-ironic17:21
Shrewsi wonder for the ipxe review if we should consider having an http_port option?17:23
JayFShrews: link?17:24
ShrewsJayF: https://review.openstack.org/9931817:24
JayFShrews: I agree with you generally, but adding that config option was missed in the spec :(17:26
JayFI'll comment on it with something saying I think we should anyway and see how it goes over :)17:26
Shrewsdoes that mean it can't be added now?17:26
NobodyCamJayF: +!17:26
NobodyCam+1 even17:26
NobodyCami would think its worth adding17:27
Shrewsi already left a comment17:27
Shrewsbut feel free to add your own too17:27
JayFShrews: jinx :)17:29
jrolldevananda: poke me when you have a moment so we can talk about talks :)17:29
jrollShrews JayF, fwiw, I don't think anyone will kill that idea just because it isn't in the spec17:29
jrollmy thought is that should be a url eg. http://hostname:1234/somepath17:31
JayFjroll: that doesn't match the usual way those vars are presented for other things though17:31
JayFjroll: all other stuff is usually host/port/path separately17:31
jrollyes it does17:31
JayFjroll: although I personally agree that URLs are much better in most cases17:31
jrollno, don't believe so17:31
jrollpretty sure it is usually just an endpoint17:32
jrolla la api_endpoint in configs17:32
JayFheh, and it's a mix in the settings17:32
JayFlooks like keystoneclient can take both17:32
jrollright17:33
JayFand most other things use a url17:33
JayFso I'd be very OK with that as well, but probably should've been mentioned in the spec :(17:33
jrollbut split options in keystone is deprecated :)17:33
jrollagree, but17:33
* JayF doesn't want to crater lucas-dinner's already awesome work with something that should've been caught earlier17:33
jrolldisagree with another spec for that17:33
jrolldo it or else i will :p17:33
JayFI don't want 'another spec for that'17:33
jrolland I hate reviewing on mobile17:34
JayFI'm suggesting that something good shouldn't be held up for something better in a lot of cases17:34
rlooFWIW, I don't think a spec is set in stone.17:34
jrollif we land this as is someone will want a spec for the next patch17:34
JayFjroll: and we should get good at telling $someone that they're wrong and being pedantic :P17:34
JayFrloo: can we submit merge reqs to edit specs?17:34
JayFrloo: I guess it's technically possible, pretty interesting when you think about design docs as code17:35
rlooJayF: I was wondering about that. I'd like to. Guess that is something we can ask Deva. I'd like the specs to be kept up-to-date and clearly, a spec can't be totally 100% accurate even though we'd like it to be.17:35
*** harlowja has joined #openstack-ironic17:35
rlooJayF: otherwise, I'd have to ding JoshNang on his swift-url patch cuz it is a bit diff from the spec.17:35
jrollright, but when does it end :/17:36
jrollw up to date specs17:36
rloojroll: so have you worked on a project where there were requirements/design docs, etc?17:36
rloojroll: where does it end there? seems like we're reasonable people (i'd like to think so). we should do what works for us so that we can do our best w/o a lot of overhead.17:37
jrollrloo: kind of. I ran :)17:37
JayFrloo: we all work in an environment where you're expected to make things work, write tests to prove it, then iterate over time. I've probably writen 4 design docs, tops, in my career, and they were mostly for things that couldn't be iterated upon (like setting up a DNS naming scheme) without a lot of pain17:37
rloocaveat being 'except for what the openstack community imposes on us that we might disagree with ;)17:37
jrollrloo: what I mean is... if ipxe code changes over time, do we keep updating the spec etx17:38
jrollidk if I agree with updating the spec17:38
rloojroll: ahhh. that's a good question. I think that depends on how-much the ipxe code changes.17:38
jrollespecially because we're now freezing new ironic-specs patches :p17:39
JayFI guess here is the core question:17:39
JayF - Should people who aren't Openstack Developers use specs for anything at all ever17:39
JayFi.e. they aren't supposed to be documentation for anyone but the people implementing it, right?17:39
openstackgerritNisha Agarwal proposed a change to openstack/ironic-specs: iLO Node discovery  https://review.openstack.org/10908817:39
rlooJayF: seems like I saw something in the list about that, and no, the specs are for developers if i recall correctly.17:39
NobodyCamlol love it when sales men call with info that is YEARS out of date17:39
JayFrloo: in that case I agree with Jim, that we shouldn't /need/ to update specs in 99.999% of cases17:40
jrollJayF: thing is, PMs etc use specs17:40
jrollalso release notes17:40
jrolletc17:41
jrollannoying but true17:41
JayFthe .001% of specs that would warrant a change would be the ones that the substance of the feature changed17:41
JayFi.e. if someone is using a spec to configure 'http_host" for iPXE, they're probably going to be in for a bad time17:41
rloowhat's a PM?17:41
*** jistr has quit IRC17:42
JayFbut overall, even if the option structure changes a little, it's still essentially the same17:42
JayFrloo: Product Manager || Project Manager17:42
rloowe don't have any in openstack, do we?17:42
JayFCompanies that sponsor Openstack development have lots and lots of 'em :)17:42
rlooJayF: well don't tell your PMs about the specs then ;)17:43
JayFrloo: I don't think any of our PMs use them at all17:43
JayFrloo: if anything; we err too much on the other side -- internal docs and conversations about features that we know will end up upstream17:43
* Shrews notes that asking even the simplest of questions can lead to much IRC scrollback17:44
rlooShrews - I think to summarize, the question probably for devananda, is when/if a spec should be updated after it has merged.17:46
rloooh, and is it OK to deviate from the spec, eg different/more configs.17:46
adam_grloo, re: 109022 we need to ensure nodes are cleaned up after all exceptions, not only the ones we're currently catching17:47
rlooadam_g: just for spawning or all cases?17:47
*** rainya has quit IRC17:49
adam_grloo, spawning, so that failed provisions properly disassociate instances from nodes and kick resources back to nova17:49
rlooadam_g: ok. and is it ok to reraise ironic exceptions?17:50
adam_grloo, failures elsewhere usually cause things to stay in some ERROR state waiting for admin action (ie, rebuild)17:50
devanandarloo: that's an evolving discussion17:51
devanandaideally, i think we shouldn't approve a spec until we're comfortable with, and have thought through, the implications, required options, etc17:51
devanandaupdating a spec after landing it means the design was wrong / incomplete. but also, we admit mistakes and learn from them, so maybe that's ok?17:52
devanandai don't have a cut-anbd-dry view on that yet17:52
lucas-dinnerShrews, JayF yeah port is useful... the way I was configuring the port was to put it as part of the http_server value17:53
rloodevananda: yes, I think it's OK and I'd prefer that it be updated than for it to be mis-leading or whatever.17:53
lucas-dinnerlike https://review.openstack.org/#/c/99677/9/lib/ironic (L265)17:53
lucas-dinnerShrews, JayF but it's not very intuitive... I will add a config option for port there17:53
JayFlucas-dinner: great! Thanks!17:53
JayFlucas-dinner: jroll was suggesting it change to just a fully qualified URL, which I'm personally OK with as well, but either is fine :)17:54
rloodevananda: otherwise, I worry that we'd spend even more time over the specs than we do now and I'm not sure we (well I) want to do that.17:54
* JayF just glad iPXE support is going in mainline17:54
adam_grloo, re-raising the non-nova exceptions should be fine, the compute manager will catch those and cause a reschedule17:54
lucas-dinnerJayF, :D right... jroll if u want please leave a comment on the patch and I will address it tomorrow asap17:54
rlooadam_g: as long as it is ok with nova to expect non-nova exceptions. eg in ironic, we don't want non-ironic exceptions to make it 'up' the chain.17:55
adam_grloo, https://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n134417:55
* lucas-dinner brb again17:55
rlooadam_g: so nova uses the big Exception hammer to make sure they get it all.17:56
rlooadam_g: thx. i'll take another look at that patch.17:57
adam_grloo, np :)17:57
adam_gShrews,17:57
adam_gRun: 663 in 488.563237 sec.17:57
adam_g - Passed: 60017:57
adam_g - Skipped: 6317:57
adam_g - Failed: 017:57
adam_gthats smoke-serial minus scenarios17:58
stevebakerdevananda: hey, https://review.openstack.org/#/c/92257/ is ready for another look18:07
*** Nisha has quit IRC18:07
devanandaadam_g: awesome. that all updated on the 'pad, I presume?18:07
adam_gdevananda, yup. required patches @ https://etherpad.openstack.org/p/IronicCI18:08
devanandasweet18:08
devanandai'll poke folks next week in portland, if they aren't already landed18:08
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Adding swift temp url support  https://review.openstack.org/8139118:09
devanandastevebaker: LGTM, but please don't merge it until it passes check-tempest-dsvm-virtual-ironic-nv18:10
devanandathat's non-voting so you need to atually look at it, not just the jenkins vote18:11
* devananda boards a plane18:11
Shrewsadam_g: that's waaay more tests than what my test run had18:11
stevebakerdevananda: ok. are there known other failures on that job?18:11
* Shrews scratches head18:11
devanandastevebaker: only the gate problem which nova created yesterday18:11
devanandastevebaker: once that merges the job SHOULd work again18:11
* devananda really, actually boards a plane18:12
stevebakerdevananda: ok.18:12
stevebakerdevananda: See you in Hawaii ;)18:12
Shrewsadam_g: my notes are at the bottom of https://etherpad.openstack.org/p/IronicTempestFeatures18:13
NobodyCambrb18:15
* rloo wonders why we can't have an OpenStack summit or midcycle meetup in Hawaii.18:17
NobodyCamrloo: ++18:21
* GheRivero will never take a >26 hours flight just to go to Hawaii just for work18:21
NobodyCamGheRivero: ask your "better half"18:22
NobodyCamlol my bet is they would want to go18:22
rlooGheRivero: yeah, don't do it "just for work"! Is it really that long a flight?18:23
GheRiverorloo: +2h for check in and another 2.30h ride to the airport... so it's actually worst18:26
NobodyCamGheRivero: :(18:26
rlooGheRivero: but you love where you live, right? :D Anyway, I seriously doubt we'll be going to Hawaii.18:27
*** amitpp has joined #openstack-ironic18:27
GheRivero:) I can always stay an extra month for holidays :)18:28
* NobodyCam would be happy with a extra week18:29
NobodyCam:)18:29
rlooGheRivero: sweet!18:32
*** rainya has joined #openstack-ironic18:37
*** bvivek has quit IRC18:38
NobodyCam109033 almost there. two tests18:39
NobodyCamleft18:39
GheRivero\o/18:41
*** amitpp has quit IRC18:43
NobodyCamupdate all test on 109033 : Success!18:55
jrollI want to propose a spec to add a "notes" field to the node table... but that's so cmdb18:58
jrollor like make maintenance a text field :)18:58
NobodyCamoh that is very cmdb like19:00
jrollI know19:01
jrollbut like...19:01
jrollso useful19:02
NobodyCambrb19:03
rloohow long do we wait after the merge, to do rechecks?19:07
* rloo tries a recheck bug 1347795 and crosses fingers19:09
*** lsmola has quit IRC19:20
greghaynesHas there been any thought on giving conductors a uuid in the schema? Curious if this has just not been needed or is intentionally not done due to conductor.hostname?19:26
greghaynesI need to add a filter to nodes based on conductor for some context....19:26
openstackgerritAdam Gandelman proposed a change to openstack/ironic: Generalize exception handling in Nova driver  https://review.openstack.org/10902219:27
lifelessgreghaynes: you do?19:28
lifelessgreghaynes: the hostname is the key to use19:28
greghayneslifeless: ok. devananda mentioned that for the hashring rebalance it might be better to rebalance nodes filtered by the conductor that is now missing which could be a value stored in the db19:29
greghaynesrather than walking the whole list of nodes19:29
lifelessyes, thats a query on the hostname19:30
lifelessyou want the current owning conductor to be a field on the node19:30
lifelessthen its select from nodes where owner=failed_conductor19:30
greghaynesYep, that should work fine19:30
*** scubacuda has joined #openstack-ironic19:55
*** romcheg1 has quit IRC20:01
*** ChuckC has quit IRC20:07
*** chuckC has joined #openstack-ironic20:13
*** chuckC has quit IRC20:14
*** marzif has joined #openstack-ironic20:19
rlooanyone out there, NobodyCam, Shrews, this one might have a chance of making it in today if you have time: https://review.openstack.org/#/c/109022/.20:26
rlooalthough I guess deva should still be the one that approves.20:26
Shrewsrloo: yeah, that's deva's call for driver related patches20:26
rloostill need eyeballs on it though.20:27
Shrewsrloo: i'll look it over20:31
rlooadam_g thanks you Shrews :-)20:31
Shrewsrloo: thx for handling the rechecks20:35
rlooyw Shrews. Still crossing my fingers...20:35
* Shrews trying to simultaneously review code and deal with getting his door replaced after an attempted break in20:36
rlooShrews: not good, the door is more important than the review.20:36
devanandai'm in the airport for another hour or two, apparently20:41
devanandajroll: what are yall doing for network isolation of tenants?20:42
openstackgerritA change was merged to openstack/python-ironicclient: Add driver-properties command  https://review.openstack.org/7633820:43
devanandawoot! our gate's workign!20:43
rloowhoohoo! I think I waited 15-30 min or so (it's all a blur) before rechecking the others. So there should be a few more merges soon/today, unless there are conflicts.20:44
devanandaawesome, thanks20:44
rlooShrews, devananda beat you to 109022. (Go take care of the door.)20:49
Shrewsdang it devananda. quit approving patches i'm reviewing!20:49
Shrews:-P20:49
devanandalol20:49
* Shrews +2's out of spite20:50
Shrews:)20:50
devanandaShrews: all yours. i'll go back to writing my slides for tomorrow20:50
Shrewsdevananda: in rtp still?20:51
Shrewserr, rdu20:51
devanandaya20:51
devanandarerouted. ATL is hall thunderstorms20:51
NobodyCamoh happy happy joy joy20:52
devanandaJayF: ping since jroll didn't reply yet20:52
Shrewsdevananda: ah. so, one very important thing i learned about traveling living in this area... NEVER route through ATL in the summer during evening hours20:52
devanandaShrews: good to know. 20:52
Shrewsyou're almost guaranteed to be delayed due to weather20:52
Shrewsi try to route through MSP whenever possible (for Delta, at least)20:54
JayFdevananda: I saw the question, and I 1) Don't understand 100% all the technical things about how we do it and 2) Don't know how much of it we are making public20:55
JayFdevananda: it boils down to $vendor_things, and I assure you we tested to ensure the network isolation (i.e., no arp poisoning or IP-stealing) worked properly20:55
devanandaJayF: cool. that confirms my thinking that you *are* doing it.20:56
JayFdevananda: yes, we absolutely are :)20:56
*** mrda-away is now known as mrda21:01
mrdaMorning Ironic!21:01
NobodyCammorening mrda21:03
mrdaNobodyCam: o/21:04
mrdadevananda: yay, 107882 approved!21:05
*** cdent has quit IRC21:07
*** derekh_ has quit IRC21:08
* devananda wanders off to get a new boarding pass21:13
NobodyCambrb21:28
openstackgerritA change was merged to openstack/ironic: Generalize exception handling in Nova driver  https://review.openstack.org/10902221:29
rloomrda: do you have time to rebase 107882?21:32
mrdaof course!21:32
mrda:)21:33
* NobodyCam thinks he's comming down with some form of travel sickness :(21:34
openstackgerritA change was merged to openstack/ironic: Backporting nova host manager changes into ironic  https://review.openstack.org/10887221:35
rlooNobodyCam: go home and stay home!21:35
* NobodyCam is home... lol and am here until sunday lol21:36
*** Mikhail_D_ltp has quit IRC21:36
rlooOh, didn't realize you were home already NobodyCam. Well, you have a few days to recuperate :D21:36
NobodyCamyep.. :)21:37
openstackgerritA change was merged to openstack/ironic: Implement API to get driver properties  https://review.openstack.org/10709621:40
*** jdob has quit IRC21:43
*** rwsu has quit IRC21:44
*** jcoufal has quit IRC21:44
openstackgerritMichael Davies proposed a change to openstack/ironic: Import fixes from the Nova driver reviews  https://review.openstack.org/10788221:51
*** matty_dubs is now known as matty_dubs|gone21:52
rlooI see a failure in check-tempest-dsvm-virtual-ironic, dib-run-parts, "rmdir: failed to remove '/tmp/image.JgwLksHL/mnt/tmp/in_target.d': Device or resource busy"21:58
rloohttp://logs.openstack.org/88/86588/27/check/check-tempest-dsvm-virtual-ironic/ac170fe/logs/devstacklog.txt.gz21:58
openstackgerritA change was merged to openstack/ironic: Catch oslo.db error instead of sqlalchemy error  https://review.openstack.org/10894321:59
rlooguess what I'm going to do...21:59
NobodyCamlol file a bug?22:00
NobodyCam:-p22:00
*** dguerri is now known as _dguerri22:00
rloosomething even easier NobodyCam, but I won't mention it here.22:00
NobodyCamlol22:01
NobodyCamshhh22:01
* NobodyCam wont tell22:01
rlooheh. I think everything else has merged, except for that one failure and the rebase.22:01
openstackgerritA change was merged to openstack/ironic: Fix nodes left in an incosistent state if no workers  https://review.openstack.org/10095822:02
rloo107882 needed to be rebased. Could someone +2/approve? devananda already approved it once.22:04
rloooh, maybe I can do that myself.22:04
* mrda is off to propose new patches to nova, now that things have merged on our side22:06
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Adding swift temp url support  https://review.openstack.org/8139122:08
*** chuckC has joined #openstack-ironic22:12
rlooJoshNang: thx for updating 81391. I have to take off now, most likely won't get around to looking again until next Mon. I hope it'll be approved before then ;)22:13
*** marzif has quit IRC22:16
JoshNangrloo: no worries! thanks for the great reviews!22:29
*** jgrimm has quit IRC22:39
*** chuckC has quit IRC22:47
*** chuckC has joined #openstack-ironic22:53
*** radsy has joined #openstack-ironic22:54
*** rloo has quit IRC22:56
*** chuckC has quit IRC23:09
openstackgerritA change was merged to openstack/ironic: Import fixes from the Nova driver reviews  https://review.openstack.org/10788223:14
openstackgerritA change was merged to openstack/ironic: IPMINative to use the new ManagementInterface  https://review.openstack.org/8658823:19
*** athomas has quit IRC23:20
*** lucas-dinner has quit IRC23:28
*** wanyen has quit IRC23:31
*** jcoufal has joined #openstack-ironic23:45
mrdaSo, pxe_bootfile_name config option in the nova ironic driver...23:50
mrdait's currently in our tree, and is referenced directly, or indirectly in the following files:23:50
mrdaironic/common/neutron.py ironic/common/pxe_utils.py ironic/drivers/modules/pxe.py ironic/tests/test_neutron.py ironic/tests/test_pxe_utils.py23:51
mrdaIf I remove these references, all tests pass - meaning everything is ok, right? :)23:51
mrdaAny objections before I put up this patch for review?23:51
jrollummmmmmmmmm23:52
jrolldid you try tempest?23:52
jrollthat has to fail horribly23:52
mrdaok, thanks jroll23:52
jrollmrda: just my guess, I know nothing :)23:52
jrollput it up and see what happens23:52
mrdaI have this comment from Deva on this in https://review.openstack.org/#/c/103167/7/nova/virt/ironic/driver.py "This has been refactored out, and isn't needed here any more"23:52
jrolland watch deva strike it down23:53
mrdaSo I'm not a pxe expert, but it appears it's not needed in the nova driver for ironic - just wondering if it's needed internally23:53
jrollhm, you might be right23:54
jrollI'm not a pxe expert either :P23:54
mrdaok, here comes the patch - wheee!23:54
* jroll braces himself23:55
mrdalol23:58
openstackgerritMichael Davies proposed a change to openstack/ironic: Remove config option pxe_bootfile_name & vestiges  https://review.openstack.org/10945523:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!